Context Navigation

← Previous Period
Next Period →

Timeline

May 27, 2006:

11:33 AM Changeset in webkit [14619] by andersca

2 edits in trunk/WebCore

2006-05-27 Anders Carlsson <acarlsson@apple.com>

bindings/js/JSHTMLElementWrapperFactory.cpp: Correct include file names.

May 26, 2006:

7:23 PM Changeset in webkit [14618] by justing

12 edits
4 adds in trunk

LayoutTests:

Reviewed by levi

Added, test for the crash by focusing an editable html element and then
inserting a tab

editing/selection/editable-html-element-expected.checksum: Added.
editing/selection/editable-html-element-expected.png: Added.
editing/selection/editable-html-element-expected.txt: Added.
editing/selection/editable-html-element.html: Added. Fixed:
editing/selection/focus_editable_html-expected.checksum:
editing/selection/focus_editable_html-expected.png:
editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by levi

<rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message

dom/Position.cpp: (WebCore::Position::inRenderedContent): Removed a candidate at [html, 0].
editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
editing/Selection.cpp: (WebCore::Selection::validate): If visible positions can't be created from the endpoints, then create a null selection. Not doing this was making editing code think there was a valid, editable selection even though there wasn't.
editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Early return.
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary. It looks like a non-editable/editable boundary since rootEditableElement stops at the body even if the html element is editable.

3:17 PM Changeset in webkit [14617] by adele

2 edits in trunk/WebCore

Reviewed by Justin.

Fixes a mistake in my last checkin. Uses maxDeepOffset to get the end position for
the textarea's inner div.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks):

2:13 PM Changeset in webkit [14616] by adele

8 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Added test for new textarea implementation. Tests
wrap attributes and form submission.

fast/forms/textarea-appearance-wrap-expected.txt: Added.
fast/forms/textarea-appearance-wrap.html: Added.

WebCore:

Reviewed by Hyatt.

Added support for wrap=hard for new textarea implementation.

Tests: fast/forms/textarea-appearance-wrap.html

dom/Range.h: Added version of toString that will convert BRs to newlines.
dom/Range.cpp: (WebCore::Range::toString):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): When in plain-text mode, and a white-space mode that doesn't collapse whitespace, create a fragment with one text node.
editing/visible_units.cpp: (WebCore::previousLinePosition): Subtract scroll offset so the absolute position for the containing block is correct. (WebCore::nextLinePosition): ditto.
rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): If the position is equal to the left edge of the box, make the affinity downstream so the position doesn't jump back to the previous line. (WebCore::RenderText::atLineWrap): The logic was reversed here in a recent change. If the box is not at a line break, then its at a line wrap. (WebCore::RenderText::caretRect): Only go to the next text box if its at a line wrap and the affinity is also downstream. If its upstream, then the correct box is on the current line. (WebCore::RenderText::inlineBox): ditto.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): multi line controls don't need to check valueMatchesRenderer before updating the renderer. For textareas, the renderer should always try to update. This matches our old textarea behavior. (WebCore::RenderTextField::text): Pass true to textContent so it converts BRs to newlines. (WebCore::RenderTextField::textWithHardLineBreaks): Iterate through the RootLineBoxes to find the soft wraps and replace them with newlines.

1:30 PM Changeset in webkit [14615] by andersca

5 edits
2 adds in trunk

WebCore:

2006-05-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::handleLocalEvents): Invoke capturing event listeners for the AT_TARGET phase. This violates the DOM spec but it's what Mozilla does.

LayoutTests:

2006-05-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET

dom/html/level2/events/dispatchEvent09-expected.txt:
dom/xhtml/level2/events/dispatchEvent09-expected.txt: These fail now.

fast/dom/capturing-event-listeners-expected.txt: Added.
fast/dom/capturing-event-listeners.html: Added.

12:34 PM Changeset in webkit [14614] by harrison

3 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel

WebView/WebHTMLView.m: (-[WebHTMLView _increaseSelectionListLevel]):
Now returns DOMNode*

(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):

Added. These also return DOMNode*

WebView/WebHTMLViewPrivate.h:
Updated as above

12:31 PM Changeset in webkit [14613] by harrison

7 edits
2 moves in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
Renamed ModifySelectionListLevelCommand .cpp and .h to ModifySelectionListLevel .cpp and .h

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
Call functions in IncreaseSelectionListLevelCommand or DecreaseSelectionListLevelCommand instead of ModifySelectionListLevelCommand.

(-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
(-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):

Added.

editing/ModifySelectionListLevel.cpp: Added.
Renamed from ModifySelectionListLevelCommand.cpp
Made ModifySelectionListLevelCommand class into a useful base class for new classes IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand.

(WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
(WebCore::getStartEndListChildren):
(WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore):
(WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange):

ModifySelectionListLevelCommand is base class for IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand

(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
(WebCore::IncreaseSelectionListLevelCommand::listElement):
(WebCore::canIncreaseListLevel):
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
(WebCore::increaseSelectionListLevelWithType):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

Now a subclass of ModifySelectionListLevelCommand
Added Ordered and Unordered increaser functions
Increaser functions return the list element that the items were moved into

(WebCore::DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand):
(WebCore::canDecreaseListLevel):
(WebCore::DecreaseSelectionListLevelCommand::doApply):
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
(WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel):

No functional changes other than to become a subclass of ModifySelectionListLevelCommand

editing/ModifySelectionListLevel.h: Added. (WebCore::):
- Renamed from ModifySelectionListLevelCommand.cpp

editing/ModifySelectionListLevelCommand.cpp: Removed.
Renamed to ModifySelectionListLevel.cpp

editing/ModifySelectionListLevelCommand.h: Removed.
Renamed to ModifySelectionListLevel.h

editing/htmlediting.cpp: (WebCore::createOrderedListElement): (WebCore::createUnorderedListElement):
editing/htmlediting.h:

12:26 PM Changeset in webkit [14612] by brmorris

1 edit in S60/trunk/build.bat

S60Webkit:

2006-05-25 Bradley <bradley.morrison@nokia.com>

Reviewed by dacarson.

build.bat now deletes outdated headers.
(fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9126)

11:58 AM Changeset in webkit [14611] by tomernic

2 edits in trunk/WebKit

Reviewed by Anders.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8347>
REGRESSION: Flash movie audible but not visible until window is resized

Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView dataSourceUpdated:]): Layout if needed here. Maciej recently removed the "LayoutAcceptable" frame state, which used to cause plugin document views to lay out immediately upon receiving data. This call to -layout has the same effect.

11:11 AM Changeset in webkit [14610] by sfalken