⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 11, 2006:

6:44 PM Changeset in webkit [17001] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-10-11 brmorris <thisisbradley@gmail.com>

Reviewed by zalan
DESC: send reindeer UA String
http://bugs.webkit.org/show_bug.cgi?id=9189

  • BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK
5:54 PM Changeset in webkit [17000] by darin
  • 11 edits in trunk/WebKit

Reviewed by Adele.

  • preparations for making more code C++
  • WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.
  • Misc/WebKitLogging.h:
  • Misc/WebKitSystemBits.h:
  • Misc/WebLocalizableStrings.h:
  • WebCoreSupport/WebSystemInterface.h: Added extern "C".
  • Misc/WebNSViewExtras.h:
  • WebView/WebDataSource.m: (addTypesFromClass):
  • WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".
  • WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
  • Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
5:40 PM Changeset in webkit [16999] by darin
  • 14 edits in trunk/WebCore

Reviewed by John.

  • some changes to prepare for converting more code to C++
  • bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.
  • bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.
  • loader/mac/LoaderNSURLExtras.m:
  • loader/mac/WebDataProtocol.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFormDataStream.m:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebPolicyDecider.mm:
  • loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.
4:18 PM Changeset in webkit [16998] by darin
  • 2 edits in trunk/WebKitLibraries

Reviewed by John Sullivan.

  • WebKitSystemInterface.h: Updated to a C++-compatible version.
4:15 PM Changeset in webkit [16997] by sullivan
  • 4 edits in trunk/WebCore

Darin wrote this code; we tested it; I give it the thumbs up.


  • fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

The hash table to look up an element class given a QualifiedName was
not working at all.

  • dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.
  • bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto
2:09 PM Changeset in webkit [16996] by aroben
  • 3 edits in trunk/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create and Icon::newIconForFile.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):
1:39 PM Changeset in webkit [16995] by kmccullo
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.

These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

  • fast/js/date-DST-time-cusps-expected.txt: Added.
  • fast/js/date-DST-time-cusps.html: Added.
  • fast/js/resources/date-DST-time-cusps.js: Added.
11:45 AM Changeset in webkit [16994] by oliver
  • 3 edits in trunk/LayoutTests

2006-10-11 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Fix svg text related layout tests

  • svg/custom/getsvgdocument-expected.txt:
  • svg/hixie/viewbox/003-expected.txt:
11:27 AM Changeset in webkit [16993] by oliver
  • 3 edits
    4 adds in trunk

2006-10-11 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

Reviewed by Geoff.

Test case for http://bugs.webkit.org/show_bug.cgi?id=11251

  • fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • fast/canvas/zero-size-fill-rect-expected.png: Added.
  • fast/canvas/zero-size-fill-rect-expected.txt: Added.
  • fast/canvas/zero-size-fill-rect.html: Added.
11:26 AM Changeset in webkit [16992] by brmorris
  • 1 edit
    7 adds in S60/trunk/S60Internals

Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
http://bugs.webkit.org/show_bug.cgi?id=9435

  • target/GCCE/SDKGCCEPatch.zip: Added.
  • target/RVCT/S60LibsRVCT.zip: Added.
  • target/RVCT/S60RVCTPatch.zip: Added.
  • target/RVCT/rvct2_2.h: Added. (std::):
11:19 AM Changeset in webkit [16991] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"

Take better care of empty cursor lists.

Test: fast/css/invalid-cursor-property-crash.html

10:56 AM Changeset in webkit [16990] by aroben
  • 2 edits in trunk/WebCore

Fixing Windows for real this time.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:30 AM Changeset in webkit [16989] by aroben
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:14 AM Changeset in webkit [22353] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Clean up logic in Icon::newIconForFile.

  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.
10:08 AM Changeset in webkit [22352] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fixes <rdar://problem/4777719>
Icons don't paint with CG

  • platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.
9:54 AM Changeset in webkit [22351] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create, Icon::create.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.
8:04 AM Changeset in webkit [16988] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test for http://bugs.webkit.org/show_bug.cgi?id=4377

  • fast/layers/layer-visibility-expected.checksum: Added.
  • fast/layers/layer-visibility-expected.png: Added.
  • fast/layers/layer-visibility-expected.txt: Added.
  • fast/layers/layer-visibility.html: Added.

WebCore:

Reviewed by Hyatt.


http://bugs.webkit.org/show_bug.cgi?id=4377


Respect css visibility semantics for layers too

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
12:15 AM Changeset in webkit [16987] by mjs
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Oliver.

  • added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):


  • use it in WidgetMac so it gets tested in at least one place


  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):

Oct 10, 2006:

11:35 PM Changeset in webkit [16986] by beidson
  • 8 edits in trunk

WebCore:

Reviewed by Maciej.

Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]):

WebKit:

Reviewed by Maciej.

Moved WebFrameLoader into WebCoreFrameBridge

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge close]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
9:39 PM Changeset in webkit [16985] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 11246: Minor Drosera code cleanup
http://bugs.webkit.org/show_bug.cgi?id=11246

  • Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.
9:35 PM Changeset in webkit [16984] by thatcher
  • 7 edits
    5 adds in trunk/WebKitTools

Reviewed by Tim H.

Bug 9778: http://bugs.webkit.org/show_bug.cgi?id=9778

  • ChangeLog:
  • Drosera/Drosera.xcodeproj/project.pbxproj: Added files
  • Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
  • Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
  • Drosera/Images/SourceArrowOpen.png: Added.
  • Drosera/Images/fileIcon.jpg: Added.
  • Drosera/Images/siteCollapsed.tif: Added.
  • Drosera/Images/siteExpanded.tif: Added.
  • Drosera/Images/siteIcon.tif: Added.
  • Drosera/debugger.css: Added File Browser styles
  • Drosera/debugger.html: Added File Browser UI
  • Drosera/debugger.js: Added File Browser functionality
9:35 PM Changeset in webkit [22350] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixes <rdar://problem/4731316>
Crash when <input type="file"> element removed while file chooser is open

  • platform/win/FileChooserWin.cpp: Make FileChooser ref-counted. (WebCore::FileChooser::create): (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around the call to GetOpenFileName so we don't get deleted while the file chooser window is open.
9:33 PM Changeset in webkit [16983] by aroben
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make FileChooser ref-counted.

  • platform/FileChooser.h:
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
  • rendering/RenderFileUploadControl.h:
8:46 PM Changeset in webkit [16982] by weinig
  • 22 edits
    1 delete in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
Even More auto-generated Objective-C DOM bindings changes

  • Auto-generate DOMSVGPathElement.
  • Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.
  • Add SVG classes to DOMNode and DOMEvent internal interfaces.
  • Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.
  • Assorted cleanups.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]):
  • bindings/objc/DOMSVGPathSegInternal.h: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSRule.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/Event.cpp: (WebCore::Event::isSVGZoomEvent):
  • dom/Event.h:
  • dom/Event.idl:
  • dom/Node.idl:
  • ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/svg/SVGAnimatedAngle.idl:
  • ksvg2/svg/SVGCircleElement.idl:
  • ksvg2/svg/SVGClipPathElement.idl:
  • ksvg2/svg/SVGPathElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
8:41 PM Changeset in webkit [22349] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4772428>
<select> popup menus positioned incorrectly within frames

  • rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::setPositionAndSize): Use contentsToWindow() instead of scrollOffset() to correct menu location.
7:29 PM Changeset in webkit [22348] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-10 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


<rdar://4775676>
Crash in CoreFoundation parsing a "corrupt" plist


Prevent crash when we encounter a corrupt history plist by using
structured exception handling to catch the crash and return
an empty history list.

  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL):
7:22 PM Changeset in webkit [16981] by oliver
  • 2 edits in trunk/WebCore

2006-10-10 Oliver Hunt <oliver@apple.com>

rubber stamped by Anders.

More buildbot bustage

  • kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline):
7:12 PM Changeset in webkit [16980] by oliver
  • 4 edits in trunk/WebCore

2006-10-10 Oliver Hunt <oliver@apple.com>

Reviewed by Anders

Unbreak build bots

  • dom/Text.cpp:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline):
6:28 PM Changeset in webkit [16979] by oliver
  • 9 edits
    10 adds in trunk/WebCore

2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>

Reviewed by hyatt.

Fixes bugs #6423, #6559, #10380 and #10839

  • WebCore.xcodeproj/project.pbxproj:
  • css/svg.css:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox):
  • kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer):
  • kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect):
  • kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer):
  • kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects):
  • kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox):
  • kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
  • kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
  • kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
  • kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer):
  • ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer):
  • rendering/InlineFlowBox.h:
6:26 PM Changeset in webkit [16978] by oliver
  • 271 edits in trunk/LayoutTests

2006-10-10 Oliver Hunt <ohunt@apple.com>

Rubber stamped by Anders.

Updated to deal with new svg text renderers, and
updated result.

custom/text-clip testcase was incorrect, and has been fixed

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/custom/baseval-animval-equality-expected.checksum:
  • svg/custom/baseval-animval-equality-expected.png:
  • svg/custom/coords-relative-units-transforms-expected.checksum:
  • svg/custom/coords-relative-units-transforms-expected.png:
  • svg/custom/coords-relative-units-transforms-expected.txt:
  • svg/custom/createelement-expected.txt:
  • svg/custom/feComponentTransfer-Discrete-expected.txt:
  • svg/custom/feComponentTransfer-Gamma-expected.txt:
  • svg/custom/feComponentTransfer-Linear-expected.txt:
  • svg/custom/feComponentTransfer-Table-expected.txt:
  • svg/custom/foreign-object-skew-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/image-with-transform-clip-filter-expected.txt:
  • svg/custom/invalid-css-expected.txt:
  • svg/custom/invalid-fill-expected.txt:
  • svg/custom/invalid-viewbox1-expected.txt:
  • svg/custom/invalid-viewbox2-expected.txt:
  • svg/custom/junk-data-expected.txt:
  • svg/custom/marker-overflow-clip-expected.txt:
  • svg/custom/missing-xlink-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/svg-overflow-types-expected.txt:

text-clip was an incorrect test, rather than an incorrect result

  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-clip.svg:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-gradient-no-content-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/tref-update-expected.txt:
3:04 PM Changeset in webkit [22347] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4763246>
Using arrow keys in <select> popup fires onChange event

Also updates text shown in <select> element on page when using arrow
keys to change selection within the popup menu, and makes onChange fire
in the same cases as Firefox/IE.

  • rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::down): Update text of the <select> control. Change call to valueChanged() so that onChange doesn't fire. (WebCore::RenderPopupMenuWin::up): Ditto. (WebCore::PopupWndProc): Don't fire onChange anytime selection changes. Fire onChange when pressing Enter
2:57 PM Changeset in webkit [16977] by aroben
  • 5 edits in trunk/WebCore

Reviewed by Adele.

Improve popup menu behavior.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection.
  • html/HTMLSelectElement.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here.
  • rendering/RenderMenuList.h:
2:28 PM Changeset in webkit [16976] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-10 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: On ActivateEvent, clear the "don't submit form twice" data member.
http://bugs.webkit.org/show_bug.cgi?id=11242

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
2:18 PM Changeset in webkit [16975] by adele
  • 15 edits in trunk

WebCore:

Reviewed by Beth.

  • Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

Moved autoscroll code to the Frame class

  • bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
  • bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):
  • bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore.
  • page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto.
  • page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac.
  • page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.

WebKit:

Reviewed by Beth.

Removed handleAutoscrollForMouseDragged. Except for autoscroll caused by drag and drop, all other
autoscrolling should be done in WebCore instead of in AppKit.

  • WebCoreSupport/WebFrameBridge.m:
  • WebView/WebHTMLView.m:
  • WebView/WebHTMLViewPrivate.h:
2:02 PM Changeset in webkit [16974] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-10 bujtas <zbujtas@gmail.com>

Reviewed by NOBODY.
DESC: changing capital includes to non-capital
http://bugs.webkit.org/show_bug.cgi?id=11247

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLNamespace::m_ref): (khtml::): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElement): (khtml::XMLTokenizer::endElement): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::exitText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::setTransformSource): (khtml::attributesStartElementHandler): (khtml::XMLAttributes::operator=): (khtml::XMLAttributes::split):
2:00 PM Changeset in webkit [16973] by darin
  • 2 edits
    9 moves in trunk/WebCore

Rubber stamped by Maciej.

  • convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/WebDataProtocol.m: Removed.
  • loader/mac/WebDocumentLoader.m: Removed.
  • loader/mac/WebFormState.m: Removed.
  • loader/mac/WebFrameLoader.m: Removed.
  • loader/mac/WebLoader.m: Removed.
  • loader/mac/WebMainResourceLoader.m: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
  • loader/mac/WebPolicyDecider.m: Removed.
  • loader/mac/WebSubresourceLoader.m: Removed.
  • loader/mac/WebDataProtocol.mm: Added.
  • loader/mac/WebDocumentLoader.mm: Added.
  • loader/mac/WebFormState.mm: Added.
  • loader/mac/WebFrameLoader.mm: Added.
  • loader/mac/WebLoader.mm: Added.
  • loader/mac/WebMainResourceLoader.mm: Added.
  • loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
  • loader/mac/WebPolicyDecider.mm: Added.
  • loader/mac/WebSubresourceLoader.mm: Added.
2:00 PM Changeset in webkit [16972] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/do-file-rename: Added.
1:10 PM Changeset in webkit [16971] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.


  • loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain.
12:17 PM Changeset in webkit [22346] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth.

  • fix problem where you can't type in subframes
  • WebView.cpp: (WebViewWndProc): Use WebView's focusedTargetFrame() function instead of sending everything to the main frame.
10:01 AM Changeset in webkit [16970] by darin
  • 2 edits in trunk/WebKit
  • corrected an archive regression caused by loader refactoring (pointed out by Graham Dennis)
  • WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]): Fix selector name.
9:19 AM Changeset in webkit [16969] by brmorris
  • 33 edits
    18 adds in S60/trunk

2006-10-04 sareen <shyam.sareen@nokia.com>

Reviewed by Zalan, yongjun.
DESC: Change the dll names BROWSER_SDK and add stub for HistoryProvider
http://bugzilla.opendarwin.org/show_bug.cgi?id=11148
http://bugzilla.opendarwin.org/show_bug.cgi?id=11149
http://bugzilla.opendarwin.org/show_bug.cgi?id=11150

4:03 AM Changeset in webkit [16968] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • fixed release build
  • WebCore.xcodeproj/project.pbxproj:
3:48 AM Changeset in webkit [16967] by mjs
  • 20 edits
    24 moves in trunk

WebCore:

Rubber stamped by Eric.

  • moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/LoaderNSURLExtras.m: Added.
  • loader/mac/WebDataProtocol.m: Added.
  • loader/mac/WebDocumentLoader.m: Added.
  • loader/mac/WebFormDataStream.m: Added.
  • loader/mac/WebFrameLoader.m: Added.
  • loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
  • loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]):
  • loader/mac/WebPolicyDecider.m: Added.
  • loader/mac/WebSubresourceLoader.h: Added.
  • loader/mac/WebSubresourceLoader.m: Added.

WebKit:

Rubber stamped by Eric.


  • moved a whole bunch of stuff over to WebCore - updated includes appropriately
  • Loader/LoaderNSURLExtras.h: Removed.
  • Loader/LoaderNSURLExtras.m: Removed.
  • Loader/WebDataProtocol.h: Removed.
  • Loader/WebDataProtocol.m: Removed.
  • Loader/WebDocumentLoader.h: Removed.
  • Loader/WebDocumentLoader.m: Removed.
  • Loader/WebFormDataStream.h: Removed.
  • Loader/WebFormDataStream.m: Removed.
  • Loader/WebFormState.h: Removed.
  • Loader/WebFormState.m: Removed.
  • Loader/WebFrameLoader.h: Removed.
  • Loader/WebFrameLoader.m: Removed.
  • Loader/WebFrameLoaderClient.h: Removed.
  • Loader/WebLoader.h: Removed.
  • Loader/WebLoader.m: Removed.
  • Loader/WebMainResourceLoader.h: Removed.
  • Loader/WebMainResourceLoader.m: Removed.
  • Loader/WebNetscapePlugInStreamLoader.h: Removed.
  • Loader/WebNetscapePlugInStreamLoader.m: Removed.
  • Loader/WebPlugInStreamLoaderDelegate.h: Removed.
  • Loader/WebPolicyDecider.h: Removed.
  • Loader/WebPolicyDecider.m: Removed.
  • Loader/WebSubresourceLoader.h: Removed.
  • Loader/WebSubresourceLoader.m: Removed.
  • Misc/WebNSURLExtras.m:
  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m:
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebFrame.m:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m:
  • WebView/WebPolicyDeciderMac.h:
  • WebView/WebPolicyDelegate.m:
  • WebView/WebView.m:
3:38 AM Changeset in webkit [16966] by bdash
  • 2 edits in trunk/WebKit

2006-10-10 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

Fix crash on launch in nightly builds after r16965.

Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView. If this happens,
InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
pointer.

  • Misc/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
2:49 AM Changeset in webkit [16965] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Oliver (sort of?)

  • WebCore part of moving down NSURL extras
  • WebCore.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
2:44 AM Changeset in webkit [16964] by mjs
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Oliver.


  • split out some NSURL extras to be moved to WebCore
  • Loader/LoaderNSURLExtras.h: Added.
  • Loader/LoaderNSURLExtras.m: Added. (urlByRemovingComponent): (urlByRemovingFragment): (urlOriginalDataAsString): (urlOriginalData): (urlWithData): (WebCFAutorelease): (urlWithDataRelativeToURL): (urlByRemovingResourceSpecifier): (urlIsFileURL): (stringIsFileURL): (urlIsEmpty): (canonicalURL):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (setHTTPReferrer): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader safeLoadURL:]):
  • Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
1:42 AM Changeset in webkit [16963] by rwlbuis
  • 12 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg animation classes.

1:06 AM Changeset in webkit [16962] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

  • added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]):

Oct 9, 2006:

11:51 PM Changeset in webkit [16961] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Anders.


  • sever final WebFrame dependencies
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader checkLoadComplete]):
11:12 PM Changeset in webkit [16960] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Brady.


  • convert more WebFrameLoader stuff to be independent of WebFrame
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader client]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebDataSource.m: (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
  • WebView/WebFrame.m: (-[WebFrame _dispatchCreateWebViewWithRequest:]):
10:14 PM Changeset in webkit [16959] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Anders and Oliver.


  • move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadRequest:]): (-[WebFrameLoader loadRequest:inFrameNamed:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _hasFrameView]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _didFinishLoad]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
9:04 PM Changeset in webkit [22345] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve

<rdar://4721579> - WebPreferences for IconDatabase hooked up
This completes the above task by implementing the icon database location preference


  • WebIconDatabase.cpp: (WebIconDatabase::init): Get the location from the prefs, fallback to the default via shell call
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::iconDatabaseLocation): (WebPreferences::setIconDatabaseLocation):
8:16 PM Changeset in webkit [16958] by mjs
  • 1 edit
    2 adds in trunk/WebKit

Not reviewed, build fix.


  • added forgotten files
  • Loader/WebPolicyDecider.h: Added.
  • Loader/WebPolicyDecider.m: Added. (-[WebPolicyDecider invalidate]):
7:41 PM Changeset in webkit [16957] by mjs
  • 6 edits
    2 adds in trunk/WebKit

Reviewed by Brady.


  • add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
  • Loader/WebFrameLoaderClient.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.m: (-[WebFrame _createPolicyDeciderWithTarget:action:]): (decisionListener): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
  • WebView/WebPolicyDeciderMac.h: Added.
  • WebView/WebPolicyDeciderMac.m: Added. (-[WebPolicyDeciderMac initWithTarget:action:]): (-[WebPolicyDeciderMac dealloc]): (-[WebPolicyDeciderMac decisionListener]): (-[WebPolicyDeciderMac invalidate]):
7:10 PM Changeset in webkit [16956] by beidson
  • 5 edits
    1 add in trunk/WebKit

Reviewed by John

http://bugs.webkit.org/show_bug.cgi?id=11195
Added the WebIconDatabaseDelegate. This allows the ability to allow customization of
IconDatabase behavior in the future, starting now with the ability to override the
default icon fairly flexibly

  • Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
  • Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase delegate]):
  • Misc/WebIconDatabaseDelegate.h: Added.
  • Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
  • WebKit.xcodeproj/project.pbxproj:
6:52 PM Changeset in webkit [16955] by aroben
  • 2 edits in trunk/WebCore

Backing out accidental commit.

  • page/Frame.cpp: (WebCore::Frame::finishedParsing):
6:49 PM Changeset in webkit [16954] by aroben
  • 11 edits in trunk/WebCore

Reviewed by Darin.

Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
this could cause recursive calls to the destructor. RefPtr now also
inherits from Noncopyable.

  • dom/NodeFilter.h:
  • dom/Traversal.h:
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::finishedParsing):
  • page/Frame.h:
  • page/Plugin.h:
  • platform/FontFallbackList.h:
  • platform/Icon.h:
  • platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount):
  • platform/StringImpl.h:
6:30 PM Changeset in webkit [16953] by darin
  • 7 edits in trunk/WebKit

Reviewed by Maciej.

  • eliminated uses of WebResource and WebView from WebFrameLoader
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): (-[WebFrameLoader _canShowMIMEType:]): (-[WebFrameLoader _representationExistsForURLScheme:]): (-[WebFrameLoader _generatedMIMETypeForURLScheme:]): (-[WebFrameLoader loadDocumentLoader:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
  • Loader/WebFrameLoaderClient.h:
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader loadWithRequestNow:]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame _canUseResourceForRequest:]): (-[WebFrame _canUseResourceWithResponse:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _setDefersCallbacks:]): (-[WebFrame _canHandleRequest:]): (-[WebFrame _canShowMIMEType:]): (-[WebFrame _representationExistsForURLScheme:]): (-[WebFrame _generatedMIMETypeForURLScheme:]): (-[WebFrame _elementForEvent:]):
6:09 PM Changeset in webkit [16952] by oliver
  • 10 edits in trunk/WebCore

2006-10-09 Oliver Hunt <ohunt@apple.com>

Reviewed by Anders.

Correcting ifdef's

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop):
  • html/CanvasGradient.h:
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern):
  • html/CanvasPattern.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext):
  • html/HTMLCanvasElement.h:
6:04 PM Changeset in webkit [16951] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.


  • do all the stuff that setting the referrer should
  • Loader/WebFrameLoader.m: (setHTTPReferrer): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebKit.xcodeproj/project.pbxproj:
5:53 PM Changeset in webkit [16950] by mjs
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.


  • test case that ensures Referer[sic] header is sent
  • http/tests/misc/referrer-expected.txt: Added.
  • http/tests/misc/referrer.html: Added.
  • http/tests/misc/resources/referrer-result.php: Added.
5:38 PM Changeset in webkit [22344] by andersca
  • 8 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Fix <rdar://problem/4756255>
PDF/Acrobat Reader plugin don't work


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): Implement these, getting the instance from the plugin view.


  • platform/win/TemporaryLinkStubs.cpp: Remove functions that are now implemented.


  • plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): Implement this, returning whether we a plugin exists for a given mime type.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::parseVersionString): (WebCore::compareVersions): New functions for handling versions.


(WebCore::addMozillaPluginPaths):
(WebCore::addWindowsMediaPlayerPluginPath):
(WebCore::addQuickTimePluginPath):
(WebCore::addJavaPluginPath):
(WebCore::addAdobeAcrobatPluginPath):
(WebCore::PluginDatabaseWin::defaultPluginPaths):
Factor out checks into separate functions, add checks for Java and Adobe Acrobat.

(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
Handle null MIME types.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Add some missing functions. Unload the library if the load failed.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): Uncomment code for getting the element object.


(WebCore::PluginViewWin::bindingInstance):

  • plugins/win/PluginViewWin.h: New function which fetches the plugin NPObject and wraps it in an instance.
5:05 PM Changeset in webkit [16949] by aroben
  • 2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merge r16948 to tag.

4:57 PM Changeset in webkit [16948] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix a possible recursive destructor call.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed.
4:49 PM Changeset in webkit [16947] by weinig
  • 42 edits
    2 adds in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
Assorted Objective-C bindings changes

  • Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
  • Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement.
  • Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker)
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
  • bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
  • bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString):
  • bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
  • bindings/objc/DOMSVG.h:
  • bindings/objc/DOMSVGPathSegInternal.h: Added.
  • bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
  • bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/NodeIterator.idl:
  • dom/TreeWalker.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLObjectElement.idl:
  • ksvg2/svg/SVGDocument.idl:
  • ksvg2/svg/SVGElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
  • ksvg2/svg/SVGPathSegArcAbs.idl:
  • ksvg2/svg/SVGPathSegArcRel.idl:
  • ksvg2/svg/SVGPathSegClosePath.idl:
  • ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
  • ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
  • ksvg2/svg/SVGPathSegLinetoAbs.idl:
  • ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
  • ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
  • ksvg2/svg/SVGPathSegLinetoRel.idl:
  • ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
  • ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
  • ksvg2/svg/SVGPathSegMovetoAbs.idl:
  • ksvg2/svg/SVGPathSegMovetoRel.idl:
4:28 PM Changeset in webkit [16946] by bdash
  • 2 edits in trunk/WebCore

2006-10-09 Don Gibson <dgibson77@gmail.com>

Unreviewed build fix.

Fix windows build bustage.

  • platform/win/TemporaryLinkStubs.cpp:
4:08 PM Changeset in webkit [16945] by bdash
  • 15 edits in trunk

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler flags (show warning, no rtti and exceptions).

  • jscore.bkl:

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler options.

  • Bakefiles.bkgen:
  • presets.bkl:

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Fix memory leaks discovered via valgrind. Gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl:
  • make-generated-sources.sh:
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::draw):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
a page. This allows automatic testing via e.g. valgrind.

  • GdkLauncher/gdklauncher.bkl:
  • GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (LauncherFrameGdk::setExitAfterLoading): (LauncherFrameGdk::handledOnloadEvents): (handle_event): (main):
3:36 PM Changeset in webkit [16944] by bdash
  • 2 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Beth.

Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.

  • platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage):
3:34 PM Changeset in webkit [16943] by bdash
  • 2 edits in trunk/LayoutTests

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Use log() instead of alert() just like in all other tests.

  • editing/selection/move-begin-end.html:
3:30 PM Changeset in webkit [16942] by bdash
  • 4 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Unreviewed build fix.

Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.

  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget):
  • platform/qt/FrameQt.h:
  • platform/qt/TemporaryLinkStubs.cpp:
3:24 PM Changeset in webkit [16941] by beidson
  • 6 edits in trunk

WebCore:

Reviewed by Maciej

Tiny changes to help reorganize WebFrameLoader code in WebKit

  • bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side

WebKit:

Reviewed by Maciej

Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader

  • Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
  • WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge createInstance]):
2:44 PM Changeset in webkit [16940] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.


(Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)


  • avoid a needless use of WebFrame
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2:36 PM Changeset in webkit [16939] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-10-09 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Fix issues with touch support

  • Activate an element only if it received both down and up pointer events
  • Fix coordinates calculation in frames while zooming
  • Update cursor in each touch event, to give user the correct feedback

http://bugs.webkit.org/show_bug.cgi?id=11229

  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL):
1:27 PM Changeset in webkit [16938] by beidson
  • 2 edits in trunk/WebKit

A *real* fake fix for the layouttest problem until the real fix

  • Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
1:15 PM Changeset in webkit [16937] by beidson
  • 2 edits in trunk/WebKit

Quick layouttest fix until I make the real fix

  • Loader/WebFrameLoader.m:
1:06 PM Changeset in webkit [16936] by mjs
  • 7 edits in trunk/WebKit

Reviewed by Darin.


  • wean WebFrameLoader from WebDataSource private stuff


(actually just tweaks tot he above to make merging my future
patches easier since Darin did a lot of the same stuff)

  • Loader/WebDocumentLoader.h:
  • Loader/WebDocumentLoader.m: (-[WebDocumentLoader URLForHistory]):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebDataSource.m: (-[WebDataSource _URLForHistory]):
  • WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]):
12:31 PM Changeset in webkit [16935] by darin
  • 7 edits in trunk/WebKit

Reviewed by Brady.

  • eliminated WebFrameLoader dependency on WebDataSourceInternal.h, WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with most but not all references to WebView
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader handleUnimplementablePolicyWithError:]): (-[WebFrameLoader cannotShowMIMETypeWithResponse:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader checkLoadComplete]):
  • Loader/WebFrameLoaderClient.h:
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
  • WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _formDelegate]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _revertToProvisionalWithDocumentLoader:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _URLForHistoryForDocumentLoader:]): (-[WebFrame _cancelledErrorWithRequest:]): (-[WebFrame _cannotShowURLErrorWithRequest:]): (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]): (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]): (-[WebFrame _fileDoesNotExistErrorWithResponse:]): (-[WebFrame _shouldFallBackForError:]): (-[WebFrame _hasWebView]): (-[WebFrame _mainFrameURL]):
  • WebView/WebFrameInternal.h:
11:50 AM Changeset in webkit [22343] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Steve.

Fix <rdar://problem/4773320>
Safari didn't pick up quicktime that was already installed


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths):
11:43 AM Changeset in webkit [16934] by aroben
  • 2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merging r16932 to tag.

11:41 AM Changeset in webkit [16933] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix.

11:30 AM Changeset in webkit [22342] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4773142>
Crash in Settings::mediumFontSize() on ebay.com

Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
end up calling the Frame::saveDocumentState, which is pure virtual.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
11:29 AM Changeset in webkit [16932] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
already called frome ~FrameMac.

  • page/Frame.cpp: (WebCore::Frame::~Frame):
11:29 AM Changeset in webkit [16931] by darin
  • 7 edits in trunk/WebKit

Reviewed, landed, tweaked a bit by Darin.

  • removed most uses of WebFrameBridge from WebFrameLoader (WebCoreFrameBridge use is OK)
  • Loader/WebDocumentLoader.m: (-[WebDocumentLoader bridge]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
  • WebView/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]):
  • WebView/WebFrameInternal.h:
11:28 AM Changeset in webkit [22341] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Fix build.
11:04 AM Changeset in webkit [16930] by darin
  • 6 edits in trunk/WebKit

Reviewed by Brady.

  • removed almost all direct use of WebView from WebFrameLoader
  • Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • Loader/WebFrameLoaderClient.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.m: (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _hasBackForwardList]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]): (-[WebFrame _progressStarted]): (-[WebFrame _progressCompleted]): (-[WebFrame _incrementProgressForIdentifier:response:]): (-[WebFrame _incrementProgressForIdentifier:data:]): (-[WebFrame _completeProgressForIdentifier:]): (-[WebFrame _setMainFrameDocumentReady:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _startDownloadWithRequest:]):
10:47 AM Changeset in webkit [16929] by andersca
  • 2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

  • bridge/win/FrameWin.h: Add function declaration.
10:35 AM Changeset in webkit [16928] by andersca
  • 2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build.
10:21 AM Changeset in webkit [16927] by andersca
  • 6 edits
    2 deletes in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Move applet widget creation to Frame and get rid of JavaAppletWidget.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/JavaAppletWidget.h: Removed.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget):
  • bridge/mac/JavaAppletWidget.mm: Removed.
  • page/Frame.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
2:53 AM Changeset in webkit [16926] by mjs
  • 7 edits
    2 adds in trunk/WebKit

Reviewed by Alice.

  • moved WebFormState into Loader directory and tweaked to void WebKit dependencies


  • Loader/WebDocumentLoader.h:
  • Loader/WebFormState.h: Added.
  • Loader/WebFormState.m: Added. (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState dealloc]): (-[WebFormState form]): (-[WebFormState values]): (-[WebFormState sourceFrame]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.m:
  • WebView/WebFrameInternal.h:
2:29 AM Changeset in webkit [16925] by bdash
  • 2 edits
    1 add
    1 delete in trunk/WebCore

2006-10-09 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Subversion does not support resource forks and HFS metadata, so
the resources for this test need to be on a disk image.

  • manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
  • manual-tests/resources/plain-text-paste.dmg: Added.
  • manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
  • manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
  • manual-tests/resources/plain-text-paste/._4.txt: Removed.
  • manual-tests/resources/plain-text-paste/._5.webloc: Removed.
  • manual-tests/resources/plain-text-paste/1.textClipping: Removed.
  • manual-tests/resources/plain-text-paste/2.textClipping: Removed.
  • manual-tests/resources/plain-text-paste/3.gif: Removed.
  • manual-tests/resources/plain-text-paste/4.txt: Removed.
  • manual-tests/resources/plain-text-paste/5.webloc: Removed.
2:09 AM Changeset in webkit [16924] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Oliver.

  • remove dependency on WebNSURLRequestExtras.h


  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
1:59 AM Changeset in webkit [16923] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Oliver.


  • removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
  • Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
1:44 AM Changeset in webkit [16922] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Oliver.


  • remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
  • Loader/WebDocumentLoader.h:
  • Loader/WebDocumentLoader.m: (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader initialRequest]): (-[WebDocumentLoader URL]): (-[WebDocumentLoader unreachableURL]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _URL]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader safeLoadURL:]):
  • Loader/WebFrameLoaderClient.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge originalRequestURL]):
  • WebView/WebDataSource.m: (-[WebDataSource _URL]): (-[WebDataSource dealloc]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _forceLayoutForNonHTML]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]): (-[WebFrame _makeRepresentationForDocumentLoader:]):
12:40 AM Changeset in webkit [16921] by rwlbuis
  • 31 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in filter classes.

12:36 AM Changeset in webkit [16920] by rwlbuis
  • 24 edits in trunk/WebCore

Reviewed by olliej.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in SVGPath* classes.

12:32 AM Changeset in webkit [16919] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.

  • removed need for WebFrameLoader to now about WebDocumentLoaderMac
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac setFrameLoader:]): (-[WebDocumentLoaderMac detachFromFrameLoader]):
12:27 AM Changeset in webkit [16918] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by aroben.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg shape classes.

12:23 AM Changeset in webkit [16917] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • passed calls that require WebScriptDebugServer across the client interface
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
12:03 AM Changeset in webkit [16916] by darin
  • 5 edits in trunk/WebKit

Reviewed by Maciej.

  • passed calls that require WebHTMLView or WebFrameView calls across the client interface
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader opened]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader reload]): (-[WebFrameLoader transitionToCommitted:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _forceLayout]): (-[WebFrame _setDocumentViewFromPageCache:]): (-[WebFrame _setCopiesOnScroll]):

Oct 8, 2006:

11:46 PM Changeset in webkit [16915] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • pass remaining delegate methods across client interface
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _dispatchDidFirstLayoutInFrame]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchShow]): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]): (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
11:30 PM Changeset in webkit [16914] by darin
  • 16 edits in trunk

WebCore:

Reviewed by Maciej.

  • added a bit more WebCoreSystemInterface

wkGetNSURLResponseCalculatedExpiration
wkGetNSURLResponseLastModifiedDate
wkGetNSURLResponseMustRevalidate

  • WebCore.exp: Added the new symbols.
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • quiet down the code generation script
  • bindings/scripts/CodeGenerator.pm:

WebKit:

Reviewed by Maciej.

  • use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
  • Loader/WebFrameLoader.m: Update includes. (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK. (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added the three new symbols, and resorted the list.
  • Loader/WebDataProtocol.m:
  • Loader/WebLoader.m:
  • Loader/WebMainResourceLoader.h:
  • Loader/WebMainResourceLoader.m:
  • Loader/WebNetscapePlugInStreamLoader.h:
  • Loader/WebNetscapePlugInStreamLoader.m:
  • Loader/WebSubresourceLoader.h:
  • Loader/WebSubresourceLoader.m: Changed import statements to consistently use the "" format.
11:19 PM Changeset in webkit [16913] by mjs
  • 2 edits in trunk/WebKit

Not reviewed.


  • fix accidental build break due to editing while committing
  • Loader/WebFrameLoader.m:
11:17 PM Changeset in webkit [16912] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • move all WebFrameLoadDelegate methods across client interface
  • Loader/WebFrameLoader.m: (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _dispatchDidCancelClientRedirectForFrame]): (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]): (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]): (-[WebFrame _dispatchWillCloseFrame]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidReceiveTitle:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]):
10:44 PM Changeset in webkit [16911] by darin
  • 6 edits in trunk/WebKit

Reviewed by Maciej.

  • removed some of the WebKit dependencies in WebFrameLoader
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader reload]): (-[WebFrameLoader didChangeTitleForDocument:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
  • WebView/WebFrameInternal.h:
  • some other tweaks
  • Misc/WebNSURLRequestExtras.m: (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
10:42 PM Changeset in webkit [16910] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • pass all WebResourceLoadDelegate methods across client, removing need to include related headers
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
10:23 PM Changeset in webkit [16909] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Darin.


  • started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
  • Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
  • Loader/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge handledOnloadEvents]):
  • WebView/WebFrame.m: (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
  • WebView/WebFrameInternal.h:
9:30 PM Changeset in webkit [16908] by darin
  • 11 edits in trunk/WebKit

Reviewed by Maciej.

  • moved more methods to WebFrameLoader from WebFrame
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader reload]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader checkLoadComplete]):
  • Loader/WebFrameLoaderClient.h:
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge close]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _detachedFromParent1]): (-[WebFrame _detachedFromParent2]): (-[WebFrame _detachedFromParent3]): (-[WebFrame _detachedFromParent4]): (-[WebFrame _updateHistoryAfterClientRedirect]): (-[WebFrame _loadedFromPageCache]):
  • WebView/WebFrameInternal.h:
  • WebView/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
  • WebView/WebView.m: (-[WebView _close]): (-[WebView setDefersCallbacks:]):
8:56 PM Changeset in webkit [16907] by mjs
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

  • more code laundering - add wkSupportsMultipartXMixedReplace
  • WebCore.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.


  • avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
  • Loader/WebDocumentLoader.m: (-[WebDocumentLoader initWithRequest:]):
  • Loader/WebMainResourceLoader.m:
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebView/WebDataSource.m: (-[WebDataSource _initWithDocumentLoader:]):
8:23 PM Changeset in webkit [16906] by bdash
  • 1 edit in trunk/WebKit/WebView/WebFrame.m

Release build fix: silence warning about unused variable.

7:43 PM Changeset in webkit [16905] by darin
  • 2 edits in trunk/WebKit
  • build fix (also a fix for a crasher I forgot to commit before)
  • Loader/WebFrameLoader.m: Added some missing includes. (-[WebFrameLoader checkLoadCompleteForThisFrame]): Added a needed retain/release.
7:35 PM Changeset in webkit [16904] by darin
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • quick fix to loader problem causing layout test failures
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge that we retain/release. (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Same here.
7:17 PM Changeset in webkit [22340] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Port of OpenSource r16526, r16528

Break up ResourceLoaderWndProc into callback functions.

  • platform/win/ResourceLoaderWin.cpp: Fix up #includes (WebCore::): Remove loadStatusMessage, struct JobLoadStatus, add messageHandlers array. (WebCore::ResourceLoaderWndProc): Split handling of different messages into callbacks. (WebCore::ResourceLoader::onHandleCreated): New callback. (WebCore::ResourceLoader::onRequestRedirected): New callback. (WebCore::ResourceLoader::onRequestComplete): New callback. (WebCore::initializeOffScreenResourceLoaderWindow): No need to register loadStatusMessage anymore. (WebCore::transferJobStatusCallback): Change how information is passed into ResourceLoaderWndProc.
7:09 PM Changeset in webkit [16903] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Adam.


  • removed a few includes from WebFrameLoader, fixed up as appropriate
  • segregated header includes into ones that need to go away to move the code and ones that don't
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[WebFrame _privateBrowsingEnabled]):
6:48 PM Changeset in webkit [16902] by darin
  • 9 edits in trunk/WebKit

Reviewed by Maciej.

  • moved a few methods from WebFrame to WebFrameLoader
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (isBackForwardLoadType): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • Loader/WebFrameLoaderClient.h:
  • Plugins/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
  • WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _updateBackground]): (-[WebFrame _frameLoader]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForBackForwardNavigation]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _tokenForLoadErrorReset]): (-[WebFrame _resetAfterLoadError:]): (-[WebFrame _doNotResetAfterLoadError:]):
  • WebView/WebFrameInternal.h:
5:44 PM Changeset in webkit [16901] by bdash
  • 2 edits in trunk/WebKit

2006-10-09 Mark Rowe <bdash@webkit.org>

Rubber-stamped by Darin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that is triggering an assertion failure.
5:33 PM Changeset in webkit [16900] by bdash
  • 2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Darin and Oliver.

Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.

  • platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage. (WebCore::GraphicsContext::drawConvexPolygon):
4:52 PM Changeset in webkit [16899] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.


  • remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into two coincidentally matching enums)
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader commitProvisionalLoad:]): (isBackForwardLoadType): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader didFirstLayout]):
  • WebCoreSupport/WebFrameBridge.m:
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _loadType]): (-[WebFrame loadRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebView.m:
4:33 PM Changeset in webkit [16898] by andersca
  • 2 edits in trunk/WebCore

2006-10-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

  • page/Frame.cpp: (WebCore::Frame::submitForm): No need to use latin1() here.
3:47 PM Changeset in webkit [16897] by darin
  • 6 edits in trunk/WebKit

Reviewed by Maciej.

  • move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge
  • Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader closeOldDataSources]):
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge loader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge imageTitleForFilename:size:]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
  • WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFramePrivate setWebFrameView:]): (-[WebFramePrivate setProvisionalItem:]): (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _setTitle:]): (-[WebFrame _defersCallbacksChanged]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForSavingDocState]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _frameLoader]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame frameView]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
  • WebView/WebFrameInternal.h:
3:45 PM Changeset in webkit [16896] by bdash
  • 2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Darin.

Kill warnings when generating IDL files on Qt/Linux, as the
SOURCE_ROOT environment variable is not defined (and not needed) for us.

  • bindings/scripts/CodeGenerator.pm:
3:24 PM Changeset in webkit [16895] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • split didNotOpenURL: into general and page-cache-specific parts
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:]): (-[WebCoreFrameBridge invalidatePageCache:]):
3:10 PM Changeset in webkit [16894] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Darin.


  • move remaining movable data fields from WebFrameLoader to WebFrame
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitIfReady]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader isQuickRedirectComing]):
  • Loader/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
  • WebView/WebDataSource.m: (-[WebDataSource _loadFromPageCache:]):
  • WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _didFinishLoad]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame stopLoading]): (-[WebFrame _invalidateCurrentItemPageCache]):
  • WebView/WebFrameInternal.h:
2:40 PM Changeset in webkit [16893] by andersca
  • 3 edits in trunk/WebCore

2006-10-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

  • loader/loader.cpp: Remove DeprecatedStringList.h include.


  • page/Frame.cpp: (WebCore::Frame::submitForm): Don't remove "attach" from mailto URLs, we don't do it anywhere else.
2:28 PM Changeset in webkit [16892] by darin
  • 12 edits
    4 moves in trunk/WebKit

Rubber stamped by Maciej.

  • changed "document load state" to "document loader"
  • Loader/WebDocumentLoadState.h: Removed.
  • Loader/WebDocumentLoadState.m: Removed.
  • Loader/WebDocumentLoader.h: Added.
  • Loader/WebDocumentLoader.m: Added. (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setTitle:]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader activeDocumentLoader]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader setDocumentLoader:]): (-[WebFrameLoader documentLoader]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader setPolicyDocumentLoader:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader provisionalDocumentLoader]): (-[WebFrameLoader setProvisionalDocumentLoader:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
  • Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebDocumentLoadStateMac.h: Removed.
  • WebView/WebDocumentLoadStateMac.m: Removed.
  • WebView/WebDocumentLoaderMac.h: Added.
  • WebView/WebDocumentLoaderMac.m: Added.
  • WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
  • WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):
1:44 PM Changeset in webkit [16891] by darin
  • 1 edit in trunk/WebKit/ChangeLog

More change log tweaking -- it's well worth it!

1:42 PM Changeset in webkit [16890] by darin
  • 1 edit in trunk/WebKit/ChangeLog

Fixed grammar mistake in change log entry.

1:42 PM Changeset in webkit [16889] by darin
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

Also added a helper function in WebFrameLoader so code that checks for back/forward load types
is easier to read.

  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load state to nil instead of the passed-in object. (isBackForwardLoadType): Added. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType. (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): Ditto. (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.
12:19 PM Changeset in webkit [16888] by weinig
  • 27 edits
    2 deletes in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
Yet another round of Objective-C SVG DOM bindings auto-generation

  • Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent, DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, DOMSVGZoomAndPan and DOMSVGZoomEvent.
  • Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement using the new [ConvertFromString] property.
  • Add forward declarations for NS* types to auto-generated classes.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMHTMLAppletElement.mm: Removed.
  • bindings/objc/DOMHTMLEmbedElement.mm: Removed.
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • ksvg2/svg/SVGPatternElement.idl:
  • ksvg2/svg/SVGPolygonElement.idl:
  • ksvg2/svg/SVGPolylineElement.idl:
  • ksvg2/svg/SVGRadialGradientElement.idl:
  • ksvg2/svg/SVGRenderingIntent.idl:
  • ksvg2/svg/SVGScriptElement.idl:
  • ksvg2/svg/SVGSetElement.idl:
  • ksvg2/svg/SVGStopElement.idl:
  • ksvg2/svg/SVGSwitchElement.idl:
  • ksvg2/svg/SVGSymbolElement.idl:
  • ksvg2/svg/SVGTRefElement.idl:
  • ksvg2/svg/SVGTSpanElement.idl:
  • ksvg2/svg/SVGTextContentElement.idl:
  • ksvg2/svg/SVGTextElement.idl:
  • ksvg2/svg/SVGTextPositioningElement.idl:
  • ksvg2/svg/SVGTitleElement.idl:
  • ksvg2/svg/SVGUseElement.idl:
  • ksvg2/svg/SVGViewElement.idl:
  • ksvg2/svg/SVGZoomEvent.idl:
6:53 AM Changeset in webkit [16887] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fix two recently introduced leaks: one of an NSString, the other of a WebDataSource
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Rearranged code to avoid storage leak in case of identical title.
  • Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method from the header.
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader as needed if this load state is going away rather than moving on to become the provisional load state. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting. (-[WebFrameLoader _loadRequest:archive:]): Added an assertion. (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion. (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion. (-[WebFrameLoader reload]): Added an assertion. (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid calling _documentLoadState over and over again.
1:02 AM Changeset in webkit [22339] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add win2k/classic support for all controls.

12:47 AM Changeset in webkit [22338] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-07 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Fix <rdar://4772205> Regression (r10623): WinInet loader doesn't ever write to the cache.

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): Apply POST related flags only for posts. (WebCore::ResourceLoader::startHTTPRequest): Don't add no-cache-write flag to non-post transactions.
Note: See TracTimeline for information about the timeline view.