⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 4, 2007:

7:49 PM Changeset in webkit [21977] by sfalken
  • 1 copy in tags/Safari-522.8.10b

New tag.

6:09 PM BuildingGdk edited by jdahlin@async.com.br
(diff)
5:15 PM Changeset in webkit [21976] by oliver
  • 3 edits in trunk/WebKit

Reviewed by Geoff and Justin.

Fix for <rdar://problem/5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/5245964> Safari hangs for several
seconds when trying to select text using mouse


This is a by product of the textStorage hack used to fix
rdar://problem/5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.


This check should really have been present in the original
patch.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
5:10 PM Changeset in webkit [21975] by andersca
  • 2 edits in trunk/WebCore

Reviewed, tweaked and landed by Anders.

<rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted


Null check the provisional document loader. If an application stops the load
inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
4:43 PM Changeset in webkit [21974] by bdash
  • 6 edits in trunk/WebCore

2007-06-04 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=13986
Cairo graphics fixes and cleanups

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::surface): Provide surface() accessor.
  • platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::rotate): Convert from degrees to radians to fix rotation.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Add save/restore. (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to avoid further confusion.
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do not describe a point/size but rather the two control points of the rectangular region. (WebCore::Path::contains): Remove needless casts.
4:40 PM Changeset in webkit [21973] by bdash
  • 2 edits in trunk/WebKitTools

2007-06-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Anders.

  • WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
4:37 PM Changeset in webkit [21972] by bdash
  • 2 edits in tags/Safari-5522.8.3/WebKitTools

Roll out change landed in the wrong place.

4:36 PM Changeset in webkit [21971] by bdash
  • 2 edits in tags/Safari-5522.8.3/WebKitTools

2007-06-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Anders.

  • WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
2:49 PM Changeset in webkit [21970] by yongjzha
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <​yongjun.zhang@nokia.com>

DESC: Remove circular dependency between UI RSS file and engine
​http://bugs.webkit.org/show_bug.cgi?id=13994

  • BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::NewL): (CWidgetExtension::~CWidgetExtension): (CWidgetExtension::LaunchApplicationL): (CWidgetExtension::OpenApplication): (CWidgetExtension::SetPreferenceForKey): (CWidgetExtension::AddOptionMenuItemsL): (CWidgetExtension::MenuItemSelected): (CWidgetExtension::SetParamL): (CWidgetExtension::AddOptionsMenuItem): (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::Append): (CWidgetExtension::DeleteMenuItem): (CWidgetExtension::ReplaceMenuItem): (CWidgetExtension::MenuItem): (CWidgetExtension::GetFromMenuItemCollection): (CWidgetExtension::SetDimmed): (CWidgetExtension::SetMenuItemObserver): (CWidgetExtension::MenuItemObserver): (CWidgetExtension::MenuObserver): (CWidgetExtension::RightKeyObserver): (CWidgetExtension::FindNodeById): (CWidgetExtension::FindNodeByText):
2:27 PM Changeset in webkit [21969] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix the buildbot.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
11:39 AM Changeset in webkit [21968] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Kimon Tsinteris.


<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Demonstrates bug:

  • editing/selection/5241148-expected.txt: Added.
  • editing/selection/5241148.html: Added. Updated to reflect new equivalents for positions before/after tables:
  • editing/selection/click-before-and-after-table-expected.txt:
  • editing/selection/click-before-and-after-table.html:

WebCore:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections


Return valid equivalents from these methods (no [img, 1] for
example). ActivEdit was using positions returned from these
methods to create new DOM Ranges.


  • editing/SelectionController.cpp: (WebCore::SelectionController::baseNode): (WebCore::SelectionController::baseOffset): (WebCore::SelectionController::extentNode): (WebCore::SelectionController::extentOffset): (WebCore::SelectionController::anchorNode): (WebCore::SelectionController::anchorOffset): (WebCore::SelectionController::focusNode): (WebCore::SelectionController::focusOffset):
  • editing/SelectionController.h:
9:17 AM BuildingQtOnLinux edited by bero@arklinux.org
Add gcc 4.2 incompatibility workaround (diff)
6:41 AM Changeset in webkit [21967] by rwlbuis
  • 2 edits in trunk/WebCore

Fix the svg experimental build.

5:15 AM BuildingQtOnLinux edited by bero@arklinux.org
Add qmake build dependency and note about having qmake in the PATH (diff)
5:01 AM BuildingQtOnLinux edited by bero@arklinux.org
Add flex to list of build deps (diff)
4:51 AM BuildingQtOnLinux edited by bero@arklinux.org
update headline to reflect the fact that Ark instructions are included (diff)
3:43 AM BuildingQtOnLinux edited by bero@arklinux.org
Add Ark Linux build instructions where they differ from *ubuntu's … (diff)
2:41 AM Changeset in webkit [21966] by bdash
  • 86 edits
    428 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <​mrowe@apple.com>

Upgrade to WordPress 2.2. I didn't go to the effort of tracking down files
present in the old version which have since been removed, but it's unlikely
they'll ever cause a problem.

1:30 AM Changeset in webkit [21965] by bdash
  • 1 edit
    11 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <​mrowe@apple.com>

Add graphics used by existing blog posts into SVN.

  • blog/wp-content/rotate.png: Added.
  • blog/wp-content/drosera.png: Added.
  • blog/wp-content/hitlist.png: Added.
  • blog/wp-content/svgtextmini.png: Added.
  • blog/wp-content/svgtextmini_01.png: Added.
  • blog/wp-content/textfield_screenshot.jpg: Added.
  • blog/wp-content/Picture9.png: Added.
  • blog/wp-content/svgtext.png: Added.
  • blog/wp-content/webInspector.png: Added.
  • blog/wp-content/rotate.svg: Added.
  • blog/wp-content/chucknorris.png: Added.
1:04 AM Changeset in webkit [21964] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=6170
CSS1: Properties for :first-letter aren't recalculated on color change

Mark styles with first-letter as unique.

Jun 3, 2007:

10:46 PM Changeset in webkit [23443] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.


<rdar://problem/5246665> Drop down lists are not drawn on volvocars.us

  • WebView.cpp: (WebView::userAgentForKURL):
7:05 PM Changeset in webkit [21963] by sfalken
  • 1 copy in tags/Safari-522.8.8b

New tag.

5:52 PM Changeset in webkit [21962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageWx.cpp

We need to clip ourselves when drawing tiled (e.g. background) images.

5:16 PM Changeset in webkit [23442] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Update to last fix.
Invalidate a list of rects rather than unioning them.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): (WebCore::PluginViewWin::invalidateRect):
  • plugins/win/PluginViewWin.h:
4:28 PM Changeset in webkit [21961] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

For Windows, match the debug-runtime-libs setting with the one the wx build is using.

4:25 PM Changeset in webkit [21960] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

Send the load complete message when the document load completes, as wxWebView currently only monitors overall load progress.

2:01 PM Changeset in webkit [23441] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

<rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com


Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
starving other HWNDs.


This code defers the invalidate through a WebCore::Timer. We could have used a Windows ::SetTimer
to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateTimerFired): Added. (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash. (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
  • plugins/win/PluginViewWin.h:
1:31 PM Changeset in webkit [21959] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/GraphicsContextWx.cpp

Remove debugging statement.

1:25 PM Changeset in webkit [21958] by kevino
  • 3 edits in branches/wx-port-alpha/trunk/JavaScriptCore

Fixing a couple defines, and removing an unused sources tag in JSCore project file.

1:05 PM Changeset in webkit [21957] by kevino
  • 4 edits in branches/wx-port-alpha/trunk/WebKit/wx

Better support for page load progress indicators, along with support for getting the page title.

Jun 2, 2007:

7:56 PM Changeset in webkit [23440] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update last fix to use startsWith instead of strcmpi.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL):
5:21 PM WikiStart edited by pewtermoose@gmail.com
(diff)
5:20 PM FAQ created by pewtermoose@gmail.com
11:05 AM Changeset in webkit [23439] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by gramps.

Fix ​http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
Make "javascript" URL scheme string compare case insensitive.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Use strcmpi.
  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.

Jun 1, 2007:

10:57 PM Changeset in webkit [21956] by sfalken
  • 1 copy in tags/Safari-522.8.7b

New tag.

8:30 PM Changeset in webkit [21955] by bdash
  • 1 edit in tags/Safari-5522.8.3/WebCore/Configurations/Version.xcconfig

Versioning.

8:20 PM Changeset in webkit [21954] by bdash
  • 1 copy in tags/Safari-5522.8.3

New tag.

8:12 PM Changeset in webkit [21953] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21952.

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
7:37 PM Changeset in webkit [21952] by andersca
  • 2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.


  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
6:58 PM Changeset in webkit [21951] by kevino
  • 3 edits in branches/wx-port-alpha/trunk

Don't require a debug build of wxWidgets to be used with wxWebKit.

4:54 PM Changeset in webkit [21950] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling the event handler methods directly, post the fake event on the application event queue. This ensures that the fake event is handled only after handling of the initiating event has ended, and is seen by ancestor frames' event handlers.
3:27 PM Changeset in webkit [21949] by sfalken
  • 1 copy in tags/Safari-522.8.6b

New tag.

3:10 PM Changeset in webkit [23438] by kmccullo
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

  • Uncommenting some functions that should not be commented out. I needed them for the Drosera port.
  • WebKit.vcproj/WebKit_debug.def:
3:07 PM Changeset in webkit [23437] by kmccullo
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

3:00 PM Changeset in webkit [21948] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/StringWx.cpp

More robust string conversion, courtesy of Vaclav Slavik.

2:52 PM Changeset in webkit [23436] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

If the value exists but is empty, return an empty String.


  • plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo):
2:28 PM Changeset in webkit [21947] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Add explicit cast (some users reported 'ambiguous call' errors without it).

2:26 PM Changeset in webkit [21946] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/WebCoreSources.bkl

Remove duplicate file entry.

2:23 PM Changeset in webkit [21945] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/page/Frame.h

Remove unused variable.

2:12 PM Changeset in webkit [21944] by eseidel
  • 14 edits in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
​http://bugs.webkit.org/show_bug.cgi?id=12568


This is covered by the W3C tests (including mask-intro01)

  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMaskElement.idl:
  • platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
2:05 PM Changeset in webkit [21943] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21933.

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
2:05 PM Changeset in webkit [21942] by bdash
  • 3 edits in branches/Safari-5522/WebCore

Merge r21905.

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
​http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.
2:05 PM Changeset in webkit [21941] by bdash
  • 5 edits
    4 adds in branches/Safari-5522

Merge r21902.

LayoutTests:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

  • fast/dom/frame-contentWindow-crash-expected.txt: Added.
  • fast/dom/frame-contentWindow-crash.html: Added.
  • fast/dom/iframe-contentWindow-crash-expected.txt: Added.
  • fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
2:04 PM Changeset in webkit [21940] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21897.

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
1:55 PM Changeset in webkit [23435] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker.


Remove unnecessary user agent spoofs, now that we have the final UA in place.
Added spoof to allow Flash downloads from adobe.com

  • WebView.cpp: (WebView::userAgentForKURL):
12:09 PM Changeset in webkit [23434] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Add the default path for the new WMP Firefox plugin.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginPath):
11:01 AM Changeset in webkit [21939] by andersca
  • 15 edits in branches/Safari-522

Merge r20613 and the subsequent build fix, r20614

5:47 AM Changeset in webkit [21938] by staikos
  • 2 edits in trunk/WebCore

2007-06-01 George Staikos <​staikos@kde.org>

Reviewed by bdash.

Redo the build fix again after it was backed out

  • WebCore.pro: add an include guard around CSSGrammar.h
5:40 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
5:39 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
4:20 AM Changeset in webkit [21937] by eseidel
  • 2 edits
    1 add in branches/feature-branch/WebCore

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by lars.


Cursor does not change to hand over links containing <use>
​http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

  • manual-tests/svg-link-hover-use.svg: Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode
2:59 AM Changeset in webkit [21936] by eseidel
  • 5 edits
    4 adds in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
​http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):
2:34 AM Changeset in webkit [21935] by bdash
  • 2 edits in trunk/WebCore

Roll out r21916 as it did nothing to fix the build.

1:13 AM Changeset in webkit [21934] by eseidel
  • 4 edits
    5 adds in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

  • dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
  • dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):
12:25 AM Changeset in webkit [21933] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.


No test because the only code affected is the debugger, and none of the
relevant API is exported.


Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
Note: See TracTimeline for information about the timeline view.