⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 28, 2007:

7:51 PM Changeset in webkit [25286] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Removed test files in /resources/ subdirectories.

7:49 PM Changeset in webkit [25285] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

Ignore files in /resources/ subdirectories when creating a list of added tests.

  • Scripts/prepare-ChangeLog: (generateFileList):
5:32 PM Changeset in webkit [25284] by weinig
  • 4 edits
    7 adds in trunk

WebCore:

Reviewed by Darin.

Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.

Tests: http/tests/security/listener/resources/childWithXMLHttpRequest.html

http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html
http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html
http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
http/tests/security/listener/xss-XMLHttpRequest-shortcut.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window. (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.

LayoutTests:

Reviewed by Darin.

Additional tests for <rdar://problem/5426142>

  • http/tests/security/listener/resources/childWithXMLHttpRequest.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut.html: Added.
5:15 PM Changeset in webkit [25283] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
are still created during the first layout.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Only call layout if the renderer doesn't have a widget.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Likewise.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Update for enum change.


  • loader/FrameLoaderTypes.h: Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.


  • page/mac/WebCoreFrameBridge.h: Get rid of the enum here, we can use the one in FrameLoaderTypes.h


  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Only create the plug-in if it's not a Netscape plug-in.


(WebCore::RenderPartObject::layout):
Fix indentation.

WebKit:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent


  • WebCoreSupport/WebFrameBridge.mm: Use the enum from FrameLoaderTypes.h.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.
4:36 PM Changeset in webkit [25282] by honeycutt
  • 2 edits in trunk/WebKit/win

2007-08-28 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

<rdar://problem/5444457>: Content is cut when page orientation changed
in print preview
Fix: Don't return WebFrame::m_pageRects if it exists; let
computePageRectsForFrame clear and rewrite it.

  • WebFrame.cpp: (WebFrame::computePageRects): Removed an early-return case. Added a space.
3:08 PM Changeset in webkit [25281] by harrison
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.
  • platform/mac/editing/selection: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.txt: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.txt: Added.
3:06 PM Changeset in webkit [25280] by harrison
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

The selection was ending up inside non-editable content at the To Do Options
arrow image, rather then at the editable position just to the left of that image.
The problem was that startPositionForLine looked only at line boxes, and there
is no linebox for the editable position at the far left of a To Do, which is
a table. Addressed by having startPositionForLine use table offset 0 instead
of the first VisiblePosition inside the table.


Found and fixed the similar case with option-left (move by word position).


Test cases:

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.

Source changes:

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingLeftBackward):


  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::stayInEditableContentLeft): (WebCore::VisiblePosition::stayInEditableContentRight): Factored stayInEditableContentLeft() and stayInEditableContentRight() out of previous() and next().


  • editing/VisiblePosition.h: Declare stayInEditableContentLeft() and stayInEditableContentRight().
  • editing/visible_units.cpp: (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Call stayInEditableContentLeft() or stayInEditableContentRight(), as appropriate, so prevent crossing from editable content into uneditable content.


(WebCore::startPositionForLine):
Use table offset 0 instead of the first VisiblePosition in the table.

1:24 PM Changeset in webkit [25279] by bdash
  • 2 edits in trunk/WebKit

2007-08-28 Mark Rowe <​mrowe@apple.com>

Fix the buildbot build.

  • History/WebHistory.mm: (timeIntervalForBeginningOfDay): Explicitly cast to silence compiler warning.
1:12 PM Changeset in webkit [25278] by bdash
  • 2 edits in trunk/WebCore

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs

Perform the sync inside a SQLite transaction. This drops the time taken for the sync from over 90s to under half a second in the
extreme case of over 90,000 URLs being pruned.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
1:06 PM Changeset in webkit [25277] by andersca
  • 3 edits in trunk/LayoutTests

Use the correct test paths.


  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:55 PM Changeset in webkit [25276] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Put ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.

12:48 PM Changeset in webkit [25275] by bdash
  • 10 edits
    2 deletes in trunk

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays
of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems. NSTimeInterval
uses less memory and is substantially cheaper during comparisons than NSCalendarDate. The use of the HashMap
avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days
history items.

The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s. Loading
100 items drops from 0.003s to 0.002s.

  • History/WebHistory.mm: (-[WebHistoryPrivate init]): (-[WebHistoryPrivate dealloc]): (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day. (-[WebHistoryPrivate findKey:forDay:]): (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search. (-[WebHistoryPrivate _removeItemFromDateCaches:]): (-[WebHistoryPrivate _addItemToDateCaches:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API. This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed. (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the number of live autoreleased objects generated to a reasonable level.
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title rather than setting it after construction. This prevents a modification notification from being sent for each WebHistoryItem that is loaded.
  • History/WebHistoryItemInternal.h:
  • History/WebHistoryPrivate.h:
  • Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.
  • Misc/WebNSCalendarDateExtras.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Add a new constructor for HistoryItem that initializes the alternate title. This prevents WebHistoryItem
in WebKit from having explicitly set the display title, which triggers a history item changed notification
to be posted, for each history item loaded.

  • WebCore.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
12:05 PM Changeset in webkit [25274] by andersca
  • 20 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest
pass in false when creating its subresource loader.


  • WebCore.exp:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

WebKit:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Expose WKSetNSURLRequestShouldContentSniff to WebCore.


  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


  • http/tests/xmlhttprequest/resources/small-chunks.cgi: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text-expected.txt: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:03 PM Changeset in webkit [25273] by andersca
  • 3 edits in trunk/WebKitLibraries

Add WKSetNSURLRequestShouldContentSniff.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
10:23 AM Changeset in webkit [25272] by adachan
  • 5 edits
    1 add in trunk/WebKit/win

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.

Reviewed by Adam and Steve.

  • Interfaces/IWebURLResponsePrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): (WebURLResponse::sslPeerCertificate): gets peer certificate context from CFNetwork (WebURLResponse::certificateDictionary): gets the dictionary that contains SSL certificate info from CFNetwork. We retain the dictionary to ensure the certificate context is valid throughout the lifetime of the WebURLResponse.
  • WebURLResponse.h:


10:20 AM Changeset in webkit [25271] by adachan
  • 4 edits in trunk/WebKitLibraries

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.
Updated libraries.


Reviewed by Adam.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:


9:29 AM Changeset in webkit [25270] by sfalken
  • 4 edits in trunk

<rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded


Don't bypass WebView WM_PAINT if the WebView has never committed a page.
Added getter for committedFirstRealDocumentLoad.


Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
  • loader/FrameLoader.h: Added committedFirstRealDocumentLoad. (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.

Aug 27, 2007:

11:35 PM Changeset in webkit [25269] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by NOBODY (layout test result fix).

Output of layoutTestController.dumpChildFramesAsText changes in non-relevant way
when running this test on its own vs. running as part of the full suite.


Correcting test result for the output produced while running the full suite.

  • fast/encoding/frame-default-enc-expected.txt:
10:59 PM Changeset in webkit [25268] by oliver
  • 10 edits
    2 adds
    6 deletes in trunk/LayoutTests

rs=brady


Convert all the encoding tests to plain text dumps.

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding-mac-expected.txt: Added.
  • fast/encoding/char-decoding-mac.html: Added. char-decoding-mac tests the ability to decode the mac specific legacy x-nextstep charset.
  • fast/encoding/char-decoding.html:
  • fast/encoding/frame-default-enc-expected.checksum: Removed.
  • fast/encoding/frame-default-enc-expected.png: Removed.
  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/mispositioned-meta-expected.checksum: Removed.
  • fast/encoding/mispositioned-meta-expected.png: Removed.
  • fast/encoding/mispositioned-meta-expected.txt:
  • fast/encoding/mispositioned-meta.html:
  • fast/encoding/tag-in-title-expected.checksum: Removed.
  • fast/encoding/tag-in-title-expected.png: Removed.
  • fast/encoding/tag-in-title-expected.txt:
  • fast/encoding/tag-in-title.html:
  • platform/win/Skipped: Skip char-decoding-mac
4:09 PM Changeset in webkit [25267] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals


javascript: URLs need special handling when serializing. Escaping them like
normal attribute values can do bad things. Try hard to not escape anything,
escape quote characters only if really necessary. Try to match Firefox.

Test: fast/innerHTML/javascript-url.html

  • editing/markup.cpp: (WebCore::urlAttributeToQuotedString): (WebCore::startMarkup):

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals

  • fast/innerHTML/javascript-url-expected.txt: Added.
  • fast/innerHTML/javascript-url.html: Added.
3:46 PM Changeset in webkit [25266] by oliver
  • 2 edits in trunk/LayoutTests

rs=adam

Remove tests effected by <rdar://problem/5317287> from the windows skiplist

  • platform/win/Skipped:
2:57 PM Changeset in webkit [25265] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderInline.cpp
2:57 PM Changeset in webkit [25264] by hyatt
  • 5 edits in trunk/WebCore

Fix for 5441224, micro-optimizations to improve the PLT by 1%.

Reviewed by Darin

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
  • platform/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isBody):
  • rendering/RenderObject.h: (WebCore::RenderObject::renderArena): (WebCore::RenderObject::isRoot):
1:43 PM Changeset in webkit [25263] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by John.

  • Removed Leopard leaks list since all of those radars were fixed.
  • Scripts/run-webkit-tests:
10:57 AM Changeset in webkit [25262] by bdash
  • 3 edits
    5 adds in trunk

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/replaced/applet-disabled-positioned.html

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Changed to call RenderObject::createObject(), which accounts for style.

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/replaced/applet-disabled-positioned.html: Added.
  • platform/mac/fast/replaced: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.checksum: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.png: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.txt: Added.
6:36 AM Changeset in webkit [25261] by zimmermann
  • 9 edits in branches/feature-branch/WebCore

Reviewed by Mitz.

Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.

1:13 AM Changeset in webkit [25260] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

Initialise iterators to appease gcc

  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1:13 AM Changeset in webkit [25259] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Mark.

  • Scripts/pdevenv: Pass arguments along to devenv.com.

Aug 26, 2007:

11:40 PM Changeset in webkit [25258] by darin
  • 2 edits in trunk/JavaScriptCore
  • quick follow on to that last check-in
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): Need to initialize m_class to 0.
11:17 PM Changeset in webkit [25257] by bdash
  • 5 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/4949002> JSGlobalContextCreate can cause crashes because it passes a NULL JSContextRef to the globalObjectClass's initialize callback

JSCallbackObject now tracks whether it was constructed with a null ExecState. This will happen when the object is being used as the global object,
as the Interpreter needs to be created after the global object. In this situation the initialization is deferred until after the Interpreter's
ExecState is available to be passed down to the initialize callbacks.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): Track whether we successfully initialized. (KJS::JSCallbackObject::initializeIfNeeded): Attempt to initialize with the new ExecState.
  • API/JSCallbackObject.h:
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Initialize the JSCallbackObject with the Interpreter's ExecState.
  • API/testapi.c: (testInitializeOfGlobalObjectClassHasNonNullContext): (main): Verify that the context passed to the initialize callback is non-null.
11:02 PM Changeset in webkit [25256] by bdash
  • 3 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5438496> JSGlobalContextCreate crashes when passed a custom class

  • API/JSContextRef.cpp: (JSGlobalContextCreate): Specify jsNull() as the prototype and let Interpreter's constructor fix it up to point at builtinObjectPrototype().
  • API/testapi.c: (main): Use an instance of a custom class as the global object to ensure the code path is exercised in the test.
5:11 PM Changeset in webkit [25255] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


Fix for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

Test: editing/style/temporary-span-crash.html

  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart): Temporary span created here might not have renderer if document has style sheet that makes it display:none. Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display value from actual document style sheets. Null check the renderer too to be sure.

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

  • editing/style/temporary-span-crash-expected.txt: Added.
  • editing/style/temporary-span-crash.html: Added.
6:39 AM Changeset in webkit [25254] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Update prepare-ChangeLog to generate the datestamp in the correct timezone.

  • Scripts/prepare-ChangeLog: (changeLogDate): Added.
6:20 AM Changeset in webkit [25253] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Mark Rowe and David Kilzer.

Fix build failure on arm.

  • wtf/Platform.h: Also test if arm is defined.
5:46 AM Changeset in webkit [25252] by zimmermann
  • 1 edit
    5 adds in branches/feature-branch/LayoutTests

Rubberstamped by Mark.
Add missing SVG filter testcase (forgot to include in last commit).

Aug 25, 2007:

7:16 PM Changeset in webkit [25251] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Adam and Sam


<rdar://problem/5269732> Safari 3.0 for Windows cuts off text in textarea boxes during sending forms (14562)
<​http://bugs.webkit.org/show_bug.cgi?id=14562> [Win] Textarea contents partially eaten on submit/copy


WebView::handleEditingKeyboardEvent assumed all keycodes that did not trigger a named command were
to be inserted. This could cause unexpected behaviour when control characters (eg. escape) are sent,
or could cause data loss when sent a null character (as happens when dead keys are used for international
input).


This patch corrects WebView::handleEditingKeyboardEvent to prevent such characters from being sent
to Editor::insertText. This behaviour matches Firefox.

  • WebView.cpp: (WebView::handleEditingKeyboardEvent):
1:42 PM Changeset in webkit [25250] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (fixes layout tests).

Don't pass any options to window.open() in target-frame-from-window.html, specifically
those that cause the window to be resized. This caused a downstream failure in
cross-frame-access-put.html because the window.outerHeight and window.outerWidth
properties were sometimes affected by the new window size used in the popup window.

  • http/tests/navigation/target-frame-from-window.html:
12:08 PM Changeset in webkit [25249] by weinig
  • 4 edits
    16 adds in trunk

WebCore:

Reviewed by Adele.

Fix for <rdar://problem/5426142>

Use the EventTarget's frame when creating the EventListener.

Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html

http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
http/tests/security/listener/xss-window-onclick-addEventListener.html
http/tests/security/listener/xss-window-onclick-shortcut.html

  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Adele.

Tests for <rdar://problem/5426142>

  • http/tests/security/listener: Added.
  • http/tests/security/listener/resources: Added.
  • http/tests/security/listener/resources/childWindow.html: Added.
  • http/tests/security/listener/resources/childWithButton.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut.html: Added.
12:02 PM Changeset in webkit [25248] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • manual-tests/drag-out-of-background-window.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate conversion.
11:12 AM Changeset in webkit [25247] by bdash
  • 1 copy in tags/Safari-4523.2

New tag.

9:57 AM Changeset in webkit [25246] by rwlbuis
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14848
DOM table rules are not updated when changed

On a dynamic rules attr change, mark the table cells and
their ancestors (up to and including the table tag) as
changed.

9:35 AM Changeset in webkit [25245] by adele
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas


Test: fast/forms/drag-out-of-textarea.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): Only restricts hit testing if the placeholder text is visible.
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added.

LayoutTests:

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas

  • fast/forms/drag-out-of-textarea-expected.txt: Added.
  • fast/forms/drag-out-of-textarea.html: Added.
9:08 AM Changeset in webkit [25244] by bdash
  • 21 edits
    2 deletes in tags/Safari-5523.2

Roll out r25128 to prevent <rdar://5424866>.

8:49 AM Changeset in webkit [25243] by bdash
  • 4 edits in trunk

Versioning.

8:48 AM Changeset in webkit [25242] by bdash
  • 1 copy in tags/Safari-5523.2

New tag.

7:03 AM Changeset in webkit [25241] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Maciej Stachowiak.

Part 3 of ​http://bugs.webkit.org/show_bug.cgi?id=14967
Bug 14967: Reduce wtf::Vector::operator[]() overloads

  • wtf/Vector.h: (WTF::Vector::operator[]): Only provide versions of operator[] that takes a size_t argument.
7:00 AM Changeset in webkit [25240] by bdash
  • 7 edits in trunk

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • wtf/Vector.h: (WTF::Vector::data):

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • bindings/js/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary):
  • loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType):
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::dispatchScheduledEvents):
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
5:58 AM Changeset in webkit [25239] by bdash
  • 1 edit
    1 move in trunk/LayoutTests

2007-08-25 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Mitz.

Disable fast/js/string-concatenate-outofmemory.html until <​http://bugs.webkit.org/show_bug.cgi?id=15046> is resolved.

  • fast/js/string-concatenate-outofmemory.html: Removed.
  • fast/js/string-concatenate-outofmemory.html-disabled: Copied from LayoutTests/fast/js/string-concatenate-outofmemory.html.
5:37 AM Changeset in webkit [25238] by bdash
  • 1 edit
    1 delete in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Rubber-stamped by Adam Roben

  • remove unused file
  • platform/win/MouseEventWin.cpp: Removed.
5:35 AM Changeset in webkit [25237] by bdash
  • 2 edits in trunk/WebCore

2007-08-25 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Oliver Hunt.

Set paintingDisabled to true in Cairo's GraphicsContext constructor
when passed a null PlatformGraphicsContext.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:30 AM Changeset in webkit [25236] by bdash
  • 6 edits in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Covered by fast/parser/residual-style-close-across-n-blocks.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the residual style was closed before anything else in the block (so it does not apply to anything inside the block) avoid creating an empty element for it inside the block.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/parser/residual-style-close-across-n-blocks-expected.txt:
  • fast/parser/residual-style-close-across-n-blocks.html:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
5:26 AM Changeset in webkit [25235] by bdash
  • 3 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: editing/selection/move-by-line-003.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each line is tested for hits between its overflow top and the next line's overflow top. This matches RenderBlock::positionForCoordinates.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/selection/move-by-line-003-expected.txt: Added.
  • editing/selection/move-by-line-003.html: Added.
5:21 AM Changeset in webkit [25234] by bdash
  • 13 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

Test: editing/pasteboard/newlines-around-floating-or-positioned.html

  • editing/TextIterator.cpp: (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around floating or positioned blocks. This behavior seems to match WinIE's.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

  • editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
  • editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
  • fast/events/capture-on-target-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/mouseover-mouseout-expected.txt:
  • fast/events/mouseover-mouseout2-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
  • fast/events/window-events-capture-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/onselect-textarea-expected.txt:
  • fast/forms/onselect-textfield-expected.txt:
Note: See TracTimeline for information about the timeline view.