Timeline
Jan 22, 2008:
- 8:01 PM Changeset in webkit [29728] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
- fix http://bugs.webkit.org/show_bug.cgi?id=16905 <rdar://problem/5692407> REGRESSION (3.0.4-TOT): "menu" pseudocolor is badly chosen
The regression test for this is fast/css/css2-system-color.html which
is currently disabled.
- rendering/RenderThemeMac.mm: (WebCore::menuBackgroundColor): Added. Uses HIThemeDrawMenuBackground to draw the menu item background into a bitmap graphics context and returns the color of the pixel at (0, 0). (WebCore::RenderThemeMac::systemColor): Changed to call menuBackgroundColor for the CSS2 menu color.
- 4:29 PM Changeset in webkit [29727] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- turn full repainting back on for <canvas> until we get incremental repaint working properly
Ollie and I came up with a plan for testing this, but for now we should
just fall back on the "repaint everything" behavior we have always had.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw): Just call repaint.
- 3:16 PM Changeset in webkit [29726] by
-
- 5 edits2 adds in trunk
Reviewed by Darin and Adam.
<rdar://problem/5688975>
div element on microsoft site has wrong left offset.
Return true even if NPN_GetProperty returns null or undefined. This matches Firefox
(and is what the Silverlight plug-in expects).
- bindings/NP_jsobject.cpp: (_NPN_GetProperty):
WebKitTools:
Reviewed by Darin and Adam.
<rdar://problem/5688975>
div element on microsoft site has wrong left offset.
Add new method for testing the return vale of NPN_GetProperty.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):
LayoutTests:
Reviewed by Darin and Adam.
<rdar://problem/5688975>
div element on microsoft site has wrong left offset.
Add test.
- plugins/netscape-get-property-return-value-expected.txt: Added.
- plugins/netscape-get-property-return-value.html: Added.
- 1:23 PM Changeset in webkit [29725] by
-
- 2 edits in trunk/WebCore
2008-01-22 Alp Toker <alp@atoker.com>
GTK+/qmake build fix.
- WebCore.pro:
- 12:46 PM Changeset in webkit [29724] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
<rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
- DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
- 12:45 PM Changeset in webkit [29723] by
-
- 9 edits2 adds2 deletes in trunk
2008-01-22 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
[GTK] API: WebKitWebSettings is not usable
http://bugs.webkit.org/show_bug.cgi?id=16219
Implement WebKitWebSettings.
- 11:33 AM Changeset in webkit [29722] by
-
- 6 edits9 adds in trunk
Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com
WebCore:
Add HTMLFrameOwnerElement::scrollingMode
This new virtual method is overridden by HTMLFrameElementBase to
provide the scrolling mode set on the frame or iframe element. Object
elements always have scrolling=auto, so there's no need to override
this method for HTMLPlugInElement.
Reviewed by Hyatt.
- html/HTMLFrameElementBase.h: Declare scrollingMode as virtual.
- html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::scrollingMode): Added.
WebKit/win:
Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com
Now that we have multiple FrameViews per Frame on Windows, we need to
make sure each FrameView gets its scrolling mode set correctly. On Mac
this works because WebFrameView holds the scrolling mode and a single
WebFrameView is shared by many FrameViews. On Windows, we have no such
shared object, so we just ask the Frame's owner element for the
scrolling mode.
Tests: fast/frames/frame-scrolling-attribute.html
fast/frames/iframe-scrolling-attribute.html
Reviewed by Hyatt.
- WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode on the FrameView based on the scrolling mode of the Frame's owner element.
LayoutTests:
Tests for <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com
Reviewed by Hyatt.
- fast/frames/frame-scrolling-attribute.html: Added.
- fast/frames/iframe-scrolling-attribute.html: Added.
- platform/mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
- platform/mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
- platform/mac/fast/frames/frame-scrolling-attribute-expected.txt: Added.
- platform/mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
- platform/mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
- platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
- 9:36 AM Changeset in webkit [29721] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter double divider and no padding
Now that cellpadding cascades properly on <td>s, we need to make the view source padding rules in the user
agent sheet have !important in order to override author settings.
Reviewed by Tim
- css/view-source.css:
- 8:09 AM Changeset in webkit [29720] by
-
- 5 edits in trunk/WebCore
Reviewed by Alp.
Allow to use SVGPaintServerSolid without RenderObject/RenderStyle. Used later to draw SVG Fonts in HTML.
- 6:57 AM Changeset in webkit [29719] by
-
- 2 edits in trunk/WebCore
Reviewed by Alp.
Initialize missing variables, m_lineGap / m_lineSpacing.
Only noticeable when trying to render HTML text using SVG Fonts (which is not possible with trunk, but with my local version).
- 5:53 AM Changeset in webkit [29718] by
-
- 4 edits in trunk/WebCore
2008-01-22 Alp Toker <alp@atoker.com>
Reviewed by Nikolas.
Fix Cairo SVG fonts following changes in r29700.
Set the font description's details as needed in FontPlatformData and
eliminate GraphicsContext::setPlatformFont() since it was redundant
and assumed all fonts were Cairo fonts.
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 3:10 AM Changeset in webkit [29717] by
-
- 3 edits4 adds in trunk
Reviewed by Eric.
<rdar://problem/5699344> Reproducible crash when navigating back to a page using SVG fonts
Test: svg/custom/font-platformDestroy-crash.svg
- 2:03 AM Changeset in webkit [29716] by
-
- 2 edits in trunk/WebKit/qt
Lars Knoll <lars@trolltech.com>
setup a family for cursive and fantasy fonts as well.
- 2:03 AM Changeset in webkit [29715] by
-
- 2 edits in trunk/WebCore
Lars Knoll <lars@trolltech.com>
cleanup the CookieJarQt implementation and implement cookiesEnabled.
- 2:03 AM Changeset in webkit [29714] by
-
- 2 edits in trunk
Simon Hausmann <Simon Hausmann>
Don't compile the ICO plugin when building against Qt >= 4.4
- 2:03 AM Changeset in webkit [29713] by
-
- 5 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Implement ChromeClientQt::setToolTip
Implement ChromeClientQt::mouseDidMoveOverElement
- 12:38 AM Changeset in webkit [29712] by
-
- 19 edits1 add in trunk
Lars Knoll <lars@trolltech.com>
Ported the font implementation to use the new QFont features of Qt 4.4.
Jan 21, 2008:
- 10:48 PM Changeset in webkit [29711] by
-
- 4 edits in trunk
Reviewed by Nikolas & Oliver.
Tested by svg/custom/svg-features.html
- dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals
- 10:18 PM Changeset in webkit [29710] by
-
- 12 edits2 adds in trunk
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
(and a bunch of other crashes)
Plus, a .7% SunSpider speedup to boot.
Replaced the buggy currentExec and savedExec mechanisms with an
explicit ExecState stack.
- kjs/collector.cpp: (KJS::Collector::collect): Explicitly mark the ExecState stack.
(KJS::Collector::reportOutOfMemoryToAllExecStates): Slight change in
behavior: We no longer throw an exception in any global ExecStates,
since global ExecStates are more like pseudo-ExecStates, and aren't
used for script execution. (It's unclear what would happen if you left
an exception waiting around in a global ExecState, but it probably
wouldn't be good.)
WebCore:
Reviewed by Maciej Stachowiak.
Adapted WebCore to the fix for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy): No convenient way to make this assertion anymore. (It wasn't firing for anyone, anyway, so it's no big loss.)
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): Use the ExecState stack, instead of currentExec. (-[WebScriptObject setException:]): ditto. Also, a slight change in behavior: If no ExecStates are active, we no longer throw an exception in the global ExecState. The JavaScriptCore ChangeLog explains why. This also matches the behavior of +throwException.
LayoutTests:
Layout test for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
- fast/js/exec-state-marking-expected.txt: Added.
- fast/js/exec-state-marking.html: Added.
- 4:52 PM Changeset in webkit [29709] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix Qt build, after the rmdir() fixes.
- 4:49 PM Changeset in webkit [29708] by
-
- 2 edits in trunk/WebCore
Not reviewed. Another Wx build fix.
- 4:30 PM Changeset in webkit [29707] by
-
- 2 edits in trunk/WebCore
- try to fix Qt build
- platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): QDir::root().rmdir() instead of QDir::rmdir().
- 4:05 PM Changeset in webkit [29706] by
-
- 3 edits in trunk/WebCore
Not reviewed. Yet another win/gtk build fix.
- 3:43 PM Changeset in webkit [29705] by
-
- 2 edits in trunk/WebCore
Not reviewed. Another build fix for Gtk/Linux & Wx/Mac.
- 3:26 PM Changeset in webkit [29704] by
-
- 4 edits in trunk/WebCore
Not reviewed. Build fix for Qt/Gtk & Wx.
- 3:16 PM Changeset in webkit [29703] by
-
- 3 edits in trunk/WebCore
Not reviewed. Build fix for ports that don't build SVG: wx.
- 3:12 PM Changeset in webkit [29702] by
-
- 2 edits in trunk/WebCore
Not reviewed. (First) Build fix for Qt/Gtk.
- 3:06 PM Changeset in webkit [29701] by
-
- 7 edits in trunk
2008-01-21 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16955
Get errors when cross-compile webkit-gtk
- 2:56 PM Changeset in webkit [29700] by
-
- 86 edits6 adds2 deletes in trunk
Reviewed by Eric. Older parts reviewed by Dan.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16880 (SVGCSSFontFace should die, instead integrate within the FontCache.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16784 (In-document fonts work only as the first child to font-face-src)
Proper integration of SVG Fonts within the existing custom font concept, removing the need for a custom SVGCSSFontFace.
Integrate within the CSSFontFaceSource logic for caching support, as well as the framework for external SVG Fonts.
Proper handling of missing glyphs, using <missing-glyph> element. If that is not specified in a font, fallback to non-SVG font rendering.
- 2:43 PM Changeset in webkit [29699] by
-
- 2 edits in trunk/WebKit/gtk
2008-01-21 Alp Toker <alp@atoker.com>
GTK+ build fix for breakage introduced in r29698.
- WebCoreSupport/ChromeClientGtk.h:
- 2:23 PM Changeset in webkit [29698] by
-
- 53 edits in trunk
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
- remove the default database quota setting
- simplify the quota-related client calls by merging the one for a new database with the one for an existing database, adding a feature where you can get details about a database being created using the same functions that work on the other databases, and removing the parameters and return values, instead having clients use a function to set the quota
- fix unsafe multi-thread access to the database tracker's quota map
- fix bug in deleteAllDatabases where it would iterate a HashMap while modifying it
The tracker database is now only created when we set the quota for a database origin.
Thus asking for info about databases won't cause anything to be written to disk.
- WebCore.base.exp: Updated.
- bindings/js/GCController.cpp: Added an #if to get rid of an unused function warning.
- page/Chrome.cpp: Removed database-related functions. There's no problem having the code deal directly with the client.
- page/Chrome.h: Ditto. Also made Chrome inherit from Noncopyable.
- page/ChromeClient.h: Replaced the two quota-related functions with a single one. The details about the state of databases in the origin are now available by asking for database details. There's also no need to pass the security origin, since it's easy to get that from the frame's document.
- page/Settings.cpp: Removed the default quota setting.
- page/Settings.h: Ditto.
- platform/FileSystem.h: Added deleteEmptyDirectory.
- platform/gtk/FileSystemGtk.cpp: (WebCore::deleteEmptyDirectory): Added.
- platform/posix/FileSystemPOSIX.cpp: (WebCore::deleteEmptyDirectory): Added.
- platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): Added.
- platform/win/FileSystemWin.cpp: (WebCore::deleteEmptyDirectory): Added.
- platform/wx/FileSystemWx.cpp: (WebCore::deleteEmptyDirectory): Added placeholder.
- storage/DatabaseDetails.h: Removed the isValid() function since its name is confusing -- we removed our other isValid() functions. For the few callers that need this, it's fine to just check name().isEmpty(). Made the member functions all const.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Removed m_defaultQuota initialization. Added m_proposedDatabase and m_thread. (WebCore::DatabaseTracker::setDatabaseDirectoryPath): Got rid of code that would open the tracker database here. This might slightly speed up launch time, since we won't do the I/O until we have to, and before we were actually creating an SQL database in this code that's run when we go to the first webpage. (WebCore::DatabaseTracker::trackerDatabasePath): Added. (WebCore::DatabaseTracker::openTrackerDatabase): Added a boolean parameter telling this function whether to create the database. Made this function safe to call if the database is already open. Also made the function fail quietly if the path has not been set yet. (WebCore::DatabaseTracker::canEstablishDatabase): Got rid of the call to the establishEntryForOrigin function. The origin is now put in the tracker database when the quota is set to a non-zero value. When judging if there's enough space for the new database, require at least one byte even if estimatedSize is 0, and check for overflow. Also added code here to populate the origins map, which guarantees it will be ready when the database uses it on another thread later. Also changed this to call the new ChromeClient function. (WebCore::DatabaseTracker::hasEntryForDatabase): Added code to open the tracker database, since that's no longer done by setDatabaseDirectoryPath. (WebCore::DatabaseTracker::originPath): Added. (WebCore::DatabaseTracker::fullPathForDatabase): Added code so that this will return a null string for the proposed database if called from within the ChromeClient function. Also switched from empty string to null string for the error cases. (WebCore::DatabaseTracker::populateOrigins): Added code to open the tracker database. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::detailsForNameAndOrigin): Ditto. Also added code that will return the details of the proposed database if called from within the ChromeClient function. This is how the client can learn of the display name and the estimated size of the new database. (WebCore::DatabaseTracker::setDatabaseDetails): Added code to open the tracker database. (WebCore::DatabaseTracker::quotaForOrigin): Made this code OK to call on a non-main thread by using m_quotaMapGuard to guard access to the map. Other code runs on the main thread only, and only functions that write to the map use the lock. (WebCore::DatabaseTracker::setQuota): Changed this function so it can insert the initial quota as well as updating an existing quota. Added locking since this function modifies the quota map. Added code to open the tracker database. Added an early exit if the quota is already correct, which is guarantees that if you set a quota to 0 it won't trigger creation of a tracker database. (WebCore::DatabaseTracker::addDatabase): Added code to open the tracker database. (WebCore::DatabaseTracker::deleteAllDatabases): Made a copy of the quota map before iterating it to find all the origins. This fixes a problem with the old code where it would modify the map while iterating it, which gives assertions in debug builds and unpredictable results. (WebCore::DatabaseTracker::deleteOrigin): Replaced deleteDatabasesWithOrigin with this function. Added code to open the tracker database if needed. Added code to delete the origin from the tracker database, and to close the tracker database and delete files and directories as needed if we are deleting the final origin. (WebCore::DatabaseTracker::deleteDatabase): Added code to open the tracker database if needed.
- storage/DatabaseTracker.h: Renamed databasePath to databaseDirectoryPath for clarity, including the data member, and the getter and setter functions. Replaced deleteDatabasesWithOrigin with deleteOrigin. Removed the functions dealing with default origin quota. There is no default any more; origins start with no quota and the client must set a quota. Added trackerDatabasePath and originPath helper functions. Added a boolean parameter to openTrackerDatabase to tell it whether to create the database or not. Removed the establishEntryForOrigin function. Renamed m_originQuotaMap to just m_quotaMap, and added m_quotaMapGuard. Added a QuotaMap typedef. Added m_proposedDatabase, which holds the origin and details for the current proposed database during the client callback function that must decide whether to grant quota. Added a m_thread data member for debugging use to assert if functions that can only be called on a single thread are misused.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Changed to call the new exceededDatabaseQuota function instead of the old one.
- svg/graphics/SVGImageEmptyClients.h: Updated for the change to ChromeClient.
WebKit/gtk:
Reviewed by John Sullivan.
- updated for changes to database functions
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
- WebCoreSupport/ChromeClientGtk.h:
- WebView/webkitprivate.cpp: (webkit_init):
WebKit/mac:
Reviewed by John Sullivan.
- fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
- add a missing export of WebDatabaseExpectedSizeKey
- implement deleteOrigin: and remove deleteDatabasesWithOrigin:
- Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null name instead of calling isValid(). (-[WebDatabaseManager deleteOrigin:]): Implemented. (WebKitInitializeDatabasesIfNecessary): Updated for name change.
- Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
- WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions we had before with a single one.
- WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
- WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
- WebView/WebPreferences.m: (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
- WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota:.
- WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate methods we had before with a single one.
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Removed the code to set the default database origin quota in WebCore::Settings based on WebPreferences.
- WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual types of parameters that the database UI delegate methods had before.
WebKit/qt:
Reviewed by John Sullivan.
- updated for changes to ChromeClient database functions
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::exceededDatabaseQuota):
- WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Reviewed by John Sullivan.
- fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
- fix incorrect value for WebDatabaseDisplayNameKey in header
- Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin. Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for WebDatabaseDisplayNameKey.
- Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
- Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions with a single one.
- WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions with a single one.
- WebChromeClient.h: Ditto.
- WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to detect a nonexistent database rather than using isValid. (WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic change too, but both have the same name). (WebDatabaseManager::deleteDatabase): Updated for name change. (WebKitSetWebDatabasesPathIfNecessary): Ditto.
- WebDatabaseManager.h: Updated for name changes.
- WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Removed the default for WebKitDefaultDatabaseQuotaKey.
- WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
- WebView.cpp: (WebView::notifyPreferencesChanged): Removed the code to set the default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.
WebKit/wx:
Reviewed by John Sullivan.
- updated for changes to ChromeClient database functions
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::exceededDatabaseQuota):
- WebKitSupport/ChromeClientWx.h:
- 1:52 PM Changeset in webkit [29697] by
-
- 1 edit4 adds in trunk/LayoutTests
Rubber stamped by Oliver.
Add missing layout test results.
- 1:19 PM Changeset in webkit [29696] by
-
- 3 edits4 adds in trunk
WebCore:
Fix a bug in layers where the positioned ancestor was being computed incorrectly (the root should not
automatically be included).
Reviewed by olliej
Added fast/layers/positioned-inside-root-with-margins.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor):
LayoutTests:
Reviewed by olliej
- fast/layers/positioned-inside-root-with-margins.html: Added.
- platform/mac/fast/layers/positioned-inside-root-with-margins-expected.checksum: Added.
- platform/mac/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
- platform/mac/fast/layers/positioned-inside-root-with-margins-expected.txt: Added.
- 11:00 AM Changeset in webkit [29695] by
-
- 2 edits in trunk/LayoutTests
Adding media/{audio,video}-controls-rendering.html back to the skipped list, since they're still failing on some machines.
- platform/win/Skipped:
- 8:59 AM Changeset in webkit [29694] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mitz and Adam.
- Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the sorting speed by doing all sort criteria in a single pass instead of three sorts.
- 3:37 AM QtWebKitContrib edited by
- (diff)
- 3:06 AM Changeset in webkit [29693] by
-
- 2 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Change QWebHistoryInterface::addHistoryEntry() from const to non-const
- 3:06 AM Changeset in webkit [29692] by
-
- 2 edits in trunk/WebKit/qt
Adam Treat <treat@kde.org>
- Don't leak the d-pointer in QWebSettings.
- 2:47 AM Changeset in webkit [29691] by
-
- 2 edits in trunk/WebKit/qt
Simon Hausmann <Simon Hausmann>
Update the WebKit version number from WebKit/win/WebKit.vcproj/VERSION.
This has the fortunate side-effect that gmail sends us sensible HTML/JS again :)
- 2:41 AM Changeset in webkit [29690] by
-
- 2 edits in trunk/WebCore
Fix KURL to QUrl conversion.
Stick to the encoded version of the URL and in addition to KURL we encode the
characters mentioned in section 2.4.3 of RFC 2396 as QUrl requires these, too.
This fixes fast/css/import-rule-regression-11590.html,
fast/css/import-style-update.html, svg/hixie/processing-model/003.xml and
svg/hixie/processing-model/004.xml.
- 2:40 AM Changeset in webkit [29689] by
-
- 10 edits in trunk
Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
- Fix GraphicsContext::drawFocusRing to also draw single focus rects.
- Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events and make the return value depend on whether we successfully determined a focusable node or not.
- Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly if we could not handle the focus chain ourselves.
- Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
- Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only used to control the situation of stepping out of the focus chain inside the page.
- Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain. The layout tests expect this to be disabled but for the user it seems sensible to have it on by default, hence the default in qwebsettings.cpp
- 2:40 AM Changeset in webkit [29688] by
-
- 2 edits in trunk/WebCore
Fix access key support and fast/forms/legend-access-key.html
SVN revision 26664 changed the default access key for the non-mac build to Alt
while this test relies on Ctrl.
- 2:39 AM Changeset in webkit [29687] by
-
- 2 edits in trunk/WebCore
Fix error reporting when parsing X(HT)ML fragments.
We use the regular XMLTokenizer write()/.../end() sequence to parse those
fragments, but we should not report any parsing errors inline inside the
content. Instead we should just return the error and the DOM layer will take
care of throwing an exception.
This fixes fast/innerHTML/innerHTML-changing-document-properties.xhtml
- 1:10 AM Changeset in webkit [29686] by
-
- 2 edits in trunk/WebCore
Holger Freyther <holger.freyther@trolltech.com>
Fix some issues with redirections.
- Ensure that we deliver the response to the ResourceHandleClient only once by setting m_responseSent back to false only before calling start() for the redirection
- Added 307 as another HTTP status code that causes a redirection after POST to become get, just like in MainResourceLoader::isPostOrRedirectAfterPost
- Also set the HTTP method on the ResourceRequest to GET before passing it to willSendRequest.
- willSendRequest's newRequest argument is actually an in/out argument and could be modified in theory, so set m_request accordingly after the call.
- 1:09 AM Changeset in webkit [29685] by
-
- 2 edits in trunk/WebCore
Holger Freyther <holger.freyther@trolltech.com>
Fixed WebCore::cookies() to return all cookies, not only the first one.
Fixes login into mail.yahoo.com.
- 1:01 AM Changeset in webkit [29684] by
-
- 3 edits in trunk/LayoutTests
Try to make the test less timing dependent to fix occasional test bot failures.
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- 12:36 AM Mobile edited by
- (diff)
Jan 20, 2008:
- 11:07 PM Changeset in webkit [29683] by
-
- 2 edits in trunk/WebKit/gtk
2008-01-20 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.
- WebView/webkitwebview.cpp:
- 9:34 PM Changeset in webkit [29682] by
-
- 4 edits in trunk/WebKit
Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.
Reviewed by Dan Bernstein.
- WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
- mac/WebView/WebView.mm:
(+[WebView initialize]):
- 8:30 PM Changeset in webkit [29681] by
-
- 2 edits in trunk/WebCore
Fix http://bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/5682985
Reviewed by Mitz
Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.
- 8:04 PM Changeset in webkit [29680] by
-
- 2 edits in trunk/LayoutTests
- update Tiger-specific results for r29667
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- 6:01 PM Changeset in webkit [29679] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Assertion failure in FrameView::scheduleRelayout (!m_frame->document() !m_frame->document()->inPageCache()) when going back from a page with a focused popup - dom/Document.cpp: (WebCore::Document::setFocusedNode): Bail out if the document is in the page cache. Documents in the back/forward cache are "frozen" and should not change state.
- 3:18 PM Changeset in webkit [29678] by
-
- 3 edits10 adds in trunk
WebCore:
Reviewed by Sam Weinig.
We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.
Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html
http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
LayoutTests:
Reviewed by Sam Weinig.
- http/tests/security/postMessage: Added.
- http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
- http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
- http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
- http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
- http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
- http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
- http/tests/security/postMessage/resources: Added.
- http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
- http/tests/security/postMessage/resources/post-message-listener.html: Added.
- 1:22 PM Changeset in webkit [29677] by
-
- 5 edits in trunk
WebCore:
Reviewed by Adele.
Fix <rdar://problem/5695451>
Middle part of the media timeline missing on Windows if load failed
Add some null checking to avoid getting garbage results from the functions.
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::duration): (QTMovieWin::currentTime): (QTMovieWin::setCurrentTime): (QTMovieWin::maxTimeLoaded):
LayoutTests:
Reviewed by Adele.
Update test so it checks the state of time related properties after the failure.
- media/video-error-does-not-exist-expected.txt:
- media/video-error-does-not-exist.html:
Jan 19, 2008:
- 8:53 PM Changeset in webkit [29676] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix 'Reviewed by' typo in ChangeLog
- 8:49 PM Changeset in webkit [29675] by
-
- 2 edits in trunk/WebCore
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor
http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice
Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.
- platform/graphics/gtk/VideoSinkGStreamer.cpp:
- 8:25 PM WikiStart edited by
- Remove spam (diff)
- 10:51 AM Changeset in webkit [29674] by
-
- 2 edits in trunk/WebKitTools
Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.
Reviewed by Alp Toker.
- Scripts/run-webkit-tests:
- 10:34 AM Changeset in webkit [29673] by
-
- 2 edits in trunk/WebCore
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 10:27 AM Changeset in webkit [29672] by
-
- 272 edits in trunk
Set svn:eol-style=native on .idl and .c files that were missed in r29663.
- 10:10 AM Changeset in webkit [29671] by
-
- 9 edits in trunk/WebKit/win
2008-01-19 Mark Rowe <mrowe@apple.com>
Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.
- Interfaces/IGEN_DOMObject.idl:
- 7:46 AM Changeset in webkit [29670] by
-
- 4 edits in trunk
2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Add svg foreign object and svg experimental to the GTK+/autotools
build system.
- 5:58 AM Changeset in webkit [29669] by
-
- 2 edits in trunk/WebKit/gtk
2008-01-19 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete
Implement these functions.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
- 2:43 AM Changeset in webkit [29668] by
-
- 2 edits in trunk/WebKitTools
<rdar://problem/5695344> check-for-global-initializers script never checks any object files
Reviewed by Darin.
We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.
Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!
Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.
- Scripts/check-for-global-initializers:
- 2:12 AM Changeset in webkit [29667] by
-
- 21 edits5 adds in trunk
WebCore:
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
Test: editing/selection/inconsistent-in-removeChildNode.html
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.
LayoutTests:
Reviewed by Maciej Stachowiak.
- test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
- editing/selection/inconsistent-in-removeChildNode.html: Added.
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac-leopard/editing/selection: Added.
- platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
- platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
- platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
- platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/execCommand/find-after-replace-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
- platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/mac/editing/selection/replace-selection-1-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-expected.txt:
- platform/mac/editing/style/remove-underline-in-bold-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 1:43 AM Changeset in webkit [29666] by
-
- 2 edits in trunk/WebCore
Build fix for --svg-foreign-object path
Reviewed by Eric Seidel
