⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 6, 2008:

11:14 PM Changeset in webkit [35031] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Rename "Access-Contol-Origin" to "Origin" to match the latest
Access Control for Cross-Site Request draft. (Editor's Draft 25 May 2008)

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):

LayoutTests:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Rename "Access-Contol-Origin" to "Origin" to match the latest
Access Control for Cross-Site Request draft. (Editor's Draft 25 May 2008)

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-expected.txt:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
9:17 PM Changeset in webkit [35030] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • WebCore.vcproj/WebCore.vcproj:
8:10 PM Changeset in webkit [35029] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • add missing brace
  • platform/graphics/qt/FontCacheQt.cpp:
8:08 PM Changeset in webkit [35028] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the Qt build
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::addClient): (WebCore::FontCache::removeClient):
7:49 PM Changeset in webkit [35027] by weinig@apple.com
  • 71 edits in trunk

JavaScriptCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Second step in broad cleanup effort.

[ File list elided ]

WebCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Add #include for kjs/protect.h.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
7:40 PM Changeset in webkit [35026] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Save a few more bits in RenderStyle

Reviewed by Darin.

No test cases added since there is no change in behavior.

This changes WebCore::StyleMarqueeData from using 6 bits to 5 bits,
WebCore::RenderStyle::inherited_flags from using 36 bits to 35 bits,
and WebCore::RenderStyle::noninherited_flags from using 49 bits to
47 bits.

  • rendering/style/RenderStyle.h: (WebCore::StyleMarqueeData::behavior): Reduce from 3 bits to 2 bits since EMarqueeBehavior has 4 items. (WebCore::RenderStyle::inherited_flags._text_align): Reduce from 4 bits to 3 bits since ETextAlign has 8 items. (WebCore::RenderStyle::noninherited_flags._overflowX): Reduce from 4 bits to 3 bits since EOverflow has 6 items. (WebCore::RenderStyle::noninherited_flags._overflowY): Ditto.
5:00 PM Changeset in webkit [35025] by mitz@apple.com
  • 11 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5735163> WebCore caching makes text look wrong after font changes; need to respond appropriately instead
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): Added a call to FontCache::addClient(). (WebCore::CSSFontSelector::~CSSFontSelector): Added a call to FontCache::removeClient(). (WebCore::CSSFontSelector::fontCacheInvalidated): Added. Called by the font cache when it is invalidated, and ensures that the document is updated.
  • css/CSSFontSelector.h:
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Added code to compare the font fallback lists' font cache generations.
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::addClient): Added. (WebCore::FontCache::removeClient): Added. (WebCore::FontCache::generation): Added. (WebCore::FontCache::invalidate): Added. Deletes the platform data cache, increments the generation counter, and notifies all clients.
  • platform/graphics/FontCache.h:
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): Added initialization of m_generation. (WebCore::FontFallbackList::invalidate): Added code to reset m_generation. (WebCore::FontFallbackList::fontDataAt): Added an assertion. (WebCore::FontFallbackList::fontDataForCharacters): Ditto. (WebCore::FontFallbackList::setPlatformFont): Ditto.
  • platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::generation): Added. Returns the font cache generation used to populate the list.
  • platform/graphics/FontSelector.h: (WebCore::FontSelector::fontCacheInvalidated): Added.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheATSNotificationCallback): Added. Calls FontCache::invalidate(). (WebCore::FontCache::platformInit): Added code to register for ATS notifications.
  • svg/SVGFontFaceElement.cpp: Removed unneeded #inlcudes.

Jul 5, 2008:

10:35 PM Changeset in webkit [35024] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/WebKit

Remove WebSearchableTextView as it has been unused for some time now.

Reviewed by John Sullivan.

10:35 PM Changeset in webkit [35023] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.

Reviewed by John Sullivan.

10:26 PM Changeset in webkit [35022] by weinig@apple.com
  • 43 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

First step in broad cleanup effort.

[ File list elided ]

5:10 PM Changeset in webkit [35021] by weinig@apple.com
  • 17 edits
    3 moves in trunk

JavaScriptCore:

2008-07-05 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Rename list.h/cpp to ArgList.h/cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.h:
  • kjs/AllInOneFile.cpp:
  • kjs/ArgList.cpp: Copied from JavaScriptCore/kjs/list.cpp.
  • kjs/ArgList.h: Copied from JavaScriptCore/kjs/list.h.
  • kjs/IndexToNameMap.cpp:
  • kjs/JSGlobalData.cpp:
  • kjs/JSGlobalData.h:
  • kjs/JSObject.h:
  • kjs/collector.cpp:
  • kjs/list.cpp: Removed.
  • kjs/list.h: Removed.

WebCore:

2008-07-05 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Rename list.h/cpp to ArgList.h/cpp.

  • ForwardingHeaders/kjs/ArgList.h: Copied from WebCore/ForwardingHeaders/kjs/list.h.
  • ForwardingHeaders/kjs/list.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/qt/qt_instance.cpp:
  • page/Console.cpp:
4:40 PM Changeset in webkit [35020] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds again.

  • kjs/BooleanPrototype.cpp:
  • kjs/ErrorPrototype.cpp:
  • kjs/FunctionPrototype.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/ObjectPrototype.cpp:
4:36 PM Changeset in webkit [35019] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <​sam@webkit.org>

Fix build on case-sensitive build systems.

  • kjs/IndexToNameMap.cpp:
4:32 PM Changeset in webkit [35018] by weinig@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <​sam@webkit.org>

Fix build.

  • kjs/Arguments.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/ErrorPrototype.cpp:
  • kjs/FunctionPrototype.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/ObjectPrototype.cpp:
  • kjs/RegExpPrototype.cpp:
  • kjs/StringConstructor.cpp:
  • kjs/lookup.cpp:
4:26 PM Changeset in webkit [35017] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne build.

  • kjs/JSGlobalObject.cpp:
4:19 PM Changeset in webkit [35016] by weinig@apple.com
  • 17 edits
    10 copies
    1 add in trunk

JavaScriptCore:

2008-07-05 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Split Arguments, IndexToNameMap, PrototypeFunction, GlobalEvalFunction and
the functions on the global object out of JSFunction.h/cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/Arguments.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/Arguments.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/GlobalEvalFunction.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/GlobalEvalFunction.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/IndexToNameMap.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/IndexToNameMap.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/JSActivation.cpp:
  • kjs/JSFunction.cpp:
  • kjs/JSFunction.h:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObjectFunctions.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/JSGlobalObjectFunctions.h: Copied from JavaScriptCore/kjs/JSFunction.h. The functions on the global object should be in JSGlobalObject.cpp, but putting them there was a 0.5% regression.
  • kjs/PrototypeFunction.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/PrototypeFunction.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/Shell.cpp:
  • kjs/lexer.cpp:
  • kjs/ustring.cpp:

WebCore:

2008-07-05 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Split Arguments, IndexToNameMap, PrototypeFunction, GlobalEvalFunction and
the functions on the global object out of JSFunction.h/cpp.

  • ForwardingHeaders/kjs/PrototypeFunction.h: Added.
  • bindings/js/JSDOMBinding.cpp:
1:44 PM Changeset in webkit [35015] by mitz@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • rename BidiIterator and BidiState

Renamed BidiIterator to InlineIterator and BidiState
to InlineBidiResolver. Renamed variables of type InlineBidiResolver{*,&}
to "resolver".

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::InlineIterator::InlineIterator): (WebCore::operator==): (WebCore::operator!=): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::increment): (WebCore::InlineIterator::atEnd): (WebCore::InlineIterator::current): (WebCore::InlineIterator::direction): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::InlineBidiResolver::appendRun): (WebCore::RenderBlock::bidiReorderLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
10:57 AM Changeset in webkit [35014] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog entry for r35006.

3:35 AM Changeset in webkit [35013] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-05 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Oliver Hunt

Coding style fix

  • html/CanvasRenderingContext2D.cpp: Indentation fix

Jul 4, 2008:

11:44 PM Changeset in webkit [35012] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix windows build

11:18 PM Changeset in webkit [35011] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <​sam@webkit.org>

Really fix the mac build.

10:59 PM Changeset in webkit [35010] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-04 Sam Weinig <​sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_instance.cpp:
10:47 PM Changeset in webkit [35009] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <​sam@webkit.org>

Fix mac build.

10:44 PM Changeset in webkit [35008] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/Error.cpp:
  • kjs/GetterSetter.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/operations.cpp:
10:35 PM Changeset in webkit [35007] by weinig@apple.com
  • 31 edits
    4 copies
    1 add in trunk

JavaScriptCore:

2008-07-04 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • API/JSCallbackObjectFunctions.h:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ClassInfo.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/Error.cpp: Copied from JavaScriptCore/kjs/JSObject.cpp.
  • kjs/Error.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/GetterSetter.cpp:
  • kjs/GetterSetter.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/nodes.h:

JavaScriptGlue:

2008-07-04 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Dan Bernstein.

  • JSObject.h: Rename the header guard as it now conflicts with the JSObject in JavaScriptCore.

WebCore:

2008-07-04 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • ForwardingHeaders/kjs/Error.h: Added.
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSEventTargetBase.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_runtime.cpp:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:
9:51 PM Changeset in webkit [35006] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<​https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

Tests: webarchive/archive-empty-frame-dom-expected.txt

webarchive/doctype.html

  • editing/markup.cpp: (WebCore::createFullMarkup): If the Node is a Document or a DocumentType, don't prepend the <!DOCTYPE> tag since that will cause it to be duplicated.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.

LayoutTests:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<​https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

  • webarchive/archive-empty-frame-dom-expected.txt: Updated test results now that we don't emit two <!DOCTYPE> tags.
  • webarchive/doctype-expected.txt: Added.
  • webarchive/doctype.html: Added.
9:34 PM Changeset in webkit [35005] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-04 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix

  • GNUmakefile.am:
3:43 PM Changeset in webkit [35004] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-07-04 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Eric Seidel.

Bring our implementation of the Netscape plugin API closer to current
code style guidelines.

  • bridge/NP_jsobject.cpp: (getListFromVariantArgs): (jsAllocate): (jsDeallocate): (_NPN_CreateScriptObject): (_NPN_CreateNoScriptObject): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_Enumerate):
  • bridge/npruntime_impl.h:
5:04 AM Changeset in webkit [35003] by Simon Hausmann
  • 5 edits in trunk/WebCore

Fix the Qt/Windows build.

4:37 AM Changeset in webkit [35002] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Mac build for real, don't define listDirectory() twice.

3:55 AM Changeset in webkit [35001] by Simon Hausmann
  • 3 edits in trunk/WebCore

Prospective Mac build fix.

3:41 AM Changeset in webkit [35000] by Simon Hausmann
  • 5 edits
    3 deletes in trunk/WebCore

2008-07-04 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Move duplicated code from each PluginDatabaseXX-implementation
to PluginDabase.cpp -- ifdefed based on the XP_PLATFORM we are
compiling plugins for.

This make the code cleaner and we can share common patterns.
The only implementation left which is specific is the Win
implementation (also used by QtWebKit/Win), but we might
want to move that too.

3:41 AM Changeset in webkit [34999] by Simon Hausmann
  • 7 edits in trunk/WebCore/platform

2008-06-25 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Add an abstraction for listing files in a directory to FileSystem.h.

Currently this is only implemented for the Qt and GTK port. The other
ports have a default implementations which call notImplemented().

3:10 AM Changeset in webkit [34998] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-04 Benjamin C Meyer <​ben@meyerhome.net>

Reviewed by Simon.

Update the webkit version in the QtWebKit useragent string to match trunk

1:28 AM Changeset in webkit [34997] by Simon Hausmann
  • 5 edits in trunk

Fix the Wx build

12:46 AM Changeset in webkit [34996] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Gtk build, adapt to renamed files.

12:37 AM Changeset in webkit [34995] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build, adapt to renamed files.

12:25 AM Changeset in webkit [34994] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix output path of recently-added script phase to reference the correct file.
This prevents Xcode from running the script phase unnecessarily, which caused
the generated header to be recreated and lead to AllInOneFile.cpp rebuilding.

Reviewed by Oliver Hunt.

Jul 3, 2008:

10:21 PM Changeset in webkit [34993] by oliver@apple.com
  • 8 edits
    8 moves
    1 add in trunk/WebCore

Move filter implementations to platform directory.

Reviewed by Eric Seidel

6:10 PM Changeset in webkit [34992] by oliver@apple.com
  • 19 edits
    3 deletes in trunk/WebCore

2008-07-03 Alex Mathews <​possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Bug 19835: WebKit needs cross-platform filter system
<​https://bugs.webkit.org/show_bug.cgi?id=19835>

More class refactoring in preparation for cross-platform filter
implementation.

5:06 PM Changeset in webkit [34991] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Follow-up to the 64-bit build fix. Use intptr_t rather than ssize_t as the latter is non-standard and does not exist on Windows.

4:22 PM Changeset in webkit [34990] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix the 64-bit build.

2:37 PM Changeset in webkit [34989] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/6020930> Bidi Problem When Resizing Window

Test: fast/text/international/bidi-AN-after-empty-run.html

  • platform/text/BidiResolver.h: (WebCore::::appendRun): Changed to reset the current direction and "end of run" direction even in the empty run case.
  • rendering/bidi.cpp: (WebCore::BidiState::appendRun): Ditto.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/6020930> Bidi Problem When Resizing Window
  • fast/text/international/bidi-AN-after-empty-run.html: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
1:52 PM Changeset in webkit [34988] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk

<rdar://5983747> Safari crashes trying to load the SilverLight plugin

If a plug-in returned an error code from NPP_NewStream, we would call
NPP_DestroyStream while cleaning up the request. We now only call
NPP_DestroyStream if NPP_NewStream was successful, matching Firefox.

Reviewed by Anders.

12:35 PM Changeset in webkit [34987] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-07-03 David Hyatt <​hyatt@apple.com>

Revise Dan's fix for an assert on Windows, since layoutIfNeededRecursive doesn't exist on the
Mac. Revert updateControlTints and add the layout call outside of it in the already-existing
!PLATFORM(MAC) ifdef in FocusController's setActive method.

Reviewed by ggaren, weinig

  • page/FocusController.cpp: (WebCore::FocusController::setActive):
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints):
12:13 PM Changeset in webkit [34986] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19884
Locating a store at www.366.ru doesn't work

Test: fast/forms/submit-with-base.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Treat empty action the same as missing one - ignore base URL.
12:06 PM Changeset in webkit [34985] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Removed checking for the array get/put fast case from the array code.
Callers who want the fast case should call getIndex and/or setIndex
instead. (get_by_val and put_by_val already do this.)


SunSpider reports no change overall, but a 1.4% speedup on fannkuch and
a 3.6% speedup on nsieve.

11:51 AM Changeset in webkit [34984] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6048904> Assert in WebCore::Frame::paint in Windows
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Changed to update layout recursively and not just for the top-level frame.
11:26 AM Changeset in webkit [34983] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

11:13 AM Changeset in webkit [34982] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-07-03 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff.

Bug 19853: REGRESSION (r34838): Crash when visiting ​http://www.thewebsiteisdown.com/salesguy.html
​https://bugs.webkit.org/show_bug.cgi?id=19853

Remove the body of _NPN_SetException(), because it was simply calling
throwError(), which sets an exception on an ExecState but does not
actually handle it. The presence of an exception on the global ExecState
causes assertions that there is no exception set on that ExecState to
fail, as well as causing Machine::execute() to mistakingly return 0 in
some cases, as it assumes the presence of an exception implies that it
has run out of memory.

  • bridge/NP_jsobject.cpp: (_NPN_SetException):
10:57 AM Changeset in webkit [34981] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

  • Windows build fix
  • VM/Machine.cpp: (KJS::Machine::Machine):
6:01 AM Changeset in webkit [34980] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-03 Maciej Katafiasz <​mathrick@gmail.com>

Gtk build fix with SVG filters enabled

  • GNUmakefile.am: Include missing SVG filter sources
1:06 AM Changeset in webkit [34979] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-03 Simon Hausmann <Simon Hausmann>

Reviewed by Alexey Proskuryakov.

Fix the non-threaded build.

12:54 AM Changeset in webkit [34978] by Simon Hausmann
  • 4 edits in trunk

Fix the Qt build

12:44 AM Changeset in webkit [34977] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Don't create unnecessary JSGlobalData instances.

  • kjs/JSGlobalData.h:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::threadInstanceExists): (KJS::JSGlobalData::sharedInstanceExists): (KJS::JSGlobalData::threadInstance): (KJS::JSGlobalData::sharedInstance): (KJS::JSGlobalData::threadInstanceInternal): (KJS::JSGlobalData::sharedInstanceInternal): Added methods to query instance existence.
  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce): Initialize thread instance static in a new way.
  • API/JSBase.cpp: (JSGarbageCollect):
  • kjs/collector.cpp: (KJS::Heap::collect): Check for instance existence before accessing it.
12:10 AM Changeset in webkit [34976] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-07-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.


Updated this test result to match our new, smaller recursion limit.
With the new limit, an exception is thrown on entry to the document.write
script, which is why you see an exception logged to the console, instead
of caught inside the script.

  • fast/js/global-recursion-on-full-stack-expected.txt:
Note: See TracTimeline for information about the timeline view.