Timeline
Feb 3, 2009:
- 10:58 PM WebCoreRendering created by
- 10:55 PM WikiStart edited by
- (diff)
- 9:24 PM Changeset in webkit [40607] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6554092> Slow script dialog starts coming up over and over again
Reviewed by John Sullivan.
Work around <rdar://problem/6554067> by consuming any exceptions that are
thrown by _web_localizedDescription
- 9:06 PM Changeset in webkit [40606] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.
Reviewed by Mark Rowe
- dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
- 8:59 PM Changeset in webkit [40605] by
-
- 4 edits3 adds in trunk
2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.
- 8:26 PM Changeset in webkit [40604] by
-
- 2 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.
Reviewed by Mark Rowe
- rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::bidiNext):
- 8:24 PM Changeset in webkit [40603] by
-
- 1 edit in branches/Safari-6528/WebKit/win/WebHistoryItem.cpp
Merge r40394.
- 8:24 PM Changeset in webkit [40602] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40392.
- 8:23 PM Changeset in webkit [40601] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40529.
- 8:23 PM Changeset in webkit [40600] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40528.
- 8:23 PM Changeset in webkit [40599] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40516.
- 8:23 PM Changeset in webkit [40598] by
-
- 4 edits in branches/Safari-6528
Merge r40514.
- 8:23 PM Changeset in webkit [40597] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40511.
- 8:23 PM Changeset in webkit [40596] by
-
- 37 edits in branches/Safari-6528
Merge r40508.
- 8:23 PM Changeset in webkit [40595] by
-
- 7 edits in branches/Safari-6528/WebKit/win
Merge r40503.
- 8:23 PM Changeset in webkit [40594] by
-
- 7 edits in branches/Safari-6528/WebKit
Merge r40382.
- 8:23 PM Changeset in webkit [40593] by
-
- 10 edits in branches/Safari-6528
Merge r40380.
- 8:23 PM Changeset in webkit [40592] by
-
- 9 edits in branches/Safari-6528/WebKit
Merge r40436.
- 8:23 PM Changeset in webkit [40591] by
-
- 16 edits in branches/Safari-6528
Merge r40432.
- 8:23 PM Changeset in webkit [40590] by
-
- 10 edits55 adds in branches/Safari-6528
Merge r40424.
- 8:22 PM Changeset in webkit [40589] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40376.
- 8:22 PM Changeset in webkit [40588] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40373.
- 8:22 PM Changeset in webkit [40587] by
-
- 9 edits in branches/Safari-6528
Merge r40353.
- 8:22 PM Changeset in webkit [40586] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40558.
- 8:22 PM Changeset in webkit [40585] by
-
- 3 edits3 adds in branches/Safari-6528
Merge r40541.
- 8:22 PM Changeset in webkit [40584] by
-
- 3 edits3 adds in branches/Safari-6528
Merge r40522.
- 8:22 PM Changeset in webkit [40583] by
-
- 5 edits in branches/Safari-6528/WebCore
Merge r40472.
- 8:22 PM Changeset in webkit [40582] by
-
- 2 edits in branches/Safari-6528/WebKitLibraries
Merge r40448.
- 8:22 PM Changeset in webkit [40581] by
-
- 6 edits in branches/Safari-6528
Merge r40397.
- 8:22 PM Changeset in webkit [40580] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40396.
- 8:22 PM Changeset in webkit [40579] by
-
- 5 edits2 copies5 adds in branches/Safari-6528
Merge r40368.
- 8:22 PM Changeset in webkit [40578] by
-
- 11 edits in branches/Safari-6528
Merge r40366.
- 8:21 PM Changeset in webkit [40577] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40358.
- 8:21 PM Changeset in webkit [40576] by
-
- 3 edits7 adds in branches/Safari-6528
Merge r40356.
- 8:21 PM Changeset in webkit [40575] by
-
- 6 edits1 copy2 adds in branches/Safari-6528
Merge r40355.
- 8:21 PM Changeset in webkit [40574] by
-
- 24 edits in branches/Safari-6528
Merge r40354.
- 8:21 PM Changeset in webkit [40573] by
-
- 4 edits in branches/Safari-6528
Merge r40345.
- 8:21 PM Changeset in webkit [40572] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40343.
- 8:21 PM Changeset in webkit [40571] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40339.
- 8:21 PM Changeset in webkit [40570] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40335.
- 8:21 PM Changeset in webkit [40569] by
-
- 13 edits3 adds in branches/Safari-6528
Merge r40332.
- 8:21 PM Changeset in webkit [40568] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40313.
- 8:21 PM Changeset in webkit [40567] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40305.
- 8:20 PM Changeset in webkit [40566] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40304.
- 6:45 PM Changeset in webkit [40565] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typo in Changelog
- 6:41 PM Changeset in webkit [40564] by
-
- 19 edits1 add in trunk/WebCore
2009-02-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.
RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
- 6:06 PM Changeset in webkit [40563] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
Reviewed by Darin Adler & Sam Weinig
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 6:02 PM Changeset in webkit [40562] by
-
- 10 edits in trunk/JavaScriptCore
2009-02-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:
jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32
Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).
This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branchPtrWithPatch): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchTest32): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchAdd32): (JSC::MacroAssembler::branchMul32): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchSub32): (JSC::MacroAssembler::set32): (JSC::MacroAssembler::setTest32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::jccRel32): (JSC::X86Assembler::setccOpcode): (JSC::X86Assembler::cmpq_mr): (JSC::X86Assembler::setcc_r): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::jne): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::jcc): (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference):
- 5:52 PM Changeset in webkit [40561] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-03 David Hyatt <hyatt@apple.com>
Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.
Reviewed by Maciej
- wtf/Vector.h: (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::allocateBuffer):
- 5:18 PM Changeset in webkit [40560] by
-
- 6 edits2 adds in trunk
WebCore:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::clear):
- editing/Editor.h: (WebCore::Editor::setShouldStyleWithCSS): (WebCore::Editor::shouldStyleWithCSS):
- editing/EditorCommand.cpp: (WebCore::executeStyleWithCSS): (WebCore::stateStyleWithCSS): (WebCore::CommandEntry::):
LayoutTests:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
- editing/execCommand/5685604-1-expected.txt: Added.
- editing/execCommand/5685604-1.html: Added.
- 5:05 PM Changeset in webkit [40559] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig.
This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
- 4:55 PM Changeset in webkit [40558] by
-
- 2 edits in trunk/WebCore
2009-02-03 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
- Fix for <rdar://problem/6549743>
On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- 4:46 PM Changeset in webkit [40557] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
ChangeLog date fix.
- 4:39 PM Changeset in webkit [40556] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Darin Adler.
Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).
- 4:31 PM Changeset in webkit [40555] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Back this change out since it is causing layout tests to crash. There is something subtle going on
here.
Reviewed by Darin Adler
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 3:57 PM Changeset in webkit [40554] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
Reviewed by Sam Weinig
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 3:56 PM Changeset in webkit [40553] by
-
- 5 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
Reviewed by Darin Adler
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- platform/KURL.cpp: (WebCore::KURL::invalidate): (WebCore::KURL::KURL):
- platform/KURL.h: (WebCore::KURL::isHTTPOrHTTPS):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::setAllowHTTPCookies):
- 3:53 PM Changeset in webkit [40552] by
-
- 3 edits in trunk/LayoutTests
Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.
- 3:25 PM Changeset in webkit [40551] by
-
- 1 edit2 adds in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Add manual test for floating divs with scrollbars.
- manual-tests/gtk/floatingdiv.html: Added.
- 3:25 PM Changeset in webkit [40550] by
-
- 3 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.
Also do not disconnect the signals when destroying the widget,
it's superfluous.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk):
- 3:25 PM Changeset in webkit [40549] by
-
- 2 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Declare scrollBar as GtkWidget* to avoid needless
casting.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk):
- 3:25 PM Changeset in webkit [40548] by
-
- 2 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Properly calculate the scrollbar location for their
usage in RenderLayout.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
- 2:14 PM Changeset in webkit [40547] by
-
- 10 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
of these methods up to RenderObject.
Reviewed by Beth Dakin
- bindings/objc/DOM.mm: (-[DOMNode lineBoxRects]):
- dom/Range.cpp: (WebCore::Range::addLineBoxRects):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
- rendering/RenderObject.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuadsForRange):
- rendering/RenderText.h:
- 1:26 PM Changeset in webkit [40546] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig and Oliver Hunt.
Added getImageData() support for QtWebKit.
[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
- 1:00 PM Changeset in webkit [40545] by
-
- 2 edits in trunk/WebCore
2009-02-03 Eric Roman <eroman@chromium.org>
Reviewed by Holger Freyther.
Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.
- page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
- 12:43 PM Changeset in webkit [40544] by
-
- 3 edits in trunk/WebCore
2009-02-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Hook accelerated compositing into RenderLayer.
- 12:14 PM Changeset in webkit [40543] by
-
- 19 edits in trunk
2009-02-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Hook up accelerated compositing layers the native
view system on Mac.
- 11:51 AM Changeset in webkit [40542] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Hans Peter Freyther.
Fixed getImageData and putImageData and respect pre-
multiplied colors.
Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
https://bugs.webkit.org/show_bug.cgi?id=21575
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
- 11:49 AM Changeset in webkit [40541] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Brady Eidson.
- fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
Test: fast/history/window-open.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the missing lockBackForwardList parameter to FrameLoader::changeLocation().
LayoutTests:
Reviewed by Brady Eidson.
- test for <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
- fast/history/window-open-expected.txt: Added.
- fast/history/window-open.html: Added.
- 11:40 AM Changeset in webkit [40540] by
-
- 4 edits in trunk/WebKit/gtk
2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22988
[GTK] Need a public method to add a WebKitWebHistoryItem to
WebKitWebBackForwardList.
Wrap WebCore::BackForwardList::addItem.
- tests/main.c: (test_webkit_web_back_forward_list_add_item): (main):
- webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
- webkit/webkitwebbackforwardlist.h:
- 9:46 AM Changeset in webkit [40539] by
-
- 2 edits in trunk/WebCore
2009-02-03 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build after r40536.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
- 9:41 AM Changeset in webkit [40538] by
-
- 2 edits in trunk/WebCore
- fix -Wmissing-prototypes builds
- loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidSendData): Marked this function static. (WebCore::workerContextDidReceiveResponse): Ditto. (WebCore::workerContextDidReceiveData): Ditto. (WebCore::workerContextDidFinishLoading): Ditto. (WebCore::workerContextDidFail): Ditto. (WebCore::workerContextDidGetCancelled): Ditto. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
- 9:29 AM Changeset in webkit [40537] by
-
- 2 edits in trunk/WebCore
CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
<rdar://problem/6509514>
Reviewed by Adam Roben.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Null check the value returned from WebCore::IconDatabase::iconForPageURL().
- 8:10 AM Changeset in webkit [40536] by
-
- 6 edits in trunk
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added accessor for JSByteArray storage.
WebCore:
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix conversion of QByteArray to JavaScript and back. Instead of
converting it to a String (data loss!) we now map it to JSByteArray.
WebKit/qt:
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added a unit test to verify the succesful conversion from QByteArray to
JSByteArray and back to QByteArray.
- 7:44 AM Changeset in webkit [40535] by
-
- 2 edits in trunk/WebCore
Build fix.
- GNUmakefile.am: Removed WorkerTask.{h,cpp}.
- 2:32 AM Changeset in webkit [40534] by
-
- 11 edits3 adds in trunk
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22718
Implement WindowTimers interface in Workers.
This patch moves timeoutID from Document to ScriptExecutionContext
and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
Also added a test for those methods.
Test: fast/workers/worker-timeout.html
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::setTimeoutOrInterval): Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::clearTimeout):
(WebCore::JSWorkerContext::setInterval):
(WebCore::JSWorkerContext::clearInterval):
Added methods exposed to JS.
- dom/Document.cpp:
- dom/Document.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addTimeout): (WebCore::ScriptExecutionContext::removeTimeout): (WebCore::ScriptExecutionContext::findTimeout):
- dom/ScriptExecutionContext.h: The timerID map moves from Document to ScriptExecutionContext, to be available to Document and to WorkerContext.
- dom/WorkerContext.cpp: (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
- dom/WorkerContext.h:
- page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::removeById): Code change here reflects move of timeoutID map to the ScriptExecutionContext. Some checks and casts are no longer needed.
- 1:18 AM Changeset in webkit [40533] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer on WorkerRunLoop
- JavaScriptCore.exp: Forgot to expose ThreadCondition::timedWait() in one of previous patches.
- 1:11 AM Changeset in webkit [40532] by
-
- 3 edits in trunk/WebCore
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer for Workers.
- dom/WorkerRunLoop.cpp: Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads. (WebCore::WorkerSharedTimer::WorkerSharedTimer): (WebCore::WorkerSharedTimer::setFiredFunction): (WebCore::WorkerSharedTimer::setFireTime): (WebCore::WorkerSharedTimer::stop): (WebCore::WorkerSharedTimer::isActive): (WebCore::WorkerSharedTimer::fireTime): (WebCore::WorkerSharedTimer::fire): (WebCore::WorkerRunLoop::WorkerRunLoop): Initializes a WorkerSharedTimer instance. (WebCore::WorkerRunLoop::~WorkerRunLoop): The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer. (WebCore::WorkerRunLoop::run): Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
- dom/WorkerRunLoop.h: Add member of type OwnPtr<WorkerSharedTimer>
- 12:57 AM Changeset in webkit [40531] by
-
- 2 edits in trunk/WebCore
2009-02-03 Steve Falkenburg <sfalken@apple.com>
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 12:24 AM Changeset in webkit [40530] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where appropriate.
- 12:05 AM Changeset in webkit [40529] by
-
- 2 edits in trunk/WebKit/win
2009-02-03 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::visitedURL):
Feb 2, 2009:
- 11:57 PM Changeset in webkit [40528] by
-
- 2 edits in trunk/WebKit/win
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::visitedURL):
- 11:41 PM Changeset in webkit [40527] by
-
- 15 edits3 adds in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Part 2 of
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>
Enable the async portion of ThreadableLoader for workers.
No observable change in behavior, so no test.
- 11:38 PM Changeset in webkit [40526] by
-
- 12 edits2 deletes in trunk/WebCore
2009-02-02 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>
No observable change in behavior, so no test.
- WebCore.xcodeproj/project.pbxproj:
- dom/Worker.cpp:
- dom/Worker.h:
- dom/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postTask): (WebCore::WorkerContext::postTaskToWorkerObject):
- dom/WorkerContext.h:
- dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Expose postTaskToWorkerContext for use by the worker object thread.
(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
with postMessageToWorkerObject.
- dom/WorkerMessagingProxy.h:
- dom/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::postTask):
- dom/WorkerRunLoop.h:
- dom/WorkerTask.cpp: Removed.
- dom/WorkerTask.h: Removed. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.
The resulted in the class going away along with an adapter that made
a ScriptExecutionContext::Task look like a WorkerTask.
- dom/WorkerThread.cpp:
- dom/WorkerThread.h:
- 11:36 PM Changeset in webkit [40525] by
-
- 10 edits2 adds in trunk/WebCore
2009-02-02 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23618: Templated worker tasks should be more error proof to use.
<https://bugs.webkit.org/show_bug.cgi?id=23618>
Add the generic worker tasks templates needed for the WorkerThreadableLoader.
No observable change in behavior, so no test.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/CrossThreadCopier.cpp: Added.
- dom/CrossThreadCopier.h: Added. (WebCore::CrossThreadCopierPassThrough::copy):
- dom/GenericWorkerTask.h: Stop doing the WorkerMessagingProxy::askedToTerminate call automatically in performTask because was not obvious that it would be done and not always needed.
(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask1::GenericWorkerTask1):
(WebCore::GenericWorkerTask1::performTask):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask2::GenericWorkerTask2):
(WebCore::GenericWorkerTask2::performTask):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask3::GenericWorkerTask3):
(WebCore::GenericWorkerTask3::performTask):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask4::GenericWorkerTask4):
(WebCore::GenericWorkerTask4::performTask):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask5::GenericWorkerTask5):
(WebCore::GenericWorkerTask5::performTask):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask6::GenericWorkerTask6):
(WebCore::GenericWorkerTask6::performTask):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask7::GenericWorkerTask7):
(WebCore::GenericWorkerTask7::performTask):
(WebCore::createCallbackTask):
- dom/WorkerContext.cpp: (WebCore::addMessageTask): (WebCore::WorkerContext::addMessage):
- dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
- 10:45 PM Changeset in webkit [40524] by
-
- 15 edits in trunk/WebCore
2009-02-02 Sam Weinig <sam@webkit.org>
Reviewed by David "The Barnabas Jones" Hyatt.
Move removeChildNode, appendChildNode and insertChildNode from
RenderContainer into RenderObjectChildList. Make moveChildNode
static in RenderBlock, as that was the only user.
- rendering/RenderBlock.cpp: (WebCore::moveChild): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::handleRunInChild):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild):
- rendering/RenderContainer.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::childBecameNonInline):
- rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
- rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper):
- rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore::RenderSVGContainer::removeChild):
- rendering/RenderSVGContainer.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::removeChild):
- rendering/RenderTable.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChild):
- rendering/RenderTableSection.h:
- 10:39 PM Changeset in webkit [40523] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Alder.
https://bugs.webkit.org/show_bug.cgi?id=23697
Leaks seen on Worker tests
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed() is called.
- 10:08 PM Changeset in webkit [40522] by
-
- 3 edits3 adds in trunk
<https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
<rdar://problem/6543487>
Reviewed by Gavin Barraclough.
In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
itself recursively, it will incorrectly emit (and thus consume) the next single character
match in the current character class. As WREC uses a binary search this out of sequence
codegen could result in a character match being missed and so cause the regex to produce
incorrect results.
- 9:26 PM Changeset in webkit [40521] by
-
- 5 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Move positionForCoordinates up from RenderContainer into RenderBox.
Reviewed by Sam Weinig
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForCoordinates):
- rendering/RenderBox.h:
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- 8:47 PM Changeset in webkit [40520] by
-
- 4 edits in trunk
Incorrect handling of findstr results in *.vcproj.
Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
- 8:46 PM Changeset in webkit [40519] by
-
- 3 edits in trunk/WebKit/wx
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
- WebKitSupport/FrameLoaderClientWx.h:
- 8:33 PM Changeset in webkit [40518] by
-
- 13 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Refactor the handling of before/after content and generated content. Move most of the functions from
RenderContainer into RenderObjectChildList.
Reviewed by Sam Weinig
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
- rendering/RenderBox.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::findBeforeAfterParent): (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderObjectChildList.h:
- 8:23 PM Changeset in webkit [40517] by
-
- 3 edits in trunk/WebCore
2009-02-02 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23661
Fix Chromium build.
- history/HistoryItem.h: need to include <wtf/OwnPtr.h>
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
- 7:08 PM Changeset in webkit [40516] by
-
- 2 edits in trunk/WebCore
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
- 7:06 PM Changeset in webkit [40515] by
-
- 4 edits in trunk/WebKit
WebKit/qt:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- Api/qwebframe.cpp: (QWebFrame::QWebFrame): (QWebFrame::load): (QWebFrame::setHtml): (QWebFrame::setContent):
WebKit/wx:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebFrame.cpp: (wxWebFrame::LoadURL):
- 7:03 PM Changeset in webkit [40514] by
-
- 4 edits in trunk
WebCore:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCore.base.exp:
WebKit/mac:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
- 6:56 PM Changeset in webkit [40513] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- webkit/webkitwebview.cpp:
- 6:54 PM Changeset in webkit [40512] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- webkit/webkitwebframe.cpp:
- 6:52 PM Changeset in webkit [40511] by
-
- 2 edits in trunk/WebKit/win
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
- 6:52 PM Changeset in webkit [40510] by
-
- 2 edits in trunk/WebKit/qt
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
- 6:49 PM Changeset in webkit [40509] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- 6:31 PM Changeset in webkit [40508] by
-
- 37 edits in trunk
WebCore:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- WebCore.base.exp: Renamed some exports.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (windowProtoFuncOpen):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::assign): Treat any navigation that is not initiated by the user as a redirect from the perspective of global history.
- history/HistoryItem.cpp: (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect chain.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect): (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect): (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly, added yet another way to track redirect state during loading, since none of the others did what I wanted, and I didn't want to cause behavior changes in existing code.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Stubbed out a client function to keep things building.
- loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect => FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all the other meanings of "redirect" in the loading code.
(WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
redirect as a redirect from the perspective of global history.
(WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
parameter.
(WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load): Updated for rename and extra parameter.
(WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
in the DocumentLoader, so it's accessible to WebKit's global history code.
(WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
only has meaning to global history, and m_quickRedirectComing pertains
to other kinds of history.
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
(WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
navigations even if they don't create new history items, so we can track
the redirect in the existing history item.
- loader/FrameLoader.h: See above.
- loader/FrameLoaderClient.h: New client interface used by FrameLoader::updateHistory* to record a redirect even if it doesn't create a new history item of its own.
- loader/FrameLoaderTypes.h: See above. (WebCore::):
- page/DragController.cpp: (WebCore::DragController::performDrag):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Updated for extra parameter.
WebKit/gtk:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
Keep GTK building.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate lastVisitedEntry]): (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history entry in case we're asked to add redirect information to it later.
(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
(-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
information in global history.
- History/WebHistoryInternal.h:
- WebCoreSupport/WebFrameLoaderClient.h: See above and below.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect information in global history.
- WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
- WebView/WebFramePrivate.h: Updated for rename and extra parameter.
WebKit/qt:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
Keep Qt building.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientQt::createFrame):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Store redirect information in global history.
(WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
- WebCoreSupport/WebFrameLoaderClient.h: See above.
- WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::loadData): Updated for extra parameter.
- WebHistory.cpp: (WebHistory::visitedURL): (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect information in global history.
- WebHistory.h: See above.
- 5:35 PM Changeset in webkit [40507] by
-
- 5 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Work around a limitation in MIG where two functions can't have the same name even if they're
not in the same subsystem.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 5:21 PM Changeset in webkit [40506] by
-
- 4 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
Remove RenderSVGContainer's implementation, since it was never called.
Reviewed by Beth Dakin
- rendering/RenderBox.cpp: (WebCore::RenderBox::minPrefWidth):
- rendering/RenderBox.h: (WebCore::RenderBox::calcPrefWidths):
- rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
- rendering/RenderSVGContainer.h:
- 4:59 PM Changeset in webkit [40505] by
-
- 11 edits in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.
- WebCore.LP64.exp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement): (WebCore::ScriptController::jsObjectForPluginElement):
- bindings/js/ScriptController.h:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement WKPCGetPluginElementObject.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetPluginElementNPObject):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView WebCore::]):
- 4:45 PM Changeset in webkit [40504] by
-
- 2 edits in trunk/WebCore
2009-02-02 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel (and Ojan Vafai).
https://bugs.webkit.org/show_bug.cgi?id=23696
Select element doesn't show new value when focus is switched in
onchange event.
Fix PopupMenuChromium to hide itself before calling valueChanged. This
better matches the behavior of the other ports.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
- 4:28 PM Changeset in webkit [40503] by
-
- 7 edits in trunk/WebKit/win
2009-02-02 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
- Interfaces/IWebHistoryItemPrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
- WebHistory.cpp: (WebHistory::visitedURL):
- WebHistory.h:
- WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
- WebHistoryItem.h:
- 4:27 PM Changeset in webkit [40502] by
-
- 2 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Make sure scrollWidth/Height just return 0 for inline flows.
Reviewed by Beth Dakin
- rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
- 4:27 PM Changeset in webkit [40501] by
-
- 25 edits in trunk
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676
- API/JSObjectRef.cpp: (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): Ditto. (JSC::Lexer::clear): Ditto.
- wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of reserveCapacity for use when the vector is brand new (still size 0 with no capacity other than the inline capacity).
WebCore:
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::sortMatchedRules):
- dom/Document.cpp: (WebCore::Document::formElementsState):
- dom/NamedAttrMap.h: (WebCore::NamedAttrMap::reserveInitialCapacity):
- editing/TextIterator.cpp: (WebCore::CharacterIterator::string): (WebCore::SearchBuffer::SearchBuffer): (WebCore::plainTextToMallocAllocatedBuffer):
- editing/markup.cpp: (WebCore::joinMarkups):
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
- html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
- page/mac/AccessibilityObjectWrapper.mm: (convertToVector):
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::invalidate):
- platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::copyData):
- platform/network/mac/FormDataStreamMac.mm: (WebCore::formCreate):
- xml/XPathNodeSet.cpp: (WebCore::XPath::NodeSet::sort): Use reserveInitialCapacity instead of of reserveCapacity in all these call sites, which are working on new vectors that are guaranteed not to be empty.
- 4:22 PM Changeset in webkit [40500] by
-
- 7 edits in trunk/WebCore
2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>
Build fix after r40486.
Rubber-stamped by Ada Chan.
- dom/Document.h:
- page/EventHandler.h:
- rendering/EllipsisBox.h:
- rendering/InlineBox.h:
- rendering/InlineFlowBox.h:
- rendering/RenderLayer.h:
- 4:07 PM Changeset in webkit [40499] by
-
- 4 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode. (WebCore::ContainerNode::removedFromDocument): Ditto.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node. (WebCore::EventTargetNode::removedFromDocument): Ditto.
- dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Updated comment. (WebCore::Node::removedFromDocument): Ditto.
- 3:57 PM Changeset in webkit [40498] by
-
- 2 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
- WebView/WebHTMLView.mm:
- 3:48 PM Changeset in webkit [40497] by
-
- 14 edits2 deletes in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
More plug-in cleanup.
- WebCore.NPAPI.exp: Add new symbols.
- bindings/objc/DOM.mm:
- bindings/objc/DOMPrivate.h: Remove methods that WebKit doesn't use anymore.
WebKit:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView dataSource]):
- Plugins/WebKitPluginContainerView.h: Removed.
- Plugins/WebKitPluginContainerView.mm: Removed.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView getVariable:value:]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
- 3:44 PM Changeset in webkit [40496] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.h:
- 3:30 PM Changeset in webkit [40495] by
-
- 3 edits in trunk/WebKit/win
2009-02-02 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- 3:07 PM Changeset in webkit [40494] by
-
- 3 edits in trunk/WebCore
2009-02-02 Jay Campan <jcampan@chromium.org>
Reviewed by Eric Seidel.
Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653
No functional changes, only code cleanup, thus no tests.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h:
- 2:36 PM Changeset in webkit [40493] by
-
- 18 edits in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
- loader/FrameLoader.cpp: (WebCore::toPlugInElement): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
WebKit/gtk:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
WebKit/qt:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebFrame.cpp: (WebFrame::createJavaAppletWidget):
- WebFrame.h:
- 2:10 PM Changeset in webkit [40492] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding bug URL for a recent check-in.
- 1:48 PM Changeset in webkit [40491] by
-
- 2 edits in trunk/WebCore
Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank
Applies to Torch Mobile platform only right now, as per request.
- 1:35 PM Changeset in webkit [40490] by
-
- 5 edits in trunk/WebCore
- 1:15 PM Changeset in webkit [40489] by
-
- 2 edits in trunk
2009-02-02 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Holger Freyther.
Don't require Geolocation by default.
- configure.ac:
- 12:59 PM Changeset in webkit [40488] by
-
- 3 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Try to fix Wx build, and maybe Chromium build too.
- WebCore.scons: Added IdentifierRep.cpp.
- WebCoreSources.bkl: Ditto.
- 12:55 PM Changeset in webkit [40487] by
-
- 2 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Try to fix Wx build.
- html/HTMLAreaElement.cpp: Added missing include of "Path.h".
- 12:46 PM Changeset in webkit [40486] by
-
- 11 edits in trunk
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.
- dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
- editing/SelectionController.cpp: (WebCore::SelectionController::contains):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
- page/EventHandler.h:
- rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::HitTestRequest): (WebCore::HitTestRequest::readOnly): (WebCore::HitTestRequest::active): (WebCore::HitTestRequest::mouseMove): (WebCore::HitTestRequest::mouseUp): (WebCore::HitTestRequest::ignoreClipping):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState):
- 12:41 PM Changeset in webkit [40485] by
-
- 3 edits in trunk/WebCore
Fix the WML build by including the inlined renderStyle().
- 12:11 PM Changeset in webkit [40484] by
-
- 3 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Niko Zimmermann.
Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971
Also fix other XPath tests that are crashing.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we need to make Attr nodes here. Yuck!
- 11:53 AM Changeset in webkit [40483] by
-
- 3 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
When a new Web View was not created, report back to the plug-in host.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest):
- Plugins/Hosted/WebKitPluginHost.defs:
- 11:29 AM Changeset in webkit [40482] by
-
- 4 edits3 adds in trunk
Implement WML specific attributes of WMLInputElement.
- 11:14 AM Changeset in webkit [40481] by
-
- 2 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
- 11:12 AM Changeset in webkit [40480] by
-
- 3 edits in trunk/LayoutTests
2009-01-29 Scott Violet <sky@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails
Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.
- transitions/transition-end-event-helpers.js: (recordTransitionEndEvent): (runTransitionTest.startTest._endFunction): (runTransitionTest.startTest): (runTransitionTest):
- transitions/transition-end-event-nested.html:
- 11:10 AM Changeset in webkit [40479] by
-
- 1 edit in trunk/WebCore/ChangeLog
Forgot to update ChangeLog in my last commit.
- 11:03 AM Changeset in webkit [40478] by
-
- 2 edits in trunk/WebCore
Correct build regression.
- 10:45 AM Changeset in webkit [40477] by
-
- 1 edit in trunk/WebCore/wml/WMLAElement.cpp
Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
- 10:12 AM Changeset in webkit [40476] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
Not easily testable.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource handle in a manner that is closer to what CachedResource does. We now make conditional requests for better performance, and set max-age to ensure that stale responses are not used. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource is 304, take it from the newest cache. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for the manifest if the response code was 304 - it won't be needed. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that m_manifestResource is not null with a check. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as an indication that the response was 304. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
- loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
- 9:29 AM Changeset in webkit [40475] by
-
- 31 edits in trunk/WebCore
2009-02-01 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead of the old name, getCSSTarget. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than calling through to EventTargetNode::insertedIntoDocument. (WebCore::ContainerNode::removedFromDocument): Ditto. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit. (WebCore::ContainerNode::removedFromTree): Ditto.
- dom/ContainerNode.h: Moved the constructor definition here and made it inline.
- dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and its contents only to avoid the document type node. This allows us to remove the virtual function call to isEventTargetNode from the loop. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
- dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed getCSSTarget to cssTarget.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the rare data check into an assertion.
- dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline. Also moved the constructor definition here and made it inline. And added toEventTargetNode, matching the design of the render tree checked casts. Later we can migrate all callers from EventTargetNodeCast to toEventTargetNode.
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from clearAttributes, so we could use this loop in cases where we're not clearing the attributes. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of clearAttributes here. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of clearAttributes. We don't need to clear the attributes array just because the element is going away, so don't. (WebCore::NamedAttrMap::virtualLength): Added.
- dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a non-virtual function. This was a fairly hot function.
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the m_element data member is private.
- dom/NamedMappedAttrMap.h: Made a few functions private. Made the hasMappedAttributes function non-virtual.
- dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
- dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's only non-empty in subclasses of ContainerNode. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).
- dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
- dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and setPrefix function definitions into the header and made them inline.
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now an OwnPtr. (WebCore::HTMLAreaElement::accessKey): Use AtomicString. (WebCore::HTMLAreaElement::setAccessKey): Ditto. (WebCore::HTMLAreaElement::alt): Ditto. (WebCore::HTMLAreaElement::setAlt): Ditto. (WebCore::HTMLAreaElement::coords): Ditto. (WebCore::HTMLAreaElement::setCoords): Ditto. (WebCore::HTMLAreaElement::setHref): Ditto. (WebCore::HTMLAreaElement::shape): Ditto. (WebCore::HTMLAreaElement::setShape): Ditto. (WebCore::HTMLAreaElement::setTarget): Ditto.
- html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize the common case where an area element is parsed but never hit-tested. This could also have been done by changing the Path class's null case to be more efficient, but this seems fine.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead of insertAttribute. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead of its old name getCSSTarget.
- platform/graphics/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
- platform/graphics/GlyphWidthMap.h: Made most of this class inline. Changed m_pages to use OwnPtr.
- platform/text/PlatformString.h: Remove include no longer needed since StringImpl.h includes it.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored from createStrippingNullCharacters.
- platform/text/StringImpl.h: Moved the definition of createStrippingNullCharacters here and made it inline.
- rendering/RenderObject.cpp: (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from firstLineStyle.
- rendering/RenderObject.h: Moved the definition of the firstLineStyle function here and made it inline. Moved the definition of the documentBeingDestroyed function here and made it inline.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of getNamedItem here since it accomplishes the same thing but is more efficient. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of getNamedItemNS.
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
- 7:29 AM Changeset in webkit [40474] by
-
- 2 edits in trunk/WebKit/qt
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build to call forceLayout on the view instead.
- Api/qwebpage.cpp: (QWebPage::setFixedLayoutSize): (QWebPage::setUseFixedLayout):
- 5:16 AM Changeset in webkit [40473] by
-
- 18 edits in trunk
Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
https://bugs.webkit.org/show_bug.cgi?id=23428
FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...
Adjust the WebCore/WebKit consumers of these methods.
Feb 1, 2009:
- 12:30 PM Changeset in webkit [40472] by
-
- 5 edits in trunk/WebCore
Reviewed by John Sullivan.
- fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
Fixes http/tests/navigation/multiple-back-forward-entries.html
r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.
Jan 31, 2009:
- 10:23 PM Changeset in webkit [40471] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().
- rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
- rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.
- 9:07 PM Changeset in webkit [40470] by
-
- 4 edits in trunk/WebKit/win
2009-01-31 Matt Lilek <webkit@mattlilek.com>
Not reviewed, build fixes.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 5:30 PM Changeset in webkit [40469] by
-
- 3 edits in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.
Reviewed by Dan Bernstein
- rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
- rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):
- 4:59 PM Changeset in webkit [40468] by
-
- 2 edits in trunk/WebKit/mac
2009-01-31 John Sullivan <sullivan@apple.com>
Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.
Reviewed by Darin Adler
- WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes
- 4:55 PM Changeset in webkit [40467] by
-
- 3 edits in trunk/WebCore
2009-01-31 Darin Adler <Darin Adler>
Fix Mac build.
- loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.
- loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.
- 4:52 PM Changeset in webkit [40466] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix WIndows bustage.
- 4:14 PM Changeset in webkit [40465] by
-
- 2 edits in trunk/WebKit/mac
2009-01-31 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Fix code that assumes all command selectors end in colons.
rdar://problem/6545874
- WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.
- 3:55 PM Changeset in webkit [40464] by
-
- 3 edits in trunk/WebCore
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.
- rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
- 2:03 PM Changeset in webkit [40463] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt
Update layout test results for 11363.
- 1:40 PM Changeset in webkit [40462] by
-
- 4 edits in trunk/WebCore
Add RenderObjectChildList.cpp to all projects.
- 1:38 PM Changeset in webkit [40461] by
-
- 18 edits1 add in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
- rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
- rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
- rendering/RenderInline.h: (WebCore::RenderInline::layout):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
- rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
- rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
- rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- rendering/RenderObjectChildList.h:
- rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):
- 1:34 PM Changeset in webkit [40460] by
-
- 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
Update layout test results for 11363.
- 1:34 PM Changeset in webkit [40459] by
-
- 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
Update layout test results for 11363.
- 1:30 PM Changeset in webkit [40458] by
-
- 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs
Update layout test results for 11363.
- 1:28 PM Changeset in webkit [40457] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout test results for 11363.
- 1:28 PM Changeset in webkit [40456] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout test results for 11363.
- 1:26 PM Changeset in webkit [40455] by
-
- 1 edit in trunk/LayoutTests/editing/deleting/5408255.html
Update layout test results for 11363.
- 1:23 PM Changeset in webkit [40454] by
-
- 1 edit in trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt
Update layout test results for 11363.
- 1:20 PM Changeset in webkit [40453] by
-
- 5 edits in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.
Reviewed by Oliver Hunt
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
- rendering/RenderTableSection.h:
- 10:07 AM Changeset in webkit [40452] by
-
- 6 edits in trunk/WebCore
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- 8:02 AM Changeset in webkit [40451] by
-
- 2 edits in trunk/WebKit/wx
2009-01-31 Darin Adler <Darin Adler>
Build fix.
- WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.
- 1:36 AM Changeset in webkit [40450] by
-
- 4 edits1 move4 adds1 delete in trunk
2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Nikolas Zimmermann.
[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136
- GNUmakefile.am:
- acinclude.m4: Removed.
- autogen.sh:
- autotools/acinclude.m4: Added.
- autotools/dolt.m4: Added.
- autotools/symbols.filter: Renamed from symbols.filter.
- autotools/webkit.m4: Added.
- configure.ac:
- 12:42 AM Changeset in webkit [40449] by
-
- 18 edits in trunk
WebCore:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
- page/SecurityOrigin.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
- page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):
WebKit/win:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
WebKit/mac:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferencesPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
