⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 16, 2009:

6:26 PM Changeset in webkit [41755] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip media tests that are currently failing.

Rubber-stamped by Adele Peterson.

  • platform/mac-snowleopard/Skipped:
5:10 PM Changeset in webkit [41754] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

<rdar://problem/6642742> Top Sites malfunction when switching text zoom mode

  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is currently showing a non-HTML view.
4:55 PM Changeset in webkit [41753] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is currently crashing.

Rubber-stamped by Beth Dakin.

  • platform/mac-snowleopard/Skipped:
4:55 PM Changeset in webkit [41752] by mrowe@apple.com
  • 7 edits in trunk/LayoutTests

Update test results for six accessibility tests.

Rubber-stamped by Beth Dakin.

  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
  • platform/mac/accessibility/table-with-rules-expected.txt:
4:55 PM Changeset in webkit [41751] by mrowe@apple.com
  • 1 edit
    1 copy
    37 moves
    1 add in trunk/LayoutTests

Move platform-specific acessibility tests and results into platform/mac.

Rubber-stamped by Beth Dakin.

  • platform/mac/accessibility/accesskey-expected.txt: Renamed from LayoutTests/accessibility/accesskey-expected.txt.
  • platform/mac/accessibility/accesskey.html: Renamed from LayoutTests/accessibility/accesskey.html.
  • platform/mac/accessibility/aria-describedby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-describedby-on-input-expected.txt.
  • platform/mac/accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-on-input-expected.txt.
  • platform/mac/accessibility/aria-range-expected.txt: Renamed from LayoutTests/accessibility/aria-range-expected.txt.
  • platform/mac/accessibility/aria-range-value-expected.txt: Renamed from LayoutTests/accessibility/aria-range-value-expected.txt.
  • platform/mac/accessibility/aria-range-value.html: Renamed from LayoutTests/accessibility/aria-range-value.html.
  • platform/mac/accessibility/aria-range.html: Renamed from LayoutTests/accessibility/aria-range.html.
  • platform/mac/accessibility/aria-roles-expected.txt: Renamed from LayoutTests/accessibility/aria-roles-expected.txt.
  • platform/mac/accessibility/aria-slider-expected.txt: Renamed from LayoutTests/accessibility/aria-slider-expected.txt.
  • platform/mac/accessibility/aria-slider.html: Renamed from LayoutTests/accessibility/aria-slider.html.
  • platform/mac/accessibility/aria-spinbutton-expected.txt: Renamed from LayoutTests/accessibility/aria-spinbutton-expected.txt.
  • platform/mac/accessibility/aria-spinbutton.html: Renamed from LayoutTests/accessibility/aria-spinbutton.html.
  • platform/mac/accessibility/bounds-for-range-expected.txt: Renamed from LayoutTests/accessibility/bounds-for-range-expected.txt.
  • platform/mac/accessibility/bounds-for-range.html: Renamed from LayoutTests/accessibility/bounds-for-range.html.
  • platform/mac/accessibility/content-editable-expected.txt: Renamed from LayoutTests/accessibility/content-editable-expected.txt.
  • platform/mac/accessibility/content-editable.html: Renamed from LayoutTests/accessibility/content-editable.html.
  • platform/mac/accessibility/document-attributes-expected.txt: Renamed from LayoutTests/accessibility/document-attributes-expected.txt.
  • platform/mac/accessibility/document-attributes.html: Renamed from LayoutTests/accessibility/document-attributes.html.
  • platform/mac/accessibility/document-links-expected.txt: Renamed from LayoutTests/accessibility/document-links-expected.txt.
  • platform/mac/accessibility/document-links.html: Renamed from LayoutTests/accessibility/document-links.html.
  • platform/mac/accessibility/double-title-expected.txt: Renamed from LayoutTests/accessibility/double-title-expected.txt.
  • platform/mac/accessibility/double-title.html: Renamed from LayoutTests/accessibility/double-title.html.
  • platform/mac/accessibility/frame-with-title-expected.txt: Renamed from LayoutTests/accessibility/frame-with-title-expected.txt.
  • platform/mac/accessibility/frame-with-title.html: Renamed from LayoutTests/accessibility/frame-with-title.html.
  • platform/mac/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/image-map1-expected.txt.
  • platform/mac/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/image-map2-expected.txt.
  • platform/mac/accessibility/input-image-url-expected.txt: Renamed from LayoutTests/accessibility/input-image-url-expected.txt.
  • platform/mac/accessibility/input-image-url.html: Renamed from LayoutTests/accessibility/input-image-url.html.
  • platform/mac/accessibility/internal-link-anchors-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors-expected.txt.
  • platform/mac/accessibility/internal-link-anchors.html: Renamed from LayoutTests/accessibility/internal-link-anchors.html.
  • platform/mac/accessibility/internal-link-anchors2-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors2-expected.txt.
  • platform/mac/accessibility/legend-expected.txt: Renamed from LayoutTests/accessibility/legend-expected.txt.
  • platform/mac/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/plugin-expected.txt.
  • platform/mac/accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/radio-button-group-members-expected.txt.
  • platform/mac/accessibility/resources/cake.png: Copied from LayoutTests/accessibility/resources/cake.png.
  • platform/mac/accessibility/resources/test.swf: Renamed from LayoutTests/accessibility/resources/test.swf.
  • platform/mac/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/table-one-cell-expected.txt.
4:30 PM Changeset in webkit [41750] by Darin Adler
  • 7 edits in trunk/WebKit

WebKit:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/mac:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard. (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here.

WebKit/win:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

For now, change only the localized strings, not the terminology in the code.

  • WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here. (WebCore::contextMenuItemTagTextDirectionMenu): And here.
4:15 PM Changeset in webkit [41749] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
​https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

Test: editing/selection/move-paragraph-document-edges.html

  • editing/visible_units.cpp: (WebCore::previousParagraphPosition): Use the last result from previousLinePosition rather than going all the way back to what was originally passed in when we hit exception cases like null or not moving. This correctly inherits the behavior of previousLinePosition when we are in a paragraph at the edge of a document. (WebCore::nextParagraphPosition): Ditto.

LayoutTests:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
​https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

  • editing/selection/move-paragraph-document-edges-expected.txt: Added.
  • editing/selection/move-paragraph-document-edges.html: Added.
3:41 PM Changeset in webkit [41748] by Darin Adler
  • 3 edits in trunk/WebCore

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
​https://bugs.webkit.org/show_bug.cgi?id=24619

  • rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
  • rendering/RenderView.h: Ditto.
3:37 PM Changeset in webkit [41747] by christian@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-16 Christian Dywan <​christian@twotoasts.de>

Reviewed by Adam Roben.

[gtk] API implementation: url and title
​http://bugs.webkit.org/show_bug.cgi?id=14807

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: Implement "title" and "uri" properties as well as according functions. "uri" always reflects the current location including navigation inside the same page. title-changed is deprecated.
3:19 PM Changeset in webkit [41746] by pkasting@chromium.org
  • 10 edits in trunk/WebCore

2009-03-16 Peter Kasting <​pkasting@google.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24368
DOM scroll events should be based off the actual number of wheel
ticks, not off the number of lines scrolled. This matches IE.

  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::wheelTicksX): (WebCore::PlatformWheelEvent::wheelTicksY):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3:07 PM Changeset in webkit [41745] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-03-16 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Clean up a few issues in the Animation code:

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Whitespace

(WebCore::AnimationBase::willNeedService):
Don't round to float, use std::max

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startTimeResponse): Fix erroneously copied line to null out m_lastResponseWaiter.
2:58 PM Changeset in webkit [41744] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Don't mig_deallocate random data in case an instance proxy method returns false.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCEnumerate):
2:49 PM Changeset in webkit [41743] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2009-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler and John Sullivan.

When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.


Instead, just zero out the member variable in invalidate.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvalidate): (pluginDeallocate):
2:34 PM Changeset in webkit [41742] by hyatt@apple.com
  • 63 edits in trunk

WebCore:

2009-03-12 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

Existing tests cover this.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition):

LayoutTests:

2009-03-16 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

  • platform/mac/fast/body-propagation/overflow/002-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.txt:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/overflow/003-expected.checksum:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/003-expected.txt:
  • platform/mac/fast/overflow/004-expected.checksum:
  • platform/mac/fast/overflow/004-expected.png:
  • platform/mac/fast/overflow/007-expected.checksum:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/007-expected.txt:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
2:19 PM Changeset in webkit [41741] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-16 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

Test: fast/forms/select-max-length.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):

LayoutTests:

2009-03-16 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Test for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

  • fast/forms/select-max-length-expected.txt: Added.
  • fast/forms/select-max-length.html: Added.
1:56 PM Changeset in webkit [41740] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

REGRESSION: undo-iframe-location-change.html is failing on the buildbots
​https://bugs.webkit.org/show_bug.cgi?id=24626

Added a call to [[webview undoManager] removeAllActions]
to make sure anything left on the undo stack after one test
will not affect any later test.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
1:09 PM Changeset in webkit [41739] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6633944>
REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin


Defer loading while calling webPlugInInitialize since it can end up spinning the run loop.


  • Plugins/WebPluginController.mm: (-[WebPluginController addPlugin:]):
1:03 PM Changeset in webkit [41738] by Adam Roben
  • 4 edits in trunk/WebKit/win

Add IWebFramePrivate::isDisplayingStandaloneImage

This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
uses.

Reviewed by Darin Adler.

  • Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
  • WebFrame.cpp: (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our Document is an image document.
  • WebFrame.h: Added isDisplayingStandaloneImage.
12:56 PM Changeset in webkit [41737] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-16 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6686721> Media document crash in 64-bit WebKit

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when rendering inline with old versions of QuickTime, so don't look for it when we are in a media document.
12:55 PM Changeset in webkit [41736] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-16 Pamela Greene <​pam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove test dependency on precise window location and size. It's not
clear to me why these vary, but they're not what the test is checking,
so it need not depend on them in any case.
​https://bugs.webkit.org/show_bug.cgi?id=24170

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
11:54 AM Changeset in webkit [41735] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6622601>


Make sure to update both the window frame and the plug-in frame.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView addWindowObservers]):
9:47 AM Changeset in webkit [41734] by Dimitri Glazkov
  • 9 edits in trunk/WebCore

2009-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=24590
Refactor InspectorDOMStorageResource to use ScriptFunctionCall.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
  • bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): Added Storage helper.
  • bindings/js/ScriptObjectQuarantine.h: Ditto.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use bind method. (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method. (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
  • inspector/InspectorController.h: Removed add/remove methods for DOM storage.
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added. (WebCore::InspectorDOMStorageResource::bind): Added. (WebCore::InspectorDOMStorageResource::unbind): Added.
  • inspector/InspectorDOMStorageResource.h:
9:13 AM Changeset in webkit [41733] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-16 Mike Belshe <​mike@belse.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior, this time with the code that
compiles.

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): Fix copy/paste mistake.
12:39 AM Changeset in webkit [41732] by ap@webkit.org
  • 12 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21752
REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it

Test: fast/dom/Window/window-early-properties-xhr.html

For some transitions, the Window object is not replaced, but Document is. When this happened,
window.document property was updated, but references to Document kept in cached constructors
were not.

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::document): (WebCore::JSAudioConstructor::mark):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): (WebCore::JSImageConstructor::document): (WebCore::JSImageConstructor::mark):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::scriptExecutionContext): (WebCore::JSMessageChannelConstructor::mark):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): (WebCore::JSOptionConstructor::document): (WebCore::JSOptionConstructor::mark):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext): (WebCore::JSXMLHttpRequestConstructor::mark):
  • bindings/js/JSXMLHttpRequestConstructor.h: Changed cached constructors to keep a reference to Window, not Document.
12:12 AM Changeset in webkit [41731] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24549
Impose a limit on Access-Control-Max-Age value

  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::parse):

Mar 15, 2009:

7:04 PM Changeset in webkit [41730] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6668875> Normalize Geolocation results

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
6:02 PM Changeset in webkit [41729] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

Update ::toString format as suggested by Darin Adler.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
5:31 PM Changeset in webkit [41728] by Simon Fraser
  • 3 edits in trunk/JavaScriptCore

2009-03-15 Simon Fraser <Simon Fraser>

Revert r41718 because it broke DumpRenderTree on Tiger.

  • JavaScriptCorePrefix.h:
  • wtf/Platform.h:
4:55 PM Changeset in webkit [41727] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Reviewed by Darin Adler.

Yet another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encodingForFormSubmission):
4:41 PM Changeset in webkit [41726] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-03-15 Simon Fraser <Simon Fraser>

Build fix: no review.

  • rendering/style/ContentData.h:
4:32 PM Changeset in webkit [41725] by ddkilzer@apple.com
  • 9 edits in trunk/WebCore

Bug 24542: Improve ContentData encapsulation

<​https://bugs.webkit.org/show_bug.cgi?id=24542>

Reviewed by Simon Fraser.

No tests since there is no change in behavior.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Used getter methods instead of data members on ContentData class. Used isImage() convenience method.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Extracted code into deleteContent() method. (WebCore::ContentData::dataEquivalent): Added. Extracted code from StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::ContentData::deleteContent): Added. Used by setter methods.
  • rendering/style/ContentData.h: Made m_type, m_content and m_next private. (WebCore::ContentData::isCounter): Added. (WebCore::ContentData::isImage): Added. (WebCore::ContentData::isNone): Added. (WebCore::ContentData::isText): Added. (WebCore::ContentData::type): Added. (WebCore::ContentData::dataEquivalent): Added. (WebCore::ContentData::image): Added. (WebCore::ContentData::setImage): Added. (WebCore::ContentData::text): Added. (WebCore::ContentData::setText): Added. (WebCore::ContentData::counter): Added. (WebCore::ContentData::setCounter): Added. (WebCore::ContentData::next): Added. (WebCore::ContentData::setNext): Added.
  • rendering/style/CounterContent.h: (WebCore::operator!=): Removed. (WebCore::operator==): Renamed operator!=() and reversed its logic after extracting code from StyleRareNonInheritedData::contentDataEquivalent() to create ContentData::dataEquivalent().
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Used new getters and setters on ContentData class. Changed first argument from a StringImpl* to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::setContent): Updated declaration.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Extracted most logic in while() loop into ContentData::dataEquivalent().
3:39 PM Changeset in webkit [41724] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.3

Tagging 1.1.3.

3:26 PM Changeset in webkit [41723] by xan@webkit.org
  • 2 edits in trunk

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Bump version to 1.1.3 for release and fix soversion
calculation (oops). Thanks to Frederik Himpe for pointing this
out.

  • configure.ac:
1:15 PM Changeset in webkit [41722] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Mark Rowe.

  • config.ini: fix my blog's feed address.
11:51 AM Changeset in webkit [41721] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.2

Tagging 1.1.2.

10:40 AM Changeset in webkit [41720] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

Fix default policy decision to be ignore, on MIME checks, if
WebKit doesn't know how to handle the MIME type. The documentation
is already correct, and this was an oversight when the policy
decision code was first committed. Since 1.1.2 will be the first
release to support download, there is no practical change in
behavior.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
10:40 AM Changeset in webkit [41719] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:23 AM Changeset in webkit [41718] by kevino@webkit.org
  • 3 edits in trunk/JavaScriptCore

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

8:30 AM Changeset in webkit [41717] by xan@webkit.org
  • 4 edits in trunk

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Bump version and libtool version for release.

  • configure.ac:

WebKit/gtk:

2009-03-15 Xan Lopez <​xlopez@igalia.com>

  • NEWS: update for 1.1.2.
4:26 AM Changeset in webkit [41716] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/editing/selection/5354455-2.html

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

2:22 AM Changeset in webkit [41715] by ap@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19737
No cursor and paste not enabled right clicking text field/area

Test: fast/events/right-click-focus.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
1:56 AM Changeset in webkit [41714] by ap@webkit.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Suggested by Mark Rowe.

Move results for security/block-test.html to their correct locations. Results for other
platforms will need to be generated.

  • platform/mac-leopard/security/block-test-expected.txt: Removed.
  • platform/mac-tiger/security: Added.
  • platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
  • platform/mac/security: Added.
  • platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
  • security/block-test-expected.txt: Removed.
1:42 AM Changeset in webkit [41713] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=23949
HTMLSelectElement is in inconsistent state when handling mutation events

Test: fast/forms/mutation-event-recalc.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::appendChild): Call childrenChanged() before dispatching modification events, not after.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::insertBefore): (WebCore::HTMLSelectElement::replaceChild): (WebCore::HTMLSelectElement::removeChild): (WebCore::HTMLSelectElement::appendChild): (WebCore::HTMLSelectElement::removeChildren): Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events were already dispatched.
1:23 AM Changeset in webkit [41712] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adele Peterson.

  • fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately

Made WebHTMLView validate user interface items with the selector
-makeBaseWritingDirectionNatural: by returning NO and, if the item is
a menu item, setting its state to "off".

Strictly speaking, since -makeBaseWritingDirectionNatural: is never
valid for WebViews, WebHTMLView should not need to respond to it and
validate it, however because other responders respond to all three
-makeBaseWritingDirection*: messages and set the menu item state, having
WebHTMLView do the same makes application developers' lives easier.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]):
1:16 AM Changeset in webkit [41711] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Add svn:executable property to recently added cgi scripts.

  • http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

Mar 14, 2009:

8:23 PM Changeset in webkit [41710] by mrowe@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

  • platform/mac-snowleopard/Skipped: Added.
7:55 PM Changeset in webkit [41709] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <​bolsinga@apple.com>

<rdar://problem/6683465>

Geolocation has to be able to handle NULL Frames.

Reviewed by Mark Rowe

6:58 PM Changeset in webkit [41708] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

Geoposition::toString was missing the Coordinates after the update.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
4:44 PM Changeset in webkit [41707] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-03-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[Gtk] Build fix - pass a Coordinate to Geoposition::create
​https://bugs.webkit.org/show_bug.cgi?id=24603

Gtk build fix per r41650
​https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position

Pass a Coordinate to Geoposition::create.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
4:14 PM Changeset in webkit [41706] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] use of confirm dialog (yes/no) causes segfault
​https://bugs.webkit.org/show_bug.cgi?id=20940

Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
OBJECT,STRING,POINTER

  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
3:02 PM Changeset in webkit [41705] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-14 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Remove two now working tests from GTK's Skipped list.

  • platform/gtk/Skipped:
1:22 PM Changeset in webkit [41704] by xan@webkit.org
  • 2 edits in trunk

2009-03-14 Xan Lopez <​xlopez@igalia.com>

No review, build fix.

Split clean rules to make distcheck pass.

  • GNUmakefile.am:
5:50 AM Changeset in webkit [41703] by mrowe@apple.com
  • 21 edits
    20 copies
    7 adds in trunk/LayoutTests

Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

  • fast/dom/getElementsByClassName/011-expected.txt:
  • fast/parser/external-entities-expected.txt:
  • platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
  • platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
  • platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
  • platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
  • platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
  • platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
  • platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
  • platform/mac/fast/invalid/missing-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.checksum:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.checksum:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.checksum:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/hixie/error/012-expected.txt:
5:19 AM Changeset in webkit [41702] by mrowe@apple.com
  • 8 edits
    25 copies
    8 moves
    5 adds
    1 delete in trunk

Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory. The
results for older versions of Mac OS X are structured as a series of overlays. When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

  • Scripts/run-webkit-tests:
5:02 AM Changeset in webkit [41701] by ap@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24545
Make cross-site XHR simple request definition match current spec draft

Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language. (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those that could be sent via form submission.
4:56 AM Changeset in webkit [41700] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=15172
object fallback - empty string for first argument of setAttributeNS does not work like null

​https://bugs.webkit.org/show_bug.cgi?id=24548
createElementNS("", name) should create an element in null namespace

Tests: fast/dom/createElementNS-empty-namespace.html

fast/dom/setAttributeNS-empty-namespace.html

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Convert empty namespaces to null.
4:54 AM Changeset in webkit [41699] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24591
Add my blog to Planet WebKit

Add my blog to the planet.

  • config.ini:

Mar 13, 2009:

11:17 PM Changeset in webkit [41698] by mrowe@apple.com
  • 10 edits in trunk

Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

  • Configurations/DebugRelease.xcconfig:
11:17 PM Changeset in webkit [41697] by mrowe@apple.com
  • 4 edits in trunk

Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

11:17 PM Changeset in webkit [41696] by mrowe@apple.com
  • 8 edits in trunk/WebKitTools

Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it. This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

  • Scripts/build-webkit: Remove architecture-related code.
  • Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
  • Scripts/run-javascriptcore-tests: Remove architecture-related code.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments. The --32-bit argument will set the

architecture preference to the 32-bit architecture of the machine. The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.

  • Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the

auto-detection.

11:17 PM Changeset in webkit [41695] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings. When building in Xcode, this setting isn't present so
Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

  • JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is

already newer than the input file.

5:53 PM Changeset in webkit [41694] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 John Abd-El-Malek <​jam@google.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24593
Added requestorID so we can track the request to its WebView without using frame (which was removed).

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::requestorID): (WebCore::ResourceRequest::setRequestorID): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::policyURL): (WebCore::ResourceRequest::setPolicyURL): (WebCore::ResourceRequest::requestorPid): (WebCore::ResourceRequest::setRequestorPid):
4:07 PM Changeset in webkit [41693] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/WebCore

2009-03-13 Mike Belshe <​mike@belshe.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24561
Add custom V8 bindings for HTMLElementCanvas, Location.

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
  • bindings/v8/custom/V8LocationCustom.cpp: Added.
3:47 PM Changeset in webkit [41692] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-03-13 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24584

Fix transparent text rendering on Chromium. FontChromiumWin
was calling beginTransparencyLayer()/endTransparencyLayer(), with
a TransparencyWin inside to do GDI ClearType rendering over an
opaque background. TransparencyWin does its special sauce
in the destructor, but it was being called too late to be used
correctly in the layer. Put the special sauce into a new function,
composite(), and call that explicitly instead.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::~TransparencyWin): (WebCore::TransparencyWin::composite): (WebCore::TransparencyWin::init):
  • platform/graphics/chromium/TransparencyWin.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::):
3:46 PM Changeset in webkit [41691] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-13 Mike Belshe <​mike@belshe.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24562
Add custom implementation for getCSSCanvasContext to V8 bindings.

  • bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
3:43 PM Changeset in webkit [41690] by eric@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2009-03-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

Add tests for various types of textareas. Tests in both
quirks and standards modes. Although only the standards
modes tests fit in the pixel results.
​https://bugs.webkit.org/show_bug.cgi?id=24370

  • fast/forms/basic-textareas.html: Added.
  • platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/mac/fast/forms/basic-textareas-expected.png: Added.
  • platform/mac/fast/forms/basic-textareas-expected.txt: Added.
3:42 PM Changeset in webkit [41689] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-13 Mike Belshe <​mike@belse.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior.

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): remove extra logic around question mark.
3:32 PM Changeset in webkit [41688] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker and Geoffrey Garen.

<rdar://problem/6590384>
REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting


When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call,
and thus calling -[WebView hostWindow] will crash since _private is nil.


  • WebView/WebView.mm: (-[WebView hostWindow]):
3:20 PM Changeset in webkit [41687] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
​https://bugs.webkit.org/show_bug.cgi?id=24474

3:01 PM WebKit Team edited by ojan@chromium.org
(diff)
3:00 PM Changeset in webkit [41686] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-03-13 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24589
Upstream changes to V8 event listeners (Chromium r11133) in order to
fix worker functionality break in Chromium.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
2:53 PM WebKit Team edited by Dimitri Glazkov
Ego-tuning. (diff)
2:52 PM Changeset in webkit [41685] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-03-13 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

Resolved name conflict with globally defined tzname in Symbian.
Replaced with different name instead of using namespace qualifier
(appeared to be less clumsy).

  • runtime/DateMath.cpp:
2:48 PM WebKit Team edited by pam@chromium.org
(diff)
2:45 PM WebKit Team edited by abarth@webkit.org
(diff)
2:31 PM Changeset in webkit [41684] by Dimitri Glazkov
  • 11 edits
    5 copies
    1 add in trunk/WebCore

2009-03-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=24524
Introduce ScriptObject and ScriptFunctionCall abstractions.

  • GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/ScriptFunctionCall.cpp: Added.
  • bindings/js/ScriptFunctionCall.h: Added.
  • bindings/js/ScriptObject.cpp: Added.
  • bindings/js/ScriptObject.h: Added.
  • bindings/js/ScriptObjectQuarantine.cpp: Added.
  • bindings/js/ScriptObjectQuarantine.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind. (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind. (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
  • inspector/InspectorController.h: Removed addScriptDatabaseResource and removeScriptDatabaseResource declarations.
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): Added. (WebCore::InspectorDatabaseResource::unbind): Added.
  • inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
2:26 PM Changeset in webkit [41683] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-03-13 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24467
Make Skia drawRect() and stroke behavior match CG.

This makes drawRect() ignore the stroke width (like CG does), and
adds a warning comment about that to the appropriate header.

It also eliminates some hacky code in Skia's stroke preparation,
which tried to adjust odd-width strokes to fall on pixel boundaries.
Not only did this not match CG, it wouldn't necessarily work right,
because there could be other transforms (e.g. full-page zoom) that
would affect the stroke before it reached the device pixel level.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintForStroking):
1:45 PM Changeset in webkit [41682] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24583
Need to change scope of constructor and destructor of V8ObjectEventListener from private
to protected so that they could be used in its derived class V8WorkerContextEventListener.

  • bindings/v8/V8ObjectEventListener.h:
12:53 PM Changeset in webkit [41681] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <​andersca@apple.com>

And yet another attempt...


  • Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler):
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
12:52 PM Changeset in webkit [41680] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <​andersca@apple.com>

Another attempt at fixing the build.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
12:39 PM Changeset in webkit [41679] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <​andersca@apple.com>

Try to fix the SL build.

  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown):
12:13 PM Changeset in webkit [41678] by levin@chromium.org
  • 1 edit
    8 moves in trunk/WebCore

2009-03-13 David Levin <​levin@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24579
Many V8*Event* files are misplaced.

This code is infrastructure for supporting the bindings and thus should
be in the bindings/v8 directory.

  • bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
  • bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
  • bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
  • bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
  • bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
  • bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
  • bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
  • bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
12:06 PM Changeset in webkit [41677] by adele@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

2009-03-13 Adele Peterson <​adele@apple.com>

Reviewed by Justin Garcia.

Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

Test: editing/pasteboard/5089327.html

Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans):

LayoutTests:

2009-03-13 Adele Peterson <​adele@apple.com>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

  • editing/pasteboard/5089327.html: Added.
  • platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5089327-expected.png: Added.
  • platform/mac/editing/pasteboard/5089327-expected.txt: Added.

Updated colors for pasted content.

  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:
11:57 AM Changeset in webkit [41676] by andersca@apple.com
  • 2 edits in trunk/WebKitExamplePlugins

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Update to match new API.


  • NetscapeInputMethodPlugin/main.m: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleDraw): (invalidatePlugin): (handleFocusChanged): (handleMouseMoved): (handleMouseDown): (handleTextFieldKeyDown): (handleTextInput): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
11:56 AM Changeset in webkit [41675] by bolsinga@apple.com
  • 14 edits
    3 adds in trunk

2009-03-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
​https://bugs.webkit.org/show_bug.cgi?id=24505

WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.


WebChromeClient now calls the private UI delegate method
-webView:frame:requestGeolocationPermission:securityOrigin:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestGeolocationPermissionForFrame):
  • WebCoreSupport/WebGeolocation.mm: Added. (WebCore::if): (-[WebGeolocation shouldClearCache]): (-[WebGeolocation setIsAllowed:]): (-[WebGeolocation dealloc]):
  • WebCoreSupport/WebGeolocationInternal.h: Added.
  • WebCoreSupport/WebGeolocationPrivate.h: Added.
  • WebView/WebUIDelegatePrivate.h:

2009-03-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
​https://bugs.webkit.org/show_bug.cgi?id=24505

Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.

  • WebKit.xcodeproj/project.pbxproj:

2009-03-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
​https://bugs.webkit.org/show_bug.cgi?id=24505

Geolocation now requests permission from the Chrome asynchronously.
The Chrome is passed the Geolocation object, and the Chrome sets the permission
on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
of SecurityOrigins with geolocation permission. This is so that the GeolocationService
can inform the Chrome of its request, and the Chrome is also free to implement its
own policy.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::requestGeolocationPermissionForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::displayChallengeIfNecessary): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h: (WebCore::Geolocation::isAllowed): (WebCore::Geolocation::setShouldClearCache): (WebCore::Geolocation::shouldClearCache): (WebCore::Geolocation::):
11:44 AM Changeset in webkit [41674] by andersca@apple.com
  • 12 edits
    1 delete in trunk

WebCore:

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Add a NPCocoaEventTextInput event type. Remove the text input variables.


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit:

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Remove nptextinput.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Replace the text input API with a simpler API that uses a separate text input window.


  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): Initialize m_keyEventHandler to 0.


(WebNetscapePluginEventHandlerCocoa::keyDown):
If the plug-in returns 0 from NPP_HandleEvent, pass the event to the TSM machinery.


(WebNetscapePluginEventHandlerCocoa::focusChanged):
Install/remove the key event handler as needed.


(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
Get the text and send a TextInput event.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Remove the old text input API.


(-[WebNetscapePluginView inputContext]):
Always return nil here.


  • Plugins/npapi.mm:
  • Plugins/nptextinput.h: Removed.

WebKitTools:

2009-03-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Add a case statement for NPCocoaEventTextInput.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa):
11:18 AM Changeset in webkit [41673] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed


The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
for x-oleobject.


  • rendering/RenderPartObject.cpp: (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
10:57 AM WebKit Team edited by abarth@webkit.org
(diff)
10:47 AM WebKit Team edited by dimich@chromium.org
(diff)
10:45 AM Changeset in webkit [41672] by pam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Fisher.

Add tests for window property lookup precedence in the presence of
conflicting names in a child frame and in a named document element.

​https://bugs.webkit.org/show_bug.cgi?id=24170

  • fast/dom/Window/resources/window-properties.js: Added.
  • fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • fast/dom/Window/window-lookup-precedence.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldEvaluateTo): Added. Compares expected values of various types.
10:32 AM Changeset in webkit [41671] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24559
Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.

  • bindings/v8/custom/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
10:32 AM Changeset in webkit [41670] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24557
This is to support running multiple workers in a single worker process in chromium.

  • bindings/v8/custom/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): Add locker to v8 event listener of worker context.
10:09 AM Changeset in webkit [41669] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-13 Pamela Greene <​pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to ensure that DOM constructors have higher lookup
precedence than a document element with the same name.

​https://bugs.webkit.org/show_bug.cgi?id=24520

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
9:52 AM WebKit Team edited by pam@chromium.org
(diff)
9:20 AM Changeset in webkit [41668] by pam@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <​pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that the JS wrapper for the document in an
inner frame is created in the correct context when it's accessed
from the outer frame first.

​https://bugs.webkit.org/show_bug.cgi?id=24564

  • fast/dom/resources/wrapper-context-inner.html: Added.
  • fast/dom/wrapper-context-expected.txt: Added.
  • fast/dom/wrapper-context.html: Added.
9:11 AM WebKit Team edited by treat@kde.org
Update with new reviewers and affiliations (diff)
6:25 AM Changeset in webkit [41667] by ap@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=24575
XHR response is incorrect after a network error.

Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html

http/tests/xmlhttprequest/cross-site-denied-response-sync.html
http/tests/xmlhttprequest/cross-site-denied-response.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request. (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note that since internalAbort() can drop GC protection, it is not safe to use the object after this call. (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and return early if it was. This can happen during sync requests, as the loader does not know that it was aborted, and just synthesizes all callbacks.
5:57 AM Changeset in webkit [41666] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Updating results after the fix for bug 3547.

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: The status text for a failed local file load is no longer "OK", which is good.
4:06 AM Changeset in webkit [41665] by ap@webkit.org
  • 5 edits
    4 adds in trunk

2009-03-13 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=3547
XMLHttpRequest.statusText returns always "OK"

Covered by existing tests (which now pass on all platforms but Mac).

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up to each platform to correctly set the status text or set it to "OK" to retain current behavior.
3:05 AM Changeset in webkit [41664] by ap@webkit.org
  • 2 edits in trunk/WebCore

2009-03-13 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24349
[QT] HTTP status text is never set

Set HTTP status text to the reason phrase attribute of QNetworkReply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
Note: See TracTimeline for information about the timeline view.