⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 13, 2009:

11:39 PM Changeset in webkit [42480] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Missed code from last patch

11:33 PM Changeset in webkit [42479] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 David Hyatt <​hyatt@apple.com>

Reviewed by Cameron Zwarich.

Remove an outdated comment in ScrollView.h

  • platform/ScrollView.h:
11:24 PM Changeset in webkit [42478] by oliver@apple.com
  • 6 edits
    4 adds in trunk

BUG 25171: It should be possible to manually set the name of an anonymous function
<​https://bugs.webkit.org/show_bug.cgi?id=25171>

Submitted by Francisco Tolmasky <​francisco@280north.com>
Reviewed by Oliver Hunt.

This change adds the displayName property to functions, which when set overrides the
normal name when appearing in the console.

10:30 PM Moving to Git edited by John Haitas
trivial fix incorrect 'there' replaced with correct 'their' (diff)
10:03 PM Changeset in webkit [42477] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25177

QTTrack's -media method always return NULL in 64-bit QTKit, so
MediaPlayerPrivate::disableUnsupportedTracks should use
QTTrackMediaTypeAttribute to get a track's type.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
9:52 PM Changeset in webkit [42476] by ggaren@apple.com
  • 8 edits in trunk/WebCore

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

More fix for ​https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions

Stop using protected event listeners on the window object.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're no longer protected.

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Create unprotected event
listeners, since we mark them now.

  • bindings/js/JSEventListener.h: Made some functions public so DOMWindow could call them.
  • bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header, so it could be shared.
  • bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking and invalidating code for the DOMWindow.
  • dom/RegisteredEventListener.h: (WebCore::markEventListeners): (WebCore::invalidateEventListeners): Added helper functions.
  • page/DOMWindow.idl: Make the window's event listener attributes not protected.
9:13 PM Changeset in webkit [42475] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Mark Rowe.

OS X standalone media documents should not switch from <video> to <embed> when
QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
with a slow network connection or when a movie is not saved fast-start.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
6:03 PM Changeset in webkit [42474] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-04-13 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24453
REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
the main document that timer callback makes are not flushed.

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded() since timers may affect documents other then their own.
5:21 PM Changeset in webkit [42473] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by David Hyatt.

Check document for nullity to avoid crashing on GTK+, when
creating the WebView.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
5:19 PM Changeset in webkit [42472] by adachan@apple.com
  • 2 edits in trunk/WebCore

Forgot to capitalize the "US".

  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
5:10 PM Changeset in webkit [42471] by adachan@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
Revert back to the old word breaking behavior by using en_US_POSIX locale.

Reviewed by Steve Falkenburg.

  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
4:42 PM Changeset in webkit [42470] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Darin.

<rdar://problem/6784955> REGRESSION: closing a tab containing a PDF causes world leaks


Simplify the _trackFirstResponder method by just caching the value instead of retaining
a Cocoa object.


  • WebView/WebPDFView.h: Eliminated trackedFirstResponder object and replaced it with a firstResponderIsPDFDocumentView boolean.
  • WebView/WebPDFView.mm: (-[WebPDFView dealloc]): Removed no longer necessary ASSERT. (-[WebPDFView viewWillMoveToWindow:]): Removed call to release and nil-out trackedFirstResponder, which no longer exists. In the new code all we do now is set firstResponderIsPDFDocumentView to NO. (-[WebPDFView _trackFirstResponder]): Rewrote this method to just cache the value instead of retaining an object.
3:36 PM Changeset in webkit [42469] by Darin Adler
  • 4 edits in trunk/WebKitTools

2009-04-13 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

  • Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to make these scripts work better with the build window in new versions of Xcode.
  • Scripts/check-for-global-initializers: Ditto.
  • Scripts/check-for-weak-vtables: Ditto.
3:18 PM Changeset in webkit [42468] by Darin Adler
  • 3 edits in trunk/WebCore

2009-04-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • platform/cf/BinaryPropertyList.cpp: Added comment.
  • platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
3:16 PM Changeset in webkit [42467] by Darin Adler
  • 8 edits
    2 adds in trunk

WebCore:

2009-04-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
​https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693

Test: editing/selection/click-after-nested-block.html

  • rendering/RenderBlock.cpp: (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint can share code. (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first child box. Changed special case for last child box to propertly handle the various types of child box that are not hit test candidates (the same ones already handled by the hit test loop below), adding in a loop so we find the last candidate.

LayoutTests:

2009-04-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
​https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693

  • editing/selection/click-after-nested-block-expected.txt: Added.
  • editing/selection/click-after-nested-block.html: Added.
  • fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
  • fast/events/pointer-events.html: Changed this to a plain-text test, because the old results reflected a difference in hit testing behavior that this test was not intended to exercise and it's better to have the test be more cross-platform. Also removed unneeded use of waitUntilDone.
  • fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by running the make-js-test-wrappers script. If we want to include type and charset attributes in the script elements, we can change make-js-test-wrappers to do that for all tests at some point.
  • fast/js/function-apply-aliased.html: Ditto.
  • fast/js/function-call-aliased.html: Ditto.
2:44 PM Changeset in webkit [42466] by ggaren@apple.com
  • 4 edits in trunk

JavaScriptCore:

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.

  • tests/mozilla/expected.html:

WebKitTools:

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.

  • Scripts/run-javascriptcore-tests:
2:39 PM Changeset in webkit [42465] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/accessibility/frame-with-title-expected.txt

Update accessibility layout test from last checkin.

2:34 PM Changeset in webkit [42464] by hyatt@apple.com
  • 9 edits in trunk

Webcore:

2009-04-13 David Hyatt <​hyatt@apple.com>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

  • WebCore.base.exp:
  • page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
  • platform/ScrollView.h:

WebKit/mac:

2009-04-13 David Hyatt <​hyatt@apple.com>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

This patch also eliminates WebHTMLView's separate notion of needing a layout and just consolidates it with
WebCore's notion of needing layout.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]): (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _needsLayout]):
  • WebView/WebHTMLViewInternal.h:
2:31 PM Changeset in webkit [42463] by Adam Roben
  • 7 edits in trunk

Windows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

Add SharedBuffer::wrapCFData

This is the CF-equivalent of wrapNSData.

Reviewed by Brady Eidson.

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::wrapCFData):

WebKit/win:

Windows part 2 of <rdar://5438063> Saving history containing 100,000
entries causes pauses of 2s while browsing

Reviewed by Brady Eidson.

  • Interfaces/IWebHistoryPrivate.idl: Added data, analagous to WebKit/mac's -[WebHistory _data] method.
  • WebHistory.cpp: (WebHistory::saveHistoryGuts): Changed to call data() to get the data for saving. (WebHistory::data): Added. Returns the data for saving as an IStream. (WebHistory::data): Added. Returns the data for saving as a CFDataRef.
  • WebHistory.h: Added data.
2:27 PM Changeset in webkit [42462] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Further massage tests to disable tests that are failingto make the
results more useful.

  • platform/gtk/Skipped:
2:09 PM Changeset in webkit [42461] by ggaren@apple.com
  • 4 edits in trunk

JavaScriptCore:

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.

  • tests/mozilla/expected.html: Updated expected results.

WebKitTools:

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.

  • Scripts/run-javascriptcore-tests:
1:57 PM Changeset in webkit [42460] by justin.garcia@apple.com
  • 1 edit in trunk/WebCore/page/EventHandler.cpp

Adding a comment to my previous code change.

1:55 PM Changeset in webkit [42459] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-04-13 Darin Adler <Darin Adler>

  • WebView/WebViewPrivate.h: Updated comments.
1:48 PM Changeset in webkit [42458] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • page/EventHandler.cpp: (WebCore::documentPointForWindowPoint):
1:46 PM Changeset in webkit [42457] by Antti Koivisto
  • 14 edits in trunk

WebCore:

2009-04-13 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.

<rdar://problem/6740294> Increase the connection count per host


Try to use six connections per host if possible.

  • WebCore.base.exp:
  • loader/loader.cpp: (WebCore::Loader::Loader):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceRequestBase.cpp: (WebCore::initMaximumHTTPConnectionCountPerHost):
  • platform/network/ResourceRequestBase.h:
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::initMaximumHTTPConnectionCountPerHost):

WebKit/mac:

2009-04-13 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.


<rdar://problem/6740294> Increase the connection count per host

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

2009-04-13 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.


<rdar://problem/6740294> Increase the connection count per host

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
1:38 PM Changeset in webkit [42456] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-13 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=25153
Can't place the caret into text field that scrolls the window on focus


We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
coordinate) and use that any time we refetch.

  • page/EventHandler.cpp: (WebCore::documentPointForWindowPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::prepareMouseEvent):

LayoutTests:

2009-04-13 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.


<rdar://problem/6748324> REGRESSION (Kirkwood): Can't type in Netflix search field

  • fast/forms/25153-expected.txt: Added.
  • fast/forms/25153.html: Added.
1:29 PM Changeset in webkit [42455] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-13 Sam Weinig <​sam@webkit.org>

Fix bad expected result.

  • fast/frames/frame-unload-crash-expected.txt:
1:26 PM Changeset in webkit [42454] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-04-13 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
to conform to our style guidelines.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::allowPopUp):
  • page/Settings.h: (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
1:24 PM Changeset in webkit [42453] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Mac build fix: Made another header private.

  • WebCore.xcodeproj/project.pbxproj:
1:20 PM Changeset in webkit [42452] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-04-13 Jian Li <​jianli@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=25121
Upstream changes to handle error messages from V8 when running worker script.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::reportFatalErrorInV8): (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h:
1:18 PM Changeset in webkit [42451] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-13 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Tweak my last check-in, moving the thread violation check up to the API-level calls so the logging is more
useful to developers/users.

  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not on the main thread, only perform the "call on main thead" workaround, as the log/exception raising is now up at the API level. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Perform a thread violation check here so logging is more meaningful. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
1:16 PM Changeset in webkit [42450] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Build fix: Made setInlineEventListenerForType not inline, since Document
calls it now. Made RegisteredEventListener.h a private header on Mac,
so WebKit can use it.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType):
1:14 PM Changeset in webkit [42449] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/6404439> REGRESSION: Overlapping text and other layout issues in View Sample feature of MYOB FIrstEdge v3
  • page/Navigator.cpp: (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of JavaScript files this quirk applies to.
1:03 PM Changeset in webkit [42448] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-13 Brady Eidson <​beidson@apple.com>

Reviewed by Kevin Decker

<rdar://problem/6712063> Garmin WebUpdater crashes

  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not called on the main thread, add a ThreadViolationCheckRoundTwo() call to either log or raise an exception. In the case where it's only a log, reschedule the _loadData call to occur on the main thread.
12:50 PM Changeset in webkit [42447] by weinig@apple.com
  • 13 edits in trunk

WebCore:

2009-04-13 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Move open and showModalDialog functions out of JSDOMWindowBase
and into JSDOMWindow by partially generating them.

This slightly changes the behavior of getting window.showModalDialog
when the embedding app does not support it to return undefined regardless
of shadowing. This should not be an issue in a practice, but will be addressed
when we add a generic way to handle runtime specialization of property
access.

  • DerivedSources.make: Remove JSDOMWindowBase.lut.h
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::): (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from here to JSDOMWindow::customGetOwnPropertySlot. (WebCore::JSDOMWindowBase::put): Remove dead code.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase. (WebCore::DOMWindow::allowPopUp): Ditto. (WebCore::DOMWindow::canShowModalDialog): Ditto. (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-04-13 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Update tests after moving showModalDialog from JSDOMWindowBase to
JSDOMWindow and slightly changing the behavior when showModalDialog
is not available, as is the case for DumpRenderTree.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
12:43 PM Changeset in webkit [42446] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Moved storage for window event listeners into the window object.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): Add / remove window event listeners to / from the window object.
  • dom/Document.cpp: (WebCore::Document::removeAllEventListeners): (WebCore::Document::clear): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved a bunch of code to the DOMWindow class, and left behind a few calls through to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
  • dom/Document.h: ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window object, not the document.
  • dom/Node.h:
  • dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector declaration, since it's required in more places now.
  • history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Updated for rename. Also, remove event listeners before detaching and clearing the document's window pointer, since the the document needs its window pointer in order to tell the window to clear its event listeners.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and movement of window event listeners into the window.
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for movement of window event listeners into the window.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::handleEvent): (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners): (WebCore::DOMWindow::hasEventListener): (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::removeInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::addPendingFrameUnloadEventCount): (WebCore::DOMWindow::removePendingFrameUnloadEventCount): (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount): (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
  • page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
  • page/Frame.cpp: (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
12:05 PM Changeset in webkit [42445] by bolsinga@apple.com
  • 4 edits in trunk/WebCore

2009-04-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25149

The Geolocation timer needs to start after the UA has granted permission.

  • bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions> (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions> where needed. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::startTimer): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows (WebCore::Geolocation::startTimer): (WebCore::Geolocation::startTimersForOneShots): (WebCore::Geolocation::startTimersForWatchers): (WebCore::Geolocation::startTimers):
  • page/Geolocation.h: (WebCore::Geolocation::GeoNotifier::create):
11:01 AM Changeset in webkit [42444] by pam@chromium.org
  • 3 edits in trunk/WebCore

2009-04-13 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Fisher.

Fix Chromium (V8) build by renaming methods to match changes
in ​http://trac.webkit.org/changeset/42377.

​https://bugs.webkit.org/show_bug.cgi?id=25141

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
10:52 AM Changeset in webkit [42443] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-04-13 Darin Adler <Darin Adler>

  • Scripts/make-js-test-wrappers: Added another exception.
10:47 AM Changeset in webkit [42442] by darin@chromium.org
  • 3 edits
    5 adds in trunk

2009-04-13 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25136
CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame

Test: fast/frames/frame-unload-crash.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
10:38 AM Changeset in webkit [42441] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-04-13 Sam Weinig <​sam@webkit.org>

Reviewed by Tim Hatcher.

Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.

  • page/DOMWindow.idl:

LayoutTests:

2009-04-13 Sam Weinig <​sam@webkit.org>

Reviewed by Tim Hatcher.

Update test results after putting the MessagePort constructor
back in ENABLE_CHANNEL_MESSAGING.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
10:24 AM Changeset in webkit [42440] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 Greg Bolsinga <​bolsinga@apple.com>

Fix GTK build break.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
10:14 AM Changeset in webkit [42439] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-13 David Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler and Dan Bernstein.

Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
Schedule a style recalc if needed when an object comes out of the page cache.

  • dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::setInPageCache):
10:11 AM Changeset in webkit [42438] by timothy@apple.com
  • 3 edits in trunk/WebCore

Correctly sort (program) scripts in the Scripts panel popup menu.

Reviewed by Ada Chan.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code and sort "(program)" options by the sourceID to maintain some order.
  • inspector/front-end/utilities.js: (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction. Just set 'first' and break so the correct result will be returned.
10:07 AM Changeset in webkit [42437] by bolsinga@apple.com
  • 10 edits
    1 add in trunk/WebCore

2009-04-13 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24770


Add custom code for Coordinates that returns null when required by the
Geolocation spec.


​http://dev.w3.org/geo/api/spec-source.html#coordinates

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCoordinatesCustom.cpp: Added. (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided. (WebCore::JSCoordinates::altitudeAccuracy): Ditto (WebCore::JSCoordinates::heading): Ditto (WebCore::JSCoordinates::speed): Ditto
  • page/Coordinates.h: (WebCore::Coordinates::create): Add 'canProvide' parameters and values (WebCore::Coordinates::canProvideAltitude): (WebCore::Coordinates::canProvideAltitudeAccuracy): (WebCore::Coordinates::canProvideHeading): (WebCore::Coordinates::canProvideSpeed): (WebCore::Coordinates::Coordinates):
  • page/Coordinates.idl: specify custom getters
  • platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
9:27 AM Changeset in webkit [42436] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing

Added simple printing unit tests.

  • tests/testwebframe.c: (print_requested_cb): (print_timeout): (test_webkit_web_frame_printing): (main):
9:26 AM Changeset in webkit [42435] by kov@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing

Implement proper printing API, using the GTK+ printing API.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
9:15 AM Changeset in webkit [42434] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Reworked the skipped tests listing so that it is easier to find
tests that are skipped but pass using diff. Enable all tests that
are passing, and disable failing tests except for a few crashers
and known regressions. This is an effort to make the build slave
output more useful when it is back.

  • platform/gtk/Skipped:
8:12 AM Changeset in webkit [42433] by adele@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-04-13 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

Test: editing/inserting/5510537.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.

LayoutTests:

2009-04-13 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

  • editing/inserting/5510537.html: Added.
  • platform/mac/editing/inserting/5510537-expected.checksum: Added.
  • platform/mac/editing/inserting/5510537-expected.png: Added.
  • platform/mac/editing/inserting/5510537-expected.txt: Added.
7:46 AM Changeset in webkit [42432] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Fix problem when encoding history files with duplicate integer arrays near the end of the file.
This results in an assertion failure, and if assertions are turned off, corrupted output.

When writing an integer array it's important not to add an object reference to the
aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
more importantly, it's possible this instance integer array is a duplicate and won't be
written out. If so, there's no guarantee there's enough space in the aggregate buffer to
store the object references (the references will be ignored). In some cases the aggregate
buffer can then overrun the data being written; normally this is prevented by the fact that
the data being written will include a copy of the aggregate buffer.

Also removed a bit of unneeded dead code to handle the integer -1.

  • platform/cf/BinaryPropertyList.cpp: (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded m_integerNegativeOneObjectReference, since property lists support only non-negative integers. (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for m_integerNegativeOneObjectReference. (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto. (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference): Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling addAggregateObjectReference. (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new writeIntegerWithoutAddingAggregateObjectReference function. (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the code to save and restore m_currentAggregateBufferByte, which is no longer needed.
4:31 AM Changeset in webkit [42431] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed Qt build fix

Apr 12, 2009:

5:41 PM Changeset in webkit [42430] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-04-12 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move the event and crypto attributes and the captureEvents and releaseEvents
functions out of JSDOMWindowBase by partially generating them.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::currentEvent): Make const.
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::crypto): Not implemented. (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::captureEvents): Not implemented. (WebCore::JSDOMWindow::releaseEvents): Ditto.
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update test result for new nop window.crypto behavior.

  • http/tests/security/cross-frame-access-get-expected.txt:
4:42 PM Changeset in webkit [42429] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

2009-04-12 Sam Weinig <​sam@webkit.org>

Update results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
4:10 PM Changeset in webkit [42428] by weinig@apple.com
  • 10 edits in trunk

WebCore:

2009-04-12 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move more attributes out of JSDOMWindowBase by
partially generating them.

  • Expose the MessagePort constructor.
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xMLHttpRequest): (WebCore::JSDOMWindow::xSLTProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update tests after making MessageChannel completely missing when not
compiling with support for it (and removing it from the tests because
we never compile with support for it right now) and exposing the MessagePort
constructor.

  • fast/dom/constructors-cached-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/resources/constructors-cached.js:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
10:57 AM Changeset in webkit [42427] by timothy@apple.com
  • 2 edits in trunk/WebCore

A resource's filename is not correct after a redirect in the Inspector.

Reviewed by Dan Bernstein.

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): Fix a typo in the lastPathComponent property name.
9:24 AM Changeset in webkit [42426] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-12 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test: editing/inserting/6609479-1.html

Follow-up to <rdar://problem/6609479>.

Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
at the start of a paragraph.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):

LayoutTests:

2009-04-12 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Another test for <rdar://problem/6609479>. This covers inserting HTML in a quoted table.

  • editing/inserting/6609479-1-expected.txt: Added.
  • editing/inserting/6609479-1.html: Added.

Apr 11, 2009:

10:49 PM Changeset in webkit [42425] by adele@apple.com
  • 8 edits
    2 adds in trunk

WebCore:

2009-04-11 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

Test: editing/inserting/6609479.html

Don't break a blockquote if pasting or inserting into a table.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):

LayoutTests:

2009-04-11 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

  • editing/inserting/5418891.html: Changed test so it doesn't involve tables.
  • editing/inserting/6609479-expected.txt: Added.
  • editing/inserting/6609479.html: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5418891-expected.txt:
6:11 PM Changeset in webkit [42424] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6643103> Unscaled values from body.scrollHeight

Test: fast/css/zoom-body-scroll.html

Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
setters.

  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6643103> Unscaled values from body.scrollHeight
  • fast/css/zoom-body-scroll-expected.txt: Added.
  • fast/css/zoom-body-scroll.html: Added.

Apr 10, 2009:

10:40 PM Changeset in webkit [42423] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Jon Honeycutt.

  • fix <rdar://problem/6752340> Light blue-green background in content area in Mail
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Use device white, rather than calibrated white, as the default background color.
10:31 PM Changeset in webkit [42422] by timothy@apple.com
  • 8 edits in trunk/WebCore

Allow page navigation and reload while stopped at a breakpoint.

<rdar://problem/6781108> Having a breakpoint active prevents page reload

Reviewed by Darin Adler.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue): Call the resumedScript function.
  • inspector/InspectorController.h: Added didContinue.
  • inspector/JavaScriptDebugListener.h: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
  • inspector/front-end/inspector.js: (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
7:18 PM Changeset in webkit [42421] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land corrected results for complex-character-based-fallback.html

  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
5:56 PM Changeset in webkit [42420] by Darin Adler
  • 1 edit
    1 move in trunk/LayoutTests

2009-04-10 Darin Adler <Darin Adler>

Rubber stamped by Adam Roben.

Disabled fast/dom/gc-8.html, which was using Timer in an unsafe way that now
triggers an assertion.

We'll reenable the test after fixing the problem. But this is a test-only problem.

  • fast/dom/gc-8.html: Removed.
  • fast/dom/gc-8.html-disabled: Copied from fast/dom/gc-8.html.
5:47 PM Changeset in webkit [42419] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC


r21436 changed the semantics of AXObjectCache::get() to not create
objects on demand. Changing this get() call into a getOrCreate() call
fixes the crash.


Rubber stamped by Jon Honeycutt.

  • AccessibleDocument.cpp: (AccessibleDocument::AccessibleDocument):
5:43 PM Changeset in webkit [42418] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Remove unused include for JSLock.

  • page/mac/FrameMac.mm:
5:41 PM Changeset in webkit [42417] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Add back the keepAlive timer for after the script execution to
protect the callers of evaluate, as was part of the original intent
of timer.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • page/mac/FrameMac.mm:
5:39 PM Changeset in webkit [42416] by mitz@apple.com
  • 7 edits
    3 adds in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • test and expected result updates following r42379
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt: Updated results.
  • fast/text/offsetForPosition-cluster-at-zero.html: Removed font-dependent alert that was accidently left in this test.
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.txt: Added.
  • platform/win/Skipped:
5:26 PM Changeset in webkit [42415] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=25137

If we reload, the animation controller sticks around and has
a stale animation time. So the needed delay is computed wrong.
I added a reset of the animation timer on load.

I did not do a test case because this only happens on reload so I
couldn't make an automated test. I tried using an iframe and using
reload() but that doesn't tickle the bug.

5:13 PM Changeset in webkit [42414] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add our new test font to the list that DRT knows about

Reviewed by Dan Bernstein.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Added WebKit Layout Tests 2.ttf.
5:10 PM Changeset in webkit [42413] by Darin Adler
  • 4 edits in trunk/WebCore

2009-04-10 Grace Kloba <​klobag@gmail.com>

Reviewed by Darin Adler.

Move WORKERS header files inside ENABLE(WORKERS).
So if WORKERS is not enabled and the generated files are not generated, the build is still working.

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSMessageChannelConstructor.cpp:
  • bindings/js/ScheduledAction.cpp:
4:59 PM Changeset in webkit [42412] by Darin Adler
  • 7 edits in trunk

WebCore:

2009-04-10 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.
This adds some diagnostics so we'll catch that kind of mistake immediately.

  • platform/Timer.cpp: (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions. (WebCore::TimerBase::start): Assert it's the same thread the timer was created on. (WebCore::TimerBase::stop): Ditto. (WebCore::TimerBase::isActive): Ditto. (WebCore::TimerBase::setNextFireTime): Ditto.
  • platform/Timer.h: Added the thread identifier data member.

WebKit/mac:

2009-04-10 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.

  • History/WebHistoryItem.mm: (-[WebWindowWatcher windowWillClose:]): Call later on main thread, if called on non-main thread.
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView _updateControlTints]): Added. Factored out the non-thread-safe part of our override of _windowChangedKeyState. (-[WebHTMLView _windowChangedKeyState]): Call _updateControlTints later on main thread, if called on non-main thread.
  • WebView/WebPreferences.mm: (-[WebPreferences _postPreferencesChangesNotification]): Call later on main thread, if called on non-main thread
4:39 PM Changeset in webkit [42411] by Adam Roben
  • 2 edits in trunk/WebKit/win

Add our invidual IDL files back to Interfaces.vcproj, but disable them

This allows the IDL files to be found in Solution Explorer.

Rubber-stamped in advance by Steve Falkenburg.

  • WebKit.vcproj/Interfaces.vcproj:
4:19 PM Changeset in webkit [42410] by Simon Fraser
  • 5 edits
    2 adds in trunk

2009-04-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=25108

If you remove a class with a transition while that transition is running
the animation timer will continue to fire after the transition is finished.
This has no visual indication, but it does drain the processor. And in some
cases it might even cause a glitch in future animations. Unfortunately there
is no way to test this without putting in printfs.

This happens because the animation logic is never traversed after a transition
is removed, so we never get a chance to cleanup. So I added cleanup in the logic
that fires the dispatch of the last style change when the animation finishes.

Test: transitions/remove-transition-style.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
3:52 PM Changeset in webkit [42409] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6648858>
CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241

The Frame (and therefore ScriptController) were being destroyed
during JavaScript execution causing the JSDOMWindowShell to become
null.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame instead of the keep-alive timer, since a nested event loop used from with-in JavaScript execution could cause the timer to fire before returning.
3:30 PM ApplicationsGtk edited by evandrofisico@gmail.com
Correct claws-mail webkit plugin URL (diff)
3:27 PM Changeset in webkit [42408] by Dimitri Glazkov
  • 7 edits in trunk/WebCore

2009-04-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=25133
Fix an error in InspectorController's bindings, clean up a few header
includes, make empty object construction in ScriptObject less ambiguous.

  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::setSetting): Send correct argument from

the bindings.

  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::createNew): Added.
  • bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
  • inspector/ConsoleMessage.cpp: Remove unused header.
  • inspector/ConsoleMessage.h: Ditto.
  • inspector/InspectorResource.cpp: (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
2:50 PM Changeset in webkit [42407] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben.

  • re-enable css2.1 tests that were disabled following r42379 and make them use a different fallback font for certain characters, to get the vertical metrics to match Mac
  • platform/win/Skipped:
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
2:44 PM Changeset in webkit [42406] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=25134

This both fixes a bug where I was not sending in the right time
to continue the animation and was not recomputing current time
when coming out of suspend.

1:48 PM Changeset in webkit [42405] by eric.carlson@apple.com
  • 3 edits in trunk/WebKitLibraries

2009-04-10 Eric Carlson <​eric.carlson@apple.com>

WebKitSystemInterface changes for <rdar://problem/6646998>

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
1:41 PM Changeset in webkit [42404] by timothy@apple.com
  • 1 edit in trunk/WebCore/bindings/js/ScriptCachedFrameData.cpp

Revert an unintentional logic change in r42400.

1:17 PM Changeset in webkit [42403] by Simon Fraser
  • 3 edits in trunk/WebKitLibraries

2009-04-10 Simon Fraser <Simon Fraser>

Fix the leopard build by updating WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
1:07 PM Changeset in webkit [42402] by timothy@apple.com
  • 3 edits
    1 delete in trunk/WebKit

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

WebKit:

2009-04-10 Timothy Hatcher <​timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-04-10 Timothy Hatcher <​timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • Misc/DOMDocumentPrivate.h: Removed.
1:05 PM Changeset in webkit [42401] by Adam Roben
  • 2 edits in trunk/WebCore

Give Windows's <select> popup menus drop shadows

Rubber-stamped by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
1:00 PM Changeset in webkit [42400] by timothy@apple.com
  • 4 edits in trunk/WebCore

Fix a bug in the Web Inspector where it would show scripts
from previous pages when toggling the debugger off and back on.

​https://bugs.webkit.org/show_bug.cgi?id=25095
rdar://problem/6769970

Reviewed by John Sullivan.

  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the debugger for the scriptController. This balances the attachDebugger that was already in ScriptCachedFrameData::restore. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Clear the debugger from the current window before setting the new window.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate source providers for code associated this as the debugger.
12:17 PM Changeset in webkit [42399] by eric.carlson@apple.com
  • 7 edits in trunk

2009-04-10 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

When possible avoid asking QTKit for the MIME types that require QTKitServer
when running 64-bit.

  • WebCore.base.exp: Added new entry point.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add an NSArray of types to the cache. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does not start QTKitServer if it is not already running). (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid starting QTKitServer if possible.
  • platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-10 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes.
11:55 AM Changeset in webkit [42398] by Adam Roben
  • 2 edits in trunk/WebCore

Turn on window animations for <select> popup menus

We turned these off back when <select> popup menus were partially
transparent. Now that they're opaque, there's no reason not to
animate them.

Reviewed by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the window animation.
11:39 AM Changeset in webkit [42397] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • skip failures following r42379 until they are addressed by code changes or test changes
  • platform/win/Skipped:
11:32 AM Changeset in webkit [42396] by mitz@apple.com
  • 6 edits in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix a regression from r42379 which made zero-width characters affect line height

Test: fixes fast/text/wide-zero-width-space.html

  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation): Add to the fallback font list set here, and only if the glyph is not zero-width... (WebCore::ATSULayoutParameters::initialize): ...instead of doing it here. This matches WidthIterator's behavior.

LayoutTests:

Reviewed by Sam Weinig.

  • revert broken test results that were checked in with r42379, now that the regression is fixed
  • platform/mac/fast/text/wide-zero-width-space-expected.checksum:
  • platform/mac/fast/text/wide-zero-width-space-expected.png:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt:
11:31 AM Changeset in webkit [42395] by Adam Roben
  • 4 edits in trunk/LayoutTests

Update Windows results for complex-character-based-fallback.html

Rubber-stamped by Dan Bernstein.

  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Updated.
10:39 AM Changeset in webkit [42394] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-10 Darin Fisher <​darin@chromium.org>

Fixing build bustage caused by warnings being treated as errors.
1- A local variable was only be used inside a debug assertion, which

caused grief for the release build.

2- Missing initializer for member 'DocumentMarker::activeMatch'

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::setMarkersActive):
10:24 AM Changeset in webkit [42393] by darin@chromium.org
  • 9 edits in trunk/WebCore

2009-04-10 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by John Sullivan.

Fixing: ​https://bugs.webkit.org/show_bug.cgi?id=25117
(TextMatches don't have a concept of active match)

For the ports that use the DocumentMarker as highlighting for FindInPage it is
useful to have a flag that specifies which marker is active, so it can be drawn
in a different color.

This allows me to remove the hack to use the SelectionController to highlight
the active match (in the ChromiumWin port).

  • dom/Document.cpp: (WebCore::Document::setMarkersActive):
  • dom/Document.h:
  • dom/DocumentMarker.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformActiveTextSearchHighlightColor): (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
  • rendering/RenderThemeChromiumWin.h:
10:13 AM Changeset in webkit [42392] by pam@chromium.org
  • 2 edits in trunk/WebCore

2009-04-10 Pamela Greene <​pam@chromium.org>

Reviewed by Dimitri Glazkov.

Build fix for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=12440

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
5:03 AM Changeset in webkit [42391] by kov@webkit.org
  • 13 edits in trunk/WebKit/gtk

WebKit/gtk/

2009-04-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Mark the missing strings for translation.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_cancel):
  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
  • webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp:

WebKit/gtk/po/

2009-04-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Extracting translation for the files that got translation calls.

  • POTFILES:
  • de.po:
  • pt_BR.po:
  • webkit.pot:
Note: See TracTimeline for information about the timeline view.