⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 12, 2009:

11:11 PM Changeset in webkit [49492] by eric@webkit.org
  • 6 edits in trunk

2009-10-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Missing default value for the default text encoding.
​https://bugs.webkit.org/show_bug.cgi?id=30311

QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.

Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.

  • platform/qt/Skipped:

2009-10-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Missing default value for the default text encoding.
​https://bugs.webkit.org/show_bug.cgi?id=30311

QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.

Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
10:38 PM Changeset in webkit [49491] by cam@webkit.org
  • 2 edits in trunk/WebKitSite

Change <a name> to id="" to fix styling problems
​https://bugs.webkit.org/show_bug.cgi?id=30283

Reviewed by Eric Seidel.

This prevents the headings from being styled like links.

  • coding/contributing.html:
9:59 PM Changeset in webkit [49490] by eric@webkit.org
  • 7 edits in trunk

2009-10-12 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30034

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
  • fast/dom/elementFromPoint-relative-to-viewport.html:

2009-10-12 Xiaomei Ji <​xji@chromium.org>

Reviewed by Sam Weinig.

Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
​https://bugs.webkit.org/show_bug.cgi?id=30034

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
9:22 PM Changeset in webkit [49489] by ukai@chromium.org
  • 5 edits in trunk/LayoutTests

2009-10-12 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed. Fix 4 layout test failures by webkit r49488

WebKit r49488 enables window.WebSocket back.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
6:44 PM Changeset in webkit [49488] by ukai@chromium.org
  • 9 edits
    6 adds in trunk

WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

Test: fast/websockets/websocket-event-target.html

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

  • websockets/WebSocket.idl:

WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests: Add a test to verify WebSocket's EventTarget methods.
​https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <​ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

  • fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
  • fast/websockets/script-tests/websocket-event-target.js: Added.

(openListener):
(messageListener):
(closeListener):

  • fast/websockets/websocket-event-target-expected.txt: Added.
  • fast/websockets/websocket-event-target.html: Added.
5:47 PM Changeset in webkit [49487] by weinig@apple.com
  • 5 edits
    13 deletes in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>

Reviewed by Darin Adler.

WebCore:

Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

LayoutTests:

Test the lack of UTF-7 support. Remove old UTF-7 tests.

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding.html:
  • http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
  • http/tests/misc/submit-get-in-utf7.html: Removed.
  • http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
  • http/tests/misc/submit-post-in-utf7.html: Removed.
  • http/tests/misc/url-in-utf7-expected.txt: Removed.
  • http/tests/misc/url-in-utf7.html: Removed.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
  • http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
  • http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
5:37 PM Changeset in webkit [49486] by hyatt@apple.com
  • 9 edits
    2 adds in trunk

Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.

Reviewed by Darin Adler.

Added fast/dom/beforeload/frame-before-load.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::isBeforeLoadEvent):

  • dom/Event.cpp:

(WebCore::Event::isBeforeLoadEvent):

  • dom/Event.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):

5:27 PM Changeset in webkit [49485] by eric@webkit.org
  • 5 edits in trunk

2009-10-12 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Port - Windows
​https://bugs.webkit.org/show_bug.cgi?id=29969

  • chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.

2009-10-12 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Port - Windows
​https://bugs.webkit.org/show_bug.cgi?id=29969

  • Scripts/pdevenv: removed msvc's /useenv for chromium builds
  • Scripts/webkitdirs.pm:
5:15 PM BuildingQtOnLinux edited by sch@eecs.berkeley.edu
added error relating to phonon (diff)
4:49 PM Changeset in webkit [49484] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

Test: fast/dynamic/position-absolute-to-fixed-crash.html

The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.

LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

  • fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
  • fast/dynamic/position-absolute-to-fixed-crash.html: Added.
4:20 PM Changeset in webkit [49483] by eric@webkit.org
  • 5 edits in trunk

2009-10-12 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Add a palette() method that is needed by our RenderTheme.

  • platform/qt/QWebPageClient.h:

2009-10-12 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Hausmann.

Implement the new palette() methods on the page clients

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
  • Api/qwebview.cpp: (QWebViewPrivate::palette):
4:16 PM Changeset in webkit [49482] by mrowe@apple.com
  • 1 edit in branches/safari-4-branch/WebCore/dom/Element.cpp

Fix release builds.

4:05 PM Changeset in webkit [49481] by eric@webkit.org
  • 9 edits
    4 adds in trunk

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.

  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Gradients can't handle percentage values in userSpaceOnUse mode
​https://bugs.webkit.org/show_bug.cgi?id=30286

Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.

Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg

  • svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
  • svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
3:39 PM Changeset in webkit [49480] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebCore

Merge r49218.

3:33 PM Changeset in webkit [49479] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.

Reviewed by Timothy Hatcher.

Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):

  • inspector/front-end/inspector.css:
3:32 PM Changeset in webkit [49478] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch/WebKit

Merge r48946.

3:32 PM Changeset in webkit [49477] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r47883.

3:25 PM Changeset in webkit [49476] by Csaba Osztrogonác
  • 6 edits in trunk/WebKitTools

jsc scripts cleanup and Qt/GTK fix
​https://bugs.webkit.org/show_bug.cgi?id=30288

Patch by Csaba Osztrogonac <Csaba Osztrogonác> on 2009-10-12
Reviewed by Darin Adler.

Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.

  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc:
  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:
  • Scripts/webkitdirs.pm:
3:25 PM Changeset in webkit [49475] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48787.

3:25 PM Changeset in webkit [49474] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r48775.

2:30 PM Changeset in webkit [49473] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-10-12 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r49429, because it broke layout tests.
​http://trac.webkit.org/changeset/49429

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
2:15 PM Changeset in webkit [49472] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

SVG - crash on feMerge when input not available
​https://bugs.webkit.org/show_bug.cgi?id=30297

Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.

Test: svg/filters/feMerge-wrong-input.svg

  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):

2009-10-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eirc Seidel.

feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.

  • svg/filters/feMerge-wrong-input-expected.checksum: Added.
  • svg/filters/feMerge-wrong-input-expected.png: Added.
  • svg/filters/feMerge-wrong-input-expected.txt: Added.
  • svg/filters/feMerge-wrong-input.svg: Added.
2:07 PM Changeset in webkit [49471] by mrowe@apple.com
  • 3 edits
    18 adds in branches/safari-4-branch

Merge r48572.

2:07 PM Changeset in webkit [49470] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-4-branch

Merge r47801.

2:07 PM Changeset in webkit [49469] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/WebCore

Merge r47771.

2:00 PM Changeset in webkit [49468] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48848.

2:00 PM Changeset in webkit [49467] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48547.

2:00 PM Changeset in webkit [49466] by mrowe@apple.com
  • 5 edits
    4 adds in branches/safari-4-branch

Merge r48546.

2:00 PM Changeset in webkit [49465] by mrowe@apple.com
  • 3 edits
    8 adds in branches/safari-4-branch

Merge r47900.

2:00 PM Changeset in webkit [49464] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r48743.

1:49 PM Changeset in webkit [49463] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-4-branch

Merge r46136.

1:49 PM Changeset in webkit [49462] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r47509.

1:42 PM Changeset in webkit [49461] by Csaba Osztrogonác
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-10-12 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed. Added myself to committers.py.

  • Scripts/modules/committers.py:
1:42 PM Changeset in webkit [49460] by mrowe@apple.com
  • 6 edits
    24 adds in branches/safari-4-branch

Merge r48647.

1:42 PM Changeset in webkit [49459] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46521.

1:38 PM Changeset in webkit [49458] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r47551.

1:38 PM Changeset in webkit [49457] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r47300.

1:34 PM Changeset in webkit [49456] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48957.

1:34 PM Changeset in webkit [49455] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48956.

1:34 PM Changeset in webkit [49454] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r48953.

1:33 PM Changeset in webkit [49453] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r46548.

1:19 PM Changeset in webkit [49452] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48369.

1:19 PM Changeset in webkit [49451] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r47657.

1:19 PM Changeset in webkit [49450] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r46058.

1:19 PM Changeset in webkit [49449] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r45945.

1:19 PM Changeset in webkit [49448] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r48725.

1:03 PM WebKit Team edited by Csaba Osztrogonác
(diff)
1:00 PM Changeset in webkit [49447] by cmarrin@apple.com
  • 19 edits
    3 adds in trunk

Added automatic flush before compositing
​https://bugs.webkit.org/show_bug.cgi?id=30236

This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.

Test: fast/canvas/webgl/triangle.html

12:38 PM Changeset in webkit [49446] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
​https://bugs.webkit.org/show_bug.cgi?id=30302

Closely match the default httpd.conf for layout tests.

  • http/conf/fedora-httpd.conf:
11:09 AM Changeset in webkit [49445] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=30307

Fix 0 sentinel for g_object_set() function call.

  • platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
11:05 AM Changeset in webkit [49444] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-10-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Remove unnecessary self-include.

  • webkit/webkitsecurityorigin.h:
9:29 AM Changeset in webkit [49443] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-10-12 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Video keeps playing after going fullscreen, then closing window
​https://bugs.webkit.org/show_bug.cgi?id=30164

Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
8:52 AM Changeset in webkit [49442] by eric@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2009-10-12 Andras Becsi <​becsi.andras@stud.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

[Qt] Add expected files for new passing fast tests.

  • platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
  • platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
  • platform/qt/fast/css/text-rendering-expected.txt: Added.
  • platform/qt/fast/forms/basic-buttons-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
  • platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
8:26 AM Changeset in webkit [49441] by krit@webkit.org
  • 7 edits
    3 adds in trunk

2009-10-12 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop in="" from <feFlood>
​https://bugs.webkit.org/show_bug.cgi?id=29001

This makes <feFlood in="bogus"> have an effect, too.

​http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

Test: svg/dom/feFlood-no-in1.html

  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
  • svg/graphics/filters/SVGFEFlood.h:

LayoutTest:

Drop in="" from <feFlood>
​https://bugs.webkit.org/show_bug.cgi?id=29001

This makes <feFlood in="bogus"> have an effect, too.

​http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute

  • svg/dom/feFlood-no-in1-expected.txt: Added.
  • svg/dom/feFlood-no-in1.html: Added.
  • svg/dom/script-tests/feFlood-no-in1.js: Added.
8:05 AM Changeset in webkit [49440] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-10-12 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

QWebPage's createViewlessPlugin autotest crash fix.

It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.

An autotest that covers this use-case, is included.

​https://bugs.webkit.org/show_bug.cgi?id=30118

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
7:34 AM Changeset in webkit [49439] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=29998

Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
7:18 AM Changeset in webkit [49438] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=29997

Fixes double memcpy of all rendered video frames.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
  • platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
7:15 AM Changeset in webkit [49437] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-10-12 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha.

[GTK] Crash when right-clicking misspelled word
​https://bugs.webkit.org/show_bug.cgi?id=29772

Make sure the dictionary exist before adding it to the list of
dictionaries.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
4:56 AM Changeset in webkit [49436] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubberstamped by Eric Seidel.

[Gtk] Fix icu CFLAG for Darwin
​https://bugs.webkit.org/show_bug.cgi?id=29517

Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.

  • autotools/webkit.m4:
4:55 AM Changeset in webkit [49435] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
​https://bugs.webkit.org/show_bug.cgi?id=29518

  • configure.ac:
3:14 AM QtBackLog edited by zecke@selfish.org
Add new items and pointers to them (diff)

Oct 11, 2009:

11:50 PM Changeset in webkit [49434] by dbates@webkit.org
  • 5 edits
    6 adds in trunk

2009-10-11 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=30242


Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.


JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.

Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html

http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
  • page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.

2009-10-11 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=30242


Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.

  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
9:17 PM Changeset in webkit [49433] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

Test: plugins/setProperty.html

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.

LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=30295

Reviewed by Darin Adler.

  • plugins/setProperty-expected.txt: Added.
  • plugins/setProperty.html: Added.
8:30 PM Changeset in webkit [49432] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-10-11 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Fixes a build break in the V8 bindings caused by revision 49420.
​https://bugs.webkit.org/show_bug.cgi?id=30294

Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.

  • WebCore.gypi: Include CanvasActiveInfo.idl in build.
  • bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
  • bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:15 PM Changeset in webkit [49431] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Collin Jackson <​collinj@webkit.org>

Reviewed by Adam Barth.

Log mixed content warnings to console

​https://bugs.webkit.org/show_bug.cgi?id=30290

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
7:53 PM Changeset in webkit [49430] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-10-11 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Collin to committers.py.

  • Scripts/modules/committers.py:
7:36 PM QtBackLog edited by zecke@selfish.org
(diff)
3:48 PM Changeset in webkit [49429] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Adam Barth.

[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See ​http://crbug.com/24200.
​https://bugs.webkit.org/show_bug.cgi?id=30250

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
3:34 PM Changeset in webkit [49428] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-11 Lyon Chen <​lyon.chen@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Correct the position of #endif sentence inside WebCore::Document::finishedParsing().

​https://bugs.webkit.org/show_bug.cgi?id=30244

This change requires no test case as it fix a compiling error.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
3:17 PM Changeset in webkit [49427] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-10-11 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Sets a 500K stack limit for JavaScript workers in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=29797

Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <​http://crbug.com/21653>.

This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.

Test: LayoutTests/fast/workers/use-machine-stack.html

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
  • bindings/v8/WorkerContextExecutionProxy.h:
2:30 PM Changeset in webkit [49426] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-enable the JIT.

1:01 PM Changeset in webkit [49425] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.

2:46 AM Changeset in webkit [49424] by cam@webkit.org
  • 10 edits
    3 adds in trunk

Allow [Reflect] on SVG elements.
​https://bugs.webkit.org/show_bug.cgi?id=28936

Reviewed by Sam Weinig.

Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].

Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.

WebCore:

Test: svg/dom/id-reflect.html

  • bindings/scripts/CodeGenerator.pm: Add a function to determine the

appropriate C++ namespace for attribute name constants.

  • bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling

code for [Reflect] on an attribute with a setter exception.

  • bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of

"HTMLNames" when appropriate.

  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/SVGElement.cpp: Remove getter and setter methods for id.
  • svg/SVGElement.h: Ditto.
  • svg/SVGElement.idl: Add [Reflect] to id.

LayoutTests:

  • svg/dom/script-tests/id-reflect.js: Added.
  • svg/dom/id-reflect-expected.txt: Added.
  • svg/dom/id-reflect.html: Added.

Oct 10, 2009:

8:47 PM Changeset in webkit [49423] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Support for String.trim(), String.trimLeft() and String.trimRight() methods
​https://bugs.webkit.org/show_bug.cgi?id=26590

Reviewed by Maciej Stachowiak.

Implement trim, trimLeft, and trimRight

3:10 PM Changeset in webkit [49422] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
​https://bugs.webkit.org/show_bug.cgi?id=30279

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.

  • platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
2:46 PM Changeset in webkit [49421] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix paths in xcode.

2:16 PM Changeset in webkit [49420] by oliver@apple.com
  • 10 edits
    2 copies
    8 adds in trunk

Implement getActiveAttrib and getActiveUniform
​https://bugs.webkit.org/show_bug.cgi?id=30276

Reviewed by Eric Carlson.

Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.

Test: fast/canvas/webgl/getActiveTest.html

12:21 PM Changeset in webkit [49419] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Adding new attributes in Element Panel is
counterintuitive.

​https://bugs.webkit.org/show_bug.cgi?id=30057

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
9:19 AM Changeset in webkit [49418] by Laszlo Gombos
  • 4 edits in trunk/WebCore

2009-10-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

Build fix if Netscape plugin support is turned off
​https://bugs.webkit.org/show_bug.cgi?id=30275

In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
8:56 AM Changeset in webkit [49417] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2009-10-10 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r49415.

Add HistoryController.cpp to the build.

  • WebCore.pro:
6:53 AM Changeset in webkit [49416] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
​https://bugs.webkit.org/show_bug.cgi?id=30262

This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.

  • platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
3:04 AM BuildingQtOnWindows edited by robert@roberthogan.net
(diff)
2:11 AM Changeset in webkit [49415] by abarth@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2009-10-10 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

Move HistoryController to its own file
​https://bugs.webkit.org/show_bug.cgi?id=30272

Purely mechanical.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/HistoryController.cpp: Added.
  • loader/HistoryController.h: Added.

Oct 9, 2009:

8:36 PM Changeset in webkit [49414] by rniwa@webkit.org
  • 10 edits
    3 adds in trunk

ApplyStyleCommand removes presentational tags even when not necessary
​https://bugs.webkit.org/show_bug.cgi?id=28091

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.

WebCore:

This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.

Test: editing/execCommand/toggle-style-3.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements

  • editing/ApplyStyleCommand.h:

LayoutTests:

This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later

  • editing/execCommand/19653-2-expected.txt: Two b elements are merged.
  • editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
  • editing/execCommand/script-tests/toggle-style-3.js: Added.

(testSingleToggle):

  • editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
  • editing/execCommand/toggle-style-3-expected.txt: Added.
  • editing/execCommand/toggle-style-3.html: Added.
  • editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
  • platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
  • platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
7:27 PM Changeset in webkit [49413] by abarth@webkit.org
  • 10 edits in trunk

2009-10-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=30246

Update API call.

  • WebView.cpp: (WebView::loadBackForwardListFromOtherView):

2009-10-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=30246

Update API call.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreViewState):
  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]):

2009-10-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Factor HistoryController out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=30246

HistoryController is in charge of managing the current / previous /
provisional HistoryItems. The split isn't perfect, but it's a place to
start. I'll move HistoryController into its own file in another patch.

  • WebCore.base.exp:
  • loader/FrameLoader.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::~HistoryController): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::begin): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::HistoryController::updateForFrameLoadCompleted): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::HistoryController::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::HistoryController::createHistoryItem): (WebCore::FrameLoader::checkDidPerformFirstNavigation): (WebCore::HistoryController::addBackForwardItemClippedAtTarget): (WebCore::HistoryController::createHistoryItemTree): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::HistoryController::urlsMatchItem): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::childFramesMatchItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::updateForAnchorScroll): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::FrameLoader::didChangeTitle):
  • loader/FrameLoader.h: (WebCore::HistoryController::current): (WebCore::HistoryController::provisional): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::creatingInitialEmptyDocument):
  • page/Page.cpp: (WebCore::Page::goToItem):
5:53 PM Changeset in webkit [49412] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

Try to fix Windows build by adding needed exports.

5:46 PM Changeset in webkit [49411] by mrowe@apple.com
  • 5 edits in trunk

WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in

Reviewed by Brady Eidson.

At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out. This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.

WebKitTools: Enable plug-in halting in DumpRenderTree.

We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:shouldHaltPlugin:]):

5:38 PM Changeset in webkit [49410] by ap@apple.com
  • 2 edits in trunk/WebCore

Unreviewed - fixing an obvious typo in my previous check-in.

​https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

Fixes existing tests (which I thought I had run the previous time).

  • platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the set by reference.
5:30 PM Changeset in webkit [49409] by ggaren@apple.com
  • 10 edits in trunk/JavaScriptCore

Eliminated some legacy bytecode weirdness.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.

Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.

To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.

Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.

SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.

  • bytecode/CodeBlock.cpp:

(JSC::printConditionalJump):
(JSC::CodeBlock::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):

  • bytecompiler/Label.h:

(JSC::Label::setLocation):
(JSC::Label::bind):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):

4:28 PM Changeset in webkit [49408] by levin@chromium.org
  • 3 edits in trunk/WebCore

[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
​https://bugs.webkit.org/show_bug.cgi?id=30264

Patch by David Levin <​levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.

The base class method changed in r48884.

Test: fast/worker/worker-script-error.html

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::reportError):

  • bindings/v8/V8WorkerContextEventListener.h:
3:45 PM Changeset in webkit [49407] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bad ChangeLog entry merge in r49019 by the commit queue script.

3:29 PM Changeset in webkit [49406] by ap@apple.com
  • 6 edits
    10 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work

Tests: http/tests/xmlhttprequest/logout.html

http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html

Fix several issues with existing credential handling code.

  • platform/network/CredentialStorage.cpp: (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't want to iterate paths for origins that never had credentials associated with them. Changed to use a separate HashSet for this. (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't match the spec very well. UAs are supposed to deduce protection space from an URL, and then use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap is now PathToDefaultProtectionSpaceMap. (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. (WebCore::CredentialStorage::set): Updated for above changes. (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find a prefix in OriginToDefaultBasicCredentialMap. (WebCore::CredentialStorage::set): Another version of set() can update credentials for a URL default protection space. It does nothing if the given URL doesn't correspond to a known protection space. (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.
  • platform/network/CredentialStorage.h: Made the distinction between methods that use a known protection space and those that deduce one from URL more clear.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Update credentials before starting the request for real. This makes the following pattern work: var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); wrong credentials req.send(""); req.abort(); Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. Note that one cannot log in using the same method, because there isn't a known protection space for the URL yet in that case, so the added code has no effect. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of course), and matches sync case. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Renamed getDefaultAuthenticationCredential() to get().
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac code.
3:01 PM Changeset in webkit [49405] by eric@webkit.org
  • 14 edits
    4 adds in trunk

2009-10-09 Enrica Casucci <​enrica@apple.com>

Reviewed by Adele Peterson.

Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
​https://bugs.webkit.org/show_bug.cgi?id=28722
Added test case for ​https://bugs.webkit.org/show_bug.cgi?id=23995

  • editing/execCommand/19653-1-expected.txt: Re-baselined.
  • editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
  • editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
  • editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
  • editing/execCommand/indent-with-style-expected.txt: Added.
  • editing/execCommand/indent-with-style.html: Added.
  • editing/undo/undo-indent-expected.txt: Added.
  • editing/undo/undo-indent.html: Added.
  • platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
  • platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.

2009-10-09 Enrica Casucci <​enrica@apple.com>

Reviewed by Adele Peterson.

Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
​https://bugs.webkit.org/show_bug.cgi?id=28722
Restored the behavior prior to ​http://trac.webkit.org/changeset/46143. This change implemented the
indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.

Added editing/undo/undo-indent.html test.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to ensure TextIterator could correctly calculate the position starting from the index.
  • editing/IndentOutdentCommand.h: Restored.
2:24 PM Changeset in webkit [49404] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-10-09 Rimas Kudelis <​rq@akl.lt>

Rubber-stamped by Gustavo Noronha

​https://bugs.webkit.org/show_bug.cgi?id=30054
Localization of WebKit GTK into Lithuanian

  • lt.po: Added.
2:24 PM Changeset in webkit [49403] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Adler.

Optimization: Many StringImpl transformations are no-ops and should just return 'this'
​https://bugs.webkit.org/show_bug.cgi?id=30186

Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
detect no-ops and return this instead of creating a new instance.
Empirical testing shows that the majority of calls to these methods are no-ops, making
this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace):
1:51 PM Changeset in webkit [49402] by krit@webkit.org
  • 6 edits
    4 adds in trunk

2009-10-09 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

SVG Filter feGaussianBlur implementation is missing
​https://bugs.webkit.org/show_bug.cgi?id=28141

This is the implementation of GaussianBlur filter for SVG.

There is already a test for feGaussianBlur
Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg

Test: svg/filters/feGaussianBlur.svg

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isAlphaImage): (WebCore::FilterEffect::setIsAlphaImage):
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):

Test for feGaussianBlur implementation

  • platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
  • platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
  • svg/filters/feGaussianBlur.svg: Added.
12:37 PM Changeset in webkit [49401] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-10-09 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] QoS support in the video sink
​https://bugs.webkit.org/show_bug.cgi?id=29959

Removed the async buffer queue from the sink. Synchronize the
render method of the sink using a g_timeout_add() combined with a
gcond triggered when the buffer has been rendered.
Also fixed the video sink reference handling in the player, now
that the idle is not there anymore to mess up things.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_stop): (webkit_video_sink_class_init):
12:13 PM Changeset in webkit [49400] by krit@webkit.org
  • 19 edits
    6 adds in trunk

2009-10-08 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

feMorphology filter is not implemented
​https://bugs.webkit.org/show_bug.cgi?id=5863

Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug
with the attribute "operator". It was only accessible via "_operator"
on JavaScript.

Test: svg/dom/operatorAttribute.xhtml

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.SVG.Filters.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • page/DOMWindow.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEMorphologyElement.cpp: Added. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h: Added.
  • svg/SVGFEMorphologyElement.idl: Added.
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<):
  • svg/graphics/filters/SVGFEMorphology.h: (WebCore::):
  • svg/svgtags.in:

Reviewed by Nikolas Zimmermann.

Attribute "operator" schould only be accessible by "operator", not by "_operator"

  • svg/dom/operatorAttribute-expected.txt: Added.
  • svg/dom/operatorAttribute.html: Added.
  • svg/dom/script-tests/operatorAttribute.js: Added.
12:12 PM Changeset in webkit [49399] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Dimitri Glazkov.

Fix Chromium breakage.

​https://bugs.webkit.org/show_bug.cgi?id=30104

  • inspector/front-end/inspector.js: (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods.
11:14 AM Changeset in webkit [49398] by ggaren@apple.com
  • 9 edits in trunk/JavaScriptCore

Migrated some code that didn't belong out of Structure.

Patch by Geoffrey Garen <​ggaren@apple.com> on 2009-10-09
Reviewed by Sam Weinig.

SunSpider says maybe 1.03x faster.

  • runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of

a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)

  • runtime/JSGlobalObject.cpp:

(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):

  • runtime/JSObject.h:

(JSC::JSObject::markChildrenDirect):

  • runtime/PropertyNameArray.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.

10:31 AM Changeset in webkit [49397] by Laszlo Gombos
  • 7 edits in trunk

2009-10-09 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

Sets Qt::WA_InputMethodEnabled and Qt::ImhHiddenText for password fields in EditorClientQt
setInputMethodState. This change is needed so widgets such as the s60 software
input panel can receive input method events for password fields.
It's up to the Qt platform to determine which widget will receive input method
events when these flags are set.
Also added implementation for setInputMethodEnabled and setInputMethodHint
to QGraphicsWebViewPrivate and QWebViewPrivate. This change removes the direct
dependency on QWebView and uses QWebPageClient.
Added autotest to tst_qwebpage.cpp

​https://bugs.webkit.org/show_bug.cgi?id=30023

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::setInputMethodEnabled): (QGraphicsWebViewPrivate::setInputMethodHint):
  • Api/qwebview.cpp: (QWebViewPrivate::setInputMethodEnabled): (QWebViewPrivate::setInputMethodHint):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

2009-10-09 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Added pure virtual methods setInputMethodEnabled and setInputMethodHint to QWebPageClient

​https://bugs.webkit.org/show_bug.cgi?id=30023

  • platform/qt/QWebPageClient.h:
10:26 AM Changeset in webkit [49396] by Darin Adler
  • 1 edit
    3 moves in trunk/LayoutTests

Requested by Mark Rowe.

Patch by Darin Adler <Darin Adler> on 2009-10-09
Moved DOM test that was in fast/js to fast/dom where it belongs.

  • fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:

Copied from fast/js/invalid-domain-change-throws-exception-expected.txt.

  • fast/dom/Document/invalid-domain-change-throws-exception.html:

Copied from fast/js/invalid-domain-change-throws-exception.html.
Regenerated with the make-script-test-wrappers.

  • fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:

Copied from fast/js/resources/invalid-domain-change-throws-exception.js.

  • fast/js/invalid-domain-change-throws-exception-expected.txt: Removed.
  • fast/js/invalid-domain-change-throws-exception.html: Removed.
  • fast/js/resources/invalid-domain-change-throws-exception.js: Removed.
10:20 AM Changeset in webkit [49395] by hyatt@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog patch reviewer to be accurate.

10:03 AM Changeset in webkit [49394] by hyatt@apple.com
  • 11 edits
    2 adds in trunk

Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic
ImageEventSender that can be used by both load and beforeload events. If the document has any
beforeload listeners, then the installation of images onto the renderer becomes asynchronous
and will be held up until the beforeload event can fire at a later date.

Reviewed by Adam Roben.

Both beforeload and load events now fire at the end of the tokenizer write() methods, so that
in the typical parsing case we don't have to put off the beforeload/load events until after
a layout or paint might already have happened. This lets beforeload/load not cause extra
layouts and repaints.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::dispatchBeforeLoadEvent):

  • dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::write):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::write):

  • loader/ImageLoader.cpp:

(WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender):
(WebCore::ImageLoadEventSender::ImageLoadEventSender):
(WebCore::beforeLoadEventSender):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingEvents):
(WebCore::ImageEventSender::ImageEventSender):
(WebCore::ImageEventSender::dispatchEventSoon):
(WebCore::ImageEventSender::cancelEvent):
(WebCore::ImageEventSender::dispatchPendingEvents):
(WebCore::ImageEventSender::timerFired):

  • loader/ImageLoader.h:

(WebCore::ImageLoader::haveFiredBeforeLoadEvent):

  • wml/WMLImageElement.cpp:

(WebCore::WMLImageElement::attach):

9:36 AM Changeset in webkit [49393] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-10-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

Web Inspector: Wrap Database into ScriptObject in v8 bindings.

​https://bugs.webkit.org/show_bug.cgi?id=30174

No tests due to no Script* test infrastructure.

  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
9:35 AM Changeset in webkit [49392] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

Add SPI to specifically enable visited link tracking.

Reviewed by Dan Bernstein.

  • History/WebHistory.mm:

(+[WebHistory _setVisitedLinkTrackingEnabled:]):

  • History/WebHistoryPrivate.h:
7:58 AM Changeset in webkit [49391] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView.

'client' is 0 when we have no view.

​https://bugs.webkit.org/show_bug.cgi?id=30251

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
7:51 AM Changeset in webkit [49390] by mitz@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png.

5:47 AM Changeset in webkit [49389] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Plugins : Add missing setCurrentPlugin(0)

​https://bugs.webkit.org/show_bug.cgi?id=30248

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):
5:32 AM Changeset in webkit [49388] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] beforeload event does not fire on script elements in XML
​https://bugs.webkit.org/show_bug.cgi?id=30235

r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one
made in XMLTokenizerLibxml2.cpp.

  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
5:12 AM Changeset in webkit [49387] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's CSSParserValueList
​https://bugs.webkit.org/show_bug.cgi?id=30249

Inherits CSSParserValueList class from FastAllocBase because it has
been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271.

  • css/CSSParserValues.h:
4:32 AM Changeset in webkit [49386] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : Create Pixmap only when size changes.

​https://bugs.webkit.org/show_bug.cgi?id=30214

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
2:36 AM Changeset in webkit [49385] by jhoneycutt@apple.com
  • 25 edits in trunk

Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.

This fixes a leak of WebPluginHalterClients:
​https://bugs.webkit.org/show_bug.cgi?id=30119.

WebCore:

Reviewed by Dan Bernstein.

  • WebCore.base.exp:

Removed the export of WebCore::Settings::setPluginHalterEnabled().

  • loader/EmptyClients.h:

(WebCore::EmptyPluginHalterClient::enabled):

  • page/Page.cpp:

(WebCore::Page::Page):
Remove initialization of m_pluginHalterClient, which was removed. If a
non-null PluginHalterClient was passed, create the PluginHalter, and
set its allowed run time.

  • page/Page.h:

Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient.

  • page/PluginHalter.cpp:

(WebCore::PluginHalter::didStartPlugin):
Check whether the PluginHalterClient is enabled.
(WebCore::PluginHalter::didStopPlugin):
Ditto.

  • page/PluginHalter.h:

Made m_client an OwnPtr.

  • page/PluginHalterClient.h:

Added a function to return the enabled state.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Remove initialization of removed member.

  • page/Settings.h:

Removed settings for the enabled state of the PluginHalter; we now use
the existence of a WebPluginHalterDelegate to determine whether the
PluginHalter is enabled.

WebKit/mac:

  • WebCoreSupport/WebPluginHalterClient.h:

Add declaration for new function.

  • WebCoreSupport/WebPluginHalterClient.mm:

(WebPluginHalterClient::enabled):
Check whether the UIDelegate responds to shouldHaltPlugin.

  • WebView/WebPreferenceKeysPrivate.h:

Remove the "enabled" preference key.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Remove the initialization of the pref.

  • WebView/WebPreferencesPrivate.h:

Remove the getter/setter for this pref.

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):
Remove propagation of the pref.

WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:

Remove the getter and setter.

  • WebCoreSupport/WebPluginHalterClient.cpp:

(WebPluginHalterClient::enabled):
Return true if the delegate exists.

  • WebCoreSupport/WebPluginHalterClient.h:

Declare implementation of enabled().

  • WebPreferenceKeysPrivate.h:

Removed the pref key.

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.

  • WebPreferences.h:

Removed declaration of the getter/setter.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):
Don't propagate the pref.

1:59 AM Changeset in webkit [49384] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the GTK release build.

  • GNUmakefile.am: Include Grammar.cpp in release builds now that

AllInOneFile.cpp is gone.

12:50 AM Changeset in webkit [49383] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-10-09 Gabor Loki <​loki@inf.u-szeged.hu>

Rubber-stamped by Eric Seidel.

Add ARM JIT support for Gtk port (disabled by default)
​https://bugs.webkit.org/show_bug.cgi?id=30228

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.