Context Navigation

← Previous Period
Next Period →

Timeline

Nov 2, 2009:

11:51 PM Changeset in webkit [50445] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Get the correct Gtk+ object before attempting to turn it into an AtkObject.

DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement):

11:01 PM Changeset in webkit [50444] by Chris Fleizach

23 edits in trunk/WebCore

fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

Reviewed by David Levin.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

accessibility/AccessibilityAllInOne.cpp:
accessibility/AccessibilityImageMapLink.cpp:
accessibility/AccessibilityList.h:

(WebCore::AccessibilityList::isList):

accessibility/AccessibilityListBox.cpp:
accessibility/AccessibilityListBox.h:

(WebCore::AccessibilityListBox::isListBox):

accessibility/AccessibilityListBoxOption.cpp:
accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::isListBoxOption):

accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):

accessibility/AccessibilityObject.h:

(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):

accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):

accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation):

accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

accessibility/AccessibilityTableColumn.cpp:
accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

accessibility/AccessibilityTableRow.cpp:
accessibility/mac/AccessibilityObjectWrapper.h:

10:49 PM Changeset in webkit [50443] by oliver@apple.com

6 edits in trunk

REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045

Reviewed by Gavin Barraclough.

Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.

9:51 PM Changeset in webkit [50442] by darin@chromium.org

2 edits in trunk/WebCore

2009-11-02 Darin Fisher <darin@chromium.org>

Fixing JSC build bustage.

bindings/js/ScriptController.cpp: Added missing #include

9:47 PM Changeset in webkit [50441] by darin@chromium.org

7 edits in trunk/WebCore

2009-10-30 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
https://bugs.webkit.org/show_bug.cgi?id=30967

bindings/js/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
bindings/v8/V8Proxy.h: Ditto
loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowJavaScript):
platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function

8:40 PM Changeset in webkit [50440] by beidson@apple.com

2 edits in trunk/WebCore

Rubberstamped by Mark Rowe.

Fix a typo in Mark's last commit.

loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

8:00 PM Changeset in webkit [50439] by mrowe@apple.com

2 edits in trunk/WebCore

Re-enable support for web archives on Windows. It was mistakenly disabled in r50438.

Rubber-stamped by Brady Eidson.

loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

7:24 PM Changeset in webkit [50438] by eric@webkit.org

10 edits in trunk

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

wtf/Platform.h: Turn on CF support if both QT and DARWIN platforms are defined.

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp to the Darwin build.
loader/archive/ArchiveFactory.cpp: Change the support for legacy WebArchive from all CF platforms to Mac and Chromium CF platforms. (WebCore::archiveMIMETypes):
platform/text/AtomicString.h: Remove PLATFORM(QT) && PLATFORM(DARWIN) test as it is redundant now.
platform/text/PlatformString.h: Ditto.
platform/text/StringImpl.h: Ditto.
platform/text/cf/StringCF.cpp: Ditto.
platform/text/cf/StringImplCF.cpp: Ditto.

6:35 PM Changeset in webkit [50437] by eric@webkit.org

5 edits
1 add in trunk/WebCore

2009-11-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
https://bugs.webkit.org/show_bug.cgi?id=30985

Our current code does not conform to our style guide.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/chromium/MIMETypeRegistryChromium.cpp:
plugins/chromium/PluginDataChromium.cpp:
plugins/chromium/PluginDataChromium.h: Added.

6:07 PM Changeset in webkit [50436] by adele@apple.com

3 edits in trunk/WebCore

Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)

Reviewed by Darin Adler.

This bug is timing dependent, and not always reproducible. I could not think of a way to add a
layout test that would demonstrate the problem and fix.

platform/mac/ThemeMac.mm:

(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here. Consider that when deciding if the button should have the default style in RenderTheme.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active. This fixes

a problem I noticed where the button would flicker crazily if the page with the default button was in the background.

5:44 PM Changeset in webkit [50435] by mitz@apple.com

3 edits in trunk/WebCore

Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.

Reviewed by Anders Carlsson.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().

rendering/RenderWidget.h:

5:39 PM QtBackLog edited by zecke@selfish.org

Mention #31009 (diff)

5:38 PM Changeset in webkit [50434] by dumi@chromium.org

1 edit
6 adds in trunk/WebCore

Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30701

storage/chromium: Added.
storage/chromium/DatabaseObserver.h: Added.
storage/chromium/DatabaseTrackerChromium.cpp: Added.
storage/chromium/QuotaTracker.cpp: Added.
storage/chromium/QuotaTracker.h: Added.
storage/chromium/SQLTransactionClientChromium.cpp: Added.

5:06 PM Changeset in webkit [50433] by enrica@apple.com

4 edits
2 adds in trunk

Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
https://bugs.webkit.org/show_bug.cgi?id=31023

Reviewed by Adele Peterson and Dan Bernstein.

WebCore:

Test: editing/execCommand/align-in-span.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.

rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.

LayoutTests:

editing/execCommand/align-in-span-expected.txt: Added.
editing/execCommand/align-in-span.html: Added.

4:04 PM Changeset in webkit [50432] by cmarrin@apple.com

8 edits in trunk

Exception checks were being too aggressive
https://bugs.webkit.org/show_bug.cgi?id=31005

Several calls in CanvasRenderingContext3D are allowed to
have a null value passed, which indicated that the
object is being unbound. Handle this case and the corresponding
null handling in GraphicsContext3DMac.

2:53 PM Changeset in webkit [50431] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2009-11-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Each JS execution in console adds extra item into "scripts" combo
https://bugs.webkit.org/show_bug.cgi?id=30212

Added manual test

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
manual-tests/inspector/hidden-evals.html: Added.

2:26 PM Changeset in webkit [50430] by eric@webkit.org

2 edits in trunk

2009-11-02 Estêvão Samuel Procópio <tevaum@gmail.com>

Reviewed by Gustavo Noronha.

[Build] make install ignores --prefix option for gobject-introspection.
https://bugs.webkit.org/show_bug.cgi?id=31025

Make the build system use the --prefix path also when installing
gobject-introspection files.

configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR

2:03 PM Changeset in webkit [50429] by eric.carlson@apple.com

6 edits in trunk/WebKit

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

Fix localized strings for media controller time values.

English.lproj/Localizable.strings:

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaTimeDescription:]):

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):

2:02 PM Changeset in webkit [50428] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
https://bugs.webkit.org/show_bug.cgi?id=31030

dom/Node.cpp: (WebCore::eventHasListeners): Checks DOMWindow for listeners. (WebCore::Node::dispatchGenericEvent):

1:31 PM Changeset in webkit [50427] by dimich@chromium.org

29 edits in trunk

Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612

Reviewed by David Levin.

JavaScriptCore:

wtf/MessageQueue.h:

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.

wtf/Threading.cpp:

(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890

WebCore:

No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.

There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.

ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.

dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):

dom/Document.h:
dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):

dom/ScriptExecutionContext.h:
dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):

dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):

loader/FrameLoader.cpp:

(WebCore::HashChangeEventTask::create):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):

storage/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):

storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):

storage/DatabaseThread.h:
storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):

storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::localStorageThread):

storage/LocalStorageThread.h:
websockets/WebSocket.cpp:

(WebCore::ProcessWebSocketEventTask::create):

workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):

workers/GenericWorkerTask.h:

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):

workers/WorkerContext.cpp:

(WebCore::WorkerContext::postTask):

workers/WorkerContext.h:
workers/WorkerLoaderProxy.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):

workers/WorkerMessagingProxy.h:
workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):

workers/WorkerRunLoop.h:

(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):

1:14 PM Changeset in webkit [50426] by mitz@apple.com

3 edits in trunk/WebKit/mac

Made the remaining time display show negative zero at the end of the
video.

Reviewed by Anders Carlsson.

Made other cleanup.

WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of

_timeline and _volumeSlider to the more generic NSControl.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.

12:14 PM Changeset in webkit [50425] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

platform/gtk/Skipped: Unskip fixed test.

11:34 AM Changeset in webkit [50424] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

new m_seekTime attribute to keep track of the seek position

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

11:25 AM Changeset in webkit [50423] by xan@webkit.org

2 edits in trunk/WebCore

2009-11-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove Referer when redirecting to non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31021

Remove referer from HTTP headers when redirecting to a non-secure
site.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

11:10 AM Changeset in webkit [50422] by xan@webkit.org

2 edits in trunk

2009-11-02 Xan Lopez <xlopez@igalia.com>

Bump version before release (or post-release, depending on your
point of view) so that we can make applications depending on
unreleased APIs in WebKit svn fail at configure time when the
requirements are not met.

configure.ac:

11:00 AM Changeset in webkit [50421] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=18539
multipart/form-data not being parsed correctly on server due to '+' in boundary string

No test - the characters that the boundary is made of are not deterministic.

platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as they cause problems on many web sites.

10:52 AM Changeset in webkit [50420] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

Also fix call to logResult() as parameters were reversed, resulting in
printing an error message of "false".

https://bugs.webkit.org/show_bug.cgi?id=31017

media/video-currentTime-set.html: Timeout increased to 2000ms.

10:41 AM Changeset in webkit [50419] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30969
A no-prefix XPath node test should not match no-namespace elements in HTML document

Test: fast/xpath/null-namespace-in-html.html

xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements in HTML documents (as these are the ones that can have null namespace).

10:32 AM Changeset in webkit [50418] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] No timeline marks on resources panel.

https://bugs.webkit.org/show_bug.cgi?id=31013

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):

10:26 AM Changeset in webkit [50417] by levin@chromium.org

2 edits in trunk/WebCore

Possible crash in RenderSlider::layout.
https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

10:17 AM Changeset in webkit [50416] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix Qt build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=30905

WebCore.pro:
platform/graphics/BitmapImage.h:
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::create):

10:09 AM Changeset in webkit [50415] by eric@webkit.org

5 edits
4 adds in trunk

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

tests/qwebview/tst_qwebview.cpp: (WebViewCrashTest::WebViewCrashTest): (WebViewCrashTest::loading): (tst_QWebView::crashTests):

10:01 AM Changeset in webkit [50414] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix a leftover from profiles panel generalization.

https://bugs.webkit.org/show_bug.cgi?id=31010

inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get searchableViews):

9:53 AM Changeset in webkit [50413] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Kai Koehne <kai.koehne@nokia.com>

Reviewed by Holger Freyther.

Remove implementation of ImageDecocerQt::clearFrameBufferCache.
The implementation was buggy, and will visually break repeating
animations anyway.

https://bugs.webkit.org/show_bug.cgi?id=31009

platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::clearFrameBufferCache):

9:35 AM Changeset in webkit [50412] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Provides access to the reported content language.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_document_get_locale):

9:27 AM Changeset in webkit [50411] by eric@webkit.org

6 edits
2 adds in trunk

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

inspector/css-syntax-highlight-expected.txt: Added.
inspector/css-syntax-highlight.html: Added.
inspector/javascript-syntax-highlight-expected.txt:

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

Test: inspector/css-syntax-highlight.html

inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter):
inspector/front-end/inspectorSyntaxHighlight.css:

9:03 AM Changeset in webkit [50410] by mitz@apple.com

7 edits in trunk

WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary

#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.

WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import

statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

8:57 AM Changeset in webkit [50409] by Chris Fleizach

21 edits
4 adds in trunk

Support ARIA "tab" roles
https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore:

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html

accessibility/aria-tab-roles.html

accessibility/AXObjectCache.cpp:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:
accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:
html/HTMLAttributeNames.in:

WebKit:

Add a localizable string for tab panel.

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

WebKit/mac:

WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:
DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests:

accessibility/aria-controls-with-tabs-expected.txt: Added.
accessibility/aria-controls-with-tabs.html: Added.
accessibility/aria-tab-roles.html: Added.
platform/gtk/Skipped:
platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
platform/win/Skipped:

7:27 AM Changeset in webkit [50408] by senorblanco@chromium.org

2 edits in trunk/WebCore

This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium. The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not. In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test. This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

4:36 AM BuildingQtOnOSX edited by vestbo@webkit.org

(diff)

1:37 AM Changeset in webkit [50407] by pfeldman@chromium.org

10 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds window event dispatches to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31002

English.lproj/localizedStrings.js:
dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent. (WebCore::Node::dispatchGenericEvent):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed. (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):

1:25 AM Surfin' Safari Translations edited by casey.hattori@gmail.com

(diff)

1:25 AM Changeset in webkit [50406] by pfeldman@chromium.org

10 edits in trunk/WebCore

2009-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Convert script tag event into a more generic
script eval event in timeline.

https://bugs.webkit.org/show_bug.cgi?id=30999

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):

1:22 AM Surfin' Safari Translations created by casey.hattori@gmail.com

Nov 1, 2009:

10:36 PM newpage edited by casey.hattori@gmail.com

(diff)

10:34 PM newpage created by casey.hattori@gmail.com

10:21 PM Changeset in webkit [50405] by bweinstein@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

dom/Node.cpp:

(WebCore::eventHasListeners):

10:07 PM QtBackLog edited by zecke@selfish.org

(diff)

10:03 PM Changeset in webkit [50404] by bweinstein@apple.com

1 edit in trunk/WebCore/dom/Node.cpp

Re-fix the Mac build. Sorry :-(.

9:57 PM Changeset in webkit [50403] by bweinstein@apple.com

1 edit in trunk/WebCore/dom/Node.cpp

Change ssize_t to unsigned to try and fix Windows build.

7:53 PM Changeset in webkit [50402] by mitz@apple.com

2 edits in trunk/WebKit/mac

Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]):

7:30 PM Changeset in webkit [50401] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-01 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

buildbots should use --exit-after-N-failures
https://bugs.webkit.org/show_bug.cgi?id=30809

Make the bots exit after 20 failures to prevent never-ending
test runs where every test spends a minute crashing.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

7:23 PM Changeset in webkit [50400] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Does not send DOM dispatches to the InspectorTimelineAgent if there
are no event listeners.
https://bugs.webkit.org/show_bug.cgi?id=30995

dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):

7:14 PM Changeset in webkit [50399] by mitz@apple.com

2 edits in trunk/WebKit/mac

Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

6:50 PM Changeset in webkit [50398] by rolandsteiner@chromium.org

2 edits in trunk/WebCore

No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

WebCore.vcproj/WebCore.vcproj:

5:52 PM Changeset in webkit [50397] by rolandsteiner@chromium.org

12 edits
8 adds in trunk

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore:

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element

1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting

0-n inline object(s)

0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base

1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.

New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:

CSS

css/html.css: Added <ruby> and <rt>

Existing render files:

rendering/RenderBlock.cpp: make moveChild a member function moveChildTo

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

rendering/RenderBlock.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name

rendering/RenderObject.h: add query methods for ruby renderers

(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:

rendering/RenderRuby.cpp: Added.

(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

rendering/RenderRuby.h: Added.

(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):

rendering/RenderRubyBase.cpp: Added.

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):

rendering/RenderRubyBase.h: Added.

(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):

rendering/RenderRubyRun.cpp: Added.

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

rendering/RenderRubyRun.h: Added.

(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):

rendering/RenderRubyText.cpp: Added.

(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):

rendering/RenderRubyText.h: Added.

(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests:

Further layout tests will be committed in a follow-up patch under fast/ruby.

fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>

5:00 PM Changeset in webkit [50396] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null

Test: fast/dom/Node/default-namespace-empty-argument.html

dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.

1:38 PM Changeset in webkit [50395] by eric@webkit.org

4 edits in trunk

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Updating the expected result to reflect the change.

fast/loader/url-parse-1-expected.txt:

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

platform/KURL.cpp: (WebCore::KURL::parse):

1:30 PM Changeset in webkit [50394] by oliver@apple.com

4 edits in trunk/WebCore

Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

1:22 PM Changeset in webkit [50393] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Implements what has been implemented in AT-SPI.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):

12:49 PM Changeset in webkit [50392] by eric@webkit.org

9 edits in trunk

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

WebKit.pri: Turn on warnings for the GCC compiler

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN

12:41 PM Changeset in webkit [50391] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

[Regression] monitorEvent doesn't work

inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):

12:33 PM Changeset in webkit [50390] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
https://bugs.webkit.org/show_bug.cgi?id=30990

inspector/front-end/SourceFrame.js:

12:04 PM Changeset in webkit [50389] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title

Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.

8:18 AM Changeset in webkit [50388] by eric@webkit.org

4 edits
2 adds in trunk/LayoutTests

2009-11-01 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
https://bugs.webkit.org/show_bug.cgi?id=30902

fast/text/international/thai-cursor-position-expected.txt: Added.
fast/text/international/thai-cursor-position.html: Added.
platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
platform/qt/Skipped: ditto.
platform/win/Skipped: ditto.

8:11 AM Changeset in webkit [50387] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Double clicking on a breakpoints should not select text
https://bugs.webkit.org/show_bug.cgi?id=30950

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):

8:03 AM Changeset in webkit [50386] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

fast/css/list-item-pseudo-nocrash-expected.txt: Added.
fast/css/list-item-pseudo-nocrash.html: Added.

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

Test: fast/css/list-item-pseudo-nocrash.html

rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):

7:54 AM Changeset in webkit [50385] by eric@webkit.org

4 edits in trunk

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

platform/gtk/Skipped: Unskip fixed test.

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):

7:25 AM Changeset in webkit [50384] by jberlin@webkit.org

2 edits in trunk/WebKitTools

2009-11-01 Jessie Berlin <jberlin@webkit.org>

Adding myself to the committers list.

Scripts/modules/committers.py:

Oct 31, 2009:

4:22 PM Changeset in webkit [50383] by oliver@apple.com

2 edits in trunk/WebCore

Build fix

4:10 PM Changeset in webkit [50382] by oliver@apple.com

2 edits in trunk/WebCore

Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983

Reviewed by Darin Adler

3:19 PM Changeset in webkit [50381] by oliver@apple.com

6 edits
6 adds in trunk

WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981

Reviewed by Jon Honeycutt.

Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.

Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html

fast/canvas/webgl/null-object-behaviour.html

2:54 PM BuildingOnWindows edited by jberlin@webkit.org

(diff)

Oct 30, 2009:

8:48 PM Changeset in webkit [50380] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

8:48 PM Changeset in webkit [50379] by mrowe@apple.com

1 copy in tags/Safari-6531.21.8

New tag.

8:47 PM Changeset in webkit [50378] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Fix the build.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):

7:11 PM Changeset in webkit [50377] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Fixed failing layout test: restore a special case I accidentally deleted.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30
Reviewed by Oliver Hunt.

runtime/DatePrototype.cpp:

(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.

5:51 PM Changeset in webkit [50376] by jhoneycutt@apple.com

2 edits in trunk/WebKitTools

Fix an issue that Adam noticed in DRT.

Reviewed by Darin Adler.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Get the length of the role text, and create a buffer dynamically.

5:26 PM Changeset in webkit [50375] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

5:25 PM Changeset in webkit [50374] by mrowe@apple.com

1 copy in tags/Safari-6531.21.7

New tag.

5:23 PM Changeset in webkit [50373] by mrowe@apple.com

3 edits
2 adds in branches/safari-4-branch

Merge r50356.

5:23 PM Changeset in webkit [50372] by mrowe@apple.com

6 edits
2 adds in branches/safari-4-branch

Merge r50355.

5:23 PM Changeset in webkit [50371] by mrowe@apple.com

7 edits in branches/safari-4-branch

Merge r50354.

5:23 PM Changeset in webkit [50370] by mrowe@apple.com

8 edits in branches/safari-4-branch

Merge r50353.

4:18 PM Changeset in webkit [50369] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryResult
https://bugs.webkit.org/show_bug.cgi?id=30857

Reviewed by Darin Adler.

Inherits MediaQueryResult class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
it is no need to be copyable.

css/CSSStyleSelector.h:

4:16 PM Changeset in webkit [50368] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

css/MediaQueryEvaluator.h:

4:10 PM Changeset in webkit [50367] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

css/MediaQueryEvaluator.h:

4:08 PM Changeset in webkit [50366] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleSet
https://bugs.webkit.org/show_bug.cgi?id=30852

Reviewed by Darin Adler.

Inherits CSSRuleSet class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
it is no need to be copyable.

css/CSSStyleSelector.cpp:

4:06 PM Changeset in webkit [50365] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleData
https://bugs.webkit.org/show_bug.cgi?id=30851

Reviewed by Darin Adler.

Inherits CSSRuleData class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
it is no need to be copyable.

css/CSSStyleSelector.h:

4:02 PM Changeset in webkit [50364] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleDataList
https://bugs.webkit.org/show_bug.cgi?id=30850

Reviewed by Darin Adler.

Inherits CSSRuleDataList class from Noncopyable because it has been
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
it is no need to be copyable.

css/CSSStyleSelector.h:

3:59 PM Changeset in webkit [50363] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSNamespace
https://bugs.webkit.org/show_bug.cgi?id=30849

Reviewed by Darin Adler.

Inherits CSSNamespace struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
it is no need to be copyable.

css/CSSNamespace.h:

3:41 PM Changeset in webkit [50362] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-30 Eric Seidel <eric@webkit.org>

No review, rolling out r50105.
http://trac.webkit.org/changeset/50105

This commit was causing:
https://bugs.webkit.org/show_bug.cgi?id=30869
We'll re-implement the feature a different way.

Scripts/bugzilla-tool:

3:35 PM Changeset in webkit [50361] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: update for object-to-pointer change.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

3:26 PM Changeset in webkit [50360] by dimich@chromium.org

5 edits in trunk/WebCore

Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
Move the synchronizer object out of the DatabaseTask so there is no need to keep
the pointer to Databasetask around after passing it to MessageQueue.
Also pass the references to return parameters to the task so it can update them.
https://bugs.webkit.org/show_bug.cgi?id=30941

Reviewed by David Levin.

No new tests, since this is just moving the code around, no change in functionality.

storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
(WebCore::Database::markAsDeletedAndClose): Ditto.
(WebCore::Database::tableNames): Ditto.
(WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
(WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.

storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
(WebCore::DatabaseTaskSynchronizer::taskCompleted):
(WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
(WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
(WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
(WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.

storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

3:23 PM Changeset in webkit [50359] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-29
Reviewed by Darin Adler.

SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.

runtime/DateInstance.cpp:

(JSC::DateInstance::gregorianDateTime):

runtime/DateInstance.h:
runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Renamed getGregorianDateTime to gregorianDateTime,
since it no longer has an out parameter. Uses 0 to indicate invalid dates.

3:09 PM Changeset in webkit [50358] by adele@apple.com

3 edits
2 adds in trunk

REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955
<rdar://problem/7067033>

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-30
Reviewed by Darin Adler.

WebCore:

When the command is deleteWordBackward or deleteWordForward
we should not add to the open typing command, but
create a new one.

Test: editing/undo/undo-deleteWord.html

editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.

LayoutTests:

editing/undo/undo-deleteWord-expected.txt: Added.
editing/undo/undo-deleteWord.html: Added.

3:03 PM Changeset in webkit [50357] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-10-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Make MediaPlayer constructor private
https://bugs.webkit.org/show_bug.cgi?id=30965

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.

platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): New.

2:38 PM Changeset in webkit [50356] by jhoneycutt@apple.com

3 edits
2 adds in trunk

Test for MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Adam Roben.

WebKitTools:

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Allow the role returned to be a BSTR.
(AccessibilityUIElement::description):
Fix a copy/paste error.

LayoutTests:

platform/win/accessibility/heading-elements-expected.txt: Added.
platform/win/accessibility/heading-elements.html: Added.

2:38 PM Changeset in webkit [50355] by jhoneycutt@apple.com

7 edits
2 adds in trunk

Test for MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(getAccessibilityValueCallback):
Return the accessibility value.
(AccessibilityUIElement::getJSClass):
Added "accessibilityValue" value.

DumpRenderTree/AccessibilityUIElement.h:

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::accessibilityValue):
Get the object's value, and return it as a JS string.

LayoutTests:

platform/win/accessibility/linked-elements-expected.txt: Added.
platform/win/accessibility/linked-elements.html: Added.

2:38 PM Changeset in webkit [50354] by jhoneycutt@apple.com

7 edits in trunk

MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Alice Liu.

WebCore:

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::stringRoleForMSAA):
(WebCore::AccessibilityObject::descriptionForMSAA):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::shouldReturnTagNameAsRoleForMSAA):
If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
true.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
If the element should return its tag name as the role, return the tag
name.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
If the object is a heading, return the string "L" followed by the
heading level.
(WebCore::AccessibilityRenderObject::descriptionForMSAA):
If the object has a positional description, return it. Otherwise, get
the accessibility description, and prefix it with "Description" so that
MSAA clients know that it's not a positional description.

accessibility/AccessibilityRenderObject.h:

WebKit/win:

AccessibleBase.cpp:

(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.

AccessibleBase.h:

Removed description(), as this was moved to WebCore.

2:37 PM Changeset in webkit [50353] by jhoneycutt@apple.com

8 edits in trunk

MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebCore:

accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::stringValueForMSAA):
Return the URL.
(WebCore::AccessibilityImageMapLink::nameForMSAA):
Return the alt text.

accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::isLinked):
Return true.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isLinked):
(WebCore::AccessibilityObject::stringValueForMSAA):
(WebCore::AccessibilityObject::nameForMSAA):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::isLinkable):
Return true if the element is considered "linkable" with respect to
accessibility.
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
If the element is linkable, check whether it has a parent anchor
element. If so, return the anchor element's href.
(WebCore::AccessibilityRenderObject::isLinked):
Return true if the element is linkable and if it's parent anchor tag's
href is non-empty.
(WebCore::AccessibilityRenderObject::nameForMSAA):
For text nodes, return the text.

accessibility/AccessibilityRenderObject.h:

WebKit/win:

AccessibleBase.cpp:

(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.

2:20 PM Changeset in webkit [50352] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch WebKitPrefix to force rebuild of WebKit.

1:59 PM Changeset in webkit [50351] by levin@chromium.org

24 edits in trunk

Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832

Patch by Evan Stade <estade@chromium.org> on 2009-10-30
Reviewed by David Levin.

WebCore:

This is similar to AX code that is already in place, except that this also informs the
chrome when there stops being a focused node. This is needed for a browser to show the
anchor for links that have keyboard focus.

dom/Document.cpp:

(WebCore::Document::setFocusedNode):

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::focusedNodeChanged):

page/Chrome.cpp:

(WebCore::Chrome::focusedNodeChanged):

page/Chrome.h:
page/ChromeClient.h:

WebKit/gtk: