⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 19, 2010:

11:39 PM Changeset in webkit [57874] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK form roles.

  • tests/testatkroles.c: (test_webkit_atk_get_role_check_box): (test_webkit_atk_get_role_entry): (test_webkit_atk_get_role_label): (test_webkit_atk_get_role_listbox): (test_webkit_atk_get_role_password_text): (test_webkit_atk_get_role_push_button): (test_webkit_atk_get_role_radio_button): (main):
11:30 PM Changeset in webkit [57873] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-19 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by David Hyatt.

Add missing dummy implementations in PluginPackageNone and PluginViewNone.
​http://webkit.org/b/37478

  • plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::NPVersion): Add dummy implementation.
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::handleFocusInEvent): Add dummy implementation. (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
11:18 PM Changeset in webkit [57872] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Turn off some unit tests for now - the new-run-webkit-tests dryrun
tests for chromium won't work if you don't have a chromium checkout.

​https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:00 PM Changeset in webkit [57871] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

(Re-)add dryrun.py; this was renamed from passing.py in the previous
CL but apparently somehow didn't get checked in.

​https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
10:41 PM Changeset in webkit [57870] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

check-webkit-style: exits when encountering a deleted file
​https://bugs.webkit.org/show_bug.cgi?id=37122

This reverts the quick fix done by r57119 and makes check_patch
not call check_file for deleted files.

Also this change fixes the behavior for "-", which should mean
stdin. Before this change, the style checker just ignored "-"
with a warning message.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
10:10 PM Changeset in webkit [57869] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-19 Daniel Bates <​dbates@rim.com>

No review, rolling out 57868.
​http://trac.webkit.org/changeset/57868
​https://bugs.webkit.org/show_bug.cgi?id=37748

Sheriffbot wasn't very inspirational after this patch.
Instead, he was silent when you said hi :-(. Rolling
out this patch so that I can debug/test this some more.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
9:34 PM Changeset in webkit [57868] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-19 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
9:22 PM Changeset in webkit [57867] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-04-19 Simon Fraser <Simon Fraser>

Reviewed by Geoff Garen.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
since it's only used for <object> fallback.

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
  • rendering/RenderEmbeddedObject.h: (WebCore::RenderEmbeddedObject::hasFallbackContent):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h:
9:02 PM Changeset in webkit [57866] by Simon Fraser
  • 15 edits
    4 copies in trunk/WebCore

2010-04-19 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=37741

Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
and move code from RenderPart and RenderPartObject into these new classes.


There should be no functionality difference with this change, so no new tests.


Fixing up renderer names in the layout tests will be done in a later pass.


Fix build systems to include the new files.


  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::createRenderer):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame):
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.cpp: Added. (WebCore::RenderFrameBase::RenderFrameBase): (WebCore::RenderFrameBase::layoutWithFlattening):
  • rendering/RenderFrameBase.h: Added.
  • rendering/RenderIFrame.cpp: Added. (WebCore::RenderIFrame::RenderIFrame): (WebCore::RenderIFrame::calcHeight): (WebCore::RenderIFrame::calcWidth): (WebCore::RenderIFrame::flattenFrame): (WebCore::RenderIFrame::layout):
  • rendering/RenderIFrame.h: Added. (WebCore::RenderIFrame::renderName):
  • rendering/RenderPart.cpp:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderPartObject.h:
8:59 PM Changeset in webkit [57865] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Bindings clean-up.
​https://bugs.webkit.org/show_bug.cgi?id=37833

Reviewed by Geoffrey Garen.

Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

7:59 PM Changeset in webkit [57864] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix the Mac builders for now by restoring the keepAlive function.

7:10 PM Changeset in webkit [57863] by kevino@webkit.org
  • 7 edits in trunk

Build fixes for wx with latest trunk.

6:43 PM Changeset in webkit [57862] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [57861] by jberlin@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

Remove an extra space in the getComputedStyle-with-psuedo-element test that was causing it to fail on the Chromium bots, and remove the platform-specific results that were landed in the meantime.

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
5:53 PM Changeset in webkit [57860] by dpranke@chromium.org
  • 5 edits
    1 delete in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
that can be used to test platforms other than the one you are running
on. This can be useful for checking baselines and testing code
coverage.

Note that running the code on the "wrong" port requires each
port-specific implementation to actually not require any
platform-specific python code (e.g., the chromium-win port must
test for the existence of windows functions before calling them).

​https://bugs.webkit.org/show_bug.cgi?id=37782

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:34 PM Changeset in webkit [57859] by mrowe@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force generated interfaces to be rebuilt. Boo.

5:33 PM Changeset in webkit [57858] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add --build (default) and --no-build
options to make that step optional. This flag modifies what happens
in port.check_build().

​https://bugs.webkit.org/show_bug.cgi?id=37786

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:24 PM Changeset in webkit [57857] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:16 PM Changeset in webkit [57856] by mrowe@apple.com
  • 38 edits
    2 deletes in trunk

Roll out r57823.

It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
by shipping clients of WebKit on Windows. Adding methods to a delegate interface in this
manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
methods are used.

4:35 PM Changeset in webkit [57855] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests - fix a typo in r57480 that caused us to stop
logging the actual list of unexpected results.

​https://bugs.webkit.org/show_bug.cgi?id=37831

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:30 PM Changeset in webkit [57854] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
4:26 PM Changeset in webkit [57853] by barraclough@apple.com
  • 23 edits
    4 deletes in trunk

This broke windows.

Reviewed by NOBODY (rolling out r57829).

JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):

  • runtime/Identifier.h:

(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Removed.
  • wtf/WTFThreadData.h: Removed.

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • JSUtils.cpp:

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::atomicStringTable):

  • platform/text/AtomicString.cpp:

(WebCore::stringTable):

4:24 PM Changeset in webkit [57852] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • platform/graphics/mac/GraphicsContext3DMac.cpp:
4:10 PM Changeset in webkit [57851] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed and landed by Anders Carlsson.

Patch by Douglas Gregor <​dgregor@apple.com> on 2010-04-19

  • runtime/UStringImpl.h:

Fix class/struct declaration mismatches.

4:05 PM Changeset in webkit [57850] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

From a patch by Tor Arne Vestbo <​tor.arne.vestbo@nokia.com>

new-run-webkit-tests: make the retry step more explicit
​https://bugs.webkit.org/show_bug.cgi?id=37606

It might be confusing to see the test and percent counters
reset without any notice of what's going on, so we make the
message that a retry-run is started explicit.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:59 PM Changeset in webkit [57849] by weinig@apple.com
  • 8 edits in trunk/WebKitTools

Add support for opening a new window (File->New Window) to
Windows MiniBrowser. Accelerator doesn't work.

Reviewed by Anders Carlsson.

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Use BrowserView::create.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
by creating a new window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::create): Added. Don't allow creating
BrowserWindows on the stack by making constructor
private and exposing the create function.

  • MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::createNewWindow): Move new window creation
logic here.

  • MiniBrowser/win/MiniBrowser.h:
  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/main.cpp:

(_tWinMain): Use the new MiniBrowser::createNewWindow().

3:54 PM QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
3:27 PM Changeset in webkit [57848] by Chris Fleizach
  • 8 edits
    2 adds in trunk

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

Test: platform/mac/accessibility/element-haspopup.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaHasPopup):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaHasPopup): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • platform/mac/accessibility/element-haspopup-expected.txt: Added.
  • platform/mac/accessibility/element-haspopup.html: Added.

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::hasPopup):
3:09 PM Changeset in webkit [57847] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Submit a better workaround for r57806 than the one in r57831 - log
an error and exit if you try to run new-run-webkit-tests with --use-drt
on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=37822

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:03 PM Changeset in webkit [57846] by jesus@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Just adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
2:59 PM Changeset in webkit [57845] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add slightly better logging to the websocket python wrapper script,
including a --verbose flag for debug output.

​https://bugs.webkit.org/show_bug.cgi?id=37233

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/new-run-webkit-websocketserver:
2:57 PM Changeset in webkit [57844] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix a crash when rendering <select> elements with WebKit2.

Reviewed by Sam Weinig.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.

2:56 PM Changeset in webkit [57843] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a way (--print-unexpected-results) to
(re-)print out the tests that produced unexpected results in the
last run. Also add a way (--retry-unexpected-results) to
automatically re-test them.

​https://bugs.webkit.org/show_bug.cgi?id=37783

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:48 PM Changeset in webkit [57842] by jamesr@google.com
  • 1 edit
    6 adds
    3 deletes in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed, move chromium baselines for fast/url around.

The desired behavior is that chromium-win use one set of baselines and
chromium-mac/chromium-linux use another, however to do we have to
duplicate the mac+linux results into chromium-mac and chromium-linux.

  • platform/chromium-linux/fast/url/file-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-win-expected.txt: Added.
  • platform/chromium-mac/fast/url/file-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/fast/url/file-expected.txt: Removed.
  • platform/chromium/fast/url/relative-unix-expected.txt: Removed.
  • platform/chromium/fast/url/relative-win-expected.txt: Removed.
2:41 PM Changeset in webkit [57841] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Restructure the logging in new-run-webkit-tests so that many of log
messages that were logged to the MeteredStream also get logged in
--verbose mode.

​https://bugs.webkit.org/show_bug.cgi?id=37780

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:39 PM Changeset in webkit [57840] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add 'summary' and 'unexpected-results' options
to the --log flag. Also add a 'progress' flag to enable the regular
progress bar (as opposed to 'detailed-progress', which enables the
dots). Also add a 'nothing' flag to allow you to be explicit that
you don't want any logging on the command line.

The default is
'--log detailed-progress,summary,unexpected,unexpected-results'

(The default logging is unchanged by this patch, this just makes things
properly configurable).

Note that 'nothing' doesn't work properly yet; I need a couple other
patches to land to avoid rewriting things several different ways.

​https://bugs.webkit.org/show_bug.cgi?id=37785

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:15 PM Changeset in webkit [57839] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
​https://bugs.webkit.org/show_bug.cgi?id=36031

Reviewed by Darin Adler.

WebCore:

Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.

Test: fast/dom/Node/fragment-mutation.html

  • dom/ContainerNode.cpp:

(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in

inserting/appending operation.

(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.

  • dom/Node.cpp:

(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.

LayoutTests:

These tests study various side-effects of DOM mutation events fired during appending/inserting
document fragments.

  • fast/dom/Node/fragment-mutation-expected.txt: Added.
  • fast/dom/Node/fragment-mutation.html: Added.
2:10 PM Changeset in webkit [57838] by jamesr@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed - yet more rebaselines and expectation updates.

  • platform/chromium-win/fast/url/file-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [57837] by ggaren@apple.com
  • 1 edit
    3 adds in trunk/JavaScriptCore

Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.

Reviewed by Beth Dakin.

  • tests/perf: Added.
  • tests/perf/bench-allocate-nonretained.js: Added.
  • tests/perf/bench-allocate-retained.js: Added.
1:56 PM Changeset in webkit [57836] by kenneth@webkit.org
  • 4 edits in trunk/WebKitTools

Make the URL change on committed load.

Reviewed by Simon Hausmann.

  • QtLauncher/mainwindow.cpp:

(MainWindow::buildUI):
(MainWindow::setAddressUrl):

  • QtLauncher/mainwindow.h:
1:51 PM Changeset in webkit [57835] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:50 PM Changeset in webkit [57834] by jamesr@google.com
  • 4 edits
    3 adds
    2 deletes in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed. More chromium rebaselines+expectation updates.

  • platform/chromium-linux/fast/css/getComputedStyle: Added.
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-mac/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:35 PM Changeset in webkit [57833] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix a typo in the rebaselining tool that causes us to use "debug"
instead of "Debug" in a directory path, which fails on platforms with
case-sensitive filesystems.

​https://bugs.webkit.org/show_bug.cgi?id=37819

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1:20 PM Changeset in webkit [57832] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed build fix.

Update chromium expectations

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [57831] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix breakage of chromium-win canary bots caused by r57806. That patch
introduced the option of using Chrome's new port of DumpRenderTree,
but unfortunately that port relies on the webkit.py class
implementation which uses non-blocking I/O that isn't available on
Windows. This patch turns off that option and doesn't import the
class if we're running on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=37817

  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:12 PM Changeset in webkit [57830] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix regression introduced in r57820.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of just setting a URL on the one used for the previous <source> element. This restores the behavior prior to the changes for ​https://bugs.webkit.org/show_bug.cgi?id=37728.
1:05 PM Changeset in webkit [57829] by barraclough@apple.com
  • 22 edits
    2 copies
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.

Reviewed by Sam Weinig.

Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.

JavaScriptCore:

WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.

This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):

  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.

(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • JSUtils.cpp: Update

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h: Remove m_atomicStringTable.

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().

1:00 PM CommitterTips edited by jesus@webkit.org
There is no more "--no-build" option anymore. (diff)
12:36 PM Changeset in webkit [57828] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-04-19 James Robinson <​jamesr@chromium.org>

Reviewed by abarth.

Fix a typo

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
12:29 PM Changeset in webkit [57827] by jamesr@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2010-04-19 James Robinson <​jamesr@chromium.org>

Unreviewed build fix for Chromium

Add baselines for new platform-specific tests.

  • platform/chromium/fast/url: Added.
  • platform/chromium/fast/url/file-expected.txt: Added.
  • platform/chromium/fast/url/relative-expected.txt: Added.
  • platform/chromium/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [57826] by adachan@apple.com
  • 3 edits in trunk/WebCore

Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
12:13 PM Changeset in webkit [57825] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests when there are spaces in the path

Fixes <​http://webkit.org/b/37809>

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Use an "indirect object" to specify the

path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.

12:01 PM Changeset in webkit [57824] by Dimitri Glazkov
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild of Interfaces.vcproj

11:49 AM Changeset in webkit [57823] by Dimitri Glazkov
  • 38 edits
    2 adds in trunk

WebCore: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

Test: fast/dom/icon-url-property.html

  • dom/Document.cpp:

(WebCore::Document::setIconURL):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setIconURL):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::iconURL):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didChangeIcons):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

  • src/FrameLoaderClientImpl.h:

WebKit/gtk: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidChangeIcons):

WebKit/qt: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::didChangeTitle):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:

(WebFrame::didChangeIcons):

  • WebFrame.h:

WebKitTools: Add test support for icon changes.

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpIconChangesCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpIconChanges):
(LayoutTestController::setDumpIconChanges):

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didChangeIcons):

  • DumpRenderTree/win/FrameLoadDelegate.h:
  • WinLauncher/WinLauncher.h:

(WinLauncherWebHost::didChangeIcons):

LayoutTests: Add test for icon change notifications.

Patch by Dave Moore <​davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33812

  • fast/dom/icon-url-property-expected.txt: Added.
  • fast/dom/icon-url-property.html: Added.
  • Skipped on all platforms but Win
11:37 AM Changeset in webkit [57822] by adachan@apple.com
  • 12 edits in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.

Reviewed by Jeremy Orlow.

  • WebCore.base.exp: Export Settings::setSessionStorageQuota().
  • page/Page.cpp:

(WebCore::Page::sessionStorage):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

  • page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::sessionStorageNamespace):

  • storage/StorageNamespaceImpl.h:

WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=37717
Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
StorageNamespace::sessionStorageNamespace() take in a quota parameter.

Reviewed by Jeremy Orlow.

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • src/WebStorageNamespaceImpl.cpp:

(WebKit::WebStorageNamespace::createSessionStorageNamespace):

11:34 AM Changeset in webkit [57821] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for WinCE.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

Moved the include of the non-existing errno.h header file inside
platform guard macros.

  • jit/ExecutableAllocatorFixedVMPool.cpp:
11:28 AM Changeset in webkit [57820] by eric.carlson@apple.com
  • 9 edits
    2 deletes in trunk

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
​https://bugs.webkit.org/show_bug.cgi?id=37728

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute changes unless it is missing. (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal. (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad. (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad so the previously loading file, if any, is cancelled there.

2010-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
​https://bugs.webkit.org/show_bug.cgi?id=37728

  • media/event-attributes-expected.txt: Updated results.
  • media/event-attributes.html: Do not need to call load().
  • media/video-source-add-src-expected.txt: Removed.
  • media/video-source-add-src.html: Removed.
  • media/video-src-change-expected.txt: Updated results.
  • media/video-src-change.html: Update test to match current behavior.
  • media/video-src-invalid-remove-expected.txt: Updated results.
  • media/video-src-invalid-remove.html: Update test to match current behavior.
11:07 AM Changeset in webkit [57819] by Simon Hausmann
  • 8 edits in trunk

[Qt] Fix compilation against namespaced Qt.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

WebCore:

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/Tile.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.h:
11:00 AM Changeset in webkit [57818] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-19 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Destroy SharedTimerQt before destruction of QCoreApplication.

To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
into the SharedTimerQt instance.

​https://bugs.webkit.org/show_bug.cgi?id=36832

No functional change so no new tests.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::destroy): (WebCore::SharedTimerQt::inst):
10:48 AM Changeset in webkit [57817] by mitz@apple.com
  • 2 edits in trunk/WebCore

Make the fix for <rdar://problem/7873647> from r57759 more robust.

Reviewed by Darin Adler.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.

10:43 AM Changeset in webkit [57816] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-04-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

WinLauncher.h should use LF line-endings and use native line-endings style.
​https://bugs.webkit.org/show_bug.cgi?id=37807

  • WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
10:38 AM Changeset in webkit [57815] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Add and enable the build of testatkroles to test ATK non form roles.

  • GNUmakefile.am:

2010-04-19 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Add testatkroles to test ATK non form roles.

  • tests/testatkroles.c: Added. (finish_loading): (atk_roles_fixture_setup): (atk_roles_fixture_teardown): (get_child_and_test_role): (test_webkit_atk_get_role_document_frame): (test_webkit_atk_get_role_heading): (test_webkit_atk_get_role_image): (test_webkit_atk_get_role_link): (test_webkit_atk_get_role_list_and_item): (test_webkit_atk_get_role_paragraph): (test_webkit_atk_get_role_section): (test_webkit_atk_get_role_table): (main):
10:21 AM Changeset in webkit [57814] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by Sam Weinig.

  • WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
10:11 AM Changeset in webkit [57813] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-04-19 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix.

  • bindings/v8/JavaScriptCallFrame.h:
10:01 AM Changeset in webkit [57812] by yurys@chromium.org
  • 10 edits
    3 adds in trunk

2010-04-19 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement JavaScriptCallFrame that works for v8.
Implementing this binding for v8 allows to make evaluations on
call frames and protects access to the debugger context from
inspected context.

​https://bugs.webkit.org/show_bug.cgi?id=37755

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/v8/JavaScriptCallFrame.cpp: Added. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::scopeType): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/v8/JavaScriptCallFrame.h: Added. (WebCore::JavaScriptCallFrame::create):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added. (WebCore::V8JavaScriptCallFrame::evaluateCallback): (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter): (WebCore::V8JavaScriptCallFrame::scopeTypeCallback): (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter): (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
  • inspector/JavaScriptCallFrame.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
9:41 AM Changeset in webkit [57811] by Csaba Osztrogonác
  • 5 edits
    39 adds in trunk/LayoutTests

[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.

Rubber-stamped by Simon Hausmann.

Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped:
  • platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
  • platform/qt/fast/frames/frame-navigation-expected.png: Added.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
  • platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
  • platform/qt/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt/fast/overflow/line-clamp-expected.txt: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
  • platform/qt/http/tests/misc/error404-expected.checksum: Added.
  • platform/qt/http/tests/misc/error404-expected.png: Added.
  • platform/qt/http/tests/misc/error404-expected.txt: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
  • platform/qt/http/tests/misc/iframe404-expected.png: Added.
  • platform/qt/http/tests/misc/iframe404-expected.txt: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/qt/http/tests/uri/css-href-expected.checksum: Added.
  • platform/qt/http/tests/uri/css-href-expected.png: Added.
  • platform/qt/http/tests/uri/css-href-expected.txt: Updated.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
8:05 AM Changeset in webkit [57810] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Rubber Stamped by Adam Roben

Chromium Release Build Fix.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.

6:28 AM Changeset in webkit [57809] by jberlin@webkit.org
  • 13 edits
    2 adds in trunk

First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
​https://bugs.webkit.org/show_bug.cgi?id=24021

Reviewed by Dave Hyatt.

WebCore:

Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.

Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html

  • WebCore.base.exp:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Take into consideration the pseudo-element.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.

  • dom/Element.cpp:

(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.

  • dom/Element.h:

(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.

  • dom/Node.h:

(WebCore::Node::computedStyle):
Ditto.

  • dom/Node.cpp:

(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):
Ditto.

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.
4:54 AM Changeset in webkit [57808] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] lacks clipToImageBuffer()
​https://bugs.webkit.org/show_bug.cgi?id=24289

Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.

  • platform/qt/Skipped:
2:05 AM Changeset in webkit [57807] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a test initialization problem
​https://bugs.webkit.org/show_bug.cgi?id=37791

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Call resetTestController() before runFileTest(). Some controllers initialize their fields in reset() and not in their constructors.
1:52 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:40 AM Changeset in webkit [57806] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
​https://bugs.webkit.org/show_bug.cgi?id=37793

We need to use WebKitDriver instead of ChromiumDriver for Chromium
DRT because its interface is different from test_shell.

Chromium DRT has no UI. So we can't use it to show test results.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

Apr 18, 2010:

11:36 PM Changeset in webkit [57805] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Make failure-reason more forgiving
​https://bugs.webkit.org/show_bug.cgi?id=37525

Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:13 PM Changeset in webkit [57804] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-18 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Laszlo Gombos.

[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
​https://bugs.webkit.org/show_bug.cgi?id=37434

Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.

  • wtf/Platform.h:
9:26 PM Changeset in webkit [57803] by Chris Jerdonek
  • 3 edits
    2 adds in trunk/WebKitTools

Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
  • Scripts/webkitpy/style/checker.py:
    • Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
    • Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
  • Scripts/webkitpy/style/filereader.py: Added.
    • Created a TextFileReader class that encapsulates reading and iterating over text files.
  • Scripts/webkitpy/style/filereader_unittest.py: Added.
    • Added a TextFileReaderTest class to unit-test the new TextFileReader class.
9:22 PM Changeset in webkit [57802] by eric@webkit.org
  • 4 edits in trunk

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

  • WebCore.pro:
9:08 PM Changeset in webkit [57801] by eric@webkit.org
  • 2 edits in trunk

2010-04-18 Michael Forney <​michael@mforney.org>

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=37762

Fixes the sandbox option in configure.

  • configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
8:26 PM Changeset in webkit [57800] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests should be able to use chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=37645

Make sure that the lack of a chromium checkout doesn't cause the script to
fail.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths

to be relative to an upstream output dir.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2:25 PM Changeset in webkit [57799] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Exit non-zero of launching the harness fails.
1:58 PM Changeset in webkit [57798] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
1:56 PM Changeset in webkit [57797] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-18 Adam Barth <​abarth@webkit.org>

Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.

  • blog-files/loader-diagram.svg:
1:34 PM Changeset in webkit [57796] by eric@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
​https://bugs.webkit.org/show_bug.cgi?id=37632

This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.

Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.

I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.

  • Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
  • Scripts/run-webkit-tests:
    • A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
10:43 AM Changeset in webkit [57795] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33295

The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
4:01 AM Changeset in webkit [57794] by robert@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Add support for LayoutTestController commands

2010-04-18 Robert Hogan <​robert@webkit.org>

Unreviewed fix to pixel differences in unskipped layout tests.

[Qt] Add support for LayoutTestController commands

Fix up minor pixel differences on unskipped tests from r57793.

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt:
3:36 AM Changeset in webkit [57793] by robert@webkit.org
  • 17 edits in trunk

[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:25 AM Changeset in webkit [57792] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-18 Antonio Gomes <​tonikitoo@webkit.org>

[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

It was removed by r57511.

  • platform/qt/Skipped:

Apr 17, 2010:

11:27 PM Changeset in webkit [57791] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

  • blog-files/loader-diagram.svg: Added.
11:03 PM Changeset in webkit [57790] by ap@apple.com
  • 8 edits in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
  • bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.
  • html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.
  • html/HTMLFrameSetElement.idl: Ditto.
10:00 PM Changeset in webkit [57789] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-04-17 Juan C. Montemayor <​jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
​https://bugs.webkit.org/show_bug.cgi?id=20219

  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
5:42 PM Changeset in webkit [57788] by eric@webkit.org
  • 13 edits
    2 deletes in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
​https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
1:43 PM Changeset in webkit [57787] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
​https://bugs.webkit.org/show_bug.cgi?id=37453

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
  • bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
1:10 PM Changeset in webkit [57786] by eric@webkit.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
​https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land ​http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

  • fast/url/file-expected.txt: Added.
  • fast/url/file.html: Added.
  • fast/url/mailto.html:
  • fast/url/script-tests/file.js: Added.
1:00 PM Changeset in webkit [57785] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
​https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

  • fast/url/relative-expected.txt: Added.
  • fast/url/relative-unix-expected.txt: Added.
  • fast/url/relative-unix.html: Added.
  • fast/url/relative-win-expected.txt: Added.
  • fast/url/relative-win.html: Added.
  • fast/url/relative.html: Added.
  • fast/url/script-tests/relative-unix.js: Added.
  • fast/url/script-tests/relative-win.js: Added.
  • fast/url/script-tests/relative.js: Added.
11:42 AM Changeset in webkit [57784] by eric@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-04-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

​https://bugs.webkit.org/show_bug.cgi?id=37740

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorController.h:
9:00 AM Changeset in webkit [57783] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
​https://bugs.webkit.org/show_bug.cgi?id=37753

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [57782] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
​https://bugs.webkit.org/show_bug.cgi?id=37752

  • platform/gtk/Skipped:
8:16 AM Changeset in webkit [57781] by alex
  • 2 edits in trunk/WebKit/gtk

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

  • webkit/webkitdownload.cpp: (webkit_download_finalize):
7:55 AM Changeset in webkit [57780] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
​https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

  • WebCore.gypi: Added GLES2Context.h
  • platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
​https://bugs.webkit.org/show_bug.cgi?id=37541

  • WebKit.gyp:
  • public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
  • src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):
6:37 AM Changeset in webkit [57779] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Crash while handling SVG font in the wrong namespace imported with @font-face
​https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

  • fast/invalid/invalidSVGFont-expected.txt: Added.
  • fast/invalid/invalidSVGFont.html: Added.
  • fast/invalid/resources/svgFontWrongNamespace.svg: Added.
1:13 AM Changeset in webkit [57778] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
​https://bugs.webkit.org/show_bug.cgi?id=37742

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1:02 AM Changeset in webkit [57777] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Fix expected results for unit test broken by
​http://trac.webkit.org/changeset/57772

  • Scripts/webkitpy/common/net/buildbot_unittest.py:

Apr 16, 2010:

11:14 PM Changeset in webkit [57776] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r57770.
​http://trac.webkit.org/changeset/57770
​https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

  • platform/qt/Skipped:
9:40 PM Changeset in webkit [57775] by dbates@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-04-16 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=36312

Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <​http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

  • Android.mk: Added file ViewportArguments.cpp.
  • GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::isSeparator): Added. (WebCore::Document::processArguments): Added. (WebCore::Document::processViewport): Added.
  • dom/Document.h:
  • dom/ViewportArguments.cpp: Added. (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
  • dom/ViewportArguments.h: Added. (WebCore::): (WebCore::ViewportArguments::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
  • page/ChromeClient.h: (WebCore::ChromeClient::didReceiveViewportArguments): Added.
8:23 PM Changeset in webkit [57774] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebKit2

Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

  • UIProcess/API/C/WKBase.h:
  • WebProcess/win/WebProcessMain.h:
  • win/WebKit2.def: Removed.
  • win/WebKit2.vcproj:
8:06 PM Changeset in webkit [57773] by weinig@apple.com
  • 8 edits in trunk

Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

  • win/WebKit2.def:

WebKitTools:

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.

  • MiniBrowser/win/BrowserView.h:

(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

  • MiniBrowser/win/main.cpp:

(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

7:53 PM Changeset in webkit [57772] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

  • Scripts/webkitpy/common/net/buildbot.py:

(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

7:30 PM Changeset in webkit [57771] by dumi@chromium.org
  • 2 edits in trunk/WebKit/chromium

Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

7:04 PM Changeset in webkit [57770] by eric@webkit.org
  • 4 edits in trunk

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
​https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
5:24 PM Changeset in webkit [57769] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

5:20 PM Changeset in webkit [57768] by dumi@chromium.org
  • 4 edits in trunk/WebKit/chromium

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
​https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

  • public/WebSecurityOrigin.h:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

5:14 PM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:12 PM Changeset in webkit [57767] by dimich@chromium.org
  • 7 edits
    1 move
    1 add in trunk

WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.

  • bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
​https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

  • platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
  • platform/chromium/fast/workers/worker-close-expected.txt: Added.
5:10 PM Changeset in webkit [57766] by barraclough@apple.com
  • 28 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSMimeTypeArrayCustom.cpp:

(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginArrayCustom.cpp:

(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):

  • bindings/js/JSPluginCustom.cpp:

(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::initPopStateEvent):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

  • platform/text/AtomicString.h:

(WebCore::AtomicString::AtomicString):

4:58 PM Changeset in webkit [57765] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix typo from r55729

  • platform/win/Skipped:
4:51 PM Changeset in webkit [57764] by weinig@apple.com
  • 5 edits in trunk

Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(_createNewPage): Use the correct initializer to and load the window.

4:45 PM Changeset in webkit [57763] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

  • platform/chromium/test_expectations.txt:
4:31 PM Changeset in webkit [57762] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [57761] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Don't optimize debug builds.

Reviewed by Mark Rowe.

  • WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.
4:13 PM Changeset in webkit [57760] by ukai@chromium.org
  • 3 edits
    4 adds in trunk

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
​https://bugs.webkit.org/show_bug.cgi?id=37682

  • websocket/tests/bad-handshake-crash-expected.txt: Added.
  • websocket/tests/bad-handshake-crash.html: Added.
  • websocket/tests/bad-handshake-crash_wsh.py: Added.
  • websocket/tests/script-tests/bad-handshake-crash.js: Added.

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
​https://bugs.webkit.org/show_bug.cgi?id=37682

If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.

Test: websocket/tests/bad-handshake-crash.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.
4:10 PM Changeset in webkit [57759] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

  • fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
  • fast/dynamic/hover-style-recalc-crash.html: Added.
4:07 PM Changeset in webkit [57758] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3DInternal::beginPaint):

3:42 PM Changeset in webkit [57757] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

3:31 PM Changeset in webkit [57756] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
3:29 PM Changeset in webkit [57755] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [57754] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Make Safari correctly allocate 5MB of DB storage to all new
origins.
​https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::detailsForNameAndOrigin):

3:06 PM Changeset in webkit [57753] by scherkus@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-04-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

  • platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:05 PM Changeset in webkit [57752] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
2:57 PM Changeset in webkit [57751] by mrowe@apple.com
  • 4 edits in tags/Safari-533.5.2/WebKit/win

Merge r57615.

2:56 PM Changeset in webkit [57750] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.2

Versioning.

2:55 PM Changeset in webkit [57749] by kinuko@chromium.org
  • 9 edits
    3 adds in trunk/WebCore

2010-04-16 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
​https://bugs.webkit.org/show_bug.cgi?id=37218

No new tests; tests will be added when we add upper layer implementations.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: (WebCore::FileStream::stop):
  • html/FileStream.h:
  • html/FileStreamClient.h: (WebCore::FileStreamClient::didStop):
  • html/FileStreamProxy.cpp: Added
  • html/FileStreamProxy.h: Added
  • html/FileThreadTask.h: Added
2:50 PM Changeset in webkit [57748] by barraclough@apple.com
  • 11 edits in trunk

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

  • WebCore.base.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsString):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::create):

  • platform/text/StringImpl.h:
2:39 PM Changeset in webkit [57747] by eric@webkit.org
  • 7 edits in trunk

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
​https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getOwnerGLWidget): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
​https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
2:39 PM Changeset in webkit [57746] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.2

New tag.

2:27 PM Changeset in webkit [57745] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebKit compilation fails with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=37699

API for readPixels() has been changed.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::readPixels):
2:16 PM Changeset in webkit [57744] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt]QtLauncher crash on page with CSS 3D transform
​https://bugs.webkit.org/show_bug.cgi?id=36859

Added a neccessary null-pointer check, lack of which created the crash circumstances.

Tested by ​http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
2:14 PM Changeset in webkit [57743] by scherkus@chromium.org
  • 59 edits in trunk/LayoutTests

2010-04-16 Sergey Ulanov <​sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
2:08 PM Changeset in webkit [57742] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

1:52 PM Changeset in webkit [57741] by andersca@apple.com
  • 2 edits in trunk/WebCore

Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

  • platform/mac/ThemeMac.mm:

(WebCore::paintCheckbox):
(WebCore::paintRadio):

1:34 PM Changeset in webkit [57740] by barraclough@apple.com
  • 3 edits in trunk/WebKit/win
  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

1:26 PM Changeset in webkit [57739] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix windows build.

Reviewed by Sam Weinig.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::run):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody):
(WebKit::launchWebProcess):

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain):

1:21 PM Changeset in webkit [57738] by barraclough@apple.com
  • 73 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:

WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString

  • to JSDOMBindings.h, and updates code to call these methods.
  • WebCore.base.exp:
  • WebCore.order:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::getEventListenerHandlerBody):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptObject::set):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:

(WebCore::ScriptValue::toString):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):

  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::sourceString):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • platform/KURL.h:

(WebCore::KURL::operator const String&):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptDebugger.mm:

(toNSURL):

  • WebView/WebView.mm:

(aeDescFromJSValue):

1:15 PM Changeset in webkit [57737] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

  • Use the same waitFor logic as do for the Mac resizing DrawingAreaUpdateChunk code.
  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):

  • Shared/win/UpdateChunk.h: Add a constructor that only takes an IntRect and allocates the shared memory mapping for you.
  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:

Perform wait in paint as we do on the mac.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

Specialize setSize() drawing and factor out painting
into a helper function.

1:13 PM Changeset in webkit [57736] by ajwong@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

  • platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-win/fast/url/standard-url-expected.txt:
1:05 PM Changeset in webkit [57735] by ajwong@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

  • platform/chromium-linux/fast/url/host-expected.txt: Added.
  • platform/chromium-linux/fast/url/path-expected.txt: Added.
  • platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
12:58 PM Changeset in webkit [57734] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Always pass a view to the AppKit drawing functions.
​https://bugs.webkit.org/show_bug.cgi?id=37724

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
12:45 PM Changeset in webkit [57733] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

Test: fast/events/recorded-keydown-event.html

  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is frameless.
12:36 PM Changeset in webkit [57732] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2010-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Make run loops be allocated as thread specific data.
​https://bugs.webkit.org/show_bug.cgi?id=37723

  • Platform/RunLoop.cpp: (RunLoop::initializeMainRunLoop): (RunLoop::current): (RunLoop::main):
  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm: (RunLoop::run): (RunLoop::stop):
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: (WebKit::webThreadBody): (WebKit::launchWebProcess):
  • UIProcess/ResponsivenessTimer.cpp: (WebKit::ResponsivenessTimer::ResponsivenessTimer):
  • WebProcess/Launching/mac/WebProcessMain.mm: (main):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::isSeparateProcess):
11:52 AM Changeset in webkit [57731] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <​http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
11:40 AM Changeset in webkit [57730] by Adam Roben
  • 3 edits in trunk/WebKit/win

Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

  • ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which

lists all our instantiatable classes.

  • WebKitClassFactory.cpp: Added a now-required #include.
11:19 AM Changeset in webkit [57729] by Adam Roben
  • 2 edits in trunk/LayoutTests

SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<​http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped:
11:19 AM Changeset in webkit [57728] by ukai@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=37687

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
11:07 AM Changeset in webkit [57727] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-04-16 Jian Li <​jianli@chromium.org>

Reviewed by Dmitry Titov.

Update FormDataList to fix style violations in old code.
​https://bugs.webkit.org/show_bug.cgi?id=37689

  • html/FormDataList.h: (WebCore::FormDataList::appendData): (WebCore::FormDataList::appendBlob):
11:00 AM Changeset in webkit [57726] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Update FormDataList to fix style violations in old code.
​https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

10:59 AM Changeset in webkit [57725] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix WebKit2 build.

  • WebCore.base.exp:
10:18 AM Changeset in webkit [57724] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-16 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-16 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
10:09 AM Changeset in webkit [57723] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor.

9:18 AM Changeset in webkit [57722] by eric@webkit.org
  • 9 edits
    3 deletes in trunk/LayoutTests

2010-04-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57719.
​http://trac.webkit.org/changeset/57719
​https://bugs.webkit.org/show_bug.cgi?id=37708

Broke 8 URL tests on Windows due to use of ​file:///tmp/ URLs,
which don't work on Windows. (Requested by aroben on #webkit).

  • fast/url/anchor.html:
  • fast/url/file-expected.txt: Removed.
  • fast/url/file.html: Removed.
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/script-tests/TEMPLATE.html:
  • fast/url/script-tests/file.js: Removed.
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
7:11 AM Changeset in webkit [57721] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Antonio Gomes <​tonikitoo@webkit.org>

Unreviewed QtWebKit (with Qt 4.7) build fix.

Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:36 AM Changeset in webkit [57720] by eric@webkit.org
  • 5 edits in trunk

2010-04-16 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37690

  • DEPS: Need to roll deps to remove a dependency on src/chrome
  • gyp_webkit: generate makefiles for DRT.gyp on Linux

2010-04-16 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37690

  • Scripts/build-dumprendertree: Add support for win and linux
12:27 AM Changeset in webkit [57719] by mjs@apple.com
  • 9 edits
    3 adds in trunk/LayoutTests

2010-04-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Test file: URL canonicalization
​https://bugs.webkit.org/show_bug.cgi?id=37700

  • fast/url/script-tests/file.js: Added new test.
  • fast/url/file-expected.txt: Added (expected results).
  • fast/url/file.html: Added (wrapper).
  • fast/url/script-tests/TEMPLATE.html: Add an explicit dependable <base> URL to the template, to avoid making test expectations system dependent.


Other test wrappers regenerated for the above change:

  • fast/url/anchor.html:
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
12:25 AM Changeset in webkit [57718] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.

[Qt] GraphicsLayer: performance optimizations
​https://bugs.webkit.org/show_bug.cgi?id=35393

No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::updateState):
12:20 AM QtWebKitRelease20 edited by Henry Haverinen
(diff)
12:19 AM QtWebKit edited by Henry Haverinen
(diff)
12:14 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:14 AM Changeset in webkit [57717] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-16 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebCore::Font::font() causes a QFont detach
​https://bugs.webkit.org/show_bug.cgi?id=37683

Moved the setStyleStrategy call to FontPlatformData
to avoid the detach.

Thanks to Holger for spotting this.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
12:13 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:03 AM Changeset in webkit [57716] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
​http://webkit.org/b/35915

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
  • efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.
Note: See TracTimeline for information about the timeline view.