Timeline
Jul 5, 2010:
- 11:48 PM Changeset in webkit [62529] by
-
- 11 edits in trunk/WebCore
2010-07-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Add WebSocket resource type to Web Inspector.
When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
- inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
- inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
- websockets/WebSocketChannel.h:
- 11:43 PM Changeset in webkit [62528] by
-
- 2 edits in trunk/WebCore
2010-07-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium build.
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
- 11:29 PM Changeset in webkit [62527] by
-
- 3 edits in trunk/WebCore
2010-07-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Move processStartTagForInBody to its own function.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
- html/HTMLTreeBuilder.cpp.orig: Added.
- html/HTMLTreeBuilder.h:
- 11:29 PM Changeset in webkit [62526] by
-
- 2 edits in trunk/WebKitTools
2010-07-05 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Eric Seidel.
REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
https://bugs.webkit.org/show_bug.cgi?id=41612
- Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
- 11:14 PM Changeset in webkit [62525] by
-
- 4 edits in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix one more notImplemented in h1-h6 start tag handling
https://bugs.webkit.org/show_bug.cgi?id=41654
- html5lib/runner-expected-html5.txt:
- Fix two sub-tests!
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix one more notImplemented in h1-h6 start tag handling
https://bugs.webkit.org/show_bug.cgi?id=41654
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 11:05 PM Changeset in webkit [62524] by
-
- 3 edits in trunk/WebCore
2010-07-05 Eric Seidel <eric@webkit.org>
Unreviewed. Just fixing proess to process.
Clearly Adam and I can't spell. Thankfully MikeSmith can.
Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakeStartTag): (WebCore::HTMLTreeBuilder::processFakeEndTag): (WebCore::HTMLTreeBuilder::processIsindexStartTagForBody): (WebCore::HTMLTreeBuilder::processStartTag):
- html/HTMLTreeBuilder.h:
- 11:01 PM Changeset in webkit [62523] by
-
- 9 edits1 add in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650
- html5lib/resources/tests2.dat:
- Make the expected wording match the HTML5 spec. Not sure why the wording in this test diverged.
- html5lib/resources/isindex.dat:
- Cover more isindex cases.
- html5lib/runner.html:
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650
Covered by html5lib/runner.html including a new
isindex.dat test suite.
- html/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- Support passing attributes to the constructor.
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::takeAtributes):
- Reduces ref-churn, and makes it possible for callers to modify attributes w/o affecting future uses of the attributes.
(WebCore::AtomicHTMLToken::usesName):
- Used by ASSERTS.
(WebCore::AtomicHTMLToken::usesAttributes):
- Used by ASSERTS.
- html/HTMLTreeBuilder.cpp:
(WebCore::convertToOldStyle):
- Can't be const, now that we use takeAttributes()
(WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML):
(WebCore::HTMLTreeBuilder::proesssFakeStartTag):
- New function. I'm not sure this is the perfect design (I'd kinda like AtomicHTMLToken to be copyable so we can have create functions for it), but this makes the callsites using fake tokens much more readable.
(WebCore::HTMLTreeBuilder::proesssFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakeCharacters):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::insertScriptElement):
- Use takeAttributes() for less ref-churn.
(WebCore::HTMLTreeBuilder::createElement): ditto
(WebCore::HTMLTreeBuilder::finished):
- Remove bogus use of AtomicHTMLToken constructor which wasn't even being used now that we support emitting EOF tokens from the Tokenizer directly.
- html/HTMLTreeBuilder.h:
- 10:38 PM Changeset in webkit [62522] by
-
- 2 edits in trunk/WebCore
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ASSERT that we're processing the correct type of token
https://bugs.webkit.org/show_bug.cgi?id=41647
Making these asserts work required a small (non-observable) tweak to
some old code.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
- 10:31 PM Changeset in webkit [62521] by
-
- 6 edits in trunk
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement in select in table
https://bugs.webkit.org/show_bug.cgi?id=41646
Add some tests for this mode. We fail all these tests currently
because there's no way to get into this mode. :(
- html5lib/resources/tables01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement in select in table
https://bugs.webkit.org/show_bug.cgi?id=41646
This mode is mostly a fall-through to the InSelectMode.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 10:14 PM Changeset in webkit [62520] by
-
- 9 edits in trunk
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement basic text node coalescing
https://bugs.webkit.org/show_bug.cgi?id=41623
- html5lib/resources/webkit01.dat:
- This test had incorrect expected results according to the spec and to Minefield.
- html5lib/runner-expected-html5.txt:
- Update expected results to show test progression. In some cases, we continue to fail tests, but in new (also wrong) ways. I think that's ok though.
- html5lib/runner-expected.txt:
- Update expected results w.r.t. new webkit01.dat baseline.
- html5lib/webkit-resumer-expected.txt:
- Update expected results w.r.t. new webkit01.dat baseline.
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement basic text node coalescing
https://bugs.webkit.org/show_bug.cgi?id=41623
This patch isn't the end-all, be-all of text node coalescing, but it's
a good start.
- dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
- dom/CharacterData.h:
- Added a new method to dance around mutation events.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertTextNode):
- 9:58 PM Changeset in webkit [62519] by
-
- 4 edits in trunk
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement InSelectMode
https://bugs.webkit.org/show_bug.cgi?id=41627
Massive test progression.
- html5lib/runner-expected-html5.txt:
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement InSelectMode
https://bugs.webkit.org/show_bug.cgi?id=41627
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 9:57 PM Changeset in webkit [62518] by
-
- 3 edits in trunk/WebKitTools
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
We should be able to specify a bug to block for webkit-patch upload
https://bugs.webkit.org/show_bug.cgi?id=41648
This will be useful for working on the HTML5 parser.
- Scripts/webkitpy/tool/steps/createbug.py:
- Scripts/webkitpy/tool/steps/options.py:
- 9:21 PM Changeset in webkit [62517] by
-
- 2 edits in trunk/LayoutTests
2010-07-05 Yuzo Fujishima <yuzo@google.com>
Unreviewed test expectation update.
Fix: On Leopard run-webkit-tests complains: Skipped list contained
'compositing/iframes/composited-iframe.html', but no file of that name
could be found
- platform/mac-leopard/Skipped: Removed the above test.
- 8:34 PM Changeset in webkit [62516] by
-
- 5 edits in trunk/LayoutTests
2010-07-05 Adam Barth <abarth@webkit.org>
Unreviewed.
We were discussing this test case, so I figured I might as well add it
to the suite.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
- 8:11 PM Changeset in webkit [62515] by
-
- 2 edits in trunk/WebKit
2010-07-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement downloadURL in ContextMenuClientEfl
When user selects a download menu from context menu, send the download
request to application.
https://bugs.webkit.org/show_bug.cgi?id=41149
- efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::downloadURL): Get url for downloading file and Send it to application.
- efl/WebCoreSupport/ContextMenuClientEfl.h:
- 7:03 PM Changeset in webkit [62514] by
-
- 3 edits2 adds in trunk
2010-07-05 Fady Samuel <fsamuel@chromium.org>
Reviewed by Darin Adler.
Fixed a svg crash when setting class of an svg ellipse object.
Altering the CSS class of an attached SVG element causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=40857
- platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Added.
- svg/css/svg-ellipse-render-crash.html: Added.
2010-07-05 Fady Samuel <fsamuel@chromium.org>
Reviewed by Darin Adler.
Fixed a svg crash when setting class of an svg ellipse object.
Altering the CSS class of an attached SVG element causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=40857
Test: svg/css/svg-ellipse-render-crash.html
- dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged):
- 6:06 PM Changeset in webkit [62513] by
-
- 4 edits2 adds in trunk
Reproducible crash with Optimize Legibility extension
https://bugs.webkit.org/show_bug.cgi?id=41585
Reviewed by Sam Weinig.
WebCore:
Test: fast/css/text-rendering-priority.html
Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.
- css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.
LayoutTests:
- fast/css/text-rendering-priority-expected.txt: Added.
- fast/css/text-rendering-priority.html: Added.
- 5:53 PM Changeset in webkit [62512] by
-
- 1 edit2 adds in trunk/LayoutTests
Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554
Reviewed by Dan Bernstein.
- platform/win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
- platform/win/fast/text/uniscribe-item-boundary-crash.html: Added.
- 5:51 PM Applications using WebKit edited by
- (diff)
- 5:22 PM Changeset in webkit [62511] by
-
- 7 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=41641
Reviewed by Sam Weinig.
Update compile flags to allow use of ExecutableAllocatorFixedVMPool on platforms
other than x86-64 (this may be useful on 32-bit platforms, too).
Simplify ifdefs by dividing into thwo broad allocation strategies
(ENABLE_EXECUTABLE_ALLOCATOR_FIXED & ENABLE_EXECUTABLE_ALLOCATOR_DEMAND).
Rename constant used in the code to have names descriptive of their purpose,
rather than their specific value on a given platform.
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::free):
(JSC::ExecutablePool::systemAlloc):
- jit/ExecutableAllocatorPosix.cpp:
- jit/ExecutableAllocatorSymbian.cpp:
- jit/ExecutableAllocatorWin.cpp:
- wtf/Platform.h:
- 5:11 PM Changeset in webkit [62510] by
-
- 2 edits in trunk/WebCore
optimizeLegibility doesn't play nice with fonts that do not have a space glyph
https://bugs.webkit.org/show_bug.cgi?id=41599
Reviewed by Sam Weinig.
No test because none of the fonts available to DumpRenderTree are missing a space glyph.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.
- 2:39 PM Changeset in webkit [62509] by
-
- 5 edits in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTML5's "reset insertion mode appropriately"
https://bugs.webkit.org/show_bug.cgi?id=41628
This has some minimal testing. One from my previous
</table> patch, and a few from the main suite.
Mostly resetInsertionModeAppropriately isn't used yet
but we're about to add a bunch of states which do use it
and our test coverage will expand further as we do.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
- html/HTMLTreeBuilder.h:
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Implement HTML5's "reset insertion mode appropriately"
https://bugs.webkit.org/show_bug.cgi?id=41628
Fixes a bunch of subtests!
- html5lib/runner-expected-html5.txt:
- 2:34 PM Changeset in webkit [62508] by
-
- 2 edits in trunk/WebCore
2010-07-05 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed build fix for r62503.
Chromium missing method. Filed bug 41632 to track.
- loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCache):
- 2:25 PM Changeset in webkit [62507] by
-
- 7 edits in trunk
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add </table> support for "in table" insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41591
resetInsertionModeAppropriately isn't implemented yet, however
I've added a test for the usage I added.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
- html/HTMLTreeBuilder.h:
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add </table> support for "in table" insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41591
Add tests for </table> in "in table" mode, and
one for ignored close tags.
- html5lib/resources/tables01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 2:08 PM Changeset in webkit [62506] by
-
- 2 edits in trunk/WebCore
2010-07-05 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed build fix for r62503.
Missed GTK's build file.
- GNUmakefile.am:
- 2:00 PM Changeset in webkit [62505] by
-
- 2 edits in trunk/WebCore
2010-07-05 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed build fix for r62503.
Pass a blank ResourceResponse instead of passing 0.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
- 1:47 PM Changeset in webkit [62504] by
-
- 2 edits in trunk/WebCore
2010-07-05 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed build fix for r62503.
Forward declare ApplicationCache for Chromium.
- loader/appcache/ApplicationCacheHost.h:
- 1:32 PM Changeset in webkit [62503] by
-
- 16 edits in trunk/WebCore
2010-07-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
https://bugs.webkit.org/show_bug.cgi?id=24529
Parts of this patch were written by Kavita Kanetkar <kkanetkar@chromium.org>.
Part 2: Pulling ApplicationCache Resources to Display in the Inspector.
The InspectorApplicationCacheAgent gathers the information it
needs and forwards it on to the inspector.
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): get information about the resources. (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): gathers all the information from the ApplicationCacheHost. (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
- inspector/InspectorApplicationCacheAgent.h: defines structures to hold information about caches and resources. (WebCore::InspectorApplicationCacheAgent::ApplicationCacheInfo::ApplicationCacheInfo): (WebCore::InspectorApplicationCacheAgent::ResourceInfo::ResourceInfo): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
- loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCacheForInspector): new convention, public cache accessor for the inspector. (WebCore::ApplicationCacheHost::documentLoader): added const.
The User Interface uses a DataGrid, like Cookies.
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.numberCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.localeCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
The usual frontend pull workflow, except this goes through
InspectorApplicationCacheAgent instead of InspectorController.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getApplicationCaches): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetApplicationCaches):
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.hasChildNodes): style fix. (WebInspector.DOMAgent.prototype.nodeForId): style fix. (WebInspector.ApplicationCache.getApplicationCachesAsync): pull. (WebInspector.Cookies.getCookiesAsync):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.updateManifest): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
- inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addAppCacheDomain): (WebInspector.reset):
Miscellaneous. Localized Strings and fixes.
- English.lproj/localizedStrings.js: "Type", "%s (%s)"
- inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
- inspector/InspectorController.h:
- 1:32 PM Changeset in webkit [62502] by
-
- 19 edits4 adds in trunk/WebCore
2010-07-04 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
https://bugs.webkit.org/show_bug.cgi?id=24529
Part 1: Backend -> Frontend Messages. ApplicationCache Status and Connectivity Status.
This patch adds an InspectorApplicationCacheAgent to monitor application
cache changes, starts a UI in the Storage panel, handles the boilerplate
of adding new files.
Added an agent to encapsulate and handle the application cache logic.
This is similar to the timeline agent.
- inspector/InspectorApplicationCacheAgent.cpp: Added. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse): (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus): (WebCore::InspectorApplicationCacheAgent::updateNetworkState):
- inspector/InspectorApplicationCacheAgent.h: Added.
InspectorController owns an InspectorApplicationCacheAgent. This
handles its lifetime management.
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): create the agent with a frontend. (WebCore::InspectorController::disconnectFrontend): remove the agent when closing. (WebCore::InspectorController::releaseFrontendLifetimeAgents):
- inspector/InspectorController.h:
User Interface for ApplicationCache in the StoragePanel. This follows
very closely to Cookies, it will have a sortable table of items. The
status bar contains connectivity and application cache status
indicators which update when backend messages are received. There
are some stubs which the next part will implement.
- inspector/front-end/ApplicationCacheItemsView.js: Added. (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): refresh, delete, connectivity, application cache status. (WebInspector.ApplicationCacheItemsView.prototype.show): (WebInspector.ApplicationCacheItemsView.prototype.hide): (WebInspector.ApplicationCacheItemsView.prototype.updateStatus): this is the application cache status indicator. (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState): this is the online/offline connectivity indicator. (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid): (WebInspector.ApplicationCacheItemsView.prototype.resize): (WebInspector.ApplicationCacheItemsView.prototype._deleteButtonClicked): (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback): (WebInspector.ApplicationCacheItemsView.prototype._refreshButtonClicked):
The usual dispatch flow from the backend, to the frontend, to the
panel, and then to the visible view. Some slight refactoring to
eliminate duplicated code.
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::didGetApplicationCaches): (WebCore::InspectorFrontend::updateApplicationCacheStatus):
- inspector/InspectorFrontend.h:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.StoragePanel.prototype.showDOMStorage): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.StoragePanel.prototype.showApplicationCache): (WebInspector.StoragePanel.prototype._genericViewSetup): (WebInspector.StoragePanel.prototype.updateApplicationCacheStatus): (WebInspector.StoragePanel.prototype.updateNetworkState): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle): (WebInspector.ApplicationCacheSidebarTreeElement): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get subtitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set subtitle):
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch): (WebInspector._addAppCacheDomain): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):
Notify the InspectorApplicationCacheAgent on application cache changes
or specifics. Notify the InspectorController on generic resource events.
That is because ApplicationCacheController is a ResourceClient and needs
to trigger the resource events normally handled by ResourceLoader.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::inspectorUpdateApplicationCacheStatus): helper method to prevent duplicated code. (WebCore::ApplicationCacheGroup::setNewestCache): status change. (WebCore::ApplicationCacheGroup::makeObsolete): status change. (WebCore::ApplicationCacheGroup::update): status change. (WebCore::ApplicationCacheGroup::createResourceHandle): resource event. (WebCore::ApplicationCacheGroup::willSendRequest): resource event. (WebCore::ApplicationCacheGroup::didReceiveResponse): resource event. (WebCore::ApplicationCacheGroup::didReceiveData): resource event. (WebCore::ApplicationCacheGroup::didFinishLoading): resource event. (WebCore::ApplicationCacheGroup::didFail): resource event. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): resource event. (WebCore::ApplicationCacheGroup::manifestNotFound): status change. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): status change. (WebCore::ApplicationCacheGroup::setUpdateStatus): single access point for status changes.
- loader/appcache/ApplicationCacheGroup.h:
- page/Page.cpp: (WebCore::networkStateChanged): connectivity status change.
Final inspector details to add the new file, style new elements,
images, and localized strings.
- inspector/front-end/inspector.css: (.application-cache-sidebar-tree-item .icon): (.timeline-records-counter, .storage-application-cache-status, .storage-application-cache-connectivity): (.storage-application-cache-status-icon, .storage-application-cache-connectivity-icon): (.status-bar-divider): (.storage-application-cache-status, .storage-application-cache-connectivity):
- inspector/front-end/inspector.html:
- inspector/front-end/Images/applicationCache.png: Added.
- English.lproj/localizedStrings.js: "APPLICATION CACHE", "No Application Cache information available.", "Online", "Offline"
Updated build files.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/WebKit.qrc:
- 1:17 PM Changeset in webkit [62501] by
-
- 4 edits in trunk/WebKit2
2010-07-05 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebKit2 triple click
https://bugs.webkit.org/show_bug.cgi?id=41629
QtWebkit2 triple click implementation.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseDoubleClickEvent): (QWKPage::timerEvent):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
- 1:03 PM Changeset in webkit [62500] by
-
- 6 edits in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic <col> support to the treebuilder
https://bugs.webkit.org/show_bug.cgi?id=41590
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic <col> support to the treebuilder
https://bugs.webkit.org/show_bug.cgi?id=41590
Test the new <col> support. Turns out the old treebuilder doesn't
handle <table><col> correctly.
- html5lib/resources/tables01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 1:02 PM Changeset in webkit [62499] by
-
- 8 edits1 add in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic "in row" mode to support <td> and <th> insertion
https://bugs.webkit.org/show_bug.cgi?id=41588
Also fixed <td> or <th> as a direct child of <table>.
Most of this was covered by html5lib/runner.html tests,
but I had to add a new tables01.dat to cover the <th> cases.
- html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic "in row" mode to support <td> insertion
https://bugs.webkit.org/show_bug.cgi?id=41588
Added tables01.dat to test a previously untested
<table><th> case. I expect we'll add many more table
tests there as we complete our implementation.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- html5lib/resources/tables01.dat: Added.
- 12:42 PM Changeset in webkit [62498] by
-
- 7 edits1 add in trunk
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Finish implementing "any other end tag" for "in body" mode
https://bugs.webkit.org/show_bug.cgi?id=41582
- html5lib/resources/inbody01.dat: Added.
- html5lib/runner-expected-html5.txt:
- Update the one result which was affected by this. That test would pass if we had text node coalescing.
- html5lib/runner-expected.txt:
- Update to add the extra test suite.
- html5lib/runner.html:
2010-07-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Finish implementing "any other end tag" for "in body" mode
https://bugs.webkit.org/show_bug.cgi?id=41582
I believe I found a "bug" in the HTML5 spec when writing this:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
- html/HTMLTreeBuilder.h:
- 11:32 AM Changeset in webkit [62497] by
-
- 2 edits in trunk/WebCore
2010-07-05 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Add a missing slash to the list of generated sources. This
was missing from a previous build fix.
- GNUmakefile.am:
- 11:04 AM Changeset in webkit [62496] by
-
- 4 edits in trunk/WebCore
2010-07-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: preserve scroll positions in source frame when switching between panes.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
- 10:57 AM Changeset in webkit [62495] by
-
- 1 edit17 adds in trunk/LayoutTests
2010-07-05 Yury Semikhatsky <yury@yurys-imac.local>
Unreviewed. Provide Chromium specific expectations for new svg tests.
- platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
- platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
- platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
- platform/chromium-linux/svg/filters/filter-width-update-expected.checksum: Added.
- platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Added.
- platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
- platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
- platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
- platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
- platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.png: Added.
- platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
- platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/chromium-win/svg/filters/filter-width-update-expected.checksum: Added.
- platform/chromium-win/svg/filters/filter-width-update-expected.png: Added.
- platform/chromium-win/svg/filters/filter-width-update-expected.txt: Added.
- 10:50 AM Changeset in webkit [62494] by
-
- 2 edits2 copies2 adds in trunk/WebKit2
2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233
Add stubs
- UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: Copied from WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Added. (WebKit::InjectedBundle::load):
- 10:10 AM Changeset in webkit [62493] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-05 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
ThreadingPthreads.cpp should use JNIUtility.h on Android, not outdated jni_utility.h
https://bugs.webkit.org/show_bug.cgi?id=41594
- wtf/ThreadingPthreads.cpp:
- 10:01 AM Changeset in webkit [62492] by
-
- 7 edits3 adds in trunk
2010-07-05 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dirk Schulze.
IE SVG test fails
https://bugs.webkit.org/show_bug.cgi?id=41619
Make SVGSVGElement.createSVGTransform create a SVGTransform with the
right type, thereby fixing the IE test.
Test: svg/custom/svg-createsvgtransform-type.html
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform):
- 9:54 AM Changeset in webkit [62491] by
-
- 1 edit2 adds in trunk/WebKit2
2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233
Add WebErrorsQt
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Added. (WebKit::): (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError):
- 8:29 AM Changeset in webkit [62490] by
-
- 3 edits in trunk/WebKitTools
2010-07-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
https://bugs.webkit.org/show_bug.cgi?id=41017
- Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
- Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
- 8:12 AM Changeset in webkit [62489] by
-
- 2 edits in trunk/WebCore
2010-07-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: computed style pane is not updated when styles pane is collapsed.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
- 7:32 AM Changeset in webkit [62488] by
-
- 44 edits12 adds in trunk
2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Logic to track whether elements are using relative lengths is incomplete
https://bugs.webkit.org/show_bug.cgi?id=41566
Add logic to all SVG elements which create renderes to expose a method
"bool selfHasRelativeLengths()", that returns whether the element uses relative
lengths (eg. <rect x="50%"...). This will be used soon to avoid relayouts of
container children, when the bounds have not changed.
A new method SVGStyledElement::updateRelativeLengthsInformation() is added,
which is called from the various svgAttributeChanged() methods and insertedIntoDocument/removedFromDocument.
It will be implemented in a follow-up patch. This patch does not affect any test behaviour related
to relayouting. As SVGFilterElement finally got a proper svgAttributeChanged() method, it now
properly invalidates clients on attribute changes - covered by a new test.
Tests: svg/custom/relative-sized-inner-svg.xhtml
svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml
svg/filters/filter-width-update.svg
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Rename hasRelativeValues to hasRelativeLengths.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Ditto. (WebCore::RenderSVGRoot::calcViewport): Ditto.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Ditto
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): Ditto.
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Call updateRelativeLengthsInformation() if any attribute which may contain relative lengths changes. (WebCore::SVGCircleElement::selfHasRelativeLengths): Ditto. Same for all other SVG*Elements below.
- svg/SVGCircleElement.h:
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::selfHasRelativeLengths):
- svg/SVGEllipseElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::selfHasRelativeLengths):
- svg/SVGFilterElement.h:
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::selfHasRelativeLengths):
- svg/SVGForeignObjectElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::selfHasRelativeLengths):
- svg/SVGImageElement.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::selfHasRelativeLengths):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::selfHasRelativeLengths):
- svg/SVGLinearGradientElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::selfHasRelativeLengths):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::selfHasRelativeLengths):
- svg/SVGMaskElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::selfHasRelativeLengths):
- svg/SVGPatternElement.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::selfHasRelativeLengths):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::selfHasRelativeLengths):
- svg/SVGSVGElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::insertedIntoDocument): Call updateRelativeLengthsInformation(). (WebCore::SVGStyledElement::removedFromDocument): Ditto. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Not implemented so far. Will land in a follow-up patch, together with the render tree changes.
- svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): Devirtualized. For now, just call selfHasRelativeLengths() - this will change in a follow-up patch. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): (WebCore::SVGStyledElement::selfHasRelativeLengths): Renamed from hasRelativeValues().
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::selfHasRelativeLengths):
- svg/SVGSymbolElement.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selfHasRelativeLengths):
- svg/SVGTextContentElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::insertedIntoDocument): Call right base class' method. Skipped one in the hierachy before. (WebCore::SVGTextPathElement::selfHasRelativeLengths):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::listContainsRelativeValue): New helper funtion that checks wheter a SVGLengthList contains relative lengths. (WebCore::SVGTextPositioningElement::selfHasRelativeLengths):
- svg/SVGTextPositioningElement.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): Call right base class' method. Skipped on in the hierachy before. (WebCore::SVGUseElement::removedFromDocument): Ditto. (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateRelativeLengthsInformation() after building the shadow tree. (WebCore::SVGUseElement::selfHasRelativeLengths): Same as all other methods, except that it includes the shadow tree root element.
- svg/SVGUseElement.h:
2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Logic to track whether elements are using relative lengths is incomplete
https://bugs.webkit.org/show_bug.cgi?id=41566
Add two new relative-sized-*.svg tests that would break, when relative sized kids aren't layout correctly.
Add new test covering that filters update their clients, if any attribute changes.
- platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
- platform/mac/svg/custom/relative-sized-inner-svg-expected.png: Added.
- platform/mac/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/mac/svg/filters/filter-width-update-expected.checksum: Added.
- platform/mac/svg/filters/filter-width-update-expected.png: Added.
- platform/mac/svg/filters/filter-width-update-expected.txt: Added.
- svg/custom/relative-sized-inner-svg.xhtml: Added.
- svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml: Added.
- svg/filters/filter-width-update.svg: Added.
- 7:23 AM Changeset in webkit [62487] by
-
- 2 edits in trunk/WebCore
2010-07-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Problem with copying a code from Scripts panel.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._selectionToPosition):
- 7:07 AM Changeset in webkit [62486] by
-
- 1 edit5 adds in trunk/WebKit2
2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233
Add Qt C API integration.
- UIProcess/API/cpp/qt/WKStringQt.cpp: Added. (WKStringCreateWithQString): (WKStringCopyQString):
- UIProcess/API/cpp/qt/WKStringQt.h: Added.
- UIProcess/API/cpp/qt/WKURLQt.cpp: Added. (WKURLCreateWithQUrl): (WKURLCopyQUrl):
- UIProcess/API/cpp/qt/WKURLQt.h: Added.
- 6:41 AM Changeset in webkit [62485] by
-
- 1 edit2 adds in trunk/WebKit2
2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233
Add the Qt process launcher.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Added. (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::terminateProcess): (WebKit::webThreadBody): (WebKit::ProcessLauncher::createWebThread): (webProcessMain):
- 5:48 AM Changeset in webkit [62484] by
-
- 3 edits4 adds in trunk
2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze / Darin Adler.
Node.cloneNode does not work on SVG nodes
https://bugs.webkit.org/show_bug.cgi?id=41421
Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.
Test: svg/custom/clone-element-with-animated-svg-properties.html
- dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
- 5:31 AM Changeset in webkit [62483] by
-
- 5 edits in trunk
Revert unplanned project file change.
.:
- WebKit.pro:
WebCore:
- WebCore.pri:
- WebCore.pro:
- 5:27 AM Changeset in webkit [62482] by
-
- 3 edits4 adds in trunk
2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
Memory corruption with SVG <use> element
https://bugs.webkit.org/show_bug.cgi?id=40994
Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
datastructure with the points attribute, no matter if there are changes are not. This should be
furhter optimized, but this fix is sane and fixes the root of the evil races.
Test: svg/custom/use-property-synchronization-crash.svg
- svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged):
- 5:26 AM Changeset in webkit [62481] by
-
- 5 edits4 adds in trunk
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233
Reviewed by Kenneth Rohde Christiansen.
Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/qt: Added.
- UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/WebPage/qt: Added.
- WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
- 3:50 AM Changeset in webkit [62480] by
-
- 3 edits in trunk/WebKitTools
2010-07-04 MORITA Hajime <morrita@google.com>
rebaseline-chromium-webkit-tests: UnicodeDecodeError
https://bugs.webkit.org/show_bug.cgi?id=41589
- run() method can result non-utf-8 bytes, that causes utf-8 decoding fail. Fixed to disable decoding.
- Fixed Git.find_checkout_root() to make a test pass.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 3:05 AM Changeset in webkit [62479] by
-
- 4 edits in trunk
2010-07-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
https://bugs.webkit.org/show_bug.cgi?id=41595
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
2010-07-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
https://bugs.webkit.org/show_bug.cgi?id=41595
- src/js/DebuggerScript.js:
- 3:03 AM Changeset in webkit [62478] by
-
- 7 edits3 adds in trunk
2010-07-04 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dirk Schulze.
SVG polygons should draw polygons up to the first parsing error
https://bugs.webkit.org/show_bug.cgi?id=41140
Render polygons up until the first parsing error.
Test: svg/custom/poly-parsing-error.html
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::parseMappedAttribute):
- 2:49 AM QtWebKitTriageRoster edited by
- (diff)
- 12:32 AM Changeset in webkit [62477] by
-
- 2 edits in trunk/WebCore
Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554
Reviewed by Dan Bernstein.
Test: platform/win/fast/text/uniscribe-item-boundary-crash.html
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.
- 12:18 AM Changeset in webkit [62476] by
-
- 4 edits in trunk/WebKit/mac
2010-06-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] on Mac OS use a runloop observer to process the glib context iterations
https://bugs.webkit.org/show_bug.cgi?id=35747
If VIDEO and GSTREAMER are enabled, make the WebView start a
runloop observer that will trigger the glib main context
iterations. Those are needed by the GStreamer player only at the
moment but could later be used for other GLib-dependant components
if required.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _close]): (-[WebView _clearGlibLoopObserver]): (glibContextIterationCallback): (-[WebView _scheduleGlibContextIterations]):
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
Jul 4, 2010:
- 11:56 PM Changeset in webkit [62475] by
-
- 2 edits in trunk/LayoutTests
2010-07-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark fast/js/function-apply-many-args.html as
having wrong output in debug mode.
- platform/chromium/test_expectations.txt:
- 9:45 PM Changeset in webkit [62474] by
-
- 6 edits in trunk
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587
- html5lib/runner-expected-html5.txt:
- <tr> tags now show up, imagine that.
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587
This also adds a (currently untestable?)
popUntilTableBodyScopeMarker code path.
Any tags which would be between a tbody a <tr> would end up
foster parented outside the <table>. I think the spec was
just being over-cautious with popUntilTableBodyScopeMarker.
- html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 7:37 PM Changeset in webkit [62473] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. Update Chromium test expectations.
- platform/chromium-mac/html5lib/runner-expected.txt:
- platform/chromium-win/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:27 PM Changeset in webkit [62472] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 4:15 PM Changeset in webkit [62471] by
-
- 5 edits2 adds in trunk/WebKit2
Add simple command line parser and pass mode argument to the web process
https://bugs.webkit.org/show_bug.cgi?id=41586
Reviewed by Dan Bernstein.
- Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
Add CommandLine class.
- Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.
- WebKit2.xcodeproj/project.pbxproj:
Add CommandLine to the xcode project.
- WebProcess/Launching/mac/WebProcessMain.mm:
(webProcessMain):
(main):
Parse the command line and check the mode.
- 3:06 PM Changeset in webkit [62470] by
-
- 2 edits in trunk/WebCore
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453
Fix Qt Minimal build. SVGNames.h should always
be generated, even when SVG is off, however that's
not how things currently work.
- html/HTMLTreeBuilder.cpp:
- 2:54 PM Changeset in webkit [62469] by
-
- 9 edits in trunk
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581
- html5lib/runner-expected-html5.txt:
- Update expectations now that we pass 6 more tests.
2010-07-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581
There is still a bunch of low-hanging fruit left for this
mode, but even this most-basic support lets us pass 6 more tests. :)
It's a progression, ship it! :)
- html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableScopeMarker):
- html/HTMLElementStack.h:
- html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::appendMarker):
- html/HTMLFormattingElementList.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- html/HTMLTreeBuilder.h:
- 2:15 PM Changeset in webkit [62468] by
-
- 13 edits1 add in trunk
2010-07-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453
Added new adoption01 suite for testing adoption agency
bugs. Right now only the simplest adoption test passes.
I'll be adding more in future commits.
- html5lib/resources/adoption01.dat: Added.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
2010-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453
This changes some test results, but only makes the simplest
adoption agency cases pass. I think the code is likely
very close, but further iteration to make this change larger
seems counter-productive. I recommend we check in this
progression and work from here.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::addChildCommon):
- Make sure callers don't assume this will reparent.
(WebCore::ContainerNode::parserAddChild):
- Update comment to document lack of reparenting behavior.
- html/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::~ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::ElementRecord::isAbove):
- Added for debugging.
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::insertAbove):
- Needed for the adoption agency.
(WebCore::HTMLElementStack::topRecord):
(WebCore::HTMLElementStack::bottom):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::headElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):
- Fix the name to match top/bottom.
- html/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext):
- html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::closestElementInScopeWithName): (WebCore::HTMLFormattingElementList::contains): (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::remove):
- html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::isEmpty): (WebCore::HTMLFormattingElementList::size):
- html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
- Part of the Adoption Agency algorithm.
(WebCore::HTMLTreeBuilder::findFosterParentFor):
- Used to move mis-nested content out of tables. This doesn't seem to work quite right yet.
(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- The ridiculously long/complicated adoption agency algorithm from HTML5.
(WebCore::HTMLTreeBuilder::processEndTag):
- html/HTMLTreeBuilder.h:
- 10:44 AM Changeset in webkit [62467] by
-
- 2 edits in trunk/WebCore
2010-07-04 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578
Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSHTMLFrameElementCustom.cpp:
- bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- 9:22 AM Changeset in webkit [62466] by
-
- 14 edits2 deletes in trunk/WebCore
2010-07-04 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578
Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSHTMLFrameElementCustom.cpp:
- bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- 9:06 AM UpdatingBugzilla edited by
- (diff)
- 9:04 AM UpdatingBugzilla edited by
- (diff)
- 6:38 AM Changeset in webkit [62465] by
-
- 2 edits in trunk/LayoutTests
2010-07-04 Robert Hogan <robert@webkit.org>
[Qt] Triage failing HTTP tests in Qt Skipped list
Unreviewed, sorting tests and adding comments to skipped list.
- platform/qt/Skipped:
- 4:48 AM Changeset in webkit [62464] by
-
- 2 edits in trunk/JavaScriptCore
Build fix after r62456.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.
- 3:38 AM Changeset in webkit [62463] by
-
- 2 edits in trunk/LayoutTests
[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
Unreviewed, accidental omission from r61505
https://bugs.webkit.org/show_bug.cgi?id=36702
Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of http://trac.webkit.org/changeset/61505
- 3:16 AM Changeset in webkit [62462] by
-
- 3 edits4 adds in trunk/LayoutTests
2010-07-04 Yury Semikhatsky <yury@yurys-imac.local>
Unreviewed. Update Chromium test expectations.
- platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
- platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
- platform/chromium-mac/html5lib/runner-expected.txt:
- platform/chromium-win/fast/js/function-apply-expected.txt: Added.
- platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
- platform/chromium-win/html5lib/runner-expected.txt:
- 2:41 AM Changeset in webkit [62461] by
-
- 2 edits in trunk/WebKit2
2010-07-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
WebProcess crashes in release for simple layout tests
https://bugs.webkit.org/show_bug.cgi?id=41575
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl* before taking it out of its parent String, to avoid returning freed memory.
Jul 3, 2010:
- 10:09 PM Changeset in webkit [62460] by
-
- 7 edits in trunk
2010-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561
Test coverage of this mode was a bit ... lacking, shall we say? This
patch adds a test for it.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
2010-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561
This mode is almost unobservable. The main way to observe it seems to
be seeing where comment nodes get attached to the DOM.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 9:53 PM Changeset in webkit [62459] by
-
- 2 edits in trunk/WebKit2
Add stdint.h include to fix WebKitTestRunner build.
Rubber stamped by Anders Carlsson.
- UIProcess/API/C/WKPage.h:
- 6:33 PM Changeset in webkit [62458] by
-
- 5 edits in trunk
2010-07-03 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572
- platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.
2010-07-03 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572
- html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code. (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
- html/canvas/WebGLRenderingContext.h: Helper function declaration.
- 5:11 PM Changeset in webkit [62457] by
-
- 4 edits in trunk/JavaScriptCore
Patch for https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.
Reviewed by Darin Adler.
- MSVC does not ensure the buffers are null terminated as the unix versions do.
- runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
- runtime/UString.cpp: Clean up includes.
(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.
- wtf/StringExtras.h:
(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.
- 4:49 PM Changeset in webkit [62456] by
-
- 5 edits in trunk
2010-07-03 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
the interpreter as well as the JIT.
https://bugs.webkit.org/show_bug.cgi?id=41351
rdar://problem/8142141
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Fix signed integer overflow problem in op_load_varargs handling. 0xFFFFFFFF was read as -1.
2010-07-03 Darin Adler <Darin Adler>
Added test cases for edge cases in apply function on arrays.
https://bugs.webkit.org/show_bug.cgi?id=41351
- fast/js/function-apply-expected.txt: Updated to expect success.
- fast/js/script-tests/function-apply.js: Added test cases.
- 4:02 PM Changeset in webkit [62455] by
-
- 2 edits in trunk/WebCore
Ugh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.
- storage/IDBKey.h:
(WebCore::IDBKey::~IDBKey):
- 4:00 PM Changeset in webkit [62454] by
-
- 3 edits in trunk/WebKitTools
2010-07-03 Patrick Gansterer <paroga@paroga.com>
Reviewed by Simon Hausmann.
[Qt] Fix DumpRenderTree userStyleSheet handling.
https://bugs.webkit.org/show_bug.cgi?id=41570
DumpRenderTree did only set the userStyleSheet at
layoutTestController.setUserStyleSheetEnabled().
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:48 PM UpdatingBugzilla edited by
- (diff)
- 3:48 PM Changeset in webkit [62453] by
-
- 2 edits in trunk/WebCore
Build fix. Forgot destructor.
- storage/IDBKey.cpp:
(WebCore::IDBKey::~IDBKey):
- 3:46 PM UpdatingBugzilla edited by
- (diff)
- 3:45 PM UpdatingBugzilla edited by
- Updated Update section for bzr (diff)
- 3:37 PM UpdatingBugzilla edited by
- Switched from CVS to bzr for upstream Bugzilla repository. (diff)
- 3:18 PM Changeset in webkit [62452] by
-
- 20 edits6 copies5 adds in trunk
2010-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252
Set the role to Private.
- JavaScriptCore.xcodeproj/project.pbxproj:
2010-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252
It'll take some time to get data persistence working for IndexedDB,
so until then, we'll just store everything in an in memory tree.
The tree uses WTF::AVLTree and is a template so that it can be used by
object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
IDBKey). This class will be used in a subsequent patch.
Also add an IDBKey type that represents one of these keys. We use a
custom toJS function in a way similar to IDBAny to convert from WebCore
to a JS value. For converting the other way, we have to teach the code
generators what to do (unfortunately). This is done in a way similar
to serialized script value. Unlike serialized script value, IDBKey is
in WebCore and only a helper function is JS engine specific.
This code is not accessable from layout tests. (Will fix in
https://bugs.webkit.org/show_bug.cgi?id=41250) The bindings tests
show us that the generated bindings are what we expect.
- ForwardingHeaders/wtf/AVLTree.h: Added.
- bindings/js/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
- bindings/js/IDBBindingUtilities.h: Added.
- bindings/js/JSIDBKeyCustom.cpp: Added. (WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::idbKey):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_idb_key):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionIdbKey):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj idbKey:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::idbKeyCallback): (WebCore::):
- bindings/v8/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
- bindings/v8/IDBBindingUtilities.h: Added.
- bindings/v8/custom/V8IDBKeyCustom.cpp: Added. (WebCore::toV8):
- storage/IDBCallbacks.h:
- storage/IDBKey.cpp: Added. (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::~IDBKey):
- storage/IDBKey.h: Added. (WebCore::IDBKey::create): (WebCore::IDBKey::): (WebCore::IDBKey::type): (WebCore::IDBKey::string): (WebCore::IDBKey::number):
- storage/IDBKey.idl: Added.
- storage/IDBKeyTree.h: Added. (WebCore::IDBKeyTree::create): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::null): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node): (WebCore::::IDBKeyTree): (WebCore::::~IDBKeyTree): (WebCore::::AVLTreeAbstractor::compare_key_key): (WebCore::::get): (WebCore::::insert): (WebCore::::remove):
- 2:57 PM Changeset in webkit [62451] by
-
- 14 edits in trunk
The missing plug-in indicator should be clickable
https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>
From an original patch by Kevin Decker.
Reviewed by Darin Adler.
WebCore:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.
- page/ChromeClient.h:
(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.
- rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.
WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.
- WebView/WebUIDelegatePrivate.h:
Declare didPressMissingPluginButton.
WebKit/win:
- Interfaces/IWebUIDelegatePrivate.idl:
Added a new delegate interface, and declare a function
didPressMissingPluginButton().
- Interfaces/WebKit.idl:
Touch this file to force interfaces to be rebuilt.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.
- WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().
- 2:36 PM Changeset in webkit [62450] by
-
- 4 edits in trunk
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Unskip fast/history/self-is-visited.html
- platform/qt/Skipped:
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Object property names such as 'background-color' need to be returned in camel
case, i.e. backgroundColor so that JS can reference them. Add support for this
to DumpRenderTreeSupportQt.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
- 1:30 PM Changeset in webkit [62449] by
-
- 9 edits in trunk
Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539
Reviewed by Geoffrey Garen.
Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.
- parser/Lexer.cpp:
(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::copyStringWithoutBOMs):
WebCore:
Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.
- bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
- bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::StringSourceProvider):
- loader/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):
- loader/CachedScript.h:
(WebCore::CachedScript::):
CachedScript now stores decoded data with the BOMs stripped,
and caches the presence of BOMs across memory purges.
- 12:20 PM Changeset in webkit [62448] by
-
- 2 edits in trunk/WebCore
2010-07-03 Xan Lopez <xlopez@igalia.com>
Include DerivedSources/WebCore before DerivedSources/
Recently DerivedSources generation was changed, with some files no
longer being generated in the toplevel DerivedSources
directory. Since that directory is first in the -I flags the build
can be broken in some cases by including old files unless a 'make
clean' is done. Change the -I order to fix the build in the 32 bit
Release bot.
- GNUmakefile.am:
- 7:08 AM Changeset in webkit [62447] by
-
- 7 edits1 add in trunk
2010-07-03 Erik Arvidsson <arv@chromium.org>
Reviewed by Ojan Vafai.
Fix issue where a contextmenu event was reporting the wrong target if
the context menu was shown due to pressing the context menu key
(or Shift+F10).
Split sendContextMenuForEvent into one case for keyboard events and use
that when the contextmenu event should be dispatched due to a keypress.
For the keboard case we now use the focused node as the target for the
event and use the clipped rect to determine the position of the menu.
Use manual test since DRT does not handle context menu keys.
- manual-tests/win/contextmenu-key.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::sendContextMenuEventForKey):
- page/EventHandler.h:
2010-07-03 Erik Arvidsson <arv@chromium.org>
Reviewed by Ojan Vafai.
Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
2010-07-03 Erik Arvidsson <arv@chromium.org>
Reviewed by Ojan Vafai.
Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).
- WebView.cpp: (WebView::handleContextMenuEvent):
- 5:03 AM Changeset in webkit [62446] by
-
- 2 edits in trunk/WebCore
2010-07-03 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 3:42 AM Changeset in webkit [62445] by
-
- 10 edits in trunk/LayoutTests
2010-07-03 Robert Hogan <robert@webkit.org>
[Qt] Update Qt expected results after r62444
Unreviewed, update test results.
http://trac.webkit.org/changeset/62444
https://bugs.webkit.org/show_bug.cgi?id=41088
Qt expected results for various fast/ tests updated to reflect
support for dumpChildFrameScrollPositions(). Checked against Mac results
and they are all good.
I have not updated the .png and .checksum files for the tests. This is
because I suspect I will not get the same pixel results as the Qt build
bot.
- platform/qt/fast/dynamic/anchor-lock-expected.txt:
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
- platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
- platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
- platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
- platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
- platform/qt/fast/repaint/fixed-tranformed-expected.txt:
- platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
- platform/qt/transforms/2d/transform-fixed-container-expected.txt:
- 3:00 AM Changeset in webkit [62444] by
-
- 7 edits in trunk
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpChildFrameScrollPositions
Unskip:
http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html
- platform/qt/Skipped:
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpChildFrameScrollPositions
Unskip:
http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFrameScrollPosition): (WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFrameScrollPositions):
- 1:45 AM Changeset in webkit [62443] by
-
- 2 edits1 add in trunk/WebCore
2010-07-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Port Widget
https://bugs.webkit.org/show_bug.cgi?id=41538
Make Widget a dummy class. WebKit Brew MP uses the full screen mode
and does not use the window system introduced in Brew MP.
- platform/Widget.h:
- platform/brew/WidgetBrew.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
- 1:30 AM Changeset in webkit [62442] by
-
- 3 edits in trunk/JavaScriptCore
2010-07-03 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kent Tamura.
[WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
https://bugs.webkit.org/show_bug.cgi?id=41411
- wtf/unicode/wince/UnicodeWince.cpp: (WTF::Unicode::isAlphanumeric):
- wtf/unicode/wince/UnicodeWince.h: (WTF::Unicode::isArabicChar):
- 1:17 AM Changeset in webkit [62441] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
https://bugs.webkit.org/show_bug.cgi?id=41524
Print "WebKit CRASH" before crashing.
- wtf/Assertions.h:
- 12:17 AM Changeset in webkit [62440] by
-
- 4 edits in trunk
2010-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560
It's somewhat hard to observe this state, so I'm not surprised that the
diff to the expected results are small. We still fail this test
because we don't handle whitespace correctly.
- html5lib/runner-expected-html5.txt:
2010-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 12:03 AM Changeset in webkit [62439] by
-
- 4 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559
And the tests keep progressing.
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559
Pretty straighforward. We still don't handle character tokens
correctly.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
Jul 2, 2010:
- 11:47 PM Changeset in webkit [62438] by
-
- 6 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558
Yay test progression.
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558
Handling the <frameset> tag in the InBody mode is somewhat delicate.
- html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popHTMLBodyElement): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popCommon):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 11:45 PM Changeset in webkit [62437] by
-
- 2 edits in trunk/JavaScriptCore
Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
Reviewed by Oliver Hunt.
This method tried to repatch a LDR (T2) into an ADD (T3) - but it only
repatches the first instruction word. The layout of the fields in the
second word is different, and also needs repatching.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchLoadPtrToLEA):
- 11:32 PM Changeset in webkit [62436] by
-
- 7 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557
There didn't seem to be test coverage of these cases in the suite, so I
added a couple tests.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557
So sayeth the spec.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 11:20 PM Changeset in webkit [62435] by
-
- 4 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 11:07 PM Changeset in webkit [62434] by
-
- 5 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555
Test progression.
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555
This patch is kind of goofy but apparently how the world works.
- html/HTMLToken.h: (WebCore::AtomicHTMLToken::setName):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 10:42 PM Changeset in webkit [62433] by
-
- 2 edits in trunk/LayoutTests
Fix test to account for the arg count clamping we do with function.apply
- 9:52 PM Changeset in webkit [62432] by
-
- 6 edits3 adds in trunk
Clamp the number of arguments supported by function.apply
https://bugs.webkit.org/show_bug.cgi?id=41351
<rdar://problem/8142141>
Reviewed by Gavin Barraclough.
Add clamping logic to function.apply similar to that
enforced by firefox. We have a smaller clamp than
firefox as our calling convention means that stack
usage is proportional to argument count -- the firefox
limit is larger than you could actually call.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Arguments.h:
(JSC::Arguments::):
LayoutTests:
Testcases.
- fast/js/function-apply-many-args-expected.txt: Added.
- fast/js/function-apply-many-args.html: Added.
- fast/js/script-tests/function-apply-many-args.js: Added.
- 9:23 PM Changeset in webkit [62431] by
-
- 2 edits in trunk/WebCore
2010-07-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Remove extra semicolon at the end of HTMLTreeBuilder::attach
https://bugs.webkit.org/show_bug.cgi?id=41546
This is not critical, but the extra semicolon at the end of HTMLTreeBuilder::attach
causes a warning in RVCT.
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
- 9:07 PM Changeset in webkit [62430] by
-
- 2 edits in trunk/WebKit2
2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Wrong method name in file Connection.h
https://bugs.webkit.org/show_bug.cgi?id=41536
Method openConnectionHandler was spelled as openConnection in class Connection.
- Platform/CoreIPC/Connection.h:
- 8:53 PM Changeset in webkit [62429] by
-
- 2 edits in trunk/WebCore
2010-07-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Performance::disconnectFrame() needs to disconnect its children
https://bugs.webkit.org/show_bug.cgi?id=41533
No new tests because no new functionality.
- page/Performance.cpp: (WebCore::Performance::disconnectFrame):
- 8:39 PM Changeset in webkit [62428] by
-
- 3 edits in trunk/WebKit2
2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Sam Weinig.
Adding notification and touch events methods to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=41527
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::notificationPresenter): (WebKit::WebChromeClient::needTouchEvents):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 8:08 PM Changeset in webkit [62427] by
-
- 2 edits in trunk/WebCore
2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Sam Weinig.
Checking if WTF_USE_JSC is defined before redefining it in config.h
https://bugs.webkit.org/show_bug.cgi?id=41530
- config.h:
- 8:05 PM Changeset in webkit [62426] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
Mark a newly added test as crashing.
- platform/chromium/test_expectations.txt:
- 7:46 PM Changeset in webkit [62425] by
-
- 2 edits in trunk/WebKit2
2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Sam Weinig.
Removing CoreFoundation.h include from WKFrame.h
https://bugs.webkit.org/show_bug.cgi?id=41528
- UIProcess/API/C/WKFrame.h:
- 7:18 PM Changeset in webkit [62424] by
-
- 4 edits in trunk/WebCore
2010-07-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Dimitri Glazkov.
Add vendor prefix to window.performance
https://bugs.webkit.org/show_bug.cgi?id=41525
No new tests because window.performance tests not landed yet.
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitPerformance):
- page/DOMWindow.h: (WebCore::DOMWindow::optionalWebkitPerformance):
- page/DOMWindow.idl:
- 7:02 PM Changeset in webkit [62423] by
-
- 2 edits in trunk/WebCore
2010-07-02 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
Minor fix: Diffuse constant is float (not integer)
https://bugs.webkit.org/show_bug.cgi?id=10412
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
- 6:49 PM Changeset in webkit [62422] by
-
- 3 edits in trunk/JavaScriptCore
2010-07-02 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
https://bugs.webkit.org/show_bug.cgi?id=40179
Add the MIPS part to re-enable JIT_OPTIMIZE_NATIVE_CALL.
- jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall):
- wtf/Platform.h:
- 6:20 PM Changeset in webkit [62421] by
-
- 2 edits in branches/audio/WebCore
Fixes to build for audio branch
- 6:20 PM Changeset in webkit [62420] by
-
- 1 edit in branches/audio/WebCore/WebCore.gypi
Generate bindings for AudioGainNode
- 5:28 PM Changeset in webkit [62419] by
-
- 4 edits in trunk/JavaScriptCore
Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.
Reviewed by Oliver Hunt.
Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
- runtime/JSImmediate.h:
(JSC::JSValue::isCell):
- 5:11 PM Changeset in webkit [62418] by
-
- 2 edits in trunk/WebCore
2010-07-02 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Build fix for GTK+. Try to force a rebuild of the HTMLNames.h
file first by touching HTMLTagNames.in.
- html/HTMLTagNames.in:
- 5:08 PM Changeset in webkit [62417] by
-
- 5 edits3 adds in trunk
2010-07-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
Add test to verify proper clamping of RGB values.
https://bugs.webkit.org/show_bug.cgi?id=39482
Also unskip 3 canvas/philip tests that now pass.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors
- fast/canvas/canvas-color-clamping-expected.txt: Added.
- fast/canvas/canvas-color-clamping.html: Added.
- fast/canvas/script-tests/canvas-color-clamping.js: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
2010-07-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
RGB colors should be clamped to the 0-255 range
https://bugs.webkit.org/show_bug.cgi?id=39482
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors
Test: fast/canvas/canvas-color-clamping.html
- css/CSSParser.cpp: (WebCore::parseColorInt): (WebCore::CSSParser::parseColor): (WebCore::parseColorIntFromValue): (WebCore::CSSParser::parseColorParameters):
- 4:49 PM Changeset in webkit [62416] by
-
- 9 edits in trunk
2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549
accursed last minute changes (Requested by olliej on #webkit).
- parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::copyCodeWithoutBOMs): (JSC::Lexer::sourceCode):
- parser/SourceProvider.h: (JSC::): (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::hasBOMs): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
- wtf/text/StringImpl.h:
2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549
accursed last minute changes (Requested by olliej on #webkit).
- bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
- bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
- loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
- loader/CachedScript.h:
- 4:46 PM Changeset in webkit [62415] by
-
- 1 edit2 moves in trunk/WebKitTools
Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
Reviewed by Anders Carlsson.
- Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
- Scripts/debug-webkittestrunner: Removed.
- Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
- Scripts/run-webkittestrunner: Removed.
- 4:26 PM Changeset in webkit [62414] by
-
- 3 edits in trunk/JavaScriptCore
Patch for https://bugs.webkit.org/show_bug.cgi?id=41548
Use snprintf instead of sprintf everywhere in JavaScriptCore
Reviewed by Geoffrey Garen.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
- runtime/UString.cpp:
(JSC::UString::from):
- 4:15 PM Changeset in webkit [62413] by
-
- 2 edits in trunk/WebCore
2010-07-02 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Further Build fix for GTK+. Also include HTMLElementFactory.h in
the list of dependencies.
- GNUmakefile.am:
- 4:11 PM Changeset in webkit [62412] by
-
- 2 edits in trunk/WebCore
2010-07-02 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Build fix for GTK+. *Names.{cpp,h} targets should now include the
header files. Also adds the header files to the generated sources list.
- GNUmakefile.am:
- 3:50 PM Changeset in webkit [62411] by
-
- 12 edits in trunk
WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404
Reviewed by Darin Fisher.
- Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
- Removed the Database::stop{ed}() methods.
- Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
- Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
- Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
- Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::stopDatabases):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::hasOpenDatabases):
- storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):
- storage/Database.h:
- storage/DatabaseTask.cpp:
(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):
- storage/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404
Reviewed by Darin Fisher.
- storage/open-database-creation-callback.html:
- 3:31 PM Changeset in webkit [62410] by
-
- 9 edits in trunk
2010-07-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539
Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.
- parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::sourceCode):
- parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
- wtf/text/StringImpl.h: (WebCore::StringImpl::copyStringWithoutBOMs):
2010-07-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539
Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.
- bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
- bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
- loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
- loader/CachedScript.h: (WebCore::CachedScript::): CachedScript now stores decoded data with the BOMs stripped, and caches the presence of BOMs across memory purges.
- 3:18 PM Changeset in webkit [62409] by
-
- 3 edits3 adds in trunk/LayoutTests
2010-07-02 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, expectations update.
Provide new expectations for ports that don't handle "Enter-on-select" in the same way as Safari.
https://bugs.webkit.org/show_bug.cgi?id=39532
- platform/chromium-win/fast/forms/implicit-submission-expected.txt: Added.
- platform/gtk/Skipped: Unskipped the test.
- platform/gtk/fast/forms/implicit-submission-expected.txt: Added.
- platform/qt/Skipped: Unskipped the test.
- platform/qt/fast/forms/implicit-submission-expected.txt: Added.
- 3:03 PM Changeset in webkit [62408] by
-
- 2 edits in trunk/LayoutTests
Reviewed by David Levin.
fast/canvas/webgl/program-test.html failed on leopard bot
https://bugs/webkit.org/show_bug.cgi?id=41542
- platform/mac-leopard/Skipped: Skip the failing test for now.
- 2:58 PM Changeset in webkit [62407] by
-
- 2 edits in trunk/WebCore
Add missing symbol to exports file.
- WebCore.base.exp:
- 2:54 PM Changeset in webkit [62406] by
-
- 6 edits in trunk/WebKit2
Patch for https://bugs.webkit.org/show_bug.cgi?id=41540
WebKit2: Add InjectedCode API to get a list of subframes
Reviewed by Oliver Hunt.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyChildFrames):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::childFrameRef):
(WebKit::childFrameDeref):
(WebKit::WebFrame::childFrames):
- WebProcess/WebPage/WebFrame.h:
- mac/WebKit2.exp:
- 2:34 PM Changeset in webkit [62405] by
-
- 5 edits in trunk/JavaScriptCore
[ Updated after rollout. ]
Patch by Renata Hodovan <reni@inf.u-szeged.hu> on 2010-07-02
Reviewed by Oliver Hunt.
Merged RegExp constructor and RegExp::create methods.
Both functions are called with three parameters and check whether
flags (the third param) is given or not.
Avoid extra hash lookups in RegExpCache::create by passing a pre-computed
iterator parameter.
https://bugs.webkit.org/show_bug.cgi?id=41055
- runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
- runtime/RegExp.h:
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
- runtime/RegExpCache.h:
- 2:31 PM Changeset in webkit [62404] by
-
- 5 edits in trunk
Versioning.
- 2:29 PM Changeset in webkit [62403] by
-
- 1 copy in tags/Safari-534.2
New tag.
- 2:11 PM Changeset in webkit [62402] by
-
- 5 edits in trunk/LayoutTests
Update some Windows layout test results after r62215 - adding the .dataset
DOM property.
Rubber-stamped by Anders Carlsson.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 1:43 PM Changeset in webkit [62401] by
-
- 3 edits in trunk/LayoutTests
2010-07-02 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, expectations update.
Add fast/forms/implicit-submission.html to Gtk and Qt Skipped list,
because their behaviors are platform-specific and don't match
expected results.
https://bugs.webkit.org/show_bug.cgi?id=39532
- platform/gtk/Skipped: Added fast/forms/implicit-submission.html.
- platform/qt/Skipped: Ditto.
- 1:39 PM Changeset in webkit [62400] by
-
- 2 edits in trunk/WebKitTools
Some http tests fail on Windows with Cygwin 1.7
https://bugs.webkit.org/show_bug.cgi?id=41537
Reviewed by Steve Falkenburg.
With Cygwin 1.7, the registry key at SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/
doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
just need root mount point, which is defined in SOFTWARE
Cygwin
setup.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(resolveCygwinPath): Fall back to SOFTWARE
Cygwin
setup if
SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/ doesn't work.
- 12:51 PM Changeset in webkit [62399] by
-
- 5 edits2 adds in trunk
2010-07-02 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Remove the extra setFailed() call in JPEG decoder to prevent
re-using an already freed object.
https://bugs.webkit.org/show_bug.cgi?id=41487
Test: fast/images/large-size-image-crash.html
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
2010-07-02 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Tests that images with large width and height values do not result in crash.
Skip layout test for mac and win since it needs to be fixed at image decoder layer for Safari.
https://bugs.webkit.org/show_bug.cgi?id=41487
- fast/images/large-size-image-crash-expected.txt: Added.
- fast/images/large-size-image-crash.html: Added.
- fast/images/resources/large-size-image-crash.jpeg: Added.
- platform/mac/Skipped:
- platform/win/Skipped:
- 12:45 PM Changeset in webkit [62398] by
-
- 6 edits3 adds in trunk
2010-07-02 Peter Beverloo <peter@lvp-media.com>
Reviewed by Maciej Stachowiak.
Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.
Tests for <p> closing, phrasing child content and residual style.
- fast/html/mark-element-expected.txt: Added.
- fast/html/mark-element.html: Added.
- fast/html/script-tests/mark-element.js: Added.
2010-07-02 Peter Beverloo <peter@lvp-media.com>
Reviewed by Maciej Stachowiak.
Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.
Test: fast/html/mark-element.html
Tests for <p> closing, phrasing child content and residual style.
- css/html.css: (mark):
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLTagNames.in:
- html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag):
- 12:24 PM Changeset in webkit [62397] by
-
- 9 edits1 add in trunk
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473
- fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Test against overflow, size-0 buffer, and count==0 situations.
- fast/canvas/webgl/draw-arrays-out-of-bounds.html: Ditto.
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Ditto.
- fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473
- WebCore.gypi: Add CheckedInt.h.
- WebCore.xcodeproj/project.pbxproj: Add CheckedInt.h.
- html/canvas/CheckedInt.h: Added support of safe integer operations. (mozilla::CheckedInt_internal::integer_type_manually_recorded_info::): (mozilla::CheckedInt_internal::is_unsupported_type::): (mozilla::CheckedInt_internal::): (mozilla::CheckedInt_internal::integer_traits::): (mozilla::CheckedInt_internal::integer_traits::min): (mozilla::CheckedInt_internal::integer_traits::max): (mozilla::CheckedInt_internal::has_sign_bit): (mozilla::CheckedInt_internal::binary_complement): (mozilla::CheckedInt_internal::is_in_range): (mozilla::CheckedInt_internal::is_add_valid): (mozilla::CheckedInt_internal::is_sub_valid): (mozilla::CheckedInt_internal::is_mul_valid): (mozilla::CheckedInt_internal::is_div_valid): (mozilla::CheckedInt::CheckedInt): (mozilla::CheckedInt::value): (mozilla::CheckedInt::valid): (mozilla::CheckedInt::operator -): (mozilla::CheckedInt::operator ==): (mozilla::CheckedInt::operator !=): (mozilla::operator /): (mozilla::cast_to_CheckedInt_impl::run): (mozilla::): (mozilla::cast_to_CheckedInt): (mozilla::operator ==):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayConservative): Fix a bug against 0-size buffer situation. (WebCore::WebGLRenderingContext::drawArrays): Deal with overflows and count==0 situation. (WebCore::WebGLRenderingContext::drawElements): Deal with count==0 situation.
- 12:06 PM Changeset in webkit [62396] by
-
- 7 edits2 adds in trunk
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380
- fast/canvas/webgl/program-test-expected.txt: Added.
- fast/canvas/webgl/program-test.html: Added.
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380
Test: fast/canvas/webgl/program-test.html
- html/canvas/WebGLProgram.cpp: Add flag for link failure due to missing shaders. (WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h: Add interface for linkFailure flag. (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramParameter): Intercept when linkFailureFlag is set. (WebCore::WebGLRenderingContext::linkProgram): Check if there are missing shaders and don't link if yes.
- html/canvas/WebGLShader.cpp: Cache shader type. (WebCore::WebGLShader::WebGLShader):
- html/canvas/WebGLShader.h: Ditto. (WebCore::WebGLShader::getType):
- 12:00 PM Changeset in webkit [62395] by
-
- 3 edits in trunk/WebKit2
Turn off the Objective-C garbage collection for the WebProcess.
Reviewed by Anders Carlsson.
- Configurations/WebProcess.xcconfig:
- WebProcess/Launching/mac/WebProcessMain.mm:
(main): Assert that GC is off.
- 11:54 AM CodeReview created by
- 11:47 AM Changeset in webkit [62394] by
-
- 6 edits in trunk
2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html
Remove the following test case from Skipped:
canvas/philip/tests/2d.drawImage.negativedest.html
canvas/philip/tests/2d.drawImage.negativedir.html
canvas/philip/tests/2d.drawImage.negativesource.html
- platform/qt/Skipped:
2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html
Support negative width and height in canvas image draw
- platform/graphics/FloatRect.h:
- platform/graphics/qt/FloatRectQt.cpp: (WebCore::FloatRect::normalized):
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- 11:43 AM Changeset in webkit [62393] by
-
- 2 edits in trunk/WebKit2
There is no longer a reason to check that the process is valid when posting
a message to the bundle, the process code will take care of that for us.
Reviewed by Anders Carlsson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle):
- 11:42 AM WikiStart edited by
- (diff)
- 11:42 AM Changeset in webkit [62392] by
-
- 2 edits in trunk/WebKit2
Use send instead of connection()->send(), now that connections() are created
asynchronously it can be null at this point and the message needs to be queued.
Reviewed by Anders Carlsson.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::setUpAcceleratedCompositing):
- 11:06 AM Changeset in webkit [62391] by
-
- 7 edits in trunk
2010-06-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Alexey Proskuryakov.
REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532
- fast/forms/implicit-submission-expected.txt: Updated.
- fast/forms/implicit-submission.html: Added more test coverage for selects.
2010-06-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Alexey Proskuryakov.
REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532
Restore behavior where hitting "Enter" on a select element attempts to submit
form implicitly.
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): Added htmlForm argument,
and attempting to submit implicitly.
(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Plumbed through htmlForm argument.
- dom/SelectElement.h: Added htmlForm argument to method declaration.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed to provide submitting form
as the argument.
- 10:30 AM Changeset in webkit [62390] by
-
- 5 edits in trunk
2010-07-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508
- platform/chromium/test_expectations.txt: fast/forms/indeterminate.html fails temporarily.
2010-07-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): Use dedicated images for indeterminate states.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): Do not use DFCS_CHECKED in a case of indeterminate state in order to have consistent appearance of indeterminate checkbox.
- 10:21 AM Changeset in webkit [62389] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-02 Martin Robinson <mrobinson@igalia.com>
Unreviewed. Build fix for GTK+.
Build Lexer.lut.h with the rest of the .lut.h files. Later these should
all probably be moved to DerivedSources.
- GNUmakefile.am:
- 10:14 AM Changeset in webkit [62388] by
-
- 3 edits1 add in trunk/WebCore
Fixes https://bugs.webkit.org/show_bug.cgi?id=41323.
Provides an implementation of the 'squiggle' used for
bad grammar or spelling, based on the Pango logic used
by the GTK builds.
Reviewed by Gustavo Noronha Silva.
No new tests. Covered by LayoutTests/editing/spelling
- WebCore.vcproj/WebCore.vcproj: Add new file holding underline
implementation, set to build only for WinCairo port.
- platform/graphics/cairo/DrawErrorUnderline.cpp: Added.
(drawErrorUnderline): New file containing the squiggle drawing
logic based on the Pango implementation. Placed in its own file
to isolate licenses.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
Have WinCairo build call new 'drawErrorUnderline' implementation.
- 9:53 AM Changeset in webkit [62387] by
-
- 10 edits in trunk
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.
- GNUmakefile.am:
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
Generate JavaScriptCore derived sources in <builddir>/DerivedSources/JavaScriptCore.
- GNUmakefile.am:
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
Generate WebCore derived sources in <builddir>/DerivedSources/WebCore.
- GNUmakefile.am:
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.
- webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
The JavaScriptCore cppflags used to include the top-level DerivedSources directory
allowing the tools to build as a side-effect. Now that the top-level directory
is no longer in the list of JavaScriptCore includes, include it explicitly.
- GNUmakefile.am:
- 9:45 AM Changeset in webkit [62386] by
-
- 3 edits3 adds in trunk
2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458
- yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):
2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458
- fast/js/regexp-look-ahead-expected.txt: Added.
- fast/js/regexp-look-ahead.html: Added.
- fast/js/script-tests/regexp-look-ahead.js: Added.
- 9:35 AM Changeset in webkit [62385] by
-
- 6 edits4 adds in trunk
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300
- fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Added.
- fast/canvas/webgl/gl-bind-attrib-location-test.html: Added.
- fast/canvas/webgl/gl-vertex-attrib-expected.txt: Added.
- fast/canvas/webgl/gl-vertex-attrib.html: Added.
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300
Test: fast/canvas/webgl/gl-bind-attrib-location-test.html
fast/canvas/webgl/gl-vertex-attrib.html
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::numActiveAttribLocations): const. (WebCore::WebGLProgram::getActiveAttribLocation): const. (WebCore::WebGLProgram::isUsingVertexAttrib0): Determine whether vertex attrib 0 is used by the program.
- html/canvas/WebGLProgram.h: Declare isUsingVertexAttrib0.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Deal with vertex attrib 0. (WebCore::WebGLRenderingContext::disableVertexAttribArray): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::getVertexAttrib): Use cached value instead of calling glGetVertexAtrtrib. (WebCore::WebGLRenderingContext::vertexAttrib1f): Validate input, deal with vertex attrib 0. (WebCore::WebGLRenderingContext::vertexAttrib1fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttribPointer): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Move isGLES2Compliant() to caller. (WebCore::WebGLRenderingContext::vertexAttribImpl): Helper for vertexAttribNfv. (WebCore::WebGLRenderingContext::initVertexAttrib0): Initialize vertex attrib 0. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Simulate vertex attrib 0. (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation): Restore states after simulating vertex attrib 0.
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): Tracking full vertex attrib states. (WebCore::WebGLRenderingContext::VertexAttribState::initValue): Init value to [0,0,0,1].
- 9:20 AM Changeset in webkit [62384] by
-
- 8 edits in trunk
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383
- fast/canvas/webgl/gl-uniform-arrays-expected.txt: Test against invalid array size.
- fast/canvas/webgl/gl-uniform-arrays.html: Ditto.
- fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Ditto.
- fast/canvas/webgl/gl-uniformmatrix4fv.html: Ditto.
2010-07-02 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383
- html/canvas/WebGLRenderingContext.cpp: Validate input array size. (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::validateUniformParameters): (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
- html/canvas/WebGLRenderingContext.h: Add helper functions.
- 8:15 AM Changeset in webkit [62383] by
-
- 4 edits in trunk
[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear
Reviewed by Simon Hausmann.
The implementation of PathQt's addArcTo() was not float-safe and also had
a case where it drew an 'infinite' line, which is not part of the spec.
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto
We now use qFuzzyCompare() in both cases. The method isPointOnPathBorder()
also had the same problem, and was refactored a bit in the process of fixing
the bug.
Initial patch by Andreas Kling.
- 7:11 AM Changeset in webkit [62382] by
-
- 3 edits in trunk/JavaScriptCore/qt
2010-07-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Compilation fix.
QScriptEnginePrivate::newArray can't be const because it can
throw an exception.
[Qt] QScriptEnginePrivate compilation fix
https://bugs.webkit.org/show_bug.cgi?id=41520
- api/qscriptengine_p.cpp: (QScriptEnginePrivate::newArray):
- api/qscriptengine_p.h:
- 6:56 AM Changeset in webkit [62381] by
-
- 2 edits in trunk/LayoutTests
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline html5lib/runner.html on Chromium Mac.
- platform/chromium-mac/html5lib/runner-expected.txt:
- 4:43 AM Changeset in webkit [62380] by
-
- 10 edits4 adds in trunk
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511
- fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
- fast/events/popup-blocked-from-fake-user-gesture.html: Added.
- http/tests/inspector/change-iframe-src-expected.txt: Added.
- http/tests/inspector/change-iframe-src.html: Added.
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511
Tests: fast/events/popup-blocked-from-fake-user-gesture.html
http/tests/inspector/change-iframe-src.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511
- src/WebBindings.cpp: (WebKit::getEvent):
- 4:36 AM Changeset in webkit [62379] by
-
- 3 edits in trunk/LayoutTests
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline html5lib/runner.html
- platform/chromium-mac/html5lib/runner-expected.txt:
- platform/chromium-win/html5lib/runner-expected.txt:
- 3:47 AM QtWebKitBugs edited by
- (diff)
- 3:43 AM QtWebKitTriageRoster edited by
- (diff)
- 3:38 AM Changeset in webkit [62378] by
-
- 6 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505
Test progression plus reduced test case.
- html5lib/resources/comments01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505
I noticed this error when browsing through the HTML5lib failures.
We're adding an extra character to the comment token, contrary to what
the spec says to do.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
- 3:37 AM Changeset in webkit [62377] by
-
- 6 edits1 add in trunk/JavaScriptCore/qt
Implement exception reporting in the QtScript API.
Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-28
Reviewed by Simon Hausmann.
The exception should be accessible through the API by the uncaughtException
function. Functions; hasUncaughtException, clearExceptions, uncaughtExceptionLineNumber,
uncaughtExceptionBacktrace were added to facilitate error checking and debugging.
[Qt] QtScript API should be exceptions aware.
https://bugs.webkit.org/show_bug.cgi?id=41199
- api/qscriptengine.cpp:
(QScriptEngine::hasUncaughtException):
(QScriptEngine::uncaughtException):
(QScriptEngine::clearExceptions):
(QScriptEngine::uncaughtExceptionLineNumber):
(QScriptEngine::uncaughtExceptionBacktrace):
- api/qscriptengine.h:
- api/qscriptengine_p.cpp:
(QScriptEnginePrivate::QScriptEnginePrivate):
(QScriptEnginePrivate::~QScriptEnginePrivate):
(QScriptEnginePrivate::uncaughtException):
- api/qscriptengine_p.h:
(QScriptEnginePrivate::):
(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::hasUncaughtException):
(QScriptEnginePrivate::clearExceptions):
(QScriptEnginePrivate::setException):
(QScriptEnginePrivate::uncaughtExceptionLineNumber):
(QScriptEnginePrivate::uncaughtExceptionBacktrace):
- api/qscriptvalue_p.h:
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::inherits):
- tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::uncaughtException):
- 3:26 AM Changeset in webkit [62376] by
-
- 5 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503
See test progression.
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503
This is a common idiom because <p> likes to close itself.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInScope): (WebCore::HTMLTreeBuilder::processStartTag):
- html/HTMLTreeBuilder.h:
- 3:14 AM Changeset in webkit [62375] by
-
- 7 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501
The AfterAfterBodyMode doesn't seem to be well-covered by the existing
HTML5lib tests, so I added a few more tests to cover it. It's somewhat
hard to observe. The only way I can figure out to observe it is where
the comment elements get attached to the DOM.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501
In implementing this mode, I noticed a bug in the character processing
of the AfterBodyMode, which I fixed by adding a break statement. Also,
to get one of the new tests to pass, I needed to implement one
notImplemented() in the InBody insertion mode. Yay for testing.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 3:02 AM Changeset in webkit [62374] by
-
- 2 edits in trunk/WebCore
2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62371.
http://trac.webkit.org/changeset/62371
https://bugs.webkit.org/show_bug.cgi?id=41515
"Breaks media/controls-drag-timebar.html on 32-Bit Release"
(Requested by philn-tp on #webkit).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
- 2:51 AM QtWebKitWeeklyBuilds edited by
- (diff)
- 2:49 AM QtWebKitWeeklyBuilds edited by
- (diff)
- 2:42 AM QtWebKitJournal edited by
- (diff)
- 2:42 AM QtWebKitWeeklyBuilds created by
- 2:42 AM QtWebKitJournal edited by
- (diff)
- 2:36 AM Changeset in webkit [62373] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Remove accidentally added expectations on Chromium Linux - they should be derived from Windows ones.
- platform/chromium-linux/html5lib/runner-expected.txt: Removed.
- 2:29 AM Changeset in webkit [62372] by
-
- 3 edits1 copy1 add in trunk/LayoutTests
2010-07-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
- platform/chromium-linux/html5lib/runner-expected.txt: Added.
- platform/chromium-win/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:48 AM Changeset in webkit [62371] by
-
- 2 edits in trunk/WebCore
2010-06-28 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] can't seek past maxTimeLoaded value
https://bugs.webkit.org/show_bug.cgi?id=40526
Extended the seekable range to the whole media. This allows video
played with progressive download to be seeked past the current
buffered position.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
- 1:29 AM Changeset in webkit [62370] by
-
- 8 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500
Update expected results to show test progression. Also, add some test
cases to cover how attributes on </br> tags are handled.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500
In the coarse of implementing this state, I ran into an ASSERT in how
</br> tags where handled, which I fixed. Technically, that could be a
separate patch, but it seemed harmless to include it here (with tests).
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::insertCommentOnHTMLHtmlElement):
- html/HTMLTreeBuilder.h:
- 1:14 AM Changeset in webkit [62369] by
-
- 4 edits in trunk
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502
See test progression. Fun game.
- html5lib/runner-expected-html5.txt:
2010-07-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502
Implement notImplemented() per spec.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
