Timeline
Jul 19, 2010:
- 11:54 PM Changeset in webkit [63725] by
-
- 1 edit7 adds in trunk/LayoutTests
2010-07-19 Dirk Schulze <krit@webkit.org>
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Unreviewed update of Win baseline.
- platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
- platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/win/svg/custom/use-css-events-expected.txt: Added.
- platform/win/svg/dom: Added.
- platform/win/svg/dom/path-parser-expected.txt: Added.
- 11:41 PM Changeset in webkit [63724] by
-
- 5 edits in trunk/LayoutTests
2010-07-19 Dirk Schulze <krit@webkit.org>
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Unreviewed update of Qt baseline.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 11:28 PM Changeset in webkit [63723] by
-
- 7 edits2 adds in trunk
2010-07-19 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Added a simple implementation of VideoLayerChromium. Uses the
LayerChromium::updateTextureRect() to send video frames to the
GPU.
https://bugs.webkit.org/show_bug.cgi?id=42234
- WebCore.gypi: Added include for VideoLayerChromium.
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToMedia): Implemented setContentsToMedia, though it does not seem to trigger a repaint correctly.
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp: Added. (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents):
- platform/graphics/chromium/VideoLayerChromium.h: Added. (WebCore::VideoLayerChromium::drawsContent):
2010-07-19 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Updated WebMediaPlayer to support accelerated rendering and to
create and return a VideoChromiumLayer as its platform layer.
https://bugs.webkit.org/show_bug.cgi?id=42234
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::create):
- src/WebMediaPlayerClientImpl.h: (WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
- 11:23 PM Changeset in webkit [63722] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed test expectation fix.
fast/css/font-face-download-error.html should be skipped for Qt like
other @font-face tests.
https://bugs.webkit.org/show_bug.cgi?id=42342
- platform/qt/Skipped:
- 10:37 PM Changeset in webkit [63721] by
-
- 52 edits7 adds in trunk
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Added piOverTwo to MathExtras.
- wtf/MathExtras.h:
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Cleanup the parsing code for SVG Paths. Move classes out of the convoluted SVGParserUtilities.cpp
in their own files. Make use of WebCore specific objects in parsing code like FloatPoint, AffineTransform,
etc. instead of using home-brewn solutions.
The SVGPathParser parses a path data string and delivers the parsed segments and values to the SVGPathConsumer.
SVGPathConsumer is the base class for SVGPathBuilder and SVGPathSegListBuilder, that either build the platform
Path object or a SVGPathSegList out of the segments.
We're now directly parsing floats instead of truncating precision to float afterwards.
SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448
If one of the radii on the elliptic arc are zero, we should draw a line from the starting point to
the end point according to the spec. Fixed this bug with this patch, because an is zero check and
an DRT check was neccessary with the current clean-up.
Extended svg/dom/path-parser.xhml to check the correct behavior.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): Follow WebKit style and use multiple lines for the function. (WebCore::FloatPoint::scale): Scale FloatPoint. (WebCore::operator+=): (WebCore::operator+): Add two FloatPoints and give back the sum as FloatPoint.
- svg/SVGAllInOne.cpp: Added new created files.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): Use new PathParser to create a PathSegList.
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): Use new PathParser to create a Path.
- svg/SVGGlyphElement.cpp: (WebCore::parsePathData): Use new PathParser to create a Path.
- svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): Removed parseArcFlag(double&), we parse in float now.
- svg/SVGParserUtilities.h: Removed path parsing code and a lot of unneccessary includes.
- svg/SVGPathBuilder.cpp: Added. (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::build): Builds a normalized Path. (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
- svg/SVGPathBuilder.h: Added. We just create normalized Paths, so this functions should never be reached. (WebCore::SVGPathBuilder::lineToHorizontal): (WebCore::SVGPathBuilder::lineToVertical): (WebCore::SVGPathBuilder::curveToCubicSmooth): (WebCore::SVGPathBuilder::curveToQuadratic): (WebCore::SVGPathBuilder::curveToQuadraticSmooth): (WebCore::SVGPathBuilder::arcTo):
- svg/SVGPathConsumer.h: Added. Base class of SVGPathBuilder and SVGPathSegListBuilder. (WebCore::): (WebCore::SVGPathConsumer::SVGPathConsumer): (WebCore::SVGPathConsumer::~SVGPathConsumer):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute): Use new PathParser to create a PathSegList.
- svg/SVGPathParser.cpp: Added. (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::~SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataString): (WebCore::SVGPathParser::decomposeArcToCubic): Normalizes an arc to multiple cubic curves.
- svg/SVGPathParser.h: Added.
- svg/SVGPathSegListBuilder.cpp: Added. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::build): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
- svg/SVGPathSegListBuilder.h: Added.
2010-07-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410
Parsing values as float instead of double causes some minimal changes on DRT results and
pixel results. Even if the values get shrinked to float before the calculation of arc and
others. But the calculation itself transforms the values back to double and shrinks it to
floats again right before the drawing.
SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448
Extended svg/dom/path-parser.xhml to check the correct behavior. We draw a line from the
current point to the given end point.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/mac/svg/custom/use-css-events-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/hixie/perf/007-expected.checksum:
- platform/mac/svg/hixie/perf/007-expected.png:
- platform/mac/svg/hixie/perf/007-expected.txt:
- svg/custom/path-getTotalLength-expected.txt:
- svg/dom/path-parser-expected.txt:
- svg/dom/script-tests/path-parser.js:
- 10:28 PM Changeset in webkit [63720] by
-
- 3 edits in trunk/LayoutTests
Unreviewed trivial fix after r63684.
https://bugs.webkit.org/show_bug.cgi?id=30464
- fast/dom/Window/window-properties-expected.txt: Updated.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- 10:10 PM Changeset in webkit [63719] by
-
- 4 edits2 adds in trunk
2010-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342
- fast/css/font-face-download-error-expected.txt: Added.
- fast/css/font-face-download-error.html: Added.
2010-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342
Test: fast/css/font-face-download-error.html
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::isValid): Valid if at least one font face is valid. (WebCore::CSSSegmentedFontFace::getFontData): Check validity for each font face.
- css/CSSSegmentedFontFace.h: Make isValid private.
- 9:33 PM Changeset in webkit [63718] by
-
- 2 edits in trunk/WebCore
2010-07-19 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42568
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::systemFontSize): (WebCore::pointsToPixels): (WebCore::querySystemBlinkInterval): (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
- 9:32 PM Changeset in webkit [63717] by
-
- 2 edits in trunk/WebCore
(Hopefully the last) Windows build fix.
Version of CoreServices.h in WebKit Support Libraries uses
pragma once, unlike the version I have locally. Switch based
on COLORSYNCDEPRECATED instead.
- WebCorePrefix.h:
- 9:17 PM Changeset in webkit [63716] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- WebCorePrefix.h:
- 9:09 PM Changeset in webkit [63715] by
-
- 2 edits in trunk/LayoutTests
Remove now passing tests from the skipped list.
Reviewed by Maciej Stachowiak.
- platform/mac-wk2/Skipped:
- 9:05 PM Changeset in webkit [63714] by
-
- 2 edits in trunk/WebKitTools
Fix build.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Paths of generated files should be relative to the build product.
- 8:42 PM Changeset in webkit [63713] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-19 Mike Moretti <mike.moretti@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] Build fix after r63404.
Implement isValid() function for the Symbian executable allocator.
- jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::isValid):
- 8:24 PM Changeset in webkit [63712] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCorePrefix.h:
- 8:14 PM Changeset in webkit [63711] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCorePrefix.h:
- 8:01 PM Changeset in webkit [63710] by
-
- 12 edits in trunk
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements support for markerTextForListItem in the Windows port.
- DOMCoreClasses.cpp: (DOMElement::markerTextForListItem): Added.
- DOMCoreClasses.h:
- Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
- Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
- Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
- WebView.cpp: (WebView::elementFromJS): Added.
- WebView.h:
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Remove skipped layout tests now that we have DRT support.
- platform/win/Skipped:
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements DRT support for markerTextForListItem in the Windows port.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::markerTextForListItem): Implemented.
- 8:00 PM Changeset in webkit [63709] by
-
- 7 edits in trunk/WebCore
Windows Build fixes for new ColorSync API.
We support both new and old APIs, since the newer headers aren't in the tree yet.
- WebCorePrefix.h: Removed include of CoreServices.h. Included via ColorSyncPriv.h instead, since header may not be present.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::createCGColor): Conditionally use new ColorSync API.
- platform/graphics/opentype/OpenTypeUtilities.cpp: Define Fixed if CoreServices.h doesn't.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::updateLayerDrawsContent): Use 0 instead of nil, since nil is no longer present via CoreServices.h.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Include AssertMacros.h.
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::operator CFErrorRef): Use 0 instead of nil, since nil is no longer present via CoreServices.h.
- 7:40 PM Changeset in webkit [63708] by
-
- 3 edits2 adds in trunk/WebKit2
WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
https://bugs.webkit.org/show_bug.cgi?id=42356
Reviewed by Sam Weinig.
Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
Call setMachPortQueueLength.
- Platform/mac/MachUtilities.cpp: Added.
(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.
- Platform/mac/MachUtilities.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add MachUtilities.cpp and MachUtilities.h
- 7:37 PM Changeset in webkit [63707] by
-
- 2 edits in trunk/WebCore
2010-07-19 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Dimitri Glazkov.
Only set unloadEventEnd when the unload event is actually fired
https://bugs.webkit.org/show_bug.cgi?id=42607
r63689 introduced this ASSERT and it began failing on Qt and Mac debug.
For some reason, it did not fail on Windows (which is where I was
testing). The ASSERT was disabled in r63699.
Test: page-cache related layout tests don't crash in debug mode on Mac.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 7:03 PM Changeset in webkit [63706] by
-
- 2 edits in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
https://bugs.webkit.org/show_bug.cgi?id=42513
Avoid making unnecessary deep-copies of QPainterPaths that will
be discarded after use.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- 6:44 PM Changeset in webkit [63705] by
-
- 4 edits in trunk
2010-07-19 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719
Fixed compiler warning introduced by original patch.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
2010-07-19 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719
Fixed compiler warning introduced by original patch. No new tests;
covered by existing tests.
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- 6:19 PM Changeset in webkit [63704] by
-
- 10 edits in trunk
Handle NP_ASFILE and NP_ASFILEONLY transfer modes
https://bugs.webkit.org/show_bug.cgi?id=42587
Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.
WebCore:
- WebCore.exp.in:
Export functions from FileSystem.h
- platform/mac/FileSystemMac.mm:
(WebCore::openTemporaryFile):
Try to create a temporary file using mkstemp.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_StreamAsFile):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add NPP_ wrapper.
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_fileHandle.
(WebKit::isSupportedTransferMode):
NP_ASFILE and NP_ASFILEONLY is now supported.
(WebKit::NetscapePluginStream::deliverData):
Call deliverDataToFile if necessary.
(WebKit::NetscapePluginStream::deliverDataToFile):
Create a temporary file and write the data into it.
(WebKit::NetscapePluginStream::stop):
If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to
call NPP_StreamAsFile and close the file and delete it.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cancelStreamLoad):
Keep a reference to the Stream since cancelling it will remove it from the map.
- 6:01 PM Changeset in webkit [63703] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
- WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeTestPluginPath):
- 5:25 PM Changeset in webkit [63702] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update one more expected result missed in r63684.
- platform/mac-leopard/accessibility/media-element-expected.txt:
- 5:07 PM Changeset in webkit [63701] by
-
- 9 edits in trunk
Implement NPN_PostURLNotify
https://bugs.webkit.org/show_bug.cgi?id=42602
Reviewed by Sam Weinig.
WebCore:
Export symbols needed by WebKit2.
- WebCore.exp.in:
WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
Read the buffer from a file if necessary and parse it.
(WebKit::NPN_GetURLNotify):
Add extra arguments.
(WebKit::NPN_PostURLNotify):
Parse the post buffer, then call NetscapePlugin::loadURL.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
Pass the method, the header fields and form data along.
(WebKit::NetscapePlugin::allowPopups):
Just return false for now.
(WebKit::NetscapePlugin::initialize):
Pass extra arguments to loadURL.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PluginController.h:
Add method, header fields and form data.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
Set the method, add the header fields and set the body.
- 4:55 PM Changeset in webkit [63700] by
-
- 6 edits in trunk/WebKitTools
Remove dependency on getopt from WebKitTestRunner.
Reviewed by Jon Honeycutt.
- Simplify options parsing and eliminate unused options.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
- WebKitTestRunner/TestController.h:
(WTR::TestController::testPluginPath):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
- 4:54 PM Changeset in webkit [63699] by
-
- 2 edits in trunk/WebCore
2010-07-19 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Remove overzealous ASSERT from r63689
https://bugs.webkit.org/show_bug.cgi?id=42606
No new tests because no new functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 4:36 PM Changeset in webkit [63698] by
-
- 3 edits in trunk/WebKitTools
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
[Qt] MiniBrowser: Progress indication at address bar
https://bugs.webkit.org/show_bug.cgi?id=42565
Reviewed by Antonio Gomes.
Make possible to see load progress at address bar based on
QtTestBrowser solution
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadProgress):
- MiniBrowser/qt/BrowserWindow.h:
- 4:35 PM Changeset in webkit [63697] by
-
- 3 edits in trunk/WebKitTools
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
https://bugs.webkit.org/show_bug.cgi?id=42564
Reviewed by Antonio Gomes.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserView::load): (BrowserWindow::BrowserWindow): (BrowserWindow::titleChanged): (BrowserWindow::urlChanged):
- MiniBrowser/qt/BrowserWindow.h:
- 4:19 PM Changeset in webkit [63696] by
-
- 2 edits in trunk/WebCore
2010-07-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Mark Rowe.
Web Inspector: Do Not Copy *.re2js Inspector Resources in XCode Build Phase
https://bugs.webkit.org/show_bug.cgi?id=42601
Remove *.re2js files after copying them over in the Build Phase. We do
the same to remove the WebKit.qrc file.
- WebCore.xcodeproj/project.pbxproj:
- 3:38 PM Changeset in webkit [63695] by
-
- 4 edits in branches/safari-533.17-branch/WebCore
Revert r63029 to address <rdar://problem/8202667>.
- 3:38 PM Changeset in webkit [63694] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Revert r63030 to address <rdar://problem/8202667>.
- 3:23 PM Changeset in webkit [63693] by
-
- 8 edits10 adds in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
Reviewed by Adam Roben.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Added.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
- WebKitTestRunner/InjectedBundle/Bindings: Added.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
- WebKitTestRunner/win/build-generated-files.sh: Added.
- 3:21 PM Changeset in webkit [63692] by
-
- 6 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed.
[chromium] Update test expectations after r63681.
Add new expected results for the clearly correct cases after r63684.
- platform/chromium-mac/media/video-load-networkState-expected.txt:
- platform/chromium-mac/media/video-src-change-expected.txt:
- platform/chromium-win/media/video-load-networkState-expected.txt:
- platform/chromium-win/media/video-src-change-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:16 PM Changeset in webkit [63691] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update more tests/results missed in r63684.
- accessibility/media-element.html:
- media/unsupported-rtsp-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- 2:58 PM Changeset in webkit [63690] by
-
- 2 edits in trunk/WebKitTools
Clean up the buildbot configuration a little.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 2:55 PM Changeset in webkit [63689] by
-
- 16 edits3 adds in trunk
2010-07-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512
- fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document. (checkTimingNotChanged): (): (loadHandler):
- fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
- fast/dom/webtiming-navigate-within-document-expected.txt: Added.
- fast/dom/webtiming-navigate-within-document.html: Added.
- platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
- platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.
2010-07-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512
Test: fast/dom/webtiming-navigate-within-document.html
- loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader. (WebCore::DocumentLoader::documentLoadTiming):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up. (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document. (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
- loader/FrameLoader.h: Get rid of FrameLoadTimeline.
- loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable. (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
- page/Navigation.cpp: (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
- page/Timing.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks. (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::redirectStart): (WebCore::Timing::redirectEnd): (WebCore::Timing::fetchStart): (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart): (WebCore::Timing::responseEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd): (WebCore::Timing::documentLoader): (WebCore::Timing::documentLoadTiming): (WebCore::Timing::resourceLoadTiming): (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
- page/Timing.h:
- 2:18 PM Changeset in webkit [63688] by
-
- 8 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.
LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.
- 2:05 PM Changeset in webkit [63687] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Simon Fraser <Simon Fraser>
Reviewed by Brady Eidson.
Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591
Hook up various loading notifications to update the URL bar in MiniBrowser.
- MiniBrowser/mac/BrowserWindowController.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): (-[BrowserWindowController didStartProvisionalLoadForFrame:]): (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): (-[BrowserWindowController didFailLoadWithErrorForFrame:]): (-[BrowserWindowController didCommitLoadForFrame:]):
- 1:53 PM Changeset in webkit [63686] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update tests/results missed in r63684.
- media/video-error-does-not-exist-expected.txt:
- media/video-load-networkState-expected.txt:
- media/video-load-networkState.html:
- 1:38 PM Changeset in webkit [63685] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree
Updating test results.
- platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: There are custom results for Tiger, adding new printout to it, as well.
- platform/gtk/http/tests/misc: Added.
- platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
- platform/gtk/http/tests/xmlhttprequest: Added.
- platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
- platform/qt/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt. These platforms don't seem to have auth delegate calls, so we can't log auth dialogs.
- 1:11 PM Changeset in webkit [63684] by
-
- 19 edits in trunk
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_completelyLoaded. (WebCore::HTMLMediaElement::parseMappedAttribute): Don't deal with 'load' event. (WebCore::HTMLMediaElement::prepareForLoad): Set m_completelyLoaded to false. (WebCore::HTMLMediaElement::setNetworkState): Don't post 'load' event. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if m_networkState != NETWORK_LOADING. (WebCore::HTMLMediaElement::userCancelledLoad): No more NETWORK_LOADED state.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
- html/HTMLMediaElement.idl: Remove NETWORK_LOADING.
2010-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>
- media/audio-delete-while-slider-thumb-clicked.html: Trigger test on 'canplaythrough' instead of 'load'.
- media/audio-delete-while-step-button-clicked.html: Ditto.
- media/event-attributes-expected.txt:
- media/event-attributes.html: Correct logic to check that 'progress' event(s) are fired while loading file, but not when src set to invalid file. 'abort' event is fired when the src is changed.
- media/invalid-media-url-crash-expected.txt:
- media/media-constants-expected.txt: No more NETWORK_LOADED state.
- media/media-constants.html: No more NETWORK_LOADED state. Clean up test.
- media/remove-from-document-expected.txt:
- media/remove-from-document.html: Ditto.
- media/video-controls-visible-audio-only.html: Trigger test on 'canplaythrough' instead of 'load'.
- media/video-source-none-supported-expected.txt: No more NETWORK_LOADED state.
- media/video-src-change-expected.txt: Ditto.
- media/video-src-none-expected.txt:
- media/video-src-none.html: No more NETWORK_LOADED state. Fix bogus test that generated "FAIL" in results.
- 1:08 PM Changeset in webkit [63683] by
-
- 4 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed.
[chromium] Update test_expectations with passing/flaky tests.
Add new chromium expected result from r63680.
- platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:08 PM Changeset in webkit [63682] by
-
- 8 edits in trunk/WebKit2
Add local storage support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42584
Reviewed by Darin Adler.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::swap):
- Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLocalStorageEnabled):
(WKPreferencesGetLocalStorageEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setLocalStorageEnabled):
(WebKit::WebPreferences::localStorageEnabled):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):
- 1:03 PM Changeset in webkit [63681] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" case.
- 11:46 AM Changeset in webkit [63680] by
-
- 9 edits5 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=40996
Progress event should not be fired during synchronous XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=17502
Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange
Tests: http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html
http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): We now only dispatch readystatechange event for synchronous requests in states UNSENT, OPENED and DONE. I'm not sure what exactly the spec draft says about readystatechange for sync requests, but this seems to be the most logical and backwards compatible behavior. (WebCore::XMLHttpRequest::didReceiveData): Don't dispatch progress events for sync requests. Note that we already don't dispatch upload progress events for those.
- 11:09 AM Changeset in webkit [63679] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
- platform/qt/Skipped: Add tests again until fix which were unskipped by r63657.
- 10:45 AM Changeset in webkit [63678] by
-
- 6 edits in trunk/LayoutTests
2010-07-19 Ojan Vafai <ojan@chromium.org>
Unreviewed. Update expectations from http://trac.webkit.org/changeset/63672
and cleanup some unexpected passes.
- platform/chromium-linux/fast/forms/hidden-listbox-expected.checksum:
- platform/chromium-linux/fast/forms/hidden-listbox-expected.png:
- platform/chromium-win/fast/forms/hidden-listbox-expected.checksum:
- platform/chromium-win/fast/forms/hidden-listbox-expected.png:
- platform/chromium/test_expectations.txt:
- 10:34 AM Changeset in webkit [63677] by
-
- 2 edits in trunk/WebKit2
2010-07-19 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Uae an OwnPtr for the drawing area in WebPage (fixes a leak!).
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::drawingArea):
- 10:26 AM Changeset in webkit [63676] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] refactor npapi plugin copy step
https://bugs.webkit.org/show_bug.cgi?id=42493
This is to avoid duplicate copy rules in the Linux make build.
- WebKit.gyp:
- DEPS: 52483:52869
- 10:19 AM Changeset in webkit [63675] by
-
- 3 edits in trunk/JavaScriptCore
2010-07-16 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Use OwnPtr for CodeBlock objects
https://bugs.webkit.org/show_bug.cgi?id=42490
- runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): Moved this here and made it non-inline. Eliminated the code that used to initialize the raw pointer since it's now an OwnPtr. (JSC::EvalExecutable::~EvalExecutable): Removed the explicit delete here. (JSC::ProgramExecutable::ProgramExecutable): Ditto. (JSC::ProgramExecutable::~ProgramExecutable): Ditto. (JSC::FunctionExecutable::FunctionExecutable): Ditto. (JSC::FunctionExecutable::~FunctionExecutable): Ditto. (JSC::EvalExecutable::compileInternal): Added use of adoptPtr and get. (JSC::ProgramExecutable::compileInternal): Ditto. (JSC::FunctionExecutable::compileForCallInternal): Ditto. (JSC::FunctionExecutable::compileForConstructInternal): Ditto. (JSC::FunctionExecutable::recompile): Use clear instead of delete followed by assignment of 0.
- runtime/Executable.h: Moved constructors to the cpp file and changed raw pointers to OwnPtr.
- 10:18 AM Changeset in webkit [63674] by
-
- 7 edits3 deletes in trunk/WebKitTools
2010-07-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63671.
http://trac.webkit.org/changeset/63671
https://bugs.webkit.org/show_bug.cgi?id=42575
broke windows (Requested by weinig on #webkit).
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Removed.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setWaitToDump): (WTR::displayCallback): (WTR::dumpAsTextCallback): (WTR::dumpStatusCallbacksCallback): (WTR::waitUntilDoneCallback): (WTR::notifyDoneCallback): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::repaintSweepHorizontallyCallback): (WTR::testRepaintCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): (WTR::LayoutTestController::dumpStatusCallbacks): (WTR::LayoutTestController::setDumpStatusCallbacks): (WTR::LayoutTestController::setTestRepaint): (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 10:13 AM Changeset in webkit [63673] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix eol-style propety for the following file, otherwise svn-apply will fail.
https://bugs.webkit.org/show_bug.cgi?id=42573
- canvas/philip/tests.js: Added property svn:eol-style.
- 9:48 AM Changeset in webkit [63672] by
-
- 4 edits8 adds in trunk
<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
https://bugs.webkit.org/show_bug.cgi?id=34913
Reviewed by Simon Fraser.
WebCore:
Tests: fast/repaint/view-background-from-body-1.html
fast/repaint/view-background-from-body-2.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.
LayoutTests:
- fast/repaint/view-background-from-body-1.html: Added.
- fast/repaint/view-background-from-body-2.html: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
- platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
- platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
- 9:43 AM Changeset in webkit [63671] by
-
- 7 edits8 adds in trunk/WebKitTools
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
Reviewed by Adam Roben.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/DerivedSources.make: Added.
- WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
- WebKitTestRunner/InjectedBundle/Bindings: Added.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 9:39 AM Changeset in webkit [63670] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
fix chromium linux compile on ubuntu maverick
https://bugs.webkit.org/show_bug.cgi?id=42528
- Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
- 9:23 AM Changeset in webkit [63669] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-19 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Live edit is not working in chromium.
https://bugs.webkit.org/show_bug.cgi?id=42572
- src/js/DebuggerScript.js:
- 9:21 AM Changeset in webkit [63668] by
-
- 4 edits in trunk/WebKitTools
When dumping a response's MIME type, print its URL's last path component rather than its suitable-for-test-result form
This matches the Mac behavior.
Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows
Reviewed by Anders Carlsson.
- DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.
- 9:21 AM Changeset in webkit [63667] by
-
- 2 edits in trunk/WebCore
Fix an assertion when a plugin returns -1 from NPP_Write
We were forgetting to call setDefersLoading(false) before destroying
the PluginStream. In the process of destroying the stream, someone
would call setDefersLoading(true), and we would assert because we were
already deferring loads.
Fixes <http://webkit.org/b/42563> Assertion failure in
ResourceHandle::setDefersLoading when running
plugins/return-negative-one-from-write.html on Windows
Reviewed by Anders Carlsson.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::deliverData): Call setDefersLoading(false)
before destroying the stream, to match the setDefersLoading(true) call
earlier in this function. (We already call setDefersLoading(false) in
the non-error case later on.)
- 9:06 AM Changeset in webkit [63666] by
-
- 2 edits in trunk/WebCore
2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Fix some EFL theme issues
https://bugs.webkit.org/show_bug.cgi?id=42569
Keep a pointer to theme filename and check for it correctly.
Reduce the scope of some variables.
Don't test for platformWidget() since we are not using it.
No new tests, no new functionality.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyCursor): (WebCore::Widget::setCursor):
- 8:52 AM Changeset in webkit [63665] by
-
- 2 edits in trunk/WebCore
2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add ifdef to compile code just on presence of Ecore_X
https://bugs.webkit.org/show_bug.cgi?id=42567
No new tests since there's no new functionality.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::setEvasObject): Add #ifdef HAVE_ECORE_X to it.
- 8:29 AM Changeset in webkit [63664] by
-
- 19 edits2 copies in trunk
WebKit2 does not have application cache
https://bugs.webkit.org/show_bug.cgi?id=42552
Reviewed by Adam Roben.
WebKit2:
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add SetApplicationCacheDirectory.
- Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
add offlineWebApplicationCacheEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetOfflineWebApplicationCacheEnabled):
(WKPreferencesGetOfflineWebApplicationCacheEnabled):
- UIProcess/API/C/WKPreferences.h:
Add getters/setters for whether the application cache is enabled.
- UIProcess/WebContext.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setOfflineWebApplicationCacheEnabled):
Update the store and call update().
- UIProcess/WebPreferences.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
Ask the web process to set the application cache directory.
- UIProcess/mac/WebContextMac.mm: Added.
(WebKit::WebContext::applicationCacheDirectory):
Return the application cache directory.
- UIProcess/win/WebContextWin.cpp: Added.
(WebKit::WebContext::applicationCacheDirectory):
Ditto.
- WebKit2.xcodeproj/project.pbxproj:
Add WebContextMac.mm
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
(WebKit::WebPage::didReceiveMessage):
Handle PreferencesDidChange. Get rid of the default: case statement so we'll
get warnings if we have unhandled message kinds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setApplicationCacheDirectory):
Set the application cache directory.
(WebKit::WebProcess::didReceiveMessage):
Handle SetApplicationCacheDirectory.
win/WebKit2.vcproj:
Add WebContextWin.cpp
WebKitTools:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.
(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.
- WebKitTestRunner/TestInvocation.h:
LayoutTests:
- platform/mac-wk2/Skipped:
Remove http/tests/appcache from skipped list.
- 8:23 AM Changeset in webkit [63663] by
-
- 5 edits in trunk
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[chromium] inspector/console-trace.html failing on windows after r63548
https://bugs.webkit.org/show_bug.cgi?id=42485
- inspector/console-trace.html: call dumpConsoleMessages sycnhronously right after console.trace
- platform/chromium/test_expectations.txt:
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add/removeStyleClass shouldn't increase number of spaces between class names.
https://bugs.webkit.org/show_bug.cgi?id=42485
- inspector/front-end/utilities.js: (Element.prototype.removeStyleClass):
- 8:19 AM Changeset in webkit [63662] by
-
- 15 edits in trunk/WebCore
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show stack trace for uncaught exceptions when Web Inspector is open.
https://bugs.webkit.org/show_bug.cgi?id=42560
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/v8/ScriptController.h:
- bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
- bindings/v8/V8ConsoleMessage.h:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype.toString):
- inspector/front-end/inspector.css: (.console-message.repeated-message > ol.stack-trace): (.section .properties ol, .event-properties ol, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.section .properties ol.expanded, .event-properties ol.expanded, .stack-trace ol, ol.stack-trace):
- page/Console.cpp: (WebCore::Console::addMessage):
- page/Console.h: (WebCore::):
- 8:12 AM Changeset in webkit [63661] by
-
- 2 edits in trunk/WebKitTools
2010-07-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Roben.
Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Specifying python explicitly.
- 8:05 AM Changeset in webkit [63660] by
-
- 2 edits in trunk/WebCore
2010-07-19 Robin Burchell <robin.burchell@collabora.co.uk>
Reviewed by Antonio Gomes
[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.
Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: https://bugs.webkit.org/show_bug.cgi?id=42392
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
- 7:52 AM Changeset in webkit [63659] by
-
- 4 edits in trunk/WebCore
2010-07-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check
https://bugs.webkit.org/show_bug.cgi?id=42284
New name is isEquivalentColor(CanvasStyle).
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle):
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
- html/canvas/CanvasStyle.h:
- 7:50 AM Changeset in webkit [63658] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Remove non-existent files from Skipped list.
- platform/qt/Skipped:
- Unskip fast/dynamic/flash-replacement-test.html, because it was removed by r61289
- Rename fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2.html after r63284
- Unskip inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r63314
- Unskip media/video-src-empty.html, because it was removed by r63119
- 7:27 AM Changeset in webkit [63657] by
-
- 5 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510
Unskip:
- canvas/philip/tests/2d.shadow.canvas.alpha.html
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- canvas/philip/tests/2d.shadow.canvas.transparent.2.html
- canvas/philip/tests/2d.shadow.image.alpha.html
- canvas/philip/tests/2d.shadow.image.transparent.1.html
- canvas/philip/tests/2d.shadow.image.transparent.2.html
- platform/qt/Skipped:
- 7:24 AM Changeset in webkit [63656] by
-
- 4 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508
Unskip:
- canvas/philip/tests/2d.shadow.canvas.basic.html
Reskip (bug now exposed):
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- platform/qt/Skipped:
- 7:12 AM Changeset in webkit [63655] by
-
- 1 edit45 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add platform specific expected results for new passing SVG tests.
Compared to Mac png files and Mac expected files.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
- platform/qt/svg/custom/convolution-crash-expected.checksum: Added.
- platform/qt/svg/custom/convolution-crash-expected.png: Added.
- platform/qt/svg/custom/convolution-crash-expected.txt: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.checksum: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.png: Added.
- platform/qt/svg/custom/marker-child-changes-css-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt.
- platform/qt/svg/custom/recursive-gradient-expected.checksum: Added.
- platform/qt/svg/custom/recursive-gradient-expected.png: Added.
- platform/qt/svg/custom/recursive-gradient-expected.txt: Added.
- platform/qt/svg/custom/recursive-mask-expected.checksum: Added.
- platform/qt/svg/custom/recursive-mask-expected.png: Added.
- platform/qt/svg/custom/recursive-mask-expected.txt: Added.
- platform/qt/svg/custom/recursive-pattern-expected.checksum: Added.
- platform/qt/svg/custom/recursive-pattern-expected.png: Added.
- platform/qt/svg/custom/recursive-pattern-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.png: Added.
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.png: Added.
- platform/qt/svg/custom/relative-sized-inner-svg-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
- platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.checksum: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.png: Added.
- platform/qt/svg/custom/text-rotated-gradient-expected.txt: Added.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.checksum.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt.
- platform/qt/svg/filters/filter-empty-g-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.checksum.
- platform/qt/svg/filters/filter-empty-g-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
- platform/qt/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
- platform/qt/svg/filters/filter-width-update-expected.checksum: Added.
- platform/qt/svg/filters/filter-width-update-expected.png: Added.
- platform/qt/svg/filters/filter-width-update-expected.txt: Added.
- 7:08 AM Changeset in webkit [63654] by
-
- 4 edits in trunk
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973
Remove erroneous optimization that ignored painting calls when
the stroke/fill color had an alpha value of zero.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973
Unskip fast/canvas/canvas-composite-alpha.html
- platform/qt/Skipped:
- 7:06 AM Changeset in webkit [63653] by
-
- 3 edits1 add in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
CSS3 background: Number of layers should be determined by background-image element count
https://bugs.webkit.org/show_bug.cgi?id=41201
Manual test: css3-background-layer-count.html
- manual-tests/css3-background-layer-count.html: Added.
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): Don't repeat image properties, they determine the total number of layers. (WebCore::FillLayer::cullEmptyLayers): Change culling logic to discard all layers after the first one without an image set.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): Call fillUnsetProperties() before cullEmptyLayers() (WebCore::InheritedFlags::adjustMaskLayers): Ditto.
- 5:45 AM Changeset in webkit [63652] by
-
- 2 edits in trunk/WebCore
2010-07-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid QImage::pixel() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=42463
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Use QImage::scanLine() instead of fetching data pixel-by-pixel.
- 5:43 AM Changeset in webkit [63651] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-19 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix build on 64-bit systems. According to
JavaScriptCore/wtf/Platform.h, x86_64 uses fixed allocator, which
needs jit/ExecutableAllocatorFixedVMPool.cpp to be included in build
system.
https://bugs.webkit.org/show_bug.cgi?id=42559
- CMakeListsEfl.txt: add missing file for x86_64.
- 5:28 AM Changeset in webkit [63650] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] Fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=42556
text-rotated-gradient.svg is flaky on linux, and clip-path-child-changes.svg
isn't actually flaky.
- platform/chromium/test_expectations.txt:
- 5:17 AM Changeset in webkit [63649] by
-
- 2 edits in trunk/WebCore
2010-07-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: hide "toggle debugger" button when debugger is always enabled
https://bugs.webkit.org/show_bug.cgi?id=42558
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- 4:52 AM Changeset in webkit [63648] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-07-19 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
Remove chromium rebaselines for document.all layout test.
https://bugs.webkit.org/show_bug.cgi?id=42557
V8 changed behavior to match JSC completely on document.all. Remove
chromium rebaseline.
- platform/chromium-mac/fast/dom/undetectable-document-all-expected.txt: Removed.
- platform/chromium-win/fast/dom/undetectable-document-all-expected.txt: Removed.
- 3:54 AM Changeset in webkit [63647] by
-
- 2 edits in trunk/LayoutTests
2010-07-19 Kent Hansen <kent.hansen@nokia.com>
Unreviewed, fix failure introduced in r63645.
Ignore jscprint property since it only appears in
debug builds (as per window-property-descriptors test).
- fast/dom/Window/window-properties.html:
- 2:40 AM Changeset in webkit [63646] by
-
- 3 edits in trunk/WebCore
2010-07-19 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
https://bugs.webkit.org/show_bug.cgi?id=42466
(Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447)
No new functionality so no new tests.
- dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Move here to avoid needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h.
- dom/DeviceOrientationEvent.h:
- 1:23 AM Changeset in webkit [63645] by
-
- 5 edits in trunk/LayoutTests
2010-07-19 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Sam Weinig.
Improve coverage of fast/dom/Window/window-properties test
https://bugs.webkit.org/show_bug.cgi?id=42258
Use Object.getOwnPropertyNames to cover ECMA properties
and other native properties.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
Jul 18, 2010:
- 10:39 PM Changeset in webkit [63644] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Add more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42551
- platform/mac-wk2/Skipped:
- 10:16 PM Changeset in webkit [63643] by
-
- 2 edits in trunk/WebCore
Fix Build.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
- 9:51 PM Changeset in webkit [63642] by
-
- 2 edits in trunk/WebCore
Always set the current NSGraphicsContext before calling drawWithFrame
https://bugs.webkit.org/show_bug.cgi?id=42542
Reviewed by Dan Bernstein.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- 8:49 PM Changeset in webkit [63641] by
-
- 2 edits in trunk/WebKit/qt
2010-07-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebPage fails cursorMovements and textSelection
https://bugs.webkit.org/show_bug.cgi?id=42531
Correct the HTML used by these tests.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::textEditing):
- 6:10 PM Changeset in webkit [63640] by
-
- 2 edits in trunk/WebKit2
Another attempt at fixing the Windows build.
- WebProcess/Plugins/NPJSObjectMap.h:
- 5:13 PM Changeset in webkit [63639] by
-
- 2 edits in trunk/WebKit2
Try to fix Windows build.
- win/WebKit2.vcproj:
- 5:11 PM WebKit Team edited by
- (diff)
- 5:09 PM Changeset in webkit [63638] by
-
- 10 edits1 move1 delete in trunk
Move PluginWidget to WebKit
https://bugs.webkit.org/show_bug.cgi?id=42530
Reviewed by Sam Weinig.
WebCore:
Rename the PluginWidget class to PluginViewBase and make it an abstract base class.
This is a stopgap measure until we have a single PluginView class that we can use everywhere.
- WebCore.exp.in:
Remove PluginWidget symbols.
- WebCore.xcodeproj/project.pbxproj:
Update.
- platform/Widget.h:
(WebCore::Widget::isPluginViewBase):
Return false.
- plugins/PluginViewBase.h: Added.
(WebCore::PluginViewBase::platformLayer):
Always return 0 here now.
(WebCore::PluginViewBase::isPluginViewBase):
Return true.
- plugins/PluginWidget.h: Removed.
- plugins/mac/PluginWidgetMac.mm: Removed.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
Cast to PluginWidgetBase instead.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Cast to PluginWidgetBase instead.
WebKit/mac:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView pluginLayer]):
Add default pluginLayer implementation.
- WebCoreSupport/WebFrameLoaderClient.mm:
(PluginWidget::PluginWidget):
(PluginWidget::invalidateRect):
Move the guts of PluginWidget here from WebCore.
(NetscapePluginWidget::platformLayer):
Get the layer from the plug-in view.
- 4:45 PM WebKit Team edited by
- (diff)
- 3:55 PM Changeset in webkit [63637] by
-
- 2 edits in trunk/WebKit/qt
2010-07-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527
Correct the HTML used by these tests.
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::firstChildNextSibling): (tst_QWebElement::lastChildPreviousSibling):
- 3:27 PM Changeset in webkit [63636] by
-
- 5 edits in trunk/WebKit2
More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526
Reviewed by Sam Weinig.
- WebProcess/Plugins/NPJSObjectMap.cpp:
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
Check if the JSObject has the given property.
(WebKit::NPJSObject::getProperty):
Add stubbed out function.
(WebKit::NPJSObject::npClass):
Add NP_HasProperty and NP_GetProperty.
(WebKit::NPJSObject::NP_HasProperty):
Call NPJSObject::hasProperty.
(WebKit::NPJSObject::NP_GetProperty):
Call NPJSObject::getProperty.
- WebProcess/Plugins/NPRuntimeUtilities.cpp:
(WebKit::releaseNPVariantValue):
Release the given NPVariant.
- WebProcess/Plugins/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetProperty):
Call the NPClass GetProperty function.
(WebKit::NPN_HasProperty):
Call the NPClass HasProperty function.
(WebKit::NPN_ReleaseVariantValue):
Call releaseNPVariantValue.
- 3:25 PM Changeset in webkit [63635] by
-
- 3 edits in trunk/LayoutTests
2010-07-18 Dean Jackson <dino@apple.com>
Unreviewed (although this was discussed with SimonF in
original review).
Unfortunately the test in the previous commit is platform
specific (I was hoping it would not be) and is failing
the bots. This update exercises the same thing, but doesn't
check for exact values.
- fast/transforms/scrollIntoView-transformed-expected.txt:
- fast/transforms/scrollIntoView-transformed.html:
- 3:01 PM Changeset in webkit [63634] by
-
- 2 edits in trunk/WebCore
2010-07-18 Dean Jackson <dino@apple.com>
Unreviewed.
Remove the unwanted extra line that Xcode
added in my last commit.
- WebCore.xcodeproj/project.pbxproj:
- 2:55 PM Changeset in webkit [63633] by
-
- 5 edits2 adds in trunk
2010-07-18 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=41259
Interacting with a <select> element within a transformed and clipped
container scrolls the container
The Node::getRect and ContainerNode::getRect functions were not
transform-aware. This fixes both, and has a test to make sure
we're not breaking any existing scrollToView code. This means
that a <select> popup will appear in the correct place if it
is within a transformed and scrolled container.
The test makes sure that existing scrollToView
code doesn't break, but also checks that a <select> popup will appear
in the correct place.
Test: fast/transforms/scrollIntoView-transformed.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms.
- dom/Node.cpp: (WebCore::Node::getRect):
- make sure localToAbsolute gets told to look for transforms.
- 2:38 PM Changeset in webkit [63632] by
-
- 7 edits in trunk/WebKit/mac
<http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
Reviewed by Dan Bernstein.
- Carbon/CarbonWindowAdapter.mm:
(-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase init]):
- Misc/WebNSPasteboardExtras.mm:
(-[NSFilePromiseDragSource initWithSource:]):
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation init]):
- WebView/WebPreferences.mm:
(-[WebPreferences init]):
- WebView/WebView.mm:
(-[WebView UIDelegate]):
(-[WebView resourceLoadDelegate]):
(-[WebView downloadDelegate]):
(-[WebView policyDelegate]):
(-[WebView frameLoadDelegate]):
- 2:33 PM Changeset in webkit [63631] by
-
- 6 edits2 adds in trunk
Add NPJSObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=42524
Reviewed by Sam Weinig.
WebCore:
Export ScriptController functions.
- WebCore.exp.in:
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- WebProcess/Plugins/NPJSObjectMap.cpp: Added.
- WebProcess/Plugins/NPJSObjectMap.h: Added.
Add NPJSObjectMap, a map which contains NPObjects that wrap JavaScript objects.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Initialize the map.
(WebKit::PluginView::~PluginView):
Invalidate the map.
(WebKit::PluginView::frame):
Add frame getter.
(WebKit::PluginView::windowScriptNPObject):
Wrap the window object.
(WebKit::PluginView::pluginElementNPObject):
Wrap the plug-in element object.
- WebProcess/Plugins/PluginView.h:
- 12:44 PM Changeset in webkit [63630] by
-
- 3 edits2 adds in trunk/WebKit2
Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/NPRuntimeUtilities.cpp: Added.
- WebProcess/Plugins/NPRuntimeUtilities.h: Added.
Add new file with NPRuntime related utility functions.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_CreateObject):
(WebKit::NPN_RetainObject):
(WebKit::NPN_ReleaseObject):
Call the corresponding NPRuntimeUtilities functions.
- 11:57 AM Changeset in webkit [63629] by
-
- 7 edits in trunk/WebKit2
Begin work on NPRuntime support
https://bugs.webkit.org/show_bug.cgi?id=42519
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle NPNVWindowNPObject and NPNVPluginElementNPObject.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
Call the plug-in controller.
- WebProcess/Plugins/PluginController.h:
Add new windowScriptNPObject and pluginElementNPObject functions.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
Add stubbed out functions.
- 10:45 AM Changeset in webkit [63628] by
-
- 4 edits in trunk
Implement some NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42518
Reviewed by Dan Bernstein.
WebCore:
- WebCore.exp.in:
Export IdentifierRep functions.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetStringIdentifier):
(WebKit::NPN_GetStringIdentifiers):
(WebKit::NPN_GetIntIdentifier):
(WebKit::NPN_IdentifierIsString):
(WebKit::NPN_UTF8FromIdentifier):
(WebKit::NPN_IntFromIdentifier):
(WebKit::NPN_CreateObject):
- 10:01 AM Changeset in webkit [63627] by
-
- 10 edits in trunk
Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516
Reviewed by Dan Bernstein.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add setStatusbarText callback to WKBundlePageUIClient.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::setStatusbarText):
Call setStatusbarText.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setStatusbarText):
Call the bundle page UI client.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.
(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.
(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.
- 9:32 AM Changeset in webkit [63626] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[V8] Web Inspector: get actual breakpoint location from v8 and pass it
to ScripDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=42452
- src/js/DebuggerScript.js:
- 7:35 AM Changeset in webkit [63625] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium: fixed one more expectation to
reflect changes in r63616.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [63624] by
-
- 2 edits in trunk/LayoutTests
2010-07-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium: fixed test expectations (reflected changes
in r63616).
- platform/chromium/test_expectations.txt:
Jul 17, 2010:
- 7:33 PM Changeset in webkit [63623] by
-
- 5 edits in trunk/LayoutTests
2010-07-17 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Simon Hausmann.
Import new version of 2d.pattern.image.string.html from Philip Taylor.
The original test was buggy and we now pass it.
- canvas/philip/tests/2d.pattern.image.string-expected.txt:
- canvas/philip/tests/2d.pattern.image.string.html:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 6:59 PM Changeset in webkit [63622] by
-
- 2 edits in trunk/WebCore
2010-07-17 TJ Lee <tjlee0909@gmail.com>
Reviewed by Timothy Hatcher.
HTMLLinkElement ignores dnsPrefetchingEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=42500
Changed the HTML Link tag to check that the browser
has DNS-prefetching enabled before calling ResourceHandle::prepareForURL.
There are no test cases for this patch because it was unclear how to test
this using a layout test. A possible test case would be to
clear the DNS cache on the client's machine before loading a page with
<link rel="dns-prefetch" href="SomeSiteThatsNotTheCurrentOne.com"> and
then check the number of DNS cache entries.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- 6:39 PM Changeset in webkit [63621] by
-
- 14 edits in trunk
WebKit2: WebKitTestRunner should load the test plug-in
https://bugs.webkit.org/show_bug.cgi?id=42509
Reviewed by Maciej Stachowiak.
- UIProcess/API/C/WKContext.cpp:
(_WKContextSetAdditionalPluginPath):
Add a private function for setting a single additional plug-in path. the WebKit1 SPI that does the
same thing takes an array of paths, but this is good enough for now.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::setAdditionalPluginPaths):
Set the additional plug-in paths vector and refresh the database.
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
First try to load plug-ins in the additional plug-in paths.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setAdditionalPluginPath):
Call PluginInfoStore::setAdditionalPluginPaths.
- UIProcess/WebContext.h:
(WebKit::WebContext::pluginInfoStore):
Make the plug-in info store per context instead of having a single shared info store.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPlugins):
(WebKit::WebProcessProxy::getPluginHostConnection):
- UIProcess/WebProcessProxy.h:
Get the plug-in info store from the context.
WebKitTools: * WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Get the test plug-in path and set it on the context.
Reviewed by Maciej Stachowiak.
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::initializeInjectedBundlePath):
Simplify this code by using NSBundle.
(WTR::TestController::testPluginPath):
Return the test plug-in path.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::testPluginPath):
Ditto.
- 5:15 PM Changeset in webkit [63620] by
-
- 3 edits in trunk/WebCore
2010-07-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Asynchronous policy checks make FrameLoader think it is done loading prematurely
https://bugs.webkit.org/show_bug.cgi?id=42489
This caused many (~100) layout tsts to fail under WebKit2.
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe): Right after loading a new subframe, if m_complete is true, do not consider it done if it has a provisional loader. This will happen in the case where the policy check is asynchronous.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::subframeIsLoading): For similar reasons, consider a subframe to be loading if it has a policy decision pending.
- 5:11 PM Changeset in webkit [63619] by
-
- 2 edits in trunk/LayoutTests
2010-07-17 Andreas Kling <andreas.kling@nokia.com>
[Qt] Reskip 2d.path.quadraticCurveTo.scaled.html
This test fails with the Qt version running on the bot.
- platform/qt/Skipped:
- 4:48 PM Changeset in webkit [63618] by
-
- 2 edits in trunk/LayoutTests
Another attempt at fixing this test.
- plugins/npruntime/browser-object-identity.html:
- 3:11 PM Changeset in webkit [63617] by
-
- 2 edits in trunk/LayoutTests
2010-07-17 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Unskipped two canvas tests that are passing
- canvas/philip/tests/2d.path.arc.twopie.3.html
- canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html
- platform/qt/Skipped:
- 2:51 PM Changeset in webkit [63616] by
-
- 4 edits13 moves5 deletes in trunk/LayoutTests
Move platform specific plug-ins to platform/
https://bugs.webkit.org/show_bug.cgi?id=42506
Reviewed by Sam Weinig.
- platform/gtk/Skipped:
- platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Removed.
- platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Removed.
- platform/mac/plugins/call-as-function-test-expected.txt: Renamed from LayoutTests/plugins/call-as-function-test-expected.txt.
- platform/mac/plugins/call-as-function-test.html: Renamed from LayoutTests/plugins/call-as-function-test.html.
- platform/mac/plugins/jsobjc-dom-wrappers-expected.txt: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers-expected.txt.
- platform/mac/plugins/jsobjc-dom-wrappers.html: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers.html.
- platform/mac/plugins/jsobjc-simple-expected.txt: Renamed from LayoutTests/plugins/jsobjc-simple-expected.txt.
- platform/mac/plugins/jsobjc-simple.html: Renamed from LayoutTests/plugins/jsobjc-simple.html.
- platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Removed.
- platform/mac/plugins/qt-qwidget-plugin-expected.png: Removed.
- platform/mac/plugins/qt-qwidget-plugin-expected.txt: Removed.
- platform/mac/plugins/root-object-premature-delete-crash-expected.txt: Renamed from LayoutTests/plugins/root-object-premature-delete-crash-expected.txt.
- platform/mac/plugins/root-object-premature-delete-crash.html: Renamed from LayoutTests/plugins/root-object-premature-delete-crash.html.
- platform/mac/plugins/throw-on-dealloc-expected.txt: Renamed from LayoutTests/plugins/throw-on-dealloc-expected.txt.
- platform/mac/plugins/throw-on-dealloc.html: Renamed from LayoutTests/plugins/throw-on-dealloc.html.
- platform/mac/plugins/undefined-property-crash-expected.txt: Renamed from LayoutTests/plugins/undefined-property-crash-expected.txt.
- platform/mac/plugins/undefined-property-crash.html: Renamed from LayoutTests/plugins/undefined-property-crash.html.
- platform/qt/Skipped:
- platform/qt/plugins/qt-qwidget-plugin.html: Renamed from LayoutTests/plugins/qt-qwidget-plugin.html.
- platform/win/Skipped:
- 2:44 PM Changeset in webkit [63615] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed build system cleanup.
Patch by Leandro Pereira <leandro@profusion.mobi> on 2010-07-16
Remove reference to "mediaControlsGtk.css".
- cmake/WebKitGenerators.cmake:
- 2:32 PM Changeset in webkit [63614] by
-
- 4 edits in trunk
2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400
FillRect with shadow need take alpha information from fillstyle
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400
Remove the following test case from Skipped:
canvas/philip/tests/2d.shadow.alpha.5.html
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.transparent.1.html
canvas/philip/tests/2d.shadow.image.scale.html
canvas/philip/tests/2d.shadow.pattern.alpha.html
canvas/philip/tests/2d.shadow.pattern.transparent.1.html
- platform/qt/Skipped:
- 2:21 PM Changeset in webkit [63613] by
-
- 4 edits34 moves3 adds1 delete in trunk/LayoutTests
Move NPRuntime related tests to plugins/npruntime
https://bugs.webkit.org/show_bug.cgi?id=42505
Reviewed by Dan Bernstein.
- platform/gtk/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/win/Skipped:
Update skipped lists.
- plugins/netscape-identifier-conversion.html: Removed.
- plugins/npruntime/bindings-test-expected.txt: Renamed from LayoutTests/plugins/bindings-test-expected.txt.
- plugins/npruntime/bindings-test.html: Renamed from LayoutTests/plugins/bindings-test.html.
- plugins/npruntime/browser-object-identity-expected.txt: Renamed from LayoutTests/plugins/netscape-browser-object-identity-expected.txt.
- plugins/npruntime/browser-object-identity.html: Renamed from LayoutTests/plugins/netscape-browser-object-identity.html.
- plugins/npruntime/construct-expected.txt: Renamed from LayoutTests/plugins/netscape-construct-expected.txt.
- plugins/npruntime/construct.html: Renamed from LayoutTests/plugins/netscape-construct.html.
- plugins/npruntime/embed-property-expected.txt: Renamed from LayoutTests/plugins/embed-property-expected.txt.
- plugins/npruntime/embed-property.html: Renamed from LayoutTests/plugins/embed-property.html.
- plugins/npruntime/enumerate-expected.txt: Renamed from LayoutTests/plugins/netscape-enumerate-expected.txt.
- plugins/npruntime/enumerate.html: Renamed from LayoutTests/plugins/netscape-enumerate.html.
- plugins/npruntime/get-int-identifier-special-values-expected.txt: Renamed from LayoutTests/plugins/getintidentifier-special-values-expected.txt.
- plugins/npruntime/get-int-identifier-special-values.html: Renamed from LayoutTests/plugins/getintidentifier-special-values.html.
- plugins/npruntime/get-property-return-value-expected.txt: Renamed from LayoutTests/plugins/netscape-get-property-return-value-expected.txt.
- plugins/npruntime/get-property-return-value.html: Renamed from LayoutTests/plugins/netscape-get-property-return-value.html.
- plugins/npruntime/identifier-conversion-expected.txt: Renamed from LayoutTests/plugins/netscape-identifier-conversion-expected.txt.
- plugins/npruntime/identifier-conversion.html: Renamed from LayoutTests/plugins/netscape-identifier-conversion.html.
- plugins/npruntime/invoke-browserfuncs-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs-expected.txt.
- plugins/npruntime/invoke-browserfuncs.html: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs.html.
- plugins/npruntime/invoke-default-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-default-expected.txt.
- plugins/npruntime/invoke-default.html: Renamed from LayoutTests/plugins/netscape-invoke-default.html.
- plugins/npruntime/invoke-expected.txt: Renamed from LayoutTests/plugins/invoke-expected.txt.
- plugins/npruntime/invoke-failure-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-failure-expected.txt.
- plugins/npruntime/invoke-failure.html: Renamed from LayoutTests/plugins/netscape-invoke-failure.html.
- plugins/npruntime/invoke.html: Renamed from LayoutTests/plugins/invoke.html.
- plugins/npruntime/npruntime-expected.txt: Renamed from LayoutTests/plugins/npruntime-expected.txt.
- plugins/npruntime/npruntime.html: Renamed from LayoutTests/plugins/npruntime.html.
- plugins/npruntime/round-trip-npobject-expected.txt: Renamed from LayoutTests/plugins/round-trip-npobject-expected.txt.
- plugins/npruntime/round-trip-npobject.html: Renamed from LayoutTests/plugins/round-trip-npobject.html.
- plugins/npruntime/script-tests/TEMPLATE.html: Renamed from LayoutTests/plugins/script-tests/TEMPLATE.html.
- plugins/npruntime/script-tests/browser-object-identity.js: Renamed from LayoutTests/plugins/script-tests/netscape-browser-object-identity.js.
(description.gc):
- plugins/npruntime/script-tests/identifier-conversion.js: Renamed from LayoutTests/plugins/script-tests/netscape-identifier-conversion.js.
- plugins/npruntime/set-property-expected.txt: Renamed from LayoutTests/plugins/setProperty-expected.txt.
- plugins/npruntime/set-property.html: Renamed from LayoutTests/plugins/setProperty.html.
- plugins/npruntime/throw-exception-expected.txt: Renamed from LayoutTests/plugins/netscape-throw-exception-expected.txt.
- plugins/npruntime/throw-exception.html: Renamed from LayoutTests/plugins/netscape-throw-exception.html.
- 1:47 PM Changeset in webkit [63612] by
-
- 4 edits in trunk/WebKit2
Stop all NPStreams before destroying a plug-in
https://bugs.webkit.org/show_bug.cgi?id=42504
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::stopAllStreams):
Go through all streams and stop them.
(WebKit::NetscapePlugin::destroy):
Call stopAllStreams.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add stopAllStreams.
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
Make stop public.
- 1:20 PM Changeset in webkit [63611] by
-
- 3 edits in trunk/WebKit2
Open streams should not keep a plug-in view alive
https://bugs.webkit.org/show_bug.cgi?id=42503
Reviewed by Dan Bernstein.
PluginView::Stream now has a weak reference to its PluginView.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::~Stream):
Assert that the plug-in view is null.
(WebKit::PluginView::Stream::didFail):
After calling removeStream, set the plug-in view member variable to 0. This is OK to do
since we keep a reference to the Stream, so we're sure that the call to removeStream does not
destroy the stream.
(WebKit::PluginView::Stream::didFinishLoading):
Ditto .
(WebKit::PluginView::~PluginView):
Cancel all streams.
(WebKit::PluginView::cancelAllStreams):
Cancel all streams.
- 11:11 AM Changeset in webkit [63610] by
-
- 2 edits in trunk/LayoutTests
2010-07-17 John Gregg <johnnyg@google.com>
Unreviewed, updating test expectations.
[chromium] Updating the expecations for input-file-directory-upload.html
https://bugs.webkit.org/show_bug.cgi?id=42419
- platform/chromium/test_expectations.txt:
- 10:04 AM Changeset in webkit [63609] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-17 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
[chromium] directory upload: pass the attribute up to the chrome client
https://bugs.webkit.org/show_bug.cgi?id=42475
This allows chromium to display the native system directory picker when
the directory attribute is present on the input element.
- public/WebFileChooserParams.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel):
- 8:43 AM Applications using WebKit edited by
- Added Surf and Tom thought the alphabet started with T (diff)
- 8:08 AM HackingWebInspector edited by
- Typos (diff)
- 4:51 AM Changeset in webkit [63608] by
-
- 2 edits in trunk/WebCore
2010-07-17 Nikita Vasilyev <me@elv1s.ru>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Edit long CSS attributes works incorrect
https://bugs.webkit.org/show_bug.cgi?id=42476
- inspector/front-end/inspector.css: (.editing):
Jul 16, 2010:
- 9:53 PM Changeset in webkit [63607] by
-
- 5 edits in trunk
2010-07-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Sam Weinig.
Failing 2d.path.arcTo.ensuresubpath.* philip canvas tests
https://bugs.webkit.org/show_bug.cgi?id=42186
Unskip tests:
- canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html
- canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html
- platform/mac/Skipped:
2010-07-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Sam Weinig.
Failing 2d.path.arcTo.ensuresubpath.* philip canvas tests
https://bugs.webkit.org/show_bug.cgi?id=42186
Move code from Qt's Path::addArcTo() up to CanvasRenderingContext2D.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): Behave as moveTo(x1,y1) if the current path is empty.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): Remove now-redundant code.
- 8:23 PM Changeset in webkit [63606] by
-
- 6 edits in trunk/WebCore
2010-07-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
QtWebkit creates an unnecessary deep copy of images when canvas drawing is done
A https://bugs.webkit.org/show_bug.cgi?id=32530
Solve this by adding ImageBuffer::imageForRendering() which returns an image
that can be used for rendering now, but isn't a copy to be kept around.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::imageForRendering):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::imageForRendering): Added to provide an image that can be used for rendering now, but may change in the future.
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::StillImage): (WebCore::StillImage::~StillImage): (WebCore::StillImage::size): (WebCore::StillImage::nativeImageForCurrentFrame): (WebCore::StillImage::draw):
- platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::createForRendering): Added for use in ImageBuffer::imageForRendering(), provides a thin wrapper around a QPixmap*.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Paint with ImageBuffer::imageForRendering()
- 8:19 PM Changeset in webkit [63605] by
-
- 2 edits in trunk/WebCore
2010-07-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
[Qt] Remove redundant logic in Path::addArcTo()
https://bugs.webkit.org/show_bug.cgi?id=42494
Bounds checking for arcTo() is now done in cross-platform code
thanks to <http://trac.webkit.org/changeset/63599>
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
- 7:48 PM Changeset in webkit [63604] by
-
- 2 edits in trunk/WebKitTools
2010-07-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach webkitpy about queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=42492
- Scripts/webkitpy/common/net/statusserver.py:
- 6:23 PM Changeset in webkit [63603] by
-
- 2 edits5 adds in trunk/LayoutTests
2010-07-16 Nico Weber <thakis@chromium.org>
Reviewed by Ojan Vafai.
Add chromium/win and linux expectations for fast/canvas/toDataUrl-alpha.
- platform/chromium-linux/fast/canvas/toDataURL-alpha-expected.checksum: Added.
- platform/chromium-linux/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/chromium-win/fast/canvas/toDataURL-alpha-expected.checksum: Added.
- platform/chromium-win/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/chromium-win/fast/canvas/toDataURL-alpha-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:05 PM Changeset in webkit [63602] by
-
- 31 edits in trunk
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
This patch just reverts the change to WebCore/page/FocusController.cpp
made in changeset 61484, and add a new method named
willSetInputMethodState in EditorClient interface, which gets called
in FocusController just before changing the focused node.
No new tests, because no new functionality.
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::willSetInputMethodState):
- page/EditorClient.h:
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::willSetInputMethodState):
- efl/WebCoreSupport/EditorClientEfl.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Implement EditorClient::willSetInputMethodState which replaces
setInputMethodState method.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::willSetInputMethodState): (WebKit::EditorClientImpl::setInputMethodState):
- src/EditorClientImpl.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::willSetInputMethodState):
- WebCoreSupport/EditorClientGtk.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::willSetInputMethodState):
- WebCoreSupport/EditorClientHaiku.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::willSetInputMethodState):
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::willSetInputMethodState):
- WebCoreSupport/EditorClientQt.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::willSetInputMethodState):
- WebCoreSupport/WebEditorClient.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::willSetInputMethodState):
- WebKitSupport/EditorClientWx.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::willSetInputMethodState):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 5:34 PM Changeset in webkit [63601] by
-
- 2 edits in trunk/LayoutTests
2010-07-16 Tony Chang <tony@chromium.org>
Not reviewed, updating test expectations.
[chromium] clean up test expectations
https://bugs.webkit.org/show_bug.cgi?id=42491
- platform/chromium/test_expectations.txt: fast/dynamic/flash-replacement-test.html doesn't exist and svg/filters/filter-empty-g.svg is a duplicate on Linux.
- 5:27 PM Changeset in webkit [63600] by
-
- 2 edits in trunk/WebKit2
Build fix, not reviewed.
Reverted http://trac.webkit.org/changeset/63585 because getopt isn't
available in the OpenSource support libraries
- WebKit2.sln:
- 5:08 PM Changeset in webkit [63599] by
-
- 13 edits in trunk
2010-07-16 Matthew Delaney <mdelaney@apple.com>
Reviewed by Sam Weinig.
Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188
- platform/mac/Skipped: Unskipped now passing tests.
2010-07-16 Matthew Delaney <mdelaney@apple.com>
Reviewed by Sam Weinig.
Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188
- html/canvas/CanvasRenderingContext2D.cpp: Note, updated parameter names to match spec. (WebCore::CanvasRenderingContext2D::lineTo): Pulled bound checking code out of lower code to have checks for all platforms. (WebCore::CanvasRenderingContext2D::arcTo): Bound checking per the spec for arcTo parameters. Updated parameter names to match spec.
- platform/graphics/Path.h: Added in new method to expose the current position.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::currentPoint): Added in likely correct implementation for this call with a FIXME just in case.
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::currentPoint): Added in support for this call.
- platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
- platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::currentPoint): Added in likely implementation for this call with a FIXME just in case.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::currentPoint): Added in implementation for this call courtesy of Andrea Kling.
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
- platform/graphics/wince/PathWince.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
- 4:43 PM Changeset in webkit [63598] by
-
- 3 edits10 deletes in trunk
2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63593.
http://trac.webkit.org/changeset/63593
https://bugs.webkit.org/show_bug.cgi?id=42487
Broke a few chromium pixel tests (Requested by tonywork on
#webkit).
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
- svg/stroke/path-zero-strokewidth-test.svg: Removed.
2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63593.
http://trac.webkit.org/changeset/63593
https://bugs.webkit.org/show_bug.cgi?id=42487
Broke a few chromium pixel tests (Requested by tonywork on
#webkit).
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 4:18 PM Changeset in webkit [63597] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Alice Liu.
Fix Windows build.
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
- 4:11 PM Changeset in webkit [63596] by
-
- 2 edits in trunk/LayoutTests
2010-07-16 Ojan Vafai <ojan@chromium.org>
Unreviewed. Update expectations with new failures.
- platform/chromium/test_expectations.txt:
- 4:03 PM Changeset in webkit [63595] by
-
- 7 edits in trunk
Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
https://bugs.webkit.org/show_bug.cgi?id=29355
Reviewed by Sam Weinig.
WebCore:
- WebCore.exp.in: Updated.
- platform/graphics/Font.cpp:
(WebCore::Font::Font): Added a font smoothing mode parameter to the constructor.
Set the font smoothing mode in the font description.
- platform/graphics/Font.h:
WebKit/mac:
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
-_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
parameter.
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
mode to antialiased. Otherwise, sets it to auto.
(-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
changing the font smoothing setting in the graphics context, call
-_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
parameter.
- 3:59 PM Changeset in webkit [63594] by
-
- 3 edits in trunk/WebCore
2010-07-16 Satish Sampath <satish@chromium.org>
Reviewed by Anders Carlsson.
Add speech attribute to IDL for enabling access from JS.
https://bugs.webkit.org/show_bug.cgi?id=42483
No tests added, this change is a pre-requisite for future layout tests.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Update the renderer when speech attribute changes.
- html/HTMLInputElement.idl: Added the speech attribute to IDL.
- 3:42 PM Changeset in webkit [63593] by
-
- 3 edits14 adds in trunk
2010-07-16 Fady Samuel <fsamuel@chromium.org>
Reviewed by David Levin.
Added layout test to show correct zero-width stroke.
SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
- platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
- platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
- platform/mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
- svg/stroke/path-zero-strokewidth-test.svg: Added.
2010-07-16 Fady Samuel <fsamuel@chromium.org>
Reviewed by David Levin.
Avoids adding stroke when stroke-width is zero.
SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387
Test: svg/stroke/path-zero-strokewidth-test.svg
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 3:29 PM Changeset in webkit [63592] by
-
- 2 edits in trunk/WebCore
2010-07-16 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::getThemeData): Fix a typo.
- 3:21 PM Changeset in webkit [63591] by
-
- 2 edits in trunk/WebKit/mac
Remove semicolons from Objective-C method declarations.
Reviewed by Sam Weinig.
- WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]):
(+[WebRenderLayer compositingInfoForLayer:]):
- 3:20 PM Changeset in webkit [63590] by
-
- 10 edits in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
<rdar://problem/8197701>
Add notification of when the BackForwardList changes
to aid invalidation of Back/Forward related UI elements.
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKPage.h:
Add didChangeBackForwardList to the WKPageLoaderClient. This
fires whenever an item is added or removed from the back forward
list or when the cursor changes position.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/WebPageProxy.h:
Pipe changes to the WebBackForwardList up to the page load client.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(_didStartProvisionalLoadForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didChangeBackForwardList):
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 3:05 PM Changeset in webkit [63589] by
-
- 10 edits in trunk
2010-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259
No additional tests. Existing tests cover this change and we'll
update expectations.
- platform/chromium/ChromiumBridge.h: Add paintSpinButton().
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineState): Add ControlSubPart parameter and add support for spin buttons. (WebCore::RenderThemeChromiumWin::determineClassicState): ditto. (WebCore::RenderThemeChromiumWin::getThemeData): ditto. (WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle): Added. (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): Added.
- rendering/RenderThemeChromiumWin.h: Declare ControlSubpart, and add it to some functions.
2010-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259
- public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintSpinButton): Added.
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintSpinButton): Added. It calls WebThemeEngine::paintSpinButton().
2010-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259
- DumpRenderTree/chromium/WebThemeEngineDRT.cpp: (WebThemeEngineDRT::paintSpinButton): Added. Check state consistency and use existing arrow painting code.
- DumpRenderTree/chromium/WebThemeEngineDRT.h:
- 3:03 PM Changeset in webkit [63588] by
-
- 2 edits in trunk/WebCore
2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Use function provided by EFL for system beep
https://bugs.webkit.org/show_bug.cgi?id=42481
EFL port does not support automated tests, yet.
- platform/efl/SoundEfl.cpp: (WebCore::systemBeep):
- 2:49 PM Changeset in webkit [63587] by
-
- 2 edits in trunk/WebCore
2010-07-16 Sarah Strong <sarah.e.strong@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Clipboard data is lost on exit
https://bugs.webkit.org/show_bug.cgi?id=27411
No new tests. To manually test the bug fixed by this patch:
1) Open an application that uses a webkit webview on a GNOME-based system
2) Copy some text from that application
3) Optional: paste it to another application. This should work properly with and without this patch.
4) Exit the application completely.
5) Paste:
Without this patch, you cannot because your clipboard is empty.
With this patch, pasting succeeds.
I have not included an automated test because of the difficulty of testing behaviour after application exit.
- 2:40 PM Changeset in webkit [63586] by
-
- 4 edits3 adds in trunk
Keyboard operations for <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42076
Reviewed by Darin Fisher.
WebCore:
- The up arrow key works as stepUp().
- The down arrow key works as stepDown().
- Reject characters other than + - 0-9 . e E
Test: fast/forms/input-number-keyoperation.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
Add up/down arrow keys support, and call handleBeforeTextInsertedEvent().
(WebCore::isNumberCharacter):
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
For type=number, remove unacceptable characters.
- html/HTMLInputElement.h:
LayoutTests:
- fast/forms/input-number-keyoperation-expected.txt: Added.
- fast/forms/input-number-keyoperation.html: Added.
- fast/forms/script-tests/input-number-keyoperation.js: Added.
- 2:21 PM Changeset in webkit [63585] by
-
- 2 edits in trunk/WebKit2
Add WebKitTestRunner to the WebKit2 solution
Reviewed by Sam Weinig.
- WebKit2.sln: Add InjectedBundle and WebKitTestRunner projects. Also change the build dependency order from
DumpRunderTree --> WebKitAPITest to
DumpRenderTree --> InjectedBundle --> WebKitTestRunner --> WebKitAPITest
- 2:20 PM Changeset in webkit [63584] by
-
- 2 edits in trunk/LayoutTests
Land updated expected results for fast/dom/prototype-inheritance-2-expected.txt on Windows.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 2:20 PM Changeset in webkit [63583] by
-
- 9 edits1 add in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=42430
Make WebKitTestRunner on Windows actually load and run a test
Reviewed by Sam Weinig.
- WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
(WKBundleInitialize):
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added. Output is a dll.
- WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
(WTR::createWKURL):
- WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
other existing checks, and avoid including Platform.h
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::registerWindowClass): Added.
(WTR::PlatformWebView::PlatformWebView): Implemented.
(WTR::PlatformWebView::~PlatformWebView): Implemented.
(WTR::PlatformWebView::page): Implemented.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build
configuration specific path to InjectedBundle.dll.
- WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::runUntil): Implemented.
- WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
- 2:18 PM Changeset in webkit [63582] by
-
- 4 edits in trunk/WebCore
2010-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Improve hover state handling for spin buttons
https://bugs.webkit.org/show_bug.cgi?id=42260
Background:
When we move the mouse cursor to a node from the outside of the node,
the following steps are executed.
- setHovered(true) is called.
- The node is repainted for the hover state.
- 'mousemove' event is dispatched for the node.
For a spin-button, RenderTheme::paint{Inner,Outer}SpinButton() is
called before the event handler of the spin-button. So we can't
detect which of the up part or the down part is hovered correctly.
Solution:
The hover state of a spin-button is one of three states;
Indeterminate, Up, and Down. The state is Indeterminate since
setHovered(true) is called and until 'mousemove' event is
dispatched.
No new tests because there are no implementation of spin-buttons
with hovered state yet.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isSpinUpButtonPartPressed): (WebCore::RenderTheme::isHovered): Return false if the node is a spin-button and the state is Indeterminate. (WebCore::RenderTheme::isSpinUpButtonPartHovered):
- rendering/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::SpinButtonElement): Initialize m_upDownState. (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::SpinButtonElement::setHovered): Set the state to Indeterminate.
- rendering/TextControlInnerElements.h: (WebCore::SpinButtonElement::upDownState):
- 2:11 PM Changeset in webkit [63581] by
-
- 5 edits in trunk
2010-07-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build system cleanup.
Move ExecutableAllocator{FixedVMPool,Posix,Symbian,Win}.cpp from
root CMakeLists.txt to the platform CMakeLists.txt.
- CMakeLists.txt:
- CMakeListsEfl.txt: Add ExecutableAllocatorPosix.cpp.
2010-07-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build system cleanup.
Remove reference to "mediaControlsGtk.css".
- cmake/WebKitGenerators.cmake:
- 2:11 PM Changeset in webkit [63580] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] Avoid crashing if offscreen GLES2 context creation fails
https://bugs.webkit.org/show_bug.cgi?id=42469
If creating or initializing an offscreen GLES2Context fails we should return null
rather than crashing or returning an invalid context.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::getOffscreenGLES2Context):
- 2:01 PM Changeset in webkit [63579] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7527532> Crash beneath setSelection() during detach()
https://bugs.webkit.org/show_bug.cgi?id=42020
Reviewed by Simon Fraser.
No test because I am unable to reproduce the crash.
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): In the clearSelection() case, where the repaint mode is
RepaintNewMinusOld, avoid making RenderBlockSelectionInfo instances, and thereby avoid calling
localToAbsolute() during detach().
- 1:47 PM Changeset in webkit [63578] by
-
- 5 edits in trunk
clang++ build fixes for JavaScriptCore and WebCore
https://bugs.webkit.org/show_bug.cgi?id=42478
Reviewed by Sam Weinig.
- runtime/RegExpKey.h:
(JSC::operator==):
Move the RegExpKey equals operator into the JSC namespace so it can be found by ADL.
WebCore:
- platform/network/Credential.cpp:
(WebCore::Credential::type):
- platform/network/Credential.h:
Remove const qualifier on Credential::type since it doesn't have an effect on the type.
- 1:46 PM Changeset in webkit [63577] by
-
- 2 edits in trunk/WebCore
Fix release build.
- storage/Database.cpp:
(WebCore::DerefContextTask::performTask):
- 1:31 PM Changeset in webkit [63576] by
-
- 13 edits2 adds in trunk
2010-07-16 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Safari pegs CPU and drops frames on http://neography.com/experiment/circles/solarsystem/ (CSS animations)
https://bugs.webkit.org/show_bug.cgi?id=41409
AnimationController::isAnimatingPropertyOnRenderer() really asked whether an accelerated animation
or transition was running. This prevented us from falling into compositing layers for animation
on platforms, like Windows, that don't have accelerated animations.
Fix by making things more explicit: we now have two methods, isRunningAnimationOnRenderer()
and isRunningAcceleratedAnimationOnRenderer().
Changes are more extensive because I flipped the sense of 'm_fallbackAnimating', which is
now 'm_isAccelerated', for clarity.
Test: compositing/animation/animation-compositing.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): m_fallbackAnimating -> m_isAccelerated (WebCore::AnimationBase::blendProperties): Ditto. (WebCore::AnimationBase::updateStateMachine): Ditto.
- page/animation/AnimationBase.h: (WebCore::AnimationBase::isAnimatingProperty): Takes new acceleratedOnly parameter which causes the method to only return true if the animation is accelerated. (WebCore::AnimationBase::isAccelerated): Changed from isFallbackAnimating.
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer): (WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer): (WebCore::AnimationController::isRunningAnimationOnRenderer): (WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
- page/animation/CompositeAnimation.h:
- page/animation/AnimationController.h: Rename isAnimatingPropertyOnRenderer(), add isRunningAcceleratedAnimationOnRenderer().
- page/animation/AnimationControllerPrivate.h: Ditto.
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): !isFallbackAnimating() -> isAccelerated(). (WebCore::CompositeAnimation::isAnimatingProperty): Pass acceleratedOnly down.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::timeToNextService): !isFallbackAnimating() -> isAccelerated().
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::timeToNextService): isFallbackAnimating() -> !isAccelerated().
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Avoid touching the transform or opacity if an accelerated animation is running.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForAnimation): Make compositing layers if an animation of transform or opacity is running.
- 1:26 PM Changeset in webkit [63575] by
-
- 1 edit1 move in trunk/LayoutTests
2010-07-16 Ojan Vafai <ojan@chromium.org>
Unreviewed. Put expected result from r63568 in the right place.
It should apply to windows and linux, not just linux.
- platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.txt.
- 1:25 PM Changeset in webkit [63574] by
-
- 2 edits in trunk/LayoutTests
2010-07-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Ojan Vafai.
Fix fast/dom/prototype-inheritance.html for chromium
https://bugs.webkit.org/show_bug.cgi?id=42477
- fast/dom/script-tests/prototype-inheritance.js:
- 1:17 PM Changeset in webkit [63573] by
-
- 2 edits in trunk/WebCore
2010-07-16 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Assertion when turning Accelerated Compositing off on a composited page
https://bugs.webkit.org/show_bug.cgi?id=42408
When accelerated compositing is turned off, check m_hasAcceleratedCompositing
before saying that the root layer will be composited. Fixes an assertion.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 12:45 PM Changeset in webkit [63572] by
-
- 3 edits2 adds in trunk
Spatial navigation: do not consider outline for focusable element boundaries
https://bugs.webkit.org/show_bug.cgi?id=42474
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
Test: fast/events/spatial-navigation/snav-zero-margin-content.html
Currently in WebCore::renderRectRelativeToRootDocument function, we are calling
RenderObject::absoluteClippedOverflowRect to obtain the rect boundary of a given
renderer/element. This method deals with outline, which is out of elements boundary.
It makes spatial navigation to fail on common sites like google.gom: "Web, Images, Map, etc"
are inaccessible.
Patch replaces RenderObject::absoluteClippedOverflowRect by Node::getRect,
which returns only the absolute bounding box rect of the Element.
- page/SpatialNavigation.cpp:
(WebCore::renderRectRelativeToRootDocument):
(WebCore::checkNegativeCoordsForNode):
LayoutTests:
- fast/events/spatial-navigation/snav-zero-margin-content-expected.txt: Added.
- fast/events/spatial-navigation/snav-zero-margin-content.html: Added.
- 12:37 PM Changeset in webkit [63571] by
-
- 4 edits in trunk/WebCore
2010-07-15 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Gustavo Noronha.
[Qt] Remove unnecessary WebKit headers inclusion from WebCore files
https://bugs.webkit.org/show_bug.cgi?id=42416
There are some places in WebCore unnecessarily including WebKit headers.
Cleaning up only, no testing needed.
- platform/network/qt/ResourceHandleQt.cpp:
- platform/qt/RenderThemeQt.c
- 12:23 PM Changeset in webkit [63570] by
-
- 4 edits in trunk/WebCore
Refinement of r63556: moved the tab width computation back to Font, but added a
SimpleFontData parameter.
Reviewed by Anders Carlsson.
- platform/graphics/Font.h:
(WebCore::Font::tabWidth):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- 12:20 PM Changeset in webkit [63569] by
-
- 2 edits in trunk/WebCore
2010-07-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Pavel Feldman.
Fix unit error in calculating timings from ResourceLoadTiming API
https://bugs.webkit.org/show_bug.cgi?id=42473
The start and end offsets are already in milliseconds so they should not be multiplied by 1000.0 like requestTime.
No new tests because, for a yet unknown reason, the ResourceLoadTiming API is not populated in the chromium test shell like it is in full chromium. This means the test that would have caught this bug (fast/dom/webtiming.html) currently has its expectation set to FAIL.
- page/Timing.cpp: (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart):
- 12:08 PM Changeset in webkit [63568] by
-
- 2 edits1 add in trunk/LayoutTests
2010-07-16 Ojan Vafai <ojan@chromium.org>
Unreviewed. Add another expected chromium failure and the missing the text expectation in r63567.
- platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:36 AM Changeset in webkit [63567] by
-
- 14 edits8 adds in trunk/LayoutTests
2010-07-16 Ojan Vafai <ojan@chromium.org>
Unreviewed. Add new chromium expectations and update expected failures. All updated expected
failures have the relevant details in the bugs.webkit.org bug.
Below are the revisions that caused needing new expectations.
http://trac.webkit.org/changeset/63531/
svg/custom/relative-sized-content-with-resources.xhtml
svg/custom/marker-child-changes-css.svg
http://trac.webkit.org/changeset/63542/
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
http://trac.webkit.org/changeset/63517/
fast/css/empty-generated-content.html
css2.1/t1204-root-e.html
http://trac.webkit.org/changeset/63517/
html5lib/runner.html
- platform/chromium-linux/svg/custom/marker-child-changes-css-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/marker-child-changes-expected.checksum.
- platform/chromium-linux/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/marker-child-changes-expected.png.
- platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
- platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png: Added.
- platform/chromium-linux/svg/text/selection-background-color-expected.checksum:
- platform/chromium-linux/svg/text/selection-background-color-expected.png:
- platform/chromium-linux/svg/text/selection-styles-expected.checksum:
- platform/chromium-linux/svg/text/selection-styles-expected.png:
- platform/chromium-mac/html5lib/runner-expected.txt:
- platform/chromium-win/css2.1/t1204-root-e-expected.txt:
- platform/chromium-win/fast/css/empty-generated-content-expected.txt:
- platform/chromium-win/html5lib/runner-expected.txt:
- platform/chromium-win/svg/custom/marker-child-changes-css-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-child-changes-expected.checksum.
- platform/chromium-win/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-child-changes-expected.png.
- platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
- platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png: Added.
- platform/chromium-win/svg/text/selection-background-color-expected.checksum:
- platform/chromium-win/svg/text/selection-background-color-expected.png:
- platform/chromium-win/svg/text/selection-styles-expected.checksum:
- platform/chromium-win/svg/text/selection-styles-expected.png:
- platform/chromium/test_expectations.txt:
- 11:32 AM Changeset in webkit [63566] by
-
- 8 edits3 adds in trunk
2010-07-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
ES5 allows use of reserved words as IdentifierName
https://bugs.webkit.org/show_bug.cgi?id=42471
Modify the lexer to allow us to avoid identifying reserved
words in those contexts where they are valid identifiers, and
we know it's safe. Additionally tag the reserved word tokens
so we can easily identify them in those cases where we can't
guarantee that we've skipped reserved word identification.
- parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
- parser/JSParser.h: (JSC::):
- parser/Lexer.cpp: (JSC::Lexer::lex):
- parser/Lexer.h: (JSC::Lexer::):
2010-07-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
ES5 allows use of reserved words as IdentifierName
https://bugs.webkit.org/show_bug.cgi?id=42471
Add tests to check for correct handling of reserved words with
the ES5 semantics.
- fast/js/reserved-words-as-property-expected.txt: Added.
- fast/js/reserved-words-as-property.html: Added.
- fast/js/script-tests/reserved-words-as-property.js: Added. ():
- fast/js/sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.5_Object_Initializer/S11.1.5_A4.1-expected.txt:
- fast/js/sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.5_Object_Initializer/S11.1.5_A4.2-expected.txt: These tests are wrong, unsure how to get sputnik tests corrected.
- 11:22 AM Changeset in webkit [63565] by
-
- 5 edits in trunk/LayoutTests
LayoutTests/http/tests/cookies/multiple-cookies.html sometimes fails because the cookies are returned in a different order
https://bugs.webkit.org/show_bug.cgi?id=42095
Reviewed by Alexey Proskuryakov.
Normalize the cookie strings by splitting them into an array, sorting the array and then joining back.
- http/tests/cookies/multiple-cookies-expected.txt:
- http/tests/cookies/resources/cookies-test-pre.js:
(normalizeCookie):
(testCookies):
- websocket/tests/httponly-cookie-expected.txt:
- websocket/tests/httponly-cookie.pl:
- 11:01 AM Changeset in webkit [63564] by
-
- 4 edits in trunk/WebKitTools
2010-07-16 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Make revalidation of back/forward work a little better with page loads
https://bugs.webkit.org/show_bug.cgi?id=42470
- MiniBrowser/mac/BrowserWindow.xib:
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController validateToolbar]): (_didStartProvisionalLoadForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame):
- 10:47 AM Changeset in webkit [63563] by
-
- 1 edit10 deletes in trunk/LayoutTests
Remove fast/dynamic/flash-replacement-test.html
https://bugs.webkit.org/show_bug.cgi?id=42467
Reviewed by Simon Fraser.
This test doesn't really test anything since the flash file it points to doesn't exist, and
the flash replacement test requires a SWF file that triggers a style layout when instantiating the plug-in.
Furthermore, we don't even instantiate Netscape plug-ins from attach anymore which makes this test
even less accurate.
Also, it's failing on Mac if Flash 10.1, which uses the Core Animation drawing model, is installed.
- fast/dynamic/flash-replacement-test.html: Removed.
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png: Removed.
- platform/chromium-win/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
- platform/chromium-win/fast/dynamic/flash-replacement-test-expected.png: Removed.
- platform/chromium-win/fast/dynamic/flash-replacement-test-expected.txt: Removed.
- platform/mac/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
- platform/mac/fast/dynamic/flash-replacement-test-expected.png: Removed.
- platform/mac/fast/dynamic/flash-replacement-test-expected.txt: Removed.
- platform/qt/fast/dynamic/flash-replacement-test-expected.txt: Removed.
- 10:46 AM Changeset in webkit [63562] by
-
- 5 edits in trunk
Really add WARN_UNUSED_RESULT to leakRef
https://bugs.webkit.org/show_bug.cgi?id=42464
Reviewed by David Levin.
- wtf/PassRefPtr.h:
(WTF::PassRefPtr::):
(WTF::NonNullPassRefPtr::):
Put the WARN_UNUSED_RESULT attribute at the right place.
- wtf/RetainPtr.h:
(WTF::RetainPtr::releaseRef):
Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
to be fixed first.
WebCore:
Get rid of a call to releaseRef here by passing the ScriptExecutionContext
reference through to the DerefContextTask.
- storage/Database.cpp:
(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::performTask):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
- 10:16 AM Changeset in webkit [63561] by
-
- 5 edits in trunk/WebCore
2010-07-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: The current implementation of generator is not ready
for generation Backend part of Inspector interface. The full patch
with Backend is quite big and I've split it.
https://bugs.webkit.org/show_bug.cgi?id=42462
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorValues.cpp: (WebCore::InspectorArray::get):
- inspector/InspectorValues.h: (WebCore::InspectorArray::length):
- 9:50 AM Changeset in webkit [63560] by
-
- 3 edits2 adds in trunk
2010-07-15 Rob Buis <rwlbuis@gmail.com>
Reviewed by Darin Adler.
An empty value for xml:lang isn't considered
https://bugs.webkit.org/show_bug.cgi?id=42042
Allow :lang selector to match empty values for xml:lang and
lang attributes.
Test: fast/css/lang-selector-empty-attribute.xhtml
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 9:38 AM Changeset in webkit [63559] by
-
- 15 edits2 adds in trunk
2010-07-15 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Update expectations for Web Timing enabled in chromium port.
https://bugs.webkit.org/show_bug.cgi?id=42313
Default expectations are to PASS (Web Timing enabled). Since the gtk, qt, win, and mac platforms do not have WEB_TIMING enabled, they must skip these tests.
- fast/dom/Window/window-properties-performance-expected.txt: Added.
- fast/dom/Window/window-properties-performance.html: Added.
- fast/dom/Window/window-properties.html: Skip webkitPerformance so that its platform-specific expectations can be managed in window-properties-performance.html.
- fast/dom/navigation-type-back-forward-expected.txt: Update to PASS
- fast/dom/navigation-type-navigate-expected.txt: Update to PASS
- fast/dom/navigation-type-reload-expected.txt: Update to PASS
- fast/dom/webtiming-expected.txt: Updated to mostly PASS. Currently has failures because chromium is not populating the ResourceLoadTiming API. This will be resolved when http://codereview.chromium.org/2909016 lands.
- fast/dom/webtiming.html: Update test based on new backfill functionality from https://bugs.webkit.org/show_bug.cgi?id=42303.
- http/tests/misc/webtiming-one-redirect-expected.txt: Update to PASS
- http/tests/misc/webtiming-two-redirects-expected.txt: Update to PASS
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-07-15 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Enable window.webkitPerformance (Web Timing) for chromium
https://bugs.webkit.org/show_bug.cgi?id=42313
- features.gypi:
- 9:28 AM Changeset in webkit [63558] by
-
- 2 edits in trunk/WebCore
2010-07-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Shift-Enter does not do a reverse search. It searches forward.
https://bugs.webkit.org/show_bug.cgi?id=42459
- inspector/front-end/inspector.js: (WebInspector.performSearch):
- 9:11 AM Changeset in webkit [63557] by
-
- 2 edits in trunk/WebCore
2010-07-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not include SSL time into Waiting time.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
- 9:08 AM Changeset in webkit [63556] by
-
- 4 edits in trunk/WebCore
<rdar://problem/8198266> white-space: pre text containing tabs is not laid out correctly when the font lacks a space glyph
https://bugs.webkit.org/show_bug.cgi?id=42437
Reviewed by Anders Carlsson.
No test because none of the fonts available to DumpRenderTree are missing a space glyph.
Changed the tab width computation to use the width of the space glyph from the font that has
a space glyph, which may be a fallback font if the primary font lacks a space glyph.
- platform/graphics/Font.h: Removed Font::tabWidth().
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- 9:08 AM Changeset in webkit [63555] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63551.
http://trac.webkit.org/changeset/63551
https://bugs.webkit.org/show_bug.cgi?id=42460
"Problems with gyp" (Requested by yurys on #webkit).
- DEPS:
- 9:00 AM Changeset in webkit [63554] by
-
- 4 edits in trunk/WebCore
2010-07-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add SSL time label into the resources popover.
- English.lproj/localizedStrings.js:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::buildObjectForTiming):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
- 8:53 AM Changeset in webkit [63553] by
-
- 2 edits in trunk/WebCore
2010-07-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix. Add missing include.
- inspector/ConsoleMessage.h:
- 8:50 AM Changeset in webkit [63552] by
-
- 2 edits in trunk/WebCore
2010-07-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Path: Avoid creating a new GraphicsContext in strokeContains() and strokeBoundingRect()
https://bugs.webkit.org/show_bug.cgi?id=42456
- platform/graphics/qt/PathQt.cpp: (WebCore::scratchContext): Added, provides a scratch GraphicsContext. (WebCore::Path::strokeContains): Use the scratch context instead of creating a new GraphicsContext. (WebCore::Path::strokeBoundingRect): Ditto.
- 8:46 AM Changeset in webkit [63551] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Bump up Chromium revision.
- DEPS:
- 8:38 AM Changeset in webkit [63550] by
-
- 2 edits in trunk/WebCore
2010-07-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] V8Proxy::retrieve may return null if javascript is disabled. Add a check
to avoid crashes in inspected page.
https://bugs.webkit.org/show_bug.cgi?id=42065
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener):
- 8:33 AM Changeset in webkit [63549] by
-
- 5 edits in trunk
2010-07-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: disable AppCache in chromium.
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache):2010-07-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: disable AppCache in chromium.
- src/js/DevTools.js: (WebInspector.loaded):
- 8:30 AM Changeset in webkit [63548] by
-
- 14 edits2 adds in trunk
2010-07-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
console.trace should show file and line number for each function in the stack
https://bugs.webkit.org/show_bug.cgi?id=21180
Test: inspector/console-trace.html
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::initialize):
- bindings/v8/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/v8/ScriptCallFrame.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::getFrameLocation): (WebCore::toScriptCallFrame): (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::CallFrame::CallFrame): (WebCore::ConsoleMessage::CallFrame::isEqual): (WebCore::ConsoleMessage::CallFrame::createFrontendObject): (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype._createStackTraceElement): (WebInspector.ConsoleMessage.prototype._createSourceUrlLink):
- inspector/front-end/inspector.css: (.console-message.expandable > .console-message-text::before): (.console-message.expandable.collapsed > .console-message-text::before): (.console-message.expandable.collapsed > ol.stack-trace): (.console-message > ol.stack-trace): (.console-message.repeated-message > ol.stack-trace): (.console-message.repeated-message > ol.stack-trace.trace-message):
- page/Console.idl:
2010-07-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
console.trace should show file and line number for each function in the stack
https://bugs.webkit.org/show_bug.cgi?id=21180
- http/tests/inspector/console-tests.js: (frontend_dumpConsoleMessages):
- inspector/console-trace-expected.txt: Added.
- inspector/console-trace.html: Added.
- 8:21 AM QtWebKitWeeklyBuilds edited by
- added link to nightly builds from tronical's email (diff)
- 7:50 AM Changeset in webkit [63547] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] A non-existent resource is referenced from devTools.css
The erroneous rule has been removed.
https://bugs.webkit.org/show_bug.cgi?id=42454
- src/js/devTools.css:
- 7:41 AM Changeset in webkit [63546] by
-
- 4 edits in trunk
2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Build with MathML enabled. Fix build when MathML is enabled and
make it the default.
https://bugs.webkit.org/show_bug.cgi?id=42453
- cmake/OptionsEfl.cmake: build with MathML enabled as default.
2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Build with MathML enabled. Fix build when MathML is enabled and
make it the default.
https://bugs.webkit.org/show_bug.cgi?id=42453
EFL port does not support automated tests, yet.
- CMakeLists.txt: add missing source file and sort.
- 7:07 AM Changeset in webkit [63545] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-16 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Check that end node of a range has a valid renderer in WebViewImpl::caretOrSelectionBounds()
to avoid crash in Position::getInlineBoxAndOffset() when start node has renderer but end one doesn't.
https://bugs.webkit.org/show_bug.cgi?id=42449
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds):
- 6:50 AM Changeset in webkit [63544] by
-
- 2 edits in trunk/WebCore
2010-07-16 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
DeviceOrientationEvent.h should not forward-declare DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=42447
When destructing m_orientation, DeviceOrientation cannot be an incomplete type.
- dom/DeviceOrientationEvent.h:
- 6:45 AM Changeset in webkit [63543] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-07-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Remove wrong test expectations for clip-path-child-changes.svg from chromium-mac
and mark it as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=42445
- platform/chromium-mac/svg/custom/clip-path-child-changes-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 4:39 AM Changeset in webkit [63542] by
-
- 15 edits in trunk
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
gradientTransform + objectBoundingBox is wrong
https://bugs.webkit.org/show_bug.cgi?id=42446
gradientTransform + gradientUnits="objectBoundingBox" is wrong. Reverse multiplication order of both transforms.
- rendering/RenderSVGResourceGradient.cpp: s/multiply/multLeft/
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
gradientTransform + objectBoundingBox is wrong
https://bugs.webkit.org/show_bug.cgi?id=42446
Update pixel test results after fixing gradientTransform and gradientUnits="objectBoundingBox" usage for shapes & text.
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac/svg/text/selection-background-color-expected.checksum:
- platform/mac/svg/text/selection-background-color-expected.png:
- platform/mac/svg/text/selection-styles-expected.checksum:
- platform/mac/svg/text/selection-styles-expected.png:
- 4:38 AM Changeset in webkit [63541] by
-
- 3 edits in trunk/LayoutTests
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Forgot to land new pixel test result in r63535.
- platform/mac/svg/custom/convolution-crash-expected.checksum:
- platform/mac/svg/custom/convolution-crash-expected.png:
- 4:02 AM Changeset in webkit [63540] by
-
- 163 edits10 adds in trunk/LayoutTests
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Regenerated pixel test results for svg/dynamic-updates. Not enabling the actual dumping of pixel test results yet,
as we're having several regressions that should be identified first. Only updated results which only have text
rendering differences (after the text rewrite, last month).
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
- 4:00 AM Changeset in webkit [63539] by
-
- 1 edit in trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
Unreviewed test expectations fix after r63537.
- 3:49 AM Changeset in webkit [63538] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Unreviewed. Whitespace change to WebKit/win/Interfaces/WebKit.idl to enforce IDL rebuild.
- 2:54 AM Changeset in webkit [63537] by
-
- 29 edits in trunk
2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Make JS memory stats available via 'Performance' object (Web Timing).
This statistics is populated only if 'WebKitMemoryInfoEnabled'
preference is set.
'console.memory' is kept until Web Timing object becomes visible by
default (currently it is hidden under compile-time flag). These stats
are guarded with the same preference.
- bindings/js/JSConsoleCustom.cpp:
- bindings/v8/custom/V8ConsoleCustom.cpp:
- page/Console.cpp: (WebCore::Console::disconnectFrame): (WebCore::Console::memory):
- page/Console.h:
- page/Console.idl:
- page/MemoryInfo.cpp: (WebCore::MemoryInfo::MemoryInfo):
- page/MemoryInfo.h: (WebCore::MemoryInfo::create):
- page/Performance.cpp: (WebCore::Performance::disconnectFrame): (WebCore::Performance::memory):
- page/Performance.h:
- page/Performance.idl:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h: (WebCore::Settings::setMemoryInfoEnabled): (WebCore::Settings::memoryInfoEnabled):
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMemoryInfoEnabled):
- src/WebSettingsImpl.h:
- WebKit.order:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences memoryInfoEnabled]): (-[WebPreferences setMemoryInfoEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::memoryInfoEnabled): (WebPreferences::setMemoryInfoEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 2:48 AM Changeset in webkit [63536] by
-
- 11 edits in trunk/WebKitTools
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add possibility to dumpAsText and generate a pixel test result
https://bugs.webkit.org/show_bug.cgi?id=42374
Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
(Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsTextAndPixelsCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::setDumpAsTextAndPixels):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::shouldDumpAsTextAndPixels):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
- DumpRenderTree/mac/DumpRenderTree.mm: (dump):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
- DumpRenderTree/win/DumpRenderTree.cpp: (dump):
- DumpRenderTree/wx/DumpRenderTreeWx.cpp: (dump):
- 2:45 AM Changeset in webkit [63535] by
-
- 3 edits in trunk
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273
Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.
1) Fix clamping the rgb values:
"image->set(pixel++, clampRGBAValue(totals[0], maxAlpha));" totals[0] -> totals[i].
2) Don't apply the divisior divison and bias addition multiple times, accumulated!
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::setDestinationPixels): Fix two evil bugs, breaking feConvolveMatrix.
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273
Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.
Update convolution-crash.svg results.
- platform/mac/svg/custom/convolution-crash-expected.checksum:
- platform/mac/svg/custom/convolution-crash-expected.png:
- 2:25 AM Changeset in webkit [63534] by
-
- 5 edits in trunk/LayoutTests
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline two results which seemed to be corrupt (DRT warns).
- platform/mac/svg/custom/convolution-crash-expected.checksum:
- platform/mac/svg/custom/convolution-crash-expected.png:
- platform/mac/svg/custom/mask-colorspace-expected.checksum:
- platform/mac/svg/custom/mask-colorspace-expected.png:
- 1:40 AM Changeset in webkit [63533] by
-
- 1 edit1 add in trunk/LayoutTests
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing layout test results for fast/js/numeric-compare.html, which landed in r63515.
- fast/js/numeric-compare-expected.txt: Added.
- 1:32 AM Changeset in webkit [63532] by
-
- 2 edits in trunk/WebKitTools
2010-07-16 Kent Hansen <kent.hansen@nokia.com>
Unreviewed. Adding myself as committer.
- Scripts/webkitpy/common/config/committers.py:
- 1:26 AM Changeset in webkit [63531] by
-
- 40 edits8 adds in trunk
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
relative positioning does not work for radialGradient after window resize
https://bugs.webkit.org/show_bug.cgi?id=41249
Redesign the way resources are invalidated. No longer utilize the DOM tree, specifically SVGStyledElement::svgAttributeChanged(), to invalidate
all resources in the ancestor chain (including itself) when any attribute changes. rect.setAttribute("foo", "bar") should never invalidate the
resources. Also the old approach didn't work correctly if the root layout changed (eg. window size change) - we failed to invalidate the resources,
thus leading to wrong renderings.
Instead of calling setNeedsLayout(true) from the SVG*Element classes, call RenderSVGResource::markForLayoutAndParentResourceInvalidation(), which
does the same thing and invalidates all resources in the ancestor chain (removing the cached results from the HashMaps). This only happens from
the various svgAttributeChanged() methods, if we know which attribute changed, and what action has to be taken.
All SVG renderers now invalidate their own resources on layout() if the layout changed (selfNeedsLayout()=true). The resources will be recreated
and cached during the following paint() call.
Tests: svg/custom/marker-child-changes-css.svg
svg/custom/relative-sized-content-with-resources.xhtml
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Ditto.
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): Ditto.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Ditto.
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleDidChange): Added, to invalidate resources on CSS changes, covered by new svg/custom/marker-child-changes-css.svg test.
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGResource.cpp: (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation): Add new "needsBoundaries" parameter, calling setNeedsBoundaries() on the target render object,
simplifying all RenderSVGResource* code.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): New static method used from DOM tree to invalidate all cached resources in the ancestor chain
for a render object. Also marks the renderer for layout, if needed.
- rendering/RenderSVGResource.h:
- rendering/RenderSVGResourceClipper.cpp: Simplify code, remove no longer needed hacks, as invalidation is now carried out by render tree. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): Add m_invalidationBlocked hack, to avoid invalidations, while we're mutating the render styles (which is a hack!). (WebCore::RenderSVGResourceClipper::invalidateClients): Don't do anything if m_invalidationBlocked=true. (WebCore::RenderSVGResourceClipper::invalidateClient): Ditto. (WebCore::RenderSVGResourceClipper::createClipData): Set m_invalidationBlocked before mutating render styles, as they are restored immediately after creating the clip image. (WebCore::RenderSVGResourceClipper::resourceBoundingBox): Remove no longer needed hack to initialize ClipperData earlier than applyResource() would do.
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceFilter::invalidateClient): Remove wrong assertion.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceGradient::invalidateClient): Remove wrong assertion.
- rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceMarker::invalidateClient): Remove wrong assertion.
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceMasker::invalidateClient): Remove wrong assertion. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): Remove no longer needed hack to initializer MaskerData earlier than applyResource() would do.
- rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourcePattern::invalidateClient): Remove wrong assertion.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyResultsToTarget): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Ditto.
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): Ditto.
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::notifyFinished): Ditto.
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): Ditto.
- svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged): Ditto.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Ditto.
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): Ditto.
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged): Ditto.
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): Ditto.
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): Ditto.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale): Ditto. (WebCore::SVGSVGElement::svgAttributeChanged): Ditto. (WebCore::SVGSVGElement::inheritViewAttributes): Ditto.
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): Changed m_offset initialization from 0.0f to 0. (WebCore::SVGStopElement::svgAttributeChanged): Add missing implementation, calling RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) on offsetAttr changes.
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): Don't call invalidateResourceInAncestorChain() on every attribute change, do it in all classes inheriting from us,
for specific attributes. Also stop calling RenderSVGResource::invalidateAllResourcesOfRenderer(), all handled in the render tree now.
(WebCore::SVGStyledElement::invalidateResourceClients): Early exit, if document is still parsing.
- svg/SVGStyledElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::svgAttributeChanged): Ditto.
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): Ditto.
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): Ditto.
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): Ditto. (WebCore::SVGUseElement::updateContainerSizes): Ditto. (WebCore::SVGUseElement::updateContainerOffsets): Ditto.
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
relative positioning does not work for radialGradient after window resize
https://bugs.webkit.org/show_bug.cgi?id=41249
- platform/mac/svg/custom/marker-child-changes-css-expected.checksum: Added.
- platform/mac/svg/custom/marker-child-changes-css-expected.png: Added.
- platform/mac/svg/custom/marker-child-changes-css-expected.txt: Added.
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.png: Added.
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
- svg/custom/marker-child-changes-css.svg: Added.
- svg/custom/relative-sized-content-with-resources.xhtml: Added.
- 1:15 AM Changeset in webkit [63530] by
-
- 4 edits4 adds in trunk
2010-07-16 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175
This is a SVG with an empty <g> within a <g>, to which a filter is applied by reference.
The rendered image is all blank.
- platform/mac/svg/filters/filter-empty-g-expected.checksum: Added
- platform/mac/svg/filters/filter-empty-g-expected.png: Added
- platform/mac/svg/filters/filter-empty-g-expected.txt: Added
- svg/filters/filter-empty-g.svg: Added
2010-07-16 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175
Avoid painting of zero-sized image buffers. Skia can't handle it.
Test: svg/filters/filter-empty-g.svg
- WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (ImageBuffer::ImageBuffer):
- 12:50 AM Changeset in webkit [63529] by
-
- 2 edits in trunk/LayoutTests
2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
- platform/chromium/test_expectations.txt:
- 12:46 AM Changeset in webkit [63528] by
-
- 4 edits in trunk
2010-07-16 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Regression in r63100: Don't clear m_loadType in
FrameLoader::handledOnloadEvents, as it is used
to make some decisions after the load has actually
completed.
Tickling this bug requires manipulation
via the API (layout tests don't appear to traverse
the correct codepath), so no layout test.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Don't reset m_loadType. (WebCore::FrameLoader::addExtraFieldsToRequest): Set subresource cache
policy in one place and don't depend on m_loadType.
2010-07-16 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Uncomment an assert that broke due to r63100.
- tests/testwebview.c:
- 12:36 AM Changeset in webkit [63527] by
-
- 2 edits in trunk/WebKitTools
2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Another uneviewed attempt to fix build.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext):
- 12:12 AM Changeset in webkit [63526] by
-
- 2 edits in trunk/WebKitTools
2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed tiger build fix.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): (createBitmapContextFromWebView):
