Timeline
Aug 22, 2010:
- 11:27 PM Changeset in webkit [65794] by
-
- 2 edits in trunk/LayoutTests
2010-08-22 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt:
- 11:11 PM Changeset in webkit [65793] by
-
- 4 edits in trunk/WebCore
2010-08-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] don't expose the private player in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=44332
Only a pointer to our playbin2 element instance is required
instead of the whole MediaPlayerPrivateGStreamer instance.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::createGWorld): (WebCore::GStreamerGWorld::GStreamerGWorld): (WebCore::GStreamerGWorld::~GStreamerGWorld): (WebCore::GStreamerGWorld::enterFullscreen): (WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/GStreamerGWorld.h: (WebCore::GStreamerGWorld::pipeline):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- 8:50 PM Changeset in webkit [65792] by
-
- 3 edits in trunk/WebKitTools
2010-08-22 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
https://bugs.webkit.org/show_bug.cgi?id=43010
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::applyPrefs):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 5:52 PM Changeset in webkit [65791] by
-
- 2 edits in trunk/WebCore
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext: Simplify getting the clip bounding rect
https://bugs.webkit.org/show_bug.cgi?id=44396
Move the Qt 4.8 version check for QPainter::clipBoundingRect()
into a GraphicsContextPlatformPrivate method.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
- 5:30 PM Changeset in webkit [65790] by
-
- 2 edits in trunk/WebKit/efl
2010-08-22 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Remove duplicated include entry from default theme.
https://bugs.webkit.org/show_bug.cgi?id=44345
This used to create the group webkit/widget/entry twice in
the theme. It's leading to a bug with the newer versions of
EFL.
- DefaultTheme/default.edc:
- 5:14 PM Changeset in webkit [65789] by
-
- 2 edits in trunk/WebKit/qt
2010-08-22 Marc Mutz <marc.mutz@kdab.com>
Reviewed by Antonio Gomes.
[Qt] Actually emit the QWebView::selectionChanged() signal
- Api/qwebview.cpp: (QWebView::setPage): Connect QWebPage::selectionChanged() to QWebView::selectionChanged()
- 3:42 PM Changeset in webkit [65788] by
-
- 18 edits in trunk
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
- DerivedSources.pro:
- Shared/CoreIPCSupport/WebPageMessageKinds.h: (WebPageMessage::):
- Shared/WebEvent.h: (WebKit::WebEvent::): (WebKit::WebTouchPoint::): (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::id): (WebKit::WebTouchPoint::state): (WebKit::WebTouchPoint::screenPosX): (WebKit::WebTouchPoint::screenPosY): (WebKit::WebTouchPoint::posX): (WebKit::WebTouchPoint::posY): (WebKit::WebTouchPoint::setState): (WebKit::WebTouchPoint::encode): (WebKit::WebTouchPoint::decode): (WebKit::WebTouchEvent::WebTouchEvent): (WebKit::WebTouchEvent::type): (WebKit::WebTouchEvent::touchPoints): (WebKit::WebTouchEvent::encode): (WebKit::WebTouchEvent::decode): (WebKit::WebTouchEvent::isTouchEventType):
- Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint): (WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent): (WebKit::platform):
- Shared/WebEventConversion.h:
- Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent):
- Shared/qt/WebEventFactoryQt.h:
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::event): (QGraphicsWKView::touchEvent):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::touchEvent):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::touchEvent):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::touchEvent): (WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- 2:41 PM Changeset in webkit [65787] by
-
- 29 edits2 adds in trunk
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Chromium port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::addMarker): (WebKit::WebFrameImpl::setMarkerActive):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Windows port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- WebFrame.cpp: (WebFrame::unmarkAllMisspellings): (WebFrame::unmarkAllBadGrammar):
- WebView.cpp: (WebView::rectsForTextMatches):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Mac port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): (-[WebFrame _unmarkAllMisspellings]):
- WebView/WebHTMLView.mm: (-[WebHTMLView unmarkAllTextMatches]): (-[WebHTMLView rectsForTextMatches]):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the EFL port to use DocumentMarkerController.
No functionality was changed, so no new tests.
- ewk/ewk_frame.cpp: (ewk_frame_text_matches_unmark_all):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Moves the document marker management code in Document.cpp into its own
class called DocumentMarkerController.
No functionality was changed, so no new tests.
- Android.mk: Added DocumentMarkerController.cpp
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
- WebCore.exp.in: Substituted symbols ZN7WebCore24DocumentMarkerController13removeMarkersENS_14DocumentMarker10MarkerTypeE and ZN7WebCore24DocumentMarkerController23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE for ZN7WebCore8Document13removeMarkersENS_14DocumentMarker10MarkerTypeE and ZN7WebCore8Document23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE, respectively.
- WebCore.gypi: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: (WebCore::Document::removedLastRef): Modified to call DocumentMarkerController::detach(). (WebCore::Document::~Document): Removed "deleteAllValues(m_markers)" as DocumentMarkerController is stored in OwnPtr; so it will be destroyed automatically on Document destruction. (WebCore::Document::textInserted): Modified to use marker controller. (WebCore::Document::textRemoved): Ditto.
- dom/Document.h: (WebCore::Document::markers): Added.
- dom/DocumentMarkerController.cpp: Added. (WebCore::placeholderRectForMarker): (WebCore::DocumentMarkerController::detach): (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersForNode): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::setRenderedRectForMarker): (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive):
- dom/DocumentMarkerController.h: Added. (WebCore::DocumentMarkerController::~DocumentMarkerController):
- editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Modified to use marker controller. (WebCore::findFirstMisspellingInRange): Ditto. (WebCore::findFirstGrammarDetailInRange): Ditto. (WebCore::Editor::advanceToNextMisspelling): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::changeBackToReplacedString): Ditto.
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Ditto. (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
- page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Ditto. (WebCore::Frame::setMarkedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::respondToChangedSelection): Ditto.
- page/FrameView.cpp: (WebCore::FrameView::getTickmarks): Ditto. (WebCore::FrameView::paintContents): Ditto.
- page/Page.cpp: (WebCore::Page::unmarkAllTextMatches): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Ditto. (WebCore::HitTestResult::replacedString): Ditto.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto. (WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::computeTextMatchMarkerRect): Ditto.
- 2:32 PM Changeset in webkit [65786] by
-
- 6 edits in trunk
Add the blob URL member to FormData.
https://bugs.webkit.org/show_bug.cgi?id=44387
Reviewed by Darin Fisher.
WebCore:
This is in preparation to switch blob implementation to using BlobData
model. When a blob is added to a FormData, it is represented as a blob
URL in the list.
- platform/network/FormData.cpp:
(WebCore::FormData::appendBlob):
- platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(WebCore::FormDataElement::):
(WebCore::operator==):
WebKit/chromium:
As the result of adding the blob URL member to the FormData, we need
to update the corresponding WebKit API for chromium.
- public/WebHTTPBody.h:
(WebKit::WebHTTPBody::Element::):
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendBlob):
- 11:38 AM Changeset in webkit [65785] by
-
- 4 edits in trunk
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
- html5lib/resources/adoption01.dat:
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
The HTML5 spec has changed since Adam and I original wrote
the HTMLTreeBuilder. Most important for this change was resolution of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9580
I also removed our "phrasing" tag support since that was also removed
from the spec as part of other bug fixes.
This is tested by tonyg's <a><svg><tr><input></a> test in adoption01.dat.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement): (WebCore::HTMLTreeBuilder::processEndTag):
- 5:12 AM Changeset in webkit [65784] by
-
- 2 edits in trunk/WebCore
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] TransparencyLayer: Always use anti-aliasing and smooth pixmap transform
https://bugs.webkit.org/show_bug.cgi?id=44394
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer): Set the Antialiasing and SmoothPixmapTransforms render hints for all TransparencyLayers.
- 1:38 AM Changeset in webkit [65783] by
-
- 4 edits in trunk
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient): Reverse the (radial) gradient if r0 > r1.
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
Unskip two tests that now pass:
- canvas/philip/tests/2d.gradient.radial.outside2.html
- canvas/philip/tests/2d.gradient.radial.outside3.html
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [65782] by
-
- 5 edits in trunk/WebCore
[Qt] Layer approach to support generic shadow handling
https://bugs.webkit.org/show_bug.cgi?id=44380
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-22
Reviewed by Dirk Schulze.
The pair beginShadowLayer and endShadowLayer creates a temporary image
where the caller can draw onto, using the returned QPainter. When
endShadowLayer is called, the temporary image will be filtered, using
the specified shadow color and blur radius, and drawn to the graphics
context.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/ContextShadow.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::contextShadow):
Aug 21, 2010:
- 8:01 PM Changeset in webkit [65781] by
-
- 6 edits in trunk/WebKitTools
Check in missing files.
- 6:58 PM Changeset in webkit [65780] by
-
- 44 edits in trunk
Remove specialized retain/release functions in favor of a single one for WKTypeRefs
https://bugs.webkit.org/show_bug.cgi?id=44386
Reviewed by Dan Bernstein.
WebKit2:
- UIProcess/API/C/WKArray.cpp:
(WKArrayGetSize):
- UIProcess/API/C/WKArray.h:
- UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListCopyForwardListWithLimit):
- UIProcess/API/C/WKBackForwardList.h:
- UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyTitle):
- UIProcess/API/C/WKBackForwardListItem.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKData.cpp:
(WKDataGetSize):
- UIProcess/API/C/WKData.h:
- UIProcess/API/C/WKDictionary.cpp:
(WKDictionaryCopyKeys):
- UIProcess/API/C/WKDictionary.h:
- UIProcess/API/C/WKError.h:
- UIProcess/API/C/WKFormSubmissionListener.cpp:
(WKFormSubmissionListenerContinue):
- UIProcess/API/C/WKFormSubmissionListener.h:
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetPage):
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerIgnore):
- UIProcess/API/C/WKFramePolicyListener.h:
- UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyURL):
- UIProcess/API/C/WKNavigationData.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetContext):
- UIProcess/API/C/WKPageNamespace.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesGetLocalStorageEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/C/WKString.cpp:
- UIProcess/API/C/WKString.h:
- UIProcess/API/C/WKType.cpp:
(WKRetain):
(WKRelease):
- UIProcess/API/C/WKType.h:
- UIProcess/API/C/WKURL.cpp:
(WKURLGetTypeID):
- UIProcess/API/C/WKURL.h:
- UIProcess/API/cpp/WKRetainPtr.h:
- UIProcess/API/win/WKView.cpp:
- UIProcess/API/win/WKView.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::shared):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetTypeID):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldNormalWorld):
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
WebKitTools:
- MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
(didNavigateWithNavigationData):
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationWillTerminate:]):
- MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController fetch:]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL):
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::~PlatformWebView):
- 11:40 AM Changeset in webkit [65779] by
-
- 6 edits in trunk
2010-08-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media engine should not be asked to open all urls
https://bugs.webkit.org/show_bug.cgi?id=44370
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Do nothing with urls with a type attribute that would be rejected by canPlayType().
2010-08-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media engine should not be asked to open all urls
https://bugs.webkit.org/show_bug.cgi?id=44370
- media/video-source-none-supported-expected.txt:
- media/video-source-none-supported.html:
- media/video-source-type.html:
- 3:11 AM Changeset in webkit [65778] by
-
- 2 edits in trunk/LayoutTests
2010-08-21 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] http/tests/incremental should be enabled
https://bugs.webkit.org/show_bug.cgi?id=44284
- platform/qt/Skipped: Enable http/tests/incremental, disabling only one failing test (#44282)
- 2:23 AM Changeset in webkit [65777] by
-
- 2 edits in trunk/LayoutTests
2010-08-21 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] All sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/ tests can be re-enabled
https://bugs.webkit.org/show_bug.cgi?id=44192
Tested on several scenarios, including qt-4.7 and qt-4.6
- platform/qt/Skipped:
- 1:33 AM Changeset in webkit [65776] by
-
- 2 edits in trunk/WebCore
[Qt] Faster bounding rect for the shadow clip region
https://bugs.webkit.org/show_bug.cgi?id=44369
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-21
Reviewed by Kenneth Rohde Christiansen.
Like in r65650, we should use the faster QPainter::clipBoundingRect
when it is available.
- platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::drawShadowRect):
Aug 20, 2010:
- 10:14 PM Changeset in webkit [65775] by
-
- 2 edits in trunk/WebCore
[Qt] When using the raster graphics system on Maemo5, allow
Flash to render directly into the raster window surface.
wmode=transparent is now supported as a result of this change.
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=44043
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paintUsingImageSurfaceExtension):
- 10:06 PM Changeset in webkit [65774] by
-
- 3 edits3 adds in trunk
2010-08-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources
- http/tests/misc/resources/script-500.php: Added.
- http/tests/misc/script-500-expected.txt: Added.
- http/tests/misc/script-500.html: Added.
2010-08-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources
Test: http/tests/misc/script-500.html
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveData): Treat all HTTP codes >= 400 as error ones, since they are.
- 8:39 PM Changeset in webkit [65773] by
-
- 2 edits in trunk/WebKitTools
2010-08-20 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with Python 2.3
https://bugs.webkit.org/show_bug.cgi?id=44373
Replaced the function sorted() by a call to sort()
on the entry list.
The function sorted() has been added to Python 2.4.
The function method sort() of List works with older
versions of Python.
- Scripts/create-html-entity-table:
- 6:18 PM Changeset in webkit [65772] by
-
- 2 edits in trunk/LayoutTests
2010-08-20 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] Enable some http/ tests which are passing for some time
https://bugs.webkit.org/show_bug.cgi?id=44366
These are reported as "passing, require confirmation on bot". Some of them
fail on my machines, so I'm enabling only the ones which pass.
- platform/qt/Skipped: enable several http tests
- 6:01 PM Changeset in webkit [65771] by
-
- 7 edits in trunk/WebKit/qt
2010-08-20 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Ariya Hidayat.
[Qt] constify core() and kit() parameters
https://bugs.webkit.org/show_bug.cgi?id=44347
- Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
- Api/qwebframe_p.h:
- Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core):
- Api/qwebhistory_p.h:
- Api/qwebpage.cpp: (QWebPagePrivate::core):
- Api/qwebpage_p.h:
- 5:35 PM Changeset in webkit [65770] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix for chromium (and remove duplicated ChangeLog entry).
- 5:25 PM Changeset in webkit [65769] by
-
- 10 edits4 adds in trunk
2010-08-20 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::Node::createRendererIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=44129
- html5lib/resources/adoption02.dat: A crazy DOM from https://bugs.webkig.org/show_bug.cgi?id=44170 which previously crashed. The expectation doesn't appear to be correct, but it behaves the same in Firefox 4, so I'm going to file a spec bug.
- fast/parser/remove-misnested-iframe-in-beforeload-expected.txt:
- fast/parser/remove-misnested-iframe-in-beforeload.html: Misnest a node in a table and remove it during its beforeload handler. The node should not be in the tree.
- fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt:
- fast/parser/remove-misnested-iframe-parent-in-beforeload.html: Misnest a node in a table and remove its parent during its beforeload handler. The adoption agency should have already changed its parent to the one before the table and it and its parent should be removed.
2010-08-20 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::Node::createRendererIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=44129
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): Factor out core bit to insertBetween. (WebCore::ContainerNode::insertBetween): Factored out of insertBefore. (WebCore::ContainerNode::parserInsertBefore): Similar to insertBefore, but doesn't handle reparenting or dispatch DOM mutation events. (WebCore::ContainerNode::removeChild): Factor out core bit to removeBetween. (WebCore::ContainerNode::removeBetween): Facotred out of removeChild. (WebCore::ContainerNode::parserRemoveChild): Similar to removeChild, but doesn't handle reparenting or dispatch DOM mutation events. (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::legacyParserAddChild):
- dom/ContainerNode.h:
- dom/Node.cpp: (WebCore::Node::parserRemoveChild): (WebCore::Node::parserInsertBefore):
- dom/Node.h:
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite): Use new parserInsertBefore.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::reparentChildren): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Was missing a key bit from the spec about removing the old parent if it exists.
- 5:18 PM Changeset in webkit [65768] by
-
- 2 edits in trunk/WebCore
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix. Had included wrong version of build file.
- 5:13 PM Changeset in webkit [65767] by
-
- 4 edits in trunk
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Joseph Pecoraro.
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
- platform/gtk/Skipped: Unskip tests which are now passing.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Joseph Pecoraro.
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
- GNUmakefile.am: Fix dependency tracking for copied web inspector files.
- 5:04 PM Changeset in webkit [65766] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-20 James Robinson <jamesr@chromium.org>
Synchronize default of use_accelerated_compositing gyp variable with downstream. Unreviewed.
- features.gypi:
- 5:02 PM Changeset in webkit [65765] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add chromium-side callback implementation for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44350
Add WebFileSystemCallbacks that calls back the WebCore's implementation.
- WebKit.gyp:
- src/WebFileSystemCallbacksImpl.cpp: Added.
- src/WebFileSystemCallbacksImpl.h: Added.
- 4:59 PM Changeset in webkit [65764] by
-
- 4 edits6 adds in branches/audio/WebCore
Split out HRTFPanner file into: HRTFKernel, HRTFElevation, HRTFDatabase, HRTFPanner files
- 4:49 PM Changeset in webkit [65763] by
-
- 9 edits2 adds in trunk/WebCore
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add Callback implementation for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44349
No new tests; tests will be added later.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/FileSystemCallbacks.cpp: Added.
- storage/FileSystemCallbacks.h: Added.
- storage/EntryCallback.h: Nits fix
- storage/FileSystemCallback.h: Nits fix
- 4:48 PM Changeset in webkit [65762] by
-
- 1 edit3 deletes in trunk/LayoutTests
2010-08-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65757.
http://trac.webkit.org/changeset/65757
https://bugs.webkit.org/show_bug.cgi?id=44371
"fails on chromium windows and there is also a bug in the test
script." (Requested by rniwa on #webkit).
- editing/style/make-text-writing-direction-inline-expected.txt: Removed.
- editing/style/make-text-writing-direction-inline.html: Removed.
- editing/style/script-tests/make-text-writing-direction-inline.js: Removed.
- 4:23 PM Changeset in webkit [65761] by
-
- 3 edits in trunk/WebCore
2010-08-20 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] WebKit does not compile with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=44335
- PlatformGLObject => Platform3DObject
- Implemented getAttachedShaders()
- Implemented bufferData() and bufferSubData() for ArrayBuffer*
- Removed reference to nonexistent variable in getImageData()
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/qt/GraphicsLayerQt.h:
- 4:03 PM Changeset in webkit [65760] by
-
- 2 edits in trunk/WebCore
#ifdef-out some Leopard-and-earlier code.
Reviewed by Dave Kilzer.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
- 3:43 PM Changeset in webkit [65759] by
-
- 3 edits in trunk/WebCore
2010-08-20 Kenneth Russell <kbr@google.com>
Unreviewed, speculative Chromium build fix. Forward declare
IntSize in WebGLRenderingContext.h and include IntSize.h in .cpp.
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- 3:19 PM Changeset in webkit [65758] by
-
- 3 edits2 adds in trunk
2010-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element canPlayType("application/octet-stream") not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=44343
Test: media/media-can-play-octet-stream.html
- platform/graphics/MediaPlayer.cpp: (WebCore::applicationOctetStream): New, accessor for static string used more than once. (WebCore::textPlain): Ditto. (WebCore::codecs): Ditto. (WebCore::chooseBestEngineForTypeAndCodecs): Special case "application/octet-stream". (WebCore::MediaPlayer::load): Use static static string methods. (WebCore::MediaPlayer::supportsType): Special case "application/octet-stream".
2010-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element canPlayType("application/octet-stream") not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=44343
- media/media-can-play-octet-stream-expected.txt: Added.
- media/media-can-play-octet-stream.html: Added.
- 3:14 PM Changeset in webkit [65757] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-08-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=43989
Added a test for MakeTextWritingDirectionNatural, MakeTextWritingDirectionLeftToRight,
and MakeTextWritingDirectionRightToLeft commands.
- editing/style/make-text-writing-direction-inline.html: Added.
- editing/style/script-tests/make-text-writing-direction-inline.js: Added. (modifyWritingDirection): (selectFirstWord): (selectSecondAndThirdWords):
- 3:12 PM Changeset in webkit [65756] by
-
- 4 edits4 adds in trunk
2010-08-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Implement HTMLVideoElement support for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=33852
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): (WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer): (WebCore::WebGLRenderingContext::LRUImageBufferCache::bubbleToFront):
- html/canvas/WebGLRenderingContext.h:
2010-08-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Implement HTMLVideoElement support for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=33852
- fast/canvas/webgl/resources/quadrants.mp4: Added.
- fast/canvas/webgl/resources/quadrants.ogv: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: Added.
- 2:54 PM Changeset in webkit [65755] by
-
- 3 edits2 adds in trunk
WebCore: Removing an incorrect ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=44151
Reviewed by Adam Barth.
A failure in the preflight step of a transaction wrapper does not
guarantee that the transaction is rolled back (and it shouldn't).
Test: storage/change-version-no-crash-on-preflight-failure.html
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
LayoutTests: Check that a failure in the preflight step of a transaction wrapper does not trigger any assertion.
https://bugs.webkit.org/show_bug.cgi?id=44151
Reviewed by Adam Barth.
- storage/change-version-no-crash-on-preflight-failure-expected.txt: Added.
- storage/change-version-no-crash-on-preflight-failure.html: Added.
- 2:44 PM Changeset in webkit [65754] by
-
- 2 edits in trunk/WebCore
2010-08-20 David Leong <david.leong@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Update Symbian capabilities to remove AllFiles and DRM
Add CONFIG(production) variation for set of DLL capabilities.
DRM and AllFiles capabilities need to be audited for the sis
package to be signed.
No new tests.
- WebCore.pro: Updated Symbian Capabilities.
- 2:14 PM Changeset in webkit [65753] by
-
- 2 edits in trunk/WebCore
2010-08-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Do Not Copy Subversion Related Files in Inspector Build Phase
https://bugs.webkit.org/show_bug.cgi?id=44353
- WebCore.xcodeproj/project.pbxproj: remove .svn directories in the "Copy Inspector Resources" build phase.
- 2:03 PM Changeset in webkit [65752] by
-
- 3 edits4 adds in trunk
2010-08-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/8245719> backface-visibility and reflections don't play nicely together.
On elements with a reflection and backface-visibility: hidden, set the doubleSided property on the
reflection flattening layer so that backface-visibility works in all configurations.
Test: compositing/reflections/backface-hidden-reflection.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateBackfaceVisibility): Call setDoubleSided: on the structural layer for reflections. (WebCore::GraphicsLayerCA::ensureStructuralLayer): Fix a comment typo, and call updateBackfaceVisibility() when we gain a structural layer.
- 1:37 PM Changeset in webkit [65751] by
-
- 6 edits in trunk/WebKit2
2010-08-20 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Implement cursor change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44263
Implemented PageClient::setCursor.
- UIProcess/API/qt/qgraphicswkview.cpp: Added updateCursor slot to be connected to the QWKPage::setCursor signal. (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::updateCursor): Sets the cursor of the widget.
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::setCursor): Added implementation for PageClient::setCursor. Emitting singal through the QWKPage.
- UIProcess/API/qt/qwkpage.h: Added setCursor signal.
- UIProcess/API/qt/qwkpage_p.h:
- 1:19 PM Changeset in webkit [65750] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-08-20 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline.
New test was added in r65746, it requires a new chromium-linux baseline.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Added.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Added.
- 12:44 PM Changeset in webkit [65749] by
-
- 2 edits in trunk/WebCore
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
style correction in markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=44318
Make markup.cpp pass check-webkit-style.
No new tests are added since this is a cleanup.
- editing/markup.cpp: (WebCore::MarkupAccumulator::appendAttributeValue): (WebCore::appendEscapedContent): (WebCore::MarkupAccumulator::appendStartMarkup): (WebCore::completeURLs): (WebCore::isElementPresentational): (WebCore::isSpecialAncestorBlock): (WebCore::shouldIncludeWrapperForFullySelectedRoot): (WebCore::createMarkup): (WebCore::fillContainerFromString): (WebCore::createFragmentFromText): (WebCore::createFragmentFromNodes):
- 12:23 PM Changeset in webkit [65748] by
-
- 3 edits2 adds in trunk
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
crash when trying to access a stale Node pointer in FocusController::setFocusedNode
https://bugs.webkit.org/show_bug.cgi?id=44226
- fast/events/focus-change-crash2-expected.txt: Added.
- fast/events/focus-change-crash2.html: Added.
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
crash when trying to access a stale Node pointer in FocusController::setFocusedNode
https://bugs.webkit.org/show_bug.cgi?id=44226
Test: fast/events/focus-change-crash2.html
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): add a ref to prevent the focused node from being deleted
- 12:02 PM Changeset in webkit [65747] by
-
- 3 edits2 adds in trunk
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix a null pointer crash when dispatching JS keyboard events
https://bugs.webkit.org/show_bug.cgi?id=44313
- fast/events/initkeyboardevent-crash-expected.txt: Added.
- fast/events/initkeyboardevent-crash.html: Added.
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix a null pointer crash when dispatching JS keyboard events
https://bugs.webkit.org/show_bug.cgi?id=44313
- src/WebInputEventConversion.cpp: (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
- 12:02 PM BuildingQtOnOSX edited by
- mention QtXmlPatterns (diff)
- 11:49 AM Changeset in webkit [65746] by
-
- 3 edits4 adds in trunk
2010-08-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Slider labels do not update as you move the sliders on this page
https://bugs.webkit.org/show_bug.cgi?id=41020
When repainting after layout in a multicol element, we need to adjust the
repaint rect for the columns.
Test: fast/repaint/multicol-repaint.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
- 11:33 AM Changeset in webkit [65745] by
-
- 8 edits1 copy1 move in trunk/WebCore
Move FileStreamClient to platform and add AsyncFileStream interface.
https://bugs.webkit.org/show_bug.cgi?id=44224
Reviewed by David Levin.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/FileStreamProxy.cpp: Account for the change.
(WebCore::FileStreamProxy::FileStreamProxy):
(WebCore::FileStreamProxy::stop):
- html/FileStreamProxy.h: Make it derive from AsyncFileStream.h.
- platform/AsyncFileStream.h: Added.
- platform/FileStreamClient.h: Renamed from WebCore/html/FileStreamClient.h.
- 11:25 AM BuildingQtOnOSX edited by
- Fix for potential include problem (diff)
- 11:24 AM Changeset in webkit [65744] by
-
- 4 edits1 add in trunk
2010-08-20 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.
- CMakeListsEfl.txt: Depend on Fontconfig, PNG, JPEG and dl libraries.
2010-08-20 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.
- cmake/FindFontconfig.cmake: Added.
- cmake/OptionsEfl.cmake: Find Fontconfig, JPEG, and PNG libraries.
- 11:12 AM Changeset in webkit [65743] by
-
- 6 edits7 deletes in trunk/WebKit/chromium
2010-08-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Removing the deprecated class WebEvent and friends.
https://bugs.webkit.org/show_bug.cgi?id=44296
- WebKit.gyp:
- public/WebEvent.h: Removed.
- public/WebEventListener.h: Removed.
- public/WebMutationEvent.h: Removed.
- public/WebNode.h:
- src/EventListenerWrapper.cpp: (WebKit::EventListenerWrapper::webDOMEventListenerDeleted):
- src/EventListenerWrapper.h:
- src/WebEvent.cpp: Removed.
- src/WebEventListener.cpp: Removed.
- src/WebEventListenerPrivate.cpp: Removed.
- src/WebEventListenerPrivate.h: Removed.
- src/WebNode.cpp: (WebKit::WebNode::removeEventListener):
- 11:00 AM Changeset in webkit [65742] by
-
- 5 edits2 adds in trunk
2010-08-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Prevent use of stale notification presenter pointer in notifications by instead using
a notification center pointer and deriving the presenter from it. Notification presenter
gets properly destroyed using disconnectFrame function inside notification center. Add
null checks for notification presenter.
https://bugs.webkit.org/show_bug.cgi?id=43645
Test: fast/notifications/notifications-window-close-crash.html
- notifications/Notification.cpp: (WebCore::Notification::Notification): (WebCore::Notification::create): (WebCore::Notification::show): (WebCore::Notification::cancel): (WebCore::Notification::contextDestroyed): (WebCore::Notification::finishLoading):
- notifications/Notification.h: (WebCore::Notification::detachPresenter):
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
2010-08-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Manual test to check that canceling the notification on a closed window does
not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=43645
- fast/notifications/notifications-window-close-crash-expected.txt: Added.
- fast/notifications/notifications-window-close-crash.html: Added.
- 10:50 AM Changeset in webkit [65741] by
-
- 3 edits in trunk/WebCore
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
r64526 broke the GTK+-3 build
https://bugs.webkit.org/show_bug.cgi?id=44254
No new tests, as this is covered by manual-tests/cursor.html.
- platform/gtk/CursorGtk.cpp: (WebCore::createPixmapFromBits): Added this method which turns the inline data structures into GdkPixmaps using Cairo and GDK-Cairo. (WebCore::createNamedCursor): Modified this method to use the new helper.
- platform/gtk/CursorGtk.h: Changed all inline data structures to be unsigned char arrays (which Cairo requires). The progress cursor is known in X11 icon themes as "left_ptr_watch." This change to the name preserves the old behavior of taking this icon from the theme when available. It seems that this worked in the past due to a fluke or failure of the previous code.
- 10:24 AM Changeset in webkit [65740] by
-
- 14 edits in trunk
2010-08-19 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Fix failing WebGL tests in Chromium in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44305
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): Add implementation.
2010-08-19 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Fix failing WebGL tests in Chromium in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44305
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Add "#ifdef GLES" around precision keywords.
- fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Re-enable the failing tests.
- fast/canvas/webgl/gl-bind-attrib-location-test.html: Add "#ifdef GLES" around precision keywords.
- fast/canvas/webgl/read-pixels-pack-alignment-expected.txt: Ditto.
- fast/canvas/webgl/read-pixels-pack-alignment.html: Ditto.
- fast/canvas/webgl/resources/fragmentShader.frag: Ditto.
- fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
- fast/canvas/webgl/texture-active-bind.html: Ditto.
- fast/canvas/webgl/texture-complete.html: Ditto.
- fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
- platform/chromium/test_expectations.txt: Ditto.
- 10:13 AM Changeset in webkit [65739] by
-
- 2 edits in trunk/LayoutTests
2010-08-20 Martin Robinson <mrobinson@igalia.com>
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
- platform/gtk/Skipped: Skip failing tests.
- 10:07 AM Changeset in webkit [65738] by
-
- 2 edits in trunk/LayoutTests
2010-08-20 John Gregg <johnnyg@google.com>
Unreviewed, test expectations.
Add fail expectations for some SVG tests after r65729. See bug 44341.
- platform/chromium/test_expectations.txt:
- 9:32 AM Changeset in webkit [65737] by
-
- 7 edits in trunk
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
- platform/gtk/Skipped: Unskip tests which should now be passing.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
Allow setting the inspector resources path via an environment variables
and add a method, inspectorFilesPath, to the WebKit InspectorClient that
encapsulates this logic.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to get the path to the resource. (WebKit::InspectorClient::inspectorFilesPath): Added. (WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method.
- WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
- Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate path before running tests.
- 9:01 AM Changeset in webkit [65736] by
-
- 2 edits in trunk/WebCore
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Eliminate full-surface copy from canvas.drawImage(...)
https://bugs.webkit.org/show_bug.cgi?id=44190
Covered by canvas layout tests.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::drawsUsingCopy): Return false now. (WebCore::ImageBuffer::clip): Add a link to the bug which tracks this feature. (WebCore::ImageBuffer::draw): Construct the bitmap image without the full-surface copy. (WebCore::ImageBuffer::drawPattern): Ditto.
- 8:13 AM Changeset in webkit [65735] by
-
- 2 edits in trunk/WebCore
2010-08-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[REGRESSION] r65608 broke gtk distcheck
https://bugs.webkit.org/show_bug.cgi?id=44333
Define the inspector.html as a noinst_DATA intead of using the dir
suffix, which is used for installation.
- GNUmakefile.am:
- 8:07 AM Changeset in webkit [65734] by
-
- 4 edits in trunk/WebKitTools
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Part 2 of 2
Add unit tests that were not landed in the first commit.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases: "SVN: binary file (isBinary true) using Windows line endings" "SVN: property diff, followed by file change diff using Windows line endings" "SVN: two consecutive property diffs using Windows line endings" "SVN: binary file with executable bit change usng Windows line endings" "SVN: binary file followed by property change on different file using Windows line endings" "SVN: binary file followed by file change on different file using Windows line endings" "SVN: file change diff with property change, followed by property change diff using Windows line endings" "SVN: file change diff with property change, followed by file change diff using Windows line endings"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases: "add svn:executable, followed by empty line and start of next diff using Windows line endings" "add svn:executable, followed by empty line and start of next property diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" "add svn:executable, followed by empty line and start of binary patch using Windows line endings" "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" "single-line '+' with trailing new line using Windows line endings" "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases: "single-line '-' change followed by empty line with Windows line endings" "multi-line '+' change and start of binary patch with Windows line endings"
- 7:48 AM Changeset in webkit [65733] by
-
- 2 edits in trunk/WebKit
2010-08-20 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
As opposed to WebCore, JavascriptCore and wtf, webkit is always a
shared library. After r65366, libewebkit.so was not being installed
anymore when building with SHARED_CORE=0 (which is the default). This
partially reverts that revision in order to fix this issue.
- CMakeLists.txt: always install webkit library.
- 7:45 AM Changeset in webkit [65732] by
-
- 2 edits in trunk/WebKitTools
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Fixes an issue where an empty line following the property value
in an SVN property change diff would not be detected if it had
Windows line endings (i.e. ended in CRLF). Hence it was consumed
as if it was part of a multi-line property value.
- Scripts/VCSUtils.pm:
- Modified parseSvnPropertyValue() to detect empty line with Windows line endings.
- Added toWindowsLineEndings().
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases: "SVN: binary file (isBinary true) using Windows line endings" "SVN: property diff, followed by file change diff using Windows line endings" "SVN: two consecutive property diffs using Windows line endings" "SVN: binary file with executable bit change usng Windows line endings" "SVN: binary file followed by property change on different file using Windows line endings" "SVN: binary file followed by file change on different file using Windows line endings" "SVN: file change diff with property change, followed by property change diff using Windows line endings" "SVN: file change diff with property change, followed by file change diff using Windows line endings"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases: "add svn:executable, followed by empty line and start of next diff using Windows line endings" "add svn:executable, followed by empty line and start of next property diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next diff using Windows line endings" "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings" "add svn:executable, followed by empty line and start of binary patch using Windows line endings" "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings" "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings" "single-line '+' with trailing new line using Windows line endings" "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings" "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings" "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases: "single-line '-' change followed by empty line with Windows line endings" "multi-line '+' change and start of binary patch with Windows line endings"
- 6:38 AM Changeset in webkit [65731] by
-
- 12 edits in trunk
2010-08-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement breaking on DOM node subtree mutations.
https://bugs.webkit.org/show_bug.cgi?id=42886
Add two entries to Web Inspector DOM element context menu:
- "Stop on subtree modifications": will break on adding/removing of any element which is a child of the DOM element
- "Remove breakpoints": will remove all breakpoints associated with the DOM element
- English.lproj/localizedStrings.js:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent):
- bindings/v8/ScriptDebugServer.h:
- inspector/Inspector.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::pauseOnBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/Settings.js:
2010-08-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: enable DOM breakpoints for chromium
https://bugs.webkit.org/show_bug.cgi?id=42886
- src/js/DevTools.js: (WebInspector.loaded):
- 4:34 AM Changeset in webkit [65730] by
-
- 7 edits in trunk/WebCore
2010-08-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: discard InjectedScript reference on ScriptState when clearing injected scripts
https://bugs.webkit.org/show_bug.cgi?id=44328
Otherwise if the reference is not cleared we may remove InjectedScript from the
map on InjectedScriptHost but keep it on ScriptState and try to reuse it later.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::discardInjectedScript):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::discardInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScript.h: (WebCore::InjectedScript::scriptState):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::discardInjectedScripts):
- inspector/InjectedScriptHost.h:
- 2:13 AM Changeset in webkit [65729] by
-
- 4 edits4 adds in trunk
2010-08-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Clippers are rasterized, when applied to scaled target object
https://bugs.webkit.org/show_bug.cgi?id=44325
Use SVGImageBufferTools logic for RenderSVGResourceClipper, just like RenderSVGResourceMasker/Gradient,
to avoid pixelation, when the clipper is applied to a scaled target object, or when the document is scaled.
Test: svg/clip-path/clip-path-pixelation.svg
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext): (WebCore::RenderSVGResourceClipper::createClipData):
- rendering/RenderSVGResourceClipper.h:
2010-08-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Clippers are rasterized, when applied to scaled target object
https://bugs.webkit.org/show_bug.cgi?id=44325
- platform/mac/svg/clip-path/clip-path-pixelation-expected.checksum: Added.
- platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Added.
- platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Added.
- svg/clip-path/clip-path-pixelation.svg: Added.
- 1:12 AM Changeset in webkit [65728] by
-
- 2 edits in trunk/WebCore
2010-08-20 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Initialize GDK before loading plugins
https://bugs.webkit.org/show_bug.cgi?id=44324
Attempt to call gdk_init_check() before loading any plugins.
This prevents various crashes and freezes in Adobe's Flash plugin.
- plugins/qt/PluginPackageQt.cpp: (WebCore::initializeGdkIfPossible): (WebCore::PluginPackage::load):
- 12:58 AM Changeset in webkit [65727] by
-
- 2 edits in trunk/WebCore
Follow-up to r41020.
Reviewed by Mark Rowe.
No change in behavior, thus no new tests.
- platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Asserted that the NSFont parameter is not nil,
and removed nil check.
(WebCore::FontPlatformData::setFont): Asserted that the NSFont parameter is not nil and that
this is not the deleted value, and removed code to handle those cases.
Aug 19, 2010:
- 9:51 PM Changeset in webkit [65726] by
-
- 4 edits in trunk
2010-08-19 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
[chromium] TilingData::tilePositionY has typo of X where Y should be used
https://bugs.webkit.org/show_bug.cgi?id=44195
Corrected error, and rewrote functions to use for loop instead of recursion.
Unit Tests added to WebKit/chromium/tests/TilingDataTest.cpp
- platform/graphics/chromium/TilingData.cpp: (WebCore::TilingData::tilePositionX): (WebCore::TilingData::tilePositionY):
2010-08-19 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
[chromium] TilingData::tilePositionY has typo of X where Y should be used
https://bugs.webkit.org/show_bug.cgi?id=44195
Unit tests added for tileSize and tilePosition.
- tests/TilingDataTest.cpp: (WebCore::TEST):
- 9:28 PM Changeset in webkit [65725] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-08-19 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update for r65723.
- platform/chromium-win/fast/forms/listbox-selection-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 8:57 PM Changeset in webkit [65724] by
-
- 5 edits1 copy3 moves3 adds in trunk
2010-08-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
Assertion failure when going back inside frame during onload
https://bugs.webkit.org/show_bug.cgi?id=44217
Adds a test that does a history.back() within the main frame during
onload of a child frame. If HISTORY_ALWAYS_ASYNC was set to 0, this
would crash the DRT with an assertion failure, since we hadn't called
updateForFrameLoadCompleted in the main frame yet.
(renames history-back-within-subframe to history-back-within-subframe-hash
to differentiate between the two otherwise similar tests)
- fast/history/history-back-within-subframe-hash-expected.txt: Renamed from LayoutTests/fast/history/history-back-within-subframe-expected.txt.
- fast/history/history-back-within-subframe-hash.html: Renamed from LayoutTests/fast/history/history-back-within-subframe.html.
- fast/history/history-back-within-subframe-url-expected.txt: Added
- fast/history/history-back-within-subframe-url.html: Added.
- fast/history/resources/history-back-within-subframe-hash-2.html: Renamed from LayoutTests/fast/history/resources/history-back-within-subframe-2.html.
- fast/history/resources/history-back-within-subframe-url-2.html: Added.
- fast/history/resources/history-back-within-subframe-url-3.html: Added.
2010-08-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
Assertion failure when going back inside frame during onload
https://bugs.webkit.org/show_bug.cgi?id=44217
Fix assertion failure when doing a history.back() within the main frame
during onload of a child frame. This would happen when
HISTORY_ALWAYS_ASYNC was set to 0, because we would only compare the
current frame document sequence numbers when determining if we're in the
same document, instead of also recursing over child frames.
Test: fast/history/history-back-within-subframe-hash.html
- history/HistoryItem.cpp: (WebCore::HistoryItem::hasSameDocuments):
- history/HistoryItem.h:
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- 8:37 PM Changeset in webkit [65723] by
-
- 3 edits1 add in trunk/LayoutTests
2010-08-19 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Improve portability of fast/forms/listbox-selection.html
https://bugs.webkit.org/show_bug.cgi?id=35786
Changed to use script-tests style for improving portability.
- For sending mouse events to the target element, calculating the item height at runtime instead using Mac-specific metrics.
- Using mouseDown(), mouseUp(), and keyDown() to send events with modifier keys in a platform-independent way.
- fast/forms/listbox-selection-expected.txt: Updated to match with new test.
- fast/forms/listbox-selection.html: Modified to use script-tests style.
- fast/forms/script-tests/listbox-selection.js: Added.
- 7:51 PM Changeset in webkit [65722] by
-
- 4 edits in trunk
2010-08-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Fix cursor change propagation
https://bugs.webkit.org/show_bug.cgi?id=44250
No functional change so new tests.
Propagate the setCursor callback to the PageClient via the HostWindow instead of preassuming
the concrete type of the ChromeClient (what was generally wrong and actually incompatible with WebKit2).
- platform/qt/WidgetQt.cpp: (WebCore::Widget::setCursor):
2010-08-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Fix cursor change propagation
https://bugs.webkit.org/show_bug.cgi?id=44250
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setCursor): Implemented. Propagete the callback forward to the PageClient.
- 6:22 PM Changeset in webkit [65721] by
-
- 3 edits2 adds22 deletes in trunk/LayoutTests
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html
https://bugs.webkit.org/show_bug.cgi?id=44220
Converted the tests.
- editing/pasteboard/4242293-1-expected.txt: Added.
- editing/pasteboard/4242293-1.html:
- editing/pasteboard/copy-paste-bidi-expected.txt: Added.
- editing/pasteboard/copy-paste-bidi.html:
- platform/chromium-linux/editing/pasteboard/4242293-1-expected.checksum: Removed.
- platform/chromium-linux/editing/pasteboard/4242293-1-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
- platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/4242293-1-expected.checksum: Removed.
- platform/chromium-win/editing/pasteboard/4242293-1-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/4242293-1-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
- platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/4242293-1-expected.checksum: Removed.
- platform/mac-leopard/editing/pasteboard/4242293-1-expected.png: Removed.
- platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
- platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
- platform/mac/editing/pasteboard/4242293-1-expected.checksum: Removed.
- platform/mac/editing/pasteboard/4242293-1-expected.png: Removed.
- platform/mac/editing/pasteboard/4242293-1-expected.txt: Removed.
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
- platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
- platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
- 6:05 PM Changeset in webkit [65720] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 Martin Robinson <mrobinson@igalia.com>
[GTK] r65681 broke a couple GTK+ a11y tests
https://bugs.webkit.org/show_bug.cgi?id=44316
- platform/gtk/Skipped: Skip some newly failing tests.
- 5:58 PM Changeset in webkit [65719] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 James Robinson <jamesr@chromium.org>
Unreviewed. Clean up test_expectations now that tables/hittesting/filltable-* pass on Chromium.
- platform/chromium/test_expectations.txt:
- 5:47 PM Changeset in webkit [65718] by
-
- 5 edits3 adds in trunk/WebKit/chromium
2010-08-19 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add WebKit API for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=43151
Add asynchronous FileSystem interface to WebKit API for
FileSystem API.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
- WebKit.gyp:
- public/WebFileError.h: Added.
- public/WebFileSystem.h: Added.
- public/WebFileSystemEntry.h: Added.
- public/WebFileSystemCallbacks.h: Added.
- public/WebKitClient.h: (WebKit::WebKitClient::fileSystem):
- public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):
- 5:46 PM Changeset in webkit [65717] by
-
- 13 edits2 adds2 deletes in trunk/WebCore
2010-08-19 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Rearranging the accelerated compositing code such that the
layer rendering logic now lives in the layer classes rather than the
compositor. This lifts the restriction of having one texture per layer
and significantly cleans up the compositor code. This change mostly
resulted in a lot of code moving around files. Noteworthy changes
include:
- Made LayerChromium a proper based class for layers that mostly handles the updates to the layer properties and superlayer / sublayer updates.
- Introduced a new layer type, ContentLayerChromium, which handles layers that require a GraphicsContext to render their content.
- ImageLayerChromium and VideoLayerChromium now derive from ContentLayerChromium as they share the same shader and draw function.
- Removed TransformLayerChromium as its functionality is now replaced by the base LayerChromium class.
- Re-arranged the order in which the members of LayerChromium are defined in the header file to form a more reasonable logical grouping.
- Changed LayerRendererChromium to use the shader creation and drawing methods defined in the layer classes. As a result, a lot of GL code was removed from the implementation file.
- Eliminated randomly dispersed calls to check for GL errors by a macro (GLC) which allows turning error testing on/off with a single define (DEBUG_GL_CALLS defined in LayerRendererChromium.h)
- Replaced the previous layer render loop with two traversals of the layer hierarchy, the first to update transforms and opacity values and the second to render the layers. Eliminated global Z sorting of all layers as it was wrong. https://bugs.webkit.org/show_bug.cgi?id=44148
Test: Verified that pages using the compositor and compositor
layout tests have not regressed.
- WebCore.gypi:
- platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::SharedValues::SharedValues): (WebCore::CanvasLayerChromium::SharedValues::~SharedValues): (WebCore::CanvasLayerChromium::updateContents): (WebCore::CanvasLayerChromium::draw):
- platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::SharedValues::canvasShaderProgram): (WebCore::CanvasLayerChromium::SharedValues::shaderSamplerLocation): (WebCore::CanvasLayerChromium::SharedValues::shaderMatrixLocation): (WebCore::CanvasLayerChromium::SharedValues::shaderAlphaLocation): (WebCore::CanvasLayerChromium::SharedValues::initialized):
- platform/graphics/chromium/ContentLayerChromium.cpp: Added. (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::SharedValues::~SharedValues): (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h: Added. (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::SharedValues::contentShaderProgram): (WebCore::ContentLayerChromium::SharedValues::shaderSamplerLocation): (WebCore::ContentLayerChromium::SharedValues::shaderMatrixLocation): (WebCore::ContentLayerChromium::SharedValues::shaderAlphaLocation): (WebCore::ContentLayerChromium::SharedValues::initialized):
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::ImageLayerChromium): (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::SharedValues::~SharedValues): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::createShaderProgram): (WebCore::LayerChromium::toGLMatrix): (WebCore::LayerChromium::drawTexturedQuad): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::prepareForDraw):
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::contentsDirty): (WebCore::LayerChromium::drawsContent): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::draw): (WebCore::LayerChromium::SharedValues::quadVerticesVbo): (WebCore::LayerChromium::SharedValues::quadElementsVbo): (WebCore::LayerChromium::SharedValues::maxTextureSize): (WebCore::LayerChromium::SharedValues::borderShaderProgram): (WebCore::LayerChromium::SharedValues::borderShaderMatrixLocation): (WebCore::LayerChromium::SharedValues::borderShaderColorLocation): (WebCore::LayerChromium::SharedValues::initialized): (WebCore::LayerChromium::layerRenderer):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::debugGLCall): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::checkTextureSize): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::projectionMatrix): (WebCore::LayerRendererChromium::layerSharedValues): (WebCore::LayerRendererChromium::contentLayerSharedValues): (WebCore::LayerRendererChromium::canvasLayerSharedValues):
- platform/graphics/chromium/TransformLayerChromium.cpp: Removed.
- platform/graphics/chromium/TransformLayerChromium.h: Removed.
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateContents): (WebCore::VideoLayerChromium::createTextureRect):
- platform/graphics/chromium/VideoLayerChromium.h:
- 5:40 PM Changeset in webkit [65716] by
-
- 6 edits in trunk/WebCore
2010-08-19 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Clean up some selection code
https://bugs.webkit.org/show_bug.cgi?id=44314
Change the concept of "layout" in SelectionController to "updateCaretRect", renaming
methods accordingly.
Move selection and printing methods in RenderView.h into groups.
No behavioral changes.
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::setCaretRectNeedsUpdate): (WebCore::SelectionController::updateCaretRect): (WebCore::SelectionController::localCaretRect): (WebCore::SelectionController::recomputeCaretRect): Test m_caretRectNeedsUpdate first. (WebCore::SelectionController::invalidateCaretRect):
- editing/SelectionController.h:
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderView.h: (WebCore::RenderView::selectionStart): (WebCore::RenderView::selectionEnd): (WebCore::RenderView::printRect): (WebCore::RenderView::setPrintRect):
- 5:03 PM Changeset in webkit [65715] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-19 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
[Chromium] Rolls Chromium DEPS forward to 56564
https://bugs.webkit.org/show_bug.cgi?id=44281
Roll Chromium DEPS forward to 56564 to include WebFileSystem
implementation changes.
- DEPS:
- 4:39 PM Changeset in webkit [65714] by
-
- 6 edits5 moves5 deletes in trunk/LayoutTests
2010-08-19 Fady Samuel <fsamuel@chromium.org>
Reviewed by Dimitri Glazkov.
Fixed table hit testing layout test issues
https://bugs.webkit.org/show_bug.cgi?id=44204
Moved expectations to the same directory as tests.
Expectations were failing due to inconsistent eventSender behavior:
Switched to using elementFromPoint
- platform/gtk/tables/hittesting/filltable-emptycells-expected.txt: Removed.
- platform/gtk/tables/hittesting/filltable-levels-expected.txt: Removed.
- platform/gtk/tables/hittesting/filltable-outline-expected.txt: Removed.
- platform/gtk/tables/hittesting/filltable-rtl-expected.txt: Removed.
- platform/gtk/tables/hittesting/filltable-stress-expected.txt: Removed.
- tables/hittesting/filltable-emptycells-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-emptycells-expected.txt.
- tables/hittesting/filltable-emptycells.html:
- tables/hittesting/filltable-levels-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-levels-expected.txt.
- tables/hittesting/filltable-levels.html:
- tables/hittesting/filltable-outline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-outline-expected.txt.
- tables/hittesting/filltable-outline.html:
- tables/hittesting/filltable-rtl-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-rtl-expected.txt.
- tables/hittesting/filltable-rtl.html:
- tables/hittesting/filltable-stress-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-stress-expected.txt.
- tables/hittesting/filltable-stress.html:
- 3:52 PM Changeset in webkit [65713] by
-
- 6 edits in trunk
BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
WebCore:
- WebCore.exp.in:
(WebCore::ScrollView::contentsToWindow): Added export.
WebKit2:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint): Changed frameRect() to
m_frameRect.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction): Updated method signature.
(decidePolicyForNewWindowAction): Updated method signature.
- 3:35 PM Changeset in webkit [65712] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-08-19 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
<style> inside <noscript> is parsed when JavaScript is enabled.
https://bugs.webkit.org/show_bug.cgi?id=44021
More random bugs fixed by the HTML5 parser. Time to document with a
couple tests. I added both these tests because <noscript> in <body> is
slightly different than <noscript> before <body>.
- fast/parser/no-style-in-noscript-expected.txt: Added.
- fast/parser/no-style-in-noscript-with-body-expected.txt: Added.
- fast/parser/no-style-in-noscript-with-body.html: Added.
- fast/parser/no-style-in-noscript.html: Added.
- 3:09 PM Changeset in webkit [65711] by
-
- 4 edits in trunk
BUILD FIX #3: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
Still trying to make Qt Linux Release minimal buildbot happy.
WebCore:
- plugins/PluginViewNone.cpp: Compile missing methods for Qt.
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin): Wrap code that
handles Netscape plugins in #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif.
- 2:59 PM Changeset in webkit [65710] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Jon Honeycutt.
Add a few items in the WebKitTestRunner Skipped list.
- platform/mac-wk2/Skipped:
- 2:41 PM Changeset in webkit [65709] by
-
- 2 edits in trunk/LayoutTests
Add a few items in the WebKitTestRunner Skipped list.
Rubber-stamped by Jon Honeycutt.
- platform/mac-wk2/Skipped:
- 2:32 PM Changeset in webkit [65708] by
-
- 2 edits in trunk/WebKit/qt
BUILD FIX: FrameLoaderClientQt.h should include ResourceError.h
- WebCoreSupport/FrameLoaderClientQt.h: Include ResourceError.h.
- 2:25 PM Changeset in webkit [65707] by
-
- 2 edits in trunk/WebCore
BUILD FIX: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
Reviewed by Joseph Pecoraro.
- plugins/PluginView.cpp: Added #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif macros around the source to fix the Qt Linux Release
Minimal build.
- 2:23 PM Changeset in webkit [65706] by
-
- 2 edits in trunk/WebKit2
Send mouse events to windowless plugins on Windows
This seems to have been the last issue blocking us from playing videos
on vimeo.com.
Fixes <http://webkit.org/b/44276> <rdar://problem/8330398> Can't click
play button in vimeo.com Flash video player in WebKit2 on Windows
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::toNP): Added. Converts a WebMouseEvent to an NPEvent. Code
was adapted from WebCore's PluginViewWin.cpp.
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Convert the WebMouseEvent to an NPEvent and send it to the plugin.
- 2:22 PM Changeset in webkit [65705] by
-
- 8 edits in trunk/WebKit2
Add support for painting windowless plugins on Windows
This gets the video on the front page of vimeo.com painting (though
you can't make it play because we don't support mouse events yet).
Fixes <http://webkit.org/b/44274> <rdar://problem/8330398> Windowless
plugins don't paint in WebKit2 on Windows
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Tell the plugin that we support windowless
mode on Windows.
(WebKit::NPN_SetValue): Implemented handling of NPPVpluginWindowBool
by calling through to NetscapePlugin::setIsWindowed.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Added initialization of
m_isWindowed. It defaults to false on Mac and true on other platforms,
matching WebCore's PluginView.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added m_isWindowed.
(WebKit::NetscapePlugin::setIsWindowed): Added standard setter.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint): Moved Mac-specific context
translation code here from PluginView::paint.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint): Implemented. Code was ported
from WebCore's PluginViewWin.cpp.
- WebProcess/Plugins/Plugin.h: Updated the comment for Plugin::paint
to explain the coordinate system of the context.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Changed to translate the context from
document to window coordinates. We were previously trying to translate
to plugin-local coordinates, but this only worked for documents whose
origin was the same as the window's origin (i.e., the main frame). The
plugin takes care of any further translations needed. (Mac translates
the context into plugin-local coordinates, and Windows leaves it in
window coordinates.)
- 2:22 PM Changeset in webkit [65704] by
-
- 2 edits in trunk/WebKit2
Implement PluginInfoStore::pluginsDirectories
This makes WebKit2 able to find and load Flash on Windows.
Note that we aren't yet respecting the MozillaPlugins registry key.
That's covered by <http://webkit.org/b/44271>.
Fixes <http://webkit.org/b/43510> <rdar://problem/8273827> WebKit2
should load plugins from the same directories as old-WebKit
Reviewed by Jon Honeycutt and Ada Chan.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::parseVersionString):
(WebKit::compareVersions):
(WebKit::safariPluginsDirectory):
(WebKit::addMozillaPluginDirectories):
(WebKit::addWindowsMediaPlayerPluginDirectory):
(WebKit::addQuickTimePluginDirectory):
(WebKit::addAdobeAcrobatPluginDirectory):
(WebKit::addMacromediaPluginDirectories):
(WebKit::PluginInfoStore::pluginsDirectories):
Ported (and ever-so-slightly cleaned up) code from WebCore's
PluginDatabaseWin.cpp.
- 2:22 PM Changeset in webkit [65703] by
-
- 4 edits in trunk
Call NP_GetEntryPoints before NP_Initialize on Windows
Doing otherwise will cause Flash and QuickTime to crash inside
NP_Initialize.
Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows
Reviewed by Sam Weinig.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad): On Windows, first call
NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
prevent Silverlight (e.g.) from crashing (see r38858).
WebKitTools:
Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order
The order differs between Mac and Windows (see r38858).
- DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior. Crash on Mac
if NP_GetEntryPoints has been called already. This matches
Silverlight's behavior.
- 2:21 PM Changeset in webkit [65702] by
-
- 3 edits1 add in trunk/WebKit2
Add NetscapePluginWin.cpp
Fixes <http://webkit.org/b/44269> <rdar://problem/8330391>
NetscapePlugin.h contains functions that should be in
NetscapePluginWin.cpp
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Moved functions from
here...
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: ...to here.
- win/WebKit2.vcproj: Added NetscapePluginWin.cpp and let VS reorder
the file list.
- 2:21 PM Changeset in webkit [65701] by
-
- 2 edits in trunk/WebKitTools
Make build-webkittestrunner build TestNetscapePlugIn on Windows
Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
Reviewed by Sam Weinig.
- WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
Threaded it in between ImageDiff and InjectedBundleGenerated.
- 2:13 PM Changeset in webkit [65700] by
-
- 4 edits in trunk/WebCore
2010-08-19 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
[CHROMIUM] Assert w/canvas image draw
https://bugs.webkit.org/show_bug.cgi?id=44279
Don't use bitmap->pixelRef()->getPixels() directly; prefer
bitmap->pixels() and an SkAutoLockPixels. Also, make sure to set
the backing store state to Software when it was None. This handles
missing draws when the first call is software. Finally, remove some
spurious prepareForSoftwareDraw() calls in addPath() and beginPath().
It's really the fillPath() or strokePath() that matters.
Covered by LayoutTests/fast/canvas/arc360.html and others.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::beginPath): Remove spurious prepareForSoftwareDraw() calls.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2): Lock SkBitmap's pixels, and use ->getPixels().
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw): Switch backing store state to Software when it was None.
- 2:09 PM Changeset in webkit [65699] by
-
- 8 edits in trunk/WebKit2
Add modifier key info to policy client functions in WebKit2
<rdar://problem/8185298>
https://bugs.webkit.org/show_bug.cgi?id=44280
Reviewed by Adam Roben.
- UIProcess/API/C/WKAPICast.h:
Add conversion function for modifiers and rename an incorrectly named
toWK to toRef.
- UIProcess/API/C/WKPage.h:
Add WKEventModifiers enum.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
- UIProcess/WebPolicyClient.h:
Pipe through modifier info.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::modifiersForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Get modifier info out of the NavigationInfo class in the same manner as
WebKit1.
- 2:03 PM Changeset in webkit [65698] by
-
- 3 edits in trunk/JavaScriptCore
2010-08-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Geoffrey Garen.
JSC: Move the static_cast into to(U)Int32 fast case
https://bugs.webkit.org/show_bug.cgi?id=44037
Do the static_cast<(u)int32_t> inline to avoid the function call overhead
for easily converted values (within (u)int32_t range.)
- runtime/JSValue.cpp: (JSC::toInt32SlowCase): (JSC::toUInt32SlowCase):
- runtime/JSValue.h: (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32):
- 1:51 PM Changeset in webkit [65697] by
-
- 15 edits in trunk
<http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
Reviewed by Joseph Pecoraro.
WebCore:
- WebCore.exp.in:
(WebCore::HTMLPlugInElement::getNPObject): Moved from general
section into ENABLE(NETSCAPE_PLUGIN_API) section.
(WebCore::FrameView::windowClipRectForLayer): Moved from
ENABLE(NETSCAPE_PLUGIN_API) section to general section since
it's used by WebKit2.
- plugins/PluginView.h: Added #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif macros as needed to make iOS WebKit build with
NETSCAPE_PLUGIN_API disabled.
- plugins/PluginViewNone.cpp: Ditto.
(WebCore::PluginView::platformGetValueStatic):
WebKit/mac:
- Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
USE(PLUGIN_HOST_PROCESS) to
USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
- Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
- Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
- Plugins/Hosted/ProxyInstance.mm: Ditto.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
- WebCoreSupport/WebChromeClient.mm: Ditto.
(WebChromeClient::createWindow):
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
(WebFrameLoaderClient::dispatchCreatePage):
- WebView/WebHTMLView.mm:
(needsCursorRectsSupportAtPoint): Added #if
ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
- WebView/WebView.mm:
(+[WebView _isNodeHaltedPlugin:]): Ditto.
(+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
(+[WebView _restartHaltedPluginForNode:]): Ditto.
- 1:46 PM Changeset in webkit [65696] by
-
- 2 edits in trunk/WebKitTools
2010-08-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
install rietveld's upload script from a versioned url
https://bugs.webkit.org/show_bug.cgi?id=44291
autoinstall expects the file at a given URL to never change.
In order to be able to update the file, we need to be able to
change the path.
- Scripts/webkitpy/thirdparty/init.py:
- 1:16 PM Changeset in webkit [65695] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 John Gregg <johnnyg@google.com>
Unreviewed, chromium test expectations.
Add expected failures for caret-based pixel tests. See bug 44290.
- platform/chromium/test_expectations.txt:
- 1:04 PM Changeset in webkit [65694] by
-
- 4 edits in trunk/WebKitTools
2010-08-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add --webkit_patch_id to reitveld uploads
https://bugs.webkit.org/show_bug.cgi?id=44289
This is the first step in having rietveld store which
patches have been uploaded and getting rid of the
in-rietveld flag.
- Scripts/webkitpy/common/net/rietveld.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/postcodereview.py:
- 12:48 PM Changeset in webkit [65693] by
-
- 8 edits7 adds in trunk/LayoutTests
2010-08-19 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaselines.
Add new baselines after http://trac.webkit.org/changeset/65665/
- platform/chromium-linux/svg/custom/pattern-rotate-expected.checksum: Added.
- platform/chromium-linux/svg/custom/pattern-rotate-expected.png: Added.
- platform/chromium-linux/svg/transforms: Added.
- platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
- platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
- platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-rotate-expected.checksum:
- platform/chromium-win/svg/custom/pattern-rotate-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
- platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
- platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium/test_expectations.txt
- 12:32 PM Changeset in webkit [65692] by
-
- 37 edits14 adds in trunk
2010-08-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make DocumentParser safer to use
https://bugs.webkit.org/show_bug.cgi?id=43055
This also includes a test from
https://bugs.webkit.org/show_bug.cgi?id=42099
These tests were kindly provided by Nate Chapin and Adam Barth.
- fast/frames/document-write-in-iframe-onload-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
- fast/frames/document-write-in-iframe-onload.html: Added.
- fast/frames/resources/set-src-to-javascript-url.html: Added.
- fast/frames/set-parent-src-synchronously-expected.txt: Added.
- fast/frames/set-parent-src-synchronously.html: Added.
- fast/parser/document-close-iframe-load-expected.txt: Added.
- fast/parser/document-close-iframe-load.html: Added.
- fast/parser/document-close-nested-iframe-load-expected.txt: Added.
- fast/parser/document-close-nested-iframe-load.html: Added.
- fast/parser/iframe-sets-parent-to-javascript-url-expected.txt: Added.
- fast/parser/iframe-sets-parent-to-javascript-url.html: Added.
- fast/parser/resources/set-parent-to-javascript-url.html: Added.
2010-08-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make DocumentParser safer to use
https://bugs.webkit.org/show_bug.cgi?id=43055
Make DocumentParser and its subclasses RefCounted, and protect
HTMLDocumentParser during parsing. It's possible for a parser to
get deleted if certain actions (e.g., a document.write()) occur
synchronously.
The original version of this patch was written by Nate Chapin.
DocumentParser doesn't actually have to be fully RefCounted, since
the only two things which should ever hold a reference to it are
Document and DocumentParser itself. However using RefCounted and
RefPtr was easier/cleaner than inventing a custom ref() scheme.
This deploys a new "detach()" method throughout the parsing
framework. detach() causes the parser to disconnect from the
document so that no further modifications will be made to the
document while any possible DocumentParser stacks are unwound.
The irony of this patch is that the new detach() system is never
used, since Document always outlives the DocumentParser in all of
our layout tests. There is an ASSERT in ~Document() to verify
that the DocumentParser will not outlive the Document.
However I expect that we will soon either find new test cases, or change
the architecture in such a way that DocumentParser will outlive
Document. At which point, the detach() plumbing will be crucial.
Right now detach() serves as a safe-guard against use-after-free bugs
for any case where DocumentParser does outlive the Document.
This also fixes test cases attached to:
https://bugs.webkit.org/show_bug.cgi?id=42099
Tests: fast/frames/document-write-in-iframe-onload.html
fast/frames/set-parent-src-synchronously.html
fast/parser/document-close-iframe-load.html
fast/parser/document-close-nested-iframe-load.html
fast/parser/iframe-sets-parent-to-javascript-url.html
- dom/Document.cpp:
- Added a new detachParser() call to be used anywhere we used to call m_parser.clear(). There is an ASSERT in ~DocumentParser which ensures that we get this right.
(WebCore::Document::removedLastRef):
(WebCore::Document::~Document):
(WebCore::Document::createParser):
(WebCore::Document::detachParser):
(WebCore::Document::cancelParsing):
(WebCore::Document::implicitOpen):
- removed redundant m_parser.clear()
(WebCore::Document::implicitClose):
- dom/Document.h:
- dom/DocumentParser.cpp:
(WebCore::DocumentParser::~DocumentParser):
- ASSERT that callers always call detach() before destruction.
- This ASSERT might prove too cumbersome, but for now it's useful.
(WebCore::DocumentParser::detach):
- dom/DocumentParser.h:
- dom/RawDataDocumentParser.h:
- dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::finish):
- Add a FIXME explaining part of the reason why stopParsing() and detach() are separate concepts.
- dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::create):
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::parseDocumentFragment):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseDocumentFragment):
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::detach): (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
- html/HTMLConstructionSite.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
- html/HTMLDocument.h:
- html/HTMLDocumentParser.cpp:
- We need to protect(this) before calling into any code which might cause the parser to be destroyed.
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::notifyFinished):
(WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):
(WebCore::HTMLDocumentParser::parseDocumentFragment):
- html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::create):
- html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::detach): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executeScript): (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTMLScriptRunner::runScript):
- html/HTMLScriptRunner.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::detach): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::finished):
- html/HTMLTreeBuilder.h:
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
- html/HTMLViewSourceDocument.h:
- html/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
- html/HTMLViewSourceParser.h: (WebCore::HTMLViewSourceParser::create):
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::create): (WebCore::FTPDirectoryDocument::createParser):
- loader/FTPDirectoryDocument.h:
- loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::create): (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocument::createParser):
- loader/ImageDocument.h:
- loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::create): (WebCore::MediaDocument::createParser):
- loader/MediaDocument.h:
- loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::create): (WebCore::PluginDocument::createParser):
- loader/PluginDocument.h:
- loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::create): (WebCore::SinkDocument::createParser):
- loader/SinkDocument.h:
- loader/TextDocument.cpp: (WebCore::TextDocumentParser::create): (WebCore::TextDocument::createParser): (WebCore::createTextDocumentParser):
- loader/TextDocument.h:
- 12:29 PM Changeset in webkit [65691] by
-
- 2 edits in trunk/WebCore
Fix compilation of SelectElement.cpp with ARROW_KEYS_POP_MENU == 0
Reviewed by Simon Fraser.
- dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler): Added
UNUSED_PARAM() macro for htmlForm argument when
ARROW_KEYS_POP_MENU defined as zero.
- 12:07 PM Changeset in webkit [65690] by
-
- 2 edits in trunk/WebCore
2010-08-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Disable XSLT for production configuration
https://bugs.webkit.org/show_bug.cgi?id=37445
Introduce a new CONFIG option to maintain stable configuration for
the QtWebKit port and disable XSLT for the stable configuration
because of bug 37445.
No new tests as there is no new functionality.
- features.pri:
- 11:59 AM Changeset in webkit [65689] by
-
- 13 edits2 adds in trunk
2010-08-18 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement strict type checking in js bindings for WebGL functions
https://bugs.webkit.org/show_bug.cgi?id=44202
Test: fast/canvas/webgl/bad-arguments-test.html
- bindings/js/JSWebGLRenderingContextCustom.cpp: Add type check for wrapper types and DOMString and throw error in case of mismatch. (WebCore::JSWebGLRenderingContext::getAttachedShaders): (WebCore::JSWebGLRenderingContext::getProgramParameter): (WebCore::JSWebGLRenderingContext::getShaderParameter): (WebCore::JSWebGLRenderingContext::getUniform): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Ditto. (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback): (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- html/canvas/WebGLRenderingContext.idl: Add attribute StrictTypeChecking for WebGL functions.
2010-08-18 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement strict type checking in js bindings for WebGL functions
https://bugs.webkit.org/show_bug.cgi?id=44202
- fast/canvas/webgl/bad-arguments-test-expected.txt: Added.
- fast/canvas/webgl/bad-arguments-test.html: Added.
- fast/canvas/webgl/error-reporting-expected.txt: Fix bugs due to strict type checking in the js bindings.
- fast/canvas/webgl/error-reporting.html: ditto.
- fast/canvas/webgl/gl-object-get-calls-expected.txt: ditto.
- fast/canvas/webgl/gl-object-get-calls.html: ditto.
- fast/canvas/webgl/null-object-behaviour-expected.txt: ditto.
- fast/canvas/webgl/null-object-behaviour.html: ditto.
- 11:45 AM Changeset in webkit [65688] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-19 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Fixing previous Mac only build breakage with TilingDataTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=44223
TilingDataTest.cpp included the wrong header, which had a compile
option around the definition of the WebCore namespace. Without the
namespace defined, error. Fixed by correctly including TilingData.h,
which has no conditional compilation.
- WebKit.gyp:
- tests/TilingDataTest.cpp:
- 11:44 AM Changeset in webkit [65687] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 John Gregg <johnnyg@google.com>
Unreviewed, test expectations.
Add some new exceptions for SVG failures, see
https://bugs.webkit.org/show_bug.cgi?id=44278
- platform/chromium/test_expectations.txt:
- 11:32 AM WebKit Team edited by
- Adjusting my (kbr's) status from committer to reviewer. (diff)
- 11:28 AM Changeset in webkit [65686] by
-
- 2 edits in trunk/BugsSite
2010-08-19 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
webkit-patch barfed on upload with a new image test result
https://bugs.webkit.org/show_bug.cgi?id=39097
- PrettyPatch/PrettyPatch.rb: don't use full path to git
- 11:25 AM Changeset in webkit [65685] by
-
- 2 edits in trunk/WebKitTools
2010-08-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Adjust my status from committer to reviewer
https://bugs.webkit.org/show_bug.cgi?id=44277
- Scripts/webkitpy/common/config/committers.py:
- 11:13 AM Changeset in webkit [65684] by
-
- 3 edits in trunk/LayoutTests
2010-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=33671
media/video-loop.html fails intermittently on GTK and Chromium bots
Rewrite test to make it less timing dependent.
- media/video-loop-expected.txt:
- media/video-loop.html:
- 10:56 AM Changeset in webkit [65683] by
-
- 2 edits in trunk/WebCore
2010-08-19 Simon Fraser <Simon Fraser>
Fix Chromium build.
- svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged):
- 10:35 AM Changeset in webkit [65682] by
-
- 3 edits in trunk/LayoutTests
2010-08-19 John Gregg <johnnyg@google.com>
Unreviewed; test expectations.
Update chromium-mac expectations for zoom-mask-with-percentages.svg after
http://trac.webkit.org/changeset/65665/
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- 10:19 AM Changeset in webkit [65681] by
-
- 19 edits in trunk/WebCore
2010-08-19 Simon Fraser <Simon Fraser>
Reviewed by Nikolas Zimmermann.
HTMLElement::isContentEditable() can cause an updateStyleIfNeeded() to happen in the middle of layout
https://bugs.webkit.org/show_bug.cgi?id=21834
<rdar://problem/8093653&8261394>
If we're in the middle of layout, or painting, and something causes updateStyleIfNeeded() to
get called, then we can end up entering recalcStyle() during layout or painting. This is bad
because it can create/destry the renderers and RenderLayers which are in use by layout/painting.
This is the cause of a number of random crashers, some of which show up more frequently
in content which uses accelerated compositing.
The changes here:
- Add an assertion in Document::updateStyleIfNeeded() that we are not laying out or painting.
- Remove calls to updateStyleIfNeeded() in editing and caret painting code
- Pass along information to CTM and BBox-related SVG methods to indicate whether it's safe to update style.
Tested by new assertions and existing tests.
- dom/Document.cpp: (WebCore::Document::updateStyleIfNeeded): New assertion that we are not mid-layout or painting. (WebCore::command): Call updateStyleIfNeeded() to ensure that subsequent calls to isContentEditable() return the correct result.
- dom/Element.cpp: (WebCore::Element::focus): Move the supportsFocus() call to after style has been updated.
- editing/SelectionController.cpp: (WebCore::SelectionController::localCaretRect): (WebCore::SelectionController::caretRepaintRect): (WebCore::SelectionController::paintCaret):
- editing/SelectionController.h: (WebCore::SelectionController::localCaretRectForPainting): When painting, use localCaretRectForPainting() which does not update style. Make localCaretRect() non-const so allowing it to update style without ugly casts.
- html/HTMLElement.cpp: (WebCore::HTMLElement::isContentEditable): Don't call updateStyleIfNeeded() here. (WebCore::HTMLElement::isContentRichlyEditable): Ditto. (WebCore::HTMLElement::contentEditable): Ditto.
- page/FrameView.h: (WebCore::FrameView::isMidLayout): New accessor, used for asserting.
- rendering/RenderPath.cpp: (WebCore::fillAndStrokePath): Pass DisallowStyleUpdate to getScreenCTM since we are painting.
- rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke): This is only called when painting, so use DisallowStyleUpdate.
- svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged): Changes to the style attribute should not have side effects, since a call to Element::getAttribute() is allowed to result in a call to setAttribute() for the style attribute. To avoid updateStyleIfNeeded() during painting, this must not cause SVG to do extra work.
- svg/SVGLocatable.cpp: Pass StyleUpdateStrategy down to these methods to indicate whether it's OK to update style. (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::computeCTM): (WebCore::SVGLocatable::getTransformToElement):
- svg/SVGLocatable.h: (WebCore::SVGLocatable::):
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getBBox): (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM): (WebCore::SVGStyledTransformableElement::getBBox):
- svg/SVGStyledTransformableElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getBBox): (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::getScreenCTM):
- svg/SVGTextElement.h:
- 10:16 AM Changeset in webkit [65680] by
-
- 2 edits in trunk/WebCore
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Range, EAnnotateForInterchange, and EAbsoluteURLs should be member variables of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=44229
No new tests are added since this is a clean up.
- editing/markup.cpp: (WebCore::MarkupAccumulator::MarkupAccumulator): Added shouldResolveURLs, shouldAnnotate, and range. (WebCore::MarkupAccumulator::shouldResolveURLs): Private inline accessor for m_shouldResolveURLs. (WebCore::MarkupAccumulator::shouldAnnotate): Private inline accessor for m_shouldAnnotate. (WebCore::MarkupAccumulator::appendEndTag): Renamed local variable result to markup. (WebCore::MarkupAccumulator::appendStartTag): Removed range, annotate, shouldResolveURLs from the function arguments. (WebCore::MarkupAccumulator::wrapWithNode): Ditto. (WebCore::MarkupAccumulator::appendStartMarkup): Ditto. (WebCore::serializeNodes): Ditto and uses MarkupAccumulator. (WebCore::createMarkup): Uses MarkupAccumulator. (WebCore::serializeNodesWithNamespaces): Ditto.
- 10:04 AM Changeset in webkit [65679] by
-
- 1 edit in trunk/BugsSite/ChangeLog
2010-08-19 Tony Chang <tony@chromium.org>
Unreviewed, setting svn:eol-style native on ChangeLog.
- 9:54 AM Changeset in webkit [65678] by
-
- 1 edit in trunk/BugsSite/ChangeLog
2010-08-19 Tony Chang <tony@chromium.org>
Unreviewed. Just removing \r's from ChangeLog.
- 9:46 AM Changeset in webkit [65677] by
-
- 2 edits in trunk/WebCore
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not dump inspector errors into the inspected window console.
https://bugs.webkit.org/show_bug.cgi?id=44272
- inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
- 9:11 AM Changeset in webkit [65676] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-19 Jochen Eisinger <jochen@chromium.org>
Reviewed by Pavel Feldman.
concatenated_devtools_js should depend on inspector_protocol_sources
https://bugs.webkit.org/show_bug.cgi?id=44255
- WebKit.gyp:
- 8:47 AM Changeset in webkit [65675] by
-
- 5 edits in trunk/WebKit2
Add ability to get all the keys from a WKDictionaryRef
https://bugs.webkit.org/show_bug.cgi?id=44221
Reviewed by Adam Roben.
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/ImmutableDictionary.h:
Add keys function.
- UIProcess/API/C/WKDictionary.cpp:
(WKDictionaryCopyKeys):
- UIProcess/API/C/WKDictionary.h:
Wrap keys function.
- 8:44 AM Changeset in webkit [65674] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: activate/deactivate breakpoints using v8 debugger flag.
https://bugs.webkit.org/show_bug.cgi?id=44112
- src/js/DebuggerScript.js: ():
- 8:19 AM Changeset in webkit [65673] by
-
- 3 edits in trunk/WebCore
2010-08-19 Jeremy Orlow <jorlow@chromium.org>
Chromium build fix.
Use ASSERT_UNUSED on variables that aren't used besides by the ASSERT.
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
- 8:06 AM Changeset in webkit [65672] by
-
- 5 edits in trunk
2010-08-19 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expose Panel.onSelectionChanged in extension API
https://bugs.webkit.org/show_bug.cgi?id=44171
- inspector/extensions-api-expected.txt:
- inspector/extensions-expected.txt:
2010-08-19 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expose Panel.onSelectionChanged in extension API
https://bugs.webkit.org/show_bug.cgi?id=44171
- inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI.PanelImpl): (injectedExtensionAPI):
- 8:04 AM Changeset in webkit [65671] by
-
- 3 edits in trunk/WebKitTools
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: remove injected script fetcher from test harness.
https://bugs.webkit.org/show_bug.cgi?id=44266
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- 7:53 AM Changeset in webkit [65670] by
-
- 32 edits17 copies5 adds in trunk
2010-08-19 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
https://bugs.webkit.org/show_bug.cgi?id=44101
- storage/indexeddb/resources/shared.js: (unexpectedErrorCallback):
- storage/indexeddb/script-tests/transaction-basics.js: Added. (abortCallback): (createTransactionCallback): (test):
- storage/indexeddb/transaction-basics-expected.txt: Added.
- storage/indexeddb/transaction-basics.html: Added.
2010-08-19 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
https://bugs.webkit.org/show_bug.cgi?id=44101
This change also introduces the TransactionCoordinator, which will be used
to schedule transactions for execution.
Test: storage/indexeddb/transaction-basics.html
- WebCore.gypi:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::didLeaveScriptContext):
- bindings/v8/V8Proxy.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBTransaction):
- dom/EventTarget.h:
- page/PageGroup.h: (WebCore::PageGroup::hasIDBFactory):
- storage/IDBAbortEvent.cpp: Added. (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent): (WebCore::IDBAbortEvent::~IDBAbortEvent):
- storage/IDBAbortEvent.h: Added. (WebCore::IDBAbortEvent::isIDBAbortEvent):
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::abortPendingTransactions):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBPendingTransactionMonitor.cpp: Added. (WebCore::IDBPendingTransactionMonitor::addPendingTransaction): (WebCore::IDBPendingTransactionMonitor::removePendingTransaction): (WebCore::IDBPendingTransactionMonitor::clearPendingTransactions): (WebCore::IDBPendingTransactionMonitor::pendingTransactions):
- storage/IDBPendingTransactionMonitor.h: Added.
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::id): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::timerFired):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendInterface.h:
- storage/IDBTransactionCallbacks.h: Added. (WebCore::IDBTransactionCallbacks::~IDBTransactionCallbacks):
- storage/IDBTransactionCoordinator.cpp: Added. (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore): (WebCore::IDBTransactionBackendImpl::mode): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::sqliteDatabase): (WebCore::IDBTransactionBackendImpl::id): (WebCore::IDBTransactionBackendImpl::setCallbacks): (WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator): (WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator): (WebCore::IDBTransactionCoordinator::createTransaction): (WebCore::IDBTransactionCoordinator::abort):
- storage/IDBTransactionCoordinator.h: Added. (WebCore::IDBTransactionCoordinator::create):
2010-08-19 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
https://bugs.webkit.org/show_bug.cgi?id=44101
- WebKit.gyp:
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::abortPendingTransactions):
- public/WebIDBTransaction.h: Added. (WebKit::WebIDBTransaction::~WebIDBTransaction): (WebKit::WebIDBTransaction::mode): (WebKit::WebIDBTransaction::objectStore): (WebKit::WebIDBTransaction::abort): (WebKit::WebIDBTransaction::id): (WebKit::WebIDBTransaction::setCallbacks):
- public/WebIDBTransactionCallbacks.h: Added. (WebKit::WebIDBTransactionCallbacks::~WebIDBTransactionCallbacks): (WebKit::WebIDBTransactionCallbacks::onAbort): (WebKit::WebIDBTransactionCallbacks::id):
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
- src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::abortPendingTransactions):
- src/IDBFactoryBackendProxy.h:
- src/IDBTransactionBackendProxy.cpp: Added. (WebCore::IDBTransactionBackendProxy::create): (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebCore::IDBTransactionBackendProxy::~IDBTransactionBackendProxy): (WebCore::IDBTransactionBackendProxy::objectStore): (WebCore::IDBTransactionBackendProxy::mode): (WebCore::IDBTransactionBackendProxy::abort): (WebCore::IDBTransactionBackendProxy::scheduleTask): (WebCore::IDBTransactionBackendProxy::sqliteDatabase): (WebCore::IDBTransactionBackendProxy::id): (WebCore::IDBTransactionBackendProxy::setCallbacks):
- src/IDBTransactionBackendProxy.h: Added.
- src/IDBTransactionCallbacksProxy.cpp: Added. (WebCore::IDBTransactionCallbacksProxy::create): (WebCore::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy): (WebCore::IDBTransactionCallbacksProxy::~IDBTransactionCallbacksProxy): (WebCore::IDBTransactionCallbacksProxy::onAbort): (WebCore::IDBTransactionCallbacksProxy::id):
- src/IDBTransactionCallbacksProxy.h: Added.
- src/WebDOMStringList.cpp: (WebKit::WebDOMStringList::length):
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::transaction):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::abortPendingTransactions):
- src/WebIDBFactoryImpl.h:
- src/WebIDBTransactionCallbacksImpl.cpp: Added. (WebCore::WebIDBTransactionCallbacksImpl::WebIDBTransactionCallbacksImpl): (WebCore::WebIDBTransactionCallbacksImpl::~WebIDBTransactionCallbacksImpl): (WebCore::WebIDBTransactionCallbacksImpl::onAbort): (WebCore::WebIDBTransactionCallbacksImpl::id):
- src/WebIDBTransactionCallbacksImpl.h: Added.
- src/WebIDBTransactionImpl.cpp: Added. (WebKit::WebIDBTransactionImpl::WebIDBTransactionImpl): (WebKit::WebIDBTransactionImpl::~WebIDBTransactionImpl): (WebKit::WebIDBTransactionImpl::mode): (WebKit::WebIDBTransactionImpl::objectStore): (WebKit::WebIDBTransactionImpl::abort): (WebKit::WebIDBTransactionImpl::id): (WebKit::WebIDBTransactionImpl::setCallbacks):
- src/WebIDBTransactionImpl.h: Added. (WebKit::):
- 7:47 AM Changeset in webkit [65669] by
-
- 8 edits in trunk
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Now that we populate front-end after its onload handler, we don't need
to install injected script early. Exposing injected script source on the WebCore
level here.
https://bugs.webkit.org/show_bug.cgi?id=44029
- inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::injectedScriptSource):
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Now that we populate front-end after its onload handler, I don't think we need
to install injected script early.
https://bugs.webkit.org/show_bug.cgi?id=44029
- public/WebDevToolsAgentClient.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::frontendLoaded):
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Now that we populate front-end after its onload handler, we don't need
to install injected script early. Exposing injected script source on the WebCore
level here.
https://bugs.webkit.org/show_bug.cgi?id=44029
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::runtimePropertyChanged): (DRTDevToolsAgent::delayedFrontendLoaded): (DRTDevToolsAgent::frontendLoaded):
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- 7:47 AM Changeset in webkit [65668] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Inject wmode=opaque for both QWebView and QGraphicsWebView on Maemo5
as Flash XEmbed support is flaky.
https://bugs.webkit.org/show_bug.cgi?id=44043
Reviewed by Kenneth Christiansen.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
- 7:38 AM Changeset in webkit [65667] by
-
- 16 edits in trunk
2010-08-18 Jeremy Orlow <jorlow@chromium.org>
Implement persistance for IndexedDB ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=44164
Remove old object stores before running test.
- storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
- storage/indexeddb/script-tests/objectstore-basics.js: (openSuccess):
- storage/indexeddb/script-tests/open-cursor.js: (openSuccess):
2010-08-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement persistance for IndexedDB ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=44164
Get rid of the in-memory storage of ObjectStores and instead
use SQL backed memory.
Existing tests give most of the coverage. Will update the manual
test in the next patch (which will also re-work database.description).
- manual-tests/indexed-database.html: Get rid of race where you can click before the page loads.
- platform/sql/SQLiteStatement.cpp: Add two helper functions (WebCore::SQLiteStatement::bindInt): (WebCore::SQLiteStatement::isColumnNull):
- platform/sql/SQLiteStatement.h:
- storage/IDBCursorBackendImpl.cpp:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::importObjectStores):
- storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::sqliteDatabase):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::sqliteDatabase):
- storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::whereClause): (WebCore::bindKey): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::importIndexes): (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
- storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create): (WebCore::IDBObjectStoreBackendImpl::database):
- 6:30 AM Changeset in webkit [65666] by
-
- 13 edits in trunk
LayoutTests
2010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Enable view mode media feature layout test
https://bugs.webkit.org/show_bug.cgi?id=43278
Unskip tests that are now passing.
- platform/gtk/Skipped:
WebKit/gtk
2010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Enable view mode media feature layout test
https://bugs.webkit.org/show_bug.cgi?id=43278
Add the view-mode property, to control the WebCore page's viewMode.
- docs/webkitgtk-sections.txt:
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (webkit_web_view_set_property): (webkit_web_view_class_init): (webkit_web_view_set_view_mode): (webkit_web_view_get_view_mode):
- webkit/webkitwebview.h:
WebKitTools
2010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Enable view mode media feature layout test
https://bugs.webkit.org/show_bug.cgi?id=43278
Add view mode media feature testing infrastructure, and add
placeholder methods for the other platforms'
LayoutTestControllers.
- DumpRenderTree/LayoutTestController.cpp: (setViewModeMediaFeatureCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setViewModeMediaFeature):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setViewModeMediaFeature):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setViewModeMediaFeature):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setViewModeMediaFeature):
- 5:41 AM Changeset in webkit [65665] by
-
- 76 edits16 adds in trunk
2010-08-19 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Pattern is rasterized
https://bugs.webkit.org/show_bug.cgi?id=41396
SVG pattern size changed when resizing browser
https://bugs.webkit.org/show_bug.cgi?id=38704
Incorrect pattern tilling
https://bugs.webkit.org/show_bug.cgi?id=41603
Apply same fixes to <pattern> that <mask> recently received. Build the tile image in absolute coordinates,
to avoid pixelation, when the target element is scaled. Also fixes problems when zooming into patterns.
Clamp ImageBuffer sizes to RenderSVGRoots viewport, now that gradient/pattern and mask buffers are created
in absolute coordinates -> no more huge image buffer allocations, that could fail.
Drop overflow="visible" support for <pattern>, which complicates the code a lot. Neither Opera nor Firefox
support this, and SVG 1.1 2nd Edition says that the rendering behaviour is "undefined".
Tests: svg/batik/paints/patternRegions-positioned-objects.svg
svg/custom/pattern-incorrect-tiling.svg
svg/custom/pattern-no-pixelation.svg
svg/transforms/text-with-mask-with-svg-transform.svg
- rendering/PaintInfo.h: (WebCore::PaintInfo::applyTransform): Don't alter the repaint rect if it's infinite (only affects SVG). (WebCore::PaintInfo::infiniteRect): Moved from RenderLayer into PaintInfo, as applyTransform() needs it.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): s/ClipRects::infiniteRect/PaintInfo::infiniteRect/
- rendering/RenderLayer.h: Moved infiniteRect() to PaintInfo.
- rendering/RenderLayerBacking.cpp: (WebCore::clipBox): s/ClipRects::infiniteRect/PaintInfo::infiniteRect/
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clippedByAncestor): Ditto.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Clamp image buffer size, use new SVGImageBufferTools helper methods for that. (WebCore::clipToTextMask): Adapt to renames/code changes in SVGImageBufferTools. (WebCore::RenderSVGResourceGradient::applyResource): Ditto.
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource): lamp image buffer size, use new SVGImageBufferTools helper methods for that. (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): Adapt to renames/code changes in SVGImageBufferTools.
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): Rewrite to create tile image buffers in absolute coordinates, avoids pixelation artefacts. (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::buildTileImageTransform): (WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/RenderSVGResourcePattern.h:
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::transformationToOutermostSVGCoordinateSystem): Helper method, concating all localToParentTransforms() up until RenderSVGRoot is reached. (WebCore::SVGImageBufferTools::createImageBuffer): Simplified. (WebCore::SVGImageBufferTools::clipToImageBuffer): Rename absoluteTargetRect to clampedAbsoluteTargetRect. (WebCore::SVGImageBufferTools::roundedImageBufferSize): New helper method to centralize FloatSize -> IntSize rounding, when creating image buffers. (WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer): New helper methods to clamp an image buffer rect against the viewport.
- rendering/SVGImageBufferTools.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::renderSubtreeToImage): Use PaintInfo::infiniteRect() as repaint rect, to avoid any culling. (WebCore::SVGRenderSupport::findTreeRootObject): Renamed from svgRootTreeObject, and expose it. (WebCore::SVGRenderSupport::layoutChildren): s/svgRootTreeObject/findTreeRootObject/.
- rendering/SVGRenderSupport.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentTranslate): Be sure to relayout on invalidation, otherwhise resources are not updated, and we have to update them, as they depend on the absolute transform.
2010-08-19 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Pattern is rasterized
https://bugs.webkit.org/show_bug.cgi?id=41396
SVG pattern size changed when resizing browser
https://bugs.webkit.org/show_bug.cgi?id=38704
Incorrect pattern tilling
https://bugs.webkit.org/show_bug.cgi?id=41603
Update pattern results after fixing the pixelation issues.
- platform/mac-leopard/svg/batik/paints/patternRegions-expected.checksum:
- platform/mac-leopard/svg/batik/paints/patternRegions-expected.png:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
- platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
- platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-gradient-creation-expected.checksum:
- platform/mac/svg/custom/js-late-gradient-creation-expected.png:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-pattern-creation-expected.checksum:
- platform/mac/svg/custom/js-late-pattern-creation-expected.png:
- platform/mac/svg/custom/non-scaling-stroke-expected.checksum:
- platform/mac/svg/custom/non-scaling-stroke-expected.png:
- platform/mac/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
- platform/mac/svg/custom/pattern-incorrect-tiling-expected.png: Added.
- platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
- platform/mac/svg/custom/pattern-no-pixelation-expected.checksum: Added.
- platform/mac/svg/custom/pattern-no-pixelation-expected.png: Added.
- platform/mac/svg/custom/pattern-no-pixelation-expected.txt: Added.
- platform/mac/svg/custom/pattern-rotate-expected.checksum:
- platform/mac/svg/custom/pattern-rotate-expected.png:
- platform/mac/svg/custom/stroked-pattern-expected.checksum:
- platform/mac/svg/custom/stroked-pattern-expected.png:
- platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
- platform/mac/svg/custom/text-rotated-gradient-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
- platform/mac/svg/text/selection-background-color-expected.checksum:
- platform/mac/svg/text/selection-background-color-expected.png:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
- platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
- platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- svg/batik/paints/patternRegions-positioned-objects.svg: Added.
- svg/custom/pattern-incorrect-tiling.svg: Added.
- svg/custom/pattern-no-pixelation.svg: Added.
- svg/transforms/text-with-mask-with-svg-transform.svg: Added.
- svg/transforms/text-with-pattern-inside-transformed-html.xhtml:
- 5:35 AM Changeset in webkit [65664] by
-
- 1 edit32 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
- platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
- platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
- platform/qt/fast/table/early-table-layout-expected.checksum: Added.
- platform/qt/fast/table/early-table-layout-expected.png: Added.
- platform/qt/fast/table/early-table-layout-expected.txt: Added.
- platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
- platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.checksum: Added.
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png: Added.
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
- platform/qt/svg/in-html: Added.
- platform/qt/svg/in-html/circle-expected.checksum: Added.
- platform/qt/svg/in-html/circle-expected.png: Added.
- platform/qt/svg/in-html/circle-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/qt/tables/layering: Added.
- platform/qt/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/qt/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/qt/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/qt/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/qt/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/qt/tables/layering/paint-test-layering-2-expected.txt: Added.
- 5:28 AM Changeset in webkit [65663] by
-
- 4 edits in trunk/WebKit/chromium
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: remove setRuntimeFeatureEnabled API method that
is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=44237
- public/WebDevToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
- 5:19 AM Changeset in webkit [65662] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Remove outdated reference to http/tests/history/redirect-*.pl tests
[Qt] DRT keepWebHistory is not being called in redirect-30*.pl tests
https://bugs.webkit.org/show_bug.cgi?id=34212
Those tests have been renamed on
http://trac.webkit.org/changeset/65340
And are passing on the bot since then.
- platform/qt/Skipped:
- 4:00 AM Changeset in webkit [65661] by
-
- 7 edits in trunk/WebCore
2010-08-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dirk Schulze.
[GTK] The size of the shadow image uses the standard deviation
size instead of the blur radius
https://bugs.webkit.org/show_bug.cgi?id=40793
The kernelSize variable was renamed to radius and recalculated
considering the CSS3 specification
http://www.w3.org/TR/css3-background/#the-box-shadow, and the
visual result of other browsers. The HTML5 canvas shadow standard
deviation calculation that was used, was not appropiate for the
blur distance specified in the CSS3.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): Changed the calculation, now we use the parameter in the style directly as recomended in the CSS3 standard. (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::createPlatformShadow): We get the standard deviation from the radius using the new function and we create the filter with that deviation.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateStdDeviation): Added this function that gets the standard deviation from the blur radius. Required in the CSS3 case where we have this radio and we need the deviation to initialize the algorithm.
- platform/graphics/filters/FEGaussianBlur.h:
- 1:21 AM Changeset in webkit [65660] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip crashing test.
[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235
- platform/gtk/Skipped: Skip media/video-layer-crash.html
- 1:16 AM Changeset in webkit [65659] by
-
- 2 edits in trunk/WebCore
2010-08-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid unnecessary string copy in TextCodecQt::decode()
https://bugs.webkit.org/show_bug.cgi?id=44232
- platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode): Use String::append(const UChar*, int) to avoid creating a temporary string.
- 1:04 AM Changeset in webkit [65658] by
-
- 24 edits4 adds in trunk
Reviewed by Gustavo Noronha Silva.
[GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474
- configure.ac: gst-interfaces link support needed for use of GstXOverlay interface.
- GNUmakefile.am: Added new FullscreenVideoController files in the build.
LayoutTests:
Reviewed by Gustavo Noronha Silva.
[GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474
Rebaselined tests showing the video controls containing the new
fullscreen button.
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-drag-timebar-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
WebCore:
Reviewed by Gustavo Noronha Silva.
[GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474
GStreamerGWorld now catches synchronous messages coming from the
sinks and creates a GTK window where the video can be overlayed if
fullscreen display is requested using enterFullscreen.
- GNUmakefile.am:
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::gstGWorldSyncMessageCallback): (WebCore::GStreamerGWorld::GStreamerGWorld): (WebCore::GStreamerGWorld::~GStreamerGWorld): (WebCore::GStreamerGWorld::enterFullscreen): (WebCore::GStreamerGWorld::exitFullscreen): (WebCore::GStreamerGWorld::setWindowOverlay):
- platform/graphics/gstreamer/GStreamerGWorld.h: (WebCore::GStreamerGWorld::pipeline): (WebCore::GStreamerGWorld::platformVideoWindow):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/PlatformVideoWindow.h: Added. (WebCore::PlatformVideoWindow::createWindow): (WebCore::PlatformVideoWindow::window): (WebCore::PlatformVideoWindow::videoWindowId):
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Added. (PlatformVideoWindow::PlatformVideoWindow):
WebKt/gtk:
Reviewed by Gustavo Noronha Silva.
[GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474
New FullscreenVideoController object, private in the webview. It
is created when the user presses the fullscreen button of the
video controls. Video is displayed in fullscreen, controls are
displayed when the user moves the mouse and when the video is
paused. There's also basic keyboard shortcuts support: F/f to
leave fullscreen, space to toggle play/pause and up/down to
control volume.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullscreenForNode): (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):
- WebCoreSupport/ChromeClientGtk.h:
- WebCoreSupport/FullscreenVideoController.cpp: Added. (hideHudCallback): (onFullscreenGtkMotionNotifyEvent): (onFullscreenGtkActiveNotification): (onFullscreenGtkConfigureEvent): (onFullscreenGtkDestroy): (togglePlayPauseActivated): (exitFullscreenActivated): (progressBarUpdateCallback): (timeScaleButtonPressed): (timeScaleButtonReleased): (timeScaleValueChanged): (volumeValueChanged): (playerVolumeChangedCallback): (playerMuteChangedCallback): (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::~FullscreenVideoController): (FullscreenVideoController::setMediaElement): (FullscreenVideoController::gtkConfigure): (FullscreenVideoController::showHud): (FullscreenVideoController::hideHud): (onFullscreenGtkKeyPressEvent): (FullscreenVideoController::enterFullscreen): (FullscreenVideoController::updateHudPosition): (FullscreenVideoController::exitOnUserRequest): (FullscreenVideoController::exitFullscreen): (FullscreenVideoController::canPlay): (FullscreenVideoController::play): (FullscreenVideoController::pause): (FullscreenVideoController::playStateChanged): (FullscreenVideoController::togglePlay): (FullscreenVideoController::volume): (FullscreenVideoController::muted): (FullscreenVideoController::setVolume): (FullscreenVideoController::volumeChanged): (FullscreenVideoController::muteChanged): (FullscreenVideoController::currentTime): (FullscreenVideoController::setCurrentTime): (FullscreenVideoController::duration): (FullscreenVideoController::percentLoaded): (FullscreenVideoController::beginSeek): (FullscreenVideoController::doSeek): (FullscreenVideoController::endSeek): (timeToString): (FullscreenVideoController::updateHudProgressBar): (FullscreenVideoController::createHud):
- WebCoreSupport/FullscreenVideoController.h: Added. (FullscreenVideoController::mediaElement):
- webkit/webkitprivate.cpp: (webkit_web_view_enter_fullscreen): (webkit_web_view_exit_fullscreen):
- webkit/webkitprivate.h:
WebKit/gtk/po:
Reviewed by Gustavo Noronha Silva.
[GStreamer] GTK XOverlay support in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=39474
- POTFILES: Added new file that contains strings to extract.
- 12:45 AM Changeset in webkit [65657] by
-
- 2 edits in trunk/LayoutTests
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION(r64303): dumpAsMarkup doesn't print the output without layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=44225
Have notifyDone append Markup._container to document.body even if window.layoutTestController is undefined.
- resources/dump-as-markup.js: (Markup.notifyDone):
- 12:18 AM Changeset in webkit [65656] by
-
- 13 edits3 adds in trunk/WebCore
2010-08-19 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add idl and mock classes for FileWriter.
https://bugs.webkit.org/show_bug.cgi?id=44075
No new tests, since there's no new functionality.
New do-nothing classes, but the real IDL:
- FileWriter.idl:
- FileWriter.h:
- FileWriter.cpp:
The build file changes to include the above:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added FileWriter event names and required EventTarget changes.
- dom/EventNames.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::toFileWriter):
- dom/EventTarget.h:
