⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 28, 2011:

11:59 PM Changeset in webkit [82202] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82198.
​http://trac.webkit.org/changeset/82198
​https://bugs.webkit.org/show_bug.cgi?id=57304

Broke Chromium Win build. (Requested by dave_levin on
#webkit).

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:45 PM Changeset in webkit [82201] by yutak@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, fix Chromium test results and expectations.

  • platform/chromium-mac-leopard/fast/block/positioning/047-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/047-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:42 PM Changeset in webkit [82200] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2011-03-28 Ofri Wolfus <​ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
​https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

  • fast/forms/listbox-bidi-align.html: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
  • platform/mac/fast/text/drawBidiText-expected.checksum: Updated.
  • platform/mac/fast/text/drawBidiText-expected.png: Updated.

2011-03-28 Ofri Wolfus <​ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
​https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

Test: fast/forms/listbox-bidi-align.html

  • rendering/RenderListBox.cpp: (WebCore::itemOffsetForAlignment): (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
11:32 PM Changeset in webkit [82199] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-28 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Benjamin Poulain.

[Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
​https://bugs.webkit.org/show_bug.cgi?id=57142

TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
Remove ENABLE(VIDEO) guard.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
  • platform/graphics/texmap/TextureMapperNode.h:
  • platform/graphics/texmap/TextureMapperPlatformLayer.h: (WebCore::TextureMapperMediaLayer::layerType):
11:20 PM Changeset in webkit [82198] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Thomas Klausner <​tk@giga.or.at>

Reviewed by David Levin.

png-1.5 fixes
​https://bugs.webkit.org/show_bug.cgi?id=54406

Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).

Compilation fixes, so no new tests.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:18 PM Changeset in webkit [82197] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Adam Barth.

Replace fprintf(stderr, ...) with LOG_ERROR
​https://bugs.webkit.org/show_bug.cgi?id=57216

LOG_ERROR is a better choice here.

  • bridge/jni/v8/JavaClassV8.cpp: (JavaClass::JavaClass):
10:56 PM Changeset in webkit [82196] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

2011-03-28 Andrew Foster <​andrewf@chromium.org>

Reviewed by Ojan Vafai.

webkit-patch should be more intelligent about whether a bug applies to a patch
Create a new function, parse_bug_id_from_changelog() which determines
that a bug is related to a patch by parsing the output generated from
prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
the description of a patch.
​https://bugs.webkit.org/show_bug.cgi?id=56989

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/net/bugzilla/init.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py:
  • Scripts/webkitpy/tool/commands/upload.py:
10:53 PM Changeset in webkit [82195] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-03-28 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
​https://bugs.webkit.org/show_bug.cgi?id=56602

Added new methods to interface while keeping the old ones to keep
chromium working until it is also patched.

  • public/WebDevToolsAgent.h:
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
  • src/WebDevToolsAgentImpl.h:
10:41 PM Changeset in webkit [82194] by steveblock@google.com
  • 7 edits
    1 add in trunk/Source/WebCore

2011-03-28 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Add a new JavaValue to type to represent a Java value in the Java bridge
​https://bugs.webkit.org/show_bug.cgi?id=57022

This change introduces a new JavaValue type and uses it in place of jvalue
in the conversions to and from JavaNPObject used in the V8 Java bridge.

Refactoring only, no new tests.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp: (JSC::Bindings::javaTypeFromClassName): (JSC::Bindings::signatureFromJavaType): (JSC::Bindings::getJNIField): (JSC::Bindings::callJNIMethod):
  • bridge/jni/JavaType.h:
  • bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJavaValue): (JSC::Bindings::convertJavaValueToNPVariant): (JSC::Bindings::jvalueToJavaValue): (JSC::Bindings::javaValueToJvalue):
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaValueV8.h: Added. (JSC::Bindings::JavaValue::JavaValue):
10:29 PM Changeset in webkit [82193] by Patrick Gansterer
  • 19 edits in trunk/Source

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use String instead of CString as return value of openTemporaryFile
​https://bugs.webkit.org/show_bug.cgi?id=55332

We usually store all paths as UTF-16. Do this for temporary files too.

  • WebCore.exp.in
  • platform/FileSystem.h:
  • platform/android/FileSystemAndroid.cpp:
  • platform/brew/FileSystemBrew.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/haiku/FileSystemHaiku.cpp:
  • platform/mac/FileSystemMac.mm:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wince/FileSystemWinCE.cpp:
  • platform/wx/FileSystemWx.cpp:
  • plugins/PluginStream.cpp: (WebCore::PluginStream::destroyStream):
  • plugins/PluginStream.h:

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use String instead of CString as return value of openTemporaryFile
​https://bugs.webkit.org/show_bug.cgi?id=55332

  • Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::initializeTempLogFile):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
10:28 PM Changeset in webkit [82192] by Patrick Gansterer
  • 1 edit
    2 deletes in trunk/Source/WebKit/win

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Remove unused DOMCreateInstance files
​https://bugs.webkit.org/show_bug.cgi?id=57193

  • DOMCreateInstance.cpp: Removed.
  • DOMCreateInstance.h: Removed.
10:08 PM Changeset in webkit [82191] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Jeff Johnson <​opendarwin@lapcatsoftware.com>

Reviewed by Pavel Feldman.

Web Inspector: empty, non-functional window
​https://bugs.webkit.org/show_bug.cgi?id=56354

Check whether DOM local storage is enabled
before attempting to access window.localStorage.

No new tests.

9:57 PM Changeset in webkit [82190] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed. Clean up Chromium test expectations for plugins/embed-prefers-plugins-for-images.html.

  • platform/chromium/test_expectations.txt:
9:47 PM Changeset in webkit [82189] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Fix test results that were accidentally committed with a wrong
result due to a temporary wrong code change.

  • http/tests/uri/username-with-no-hostname-expected.txt:
9:36 PM Changeset in webkit [82188] by aestes@apple.com
  • 4 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/chromium/test_expectations.txt: Skip the test.
  • platform/gtk/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
8:47 PM Changeset in webkit [82187] by aestes@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

Make embed-prefers-plugins-for-images.html pass on all Apple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/win/Skipped:
  • plugins/embed-prefers-plugins-for-images-expected.txt:
  • plugins/embed-prefers-plugins-for-images.html:
8:04 PM Changeset in webkit [82186] by mjs@apple.com
  • 2 edits in trunk/Tools

Revert accidentally commited change.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

7:39 PM Changeset in webkit [82185] by Beth Dakin
  • 5 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>

Reviewed by Darin Adler.

This patch rolls out revision 79053 and fixes the same bug in a better way.

New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

Roll-out of 79053.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):

  • page/FrameView.h:
7:36 PM Changeset in webkit [82184] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

fix style sharing with :any and sibling selectors
​https://bugs.webkit.org/show_bug.cgi?id=57211

Also tests sibling selector style sharing in general since
no existing tests seem to cover that codepath.

  • fast/css/sibling-selectors-expected.txt: Added.
  • fast/css/sibling-selectors.html: Added.

2011-03-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

fix style sharing with :any and sibling selectors
​https://bugs.webkit.org/show_bug.cgi?id=57211

Test: fast/css/sibling-selectors.html

  • css/CSSStyleSelector.cpp: (WebCore::collectFeaturesFromList):
7:30 PM Changeset in webkit [82183] by ojan@chromium.org
  • 6 edits in trunk

2011-03-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

fix :-webkit-any(:last-child)
​https://bugs.webkit.org/show_bug.cgi?id=57207

  • fast/css/pseudo-any.html:

2011-03-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Antti Koivisto.

fix :-webkit-any(:last-child)
​https://bugs.webkit.org/show_bug.cgi?id=57207

We were passing the wrong arguments to checkSelector. Also, we were not
passing through the encounteredLink bool.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSStyleSelector.h:
7:15 PM Styling Form Controls edited by tkent@chromium.org
(diff)
6:45 PM Changeset in webkit [82182] by aestes@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode.
​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-wk2/plugins: Added.
  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
6:42 PM Styling Form Controls edited by tkent@chromium.org
(diff)
6:26 PM Changeset in webkit [82181] by mjs@apple.com
  • 5 edits in trunk

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
​https://bugs.webkit.org/show_bug.cgi?id=57291

  • platform/KURL.cpp: (WebCore::KURL::parse): Instead of considering URLs with credentials but no host invalid, consider them to have a host ending in @ (which fails down the line)/

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
​https://bugs.webkit.org/show_bug.cgi?id=57291

  • http/tests/uri/username-with-no-hostname.html: Adjusted test to be more tolerant of exactly how the image load fails.
6:10 PM Changeset in webkit [82180] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix some problems of the appearance of form validation message bubble.
​https://bugs.webkit.org/show_bug.cgi?id=57208

No new tests. Validation message bubble appearance is not testable
because it depends on a timer.

  • css/html.css: (::-webkit-validation-bubble): (::-webkit-validation-bubble-message): (::-webkit-validation-bubble-arrow): (::-webkit-validation-bubble-arrow-clipper):
    • Explicitly set margin, padding, and color.
    • Make the shadow darker.
    • Make the background color darker.
    • Make opacity larger.
    • Make the border color lighter.
    • Add inset shadows
    • Change the implementation of an arrow. Stop making a right triangle by the border trick. Use -webkit-transform instead.
    • Make min-width workable by changing display property of -webkit-validation-bubble to "inline-block".
  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Change the node structure. Before this change, -webkit-validation-bubble had three DIVs inside. After this change, it has two DIVs; -webkit-validation-bubble-arrow-clipper and -webkit-validation-bubble-message, and -webkit-validation-bubble-arrow-clipper contains -webkit-validation-bubble-arrow.
6:06 PM Changeset in webkit [82179] by mdelaney@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

2011-03-28 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Adele Peterson.

Updating small batch of gradient expected results files
​https://bugs.webkit.org/show_bug.cgi?id=57117

  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
5:41 PM Changeset in webkit [82178] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

REGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=56539

Unreviewed, remove the platform-specific failing results to get the bots green.
The test appears to be working in WebKit after r82106 and r82017.

  • platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Removed.
5:33 PM Changeset in webkit [82177] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Vincent Scheib <​scheib@chromium.org>

Chromium test expectation for r82159

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [82176] by enrica@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
​https://bugs.webkit.org/show_bug.cgi?id=57275
<rdar://problem/8246691>

Reviewed by Sam Weinig.

We need to classify cut and paste actions as user typing actions even when
the action is triggered by a context menu selection to
allow the propagation of the textDidChangeInTextField event.

  • editing/EditorCommand.cpp:

The following methods have been modified to properly set up
the UserTypingGestureAction when the command source is the
menu or a key binding sequence.
(WebCore::executeCut):
(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeDelete):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Changed to
call execute command instead of referring to the specific method in
the editor class.

4:53 PM Changeset in webkit [82175] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Add another test that depends on EventSender to the mac-wk2 Skipped file.

  • platform/mac-wk2/Skipped:

Add fast/events/onchange-text-form-field.html.

4:49 PM Changeset in webkit [82174] by tony@chromium.org
  • 4 edits in trunk

2011-03-28 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] have DRT write the png checksum into a png comment
​https://bugs.webkit.org/show_bug.cgi?id=57255

  • DEPS: Pull in version of chromium with comment writing

2011-03-28 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] have DRT write the png checksum into a png comment
​https://bugs.webkit.org/show_bug.cgi?id=57255

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
4:39 PM Changeset in webkit [82173] by oliver@apple.com
  • 39 edits
    3 adds in trunk

2011-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
​https://bugs.webkit.org/show_bug.cgi?id=17250

Add test cases for correct behaviour

  • fast/js/js-constructors-use-correct-global-expected.txt: Added.
  • fast/js/js-constructors-use-correct-global.html: Added.
  • fast/js/resources/js-constructors-use-correct-global.js: Added.

2011-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
​https://bugs.webkit.org/show_bug.cgi?id=17250

This is a problem with all built in constructors, the use of
lexicalGlobalObject rather than the constructors own
global object reference means that a builtin will always use
the prototype from the lexical global object rather than that
of the constructors origin.

  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeRegExp):
  • JavaScriptCore.exp:
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp: (JSC::constructDate):
  • runtime/DateInstance.cpp:
  • runtime/DateInstance.h:
  • runtime/ErrorConstructor.cpp: (JSC::constructWithErrorConstructor): (JSC::callErrorConstructor):
  • runtime/FunctionConstructor.cpp: (JSC::constructWithFunctionConstructor): (JSC::callFunctionConstructor): (JSC::constructFunction):
  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp: (JSC::JSCell::getOwnPropertySlot): (JSC::JSCell::put): (JSC::JSCell::deleteProperty): (JSC::JSCell::toThisObject): (JSC::JSCell::toObject):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toObject):
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toObject):
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::toObject):
  • runtime/JSObject.h:
  • runtime/JSString.cpp: (JSC::StringObject::create): (JSC::JSString::toObject): (JSC::JSString::toThisObject):
  • runtime/JSString.h:
  • runtime/JSValue.cpp: (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::toThisObjectSlowCase): (JSC::JSValue::synthesizeObject):
  • runtime/JSValue.h:
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/ObjectConstructor.cpp: (JSC::constructObject): (JSC::constructWithObjectConstructor): (JSC::callObjectConstructor):
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp): (JSC::constructWithRegExpConstructor): (JSC::callRegExpConstructor):
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp: (JSC::constructWithStringConstructor):
  • runtime/StringObject.h:

2011-03-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
​https://bugs.webkit.org/show_bug.cgi?id=17250

Up date for new toObject api

  • UserObjectImp.cpp: (UserObjectImp::toPrimitive): (UserObjectImp::toBoolean): (UserObjectImp::toNumber): (UserObjectImp::toString):

2011-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
​https://bugs.webkit.org/show_bug.cgi?id=17250

Update for new function and date apis

Test: fast/js/js-constructors-use-correct-global.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
4:24 PM Changeset in webkit [82172] by adele@apple.com
  • 2 edits in trunk/Tools

Removing Qt stub, since it doesn't use the same header as the others.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4:15 PM Changeset in webkit [82171] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
changed via delegate method, the page needs a full relayout and repaint
-and corresponding-
<rdar://problem/9059129>

Reviewed by Darin Adler.

Call into WebKitSystemInterface to associate the new painter with the existing
painter controller. Reset the scrollbar frame rects to the new thickness -- normally
this only happens when a scrollbar is created, so we have to reset the thickness
here to pick up the new theme thickness. Finally, force a full relayout and style
recall with setNeedsRecalcStyleInAllFrames()

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):

setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
patch moves it to be a member function on Page so that it can be called from
FrameView when the scrollbar style changes.

  • page/FrameView.cpp:

(WebCore::FrameView::setNeedsRecalcStyleInAllFrames):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setNeedsRecalcStyleInAllFrames):

  • page/Page.h:
  • page/Settings.cpp:

(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):

4:11 PM Changeset in webkit [82170] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Dirk Pranke <​dpranke@chromium.org>

RS=Tony Chang.

r81977 moved FontPlatformData.h from
WebCore/platform/graphics/cocoa to platform/graphics. This
change updates the chromium build accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=57281

  • platform/graphics/chromium/CrossProcessFontLoading.mm:
3:56 PM Changeset in webkit [82169] by scheib@chromium.org
  • 7 edits in trunk/LayoutTests

2011-03-28 Vincent Scheib <​scheib@chromium.org>

Chromium rebaseline for r82144.

  • platform/chromium-linux/fast/block/positioning/058-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/052-expected.txt:
  • platform/chromium-win/fast/block/positioning/058-expected.checksum:
  • platform/chromium-win/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/058-expected.txt:
  • platform/chromium/test_expectations.txt:
3:43 PM Changeset in webkit [82168] by adele@apple.com
  • 4 edits in trunk/Tools

Added a few more stubs.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::hasGrammarMarker):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::hasGrammarMarker):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::hasGrammarMarker):

3:31 PM Changeset in webkit [82167] by jer.noble@apple.com
  • 9 edits in trunk

MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
​https://bugs.webkit.org/show_bug.cgi?id=57249

Reviewed by Darin Adler.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
3:22 PM Changeset in webkit [82166] by adele@apple.com
  • 4 edits in trunk

Build fix.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):

Tools:

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::hasGrammarMarker):

3:07 PM Changeset in webkit [82165] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-03-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

http streams don't always display video with AVFoundation backend
​https://bugs.webkit.org/show_bug.cgi?id=57203

No new tests, we don't currently have tests for http live streams. Changes verified manually.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender. (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine

if m_shouldPrepareToRender is set.

(WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until

m_isAllowedToRender has been set.

(WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,

it has logic to figure out when setup is required.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't

using the preferred rendering mode because if we get a file's metadata between the
time supportsAcceleratedRendering() and paint() are called, we will allocate a software
renderer even when we prefer a layer backed renderer.

(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of

an explicit list of key path names.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed

to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
callers need.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the

player item, not the asset, because AVAsset.duration always returns an indefinite time
for all streaming files.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed

to assetMetadataKeyNames.

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until

metadata is available.

(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off

into sizeChanged().

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize

until tracks is non-NULL so we have a size as early as possible.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
(WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of

KVO observable properties.

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to

presentationSize change.

3:04 PM Changeset in webkit [82164] by adele@apple.com
  • 4 edits in trunk/Source/WebKit

../WebKit/chromium: Build fix.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):

Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

../WebKit/win: Build fix.

  • WebFrame.cpp: (WebFrame::hasSpellingMarker):

Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

3:01 PM Changeset in webkit [82163] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Search field focus ring is missing
​https://bugs.webkit.org/show_bug.cgi?id=57270
<rdar://problem/8765555>

Add an _automaticFocusRingDisabled method which returns YES.

  • platform/mac/ThemeMac.mm: (-[WebCoreFlippedView _automaticFocusRingDisabled]):
3:00 PM Changeset in webkit [82162] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
​https://bugs.webkit.org/show_bug.cgi?id=56823


Partial fix for most of the problem. (TOT still shows a regression, though.)

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of capacity(), since capacity() is O(n) relative to the size of the heap.

In limited circumstances, capacity() is also worse than highWaterMark()
for measuring extra cost relative to heap size, since capacity() only
measures the *current* capacity of the heap, but the heap will grow if
necessary to attain highWaterMark().

2:53 PM Changeset in webkit [82161] by aestes@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in failing results for embed-prefers-plugins-for-images.html on Leopard.
​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
2:49 PM Changeset in webkit [82160] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move more events to EventDispatcher.
​https://bugs.webkit.org/show_bug.cgi?id=57247

No functional changes, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,

since it's not used anywhere outside of the EventDispatcher.

(WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
(WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
(WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
(WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules

as a static function.

  • dom/EventDispatcher.h: Updated decls.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher. (WebCore::Node::dispatchKeyEvent): Ditto. (WebCore::Node::dispatchWheelEvent): Ditto.
2:48 PM Changeset in webkit [82159] by adele@apple.com
  • 17 edits
    2 adds in trunk

Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
​https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

Test: editing/spelling/grammar.html

  • WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,

so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph. In the case of this bug,
when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
is the only one operated on when this information is used.
(WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.

  • editing/Editor.h:

Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
​https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • WebView/WebFrame.mm:

(-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
(-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.

  • WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.

Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
​https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • DumpRenderTree/LayoutTestController.cpp:

(hasGrammarMarkerCallback): Added.
(LayoutTestController::staticFunctions): Added case for hasGrammarMarker.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.

LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
​https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • editing/spelling/grammar-expected.txt: Added.
  • editing/spelling/grammar.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:32 PM Changeset in webkit [82158] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
​https://bugs.webkit.org/show_bug.cgi?id=48983

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/paginated-layer-crash.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
into sync with updatePagination() after r68069.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.

LayoutTests:

  • fast/multicol/paginated-layer-crash-expected.txt: Added.
  • fast/multicol/paginated-layer-crash.html: Added.
2:32 PM Changeset in webkit [82157] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Downloads started with DownloadCFNet::start never start
​https://bugs.webkit.org/show_bug.cgi?id=57268

Reviewed by Jon Honeycutt.

  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::start): Call CFURLDownloadStart on the download we create.

2:28 PM Changeset in webkit [82156] by scheib@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-28 Vincent Scheib <​scheib@chromium.org>

Chromium rebaseline for r82123.

  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
2:23 PM Changeset in webkit [82155] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Benjamin Poulain.

Trivial typo fix after r82082.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

2:00 PM Changeset in webkit [82154] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • Shared/ShareableBitmap.h:
1:58 PM Changeset in webkit [82153] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Beep when pressing a menu key equivalent when a plug-in has focus
​https://bugs.webkit.org/show_bug.cgi?id=57264
<rdar://problem/8935597>

We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.

  • UIProcess/API/mac/WKView.mm: (-[WKView inputContext]):
1:53 PM Changeset in webkit [82152] by mjs@apple.com
  • 3 edits
    2 adds in trunk

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler' .

URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
​https://bugs.webkit.org/show_bug.cgi?id=57220

Test: http/tests/uri/username-with-no-hostname.html

  • platform/KURL.cpp: (WebCore::hostPortIsEmptyButUserPassIsNot): (WebCore::KURL::parse):

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler' .

URLSs with non-empty username but empty hostname are allowed to load
​https://bugs.webkit.org/show_bug.cgi?id=57220

  • http/tests/uri/username-with-no-hostname-expected.txt: Added.
  • http/tests/uri/username-with-no-hostname.html: Added.
1:45 PM Changeset in webkit [82151] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-03-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

CGImageRefs must hold a strong reference to underlying data
​https://bugs.webkit.org/show_bug.cgi?id=57263
<rdar://problem/9146179>

Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.

  • Platform/cg/CGUtilities.cpp: (WebKit::paintImage): Factor image painting code out into a separate function.

(WebKit::paintBitmapContext):
Call paintImage.

  • Shared/API/c/cg/WKImageCG.cpp: (WKImagemakeCGImage): Use ShareableBitmap::makeCGImageCopy.
  • Shared/ShareableBitmap.h:
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint): (WebKit::ShareableBitmap::makeCGImageCopy): (WebKit::ShareableBitmap::makeCGImage): (WebKit::ShareableBitmap::releaseBitmapContextData): (WebKit::ShareableBitmap::releaseDataProviderData): Add makeCGImage and makeCGImageCopy.
  • Shared/cg/WebCoreArgumentCodersCG.cpp: (CoreIPC::createImage): Use ShareableBitmap::makeCGImage.


  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setDragImage): Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.
1:34 PM Changeset in webkit [82150] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's "theEvent".
1:32 PM Changeset in webkit [82149] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests

Update progressing layout tests on SL.

1:19 PM Changeset in webkit [82148] by ap@apple.com
  • 7 edits in trunk/Source

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=57260
Clean up text input code a little

WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyboardEvent): (WebEditorClient::handleInputMethodKeydown):
  • WebView/WebHTMLViewInternal.h: Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept anything. It's just a version it interpretKeyEvents: that tells us whether it was handled, and also possibly saves resulting commands for later execution.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event handling state, like the other booleans there. Don't call interpretKeyEvents: again simply because the first call resulted in no saved commands, becasue it's confusing and apparently useless (I couldn't find any broken behavior). (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView doCommandBySelector:]): Ditto. (-[WebHTMLView insertText:]): Ditto.
  • WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand: method on WebView.

WebKit2:

  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call. (-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent: and also WebKit1.
  • WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.
1:16 PM Changeset in webkit [82147] by abarth@webkit.org
  • 6 edits
    3 adds in trunk

2011-03-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline event handlers
​https://bugs.webkit.org/show_bug.cgi?id=57212

I considered wrapping this into the canExecute check, but that approach
would require passing that function a bunch of context information to
behave correctly once we add support for the "options" directive that
re-enables these features.

Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html

  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
    • This function was a mess. I couldn't resist cleaning it up a bunch. Notice that we ASSERT at the beginning of the function that scriptExecutionContext is a document and that both ways of getting the global object are the same when document->frame() is non-zero because the document must be active and there is a one-to-one relation between Frames and active Documents.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  • page/ContentSecurityPolicy.h:

2011-03-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline event handlers
​https://bugs.webkit.org/show_bug.cgi?id=57212

  • http/tests/security/contentSecurityPolicy/resources/event-handler.pl: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html: Added.
1:09 PM Changeset in webkit [82146] by jeffm@apple.com
  • 6 edits in trunk/Source

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

ResourceError::certificate() should return a PCCERT_CONTEXT
​https://bugs.webkit.org/show_bug.cgi?id=57262

  • platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::certificate): Added.

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

ResourceError::certificate() should return a PCCERT_CONTEXT
​https://bugs.webkit.org/show_bug.cgi?id=57262

  • Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Don't assert if no PCCERT_CONTEXT is specified.
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Removed unneeded code now that ResourceError::certificate() returns a PCCERT_CONTEXT.
1:03 PM Changeset in webkit [82145] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

2011-03-28 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
12:44 PM Changeset in webkit [82144] by hyatt@apple.com
  • 4 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
occur at the end of a line.

Reviewed by Simon Fraser and Darin Adler.

The old code and new code for dealing with a trailing space object midpoint manipulated a raw
array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.

I have patched the code to only go through the Vector and to make it handle the case that led to
the corruption. Trailing positioned objects can occur both prior to and following the trailing space
object's midpoint, so we have to be prepared to deal with both cases.

This is already tested by fast/block/positioning/052.html, and that test now properly progresses
like the other positioning tests did.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

  • platform/mac/fast/block/positioning/052-expected.txt:
12:41 PM Changeset in webkit [82143] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-28 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
12:32 PM Changeset in webkit [82142] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-03-28 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
​https://bugs.webkit.org/show_bug.cgi?id=52629

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of QWebPage::repaintRequested() use a Qt::QueuedConnection.
  • tests/qwebpage/tst_qwebpage.cpp: (RepaintRequestedRenderer::RepaintRequestedRenderer): (RepaintRequestedRenderer::onRepaintRequested): (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling QWebFrame::render() in a slot connected to to QWebPage::repaintRequested() doesn't cause recursive signal emissions.
12:10 PM Changeset in webkit [82141] by Simon Fraser
  • 2 edits in trunk/Tools

2011-03-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
to link against WebKit.framework for now.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [82140] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unused CFErrorRef.

Rubber-stamped by Adam Roben.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceError): Remove unused CFErrorRef.

11:25 AM Changeset in webkit [82139] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=57251

Build fix, had remnant of another patch in r82130

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompileGetByIdChainList):

11:17 AM Changeset in webkit [82138] by andreip@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-28 Andrei Popescu <​andreip@google.com>

Reviewed by Steve Block.

V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
​https://bugs.webkit.org/show_bug.cgi?id=57100

Close the ENABLE guard and the namespace in the right order.

No new tests, just cleanup.

  • bindings/v8/custom/V8IDBAnyCustom.cpp:
  • bindings/v8/custom/V8IDBKeyCustom.cpp:
11:16 AM Changeset in webkit [82137] by jeffm@apple.com
  • 13 edits in trunk

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57195

Rename wkGetSSLPeerCertificateData() to wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*, and
implement wkGetSSLPeerCertificateData() to return a CFDataRef. Add wkSetSSLPeerCertificateData() so
WebCore::ResourceError can set the certificate in the user info dictionary.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57195


Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.

  • WebError.cpp: (WebError::sslPeerCertificate):
  • WebURLResponse.cpp: (WebURLResponse::sslPeerCertificate):

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57195

Add support for tracking the certificate in WebCore::ResourceError.

  • platform/network/ResourceErrorBase.cpp: (WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
  • platform/network/ResourceErrorBase.h: (WebCore::ResourceErrorBase::platformCopy): Added.
  • platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate. (WebCore::ResourceError::certificate): Added.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Added constructor that takes certificate data. (WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary. (WebCore::ResourceError::platformCopy): Copy m_certificate. (WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.

2011-03-28 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57195


Add support for sending the certificate with the WebCore::ResourceError.

  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Encode certificate data. (CoreIPC::deallocCertContext): Added. (CoreIPC::createCertContextDeallocator): Added. (CoreIPC::copyCert): Added. (CoreIPC::decodeResourceError): Decode certificate data.
10:57 AM Changeset in webkit [82136] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Add an extra newline to the end of the generated Inspector.idl file so that it does not
trigger the Windows "no newline at at end of file" warning.

Rubber-stamped by Adam Roben.

  • inspector/generate-inspector-idl:
10:49 AM Changeset in webkit [82135] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, added new GTK+ test expectations.

  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.png: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.txt: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.png: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.txt: Added.
10:46 AM Changeset in webkit [82134] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.

(WebCore::MediaPlayerPrivateQt::getSupportedTypes):
(WebCore::MediaPlayerPrivateQt::commitLoad):

10:29 AM Changeset in webkit [82133] by pfeldman@chromium.org
  • 3 edits in trunk/Source

2011-03-28 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fixed chromium build.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
10:19 AM Changeset in webkit [82132] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82099.
​http://trac.webkit.org/changeset/82099
​https://bugs.webkit.org/show_bug.cgi?id=57245

Breaks live edits tests on chromium. (Requested by pfeldman on
#webkit).

  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
10:16 AM Changeset in webkit [82131] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-03-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up and rename debugger domain functions.
​https://bugs.webkit.org/show_bug.cgi?id=57240

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointsActive): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerDispatcher.prototype.paused): (WebInspector.DebuggerDispatcher.prototype.resumed): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  • inspector/front-end/inspector.js: (WebInspector.didCreateWorker): (WebInspector.didDestroyWorker):
10:14 AM Changeset in webkit [82130] by oliver@apple.com
  • 30 edits in trunk/Source/JavaScriptCore

2011-03-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add additional immediate types to allow us to distinguish the source of a JIT immediate
​https://bugs.webkit.org/show_bug.cgi?id=57190

Allow us to distinguish whether a JIT immediate is a value that we
control (TrustedImm32 and TrustedImmPtr) vs. ones that can be controlled
or influenced by code we are compiling. Currently we do nothing with this
information -- this change is large and mechanical but would obscure any
logic changes that we would have made.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr): (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr): (JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32): (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::pop): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::setPtr): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchTest8):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::urshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch8): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest8): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::set32Compare32): (JSC::MacroAssemblerARM::set8Compare32): (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::add32): (JSC::MacroAssemblerARMv7::and32): (JSC::MacroAssemblerARMv7::lshift32): (JSC::MacroAssemblerARMv7::mul32): (JSC::MacroAssemblerARMv7::or32): (JSC::MacroAssemblerARMv7::rshift32): (JSC::MacroAssemblerARMv7::urshift32): (JSC::MacroAssemblerARMv7::sub32): (JSC::MacroAssemblerARMv7::xor32): (JSC::MacroAssemblerARMv7::load32): (JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARMv7::load16): (JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARMv7::store32): (JSC::MacroAssemblerARMv7::loadDouble): (JSC::MacroAssemblerARMv7::storeDouble): (JSC::MacroAssemblerARMv7::push): (JSC::MacroAssemblerARMv7::move): (JSC::MacroAssemblerARMv7::compare32): (JSC::MacroAssemblerARMv7::test32): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch16): (JSC::MacroAssemblerARMv7::branch8): (JSC::MacroAssemblerARMv7::branchTest32): (JSC::MacroAssemblerARMv7::branchTest8): (JSC::MacroAssemblerARMv7::branchAdd32): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::branchSub32): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::set32Compare32): (JSC::MacroAssemblerARMv7::set8Compare32): (JSC::MacroAssemblerARMv7::set32Test32): (JSC::MacroAssemblerARMv7::set32Test8): (JSC::MacroAssemblerARMv7::moveWithPatch): (JSC::MacroAssemblerARMv7::branchPtrWithPatch): (JSC::MacroAssemblerARMv7::storePtrWithPatch): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch): (JSC::MacroAssemblerARMv7::setupArmAddress): (JSC::MacroAssemblerARMv7::makeBaseIndexBase): (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::urshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::set8Compare32): (JSC::MacroAssemblerMIPS::set32Compare32): (JSC::MacroAssemblerMIPS::set32Test8): (JSC::MacroAssemblerMIPS::set32Test32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::add32): (JSC::MacroAssemblerX86::addWithCarry32): (JSC::MacroAssemblerX86::and32): (JSC::MacroAssemblerX86::or32): (JSC::MacroAssemblerX86::sub32): (JSC::MacroAssemblerX86::store32): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::moveWithPatch): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::storePtrWithPatch):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::lshift32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::rshift32): (JSC::MacroAssemblerX86Common::urshift32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::store32): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::push): (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::branch8): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchTest8): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set8Compare32): (JSC::MacroAssemblerX86Common::set32Compare32): (JSC::MacroAssemblerX86Common::set32Test8): (JSC::MacroAssemblerX86Common::set32Test32):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::loadDouble): (JSC::MacroAssemblerX86_64::addDouble): (JSC::MacroAssemblerX86_64::convertInt32ToDouble): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): (JSC::MacroAssemblerX86_64::addPtr): (JSC::MacroAssemblerX86_64::andPtr): (JSC::MacroAssemblerX86_64::orPtr): (JSC::MacroAssemblerX86_64::subPtr): (JSC::MacroAssemblerX86_64::xorPtr): (JSC::MacroAssemblerX86_64::storePtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::moveWithPatch): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86_64::branchTest8):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::callOperation):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::jitAssertIsInt32): (JSC::DFG::JITCompiler::emitCount):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::compile):
  • jit/JIT.cpp: (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_mod):
  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emitRightShift): (JSC::JIT::emitRightShiftSlowCase): (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitLoadCharacterString): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::checkStructure): (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag): (JSC::JIT::emitCount): (JSC::JIT::sampleInstruction): (JSC::JIT::sampleCodeBlock): (JSC::JIT::emitStoreInt32): (JSC::JIT::emitStoreCell): (JSC::JIT::emitStoreBool): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitInitRegister): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_check_has_instance): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_init_lazy_reg): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_resolve_global_dynamic): (JSC::JIT::emit_op_new_regexp): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs): (JSC::JIT::emit_op_new_func):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_check_has_instance): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_tear_off_arguments): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_create_activation): (JSC::JIT::emit_op_create_arguments): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::softModulo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument):
  • jit/JITStubs.cpp: (JSC::getPolymorphicAccessStructureListSlot): (JSC::DEFINE_STUB_FUNCTION):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::emitLoadDouble):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::SpecializedThunkJIT): (JSC::SpecializedThunkJIT::loadJSStringArgument): (JSC::SpecializedThunkJIT::tagReturnAsInt32): (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
  • jit/ThunkGenerators.cpp: (JSC::charToString): (JSC::powThunkGenerator):
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::matchCharacterClass): (JSC::Yarr::YarrGenerator::storeToFrame): (JSC::Yarr::YarrGenerator::storeToFrameWithPatch): (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode): (JSC::Yarr::YarrGenerator::generatePatternCharacterSingle): (JSC::Yarr::YarrGenerator::generatePatternCharacterFixed): (JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy): (JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::YarrGenerator::generateCharacterClassFixed): (JSC::Yarr::YarrGenerator::generateCharacterClassGreedy): (JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): (JSC::Yarr::YarrGenerator::generateDisjunction):
10:10 AM Changeset in webkit [82129] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=57243

Rubber-stamped by Adam Roben.

  • platform/win/Skipped:

Remove the two tests that were removed in r71392.
Also, remove spelling-backspace-between-lines.html because it is not flakey and the
layoutTestController method is implemented on Windows, it just fails with this test.

  • platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
10:07 AM Changeset in webkit [82128] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/57239> Use forward class declaration instead of including header

Reviewed by Dan Bernstein.

Adding a "using namespace WebCore;" statement in a header may
cause issues when <WebCore/Length.h> is included before
<CoreText/CoreText.h>.

Length.h defines the LengthType enum with a 'Fixed' value.
CoreText.h includes MacTypes.h, which has a
"typedef SInt32 Fixed;" statement, and then CoreText.h includes
other headers that also use 'Fixed', but expect the typedef to
be defined, not the enum. If another header includes
"using namespace WebCore;" before CoreText.h, the
following compiler errors result (paths abbreviated):

CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
Length.h:37: error: WebCore::LengthType WebCore::Fixed
SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type

  • platform/mac/HTMLConverter.h: Use forward declaration of

DocumentLoader class instead of including header. Remove the
unused "using namespace WebCore;" statement.

10:01 AM Changeset in webkit [82127] by Dimitri Glazkov
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-03-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Introduce EventDispatcher, the new common way to fire events.
​https://bugs.webkit.org/show_bug.cgi?id=57168

The goal here is two-fold:
1) reduce the need to randomly sprinkle guards around the dispatch code
by creating a well-scoped abstraction for dispatching events.
2) create a place where fiddly event-related things like creating event
contexts for ancestors can be done lazily.

Additionally, with all the free-standing static functions, this code was
just begging to come out of Node.cpp.

The first step is a near-mechanical extraction of mouse-related events
from Node.cpp to EventDispatcher. For now, the call sites are just
replaced with invoking EventDispatcher. Later, we can remove these methods
from Node.

Refactoring, no functional changes.

  • Android.mk: Added EventDispatcher to build system.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/EventDispatcher.cpp: Added.
  • dom/EventDispatcher.h: Added.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher. (WebCore::Node::dispatchEvent): Ditto. (WebCore::Node::dispatchMouseEvent): Ditto. (WebCore::Node::dispatchSimulatedClick): Ditto.
  • dom/Node.h: Updated decls.
9:37 AM Changeset in webkit [82126] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
introduction in r82056.
​https://bugs.webkit.org/show_bug.cgi?id=57238

Unreviewed, add expected failing results, since vertical text is not yet implemented on
Windows, to get the bots green.

  • platform/win/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/win/fast/blockflow/fallback-orientation-expected.txt: Added.
9:29 AM Changeset in webkit [82125] by benjamin.poulain@nokia.com
  • 12 edits in trunk

2011-03-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Enable QT_ASCII_CAST_WARNINGS by default in webkit.pri to catch the errors early on.

  • Source/WebKit.pri:

2011-03-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

  • QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
  • tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests since they are applications, not libraries.

2011-03-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Disable QT_ASCII_CAST_WARNINGS for applications.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • MiniBrowser/qt/MiniBrowser.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
9:24 AM Changeset in webkit [82124] by sergio@webkit.org
  • 5 edits in trunk

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fullscreen tests failing after r82084
​https://bugs.webkit.org/show_bug.cgi?id=57219

Unskipped some fullscreen tests passing now.

  • platform/gtk/Skipped:

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fullscreen tests failing after r82084
​https://bugs.webkit.org/show_bug.cgi?id=57219

Added the withKeyboard parameter to supportsFullScreenForElement
method in ChromeClient. Fullscreen will be disabled for keyboard
access by default.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullScreenForElement):
  • WebCoreSupport/ChromeClientGtk.h:
9:17 AM Changeset in webkit [82123] by mitz@apple.com
  • 4 edits
    8 adds in trunk

<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
​https://bugs.webkit.org/show_bug.cgi?id=57197

Reviewed by Maciej Stachowiak.

Source/WebCore:

Tests: fast/repaint/overflow-flipped-writing-mode-block.html

fast/repaint/overflow-flipped-writing-mode-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
with the damage rect.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint): Made the intersection check more like the one in
RenderBlock::paint().

LayoutTests:

  • fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-expected.txt: Added.
  • fast/repaint/overflow-flipped-writing-mode-block.html: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
  • fast/repaint/overflow-flipped-writing-mode-table.html: Added.
8:58 AM Changeset in webkit [82122] by sergio@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, rebaseline GTK+ test results.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
8:56 AM Changeset in webkit [82121] by xji@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

move directionOfEnclosingBlock() to be global so that it could be reused.
​https://bugs.webkit.org/show_bug.cgi?id=57233.

Provide global function directionOfEnclosingBlock(Node*) so that it could be
reused in SelectionController and other functionalities that need enclosing
block's direcionality, such as moving caret by word in visual order.


No new functionality, so no new tests.

  • editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
  • editing/htmlediting.cpp: (WebCore::directionOfEnclosingBlock):
  • editing/htmlediting.h:
8:48 AM Changeset in webkit [82120] by Darin Adler
  • 21 edits in trunk/Source/WebKit/win

Set eol-style to native on more files. I noticed the last check-in had an entire file
changing because of an EOL style change, and setting this property prevents that from
happening in future. We may want to do this systematically for more of WebKit later.

  • AccessibleBase.cpp: Added property svn:eol-style.
  • AccessibleBase.h: Added property svn:eol-style.
  • AccessibleDocument.cpp: Added property svn:eol-style.
  • AccessibleDocument.h: Added property svn:eol-style.
  • AccessibleImage.cpp: Added property svn:eol-style.
  • AccessibleImage.h: Added property svn:eol-style.
  • COMVariantSetter.h: Added property svn:eol-style.
  • FullscreenVideoController.cpp: Added property svn:eol-style.
  • FullscreenVideoController.h: Added property svn:eol-style.
  • WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
  • WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
  • WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
  • WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
  • WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
8:47 AM Changeset in webkit [82119] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=57236

Unreviewed, skip the flakey test in order to get the bots green.

  • platform/mac-snowleopard/Skipped:
7:43 AM Changeset in webkit [82118] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, update pixel test expectations after r82105.

  • platform/gtk/fast/css/text-align-expected.checksum:
  • platform/gtk/fast/css/text-align-expected.png:
7:39 AM Changeset in webkit [82117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56825

Fixes for context attribute handling:

  • Initialize depth and stencil buffer depending on whether they are enabled in context attributes.
  • Always enable depth buffer when stencil buffer is enabled.
  • Disable stencil buffer on OpenGL ES 2.0
  • Cleaned up clutter code from initialization. Made code paths more sane.
  • Clear mask is now set correctly in reshape().

Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::isValid): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3DInternal::getProcAddress): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::bindFramebuffer):
7:34 AM Changeset in webkit [82116] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-28 Ryosuke Niwa <​rniwa@webkit.org>

[Chromium] [Mac Leopard] Update test expectations after r82105.

  • platform/chromium-linux/fast/css/text-align-expected.checksum:
  • platform/chromium-linux/fast/css/text-align-expected.png:
  • platform/chromium-win/fast/css/text-align-expected.checksum:
  • platform/chromium-win/fast/css/text-align-expected.png:
  • platform/chromium-win/fast/css/text-align-expected.txt:
  • platform/mac-leopard/fast/css/text-align-expected.checksum:
  • platform/mac-leopard/fast/css/text-align-expected.png:
7:33 AM Changeset in webkit [82115] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] QtWebKit does not link with --3d-canvas using MinGW
​https://bugs.webkit.org/show_bug.cgi?id=57225

  • QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
7:21 AM Changeset in webkit [82114] by jeffm@apple.com
  • 1 edit
    1 delete in trunk/WebKitLibraries

Remove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.

Rubber-stamped by Adam Roben.

  • win/lib/WebKitSystemInterface_debug.lib: Removed.
7:12 AM Changeset in webkit [82113] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
​https://bugs.webkit.org/show_bug.cgi?id=57183

Reviewed by Andreas Kling.

Windows buildfix after r82065.

  • Api/DerivedSources.pro: Readding escaping on Windows platforms.
7:10 AM Changeset in webkit [82112] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Ryosuke Niwa <​rniwa@webkit.org>

[GTK] Update text expectations after r82105.

  • platform/gtk/fast/css/text-align-expected.txt:
6:44 AM Changeset in webkit [82111] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
​https://bugs.webkit.org/show_bug.cgi?id=57226

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setInitialContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.requestWillBeSent): (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached): (WebInspector.NetworkDispatcher.prototype.responseReceived): (WebInspector.NetworkDispatcher.prototype.dataReceived): (WebInspector.NetworkDispatcher.prototype.loadingFinished): (WebInspector.NetworkDispatcher.prototype.loadingFailed): (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetached): (WebInspector.NetworkDispatcher.prototype.initialContentSet): (WebInspector.NetworkDispatcher.prototype.frameNavigated): (WebInspector.NetworkDispatcher.prototype.webSocketCreated): (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest): (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived): (WebInspector.NetworkDispatcher.prototype.webSocketClosed):
6:05 AM Changeset in webkit [82110] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Update expectations after r82105.

  • platform/qt/fast/css/text-align-expected.checksum:
  • platform/qt/fast/css/text-align-expected.png:
  • platform/qt/fast/css/text-align-expected.txt:
5:41 AM Changeset in webkit [82109] by andreas.kling@nokia.com
  • 3 edits in trunk/Tools

2011-03-28 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser doesn't reset its window title when opening about:blank
​https://bugs.webkit.org/show_bug.cgi?id=57224

  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::onTitleChanged):
  • QtTestBrowser/mainwindow.h:
5:24 AM Changeset in webkit [82108] by mnaganov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-28 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
​https://bugs.webkit.org/show_bug.cgi?id=57099

  • bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
  • bindings/v8/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::~ScriptProfile):
  • bindings/v8/ScriptProfile.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
5:23 AM Changeset in webkit [82107] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix console messages positions in formatted scripts.
​https://bugs.webkit.org/show_bug.cgi?id=57010

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages): (WebInspector.DebuggerPresentationModel.prototype._reset):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addConsoleMessage): (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): (WebInspector.ScriptsPanel.prototype._consoleMessageAdded): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame.prototype.addMessageToSource):
5:18 AM Changeset in webkit [82106] by pfeldman@chromium.org
  • 16 edits
    1 add in trunk

2011-03-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=57186

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/resources/console-resource-errors-iframe.html: Added.
  • inspector/report-protocol-errors.html:
  • inspector/storage-panel-dom-storage.html:

2011-03-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=57186

  • ResourceTreeModel is now event target (Object)
  • There is no ResourceTreeModel -> UI dependencies
  • NetworkManager -> ResourceTreeModel dependencies has been removed
  • NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
  • ResourceTreeModel requests tree structure from the backend separately
  • Cached resources tree payload is now limited to url and type (no headers involved)
  • Resources tree is being rendered lazily upon request from the panel.
  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::getCachedResources): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): (.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.frontendReused): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.frontendReused): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.frames): (WebInspector.ResourceTreeModel.prototype.subframes): (WebInspector.ResourceTreeModel.prototype.resources): (WebInspector.ResourceTreeModel.prototype._onCommitLoad): (WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._onResourceUpdated): (WebInspector.ResourceTreeModel.prototype._addResourceToFrame): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype._createResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame): (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype._frameAdded): (WebInspector.ResourcesPanel.prototype._frameDetached): (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.ResourcesPanel.prototype._frameNavigated): (WebInspector.FrameTreeElement.prototype.setTitles):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
5:04 AM Changeset in webkit [82105] by rniwa@webkit.org
  • 13 edits in trunk

2011-03-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

WebKit's behavior for text-align inherit differs from other browsers
​https://bugs.webkit.org/show_bug.cgi?id=56377

The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
the alignment of the text in those nodes should be determined based on the directionality of the text,
not by the directionality of the ancestor node from which text-align property is inherited.

Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
align text to the left in a LTR context and to the right in a RTL context respectively.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND. (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Ditto.
  • rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
  • rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.

2011-03-27 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

WebKit's behavior for text-align inherit differs from other browsers
​https://bugs.webkit.org/show_bug.cgi?id=56377

Added test more cases to text-align, which already has some tests for text-align: start and text-align: end.

  • fast/css/text-align-expected.txt:
  • fast/css/text-align.html:
  • platform/mac/fast/css/text-align-expected.checksum:
  • platform/mac/fast/css/text-align-expected.png:
5:02 AM Changeset in webkit [82104] by abecsi@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-28 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the linking of jsc with MinGW after r81963.

  • jsc.pro: add -l and remove the lib suffix.
4:57 AM Changeset in webkit [82103] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix breakpoints positions in formatted scripts.
​https://bugs.webkit.org/show_bug.cgi?id=56931

Add async requestMapping method to SourceFile interface as required for populating
breakpoints sidebar pane when in "format all scripts" mode.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI. (WebInspector.PresentationBreakpoint.prototype.get sourceFileId): (WebInspector.PresentationBreakpoint.prototype.get lineNumber): (WebInspector.PresentationBreakpoint.prototype.get condition): (WebInspector.PresentationBreakpoint.prototype.get enabled): (WebInspector.PresentationBreakpoint.prototype.get url): (WebInspector.PresentationBreakpoint.prototype.get resolved): (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.requestSourceMapping): (WebInspector.FormattedSourceFile.prototype.requestSourceMapping): (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation): (WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation): (WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
4:49 AM Changeset in webkit [82102] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

This patch fixes linking errors on Qt Webkit Windows MinGW builds.
This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
QWEBKIT_EXPORT is defined as follows:

Patch by Nancy Piedra <​nancy.piedra@nokia.com> on 2011-03-28
Reviewed by Csaba Osztrogonác.

No new tests needed since only changing .pro file.

  • WebCore.pro:
4:46 AM Changeset in webkit [82101] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit/win

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix.

  • COMPropertyBag.h: Added missing include.
  • WebKitCOMAPI.h: Ditto.
  • WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
4:36 AM Changeset in webkit [82100] by yutak@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed. Yet another test result fix for fast/blockflow/fallback-orientation-expected.html.

  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt.
4:31 AM Changeset in webkit [82099] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: source frame should show the error to user when live edit is failed
​https://bugs.webkit.org/show_bug.cgi?id=57002

  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
4:30 AM Changeset in webkit [82098] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add Chromium test expectation for inspector/debugger/debugger-activation-crash.html.

  • platform/chromium/test_expectations.txt:
4:06 AM Changeset in webkit [82097] by yutak@chromium.org
  • 1 edit
    3 moves
    1 add in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, move Chromium test results into the right directory (move WinXP
baseline into chromium-win-xp).

  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum.
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.png.
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt.
3:45 AM Changeset in webkit [82096] by yutak@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add new Chromium test results and expectation.

  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:16 AM Changeset in webkit [82095] by mario@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Expose the AtkValue interface for WAI-ARIA sliders
​https://bugs.webkit.org/show_bug.cgi?id=56655

New test to check WAI-ARIA sliders required attributes.

  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Added.
  • platform/gtk/accessibility/aria-slider-required-attributes.html: Added.

2011-03-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Expose the AtkValue interface for WAI-ARIA sliders
​https://bugs.webkit.org/show_bug.cgi?id=56655

Implement AtkValue interface for WAI-ARIA sliders.

Test: platform/gtk/accessibility/aria-slider-required-attributes.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the 'property-change::accessible-value' signal when needed.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (core): New, returns a core object from an AtkValue. (webkitAccessibleValueGetCurrentValue): New, implements AtkValue. (webkitAccessibleValueGetMaximumValue): Ditto. (webkitAccessibleValueGetMinimumValue): Ditto. (webkitAccessibleValueSetCurrentValue): Ditto. (webkitAccessibleValueGetMinimumIncrement): Ditto. (atkValueInterfaceInit): Ditto. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE. (getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.
2:49 AM Changeset in webkit [82094] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <​svillar@igalia.com>

[GTK] Fullscreen tests failing after r82084
​https://bugs.webkit.org/show_bug.cgi?id=57219

Skipping some fullscreen tests failing since r82084

  • platform/gtk/Skipped:
2:33 AM Changeset in webkit [82093] by mjs@apple.com
  • 3 edits
    5 adds in trunk

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Assigning location.path to something that doesn't start with / mangles the authority
​https://bugs.webkit.org/show_bug.cgi?id=57209
<rdar://problem/9195132>


Tests: http/tests/uri/assign-path-with-leading-slash.html

http/tests/uri/assign-path-without-leading-slash.html

  • platform/KURL.cpp: (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.

2011-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Assigning location.path to something that doesn't start with / mangles the authority
​https://bugs.webkit.org/show_bug.cgi?id=57209
<rdar://problem/9195132>

  • http/tests/uri/assign-path-with-leading-slash-expected.txt: Added.
  • http/tests/uri/assign-path-with-leading-slash.html: Added.
  • http/tests/uri/assign-path-without-leading-slash-expected.txt: Added.
  • http/tests/uri/assign-path-without-leading-slash.html: Added.
  • http/tests/uri/resources/assign-path-landing.html: Added.
2:28 AM Changeset in webkit [82092] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add Chromium test expectation for fast/text/justify-ideograph-leading-expansion.html.

  • platform/chromium/test_expectations.txt:
2:19 AM Changeset in webkit [82091] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Extract functions to update logical width from computeInlineDirectionPositionsForLine
​https://bugs.webkit.org/show_bug.cgi?id=57213

Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.

They are used to update logical widths, logical left, and total logical width for left,
right, and center aligned blocks.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::updateLogicalWidthForLeftAlignedBlock): (WebCore::updateLogicalWidthForRightAlignedBlock): (WebCore::updateLogicalWidthForCenterAlignedBlock): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1:57 AM Changeset in webkit [82090] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Evan Martin <​evan@chromium.org>

Reviewed by Ryosuke Niwa.

Refactor duplicate code in HTMLTextElement
​https://bugs.webkit.org/show_bug.cgi?id=57215

  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged): This method did an equivalent loop to the text() method on the same object.
1:26 AM Changeset in webkit [82089] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, update Chromium test results for plugins/plugin-javascript-access.html.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/chromium-win/plugins/plugin-javascript-access-expected.txt:
  • platform/chromium/test_expectations.txt:

Mar 27, 2011:

11:46 PM Changeset in webkit [82088] by ukai@chromium.org
  • 3 edits
    3 adds in trunk

2011-03-27 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
​https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
  • http/tests/websocket/tests/close-unref-websocket.html: Added.
  • http/tests/websocket/tests/hanging-handshake_wsh.py: Added.

2011-03-27 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
​https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
WebSocketChannel suppress the second didClose().

Test: http/tests/websocket/tests/close-unref-websocket.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::didClose):
11:41 PM Changeset in webkit [82087] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-27 Andy Estes <​aestes@apple.com>

Reviewed by Maciej Stachowiak.

Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
​https://bugs.webkit.org/show_bug.cgi?id=57205


If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
plug-in MIME types, WebKit has to check for a property list file in
~/Library/Preferences for the MIME type dictionary.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary has the key WebPluginMIMETypesFilename, open the property list specified by that key's value and return the MIME type dictionary from there. Otherwise, return the MIME type dictionary specified by the key WebPluginMIMETypes. (WebKit::getPluginInfoFromPropertyLists): Call getMIMETypesFromPluginBundle().
11:09 PM Changeset in webkit [82086] by yutak@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.

  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.
10:15 PM Changeset in webkit [82085] by abarth@webkit.org
  • 11 edits in trunk

2011-03-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
​https://bugs.webkit.org/show_bug.cgi?id=57196

Test both allow => disallow and disallow => allow redirect cases.
Previously, we had incorrect expectations for one of the redirect
cases. Also, I've updated the policy syntax to match the default-src
syntax.

  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:

2011-03-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
​https://bugs.webkit.org/show_bug.cgi?id=57196

Resource-loading requirements in CSP apply to each hop in the redirect
chain. To make that work properly, we need to move enforcement into
the loader. Fortunately, we already have a choke-point in the loader
for enforcing this kind of policy.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunnerHost.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  • page/ContentSecurityPolicy.h:
9:27 PM Changeset in webkit [82084] by jer.noble@apple.com
  • 18 edits in trunk

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Pass whether keyboard access was requested up to ChromeClient when asking
if fullscreen mode is supported.

  • dom/Document.cpp: (WebCore::Document::webkitRequestFullScreenForElement):
  • page/ChromeClient.h: (WebCore::ChromeClient::supportsFullscreenForElement):

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullScreenForElement):
  • WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
  • WebView/WebViewInternal.h:

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::supportsFullScreen):
  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::supportsFullScreenForElement):
  • WebProcess/WebCoreSupport/WebChromeClient.h:

2011-03-27 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
​https://bugs.webkit.org/show_bug.cgi?id=56684

Accept the withKeyboard parameter to supportsFullScreenForElement.

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
7:33 PM Changeset in webkit [82083] by Patrick Gansterer
  • 3 edits
    2 adds in trunk/Tools

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Levin.

check-webkit-style should check ChangeLog for a valid bug number
​https://bugs.webkit.org/show_bug.cgi?id=57184

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py: Added.
  • Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3:54 PM Changeset in webkit [82082] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

2011-03-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts):
2:22 PM Changeset in webkit [82081] by mrowe@apple.com
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

2:21 PM Changeset in webkit [82080] by mrowe@apple.com
  • 1 copy in tags/Safari-534.26.4

New tag.

2:21 PM Changeset in webkit [82079] by mrowe@apple.com
  • 3 edits in branches/safari-534.26-branch/Source/WebKit2

Merge r82078.

12:56 PM Changeset in webkit [82078] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Dock doesn't come back after leaving fullscreen on Hulu
​https://bugs.webkit.org/show_bug.cgi?id=57189
<rdar://problem/9192413>

Port some code over from the old WebKit1 plug-in host.

  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::shimShowMenuBar): (WebKit::shimHideMenuBar): (WebKit::shimIsMenuBarVisible):
12:26 PM Changeset in webkit [82077] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Keep a strong reference to the connection to avoid crashes.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:
12:15 PM Changeset in webkit [82076] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Fix build warning about IconDatabaseClient.h (wrong path.)

12:12 PM Changeset in webkit [82075] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support for CSS color and background-color properties on select element's dropdown list
​https://bugs.webkit.org/show_bug.cgi?id=51627

Extend the QWebSelectData interface with background and foreground colors
for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
getters in RenderMenuList.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/PopupMenuQt.cpp: (SelectData::backgroundColor): (SelectData::foregroundColor): (SelectData::itemBackgroundColor): (SelectData::itemForegroundColor):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
11:26 AM Changeset in webkit [82074] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-03-27 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] Fix Api test failure -- microFocusCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=57108

Since the canvas is not self-closing tag, we need to add '</canvas>'.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
10:52 AM Changeset in webkit [82073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
​https://bugs.webkit.org/show_bug.cgi?id=57143

Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
define WTF_USE_TEXTURE_MAPPER=1.

10:42 AM Changeset in webkit [82072] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Fix agentOS() in FrameLoaderClientEfl
​https://bugs.webkit.org/show_bug.cgi?id=57177

Replace old PLATFORM macro with OS and CPU.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
10:38 AM Changeset in webkit [82071] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[EFL] Use an appropriate user agent string
​https://bugs.webkit.org/show_bug.cgi?id=57176

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
10:28 AM Changeset in webkit [82070] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Use a appropriate user agent string
​https://bugs.webkit.org/show_bug.cgi?id=57175

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::userAgent):
10:24 AM Changeset in webkit [82069] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Generate WebKitVersion.h
​https://bugs.webkit.org/show_bug.cgi?id=57128

This file will be used for the user agent string by the CMake based ports.

  • CMakeLists.txt:
10:20 AM BuildingQtOnLinux edited by srikumar.b@gmail.com
(diff)
9:36 AM Changeset in webkit [82068] by yutak@chromium.org
  • 7 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add new Chromium test result and expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/chromium/test_expectations.txt:
9:36 AM Changeset in webkit [82067] by commit-queue@webkit.org
  • 14 edits in trunk/Source

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • wtf/MessageQueue.h:

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • dom/ExceptionCode.h:
  • editing/EditorInsertAction.h:
  • loader/FrameLoaderTypes.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/ScrollTypes.h:
  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/text/TextCodec.h:
7:50 AM Changeset in webkit [82066] by rwlbuis@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-27 Rob Buis <​rwlbuis@gmail.com>

Unreviewed, update improve test result.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
7:23 AM Changeset in webkit [82065] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
​https://bugs.webkit.org/show_bug.cgi?id=57183

The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
which was due to the outputting code previously being wrapped in eval().

  • Api/DerivedSources.pro:
6:26 AM Changeset in webkit [82064] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:38 AM Changeset in webkit [82063] by yutak@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, add new Chromium test results.

  • platform/chromium-linux/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.txt: Added.
5:25 AM Changeset in webkit [82062] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, fix Chromium text expectation.

  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [82061] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-27 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Text on path positioning at zero startOffset
​https://bugs.webkit.org/show_bug.cgi?id=56245

Since for length 0 no previous point is set, choose epsilon
length to get normal at starting point of the path.

Test: svg/text/text-path-middle-align.svg

  • platform/graphics/Path.cpp: (WebCore::Path::normalAngleAtLength):
2:53 AM Changeset in webkit [82060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-27 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
created by Thiago Macieria in bug ​https://bugs.webkit.org/show_bug.cgi?id=24932

Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions

  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::thisObject):
12:18 AM Changeset in webkit [82059] by benjamin.poulain@nokia.com
  • 8 edits in trunk/Source/WebKit/qt

2011-03-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • Api/qwebkitversion.cpp: (qWebKitVersion):
  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::javaScriptConsoleMessage):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::setEditingBehavior): (DumpRenderTreeSupportQt::plainText):
  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
  • WebCoreSupport/InspectorServerQt.cpp: (WebCore::parseWebSocketChallengeNumber): (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

Mar 26, 2011:

10:19 PM Changeset in webkit [82058] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Jeff Miller <​jeffm@apple.com>

Reviewed by Sam Weinig.

WKErrorCopyCFError() doesn&apos;t actually return a copy of the CFErrorRef
​https://bugs.webkit.org/show_bug.cgi?id=57172

  • Shared/API/c/cf/WKErrorCF.cpp: (WKErrorCopyCFError): Use RetainPtr<> and leakRef() to return a real copy.
8:12 PM Changeset in webkit [82057] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix a bug which was causing the "skip back" button to be missing, causing
the media layout tests to fail.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

6:38 PM Changeset in webkit [82056] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
​https://bugs.webkit.org/show_bug.cgi?id=57169

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/blockflow/fallback-orientation.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.

LayoutTests:

  • fast/blockflow/fallback-orientation.html: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.
6:10 PM Changeset in webkit [82055] by mjs@apple.com
  • 5 edits in trunk

Source/WebKit2: Revert inadvertantly commited changes.

  • WebProcess/com.apple.WebProcess.sb:

Tools: Revert inadvertantly committed changes.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:58 PM Changeset in webkit [82054] by mjs@apple.com
  • 6 edits
    2 adds in trunk

2011-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
​https://bugs.webkit.org/show_bug.cgi?id=56150

Test: fast/css/giant-stylesheet-crash.html

  • dom/StyleElement.cpp: (WebCore::StyleElement::process):

2011-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
​https://bugs.webkit.org/show_bug.cgi?id=56150

  • fast/css/giant-stylesheet-crash-expected.txt: Added.
  • fast/css/giant-stylesheet-crash.html: Added.
5:15 PM Changeset in webkit [82053] by jer.noble@apple.com
  • 14 edits
    1 add in trunk/Source/WebCore

2011-03-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Media controls must use full screen style when in new full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=56851

Add new full screen styles for the full screen media elements.

  • DerivedSources.make: Add fullScreenQuickTime.css.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded(). (WebCore::CSSStyleSelector::CSSStyleSelector): Ditto. (WebCore::CSSStyleSelector::styleForElement): Load full screen rules

if needed.

  • css/fullscreenQuickTime.css: Added.
  • css/mediaControls.css:
  • html/shadow/MediaControls.cpp: (WebCore::isFullScreen): Added. (WebCore::MediaControls::create): Add new full screen volume controls. (WebCore::MediaControls::updateStyle): Ditto. (WebCore::MediaControls::update): Ditto. (WebCore::MediaControls::updateVolumeSliderContainer): Ditto. (WebCore::MediaControls::forwardEvent): Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::create): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet (WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
  • rendering/MediaControlElements.h:

Added m_overridePosition.

(WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added. (WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward

buttons.

5:03 PM Changeset in webkit [82052] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56956

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56956

  • Shared/WebPreferencesStore.h: Default the fullScreenEnabled preference to true.
4:46 PM Changeset in webkit [82051] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-26 Jer Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

RenderMedia should obey the view's flattening bit.
​https://bugs.webkit.org/show_bug.cgi?id=57156

Paint the current frame in software when the associated FrameView
has its flattening bit set.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
4:05 PM Changeset in webkit [82050] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for !ENABLE(DOM_STORAGE).

  • storage/StorageTracker.cpp:

Added #if ENABLE(DOM_STORAGE) like in the other storage files.

3:53 PM Changeset in webkit [82049] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows
​https://bugs.webkit.org/show_bug.cgi?id=57152

Reviewed by Steve Falkenburg.

We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.
Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor. Use return value from CertDuplicateCertificateContext().
(WebKit::PlatformCertificateInfo::operator=): Use return value from CertDuplicateCertificateContext().

  • Shared/win/PlatformCertificateInfo.h: Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor.
2:36 PM Changeset in webkit [82048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Graphic corruption appeared with Silverlight contents while resizing window
​https://bugs.webkit.org/show_bug.cgi?id=57167
<rdar://problem/9094052>

Pass DispatchMessageEvenWhenWaitingForSyncReply when sending GeometryDidChange messages since that will guarantee
that those messages will be handled before PaintEntirePlugin messages which prevents the PaintEntirePlugin handler from
painting into the wrong backing store.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
2:18 PM Changeset in webkit [82047] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Web process considered unresponsive (SPOD shown) when displaying a JavaScript alert() as a result of a click
<rdar://problem/9067557>
​https://bugs.webkit.org/show_bug.cgi?id=57166

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): Invalidate the responsiveness timer before calling out to the client.
2:17 PM Changeset in webkit [82046] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

2011-03-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Show page icons (favicons) in QtTestBrowser location bar.
​https://bugs.webkit.org/show_bug.cgi?id=57162

  • QtTestBrowser/QtTestBrowser.qrc:
  • QtTestBrowser/favicon.png: Added.
  • QtTestBrowser/locationedit.cpp: (defaultPageIcon): (LocationEdit::LocationEdit): (LocationEdit::setPageIcon): (LocationEdit::resizeEvent): (LocationEdit::updateInternalGeometry):
  • QtTestBrowser/locationedit.h:
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::onIconChanged): (MainWindow::onLoadStarted):
  • QtTestBrowser/mainwindow.h:
2:15 PM Changeset in webkit [82045] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

ASSERTION FAILED: m_operationInProgress == NoOperation loading nytimes.com
​https://bugs.webkit.org/show_bug.cgi?id=57165
<rdar://problem/9024311>

The assertion fired because during GC, the web process sends a synchronous NPObjectMessageReceiver::Deallocate
message to the plug-in process. Since this is a synchronous message, the web process needs to process incoming synchronous
messages. While waiting, we get an incoming PluginProxy::Evaluate message from the plug-in. This causes JavaScript to run
during GC which is very bad.

The fix for this is to add a flag on the connection that will cause synchronous messages sent by the connection (in this case the
plug-in process) to not be processed while the other side (the web process) is waiting for a synchronous reply _unless_ the connection
is actually processing a synchronous message. (The last part is to avoid deadlocks).

Since the call to NPN_Evaluate by the plug-in (that ends up sending the PluginProxy::Evaluate message) comes from a run loop timer firing,
it's OK to wait for it to be processed by the web process when it returns to the run loop.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage and m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount.

(CoreIPC::Connection::setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage):
Set m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage.

(CoreIPC::Connection::sendMessage):
Don't add the MessageID::DispatchMessageWhenWaitingForSyncReply flag when the right flags has been set on the connection, and it's not processing a synchronous message.

(CoreIPC::Connection::dispatchMessage):
Increment and decrement m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount accordingly.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::WebProcessConnection): Call setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the connection.
1:50 PM Changeset in webkit [82044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-26 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Benjamin Poulain.

[Qt] Remove GraphicsLayerTextureMapper::nativeLayer
​https://bugs.webkit.org/show_bug.cgi?id=57141

GraphicsLayer::nativeLayer was removed in r73380.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
1:48 PM Changeset in webkit [82043] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Rollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations))

-[NSString stringByResolvingSymlinksInPath] does not do what we needed for paths within /private.
This caused all SSL sites to stop working.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):

1:32 PM Changeset in webkit [82042] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
<rdar://problem/9127411>
​https://bugs.webkit.org/show_bug.cgi?id=57164

  • WebProcess/mac/WebProcessMac.mm: (WebKit::appendSandboxParameterPath): (WebKit::initializeSandbox): Use -[NSString stringByResolvingSymlinksInPath] instead of realpath to ensure we can resolve symlinks even if the file/directory doesn't exist yet.
1:20 PM Changeset in webkit [82041] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Factor processing of incoming sync replies out into processIncomingSyncReply
​https://bugs.webkit.org/show_bug.cgi?id=57161

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): Pass DispatchMessageEvenWhenWaitingForSyncReply to sendMessage.

(CoreIPC::Connection::processIncomingSyncReply):
Move code from processIncomingMessage to here.

(CoreIPC::Connection::processIncomingMessage):
Call processIncomingSyncReply.

1:14 PM Changeset in webkit [82040] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] layoutTestController.overridePreference("WebKitDefaultFontSize"...) does not take into account screen DPI
​https://bugs.webkit.org/show_bug.cgi?id=57160

Skip failing test. This bug was uncovered by r82033.

  • platform/gtk/Skipped:
1:07 PM Changeset in webkit [82039] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Remove a test from the GTK+ skipped list that no longer exists.

  • platform/gtk/Skipped: Update the skipped list.
1:04 PM Changeset in webkit [82038] by Martin Robinson
  • 10 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few more GTK+ tests after r82033.

  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
12:55 PM Changeset in webkit [82037] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Source/JavaScriptGlue

2011-03-26 Adam Barth <​abarth@webkit.org>

Remove the JavaScriptGlue GYP build. We're not going to use GYP for
JavaScriptGlue because JavaScriptGlue is used only by one port.

  • gyp: Removed.
  • gyp/JavaScriptGlue.gyp: Removed.
  • gyp/JavaScriptGlue.gypi: Removed.
  • gyp/remove-headers-if-needed.sh: Removed.
  • gyp/run-if-exists.sh: Removed.
  • gyp/update-info-plist.sh: Removed.
12:37 PM Changeset in webkit [82036] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate
<rdar://problem/9188041>
​https://bugs.webkit.org/show_bug.cgi?id=57159

  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::typeFromCFTypeRef): (CoreIPC::encode): (CoreIPC::decode):
  • Shared/cf/ArgumentCodersCF.h: Add encoding/decoding for SecCertificateRef type.
  • Shared/mac/PlatformCertificateInfo.mm: (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): Use ArgumentCodersCF now that it knows how to encode/decode SecCertificateRefs.
12:34 PM Changeset in webkit [82035] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Handle synchronous replies coming in out of order
​https://bugs.webkit.org/show_bug.cgi?id=57158

When processing an incoming reply, don't assume that it belongs to the last sent synchronous request.
Instead, iterate over the m_pendingSyncReplies vector backwards looking for the corresponding request.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage):
12:28 PM Changeset in webkit [82034] by andreas.kling@nokia.com
  • 5 edits
    2 adds in trunk/Source/WebKit/qt

2011-03-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
​https://bugs.webkit.org/show_bug.cgi?id=57157

Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
is always emitted when appropriate.

  • WebCoreSupport/IconDatabaseClientQt.h: Added.
  • WebCoreSupport/IconDatabaseClientQt.cpp: Added. (WebCore::IconDatabaseClientQt::instance): (WebCore::IconDatabaseClientQt::IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::performImport): (WebCore::IconDatabaseClientQt::didRemoveAllIcons): (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL): (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL): (WebCore::IconDatabaseClientQt::didChangeIconForPageURL): (WebCore::IconDatabaseClientQt::didFinishURLImport):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::registerForIconNotification): (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the QWebFrame::iconChanged() signal when the IconDatabases finishes loading a cached favicon for the frame's URL.
  • Api/qwebsettings.cpp: (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is instantiated. An IconDatabaseClient has to be registered before the IconDatabase spawns its reader thread.
11:52 AM Changeset in webkit [82033] by Martin Robinson
  • 196 edits in trunk

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
​https://bugs.webkit.org/show_bug.cgi?id=56866

Update GTK+ test results which now have differ.

  • platform/gtk/editing/pasteboard/4641033-expected.checksum:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.checksum:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.checksum:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.checksum:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.checksum:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/forms/001-expected.checksum:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.checksum:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.checksum:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.checksum:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.checksum:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.checksum:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/select-align-expected.checksum:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.checksum:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.checksum:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.checksum:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.checksum:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.checksum:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/html/keygen-expected.checksum:
  • platform/gtk/fast/html/keygen-expected.png:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/invalid/014-expected.checksum:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.checksum:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.checksum:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.checksum:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.checksum:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.checksum:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:

2011-03-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
​https://bugs.webkit.org/show_bug.cgi?id=56866

Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
broader compatibility with WebKit2 and makes setting font sizes more straightforward.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI. (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution. (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
11:23 AM Changeset in webkit [82032] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix a possible deadlock when two synchronous messages are sent at the same time
​https://bugs.webkit.org/show_bug.cgi?id=57155

Simplify code and fix a possible (although highly improbable) dead lock.

  • Platform/CoreIPC/Connection.cpp: Make SyncMessageState atomically ref counted since it can be ref()'ed from the connection queue. Get rid of m_waitForSyncReplyCount and add m_didScheduleDispatchMessagesWork.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_didScheduleDispatchMessagesWork to false.

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
if m_didScheduleDispatchMessagesWork is false, schedule a call to dispatchMessageAndResetDidScheduleDispatchMessagesWork
on the client run loop.

(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork):
Dispatch messages and set m_didScheduleDispatchMessagesWork back to false.

(CoreIPC::Connection::sendSyncMessage):
Remove calls to beginWaitForSyncReply and endWaitForSyncReply.

11:15 AM Changeset in webkit [82031] by Martin Robinson
  • 45 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <​mrobinson@igalia.com>

Rebaseline many GTK+ tests after r81994.

  • platform/gtk/fast/block/positioning/056-expected.txt:
  • platform/gtk/fast/block/positioning/auto/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/gtk/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/gtk/fast/clip/001-expected.txt:
  • platform/gtk/fast/clip/004-expected.txt:
  • platform/gtk/fast/clip/006-expected.txt:
  • platform/gtk/fast/clip/007-expected.txt:
  • platform/gtk/fast/clip/008-expected.txt:
  • platform/gtk/fast/clip/009-expected.txt:
  • platform/gtk/fast/clip/010-expected.txt:
  • platform/gtk/fast/clip/011-expected.txt:
  • platform/gtk/fast/clip/012-expected.txt:
  • platform/gtk/fast/clip/013-expected.txt:
  • platform/gtk/fast/clip/014-expected.txt:
  • platform/gtk/fast/clip/nestedTransparencyClip-expected.txt:
  • platform/gtk/fast/clip/outline-overflowClip-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/layers/layer-visibility-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
7:38 AM Changeset in webkit [82030] by abarth@webkit.org
  • 2 edits in trunk

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We shouldn't bother running GYP if the generated files are newer than the GYP files
​https://bugs.webkit.org/show_bug.cgi?id=57146

In the common case, this check will avoid any overhead from processing
the GYP files. Another approach to doing this is to add the feature to
GYP directly, but GYP's approach to this problem is to compute the
output in its entirety and compare it byte-for-byte against the output
file. In the future, it might make sense to add this approach as an
alternative approach for GYP itself.

I also removed JavaScriptGlue from the script because we're not really
going to change JavaScriptGlue over to GYP. We were using
JavaScriptGlue as a learning experience.

  • Source/gyp/configure:
7:25 AM Changeset in webkit [82029] by Csaba Osztrogonác
  • 11 edits in trunk/LayoutTests

Update Qt specific expected results after r81992.

  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
4:59 AM Changeset in webkit [82028] by abarth@webkit.org
  • 10 edits
    2 adds in trunk

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
​https://bugs.webkit.org/show_bug.cgi?id=54799

Test a variety of source-list parsing cases. There's a bunch more
cases we could be testing. We'll add more over time.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing.html: Added.

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
​https://bugs.webkit.org/show_bug.cgi?id=54799

This patch is larger than I would like, but I wasn't sure how to make
it any smaller while still being reasonably testable. I've left out
some features (such as host wildcarding and 'self') so I can add them
in later patches with tests.

Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html

  • bindings/ScriptControllerBase.cpp:
  • dom/ScriptElement.cpp:
  • html/parser/HTMLDocumentParser.cpp:
  • loader/FrameLoader.cpp:
    • Add include explicitly now that we're not spamming the include everywhere.
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
    • We need to pass the SecurityOrigin object to ContentSecurityPolicy so that it can resolve implicit parts of source patterns, such as the scheme.
  • dom/Document.h:
    • Forward declare ContentSecurityPolicy rather than including the header. Technically this could be a separate change, but I was getting annoyed at the world re-builds.
  • page/ContentSecurityPolicy.cpp: (WebCore::skipExactly): (WebCore::skipUtil): (WebCore::skipWhile):
    • Clean up these parser helper functions. We might consider moving them to a more general location. They're very helpful for writing secure HTTP header parsers.

(WebCore::CSPSource::CSPSource):

  • New class to represent one source in a source-list.

(WebCore::CSPSource::matches):
(WebCore::CSPSource::schemeMatches):
(WebCore::CSPSource::hostMatches):
(WebCore::CSPSource::portMatches):
(WebCore::CSPSource::isSchemeOnly):

  • Currently we represent scheme-only sources using with an empty m_host. Another approach I considered was using another bool, but that seemed slighly messier.

(WebCore::CSPSourceList::CSPSourceList):

  • CSPSourceList doesn't need to ref SecurityOrigin because CSPSourceList is owned by ContentSecurityPolicy, which holds a ref.

(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::parseScheme):
(WebCore::CSPSourceList::parseHost):
(WebCore::CSPSourceList::parsePort):

  • A basic "segment and recurse" parser. This parser causes us to take more branches than we need, but I don't think we need to squeeze every last ouch of performance out of this parser. This approach is more simple than some of the other approaches I tried.

(WebCore::CSPSourceList::addSourceSelf):
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::parseDirective):
(WebCore::ContentSecurityPolicy::addDirective):

  • I couldn't resist re-writing this parser to use the helper functions and to match the style of the source-list parser.
  • page/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::create):
    • Accept a SecurityOrigin context object.
3:03 AM Changeset in webkit [82027] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL and WinCE build fix for r81977.

  • platform/graphics/FontPlatformData.h:
12:49 AM Changeset in webkit [82026] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added platform-specific expected results for a new test.

  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
12:22 AM Changeset in webkit [82025] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r82000.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::openFile): Added missing function.
12:07 AM Changeset in webkit [82024] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix.

  • CMakeListsWinCE.txt: Added missing include directory.

Mar 25, 2011:

11:22 PM Changeset in webkit [82023] by mrowe@apple.com
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

11:20 PM Changeset in webkit [82022] by mrowe@apple.com
  • 1 copy in tags/Safari-534.26.3

New tag.

8:06 PM Changeset in webkit [82021] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <​scheib@chromium.org>

Chromium test_expectations: bug added for tests impacted by r81992

  • platform/chromium/test_expectations.txt:
6:42 PM Changeset in webkit [82020] by aestes@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html only passing on SnowLeopard.
​https://bugs.webkit.org/show_bug.cgi?id=57137

Check in failing results for this test (except for on SnowLeopard) until
the failure can be diagnosed.

  • platform/mac-snowleopard/plugins: Added.
  • platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
  • plugins/embed-prefers-plugins-for-images-expected.txt:
6:22 PM Changeset in webkit [82019] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-25 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

WKPageLoadAlternateHTMLString doesn't re-spawn a dead WebProcess, but should
<rdar://problem/9191493>
​https://bugs.webkit.org/show_bug.cgi?id=57134

Make all load functions respawn a dead WebProcess for consistency.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadHTMLString): Respawn a dead WebProcess.

(WebKit::WebPageProxy::loadAlternateHTMLString):
Respawn a dead WebProcess.

(WebKit::WebPageProxy::loadPlainTextString):
Respawn a dead WebProcess.

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadAlternateHTMLString): Since we may no longer always have a main frame when calling WKPageLoadAlternateHTMLString, set the unreachable URL, if there is one, on provisional load.
6:21 PM Changeset in webkit [82018] by kevino@webkit.org
  • 4 edits in trunk

[wx] Build fix, don't use the new FPD implementation yet, until we can merge ours with it.

6:17 PM Changeset in webkit [82017] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

LayoutTestController.setPluginsEnabled() isn't implemented in WebKit2,
and that is now required for fast/images/embed-image.html.

  • platform/mac-wk2/Skipped: Skip fast/images/embed-image.html
6:13 PM Changeset in webkit [82016] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/images/embed-image.html on Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=57135

It would appear that the Windows XP bot is loading a plug-in despite
the test calling layoutTestController.setPluginsEnabled(false).

  • platform/win-xp/Skipped: Skip fast/images/embed-image.html
5:52 PM Changeset in webkit [82015] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Re-work a test to not be flaky.

  • plugins/embed-prefers-plugins-for-images.html:
5:51 PM Changeset in webkit [82014] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

2011-03-25 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
​https://bugs.webkit.org/show_bug.cgi?id=57047

No new tests.

When loading a URL, checkk osee if the Appplication Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::loadPath):
  • platform/graphics/win/QTMovie.h:
5:46 PM Changeset in webkit [82013] by mitz@apple.com
  • 12 edits
    4 adds in trunk

<rdar://problem/9134330> Missing expansion before ideograph at the beginning or end of a text run
​https://bugs.webkit.org/show_bug.cgi?id=57106

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/justify-ideograph-leading-expansion.html

  • platform/graphics/TextRun.h:

Replaced TrailingExpansionBehavior enum with ExpansionBehavior flags.
(WebCore::TextRun::TextRun): Constructors now take an expansionBehavior parameter.
(WebCore::TextRun::allowsLeadingExpansion): Added this accessor.
(WebCore::TextRun::allowsTrailingExpansion): Changed to use the m_expansionBehavior member.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion from the TextRun, allowing
leading expansion when appropriate.
(WebCore::WidthIterator::advance): Moved the last-glyph-in-run check to only apply to expansion
after the glyph, not expansion before the glyph, since that is not trailing expansion. Added code
to handle expansion before the first glyph.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize m_afterExpansion from the
TextRun, allowing leading expansion when appropriate. Set m_runWidthSoFar to the leading expansion.
(WebCore::ComplexTextController::offsetForPosition): Account for leading expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Similar to WidthIterator::advance()

  • platform/graphics/mac/ComplexTextController.h: Added m_leadingExpansion member variable.
  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasSelectedChildren to m_hasSelectedChildrenOrCanHaveLeadingExpansion
to reflect the use of this bit by InlineTextBox.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Replaced calls to trailingExpansionBehavior() with expansionBehavior().
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::canHaveLeadingExpansion): Added this accessor.
(WebCore::InlineTextBox::setCanHaveLeadingExpansion): Ditto.
(WebCore::InlineTextBox::expansionBehavior): Replaced trailingExpansionBehavior() with this function,
which also considers canHaveLeadingExpansion().

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Call setCanHaveLeadingExpansion() on
text boxes that can have leading expansion. Avoid negative expansion.

  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasSelectedChildren): Updated for renaming of the flag.
(WebCore::RootInlineBox::setHasSelectedChildren): Ditto.

LayoutTests:

  • fast/text/justify-ideograph-leading-expansion.html: Added.
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
5:45 PM Changeset in webkit [82012] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

PluginView's call to invalidateContentsAndWindow() in invalidateRect() is wrong for plug-ins which paint into compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=57133
<rdar://problem/9029442>

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformInvalidate): Return true under the Core Animation drawing model, since that prevents the plug-in from calling PluginController::invalidate.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::invalidateRect): Don't call invalidateContentsAndWindow() if the plug-in has a Core Animation layer.
5:41 PM Changeset in webkit [82011] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateAVFoundation should use the Application Cache during load.
​https://bugs.webkit.org/show_bug.cgi?id=56997

No new tests.

When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Check to see if the media should be loaded

from the application cache.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): Added. (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Split out from createAVPlayerForURL.
5:30 PM Changeset in webkit [82010] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-25 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=57122. Solaris 10/SunStudio 12 expect
both sides of a ?: operation to have the same types. Extracted from original
​https://bugs.webkit.org/show_bug.cgi?id=24932, patch 13 of 17, and originally
created by Thiago Macieira.

fixes a compile issue on Solaris 10/SunStudio 12

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::serverRedirectSourceForHistory):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction):
5:29 PM Changeset in webkit [82009] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-02-03 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateQTKit should use the Application Cache during load.
​https://bugs.webkit.org/show_bug.cgi?id=53818

No new tests.

When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use that data instead of the remote URL.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): (WebCore::MediaPlayerPrivateQTKit::createQTMovie): (WebCore::MediaPlayerPrivateQTKit::loadInternal):
5:14 PM Changeset in webkit [82008] by jam@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium/public/WebSpellCheckClient.h

[chromium] add missing include from previous checkin

5:12 PM Changeset in webkit [82007] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=57132

  • platform/win/Skipped: Skip plugins/embed-prefers-plugins-for-images.html
5:10 PM Changeset in webkit [82006] by jamesr@google.com
  • 22 edits
    5 copies
    1 add in trunk/Source/WebCore

2011-03-25 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Move draw implementations to CCLayerImpl for everything except content layers
​https://bugs.webkit.org/show_bug.cgi?id=56793

Moves the implementation of the layer's draw() function from LayerChromium subclasses to CCLayerImpl subclasses for
all layer types except content layers. This gets us closer to decoupling the composite step itself from updating the layers.

The biggest change in this patch is adding a set of CCLayerImpl subclasses to implement the different drawing routines
and moving the code from each XXXLayerChromium to CCXXXLayerImpl. In order to render from the CCLayerImpl side all state
needed at draw time also has to be synchronized, which is performed in pushPropertiesTo().

On the LayerRendererChromium side there are a few changes. I've split the updateContents calls on LayerChromiums into two operations
tentatively named 'paintContentsIfNeeded' and 'updateCompositorResources'. paintContents() is used for any code that calls into WebKit in order to generate
new pixel data. It's expected that this call may take a long period of time and may involve "odd" side effects. updateCompositorResources() is used for
code that needs to update the compositor's texture data or other state. It is not expected that this callback will take long (since it's just inserting
commands into the GL command stream, ideally) and this call is expected to have access to the compositor's context, unlike paintContents().

The updateAndDrawLayers cycle now looks like this:
1.) update the root content layer
2.) update the root layer scrollbars
3.) for each LayerChromium in tree order:

a.) ensure a CCLayerImpl of the correct type exists for this layer
b.) push all draw time properties from the LayerChromium to the CCLayerImpl
c.) construct the appropriate draw transforms, render surfaces and render surface z-order sublayer lists

4.) for each LayerChromium in tree order, paint the layer's contents
5.) for each LayerChromium in tree order, update the associate compositor resources (textures, etc)
6.) draw the root layer and its scrollbars
7.) for each CCLayerImpl in render surface order, draw it

Step 3 should really happen after step 5, but right now painting a content layer requires knowledge of the render surface properties and draw transforms
in order to paint. We also currently push layer properties from LayerChromium->CCLayerImpls twice now - once at 3.b and once after 5 so we can pick
up any texture updates. This will also get fixed when the paint dependency on render surfaces is resolved.

I haven't modified the root layer or content layers in order to minimize conflicts with the other pending work in that area.

Tests: compositing/

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::createCCLayerImpl): (WebCore::CanvasLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::updateCompositorResources): (WebCore::ContentLayerChromium::bindContentsTexture):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::setLayerRenderer): (WebCore::LayerChromium::setName): (WebCore::LayerChromium::pushPropertiesTo): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::createCCLayerImpl): (WebCore::LayerChromium::createCCLayerImplIfNeeded): (WebCore::LayerChromium::ccLayerImpl): (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::paintContentsIfDirty): (WebCore::LayerChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::paintContentsRecursive): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::canvasLayerProgram): (WebCore::LayerRendererChromium::pluginLayerProgram): (WebCore::LayerRendererChromium::videoLayerRGBAProgram): (WebCore::LayerRendererChromium::videoLayerYUVProgram):
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::createCCLayerImpl): (WebCore::PluginLayerChromium::setTextureId): (WebCore::PluginLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createCCLayerImpl): (WebCore::VideoLayerChromium::updateCompositorResources): (WebCore::VideoLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp. (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::~CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::draw): (WebCore::CCCanvasLayerImpl::dumpLayerProperties):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCCanvasLayerImpl::create): (WebCore::CCCanvasLayerImpl::setTextureId): (WebCore::CCCanvasLayerImpl::setPremultipliedAlpha):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::descendantsDrawsContent): (WebCore::CCLayerImpl::updateCompositorResources): (WebCore::CCLayerImpl::writeIndent):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setAnchorPoint): (WebCore::CCLayerImpl::setAnchorPointZ): (WebCore::CCLayerImpl::setMasksToBounds): (WebCore::CCLayerImpl::setOpacity): (WebCore::CCLayerImpl::setPosition): (WebCore::CCLayerImpl::setPreserves3D): (WebCore::CCLayerImpl::setSublayerTransform): (WebCore::CCLayerImpl::setTransform):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp. (WebCore::CCPluginLayerImpl::CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::~CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::draw): (WebCore::CCPluginLayerImpl::dumpLayerProperties):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCPluginLayerImpl::create): (WebCore::CCPluginLayerImpl::setTextureId):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Added. (WebCore::CCVideoLayerImpl::CCVideoLayerImpl): (WebCore::CCVideoLayerImpl::~CCVideoLayerImpl): (WebCore::CCVideoLayerImpl::setTexture): (WebCore::CCVideoLayerImpl::draw): (WebCore::CCVideoLayerImpl::drawYUV): (WebCore::CCVideoLayerImpl::drawRGBA): (WebCore::CCVideoLayerImpl::dumpLayerProperties):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::CCVideoLayerImpl::create): (WebCore::CCVideoLayerImpl::setSkipsDraw): (WebCore::CCVideoLayerImpl::setFrameFormat):
5:09 PM Changeset in webkit [82005] by beidson@apple.com
  • 7 edits
    3 adds in trunk/Source/WebKit2

<rdar://problem/8648311> and ​https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 IconDatabase and API

Reviewed by Sam Weinig.

This gets a basic, usable API in place.
Enhancements can come in other bugs as they're needed.

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseRetainIconForURL):
(WKIconDatabaseReleaseIconForURL):
(WKIconDatabaseEnableDatabaseCleanup):

  • UIProcess/API/C/WKIconDatabase.h:


The first actual accessor for an "icon for a URL" is for a CGImageRef:

  • UIProcess/API/C/cg: Added.
  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp: Added.

(WKIconDatabaseGetCGImageForURL):

  • UIProcess/API/C/cg/WKIconDatabaseCG.h: Added.


Expose relevant methods to support the above API:

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase): New IconDatabases will have cleanup disabled from the start,

and require a single call to "enableDatabaseCleanup" to allow cleanup.

(WebKit::WebIconDatabase::setDatabasePath):
(WebKit::WebIconDatabase::enableDatabaseCleanup):
(WebKit::WebIconDatabase::imageForPageURL):

  • UIProcess/WebIconDatabase.h:


Project file stuff:

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
5:04 PM Changeset in webkit [82004] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/win

WebScrollBar not updating when calling WebScrollBar::setValue.
<rdar://problem/9143871>

Reviewed by Jon Honeycutt.

  • WebScrollBar.cpp:

(WebScrollBar::setValue):
Call scrollToOffsetWithoutAnimation to actually update the scroll position.

4:20 PM Changeset in webkit [82003] by oliver@apple.com
  • 7 edits in trunk

2011-03-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=57129

Now we disallow the cross origin accesses, rather than just disallowing
the defineOwnProperty at all.

  • http/tests/security/xss-DENIED-defineProperty-expected.txt:

2011-03-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=57129

Fix a couple of places where we uses getter()/setter() rather
than [gs]etterPresent().

  • runtime/JSObject.cpp: (JSC::JSObject::defineOwnProperty):

2011-03-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Allow defineOwnProperty to work on DOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=57129

As other engines are allowing defineOwnProperty to be applied
to host objects there's no reason for us to retain this
restriction.

  • bindings/js/JSDOMWrapper.cpp:
  • bindings/js/JSDOMWrapper.h:
4:15 PM Changeset in webkit [82002] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-25 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms
​https://bugs.webkit.org/show_bug.cgi?id=57125


Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific.
In this patch, just replicate the existing common non-Mac implementation in WebCoreArgumentCoders.h to platform-specific files.

  • Shared/WebCoreArgumentCoders.h: Move non-Mac implementations of encodeResourceError() and decodeResourceError() to common files.
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.
  • Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Added. (CoreIPC::decodeResourceError): Added.
4:07 PM Changeset in webkit [82001] by aestes@apple.com
  • 48 edits
    2 adds in trunk

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

TestNetscapePlugIn needs to register support for an image MIME type so
we can test that the embed tag prefers plug-ins to render image MIME
types.

  • DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetMIMEDescription): Ditto.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

  • fast/images/embed-image.html: Disable plug-ins to continue testing native image rendering with embed.
  • plugins/embed-prefers-plugins-for-images-expected.txt: Added.
  • plugins/embed-prefers-plugins-for-images.html: Added.
  • plugins/plugin-javascript-access-expected.txt: Updated to include the new MIME type registered by TestNetscapePlugIn.

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):
  • src/FrameLoaderClientImpl.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebFrame.cpp: (WebFrame::objectContentType):
  • WebFrame.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::objectContentType):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType):

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::objectContentType):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::objectContentType):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::objectContentType):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
QuickTime plug-in in web pages. r70748 removed our mapping of classids
to MIME types, which causes WebKit to fall back from the object to the
embed tag when QuickTime is embedded by this script. The script emits
the following embed tag to embed a QuickTime movie with a poster frame:

<embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">

The expectation is that a QuickTime plug-in is instantiated to display the
poster frame, since QuickTime registers for many common image MIME
types. This is how Gecko behaves for embed. However, WebKit prefers to
use its native image rendering for image embeds, in which case no movie
is played when the poster frame is clicked.

Fix this by changing embed to check for a plug-in that can handle the
image type before rendering the image natively. This matches Gecko.

Test: plugins/embed-prefers-plugins-for-images.html

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parametersForPlugin):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::isImageType): (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::objectContentType):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin): (WebCore::SubframeLoader::requestPlugin): (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::shouldUsePlugin):
  • loader/SubframeLoader.h:

2011-03-25 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
​https://bugs.webkit.org/show_bug.cgi?id=49016

Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
4:04 PM Changeset in webkit [82000] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

2011-03-23 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Application Cache should save audio/ and video/ mime types as flat files
​https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>

No new tests, as this behavior is not possible to test without changes to the MediaPlayer engines.

Store certain mime types as flat files alongside the Application Cache database.
This requires plumbing the saved file path from ApplicationCacheStorage through
to ApplicationCacheResource.

(WebCore::ApplicationCacheStorage::openDatabase): Modify the CacheResourceData schema and

add a new DeletedCacheResources table, add a new CacheResourceDataDeleted trigger.

(WebCore::ApplicationCacheStorage::store): Add the new path data when adding new rows in

CacheResourceData, and store media resources as flat files.

(WebCore::ApplicationCacheStorage::loadCache): Pull the "path" column from CacheResourceData

when loading cache items.

(WebCore::ApplicationCacheStorage::remove): Call checkForDeletedResources.
(WebCore::ApplicationCacheStorage::empty): Ditto.
(WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
(WebCore::ApplicationCacheStorage::deleteCacheGroup): Ditto.
(WebCore::ApplicationCacheStorage::checkForDeletedResources): Walk through DeletedCacheResourceData

looking for entries with non-empty "path" columns; if found, delete.

(WebCore::ApplicationCacheStorage::flatFileAreaSize): Walk through CacheResourceData rows

and sum the file size of those rows with flat file storage.

(WebCore::ApplicationCacheStorage::verifySchemaVersion): Call deleteTables() instead of

clearAllTables() directly.

(WebCore::ApplicationCacheStorage::deleteTables): Call empty() before deleting the tables,

so that flat files get deleted.

(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile): Added.
(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Added.

  • loader/appcache/ApplicationCacheStorage.h:
  • platform/win/FileSystemWin.cpp: (WebCore::openFile): Implement openFile on Windows.
4:01 PM Changeset in webkit [81999] by kinuko@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-25 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Data race between ~WorkerFileSystemCallbacksBridge and runTasksOnWorkerThread
​https://bugs.webkit.org/show_bug.cgi?id=56138
Stopped passing the WorkerFileSystemCallbacksBridge's reference to
MainThreadFileSystemCallbacks so that in most cases (in normal cases)
its reference is only maintained by WorkerThread.

  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::MainThreadFileSystemCallbacks::createLeakedPtr): (WebKit::MainThreadFileSystemCallbacks::MainThreadFileSystemCallbacks): (WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):
  • src/WorkerFileSystemCallbacksBridge.h:
3:56 PM Changeset in webkit [81998] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <​scheib@chromium.org>

fast/forms/input-file-directory-upload.html timing out.
​http://crbug.com/77468

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [81997] by jberlin@webkit.org
  • 10 edits in trunk/Source/WebKit2

Unreviewed build correction.

Patch by Brent Fulgham <​bfulgham@webkit.org> on 2011-03-25
Add stubs for WK2 cookie handling with cURL.

  • WebProcess/Cookies/curl: Added.
  • WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • win/WebKit2.vcproj:
3:15 PM Changeset in webkit [81996] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-25 Vincent Scheib <​scheib@chromium.org>

Attempting SLOW to resolve fast/forms/input-file-directory-upload.html

  • platform/chromium/test_expectations.txt:
3:04 PM Changeset in webkit [81995] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-25 Martin Robinson <​mrobinson@igalia.com>

Add a GTK+ specific baseline for a text test that seems to have whitespace difference,
probably due to font sizes resulting in newlines.

  • platform/gtk/fast/events/onchange-text-form-field-expected.txt: Added.
3:01 PM Changeset in webkit [81994] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

2011-03-24 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.


In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.


The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).


The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

  • animations/dynamic-stylesheet-loading-expected.txt:
  • animations/keyframe-timing-functions-expected.txt:
  • fast/block/positioning/static-inline-position-dynamic.html: Added.
  • fast/block/positioning/trailing-space-test.html: Added.
  • fast/dynamic/ancestor-to-absolute-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/input-hit-test-border-expected.txt:
  • platform/mac/fast/block/positioning/002-expected.png:
  • platform/mac/fast/block/positioning/003-expected.png:
  • platform/mac/fast/block/positioning/004-expected.png:
  • platform/mac/fast/block/positioning/005-expected.png:
  • platform/mac/fast/block/positioning/006-expected.png:
  • platform/mac/fast/block/positioning/007-expected.png:
  • platform/mac/fast/block/positioning/008-expected.png:
  • platform/mac/fast/block/positioning/009-expected.png:
  • platform/mac/fast/block/positioning/010-expected.png:
  • platform/mac/fast/block/positioning/011-expected.png:
  • platform/mac/fast/block/positioning/012-expected.png:
  • platform/mac/fast/block/positioning/013-expected.png:
  • platform/mac/fast/block/positioning/014-expected.png:
  • platform/mac/fast/block/positioning/015-expected.png:
  • platform/mac/fast/block/positioning/016-expected.png:
  • platform/mac/fast/block/positioning/017-expected.png:
  • platform/mac/fast/block/positioning/018-expected.png:
  • platform/mac/fast/block/positioning/019-expected.png:
  • platform/mac/fast/block/positioning/020-expected.png:
  • platform/mac/fast/block/positioning/021-expected.png:
  • platform/mac/fast/block/positioning/022-expected.png:
  • platform/mac/fast/block/positioning/023-expected.png:
  • platform/mac/fast/block/positioning/024-expected.png:
  • platform/mac/fast/block/positioning/025-expected.png:
  • platform/mac/fast/block/positioning/026-expected.png:
  • platform/mac/fast/block/positioning/027-expected.png:
  • platform/mac/fast/block/positioning/028-expected.png:
  • platform/mac/fast/block/positioning/029-expected.png:
  • platform/mac/fast/block/positioning/030-expected.png:
  • platform/mac/fast/block/positioning/031-expected.png:
  • platform/mac/fast/block/positioning/032-expected.png:
  • platform/mac/fast/block/positioning/033-expected.png:
  • platform/mac/fast/block/positioning/034-expected.png:
  • platform/mac/fast/block/positioning/035-expected.png:
  • platform/mac/fast/block/positioning/036-expected.png:
  • platform/mac/fast/block/positioning/037-expected.png:
  • platform/mac/fast/block/positioning/038-expected.png:
  • platform/mac/fast/block/positioning/039-expected.png:
  • platform/mac/fast/block/positioning/040-expected.png:
  • platform/mac/fast/block/positioning/041-expected.png:
  • platform/mac/fast/block/positioning/042-expected.png:
  • platform/mac/fast/block/positioning/043-expected.png:
  • platform/mac/fast/block/positioning/044-expected.png:
  • platform/mac/fast/block/positioning/045-expected.png:
  • platform/mac/fast/block/positioning/046-expected.png:
  • platform/mac/fast/block/positioning/047-expected.checksum:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/block/positioning/048-expected.png:
  • platform/mac/fast/block/positioning/049-expected.png:
  • platform/mac/fast/block/positioning/050-expected.png:
  • platform/mac/fast/block/positioning/056-expected.txt:
  • platform/mac/fast/block/positioning/061-expected.png:
  • platform/mac/fast/block/positioning/062-expected.png:
  • platform/mac/fast/block/positioning/auto/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/block/positioning/move-with-auto-width-expected.png:
  • platform/mac/fast/block/positioning/negative-rel-position-expected.png:
  • platform/mac/fast/block/positioning/relative-overconstrained-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added.
  • platform/mac/fast/clip/001-expected.txt:
  • platform/mac/fast/clip/004-expected.txt:
  • platform/mac/fast/clip/006-expected.txt:
  • platform/mac/fast/clip/007-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/clip/009-expected.txt:
  • platform/mac/fast/clip/010-expected.txt:
  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
  • platform/mac/fast/clip/013-expected.txt:
  • platform/mac/fast/clip/014-expected.txt:
  • platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/invalid/014-expected.txt:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

2011-03-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash when paused at a breakpoint caused by inaccurate Activation records.
​https://bugs.webkit.org/show_bug.cgi?id=57120

  • runtime/JSActivation.cpp: (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::getOwnPropertyNames): (JSC::JSActivation::symbolTablePutWithAttributes):
2:59 PM Changeset in webkit [81993] by bfulgham@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

Unreviewed build correction.

Add stubs for WK2 cookie handling with cURL.

  • WebProcess/Cookies/curl: Added.
  • WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • win/WebKit2.vcproj:
2:57 PM Changeset in webkit [81992] by hyatt@apple.com
  • 112 edits
    8 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=56909

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::positionLineBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

LayoutTests: Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Reviewed by Dan Bernstein.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.

Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.

  • animations/dynamic-stylesheet-loading-expected.txt:
  • animations/keyframe-timing-functions-expected.txt:
  • fast/block/positioning/static-inline-position-dynamic.html: Added.
  • fast/block/positioning/trailing-space-test.html: Added.
  • fast/dynamic/ancestor-to-absolute-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/input-hit-test-border-expected.txt:
  • platform/mac/fast/block/positioning/002-expected.png:
  • platform/mac/fast/block/positioning/003-expected.png:
  • platform/mac/fast/block/positioning/004-expected.png:
  • platform/mac/fast/block/positioning/005-expected.png:
  • platform/mac/fast/block/positioning/006-expected.png:
  • platform/mac/fast/block/positioning/007-expected.png:
  • platform/mac/fast/block/positioning/008-expected.png:
  • platform/mac/fast/block/positioning/009-expected.png:
  • platform/mac/fast/block/positioning/010-expected.png:
  • platform/mac/fast/block/positioning/011-expected.png:
  • platform/mac/fast/block/positioning/012-expected.png:
  • platform/mac/fast/block/positioning/013-expected.png:
  • platform/mac/fast/block/positioning/014-expected.png:
  • platform/mac/fast/block/positioning/015-expected.png:
  • platform/mac/fast/block/positioning/016-expected.png:
  • platform/mac/fast/block/positioning/017-expected.png:
  • platform/mac/fast/block/positioning/018-expected.png:
  • platform/mac/fast/block/positioning/019-expected.png:
  • platform/mac/fast/block/positioning/020-expected.png:
  • platform/mac/fast/block/positioning/021-expected.png:
  • platform/mac/fast/block/positioning/022-expected.png:
  • platform/mac/fast/block/positioning/023-expected.png:
  • platform/mac/fast/block/positioning/024-expected.png:
  • platform/mac/fast/block/positioning/025-expected.png:
  • platform/mac/fast/block/positioning/026-expected.png:
  • platform/mac/fast/block/positioning/027-expected.png:
  • platform/mac/fast/block/positioning/028-expected.png:
  • platform/mac/fast/block/positioning/029-expected.png:
  • platform/mac/fast/block/positioning/030-expected.png:
  • platform/mac/fast/block/positioning/031-expected.png:
  • platform/mac/fast/block/positioning/032-expected.png:
  • platform/mac/fast/block/positioning/033-expected.png:
  • platform/mac/fast/block/positioning/034-expected.png:
  • platform/mac/fast/block/positioning/035-expected.png:
  • platform/mac/fast/block/positioning/036-expected.png:
  • platform/mac/fast/block/positioning/037-expected.png:
  • platform/mac/fast/block/positioning/038-expected.png:
  • platform/mac/fast/block/positioning/039-expected.png:
  • platform/mac/fast/block/positioning/040-expected.png:
  • platform/mac/fast/block/positioning/041-expected.png:
  • platform/mac/fast/block/positioning/042-expected.png:
  • platform/mac/fast/block/positioning/043-expected.png:
  • platform/mac/fast/block/positioning/044-expected.png:
  • platform/mac/fast/block/positioning/045-expected.png:
  • platform/mac/fast/block/positioning/046-expected.png:
  • platform/mac/fast/block/positioning/047-expected.checksum:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/block/positioning/048-expected.png:
  • platform/mac/fast/block/positioning/049-expected.png:
  • platform/mac/fast/block/positioning/050-expected.png:
  • platform/mac/fast/block/positioning/056-expected.txt:
  • platform/mac/fast/block/positioning/061-expected.png:
  • platform/mac/fast/block/positioning/062-expected.png:
  • platform/mac/fast/block/positioning/auto/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/block/positioning/move-with-auto-width-expected.png:
  • platform/mac/fast/block/positioning/negative-rel-position-expected.png:
  • platform/mac/fast/block/positioning/relative-overconstrained-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
  • platform/mac/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.checksum: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.png: Added.
  • platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Added.
  • platform/mac/fast/clip/001-expected.txt:
  • platform/mac/fast/clip/004-expected.txt:
  • platform/mac/fast/clip/006-expected.txt:
  • platform/mac/fast/clip/007-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/clip/009-expected.txt:
  • platform/mac/fast/clip/010-expected.txt:
  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
  • platform/mac/fast/clip/013-expected.txt:
  • platform/mac/fast/clip/014-expected.txt:
  • platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/invalid/014-expected.txt:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
2:21 PM Changeset in webkit [81991] by Stephanie Lewis
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ build until we can implement the new cross-platform
FontPlatformData.h bits.

Patch by Martin Robinson <​mrobinson@igalia.com> on 2011-03-25

  • platform/graphics/FontPlatformData.h: Include the proper old font headers.

(WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file
which reference our obsolete font implementation.
(WebCore::FontPlatformData::hash): Ditto.

2:13 PM Changeset in webkit [81990] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-25 Martin Robinson <​mrobinson@igalia.com>

Fix the GTK+ build until we can implement the new cross-platform
FontPlatformData.h bits.

  • platform/graphics/FontPlatformData.h: Include the proper old font headers. (WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file which reference our obsolete font implementation. (WebCore::FontPlatformData::hash): Ditto.
2:04 PM Changeset in webkit [81989] by sfalken@apple.com
  • 4 edits in trunk/Source

2011-03-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Brian Weinstein.

Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
​https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>


This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Blacklist npwpf.dll.

2011-03-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Brian Weinstein.

Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
​https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>

This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin): Blacklist npwpf.dll.
1:40 PM Changeset in webkit [81988] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-25 Tony Chang <​tony@chromium.org>

Try to fix the chromium mac build.
We used the mac FontPlatformData on chromium mac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/FontPlatformData.h:
1:34 PM Changeset in webkit [81987] by jam@chromium.org
  • 6 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-24 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add setters for various client interfaces, and add WebSpellCheckClient
​https://bugs.webkit.org/show_bug.cgi?id=57070

  • public/WebSpellCheckClient.h: Added. (WebKit::WebSpellCheckClient::spellCheck): (WebKit::WebSpellCheckClient::requestCheckingOfText): (WebKit::WebSpellCheckClient::autoCorrectWord): (WebKit::WebSpellCheckClient::showSpellingUI): (WebKit::WebSpellCheckClient::isShowingSpellingUI): (WebKit::WebSpellCheckClient::updateSpellingUIWithMisspelledWord): (WebKit::WebSpellCheckClient::~WebSpellCheckClient):
  • public/WebView.h:
  • public/WebViewClient.h:
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::requestCheckingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setWebDevToolsAgentClient): (WebKit::WebViewImpl::setWebAutoFillClient): (WebKit::WebViewImpl::setWebSpellCheckClient): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::spellCheckClient):
1:27 PM Changeset in webkit [81986] by ggaren@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash in debugger beneath MarkStack::drain @ me.com, ibm.com
​https://bugs.webkit.org/show_bug.cgi?id=57080
<rdar://problem/8525907>

  • inspector/debugger/debugger-activation-crash-expected.txt: Added.
  • inspector/debugger/debugger-activation-crash.html: Added.
1:08 PM Changeset in webkit [81985] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-25 Dimitri Glazkov <Dimitri Glazkov>

Skip the test added in r81970 on WebKit2, because its harness doesn't
yet support printing hooks.

  • platform/mac-wk2/Skipped: Added printing/page-count-layout-overflow.html.
1:03 PM Changeset in webkit [81984] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Kick the build machines after r81977.

  • win/tools/vsprops/common.vsprops:
12:44 PM Changeset in webkit [81983] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Crash in debugger beneath MarkStack::drain @ me.com, ibm.com
​https://bugs.webkit.org/show_bug.cgi?id=57080
<rdar://problem/8525907>

The crash was caused by changes in the executable after recompilation.

The fix is for the activation to copy the data it needs instead of
relying on the data in the executable.


SunSpider and v8 report no change.

  • runtime/Arguments.h: (JSC::JSActivation::copyRegisters): Use our own data members instead of reading data out of the executable.
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): Initialize our data members.

(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter): Use our own data members instead of
reading data out of the executable.

  • runtime/JSActivation.h: Added new data members to track data previously tracked by the executable. Since I've removed the executable pointer, on a 64bit system, I've only made activations bigger by an int.
12:41 PM Changeset in webkit [81982] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-25 Tony Chang <​tony@chromium.org>

Build fix:
have chromium and qt use the correct FontPlatformData.h
​https://bugs.webkit.org/show_bug.cgi?id=57115

  • platform/graphics/FontPlatformData.h:
12:29 PM Changeset in webkit [81981] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=57057 Overlay scrollbars in overflow
areas paint behind positive z-index content
-and corresponding-
<rdar://problem/9070500>

Reviewed by Dave Hyatt.

Since overlay scrollbars don't clip the scrollable content like other scrollbars do,
the only way to get them to paint on top of all possible scrollable content is to
make them paint on top of everything. To do this, this patch adds a second trip
through the layer tree if it contains overlay scrollbars that need painting.

After calling paint() on the rootLayer, call paintOverlayScrollers() if
containsDirtyOverlayScrollbars() is true.

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

RenderLayer has two new member variable. m_containsDirtyOverlayScrollbars is a bool
that is set on the root layer when it has child layers that need overlay scrollbars
to be painted. m_cachedOverlayScrollbarOffset is an IntPoint to cache the tx and ty
of the overlay scrollbars on the first (normal) pass through the layer tree. This
prevents us from having to re-enter the render tree during the second (overlay-only)
pass. Finally, there is also a new paint flag: PaintLayerPaintingOverlayScrollbars.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::containsDirtyOverlayScrollbars):
(WebCore::RenderLayer::setContainsDirtyOverlayScrollbars):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayer):

12:16 PM Changeset in webkit [81980] by jberlin@webkit.org
  • 21 edits
    11 adds in trunk

WebKit2: Need to be able to set and get the Cookie Storage Policy.
​https://bugs.webkit.org/show_bug.cgi?id=50780

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateCookieStorage):
Rename privateBrowsingCookieStorage to privateCookieStorage.
(WebCore::currentCookieStorage):
Ditto.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
(WebCore::defaultCookieStorage):
Return the default cookie storage.
(WebCore::privateBrowsingCookieStorage):
Return privateCookieStorage().get()

  • platform/network/cf/CookieStorageCFNet.h:

Source/WebKit2:

  • Shared/HTTPCookieAcceptPolicy.h: Added.
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toHTTPCookieAcceptPolicy):
(WebKit::toAPI):

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetHTTPCookieAcceptPolicy):
Call through to WebCookieManagerProxy.
(WKCookieManagerGetHTTPCookieAcceptPolicy):
Ditto.

  • UIProcess/API/C/WKCookieManager.h:
  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::invalidate):
Invalidate the get http cookie accept policy callbacks.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Send a message to the Web Process with the new value.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
Keep track of the callback and send a message to the Web Process.
(WebKit::WebCookieManagerProxy::didGetHTTPCookieAcceptPolicy):
Invoke the callback.

  • UIProcess/mac/WebCookieManagerProxyMac.mm: Added.

(WebKit::WebCookieManagerProxy::persistHTTPCookieAcceptPolicy):
On Mac, also set the policy in the UI Process because the sandboxed Web Process cannot
persist the policy.

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.messages.in:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
Call platformSetHTTPCookieAcceptPolicy.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Send the result of platformGetHTTPCookieAcceptPolicy to the UI Process.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:
  • WebProcess/Cookies/cf: Added.
  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on both the default cookie storage and any Private Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/mac: Added.
  • WebProcess/Cookies/mac/WebCookieManagerMac.mm: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on the default cookie storage and add a FIXME to set it on any Private
Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/gtk: Added.
  • WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/qt: Added.
  • WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

Tools:

Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.

The test is named "CookieManager" so that we can eventually exercise more of the
CookieManager functionality in the test.

  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.

(TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
Assert that the policy returned is equal to the policy set in
didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
(TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
Set the policy to something different than the user's policy and get the policy again.
(TestWebKitAPI::didFinishLoadForFrame):
Get the user's policy so that it can be restored at the end of the test.
(TestWebKitAPI::TEST):
Load about:blank so that the Web Process gets instatiated (needed to get the
CookieManager).

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add CookieManager.cpp.

12:12 PM Changeset in webkit [81979] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-25 Cary Clark <​caryclark@google.com>

Reviewed by Dimitri Glazkov.

Add CGBitmapContext.h include to WebViewImpl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=57097

No tests. Exposes no new functionality.

  • src/WebViewImpl.cpp:
12:08 PM Changeset in webkit [81978] by eae@chromium.org
  • 6 edits
    2 adds in trunk

2011-03-25 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

Text field "onchange" event is triggered if actual value unchanged
​https://bugs.webkit.org/show_bug.cgi?id=36314

Add tests for text field change events.

  • fast/events/onchange-text-form-field-expected.txt: Added.
  • fast/events/onchange-text-form-field.html: Added.

2011-03-25 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

Text field "onchange" event is triggered if actual value unchanged
​https://bugs.webkit.org/show_bug.cgi?id=36314

Change RenderTextControl::subtreeHasChanged to only return true if the
subtree has changed since the last event was triggered.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
  • html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::setTextAsOfLastFormControlChangeEvent):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setValue):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue):
11:59 AM Changeset in webkit [81977] by bfulgham@webkit.org
  • 7 edits
    2 adds
    3 deletes in trunk/Source/WebCore

Clean up FontPlatformData structure so that a single implementation
is used across all ports. This first patch works for the Windows
build (both CG and WinCairo), and Cocoa.

Reviewed by David Hyatt.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/FontPlatformData.cpp: Added.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):

  • platform/graphics/FontPlatformData.h: Added.

(WebCore::toCTFontRef):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::orientation):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::setOrientation):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):

  • platform/graphics/cg/FontPlatformData.h: Removed.
  • platform/graphics/cocoa/FontPlatformData.h: Removed.
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/cairo/FontPlatformData.h: Removed.
11:50 AM Changeset in webkit [81976] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Websockets tests sometimes time out on apple-windows-5
​https://bugs.webkit.org/show_bug.cgi?id=55579

Unreviewed, skipping all the websocket tests on Windows to get the bots green.

  • platform/win/Skipped:
11:48 AM Changeset in webkit [81975] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r79227): CFURLCache not initialized correctly in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=57109
<rdar://problem/9184590>

Reviewed by Alexey Proskuryakov.

Check for a trailing Windows path separator, not a Unix path separator.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

11:47 AM Changeset in webkit [81974] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Pasteboard data's RTF data doesn't always include URLs via NSLinkAttributeName.
​https://bugs.webkit.org/show_bug.cgi?id=57107
<rdar://problem/9084267>

Reviewed by Oliver Hunt.

If the selection is at the beginning of content inside an anchor tag
we move the selection start to include the anchor.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Modified to change the selection
start according to the new rule.

11:44 AM Changeset in webkit [81973] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore/platform/graphics/chromium

Merge 80767 - 2011-03-10 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Make tiled compositor data structure more efficient.
​https://bugs.webkit.org/show_bug.cgi?id=54133

Previously, the compositor had a sparse 2D array of tiles for the
whole page, most of which were null. The tiles were implicitly
located based on their position in the array. This was inefficient
when the page grew (e.g. infinite scrolling) and caused some bugs
(e.g. width * height > MAX_INT). This change modifies tiles to have
explicit positions so they can be stored in a hash map.

Tests: LayoutTests/compositing/

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::invalidateTiles): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileAt): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::growLayerToContain):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::i): (WebCore::LayerTilerChromium::Tile::j): (WebCore::LayerTilerChromium::Tile::moveTo): (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue): (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):

TBR=​enne@google.com

11:26 AM Changeset in webkit [81972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-25 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[chromium] Remove deprecated overload of openFileSystem for workers
​https://bugs.webkit.org/show_bug.cgi?id=57062

  • public/WebCommonWorkerClient.h:
10:55 AM Changeset in webkit [81971] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor Network domain's frame tree API
​https://bugs.webkit.org/show_bug.cgi?id=57103

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForFrameResource): (WebCore::buildObjectForCachedResource): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::buildObjectForFrame): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::enable):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._clearResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame): (WebInspector.ResourcesPanel.prototype.addResourceToFrame):
10:49 AM Changeset in webkit [81970] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

2011-03-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
​https://bugs.webkit.org/show_bug.cgi?id=56958

  • printing/page-count-layout-overflow-expected.txt: Added.
  • printing/page-count-layout-overflow.html: Added.

2011-03-25 Dave Hyatt <​hyatt@apple.com>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
​https://bugs.webkit.org/show_bug.cgi?id=56958

Test: printing/page-count-layout-overflow.html

  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow

to the right place.

10:32 AM Changeset in webkit [81969] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove duplicate entry from JavaScriptCore.exp

JSC::createStackOverflowError(JSC::ExecState*) was originally
exported in r60057, then duplicated in r60392.

10:25 AM Changeset in webkit [81968] by benjamin.poulain@nokia.com
  • 8 edits in trunk/Source/WebKit2

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::create):

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::initializeGTK):

  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:

(tst_QGraphicsWKView::loadEmptyPage):
(tst_QGraphicsWKView::loadEmptyUrl):

  • UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:

(tst_QWKPage::loadEmptyUrl):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
(WebKit::WebProcessMainQt):

10:21 AM Changeset in webkit [81967] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source/WebCore

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
​https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Andreas Kling.

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
(JSC::Bindings::QtPixmapInstance::valueOf):

  • platform/qt/LanguageQt.cpp:

(WebCore::platformDefaultLanguage):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection):

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::initializeGtk):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::getPluginDisplay):

9:28 AM Changeset in webkit [81966] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Correct project file missing $(WebKitVSPropsRedirectionDir)s
after r81924.

  • win/WebKit2.vcproj: Restore lost $(WebKitVSPropsRedirectionDir)
9:21 AM Changeset in webkit [81965] by commit-queue@webkit.org
  • 52 edits in trunk/Source

2011-03-25 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
​https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

Code refactoring. No new tests.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • dom/Document.cpp: (WebCore::acceptsEditingFocus):
  • dom/Node.cpp: (WebCore::Node::rendererIsEditable): (WebCore::Node::shouldUseInputMethod): (WebCore::Node::canStartSelection): (WebCore::Node::rootEditableElement):
  • dom/Node.h: (WebCore::Node::isContentEditable): (WebCore::Node::rendererIsEditable): (WebCore::Node::rendererIsRichlyEditable):
  • dom/Position.cpp: (WebCore::nextRenderedEditable): (WebCore::previousRenderedEditable): (WebCore::Position::atEditingBoundary): (WebCore::Position::parentEditingBoundary): (WebCore::Position::upstream): (WebCore::Position::downstream): (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): (WebCore::AppendNodeCommand::doApply): (WebCore::AppendNodeCommand::doUnapply):
  • editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement):
  • editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
  • editing/FormatBlockCommand.cpp: (WebCore::enclosingBlockToSplitTreeTo):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply): (WebCore::MergeIdenticalElementsCommand::doUnapply):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectionFromNone):
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply): (WebCore::SplitElementCommand::doUnapply):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doUnapply): (WebCore::SplitTextNodeCommand::doReapply):
  • editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doUnapply): (WebCore::WrapContentsInDummySpanCommand::doReapply):
  • editing/htmlediting.cpp: (WebCore::highestEditableRoot): (WebCore::lowestEditableAncestor): (WebCore::isEditablePosition): (WebCore::isRichlyEditablePosition): (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::extendRangeToWrappingNodes): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::highestEnclosingNodeOfType): (WebCore::canMergeLists):
  • editing/visible_units.cpp: (WebCore::previousLeafWithSameEditability): (WebCore::previousLinePosition): (WebCore::nextLeafWithSameEditability): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::canStartSelection): (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable):
  • html/HTMLElement.h:
  • page/DragController.cpp: (WebCore::DragController::operationForLoad): (WebCore::DragController::canProcessDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::selectCursor):
  • page/FocusController.cpp: (WebCore::relinquishesEditingFocus):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
  • rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): (WebCore::RenderBlock::hasLineIfEmpty):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::addOverflowFromInlineChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  • rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus):

2011-03-25 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
​https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

  • src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition):

2011-03-25 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
​https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-03-25 Chang Shu <​cshu@webkit.org>

Reviewed by Ryosuke Niwa.

rename Node::isContentEditable and all call sites to rendererIsEditable
​https://bugs.webkit.org/show_bug.cgi?id=54290

This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
9:11 AM Changeset in webkit [81964] by mjs@apple.com
  • 3 edits
    2 adds in trunk

2011-03-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Antti Koivisto.

Crash when a wbr element is inserted inside mroot
​https://bugs.webkit.org/show_bug.cgi?id=56352

  • mathml/wbr-in-mroot-crash-expected.txt: Added.
  • mathml/wbr-in-mroot-crash.html: Added.

2011-03-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Antti Koivisto.

Crash when a wbr element is inserted inside mroot
​https://bugs.webkit.org/show_bug.cgi?id=56352

Test: mathml/wbr-in-mroot-crash.html

  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first child, instead of just assuming.
8:28 AM Changeset in webkit [81963] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe
​https://bugs.webkit.org/show_bug.cgi?id=56098

Patch by Jarred Nicholls <​jarred@sencha.com> on 2011-03-25
Reviewed by Ariya Hidayat.

Need to link advapi32.lib for jsc.exe since wtf/OSRandomSource.cpp uses the Win32 Crypto API

  • jsc.pro:
8:10 AM Changeset in webkit [81962] by commit-queue@webkit.org
  • 16 edits
    5 adds in trunk

2011-03-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: extensions can't render original XML
​https://bugs.webkit.org/show_bug.cgi?id=56263

Added source xml to transformed document, renamed onload function.

  • fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt:
  • fast/encoding/dumpAsText/utf-16-no-bom-expected.txt:
  • http/tests/xmlviewer/dumpAsText/wml-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
  • http/tests/xmlviewer/dumpAsText/xul-expected.txt:
  • platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt:
  • platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
  • svg/hixie/error/dumpAsText/004-expected.txt:
  • svg/hixie/error/dumpAsText/005-expected.txt:
  • xmlviewer/extensions-api-expected.txt: Added.
  • xmlviewer/extensions-api.html_disabled: Added.
  • xmlviewer/resources/sample.xml: Added.

2011-03-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML Viewer: extensions can't render original XML
​https://bugs.webkit.org/show_bug.cgi?id=56263

Added source xml to transformed document, renamed onload function.

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.xsl:
8:02 AM Changeset in webkit [81961] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-25 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Get rid of the invalid string conversion with ::fromAscii()
​https://bugs.webkit.org/show_bug.cgi?id=57102

Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/qt/CookieJarQt.cpp: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue):
7:17 AM Changeset in webkit [81960] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/PerformanceTests

2011-03-25 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG <use> element performance improvement
​https://bugs.webkit.org/show_bug.cgi?id=57077

Add a manual test case which is from
​http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg
for svg <use> element performance test.

  • PageLoad/svg/files/Sierpinski_carpet_6.svg: Added.
  • PageLoad/svg/svg.pltsuite:
7:15 AM Changeset in webkit [81959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-25 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] The keyboard shortcuts during fullscreen playback do not work.
​https://bugs.webkit.org/show_bug.cgi?id=57095

We need to explicitely set the focus on the widget in order to receive the keyboard events.

  • WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::show):
6:58 AM Changeset in webkit [81958] by Adam Roben
  • 1 edit
    3 deletes in trunk/LayoutTests

Remove no-longer-necessary Windows results

r81925 made Windows match Mac on this test. New Windows results were checked in, but they
were generated using the wrong fonts. Since we match Mac now, we don't need Windows-specific
results at all.

  • platform/win/fast/css/percentage-non-integer-expected.checksum: Removed.
  • platform/win/fast/css/percentage-non-integer-expected.png: Removed.
  • platform/win/fast/css/percentage-non-integer-expected.txt: Removed.
6:39 AM Changeset in webkit [81957] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

2011-03-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81953.
​http://trac.webkit.org/changeset/81953
​https://bugs.webkit.org/show_bug.cgi?id=57096

"inspector test breakage: part 2/2" (Requested by apavlov on
#webkit).

  • inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
  • inspector/styles/get-set-stylesheet-text.html: Removed.
  • inspector/styles/styles-new-API.html:

2011-03-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81953.
​http://trac.webkit.org/changeset/81953
​https://bugs.webkit.org/show_bug.cgi?id=57096

"inspector test breakage: part 2/2" (Requested by apavlov on
#webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):
5:48 AM Changeset in webkit [81956] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-03-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81954.
​http://trac.webkit.org/changeset/81954
​https://bugs.webkit.org/show_bug.cgi?id=57094

"inspector test breakage: part 1/2" (Requested by apavlov on
#webkit).

  • inspector/styles/resources/get-set-stylesheet-text.css: Removed.
5:00 AM Changeset in webkit [81955] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-25 Mikhail Naganov <​mnaganov@chromium.org>

Roll forward Chromium deps to r79379 to pick up V8 3.2.4.2.

  • DEPS:
4:59 AM Changeset in webkit [81954] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-25 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix. Add file missing from r81953

  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
4:11 AM Changeset in webkit [81953] by apavlov@chromium.org
  • 10 edits
    2 adds in trunk

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
​https://bugs.webkit.org/show_bug.cgi?id=56310

  • inspector/styles/get-set-stylesheet-text-expected.txt: Added.
  • inspector/styles/get-set-stylesheet-text.html: Added.
  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles/styles-new-API.html:

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
​https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):
3:33 AM Changeset in webkit [81952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-25 Priit Laes <​plaes@plaes.org>

Reviewed by Martin Robinson.

[GTK] [PATCH] Avoid critical warning when free-ing list of plugins
​https://bugs.webkit.org/show_bug.cgi?id=57025

  • webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_plugins_list_free): Use regular check and return instead of g_return_if_fail.
3:05 AM Changeset in webkit [81951] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extension server should not convert all resources to HAR when there are no extensions.
​https://bugs.webkit.org/show_bug.cgi?id=57044

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype._hasSubscribers):
2:19 AM Changeset in webkit [81950] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-25 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

SVG <use> element performance improvement
​https://bugs.webkit.org/show_bug.cgi?id=57077

SVG <use> element was expanding nesting <use> and <symbol> elements
in an inefficient way. After it expanded an <use> or a <symbol>
element it would restart expanding from the shadow tree root.
This behavior was leading about 160 millions of calls to
expandUseElementInShadowTree or expandSymbolElementInShadowTree for
a single shadow tree which is illustrated by
​http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg.
But the effective calls, which really expand <use> or <symbol>
elements, were about 5200; others were passing-by calls, which are
recursively down to the children.

This patch is altering the expanding path to reduce the passing-by
calls. It will expand elements in sibling chain where there is an
effective call, because the effective call replaces element which is
expanded and the replacement results lose of the sibling chain of
the replaced on the upper recursion stack. With this patch the
passing-by calls are reduced from about 160 millions to about 30
thousands.

No functionality change, no new tests.

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree): (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
  • svg/SVGUseElement.h:
2:19 AM Changeset in webkit [81949] by sergio@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-25 Sergio Villar Senin <​svillar@igalia.com>

Rebaseline GTK+ tests results after r81887

  • platform/gtk/editing/pasteboard/5065605-expected.txt:
  • platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-011-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
1:29 AM Changeset in webkit [81948] by alex
  • 2 edits in trunk/Source/WebKit2

2011-03-25 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[WK2] Consider .c files in the generate-forwarding-headers script
​https://bugs.webkit.org/show_bug.cgi?id=56680

  • Scripts/generate-forwarding-headers.pl:
1:18 AM Changeset in webkit [81947] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-25 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

Adds a regression test for keygen autofocus.
​https://bugs.webkit.org/show_bug.cgi?id=57091

  • fast/forms/autofocus-keygen-expected.txt: Added.
  • fast/forms/autofocus-keygen.html: Added.

2011-03-25 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

Makes keygen support autofocus attribute.
​https://bugs.webkit.org/show_bug.cgi?id=57091

Test: fast/forms/autofocus-keygen.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::attach):
12:29 AM Changeset in webkit [81946] by mnaganov@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-24 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add tests for HeapSnapshot module.
​https://bugs.webkit.org/show_bug.cgi?id=56835

  • http/tests/inspector/heap-snapshot-test.js: Added. (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject): (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock): (initialize_HeapSnapshotTest):
  • inspector/profiler/heap-snapshot-expected.txt: Added.
  • inspector/profiler/heap-snapshot.html: Added.
12:17 AM Changeset in webkit [81945] by mnaganov@chromium.org
  • 1 edit
    4 adds
    2 deletes in trunk/LayoutTests

2011-03-24 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of testing framework.
​https://bugs.webkit.org/show_bug.cgi?id=57006

  • http/tests/inspector/profiler-test.js: Added. (initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest): (initialize_ProfilerTest.InspectorTest.startProfilerTest): (initialize_ProfilerTest.InspectorTest.completeProfilerTest): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite.runner): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite): (initialize_ProfilerTest):
  • inspector/cpu-profiler-profiling-expected.txt: Removed.
  • inspector/cpu-profiler-profiling.html: Removed.
  • inspector/profiler/cpu-profiler-profiling-expected.txt: Added.
  • inspector/profiler/cpu-profiler-profiling.html: Added.
Note: See TracTimeline for information about the timeline view.