⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 15, 2011:

10:18 PM Changeset in webkit [93086] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

[CMAKE] Wrap files of websocket and worker in each macro.
​https://bugs.webkit.org/show_bug.cgi?id=65012

Move files of web socket and workers into each macro block in CMakeList.txt.
And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.

Reviewed by Daniel Bates.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/js/WorkerScriptController.cpp:
7:35 PM Changeset in webkit [93085] by mrowe@apple.com
  • 17 edits in tags/Safari-535.1.1

Merge r93005.

7:35 PM Changeset in webkit [93084] by mrowe@apple.com
  • 2 edits in tags/Safari-535.1.1/Source/JavaScriptCore

Merge r93000.

7:35 PM Changeset in webkit [93083] by mrowe@apple.com
  • 5 edits in tags/Safari-535.1.1/Source

Versioning.

7:23 PM Changeset in webkit [93082] by mrowe@apple.com
  • 1 copy in tags/Safari-535.1.1

New tag.

6:37 PM Changeset in webkit [93081] by barraclough@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

  • fast/js/kde/operators-expected.txt:
    • erk! missed new expected results from last commit!
6:10 PM Changeset in webkit [93080] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

New XML parser: add xml namespace to the default map of namespaces
​https://bugs.webkit.org/show_bug.cgi?id=66266

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):

6:05 PM Changeset in webkit [93079] by hayato@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash when mouse moves from <summary> element to parent <details> element.
​https://bugs.webkit.org/show_bug.cgi?id=66210

Reviewed by Dimitri Glazkov.

This is a regression caused by r92922, which wrongly assumes that
a shadow host always has a shadow root as an immediate child in
ancestors chain. This assumption does not apply to <details>
element. <details> element is implemented as a shadow host, but
may have a <summary> element as an immediate child element in
ancestors chain.

Source/WebCore:

Test: fast/dom/shadow/details-summary-mouseover.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Added.
  • fast/dom/shadow/details-summary-mouseover.html: Added.
5:56 PM Changeset in webkit [93078] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

A mousedown event is not dispatched when clicking on a disabled INPUT
​https://bugs.webkit.org/show_bug.cgi?id=27795

Reviewed by Alexey Proskuryakov.

Add a regression test now that the bug no longer reproduces.

  • fast/forms/disabled-mousedown-event-expected.txt: Added.
  • fast/forms/disabled-mousedown-event.html: Added.
5:46 PM Changeset in webkit [93077] by jamesr@google.com
  • 12 edits in branches/chromium/835/Source

Merge 92908 - Readback composited webgl results for printing
​https://bugs.webkit.org/show_bug.cgi?id=65658
BUG=55927

Patch by John Bauman <​jbauman@chromium.org> on 2011-08-11
Reviewed by James Robinson.

Source/WebCore:

The real composited results may be locked inside the compositor
context's version of a texture because the drawing buffer was
automatically cleared, so read from there to get the actual presented
version to draw.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Add support for reading from the composited version of a canvas.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::paintFramebufferToCanvas):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DInternal::reshape):

  • src/GraphicsContext3DInternal.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7664004

5:32 PM Changeset in webkit [93076] by dimich@chromium.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Add WebFrameClient::didAdoptURLLoader() notification
​https://bugs.webkit.org/show_bug.cgi?id=66167

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didAdoptURLLoader):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::~ResourceHandle):

  • src/ResourceHandleInternal.h: Added.

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):

5:32 PM Changeset in webkit [93075] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that this new test fails.

  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [93074] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Remove expectation for this test, which no longer exists.

  • platform/chromium/test_expectations.txt:
5:24 PM Changeset in webkit [93073] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add new passing expectations.

  • platform/chromium/fast/js/kde/operators-expected.txt: Added.
5:17 PM Changeset in webkit [93072] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
​https://bugs.webkit.org/show_bug.cgi?id=66264

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

4:51 PM Changeset in webkit [93071] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

Switch Element/Node to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66260

Reviewed by Eric Seidel.

Convert Element, Node, ElementRareData and ContainerNode to new layout
abstraction as a part of the ongoing conversion work.

No new tests, no new functionality.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::getRect):

  • dom/ContainerNode.h:
  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::adjustForLocalZoom):
(WebCore::Element::boundsInWindowSpace):
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::screenRect):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):

  • dom/Element.h:
  • dom/ElementRareData.h:
  • dom/Node.cpp:

(WebCore::Node::getRect):
(WebCore::Node::renderRect):
(WebCore::Node::hasNonEmptyBoundingBox):

  • dom/Node.h:
4:44 PM Changeset in webkit [93070] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Change bool return values to a 64-bit type.

LayoutTests:

  • fast/js/kde/script-tests/operators.js:

(nonSpeculativeNotInner):
(nonSpeculativeNot):
(nonSpeculativeLessInner):
(nonSpeculativeLess):
(nonSpeculativeLessEqInner):
(nonSpeculativeLessEq):
(nonSpeculativeGreaterInner):
(nonSpeculativeGreater):
(nonSpeculativeGreaterEqInner):
(nonSpeculativeGreaterEq):
(nonSpeculativeEqualInner):
(nonSpeculativeEqual):
(nonSpeculativeNotEqualInner):
(nonSpeculativeNotEqual):
(nonSpeculativeStrictEqualInner):
(nonSpeculativeStrictEqual):
(nonSpeculativeStrictNotEqualInner):
(nonSpeculativeStrictNotEqual):

  • Add tests cases that will hit the non-spec path.
4:36 PM Changeset in webkit [93069] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Committed by accident, restoring the test.

  • editing/deleting/delete-3928305-fix.html:
4:34 PM Changeset in webkit [93068] by ap@apple.com
  • 4 edits
    2 adds in trunk

Regional indicator symbols that are combined should behave as a single character when editing
​https://bugs.webkit.org/show_bug.cgi?id=65395

Reviewed by Dan Bernstein.

Part one: make backspace work.

Test: editing/deleting/regional-indicators.html

  • rendering/RenderText.cpp: (WebCore::isRegionalIndicator): (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional indicator symbols.
4:18 PM Changeset in webkit [93067] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

New XML parser: Re-entering a character node should not clobber the buffered characters
​https://bugs.webkit.org/show_bug.cgi?id=66257

Reviewed by Adam Barth.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::enterText):

3:49 PM Changeset in webkit [93066] by dimich@chromium.org
  • 40 edits in trunk/Source

FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
​https://bugs.webkit.org/show_bug.cgi?id=66165

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no change in behavior.
The original issue is only reproducible on Chromium in multi-process mode
and is tested there by a browsertest.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::transferLoadingResourcesFromPage):
Passing ResourceLoader* into the FrameLoaderClient notification.
Also, fixed the bug where the same ResourceRequest was passed for all subresources.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
returns the request as it existed before redirects (but after client's will SendRequest).
This is to be able to pass the original request for loading subresources into
FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
assignIdentifierToInitialRequest, which needs original request.

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:43 PM Changeset in webkit [93065] by abarth@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r93060.
​http://trac.webkit.org/changeset/93060
​https://bugs.webkit.org/show_bug.cgi?id=66259

Does not compile on Chromium Windows (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-15

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::clear):

  • src/WebFontCache.cpp:
3:18 PM Changeset in webkit [93064] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Touch a file to trigger a Windows build

I'm trying to ferret out some issues with our Debug builder.

  • WebView.cpp: Sorted #includes.
3:14 PM Changeset in webkit [93063] by Dimitri Glazkov
  • 3 edits in trunk/Tools

garden-o-matic frontend needs model.commitDataForRevisionRange function.
​https://bugs.webkit.org/show_bug.cgi?id=66252

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2:56 PM Changeset in webkit [93062] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed build fix after r93058.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):

  • UIProcess/TiledDrawingAreaProxy.h:
2:31 PM Changeset in webkit [93061] by Dimitri Glazkov
  • 3 edits in trunk/Tools

garden-o-matic frontend needs a generic way to track updates.
​https://bugs.webkit.org/show_bug.cgi?id=66245

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2:28 PM Changeset in webkit [93060] by mnaganov@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
​https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Darin Fisher.

  • public/WebCache.h:
  • public/WebFontCache.h:
  • src/WebCache.cpp:

(WebKit::WebCache::prune):

  • src/WebFontCache.cpp:

(WebKit::WebFontCache::prune):

2:12 PM Changeset in webkit [93059] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Refactor JS objects to allocate in static create methods rather than constructors
​https://bugs.webkit.org/show_bug.cgi?id=65347

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-15
Reviewed by Geoffrey Garen.

Source/JavaScriptGlue:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

  • JSRun.h:

(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • bindings/js/JSDOMBinding.h:
  • bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):

  • bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.cpp:

Source/WebKit/mac:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

2:06 PM Changeset in webkit [93058] by Adam Roben
  • 22 edits in trunk/Source

Update pages' style and content scale when the window's backing scale factor changes

Unfortunately, I couldn't think of a way to test this in an automated fashion.

Fixes <​http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
scale factor changes

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
  • page/Frame.cpp:

(WebCore::Frame::deviceScaleFactorChanged):

  • page/Frame.h:

Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
queries will be reevaluated, and we tell compositing layers about the new scale factor so
they can rerender at the new resolution.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
factor so that, e.g., scale-factor-dependent media queries will be reevaluated.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WKView _windowDidChangeResolution:]): Tell the WebPageProxy about the change.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:

Added deviceScaleFactorDidChange.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::deviceScaleFactorDidChange): Request a new backing store
since the current one is using an old device scale factor.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Send the device scale factor
along to the web process so it can render accordingly. This is how we tell the web process
about device scale factor changes.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange): Tell the DrawingAreaProxy when the device scale
factor changes.
(WebKit::WebPageProxy::deviceScaleFactor): Added this simple getter that calls through to
the PageClient. DrawingAreaProxy uses this function.

  • UIProcess/WebPageProxy.h: Added new members.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Send the device scale factor in the UpdateBackingStoreState message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState): Tell the WebPage and LayerTreeHost about
the new device scale factor.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

Added deviceScaleFactorDidChange.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor): Store the new scale factor and tell the page about
it so that, e.g., scale-factor-dependent media queries will be reevaluated.

  • WebProcess/WebPage/WebPage.h: Added setDeviceScaleFactor.
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::deviceScaleFactorDidChange): Tell the layer for non-composited
content about the new scale factor.

12:59 PM Changeset in webkit [93057] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Revise Skia on Chrome Mac to return fallback fonts.
​https://bugs.webkit.org/show_bug.cgi?id=62986

Reviewed by Darin Fisher.

Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.

This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::canReturnFallbackFontsForComplexText):

12:59 PM Changeset in webkit [93056] by thakis@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Implement shouldRubberBandInDirection
​https://bugs.webkit.org/show_bug.cgi?id=66206

Reviewed by Adam Barth.

History swiping can only start after an unhandled mouse wheel event
came back from the renderer, because mouse wheel javascript handlers
take precedence over history swiping. This means that rubberbanding
must not consume wheel events if they could trigger history, else
history swiping won't be triggered for pages without wheel handlers
either.

This is based on the implementation in
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection):

  • src/ChromeClientImpl.h:
12:52 PM Changeset in webkit [93055] by aa@chromium.org
  • 14 edits in trunk/Source

Pass additional details to client in didCreateIsolatedContext
​https://bugs.webkit.org/show_bug.cgi?id=66037

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/IsolatedWorld.cpp:

(WebCore::IsolatedWorld::IsolatedWorld):

  • bindings/v8/IsolatedWorld.h:

(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::id):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

  • src/FrameLoaderClientImpl.h:
12:37 PM Changeset in webkit [93054] by crogers@google.com
  • 10 edits
    5 adds in trunk

Add shell implementation for Web Audio API's MediaElementAudioSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=66175

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.idl:
  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaElementSource):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/MediaElementAudioSourceNode.cpp: Added.

(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::reset):

  • webaudio/MediaElementAudioSourceNode.h: Added.

(WebCore::MediaElementAudioSourceNode::mediaElement):

  • webaudio/MediaElementAudioSourceNode.idl: Added.

LayoutTests:

  • webaudio/mediaelementaudiosourcenode-expected.txt: Added.
  • webaudio/mediaelementaudiosourcenode.html: Added.
12:31 PM Changeset in webkit [93053] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Switch mouse events to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66179

Reviewed by Eric Seidel.

Convert mouse events to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

  • dom/MouseRelatedEvent.cpp:

(WebCore::contentsScrollOffset):
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::pageLocation):

  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::screenLocation):
(WebCore::MouseRelatedEvent::clientLocation):
(WebCore::MouseRelatedEvent::absoluteLocation):
(WebCore::MouseRelatedEvent::setAbsoluteLocation):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::selectionExtentRespectingEditingBoundary):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:
  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):

12:30 PM Changeset in webkit [93052] by Adam Roben
  • 7 edits in trunk/Tools

Teach TestWebKitAPI/gtest how to print JavaScript failures nicely

Failures now give output of the form: foo should be bar but is baz

Fixes <​http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
test is in TestWebKitAPI's output

Reviewed by David Levin.

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
members.
(TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
object, rather than doing any testing of it here.
(TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
to use a pretty error message when the test fails.

  • TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice

gtest-style macros that wrap it.

  • TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
the test passes, though. Returning early seems to have been an unnecessary optimization.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST): Changed to use the new macros.

12:23 PM Changeset in webkit [93051] by rniwa@webkit.org
  • 18 edits in trunk

webkit-indent-blockquote is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=66195

Reviewed by Tony Chang.

Source/WebCore:

Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
since no other class inherited from ApplyBlockElementCommand uses this feature.

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
(WebCore::ApplyBlockElementCommand::createBlockElement):

  • editing/ApplyBlockElementCommand.h:
  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::IndentOutdentCommand):

LayoutTests:

Rebaselined the tests since WebKit longer adds class="webkit-indent-blockquote" on blockquotes
created by execCommand('Indent') and execCommand('Outdent') after this patch.

  • editing/execCommand/19653-1-expected.txt:
  • editing/execCommand/5658933-2-expected.txt:
  • editing/execCommand/5658933-3-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • editing/execCommand/indent-nested-blockquotes-expected.txt:
  • editing/execCommand/indent-nested-div-expected.txt:
  • editing/execCommand/indent-paragraphs-expected.txt:
  • editing/execCommand/indent-pre-expected.txt:
  • editing/execCommand/indent-pre-list-expected.txt:
  • editing/execCommand/indent-pre-paragraphs-expected.txt:
  • editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
  • editing/execCommand/indent-with-style-expected.txt:
  • editing/execCommand/indent-with-style2-expected.txt:
12:07 PM Changeset in webkit [93050] by leviw@chromium.org
  • 20 edits in trunk/Source/WebCore

Switch remaining SVG Rendering methods to LayoutUnits
​https://bugs.webkit.org/show_bug.cgi?id=66169

Reviewed by Eric Seidel.

Changing remaining integer SVG methods to use the LayoutUnits abstraction.

No tests as no change in functionality.

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::visualOverflowRect):

  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::linesBoundingBox):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::parentOriginToBorderBox):
(WebCore::RenderSVGRoot::borderOriginToContentBox):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):

  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):

  • rendering/svg/SVGRootInlineBox.h:
12:07 PM Changeset in webkit [93049] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
​https://bugs.webkit.org/show_bug.cgi?id=66222

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-08-15
Reviewed by Kenneth Rohde Christiansen.

The function QTouchWebPagePrivate::getPageViewPrivate() exposed
the private QTouchWebPage to any object in WebKit.

Instead, use the friend keyword to list which objects can access
the internal of QTouchWebPage.

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::viewportRectUpdated):

11:51 AM Changeset in webkit [93048] by barraclough@apple.com
  • 5 edits in trunk

Crash accessing static property on sealed object
​https://bugs.webkit.org/show_bug.cgi?id=66242

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

  • should only check isExtensible if checkReadOnly.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • added test case.
10:41 AM Changeset in webkit [93047] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
​https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

10:21 AM Changeset in webkit [93046] by eric@webkit.org
  • 2 edits in trunk/Tools

Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.

Unreviewed.

  • Scripts/run-webkit-tests:

(usingLeaks):
(useNewRunWebKitTests):

9:56 AM Changeset in webkit [93045] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix release build when building with Clang.

Reviewed by Anders Carlsson.

  • runtime/Identifier.cpp:

(JSC::Identifier::checkCurrentIdentifierTable):
Add NO_RETURN_DUE_TO_CRASH.

8:54 AM Changeset in webkit [93044] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed.
Fix Qt-WK2 build after r93040.

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::deviceScaleFactor):

8:01 AM Changeset in webkit [93043] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Rename an instance of pageScaleFactorChanged I missed in r93040

I tried to make a test for this but failed. It would probably have been easier if we dumped
layers' content scales in layerTreeAsText output.

Followup to <​http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
the device scale factor

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

Renamed from pageScaleFactorChanged to match the base class.

7:32 AM Changeset in webkit [93042] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [V8] crash upon stepIn while not on pause.
​https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

7:26 AM Changeset in webkit [93041] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Network panel: display the current search match index in the toolbar.
​https://bugs.webkit.org/show_bug.cgi?id=66051

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
(WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):

6:43 AM Changeset in webkit [93040] by Adam Roben
  • 90 edits in trunk/Source

Clear up scale factor terminology

WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.

Fixes <​http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

Removed an unused member. This is unrelated to this patch.

  • css/MediaQueryEvaluator.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
AppKit scale factor terminology. (This is unrelated to the rest of the patch.)

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Shared/UpdateInfo.cpp:
  • Shared/UpdateInfo.h:
  • Shared/WebPageCreationParameters.cpp:
  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/BackingStore.cpp:
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
  • UIProcess/gtk/WebPopupMenuProxyGtk.h:
  • UIProcess/mac/BackingStoreMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/qt/WebPopupMenuProxyQt.h:
  • UIProcess/win/WebPopupMenuProxyWin.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
4:59 AM Changeset in webkit [93039] by reni@webkit.org
  • 4 edits in trunk/Source

Patch by Oliver Varga <​Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
​https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

4:02 AM Changeset in webkit [93038] by hayato@chromium.org
  • 9 edits in trunk

Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=64249

Reviewed by Dimitri Glazkov.

Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
that we can shrink ancestors of event target node considering shadow
DOM boundaries before dispatching focusin/focusout events.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):

  • dom/Node.h:
  • dom/UIEvent.cpp:

(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/UIEvent.h:

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
3:26 AM Changeset in webkit [93037] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

Web Inspector: not all of the properties have valid descriptors on all platforms.
Includes PropertyDescriptor protocol documentation fixes.
​https://bugs.webkit.org/show_bug.cgi?id=66215

Source/WebCore:

Activations, LocalStorage and some other properties potentially don't have
valid property descriptors. InjectedScript should use conservative getter in order to
mitigate this.

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:

LayoutTests:

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/runtime/runtime-localStorage-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-localStorage-getProperties.html: Added.
3:00 AM Changeset in webkit [93036] by vsevik@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/ResourcesPanel.js

Merge 92835 - Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
​https://bugs.webkit.org/show_bug.cgi?id=66007

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.FrameTreeElement.prototype.resourceByURL):

TBR=​vsevik@chromium.org
BUG=92405
Review URL: ​http://codereview.chromium.org/7648029

2:26 AM Changeset in webkit [93035] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: context menu on the link in the console does not have standard link options.
​https://bugs.webkit.org/show_bug.cgi?id=66214

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):

  • inspector/front-end/inspector.js:

(WebInspector.openLinkExternallyLabel):
(WebInspector.copyLinkAddressLabel):
(WebInspector.populateHrefContextMenu):

1:13 AM Changeset in webkit [93034] by pfeldman@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: showContextMenu missing in Remote DevTools
​https://bugs.webkit.org/show_bug.cgi?id=63725

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/SoftContextMenu.js: Added.

(.WebInspector.SoftContextMenu):
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._highlightPrevious):
(.WebInspector.SoftContextMenu.prototype._highlightNext):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.InspectorFrontendHost.showContextMenu):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu-item):
(.soft-context-menu-separator):
(.soft-context-menu-item-mouse-over):

  • inspector/front-end/inspector.html:

Aug 14, 2011:

11:57 PM Changeset in webkit [93033] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[QT]REGRESSION after r93011
​https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
4:08 PM Changeset in webkit [93032] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
​https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

RefPtr a few ContainerNodes to prevent premature deletion.

Test: fast/html/process-end-tag-for-inbody-crash.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody.
​https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

  • fast/html/process-end-tag-for-inbody-crash-expected.txt: Added.
  • fast/html/process-end-tag-for-inbody-crash.html: Added.
10:54 AM Changeset in webkit [93031] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.15

New tag.

5:21 AM Changeset in webkit [93030] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix GTK Windows build after r92308.
​https://bugs.webkit.org/show_bug.cgi?id=66140

Patch by Kalev Lember <​kalevlember@gmail.com> on 2011-08-14
Reviewed by Xan Lopez.

  • config.h: Don't try to include WebCoreHeaderDetection.h for GTK.
12:02 AM Changeset in webkit [93029] by abarth@webkit.org
  • 7 edits
    2 adds in trunk/Tools

Switch results detail view over to new-style object-oriented UI widgets
​https://bugs.webkit.org/show_bug.cgi?id=66200

Reviewed by Dimitri Glazkov.

This patch replaces my goofy template-based UI for the results
comparison screen with new object-oriented UI widgets.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

Aug 13, 2011:

11:55 PM Changeset in webkit [93028] by mitz@apple.com
  • 30 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of some PNG files to image/png

1:38 PM Changeset in webkit [93027] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit

Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.

Reviewed by Joseph Pecoraro.

../WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:

../WebKit/win:

  • WebPreferenceKeysPrivate.h:
12:27 PM Changeset in webkit [93026] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.

  • bindings/objc/WebScriptObject.mm:
12:25 PM Changeset in webkit [93025] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined dealloc]):

12:12 PM Changeset in webkit [93024] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove unused variables from WebView/WebFullScreenController.h
​https://bugs.webkit.org/show_bug.cgi?id=66194

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.h:

Remove a few variables which were not used.

12:03 PM Changeset in webkit [93023] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unused variables from WKFullScreenWindowController.h
​https://bugs.webkit.org/show_bug.cgi?id=66193

Reviewed by Dan Bernstein.

  • UIProcess/mac/WKFullScreenWindowController.h:

Remove _layerViewPlaceholder, _isWindowLoaded and _initialFrame which were not used.

11:57 AM Changeset in webkit [93022] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused variables from WebVideoFullscreenController.h
​https://bugs.webkit.org/show_bug.cgi?id=66192

Reviewed by Dan Bernstein.

  • platform/mac/WebVideoFullscreenController.h:

Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.

11:51 AM Changeset in webkit [93021] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Fix incorrect objective-c initialize in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=66191

Reviewed by David Kilzer.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):

  • rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.

11:31 AM Changeset in webkit [93020] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix clang build.

  • platform/chromium/PopupMenuChromium.h:
11:06 AM Changeset in webkit [93019] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate entries

by using uniq. Originally noticed by Xcode 4.

10:54 AM Changeset in webkit [93018] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add back 0xbbadbeef to CRASH to allow for old habits
​https://bugs.webkit.org/show_bug.cgi?id=66190

Reviewed by David Kilzer.

  • wtf/Assertions.h:

Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.

10:48 AM Changeset in webkit [93017] by weinig@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=66182

Reviewed by Dan Bernstein.

Fixes 10 warnings in JavaScriptCore and 2 in testapi.

  • API/tests/testapi.c:

(main):
Remove dead variables.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).

  • wtf/dtoa.cpp:

(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.

8:39 AM Changeset in webkit [93016] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
​https://bugs.webkit.org/show_bug.cgi?id=66166

Also changed base.RequestTracker to:
a) fire callback immediately if requestsInFlight is 0;
b) not barf if callback is not supplied.

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
12:00 AM Changeset in webkit [93015] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/win

Build fix.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Aug 12, 2011:

11:25 PM Changeset in webkit [93014] by mitz@apple.com
  • 25 edits in trunk/Source

Source/WebCore: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
​https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
truncated text, try to set the tooltip to the full text of the truncated text, if any.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize new member variable.
(WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.

  • page/Settings.h:

(WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.

  • rendering/HitTestResult.h:
  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Made this public.

Source/WebKit/mac: Add an option to automatically show tooltips (with the full text) over truncated text
​https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Added a default value of NO for the
ShowsToolTipOverTruncatedText preference.
(-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
(-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit/win: Add an option to automatically show tooltips (with the full text) over truncated text
​https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Interfaces/IWebPreferencesPrivate.idl: Added accessors.
  • WebPreferenceKeysPrivate.h: Defined a preference key.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added a default value of
false for the ShowsToolTipOverTruncatedText preference.
(WebPreferences::showsToolTipOverTruncatedText): Added this getter.
(WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().

Source/WebKit2: <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
​https://bugs.webkit.org/show_bug.cgi?id=66178

Reviewed by Simon Fraser.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShowsToolTipOverTruncatedText): Added this setter.
(WKPreferencesGetShowsToolTipOverTruncatedText): Added this getter.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Handle the showsToolTipOverTruncatedText preference.

8:26 PM Changeset in webkit [93013] by senorblanco@chromium.org
  • 11 edits in trunk/Source/WebCore

Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
​https://bugs.webkit.org/show_bug.cgi?id=66154

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::isAccelerated):
Plumb this call through GraphicsContext::isAcceleratedContext().
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
For the ACCELERATED_2D_CANVAS path, plumb this call through
(the new) GraphicsContext::paintsIntoCanvasBuffer().
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):
Remove the use of the m_context3D member; use a temporary instead.

  • html/canvas/CanvasRenderingContext2D.h:

Remove the m_context3D member.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Implement stub versions of these functions for other platforms.

  • platform/graphics/GraphicsContext.h:

Expose isAcceleratedContext() to all platforms. Add
paintsIntoImageBuffer() member function.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setGraphicsContext3D):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::paintsIntoImageBuffer):
Basically gut this class leaving only a static creation function.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
Use isAccelerated() in place of useSkiaGpu().

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
(WebCore::PlatformContextSkia::paintsIntoImageBuffer):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::isAccelerated):
Rename useSkiaGpu() to isAccelerated(). Plumb through
paintsIntoImageBuffer() to GraphicsContext3D.

7:40 PM Changeset in webkit [93012] by weinig@apple.com
  • 13 edits in trunk/Source

Use builtin_trap() for CRASH when building with clang
​https://bugs.webkit.org/show_bug.cgi?id=66152

Reviewed by Anders Carlsson.

../JavaScriptCore:

  • wtf/Assertions.h:

Add Clang specific CRASH macro that calls builtin_trap() instead
of silly techniques to crash. This allows the static analyzer to understand
that we are intentionally crashing. As a result, we need to mark some functions
as not returning.

Also adds a macros that annotates a function as never returning due to ASSERT or CRASH.

  • wtf/Compiler.h:

Add COMPILIER(CLANG) and fix some formatting and spelling mistakes.

  • wtf/FastMalloc.cpp:

(WTF::Internal::fastMallocMatchFailed):
Add NO_RETURN_DUE_TO_CRASH.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
Add NO_RETURN_DUE_TO_ASSERT.

../WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::fail):

  • bindings/objc/WebScriptObject.mm:
  • platform/mac/BlockExceptions.h:
  • platform/text/cf/StringImplCF.cpp:

Add NO_RETURN_DUE_TO_ASSERT.

  • bridge/IdentifierRep.h:

Don't define the destructor since it is never called,

../WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
(-[WebBaseNetscapePluginView handleMouseMoved:]):
(-[WebBaseNetscapePluginView handleMouseEntered:]):
(-[WebBaseNetscapePluginView handleMouseExited:]):
(-[WebBaseNetscapePluginView focusChanged]):
(-[WebBaseNetscapePluginView windowFocusChanged:]):
(-[WebBaseNetscapePluginView createPlugin]):
(-[WebBaseNetscapePluginView loadStream]):
(-[WebBaseNetscapePluginView shouldStop]):
(-[WebBaseNetscapePluginView destroyPlugin]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
(-[WebBaseNetscapePluginView pluginLayer]):
(-[WebBaseNetscapePluginView getFormValue:]):
Remove the ASSERT_NOT_REACHED from the base class methods. They were not
adding much value and were getting in the way of making the static analyzer
work. A better way to do this would be to use a formal protocol.

6:44 PM Changeset in webkit [93011] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
​https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

No new tests, this is not a functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
If the CSS font-face is loading from a URL then immediately
fallback to a system font matching the description, since we
cannot determine a reasonable family name from the m_string
URL. The URL could be a dataURI.

4:27 PM Changeset in webkit [93010] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT has inconsistent use of boxDouble and unboxDouble,
inconsistent use of assertions regarding doubles, and those
assertions are not turned on in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=66160

Reviewed by Gavin Barraclough.

JIT assertions are now turned on in debug builds. JIT
assertions are now used for boxing and unboxing doubles, and boxing
and unboxing no longer involves code duplication.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::convertToDouble):

4:18 PM Changeset in webkit [93009] by fsamuel@chromium.org
  • 9 edits
    4 adds in trunk/Source

Refactoring of PopupMenuChromium For Readability and Maintainability
​https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
and PopupLisBox.{h|cpp} for readability and maintainability.

No new tests as there's no change in functionality.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
  • tests/PopupMenuTest.cpp:
3:59 PM Changeset in webkit [93008] by abarth@webkit.org
  • 8 edits in branches/chromium/835/Source

Need a way to selectively use hixie-76 for websocket connections depending on destination and/or origin
​https://bugs.webkit.org/show_bug.cgi?id=65835

Patch by Denis Lagno <​dilmah@chromium.org> on 2011-08-12
Reviewed by Alexey Proskuryakov and Yuta Kitamura.

WebCore:

No new tests. (because it is temporary solution for transient period between hixie-76 and hybi-NN).

  • page/Settings.cpp:

(WebCore::Settings::addHixie76WebSocketProtocolException):
(WebCore::Settings::useHixie76WebSocketProtocol):

  • page/Settings.h:

(WebCore::Settings::setUseHixie76WebSocketProtocol):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):

WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::addHixie76WebSocketProtocolException):

  • src/WebSettingsImpl.h:
3:56 PM Changeset in webkit [93007] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Expose pageScaleFactor() to Chromium's WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=66067

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):

  • src/WebViewImpl.h:
3:48 PM Changeset in webkit [93006] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r92997 on Qt port because it uses a method on EventSender that hasn't been
implemented by Qt port's DRT. The failure is tracked by the bug 66173.

  • platform/qt/Skipped:
3:35 PM Changeset in webkit [93005] by mrowe@apple.com
  • 17 edits in trunk

Be more forward-looking in the choice of compiler.

Rubber-stamped by Jon Honeycutt.

Source/JavaScriptCore:

  • Configurations/CompilerVersion.xcconfig:

Source/JavaScriptGlue:

  • Configurations/CompilerVersion.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/CompilerVersion.xcconfig:

Source/WebCore:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit/mac:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit2:

  • Configurations/CompilerVersion.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3:32 PM Changeset in webkit [93004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] Fix non-pthreads build after r91906.
​https://bugs.webkit.org/show_bug.cgi?id=66151

Patch by Kalev Lember <​kalevlember@gmail.com> on 2011-08-12
Reviewed by David Levin.

r91906 broke the non-pthreads GTK+ build by including a header which
doesn't exist. Fix it by including DateMath.h instead of DateMap.h.

  • wtf/gtk/ThreadingGtk.cpp:
3:00 PM Changeset in webkit [93003] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix comile warning on CCLayerTreeHost

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

2:44 PM Changeset in webkit [93002] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update expectations to note flakiness.

  • platform/chromium/test_expectations.txt:
2:42 PM Changeset in webkit [93001] by rniwa@webkit.org
  • 50 edits in trunk

Apple-style-span class seems unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/execCommand/16049-expected.txt:
  • editing/execCommand/5685604-1.html:
  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/query-font-size-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-expected.txt:
  • editing/execCommand/script-tests/remove-format-multiple-elements.js:
  • editing/execCommand/script-tests/toggle-text-decorations.js:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/execCommand/toggle-text-decorations-expected.txt:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/inserting/5994480-2-expected.txt:
  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/pasteboard/paste-text-with-style-2-expected.txt:
  • editing/style/apply-font-size-to-multiple-nodes-expected.txt:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/highlight-insert-paragraph-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/invalid-font-size-expected.txt:
  • editing/style/push-down-font-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-font-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-win/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/editing/inserting/5994480-2-expected.txt:
2:42 PM Changeset in webkit [93000] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update some configuration settings that were missed back in r92432.

  • Configurations/CompilerVersion.xcconfig:
2:41 PM Changeset in webkit [92999] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
​https://bugs.webkit.org/show_bug.cgi?id=66168

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

2:35 PM Changeset in webkit [92998] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
​https://bugs.webkit.org/show_bug.cgi?id=66149

Reviewed by Eric Seidel.

Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
abstraction from ints.

No tests as no change in functionality.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::listHeight):
(WebCore::RenderListBox::baselinePosition):
(WebCore::RenderListBox::itemBoundingBoxRect):
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::itemHeight):
(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::controlClipRect):
(WebCore::RenderListBox::invalidateScrollbarRect):
(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::controlClipRect):
(WebCore::RenderMenuList::showPopup):

  • rendering/RenderMenuList.h:
2:28 PM Changeset in webkit [92997] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk

Source/WebKit/chromium: Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
​https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools: DRT: Add support for gesture events.
​https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollBegin):
(EventSender::gestureScrollEnd):
(EventSender::gestureTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests: DRT: Add support for gesture events.
​https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • fast/events/touch/gesture/gesture-click-expected.txt: Added.
  • fast/events/touch/gesture/gesture-click.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.
2:10 PM Changeset in webkit [92996] by Lucas Forschler
  • 4 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r92986.

2:08 PM Changeset in webkit [92995] by Lucas Forschler
  • 4 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r92911.

2:06 PM Changeset in webkit [92994] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r92909.

2:02 PM Changeset in webkit [92993] by hyatt@apple.com
  • 7 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66133

Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
layer tree (just as we did with painting).

Reviewed by Sam Weinig.

Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.

Source/WebCore:

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::type):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/hit-test-float-expected.txt: Added.
  • fast/regions/hit-test-float.html: Added.
2:01 PM Changeset in webkit [92992] by leviw@chromium.org
  • 8 edits in trunk

Switch RenderTable* to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66146

Reviewed by Eric Seidel.

Converting RenderTable* classes to new LayoutUnits from ints.

No new tests as no new functionality.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::firstLineBoxBaseline):
(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:

(WebCore::RenderTable::columnPositions):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
(WebCore::RenderTableSection::getBaseline):

1:58 PM Changeset in webkit [92991] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/Source/WebCore

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-08-12
Reviewed by Alexey Proskuryakov.

EventSource loader should not buffer data
​https://bugs.webkit.org/show_bug.cgi?id=61863

Disabled buffering in the EventSource loader.

Added a manual test.

  • manual-tests/eventsource/eventsource-loader-buffering.html: Added.
  • manual-tests/eventsource/eventsource-loader-buffering.php: Added.
  • page/EventSource.cpp:

(WebCore::EventSource::connect):

1:56 PM Changeset in webkit [92990] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r92982 on Qt since it uses a new layoutTestController method
that hasn't been implemented by Qt DRT. The failure is tracked by the bug 66162.

  • platform/qt/Skipped:
1:46 PM Changeset in webkit [92989] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebKit/chromium

[Chromium] Implement the embedders for the HTML5 Track List objects
​https://bugs.webkit.org/show_bug.cgi?id=60260

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-08-12
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamTrack.h: Added.

(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::isNull):

  • public/WebMediaStreamTrackList.h: Added.

(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::~WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::isNull):

  • src/WebMediaStreamTrack.cpp: Added.

(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator WTF::PassRefPtr<WebCore::MediaStreamTrack>):

  • src/WebMediaStreamTrackList.cpp: Added.

(WebKit::WebMediaStreamTrackList::initialize):
(WebKit::WebMediaStreamTrackList::reset):
(WebKit::WebMediaStreamTrackList::WebMediaStreamTrackList):
(WebKit::WebMediaStreamTrackList::operator WTF::PassRefPtr<MediaStreamTrackList>):

1:41 PM Changeset in webkit [92988] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

GTK rebaselines after r92890.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
1:34 PM Changeset in webkit [92987] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Mac rebaselines after r92890.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
1:33 PM Changeset in webkit [92986] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

REGRESSION (r91610?): Bing Maps fail to initialize (InvalidOperation:
Matrix3D.invert)
​https://bugs.webkit.org/show_bug.cgi?id=66038

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-08-12
Reviewed by Gavin Barraclough.

Simplest and lowest-impact fix for the case where the spilled format
of a DFG node differs from the register format: if the format is
converted then indicate that the spilled value is no longer valid
("kill the spill").

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::killSpilled):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

1:33 PM Changeset in webkit [92985] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
​https://bugs.webkit.org/show_bug.cgi?id=65926

Reviewed by Alexey Proskuryakov.

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
m_shouldBufferData is set to false.

1:18 PM Changeset in webkit [92984] by aestes@apple.com
  • 2 edits in trunk/Tools

allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
​https://bugs.webkit.org/show_bug.cgi?id=66158

Reviewed by Dan Bernstein.

  • DumpRenderTree/LayoutTestController.cpp:

(allowRoundingHacksCallback): The third argument is the 'this'
JSObjectRef, not the second.

1:16 PM Changeset in webkit [92983] by abarth@webkit.org
  • 8 edits
    4 deletes in trunk/Source

Unreviewed, rolling out r92976.
​http://trac.webkit.org/changeset/92976
​https://bugs.webkit.org/show_bug.cgi?id=66159

Does not compile on chromium-win (Requested by abarth|gardener
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-12

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Removed.
  • platform/chromium/PopupContainer.h: Removed.
  • platform/chromium/PopupListBox.cpp: Removed.
  • platform/chromium/PopupListBox.h: Removed.
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):
(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupItem::PopupItem):
(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
12:56 PM Changeset in webkit [92982] by aestes@apple.com
  • 19 edits
    2 adds in trunk

Cancel in onbeforeunload dialog sometime causes a button to stop working.
​https://bugs.webkit.org/show_bug.cgi?id=26211

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/loader/form-submission-after-beforeunload-cancel.html

If an onbeforeunload handler cancels a navigation that was triggered by
a form submission, WebCore's multiple form submission protection
prevents the form from being submitted a second time even though no
first submission actually took place. Fix this by clearing
m_submittedFormURL if the onbeforeunload handler cancels the load. This
allows the submission to be retried.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
if shouldClose() will return false.

Tools:

Implement a new LayoutTestController method that a test can call to set
the return value of DumpRenderTree's beforeunload UI delegate.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload.
(setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
(LayoutTestController::staticFunctions): Register
'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize
m_shouldStayOnPageAfterHandlingBeforeUnload and bind
'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
(LayoutTestController::reset): Reset
m_shouldStayOnPageAfterHandlingBeforeUnload to false.
(LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
from JavaScript.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
return the inverse of
LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Define setShouldStayOnPageAfterHandlingBeforeUnload().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
to the Test Controller telling it what value it should return in its
onbeforeunload UI delegate.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
Call InjectedBundle::postNewBeforeUnloadReturnValue().

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize
m_beforeUnloadReturnValue to true.
(WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
the value of TestController::beforeUnloadReturnValue().
(WTR::TestController::resetStateToConsistentValues): Reset
m_beforeUnloadReturnValue to true.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::beforeUnloadReturnValue):
(WTR::TestController::setBeforeUnloadReturnValue):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
message posted from the injected bundle by retrieving the message body
as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().

LayoutTests:

  • fast/loader/form-submission-after-beforeunload-cancel-expected.txt: Added.
  • fast/loader/form-submission-after-beforeunload-cancel.html: Added.
12:53 PM Changeset in webkit [92981] by hyatt@apple.com
  • 12 edits
    4 adds
    6 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66130

RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
offset.

Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
They no longer have to subclass their own layout method or worry about all of the painting logic
for anything other than the content area.

Reviewed by Anders Carlsson.

Existing tests have a layer tree example, and so those results are updated to show the tree now.

Source/WebCore:

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png:
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
  • fast/regions/content-flowed-into-regions-expected.png:
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png:
  • fast/regions/content-flowed-into-regions-with-index-expected.png:
  • fast/regions/flow-content-basic-vertical.html:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png:
12:38 PM Changeset in webkit [92980] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r92978.
​http://trac.webkit.org/changeset/92978
​https://bugs.webkit.org/show_bug.cgi?id=66155

This patch does not compile (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-12

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:56 AM Changeset in webkit [92979] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix mac build when web audio is enabled
​https://bugs.webkit.org/show_bug.cgi?id=66150

Unreviewed build fix.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

11:43 AM Changeset in webkit [92978] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
​https://bugs.webkit.org/show_bug.cgi?id=66089

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::zoomLimitsChanged):
(WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
(WebKit::WebView::zoomLevelToZoomFactor):
(WebKit::WebView::zoomFactorToZoomLevel):

  • src/WebViewImpl.h:
11:42 AM Changeset in webkit [92977] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
​https://bugs.webkit.org/show_bug.cgi?id=65724

Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).

Reviewed by Eric Carlson.

No new tests, uses existing media tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::callbackContext): Added.
(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
(WebCore::AVFWrapper::mapLock): Added.
(WebCore::AVFWrapper::map): Added.
(WebCore::AVFWrapper::addToMap): Added.
(WebCore::AVFWrapper::removeFromMap): Added.
(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
(WebCore::AVFWrapper::createPlayer): Use callbackContext().
(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
(WebCore::AVFWrapper::seekToTime): Use callbackContext().
(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().

11:36 AM Changeset in webkit [92976] by fsamuel@chromium.org
  • 8 edits
    4 adds in trunk/Source

Refactoring of PopupMenuChromium
​https://bugs.webkit.org/show_bug.cgi?id=66009

Reviewed by Darin Fisher.

Source/WebCore:

Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
for readability and maintainability.

No new tests as no functionality has changed.

  • WebCore.gypi:
  • platform/chromium/PopupContainer.cpp: Added.

(WebCore::constructRelativeMouseEvent):
(WebCore::constructRelativeWheelEvent):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::~PopupContainer):
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupContainer::hidePopup):
(WebCore::PopupContainer::notifyPopupHidden):
(WebCore::PopupContainer::layoutAndGetRTLOffset):
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupContainer::handleKeyEvent):
(WebCore::PopupContainer::hide):
(WebCore::PopupContainer::paint):
(WebCore::PopupContainer::paintBorder):
(WebCore::PopupContainer::isInterestedInEventForKey):
(WebCore::PopupContainer::chromeClientChromium):
(WebCore::PopupContainer::showInRect):
(WebCore::PopupContainer::refresh):
(WebCore::PopupContainer::isRTL):
(WebCore::PopupContainer::selectedIndex):
(WebCore::PopupContainer::menuItemHeight):
(WebCore::PopupContainer::menuItemFontSize):
(WebCore::PopupContainer::menuStyle):
(WebCore::popupData):
(WebCore::PopupContainer::getSelectedItemToolTip):

  • platform/chromium/PopupContainer.h: Added.

(WebCore::PopupContainer::listBox):
(WebCore::PopupContainer::popupType):

  • platform/chromium/PopupListBox.cpp: Added.

(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupListBox::handleMouseDownEvent):
(WebCore::PopupListBox::handleMouseMoveEvent):
(WebCore::PopupListBox::handleMouseReleaseEvent):
(WebCore::PopupListBox::handleWheelEvent):
(WebCore::PopupListBox::isInterestedInEventForKey):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
(WebCore::isCharacterTypeEvent):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::hostWindow):
(WebCore::stripLeadingWhiteSpace):
(WebCore::PopupListBox::typeAheadFind):
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowFont):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::pointToRowIndex):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::setOriginalIndex):
(WebCore::PopupListBox::getRowHeight):
(WebCore::PopupListBox::getRowBounds):
(WebCore::PopupListBox::invalidateRow):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupListBox::adjustSelectedIndex):
(WebCore::PopupListBox::hidePopup):
(WebCore::PopupListBox::updateFromElement):
(WebCore::PopupListBox::setMaxWidthAndLayout):
(WebCore::PopupListBox::layout):
(WebCore::PopupListBox::clear):
(WebCore::PopupListBox::isPointInBounds):

  • platform/chromium/PopupListBox.h: Added.

(WebCore::PopupItem::PopupItem):
(WebCore::PopupListBox::create):
(WebCore::PopupListBox::selectedIndex):
(WebCore::PopupListBox::numItems):
(WebCore::PopupListBox::setBaseWidth):
(WebCore::PopupListBox::setMaxHeight):
(WebCore::PopupListBox::setMaxWidth):
(WebCore::PopupListBox::disconnectClient):
(WebCore::PopupListBox::items):
(WebCore::PopupListBox::~PopupListBox):
(WebCore::PopupListBox::scrollToRevealSelection):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/WebPopupMenuImpl.cpp:
  • src/WebViewImpl.cpp:
11:06 AM Changeset in webkit [92975] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 92798
BUG=91972
Review URL: ​http://codereview.chromium.org/7634029

10:51 AM Changeset in webkit [92974] by weinig@apple.com
  • 10 edits
    4 adds in trunk

Move compiler specific macros to their own header
​https://bugs.webkit.org/show_bug.cgi?id=66119

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Add Compiler.h

  • wtf/AlwaysInline.h:

Move the contents of this file (which no longer was just about ALWAYS_INLINE) to
Compiler.h. We can remove this file in a later commit.

  • wtf/Compiler.h: Added.

Put all compiler specific checks and features in this file.

  • wtf/Platform.h:

Move COMPILER macro and definitions (and the odd WARN_UNUSED_RETURN compiler feature)
to Compiler.h. Include Compiler.h since it is necessary.

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/Compiler.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
10:36 AM Changeset in webkit [92973] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source/WebCore

[Qt][REGRESSION] composited content doesn't render since r92651
​https://bugs.webkit.org/show_bug.cgi?id=66108

Reviewed by Benjamin Poulain.

Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
the new signature in GraphicsLayer.h.

No new tests. This is a regression that's covered by existing pixel tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::syncCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
10:34 AM Changeset in webkit [92972] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Add a way to extend DOM objects in garden-o-matic.
​https://bugs.webkit.org/show_bug.cgi?id=66096

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
10:33 AM Changeset in webkit [92971] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 92791
BUG=91362
Review URL: ​http://codereview.chromium.org/7634026

10:28 AM Changeset in webkit [92970] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Expose pageScaleFactor in Chromium's WebHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=66139

Reviewed by Darin Fisher.

  • public/WebHistoryItem.h:
  • src/WebHistoryItem.cpp:

(WebKit::WebHistoryItem::pageScaleFactor):
(WebKit::WebHistoryItem::setPageScaleFactor):

10:22 AM Changeset in webkit [92969] by commit-queue@webkit.org
  • 19 edits
    2 copies
    27 adds in trunk

Original patch by Mihnea Ovidenie <​mihnea@adobe.com>.
Also contains some improvements done by Dave Hyatt <​hyatt@apple.com>.

[CSSRegions]RenderFlowThread should display its content using RenderRegion
​https://bugs.webkit.org/show_bug.cgi?id=65627

Source/WebCore:

RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
of RenderRegion objects that get the content from the same flow.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-12
Reviewed by David Hyatt.

Tests: fast/regions/content-flowed-into-regions-dynamically-added.html

fast/regions/content-flowed-into-regions-dynamically-removed.html
fast/regions/content-flowed-into-regions-with-dyn-index.html
fast/regions/content-flowed-into-regions-with-index-dom.html
fast/regions/content-flowed-into-regions-with-index.html
fast/regions/content-flowed-into-regions.html
fast/regions/flow-content-basic-vertical-rl.html
fast/regions/flow-content-basic-vertical.html

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::compareRenderRegions):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paint):
(WebCore::RenderRegion::styleDidChange):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

LayoutTests:

Also updated the old tests that expected an 100% by 100% RenderFlowThread. Those tests
require at least a region attached, otherwise the RenderFlowThread would have been 0/0 in size,
and no output would be generated for them in the render tree.

The attached regions are now printed in the render tree, so some tests required updated results.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-12
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html: Added.
  • fast/regions/content-flowed-into-regions-expected.png: Added.
  • fast/regions/content-flowed-into-regions-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-dyn-index.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index-dom.html: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
  • fast/regions/content-flowed-into-regions-with-index-expected.txt: Added.
  • fast/regions/content-flowed-into-regions-with-index.html: Added.
  • fast/regions/content-flowed-into-regions.html: Added.
  • fast/regions/flow-content-basic-vertical-rl.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic-vertical.html: Copied from LayoutTests/fast/regions/flow-content-basic.html.
  • fast/regions/flow-content-basic.html:
  • fast/regions/render-region-renderer-expected.txt:
  • fast/regions/resources/region-style.css: Added.

(.greenBox):
(.blueBox):
(.orangeBox):
(.flowArticle):
(.regionArticle):
(.borderBox):

  • fast/regions/webkit-flow-renderer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer-expected.txt:
  • fast/regions/webkit-flow-renderer-layer.html:
  • fast/regions/webkit-flow-renderer-nested-expected.txt:
  • fast/regions/webkit-flow-renderer-nested.html:
  • fast/regions/webkit-flow-renderer.html:
  • platform/mac/fast/regions/flow-content-basic-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
10:17 AM Changeset in webkit [92968] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 92966
BUG=92621
Review URL: ​http://codereview.chromium.org/7640019

10:15 AM Changeset in webkit [92967] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/835

Merge 92966
BUG=92621
Review URL: ​http://codereview.chromium.org/7635022

9:27 AM Changeset in webkit [92966] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash in WebCore::editingIgnoresContent
​https://bugs.webkit.org/show_bug.cgi?id=66125

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr a few nodes in case they get blown away in
dispatchEvent calls.

Test: editing/selection/select-start-remove-root-crash.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Tests that we do not crash when we blow away the root
during the firing of selectstart event in selection.

  • editing/selection/select-start-remove-root-crash-expected.txt: Added.
  • editing/selection/select-start-remove-root-crash.html: Added.
9:26 AM Changeset in webkit [92965] by nduca@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add WebThread to WebKitClient
​https://bugs.webkit.org/show_bug.cgi?id=66013

Reviewed by Darin Fisher.

  • public/WebKitClient.h:

(WebKit::WebKitClient::createThread):

  • public/WebThread.h: Added.

(WebKit::WebThread::~WebThread):

8:34 AM Changeset in webkit [92964] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: properly update console message count in source frames and resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=57009

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype._updateMessageRepeatCount):

8:15 AM Changeset in webkit [92963] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Add test for correct order of load signals in QWebPage
​https://bugs.webkit.org/show_bug.cgi?id=66016

Reviewed by Benjamin Poulain.

Add API test to ensure the order of load signals: loadStarted() needs to be emitted
first, then loadProgress(100), followed by loadFinished().

The test is skipped since this right now is broken, the bug
​https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.

  • tests/qwebpage/tst_qwebpage.cpp:

(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
(SpyForLoadSignalsOrder::isFinished):
(SpyForLoadSignalsOrder::onLoadProgress):
(tst_QWebPage::loadSignalsOrder_data):
(tst_QWebPage::loadSignalsOrder):

7:56 AM Changeset in webkit [92962] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-12 Pavel Feldman <​pfeldman@google.com>

Not reviewed: follow up to inspector test breakage.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
7:50 AM Changeset in webkit [92961] by yurys@chromium.org
  • 12 edits in trunk

Web Inspector: expand exception properties when wrapping it as object.
​https://bugs.webkit.org/show_bug.cgi?id=66035

Source/WebCore:

Use toString() value as a description for value thrown during eval.

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-eval-syntax-error-expected.txt:
  • inspector/console/console-eval-undefined-override-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • platform/chromium/inspector/console/console-eval-global-expected.txt:
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt:
  • platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt:
7:33 AM Changeset in webkit [92960] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.

In order to build correctly the QtQuick1 plugin we need to explicitly
link to the new library added in Qt5 "qtquick1".

Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
7:05 AM Changeset in webkit [92959] by andreip@google.com
  • 1 edit
    38 adds in trunk/LayoutTests

2011-08-12 Andrei Popescu <​andreip@google.com>

[Chromium] Rebaseline these tests on Leopard.

Unreviewed gardening.

  • LayoutTests/platform/chromium-linux/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac-leopard/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-mac/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • LayoutTests/platform/chromium-win-xp/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • LayoutTests/platform/chromium-win/platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
6:54 AM Changeset in webkit [92958] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: make folders optional in the Scripts' panel file selector.
​https://bugs.webkit.org/show_bug.cgi?id=66100

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
6:03 AM Changeset in webkit [92957] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: add space between error info and error message in source frame message bubble.
​https://bugs.webkit.org/show_bug.cgi?id=65069

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • inspector/debugger/source-frame-expected.txt:
5:56 AM Changeset in webkit [92956] by pfeldman@chromium.org
  • 16 edits in trunk

Web Inspector: console loses focus upon reloading the page from the inspector.
​https://bugs.webkit.org/show_bug.cgi?id=66068

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype._clearButtonClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.revealAndSelect):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._setDocument.selectNode):
(WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
(WebInspector.ElementsPanel.prototype._setDocument):
(WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.selectedDOMNode):
(WebInspector.ElementsPanel.prototype.selectDOMNode):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.updateFocusedNode):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.reset):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype._jumpToSearchResult):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.showResource):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createTopPane):

  • inspector/front-end/inspector.js:
  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.select):

LayoutTests:

  • inspector/console/command-line-api-inspect.html:
5:17 AM Changeset in webkit [92955] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Source/WebCore: Add HTMLUnknownElement interface as defined in
​http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

​https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
5:06 AM Changeset in webkit [92954] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-08-12 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h

  • inspector/InspectorAgent.h:
4:44 AM Changeset in webkit [92953] by vsevik@chromium.org
  • 29 edits in trunk

Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
​https://bugs.webkit.org/show_bug.cgi?id=66061

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::requestId):

  • inspector/IdentifiersFactory.h:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::requestId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._requestId):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._appendResource):
(WebInspector.NetworkLogView.prototype._matchResource):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype.performSearch):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.FormattedRecord):

LayoutTests:

  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-test.js:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
3:57 AM Changeset in webkit [92952] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/LayoutTests

Source/WebCore: Add HTMLUnknownElement interface as defined in
​http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.

​https://bugs.webkit.org/show_bug.cgi?id=41841

Unreviewed gardening after r92890.

  • fast/html/unknown-tag-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png: Updated.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated.
2:32 AM Changeset in webkit [92951] by hans@chromium.org
  • 5 edits in trunk

IndexedDB: Object store records don't need to have keys in all indexes
​https://bugs.webkit.org/show_bug.cgi?id=66049

Reviewed by Tony Chang.

Source/WebCore:

Allow inserting records in an object store even though they don't
yield keys in some index. The spec has changed in this regard.

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

LayoutTests:

Update test to make sure it's possible to add an object store record
even though it doesn't yield keys in every index.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
1:51 AM Changeset in webkit [92950] by hans@chromium.org
  • 12 edits in trunk

IndexedDB: Overwriting key in unique index should be possible
​https://bugs.webkit.org/show_bug.cgi?id=65993

Reviewed by Tony Chang.

Source/WebCore:

It should be possible to overwrite an object store record even if
there is a derived key for that record in an index with the unique flag set.

  • storage/IDBBackingStore.h:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • storage/IDBSQLiteBackingStore.cpp:

(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):

  • storage/IDBSQLiteBackingStore.h:

LayoutTests:

Test that it's possible to overwrite an object store record even if there
is a derived key for that record in an index with the unique flag set.

  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
12:52 AM Changeset in webkit [92949] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix after r91815 - restore changes from r91659.
​https://bugs.webkit.org/show_bug.cgi?id=64682

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Kenneth Rohde Christiansen.

Restore patch for fix ewk_view_context_menu_forward_event which
has been overwrititen by mistake.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

12:46 AM Changeset in webkit [92948] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] HTML Saving feature.
​https://bugs.webkit.org/show_bug.cgi?id=55455

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-08-12
Reviewed by Antonio Gomes.

Gets the source and location of resources for document.
TODO:

  1. Support others resources (css, plugins, media files).
  2. Currently only HTML documents are supported.
  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):
(ewk_frame_resources_location_get):

  • ewk/ewk_frame.h:
12:08 AM Changeset in webkit [92947] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.14

New tag.

Note: See TracTimeline for information about the timeline view.