⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 27, 2011:

11:51 PM Changeset in webkit [101227] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r101226.

  • DEPS:
11:28 PM Changeset in webkit [101226] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium revision.

  • DEPS:
11:08 PM Changeset in webkit [101225] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement vertical-align property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72926

Reviewed by Andreas Kling.

Part of the ongoing refactoring of CSSStyleSelector::applyProperty.

Covered by several tests under fast/css.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isPercent):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setVerticalAlignLength):
Calling setVerticalAlignLength now automatically sets verticalAlign to LENGTH.

11:06 PM WebKit Team edited by mihnea@adobe.com
(diff)
10:59 PM Changeset in webkit [101224] by abarth@webkit.org
  • 25 edits
    23 copies
    9 moves
    27 adds in trunk/Source/WebKit/chromium

[Chromium] Move the next traunch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73073

Reviewed by Darin Fisher.

These headers are all the forward-declared classes in
WebKitPlatformSupport (and their dependencies) that wrap concepts in
WebCore/platform.

There are a number of forward-declared classes in WebKitPlatformSupport
that coorespond to WebCore concepts outside of WebCore/platform. I've
marked these with FIXME comments. We'll need to study them in more
detail to see whether they should move into WebCore/platform or whether
we need to move them out of WebKitPlaformSupport.h. (One possible
resolution might be to introducing a WebKitClientSupport.h to hold
statics for client concepts).

  • public/WebBlobRegistry.h: Replaced.
  • public/WebCanvas.h: Replaced.
  • public/WebClipboard.h: Replaced.
  • public/WebColor.h: Replaced.
  • public/WebColorName.h: Replaced.
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebContentLayerClient.h:
  • public/WebContextMenuData.h:
  • public/WebCookieJar.h: Replaced.
  • public/WebCursorInfo.h:
  • public/WebDragData.h: Replaced.
  • public/WebFileSystem.h: Replaced.
  • public/WebFloatQuad.h:
  • public/WebFont.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGraphicsContext3D.h: Replaced.
  • public/WebHTTPBody.h:
  • public/WebImage.h: Replaced.
  • public/WebImageDecoder.h:
  • public/WebLayer.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamDescriptor.h: Replaced.
  • public/WebMediaStreamSource.h:
  • public/WebMimeRegistry.h: Replaced.
  • public/WebNonCopyable.h: Replaced.
  • public/WebPeerConnectionHandler.h: Replaced.
  • public/WebPeerConnectionHandlerClient.h: Replaced.
  • public/WebPlugin.h:
  • public/WebPoint.h: Replaced.
  • public/WebRect.h: Replaced.
  • public/WebRegularExpression.h:
  • public/WebScreenInfo.h:
  • public/WebScrollbar.h:
  • public/WebSize.h: Replaced.
  • public/WebSocketStreamError.h: Replaced.
  • public/WebSocketStreamHandle.h: Replaced.
  • public/WebSocketStreamHandleClient.h: Replaced.
  • public/WebThread.h: Replaced.
  • public/WebTouchPoint.h:
  • public/WebURLLoader.h: Replaced.
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/android/WebSandboxSupport.h: Removed.
  • public/android/WebThemeEngine.h: Removed.
  • public/linux/WebFontFamily.h: Removed.
  • public/linux/WebSandboxSupport.h: Removed.
  • public/linux/WebThemeEngine.h: Removed.
  • public/mac/WebSandboxSupport.h: Removed.
  • public/mac/WebThemeEngine.h: Removed.
  • public/platform/WebBlobRegistry.h: Copied from Source/WebKit/chromium/public/WebBlobRegistry.h.
  • public/platform/WebCanvas.h: Copied from Source/WebKit/chromium/public/WebCanvas.h.
  • public/platform/WebClipboard.h: Copied from Source/WebKit/chromium/public/WebClipboard.h.
  • public/platform/WebColor.h: Copied from Source/WebKit/chromium/public/WebColor.h.
  • public/platform/WebColorName.h: Copied from Source/WebKit/chromium/public/WebColorName.h.
  • public/platform/WebCookieJar.h: Copied from Source/WebKit/chromium/public/WebCookieJar.h.
  • public/platform/WebDragData.h: Copied from Source/WebKit/chromium/public/WebDragData.h.
  • public/platform/WebFileSystem.h: Copied from Source/WebKit/chromium/public/WebFileSystem.h.
  • public/platform/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/WebGraphicsContext3D.h.
  • public/platform/WebImage.h: Copied from Source/WebKit/chromium/public/WebImage.h.
  • public/platform/WebKitPlatformSupport.h:
  • public/platform/WebMediaStreamDescriptor.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
  • public/platform/WebMimeRegistry.h: Copied from Source/WebKit/chromium/public/WebMimeRegistry.h.
  • public/platform/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/WebNonCopyable.h.
  • public/platform/WebPeerConnectionHandler.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandler.h.
  • public/platform/WebPeerConnectionHandlerClient.h: Copied from Source/WebKit/chromium/public/WebPeerConnectionHandlerClient.h.
  • public/platform/WebPoint.h: Copied from Source/WebKit/chromium/public/WebPoint.h.
  • public/platform/WebRect.h: Copied from Source/WebKit/chromium/public/WebRect.h.
  • public/platform/WebSize.h: Copied from Source/WebKit/chromium/public/WebSize.h.
  • public/platform/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/WebSocketStreamError.h.
  • public/platform/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandle.h.
  • public/platform/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/WebSocketStreamHandleClient.h.
  • public/platform/WebThread.h: Copied from Source/WebKit/chromium/public/WebThread.h.
  • public/platform/WebURLLoader.h: Copied from Source/WebKit/chromium/public/WebURLLoader.h.
  • public/platform/android: Added.
  • public/platform/android/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/android/WebSandboxSupport.h.
  • public/platform/android/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/android/WebThemeEngine.h.
  • public/platform/linux: Added.
  • public/platform/linux/WebFontFamily.h: Copied from Source/WebKit/chromium/public/linux/WebFontFamily.h.
  • public/platform/linux/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/linux/WebSandboxSupport.h.
  • public/platform/linux/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/linux/WebThemeEngine.h.

(WebKit::WebThemeEngine::paint):

  • public/platform/mac: Added.
  • public/platform/mac/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/mac/WebSandboxSupport.h.
  • public/platform/mac/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/mac/WebThemeEngine.h.

(WebKit::WebThemeEngine::paintScrollbarThumb):

  • public/platform/win: Added.
  • public/platform/win/WebSandboxSupport.h: Copied from Source/WebKit/chromium/public/win/WebSandboxSupport.h.
  • public/platform/win/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/win/WebThemeEngine.h.
  • public/win/WebSandboxSupport.h: Removed.
  • public/win/WebThemeEngine.h: Removed.
10:41 PM Changeset in webkit [101223] by hayato@chromium.org
  • 71 edits in trunk/LayoutTests

Chromium rebaselines for r101202.
Unreviewed, rebaselined results.

  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
10:26 PM Changeset in webkit [101222] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Updating the licences to the correct one.
https://bugs.webkit.org/show_bug.cgi?id=73129

Replacing the incorrect ones I have submitted with the correct ones.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-27
Reviewed by Darin Fisher.

  • bridge/PeerConnectionHandler.cpp:
  • bridge/PeerConnectionHandlerInternal.cpp:
  • bridge/PeerConnectionHandlerInternal.h:
  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMediaStreamSource.h:
  • public/WebPeerConnectionHandler.h:
  • public/WebPeerConnectionHandlerClient.h:
  • src/WebMediaStreamDescriptor.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebMediaStreamSource.cpp:
10:19 PM Changeset in webkit [101221] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyTextAlign in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=73102

Reviewed by Andreas Kling.

Covered by fast/css/text-align*.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

9:46 PM Changeset in webkit [101220] by hayato@chromium.org
  • 1 edit
    86 adds in trunk/LayoutTests

Chromium rebaselines for r101202.

Unreviewed, rebaselined results.

  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-linux/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
9:15 PM Changeset in webkit [101219] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

[Qt][Mac-WebKit2] file-input-reset.html is failing because of no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=72429
https://bugs.webkit.org/show_bug.cgi?id=72571

  • platform/mac/Skipped: Move file-input-reset.html to wk/Skipped.
  • platform/qt/Skipped: Move some entries to the section for beginDragWithFiles().
  • platform/wk2/Skipped: Move file-input-reset.html from mac/Skipped.
7:50 PM Changeset in webkit [101218] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSSStyleRule: Pack m_sourceLine with CSSRule bits.
<http://webkit.org/b/73168>

Reviewed by Antti Koivisto.

Make CSSStyleRule::m_sourceLine a 27-bit integer and pack it with the rest
of the members in CSSRule. This shrinks CSSStyleRule by one CPU word
and reduces memory consumption by 81 kB on the GMail inbox (on 64-bit.)

  • css/CSSRule.h:

(WebCore::CSSRule::CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):

  • css/CSSStyleRule.h:
6:11 PM Changeset in webkit [101217] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should not emit GetMethod node
https://bugs.webkit.org/show_bug.cgi?id=73175

Reviewed by Gavin Barraclough.

Replaces all instances of the GetMethod node with GetById. This appears to
be a slight win on V8. This patch leaves GetMethod support in the code-base,
making this decision easy to reverse, for now.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

4:12 PM Changeset in webkit [101216] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] MiniBrowser stops displaying content after surfing a few pages.
https://bugs.webkit.org/show_bug.cgi?id=73172

Properly initialize WebLayerTreeInfo structures.

Reviewed by Andreas Kling.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):
(WebKit::WebLayerInfo::WebLayerInfo):
(WebKit::WebLayerTreeInfo::WebLayerTreeInfo):

3:47 PM Changeset in webkit [101215] by mrowe@apple.com
  • 10 edits in trunk/Source

<http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in: Expose the necessary symbol.
  • platform/mac/WebCoreSystemInterface.h: Ditto.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

  • WebView/WebView.mm:

(createMacOSXVersionString): Use WKGetMacOSXVersionString.

Source/WebKit2:

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::macOSXVersionString): Use WKGetMacOSXVersionString.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.

3:44 PM Changeset in webkit [101214] by Martin Robinson
  • 1 edit
    1 delete in trunk/LayoutTests

Remove a test baseline that does not differ on GTK+ now that
WebGL is active by default.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
3:25 PM Changeset in webkit [101213] by annacc@chromium.org
  • 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553

Source/WebCore:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

  • html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

  • html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

  • html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

  • html/TextTrack.h: Ditto.
  • html/TextTrack.idl: Ditto.

LayoutTests:

Fix for r101057 after it was rolled out in r101088

Reviewed by Eric Carlson.

  • media/track/track-add-track-expected.txt:
  • media/track/track-add-track.html:
  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:
  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-element-readyState.html:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-load-from-src-readyState.html:
3:05 PM Changeset in webkit [101212] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Julien Chaffraix.

The test started failing after the expected file was removed in r101203. Add the file
but specifically for Snow Leopard.

  • platform/mac-snowleopard/compositing: Added.
  • platform/mac-snowleopard/compositing/layer-creation: Added.
  • platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
1:45 PM Changeset in webkit [101211] by robert@webkit.org
  • 135 edits
    8 copies
    35 moves
    261 adds
    37 deletes in trunk/LayoutTests

Chromium rebaselines for r101202

Unreviewed, rebaselined results.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-leopard/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-96-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001a-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001b-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001c-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-001d-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-003-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-004-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-005-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-006-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-007-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-008-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-009-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-010-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-011-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-012-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-013-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-014-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-015-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-016-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-017-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-018-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-019-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-020-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-021-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-022-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-023-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-024-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-025-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-026-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-027-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-028-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-029-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-030-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-031-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-032-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-033-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-034-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-035-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-036-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-037-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-038-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-conflict-element-039-expected.txt: Renamed from LayoutTests/platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium-win/fast/css/border-conflict-element-002-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/border-conflict-element-002-expected.txt.
  • platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt:
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-95-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-97-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-98-d-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png:
1:13 PM Changeset in webkit [101210] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't allow attribute changes on <track> if feature is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=73046

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

12:52 PM Changeset in webkit [101209] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening after r101183.

  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Updated.
12:34 PM Changeset in webkit [101208] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: setCssText() mostly duplicates parseDeclaration().
<http://webkit.org/b/73171>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Let setCssText() call parseDeclaration() instead of duplicating the functionality.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setCssText):

12:29 PM Changeset in webkit [101207] by robert@webkit.org
  • 1 edit
    106 adds in trunk/LayoutTests

Mac, Qt and Gtk results for r101202

Unreviewed, new results.

  • platform/gtk/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/gtk/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/gtk/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/mac/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/mac/fast/css/border-conflict-element-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/qt/fast/css/border-conflict-element-002-expected.txt: Added.
12:20 PM Changeset in webkit [101206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CSS/XSLStyleSheet: checkLoaded() needn't be virtual.
<http://webkit.org/b/73169>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

Devirtualize checkLoaded() in CSSStyleSheet and XSLStyleSheet as they
are not overriding anything, nor are they ever overridden.

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
12:02 PM Changeset in webkit [101205] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add assertions that CSSMappedAttributeDeclarations aren't using strict parsing.
<http://webkit.org/b/73167>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antti Koivisto.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

11:48 AM Changeset in webkit [101204] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSheet: Removed unused create() overload.
<http://webkit.org/b/73170>

Patch by Andreas Kling <kling@webkit.org> on 2011-11-27
Reviewed by Antonio Gomes.

Nobody was using CSSStyleSheet::create(ownerNode, originalURL, finalURL)
so remove it.

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):

11:05 AM Changeset in webkit [101203] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

The test compositing/layer-creation/spanOverlapsCanvas.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73159

Reviewed by Andreas Kling.

The empty file spanOverlapsCanvas-expected.txt was created in the Chromium rebaseline r100557.

On Lion, the test spanOverlapsCanvas.html generates the expected test result, this patch removes
the empty file.

The empty directories compositing/layer-creation for Snow Leopard and Lion are also removed.

  • platform/mac-lion/compositing: Removed.
  • platform/mac-lion/compositing/layer-creation: Removed.
  • platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/mac-snowleopard/compositing: Removed.
  • platform/mac-snowleopard/compositing/layer-creation: Removed.
10:32 AM Changeset in webkit [101202] by robert@webkit.org
  • 74 edits
    137 adds in trunk

CSS 2.1 failure: border-conflict-element-*
https://bugs.webkit.org/show_bug.cgi?id=71244

Source/WebCore:

Reviewed by Julien Chaffraix.

From http://www.w3.org/TR/CSS21/tables.html#border-conflict-resolution :

"When two adjacent cells have the same border-width and the same border-style in a
'border-collapse: collapse' table, then the color of the border from the leftmost cell wins
(if the table's 'direction' is 'ltr'; right, if it is 'rtl') and the color of the border
from the topmost cell wins."

So WebCore::compareBorders needs to account for the position of the cell when
deciding which border wins the comparison. This will ensure that the winning border is
sorted to the appropriate position in the sorted list of borders for painting.

When conflicting collapsed borders are in the same cell, the following order of
precedence is used (where 4 has highest precedence):

3

| |

4 | | 1

|_|

2

This fixes the following failing tests from the border-conflict-element-* set
in the CSS 2.1 test suite:

border-conflict-element-001d.htm
border-conflict-element-0037.htm

One test in the suite is known to be wrong, so a corrected version has been landed outside the
css2.1 folder:

border-conflict-element-002.htm

This change entails rebaselining quite a few tests, see the LayoutTests ChangeLog for a full
explanation of the rebaselines.

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders): Compare the cells' position from the left (in 'ltr') and right (in 'rtl')

of the table and the cells' position from the top of the table when nothing
else in the style, width, or grouping of the borders determines precedence.
If the conflicting borders are in the same cell, apply the same logic to the position of the borders.

(WebCore::RenderTableCell::collapsedStartBorder): Pass the cell's position and its table's direction to CollapsedBorderValue
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::collapsedAfterBorder): ditto

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue): Learn the position of the border's cell and the direction of its table
(WebCore::CollapsedBorderValue::columnOffset): the cell's offset from the top of the table
(WebCore::CollapsedBorderValue::rowOffset): the cell's offset from the start of the table
(WebCore::CollapsedBorderValue::edge): which edge of the cell the border is on
(WebCore::CollapsedBorderValue::operator==): cells with the same position in the table are equal

LayoutTests:

Add all the passing border-conflict-element* tests from the CSS 2.1 test suite.

Add a corrected version of the CSS suite test border-conflict-element-002.htm, which can sit here until

the corrected version is landed upstream. See http://lists.w3.org/Archives/Public/public-css-testsuite/2011Nov/0002.html

Rebaseline all t170602-bdr-conflct-w-* tests. The rendering of the collapsed borders in these

tests now obeys the order of precedence for the position of the cell and the precendece of the position
of the borders within the same cell.

Rebaseline tables/mozilla/collapsing_borders/bug41262-4.html: ditto

tables/mozilla/marvin/table_rules_all.html : ditto
tables/mozilla/marvin/table_rules_none.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_cols.html : ditto
tables/mozilla_expected_failures/marvin/table_rules_rows.html : ditto

Rebaseline two border-conflict-style-* tests: ditto

Rebaseline fast/borders/border-antialiasing.html, the result is too small to confirm the difference but

presume it is one of the above.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/border-conflict-element-001.htm: Added.
  • css2.1/20110323/border-conflict-element-001a.htm: Added.
  • css2.1/20110323/border-conflict-element-001b.htm: Added.
  • css2.1/20110323/border-conflict-element-001c.htm: Added.
  • css2.1/20110323/border-conflict-element-001d.htm: Added.
  • css2.1/20110323/border-conflict-element-003.htm: Added.
  • css2.1/20110323/border-conflict-element-004.htm: Added.
  • css2.1/20110323/border-conflict-element-005.htm: Added.
  • css2.1/20110323/border-conflict-element-006.htm: Added.
  • css2.1/20110323/border-conflict-element-007.htm: Added.
  • css2.1/20110323/border-conflict-element-008.htm: Added.
  • css2.1/20110323/border-conflict-element-009.htm: Added.
  • css2.1/20110323/border-conflict-element-010.htm: Added.
  • css2.1/20110323/border-conflict-element-011.htm: Added.
  • css2.1/20110323/border-conflict-element-012.htm: Added.
  • css2.1/20110323/border-conflict-element-013.htm: Added.
  • css2.1/20110323/border-conflict-element-014.htm: Added.
  • css2.1/20110323/border-conflict-element-015.htm: Added.
  • css2.1/20110323/border-conflict-element-016.htm: Added.
  • css2.1/20110323/border-conflict-element-017.htm: Added.
  • css2.1/20110323/border-conflict-element-018.htm: Added.
  • css2.1/20110323/border-conflict-element-019.htm: Added.
  • css2.1/20110323/border-conflict-element-020.htm: Added.
  • css2.1/20110323/border-conflict-element-021.htm: Added.
  • css2.1/20110323/border-conflict-element-022.htm: Added.
  • css2.1/20110323/border-conflict-element-023.htm: Added.
  • css2.1/20110323/border-conflict-element-024.htm: Added.
  • css2.1/20110323/border-conflict-element-025.htm: Added.
  • css2.1/20110323/border-conflict-element-026.htm: Added.
  • css2.1/20110323/border-conflict-element-027.htm: Added.
  • css2.1/20110323/border-conflict-element-028.htm: Added.
  • css2.1/20110323/border-conflict-element-029.htm: Added.
  • css2.1/20110323/border-conflict-element-030.htm: Added.
  • css2.1/20110323/border-conflict-element-031.htm: Added.
  • css2.1/20110323/border-conflict-element-032.htm: Added.
  • css2.1/20110323/border-conflict-element-033.htm: Added.
  • css2.1/20110323/border-conflict-element-034.htm: Added.
  • css2.1/20110323/border-conflict-element-035.htm: Added.
  • css2.1/20110323/border-conflict-element-036.htm: Added.
  • css2.1/20110323/border-conflict-element-037.htm: Added.
  • css2.1/20110323/border-conflict-element-038.htm: Added.
  • css2.1/20110323/border-conflict-element-039.htm: Added.
  • css2.1/20110323/support/swatch-blue.png: Added.
  • css2.1/20110323/support/swatch-green.png: Added.
  • css2.1/20110323/support/swatch-lime.png: Added.
  • css2.1/20110323/support/swatch-orange.png: Added.
  • css2.1/20110323/support/swatch-red.png: Added.
  • css2.1/20110323/support/swatch-teal.png: Added.
  • css2.1/20110323/support/swatch-white.png: Added.
  • css2.1/20110323/support/swatch-yellow.png: Added.
  • fast/css/border-conflict-element-002.htm: Added.
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Addition of support/swatch-white.png rebaselines result.
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-25-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/chromium-linux/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001a-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001b-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001c-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-001d-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-003-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-005-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-006-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-007-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-008-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-009-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-010-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-011-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-012-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-013-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-014-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-015-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-016-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-017-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-018-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-019-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-020-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-021-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-022-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-023-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-024-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-025-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-026-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-027-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-028-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-029-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-030-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-031-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-032-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-033-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-034-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-035-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-036-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-037-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-038-expected.txt: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.png: Added.
  • platform/chromium/css2.1/20110323/border-conflict-element-039-expected.txt: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.png: Added.
  • platform/chromium/fast/css/border-conflict-element-002-expected.txt: Added.
7:54 AM Changeset in webkit [101201] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
5:30 AM Changeset in webkit [101200] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

REGRESSION(r97881): It broke fast/dom/error-to-string-stack-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=70476

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2011-11-27
Reviewed by Andreas Kling.

Removing obsolete qt-specific expected file as the base one is enough.

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.

Nov 26, 2011:

7:05 PM Changeset in webkit [101199] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for Windows.

5:26 PM Changeset in webkit [101198] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853

Patch by Hajime Morrita <morrita@chromium.org> on 2011-11-26
Reviewed by Kevin Ollivier.

Added WTF_HIDDEN, WTF_INLINE and JS_INLINE which
indirect attribute((visibility("hidden"))

  • config.h:
  • wtf/ExportMacros.h:
11:31 AM Changeset in webkit [101197] by alex
  • 2 edits in trunk/Source/WebCore

2011-11-26 Alejandro G. Castro <alex@igalia.com>

Fix compilation after r101157.

Reviewed by Martin Robinson.

  • bindings/scripts/preprocessor.pm: (applyPreprocessor): In case we have a string with double-quotations (") we replace it with the empty string.
10:00 AM Changeset in webkit [101196] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TexMapper][WK2][Qt] Simple opacity animations are not working
https://bugs.webkit.org/show_bug.cgi?id=73157

LayerTreeHostQt needs to know what nodes in the TextureMapper are visible, to associate
a tile to it. It is done using TextureMapperNode::collectVisibleContentsRects.

However TextureMapperNode::collectVisibleContentsRects has an optimization to check if
the current tile has opacity greater than 0.01, otherwise it will not create a tile for
the current node.

For opacity animations from 0 to 1, it is a problem because the tile is never created
and the animation never happens.

This patch fixes opacity animations.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::countDescendantsWithContent):
(WebCore::TextureMapperNode::collectVisibleContentsRects):

8:09 AM Changeset in webkit [101195] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Qt] [WK2] QtDownloadManager doesn't need to be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=73151

Reviewed by Kenneth Rohde Christiansen.

QtDownloadManager is owned by QtWebContext, and doesn't need to be a RefCounted
class. This commit also makes the callback handlers private -- following the similar
approach we take in other clients of the C API.

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::toQtDownloadManager):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload): remove unused failingUrl local variable.
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):

  • UIProcess/qt/QtDownloadManager.h:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::initialize):

  • UIProcess/qt/QtWebContext.h:
7:51 AM Changeset in webkit [101194] by commit-queue@webkit.org
  • 45 edits in trunk/Source

Unreviewed, rolling out r101193.
http://trac.webkit.org/changeset/101193
https://bugs.webkit.org/show_bug.cgi?id=73158

Breaks Windows and Qt minimal. (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-26

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::disconnectFromBackend):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):

  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromBackend):

  • loader/EmptyClients.h:

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::disconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorFrontendClientQt::disconnectFromBackend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorFrontendClient::disconnectFromBackend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/InspectorClientWinCE.cpp:
  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/InspectorClientWx.cpp:
  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::disconnectFromBackend):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
7:30 AM Changeset in webkit [101193] by pfeldman@chromium.org
  • 42 edits in trunk/Source

Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127

Source/WebCore:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspectedPageDestroyed):

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromWorker):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::closeInspectorFrontend):

Source/WebKit/chromium:

We should instead use InspectorClient::closeInspectorFrontend that would
be closing the front-end window.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::closeInspectorFrontend):

  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::closeInspectorFrontend):
(WebKit::WebDevToolsAgent::disconnectEventAsText):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/gtk:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::closeInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

Source/WebKit/qt:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::closeInspectorFrontend):
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-26
Reviewed by Yury Semikhatsky.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectorDestroyed):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
4:48 AM Changeset in webkit [101192] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a bug in TreeOutline which would cause parent elements to show up as expanded and empty
when removed and added back to the tree.

https://bugs.webkit.org/show_bug.cgi?id=73155

Reviewed by Pavel Feldman.

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.collapse): Set _treeElementsExpandedState to false instead of true.
Only TreeElement.prototype.expand should set it to true, which it does.

2:47 AM Changeset in webkit [101191] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[CMake] Clean up Web Inspector target in Source/WebKit/blackberry/CMakeListsBlackBerry.txt
https://bugs.webkit.org/show_bug.cgi?id=72784

Patch by Jonathan Dong <Jonathan Dong> on 2011-11-26
Reviewed by Nikolas Zimmermann.

Abstracted the JavaScript file names from inspector/front-end/inspector.html
to keep them in-sync with the changes of inspector.html.

  • blackberry/CMakeListsBlackBerry.txt:
2:16 AM Changeset in webkit [101190] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Fix some warnings in WebCore GTK+
https://bugs.webkit.org/show_bug.cgi?id=73137

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-26
Reviewed by Philippe Normand.

No new tests. This patch just fixes compilation warnings.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor): Remove unused variable.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::paintSliderTrack): ASSERT_UNUSED instead of ASSERT.

  • platform/gtk/SharedTimerGtk.cpp: Ditto.

(WebCore::stopSharedTimer):

12:59 AM Changeset in webkit [101189] by Martin Robinson
  • 2 edits in trunk/Tools

Try to fix the build after r101174.

  • gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.

Nov 25, 2011:

11:17 PM Changeset in webkit [101188] by caio.oliveira@openbossa.org
  • 5 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[Qt] [WK2] Remove WebContext related code from QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73150

Reviewed by Kenneth Rohde Christiansen.

Creates a QtWebContext class that abstracts away from QtWebPageProxy the
handling of creating / maintaining the default WebContext, as well as the
code for the WKContextRef clients.

Another motivation for having this entity is to have a proper place to add
objects are bound to the context, like the QtDownloadManager.

  • Target.pri:
  • UIProcess/qt/ClientImpl.cpp: Removed.
  • UIProcess/qt/ClientImpl.h: Removed.
  • UIProcess/qt/QtDownloadManager.cpp:
  • UIProcess/qt/QtWebContext.cpp: Added.

(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
(WebKit::QtWebContext::createWebPage):
(WebKit::QtWebContext::setNavigatorQtObjectEnabled):
(WebKit::QtWebContext::postMessageToNavigatorQtObject):
(WebKit::QtWebContext::initialize):
(WebKit::QtWebContext::initializeContextInjectedBundleClient):
(WebKit::toQtWebContext):
(WebKit::QtWebContext::didReceiveMessageFromInjectedBundle):

  • UIProcess/qt/QtWebContext.h: Added.

(WebKit::QtWebContext::downloadManager):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):
(QtWebPageProxy::handleDownloadRequest):

  • UIProcess/qt/QtWebPageProxy.h:
10:15 PM Changeset in webkit [101187] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String.prototype.toLower should be optimized for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=73154

Changed stringProtoFuncToLowerCase to use StringImpl::lower() which has
been optimized for 8 bit strings.

This is worth ~7% to sunspider string.tagcloud.

Reviewed by Filip Pizlo.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):

10:01 PM Changeset in webkit [101186] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.toString always uses StringImpl::characters()
https://bugs.webkit.org/show_bug.cgi?id=72969

If all component strings are 8 bit, create an 8 bit result string for toString().

This appears to be performance neutral to sunspider and v8.

Reviewed by Filip Pizlo.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

8:28 PM Changeset in webkit [101185] by eric.carlson@apple.com
  • 11 edits
    2 adds
    2 deletes in trunk

Implement addCue and removeCue in TextTrack
https://bugs.webkit.org/show_bug.cgi?id=72554

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-add-remove-cue.html

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack): Go ahead and allocate a Track even if the feature

is disabled, it just won't load anything.

(WebCore::HTMLTrackElement::scheduleLoad): Early return if the featue is disabled.
(WebCore::HTMLTrackElement::canLoadUrl): Ditto.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable): Add new cues one at a time because

cues->add(Vector<TextTrackCue*>&) is gone.

  • html/TextTrack.cpp:

(WebCore::TextTrack::addCue): Implement.
(WebCore::TextTrack::removeCue): Ditto.

  • html/TextTrack.h:

(WebCore::TextTrackCue::TextTrackCue): Initialize every member variable.
(WebCore::TextTrackCue::track): m_track is now a RefPtr.
(WebCore::TextTrackCue::setTrack): Ditto.

  • html/TextTrackCue.h:
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Don't ignore out of order cues, the spec text is not

a conformance requirement. Return bool to indicate success or failure.

(WebCore::TextTrackCueList::remove): Return bool to indicate success or failure.

  • html/TextTrackCueList.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::notifyFinished): Don't change m_state once it is set to Failed.

LayoutTests:

  • media/track/track-add-remove-cue-expected.txt: Added.
  • media/track/track-add-remove-cue.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
  • media/track/track-webvtt-tc012-out-of-order.html: Removed.
4:34 PM Changeset in webkit [101184] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring CodeGenerator*.pm for bug 72138
https://bugs.webkit.org/show_bug.cgi?id=73115

Reviewed by Adam Barth.

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.

(GenerateHeaderCustomCall):

  • bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
3:34 PM Changeset in webkit [101183] by haraken@chromium.org
  • 6 edits
    2 adds in trunk

Implement the WebGLContextEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=72856

Reviewed by Adam Barth.

Source/WebCore:

This patch makes WebGLContextEvent constructable.
The spec: http://www.khronos.org/registry/webgl/specs/latest/#5.14

Test: fast/events/constructors/webgl-context-event-constructor.html

  • html/canvas/WebGLContextEvent.cpp: Added an implementation of the WebGLContextEvent constructor.

(WebCore::WebGLContextEventInit::WebGLContextEventInit):
(WebCore::WebGLContextEvent::WebGLContextEvent):

  • html/canvas/WebGLContextEvent.h: Added a definition of WebGLContextEventInit.

(WebCore::WebGLContextEvent::create):

  • html/canvas/WebGLContextEvent.idl: Added [ConstructorTemplate=Event] IDL.

LayoutTests:

webgl-context-event-constructor.html checks the behavior of the WebGLContextEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added window.WebGLContextEvent.
  • fast/events/constructors/webgl-context-event-constructor-expected.txt: Added.
  • fast/events/constructors/webgl-context-event-constructor.html: Added.
2:59 PM Changeset in webkit [101182] by rniwa@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Add missing results for Mac after r100949 and r100036.
svg/repaint/filter-child-repaint.svg is failing. The failure is tracked by the bug 73146.

  • platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.png: Added.
  • platform/mac/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/mac/media/controls-without-preload-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/mac/svg/repaint/filter-child-repaint-expected.txt: Added.
1:52 PM Changeset in webkit [101181] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium] The DrawingBuffer::bind method was incorrectly resetting the
GL viewport parameters. This was unnecessary, and resulted in the corruption
of the WebGL context's state.
https://bugs.webkit.org/show_bug.cgi?id=73091

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-25
Reviewed by Stephen White.

Tests: fast/canvas/webgl/webgl-viewport-parameters-preserved.html

Source/WebCore:

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::bind):

LayoutTests:

  • fast/canvas/webgl/webgl-viewport-parameters-preserved-expected.txt: Added.
  • fast/canvas/webgl/webgl-viewport-parameters-preserved.html: Added.
12:21 PM Changeset in webkit [101180] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in BidiRunList<Run>::replaceRunWithRuns with an empty bdi element
https://bugs.webkit.org/show_bug.cgi?id=73116

Reviewed by Eric Seidel.

Source/WebCore:

The assertion failure was caused because isolatedResolver is initialized with
null start object due to the isolated run being empty.

Fixed the failure by skipping empty isolated runs.

Test: fast/text/empty-bdi-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):

LayoutTests:

Added a regression test.

  • fast/text/empty-bdi-crash-expected.txt: Added.
  • fast/text/empty-bdi-crash.html: Added.
11:57 AM Changeset in webkit [101179] by jesus@webkit.org
  • 11 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
https://bugs.webkit.org/show_bug.cgi?id=73096

Reviewed by Kenneth Rohde Christiansen.

Move all the interaction engine usage to QtWebPageEventHandler,
making all GestureRecognizers (Tap, Pinch and Pan) use it directly.

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::QtGestureRecognizer):

  • UIProcess/qt/QtGestureRecognizer.h:
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler::interactionEngine):

11:26 AM Changeset in webkit [101178] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove unneeded declaration from QQuickWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=73141

Reviewed by Antonio Gomes.

Left-over from r101165.

  • UIProcess/API/qt/qquickwebpage_p_p.h:
10:08 AM Changeset in webkit [101177] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

StyleGeneratedImage should ref CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=73074

Reviewed by Andreas Kling and Nikolas Zimmermann.

RenderStyle owns a bunch of StyleImage objects. However StyleGeneratedImage does not ref the
CSSImageGeneratorValue it holds so we currently rely on the stylesheet to keep the CSSImageGeneratorValues
alive as long as RenderStyle stays alive. While this works (RenderStyles are thrown away if stylesheets
change) it is not particularly robust or nice.

  • Use RefPtr<CSSImageGeneratorValue> in StyleGeneratedImage
  • Remove the RefPtr<StyleGeneratedImage> from CSSImageGeneratorValue. There is no good reason to cache StyleGeneratedImage as it is a small and uncommon object. With that the whole back-reference becomes unnecessary.
  • Switch more places to use (Pass)RefPtr<StyleImage> for consistency.
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSStyleApplyProperty.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::cachedOrPendingFromValue):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:
  • rendering/style/FillLayer.h:

(WebCore::FillLayer::setImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::StyleGeneratedImage):
(WebCore::StyleGeneratedImage::cssValue):
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):

  • rendering/style/StyleGeneratedImage.h:

(WebCore::StyleGeneratedImage::create):
(WebCore::StyleGeneratedImage::data):

9:47 AM Changeset in webkit [101176] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: assertion failure in InspectorController::restoreInspectorStateFromCookie
https://bugs.webkit.org/show_bug.cgi?id=73136

Don't call connectFrontend twice on reattach.

Reviewed by Pavel Feldman.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):

8:46 AM Changeset in webkit [101175] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Remove redundant setStrictParsing(false) calls on CSSMappedAttributeDeclarations.
<http://webkit.org/b/73134>

Reviewed by Antti Koivisto.

CSSMappedAttributeDeclarations always use non-strict parsing since they use
the argument-less CSSMutableStyleDeclaration constructor.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createMappedDecl):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

8:19 AM Changeset in webkit [101174] by Martin Robinson
  • 10 edits
    1 move
    3 adds
    4 deletes in trunk

[GTK] Integrate build-gtkdoc into build-webkit and make
https://bugs.webkit.org/show_bug.cgi?id=72626

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Remove references to old gtkdoc files. Update

the dist-hook to include copying documentation into the distribution.
This also means that the build will fail if documentation hasn't been
generated before 'make dist.'

  • configure.ac: Ditto.

Source/WebKit/gtk:

  • docs/GNUmakefile.am: Removed.
  • docs/version.xml.in: Removed.

Source/WebKit2:

  • GNUmakefile.am: Removed references to build-gtkdoc and gtkdoc.py.
  • UIProcess/API/gtk/docs/build-gtkdoc: Removed.

Tools:

  • GNUmakefile.am: Added support for new scripts and "make docs".
  • Scripts/webkitdirs.pm: Call generate-gtkdoc when building.

(buildAutotoolsProject):

  • gtk/generate-gtkdoc: Added.
  • gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
7:14 AM Changeset in webkit [101173] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark inspector/elements/remove-node.html test as crashing sometimes on Linux.

  • platform/chromium/test_expectations.txt:
7:00 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the bots (diff)
6:58 AM BuildingQt5OnHarmattan edited by Csaba Osztrogonác
Update Qt5 revision (diff)
6:44 AM Changeset in webkit [101172] by andreas.kling@nokia.com
  • 16 edits
    1 add in trunk/Source/WebCore

Factor element pointer out of CSSMutableStyleDeclaration.
<http://webkit.org/b/73121>

Reviewed by Antti Koivisto.

Move the StyledElement pointer out of CSSMutableStyleDeclaration and into a subclass
for the cases where it's needed. This reduces the size of vanilla style declarations
by one CPU word (4 or 8 bytes, depending on architecture.)

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::element):
(WebCore::CSSElementStyleDeclaration::setElement):
(WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):
(WebCore::CSSElementStyleDeclaration::~CSSElementStyleDeclaration):

Added CSSElementStyleDeclaration, a common parent class for inline styles
and mapped attributes. It extends CSSMutableStyleDeclaration by adding a backpointer
to the StyledElement that owns it.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSInlineStyleDeclaration.h: Added.

(WebCore::CSSInlineStyleDeclaration::~CSSInlineStyleDeclaration):
(WebCore::CSSInlineStyleDeclaration::create):
(WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):

Added CSSInlineStyleDeclaration.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Only follow the associated element on CSSElementStyleDeclarations.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):

Remove comment about m_element since the field was moved to a subclass.

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::isElementStyleDeclaration):
(WebCore::CSSStyleDeclaration::isInlineStyleDeclaration):

We no longer need to track whether a style declaration is mutable or not,
so the constructors are slightly simplified.
Added two bits (isElementStyleDeclaration and isInlineStyleDeclaration) for
runtime type checking. These are protected and set by the CSSElementStyleDeclaration
constructor.

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::create):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

Remove pointless CSSRule* argument to constructor since we always passed 0.

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::getInlineStyleDecl):
(WebCore::StyledElement::addSubresourceAttributeURLs):

Make the inline style on StyledElement a CSSInlineStyleDeclaration.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

Slightly simplified by having CSSInlineStyleDeclaration.

6:35 AM Changeset in webkit [101171] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
https://bugs.webkit.org/show_bug.cgi?id=73132

Reviewed by Simon Hausmann.

Make sure QWebDownloadItem is registered in the right plugin.

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

6:32 AM Changeset in webkit [101170] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: unflake timeline-network tests
https://bugs.webkit.org/show_bug.cgi?id=73123

Source/WebCore:

We should capture stack only when it makes sense. Otherwise loading from cache
results in different data sets (stacks) than regular load.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
6:19 AM Changeset in webkit [101169] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Add support for using OWRT with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947

Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2011-11-25
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
6:17 AM Changeset in webkit [101168] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix.

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded): dowsntream implementation with OVERRIDE modifier fails to compile without this stub.
5:56 AM WebKit Team edited by Alexandru Chiculita
(diff)
5:53 AM Changeset in webkit [101167] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Clean up code in WK2/ChromeClientClient related to viewport handling
https://bugs.webkit.org/show_bug.cgi?id=73128

Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

Make sure that we only call resizeToContentsIfNeeded when we are
using the tiled backing store and fixed layout as well.

Guard the scrollbar code so that it is only called when scroll
delegation is not used. Do similarily for the frameset code,
which makes no sense with frame flattening.

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

This method is only called for the main frame, so the main frame
check has been removed.

5:39 AM Changeset in webkit [101166] by yurys@chromium.org
  • 12 edits in trunk

[Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
https://bugs.webkit.org/show_bug.cgi?id=73126

Source/WebCore:

Notify embedder that front-end is loadded only when all dispatchers, panels and models
have been created so that it could dispatch messages synchronously in the loaded handler.

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • public/WebDevToolsFrontendClient.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::frontendLoaded):

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
(WebKit::WebDevToolsFrontendImpl::doDispatchOnInspectorFrontend):

  • src/WebDevToolsFrontendImpl.h:

Tools:

No need to have a separate client call for this. The front-end can store messages
which arrive before front-end loaded and dispatch them later. This happens in layout
tests only by the way as all other messages should be initiated by the front-end code.

Reviewed by Pavel Feldman.

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
4:54 AM Changeset in webkit [101165] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt] Eliminate warnings about the deprecated QQuickCanvas::sceneGraphEngine() function.

Reviewed by Andreas Kling.

We use the function in question to find out if we can connect to the scene graph's
afterRendering signal. The signal has been moved into QQuickCanvas right away, so
we can connect to it as soon as we have a canvas.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::initializeSceneGraphConnections):

  • UIProcess/API/qt/qquickwebpage_p.h:
4:48 AM Changeset in webkit [101164] by jesus@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Move event handling out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=73089

Reviewed by Kenneth Rohde Christiansen.

Move all logic related to event handling, gestures and the
interaction engine out of QtWebPageProxy, creating a separate
class called QtWebPageEventHandler. This handler will be created
by the QQuickWebViewPrivate and will be registered into QtWebPageProxy.
QQuickWebPage will now call handleEvent through this entity.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::event):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp: Added.

(QtWebPageEventHandler::dragOperationToDropAction):
(QtWebPageEventHandler::dragOperationToDropActions):
(QtWebPageEventHandler::dropActionToDragOperation):
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleMouseDoubleClickEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::timerEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::setViewportInteractionEngine):
(QtWebPageEventHandler::touchEvent):
(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):
(QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h: Added.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::didFindZoomableArea):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::eventHandler):

4:12 AM Changeset in webkit [101163] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't send Console.messagesCleared on front-end connection if console agent is not enabled
https://bugs.webkit.org/show_bug.cgi?id=73122

Console agent should stay silent if it is not enabled.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

3:39 AM Changeset in webkit [101162] by Simon Hausmann
  • 9 edits
    1 add in trunk/Source/WebKit2

[Qt] Cleanup in QML tests.

Reviewed by Tor Arne Vestbø.

Use a simple QML component for the "DesktopWebView" instead of a new QML type.
This will allow the use of the experimental extension in the future.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

2:57 AM Changeset in webkit [101161] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream the QNX/RIM specific HistoryItemViewState
https://bugs.webkit.org/show_bug.cgi?id=73114

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-11-25
Reviewed by Daniel Bates.

This patch is to upstream RIM/QNX specific HistoryItemViewState extension
to store some extra view state.

No new tests. It's not built yet.

  • history/blackberry: Added.
  • history/blackberry/HistoryItemViewState.h: Added.

(WebCore::HistoryItemViewState::HistoryItemViewState):

2:33 AM Changeset in webkit [101160] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Split scripts panel top status bar into debug toolbar and editor toolbar.
https://bugs.webkit.org/show_bug.cgi?id=73087

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._createEditorToolbar):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar):
(#scripts-editor-toolbar):
(#scripts-debug-sidebar-resizer-widget):
(.script-view):

2:06 AM Changeset in webkit [101159] by leo.yang@torchmobile.com.cn
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream BlackBerry porting of platform/text
https://bugs.webkit.org/show_bug.cgi?id=73117

Reviewed by Daniel Bates.

Initial upstream, can't be built yet, no test cases.

  • platform/text/blackberry/StringBlackBerry.cpp: Added.

(WTF::String::String):
(WTF::String::operator WebString):

  • platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp: Added.

(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

1:41 AM Changeset in webkit [101158] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Yury Semikhatsky.

  • platform/chromium/test_expectations.txt:
1:31 AM Changeset in webkit [101157] by haraken@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove WebCore.gyp/scripts/rule_binding.py
https://bugs.webkit.org/show_bug.cgi?id=73109

Reviewed by Adam Barth.

rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper
of generate-bindings.pl and thus we can remove it.

No new tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp: Replaces rule_binding.py with generate-bindings.pl.
  • WebCore.gyp/scripts/rule_binding.py: Removed.
  • bindings/scripts/preprocessor.pm: When '"ENABLE_SOMETHING=1" "ENABLE_OTHERS=0"' is passed as a define macro, the string is passed to our perl scripts without the double-quotations (") omitted. We need to omit the double quatations here.

(applyPreprocessor):

1:29 AM Changeset in webkit [101156] by yurys@chromium.org
  • 15 edits
    4 deletes in trunk

[Chromium] Web Inspector: remove legacy debugger support
https://bugs.webkit.org/show_bug.cgi?id=73081

Removed classed providing access to V8 debugging protocol. Clients should
use Web Inspector protocol instead.

Reviewed by Pavel Feldman.

Source/WebCore:

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/PageScriptDebugServer.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: Removed.
  • src/DebuggerAgentImpl.h: Removed.
  • src/DebuggerAgentManager.cpp: Removed.
  • src/DebuggerAgentManager.h: Removed.
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):
(WebKit::WebDevToolsAgentImpl::didNavigate):
(WebKit::WebDevToolsAgentImpl::didClearWindowObject):

  • src/WebDevToolsAgentImpl.h:
1:25 AM Changeset in webkit [101155] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-11-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium deps revision to 111575

  • DEPS:
1:23 AM Changeset in webkit [101154] by pfeldman@chromium.org
  • 26 edits in trunk

Web Inspector: refactor resource tree model and introduce explicit class for ResourceTreeFrame.
https://bugs.webkit.org/show_bug.cgi?id=73078

Otherwise we are managing frames and their resources using too many maps.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::restore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._fetchResourceTree):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype.frameForId):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get id):
(WebInspector.ResourceTreeFrame.prototype.get name):
(WebInspector.ResourceTreeFrame.prototype.get url):
(WebInspector.ResourceTreeFrame.prototype.get loaderId):
(WebInspector.ResourceTreeFrame.prototype.get parentFrame):
(WebInspector.ResourceTreeFrame.prototype.get childFrames):
(WebInspector.ResourceTreeFrame.prototype.isMainFrame):
(WebInspector.ResourceTreeFrame.prototype.navigate):
(WebInspector.ResourceTreeFrame.prototype.get mainResource):
(WebInspector.ResourceTreeFrame.prototype.addChildFrame):
(WebInspector.ResourceTreeFrame.prototype.removeChildFrame):
(WebInspector.ResourceTreeFrame.prototype._addResource):
(WebInspector.ResourceTreeFrame.prototype.resources):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL.filter):
(WebInspector.ResourceTreeFrame.prototype.resourceForURL):
(WebInspector.ResourceTreeFrame.prototype._callForFrameResources):
(WebInspector.PageDispatcher.prototype.frameNavigated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._resetWithFrames):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.formatContent):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-tree/resource-tree-document-url.html:
  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap.collect):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterCachedResourcesProcessed):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources.visit):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):

  • inspector/debugger/source-frame.html:
  • inspector/styles/css-live-edit.html:
  • inspector/styles/styles-history.html:
  • platform/qt/Skipped:

Nov 24, 2011:

11:10 PM Changeset in webkit [101153] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialize global variables during IDLParser object creation
https://bugs.webkit.org/show_bug.cgi?id=73108

Reviewed by Adam Barth.

Currently, IDLParser.pm initializes global variables in a global scope,
which means that the global variables are initialized just once at the beginning.
On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
on generate-bindings.pl that initializes the global variables whenever a new IDLParser
object is created. Thus, this patch initializes the global variables during
the IDLParser object creation.

No new tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(InitializeGlobalData):
(new):

10:55 PM Changeset in webkit [101152] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975

Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.

  • runtime/UString.cpp:

(JSC::UString::number):
(JSC::operator==):
(JSC::operator<):
(JSC::UString::ascii):

10:47 PM Changeset in webkit [101151] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JavaScript string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974

Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.

Reviewed by Filip Pizlo.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):

10:44 PM Changeset in webkit [101150] by haraken@chromium.org
  • 2 edits in trunk/Tools

Replace subprocess.call() with subprocess.Popen()
https://bugs.webkit.org/show_bug.cgi?id=73105

Reviewed by Adam Barth.

Currently, the stdout and stderr of the child processes of run-bindings-tests
are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
between a parent process and a child process. This patch replaces subprocess.call() with
subprocess.Popen() and synchronizes the stdout and stderr between them.
This patch also makes output messages of run-bindings-tests more readable.

With this patch, the output messages of run-bindings-tests look like as follows:

PASS: (CPP) WebDOMTestObj.h
PASS: (CPP) WebDOMTestObj.cpp
FAIL: (CPP) WebDOMTestInterface.h
--- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900
+++ /tmp/tmpDAV87G/WebDOMTestInterface.h 2011-11-25 13:44:42.712946812 +0900
@@ -23,7 +23,7 @@

#ifndef WebDOMTestInterface_h
#define WebDOMTestInterface_h

-#if ENABLE(Condition1) +#if ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

#include <WebDOMObject.h>
#include <WebDOMString.h>
@@ -53,5 +53,5 @@
WebDOMTestInterface toWebKit(WebCore::TestInterface*);

#endif

-#endif ENABLE(Condition1) +#endif ENABLE(Condition1)
ENABLE(Condition2)
ENABLE(Condition3)

PASS: (CPP) WebDOMFloat64Array.cpp
PASS: (CPP) WebDOMFloat64Array.h

Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")

  • Scripts/run-bindings-tests:

(generate_from_idl):
(detect_changes):
(run_tests):
(main):

10:36 PM Changeset in webkit [101149] by haraken@chromium.org
  • 2 edits in trunk/Tools

Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106

Reviewed by Adam Barth.

Currently, run-bindings-tests outputs the following error
(although it outputs "all tests passed!" in the end):

Testing the ObjC generator on TestObj.idl
gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
gcc: warning: '-x objective-c' after last input file has no effect
gcc: no input files

This is because CodeGeneratorObjC.pm assumes that the current working directory
is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
Thus, this patch changes it to WebKit/Source/.

  • Scripts/run-bindings-tests:

(generate_from_idl):
(main):

10:35 PM Changeset in webkit [101148] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968

Clear m_is8Bit flag for empty strings.

Reviewed by Filip Pizlo.

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):

10:23 PM Changeset in webkit [101147] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683

Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.

Reviewed by Filip Pizlo.

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):

  • runtime/UString.h:

(JSC::UString::adopt):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::adopt):

3:23 PM Changeset in webkit [101146] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix for NOT ENABLE_WEB_SOCKETS.

  • CMakeLists.txt: Move CloseEvent.idl to the unconditional files.
3:16 PM Changeset in webkit [101145] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for C++ bindings.

  • bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
12:03 PM Changeset in webkit [101144] by commit-queue@webkit.org
  • 23 edits
    23 adds in trunk

Microdata: Support for properties attribute.
https://bugs.webkit.org/show_bug.cgi?id=71050

Patch by Arko Saha <arko@motorola.com> on 2011-11-24
Reviewed by Adam Barth.

Source/WebCore:

The properties attribute returns an HTMLPropertiesCollection object with all the element's
properties. Otherwise, an empty HTMLPropertiesCollection object.

Tests: fast/dom/MicroData/itemref-refers-first-element-with-given-id.html

fast/dom/MicroData/names-property-must-be-correct.html
fast/dom/MicroData/names-property-test.html
fast/dom/MicroData/properties-collection-add-remove-itemref.html
fast/dom/MicroData/properties-collection-add-remove-property.html
fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html
fast/dom/MicroData/properties-collection-must-be-correct.html
fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html
fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html
fast/dom/MicroData/properties-collection-test.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • dom/MicroDataItemList.cpp:
  • dom/Node.cpp:

(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
(WebCore::Node::properties):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):
(WebCore::NodeRareData::properties):

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::itemAfter):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setItemValueText):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLPropertiesCollection.cpp: Added.

(WebCore::compareTreeOrder):
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::~HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::findPropetiesOfAnItem): Finds the properties of an item.
(WebCore::HTMLPropertiesCollection::length): Returns the number of elements in the properties collection.
(WebCore::HTMLPropertiesCollection::item): Returns the element with index 'index' from the collection. The items are sorted in tree order.
(WebCore::HTMLPropertiesCollection::names): Returns a DOMStringList with the property names of the elements in the collection with the order preserved but with duplicates removed.

  • html/HTMLPropertiesCollection.h: Added.
  • html/HTMLPropertiesCollection.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Added test for html properties collections.

  • fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Added.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Added.
  • fast/dom/MicroData/names-property-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/names-property-must-be-correct.html: Added.
  • fast/dom/MicroData/names-property-test-expected.txt: Added.
  • fast/dom/MicroData/names-property-test.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-add-remove-property.html: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-be-correct.html: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Added.
  • fast/dom/MicroData/properties-collection-test-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-test.html: Added.
10:25 AM Changeset in webkit [101143] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removed obsolete touchui flag
https://bugs.webkit.org/show_bug.cgi?id=73067

Reviewed by Tony Chang.

  • features.gypi:
10:10 AM Changeset in webkit [101142] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

IndexedDB: Indexes should be secondarily sorted on primary key
https://bugs.webkit.org/show_bug.cgi?id=72567

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-24
Reviewed by Tony Chang.

Source/WebCore:

Implemented by adding the primary key (i.e. unique key in the
object store) to the IndexDataKey (i.e. the composite key used
in the index. Previously, non-unique entries in the index were
stored with a unique (and hidden) sequenceNumber, so ordering was
not predictable by scripts (or per spec). The sequenceNumber
is now deprecated but still present in the LevelDB backing store
to avoid having to do a data migration.

Test: storage/indexeddb/cursor-primary-key-order.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):

  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Updates the IndexDataKey unit tests to include primary keys. The
deprecated sequenceNumber element of IndexDataKey is still tested,
although no longer used by callers.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

LayoutTests:

  • storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
  • storage/indexeddb/cursor-primary-key-order.html: Added.
8:51 AM Changeset in webkit [101141] by zeno.albisser@nokia.com
  • 15 edits in trunk/Source

[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
https://bugs.webkit.org/show_bug.cgi?id=72495

Source/JavaScriptCore:

Update defines to not use Unix Domain Sockets for platform Qt on Mac.
This enables Qt to reuse existing code for mach ports and Grand
Central Dispatch based IPC.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:

Source/WebKit2:

Make Qt using mach ports and Grand Central Dispatch for IPC
when building on Mac.

Reviewed by Simon Hausmann.

  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/CoreIPCMessageKinds.h:
  • Platform/SharedMemory.h:
  • Platform/WorkQueue.h:
  • Platform/mac/MachUtilities.cpp:
  • Platform/mac/WorkQueueMac.cpp:
  • Target.pri:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

8:36 AM Changeset in webkit [101140] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: WebInspector.inspectedPageDomain is not calculated for about:blank
https://bugs.webkit.org/show_bug.cgi?id=73082

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-24
Reviewed by Timothy Hatcher.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/inspector.js:

(WebInspector.networkResourceById):
(WebInspector.get inspectedPageDomain):

8:02 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Remove point about gobject properties (diff)
7:12 AM Changeset in webkit [101139] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
(WebInspector.ExtensionServer.prototype._handleOpenURL):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.set dispatch):
(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/externs.js:

(WebInspector.populateResourceContextMenu):

  • inspector/front-end/inspector.js:

(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):

6:57 AM Changeset in webkit [101138] by Philippe Normand
  • 6 edits
    2 adds in trunk/Source/WebCore

[GStreamer] WebAudio AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=69835

Reviewed by Martin Robinson.

New GStreamer source element pulling data from the AudioBus and
outputing audio interleaved GstBuffers suitable for playback.

  • GNUmakefile.list.am: Added the new GStreamer WebAudio element

source files to the build.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::onGStreamerWavparsePadAddedCallback): Function called
when the playback pipeline successfully parsed the audio source
into a WAV stream.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Configure the initial playback pipeline up to the WAV parser. The
audio sink is added only after the WAV parser was configured.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Reset the playback pipeline and delete it.
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
Method to add the audio sink to the pipeline and link it to the
WAV parser.
(WebCore::AudioDestinationGStreamer::start): Set pipeline to
PLAYING, at the first run it will trigger the WAV parser and hence
the audio-sink plugging.
(WebCore::AudioDestinationGStreamer::stop): Pause the pipeline.

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: Added.

(getGStreamerMonoAudioCaps): Utility function to generate
GStreamer caps representing a single audio channel for a given
sample rate.
(webKitWebAudioGStreamerChannelPosition): Utility function to
convert AudioBus channel representations to GStreamer positional
audio channel values.
(webkit_web_audio_src_class_init): GObject configuration of the
GStreamer source element.
(webkit_web_audio_src_init): Initialization of the private data of
the element.
(webKitWebAudioSourceConstructed): Configure the GstBin elements
depending on the AudioBus layout.
(webKitWebAudioSourceFinalize): Clean up the GstBin and free private
data of the element.
(webKitWebAudioSourceSetProperty): GObject property setter.
(webKitWebAudioSourceGetProperty): GObject property getter.
(webKitWebAudioSourceLoop): GstTask used to pull data from the
AudioBus and push it as GstBuffers to the src pad of the element.
(webKitWebAudioSourceChangeState): Start or stop the above GstTask
depending on the asked state transition.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h: Added.
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: GstTask support in GRefPtr.

(WTF::adoptGRef):
(WTF::GstTask):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
5:45 AM Changeset in webkit [101137] by jknotten@chromium.org
  • 1 edit in branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt

Fix test expectations.

http://codereview.chromium.org/8682014/

5:45 AM Changeset in webkit [101136] by Simon Hausmann
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Stop leaking memory in string QWK2 API's
https://bugs.webkit.org/show_bug.cgi?id=72558

Patch by Oleg Romashin <romaxa@gmail.com> on 2011-11-17
Reviewed by Simon Hausmann.

WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
stay alive after destroying the API pointers.
This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
that will be around temporarily and correctly release the object.

  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::mouseDidMoveOverElement):

  • UIProcess/qt/QtDownloadManager.cpp:

(WebKit::qt_wk_didFailDownload):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::load):
(QtWebPageProxy::url):
(QtWebPageProxy::title):

5:35 AM Changeset in webkit [101135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add implementation considering ewk_tiled_backing_store's visible status.
https://bugs.webkit.org/show_bug.cgi?id=71791

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-11-24
Reviewed by Gustavo Noronha Silva.

In order to prevent rendering and pre-rendering while backing store is hidden,
its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(ewk_tiled_backing_store_add):

5:27 AM Changeset in webkit [101134] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably

Reviewed by Andreas Kling.

We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.

  • wtf/qt/MainThreadQt.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

5:07 AM Changeset in webkit [101133] by vestbo@webkit.org
  • 13 edits in trunk

[Qt] Get rid of the buildDirForSource() function in the build system

At some point the plan was to allow for running qmake on sub-trees
of the sources, into the top level build directory, but this is no
longer possible, so no reason to keep the convenience function around.

Reviewed by Simon Hausmann.

5:03 AM Changeset in webkit [101132] by Patrick Gansterer
  • 4 edits in trunk/Source

[CMake] Add missing source files
https://bugs.webkit.org/show_bug.cgi?id=73052

Reviewed by Andreas Kling.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

Add more generic files to the sources list and remove the EFL specific stuff.

  • CMakeLists.txt:
3:37 AM Changeset in webkit [101131] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704

Reviewed by Simon Hausmann.

Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.

  • wtf/qt/MainThreadQt.cpp:

(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):

1:47 AM Changeset in webkit [101130] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Fix ASSERTs added in r101082.

Rubber-Stamped by Martin Robinson.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Check for valid pointer before
GST_OBJECT_IS_FLOATING().

1:37 AM Changeset in webkit [101129] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=69738

Reviewed by Timothy Hatcher.

The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
is traversed with the Up/Down keys.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._filesSelectChanged):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.focus):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.focus):

1:10 AM Changeset in webkit [101128] by podivilov@chromium.org
  • 11 edits
    5 adds in trunk

Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
  • http/tests/inspector/compiler-source-mapping-debug.html: Added.
  • http/tests/inspector/resources/source-map.json:
  • http/tests/inspector/resources/source1.js:
  • http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

12:38 AM Changeset in webkit [101127] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash.
12:17 AM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
12:14 AM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
12:11 AM Changeset in webkit [101126] by pfeldman@chromium.org
  • 22 edits in trunk

Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead.
https://bugs.webkit.org/show_bug.cgi?id=73024

Source/WebCore:

We use it for the URL mostly, no need to create artificial resource for that upon
attaching to the existing page.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/HAREntry.js:

(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._pageEventTime):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._exportAll):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get displayName):
(WebInspector.Resource.prototype.get displayDomain):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._initDefaultSelection):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._addRecordToTimeline):

  • inspector/front-end/utilities.js:

(String.prototype.asParsedURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
  • inspector/debugger/watch-expressions-panel-switch.html:
  • inspector/extensions/extensions-events.html:
  • inspector/performance/resources/first-open-resources.html:
  • inspector/performance/resources/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

  • inspector/performance/resources/show-panel.html:
  • inspector/styles/styles-history.html:
12:01 AM Changeset in webkit [101125] by yurys@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: exceptions in shared workers should be logged to web inspector console
https://bugs.webkit.org/show_bug.cgi?id=73022

According to section "4.7 Runtime script errors" of Web Workers spec "For shared
workers, if the error is still not handled afterwards, or if the error occurred
while handling a previous script error, the error may be reported to the user."

This change adds uncaugh exceptions to the shared worker web inspector console.

Reviewed by Pavel Feldman.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::restore):

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::restore):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext):

  • inspector/InspectorInstrumentation.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:
  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.showWorkerTerminatedScreen):

  • inspector/front-end/inspector.js:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage): console messages are now added to
the worker console agent.
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:
Note: See TracTimeline for information about the timeline view.