Context Navigation

← Previous Period
Next Period →

Timeline

Jan 24, 2012:

11:58 PM Changeset in webkit [105852] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing tests.

platform/qt-wk2/Skipped:
platform/wk2/Skipped:

11:49 PM Changeset in webkit [105851] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.

platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

11:01 PM Changeset in webkit [105850] by rniwa@webkit.org

2 edits in trunk/Tools

Build fix. Trigger Chromium Mac Release (Perf) on new commits.

BuildSlaveSupport/build.webkit.org-config/config.json:

10:48 PM Changeset in webkit [105849] by rolandsteiner@chromium.org

16 edits
2 adds in trunk

windows.internals updates

Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore:

Implement registering of a <style> element with its parent element if the 'scoped' attribute is set.
Update the registration whenever the 'scoped' attribute is changed,
or the <style> element eneters or leaves the tree.

Also, extend windows.internals to allow for testing of the registration ref-counting.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/registering.html

WebCore.exp.in:
dom/Element.cpp:

(WebCore::Element::hasScopedHTMLStyleChild):
(WebCore::Element::numberOfScopedHTMLStyleChildren):
(WebCore::Element::registerScopedHTMLStyleChild):
(WebCore::Element::unregisterScopedHTMLStyleChild):

dom/Element.h:
dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::registerScopedHTMLStyleChild):
(WebCore::ElementRareData::unregisterScopedHTMLStyleChild):
(WebCore::ElementRareData::hasScopedHTMLStyleChild):
(WebCore::ElementRareData::numberOfScopedHTMLStyleChildren):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::parseMappedAttribute):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedIntoDocument):
(WebCore::HTMLStyleElement::removedFromDocument):
(WebCore::HTMLStyleElement::willRemove):

html/HTMLStyleElement.h:
testing/Internals.cpp:

(WebCore::Internals::numberOfScopedHTMLStyleChildren):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

Add symbols for windows.internals.numberOfScopedHTMLStyleChildren

Reviewed by Dimitri Glazkov.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

Tests that registration of <style scoped> with its parent is performed correctly
in various circumstances.

Reviewed by Dimitri Glazkov.

fast/css/style-scoped/registering-expected.txt: Added.
fast/css/style-scoped/registering.html: Added.

10:08 PM Changeset in webkit [105848] by rniwa@webkit.org

3 edits in trunk/Tools

WebKit needs public performance tests running on public bots
https://bugs.webkit.org/show_bug.cgi?id=10266

Reviewed by Adam Barth.

Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(UploadPerfTestResults):
(BuildAndPerfTestFactory):
(BuildAndPerfTestFactory.init):

9:27 PM Changeset in webkit [105847] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105843>
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

platform/KURL.h:

(WebCore::KURL::innerURL):

9:17 PM Changeset in webkit [105846] by vsevik@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium test fix.

src/js/Tests.js:

(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

7:28 PM Changeset in webkit [105845] by vangelis@chromium.org

7 edits
1 add in trunk/Source

Source/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76735

This is to add skipped layers to their RenderSurface's layer list so that they
are considered in the next update. Without this change, m_skipsDraw = false sticks
with the layer for the remainder of its lifetime.

Reviewed by James Robinson.

Tests: Unit test (TiledLayerChromiumTest.cpp)

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):

platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::skipsDraw):

Source/WebKit/chromium: Adding a test to verify that m_skipsDraw gets reset between frames for
tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=76735

Reviewed by James Robinson.

WebKit.gypi:
tests/FakeCCLayerTreeHostClient.h: Added.

(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
(WebCore::FakeCCLayerTreeHostClient::layout):
(WebCore::FakeCCLayerTreeHostClient::applyScrollAndScale):
(WebCore::FakeCCLayerTreeHostClient::createLayerTreeHostContext3D):
(WebCore::FakeCCLayerTreeHostClient::didRecreateGraphicsContext):
(WebCore::FakeCCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::FakeCCLayerTreeHostClient::didCompleteSwapBuffers):
(WebCore::FakeCCLayerTreeHostClient::scheduleComposite):

tests/LayerChromiumTest.cpp:
tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::skipsDraw):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

6:47 PM Changeset in webkit [105844] by haraken@chromium.org

6 edits in trunk/Source/WebCore

Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970

Reviewed by Adam Barth.

I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.

In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:

(0) Assume that there are A.idl, B.idl and C.idl.

(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.

(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.

(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...

We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.

No tests. No change in behavior.

bindings/scripts/CodeGenerator.pm:

(UpdateFile):

bindings/scripts/CodeGeneratorCPP.pm:

(WriteData):

bindings/scripts/CodeGeneratorJS.pm:

(WriteData):

bindings/scripts/CodeGeneratorObjC.pm:

(WriteData):

bindings/scripts/CodeGeneratorV8.pm:

(WriteData):

6:20 PM Changeset in webkit [105843] by ericu@chromium.org

6 edits in trunk/Source/WebCore

Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.

fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL): Add missing escaping of URL path.

page/SecurityOrigin.cpp:

(WebCore::extractInnerURL): Use innerURL member, if it's populated.

platform/KURL.h:

(WebCore::KURL::innerURL): Add innerURL member.

platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F / in paths; it's much more readable, and it's safe.

platform/KURLGooglePrivate.h:

(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

6:13 PM Changeset in webkit [105842] by ojan@chromium.org

2 edits in trunk/Tools

Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960

Reviewed by Adam Barth.

Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.init):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):

6:02 PM Changeset in webkit [105841] by barraclough@apple.com

4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Oliver Hunt.

Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.

wtf/MetaAllocator.cpp:

(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):

Track live handle objects in a map.

(WTF::MetaAllocator::release):

Removed support for handles with null m_allocator (no longer used).
Notify the tracker of handles being released.

(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):

Moved functionality out into MetaAllocator::release.

(WTF::MetaAllocatorHandle::shrink):

Removed support for handles with null m_allocator (no longer used).

(WTF::MetaAllocator::MetaAllocator):

Initialize m_tracker.

(WTF::MetaAllocator::allocate):

Notify the tracker of new allocations.

wtf/MetaAllocator.h:

(WTF::MetaAllocatorTracker::find):

Lookup a MetaAllocatorHandle based on an address inside the allocation.

(WTF::MetaAllocator::trackAllocations):

wtf/MetaAllocatorHandle.h:
- Remove unused createSelfManagedHandle/constructor.

(WTF::MetaAllocatorHandle::key):

Added, for use in RedBlackTree.

5:44 PM Changeset in webkit [105840] by mrowe@apple.com

9 edits
1 delete in trunk

Death to JavaScriptGlue.

Rubber-stamped by Geoffrey Garen.

Source/JavaScriptGlue: Removed.
Source/Makefile: Stop building JavaScriptGlue.

Tools:

BuildSlaveSupport/build-launcher-app:

(copyNightlyLauncher):

Scripts/build-webkit:
Scripts/do-file-rename:
Scripts/do-webcore-rename:
Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific

path in conjunction with a cross-platform path.
(ShouldBuildTest):

5:40 PM Changeset in webkit [105839] by Lucas Forschler

5 edits in tags/Safari-535.18.3/Source

Versioning.

5:38 PM Changeset in webkit [105838] by abarth@webkit.org

2 edits in trunk/LayoutTests

Mark test as flaky.

platform/chromium/test_expectations.txt:

5:19 PM Changeset in webkit [105837] by haraken@chromium.org

8 edits
2 adds in trunk/Tools

webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Reviewed by David Kilzer.

Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().

This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.

Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:

(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.

(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.

5:14 PM Changeset in webkit [105836] by Lucas Forschler

9 edits in tags/Safari-535.18.3/Source/WebKit2

Merged 105517 and 105806.

5:03 PM Changeset in webkit [105835] by dpranke@chromium.org

2 edits in trunk/Tools

webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963

Reviewed by Adam Barth.

r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.

Scripts/new-run-webkit-httpd:

(run):
(main):

4:56 PM Changeset in webkit [105834] by abarth@webkit.org

2 edits in trunk/Tools

garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962

Reviewed by Ojan Vafai.

Previously, you couldn't get up to the right and bottom pixels.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

4:48 PM Changeset in webkit [105833] by Lucas Forschler

1 copy in tags/Safari-535.18.3

New Tag.

4:27 PM Changeset in webkit [105832] by mrowe@apple.com

5 edits in trunk

Clear some bogus executable bits that r105828 set.

4:22 PM Changeset in webkit [105831] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Linux-specific overrides.

platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.

4:16 PM Changeset in webkit [105830] by eae@chromium.org

1520 edits
981 copies
87 deletes in branches/subpixellayout

Merging trunk changes up until 105803 into subpixel branch.

3:58 PM Changeset in webkit [105829] by enrica@apple.com

4 edits in trunk

WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Source/WebKit/mac:

The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.

Reviewed by Alexey Proskuryakov.

WebView/WebHTMLView.mm:

(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.

Tools:

Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.

Reviewed by Alexey Proskuryakov.

TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST):

3:53 PM Changeset in webkit [105828] by commit-queue@webkit.org

4 edits
2 adds in trunk

Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-24
Reviewed by David Hyatt.

Source/WebCore:

There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

rendering/RenderBlock.h:

(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

LayoutTests:

Adding a test that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.

fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added

3:51 PM Changeset in webkit [105827] by abarth@webkit.org

2 edits in trunk/LayoutTests

Mark these tests as flaky.

platform/chromium/test_expectations.txt:

3:48 PM Changeset in webkit [105826] by dcheng@chromium.org

11 edits
1 copy
1 add in trunk

[chromium] event.dataTransfer.types should not return "Text" or "URL"
https://bugs.webkit.org/show_bug.cgi?id=76218

Source/WebCore:

Per the spec, "Text" and "URL" are special values handled for IE compatibility reasons in
dataTransfer.setData() and dataTransfer.getData(). These values should not be exposed
elsewhere.

Reviewed by Tony Chang.

Test: fast/events/dropzone-005.html

platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):

platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

LayoutTests:

Reviewed by Tony Chang.

editing/pasteboard/dataTransfer-setData-getData-expected.txt:
fast/events/dropzone-002.html:
fast/events/dropzone-005-expected.txt: Added.
fast/events/dropzone-005.html: Modified from LayoutTests/fast/events/dropzone-002.html.
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac-wk2/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:

3:46 PM Changeset in webkit [105825] by dcheng@chromium.org

6 edits in trunk/Source/WebCore

Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946

Just a const-correctness change.

Reviewed by Tony Chang.

No new tests since no functionality changed.

dom/DataTransferItemList.h:

(DataTransferItemList):

platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::length):

platform/chromium/DataTransferItemListChromium.h:

(DataTransferItemListChromium):

platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::length):

platform/qt/DataTransferItemListQt.h:

(DataTransferItemListQt):

3:37 PM Changeset in webkit [105824] by inferno@chromium.org

1 edit
2 deletes in branches/chromium/963

Revert 105795 - Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019

TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271032

3:34 PM Changeset in webkit [105823] by abarth@webkit.org

5 edits
7 adds in trunk/LayoutTests

Update table image baselines after http://trac.webkit.org/changeset/105775.

platform/chromium-mac-leopard/fast/table/027-expected.png:
platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
platform/chromium-mac-snowleopard/fast/table/027-expected.png: Added.
platform/chromium-mac-snowleopard/fast/table/027-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.txt: Added.
platform/chromium-win/fast/css/min-width-with-spanned-cell-expected.png: Added.
platform/chromium-win/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
platform/chromium-win/fast/table/027-expected.png:
platform/chromium-win/fast/table/027-vertical-expected.png:

3:30 PM Changeset in webkit [105822] by abarth@webkit.org

1 edit
5 adds
2 deletes in trunk/LayoutTests

More tweaks after leviw's updating of Mac baselines.

platform/chromium-linux-x86/fast/multicol: Removed.
platform/chromium-linux/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.

3:27 PM WebKit Team edited by haraken@chromium.org

(diff)

3:26 PM Changeset in webkit [105821] by kerz@chromium.org

1 edit in branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt

fix branch test expectations

3:21 PM Changeset in webkit [105820] by tony@chromium.org

4 edits
2 adds in trunk

REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317

Reviewed by Darin Adler.

Source/WebCore:

Test: scrollbars/scroll-rtl-or-bt-layer.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.

LayoutTests:

platform/win/Skipped:
scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
scrollbars/scroll-rtl-or-bt-layer.html: Added.

3:14 PM Changeset in webkit [105819] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Fix all of the builds after r105812.

loader/EmptyClients.h: Move the #include in to the correct #if.

3:07 PM Changeset in webkit [105818] by inferno@chromium.org

4 edits
2 copies in branches/chromium/963

Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
clearRenderRegionRangeMap breakage fixed by replacing statements from https://trac.webkit.org/changeset/102234
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9113038

3:00 PM Changeset in webkit [105817] by inferno@chromium.org

4 edits
2 deletes in branches/chromium/963

Revert 105784 - Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9129033

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9290001

2:54 PM Changeset in webkit [105816] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.

runtime/JSObject.h:

2:52 PM Changeset in webkit [105815] by dslomov@google.com

4 edits in trunk/Source/WebCore

[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.

Reviewed by David Levin.

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrieveWindowForCallingContext):

bindings/v8/V8Proxy.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

2:39 PM Changeset in webkit [105814] by levin@chromium.org

3 edits in trunk/LayoutTests

Change reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=76942

Reviewed by Jian Li.

fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:

(onmessage):

platform/chromium/test_expectations.txt:

2:36 PM Changeset in webkit [105813] by ggaren@apple.com

9 edits in trunk/Source/WebCore

Updated bindings test expectations after my last patch.

Not reviewed.

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:

(WebCore::jsTestOverridingNameGetterPrototypeFunctionAnotherFunction):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

2:36 PM Changeset in webkit [105812] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Change dispatchIntent API to pure virtual in FrameLoaderClient.

The Windows compiler needs this to deal with the forward declaration
of WebCore::IntentRequest.
https://bugs.webkit.org/show_bug.cgi?id=76940

Patch by Greg Billock <gbillock@google.com> on 2012-01-24
Reviewed by Adam Barth.

loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchIntent):

loader/FrameLoaderClient.h:

2:31 PM Changeset in webkit [105811] by ggaren@apple.com

3 edits
2 adds in trunk

JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861

Source/JavaScriptCore:

Fixed two failing layout tests after my last patch.

Reviewed by Gavin Barraclough.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.

I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.

LayoutTests:

Reviewed by Gavin Barraclough.

Added a unit test for something I got wrong while writing this patch.

fast/js/add-to-primitive-expected.txt: Added.
fast/js/add-to-primitive.html: Added.

2:25 PM Changeset in webkit [105810] by inferno@chromium.org

3 edits
2 copies in branches/chromium/963

Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9271030

2:24 PM Changeset in webkit [105809] by haraken@chromium.org

2 edits in trunk/Source/WebCore

CodeGeneratorJS.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76922

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorJS.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated JS*.h and JS*.cpp do not change.

bindings/scripts/CodeGeneratorJS.pm:

(WriteData): Used UpdateFileIfChanged().

2:23 PM Changeset in webkit [105808] by inferno@chromium.org

15 edits
5 copies in branches/chromium/963

Merge 100473 - CSS 2.1 failure: border-collapse-offset-002.htm fails
BUG=109094

2:17 PM Changeset in webkit [105807] by tsepez@chromium.org

3 edits
2 deletes in branches/chromium/963

Revert 105788 - Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9117049

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271029

2:10 PM Changeset in webkit [105806] by Beth Dakin

2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=76928
Accelerated drawing should force compositing mode
-and corresponding-
<rdar://problem/10697417>

Reviewed by Simon Fraser.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:09 PM Changeset in webkit [105805] by haraken@chromium.org

2 edits in trunk/Source/WebCore

CodeGeneratorCPP.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76926

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorCPP.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
Manually confirm that when you add a new attribute to Element.idl,
the time-stamps of unrelated WebDOM*.h and WebDOM*.cpp do not change.

bindings/scripts/CodeGeneratorCPP.pm:

(WriteData): Used UpdateFileIfChanged().

2:04 PM Changeset in webkit [105804] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r105238.
http://trac.webkit.org/changeset/105238
https://bugs.webkit.org/show_bug.cgi?id=76943

Remove the assert text hack as it served its purpose.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

1:43 PM Changeset in webkit [105803] by haraken@chromium.org

2 edits in trunk/Source/WebCore

[Refactoring] In CodeGeneratorGObject.pm, merge
GeneratePrivateHeader() into WriteData()
https://bugs.webkit.org/show_bug.cgi?id=76923

Reviewed by Adam Barth.

This patch merges GeneratePrivateHeader() into WriteData(),
so that all code to output .h/.cpp is managed by WriteData(),
just like other CodeGenerator*.pm does.

No tests. No change in behavior.
Confirm that GTK/GObject build passes.

bindings/scripts/CodeGeneratorGObject.pm:

(Generate):
(WriteData): Copied GeneratePrivateHeader() to here.
Removed $hasLegacyParen, $hasRealParent and $hasParent
since they are not used.
(GenerateInterface):

1:38 PM Changeset in webkit [105802] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add expected results for test introduced in http://trac.webkit.org/changeset/105769

fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

1:38 PM Changeset in webkit [105801] by commit-queue@webkit.org

3 edits in trunk/Tools

Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
https://bugs.webkit.org/show_bug.cgi?id=76884

Patch by James Robinson <jamesr@chromium.org> on 2012-01-24
Reviewed by Adam Barth.

Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout.execute):

Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_rollout):
(SheriffIRCBotTest.test_revert):
(SheriffIRCBotTest.test_multi_rollout):
(SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

1:32 PM Changeset in webkit [105800] by dcheng@chromium.org

4 edits in trunk

dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925

Source/WebCore:

Per the HTML spec, we are supposed to normalize types during dropzone processing by
lowercasing them.

Reviewed by Tony Chang.

Tests: fast/events/dropzone-002.html

dom/Clipboard.cpp:

(WebCore::Clipboard::hasDropZoneType):

LayoutTests:

Reviewed by Tony Chang.

fast/events/dropzone-002.html: Update layout test to check case normalization as well.

1:31 PM Changeset in webkit [105799] by robert@webkit.org

1 edit
4 adds in trunk/LayoutTests

Qt and Gtk results for tests added in r105775

Unreviewed.

platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Added.
platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
platform/qt/fast/css/min-width-with-spanned-cell-expected.txt: Added.
platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.

1:27 PM Changeset in webkit [105798] by tsepez@chromium.org

5 edits in branches/chromium/963/Source/WebCore/loader

Merge 105226 - Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
BUG=108544
Review URL: https://chromiumcodereview.appspot.com/9283038

1:27 PM Changeset in webkit [105797] by haraken@chromium.org

4 edits in trunk/Tools

The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531

Reviewed by David Kilzer.

Previously, the cpp parser of prepare-ChangeLog could not detect a change
outside methods. Consider the following cpp file.

namespace N {
int a; this change does not appear on ChangeLog.
class C {

int b; this change does not appear on ChangeLog.
void f()
{

int c; this change appears on ChangeLog.

}
int d; this change does not appear on ChangeLog.

};
int e; this change does not appear on ChangeLog.
};

The previous prepare-ChangeLog outputs just methods in which a change is found:

(N::C::f):

This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
and methods in which a change is found:

(N):
(N::C):
(N::C::f):

Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp): Modified as described above.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.

(Class104):
(Class105):
(Class106):
(Class106::func32):
(Class106::func33):
(NameSpace3):
(NameSpace4):
(NameSpace5):
(NameSpace6):
(Class107):
(NameSpace5::NameSpace6::Class107::func34):

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

1:24 PM Changeset in webkit [105796] by haraken@chromium.org

3 edits in trunk/Tools

prepare-ChangeLog outputs warnings for top-level { ... } blocks
https://bugs.webkit.org/show_bug.cgi?id=75943

Reviewed by David Kilzer.

Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
because it does not distinguish '}' at the end of a subroutine
with '}' at the end of a if or for statement.

foo.pl:

if (1) {
}
for (@v) {
}

output:

nested functions found at top-level at foo.pl:2
nested functions found at top-level at foo.pl:4

This patch fixes the bug.

Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases. No change in the test results.

1:23 PM Changeset in webkit [105795] by tsepez@chromium.org

1 edit
2 copies in branches/chromium/963

Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019

1:22 PM Changeset in webkit [105794] by dslomov@google.com

2 edits in trunk/Source/WebKit/chromium

Unreviewed: removing WebWorker.h again after r105684.

WebKit.gyp:

1:20 PM Changeset in webkit [105793] by dpranke@chromium.org

2 edits in trunk/Tools

r105674 broke check-webkit-style for chromium's test_expectations.

Unreviewed, build fix.

We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_exepectations_path):

1:18 PM Changeset in webkit [105792] by inferno@chromium.org

1 edit
3 copies in branches/chromium/963

Merge 105769 - Crash when rendering -webkit-column-span.
BUG=105459
Review URL: https://chromiumcodereview.appspot.com/9129034

1:18 PM Changeset in webkit [105791] by mario@webkit.org

24 edits in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Don't expose functions for the ATK interfaces in header files.

Expose only the initialization function for each interface, and
use the generic functions from ATK interfaces where needed.

accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionDoAction): Made this function static.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
(webkitAccessibleActionInterfaceInit): Moved to the bottom.

accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all