⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 20, 2012:

11:54 PM Changeset in webkit [108317] by abarth@webkit.org
  • 2 edits in trunk/Tools

mastercfg_unittest.py fails without simplejson
​https://bugs.webkit.org/show_bug.cgi?id=79070

Reviewed by Csaba Osztrogonác.

Now that we require Python 2.6 (and higher) we can import json rather
than simplejson. We still need to use the simplejson name because
that's what the master.cfg script expects.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

11:51 PM Changeset in webkit [108316] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r108279

11:49 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
11:48 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:47 PM Changeset in webkit [108315] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108313

11:46 PM Changeset in webkit [108314] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108312

11:45 PM Changeset in webkit [108313] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108281.

Reviewed by Alejandro G. Castro.

  • tests/testwebplugindatabase.c:

(test_webkit_web_plugin_database_get_plugins): Update the description used
in the test.

11:44 PM Changeset in webkit [108312] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108278.

Reviewed by Alejandro G. Castro.

Now that WebCore is no longer stealing focus, we need to
adjust where we grab focus to ensure that it actually succeeds.

  • tests/testcopyandpaste.c:

(map_event_cb): No longer grab focus here.
(runPasteTestCallback): Grabbing focus here seems to be late enough in the process.

11:41 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:32 PM Changeset in webkit [108311] by abarth@webkit.org
  • 4 edits in trunk

Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
​https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
11:07 PM Changeset in webkit [108310] by abarth@webkit.org
  • 7 edits
    11 moves in trunk/Source/WebCore

Unite TextTrack-related files with their friends in WebCore/html/track
​https://bugs.webkit.org/show_bug.cgi?id=78941

Reviewed by Eric Seidel.

The code that supports <track> seems to be split between the
WebCore/html directory and the WebCore/html/track directory. This
patch unites this code in the WebCore/html/track directory.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/LoadableTextTrack.cpp: Removed.
  • html/LoadableTextTrack.h: Removed.
  • html/TextTrack.cpp: Removed.
  • html/TextTrack.h: Removed.
  • html/TextTrack.idl: Removed.
  • html/TextTrackCue.cpp: Removed.
  • html/TextTrackCue.h: Removed.
  • html/TextTrackCue.idl: Removed.
  • html/TextTrackCueList.cpp: Removed.
  • html/TextTrackCueList.h: Removed.
  • html/TextTrackCueList.idl: Removed.
  • html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
  • html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
  • html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
  • html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
  • html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
  • html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
  • html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
  • html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
  • html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
  • html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
  • html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.
10:49 PM Changeset in webkit [108309] by fpizlo@apple.com
  • 79 edits
    39 adds in trunk

JSC should be a triple-tier VM
​https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

  • bytecode/BytecodeConventions.h: Added.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/Opcode.cpp:

(JSC):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(PutByIdStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

  • heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

  • interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITExceptions.cpp:

(JSC::jitThrow):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JSInterfaceJIT.h:
  • llint: Added.
  • llint/LLIntCommon.h: Added.
  • llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

  • llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

  • llint/LLIntOfflineAsmConfig.h: Added.
  • llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

  • llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

  • llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

  • llint/LowLevelInterpreter.asm: Added.
  • llint/LowLevelInterpreter.cpp: Added.
  • llint/LowLevelInterpreter.h: Added.
  • offlineasm: Added.
  • offlineasm/armv7.rb: Added.
  • offlineasm/asm.rb: Added.
  • offlineasm/ast.rb: Added.
  • offlineasm/backends.rb: Added.
  • offlineasm/generate_offset_extractor.rb: Added.
  • offlineasm/instructions.rb: Added.
  • offlineasm/offset_extractor_constants.rb: Added.
  • offlineasm/offsets.rb: Added.
  • offlineasm/opt.rb: Added.
  • offlineasm/parser.rb: Added.
  • offlineasm/registers.rb: Added.
  • offlineasm/self_hash.rb: Added.
  • offlineasm/settings.rb: Added.
  • offlineasm/transform.rb: Added.
  • offlineasm/x86.rb: Added.
  • runtime/CodeSpecializationKind.h: Added.

(JSC):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSArray.h:

(JSC):
(JSArray):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSFunction.h:

(JSC):
(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

  • runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

  • runtime/JSString.h:

(JSC):
(JSString):

  • runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(LLInt):
(JSValue):

  • runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC):
(Structure):

  • runtime/StructureChain.h:

(JSC):
(StructureChain):

  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

  • wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

  • CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • DumpRenderTree/efl/CMakeLists.txt:
10:38 PM Changeset in webkit [108308] by benjamin@webkit.org
  • 18 edits
    1 copy
    3 deletes in trunk/Source

Get rid of the LocalizationStrategy
​https://bugs.webkit.org/show_bug.cgi?id=78324

Reviewed by Sam Weinig.

Source/WebCore:

Remove LocalizationStrategy and unify the localization behind
LocalizedStrings.h and LocalizedStrings.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DefaultLocalizationStrategy.cpp: Removed.
  • platform/DefaultLocalizationStrategy.h: Removed.
  • platform/LocalizationStrategy.h: Removed.
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h:

(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):

  • platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.

Source/WebKit/qt:

Move the localization code from PlatformStrategiesQt.cpp
to LocalizedStringsQt.cpp.

Get rid of LocalizationStrategy from PlatformStrategiesQt

  • WebCoreSupport/PlatformStrategiesQt.cpp:
  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/wince:

Remove a useless #include of LocalizationStrategy.h.

  • WebCoreSupport/PlatformStrategiesWinCE.h:
10:34 PM Changeset in webkit [108307] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out ​http://trac.webkit.org/changeset/108291
It completely broke the 32-bit JIT.

  • heap/CopiedAllocator.h:
  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.h:

(JSC::Heap::allocatorForObjectWithDestructor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

  • runtime/JSArray.cpp:

(JSC::storageSize):
(JSC):

  • runtime/JSArray.h:

(ArrayStorage):
(JSArray):

10:30 PM Changeset in webkit [108306] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r108259.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
10:23 PM Changeset in webkit [108305] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
​https://bugs.webkit.org/show_bug.cgi?id=79064

Reviewed by Hajime Morita.

[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.

Test: media/media-controller.html (No change in the test results.)

  • html/HTMLMediaElement.idl:
10:17 PM Changeset in webkit [108304] by barraclough@apple.com
  • 7 edits in trunk

Put should throw if prototype chain contains a readonly property.
​https://bugs.webkit.org/show_bug.cgi?id=79069

Reviewed by Oliver Hunt.

Currently we only check the base of the put, not the prototype chain.
Fold this check in with the test for accessors.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Updated to test all objects in the propotype chain for readonly properties.

(JSC::JSObject::putDirectAccessor):
(JSC::putDescriptor):

  • Record the presence of readonly properties on the structure.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.
  • runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.

(JSC::Structure::setContainsReadOnlyProperties):

  • Added.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(get shouldBeTrue):

  • Added test case.
10:15 PM Changeset in webkit [108303] by hayato@chromium.org
  • 11 edits in trunk/Source/WebCore

Use InsertinonPoint instead of HTMLContentElement.
​https://bugs.webkit.org/show_bug.cgi?id=78778

Reviewed by Hajime Morita.

Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
This is one of followup patches for r108207.

No new tests, no change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/NodeRenderingContext.h:

(WebCore):
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

  • dom/ShadowRoot.h:

(WebCore):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::select):

  • html/shadow/HTMLContentSelector.h:

(WebCore):
(HTMLContentSelection):
(WebCore::HTMLContentSelection::insertionPoint):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::selections):
(WebCore::InsertionPoint::hasSelection):
(InsertionPoint):

10:00 PM Changeset in webkit [108302] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

MathML internals - code clean-up for RenderMathMLSubSup
​https://bugs.webkit.org/show_bug.cgi?id=79063

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
easier to follow, I am first doing some simple code clean-up.

No new tests.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

  • There is no need to iterate over baseWrapper's children since it should have only one child, the base of the <msubsup>.
9:52 PM Changeset in webkit [108301] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Replace [V8Custom=DOMWindowNOP] with [V8Custom]
​https://bugs.webkit.org/show_bug.cgi?id=79062

Reviewed by Adam Barth.

[V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
This patch replaces it with [V8Custom].

No new tests. No change in behavior.

  • page/DOMWindow.idl:
9:28 PM Changeset in webkit [108300] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
​https://bugs.webkit.org/show_bug.cgi?id=79061

Reviewed by Adam Barth.

CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].

No tests. No change in behavior.

  • css/CSSStyleDeclaration.idl:
9:25 PM Changeset in webkit [108299] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk/LayoutTests

There is no complete test cases of optional arguments for MediaStream API and PeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=78578

Reviewed by Adam Barth.

  • fast/mediastream/peerconnection-AttributesMethod-expected.txt: Added.
  • fast/mediastream/peerconnection-AttributesMethod.html: Added.
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt: Added.
  • fast/mediastream/peerconnection-argument-types.html: Added.
  • fast/mediastream/peerconnection-removestream-expected.txt: Added.
  • fast/mediastream/peerconnection-removestream.html: Added.
  • fast/mediastream/script-tests/AttributesMethod.js: Added.
  • fast/mediastream/script-tests/argument-types.js: Added.
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js: Added.

Patch by Yanbin Zhang <​yanbin.zhang@intel.com> on 2012-02-20

9:21 PM Changeset in webkit [108298] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
​https://bugs.webkit.org/show_bug.cgi?id=79058

Reviewed by Adam Barth.

[EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].

No tests.

  • html/shadow/HTMLShadowElement.idl:
8:52 PM Changeset in webkit [108297] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

Replace [Callback=FunctionOnly] with [Callback]
​https://bugs.webkit.org/show_bug.cgi?id=79060

Reviewed by Adam Barth.

[Callback=FunctionOnly] is not implemented by any code generator.
This patch replaces it with [Callback].

No tests. No change in behavior.

  • Modules/intents/IntentResultCallback.idl:
  • Modules/intents/NavigatorIntents.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • mediastream/NavigatorMediaStream.idl:
  • mediastream/NavigatorUserMediaErrorCallback.idl:
  • mediastream/NavigatorUserMediaSuccessCallback.idl:
  • mediastream/PeerConnection.idl:
  • mediastream/SignalingCallback.idl:
  • page/PositionCallback.idl:
  • page/PositionErrorCallback.idl:
8:17 PM Changeset in webkit [108296] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=78920

Override two functions for text search highlight colors so that we can
provide platform specified colors.

Patch by Andy Chen <​andchen@rim.com> on 2012-02-17
Reviewed by Antonio Gomes.

No function change so no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):

  • platform/blackberry/RenderThemeBlackBerry.h:
8:12 PM Changeset in webkit [108295] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
  • platform/chromium/fast/js/string-capitalization-expected.txt:
  • platform/chromium/test_expectations.txt:
8:06 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
8:05 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
8:05 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:59 PM Changeset in webkit [108294] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108288

7:48 PM Changeset in webkit [108293] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

Default canvas backing store to be 1:1 with specified dimensions.
​https://bugs.webkit.org/show_bug.cgi?id=78971

Reviewed by Adam Barth.

Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in ​https://bugs.webkit.org/show_bug.cgi?id=73645

This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

7:24 PM Changeset in webkit [108292] by bashi@chromium.org
  • 2 edits in trunk/Tools

Update pywebsocket to 0.7.2
​https://bugs.webkit.org/show_bug.cgi?id=79066

This version includes vendor-prefixed deflate-frame extension support.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

7:20 PM Changeset in webkit [108291] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Implement fast path for op_new_array in the baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

  • heap/CopiedAllocator.h:

(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

  • heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to
(JSC::CopiedSpace::allocator):

  • heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): Just bails out to a stub call if we fail in any way on
the fast path.

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

7:19 PM Changeset in webkit [108290] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=78785

Main Contributors:
Daniel Bates <​dbates@rim.com>
Bryan Gislason <​bgislason@rim.com>
Akash Vaswani <​akvaswani@rim.com>
Dave Battista <​dbattista@rim.com>
Robin Cao <​robin.cao@torchmobile.com.cn>
Genevieve Mak <​gmak@rim.com>
Mike Fenton <​mifenton@rim.com>

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp: Added.
  • platform/blackberry/RenderThemeBlackBerry.h: Added.
7:10 PM Changeset in webkit [108289] by commit-queue@webkit.org
  • 4 edits
    1 move
    3 deletes in trunk/Source/WebCore

[GTK] [EFL] Collapse duplicate WebGL support code
​https://bugs.webkit.org/show_bug.cgi?id=78970

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

No new tests. This just cleans up duplicated code.

Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
directory. This is in preparation for the changes necessary to
connect WebGL to the TextureMapper AC.

  • GNUmakefile.list.am: Update source list.
  • PlatformEfl.cmake: Update source list.
  • platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
  • platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.
7:05 PM Changeset in webkit [108288] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Turn on requestAnimationFrame for release builds
​https://bugs.webkit.org/show_bug.cgi?id=79038

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on requestAnimationFrame by default.
6:53 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
6:51 PM Changeset in webkit [108287] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108277

6:48 PM Changeset in webkit [108286] by Martin Robinson
  • 5 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108278

6:45 PM Changeset in webkit [108285] by Martin Robinson
  • 12 edits in releases/WebKitGTK/webkit-1.8

Merging r108281

6:39 PM Changeset in webkit [108284] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging rr108248

6:37 PM Changeset in webkit [108283] by Martin Robinson
  • 4 edits
    4 deletes in releases/WebKitGTK/webkit-1.8

Merging r108237

6:35 PM Changeset in webkit [108282] by barraclough@apple.com
  • 6 edits in trunk

DefineOwnProperty fails with numeric properties & Object.prototype
​https://bugs.webkit.org/show_bug.cgi?id=79059

Reviewed by Oliver Hunt.

ObjectPrototype caches whether it contains any numeric properties (m_hasNoPropertiesWithUInt32Names),
calls to defineOwnProperty need to update this cache.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldThrow.Object.defineProperty):

6:27 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
6:19 PM Changeset in webkit [108281] by commit-queue@webkit.org
  • 12 edits in trunk

[UNIX] Plugin information fields are not interpreted as UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=78635

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

This is tested by a change to TestNetscapePlugin and expectations updates.

  • plugins/efl/PluginPackageEfl.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

Source/WebKit2:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin): Use String::fromUTF8.

Tools:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.

LayoutTests:

Update expectations to match the fact that TestNetscapePlugin is now
returning a Unicode character in the description field.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt/plugins/plugin-javascript-access-expected.txt:
6:16 PM Changeset in webkit [108280] by commit-queue@webkit.org
  • 3 edits
    3 moves
    3 adds in trunk/Tools

[GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
​https://bugs.webkit.org/show_bug.cgi?id=78935

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Move the TestNetscapePlugin headers to a more appropriate directory and update
the build files to match.

  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
  • GNUmakefile.am: Ditto.
6:12 PM Changeset in webkit [108279] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Does not build on GNU Hurd
​https://bugs.webkit.org/show_bug.cgi?id=79045

Patch by Pino Toscano <​pino@debian.org> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • wtf/Platform.h: define WTF_OS_HURD.
  • wtf/ThreadIdentifierDataPthreads.cpp: adds a band-aid fix

for the lack of PTHREAD_KEYS_MAX definition, with a value which
should not cause issues.

6:04 PM Changeset in webkit [108278] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] Web content oftens steals focus from other widgets
​https://bugs.webkit.org/show_bug.cgi?id=77791

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus): No longer do anything special to try
to grab "real" widget focus. This matches the behavior on Qt.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::setFocus): Moved the focus handling to here.
This ensures that behavior for plugins does not change.

Source/WebKit/gtk:

  • tests/testwebview.c: Added a WebKit1 test to verify this behavior.
6:02 PM Changeset in webkit [108277] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Geolocation support should be on by default
​https://bugs.webkit.org/show_bug.cgi?id=79037

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on geolocation support in release builds.
5:33 PM Changeset in webkit [108276] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Regression (108135) isOpaque() returns uninitialized variable.
​https://bugs.webkit.org/show_bug.cgi?id=79049

Reviewed by Noam Rosenthal.

isOpaque() should use the new m_flags instead of the old m_isOpaque.
No new tests. No new functionality.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

5:27 PM Changeset in webkit [108275] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
5:20 PM Changeset in webkit [108274] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][WK2] Clipping is broken
​https://bugs.webkit.org/show_bug.cgi?id=78677

It's not necessary to add a full-viewport rect to the scissor clip stack.
It creates a situation where if there's a clip in the page, we return to
the viewport clip instead of applying the WebView's clip we got from the
scenegraph.

Also, it's unnecessary to clip before we paint the layer's content, we should
only clip afterwards, before painting the children.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::size):
(WebCore::scissorClip):
(WebCore):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

5:15 PM Changeset in webkit [108273] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Layers and tiles appear to have missing pixels in their right/bottom borders
​https://bugs.webkit.org/show_bug.cgi?id=78961

The relativeSize member should point to one pixel before the edge, since it's used
by glVertexAttribPointer, which takes edge points and not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new funcionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):

5:05 PM Changeset in webkit [108272] by commit-queue@webkit.org
  • 17 edits
    11 adds in trunk

.: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Add Implementation for the Vibration API to the WebKit-EFL port.
​http://dev.w3.org/2009/dap/vibration/

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_VIBRATION feature.
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

​http://dev.w3.org/2009/dap/vibration/
This patch implements navigator.webkitvibrate() API.
This API operates differently depending upon a given parameter:

  1. It cancels vibration when given 0 or [].
  2. It gives a vibration duration in milliseconds when given as a single integer value.
  3. It gives a vibration pattern when given as an integer array. For instance, [1000 300 1000] generates a vibration of 1000ms followed by 300ms of idle time, and then creates another vibration of 1000ms.

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Test: fast/dom/navigator-vibration.html

  • CMakeLists.txt:
  • Modules/vibration/NavigatorVibration.cpp: Added.

(WebCore):
(WebCore::NavigatorVibration::NavigatorVibration):
(WebCore::NavigatorVibration::~NavigatorVibration):
(WebCore::NavigatorVibration::webkitVibrate):
Add webkitVibrate method to get an array or single integer parameter for vibrating.
They check vibration is activated in the platform, and then call vibrate() in the Vibration class.

  • Modules/vibration/NavigatorVibration.h: Added.

(WebCore):
(NavigatorVibration):

  • Modules/vibration/NavigatorVibration.idl: Added.
  • Modules/vibration/Vibration.cpp: Added.

This class implements the entire vibration logic.
(WebCore):
(WebCore::Vibration::Vibration):
(WebCore::Vibration::~Vibration):
(WebCore::Vibration::create):
(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):
(WebCore::Vibration::supplementName):
(WebCore::Vibration::isActive):
(WebCore::provideVibrationTo):

  • Modules/vibration/Vibration.h: Added.

(WebCore):
(Vibration):
(WebCore::Vibration::from):

  • Modules/vibration/VibrationClient.h: Added.

vibrate() and cancelVibrate() need to be implemented in the VibrationClient.
(WebCore):
(VibrationClient):
(WebCore::VibrationClient::~VibrationClient):

Source/WebKit/efl: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Implementation for the Vibration API feature to the EFL-port layer.
​http://dev.w3.org/2009/dap/vibration/
There are two methods for vibration API.

  • vibrate : Vibrate device for receiving as a parameter.
  • cancelVibrate : Cancel current vibration.
  • CMakeListsEfl.txt:
  • WebCoreSupport/VibrationClientEfl.cpp: Added.

(WebCore):
(WebCore::VibrationClientEfl::VibrationClientEfl):
(WebCore::VibrationClientEfl::vibrate):
(WebCore::VibrationClientEfl::cancelVibration):
(WebCore::VibrationClientEfl::vibrationDestroyed):

  • WebCoreSupport/VibrationClientEfl.h: Added.

(WebCore):
(VibrationClientEfl):
(WebCore::VibrationClientEfl::~VibrationClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • Scripts/build-webkit: Enable ENABLE_VIBRATION feature.

LayoutTests: Add a new test case for the Vibration API.
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • fast/dom/navigator-vibration-expected.txt: Added.
  • fast/dom/navigator-vibration.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
4:57 PM Changeset in webkit [108271] by yutak@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r108263.
​http://trac.webkit.org/changeset/108263
​https://bugs.webkit.org/show_bug.cgi?id=77856

Broke Chromium Windows build.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):

  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::isStereo):
(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

4:25 PM Changeset in webkit [108270] by rniwa@webkit.org
  • 6 edits in trunk

Move more logic from handler classes to model classes and add unit tests
​https://bugs.webkit.org/show_bug.cgi?id=78989

Reviewed by Hajime Morita.

Extracted various functions from CreateHandler, ReportHanlder, and RunsHanlder to model classes
in order to unit-test them, added DataStoreTestsBase to reduce the code duplication in tests,
and added a whole bunch of unit tests in models_unittest.py.

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_branch):
(CreateHandler._create_platform):

  • Websites/webkit-perf.appspot.com/models.py:

(_create_if_possible):
(_create_if_possible.execute):
(Branch):
(Branch.create_if_possible):
(Platform):
(Platform.create_if_possible):
(Build):
(Build.get_or_insert_from_log):
(Test):
(Test.update_or_insert):
(Test.update_or_insert.execute):
(TestResult):
(TestResult.get_or_insert_from_parsed_json):
(TestResult.get_or_insert_from_parsed_json._float_or_none):
(TestResult.generate_runs):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase):
(DataStoreTestsBase.assertThereIsNoInstanceOf):
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase.assertEqualUnorderedList):
(HelperTests):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder):
(BranchTests):
(BranchTests.test_create_if_possible):
(PlatformTests):
(PlatformTests.test_create_if_possible):
(BuilderTests):
(_create_some_builder):
(BuildTests):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestResultTests):
(TestResultTests._create_build):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests._create_results):
(TestResultTests.test_generate_runs):
(ReportLogTests):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):
(RunsHandler.post):

4:18 PM Changeset in webkit [108269] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

3:49 PM Changeset in webkit [108268] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Undoing accidental changes

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

3:42 PM Changeset in webkit [108267] by mhahnenberg@apple.com
  • 11 edits
    1 add in trunk/Source/JavaScriptCore

Factor out allocation in CopySpace into a separate CopyAllocator
​https://bugs.webkit.org/show_bug.cgi?id=78610

Reviewed by Oliver Hunt.

Added a new CopyAllocator class, which allows us to do allocations without
having to load the current offset and store the current offset in the current
block. This change will allow us to easily do inline assembly in the JIT for
array allocations.

(JSC):
(CopiedAllocator):
(JSC::CopiedAllocator::currentBlock):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::allocate):
(JSC::CopiedAllocator::fitsInCurrentBlock):
(JSC::CopiedAllocator::wasLastAllocation):
(JSC::CopiedAllocator::startedCopying):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::currentUtilization):
(JSC::CopiedAllocator::resetLastAllocation):

  • heap/CopiedBlock.h:

(CopiedBlock):

  • heap/CopiedSpace.cpp: Moved some stuff from CopiedSpaceInlineMethods to here because we

weren't really getting any benefits from having such big functions in a header file.
(JSC::CopiedSpace::CopiedSpace):
(JSC):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::getFreshBlock):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::allocateFromBlock):

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

  • heap/HeapBlock.h:

(HeapBlock):

3:39 PM WebKitGTK/1.8.x edited by kov@webkit.org
chrome version update merged (diff)
3:38 PM Changeset in webkit [108266] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging ​http://trac.webkit.org/changeset/108264

3:37 PM Changeset in webkit [108265] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix Visual Studio 2010 build.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

3:22 PM Changeset in webkit [108264] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Needs to claim being a more up-to-date Chrome
​https://bugs.webkit.org/show_bug.cgi?id=79044

Reviewed by Martin Robinson.

  • webkit/webkitwebsettings.cpp:

(chromeUserAgent): update the version of Chrome we claim to be
to avoid warnings from sites such as Wordpress saying that our
browser is outdated.

3:16 PM WebKitGTK/1.8.x edited by kov@webkit.org
Adding to proposed merges [GTK] Needs to claim being a more up-to-date … (diff)
2:10 PM Changeset in webkit [108263] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Have the DynamicsCompressorNode support multi-channel data
​https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-02-20
Reviewed by Chris Rogers.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

2:02 PM Changeset in webkit [108262] by commit-queue@webkit.org
  • 11 edits in trunk

RenderMathMLRow::baselinePosition() only if linePositionMode == PositionOnContainingLine
​https://bugs.webkit.org/show_bug.cgi?id=79039

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

Source/WebCore:

RenderMathMLRow::baselinePosition() is actually unnecessary, but I am deleting it in two
steps. First we add a guard to restrict it to the intended PositionOnContainingLine
case, leaving PositionOfInteriorLineBoxes to a superclass, RenderBlock. This removes
some randomness, and tightens up the results of four existing test files.

Test: mathml/presentation/row.xhtml, fenced.xhtml, mo.xhtml, and mo-stretch.html

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

LayoutTests:

  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
1:55 PM Changeset in webkit [108261] by jonlee@apple.com
  • 11 edits in trunk/Source/WebCore

HTML input file control "No File Selected" needs more room in some languages
​https://bugs.webkit.org/show_bug.cgi?id=32366
<rdar://problem/4481028>

Reviewed by David Hyatt.

The patch exposes a function to return the "no file(s) selected" label text.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListDefaultLabel): Added to expose the text for the label in
file upload controls when nothing has been selected.
(WebCore::RenderTheme::fileListNameForWidth): Refactor to use fileListDefaultLabel().

  • rendering/RenderTheme.h: Change fileListNameForWidth() to be a const function.
  • rendering/RenderThemeMac.h: Update fileListNameForWidth() to be a const function for

platform implementations.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Refactor to use fileListDefaultLabel().

Update fileListNameForWidth() to be a const function for platform implementations.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/qt/RenderThemeQt.h:
  • platform/qt/RenderThemeQt.cpp:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Change the calculation
of the max preferred logical width. Calculate the length of the "no file(s) selected" text,
and include the button and after-button margin. Take the max of that and the original
default width, which was a string of 34 (defaultWidthNumChars) "0"'s, in the case that the
label text is too short.

1:52 PM Changeset in webkit [108260] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Rubber stamped by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

  • Errk, remove dead code from end of function.
1:14 PM Changeset in webkit [108259] by barraclough@apple.com
  • 33 edits in trunk

Move special proto property to Object.prototype
​https://bugs.webkit.org/show_bug.cgi?id=78409

Reviewed by Oliver Hunt.

Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • No need to prohibit functions named proto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • Add proto accessor to Object.prototype.
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

  • Definition of the proto accessor functions.
  • runtime/JSGlobalObjectFunctions.h:
    • Declaration of the proto accessor functions.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.

(JSC::JSObject::putDirectAccessor):

  • Track on the structure whether an object contains accessors other than one for proto.

(JSC::JSObject::defineOwnProperty):

  • No need to prohibit definition of own properties named proto.
  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

  • Remove the special handling for proto.

(JSC::JSValue::get):

  • Remove the special handling for proto.
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • Remove the special handling for proto.
  • runtime/JSValue.h:

(JSValue):

  • Made synthesizePrototype public (this may be needed by the proto getter).
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • Perform the security check & call prototype() directly.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
  • runtime/Structure.h:

(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):

  • expose allowsAccessFrom check to JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • expose allowsAccessFrom check to JSC.

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
    • Update results
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
    • proto is now a property of Object Prototype.
  • fast/js/script-tests/cyclic-prototypes.js:
    • setting an object's prototype to null removes proto setter, future usage won't set prototype.
  • fast/js/script-tests/parser-syntax-check.js:
    • Allow functions named proto
  • fast/js/script-tests/preventExtensions.js:
    • Setting proto should not throw.
  • fast/js/script-tests/prototypes.js:
    • Objects may contained own properties named proto, add new test cases.
1:11 PM Changeset in webkit [108258] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Fix PLATFORM() define for Windows.

Define WTF_PLATFORM_WIN instead of WTF_PLATFORM_WINDOWS.

  • Source/cmake/OptionsWindows.cmake:
12:43 PM Changeset in webkit [108257] by benjamin@webkit.org
  • 5 edits
    2 adds in trunk

Make JSCSSStyleDeclaration work directly with CSS Property ID
​https://bugs.webkit.org/show_bug.cgi?id=79014

Reviewed by Geoffrey Garen.

Source/WebCore:

Previously, accessing the CSS property was done by converting from
the JavaScript name to the CSS name, then converting that name to a lowercase
character array, and finally getting the CSS property ID.

This patch cut the indirection and make the code go directly from the
JavaScript name conversion to the CSS property ID.

This improves the performance mainly due to the following:
-avoid dynamic memory allocation
-cut the conversion early when possible
-do not parse the string twice
The previous fast-path optimization was removed because it is no longer
necessary with this change.

The improvement are the following:
-previous fast-path: no change
-previous slow-path: ~3 times faster

Test: fast/dom/CSSStyleDeclaration/access-longest-css-property.html
This just test the edge case of CSSPropertyName.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::writeWebKitPrefix):
(WebCore::writeEpubPrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore):
(WebCore::cssPropertyNameIOSAliasing):

  • css/CSSParser.h:

(WebCore):

LayoutTests:

  • fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/access-longest-css-property.html: Added.
11:26 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
11:15 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
11:03 AM Changeset in webkit [108256] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Updated Localizable.strings after r107440.

Rubber-stamped by Joseph Pecoraro.

  • English.lproj/Localizable.strings:
11:00 AM Changeset in webkit [108255] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

Unreviewed gardening after r108226.
Skip tests because ENABLE(SHADOW_DOM) is disabled on these platforms.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
11:00 AM Changeset in webkit [108254] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108250

10:59 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:58 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:49 AM Changeset in webkit [108253] by Nate Chapin
  • 2 edits in branches/chromium/963/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
​https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=Nate Chapin
Review URL: ​https://chromiumcodereview.appspot.com/9424038

10:49 AM Changeset in webkit [108252] by msaboff@apple.com
  • 5 edits in trunk

Update toLower and toUpper tests for Unicode 6.1 changes
​https://bugs.webkit.org/show_bug.cgi?id=78923

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • tests/mozilla/ecma/String/15.5.4.11-2.js: Updated the test

to handle a third set of results for updated Unicode 6.1
changes.
(getTestCases):
(TestCaseMultiExpected):
(writeTestCaseResultMultiExpected):
(getTestCaseResultMultiExpected):
(test):
(GetUnicodeValues):
(DecimalToHexString):

LayoutTests:

  • fast/js/script-tests/string-capitalization.js: Updated the test

to handle a new set of characters that have different results depending
on what version of Unicode the platform supports. The tests work
for Unicode 5.0 through 6.1.
(createExpected):

  • fast/js/string-capitalization-expected.txt:
10:46 AM Changeset in webkit [108251] by Nate Chapin
  • 2 edits in branches/chromium/1025/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
​https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=Nate Chapin
Review URL: ​https://chromiumcodereview.appspot.com/9424037

10:46 AM Changeset in webkit [108250] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
​https://bugs.webkit.org/show_bug.cgi?id=79036

Reviewed by Martin Robinson.

This looks like a bug in gobject. Initializing the WebProcess
before creating the soup session seems to fix the problem. It's
actually a workaround, but initializing the WebProcess as sson as
possible it's a good idea in any case.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

10:43 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
10:35 AM Changeset in webkit [108249] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

MathML internals - remove nonOperatorHeight(), hasBase()
​https://bugs.webkit.org/show_bug.cgi?id=78977

Source/WebCore:

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

Stretchy operators, including embellished ones, should stretch to the largest height of
the non-stretchy items in the same explicit or implicit <mrow>.
RenderMathMLRow::layout() used to use hasBase(), isRenderMathMLOperator(), and
nonOperatorHeight() to approximate this height. We now use unembellishedOperator() to
improve this approximation, while also simplifying the code. More plainly, the code used
to skip all operators when estimating this height, instead of just the stretchy ones. We
continue to do that for now, but we more accurately skip all embellished operators
(using our currently implemented approximate definition of this), and use the simple and
true height of the remaining items. In case all items in the row are stretchy,
style()->fontSize() is better than using whatever heights these items currently happen
to be stretched to.

Test: mathml/presentation/mo-stretch.html, and many existing tests

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::unembellishedOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests:

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

More tests with multiple embellished stretchy and non-stretchy operators will be added
later, when code is added to more precisely handle such cases.

  • mathml/presentation/mo-stretch.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Added.
9:57 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
9:34 AM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
9:24 AM Changeset in webkit [108248] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Stop the committer timer when the page is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=78907

Reviewed by Adam Roben.

We don't want the committer timer to fire after the scrolling tree has been invalidated,
so stop the committer timer to prevent it from firing and trying to access the scrolling tree.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):

9:11 AM Changeset in webkit [108247] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Allow compiling FileSystem without CoreFoundation.
​https://bugs.webkit.org/show_bug.cgi?id=79032

Reviewed by Adam Roben.

Add #if USE(CF) around code using the CoreFoundation functions.

  • platform/FileSystem.h:
  • platform/win/FileSystemWin.cpp:
8:57 AM Changeset in webkit [108246] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] run-qtwebkit-tests doesn't consider timeouts as failures
​https://bugs.webkit.org/show_bug.cgi?id=71816

RunQtAPITests will notify if a timeout occurs during testing.
Added unittest to the master.cfg

Patch by János Badics <​dicska@gmail.com> on 2012-02-20
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests.evaluateCommand):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunQtAPITestsTest):
(RunQtAPITestsTest.assertResults):
(RunQtAPITestsTest.test_timeout):
(test_success):
(test_failure):
(test_timeout_and_failure):

8:50 AM Changeset in webkit [108245] by commit-queue@webkit.org
  • 1 edit
    7 adds in trunk/Source/WebCore

[BlackBerry] Upstream the first few files in platform/graphics/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=79023

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/FloatPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatPoint::FloatPoint):
(WebCore::FloatPoint::operator BlackBerry::Platform::FloatPoint):

  • platform/graphics/blackberry/FloatRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::operator BlackBerry::Platform::FloatRect):

  • platform/graphics/blackberry/FloatSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatSize::FloatSize):
(WebCore::FloatSize::operator BlackBerry::Platform::FloatSize):

  • platform/graphics/blackberry/IntPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntPoint::IntPoint):
(WebCore::IntPoint::operator BlackBerry::Platform::IntPoint):

  • platform/graphics/blackberry/IntRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator BlackBerry::Platform::IntRect):

  • platform/graphics/blackberry/IntSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntSize::IntSize):
(WebCore::IntSize::operator BlackBerry::Platform::IntSize):

8:43 AM Changeset in webkit [108244] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

2012-02-19 Antonio Gomes <​agomes@rim.com>

All default video/audio control elements should be rect-hit testable (Part II)
PR #139518 / MKS_3005538

Reviewed by George Staikos.

Add HTMLInputElement::isMediaControlElement as a criteria
to consider a element as clickable.

Note that is should be only used while in the "ClickableByDefault"
phase of FatFingers.

  • WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::isElementClickable):
8:40 AM Changeset in webkit [108243] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WIN] Share openTemporaryFile with WinCE
​https://bugs.webkit.org/show_bug.cgi?id=58750

Reviewed by Adam Roben.

Use pathByAppendingComponent instead of PathCombine to share the
code with WinCE. Also use the wide version of Windows functions.

  • platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

7:23 AM Changeset in webkit [108242] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:19 AM WebKitIDL edited by haraken@chromium.org
(diff)
7:11 AM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
7:02 AM Changeset in webkit [108241] by commit-queue@webkit.org
  • 16 edits
    6 adds in trunk

Source/WebCore: Added code to support dispatching of missed cues in case of normal playback
and event sorting in case of simultaneous event triggering.

<track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
​https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <​victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

Tests: media/track/track-cues-missed.html

media/track/track-cues-sorted-before-dispatch.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Added initialization code
for newly added state variables.
(WebCore::trackIndexCompare): Static boolean compare function between
the index of two tracks.
(WebCore):
(WebCore::eventTimeCueCompare): Static boolean compare function between
events associated with text track cues.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Added code to
sort the events associated with text track cues before dispatching.
Each step from the specification is commented within the code.
(WebCore::HTMLMediaElement::finishSeek): Added a boolean variable that
is needed within the text track update function, to know whether a seek
event has occured before or not.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Moved the update
call for text tracks at the beginning of the function instead of the end.
'ended' events for video should be dispatched after track specific events.

  • html/HTMLMediaElement.h: Added variables to keep

state information required by the text track update algorithm (last time
the algorithm was run, and whether a seeking event has occured)
(HTMLMediaElement):

  • html/LoadableTextTrack.cpp: Refactored fireCueChangeEvent method

(WebCore::LoadableTextTrack::fireCueChangeEvent): The method dispatches a
synchronous cue change event for the track element.

  • html/LoadableTextTrack.h:

(LoadableTextTrack):

  • html/TextTrack.cpp: Modified the fireCueChange method, cached track index.

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::trackIndex): Cached the track index.
(WebCore):
(WebCore::TextTrack::invalidateTrackIndex): Invalidates the track. Used
when a new track is added in a TextTrackList instance.

  • html/TextTrack.h:

(TextTrack):
(WebCore::TextTrack::fireCueChangeEvent): The fireCueChangeEvent has been changed,
as events need to be fired asyncronously.

  • html/TextTrackCue.cpp: Added internal variables to keep the current index

position in the track cue order. This is invalidated when an element is
inserted before.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueIndex): Getter for the cueIndex.
(WebCore):
(WebCore::TextTrackCue::invalidateCueIndex): Invalidates the currently stored
cue index.
(WebCore::TextTrackCue::dispatchEvent): Event dispatching is done asynchronously
now. This should be the only method used for event dispatching.
(WebCore::TextTrackCue::setIsActive): The setIsActive method no longer dispatches
events, but rather just changes the m_isActive variable.

  • html/TextTrackCue.h:

(TextTrackCue):

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::getCueIndex): Retrieves the cue index, in the track cue
order, of a given cue.
(WebCore):
(WebCore::TextTrackCueList::add): Modified the add method such that all the next cue
indexes are invalidated.
(WebCore::TextTrackCueList::invalidateCueIndexes): Invalidates all cue indexes starting
with a specific position.

  • html/TextTrackCueList.h:

(TextTrackCueList):

  • html/track/TextTrackList.cpp:

(TextTrackList::getTrackIndex): Retrieves the track index position.
(TextTrackList::append): Added method for invalidating the text track index in case of
changing the list contents.

  • html/track/TextTrackList.h:

(TextTrackList):

LayoutTests: <track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
​https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <​victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/missed-cues.vtt: Added.
  • media/track/captions-webvtt/sorted-dispatch.vtt: Added.
  • media/track/track-cues-cuechange-expected.txt: This test had to be changed because

the synchronous dispatch of the events against the HTMLTrackElement doesn't mean that
the text track actually has any active cues at the dispatch moment.

  • media/track/track-cues-cuechange.html: Changed tests structure to guide the entering and

exit events according to the asynchronous dispatch done by TextTrack.

  • media/track/track-cues-missed-expected.txt: Added.
  • media/track/track-cues-missed.html: Added.
  • media/track/track-cues-sorted-before-dispatch-expected.txt: Added.
  • media/track/track-cues-sorted-before-dispatch.html: Added.
6:54 AM Changeset in webkit [108240] by bashi@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

[WebSocket] Move WebSocketChannel::FrameData into a separate header file
​https://bugs.webkit.org/show_bug.cgi?id=78682

Extract WebSocketChannel::FrameData as WebSocketFrame. This brings
flexibility to add classes which want to do something for
incoming/outgoing frames (e.g. compression/decompression).

Reviewed by Kent Tamura.

No new tests. No behavior change.

  • GNUmakefile.list.am: AddedWebSocketFrame.h
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketChannel.cpp: Modified to use WebSocketFrame instead of FrameData

(WebCore):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::appendMaskedFramePayload): Added.
(WebCore::makeFrameData): Added.
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h: Removed FrameData.

(WebSocketChannel):
(QueuedFrame):

  • websockets/WebSocketFrame.h: Added.

(WebCore):
(WebSocketFrame):
(WebCore::WebSocketFrame::isNonControlOpCode):
(WebCore::WebSocketFrame::isControlOpCode):
(WebCore::WebSocketFrame::isReservedOpCode):
(WebCore::WebSocketFrame::WebSocketFrame):

6:53 AM Changeset in webkit [108239] by Adam Roben
  • 2 edits in trunk/Source/WebCore

32-bit build fix

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::setRawValue): Explicitly cast long long to int, since they
are different widths in 32-bit.

6:51 AM Changeset in webkit [108238] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Clang build fix

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willModifyDOMAttr): Removed unused parameter.

6:13 AM WebKitIDL edited by haraken@chromium.org
(diff)
6:03 AM Changeset in webkit [108237] by vsevik@chromium.org
  • 4 edits
    4 deletes in trunk

Unreviewed manual rollout of r107970 which breaks table column widths
updates from javascript (e.g. inspector's network panel).

Source/WebCore:

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Removed.
  • css2.1/20110323/fixed-table-layout-013.htm: Removed.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Removed.
  • css2.1/20110323/fixed-table-layout-015.htm: Removed.
6:02 AM WebKitIDL edited by haraken@chromium.org
(diff)
5:42 AM Changeset in webkit [108236] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Inconsistent alignment of non-parsed properties (having an exclamation mark)
​https://bugs.webkit.org/show_bug.cgi?id=79028

Reviewed by Yury Semikhatsky.

  • inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

5:11 AM Changeset in webkit [108235] by apavlov@chromium.org
  • 9 edits in trunk

Web Inspector: DOMAttrModified should not be fired if the attribute value remains the same
​https://bugs.webkit.org/show_bug.cgi?id=79025

Reviewed by Pavel Feldman.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::willModifyAttribute):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::willModifyDOMAttr):
(WebCore):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):

LayoutTests:

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:
5:10 AM WebKitIDL edited by haraken@chromium.org
(diff)
5:00 AM Changeset in webkit [108234] by wingo@igalia.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog from last commit.

  • ChangeLog: Quick fix to date and email address.
4:49 AM Changeset in webkit [108233] by wingo@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

2012-02-120 Andy Wingo <​wingo@pobox.com>

Remove unused features from CodeFeatures
​https://bugs.webkit.org/show_bug.cgi?id=78804

Reviewed by Gavin Barraclough.

  • parser/Nodes.h:
  • parser/ASTBuilder.h:

(JSC::ClosureFeature):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::usesClosures):
Remove "ClosureFeature". Since we track captured variables more
precisely, this bit doesn't do us any good.

(JSC::AssignFeature):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
(JSC::ASTBuilder::usesAssignment):
Similarly, remove AssignFeature. It is unused.

4:49 AM EFLWebKit edited by dominik.rottsches@intel.com
libsoup version. (diff)
4:26 AM WebKit Team edited by wingo@igalia.com
fix markup (diff)
4:26 AM WebKit Team edited by wingo@igalia.com
add myself as a committer (diff)
4:25 AM Changeset in webkit [108232] by commit-queue@webkit.org
  • 22 edits in trunk/Source/WebKit2

[Qt][WK2] Implement proxy authentication handling.
​https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-20
Reviewed by Simon Hausmann.

This patch implements the proxy authentication handling
for the Qt port in a similar matter to the http authentication
implementation.

Since there is a need to pass the proxy port, which is of type uint16_t,
from the WebProcess to the UIProcess, an encoder and a decoder for
this type was added because it did not exist.

The message that was added to the WebPageProxy is called synchronously
as this is needed by the implementation of the network access manager
and has also been implemented this way already for the http
authentication.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeUInt16):
(CoreIPC):

  • Platform/CoreIPC/ArgumentDecoder.h:

(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::encodeUInt16):
(CoreIPC):

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::proxyAuthenticationRequiredRequest):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDialogRunner.cpp:

(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::hostname):
(ProxyAuthenticationDialogContextObject::port):
(ProxyAuthenticationDialogContextObject::prefilledUsername):
(ProxyAuthenticationDialogContextObject::accept):
(ProxyAuthenticationDialogContextObject::reject):
(QtDialogRunner::initForProxyAuthentication):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleProxyAuthenticationRequiredRequest):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeUInt16):
(WebKit):

  • WebProcess/WebPage/DecoderAdapter.h:

(DecoderAdapter):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeUInt16):
(WebKit):

  • WebProcess/WebPage/EncoderAdapter.h:

(EncoderAdapter):

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):
(WebKit):

  • WebProcess/qt/QtNetworkAccessManager.h:

(QtNetworkAccessManager):

4:16 AM Changeset in webkit [108231] by wingo@igalia.com
  • 2 edits in trunk/Tools

Add wingo as a committer.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py: Add myself to the

committers list.

4:14 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
4:13 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
3:44 AM Changeset in webkit [108230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Correct a typo error in ScrollingCoordinator.h
​https://bugs.webkit.org/show_bug.cgi?id=79012

Patch by Kwonjin Jeong <​gram@company100.net> on 2012-02-20
Reviewed by Andreas Kling.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

2:50 AM Changeset in webkit [108229] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] box-shadow and -webkit-box-shadow properties are not considered color-aware
​https://bugs.webkit.org/show_bug.cgi?id=78988

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSKeywordCompletions.js:
2:47 AM Changeset in webkit [108228] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Forms] Spin buttons of number input type should fire both input and change event
​https://bugs.webkit.org/show_bug.cgi?id=75067

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch makes spin button in number input field clicks to fire input and change events as described in WHATWG HTML5 specification.
To implement this behavior, this patch introduces new value DispatchInputAndChangeEvent in TextFieldEventBehavior.

Test: fast/forms/number/spin-button-events.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer): Pass DispatchInputAndChangeEvent instead of DispatchChangeEvent to applyStep, setValue, and setValueAsNumber.

  • html/HTMLTextFormControlElement.h: Add new enum value DispatchInputAndChangeEvent to TextFieldEventBehavior.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue): Handle DispatchInputAndChangeEvent and use RefPtr for element to keep reference.

LayoutTests:

  • fast/forms/number/spin-button-events-expected.txt: Added.
  • fast/forms/number/spin-button-events.html: Added.
2:15 AM Changeset in webkit [108227] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit2

[CMake] Update and sort list of source files.

  • CMakeLists.txt:
1:33 AM Changeset in webkit [108226] by shinyak@chromium.org
  • 5 edits
    2 adds in trunk

Attached/Detached state must be testable
​https://bugs.webkit.org/show_bug.cgi?id=79010

Reviewed by Hajime Morita.

Source/WebCore:

Added a method to check an element attached or not.

Test: fast/dom/shadow/shadow-root-attached.html

  • testing/Internals.cpp:

(WebCore::Internals::attached):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/shadow-root-attached-expected.txt: Added.
  • fast/dom/shadow/shadow-root-attached.html: Added.
1:30 AM Changeset in webkit [108225] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] check that we're not running multiple modal dialogs at the same time
​https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

1:25 AM WebKitIDL edited by haraken@chromium.org
(diff)
1:16 AM Changeset in webkit [108224] by Martin Robinson
  • 8 edits in releases/WebKitGTK/webkit-1.8

Merging r108222

1:15 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:14 AM Changeset in webkit [108223] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108216

1:13 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:12 AM Changeset in webkit [108222] by Martin Robinson
  • 8 edits in trunk

Fix WebKit2GTK+ for 'make distcheck'.

Instead of conditionally including WebKit2 GNUmakefiles, always
include them and conditionally activate the final targets.

.:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:
  • UIProcess/API/gtk/tests/GNUmakefile.am:

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • WebKitTestRunner/GNUmakefile.am:
12:59 AM Changeset in webkit [108221] by bashi@chromium.org
  • 9 edits
    3 adds in trunk/Source

[WebSocket] Add deflater/inflater classes
​https://bugs.webkit.org/show_bug.cgi?id=78449

Source/WebCore:

Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.

This patch is second try. The previous patch broke Chromium Win
build. I added dependency of zlib to WebCore.gyp. I think it's
OK because Chromium already depends on zlib.

Reviewed by Kent Tamura.

No new tests except for chromium port. Behavior is unchanged.

  • GNUmakefile.list.am: Added WebSocketDeflater.(cpp|h).
  • WebCore.gyp/WebCore.gyp: Added zlib dependency.
  • WebCore.gypi: Added WebSocketDeflater.(cpp|h).
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketDeflater.cpp: Added.

(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):

  • websockets/WebSocketDeflater.h: Added.

(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):

Source/WebKit/chromium:

Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.

Reviewed by Kent Tamura.

  • WebKit.gypi: Added zlib dependency.
  • WebKitUnitTests.gyp: Ditto.
  • tests/WebSocketDeflaterTest.cpp: Added.

(WebCore):
(WebCore::TEST):

12:48 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
12:48 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:45 AM Changeset in webkit [108220] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r108191

12:40 AM Changeset in webkit [108219] by Martin Robinson
  • 8 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108206

12:40 AM Changeset in webkit [108218] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: consume undo/redo shortcuts.
​https://bugs.webkit.org/show_bug.cgi?id=79016

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

12:39 AM Changeset in webkit [108217] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Enable video option for EFL port in build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=79006

Reviewed by Daniel Bates.

  • Scripts/build-webkit:
12:38 AM Changeset in webkit [108216] by Martin Robinson
  • 3 edits in trunk/Source/WebKit2

[GTK][WK2] WebKit2 does not build if gtk-unix-printing-3.0 is not available
​https://bugs.webkit.org/show_bug.cgi?id=79011

Fix the build when gtk-unix-printing-3.0 is not present.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):
(webkitPrintOperationRunDialogForFrame):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::create):

12:37 AM Changeset in webkit [108215] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

MediaPlayer: MediaPlayerPrivate registration cleanup
​https://bugs.webkit.org/show_bug.cgi?id=78897

Reviewed by Martin Robinson.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Simplified GStreamer Private
player registration by using the PlatformMediaEngineClassName
macro like other players do.

12:34 AM Changeset in webkit [108214] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, GTK baselines for a new fast/css-generated-content
test.

  • platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
12:28 AM Changeset in webkit [108213] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK fast/repaint rebaseline.

  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
12:07 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)

Feb 19, 2012:

11:51 PM Changeset in webkit [108212] by yurys@chromium.org
  • 5 edits in trunk/Source

[Chromium] Web Inspector: terminated workers are not removed from dedicated worker list
​https://bugs.webkit.org/show_bug.cgi?id=78899

Source/WebCore:

Notify inspector about starting context from WorkerContextProxy not from Worker.

Reviewed by Pavel Feldman.

  • workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Pass original WorkerContextProxy object to the inspector instrumentation instead
of Chromium-specific one for consistency with WorkerMessagingProxy implementation
in WebCore.

Reviewed by Pavel Feldman.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

11:47 PM WebKitIDL edited by haraken@chromium.org
(diff)
11:41 PM Changeset in webkit [108211] by gyuyoung.kim@samsung.com
  • 8 edits in trunk

[CMAKE] Check gstreamer minimum required version.
​https://bugs.webkit.org/show_bug.cgi?id=79005

Reviewed by Daniel Bates.

To enable video, Gstreamer version requires to be above 0.10.30.
This patch checks whether Gstreamer version is greater than 0.10.30.

  • Source/cmake/FindGStreamer-App.cmake:
  • Source/cmake/FindGStreamer-Base.cmake:
  • Source/cmake/FindGStreamer-Interfaces.cmake:
  • Source/cmake/FindGStreamer-Pbutils.cmake:
  • Source/cmake/FindGStreamer-Plugins-Base.cmake:
  • Source/cmake/FindGStreamer-Video.cmake:
  • Source/cmake/FindGStreamer.cmake:
11:03 PM Changeset in webkit [108210] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update a few test expectations.

  • platform/chromium/test_expectations.txt:
10:41 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:31 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:30 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:29 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:26 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:22 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:17 PM Changeset in webkit [108209] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Use shadowRootList for ColorInputType
​https://bugs.webkit.org/show_bug.cgi?id=79007

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree): Changed shadowRoot to shadowRootList.
(WebCore::ColorInputType::shadowColorSwatch): Changed shadowRoot to shadowRootList.

10:14 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:06 PM Changeset in webkit [108208] by noel.gordon@gmail.com
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

[chromium] Unreviewed. Update remaining expectations for SVGImageElement-svgdom-requiredFeatures.html.

  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium/test_expectations.txt:
10:01 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:00 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:00 PM Changeset in webkit [108207] by shinyak@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Introduce InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
​https://bugs.webkit.org/show_bug.cgi?id=78771

Reviewed by Hajime Morita.

This patch introduces InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.

This is a step for rendering <shadow> correctly, because <shadow> has almost the same function of <content>.
After this patch, we will change NodeRenderingContext and related classes to accept InsertionPoint instead of
HTMLContentElement only.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/InsertionPoint.cpp: Added.

(WebCore):
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::~InsertionPoint):

  • html/shadow/InsertionPoint.h: Added.

(WebCore):
(InsertionPoint):

9:59 PM WebKitIDL edited by haraken@chromium.org
(diff)
9:24 PM Changeset in webkit [108206] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[GTK] Can't find webinspector and error page redirection on Windows
​https://bugs.webkit.org/show_bug.cgi?id=51616

Source/WebCore:

Create and use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

  • platform/FileSystem.h:

(WebCore):

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::getPathToImageResource):

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::sharedResourcesPath):
(WebCore):

Source/WebKit/gtk:

Use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorFilesPath):

8:22 PM Changeset in webkit [108205] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Update Leopard expectation for
SVGImageElement-svgdom-requiredFeatures.html.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
5:11 PM Changeset in webkit [108204] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed - mark failing test as failing.

  • platform/chromium/test_expectations.txt:
4:04 PM Changeset in webkit [108203] by jamesr@google.com
  • 2 edits
    11 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Add leopard baselines for fast/css/relative-positioned-block-* tests, fix up test_expectations.txt

  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [108202] by jamesr@google.com
  • 9 edits
    1 copy in trunk/Source/WebCore

Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
​https://bugs.webkit.org/show_bug.cgi?id=78951

Reviewed by Adam Barth.

This move stubs for ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp instead of #ifdefing inside
ScrollingCoordinator.cpp. The mac port uses ScrollingCoordinator when #if ENABLE(THREADED_SCROLLING) is not set
and implementations in ScrollingCoordinator.cpp / ScrollingCoordinatorMac.mm otherwise. The chromium port
always uses implementations in ScrollingCoordinatorChromium.cpp. All other ports use
ScrollingCoordinatorNone.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbx:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::create):
(WebCore):

3:47 PM Changeset in webkit [108201] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Rename [CheckDomainSecurity] to [CheckSecurity]
​https://bugs.webkit.org/show_bug.cgi?id=78874

Reviewed by Adam Barth.

"Domain security" isn't a term that's used elsewhere.
This patch renames IDL attributes as follows:

  • [CheckDomainSecurity] => [CheckSecurity]
  • [DoNotCheckDomainSecurity] => [DoNotCheckSecurity]
  • [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckSecurityOnGetter]
  • [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckSecurityOnSetter]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsVisibleAcrossOrigins):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/TestDomainSecurity.idl:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
3:32 PM Changeset in webkit [108200] by jamesr@google.com
  • 8 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r108195.
​http://trac.webkit.org/changeset/108195
​https://bugs.webkit.org/show_bug.cgi?id=77700

Lots of failing ASSERT()s on v8 bots, requested by kling on
#webkit

Source/WebCore:

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

LayoutTests:

  • fast/css/css-value-wrapper-sameness-expected.txt: Removed.
  • fast/css/css-value-wrapper-sameness.html: Removed.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Added.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Added.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/script-tests/domListEnumeration.js:
3:30 PM Changeset in webkit [108199] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Rename [CheckAccessToNode] to [CheckSecurityForNode]
​https://bugs.webkit.org/show_bug.cgi?id=78991

Reviewed by Adam Barth.

For naming consistency with [CheckSecurity], this patch renames
[CheckAccessToNode] to [CheckSecurityForNode].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl:
3:24 PM Changeset in webkit [108198] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Sort WebCore XCode project files with sort-Xcode-project-files script. Unreviewed.

  • WebCore.xcodeproj/project.pbxproj:
2:50 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
2:43 PM Changeset in webkit [108197] by kov@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Merging r108190

12:58 PM Changeset in webkit [108196] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

Update expectations for test results changed by r108185

The bots only check text results.

Unreviewed.

  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
12:16 PM Changeset in webkit [108195] by kling@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk

Make CSSValue wrapper getters return unique objects every time.
<​http://webkit.org/b/77700>

Reviewed by Antti Koivisto.

Source/WebCore:

Change the behavior of CSSValue getters to return unique JS wrappers every
time they are called. This means we no longer have to deal with the risk
of leaking custom properties between unrelated documents, and are free to
implement global value sharing across WebCore.

This patch will be followed by one making CSSValuePool globally shared,
it's done in two steps to monitor the impact of this change.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsCSSValueType):

LayoutTests:

  • fast/css/css-value-wrapper-sameness-expected.txt: Added.
  • fast/css/css-value-wrapper-sameness.html: Added.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Removed.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Removed.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/script-tests/domListEnumeration.js:
12:06 PM Changeset in webkit [108194] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderBlock::splitAnonymousBlocksAroundChild.
​https://bugs.webkit.org/show_bug.cgi?id=78994

Reviewed by Eric Seidel.

Source/WebCore:

Generalize splitTablePartsAroundChild to handle splitting
in nested tables.
Table->Table Section->Table Row->Table Cell->Table->Table Section->Table Row

Test: fast/table/table-split-inside-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitTablePartsAroundChild):

LayoutTests:

  • fast/table/table-split-inside-table-expected.txt: Added.
  • fast/table/table-split-inside-table.html: Added.
11:36 AM Changeset in webkit [108193] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Remove gsettings schema from EXTRA_DIST.

  • GNUmakefile.am:
11:29 AM Changeset in webkit [108192] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Use modifier keys to execute pre-rendering.
​https://bugs.webkit.org/show_bug.cgi?id=77933

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2012-02-19
Reviewed by Chang Shu.

Use modifier key to execute pre-rendering instead of using reserved function keys.

  • EWebLauncher/main.c:

(on_key_down):

11:16 AM Changeset in webkit [108191] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Fix build on platforms where UChar is wchar_t
​https://bugs.webkit.org/show_bug.cgi?id=78996

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-19
Reviewed by Martin Robinson.

The ICU backend defines UChar as wchar_t for platforms where wchar_t is
16 bits wide, e.g. win32.

  • platform/graphics/pango/FontPango.cpp:

(WebCore::utf16ToUtf8): Use reinterpret_cast instead of static_cast.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::typeAheadFind): Ditto.

11:16 AM Changeset in webkit [108190] by kov@webkit.org
  • 7 edits
    1 delete in trunk

[GTK] Remove unused GSettings stuff
​https://bugs.webkit.org/show_bug.cgi?id=78995

Reviewed by Martin Robinson.

.:

  • configure.ac: remove gsettings schema file creation.

Source/WebKit/gtk:

  • GNUmakefile.am: remove GSettings-related stuff.
  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit): Remove unused code.

  • org.webkitgtk.gschema.xml.in: Removed.
  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_execute_script): remove gsettings-related helper.

  • webkit/webkitwebinspectorprivate.h: Ditto.
11:03 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
11:01 AM Changeset in webkit [108189] by rniwa@webkit.org
  • 3 edits in trunk

Perf-o-matic should show both WebKit and Chromium revisions
​https://bugs.webkit.org/show_bug.cgi?id=78955

Reviewed by Andreas Kling.

Include Chromium revision numbers in runs responses when available.

  • Websites/webkit-perf.appspot.com/js/config.js:

(urlForChangeset):
(urlForChangesetList):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

10:32 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:16 AM WebKitGTK edited by Martin Robinson
(diff)
10:15 AM WebKitGTK/1.8.x created by Martin Robinson
9:41 AM Changeset in webkit [108188] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.8

Branching for the WebKitGTK+ 1.8 stable release

8:53 AM Changeset in webkit [108187] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header.
8:27 AM Changeset in webkit [108186] by robert@webkit.org
  • 5 edits
    25 moves
    36 adds
    2 deletes in trunk/LayoutTests

Chromium results for r108185

Unreviewed gardening.

  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-big-endian-expected.png.
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-little-endian-expected.png.
  • platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-with-layers-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Removed.
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Removed.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt.
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
7:24 AM Changeset in webkit [108185] by robert@webkit.org
  • 19 edits
    43 adds in trunk

CSS 2.1 failure: inline-box-002.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=69210

Reviewed by David Hyatt.

Source/WebCore:

Tests: css2.1/20110323/dynamic-top-change-005.htm

css2.1/20110323/dynamic-top-change-005a.htm
css2.1/20110323/dynamic-top-change-005b.htm
css2.1/20110323/inline-box-002.htm
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent.html
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor.html
fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-parent-keeps-style.html
fast/css/relative-positioned-block-with-inline-parent.html

A block within an inline is affected by relative positioning on the inline box. Give
the anonymous block containing the block a layer and make it relative positioned. Then
calculate the offset of the anonymous block's layer by accumulating the offsets from its
inline continuation and the inline continuation's inline parents.
If the position of an inline changes from or to relative positioned then ensure that any
descendant blocks update their position and layer accordingly.

  • rendering/RenderBoxModelObject.cpp:

(): add an enum RelPosAxis
(WebCore::accumulateRelativePositionOffsets):
Total up the offsets of all relatively positioned inlines that are de-facto parents of the relatively
positioned anonymous block's child block.

(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
Use accumulateRelativePositionOffsets when calculating the relative position offset of a relatively positioned anonymous block.

(WebCore::RenderBoxModelObject::relativePositionOffsetY): ditto

  • rendering/RenderInline.cpp:

(WebCore::hasRelPositionedInlineAncestor):
Detects if the anonymous block contains a block that is the de-facto descendant of a relatively positioned inline.

(WebCore::updateStyleOfAnonymousBlockContinuations):
Update the style's positioning for each anonymous block containing a block that is descendant from the inline whose style has changed.

(WebCore::RenderInline::styleDidChange):
If an inline changes to or from relative positioning ensure that any descendant blocks change to or from relative positioning
as well, unless they still have a relatively positioned ancestor after the current ancestor loses its relative positioning.

(WebCore::RenderInline::addChildIgnoringContinuation):
If the anonymous block contains a block that is effectively descended from a relatively positioned inline, make it relatively
positioned so the block will respect its inline ancestor's relative positioning.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):
Preserve style position in anonymous block continuations when the parent block propagates a style change.

LayoutTests:

  • css2.1/20110323/dynamic-top-change-005-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005.htm: Added.
  • css2.1/20110323/dynamic-top-change-005a-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005a.htm: Added.
  • css2.1/20110323/dynamic-top-change-005b-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005b.htm: Added.
  • css2.1/20110323/inline-box-002-expected.html: Added.
  • css2.1/20110323/inline-box-002.htm: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-expected.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-keeps-style.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent.html: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/chromium/test_expectations.txt: Suppress existing tests until results rebaselined.
  • platform/gtk/test_expectations.txt: ditto
  • platform/mac/test_expectations.txt: ditto
  • platform/qt/test_expectations.txt: ditto
  • platform/win/Skipped: ditto

Feb 18, 2012:

10:25 PM Changeset in webkit [108184] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Track the NPN protocol version negotiated with the server
​https://bugs.webkit.org/show_bug.cgi?id=77349

Source/WebCore:

Patch by raman Tenneti <​rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher..

[chromium] Added ExtraData to WebURLResponse.

No intended functionality change.

  • platform/network/chromium/ResourceResponse.h:

(ExtraData):
(WebCore::ResourceResponse::ExtraData::~ExtraData):
(ResourceResponse):
(WebCore::ResourceResponse::extraData):
(WebCore::ResourceResponse::setExtraData):

Source/WebKit/chromium:

Patch by raman Tenneti <​rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher.

[chromium] Added ExtraData to WebURLResponse.

  • WebKit.gypi:
  • public/platform/WebURLResponse.h:

(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebURLResponse):

  • src/WebURLResponse.cpp:

(WebKit::WebURLResponse::extraData):
(WebKit):
(WebKit::WebURLResponse::setExtraData):

  • tests/WebURLResponseTest.cpp: Added.

(WebKit):
(TestExtraData):
(WebKit::TestExtraData::TestExtraData):
(WebKit::TestExtraData::~TestExtraData):
(WebKit::TEST):

8:57 PM Changeset in webkit [108183] by inferno@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r107965.
​http://trac.webkit.org/changeset/107965
​https://bugs.webkit.org/show_bug.cgi?id=78273

Source/WebCore:

crashes

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

LayoutTests:

Crashes on ClusterFuzz.

  • fast/multicol/span/clone-flexbox-expected.txt: Removed.
  • fast/multicol/span/clone-flexbox.html: Removed.
8:07 PM Changeset in webkit [108182] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix one more dangling reference to worker_connection.name, delete unused code.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.update):
(_WorkerState.init):

7:53 PM Changeset in webkit [108181] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/10891801> BackingStore::scroll() unnecessarily copies pixels around
​https://bugs.webkit.org/show_bug.cgi?id=78976

Reviewed by Anders Carlsson.

Rather than move pixels in the backing store in response to scrolling, we can maintain a
mapping, for the most recently scrolled rect, from backing store coordinates to view
client coordinates.

  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::performWithScrolledRectTransform): Added. Given a block to be
performed on a rect, divides the rect into parts such that for each part the mapping from
backing store coordinates to client coordinates is a (uniform) translation, and performs
the block on that part, passing it the translation that applies to the part.
(WebKit::BackingStore::resetScrolledRect): Added. Copies everything in the scrolled rect
back to where it should be under the identity map, and resets the scrolled rect and offset.
(WebKit::BackingStore::paint): Changed to call through performWithScrolledRectTransform().
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Now instead of copying pixels, just updates the scrolled
rect and offset.

5:53 PM Changeset in webkit [108180] by weinig@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Fix style issues in DFG Phase classes
​https://bugs.webkit.org/show_bug.cgi?id=78983

Reviewed by Ryosuke Niwa.

  • dfg/DFGArithNodeFlagsInferencePhase.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

Add a space before the colon in class declarations.

5:08 PM Changeset in webkit [108179] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

  • config.h:

Disable the DisallowCType check when using libc++.

4:57 PM Changeset in webkit [108178] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • page/DOMWindow.idl:
4:50 PM Changeset in webkit [108177] by dpranke@chromium.org
  • 4 edits in trunk/Tools

Add a change that should've been in r108005.

Unreviewed, build fix.

In the refactoring/cleanup in r108005 I should've changed the
implementation of WorkerConnection to make it match BrokerClient
(and everything else) so that objects had a name() method
instead of a name property.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_WorkerConnection.init):
(_WorkerConnection.name):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestsMixin.name):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_unknown_message):

4:33 PM Changeset in webkit [108176] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempt to fix Windows build.

3:51 PM Changeset in webkit [108175] by dpranke@chromium.org
  • 6 edits
    2 deletes in trunk/Tools

webkitpy: remove webkitpy.common.array_stream
​https://bugs.webkit.org/show_bug.cgi?id=78952

Reviewed by Eric Seidel.

Turns out array_stream didn't really do anything that StringIO
didn't do (at least as of Python 2.6). This change removes it
and updates all of the callers. Where possible, I changed the
test assertions in order to capture the intent more clearly,
e.g., instead of calling self.assertTrue('foo' in stream.get()),
we have self.assertContainsLine(stream, 'foo'), and instead of
self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
the latter isn't that much more readable, but StringIO doesn't
export an empty() method.

  • Scripts/webkitpy/common/array_stream.py: Removed.
  • Scripts/webkitpy/common/array_stream_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(run_and_capture):
(StreamTestingMixin):
(StreamTestingMixin.assertContains):
(StreamTestingMixin.assertContainsLine):
(StreamTestingMixin.assertEmpty):
(StreamTestingMixin.assertNotEmpty):
(LintTest):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):
(MainTest):
(MainTest.test_child_process_1):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_help_printing):
(MainTest.test_hung_thread):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_worker_modelinline_with_child_processes):
(MainTest.test_additional_platform_directory):
(RebaselineTest):
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.update):

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(TestMeteredStream.test_regular):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.assertEmpty):
(Testprinter):
(Testprinter.assertNotEmpty):
(Testprinter.assertWritten):
(Testprinter.reset):
(Testprinter.get_printer):
(Testprinter.test_help_printer):
(Testprinter.do_switch_tests.do_helper):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_test_result):
(Testprinter.test_print_progress):
(Testprinter.test_write_nothing):
(Testprinter.test_write_misc):
(Testprinter.test_write_everything):
(Testprinter.test_write_verbose):
(Testprinter.test_print_unexpected_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.assertWritten):
(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):

3:42 PM Changeset in webkit [108174] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

Add a workaround for <rdar://problem/10858112>, which cause the standard heap functions
not to work when using an iterator with proxy objects for reference and pointer types.

  • WebCorePrefix.h:

(move):
Add an overload of std::move that the heap functions can call successfully.

2:30 PM Changeset in webkit [108173] by kling@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium rebaselines after r108157.

  • platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
  • platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
2:10 PM Changeset in webkit [108172] by kevino@webkit.org
  • 4 edits in trunk

[wx] Fix wx port compilation.

2:07 PM Changeset in webkit [108171] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

[wx] Build fixes for C++ bindings after recent changes.

2:04 PM Changeset in webkit [108170] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Build fix, add new platform method wx impl.

1:48 PM Changeset in webkit [108169] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix part of the windows build failure.

  • WebCore.vcproj/WebCore.vcproj:

Don't build JSWebKitCSSRegionRule.cpp, since it is already being built
as part of DerivedSources.cpp.

1:30 PM Changeset in webkit [108168] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the libc++ build.

Reviewed by Anders Carlsson.

  • heap/Weak.h:

Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.

1:28 PM Changeset in webkit [108167] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the ENABLE(THREADED_SCROLLING) build.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):

12:07 PM Changeset in webkit [108166] by fpizlo@apple.com
  • 6 edits
    12 adds
    2 deletes in trunk/Source/JavaScriptCore

DFGPropagator.cpp has too many things
​https://bugs.webkit.org/show_bug.cgi?id=78956

Reviewed by Oliver Hunt.

Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.

(DFG):
(JSC::DFG::performArithNodeFlagsInference):

  • dfg/DFGArithNodeFlagsInferencePhase.h: Added.

(DFG):

  • dfg/DFGCFAPhase.cpp: Added.

(DFG):
(JSC::DFG::performCFA):

  • dfg/DFGCFAPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp: Added.

(DFG):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGPhase.cpp: Added.

(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h: Added.

(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):

  • dfg/DFGPredictionPropagationPhase.cpp: Added.

(DFG):
(JSC::DFG::performPredictionPropagation):

  • dfg/DFGPredictionPropagationPhase.h: Added.

(DFG):

  • dfg/DFGPropagator.cpp: Removed.
  • dfg/DFGPropagator.h: Removed.
  • dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.

(DFG):
(JSC::DFG::performVirtualRegisterAllocation):

  • dfg/DFGVirtualRegisterAllocationPhase.h: Added.

(DFG):

11:58 AM Changeset in webkit [108165] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

HTML: Remove unnecessary attributeChange() overrides.
<​http://webkit.org/b/78890>

Reviewed by Anders Carlsson.

Move logic from attributeChanged() overrides into parseAttribute().
This is a step towards making attributeChanged() non-virtual.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

11:53 AM Changeset in webkit [108164] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove Element::createAttribute().
<​http://webkit.org/b/78965>

Reviewed by Anders Carlsson.

Switch call sites to use Attribute::create() directly, as there is no magic
in calling Element::createAttribute() anymore (it used to be virtual and handled
differently by StyledElement.)

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
11:48 AM Changeset in webkit [108163] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLBodyElement: Avoid synchronous style recalc when setting link/vlink/alink.
<​http://webkit.org/b/78959>

Reviewed by Anders Carlsson.

Mark the body element for deferred style recalc instead of doing it synchronously
when the attributes change.

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseAttribute):

10:33 AM Changeset in webkit [108162] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the TextureMapper build for non-Qt ports. Qt debug builds
must use RTTI, but GTK+, at least, does not.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Make the RTTI check
Qt only.

10:17 AM Changeset in webkit [108161] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Don't error out or hang if we have
downloaded dependencies but server update check fails.

5:04 AM Changeset in webkit [108160] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107971.

  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/qt/test_expectations.txt:
4:59 AM Changeset in webkit [108159] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip new failing tests.

  • platform/qt/Skipped:
4:51 AM Changeset in webkit [108158] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed gardening r108133.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
3:42 AM Changeset in webkit [108157] by kling@webkit.org
  • 5 edits in trunk

FontFamilyValue: Utilize inheritance from CSSPrimitiveValue better.
<​http://webkit.org/b/78806>

Reviewed by Antti Koivisto.

Source/WebCore:

Now that FontFamilyValue's string doesn't change after creation, we can just
pass the massaged family name up to the CSSPrimitiveValue constructor and get
cached cssText() for free. This also shrinks FontFamilyValue by sizeof(String)
though that's less of an issue now that we cache them in CSSValuePool.

  • css/FontFamilyValue.cpp:

(WebCore::stripFontFamilyJunk):
(WebCore::FontFamilyValue::FontFamilyValue):

  • css/FontFamilyValue.h:

(WebCore::FontFamilyValue::familyName):
(FontFamilyValue):

LayoutTests:

Rebaseline as CSSPrimitiveValue.getStringValue() is no longer broken for
font-family values.

  • fast/dom/setPrimitiveValue-exceptions-expected.txt:
12:25 AM Changeset in webkit [108156] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning

12:19 AM Changeset in webkit [108155] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.16

New tag.

Feb 17, 2012:

11:56 PM Changeset in webkit [108154] by fpizlo@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

DFG::Graph should have references to JSGlobalData, the CodeBlock being compiled, and
the CodeBlock that was used for profiling
​https://bugs.webkit.org/show_bug.cgi?id=78954

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.h:

(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:
  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::parse):

  • dfg/DFGByteCodeParser.h:

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(Graph):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::globalCFA):
(JSC::DFG::propagate):

  • dfg/DFGPropagator.h:

(DFG):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

11:28 PM Changeset in webkit [108153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

There is a warning in memset in glibc that gets triggered through a
warndecl when the fill-value of memset is a non-zero constant and the
size is zero. This warning is enabled when building with
-D_FORTIFY_SOURCE=2. This patch fixes the warning.

​https://bugs.webkit.org/show_bug.cgi?id=78513

Patch by Ahmad Sharif <​asharif.tools@gmail.com> on 2012-02-17
Reviewed by Alexey Proskuryakov

  • wtf/Vector.h:
7:22 PM Changeset in webkit [108152] by adamk@chromium.org
  • 4 edits
    4 adds in trunk

Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
​https://bugs.webkit.org/show_bug.cgi?id=76087

Reviewed by Ryosuke Niwa.

Source/WebCore:

Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.

Tests: fast/dom/getElementById-consistency.html

fast/dom/getElementById-consistency2.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.

LayoutTests:

  • fast/dom/getElementById-consistency-expected.txt: Added.
  • fast/dom/getElementById-consistency.html: Added.
  • fast/dom/getElementById-consistency2-expected.txt: Added.
  • fast/dom/getElementById-consistency2.html: Added.
6:51 PM Changeset in webkit [108151] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] change the way of registering DeviceOrientation clients.
​https://bugs.webkit.org/show_bug.cgi?id=78680

Reviewed by Gustavo Noronha Silva.

Bug 78085 removed deviceOrientationClient and deviceMotionClient from PageClients. Instead,
DeviceOrientationClient and DeviceMotionClient should be registered by PageSupplement class.
Chromium, mac and qt ports are already changed by Bug 78085.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

6:46 PM Changeset in webkit [108150] by jsbell@chromium.org
  • 22 edits
    2 adds in trunk

IndexedDB: Support overloaded methods that take IDBKey or IDBKeyRange
​https://bugs.webkit.org/show_bug.cgi?id=78399

Source/WebCore:

Implements IDBObjectStore.delete(IDBKeyRange) to exercise the functionality.

Reviewed by Tony Chang.

Test: storage/indexeddb/delete-range.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString): Use .get() to disambiguate when passing RefPtr.

  • bindings/scripts/test/V8/V8TestObj.cpp: Update test expectations.
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteFunction):
(WebCore):

  • storage/IDBObjectStore.h:

(IDBObjectStore):

  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • storage/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Implements the WebKit API for IDBObjectStore.delete(IDBKeyRange),
to exercise the overload capability.

Reviewed by Tony Chang.

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::deleteFunction):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::deleteFunction):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

Tests IDBObjectStore.delete(IDBKeyRange). The spec has been updated such
that delete() always yields a result of undefined rather than a boolean,
so other test expectations are updated.

Reviewed by Tony Chang.

  • storage/indexeddb/delete-range-expected.txt: Added.
  • storage/indexeddb/delete-range.html: Added.
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/objectstore-basics.js:

(createIndex):
(removeSuccess):
(removeSuccessButNotThere):

6:20 PM Changeset in webkit [108149] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace [V8OnInstance] with [V8Unforgeable]
​https://bugs.webkit.org/show_bug.cgi?id=78894

Reviewed by Adam Barth.

[V8OnInstance] means that the method should be defined
(not on a prototype chain but) on a DOM object. It is the
same meaning as [V8Unforgeable]. This patch replaces [V8OnInstance]
with [V8Unforgeable].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • page/Location.idl:
6:07 PM Changeset in webkit [108148] by leviw@chromium.org
  • 20 edits in branches/subpixellayout/Source/WebCore

Adding pixel snapped methods to FractionalLayoutRect. Adding a roundToInt abstraction, using it everywhere except FractionalLayout* classes, and correcting a ton of incorrect rounding methods. Cleaning up RenderInline::paintOutlineForLine. Fixing a crash in adjustRectForColumns.

6:03 PM Changeset in webkit [108147] by jamesr@google.com
  • 6 edits
    1 add
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening, update baselines for svg/dynamic-updates/.. and some more getComputedStyle
results

  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
5:19 PM Changeset in webkit [108146] by jamesr@google.com
  • 2 edits
    1 move in trunk/Source/WebCore

[chromium] Unreviewed build fix. MSVS gyp generator can't handle multiple .cpps with the same name in the same
target from different paths.

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Renamed from Source/WebCore/page/scrolling/chromium/ScrollingCoordinator.cpp.

(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

5:02 PM Changeset in webkit [108145] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed mac compile fix pt 2

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

5:01 PM Changeset in webkit [108144] by dpranke@chromium.org
  • 4 edits in trunk/Tools

The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
​https://bugs.webkit.org/show_bug.cgi?id=69444

Reviewed by Tony Chang.

Currently if a test's image checksum doesn't match the checksum
in the baseline, but the images themselves match according to
ImageDiff, new-run-webkit-tests ignores the problem. This is
probably bad, but it's not yet clear what the right thing to do
is. This patch will log a warning to stderr, at least (but the
test will still pass).

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_list):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4:56 PM Changeset in webkit [108143] by dpranke@chromium.org
  • 4 edits in trunk/Tools

NRWT does not report failure for a skipped test
​https://bugs.webkit.org/show_bug.cgi?id=78750

Reviewed by Eric Seidel.

If a test is listed in a Skipped file and you run it anyway
with --force, and the test fails, currently NRWT will print
"test ran as expected"; this is confusing, because you probably
expect the test to fail and yet this might lead you to think the
test passed. This patch changes the expected behavior to "PASS",
so tests that fail will be reported.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(result_was_expected):
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_add_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_list): Add some tests that are expected to be in a Skipped file.
(TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.

4:50 PM Changeset in webkit [108142] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed mac compile fix (unused parameter warning)

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

4:33 PM Changeset in webkit [108141] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: fix test code after bug 78181
​https://bugs.webkit.org/show_bug.cgi?id=78870

Reviewed by Adam Barth.

I forgot to update the test code as per Tony's suggestion in
bug 78181 (r108005). This change does that, and in doing so
it revealed a subtle bug in _InlineWorkerConnection.run() that
I am fixing as part of this (_alive would not be cleared if an
exception was thrown).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_InlineWorkerConnection.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.handle_stop):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.handle_exception):
(_TestsMixin.test_unknown_message):

4:23 PM Changeset in webkit [108140] by jamesr@google.com
  • 23 edits
    1 copy
    1 add in trunk/Source/WebCore

Move ScrollingCoordinator out of ENABLE(THREADED_SCROLLING) ifdef and enable on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=78401

Reviewed by Adam Barth.

Separates THREADED_SCROLLING from ScrollingCoordinator and enables ScrollingCoordinator-related code on
chromium. ScrollingCoordinator receives scrolling information to be used with an external scrolling source.
ENABLE(THREADED_SCROLLING) enables a codepath that uses a thread in WebCore to handle scrolling related input
events and interact with composited layers.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

  • page/FrameView.cpp:

(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::performPostLayoutTasks):

  • page/Page.cpp:

(WebCore::Page::~Page):
(WebCore):

  • page/Page.h:

(Page):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore):

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::createThreadIfNeeded):

  • page/scrolling/ScrollingTreeState.cpp:
  • page/scrolling/ScrollingTreeState.h:
  • page/scrolling/chromium/ScrollingCoordinator.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(WebCore):
(RenderLayerCompositor):

4:14 PM Changeset in webkit [108139] by jamesr@google.com
  • 5 edits in trunk/LayoutTests

[chromium] Unreviewed - removing expectations for tests that consistently pass, update some baselines for
getComputedStyle due to new -webkit-line-align property.

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [108138] by eae@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Add FractionalLayoutPoint for sub-pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=78913

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Point class and a couple of
conversion methods to the Int and Float versions of same.

No new tests.

  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::FloatPoint):
(WebCore):
(WebCore::FloatPoint::moveBy):

  • platform/graphics/FloatPoint.h:

(WebCore):
(FloatPoint):

  • platform/graphics/FractionalLayoutPoint.h: Added.

(WebCore):
(FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::zero):
(WebCore::FractionalLayoutPoint::x):
(WebCore::FractionalLayoutPoint::y):
(WebCore::FractionalLayoutPoint::setX):
(WebCore::FractionalLayoutPoint::setY):
(WebCore::FractionalLayoutPoint::move):
(WebCore::FractionalLayoutPoint::moveBy):
(WebCore::FractionalLayoutPoint::scale):
(WebCore::FractionalLayoutPoint::expandedTo):
(WebCore::FractionalLayoutPoint::shrunkTo):
(WebCore::FractionalLayoutPoint::clampNegativeToZero):
(WebCore::FractionalLayoutPoint::transposedPoint):
(WebCore::operator+=):
(WebCore::operator-=):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::toPoint):
(WebCore::toSize):
(WebCore::flooredIntPoint):
(WebCore::roundedIntPoint):
(WebCore::ceiledIntPoint):

  • platform/graphics/FractionalLayoutSize.cpp:

(WebCore::pixelSnappedIntSize):

  • platform/graphics/FractionalLayoutSize.h:

(WebCore):

3:57 PM Changeset in webkit [108137] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Move textDirectionForSelection from Editor to EditingStyle
​https://bugs.webkit.org/show_bug.cgi?id=78868

Reviewed by Enrica Casucci.

Move textDirectionForSelection from Editor to EditingStyle to centralize the editing code's
dependency on CSSStyleDeclaration.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::textDirectionForSelection):
(WebCore):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/Editor.cpp:

(WebCore):

  • editing/Editor.h:

(Editor):

  • editing/EditorCommand.cpp:

(WebCore::stateTextWritingDirection):

  • editing/ReplaceSelectionCommand.cpp:
  • editing/markup.cpp:
3:33 PM Changeset in webkit [108136] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

MathML internals - embellished operators, getBase() accessor functions
​https://bugs.webkit.org/show_bug.cgi?id=78617

Patch by David Barton <Dave Barton> on 2012-02-17
Reviewed by Eric Seidel.

Define functions that return an unembellished "base", by omitting
subscripts/superscripts, underscripts/overscripts, or denominators. This is needed in
subsequent patches both for correct operator stretching and simple code factoring.

No new tests.

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore):
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::unembellishedOperator):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::unembellishedOperator):
(WebCore):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::unembellishedOperator):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::base):
(WebCore):
(WebCore::RenderMathMLSubSup::unembellishedOperator):
(WebCore::RenderMathMLSubSup::stretchToHeight):

  • renamed a variable for clarity, especially in later patches

(WebCore::RenderMathMLSubSup::layout):

  • renamed a variable for clarity, especially in later patches
  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::base):
(WebCore):
(WebCore::RenderMathMLUnderOver::unembellishedOperator):
(WebCore::RenderMathMLUnderOver::stretchToHeight):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

3:28 PM Changeset in webkit [108135] by noam.rosenthal@nokia.com
  • 11 edits in trunk/Source

[Qt][WK2] Allow opaque tiles
​https://bugs.webkit.org/show_bug.cgi?id=78809

Source/WebCore:

Replace the isOpaque boolean in BitmapTexture to a SupportsAlpha flag.
Use reset/didReset instead of a virtual function that has to call the superclass.

Make sure that all calls to BitmapTexture::reset() pass the correct SupportsAlpha flag,
based on the source image.
Since we now disable blending for opaque textures, we also have to make sure that we treat
the depth buffer correctly and bring it back to its previous state.

Reviewed by Kenneth Rohde Christiansen.

No behavior changes.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(WebCore::TextureMapperGLData::initStencil):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginClip):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::flags):
(WebCore::BitmapTexture::didReset):
(WebCore::BitmapTexture::reset):
(BitmapTexture):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTiledBackingStore):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::didReset):
(WebCore):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

Source/WebKit2:

Apply the SupportsAlpha flag only when the buffers actually have alpha.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/ShareableBitmap.h:

(ShareableBitmap):

  • Shared/qt/ShareableBitmapQt.cpp:
  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):

3:16 PM Changeset in webkit [108134] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Crash in SVGAnimateElement due to changed target
​https://bugs.webkit.org/show_bug.cgi?id=75096

Patch by Stephen Chenney <​schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGAnimateElement object creates various internal objects
depending on the type of property being animated, which depends on the
target. These objects were not being recreated when the target
changed, and crashes ensued. Now the SVGSMILElement provides a virtual
method that is called when the target changes, and SVGAnimateElement
updates its objects as necessary. We also deactivate the animation
when the target changes, forcing recomputation of other derived
objects.

This change also removes various unnecessary calls to semi-expensive
methods.

Not only does this change fix the new test, it also fixes potential
crashes in other tests that apparently never manifested before (but
manifest when this new test is included in DRT).

Test: svg/animations/svglength-animation-retarget-crash.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::calculateDistance):
(WebCore):
(WebCore::SVGAnimateElement::targetElementDidChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::type):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::targetElement):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):
(WebCore::SVGSMILElement::targetElementDidChange):

LayoutTests:

This test verifies that the target element information is correctly
updated when the target changes. Note that the clone is required, as
it causes the results of one animation to be pushed to a different
animation.

  • svg/animations/svglength-animation-retarget-crash-expected.txt: Added.
  • svg/animations/svglength-animation-retarget-crash.html: Added.
3:13 PM Changeset in webkit [108133] by hyatt@apple.com
  • 15 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=78934

Add the -webkit-line-align property to support the alignment of lines in the inline direction
to the line grid.

Reviewed by Dan Bernstein.

Source/WebCore:

Added fast/line-grid/line-align-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator LineAlign):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

  • fast/line-grid/line-align-parsing-expected.txt: Added.
  • fast/line-grid/line-align-parsing.html: Added.
  • fast/line-grid/script-tests/line-align-parsing.js: Added.
3:08 PM Changeset in webkit [108132] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

3:07 PM Changeset in webkit [108131] by eae@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Add FractionalLayoutSize for sub-pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=78852

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Size class and a couple of
conversion methods to the Int and Float versions of same.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::move):
Add FractionalLayoutSize version of move.

  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::FloatSize):
Add FloatSize(FractionalLayoutSize) constructor.

  • platform/graphics/FloatSize.h:
  • platform/graphics/FractionalLayoutSize.cpp: Added.
  • platform/graphics/FractionalLayoutSize.h: Added.
2:57 PM Changeset in webkit [108130] by jamesr@google.com
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

[chromium] Unreviewed. Land the last (hopefully) new baselines for fast/css/non-empty-span.html

  • platform/chromium-mac-leopard/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-win/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-win/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/non-empty-span-expected.txt.
2:50 PM Changeset in webkit [108129] by eae@chromium.org
  • 34 edits in branches/subpixellayout/Source

Avoid unnecessary rounding/snapping and replace LayoutUnit(0) with constant.

2:44 PM Changeset in webkit [108128] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r107606): Copy Link writes malformed WebURLsWithTitlesPboardType
data to the pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=78933
<rdar://problem/10874553>

For this format, the data needs to be placed in the pasteboard as array of arrays
of strings. Currently is it stored as array of strings, which causes the code
that uses this format to break.

Reviewed by Ryosuke Niwa.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setPathnamesForType):

2:36 PM Changeset in webkit [108127] by inferno@chromium.org
  • 6 edits
    12 adds in trunk

Incorrect placement of a new child when beforeChild and its
previous sibling are in the same table.
​https://bugs.webkit.org/show_bug.cgi?id=78269

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/table-cell-split.html

fast/table/table-row-split.html
fast/table/table-section-split-with-after-content.html
fast/table/table-section-split.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitAnonymousBlocksAroundChild): add
call to splitTablePartsAroundChild to take care of splitting the
table first if the child is part of table.
(WebCore::markTableForSectionAndCellRecalculation): add helper to
mark table for complete relayout by invalidating sections and cells.
(WebCore):
(WebCore::moveAllTableChildrenTo): moves children to another table.
(WebCore::RenderBlock::splitTablePartsAroundChild): split table child
and its next siblings into a new table. This allows adding a new
non-table child between the tables.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): calls
splitTablePartsAroundChild to see if we need to split the table
for adding this new child.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createAnonymousTable): add helper for
creating anonymous table.
(WebCore):
(WebCore::RenderObject::addChild): use the new helper for creating
anonymous table.

  • rendering/RenderObject.h:

(WebCore):
(RenderObject):
(WebCore::RenderObject::isTablePart): add helper to tell if the object
is a table part.

LayoutTests:

Test passes if the div child splits the table parts and is not
part of table itself.

  • fast/table/table-cell-split-expected.txt: Added.
  • fast/table/table-cell-split.html: Added.
  • fast/table/table-row-split-expected.txt: Added.
  • fast/table/table-row-split.html: Added.
  • fast/table/table-section-split-expected.txt: Added.
  • fast/table/table-section-split-with-after-content-expected.txt: Added.
  • fast/table/table-section-split-with-after-content.html: Added.
  • fast/table/table-section-split.html: Added.
2:34 PM Changeset in webkit [108126] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Element: Inline style selector and AX invalidation in attributeChanged().
<​http://webkit.org/b/78888>

Reviewed by Antti Koivisto.

Inline the updateAfterAttributeChanged() and recalcStyleIfNeededAfterAttributeChanged()
methods into Element::attributeChanged(). They were separated when we needed them in
StyledElement::attributeChanged(), but that's no longer the case.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:
2:31 PM Changeset in webkit [108125] by Adam Roben
  • 4 edits in trunk

Clang/Mac build fix after r108119

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::randomCrashThread): Annotate this function with NO_RETURN_DUE_TO_CRASH.

Tools:

Mac build fix after r108119

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runThread):
(runPthread):
(testThreadIdentifierMap):
Updated to match current WTF threading APIs.

2:25 PM Changeset in webkit [108124] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Texture eviction doesn't show up in traces.
​https://bugs.webkit.org/show_bug.cgi?id=78851

Patch by David Reveman <​reveman@chromium.org> on 2012-02-17
Reviewed by James Robinson.

Add TextureManager::evictTexture() function with TRACE statement so
that texture eviction shows up in traces.

No new tests.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::evictTexture):
(WebCore):
(WebCore::TextureManager::reduceMemoryToLimit):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

2:22 PM Changeset in webkit [108123] by abarth@webkit.org
  • 1 delete in trunk/Source/WebCore/manual-tests

Remove empty directory.

2:21 PM Changeset in webkit [108122] by Lucas Forschler
  • 1 copy in tags/Safari-535.21

New Tag.

2:09 PM Changeset in webkit [108121] by jamesr@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Unreviewed - add some more fast/css/non-empty-span expectations.

  • platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.txt: Added.
2:00 PM Changeset in webkit [108120] by jamesr@google.com
  • 2 edits
    2 moves in trunk/LayoutTests

[chromium] Unreviewed baseline and expectation updates.

  • platform/chromium-linux/fast/css/non-empty-span-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png.
  • platform/chromium-linux/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt.
  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [108119] by commit-queue@webkit.org
  • 49 edits in trunk/Source

Remove unused parameters from WTF threading API
​https://bugs.webkit.org/show_bug.cgi?id=78389

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-17
Reviewed by Adam Roben.

waitForThreadCompletion() had an out param 'void result' to get the
'void *' returned by ThreadFunction. However, the implementation in
ThreadingWin.cpp ignored the out param, not filling it in. This had
led to a situation where none of the client code made use of the param
and just ignored it.

To clean this up, the patch changes the signature of ThreadFunction to
return void instead of void* and drops the the unused 'void result'
parameter from waitForThreadCompletion. Also, all client code is
updated for the API change.

As mentioned in ​https://bugs.webkit.org/show_bug.cgi?id=78389 , even
though the change only affects internal API, Safari is using it
directly and we'll need to keep the old versions around for ABI
compatibility. For this, the patch adds compatibility wrappers with
the old ABI.

Source/JavaScriptCore:

(JSC::SamplingThread::threadStartFunc):
(JSC::SamplingThread::stop):

  • bytecode/SamplingTool.h:

(SamplingThread):

  • heap/Heap.cpp:

(JSC::Heap::~Heap):
(JSC::Heap::blockFreeingThreadStartFunc):

  • heap/Heap.h:
  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

  • wtf/ParallelJobsGeneric.h:

(ThreadPrivate):

  • wtf/ThreadFunctionInvocation.h: Update the signature of

ThreadFunction.
(WTF):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint): Update for ThreadFunction signature change.
(WTF):
(WTF::ThreadFunctionWithReturnValueInvocation::ThreadFunctionWithReturnValueInvocation):
ABI compatibility function for Safari.
(ThreadFunctionWithReturnValueInvocation): Ditto.
(WTF::compatEntryPoint): Ditto.
(WTF::createThread): Ditto.
(WTF::waitForThreadCompletion): Ditto.

  • wtf/Threading.h: Update the signature of ThreadFunction and

waitForThreadCompletion.
(WTF):

  • wtf/ThreadingPthreads.cpp: Implement the new API.

(WTF::wtfThreadEntryPoint):
(WTF):
(WTF::createThreadInternal):
(WTF::waitForThreadCompletion):

  • wtf/ThreadingWin.cpp: Implement the new API.

(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion):

Source/WebCore:

  • bindings/js/GCController.cpp:

(WebCore::collect):
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):

  • fileapi/FileThread.cpp:

(WebCore::FileThread::fileThreadStart):
(WebCore::FileThread::runLoop):

  • fileapi/FileThread.h:

(FileThread):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::close):
(WebCore::IconDatabase::iconDatabaseSyncThreadStart):
(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::syncThreadMainLoop):

  • loader/icon/IconDatabase.h:

(IconDatabase):

  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::threadCallback):

  • page/scrolling/ScrollingThread.h:

(ScrollingThread):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::databaseLoaderEntry):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

  • platform/audio/ReverbConvolver.cpp:

(WebCore::backgroundThreadEntry):
(WebCore::ReverbConvolver::~ReverbConvolver):

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThreadStart):
(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseThread.h:

(DatabaseThread):

  • storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::threadEntryPointCallback):
(WebCore::LocalStorageThread::threadEntryPoint):
(WebCore::LocalStorageThread::terminate):

  • storage/LocalStorageThread.h:

(LocalStorageThread):

  • webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::threadEntry):

  • webaudio/AsyncAudioDecoder.h:

(AsyncAudioDecoder):

  • webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::renderEntry):

  • webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThreadStart):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/win:

  • WebKit.vcproj/WebKit_Cairo.def: Add the new functions.
  • WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.

Source/WebKit2:

  • Platform/WorkQueue.h:

(WorkQueue):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::startWorkQueueThread):

  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:

(WebKit::webThreadBody):

  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp:

(WebKit::webThreadBody):

  • UIProcess/Launcher/win/ThreadLauncherWin.cpp:

(WebKit::webThreadBody):

  • WebProcess/WebProcess.cpp:

(WebKit::randomCrashThread):

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
1:53 PM Changeset in webkit [108118] by dpranke@chromium.org
  • 2 edits in trunk/Tools

revert r107147 - breaks webkit-patch on Mac SL
​https://bugs.webkit.org/show_bug.cgi?id=78866

Reviewed by Adam Barth.

It appears that zipfile.ExtractAll is broken on Python 2.6.1,
which is the version that ships on Mac SL. Reverting this
change until we no longer have to worry about that version.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller):
(AutoInstaller._extract_all): Added a comment about SL.
(AutoInstaller._unzip):

1:48 PM Changeset in webkit [108117] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

AppleMac Build fix for r108111

Remove variable that is now unused.

Unreviewed, build fix.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::alwaysRequiresLineBox): Remove lineInfo
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

1:40 PM Changeset in webkit [108116] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] GL_CHROMIUM_gpu_memory_manager extension
​https://bugs.webkit.org/show_bug.cgi?id=77155

Patch by Michal Mocny <​mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):

Source/WebKit/chromium:

  • public/platform/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • src/GraphicsContext3DPrivate.h:

(WebCore):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):

1:40 PM WebDevelopers edited by michael-gawlik@web.de
(diff)
1:36 PM Changeset in webkit [108115] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html
​https://bugs.webkit.org/show_bug.cgi?id=78859

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [108114] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk/LayoutTests

[chromium] Rebaseline tests for composited filters
​https://bugs.webkit.org/show_bug.cgi?id=78903

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-17
Reviewed by Stephen White.

  • compositing/culling/filter-occlusion-alpha-large.html:
  • compositing/culling/filter-occlusion-alpha.html:
  • compositing/culling/filter-occlusion-blur-large.html:
  • compositing/culling/filter-occlusion-blur.html:
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
1:23 PM Changeset in webkit [108113] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

[chromium] Update baselines for border-radius-wide-border-01 due to skia change. Unreviewed.

  • platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
1:17 PM Changeset in webkit [108112] by oliver@apple.com
  • 15 edits
    3 adds in trunk

Implement Error.stack
​https://bugs.webkit.org/show_bug.cgi?id=66994

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCStack):

  • parser/Nodes.h:

(JSC::FunctionBodyNode::setInferredName):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):

  • runtime/Error.h:

(JSC):

LayoutTests:

Add testcases for producing a stack trace on exception objects.

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):

  • fast/js/stack-trace-expected.txt: Added.
  • fast/js/stack-trace.html: Added.
1:10 PM Changeset in webkit [108111] by robert@webkit.org
  • 4 edits
    5 adds in trunk

REGRESSION: empty span creates renders with non-zero height
​https://bugs.webkit.org/show_bug.cgi?id=76465

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/empty-span.html

fast/css/non-empty-span.html

Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.

This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size

will need a linebox if the rest of the line is not empty.

(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark

the line non-empty - otherwise hold off.

LayoutTests:

  • fast/css/empty-span-expected.html: Added.
  • fast/css/empty-span.html: Added.
  • fast/css/non-empty-span.html: Added.
  • platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.
12:57 PM Changeset in webkit [108110] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

RealtimeAnalyserNode does not consistently respect .minDecibels
​https://bugs.webkit.org/show_bug.cgi?id=78729

Make use of m_minDecibel consistent. Clean up some style issues
with names of local variables and style issues with float
constants.

Patch by Raymond Toy <Raymond Toy> on 2012-02-17
Reviewed by Chris Rogers.

No new tests because the changes are cosmetic for style issues.

  • webaudio/RealtimeAnalyser.cpp:

(WebCore):
(WebCore::RealtimeAnalyser::doFFTAnalysis):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):

12:51 PM Changeset in webkit [108109] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

:before content incorrectly placed in continuation
when we don't have a first child.
​https://bugs.webkit.org/show_bug.cgi?id=78380

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css-generated-content/before-content-continuation-chain.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/css-generated-content/before-content-continuation-chain-expected.png: Added.
  • fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
  • fast/css-generated-content/before-content-continuation-chain.html: Added.
12:44 PM Changeset in webkit [108108] by mihnea@adobe.com
  • 34 edits
    3 adds in trunk

CSS regions enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=78525

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/css-regions-disabled.html

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::createRegionRule):

  • css/CSSParser.h:
  • dom/Document.cpp:

(WebCore::Document::cssRegionsEnabled):
(WebCore):
(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setCSSRegionsEnabled):
(WebCore::Settings::cssRegionsEnabled):
(Settings):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

Source/WebKit/chromium:

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setExperimentalCSSRegionsEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Source/WebKit/mac:

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssRegionsEnabled]):
(-[WebPreferences setCSSRegionsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSRegionsEnabled):
(WKPreferencesGetCSSRegionsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

  • fast/regions/css-regions-disabled-expected.txt: Added.
  • fast/regions/css-regions-disabled.html: Added.
  • fast/regions/script-tests/css-regions-disabled.js: Added.

(testWebKitFlowInto):
(testWebKitFlowFrom):
(testWebKitRegionOverflow):
(testComputedStyleWebKitFlowInto):
(testComputedStyleWebKitFlowFrom):
(testComputedStyleWebKitRegionOverflow):

12:09 PM Changeset in webkit [108107] by mhahnenberg@apple.com
  • 16 edits
    4 adds
    4 deletes in trunk/Source/JavaScriptCore

Rename Bump* to Copy*
​https://bugs.webkit.org/show_bug.cgi?id=78573

Reviewed by Geoffrey Garen.

Renamed anything with "Bump" in the name to have "Copied" instead.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • heap/BumpBlock.h: Removed.
  • heap/BumpSpace.cpp: Removed.
  • heap/BumpSpace.h: Removed.
  • heap/BumpSpaceInlineMethods.h: Removed.
  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):

  • heap/ConservativeRoots.h:

(ConservativeRoots):

  • heap/CopiedBlock.h: Added.

(JSC):
(CopiedBlock):
(JSC::CopiedBlock::CopiedBlock):

  • heap/CopiedSpace.cpp: Added.

(JSC):
(JSC::CopiedSpace::tryAllocateSlowCase):

  • heap/CopiedSpace.h: Added.

(JSC):
(CopiedSpace):
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::totalMemoryAllocated):
(JSC::CopiedSpace::totalMemoryUtilized):

  • heap/CopiedSpaceInlineMethods.h: Added.

(JSC):
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::pin):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::recycleBlock):
(JSC::CopiedSpace::getFreshBlock):
(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::fitsInCurrentBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::allocateFromBlock):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::isOversize):
(JSC::CopiedSpace::isPinned):
(JSC::CopiedSpace::oversizeBlockFor):
(JSC::CopiedSpace::blockFor):

  • heap/Heap.cpp:
  • heap/Heap.h:

(JSC):
(Heap):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):

  • heap/SlotVisitor.h:

(SlotVisitor):

  • runtime/JSArray.cpp:
  • runtime/JSObject.cpp:
12:07 PM Changeset in webkit [108106] by mjs@apple.com
  • 2 edits in trunk/Tools

Some API tests erroneously use = instead of == (causing build failures)
​https://bugs.webkit.org/show_bug.cgi?id=78915

Reviewed by Sam Weinig.

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
(TestWebKitAPI::decidePolicyForNewWindowAction): ditto

12:05 PM Changeset in webkit [108105] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Case typo in fast/js/script-tests/date-constructor.js
​https://bugs.webkit.org/show_bug.cgi?id=78898

Patch by Seo Sanghyeon <​sh4.seo@samsung.com> on 2012-02-17
Reviewed by Adam Barth.

  • fast/js/script-tests/date-constructor.js: toSTring to toString
12:00 PM Changeset in webkit [108104] by Martin Robinson
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] [AC] Events can starve accelerated compositing updates
​https://bugs.webkit.org/show_bug.cgi?id=78826

Reviewed by Gustavo Noronha Silva.

Instead of using a WebCore timer, which can be starved by GdkEvents,
use a raw GLib timer with GDK_PRIORITY_EVENTS to drive AC updates.
This prevents dragging from blocking rendering.

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Store a GLib source tag instead of a WebCore timer.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.

11:58 AM Changeset in webkit [108103] by mihnea@adobe.com
  • 9 edits
    2 adds in trunk

[CSSRegions]Implement NamedFlow::overflow
​https://bugs.webkit.org/show_bug.cgi?id=78880

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-named-flow-overflow.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::overflow):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::ensureNamedFlow):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderFlowThread.h:

LayoutTests:

  • fast/regions/resources/helper.js:

(testContentToRegionsMapping):

  • fast/regions/resources/region-style.css:
  • fast/regions/webkit-named-flow-overflow-expected.txt: Added.
  • fast/regions/webkit-named-flow-overflow.html: Added.
11:56 AM Changeset in webkit [108102] by commit-queue@webkit.org
  • 19 edits in trunk

flex-wrap:nowrap should be flex-wrap:none
​https://bugs.webkit.org/show_bug.cgi?id=78772

As per the spec ​http://dev.w3.org/csswg/css3-flexbox/#flex-wrap0, flex-wrap:nowrap should be changed to flex-wrap:none.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-17
Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
11:54 AM Changeset in webkit [108101] by enrica@apple.com
  • 14 edits in trunk/Source

Refactor DragData class to use PlatformStrategies in the Mac implementation.
​https://bugs.webkit.org/show_bug.cgi?id=78768

Reviewed by Darin Adler.

Source/WebCore:

No new tests. No behavior change.

  • WebCore.exp.in: Added new exported method of the PlatformPasteboard class.
  • platform/DragData.h:

(WebCore::DragData::pasteboardName): Added pasteboardName and removed pasteboard.

  • platform/PasteboardStrategy.h: Added color() method.
  • platform/PlatformPasteboard.h: Ditto.
  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create): Changed to use pasteboardName() method.

  • platform/mac/DragDataMac.mm: All the methods below have been changed to use pasteboardName

and the pasteboardStrategy() methods.
(WebCore::DragData::DragData):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::color): Added implementation of the color() method.

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h: Added color() method.
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::color):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added color() method.

(WebKit::WebPlatformStrategies::color):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
11:45 AM Changeset in webkit [108100] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
​https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

11:08 AM Changeset in webkit [108099] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] pack Gamepad shared memory structure
​https://bugs.webkit.org/show_bug.cgi?id=78022

Patch by Scott Graham <​scottmg@chromium.org> on 2012-02-17
Reviewed by Darin Fisher.

Add #pragma pack around definition of shared memory structures to
avoid differences across compilers and platforms. Add COMPILE_ASSERT
to verify expected size.

  • public/platform/WebGamepad.h:

(WebKit):

  • public/platform/WebGamepads.h:

(WebKit):

11:02 AM Changeset in webkit [108098] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

Table cell's anonymous wrappers are left in the tree, impacting our layout
​https://bugs.webkit.org/show_bug.cgi?id=7180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-switch-cell-position-bad-layout-expected.html

fast/table/table-switch-cell-position-bad-layout.html

This patch implements cell's anonymous wrapper removal at detach time.

Trimming the render tree when we remove objects from it would be more complex
to generalize as several objects override the behavior to do their own clean-ups.
This would also open more potential for programming errors.

This change is limited to table cells' as a simple step towards fixing bug 52123
and more generally eliminate some anonymous wrappers from the tree at detach time.

  • dom/Node.cpp:

(WebCore::Node::detach):
Patched detach to call destroyAndCleanupAnonymousWrappers. The Document does not need
to clean up any anonymous wrappers on detach.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Added this method to wrap destroy() call and trim the render tree. To avoid slowing down
detach in some cases, added a fast path.

  • rendering/RenderObject.h: Added destroyAndCleanupAnonymousWrappers.

LayoutTests:

  • fast/table/table-switch-cell-position-bad-layout-expected.html: Added.
  • fast/table/table-switch-cell-position-bad-layout.html: Added.
11:00 AM Changeset in webkit [108097] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT (and crash) with dynamically moved <font-face>
​https://bugs.webkit.org/show_bug.cgi?id=64839

Reviewed by Antti Koivisto.

Source/WebCore:

Reset the style declaration when rmeoving the font-face element from the document.

Test: svg/custom/font-face-move.svg

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::removedFromDocument):

LayoutTests:

  • svg/custom/font-face-move-expected.txt: Added.
  • svg/custom/font-face-move.svg: Added.
10:55 AM Changeset in webkit [108096] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r107966.

10:51 AM Changeset in webkit [108095] by Martin Robinson
  • 6 edits in trunk/Source

Fix some warnings encountered during the GTK+ build
​https://bugs.webkit.org/show_bug.cgi?id=78911

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. These are just fixes for warnings.

  • page/GestureTapHighlighter.cpp: Avoid using potentially signed operations on

a size_t type. Use size_t for iterating over members of a vector.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp: Use size_t where necessary.

(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded): Ditto.

  • platform/graphics/texmap/TextureMapperLayer.cpp: Ditto.

(WebCore::TextureMapperLayer::computeTransformsRecursive): Ditto.
(WebCore::TextureMapperLayer::paintSelfAndChildren): Ditto.
(WebCore::TextureMapperLayer::intermediateSurfaceRect): Ditto.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Initialize a new member of the loader client struct.

10:47 AM Changeset in webkit [108094] by rniwa@webkit.org
  • 5 edits
    1 add in trunk

perf-o-matic needs model unit tests
​https://bugs.webkit.org/show_bug.cgi?id=78885

Reviewed by Adam Barth.

Added unit tests for models.py.

Also renamed modelFromNumericId to model_from_numeric_id and moved set_persitent_cache and get_persistent_cache
from controller to PersistentCache.set_cache and PersistentCahce.set_cache respectively.

  • Websites/webkit-perf.appspot.com/controller.py:

(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_builder):
(CreateHandler._create_builder.execute):

  • Websites/webkit-perf.appspot.com/models.py:

(create_in_transaction_with_numeric_id_holder):
(model_from_numeric_id):
(Builder):
(Builder.create):
(Builder.update_password):
(Builder._hashed_password):
(TestResult.key_name):
(ReportLog.get_value):
(ReportLog._integer_in_payload):
(ReportLog):
(ReportLog.timestamp):
(PersistentCache):
(PersistentCache.set_cache):
(PersistentCache.set_cache.execute):
(PersistentCache.get_cache):

  • Websites/webkit-perf.appspot.com/models_unittest.py: Added.

(HelperTests):
(HelperTests.setUp):
(HelperTests.tearDown):
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_model_from_numeric_id):
(HelperTests.test_model_from_numeric_id.execute):
(BuilderTests):
(BuilderTests.setUp):
(BuilderTests.tearDown):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(ReportLog):
(ReportLog.setUp):
(ReportLog.tearDown):
(ReportLog._create_log_with_payload):
(ReportLog.test_parsed_payload):
(ReportLog.test_get_value):
(ReportLog.test_results):
(ReportLog.test_builder):
(ReportLog.test_build_number):
(ReportLog.test_webkit_revision):
(ReportLog.chromium_revision):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.tearDown):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

10:27 AM Changeset in webkit [108093] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Refactor video drawing to be more data driven
​https://bugs.webkit.org/show_bug.cgi?id=76720

Patch by Tim Dresser <​tdresser@chromium.org> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

CCVideoLayerImpl no longer handles drawing itself, but produces a list of CCVideoDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
CCLayerImpl::didDraw() is called directly after all drawing has been completed.
CCLayerImpl::draw has been removed.

willDraw and didDraw are used to handle interaction with the VideoFrameProvider
in CCVideoLayerImpl. willDraw gets a frame from the VideoFrameProvider, and
didDraw returns it.

A unit test has been added: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers.
This test ensures that CCLayerImpl::didDraw() is called on all layers,
including layers on different render surfaces.

As this was a refactor, no other tests were added.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore):
(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore::LayerRendererChromium::copyFrameToTextures):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::didDraw):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::textures):
(WebCore::CCVideoDrawQuad::frame):
(WebCore::CCVideoDrawQuad::format):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::providerMutex):
(WebCore::CCVideoLayerImpl::provider):
(Texture):

Source/WebKit/chromium:

CCLayerTreeHostImplTest.didDrawCalledOnAllLayers ensures that
CCLayerImpl::didDraw() is called on all layers, including layers
on different render surfaces.

  • tests/CCLayerTreeHostImplTest.cpp:

(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::create):
(WebKit::DidDrawCheckLayer::didDraw):
(WebKit::DidDrawCheckLayer::didDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit):
(WebKit::TEST_F):

10:19 AM Changeset in webkit [108092] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Allow printing scaled pages in WebKit2 for printers that don't support it
​https://bugs.webkit.org/show_bug.cgi?id=78823

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable scale option in print
dialog.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
manual scale to 1.
(WebKit::WebPrintOperationGtk::rotatePageIfNeeded): Renamed and
moved the needs rotate check here as an early return.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Scale the
page according to the manual scale factor.
(WebKit::WebPrintOperationGtk::renderPage): Move rotatePage to
prepareContextToDraw.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
10:17 AM Changeset in webkit [108091] by adamk@chromium.org
  • 11 edits in branches/chromium/1025/Source

Merge 107170 - DOM mutations should not be delivered on worker threads
​https://bugs.webkit.org/show_bug.cgi?id=77898

Reviewed by Dmitry Titov.

Source/WebCore:

In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.

This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).

Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.

See also ​http://crbug.com/112586, where the problem was initially
reported.

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::call):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

  • bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):

Source/WebKit/chromium:

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

TBR=​adamk@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9355009

10:09 AM Changeset in webkit [108090] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Include TestShellLinux.cpp in the build for Android
​https://bugs.webkit.org/show_bug.cgi?id=78865

Reviewed by Eric Seidel.

Android will be re-using the TestShellLinux.cpp file. I already
added this r104033, but it seems to have gotten lost in the
recent refactorings.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
10:08 AM Changeset in webkit [108089] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Allow printing multiple copies in WebKit2 for printers that don't support it
​https://bugs.webkit.org/show_bug.cgi?id=78805

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable multiple copies and
collate options in print dialog.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize number of
collated and uncolated copies done and total.
(WebKit::PrintPagesData::collatedCopiesLeft): Helper function that
returns the number of collated copies left to do.
(WebKit::PrintPagesData::uncollatedCopiesLeft): Helper function
that returns the number of uncollated copies left to do.
(WebKit::PrintPagesData::copiesLeft): Helper function
that returns the number of collated or uncollated copies left to
do.
(WebKit::PrintPagesData::incrementPageSequence): Do not finish the
print if there are uncollated copies left, and do not increment
sheet number if there are collated copies left.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualCopies to 1 and m_manualCollateCopies to false.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
10:05 AM Changeset in webkit [108088] by jchaffraix@webkit.org
  • 6 edits
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed Chromium rebaseline after r107971.

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs: Removed.
  • platform/chromium/test_expectations.txt:
10:00 AM Changeset in webkit [108087] by jamesr@google.com
  • 6 edits
    1 copy
    2 moves
    2 adds
    4 deletes in trunk/LayoutTests

[chromium] Unreviewed, update chromium pixel baselines for r108079

  • fast/borders/border-mixed-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-mixed-alpha-expected.txt.
  • fast/borders/only-one-border-with-width-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/only-one-border-with-width-expected.txt.
  • platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-leakage-expected.png: Added.
  • platform/chromium-win/fast/borders/border-mixed-alpha-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
  • platform/chromium-win/fast/borders/only-one-border-with-width-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png.
  • platform/chromium-win/fast/css/color-leakage-expected.png:
  • platform/mac/fast/borders/border-mixed-alpha-expected.txt: Removed.
  • platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/qt/fast/borders/border-mixed-alpha-expected.txt: Removed.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed.
9:43 AM Changeset in webkit [108086] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Allow printing pages in reverse order in WebKit2 for printers that don't support it
​https://bugs.webkit.org/show_bug.cgi?id=78799

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable printing in reverse
order option in print dialog.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and lastPagePosition depending on whether printing is in reverse
order or not.
(WebKit::PrintPagesData::incrementPageSequence): Use a negative
increment step when printing in reverse order. Fix page
incrementing when printing only odd/even pages broken in previous
commit due to merge conflicts.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
reverse printing to false.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
9:25 AM Changeset in webkit [108085] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Allow printing only odd/even pages in WebKit2 for printers that don't support it
​https://bugs.webkit.org/show_bug.cgi?id=78793

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable print odd/even pages
option in print dialog.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Add lastPagePosition and
initialize it depending on the page set.
(WebKit::PrintPagesData::incrementPageSequence): Use 2 step
increment when printing only odd/even pages.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualPageSet to GTK_PAGE_SET_ALL.

9:10 AM WebKit Team edited by Dimitri Glazkov
(diff)
9:06 AM Changeset in webkit [108084] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Crash at WebCore::SVGUseElement::expandSymbolElementsInShadowTree
​https://bugs.webkit.org/show_bug.cgi?id=77639

Patch by Stephen Chenney <​schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
The crash occurred when an SVG use element attempted to reference a style element while the file
contained an error causing the error banner to display. The fix is to prevent SVGUseElement
from recalculating style during tree building and return immediately when style is recalculated and
the tree is building.

Test: svg/custom/use-referencing-style-crash.svg

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle): Return false if the tree is being built.
(WebCore::SVGUseElement::didRecalcStyle): Check and return if the tree
is being built and we are not yet ready for style update.

LayoutTests:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
This test is to verify no crash in Release builds, while expectations/Skipped
are added for Debug builds. Bug 77764 tracks the Debug fix.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • svg/custom/use-referencing-style-crash-expected.txt: Added.
  • svg/custom/use-referencing-style-crash.svg: Added.
8:55 AM Changeset in webkit [108083] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r108077.
​http://trac.webkit.org/changeset/108077
​https://bugs.webkit.org/show_bug.cgi?id=78390

it broke compilation.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

8:50 AM Changeset in webkit [108082] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV@NULL (e85cb8e140071fa7790cad215b0109dc)
​https://bugs.webkit.org/show_bug.cgi?id=74858

Patch by Florin Malita <​fmalita@google.com> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/custom/tref-remove-target-crash-expected.svg

svg/custom/tref-remove-target-crash.svg

Add a DOMNodeRemovedFromDocumentEvent listener to detect when the target element is removed. Upon removal,
cleanup all listeners and re-activate the pending resource to attach if the referenced ID is added
at a later time programmatically. Also move the DOMSubtreeModifiedEvent listener from the parent to
the target element to simplify the implementation and reduce the scope.

  • svg/SVGTRefElement.cpp:

(WebCore::TargetListener::create):
(WebCore::TargetListener::cast):
(WebCore::TargetListener::clear):
(WebCore::TargetListener::TargetListener):
(WebCore::TargetListener::operator==):
(WebCore::TargetListener::handleEvent):
(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

  • svg/SVGTRefElement.h:

LayoutTests:

  • svg/custom/tref-remove-target-crash-expected.svg: Added.
  • svg/custom/tref-remove-target-crash.svg: Added.
8:48 AM Changeset in webkit [108081] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the build after r108077.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Any.generate_validate_method):

8:42 AM Changeset in webkit [108080] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Allow printing multiple pages per sheet in WebKit2 for printers that don't support it
​https://bugs.webkit.org/show_bug.cgi?id=78715

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable multiple pages per
sheet options in print dialog.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and numberOfSheets. Move pagePosition to WebPrintOperationGtk.
(WebKit::PrintPagesData::incrementPageSequence): Increment current
sheet and page position.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk):
(WebKit::WebPrintOperationGtk::currentPageIsFirstPageOfSheet):
Helper function to check whether current pages is the first one of
the current sheet.
(WebKit::WebPrintOperationGtk::currentPageIsLastPageOfSheet):
Helper function to check whether current pages is the last one of
the current sheet.
(WebKit::WebPrintOperationGtk::getRowsAndColumnsOfPagesPerSheet):
Returns the number of rows and columns of pages per sheet.
(WebKit::WebPrintOperationGtk::getPositionOfPageInSheet): Returns
the row and column number of the current page in the current sheet.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Translate,
scale and rotate accordingly to render every page in the right
place of the sheet.
(WebKit::WebPrintOperationGtk::renderPage): Call
prepareContextToDraw() before drawing the page.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::setNumberOfPagesToPrint):
(WebKit::WebPrintOperationGtk::pagePosition):
(WebKit::WebPrintOperationGtk::setPagePosition):
(WebKit::WebPrintOperationGtk::numberUp):
(WebKit::WebPrintOperationGtk::numberUpLayout):

8:40 AM Changeset in webkit [108079] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid using a transparency layer for rgba() border drawing when possible
​https://bugs.webkit.org/show_bug.cgi?id=63176

Reviewed by Dan Bernstein.

The non-radiused border drawing code would use a transparency layer
when drawing any one or more borders with alpha colors. However,
we only need to use a transparency layer when there is a corner
join between the borders being rendered with any one color,
so add a utility function includesAdjacentEdges() that can tell us
that, and use it to avoid making extraneous transparency layers.

Optimization only, no new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::includesAdjacentEdges):
(WebCore):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

8:39 AM Changeset in webkit [108078] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-02-17 Pavel Feldman <​pfeldman@google.com>

Not reviewed: Qt minimal build fix.

  • inspector/InjectedScript.h: (WebCore):
8:25 AM Changeset in webkit [108077] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Switch Debugger agent to TypeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-17
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

8:17 AM Changeset in webkit [108076] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: hide color picker on selected node update.
​https://bugs.webkit.org/show_bug.cgi?id=78896

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.prototype.get visible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

8:13 AM Changeset in webkit [108075] by pfeldman@chromium.org
  • 3 edits
    4 adds in trunk

Web Inspector: check undo-redo boundaries based on current action index, not history size.
​https://bugs.webkit.org/show_bug.cgi?id=78895

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests: inspector/elements/perform-undo-undo.html

inspector/styles/perform-undo-perform-of-mergable-action.html

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::perform):

LayoutTests:

  • inspector/elements/perform-undo-undo-expected.txt: Added.
  • inspector/elements/perform-undo-undo.html: Added.
  • inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Added.
  • inspector/styles/perform-undo-perform-of-mergable-action.html: Added.
8:06 AM Changeset in webkit [108074] by loislo@chromium.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r108071.
​http://trac.webkit.org/changeset/108071
​https://bugs.webkit.org/show_bug.cgi?id=77155

chromium-mac compilation failed

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

  • public/platform/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

  • src/GraphicsContext3DPrivate.h:

(WebCore):

  • tests/FakeWebGraphicsContext3D.h:
7:53 AM Changeset in webkit [108073] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skipping 2 new test failures on GTK.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
7:48 AM Changeset in webkit [108072] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspecter: Unreviewed. Adjust expectation for script-formatter-console.html

  • platform/chromium/test_expectations.txt:
7:41 AM Changeset in webkit [108071] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] GL_CHROMIUM_gpu_memory_manager extension
​https://bugs.webkit.org/show_bug.cgi?id=77155

Patch by Michal Mocny <​mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):

Source/WebKit/chromium:

  • public/platform/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • src/GraphicsContext3DPrivate.h:

(WebCore):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):

6:42 AM Changeset in webkit [108070] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed, adapt to the changes introduced in r107973.

SVN r107973 moved some libsoup feature initialization code to
WebCore, but only changed the GTK+ bits in WebKit.

  • ewk/ewk_main.cpp:

(_ewk_init_body): Do not initialize the content sniffer and the
decoder here, the initialization is now done in WebCore.

6:32 AM Changeset in webkit [108069] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

[GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=78893

Reviewed by Gustavo Noronha Silva.

And it's not emitted anynmore when the print dialog has been
cancelled. Since it's not possible to know whether the print
dialog was cancelled or not, the enum WebKitPrintOperationResponse
has been added, with Print and Cancel values, and it's used as
return value of webkit_print_operation_run_dialog().

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkit_print_operation_class_init): Rename done as finished.
(webkitPrintOperationRunDialogUnix): Return a
WebKitPrintOperationResponse instead of bool.
(webkitPrintOperationRunDialogWin32): Ditto.
(drawPagesForPrintingCompleted): Emit finished instead of done.
(webkitPrintOperationRunDialogForFrame): Do not emit finished if
the dialog was cancelled and return a WebKitPrintOperationResponse.
(webkit_print_operation_run_dialog): Return
WebKitPrintOperationResponse.

  • UIProcess/API/gtk/WebKitPrintOperation.h: Add

WebKitPrintOperationResponse enum.

  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Check whether the dialog has been
cancelled or not and connect to finish when the print operation is
in progress to release the print operation object when printing
finishes.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

WebKitPrintOperationResponse symbol.

  • UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrintFinished): Use finished instead of done.
(testPrintOperationPrint): Ditto.

6:25 AM Changeset in webkit [108068] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Add webkit_print_operation_print() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=76536

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationPrintPagesForFrame): Helper function to call
WebPageProxy::drawPagesForPrinting using the given
GtkPrintSettings and GtkPageSetup.
(webkitPrintOperationRunDialogForFrame): Use
webkitPrintOperationPrintPagesForFrame().
(webkit_print_operation_print): Print directly using current
GtkPrintSettings and GtkPageSetup without showing the print
dialog.

  • UIProcess/API/gtk/WebKitPrintOperation.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrintLoadChanged):
(testPrintOperationPrintDone):
(testPrintOperationPrintPrinter):
(testPrintOperationPrint):
(beforeAll):
(afterAll):

6:19 AM Changeset in webkit [108067] by kubo@profusion.mobi
  • 3 edits in trunk/Source/WebCore

[CMake, EFL] Unreviewed, fix the build when building with
SHARED_CORE=ON after r107820.

RunLoopEfl.cpp has not been upstreamed yet, and building only
RunLoop.cpp created an .so with some missing, unimplemented
symbols. The BlackBerry port seems to be in the same situation.

The best solution for now is to build RunLoop.cpp only on the
WinCE port.

  • CMakeLists.txt: Remove RunLoop.cpp from the list of files to build.
  • PlatformWinCE.cmake: Add RunLoop.cpp to the list of files to build.
5:40 AM Changeset in webkit [108066] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed, fix the build with ENABLE(DEVICE_ORIENTATION) after
r107518. The EFL EWS bot doesn't enable that flag, so the breakage
was not spotted earlier.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

5:14 AM Changeset in webkit [108065] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: a bit of color picker polish
​https://bugs.webkit.org/show_bug.cgi?id=78892

  • Fixed computed style swatch
  • Removed color: caption
  • Rendered value as source code, user-selectable
  • Removed scroller gap

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/Spectrum.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/elementsPanel.css:

(.spectrum-container):
(.spectrum-display-value):
(.spectrum-range-container):

  • inspector/front-end/popover.css:

(.popover .content.fixed-height):

5:14 AM Changeset in webkit [108064] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Chromium DEPS roll

  • DEPS: from 122122 to 122498
4:45 AM Changeset in webkit [108063] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, disable video build on EFL until it can be
supported by EFL build bot.

  • Scripts/build-webkit:
4:31 AM Changeset in webkit [108062] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: color picker does not allow changing the color.
​https://bugs.webkit.org/show_bug.cgi?id=78886

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._showPopover.showPopover):

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/Settings.js:
  • inspector/front-end/Spectrum.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

4:28 AM Changeset in webkit [108061] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: new image preview has poorly positioned popover arrow.
​https://bugs.webkit.org/show_bug.cgi?id=78884

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/utilities.js:

(Element.prototype.boxInWindow):

4:23 AM Changeset in webkit [108060] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #34 of N. Restore/move following tests back in BUGCR9950
group with a WIN exception for an IMAGE failure.

WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE

  • platform/chromium/test_expectations.txt:
3:41 AM Changeset in webkit [108059] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: enable "Single click CSS editing" experiment by default.
​https://bugs.webkit.org/show_bug.cgi?id=78881

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/elementsPanel.css:

(.styles-section .properties .enabled-button):

3:40 AM Changeset in webkit [108058] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: split innerUpdate into rebuildUpdate and refreshUpdate, make computed styles load lazily.
​https://bugs.webkit.org/show_bug.cgi?id=78827

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._validateNode):
(WebInspector.StylesSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylesSidebarPane.prototype._innerRefreshUpdate):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

  • inspector/styles/undo-add-property.html:
  • inspector/styles/undo-change-property.html:
  • inspector/styles/updates-during-dom-traversal.html:
  • inspector/styles/updates-throttled.html:
3:11 AM Changeset in webkit [108057] by noel.gordon@gmail.com
  • 8 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #32 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium/test_expectations.txt:
3:09 AM Changeset in webkit [108056] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Implement zoom in/out in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=75253

Reviewed by Gustavo Noronha Silva.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(zoomInCallback):
(zoomOutCallback):
(browser_window_init):
(browserWindowConstructed):

3:09 AM Changeset in webkit [108055] by noam.rosenthal@nokia.com
  • 7 edits in trunk/Source

[Qt][WK2] Allow partial updates
​https://bugs.webkit.org/show_bug.cgi?id=78824

Source/WebCore:

BitmapTextureGL should not zero-fill the textures when resetting.
This was needed in the previous buffer management system, where texture were not completely
filled by the backing store.

Reviewed by Simon Hausmann.

No new behavior.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(BitmapTextureGL):
(WebCore::texSubImage2DResourceSafe):
(WebCore):
(WebCore::BitmapTextureGL::reset):

Source/WebKit2:

Instead of using UpdateInfo to fill the entire tile's texture, we use it as a patch that
contains only the dirty rectangle of the current paint. This requires a lot less memory
for small updates, for example when typing a text in an input field.
This shows a significant reduction in overhead when testing on Mac with Instruments.

Reviewed by Simon Hausmann.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit):
(WebKit::LayerBackingStore::updateTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

3:07 AM Changeset in webkit [108054] by Nikolas Zimmermann
  • 2 edits in trunk/Tools

layoutTestController.display() is flaky for SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Adam Roben.

Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
Size the web view before running the test, not when dumping.
All platforms handle this correctly now.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(sizeWebViewForCurrentTest):
(runTest):

2:37 AM Changeset in webkit [108053] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Fix GTK+ build after r108003.

  • Source/autotools/symbols.filter: Add missing symbol.
2:28 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
set environment variables for sysroot before building (diff)
2:25 AM WebKitIDL edited by haraken@chromium.org
(diff)
2:22 AM WebKitIDL edited by haraken@chromium.org
(diff)
2:15 AM WebKitIDL edited by haraken@chromium.org
(diff)
1:47 AM Changeset in webkit [108052] by noel.gordon@gmail.com
  • 8 edits
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #33 of N. See also bug 78219.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/test_expectations.txt:
1:25 AM WebKitGTK/WebKit2Roadmap created by Carlos Garcia Campos
1:22 AM Changeset in webkit [108051] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType::setValue
​https://bugs.webkit.org/show_bug.cgi?id=78873

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-17
Reviewed by Kent Tamura.

This patch moves event dispatch logic to InputType and TextFieldInputType from HTMLInputElement
and merge dispatchChangeEventInResponseToSetValue to setValue.

No new tests. No change in behavior.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Move dispatch logic to InputType and TextFieldInput.

  • html/InputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
  • html/InputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.

(WebCore::InputType::setValue): Move code from dispatchChangeEventInResponseToSetValue.

  • html/TextFieldInputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
  • html/TextFieldInputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.

(WebCore::TextFieldInputType::setValue): Move code from dispatchChangeEventInResponseToSetValue. Stop dispatching event in InputType::setValue.

  • html/HTMLTextFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent to public from protected for accessing from InputType class.
1:22 AM WebKitIDL edited by haraken@chromium.org
(diff)
1:09 AM Changeset in webkit [108050] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-02-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mac build fix after r108047.

  • WebCore.xcodeproj/project.pbxproj:
1:01 AM Changeset in webkit [108049] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Removing the last presentation attribute should result in a null attributeStyle().
<​http://webkit.org/b/78812>

Reviewed by Antti Koivisto.

If the collectStyleForAttribute() pass in updateAttributeStyle() doesn't encounter any
respected presentation attributes, set a null attributeStyle() instead of an empty one.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

12:44 AM Changeset in webkit [108048] by noel.gordon@gmail.com
  • 4 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #31 of N. Any reasons for the MAC exception have been lost
in time, like tears in rain. Remove the MAC exception, update all pixel results.

  • platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium/test_expectations.txt:
12:33 AM Changeset in webkit [108047] by yurys@chromium.org
  • 19 edits
    2 adds in trunk/Source/WebCore

Web Inspector: use static counters for estimation of allocated Documents, Nodes and JS EventListeners
​https://bugs.webkit.org/show_bug.cgi?id=78825

Introduced static counters of allocated Documents, Nodes and JS EventListeners.
Their values are displayed on the Timeline panel.

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • English.lproj/localizedStrings.js:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorCounters.cpp: Added.

(WebCore):
(WebCore::InspectorCounters::counterValue):

  • inspector/InspectorCounters.h: Added.

(WebCore):
(InspectorCounters):
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getDocumentCount):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):

12:08 AM Changeset in webkit [108046] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r108034.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
12:06 AM Changeset in webkit [108045] by noel.gordon@gmail.com
  • 8 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #30 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.