Timeline
Aug 20, 2012:
- 11:50 PM Changeset in webkit [126138] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
https://bugs.webkit.org/show_bug.cgi?id=94558
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.run_test):
- 11:50 PM Changeset in webkit [126137] by
-
- 7 edits in trunk/Source/WebCore
[V8] Move handleOutOfMemory() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94563
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves handleOutOfMemory() from V8Proxy to V8Binding.
No tests. No change in behavior.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::runScript):
- 11:49 PM Changeset in webkit [126136] by
-
- 6 edits in trunk/Source/WebCore
InsertionShouldCallDidNotifyDescendantInsertions should be merged to InsertionShouldCallDidNotifySubtreeInsertions
https://bugs.webkit.org/show_bug.cgi?id=94570
Reviewed by Ryosuke Niwa.
Node::didNotifySubtreeInsertions() and Node::didNotifyDescendantInsertions() are used for similar purpose and
we could unify them to the safer one, which is didNotifySubtreeInsertions().
This change replaces the last didNotifyDescendantInsertions() implementation in HTMLBodyElement with didNotifySubtreeInsertions()
then eliminates related code which is no longer used.
No new tests. Covered by existing tests.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
- dom/Node.h: Removed didNotifyDescendantInsertions() stub and InsertionShouldCallDidNotifyDescendantInsertions enum value.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifySubtreeInsertions): morphed from didNotifyDescendantInsertions()
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto): Remove useless InsertionShouldCallDidNotifyDescendantInsertions return statement.
- 10:56 PM Changeset in webkit [126135] by
-
- 4 edits in trunk/Tools
Cleanup TestExpectationParser.parse
https://bugs.webkit.org/show_bug.cgi?id=94545
Reviewed by Dirk Pranke.
Refactor TestExpectations to simplify the code.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.parse): Merged _tokenize_list.
(TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
since the check is now done in _parser_modifiers.
(TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
(TestExpectationParser._tokenize_line): Renamed from _tokenize.
(TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
This is done on a local variable in _parse_modifiers, preserving the original case.
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
of 'rebaseline' against parsed modifiers.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationParserTests._tokenize):
(TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
(TestExpectationSerializerTests._tokenize):
(TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
been merged into parse.
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_csv): Preserves the case.
- 10:45 PM Changeset in webkit [126134] by
-
- 2 edits in trunk/Source/WebCore
Reduce GradientAttributes object size
https://bugs.webkit.org/show_bug.cgi?id=86151
Patch by Rob Buis <rbuis@rim.com> on 2012-08-20
Reviewed by Eric Seidel.
This reduces GradientAttributes in memory size by 8 bytes on my 64-bit system. It also
reduces the size of RenderSVGResourceLinearGradient and RenderSVGResourceRadialGradient.
- svg/GradientAttributes.h:
(WebCore::GradientAttributes::spreadMethod):
(WebCore::GradientAttributes::gradientUnits):
(GradientAttributes):
(WebCore):
(SameSizeAsGradientAttributes):
- 10:01 PM Changeset in webkit [126133] by
-
- 2 edits in trunk/Tools
[jhbuild] EFL now runs jhbuild update for every build
https://bugs.webkit.org/show_bug.cgi?id=94267
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-08-20
Reviewed by Martin Robinson.
Try to fix WinCE build by returning the empty string instead of
env when no jhbuild infrastructure is found.
- Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
- 9:27 PM Changeset in webkit [126132] by
-
- 4 edits2 adds in trunk
Clicking input type=range with padding or border sets wrong value
https://bugs.webkit.org/show_bug.cgi?id=94473
Reviewed by Kent Tamura.
Source/WebCore:
We should take the padding and border width into account when calculating the value from the mouse location.
Test: fast/forms/range/range-hit-test-with-padding.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderTrackElementOf):
(WebCore):
(WebCore::SliderThumbElement::setPositionFromPoint):
- html/shadow/SliderThumbElement.h:
(WebCore):
LayoutTests:
- fast/forms/range/range-hit-test-with-padding-expected.txt: Added.
- fast/forms/range/range-hit-test-with-padding.html: Added.
- 9:21 PM Changeset in webkit [126131] by
-
- 6 edits2 adds in trunk
load event shouldn't fired during node insertion traversals.
https://bugs.webkit.org/show_bug.cgi?id=94447
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLFrameElementBase::didNotifyDescendantInsertions() with empty @src
can trigger a load event during ChildNodeInsertionNotifier
traversal, whose handler can make DOM tree state inconsistent.
This change introduces a post traversal hook,
didNotifySubtreeInsertions(), for the insertion traversal and
replaces the problematic didNotifyDescendantInsertions() with it.
Since didNotifySubtreeInsertions() is invoked after the traversal,
it is safe for event handlers to mutate the tree.
Test: fast/frames/iframe-onload-and-domnodeinserted.html
- dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier): Added a post subtree notification.
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
- dom/Node.h:
(WebCore::Node::didNotifySubtreeInsertions): Newly added.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto): Now returns InsertionShouldCallDidNotifySubtreeInsertions
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Replaced didNotifyDescendantInsertions()
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
LayoutTests:
- fast/frames/iframe-onload-and-domnodeinserted-expected.txt: Added.
- fast/frames/iframe-onload-and-domnodeinserted.html: Added.
- 8:57 PM Changeset in webkit [126130] by
-
- 3 edits in trunk/Source/WebCore
Regression(r126127): Build break on multiple platforms
https://bugs.webkit.org/show_bug.cgi?id=94568
Reviewed by Hajime Morita.
Notation::cloneNode should also have ExceptionCode. We add it in this patch.
No new tests, no change in behavior.
- dom/Notation.cpp:
(WebCore::Notation::cloneNode):
- dom/Notation.h:
(Notation):
- 8:52 PM Changeset in webkit [126129] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix broken non-JIT build.
https://bugs.webkit.org/show_bug.cgi?id=94564.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-20
Reviewed by Filip Pizlo.
Added some UNUSED_PARAM() macros to make the compiler happy.
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 8:38 PM Changeset in webkit [126128] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Select popup shows blank content when its option tags contain '\' characters
https://bugs.webkit.org/show_bug.cgi?id=94321
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-08-20
Reviewed by George Staikos.
PR 194224
When the SelectPopupClient generates HTML, if there is a character '\' in the select options'
description, we should escape it to avoid the character being interpreted as an escape character.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
- 8:22 PM Changeset in webkit [126127] by
-
- 26 edits2 adds in trunk
ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704
Reviewed by Dimitri Glazkov.
Source/WebCore:
According to the spec, ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception. The existing implementation
returned null object instead.
We change the cloneNode() interface so that we can throw an exception from cloneNode().
Test: fast/dom/shadow/shadowroot-clonenode.html
- dom/Attr.cpp:
(WebCore::Attr::cloneNode):
- dom/Attr.h:
- dom/CDATASection.cpp:
(WebCore::CDATASection::cloneNode):
- dom/CDATASection.h:
(CDATASection):
- dom/Comment.cpp:
(WebCore::Comment::cloneNode):
- dom/Comment.h:
(Comment):
- dom/Document.cpp:
(WebCore::Document::cloneNode):
- dom/Document.h:
(Document):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::cloneNode):
- dom/DocumentFragment.h:
(DocumentFragment):
- dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNode):
- dom/DocumentType.h:
(DocumentType):
- dom/Element.cpp:
(WebCore::Element::cloneNode):
- dom/Element.h:
(Element):
- dom/EntityReference.cpp:
(WebCore::EntityReference::cloneNode):
- dom/EntityReference.h:
(EntityReference):
- dom/Node.h:
(Node):
(WebCore::Node::cloneNode):
- dom/Node.idl:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::cloneNode):
- dom/ProcessingInstruction.h:
(ProcessingInstruction):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/Text.cpp:
(WebCore::Text::cloneNode):
- dom/Text.h:
(Text):
LayoutTests:
- fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
- fast/dom/shadow/shadowroot-clonenode.html: Added.
- 8:04 PM Changeset in webkit [126126] by
-
- 5 edits in trunk/Source
[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=94281
Reviewed by Hajime Morita.
Source/WebCore:
Tests: Add some cases to Source/WebKit/chromium/tests/LocaleWinTest.cpp
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::isLocalizedDigit): A helper for parseNumber(). This
return true if the specified character is one of native digits.
(WebCore::LocaleWin::parseNumber):
Try to parse ASCII digits, then try to parse native digtis. This
becomes a member of LocaleWin because it uses
convertFromLocalizedNumber().
(WebCore::LocaleWin::appendNumber): Apply convertToLocalizedNumber().
(WebCore::LocaleWin::appendTwoDigitsNumber): ditto.
(WebCore::LocaleWin::appendFourDigitsNumber): ditto.
- platform/text/LocaleWin.h:
(LocaleWin):
- Make some static functions member functions of LocaleWin.
- Add isLocalizedDigit().
Source/WebKit/chromium:
- tests/LocaleWinTest.cpp:
(TEST_F): Added formatting and parsing tests for Persian locale to check
native digit behavior.
- 7:59 PM Changeset in webkit [126125] by
-
- 2 edits in trunk/Tools
Add a watcher for WTF changes
Unreviewed.
Add myself as a watcher for changes in WTF.
- Scripts/webkitpy/common/config/watchlist:
- 7:49 PM Changeset in webkit [126124] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Improved how a few test
expectations were merged together in r126117.
- platform/chromium/TestExpectations:
- 7:47 PM Changeset in webkit [126123] by
-
- 4 edits in trunk/Source/WebCore
Rename collectGarbageIfNecessary() to hintForCollectGarbage()
https://bugs.webkit.org/show_bug.cgi?id=94455
Reviewed by Adam Barth.
This is a follow-up patch for r126098.
collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends
an idle notification to V8, which is just a hint for V8 to trigger GC.
To clarify the difference, this patch renames collectGarbageIfNecessary()
to hintForCollectGarbage().
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearForNavigation):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::hintForCollectGarbage):
- bindings/v8/V8GCController.h:
(V8GCController):
- 7:35 PM Changeset in webkit [126122] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Texture layer should not generate zero textureId quads
https://bugs.webkit.org/show_bug.cgi?id=94550
Patch by Alexandre Elias <aelias@google.com> on 2012-08-20
Reviewed by Adrienne Walker.
After a context loss, CCTextureLayerImpl would clear its textureId
but continued to produce external resources and quads with the zero
textureid. Add early returns so that CCTextureLayerImpl becomes
inert after a context loss.
Added assertion in read lock so that dontUseOldResourcesAfterLostContext
test catches the problem.
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore::CCScopedLockResourceForRead::CCScopedLockResourceForRead):
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::didDraw):
(WebCore::CCTextureLayerImpl::didLoseContext):
- 7:33 PM Changeset in webkit [126121] by
-
- 7 edits1 add in trunk/Source
[Chromium] Make the popup positioning code testable
https://bugs.webkit.org/show_bug.cgi?id=94086
Reviewed by Hajime Morita.
Source/WebCore:
Introduce PopupContent interface in order to make a mock.
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRectInternal):
- Make it a member of PopupContainer to avoid namespace pollution.
- Use PopupContent interface.
- Make the code clearer.
- platform/chromium/PopupContainer.h:
(PopupContainer): Expose layoutAndCalculateWidgetRectInternal.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::popupContentHeight): Added.
- platform/chromium/PopupListBox.h:
(PopupContent): Added.
(PopupListBox): Inherit PopupContent.
(WebCore::PopupListBox::~PopupListBox):
Make this virtual because this class has some virtual functions.
Source/WebKit/chromium:
- WebKit.gypi: Add PopupContainerTest.cpp.
- tests/PopupContainerTest.cpp: Added.
(MockPopupContent):
(calculatePosition):
(TEST):
- 7:11 PM Changeset in webkit [126120] by
-
- 4 edits3 adds in trunk
XSSAuditor too tolerant of injected data: URLs from other "hostless" schemes.
https://bugs.webkit.org/show_bug.cgi?id=94547
Reviewed by Adam Barth.
Source/WebCore:
Check that there is a host before making same-host tests.
Test: fast/frames/xss-auditor-handles-file-urls.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::isLikelySafeResource):
- html/parser/XSSAuditor.h:
LayoutTests:
- fast/frames/resources/static-xss-vector.html: Added.
- fast/frames/xss-auditor-handles-file-urls-expected.txt: Added.
- fast/frames/xss-auditor-handles-file-urls.html: Added.
- 7:03 PM Changeset in webkit [126119] by
-
- 5 edits in trunk/Source/WebCore
Removed dead code from a very old iteration of CSS counters.
https://bugs.webkit.org/show_bug.cgi?id=94539
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-20
Reviewed by Eric Seidel.
Remove two unused shorts that were on StyleRareNonInheritedData that are no longer used.
No tests, this just removes dead code.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- 7:00 PM Changeset in webkit [126118] by
-
- 5 edits in trunk
Fix inspector with variables enabled and enable inspector variables tests by default.
https://bugs.webkit.org/show_bug.cgi?id=94296
Reviewed by Hajime Morita.
Source/WebCore:
Change from using getPropertyName static function to CSSProperty::cssName(), which can resolve variables if needed.
Covered by inspector/styles/variables.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
LayoutTests:
Fix paths to included javascript and enable tests by default on Chromium port.
- inspector/styles/variables/css-variables.html:
- platform/chromium/TestExpectations:
- 6:59 PM Changeset in webkit [126117] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fixed lint errors in TestExpectations after r126110.
- platform/chromium/TestExpectations:
- 6:50 PM Changeset in webkit [126116] by
-
- 2 edits in trunk/Source/WebCore
Cancel the outstanding vibration pattern if the pattern is 0 or an empty list
https://bugs.webkit.org/show_bug.cgi?id=94085
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-20
Reviewed by Kentaro Hara.
vibrate() method to stop the device from vibrating is getting called before the
vibration is in effect. Hence, it is failing to cancel the pre-existing instance
of processing vibration patterns.
This patch cancel the pre-existing instance of the processing vibration patterns
always when the vibrate() method called with pattern 0 or an empty list.
No new tests since there is no return value in the Vibration API to test this
particular case. Existing test fast/dom/navigator-vibration.html covers testing of
the Vibration API.
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::vibrate):
- 6:30 PM Changeset in webkit [126115] by
-
- 3 edits3 copies in branches/chromium/1229
Merge 125852
- 6:28 PM Changeset in webkit [126114] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix warnings on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=94543
Patch by Scott Graham <scottmg@chromium.org> on 2012-08-20
Reviewed by Adrienne Walker.
- tests/CCMathUtilTest.cpp:
- 6:14 PM Changeset in webkit [126113] by
-
- 8 edits in trunk/Source
Allow MutationEvents to be enabled/disabled per context
https://bugs.webkit.org/show_bug.cgi?id=94016
Reviewed by Ojan Vafai.
Source/WebCore:
Chromium wants to be able to turn MutationEvents off for some
Documents (e.g., for Apps V2). This patch makes the firing (and the
constructor on DOMWindow) of MutationEvents a per-context feature, with
the default being enabled.
No functional change (since the feature defaults to enabled).
It's not clear to me that there's a way to test this in DRT without
adding a special hook for this one feature. It will be tested in
Chromium once it's implemented in Chromium.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::mutationEventsEnabled): Add new method,
with the default being enabled.
- dom/ContextFeatures.h:
- dom/Document.cpp:
(WebCore::Document::addMutationEventListenerTypeIfEnabled): Add new
method that checks the ContextFeature flag before adding the passed-in
listener type.
(WebCore::Document::addListenerTypeIfNeeded): Call the new method
instead of addListenerType for MutationEvent types.
- dom/Document.h:
(WebCore::Document::addListenerType): Make private to avoid anyone
outside Document from enabling MutationEvent listeners. All callers
must go through addListenerTypeIfNeeded.
Source/WebKit/chromium:
Add Chromium/WebKit API for enabling/disabling MutationEvents via
WebPermissionClient.
- public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowMutationEvents):
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
- 6:01 PM Changeset in webkit [126112] by
-
- 4 edits2 copies in branches/chromium/1229
Merge 125869 - Source/WebCore: libwebp-0.2.0: handle alpha channel if present
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
updated the Layout test webp-image-decoding.html
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(outputMode):
switch to premultiplied-RGB if needed
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::decode):
use WebPGetFeatures() instead of WebPGetInfo(),
to detect presence of alpha channel
- platform/image-decoders/webp/WEBPImageDecoder.h:
(WEBPImageDecoder):
add a m_hasAlpha field
LayoutTests: update layout test for new libwebp-0.2.0
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
- fast/images/resources/test2.webp: Added.
lossy+alpha example
- fast/images/resources/test3.webp: Added.
lossless with alpha example
- fast/images/webp-image-decoding-expected.txt:
- fast/images/webp-image-decoding.html:
Updated test. Will now decode test2.webp and test3.webp too.
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10860057
- 6:00 PM Changeset in webkit [126111] by
-
- 8 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r126095.
http://trac.webkit.org/changeset/126095
https://bugs.webkit.org/show_bug.cgi?id=94555
Breaks compilation of downstream WebWidget::paint
implementations (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
- public/WebWidget.h:
(WebKit::WebWidget::paint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
(WebViewImpl):
- 5:59 PM Changeset in webkit [126110] by
-
- 131 edits in trunk
[Sub-pixel Layout] Block selection gap repainting can leave one pixel gaps
https://bugs.webkit.org/show_bug.cgi?id=94526
Reviewed by Eric Seidel.
Source/WebCore:
Reverting RenderLayer's m_blockSelectionGapsBounds to be an IntRect and applying enclosingIntRect to the
gapRects added to the bounds. Previously, we'd end multiple block gaps and pixel snap the result, which
can yield results one pixel off in width and height.
Covered by existing tests. This undoes some of the rebaselining from when sub-pixel was enabled for Chromium.
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
LayoutTests:
Correcting pixel gap repainting reverts a bunch of chromium expectations to their pre-sub-pixel layout
versions. This largely triggers 1-pixel image diffs in input fields.
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/square-button-appearance-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/button-sizes-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium/TestExpectations:
- 5:57 PM Applications using WebKit edited by
- (diff)
- 5:56 PM Applications using WebKit edited by
- (diff)
- 5:52 PM Changeset in webkit [126109] by
-
- 12 edits in trunk/Source
[V8] Move instrumentedCallFunction() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94456
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves instrumentedCallFunction() from V8Proxy
to ScriptController. Also this patch renames instrumentedCallFunction()
to callFunctionWithInstrumentation(), for consistency with callFunction().
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunction):
(WebCore):
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::resourceInfo):
(WebCore::resourceString):
(WebCore::ScriptController::callFunctionWithInstrumentation):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::call):
- bindings/v8/V8Callback.cpp:
(WebCore::invokeCallback):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
Source/WebKit/chromium:
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- 5:51 PM WebInspector edited by
- (diff)
- 5:50 PM Changeset in webkit [126108] by
-
- 2 edits in trunk/LayoutTests
setMockGeolocationPosition not defined in WKTR
https://bugs.webkit.org/show_bug.cgi?id=94554
Unreviewed (bot gardening)
- platform/wk2/Skipped:
- 5:45 PM Changeset in webkit [126107] by
-
- 3 edits in trunk/Source/WebCore
Never notify of insertedIntoTree during document destruction.
https://bugs.webkit.org/show_bug.cgi?id=94535
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-20
Reviewed by Eric Seidel.
Never notify of insertedIntoTree during document destruction. Previously since we
avoid notifying of willBeRemovedFromTree it's possible we could have gotten several
insertedIntoTree notifications without ever being told we were removed.
No tests needed since this just closes holes related to future code.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode): Never call insertedIntoTree during document destruction.
(WebCore::RenderObjectChildList::insertChildNode): Same.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::attachRegion): Removed unneeded document destruction check.
- 5:37 PM Changeset in webkit [126106] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Initialize GraphicsLayerChromium::m_contentsLayerId when setting contents layer
https://bugs.webkit.org/show_bug.cgi?id=94552
Reviewed by Kenneth Russell.
Set it or it don't work good.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- 5:35 PM Changeset in webkit [126105] by
-
- 15 edits12 adds in trunk
Source/WebCore: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-20
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
Tests: css3/compositing/blend-mode-property-parsing-invalid.html
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateLayerBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-20
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
- css3/compositing: Added.
- css3/compositing/blend-mode-property-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid.html: Added.
- css3/compositing/blend-mode-property-parsing.html: Added.
- css3/compositing/blend-mode-property.html: Added.
- css3/compositing/script-tests: Added.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
- css3/compositing/script-tests/blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testFilterRule):
- css3/compositing/script-tests/blend-mode-property.js: Added.
- platform/chromium/css3/compositing/blend-mode-property-expected.txt : Added.
- platform/chromium/css3/compositing/blend-mode-property-parsing-expected.txt : Added.
- 5:32 PM Changeset in webkit [126104] by
-
- 2 edits in trunk/Tools
[EFL] Move jhbuild dependencies based on SVN to tarballs
https://bugs.webkit.org/show_bug.cgi?id=90374
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Moved all the dependencies based on SVN to tarballs taken from a
equivalent snapshot from the official git mirror. This will make
update-webkitefl not dependent on network connection after the first
run. The bots will not fail if EFL SVN server in unreachable.
The reason why git mirror is not used directly is to minimize the
total size of source code we need to download.
- efl/jhbuild.modules:
- 5:31 PM Changeset in webkit [126103] by
-
- 12 edits in trunk/Source
[V8] Move retrieve{Window,Frame,PerContextData}() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94460
Reviewed by Adam Barth.
To kill V8Proxy, we move retrieve{Window,Frame,PerContextData}()
from V8Proxy to V8Binding. Also, this patch renames these methods as follows:
- retrieveWindow() -> toDOMWindow()
- retrieveFrame() -> toFrameIfNotDetached()
- retrievePerContextData() -> perContextDataForCurrentWorld()
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/BindingState.cpp:
(WebCore::activeDOMWindow):
(WebCore::firstDOMWindow):
(WebCore::activeFrame):
(WebCore::firstFrame):
(WebCore::currentFrame):
(WebCore::currentDocument):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::retrieveFrameWithGlobalObjectCheck):
(WebCore::PageScriptDebugServer::getDebugListenerForContext):
(WebCore::PageScriptDebugServer::runMessageLoopOnPause):
- bindings/v8/V8Binding.cpp:
(WebCore::retrieveWindow):
(WebCore):
(WebCore::retrieveFrame):
(WebCore::retrievePerContextData):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::constructorForType):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::context):
(WebCore::V8Proxy::matchesCurrentContext):
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/WebBindings.cpp:
(WebKit::makeIntArrayImpl):
(WebKit::makeStringArrayImpl):
- src/WebFrameImpl.cpp:
(WebKit::WebFrame::frameForContext):
- 5:20 PM Changeset in webkit [126102] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BLACKBERRY] Add notification if an element does not have touch move or mouse move handlers.
https://bugs.webkit.org/show_bug.cgi?id=94529
Patch by Genevieve Mak <gmak@rim.com> on 2012-08-20
Reviewed by George Staikos.
Send a notification to the client if the fat finger element does
not have a mouse move or touch move handler or if it is empty.
PR #177701
Reviewed Internally By Mike Lattanzio and Antonio Gomes.
- Api/WebPageClient.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 5:16 PM Changeset in webkit [126101] by
-
- 2 edits in trunk/Tools
Lots of "error, test and reference image have different properties" in pixel test output
https://bugs.webkit.org/show_bug.cgi?id=92578
Reviewed by Dirk Pranke.
Improve ImageDiff's error reporting when test result image and expected image
differ in their properties.
- DumpRenderTree/cg/ImageDiffCG.cpp:
- 5:09 PM Changeset in webkit [126100] by
-
- 2 edits in trunk/Source/WebCore
Yank an unneccessary if added in r125810.
https://bugs.webkit.org/show_bug.cgi?id=85804
Reviewed by Levi Weintraub.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- 5:06 PM Changeset in webkit [126099] by
-
- 8 edits in trunk/Source
[chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer
https://bugs.webkit.org/show_bug.cgi?id=94544
Reviewed by Adrienne Walker.
Source/Platform:
Exposes an id so users of the WebLayer API can make identity checks for layers that they do not have ownership
of.
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
GraphicsLayerChromium only keeps a weak pointer to its m_contentsLayer. When replacing it with a new contents
layer, it may be unsafe to touch the old value. It's also completely unnecessary.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
Source/WebKit/chromium:
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::id):
(WebKit):
- src/WebLayerImpl.h:
(WebLayerImpl):
- 5:02 PM Changeset in webkit [126098] by
-
- 7 edits in trunk/Source
[V8] Move collectGarbage() from ScriptController to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=94455
Reviewed by Adam Barth.
- This patch moves collectGarbage() from ScriptController to V8GCController.
- This patch makes collectGarbage() a static method.
- This patch removes ScriptController::lowMemoryNotification()
since it is not used at all.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::collectGarbage):
(WebCore):
- bindings/v8/V8GCController.h:
(V8GCController):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::collectGarbage):
- 5:00 PM Changeset in webkit [126097] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (125759) fast/forms/file/selected-files-from-history-state.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=94549
Unreviewed (Bot gardening)
- platform/mac-wk2/Skipped:
- 4:57 PM Changeset in webkit [126096] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove V8Proxy from V8IsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=94450
Reviewed by Adam Barth.
This patch removes dependency on V8Proxy from V8IsolatedContext.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8IsolatedContext.h:
(WebCore):
(V8IsolatedContext):
- 4:57 PM Changeset in webkit [126095] by
-
- 8 edits in trunk/Source/WebKit/chromium
WebWidget should be able to paint into a zoomed canvas without aliasing
https://bugs.webkit.org/show_bug.cgi?id=92043
Reviewed by James Robinson.
If accelerated compositing is enabled, WebWidget::paint reads back from
the compositor rather than re-painting the widget. That approach works
well if the canvas we're rendering into is at a similar resolution to
the pixels in the compositor, but if the canvas has been scaled (e.g.,
to help the user disambiguate links), then reading back from the
compositor will cause aliasing artifacts.
This patch adds an option to paint to let the embedder request a
software re-rendering of the widget to avoid these aliasing artifacts.
- public/WebWidget.h:
(WebKit::WebWidget::paint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::canvasBackgroundForTransparencey):
(WebKit):
(WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:50 PM Changeset in webkit [126094] by
-
- 3 edits3 adds in trunk
Canvas drawImage() should draw SVG at the correct scale.
https://bugs.webkit.org/show_bug.cgi?id=94377
Source/WebCore:
Previously, drawing SVG in canvas would render at the incorrect scale
because imageSizeForRenderer did not take into account the page scale.
After this patch, we now incorporate the page scale in
CachedImage::imageSizeForRenderer().
Reviewed by Tim Horton.
Test: svg/as-image/svg-as-image-canvas.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
LayoutTests:
Reviewed by Tim Horton.
- svg/as-image/resources/100px-green-rect.svg: Added.
- svg/as-image/svg-as-image-canvas-expected.html: Added.
- svg/as-image/svg-as-image-canvas.html: Added.
- 4:48 PM Changeset in webkit [126093] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fixed erroneous line number for LLint frame when throwing exceptions.
https://bugs.webkit.org/show_bug.cgi?id=94051.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-20
Reviewed by Filip Pizlo.
For LLInt frames, before throwing an exception, adjust the PC from the
return PC back to the call PC if we are indeed at a call site.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::adjustPCIfAtCallSite):
(JSC):
(JSC::CodeBlock::bytecodeOffset):
- bytecode/CodeBlock.h:
(CodeBlock):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::fixupPCforExceptionIfNeeded):
(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- 4:45 PM Changeset in webkit [126092] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations now that stray ASSERT is fixed in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=94548
Unreviewed.
- platform/chromium/TestExpectations:
- 4:43 PM Changeset in webkit [126091] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Roll WebKit chromium DEPS forward.
- DEPS:
- 4:43 PM Changeset in webkit [126090] by
-
- 2 edits in trunk/Source/WebCore
Assertion going back to results.html page from an image diff result
https://bugs.webkit.org/show_bug.cgi?id=94143
Reviewed by Adam Barth.
Avoid redundantly setting the DOMWindow on a JSDOMWindow shell in
ScriptCachedFrameData::restore(), as we may have already done this
in ScriptController::clearWindowShell(). This avoids an assertion
on some platforms when going Back to the test results page from
a diff image.
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
- 4:39 PM Changeset in webkit [126089] by
-
- 2 edits in trunk/Tools
Unsafe vsprintf usage in TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=94522
Reviewed by Adam Barth.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
the message buffer.
(testDocumentOpen):
(testWindowOpen):
- 4:33 PM Changeset in webkit [126088] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] OES_vertex_array_object is not correctly un/binding or deleting
https://bugs.webkit.org/show_bug.cgi?id=94029
Reviewed by Ken Russell.
When the currently bound vertex array is deleted, the specification says that
the default object should be bound in its place. Also, binding a null object
as a vertex array was not actually clearing the bound object at the GL layer.
And lastly, it should not be possible to bind a deleted vertex array.
The test case for this is the public Khronos WebGL conformance suite, in particular:
conformance/extensions/oes-vertex-array-object.html
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::deleteVertexArrayOES): Check if the deleted array is
currently bound, and if so, unbind it.
(WebCore::OESVertexArrayObject::bindVertexArrayOES): Make sure never to bind an
array that has been marked as deleted.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Remove the null check on bind. We
do need to call glBindVertexArrayAPPLE with a null value in order to clear it.
- 4:25 PM Changeset in webkit [126087] by
-
- 6 edits2 moves in trunk/LayoutTests
2d.imageData.object.wrap.html has wrong expectations
https://bugs.webkit.org/show_bug.cgi?id=94089
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Updating and renaming the test to match new version in W3C approved tests.
- canvas/philip/tests/2d.imageData.object.clamp-expected.txt: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap-expected.txt.
- canvas/philip/tests/2d.imageData.object.clamp.html: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap.html.
- platform/chromium/TestExpectations: Unskipping.
- platform/efl/Skipped: Unskipping.
- platform/gtk/TestExpectations: Unskipping.
- platform/mac/Skipped: Unskipping.
- platform/qt/Skipped: Unskipping.
- 4:18 PM Changeset in webkit [126086] by
-
- 7 edits in trunk/Source
[V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94459
Reviewed by Adam Barth.
To kill V8Proxy, we can move clearForClose() and
clearForNavigation() from V8Proxy to ScriptController.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearForNavigation):
(WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::~V8Proxy):
(WebCore::V8Proxy::handleOutOfMemory):
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 4:16 PM Changeset in webkit [126085] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Merge r126041 for <rdar://problem/12133659>.
- 4:07 PM Changeset in webkit [126084] by
-
- 3 edits3 adds in trunk
CSS Masking and CSS Filters applied in wrong order
https://bugs.webkit.org/show_bug.cgi?id=94354
Reviewed by Dean Jackson.
Source/WebCore:
According to the Filter Effects spec, the order should be first filters, then masking and clipping.
Changed the order on applying the different effects in RenderLayer.
Test: css3/filters/filter-mask-clip-order.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): First filter, then mask and clip the content.
LayoutTests:
The test checks the correct order on applying CSS Masking, Filter Effects and CSS Clipping.
According to the Filter Effects spec, the order should be first filters, then masking and clipping.
- css3/filters/filter-mask-clip-order-expected.html: Added.
- css3/filters/filter-mask-clip-order.html: Added.
- css3/filters/resources/mask.png: Added.
- 3:42 PM Changeset in webkit [126083] by
-
- 13 edits in trunk/Source
[V8] Move mainWorldContext() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94453
Reviewed by Adam Barth.
This patch moves mainWorldContext() from V8Proxy to ScriptController.
In addition, this patch removes dependency on V8Proxy from WorldContextHandle.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
- bindings/v8/NPV8Object.cpp:
(WebCore::toV8Context):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::mainWorldContext):
(WebCore):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptState.cpp:
(WebCore::mainWorldScriptState):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::context):
(WebCore::toV8Context):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::adjustedContext):
- bindings/v8/WorldContextHandle.h:
(WebCore):
(WorldContextHandle):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::mainWorldScriptContext):
- 3:41 PM Changeset in webkit [126082] by
-
- 2 edits in trunk/Source/JavaScriptCore
fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=94538
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- 3:32 PM Changeset in webkit [126081] by
-
- 2 edits in trunk/Source/JavaScriptCore
fast/js/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html crashes on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=94026
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
- 3:24 PM Changeset in webkit [126080] by
-
- 15 edits in trunk
Remove redundant TOUCH_LISTENER event type
https://bugs.webkit.org/show_bug.cgi?id=94524
Reviewed by Ryosuke Niwa.
Source/WebCore:
Code that needs to determine whether there are touch listeners
can instead call Document::touchEventHandlerCount(), added in r107832.
TOUCH_LISTENER didn't fit very well into the hasListenerType() model
anyway, as there's not a 1:1 correspondance between the enum value and
an event.
- dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Remove two bits of code:
the bookkeeping for TOUCH_LISTENER, and the notification into
ChromeClient (which is handled by calls to didAddTouchEventHandler in
all the places that call addListenerTypeIfNeeded).
(WebCore::Document::didRemoveTouchEventHandler): Remove bookkeeping for TOUCH_LISTENER.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Call touchEventHandlerCount instead of hasListenerType.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): ditto
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): ditto
- page/Frame.cpp:
(WebCore::Frame::setDocument): ditto
- testing/Internals.cpp: Remove hasTouchEventListener method since its
data source no longer exists.
- testing/Internals.h: ditto
(Internals):
- testing/Internals.idl: ditto
Source/WebKit/chromium:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove
bookkeeping for TOUCH_LISTENER.
LayoutTests:
Removed tests for hasTouchEventListener as they're redundant
with tests for touchEventHandlerCount.
- fast/events/touch/touch-handler-count-expected.txt:
- fast/events/touch/touch-handler-count.html:
- 3:23 PM Changeset in webkit [126079] by
-
- 5 edits in trunk
[BlackBerry] Enable XHR Response BLOB
https://bugs.webkit.org/show_bug.cgi?id=94525
Reviewed by Rob Buis.
.:
Add the XHR response blob enable feature to the cmake build system and
enable it for BlackBerry.
- Source/cmake/OptionsBlackBerry.cmake: Add the feature and enable
- Source/cmakeconfig.h.cmake: Add the feature
Tools:
Turn on the XHR response blob feature for the BlackBerry port.
- Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
- 3:22 PM Changeset in webkit [126078] by
-
- 2 edits in trunk/LayoutTests
Reftest fast/text-autosizing/nested-em-line-height.html needs updating after r126058
https://bugs.webkit.org/show_bug.cgi?id=94528
Unreviewed Chromium gardening. Narrow test expectation.
- platform/chromium/TestExpectations:
- 3:20 PM WebKit Team edited by
- (diff)
- 3:08 PM Changeset in webkit [126077] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Adding suppressions for failing tests.
https://bugs.webkit.org/show_bug.cgi?id=94521
https://bugs.webkit.org/show_bug.cgi?id=94528
https://bugs.webkit.org/show_bug.cgi?id=94532
- platform/chromium/TestExpectations:
- 2:57 PM Changeset in webkit [126076] by
-
- 39 edits4 copies6 moves4 deletes in trunk/Source
[chromium] Change WebLayer from a concrete type to a pure virtual interface
https://bugs.webkit.org/show_bug.cgi?id=94174
Reviewed by Adrienne Walker.
Source/Platform:
This changes WebLayer from a value type to a pure virtual interface and changes Web*Layers from subtypes to
standalone types that have a WebLayer. This better isolates the implementation from the interface and, since
it's not possible to re-wrap an existing layer, makes cleanup explicit instead of requiring the caller to invoke
special cleanup methods before shutdown.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
- chromium/public/WebScrollableLayer.h:
(WebScrollableLayer):
- chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebVideoLayer):
Source/WebCore:
This updates WebCore code for the WebLayer interface changes. Classes that have ownership of specific layer
types (such as DrawingBufferChromium, Canvas2DLayerBridge and ScrollingCoordinatorChromium) hold ownership
of a specific type and a pointer to the WebLayer to GraphicsLayerChromium to be included in the final layer
tree. GraphicsLayerChromium holds a WebContentLayer and (optionally) a WebImageLayer and WebLayer (for
m_transformLayer) and assembles the final layer tree.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::clearLayer):
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore):
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
NonCompositedContentHost.
- WebKit.gyp:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::clearClient):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayer.cpp: Removed.
- src/WebExternalTextureLayerImpl.cpp: Added.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::clearClient):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
- src/WebExternalTextureLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebKit):
(WebExternalTextureLayerImpl):
- src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
- src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
- src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
- src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
- src/WebLayer.cpp: Removed.
- src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::clearRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
- src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollableLayer.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
- src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
- src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
- src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
- src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
- src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 2:50 PM Changeset in webkit [126075] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] CCMathUtilTest.smallestAngleBetweenVectors unit test failing
https://bugs.webkit.org/show_bug.cgi?id=94502
Reviewed by Kenneth Russell.
The test needed to use EXPECT_FLOAT_EQ instead of EXPECT_EQ. In
this patch, the test is also re-enabled.
- tests/CCMathUtilTest.cpp:
- 2:41 PM Changeset in webkit [126074] by
-
- 8 edits in trunk/Source
Move transformFriendlyBoundingBox out of Range
https://bugs.webkit.org/show_bug.cgi?id=94366
Source/WebCore:
Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2012-08-20
Reviewed by Simon Fraser and Ryosuke Niwa.
Bug 93111 introduced a new method in Range called transformFriendlyBoundingBox.
However, this method should not have been added there in order to reduce the
dependencies between Range and the rendering code. This patch moves it to a
static method in RenderObject.
Tests: existing tests, no new feature added by this patch.
- dom/Range.cpp:
- dom/Range.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteBoundingBoxRectForRange):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Source/WebKit/chromium:
Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2012-08-20
Reviewed by Ryosuke Niwa.
Update the WebKit code that makes use of transformFriendlyBoundingBox.
- src/FindInPageCoordinates.cpp:
(WebKit::findInPageRectFromRange):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::selectFindMatch):
- 2:38 PM Changeset in webkit [126073] by
-
- 2 edits in trunk/Tools
Fix change for timeout detection to not crash if we have no output :)
https://bugs.webkit.org/show_bug.cgi?id=94505
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 2:34 PM Changeset in webkit [126072] by
-
- 12 edits in trunk
Replace isolate bidi-override by isolate-override https://bugs.webkit.org/show_bug.cgi?id=89746
Reviewed by Levi Weintraub.
Source/WebCore:
The combination of bidi-isolate and isolate was replaced by a single isolate-override in
http://lists.w3.org/Archives/Public/www-style/2012May/0541.html. The spec. has been updated accordingly:
http://dev.w3.org/csswg/css3-writing-modes/#unicode-bidi
To follow the specification change, added -webkit-isolate-override and removed the support for
isolate bidi-override, simplifying the CSS parser and serializer. Test: fast/text/bidi-override-isolate.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed. We can just new a CSSPrimitiveValue
constructor now.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added now that unicode-bidi always creates a signle
primitive value instead of a primitive value of css value list.
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
- css/CSSValueKeywords.in: Added -webkit-isolate-override
- css/StyleBuilder.cpp:
(WebCore): Removed ApplyPropertyUnicodeBidi since we can use ApplyPropertyDefault now.
(WebCore::StyleBuilder::StyleBuilder): Use ApplyPropertyDefault.
- platform/text/UnicodeBidi.h: Renamed OverrideIsolate to IsolateOverride to match the spec.
(WebCore::isIsolated):
(WebCore::isOverride):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRuns):
LayoutTests:
Rebaseline test expectations. These tests test the new behavior and new property value -webkit-isolate-override.
- fast/css/unicode-bidi-computed-value-expected.txt:
- fast/css/unicode-bidi-computed-value.html:
- fast/text/bidi-override-isolate.html:
- 2:32 PM Changeset in webkit [126071] by
-
- 7 edits2 adds in trunk
RenderGrid children should always be RenderBoxes
https://bugs.webkit.org/show_bug.cgi?id=94305
Reviewed by Abhishek Arya.
Source/WebCore:
During RenderGrid::layout, we assume all the children are RenderBoxes.
When removing children, if the last child is an anonymous block, we don't
want to remove the anonymous block for grids. Ensure this doesn't happen
by adding canCollapseAnonymousBlockChild to RenderBlock (flexboxen and
grid can override this method).
Test: fast/css-grid-layout/should-not-collapse-anonymous-blocks.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): Check canCollapseAnonymousBlockChild().
- rendering/RenderBlock.h:
(WebCore::RenderBlock::canCollapseAnonymousBlockChild):
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.h: canCollapseAnonymousBlockChild returns false.
- rendering/RenderFlexibleBox.h: canCollapseAnonymousBlockChild returns false.
- rendering/RenderGrid.h: canCollapseAnonymousBlockChild returns false.
LayoutTests:
Add test case from fuzzer.
- fast/css-grid-layout/should-not-collapse-anonymous-blocks-expected.txt: Added.
- fast/css-grid-layout/should-not-collapse-anonymous-blocks.html: Added.
- 2:30 PM Changeset in webkit [126070] by
-
- 2 edits in trunk/Tools
temporarily disable ImageDiff on WK2 ports for ref tests
https://bugs.webkit.org/show_bug.cgi?id=94517
Reviewed by Brady Eidson.
ImageDiff appears to be unable to handle the pngs returned from
WebKitTestRunner, so we disable checking images by default
for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference):
- 2:16 PM Changeset in webkit [126069] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r126026.
http://trac.webkit.org/changeset/126026
https://bugs.webkit.org/show_bug.cgi?id=94449
Caused assertion failure in layout test touchadjustment/context-menu.html
Source/WebCore:
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendSubtargetsForNodeToList):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
LayoutTests:
- touchadjustment/context-menu-select-text.html:
- touchadjustment/context-menu-text-subtargets-expected.txt: Removed.
- touchadjustment/context-menu-text-subtargets.html: Removed.
- touchadjustment/resources/touchadjustment.js:
- 2:15 PM Changeset in webkit [126068] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Enabling DEBUG_LAYER_ANIMATION results in build break & warnings
https://bugs.webkit.org/show_bug.cgi?id=94514
Patch by Andrew Lo <anlo@rim.com> on 2012-08-20
Reviewed by Rob Buis.
Add wtf::CString definition to fix build break when enabling DEBUG_LAYER_ANIMATION
debug prints. Fix build warnings from prints.
No new tests, non-functional change.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::addAnimation):
(WebCore::GraphicsLayerBlackBerry::pauseAnimation):
- 2:12 PM Changeset in webkit [126067] by
-
- 8 edits1 delete in trunk
[JSC] SerializedScriptValue::create() should throw a DataCloneError if input is an unsupported object
https://bugs.webkit.org/show_bug.cgi?id=94493
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
Reviewed by Oliver Hunt.
Source/WebCore:
Update JSC implementation for SerializedScriptValue::create() so that
a DataCloneError is thrown when the input value is an unsupported
object. The previous implementation was not throwing any error.
This change is according to the structured clone specification at:
http://www.w3.org/TR/html5/common-dom-interfaces.html#structured-clone
This also matches the corresponding V8 implementation.
Test: fast/events/message-port-multi.html.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::serialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/SerializedScriptValue.h:
LayoutTests:
Add checks for Function, Error and host objects arguments to
MessagePort.postMessage() in fast/events/message-port-multi.html.
According to the structured clone specification, we should throw
a DataCloneError for such input types.
- fast/dom/Window/anonymous-slot-with-changes-expected.txt:
- fast/dom/Window/anonymous-slot-with-changes.html: Update test to expect
an exception when passing a function to postMessage().
- fast/events/message-port-multi-expected.txt: Update expected result
accordingly.
- fast/events/resources/message-port-multi.js:
(testTransfers.try.f1):
- platform/chromium/fast/events/message-port-multi-expected.txt: Removed.
Now identical to global expectation.
- 2:11 PM Changeset in webkit [126066] by
-
- 9 edits2 copies in trunk/Source/WebCore
Unreviewed, rolling out r125884.
http://trac.webkit.org/changeset/125884
https://bugs.webkit.org/show_bug.cgi?id=94523
Appears to be causing a top crash in the Canary channel
(Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::mainThreadNormalWorld):
- bindings/v8/DOMWrapperWorld.h:
(WebCore):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(DOMWrapperWorld):
- bindings/v8/IsolatedWorld.cpp: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.cpp.
(WebCore):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
- bindings/v8/IsolatedWorld.h: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.h.
(WebCore):
(IsolatedWorld):
(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::count):
(WebCore::IsolatedWorld::id):
(WebCore::IsolatedWorld::domDataStore):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):
- bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):
- 2:09 PM Changeset in webkit [126065] by
-
- 2 edits in trunk/Source/WebCore
Remove improper ASSERT in AudioParamTimeline::valuesForTimeRangeImpl()
https://bugs.webkit.org/show_bug.cgi?id=94504
Reviewed by Kenneth Russell.
AudioParamTimeline::valuesForTimeRangeImpl() is able to handle the case where there are no timeline events.
So don't ASSERT for that case.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- 2:03 PM Changeset in webkit [126064] by
-
- 2 edits in trunk/Tools
Add missing FIXME: to previous change.
https://bugs.webkit.org/show_bug.cgi?id=94505
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 2:02 PM Changeset in webkit [126063] by
-
- 3 edits2 adds in trunk
Line boxes not being dirtied correctly during inline removal
https://bugs.webkit.org/show_bug.cgi?id=93156
Reviewed by David Hyatt.
Source/WebCore:
When two inline objects were being removed from different lineboxes
in an ancestral RenderBlock, the way the RenderBlock was being marked
prevented the second linebox from being marked dirty. This causes
it to not get layout in the subsequent layout pass.
This patch causes only the descendants corresponding to actual changed
lineboxes to have their ancestorLineBoxDirty bit set, rather than
the RenderBlock that contains the lineboxes themselves.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
LayoutTests:
Test exercising crashing condition for bug 93156.
- fast/block/line-layout/double-line-break-obj-removal-crash.html: Added
- fast/block/line-layout/double-line-break-obj-removal-crash-expected.txt: Added
- 1:59 PM Changeset in webkit [126062] by
-
- 2 edits in trunk/Tools
Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
https://bugs.webkit.org/show_bug.cgi?id=94505
Reviewed by Ojan Vafai.
It looks like if the webprocess times out, WTR may tell NRWT
that the test completed, but not properly reset its internal
state, and then return stale output for subsequent tests.
This patch modifies NRWT temporarily to check for
"Timed out waiting for final message from web process" in stdout
and treat that as a timeout (and thus kill WTR); this seems
to solve the cascade of failures, but of course there's probably
still a bug in WTR that needs to be fixed.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 1:48 PM Changeset in webkit [126061] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] detectContentIntentAround has a misleading name
https://bugs.webkit.org/show_bug.cgi?id=94349
Reviewed by Adam Barth.
The current WebViewClient API exposes a method named detectContentIntentAround.
However, this is not designed to detect any "content intent", but to allow the embedder
to detect content around a position and fire Android intents if appropriate.
This patch also disables content detection if the touched node listens to events
that consume the tap action like clicks, touch events or mouse events.
- public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::detectContentAround):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::detectContentOnTouch):
- src/WebViewImpl.h:
(WebViewImpl):
- 1:44 PM Changeset in webkit [126060] by
-
- 1 edit3 adds in trunk/LayoutTests
[css3-text] Add getComputedStyle tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94108
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line",
with included basic getComputedStyle* layout tests for parsing check. This
patch adds a new, more robust getComputedStyle-based layout test for this
property.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html: Added.
- fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: Added.
- 1:25 PM Changeset in webkit [126059] by
-
- 2 edits in trunk/Tools
NRWT reports unexpected EOF
https://bugs.webkit.org/show_bug.cgi?id=94387
Reviewed by Adam Barth.
Stop logging "Unexpected EOF" when we are reading the last few
bytes from stdout/stderr after stopping the subprocess.
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess.stop):
- 1:23 PM Changeset in webkit [126058] by
-
- 11 edits8 adds in trunk
Text Autosizing: Only take into account block width <= document layout width.
https://bugs.webkit.org/show_bug.cgi?id=93862
Patch by John Mellor <johnme@chromium.org> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Instead of calculating the textAutosizingMultiplier purely based on the
width of each block, we now work out the maximum width of the block
that could be displayed onscreen at any one time, and use that value.
This avoids excessive text size multiplication (there's no point making
text bigger than this, since you wouldn't be able to zoom out far
enough to read it!).
To determine the maximum onscreen block width, we take the minimum of
the block width and the layoutWidth of the narrowest non-flattened
ancestor frame. Flattened frames are ignored since they don't impose a
hard limit on the maximum width that can be displayed, instead they can
stretch to fit their contents. Note that on mobile the layoutWidth of
the main frame is the fixed layout width aka viewport width.
In practice this caps the maximum multiplier to a value that depends
on the metrics of the device. For example on a Nexus S (480 x 800px
and 1.5x devicePixelRatio) with a 980px default fixed layout width,
this limits the multiplier to: 980 / (480/1.5) = 3.0625
Most pages won't have blocks that actually hit this cap, or they will
only slightly exceed it (so their multiplier will only be slightly
reduced). For example it's not uncommon for desktop pages to be
slightly wider than 980px, but they would have to additionally have
text that spans the full width of the page for this to affect them, and
even then it would merely slightly decrease their multiplier).
This will have more dramatic effects on the rare desktop pages which
give a width=device-width (or similar) mobile viewport tag (on ports
which support viewports). A follow-up patch will hopefully address this
by wrapping the text in such excessively wide blocks to the layoutWidth.
Tests: fast/text-autosizing/narrow-iframe-flattened.html
fast/text-autosizing/narrow-iframe.html
fast/text-autosizing/wide-block.html
fast/text-autosizing/wide-iframe.html
- page/FrameView.cpp:
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
Made public and const, so can be used from TextAutosizer.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Computes the minimum layout width of the parent frames, as described
above.
(WebCore::TextAutosizer::processBlock):
Limits used block width to this min layout width.
LayoutTests:
Added 4 tests: a block wider than the main frame, iframes both narrower
than and wider than the main frame, both also containing wide blocks,
and a narrow iframe expanded by frame flattening.
I verified experimentally that narrow-iframe-flattened.html passes, by
enabling frame flattening in Settings.cpp, but unfortunately it won't
get run by any bots since the only platform which currently enables
Text Autosizing (Chromium), doesn't enable frame flattening (or have
the DRT methods required to test it).
- fast/text-autosizing/font-scale-factor-expected.html:
- fast/text-autosizing/font-scale-factor.html:
- fast/text-autosizing/narrow-iframe-expected.html: Added.
- fast/text-autosizing/narrow-iframe-flattened-expected.html: Added.
- fast/text-autosizing/narrow-iframe-flattened.html: Added.
- fast/text-autosizing/narrow-iframe.html: Added.
- fast/text-autosizing/wide-block-expected.html: Added.
- fast/text-autosizing/wide-block.html: Added.
- fast/text-autosizing/wide-iframe-expected.html: Added.
- fast/text-autosizing/wide-iframe.html: Added.
- platform/chromium/TestExpectations:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 12:53 PM Changeset in webkit [126057] by
-
- 5 edits in trunk
Respect runtime flags for Device Orientation and Device Motion
https://bugs.webkit.org/show_bug.cgi?id=94479
Reviewed by Adam Barth.
Source/WebCore:
There are flags that allows disabling of device orientation and device
motion at runtime. These flags determine the availability of the
corresponding event constructors in DOMWindow.
However, the flags should also control the ability to add event
listeners for these events, otherwise the feature can be used even if
it is disabled.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
Source/WebKit/chromium:
WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to
false.
- src/WebViewImpl.cpp:
(WebKit::WebView::create):
- 12:52 PM Changeset in webkit [126056] by
-
- 3 edits in trunk/Source/WebCore
Remove incorrect getBBox() code
https://bugs.webkit.org/show_bug.cgi?id=94419
Reviewed by Dirk Schulze.
SVGPathElement defines a getBBox() function that is wrong and
should use objectBoundingBox(). This patch cleans this up.
No new tests as this is just a cleanup of old code.
- svg/SVGPathElement.cpp:
(WebCore):
- svg/SVGPathElement.h:
(SVGPathElement):
- 12:50 PM Changeset in webkit [126055] by
-
- 13 edits in trunk/Source
[Chromium] Schedule texture uploads based on hard-coded timer and vsync.
https://bugs.webkit.org/show_bug.cgi?id=84281
Patch by David Reveman <reveman@chromium.org> on 2012-08-20
Reviewed by James Robinson.
Source/WebCore:
Improve interaction between vsync and texture uploads by performing
uploads in smaller batches and use a hard-coded timer to emulate
upload completion. This greatly reduces the chance of the compositor
missing a vsync due to being busy with texture uploads.
The CCScheduler client is now given a time limit when told to update
more resources. This time limit is passed to an instance of the
CCTextureUpdateController class, which is responsible for performing
texture updates until the limit is reached.
Unit tests: CCSchedulerTest.RequestCommit
CCTextureUpdateControllerTest.UpdateMoreTextures
CCTextureUpdateControllerTest.HasMoreUpdates
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::nextTickTime):
(WebCore):
- platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCSchedulerClient):
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore):
(WebCore::CCTextureUpdateController::onTimerFired):
(WebCore::CCTextureUpdateController::monotonicTimeNow):
(WebCore::CCTextureUpdateController::updateMoreTexturesTime):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
(WebCore::CCTextureUpdateController::updateMoreTexturesIfEnoughTimeRemaining):
(WebCore::CCTextureUpdateController::updateMoreTexturesNow):
- platform/graphics/chromium/cc/CCTextureUpdateController.h:
(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- tests/CCSchedulerTestCommon.h:
(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(WebKitTests::FakeCCTimeSource::setNextTickTime):
(FakeCCTimeSource):
- tests/CCTextureUpdateControllerTest.cpp:
- 12:36 PM Changeset in webkit [126054] by
-
- 15 edits5 adds in trunk
[css3-text] Add parsing support for -webkit-text-decoration-style
https://bugs.webkit.org/show_bug.cgi?id=94093
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-20
Reviewed by Julien Chaffraix.
This patch implements the "text-decoration-style" property parsing as specified
in CSS3 working draft, with "-webkit-" prefix. The specification can be found
here: http://dev.w3.org/csswg/css3-text/#text-decoration-style
Additionally, Mozilla implementation details can be found here:
https://developer.mozilla.org/en-US/docs/CSS/text-decoration-style
This is an individual task for bug 90958. Rendering support will be handled on a
different bug.
Source/WebCore:
Test: fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationStyleFlagsToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added non-bitwise TextDecorationStyle enum.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Added m_textDecorationStyle to default and copy constructors.
(WebCore::StyleRareNonInheritedData::operator==): Include m_textDecorationStyle in comparison.
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
Added m_textDecorationStyle here as it won't be used regularly.
LayoutTests:
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html: Added.
- fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js: Added.
- 12:23 PM Changeset in webkit [126053] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Persist cookies not from atexit() but the new onThreadFinished()
https://bugs.webkit.org/show_bug.cgi?id=94482
RIM PR 184923
Reviewed by Yong Li.
BlackBerry::Platform recently made changes that ensure
that MessageClient threads are being shut down correctly.
A new onThreadFinished() virtual was introduced for
custom clean-up functionality and can replace the
atexit() handler that we previously used to flush cookies
to the cookie database backingstore.
No new functionality, no new tests.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore):
(WebCore::CookieDatabaseBackingStore::onThreadFinished):
(WebCore::CookieDatabaseBackingStore::sendChangesToDatabaseSynchronously):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
- platform/blackberry/CookieManager.cpp:
(WebCore):
(WebCore::cookieManager):
- platform/blackberry/CookieManager.h:
- 12:15 PM Changeset in webkit [126052] by
-
- 7 edits3 adds in trunk/Source/WebCore
[chromium] Move non-GL-specific code out of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=93927
Patch by Alexandre Elias <aelias@google.com> on 2012-08-20
Reviewed by Adrienne Walker.
This patch moves most of the generic logic dealing with matrices and
render passes into a new class "CCDirectRenderer" that sits between
CCRenderer and LayerRendererChromium, and also publicly exposes a
few other things like the UnthrottledTextureUploader.
The plan is for the future software compositing implementation to also
derive from CCDirectRenderer, whereas the ubercompositor delegating
renderer will still derive from CCRenderer.
No new tests (no-op refactoring).
- WebCore.gypi:
- platform/graphics/chromium/GeometryBinding.cpp:
(WebCore::GeometryBinding::GeometryBinding):
- platform/graphics/chromium/GeometryBinding.h:
(GeometryBinding):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::bindFramebufferToOutputSurface):
(WebCore):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::enableScissorTestRect):
(WebCore::LayerRendererChromium::disableScissorTest):
(WebCore::LayerRendererChromium::setDrawViewportSize):
(WebCore::LayerRendererChromium::makeContextCurrent):
(WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/TextureCopier.h:
(TextureCopier):
- platform/graphics/chromium/TextureUploader.h:
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
- platform/graphics/chromium/cc/CCDirectRenderer.cpp: Added.
(projectionMatrix):
(canvasMatrix):
(WebCore):
(WebCore::CCDirectRenderer::DrawingFrame::initializeMatrices):
(WebCore::CCDirectRenderer::DrawingFrame::initializeScissors):
(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::drawFrame):
(WebCore::CCDirectRenderer::drawRenderPass):
(WebCore::CCDirectRenderer::useRenderPass):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):
(WebCore::CCDirectRenderer::renderPassTextureSize):
(WebCore::CCDirectRenderer::renderPassTextureFormat):
- platform/graphics/chromium/cc/CCDirectRenderer.h: Added.
(WebCore):
(CCDirectRenderer):
(WebCore::CCDirectRenderer::~CCDirectRenderer):
(WebCore::CCDirectRenderer::resourceProvider):
(WebCore::CCDirectRenderer::CCDirectRenderer):
(DrawingFrame):
(WebCore::CCDirectRenderer::DrawingFrame::DrawingFrame):
(CachedTexture):
(WebCore::CCDirectRenderer::CachedTexture::create):
(WebCore::CCDirectRenderer::CachedTexture::~CachedTexture):
(WebCore::CCDirectRenderer::CachedTexture::isComplete):
(WebCore::CCDirectRenderer::CachedTexture::setIsComplete):
(WebCore::CCDirectRenderer::CachedTexture::CachedTexture):
(WebCore::CCDirectRenderer::quadVertexRect):
(WebCore::CCDirectRenderer::quadRectTransform):
- 12:10 PM Changeset in webkit [126051] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Fixed invalid test expectation.
- platform/chromium/TestExpectations:
- 12:04 PM Changeset in webkit [126050] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/dom/Document.cpp
Merge 126043 - webkitfullscreenchange not fired properly in iframe.
https://bugs.webkit.org/show_bug.cgi?id=93525
Reviewed by Adam Barth.
webkitCancelFullScreen exits fullscreen by invoking webkitExitFullScreen on topDocument.
However, if webkitDidExitFullScreenForElement is invoked on a descendant document, no events
get dispatched. This change starts the event dispatch delay timer on the document where
webkitCancelFullScreen was called, so that the events get dispatched. In addition, when events
are dispatched, the check whether a node has been removed is changed to also check that the
node isn't in another document, as can happen with frames. Finally, webkitExitFullscreen
is fixed to remove unnecessary code and conform to the spec.
No new tests (the existing fullscreen/exit-full-screen-iframe.html test now passes).
- dom/Document.cpp:
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10855251
- 11:55 AM Changeset in webkit [126049] by
-
- 8 edits in trunk
Unreviewed Chromium rebaselining and test failure suppressions.
Source/WebKit/chromium:
https://bugs.webkit.org/show_bug.cgi?id=94502
- tests/CCMathUtilTest.cpp:
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=94494
https://bugs.webkit.org/show_bug.cgi?id=94501
https://bugs.webkit.org/show_bug.cgi?id=94502
- platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium/TestExpectations:
- 11:52 AM Changeset in webkit [126048] by
-
- 11 edits in trunk/Source/WebCore
Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271
Reviewed by Abhishek Arya.
Following bug 93874, we have an insertion notification. This change adds the
matching removal notification (willBeRemovedFromTree).
Refactoring covered by existing tests.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the code from here and moved it below.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- rendering/RenderObject.h:
This is the base function that should be called by every instance.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeRemovedFromTree):
- rendering/RenderListItem.h:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::willBeRemovedFromTree):
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::willBeRemovedFromTree):
- rendering/RenderRegion.h:
Overriden functions.
- 11:33 AM Changeset in webkit [126047] by
-
- 5 edits in trunk
CSP 1.1: The 'plugin-types' warning should include details about explicit type declaration when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94432
Patch by Mike West <mkwst@chromium.org> on 2012-08-20
Reviewed by Adam Barth.
Source/WebCore:
Given a 'plugin-types' Content Security Policy directive, an 'object' or
'embed' tag is blocked if it doesn't include an explicit declaration of
the plugin's expected media type. This restriction should be made clear
in the console warning that's generated.
Existing tests have been adjusted to agree with the new error string.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
If a media type fail to match the policy's restrictions, and the
declared type attribute is empty, then add another line to the
console warning, espousing the virtues of explicit declaration.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt:
- 11:23 AM Changeset in webkit [126046] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Update HUD resources as a final step to drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=93743
Reviewed by Adrienne Walker.
The HUD should be painted as a last step, after the whole frame has been
generated. This introduces a new "updateHudTexture" method on the HUD layer
and has the HUD layer save itself on CCLayerTreeHostImpl so that it can
call back to this method.
This allows the CCLayerTreeHostImpl to cause the HUD layer to update its
texture as a final step before drawing the frame, allowing the HUD texture
to contain all possible information about the current frame.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore):
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
(WebCore::CCHeadsUpDisplayLayerImpl::updateHudTexture):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(CCHeadsUpDisplayLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::setHudLayer):
(WebCore::CCLayerTreeHostImpl::hudLayer):
(CCLayerTreeHostImpl):
- 11:21 AM Changeset in webkit [126045] by
-
- 7 edits in trunk/Source
[chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210
Reviewed by James Robinson.
This patch issues the trace events from the animations. Animations will
report when they start and finish on the main and impl threads (via
TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they
change state.
Source/WebCore:
No new tests, only changes tracing behavior.
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::clone):
(WebCore):
(WebCore::CCActiveAnimation::cloneAndInitialize):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore::CCActiveAnimation::isControllingInstance):
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- tests/CCAnimationTestCommon.h:
- 11:16 AM Changeset in webkit [126044] by
-
- 2 edits in trunk/Tools
Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=94506
Reviewed by Dirk Pranke.
When running WK2 tests, don't add the "abort early" command line options.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ConfigureBuild.start):
(RunWebKitTests):
(RunWebKitTests.start):
(RunWebKit2Tests.start):
- 11:11 AM Changeset in webkit [126043] by
-
- 2 edits in trunk/Source/WebCore
webkitfullscreenchange not fired properly in iframe.
https://bugs.webkit.org/show_bug.cgi?id=93525
Reviewed by Adam Barth.
webkitCancelFullScreen exits fullscreen by invoking webkitExitFullScreen on topDocument.
However, if webkitDidExitFullScreenForElement is invoked on a descendant document, no events
get dispatched. This change starts the event dispatch delay timer on the document where
webkitCancelFullScreen was called, so that the events get dispatched. In addition, when events
are dispatched, the check whether a node has been removed is changed to also check that the
node isn't in another document, as can happen with frames. Finally, webkitExitFullscreen
is fixed to remove unnecessary code and conform to the spec.
No new tests (the existing fullscreen/exit-full-screen-iframe.html test now passes).
- dom/Document.cpp:
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
- 11:01 AM Changeset in webkit [126042] by
-
- 2 edits in trunk/Source/WebCore
[chromium] pepper plugins sometimes are shifted by 1 pixel
https://bugs.webkit.org/show_bug.cgi?id=94257
Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.
Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).
This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.
No new tests because we don't have Pepper plugin tests in WebKit.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
- 9:53 AM Changeset in webkit [126041] by
-
- 2 edits in trunk/Source/WebKit2
<https://bugs.webkit.org/show_bug.cgi?id=94486>
<rdar://problem/12128557>
REGRESSION (r121482, Lion-only): Closing a popover containing a WKView can crash
Reviewed by Darin Adler.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
Avoid calling the code added in 121482 that ensures that the undo stack is cleaned up
before the WKView is moved from one window to another when the WKView is being moved
out of a popover window. This avoids a bug in OS X 10.7 that was fixed in 10.8.
While this technically reopens a potentially crashing code path that 121482 closed,
it only reopens it for WKViews that are used for text editing and that are removed
from an NSPopover at some time earlier than tear-down of the NSPopover.
- 9:44 AM WebKit Team edited by
- (diff)
- 9:39 AM Changeset in webkit [126040] by
-
- 2 edits in trunk/Source/WebCore
postMessage() in MessagePort.idl does not match spec
https://bugs.webkit.org/show_bug.cgi?id=94477
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
Reviewed by Kentaro Hara.
Update definition of postMessage() in MessagePort.idl
to match the specification at:
http://www.w3.org/TR/html5/comms.html#messageport
The first argument should be of type 'any', not
'DOMString'.
No new tests, no behavior change.
- dom/MessagePort.idl:
- 9:18 AM Changeset in webkit [126039] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Merge 125407 - [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
- 9:18 AM Changeset in webkit [126038] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 125326 - [GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-10
Rubber-stamped by Ryosuke Niwa.
Fix Apple Win build, by avoiding to generate unreachable sections
of code in AccessibilityRenderObject::passwordFieldValue().
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::passwordFieldValue):
- 9:18 AM Changeset in webkit [126037] by
-
- 7 edits in releases/WebKitGTK/webkit-1.8/Source
Merge 125321 - [GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-10
Reviewed by Chris Fleizach.
Source/WebCore:
Fix broken implementation of AtkText and AtkEditableText
interfaces in the GTK port for password input fields.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue): Call the new
function passwordFieldValue() for password input fields.
(WebCore::AccessibilityRenderObject::text): Ditto.
(WebCore::AccessibilityRenderObject::textLength): Return the
actual length of the password in the field for GTK, return -1
otherwise (not to break current behavior in other platforms).
(WebCore::AccessibilityRenderObject::doAXStringForRange): Don't
early return for password fields in GTK (will rely on text()).
(WebCore::AccessibilityRenderObject::passwordFieldValue): New, it
returns the text being actually rendered for a password input
field (normally a masked string) in GTK. It returns String() in
the rest of platforms, to ensure we don't break anything there.
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::passwordFieldValue): Default
implementation of this new method, returning an empty string.
(AccessibilityObject):
Ensure the 'text-insert' and 'text-remove' signals for the AtkText
interface are properly emitted for password input fields.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Make
sure we never emit the password value for an input field in plain
text when inserting or removing text. Emit the masked text instead.
Source/WebKit/gtk:
Update unit test to ensure that password input fields behave
as expected when inserting and removing characters in them.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Updated unit test to
cover the special case of password input fields.
- 9:18 AM Changeset in webkit [126036] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 125181 - REGRESSION (r124997): Flaky crashes in two tests
https://bugs.webkit.org/show_bug.cgi?id=93501
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-09
Reviewed by Martin Robinson.
Add missing null check to make sure we early return if the
accessibility object does not have a valid parent exposed in the
accessibility hierarchy.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Add missing null check.
- 9:18 AM Changeset in webkit [126035] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 124997 - REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
https://bugs.webkit.org/show_bug.cgi?id=63611
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-08
Reviewed by Ryosuke Niwa.
Ensure document's layout is up-to-date before using TextIterator
to properly calculate the offset for a text change when emitting
accessibility related signals in GTK.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Call
to document->updateLayout() before using TextIterator.
- 9:18 AM Changeset in webkit [126034] by
-
- 18 edits in releases/WebKitGTK/webkit-1.8
Merge 120956 - [GTK] Fix NPAPI plugins on Windows
https://bugs.webkit.org/show_bug.cgi?id=54531
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-21
Reviewed by Martin Robinson.
.:
Define XP_WIN on Windows for plugin support.
- GNUmakefile.am:
Source/WebCore:
Switch to using PluginPackageWin.cpp and PluginViewWin.cpp on Windows
platform, and leave plugins/gtk/ only for XP_UNIX platforms. With this
we can share a lot of code with other ports and don't have to
reimplement all the Windows-specific code in plugins/gtk/.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/FileSystem.h:
(WebCore):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(GraphicsContextPlatformPrivate):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore):
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore):
- platform/gtk/FileSystemGtk.cpp:
(WebCore::unloadModule):
- plugins/PluginView.h:
(PluginView):
- plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::registerPluginView):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):
Source/WTF:
Define ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for the GTK+ port, and
include OwnPtrWin.cpp in the list of files built on Windows.
- GNUmakefile.am:
- GNUmakefile.list.am:
- wtf/Platform.h:
- 9:18 AM Changeset in webkit [126033] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 121441 - [GTK][Win]: Fix plugin drawing to an offscreen buffer
https://bugs.webkit.org/show_bug.cgi?id=89499
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-28
Reviewed by Brent Fulgham.
Take into account that the GTK+ port draws to a backing store and adjust
the target rectangle calculation accordingly.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):
- 9:13 AM Changeset in webkit [126032] by
-
- 15 edits9 deletes in trunk
Unreviewed, rolling out r125989.
http://trac.webkit.org/changeset/125989
https://bugs.webkit.org/show_bug.cgi?id=94485
"Two of the new tests always failed on Mac bots" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
- css3/compositing/blend-mode-property-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-invalid.html: Removed.
- css3/compositing/blend-mode-property-parsing.html: Removed.
- css3/compositing/blend-mode-property.html: Removed.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Removed.
- css3/compositing/script-tests/blend-mode-property-parsing.js: Removed.
- css3/compositing/script-tests/blend-mode-property.js: Removed.
- 8:18 AM Changeset in webkit [126031] by
-
- 4 edits in trunk/Source
[Qt] Custom tap-highlight-color renders fully opaque
https://bugs.webkit.org/show_bug.cgi?id=94468
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Adjust the default tap-highlight-color to figure in that is will be
drawn semi-transparent.
- rendering/RenderTheme.h:
(RenderTheme):
Source/WebKit2:
Draw tap-highlight-color at 50% transparency, to better match how
existing WebKit browsers act on custom tap-highlight colors.
- WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
- 8:10 AM Changeset in webkit [126030] by
-
- 9 edits in trunk/Source/WebKit2
[GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html
https://bugs.webkit.org/show_bug.cgi?id=94471
Reviewed by Martin Robinson.
In WebKit1 there's code to prevent that load signals are emitted
when loading internal custom error pages. We added
webkit_web_view_replace_content() with the same idea, but it has
ended up being problematic, because it allows to add any HTML
content (in WebKit1 we assumed internal error pages never failed
and always loaded) and it's impossible to know when the load has
finished. It also required a lot of logic to handle
replace_content as an especial case, in order to hide the fact
that it loads content. This patch renames
webkit_web_view_replace_content() as
webkit_web_view_load_alternate_html() and emit load events
normally.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewLoadChanged):
(webkitWebViewLoadFailed):
(webkitWebViewSetEstimatedLoadProgress):
(webkitWebViewResourceLoadStarted):
(webkitWebViewGetLoadingWebResource):
(webkitWebViewRemoveLoadingWebResource):
(webkitWebViewResourceLoadFinished):
(webkit_web_view_load_alternate_html):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testLoadAlternateHTML):
(beforeAll):
- UIProcess/API/gtk/tests/TestResources.cpp:
(beforeAll):
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(beforeAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadAlternateHTML):
- UIProcess/API/gtk/tests/WebViewTest.h:
- 8:09 AM Changeset in webkit [126029] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10855246
- 8:05 AM Changeset in webkit [126028] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
https://bugs.webkit.org/show_bug.cgi?id=88973
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-20
Reviewed by Pavel Feldman.
Added the following protocol methods to communicate with the WebGL injected
module: captureFrame, getTraceLog, dropTraceLog, replayTraceLog.
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::getTraceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):
- inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
- inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):
- 8:04 AM Changeset in webkit [126027] by
-
- 8 edits3 deletes in trunk/LayoutTests
Update canvas tests that are using CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=94474
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Andreas Kling.
CanvasPixelArray is deprecated. W3C already updated these tests on the
approved tests repository. Using Uint8ClampedArray, they now pass on
WebKit.
- canvas/philip/tests/2d.imageData.create1.type.html:
- canvas/philip/tests/2d.imageData.create2.type.html:
- canvas/philip/tests/2d.imageData.get.type.html:
- platform/chromium/TestExpectations:
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Removed.
- platform/qt/Skipped:
- 7:50 AM Changeset in webkit [126026] by
-
- 5 edits2 adds in trunk
[TouchAdjustment] Adjust to word or selection
https://bugs.webkit.org/show_bug.cgi?id=94449
Reviewed by Antonio Gomes.
Source/WebCore:
Makes each separate word a separate subtarget when context menu triggers
selections, and only the selected part of a partial selected node a
target when selections are not overridden.
Test: touchadjustment/context-menu-text-subtargets.html
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendQuadsToSubtargetList):
(WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
LayoutTests:
Tests that touch-adjustment can adjust to the right subtargets within text-nodes.
- touchadjustment/context-menu-select-text.html:
- touchadjustment/context-menu-text-subtargets-expected.txt: Added.
- touchadjustment/context-menu-text-subtargets.html: Added.
- touchadjustment/resources/touchadjustment.js:
(pointToString):
(shouldBeWithin):
- 7:34 AM Changeset in webkit [126025] by
-
- 3 edits in trunk/LayoutTests
Not reviewed: fixing flaky inspector test.
- http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- 6:57 AM Changeset in webkit [126024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Fixing the failure expectations for a flaky crasher XFrameOptions test
in debug builds. When it doesn't crash it fails due to text diff.
- platform/gtk/TestExpectations:
- 6:24 AM Changeset in webkit [126023] by
-
- 13 edits in trunk
The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Source/WTF:
According to the Uint8ClampedArray spec (http://www.khronos.org/registry/typedarray/specs/latest/#7.1)
which references WebIDL's clamping rules, with implications defined in http://www.w3.org/TR/WebIDL/#es-octet
we need to round to nearest integer, and to the even one if exactly halfway in between.
As a solution: applying C99's lrint which, in default rounding mode, does that.
The updated version of test 2d.imageData.object.round.html test passes now.
- wtf/MathExtras.h:
(lrint): Assembly based implementation for MSVC under X86, otherwise falling back to casting.
- wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::set): lrint instead of simple rounding.
LayoutTests:
Fixing expectations for the imageData rounding test, unskipping the tests on all ports.
- canvas/philip/tests/2d.imageData.object.round.html: Fixing expected results according to "round to even in halfway case".
- fast/canvas/canvas-ImageData-behaviour-expected.txt: Fixing expected results according to "round to even in halfway case".
- fast/canvas/canvas-ImageData-behaviour.js: Fixing expected results according to "round to even in halfway case".
- platform/chromium/TestExpectations: Updating bug id for 2d.imageData.object.round.html and for wrap case, adding SVG case for rebaselining.
- platform/efl/Skipped: 2d.imageData.object.round.html
- platform/efl/TestExpectations: Moving 2d.imageData.object.wrap.html case here with new bug id.
- platform/gtk/TestExpectations: Unskippng 2d.imageData.object.round.html, updating bug id for wrap case.
- platform/mac/Skipped: Unskipping 2d.imageData.object.round.html.
- platform/qt/Skipped: Unskipping 2d.imageData.object.round.html.
- 5:45 AM Changeset in webkit [126022] by
-
- 3 edits in trunk/Source/WebKit/efl
Regression(r124945): Build is broken when touch events is disabled
https://bugs.webkit.org/show_bug.cgi?id=94466
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Added missing guards around touch events code.
- ewk/ewk_touch_event.cpp:
- ewk/ewk_touch_event_private.h:
- 5:25 AM Changeset in webkit [126021] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
https://bugs.webkit.org/show_bug.cgi?id=94464
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-20
Reviewed by Carlos Garcia Campos.
Provide a compatibility method to access the new 'overset'
property through the old 'overflow' name in
WebKitDOMWebKitNamedFlow. Note that trying to access it through
g_object_get directly will give a runtime warning, since the
property does not actually exist anymore; this is done purely to
maintain API compatibility.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_webkit_named_flow_get_overflow): add method.
- bindings/gobject/WebKitDOMCustom.h:
- 5:21 AM Changeset in webkit [126020] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update flaky tests to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=94467
Unreviewed EFL gardening. Mark several tests as
flaky in order to make the bots green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 4:52 AM Changeset in webkit [126019] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add unit tests for WKEinaSharedString
https://bugs.webkit.org/show_bug.cgi?id=94104
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Added unit tests for WKEinaSharedString class.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp: Added.
(checkString):
(TEST_F):
- 4:01 AM Changeset in webkit [126018] by
-
- 12 edits in trunk/Source
[chromium] Convert screen space scroll gestures to layer space
https://bugs.webkit.org/show_bug.cgi?id=92499
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-08-20
Reviewed by James Robinson.
Source/WebCore:
Scroll gestures should be converted from screen space to local layer space to
correctly apply the scroll delta to page scaled and/or transformed layers.
Visually this means that the scrolled content will always follow the user's
finger for any "well-formed" layer transform.
Wheel scroll deltas will still be directly interpreted as local layer scroll
coordinates.
We also adjust the logic for propagating ("bubbling") scroll events to parent
layers. Previously a parent layer was allowed to scroll in the screen-space
axis orthogonal to the direction the starting layer scrolled toward. For
example if a vertically scrolling layer is scrolled diagonally down and right,
the layer moves down and its parent to the right.
This patch generalizes this behavior to non-axis aligned transformed layers so
that the scrolling direction of any parent is constrained to be perpendicular
direction of movement of the starting layer. This makes the scrolling behavior
of transformed layers physically plausible. For instance, assume a 45 degree
rotated, vertically scrollable layer. Dragging your finger vertically
(relative to the layer) scrolls the layer up and down, while horizontal
movement results in the parent of the layer moving in a corresponding way.
Since generally users want to scroll a single layer in one direction, this
patch also introduces a rule that if the resulting movement of a layer is
within 45 degrees of the original scroll input, the bubbling process is
stopped. This makes it possible to reliably scroll a single layer without
affecting any of its parents.
Added new unit tests:
CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollScaledLayer
CCMathUtilTest.smallestAngleBetweenVectors
CCMathUtilTest.vectorProjection
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::scrollLayerWithScreenSpaceDelta):
(WebCore):
(WebCore::scrollLayerWithLocalDelta):
(WebCore::CCLayerTreeHostImpl::scrollBy):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::smallestAngleBetweenVectors):
(WebCore):
(WebCore::CCMathUtil::projectVector):
- platform/graphics/chromium/cc/CCMathUtil.h:
(CCMathUtil):
Source/WebKit/chromium:
Added new tests for verifying transformed layer scrolling:
CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollScaledLayer
Also some tests for the introduced math utilities:
CCMathUtilTest.smallestAngleBetweenVectors
CCMathUtilTest.vectorProjection
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- tests/CCLayerTreeHostImplTest.cpp: Adjusted scroll delta in scrollChildBeyondLimit to avoid triggering the 45 degree rule.
- tests/CCLayerTreeHostTest.cpp:
- tests/CCMathUtilTest.cpp:
- tests/WebCompositorInputHandlerImplTest.cpp:
(MockCCInputHandlerClient):
(WebKit::TEST_F):
- 3:27 AM Changeset in webkit [126017] by
-
- 11 edits in trunk/Source
[GTK] Add API to set preferred languages to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90878
Source/WebCore:
Unreviewed. Fix mac build.
- WebCore.exp.in: Export WebCore::languageDidChange().
Source/WebKit2:
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Public API to set a
list of preferred languages sorted from most desirable to least
desirable.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextLanguages):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(resourceGetDataCallback):
(WebViewTest::mainResourceData): Moved from TestWebKitWebContext
to make it available to all WebViewTests.
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged): Notify our
observer that the languages have been overriden.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::buildAcceptLanguages): Helper function to build the
accept languages as specified in RFC 2616.
(WebKit::setSoupSessionAcceptLanguage): Set the accept-language
property of the default SoupSession.
(WebKit::languageChanged): Update the preferred languages in
SoupSession.
(WebKit::WebProcess::platformInitializeWebProcess): Add an
observer to be notified when the list of preferred languages is
updated.
(WebKit::WebProcess::platformTerminate): Remove the observer added
in platformInitializeWebProcess().
- 3:05 AM Changeset in webkit [126016] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: improve standalone test harness to allow attaching to inspector before test.
https://bugs.webkit.org/show_bug.cgi?id=94426
Reviewed by Vsevolod Vlasov.
- User can not "Debug", attach inspector to the front-end and "Continue" test execution.
- You can also assign filter from the query parameter.
- inspector/front-end/test-runner.html:
- 2:38 AM Changeset in webkit [126015] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark several inspector tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=94452
Unreviewed EFL gardening. Mark several inspector
tests as flaky to make the bots green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 2:33 AM Changeset in webkit [126014] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Moving a couple of WONTFIX accessibility tests into the appropriate
section.
Removing crash expectations for a few accessibility tests that were fixed
in r125920.
Adding a flaky crash expectation for a XFrameOptions http test.
Adding platform-specific baselines for a few css3 compositing tests that fail
differently because of using JavaScriptCore instead of V8.
- platform/gtk/TestExpectations:
- platform/gtk/css3/compositing: Added.
- platform/gtk/css3/compositing/blend-mode-property-expected.txt: Added.
- platform/gtk/css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- 2:29 AM Changeset in webkit [126013] by
-
- 3 edits in trunk/Tools
Add mountain lion to build config.
https://bugs.webkit.org/show_bug.cgi?id=94441
Reviewed by Adam Barth.
Add Mountain Lion to the build trigger configurations.
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
- Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
- 2:27 AM Changeset in webkit [126012] by
-
- 23 edits1 move3 adds in trunk
Web Inspector: load scripts panel lazily
https://bugs.webkit.org/show_bug.cgi?id=94416
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- removes access to WebInspector.panels.scripts and loads it lazily.
- extracts classes to their own files when classes residing in one file belong to different modules
- removes StylesPanel.js in favor of the actual classes it contains
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/compile-front-end.py:
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.handleShortcut):
- inspector/front-end/BreakpointsSidebarPane.js:
- inspector/front-end/FilteredItemSelectionDialog.js:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
- inspector/front-end/NativeBreakpointsSidebarPane.js: Added.
(WebInspector.NativeBreakpointsSidebarPane):
(WebInspector.NativeBreakpointsSidebarPane.prototype._addListElement):
(WebInspector.NativeBreakpointsSidebarPane.prototype._removeListElement):
(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
- inspector/front-end/ScriptSnippetModel.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
- inspector/front-end/SnippetJavaScriptSourceFrame.js: Added.
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
- inspector/front-end/StyleSheetOutlineDialog.js: Added.
(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemSubtitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):
- inspector/front-end/StyleSource.js: Renamed from Source/WebCore/inspector/front-end/StylesPanel.js.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
(WebInspector.StyleSource):
(WebInspector.StyleSource.prototype.isEditable):
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSource.prototype._callOrSetTimeout):
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
(WebInspector.InspectorStyleSource):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._showAnchorLocation):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
This change removes access to WebInspector.panels.scripts and loads it lazily.
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/filtered-item-selection-dialog-filtering.html:
- inspector/styles/edit-inspector-stylesheet.html:
- inspector/tabbed-editors-history.html:
- 2:16 AM Changeset in webkit [126011] by
-
- 2 edits in trunk/LayoutTests
[EFL] Move CSS 3 compositing tests to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94451
Unreviewed EFL gardening. Skip css3/compositing test
cases for EFL port until we turn on CSS_COMPOSITING
compile flag.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 2:09 AM Changeset in webkit [126010] by
-
- 6 edits2 deletes in trunk
[EFL] Get rid of pango backend support once harfbuzz-ng is working
https://bugs.webkit.org/show_bug.cgi?id=92102
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
.:
Removing choice of font backend, Pango detection not required any more.
- Source/cmake/FindPango.cmake: Removed.
- Source/cmake/LibFindMacros.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Removing choice of font backend.
Source/WebCore:
Removing support for Pango complex font rendering now that we HarfBuzz.
No new tests, no change in behavior.
- PlatformEfl.cmake: Removing Pango specific includes and libraries.
Source/WebKit:
Removing pango-specific includes and libraries.
- PlatformEfl.cmake: Pango sections removed.
- 2:00 AM Changeset in webkit [126009] by
-
- 12 edits in trunk
Web Inspector: prepare scripts panel to be lazily loaded
https://bugs.webkit.org/show_bug.cgi?id=94423
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- makes scripts panel read workspace data upon creation
- moves pause on script state management into the debugger model
- updates frontend API to use debugger model, not scripts panel
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.debuggerEnabled):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
(WebInspector.DebuggerModel.prototype._pauseOnExceptionStateChanged):
(WebInspector.DebuggerModel.prototype.get _debuggerWasDisabled):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._enableDebugging):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
- inspector/debugger/debugger-autocontinue-on-syntax-error.html:
- inspector/debugger/debugger-pause-in-internal.html:
- inspector/debugger/debugger-pause-on-exception.html:
- inspector/debugger/scripts-panel-expected.txt:
- 1:47 AM Changeset in webkit [126008] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Adapt to changes in the platform media player API
https://bugs.webkit.org/show_bug.cgi?id=94329
PR #194237
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-20
Reviewed by Antonio Gomes.
The interface to platform's media player has changed from MMRPlayer
to PlatformPlayer. This patch adapts to this change.
And we also decided to postpone the creation of PlatformPlayer until
the loading started. This is needed because we may create different
types of player for different media sources.
This is a refactor, no new tests.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::showErrorDialog):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- 1:23 AM Changeset in webkit [126007] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove FAIL expectation fixed by r126006
- platform/chromium/TestExpectations:
- 1:14 AM Changeset in webkit [126006] by
-
- 2 edits in trunk/LayoutTests
[chromium] context-menu.html fails on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94367
Reviewed by Kenneth Rohde Christiansen.
Set editing behaviour explicitly so the test behaves the same independent of host OS.
- touchadjustment/context-menu.html:
- 1:05 AM WebKit Team edited by
- (diff)
- 12:53 AM Changeset in webkit [126005] by
-
- 8 edits in trunk/Source
[V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94446
Reviewed by Adam Barth.
To kill V8Proxy, we can move contextDebugId() and setContextDebugId()
from V8Proxy to ScriptController.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore):
(WebCore::ScriptController::contextDebugId):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
- 12:47 AM Changeset in webkit [126004] by
-
- 7 edits in trunk/Source/WebCore
[V8] Move V8Proxy::newInstance() to V8ObjectConstructor
https://bugs.webkit.org/show_bug.cgi?id=94443
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves V8Proxy::newInstance() to
V8ObjectConstructor::newInstanceInFrame().
In addition, this patch does the following things:
- For consistency with V8ObjectConstructor::newInstanceInFrame(),
this patch inserts an if(v8::V8::IsDead()) check to just after
Function::NewInstance(). The check is done by V8Binding::assertIfV8IsDead().
- To avoid #include circular dependency, this patch de-inline
V8ObjectConstructor::newInstance()s. I didn't observe any perf regression.
I don't think these methods are worth being inlined, because
these methods call Function::NewInstance(), which is not inlined
and calls a bunch of heavy mehtods in V8.
No tests. No change in behavior.
- bindings/v8/NPV8Object.cpp:
(_NPN_Construct):
- bindings/v8/V8Binding.cpp:
(WebCore::assertIfV8IsDead):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8ObjectConstructor.cpp:
(WebCore::V8ObjectConstructor::newInstance):
(WebCore):
(WebCore::V8ObjectConstructor::newInstanceInFrame):
- bindings/v8/V8ObjectConstructor.h:
(WebCore):
(V8ObjectConstructor):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::instrumentedCallFunction):
- 12:38 AM Changeset in webkit [126003] by
-
- 2 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94439
Unreviewed. Temporary disabled these tests.
- platform/chromium/TestExpectations: Add entries for these tests.
- 12:33 AM Changeset in webkit [126002] by
-
- 8 edits in trunk/Source
[V8] Move V8Proxy::m_extensions to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94444
Reviewed by Adam Barth.
Source/WebCore:
To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController.
This patch also renames extensions() to registeredExtensions() for clarification.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::registeredExtensions):
(WebCore):
(WebCore::ScriptController::registerExtensionIfNeeded):
- bindings/v8/ScriptController.h:
(WebCore):
(ScriptController):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
Source/WebKit/chromium:
To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController.
No tests. No change in behavior.
- src/WebScriptController.cpp:
(WebKit::WebScriptController::registerExtension):
- 12:21 AM Changeset in webkit [126001] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: toolbar causes 8 reflows upon opening
https://bugs.webkit.org/show_bug.cgi?id=94422
Reviewed by Yury Semikhatsky.
Toolbar's overflow code causes inspector to do 8 reflows upon opening.
Fixing it via introducing batch toolbar update.
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.setCoalescingUpdate):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
- inspector/front-end/inspector.css:
(body.compact .toolbar-icon):
(body.compact .toolbar-icon.custom-toolbar-icon):
(body.compact .toolbar-item:active .toolbar-icon):
(body.compact .toolbar-label):
(body.compact .toolbar-item.resources .toolbar-icon):
(body.compact .toolbar-item.network .toolbar-icon):
(body.compact .toolbar-item.scripts .toolbar-icon):
(body.compact .toolbar-item.timeline .toolbar-icon):
(body.compact .toolbar-item.profiles .toolbar-icon):
(body.compact .toolbar-item.audits .toolbar-icon):
(body.compact .toolbar-item.console .toolbar-icon):
- inspector/front-end/inspector.js:
(WebInspector.get _setCompactMode):
(WebInspector.windowResize):
Aug 19, 2012:
- 11:51 PM Changeset in webkit [126000] by
-
- 2 edits in trunk/Source/WebCore
[V8] Replace proxy()->windowShell() in ScriptController with windowShell()
https://bugs.webkit.org/show_bug.cgi?id=94445
Reviewed by Adam Barth.
Now ScriptController owns windowShell. So ScriptController doesn't
need to get windowShell through V8Proxy.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::updateSecurityOrigin):
(WebCore::ScriptController::haveInterpreter):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::namedItemAdded):
(WebCore::ScriptController::namedItemRemoved):
- 11:11 PM Changeset in webkit [125999] by
-
- 17 edits1 add in trunk/Source/JavaScriptCore
The relationship between abstract values and structure transition watchpoints should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=94205
Reviewed by Geoffrey Garen.
This patch does a number of things related to the handling of the abstract values
arrising from values with structures known to be watchpointable:
- This rationalizes the relationship between the structure that we know an object to have *right now* based on having executed a check against that structure, and the structure that we know the object could have *in the future* based on a type check executed in the past over a structure that was watchpointable.
- We use the above to assert that structure transition watchpoints are being used soundly.
- We use the above to strength reduce CheckStructure into StructureTransitionWatchpoint whenever possible.
- This rationalizes the handling of CFA over constants that appeared in the bytecode. If at compile-time the constant has a watchpointable structure, then we can prove what structures it may have in the future. The analysis uses this to both assert that structure transition watchpoints are being used correctly, and to find opportunities for using them more aggressively.
The net effect of all of these changes is that OSR entry should work more smoothly.
It may also be a slight win due to strength reductions, though most of those strength
reductions would have already been done by the parser and the structure check hoister.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractValue.h:
(DFG):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(AbstractValue):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterValueByType):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(Node):
(JSC::DFG::Node::hasStructure):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::forwardSpeculationWatchpoint):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpointWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculateArray):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h: Added.
(DFG):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::isClearOrTop):
(JSC::DFG::StructureAbstractValue::isNeitherClearNorTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::speculationFromStructures):
(JSC::DFG::StructureAbstractValue::hasSingleton):
(JSC::DFG::StructureAbstractValue::singleton):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::StructureAbstractValue::topValue):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 10:18 PM Changeset in webkit [125998] by
-
- 12 edits in trunk/Source/WebCore
[V8] Move V8Proxy::callFunction() to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94437
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves callFunction() from V8Proxy to ScriptController.
No tests. No change in behavior.
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
- bindings/v8/NPV8Object.cpp:
(_NPN_Invoke):
(_NPN_InvokeDefault):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h:
(WebCore):
(ScheduledAction):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunction):
(WebCore):
(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::callListenerFunction):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
- 10:11 PM Changeset in webkit [125997] by
-
- 9 edits in trunk/Source/WebCore
[Forms] Set SpinButtonElement free from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=93941
Reviewed by Kent Tamura.
This patch removes dependency to HTMLInputElement from SpinButtonElement.
Functionalities used to be calling HTMLInputElement functions are
replaced to calling functions SpinButtonOwner class.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::focusAndSelectSpinButtonOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Moved code from SpinButtonElement::willRespondToMouseClickEvents
(WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents): Moved code from SpinButtonElement::forwardEvent
- html/TextFieldInputType.h:
(TextFieldInputType):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::focusAndSelectEditControlOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerFocused): Added for DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.
- html/TimeInputType.h:
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusAndSelectSpinButtonOwner): Added for SpinButtonElementOwner class change.
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToMouseEvents): ditto
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToWheelEvents): ditto
- html/shadow/DateTimeEditElement.h:
(EditControlOwner): Added new virtual function declarations for SpinButtonElementOwner class change.
(DateTimeEditElement): Added new function declarations for SpinButtonElementOwner.
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler): Changed to use SpinButtonElementOwner instead of HTMLInputElement.
(WebCore::SpinButtonElement::forwardEvent): ditto
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto
(WebCore::SpinButtonElement::step): ditto
(WebCore::SpinButtonElement::shouldRespondToMouseEvents): Added helper function for calling SpinButtonOwner instance.
- html/shadow/SpinButtonElement.h:
(SpinButtonOwner): Added new virtual function declarations.
(SpinButtonElement):
- 9:52 PM Changeset in webkit [125996] by
-
- 11 edits in trunk
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94439
Reviewed by Kent Tamura.
Source/WebCore:
This patch disabled CSS selector for Firefox compatibility applied to
multiple fields time input UI, because it is supposed to apply text
field rather than multiple fields.
This patch allows us to have same appearance among Chromium-Linux,
Mac and Win.
No new tests. Following existing tests cover this change:
fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html
- css/themeWin.css: Exclude input[type="time"] selector if ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
enabled.
LayoutTests:
This patch updates expected images of multiple fields time input UI for
Chromium-Linux and CSS selectors for expected HTML file for changing
of Source/WebCore/css/themeWin.css.
- fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css:
(.host): Changed padding property.
(.ampmField): Remove wrong property.
(.hourField): ditto
(.millisecondField): ditto
(.minuteField): ditto
(.secondField): ditto
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
- platform/chromium/TestExpectations: Remove Chromium-Mac disabled entries.
- 9:39 PM Changeset in webkit [125995] by
-
- 14 edits2 moves in trunk/Source/WebCore
[V8] Rename SafeAllocation to V8ObjectConstructor
https://bugs.webkit.org/show_bug.cgi?id=94436
Reviewed by Adam Barth.
For clarification.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::construct):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8NPObject.cpp:
(WebCore::createV8ObjectForNPObject):
- bindings/v8/V8ObjectConstructor.cpp: Renamed from Source/WebCore/bindings/v8/SafeAllocation.cpp.
(WebCore):
(WebCore::V8ObjectConstructor::isValidConstructorMode):
- bindings/v8/V8ObjectConstructor.h: Renamed from Source/WebCore/bindings/v8/SafeAllocation.h.
(WebCore):
(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(V8ObjectConstructor):
(WebCore::V8ObjectConstructor::newInstance):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::createInjectedScriptHostV8Wrapper):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- 9:35 PM EFLWebKitTests edited by
- (diff)
- 9:32 PM Changeset in webkit [125994] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Put webkit compositor binding files in separate conditionally included gyp section
https://bugs.webkit.org/show_bug.cgi?id=94392
Patch by James Robinson <jamesr@chromium.org> on 2012-08-19
Reviewed by Dirk Pranke.
This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the
WebKit repository or an external target.
- WebKit.gyp:
- WebKit.gypi:
- 9:32 PM Changeset in webkit [125993] by
-
- 6 edits in trunk/Source/WebCore
[V8] Move m_windowShell from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94438
Reviewed by Adam Barth.
m_windowShell should be owned by ScriptController.
After this change, I can move a bunch of V8Proxy methods
that access windowShell() from V8Proxy to ScriptController.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
- bindings/v8/ScriptController.h:
(WebCore):
(WebCore::ScriptController::windowShell):
(ScriptController):
- bindings/v8/V8Binding.h:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::windowShell):
(WebCore):
- bindings/v8/V8Proxy.h:
(WebCore):
(WebCore::V8Proxy::frame):
(V8Proxy):
- 9:03 PM Changeset in webkit [125992] by
-
- 2 edits in trunk/Source/WebCore
Do not allocate SQLiteDatabase's m_openErrorMessage until its needed
https://bugs.webkit.org/show_bug.cgi?id=94434
Reviewed by Andreas Kling.
Previously, m_openErrorMessage was initialized from a static literal string whenever
the database is not open.
This patch changes the way we use m_openErrorMessage to only allocate a string in the
few cases where we need it. If there is no error message, we fallback to the previous
default string.
The goal is to prevent allocating the string unless needed. That saves initialization time
and memory.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastErrorMsg):
- 8:44 PM Changeset in webkit [125991] by
-
- 2 edits in trunk/Source/WebCore
Use initialization from literal for HTML Input type names
https://bugs.webkit.org/show_bug.cgi?id=94421
Reviewed by Kent Tamura.
AtomicString's initialization from literal is faster and use less memory.
- html/InputType.cpp:
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):
- 8:39 PM Changeset in webkit [125990] by
-
- 2 edits in trunk/Source/WebCore
Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
https://bugs.webkit.org/show_bug.cgi?id=94420
Reviewed by Kentaro Hara.
Use the new StringBuilder::appendLiteral() instead of keeping some WTF::String in
memory.
The patch reduces memory usage.
It also reduces the binary size (-1672 bytes on x86_64).
I did not measure any difference in performance.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
- 8:33 PM Changeset in webkit [125989] by
-
- 15 edits11 adds in trunk
Source/WebCore: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
Tests: css3/compositing/blend-mode-property-parsing-invalid.html
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateLayerBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
- css3/compositing: Added.
- css3/compositing/blend-mode-property-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid.html: Added.
- css3/compositing/blend-mode-property-parsing.html: Added.
- css3/compositing/blend-mode-property.html: Added.
- css3/compositing/script-tests: Added.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
- css3/compositing/script-tests/blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testFilterRule):
- css3/compositing/script-tests/blend-mode-property.js: Added.
- 7:56 PM Changeset in webkit [125988] by
-
- 7 edits2 adds in trunk
DOM mutation against including <link> shouldn't trigger pending HTML parser.
https://bugs.webkit.org/show_bug.cgi?id=93641
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLLinkElement::removedFrom() invoked Document::removePendingSheet(), which can trigger
HTMLParser that can mutate DOM tree. DOM mutation reentrancy on like this is problematic and
should be prohibited.
This change add an variation of Document::removePendingSheet() which postpones the notification
which triggers DOM mutation, and flush such pending notifications at the end of ongoing mutation.
Test: http/tests/loading/remove-child-triggers-parser.html
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeRemovalNotifier::notify): Flushed pending notifications at the end.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::removePendingSheet): Added RemovePendingSheetNotificationType parameter.
(WebCore):
(WebCore::Document::didRemoveAllPendingStylesheet): Extracted from removePendingSheet()
- dom/Document.h:
(Document):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet): A flag setter.
(WebCore::Document::notifyRemovePendingSheetIfNeeded):
(WebCore):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::removedFrom): Switched to use "notification later" version of removePendingSheet()
(WebCore::HTMLLinkElement::removePendingSheet): Added RemovePendingSheetNotificationType parameter.
- html/HTMLLinkElement.h:
LayoutTests:
Note that the test content need to be such cryptic because HTML parser is involving the
captured bug and adding explanations can affect the behavior then mask the bug.
- http/tests/loading/remove-child-triggers-parser-expected.txt: Added.
- http/tests/loading/remove-child-triggers-parser.html: Added.
- 7:30 PM Changeset in webkit [125987] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Gardening for fast/forms/range/thumbslider-no-parent-slider.html
https://bugs.webkit.org/show_bug.cgi?id=94334
Unreviewed gardening.
Slider thumb can not be displayed without parent slider because
current theme of EFL does not display slider thumb separately.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-19
- platform/efl/TestExpectations:
- platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
- platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- 7:25 PM Changeset in webkit [125986] by
-
- 3 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297
Reviewed by Kent Tamura.
This patch updates a logic for detcting multiple fields time input UI
has second field or not.
- fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:
(checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
on calculating rendering width of input elements. When input elements are rendered on
same baseline, width of first one is 126px and second is 125px.
- platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
- 6:31 PM Changeset in webkit [125985] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from HTMLProgressElement::m_value
https://bugs.webkit.org/show_bug.cgi?id=94336
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.
HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because
it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement
node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.
No tests. No change in behavior.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLProgressElement.h:
- 6:08 PM Changeset in webkit [125984] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton
https://bugs.webkit.org/show_bug.cgi?id=94339
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary
RefPtr<Node>s. The rationale is described in bug 94324.
SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not
need to be RefPtr<Node>s, because they are guaranteed to point to the shadow
DOM tree of the SearchInputType node, which is guaranteed to exist in the
subtree of the SearchInputType node.
No tests. No change in behavior.
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
(WebCore::SearchInputType::destroyShadowSubtree):
(WebCore::SearchInputType::subtreeHasChanged):
- html/SearchInputType.h:
(SearchInputType):
- 3:39 PM Changeset in webkit [125983] by
-
- 5 edits4 adds in trunk
CSP 1.1: Add 'plugin-types' and 'form-action' DOM API.
https://bugs.webkit.org/show_bug.cgi?id=94415
Patch by Mike West <mkwst@chromium.org> on 2012-08-19
Reviewed by Adam Barth.
Source/WebCore:
Experimental implementations of the new 'plugin-types' and 'form-action'
directives recently landed, but we neglected to add DOM API endpoints to
query their state. Those APIs have been added to the specification[1],
and this patch brings our implementation up to date.
Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html
- page/DOMSecurityPolicy.cpp:
(isAllowed):
As a drive-by, change a parameter from a KURL to a String to match
the actual template. There's no reason to stringify an empty URL
when we can just use an empty string instead.
(isAllowedWithType):
Call out to the ContentSecurityPolicy object to check the protected
resource's ability to load a given media type.
(WebCore::DOMSecurityPolicy::allowsFormAction):
Call out to the ContentSecurityPolicy object to check the protected
resource's ability to submit a form to the given URL.
(WebCore):
(WebCore::DOMSecurityPolicy::allowsPluginType):
Pipes the plugin type through 'isAllowedWithType' for resolution.
- page/DOMSecurityPolicy.h:
Add the 'allowsPluginType' and 'allowsFormAction' methods.
(DOMSecurityPolicy):
- page/DOMSecurityPolicy.idl:
Add the 'allowsPluginType' and 'allowsFormAction' methods.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html: Added.
- 2:59 PM Changeset in webkit [125982] by
-
- 14 edits in trunk/Source/JavaScriptCore
The current state of the call frame should be taken into account in the DFG for both predictions and proofs
https://bugs.webkit.org/show_bug.cgi?id=94412
Reviewed by Geoffrey Garen.
This ensures that no matter how smart the DFG gets, it'll always know through
which entrypoint OSR will try to enter, and with which values it will attempt
to do so. For prologue OSR, this has no effect other than adding the current
arguments to the argument predictions. For loop OSR, this makes our treatment
of the loop slightly more conservative - just conservative enough to ensure
that OSR succeeds.
- bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
- bytecode/CodeBlock.h:
(CodeBlock):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::setMostSpecific):
(AbstractValue):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(Graph):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::compileOptimizedFor):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
- 12:49 PM Changeset in webkit [125981] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add additional fields to WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=94238
Patch by Rick Byers <rbyers@chromium.org> on 2012-08-19
Reviewed by James Robinson.
Add a union to WebGestureEvent with per-event-type data, as a first
step to eliminating the overloaded delta fields.
- public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
- 12:34 PM Changeset in webkit [125980] by
-
- 52 edits in trunk
Web Inspector: load network panel lazily
https://bugs.webkit.org/show_bug.cgi?id=94414
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change removes access to WebInspector.panels.network and loads it lazily.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.clone):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.create):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.NetworkLog.prototype.requestForId):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._showAnchorLocation):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
- http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.navigate):
(initialize_InspectorTest.InspectorTest._innerReloadPage):
- http/tests/inspector/network-test.js:
- http/tests/inspector/network/async-xhr-json-mime-type.html:
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html:
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
- http/tests/inspector/network/download.html:
- http/tests/inspector/network/network-cachedresources-with-same-urls.html:
- http/tests/inspector/network/network-clear-cache.html-disabled:
- http/tests/inspector/network/network-clear-cookies.html-disabled:
- http/tests/inspector/network/network-content-replacement-embed.html:
- http/tests/inspector/network/network-content-replacement-xhr.html:
- http/tests/inspector/network/network-cyrillic-xhr.html:
- http/tests/inspector/network/network-disable-cache-memory.html:
- http/tests/inspector/network/network-disable-cache-xhrs.html:
- http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
- http/tests/inspector/network/network-embed.html:
- http/tests/inspector/network/network-empty-xhr.html:
- http/tests/inspector/network/network-iframe-load-and-delete.html:
- http/tests/inspector/network/network-image-404.html:
- http/tests/inspector/network/network-initiator-from-console.html:
- http/tests/inspector/network/network-preview-json.html:
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/network/network-shared-worker.html:
- http/tests/inspector/network/network-sidebar-width.html:
- http/tests/inspector/network/network-size-chunked.html:
- http/tests/inspector/network/network-size-sync.html:
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/network/network-worker.html:
- http/tests/inspector/network/network-xhr-async-double.html:
- http/tests/inspector/network/network-xhr-async.html:
- http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
- http/tests/inspector/network/network-xhr-sync.html:
- http/tests/inspector/network/request-parameters-decoding.html:
- http/tests/inspector/network/x-frame-options-deny.html:
- http/tests/inspector/resource-har-pages.html:
- http/tests/inspector/resource-tree/resource-tree-mimetype.html:
- 12:12 PM Changeset in webkit [125979] by
-
- 2 edits in trunk/Source/WebKit2
WebPageProxy::setCursor does not check that the view is still in an active window
https://bugs.webkit.org/show_bug.cgi?id=94427
Reviewed by Alexey Proskuryakov.
The Web process may ask to change the cursor when the view is in an active window, but
if by the time the UI process receives the message, the view is no longer in a window or the
window is not active , then the cursor should not change.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCursor): Added a check that the view is in an active window before
allowing the page to change the cursor.
- 11:34 AM Changeset in webkit [125978] by
-
- 9 edits in trunk/Source/WebKit2
Unreviewed, rolling out r125972.
http://trac.webkit.org/changeset/125972
https://bugs.webkit.org/show_bug.cgi?id=94431
Breaks AppleMac builds (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-19
- UIProcess/API/gtk/WebKitWebContext.cpp:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest):
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged):
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
- 11:30 AM Changeset in webkit [125977] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r125976.
http://trac.webkit.org/changeset/125976
https://bugs.webkit.org/show_bug.cgi?id=94430
it does not fix build. (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-19
- GNUmakefile.am:
- GNUmakefile.list.am:
- 10:15 AM Changeset in webkit [125976] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add idl files in Modules/quota to EXTRA_DIST.
- GNUmakefile.list.am: Add missing files to compilation.
- 9:24 AM Changeset in webkit [125975] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r125280-r125284): inspector/console/console-format-collections.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93748
Reviewed by Pavel Feldman.
Not reviewed - simple test fix.
- inspector/console/console-format-collections-expected.txt:
- inspector/console/console-format-collections.html:
- 5:29 AM Changeset in webkit [125974] by
-
- 5 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add API unit tests for Web Intents
https://bugs.webkit.org/show_bug.cgi?id=90454
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-19
Reviewed by Kenneth Rohde Christiansen.
Add unit testing for Web intent requests,
including the "intent,request,new" signal on
the Ewk_View and the Ewk_Intent API.
- UIProcess/API/efl/ewk_view.h: Fix documentation for argument type of "intent,request,new" signal.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseClick): Add utility method to simulate a click at given
coordinates. This is needed for testing functionality that requires a user gesture.
(EWK2UnitTest):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/resources/intent-request.html: Added.
- UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(stringSortCb):
(onIntentReceived):
(TEST_F):
- 5:02 AM Changeset in webkit [125973] by
-
- 2 edits in trunk/Source/WebCore
Remove unused ElementAttributeData::removeAttribute() overload.
<http://webkit.org/b/94425>
Reviewed by Antti Koivisto.
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 2:24 AM Changeset in webkit [125972] by
-
- 9 edits in trunk/Source/WebKit2
[GTK] Add API to set preferred languages to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90878
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Public API to set a
list of preferred languages sorted from most desirable to least
desirable.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextLanguages):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(resourceGetDataCallback):
(WebViewTest::mainResourceData): Moved from TestWebKitWebContext
to make it available to all WebViewTests.
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged): Notify our
observer that the languages have been overriden.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::buildAcceptLanguages): Helper function to build the
accept languages as specified in RFC 2616.
(WebKit::setSoupSessionAcceptLanguage): Set the accept-language
property of the default SoupSession.
(WebKit::languageChanged): Update the preferred languages in
SoupSession.
(WebKit::WebProcess::platformInitializeWebProcess): Add an
observer to be notified when the list of preferred languages is
updated.
(WebKit::WebProcess::platformTerminate): Remove the observer added
in platformInitializeWebProcess().
Aug 18, 2012:
- 5:57 PM Changeset in webkit [125971] by
-
- 3 edits in trunk/Source/WebCore
Refactor SVGMaskElement to inherit from StyledElement
https://bugs.webkit.org/show_bug.cgi?id=94418
Reviewed by Dirk Schulze.
Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
to inherit from SVGStyledElement which matches the spec:
http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
No new tests as this is just a refactoring.
- svg/SVGMaskElement.cpp:
(WebCore):
(WebCore::SVGMaskElement::SVGMaskElement):
- svg/SVGMaskElement.h:
- 3:56 PM Changeset in webkit [125970] by
-
- 2 edits in branches/chromium/1229/Source
Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829399
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857077
- 2:47 PM Changeset in webkit [125969] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] ewk_back_forward_list_item properties should be in sync with WebProcessProxy::m_backForwardListItemMap
https://bugs.webkit.org/show_bug.cgi?id=94248
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-18
Reviewed by Kenneth Rohde Christiansen.
Currently ewk_back_forward_list_item properties are initialized from
WKBackForwardListItemRef once in the constructor and then just stored.
This is erroneous approach as back forward items can be initialized within
several iterations, meaning several ipc calls to UI process and several updates
of WebProcessProxy::m_backForwardListItemMap where the items are stored.
Hence the values of ewk_back_forward_list_item properties should be updated
with the corresponding WKBackForwardListItem function invokes every time
they are called.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(_Ewk_Back_Forward_List_Item): Data members have to be mutable as assigned being const pointers.
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):
- 10:43 AM Changeset in webkit [125968] by
-
- 3 edits in trunk/Source/WebCore
CSSValueList: Reserve the exact amount of space needed when constructing from CSS parser.
(No bug URL as Bugzilla is down today.)
Reviewed by Antti Koivisto.
Use Vector::reserveInitialCapacity() when constructing a CSSValueList from a CSSParserValueList
since we have the final length available. Also inlined the trivial append() and prepend().
- css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
- css/CSSValueList.h:
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):
- 7:21 AM Changeset in webkit [125967] by
-
- 3 edits in trunk/LayoutTests
Follow up to r125966, fixing flaky tests.
- inspector/elements/event-listeners-about-blank.html:
- 2:32 AM Changeset in webkit [125966] by
-
- 22 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- removed usages of WebInspector.panels.profiles.
- made panel lazily loaded
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/CPUProfileView.js: (WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js: (WebInspector.CSSSelectorProfileType.prototype.buttonClicked): (WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile): (WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile): (WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._profiles): (WebInspector.HeapSnapshotView.prototype.populateContextMenu): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js: (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileHeader.prototype.view): (WebInspector.ProfileHeader.prototype.createView): (WebInspector.ProfilesPanel.prototype.toggleRecordButton): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu): (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector._toggleSearchingForNode): (WebInspector._profilesLinkifier): (WebInspector._requestZoom.set InspectorFrontendHost): (WebInspector._requestZoom): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- WebKit.gyp:
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-summary-show-ranges.html:
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
- 12:20 AM Changeset in webkit [125965] by
-
- 29 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- Introduces importScript that evals in debug mode and inlines for release
- Loads Element, Resources, Timeline, Audits panels lazily.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor): (WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/Color.js:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.PanelDescriptor): (WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SettingsScreen.js: (WebInspector.GenericSettingsTab):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/Spectrum.js: (WebInspector.Spectrum.prototype.get outputColorFormat):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
- inspector/inline-javascript-imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- WebKit.gyp:
- scripts/concatenate_js_files.py: (OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Showing panels prior to running tests in order to load the code for them.
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/styles/styles-invalid-color-values.html:
- inspector/timeline-dfs.html:
Aug 17, 2012:
- 11:39 PM EFLWebKit edited by
- (diff)
- 11:01 PM Changeset in webkit [125964] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CSE should be more honest about when it changed the IR
https://bugs.webkit.org/show_bug.cgi?id=94408
Reviewed by Geoffrey Garen.
The CSE phase now always returns true if it changed the IR.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
- 8:46 PM Changeset in webkit [125963] by
-
- 2 edits in trunk/Tools
Add self to webkit contributors list
https://bugs.webkit.org/show_bug.cgi?id=94409
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-17
Reviewed by Dirk Pranke.
Add name, email and irc handle to webkit contributors list.
- Scripts/webkitpy/common/config/committers.py:
- 7:51 PM Changeset in webkit [125962] by
-
- 3 edits2 adds in trunk
Calendar picker shows wrong date when input element has year earlier than 100
https://bugs.webkit.org/show_bug.cgi?id=94100
Reviewed by Kent Tamura.
Source/WebCore:
Date.UTC can't set an year earlier than 100. So when the input has a value earlier than 100, calendar picker shows the wrong date.
Test: fast/forms/date/calendar-picker-appearance-pre-100.html
- Resources/pagepopups/calendarPicker.js:
(createUTCDate): Uses setUTCFullYear when the year is pre 100.
(parseDateString):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
LayoutTests:
- fast/forms/date/calendar-picker-appearance-pre-100-expected.txt: Added.
- fast/forms/date/calendar-picker-appearance-pre-100.html: Added.
- 7:27 PM EFLWebKit edited by
- (diff)
- 7:06 PM Changeset in webkit [125961] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix random noise around text in FPS HUD.
https://bugs.webkit.org/show_bug.cgi?id=94400
Reviewed by James Robinson.
This was the result of an incorrect clear operation on the canvas
that stores the font atlas used by the HUD.
- platform/graphics/chromium/CompositorHUDFontAtlas.cpp:
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):
- 7:00 PM Changeset in webkit [125960] by
-
- 27 edits in trunk
Unreviewed, rolling out r125897.
http://trac.webkit.org/changeset/125897
https://bugs.webkit.org/show_bug.cgi?id=94326
Source/WebCore:
This patch seems to have broken the inspector on the apple mac bots.
- WebCore.gypi:
- inspector/compile-front-end.py:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries.loadLibrary):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries):
- inspector/front-end/Color.js:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get outputColorFormat):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
Source/WebKit/chromium:
this patch seems to have broken the inspector on the apple mac bots.
- WebKit.gyp:
- scripts/concatenate_js_files.py:
(OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py:
(main):
LayoutTests:
This patch seems to have broken the inspector on the apple mac bots.
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/styles/styles-invalid-color-values.html:
- inspector/timeline-dfs.html:
- 5:48 PM Changeset in webkit [125959] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG is still too pessimistic about what constitutes a side-effect on array accesses
https://bugs.webkit.org/show_bug.cgi?id=94309
Reviewed by Geoffrey Garen.
This change means that even if structure transition watchpoints are not used for
hoisting of clobbered structure checks, we still retain good performance on the
benchmarks we care about. That's important, since butterflies will likely make
most array structures not watchpointable.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 5:43 PM Changeset in webkit [125958] by
-
- 5 edits in trunk
Add ability to create AtomicString using LChar* buffer and length
https://bugs.webkit.org/show_bug.cgi?id=94381
Reviewed by Geoffrey Garen.
Allows the use of 8 bit string data directly without converting to 16 bits first.
- wtf/text/AtomicString.cpp:
(WTF::LCharBufferTranslator::hash):
(LCharBufferTranslator):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::AtomicString::add):
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(AtomicString):
- wtf/text/StringImpl.h:
(StringImpl):
- 5:42 PM Changeset in webkit [125957] by
-
- 4 edits in trunk/Source/WebCore
AudioParam must support k-rate processing with audio-rate connections
https://bugs.webkit.org/show_bug.cgi?id=94385
Reviewed by Kenneth Russell.
Fully implement AudioParam *final* value calculation according to spec:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioParam
In particular, this covers the case where the parameter is k-rate, and we also
have audio-rate connections to the AudioParam.
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::finalValue):
(WebCore):
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateFinalValues):
- Modules/webaudio/AudioParam.h:
(AudioParam):
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
- 5:36 PM Changeset in webkit [125956] by
-
- 3 edits in trunk/Tools
Perfalizer should differentiate results with and without the patch
https://bugs.webkit.org/show_bug.cgi?id=94399
Reviewed by Dirk Pranke.
Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
the results page are labled accordingly.
Also use _build_without_patch when building without a patch so that we get the right error message.
- Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.run):
(PerfalizerTask._run_perf_test):
- Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
(PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
- 5:31 PM Changeset in webkit [125955] by
-
- 4 edits2 adds in trunk
Preserve styling elements in DeleteSelectionCommand
<rdar://problem/12040676>
https://bugs.webkit.org/show_bug.cgi?id=93643
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Styling elements (<link> and <style>) can appear inside editable content. To
prevent accidental deletion, we move styling elements to rootEditableElement in
DeleteSelectionCommand undoably.
Test: editing/execCommand/delete-selection-has-style.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss): Added to preserve styling elements during the command
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Modified to preserve styling elements during the command
- editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):
LayoutTests:
Test if delete selection command does move styling elements to
rootEditableElement, when the selection contains some. Also test command's
undoness.
- editing/execCommand/delete-selection-has-style-expected.txt: Added.
- editing/execCommand/delete-selection-has-style.html: Added.
- 5:25 PM Changeset in webkit [125954] by
-
- 2 edits in trunk/Tools
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
https://bugs.webkit.org/show_bug.cgi?id=94396
Reviewed by Ryosuke Niwa.
It appears that WTR is generating PNGs that ImageDiff doesn't
like, and so we're getting lots of "can not get ImageDiff"
errors (see bug 81962). The change in r124581 made this a test
failure, and this is causing the WK2 bots to frequently abort
with 500+ failures.
This change makes ImageDiff errors not be test failures just for
WK2 for now until we can better triage what's going on.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
- 5:10 PM Changeset in webkit [125953] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r125940.
http://trac.webkit.org/changeset/125940
https://bugs.webkit.org/show_bug.cgi?id=94398
"Causes crashes on the bots
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r125944%20(2626)/fast/css
/first-letter-removed-added-crash-log.txt" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
- rendering/RenderListItem.cpp:
- rendering/RenderListItem.h:
(RenderListItem):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
- rendering/RenderQuote.cpp:
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
(RenderRegion):
- 5:08 PM Changeset in webkit [125952] by
-
- 3 edits in trunk/Tools
[chromium] Add a style check for #include "cc/..." in chromium files
https://bugs.webkit.org/show_bug.cgi?id=94382
Patch by James Robinson <jamesr@chromium.org> on 2012-08-17
Reviewed by Adam Barth.
Adds a style check to make sure new chromium code follows the correct convention for including cc files.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_cc_includes):
- 5:06 PM Changeset in webkit [125951] by
-
- 3 edits2 adds in trunk
Disconnect UndoManager when its undo scope host is destroyed
https://bugs.webkit.org/show_bug.cgi?id=94388
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Disconnect UndoManager in Element's destructor to prevent
use-after-free vulnerabilities.
Test: editing/undomanager/undoscopehost-use-after-free.html
- dom/Element.cpp:
(WebCore::Element::~Element):
LayoutTests:
- editing/undomanager/undoscopehost-use-after-free-expected.txt: Added.
- editing/undomanager/undoscopehost-use-after-free.html: Added.
- 4:57 PM Changeset in webkit [125950] by
-
- 2 edits in trunk/Source/WebCore
Fixed incorrect references to JSVoidCallback.{cpp,h} in the project file.
- WebCore.xcodeproj/project.pbxproj:
- 4:51 PM Changeset in webkit [125949] by
-
- 2 edits in trunk/Source/WebCore
Fix XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 4:36 PM Changeset in webkit [125948] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry][EFL] Remove compile warning in WebCore
https://bugs.webkit.org/show_bug.cgi?id=94328
Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Rob Buis.
Fixed compile time warning in WebCore.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti
- 4:35 PM Changeset in webkit [125947] by
-
- 2 edits in trunk/Source/WebCore
[V8] use checkInboundData in setWebGLArrayHelper
https://bugs.webkit.org/show_bug.cgi?id=93051
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-17
Reviewed by Kenneth Russell.
Use TypedArray method checkInboundData in setWebGLArrayHelper instead
of performing the computation manually.
No new tests. This patch doesn't change behavior.
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::setWebGLArrayHelper):
- 4:27 PM Changeset in webkit [125946] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r125912): Crashes in worker tests
https://bugs.webkit.org/show_bug.cgi?id=94390
Reviewed by Brady Eidson and Sam Weinig.
- bindings/js/JSDOMBinding.cpp: (WebCore::reportException): It's always fine to report an exception on a worker context, but it's not fine to treat those as windows.
- 4:14 PM Changeset in webkit [125945] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Add missing header files to .gypi and missing include to CCTiledLayerImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=94391
Reviewed by Adrienne Walker.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- 4:11 PM Changeset in webkit [125944] by
-
- 2 edits in trunk/Source/WebKit2
Adding back the first statement of WebProcessMain accidentally
removed in r125358.
Reviewed by Sam Weinig.
- WebProcess/mac/WebProcessMainMac.mm: Adding back the stripping
of DYLD_INSERT_LIBRARIES.
- 4:11 PM Changeset in webkit [125943] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
https://bugs.webkit.org/show_bug.cgi?id=94269
Reviewed by Ojan Vafai.
I don't see a path through which this code is exercised.
ASSERT_NOT_REACHED doesn't cause any of our tests to fail. It might be
timing-related, in which case this ASSERT should be sporadically hit.
If this ASSERT is hit, see if we can write a test that exercises it or
at least add comments explaining how it gets exercised. If this ASSERT
is not hit after a while, change it to
ASSERT(transaction.scheduleTask(...)).
No new tests, we're looking for existing tests to fail.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- 4:07 PM Changeset in webkit [125942] by
-
- 20 edits in trunk
Unreviewed, rolling out r125922.
http://trac.webkit.org/changeset/125922
https://bugs.webkit.org/show_bug.cgi?id=94389
"Causing failing/crashing tests on Mac bots" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- WebCore.gypi:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.showProfileForURL):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._toggleSearchingForNode):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.frontendReused):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-summary-show-ranges.html:
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
- 3:04 PM Changeset in webkit [125941] by
-
- 2 edits in branches/chromium/1229/Source
Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829399
- 2:59 PM Changeset in webkit [125940] by
-
- 11 edits in trunk/Source/WebCore
Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271
Reviewed by Abhishek Arya.
Following bug 93874, we have an insertion notification. This change adds the
matching removal notification (willBeRemovedFromTree).
Refactoring covered by existing tests.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the code from here and moved it below.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- rendering/RenderObject.h:
This is the base function that should be called by every instance.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeRemovedFromTree):
- rendering/RenderListItem.h:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::willBeRemovedFromTree):
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::willBeRemovedFromTree):
- rendering/RenderRegion.h:
Overriden functions.
- 2:50 PM Changeset in webkit [125939] by
-
- 3 edits in trunk/Source
Fix vsyncTick drought when vsync throttling is disabled
https://bugs.webkit.org/show_bug.cgi?id=94012
Patch by Brian Anderson <brianderson@chromium.org> on 2012-08-17
Reviewed by James Robinson.
CCFrameRateController made an assumption that every vsyncTick results
in a call to didBeginFrame, which is not necessarily true and causes
the CCFrameRateController to stop ticking when vsync is disabled. We
move the manual ticks out of didBeginFrame and manually tick in the
proper place.
CCFrameRateControllerTest updated with use cases that should tick
without a didBeginFrame and will fail without this patch.
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
- 2:46 PM Changeset in webkit [125938] by
-
- 2 edits in trunk/Source/WebCore
Delete some dead code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=94262
Reviewed by Tony Chang.
I'm pretty sure this is dead code. None of the layout tests hit this code,
including the ones added in the original patch http://trac.webkit.org/changeset/10983.
I spent a good while and could not concoct a test that hits this code.
The test-cases added in that file, as well as the test-cases I came up with that should
go through this codepath, instead go through computePositionedLogicalHeight and never
hit computePercentageLogicalHeight.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
- 2:38 PM Changeset in webkit [125937] by
-
- 2 edits in trunk/LayoutTests
2012-08-17 Nate Chapin <Nate Chapin>
Add missing CR in bug identifiers in TextExpectations
- platform/chromium/TestExpectations:
- 2:36 PM Changeset in webkit [125936] by
-
- 4 edits in trunk/Source
Make it easier to append a literal to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=94273
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-17
Reviewed by Kentaro Hara.
Source/WebCore:
Use StringBuilder::appendLiteral() in MarkupAccumulator instead of computing every
value individually.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendXMLDeclaration):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendCDATASection):
Source/WTF:
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::appendLiteral): Add the method StringBuilder::appendLiteral() for efficiently
adding a string literal to the StringBuilder.
- 2:29 PM Changeset in webkit [125935] by
-
- 2 edits in trunk/LayoutTests
2012-08-17 Nate Chapin <Nate Chapin>
Update BUGJAPHET TextExpectations entries to point to bugs.
- platform/chromium/TestExpectations:
- 2:24 PM Changeset in webkit [125934] by
-
- 9 edits in trunk/Source/WebCore
Share the StringImpl the CSS property names
https://bugs.webkit.org/show_bug.cgi?id=94187
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-17
Reviewed by Alexey Proskuryakov.
Previously, we would instanciate a new String every time a CSS property name was needed.
This patches moves the creation of the AtomicString to CSSPropertyNames and reuse that
StringImpl whenever needed.
With the patch, accessing CSS property names from JavaScript gets about 2.1 times faster.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::item):
- css/CSSPrimitiveValue.cpp:
(WebCore::valueOrPropertyName):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::cssName):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
- css/makeprop.pl:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent):
- 2:16 PM Changeset in webkit [125933] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Allow in-region accelerated scrolling take advantage of defer_blits
https://bugs.webkit.org/show_bug.cgi?id=94379
PR #194595
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jakob Petsovits.
Client does the blitting now.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- 1:58 PM Changeset in webkit [125932] by
-
- 195 edits in trunk/Source
[chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes
https://bugs.webkit.org/show_bug.cgi?id=94279
Reviewed by Adam Barth.
Source/WebCore:
This brings us more in line with the rest of the WebKit repo and avoids potential header collisions during
transition.
- WebCore.gyp/WebCore.gyp:
- platform/chromium/support/CCThreadImpl.cpp:
- platform/chromium/support/CCThreadImpl.h:
- platform/chromium/support/WebCompositorImpl.cpp:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
- platform/graphics/chromium/IOSurfaceLayerChromium.cpp:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LinkHighlight.cpp:
- platform/graphics/chromium/RateLimiter.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
- platform/graphics/chromium/SolidColorLayerChromium.cpp:
- platform/graphics/chromium/TextureLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TreeSynchronizer.cpp:
- platform/graphics/chromium/VideoLayerChromium.cpp:
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
- platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
- platform/graphics/chromium/cc/CCAnimationCurve.cpp:
- platform/graphics/chromium/cc/CCAnimationEvents.h:
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp:
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
- platform/graphics/chromium/cc/CCDrawQuad.h:
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerIterator.cpp:
- platform/graphics/chromium/cc/CCLayerIterator.h:
- platform/graphics/chromium/cc/CCLayerQuad.cpp:
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
- platform/graphics/chromium/cc/CCLayerSorter.h:
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCMathUtil.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
- platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:
- platform/graphics/chromium/cc/CCPrioritizedTexture.h:
- platform/graphics/chromium/cc/CCProxy.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.cpp:
- platform/graphics/chromium/cc/CCRenderPass.h:
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
- platform/graphics/chromium/cc/CCRenderer.h:
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
- platform/graphics/chromium/cc/CCResourceProvider.h:
- platform/graphics/chromium/cc/CCScheduler.cpp:
- platform/graphics/chromium/cc/CCScheduler.h:
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
- platform/graphics/chromium/cc/CCScopedTexture.cpp:
- platform/graphics/chromium/cc/CCScopedTexture.h:
- platform/graphics/chromium/cc/CCScopedThreadProxy.h:
- platform/graphics/chromium/cc/CCScrollbarAnimationController.cpp:
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.cpp:
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.h:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- platform/graphics/chromium/cc/CCSettings.cpp:
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp:
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:
- platform/graphics/chromium/cc/CCTexture.cpp:
- platform/graphics/chromium/cc/CCTexture.h:
- platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:
- platform/graphics/chromium/cc/CCTextureDrawQuad.h:
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.h:
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
- platform/graphics/chromium/cc/CCTextureUpdateController.h:
- platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadTask.h:
- platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
- platform/graphics/chromium/cc/CCTileDrawQuad.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- platform/graphics/chromium/cc/CCTimer.cpp:
- platform/graphics/chromium/cc/CCTimingFunction.cpp:
- platform/graphics/chromium/cc/CCTimingFunction.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
Source/WebKit/chromium:
- src/WebAnimationCurveCommon.cpp:
- src/WebAnimationImpl.cpp:
- src/WebCompositorInputHandlerImpl.cpp:
- src/WebCompositorInputHandlerImpl.h:
- src/WebExternalTextureLayer.cpp:
- src/WebFloatAnimationCurve.cpp:
- src/WebLayerTreeView.cpp:
- src/WebLayerTreeViewImpl.cpp:
- src/WebTransformAnimationCurve.cpp:
- tests/CCActiveAnimationTest.cpp:
- tests/CCAnimationTestCommon.cpp:
- tests/CCAnimationTestCommon.h:
- tests/CCDamageTrackerTest.cpp:
- tests/CCDelayBasedTimeSourceTest.cpp:
- tests/CCFrameRateControllerTest.cpp:
- tests/CCKeyframedAnimationCurveTest.cpp:
- tests/CCLayerAnimationControllerTest.cpp:
- tests/CCLayerImplTest.cpp:
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerQuadTest.cpp:
- tests/CCLayerSorterTest.cpp:
- tests/CCLayerTestCommon.cpp:
- tests/CCLayerTestCommon.h:
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCMathUtilTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
- tests/CCOcclusionTrackerTestCommon.h:
- tests/CCPrioritizedTextureTest.cpp:
- tests/CCQuadCullerTest.cpp:
- tests/CCRenderSurfaceFiltersTest.cpp:
- tests/CCRenderSurfaceTest.cpp:
- tests/CCResourceProviderTest.cpp:
- tests/CCSchedulerStateMachineTest.cpp:
- tests/CCSchedulerTest.cpp:
- tests/CCSchedulerTestCommon.h:
- tests/CCScopedTextureTest.cpp:
- tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:
- tests/CCSolidColorLayerImplTest.cpp:
- tests/CCTestCommon.h:
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadTaskTest.cpp:
- tests/CCThreadedTest.cpp:
- tests/CCThreadedTest.h:
- tests/CCTiledLayerImplTest.cpp:
- tests/CCTiledLayerTestCommon.h:
- tests/CCTimerTest.cpp:
- tests/ContentLayerChromiumTest.cpp:
- tests/FakeCCGraphicsContext.h:
- tests/FakeCCLayerTreeHostClient.h:
- tests/FloatQuadTest.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
- tests/MockCCQuadCuller.h:
- tests/PlatformGestureCurveTest.cpp:
- tests/ScrollbarLayerChromiumTest.cpp:
- tests/TextureLayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- tests/TreeSynchronizerTest.cpp:
- tests/WebCompositorInputHandlerImplTest.cpp:
- tests/WebFloatAnimationCurveTest.cpp:
- tests/WebTransformAnimationCurveTest.cpp:
- 1:55 PM Changeset in webkit [125931] by
-
- 2 edits in trunk/Tools
Delete some dead code from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94380
Reviewed by Dirk Pranke.
This code became dead in one of the refactors of how we handle BuilderGroups.
There's no bug here, it's just dead code.
- TestResultServer/static-dashboards/builders.js:
(requestBuilderList):
(loadBuildersList):
- 1:43 PM Changeset in webkit [125930] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] REGRESSION(r125923): Breaks EFL build
https://bugs.webkit.org/show_bug.cgi?id=94376
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Alexey Proskuryakov.
Fix EFL build break after r125923.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveIntentForFrame):
- 1:42 PM Changeset in webkit [125929] by
-
- 2 edits in trunk/Source/WebCore
Delete dead code in deprecated flexbox for RTL line-clamp
https://bugs.webkit.org/show_bug.cgi?id=94282
Reviewed by Tony Chang.
-webkit-line-clamp and direction:rtl is not supported. Delete some
obviously dead code that half-tries to support it.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- 1:22 PM Changeset in webkit [125928] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for inspector/timeline/timeline-decode-resize.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94375
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-17
Reviewed by Brady Eidson.
Mark inspector/timeline/timeline-decode-resize.html as an expected
failure on mac until https://bugs.webkit.org/show_bug.cgi?id=94374
is resolved.
- platform/mac/TestExpectations:
- 1:10 PM Changeset in webkit [125927] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Refactor InspectorTest to split evals for initialization from runTest
https://bugs.webkit.org/show_bug.cgi?id=93520
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
Split function runTestInFrontend() into initialization and runTestInFrontEnd parts;
send them to the front-end in two different evaluateInFrontEnd calls, resulting in
two different eval() calls. In debug setup, we'll get two different UISourceCodes,
much easier to debug with.
Refactoring, all inspector tests pass.
- http/tests/inspector/inspector-test.js:
- 12:57 PM Changeset in webkit [125926] by
-
- 3 edits in trunk/Tools
[chromium] Add content shell bots to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94369
Reviewed by Ojan Vafai.
The bots are named $OS (Content Shell).
- TestResultServer/static-dashboards/builders.js:
(isChromiumWebkitTipOfTreeTestRunner):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 12:17 PM Changeset in webkit [125925] by
-
- 18 edits4 copies6 adds in trunk
Text Autosizing: Increase line height in proportion to font size.
https://bugs.webkit.org/show_bug.cgi?id=91660
Patch by John Mellor <johnme@chromium.org> on 2012-08-17
Reviewed by Julien Chaffraix.
Source/WebCore:
This patch causes line heights to be increased in proportion to font
size (so autosized text doesn't overlap itself). It does this by adding
a textAutosizingMultiplier() to RenderStyle, which the lineHeight()
getter multiplies its response by.
It also cleans up one or two things, for example treatAsInline is
renamed isNotAnAutosizingContainer to clarify that its purpose is to
discriminate autosizing containers (the smallest unit that we can turn
Text Autosizing on or off for; in particular these are not allowed to
be line participants, since multiple sizes on one line looks awful).
Tests: fast/text-autosizing/em-margin-border-padding.html
fast/text-autosizing/narrow-child.html
fast/text-autosizing/nested-em-line-height.html
fast/text-autosizing/simple-paragraph.html
fast/text-autosizing/span-child.html
fast/text-autosizing/wide-child.html
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue):
Replaced Length(-100.0, Percent) with RenderStyle::initialLineHeight(),
which is equivalent but makes the intent clearer.
(WebCore::ApplyPropertyLineHeight::createHandler):
Use specifiedLineHeight to match setLineHeight which takes a specified
line height (and generally this avoids accidentally inheriting text
autosizing).
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Similarly use specifiedLineHeight when inheriting line height.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::ensurePropertyMap):
Get and set specified lineHeight/fontSize if Text Autosizing is
enabled to avoid setting the specified value to the computed value
(causing values to be multiplied more than once!).
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
Adjust for renamed setBlendedFontSize, and maintain cast to int.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
Replaced Length(-100.0, Percent) with RenderStyle::initialLineHeight(),
which is equivalent but makes the intent clearer.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Use nextInPreOrderMatchingFilter instead of traverseNext, and some
other methods that got renamed.
(WebCore::TextAutosizer::processBox):
Renamed from processBlock, since RenderBoxes are sufficient; use
renamed nextInPreOrderMatchingFilter; make two calls to setMultiplier
(one for parent for line height) instead of processText.
(WebCore::TextAutosizer::setMultiplier):
Simplified from previous processText method; this just sets the
style's textAutosizingMultiplier (and the style does the rest).
(WebCore::TextAutosizer::isNotAnAutosizingContainer):
Renamed from treatAsInline; added explanatory comment; changed
isRenderBlock to isBox as boxes still have logicalWidth; changed
isInlineBlockOrInlineTable to isInline as it was an omission that
other inlines were allowed.
(WebCore::TextAutosizer::nextInPreOrderMatchingFilter):
Renamed from TextAutosizer::traverseNext.
(RenderObjectFilterFunctor):
Renamed from RenderObjectFilter to clafiry that it's a function ptr.
- rendering/TextAutosizer.h:
(TextAutosizer): Previously mentioned renamings.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
Adjust for renamed setBlendedFontSize.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
textAutosizingMultiplier is a StyleDifferenceLayout (we want
setNeedsLayoutAndPrefWidthsRecalc to get called).
(WebCore::RenderStyle::setFontSize):
Renamed from setBlendedFontSize; if Text Autosizing is enabled and a
multiplier is set it auto-calculates the computedSize; float
param instead of int as discussed on webkit.org/b/91660.
- rendering/style/RenderStyle.h:
Added specifiedFontSize, computedFontSize and specifiedLineHeight
getters; changed lineHeight to dynamically calculate autosized line
height, and made computedLineHeight use this value instead of the
specified line height; also added textAutosizingMultiplier
getter/setter (the setter updated the font description's computed
size, by calling setFontSize); also renamed the parameter to
setLineHeight to explicitly note that it's setting the
specifiedLineHeight (and can still be adjusted by autosizing).
- rendering/style/StyleVisualData.cpp/.h:
Added m_textAutosizingMultiplier (this seems the best place to put a
non-inherited non-rare presentational property).
LayoutTests:
Adjusted the expectation for simple-paragraph.html and
font-scale-factor.html now that line-height is correctly increased.
Also added 5 more tests making sure that autosized children of
non-autosized parents work correctly, and vice versa; that nested
inline elements behave correctly; and documenting the behavior of
margins, borders, and padding with em lengths.
- fast/text-autosizing/em-margin-border-padding-expected.html: Added.
- fast/text-autosizing/em-margin-border-padding.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/font-scale-factor-expected.html:
- fast/text-autosizing/font-scale-factor.html:
- fast/text-autosizing/narrow-child-expected.html: Added.
- fast/text-autosizing/narrow-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/nested-em-line-height-expected.html: Added.
- fast/text-autosizing/nested-em-line-height.html: Added.
- fast/text-autosizing/simple-paragraph-expected.html:
- fast/text-autosizing/simple-paragraph.html:
- fast/text-autosizing/span-child-expected.html: Added.
- fast/text-autosizing/span-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/wide-child-expected.html: Added.
- fast/text-autosizing/wide-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- 12:12 PM Changeset in webkit [125924] by
-
- 4 edits1 add in trunk
[CMake] Add FindDBus.cmake and use it in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=94319
Reviewed by Daniel Bates.
.:
Currently, the Battery Status-related code in the EFL port uses
libdbus but does not directly include its directories or link
against it, relying instead on the compiler flags coming via
EDbus's pkg-config information.
That will break once we stop obtaining EFL's include directories
and library paths from pkg-config, so write FindDBus.cmake to
prepare for that.
- Source/cmake/FindDBus.cmake: Added.
- Source/cmake/OptionsEfl.cmake: Look for D-Bus if BATTERY_STATUS
support is enabled.
Source/WebCore:
- PlatformEfl.cmake: Link against DBUS_LIBRARIES and add
DBUS_INCLUDE_DIRS to the include path list if BATTERY_STATUS
support is enabled.
- 12:01 PM Changeset in webkit [125923] by
-
- 2 edits in trunk/Source/WebKit2
Access m_process directly in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=94363
Reviewed by John Sullivan.
Consistency fix - we don't use accessors when we don't have to, and there is a mix in this file.
- UIProcess/WebPageProxy.cpp:
- 11:57 AM Changeset in webkit [125922] by
-
- 19 edits in trunk
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
Source/WebCore:
Moving files from .html to importScript.
- WebCore.gypi:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.showProfileForURL):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._toggleSearchingForNode):
(WebInspector._profilesLinkifier):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
Source/WebKit/chromium:
- WebKit.gyp:
- 11:45 AM Changeset in webkit [125921] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing expectations for two flaky crashers that were fixed in r125181.
Skipping three tests of otherwise unsupported features as they time out
and just prolong the bot cycle in doing so.
- platform/gtk/TestExpectations:
- 11:42 AM Changeset in webkit [125920] by
-
- 4 edits in trunk
REGRESSION(r125710) - canvas-fallback-content tests asserting in Chromium
https://bugs.webkit.org/show_bug.cgi?id=94156
Reviewed by Chris Fleizach.
Source/WebCore:
When determining if a Node is focusable, check the canvas subtree
case first before encountering assertions that assume that anything
focusable must have an associated renderer.
Fixes existing tests so they don't assert.
- dom/Node.cpp:
(WebCore::Node::isFocusable):
LayoutTests:
Fixes two canvas tests that were asserting.
- platform/chromium/TestExpectations:
- 11:39 AM Changeset in webkit [125919] by
-
- 20 edits7 adds8 deletes in trunk/LayoutTests
Unreviewed gardening. Updating test expectations after r125794.
- fast/repaint/transform-absolute-child-expected.txt: Added.
- fast/repaint/transform-repaint-descendants-expected.txt: Added.
- platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-linux/fast/repaint/transform-absolute-child-expected.png:
- platform/chromium-linux/fast/repaint/transform-repaint-descendants-expected.png:
- platform/chromium-linux/fast/repaint/transform-translate-expected.png:
- platform/chromium-linux/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
- platform/chromium-linux/media/audio-repaint-expected.png:
- platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png:
- platform/chromium-linux/transforms/svg-vs-css-expected.png:
- platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
- platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
- platform/chromium-win/fast/repaint/transform-absolute-child-expected.png:
- platform/chromium-win/fast/repaint/transform-repaint-descendants-expected.png:
- platform/chromium-win/fast/repaint/transform-translate-expected.png:
- platform/chromium-win/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
- platform/chromium-win/transforms/svg-vs-css-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/sub-pixel: Added.
- platform/chromium/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
- platform/efl/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/efl/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
- platform/mac/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed.
- 11:33 AM Changeset in webkit [125918] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark indexeddb/resources-panel as also timing out
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:31 AM Changeset in webkit [125917] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth : int WebCore::AutoTableLayout::calcEffectiveLogicalWidth()
https://bugs.webkit.org/show_bug.cgi?id=92471
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-17
Reviewed by Julien Chaffraix.
Source/WebCore:
The assert occurs due to the float based computations causing a floating
point rounding error between allocatedMaxLogicalWidth and cellMaxLogicalWidth.
Test: fast/table/assert-autotablelayout-maxlogicalwidth.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
Converting float based calculations for computing max logical width to int based;
similar to the calculations for min logical width.
LayoutTests:
- fast/table/assert-autotablelayout-maxlogicalwidth-expected.txt: Added.
- fast/table/assert-autotablelayout-maxlogicalwidth.html: Added.
Added a testcase for verifying that the assert in AutoTableLayout::calcEffectiveLogicalWidth()
for allocatedMaxLogicalWidth coming greater than cellMaxLogicalWidth, does not occur.
- 11:27 AM Changeset in webkit [125916] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add @ sourceURL to test-runner evals
https://bugs.webkit.org/show_bug.cgi?id=94268
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
Postpend a line that tells the debugger what to call this eval buffer.
Name ends in the sequennce number so all evals will appear together.
evaluateInWebInspector0.js eg
- inspector/front-end/TestController.js:
(WebInspector.evaluateForTestInFrontend):
- 11:23 AM Changeset in webkit [125915] by
-
- 2 edits in trunk/Tools
Add AV perf layout tests to webkit flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94255
Patch by Shadi Khalek <shadi@chromium.org> on 2012-08-17
Reviewed by Ojan Vafai.
Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
The isChromiumDepsAVTestRunner() filter does not work on current builder names.
It assumes the new names they are getting renamed to (AV Linux, AV Win7).
- TestResultServer/static-dashboards/builders.js:
(isChromiumTipOfTreeAVTestRunner):
(loadBuildersList):
- 11:11 AM Changeset in webkit [125914] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark context-menu.html as failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94367
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:01 AM Changeset in webkit [125913] by
-
- 269 edits7 copies3 adds20 deletes in trunk/LayoutTests
[chromium] Rebaseline Chromium mac images after r125830
Unreviewed gardening. Expectation update.
All changes looked like text fields changed imperceptibly and
checkboxes with text fields moved up to match the expected
non-Chromium versions.
- platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-snowleopard/fast/block/basic/011-expected.png:
- platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
- platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
- platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/indeterminate-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-snowleopard/fast/inline/positionedLifetime-expected.png:
- platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/bad-xml-slash-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-snowleopard/fast/table/003-expected.png:
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
- platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-mac/css1/box_properties/acid_test-expected.png:
- platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/basic/011-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/001-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/formmove-expected.png:
- platform/chromium-mac/fast/forms/formmove2-expected.png:
- platform/chromium-mac/fast/forms/indeterminate-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/inline/positionedLifetime-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/parser/bad-xml-slash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Removed.
- platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Removed.
- platform/chromium-win-xp/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Removed.
- platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Removed.
- platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Removed.
- platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Removed.
- platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
- platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- 10:45 AM Changeset in webkit [125912] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r125592): Crash in Console::addMessage, under InjectedBundle::reportException
https://bugs.webkit.org/show_bug.cgi?id=94220
Reviewed by Alexey Proskuryakov.
Previously, this code was trying to detect whether a DOMWindow is
currently displayed in a Frame by testing whether
DOMWindow->scriptExecutionContext is zero. That used to work, but now
that DOMWindow->scriptExecutionContext is non-zero for detached
DOMWindow, this code doesn't work anymore. This patch replaces the code
with the current idiom, which is to call
DOMWindow::isCurrentDisplayedInFrame.
Alexey and I couldn't figure out how to test this change. This bug
causes a crash when some Safari extensions are installed, but it's not
clear whether this bug can be triggered from the web platform. We're
going to ask Jessie for ideas when she gets back from vacation.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- 10:41 AM Changeset in webkit [125911] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Narrowing the failure expectation for http/tests/xmlhttprequest/origin-exact-matching.html.
The test now constantly fails only on release builds.
Adding a new baseline for a subpixel test that's required after r125794.
- platform/gtk/TestExpectations:
- platform/gtk/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
- 9:46 AM Changeset in webkit [125910] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add WK2 API to get suggested filename for URI responses
https://bugs.webkit.org/show_bug.cgi?id=92967
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-08-17
Reviewed by Carlos Garcia Campos.
Webcore has API to get the suggested filename for a response, add
a property and getter for it in WebKitURIResponse.
- UIProcess/API/gtk/WebKitURIResponse.cpp:
(_WebKitURIResponsePrivate): Add a CString holding the value.
(webkitURIResponseGetProperty): Add the gobject bits for the
property.
(webkit_uri_response_class_init): Install the property.
(webkit_uri_response_get_suggested_filename): New getter.
- UIProcess/API/gtk/WebKitURIResponse.h: Declare the public
method.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
symbols.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSuggestedFilename): Test the new API.
(serverCallback): Add the the content-disposition header
in one case, in order to test it.
(beforeAll): Add the new test.
- 9:09 AM Changeset in webkit [125909] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Turn off ENABLE_DATALIST_ELEMENT for Android
https://bugs.webkit.org/show_bug.cgi?id=94337
Reviewed by Kent Tamura.
We shouldn't have turned ENABLE_DATALIST_ELEMENT on for Android.
- features.gypi:
- 8:55 AM Changeset in webkit [125908] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] On reload, www.sohu.com renders part white background, part overscroll pattern
https://bugs.webkit.org/show_bug.cgi?id=94348
Reviewed by Yong Li.
Jacky Jiang <zhajiang@rim.com>
PR: 179200
This can fix the reload issues of sohu.com, yahoo.com and
thestar.com/iphone(PR158041). And it is also related with PR178305.
Internally reviewed by George Staikos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState): Keeping scales for
reload was doing more harm than good. Two reasons to remove this:
(1) During reload, contents rect is changing due to layout updates,
it is possible that the contents or the white background can't cover
the whole screen if we are using the previous scales.
(2) Before reload, the source of the web page can be changed, therefore
previous scales won't be valid anymore.
Remove shouldRestoreViewState() as this check here is useless now.
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad): During
reload, we should give it a chance to zoom to fit the screen,
otherwise, it happens that the contents can't cover the whole screen
until we restore the view state, see PR158041.
Remove shouldRestoreViewState() as the error page issue PR178305 can be
covered by reload now.
- WebCoreSupport/FrameLoaderClientBlackBerry.h: Remove unused shouldRestoreViewState().
- 8:46 AM Changeset in webkit [125907] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Removing track-active-cues.html from TextExpectations, passing now.
[Chromium] Updating bug on track-cues-sorted-before-dispatch.html.
Unreviewed gardening.
- platform/chromium/TextExpectations:
- 8:38 AM Changeset in webkit [125906] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r125892.
http://trac.webkit.org/changeset/125892
https://bugs.webkit.org/show_bug.cgi?id=94350
Broke windows build (Requested by vollick on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- 8:37 AM Changeset in webkit [125905] by
-
- 3 edits1 add in trunk/Source/WebKit2
[EFL][wk2] Add unit tests for back-forward list API
https://bugs.webkit.org/show_bug.cgi?id=92617
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
Added unit tests covering the existing EFL WK2 back-forward list API.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/resources/default_test_page.html:
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp: Added.
(serverCallbackNavigation):
(checkItem):
(urlFromTitle):
(TEST_F):
- 8:23 AM Changeset in webkit [125904] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:22 AM Changeset in webkit [125903] by
-
- 4 edits in trunk/Source
Add support for Skia Magnifier filter to Chromium layers
https://bugs.webkit.org/show_bug.cgi?id=93939
Patch by Zach Kuznia <zork@chromium.org> on 2012-08-17
Reviewed by James Robinson.
This is used by Chrome OS for the screen magnifier
Source/Platform:
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createZoomFilter):
(WebKit::WebFilterOperation::WebFilterOperation):
Source/WebCore:
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::optimize):
(WebCore::CCRenderSurfaceFilters::apply):
- 8:17 AM Changeset in webkit [125902] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Turn on a few macros for jpeg decoding and image interpolation
https://bugs.webkit.org/show_bug.cgi?id=94244
Patch by Yong Li <yoli@rim.com> on 2012-08-17
Reviewed by Antonio Gomes.
Turn on these macros to get better performance.
- wtf/Platform.h:
- 8:12 AM Changeset in webkit [125901] by
-
- 4 edits in trunk
[BlackBerry] Remove some shared libraries from linking
https://bugs.webkit.org/show_bug.cgi?id=94253
Reviewed by Yong Li.
Remove some shared libraries.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
- 7:48 AM Changeset in webkit [125900] by
-
- 2 edits in trunk/Source/WebKit2
UserMessageEncoder::baseEncode() should ASSERT when attempting to encode a non-shareable image
https://bugs.webkit.org/show_bug.cgi?id=94245
Reviewed by Alexey Proskuryakov.
It's a programming error if a client attempts to encode an image that has an
allocated bitmap, but isn't shareable, so we should assert in this case.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
Assert if we're trying to encode valid non-shareable image.
- 7:37 AM Changeset in webkit [125899] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=94344
Unreviewed EFL gardening of failing tests and new passes.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:31 AM Changeset in webkit [125898] by
-
- 10 edits4 adds in trunk
Touch adjustment for context menu gestures
https://bugs.webkit.org/show_bug.cgi?id=94101
Reviewed by Antonio Gomes.
Source/WebCore:
Adds a new filter for detecting nodes that provides extra context-menu items,
and use that in a new set of functions for adjusting context-menu gestures.
Tests: touchadjustment/context-menu-select-text.html
touchadjustment/context-menu.html
- page/EventHandler.cpp:
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::adjustGesturePosition):
- page/EventHandler.h:
(EventHandler):
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeProvidesContextMenuItems):
(TouchAdjustment):
(WebCore::findBestContextMenuCandidate):
- page/TouchAdjustment.h:
- testing/Internals.cpp:
(WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
(WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
Two new tests for context-menu touch adjustment.
- touchadjustment/context-menu-expected.txt: Added.
- touchadjustment/context-menu-select-text-expected.txt: Added.
- touchadjustment/context-menu-select-text.html: Added.
- touchadjustment/context-menu.html: Added.
- touchadjustment/resources/touchadjustment.js:
(nodeToString):
(testTouchPoint):
(testTouchPointContextMenu):
(adjustTouchPointContextMenu):
- 7:28 AM Changeset in webkit [125897] by
-
- 27 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Loading code on demand (upon the panel access).
- WebCore.gypi:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
Source/WebKit/chromium: Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- WebKit.gyp:
- scripts/concatenate_js_files.py:
(OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py:
(main):
LayoutTests: Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Loading code on demand (upon the panel access);
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/timeline-dfs.html:
- 7:23 AM Changeset in webkit [125896] by
-
- 10 edits in trunk
Unreviewed, rolling out r125880.
http://trac.webkit.org/changeset/125880
https://bugs.webkit.org/show_bug.cgi?id=94347
Breaks front-end compilation: SourceFrame passed where View is
expected. (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
- inspector/front-end/TextEditor.js:
- inspector/front-end/scriptsPanel.css:
(.script-view):
(.script-view.visible):
LayoutTests:
- inspector/debugger/reveal-execution-line.html:
- inspector/debugger/source-frame-count.html:
- 7:16 AM Changeset in webkit [125895] by
-
- 7 edits in trunk/Source
[Qt] QNX build fails due to ctype usage in system headers
https://bugs.webkit.org/show_bug.cgi?id=93849
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Simon Hausmann.
Move the check for whether DisallowCType should be active or not
to the DisallowCType.h header. This way, we can update the list
of platforms or OSes which do not work with this header in a
central place. All users can now safely include the header
and do not need to place custom guards around it.
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- config.h:
Source/WTF:
- config.h:
- wtf/DisallowCType.h:
- 7:11 AM Changeset in webkit [125894] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial build fix: Correct file name in bindings/js/DOMTransaction.h used in HEADERS
- Target.pri:
- 7:04 AM Changeset in webkit [125893] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Add unit tests for vibration_client_callbacks_set API
https://bugs.webkit.org/show_bug.cgi?id=93890
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
This patch covers unit testing of the Vibration API as delivered.
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(VibrationCbData):
(vibrateCallback):
(cancelVibrationCallback):
(loadVibrationHTMLString):
(TEST_F):
- 6:48 AM Changeset in webkit [125892] by
-
- 6 edits in trunk/Source
[chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210
Reviewed by James Robinson.
This patch issues the trace events from the animations. Animations will
report when they start and finish on the main and impl threads (via
TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they
change state.
Source/WebCore:
No new tests, only changes tracing behavior.
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::clone):
(WebCore):
(WebCore::CCActiveAnimation::cloneAndInitialize):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore::CCActiveAnimation::isControllingInstance):
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- 6:40 AM EFLWebKit edited by
- update-efl info (diff)
- 6:23 AM Changeset in webkit [125891] by
-
- 2 edits in trunk/Tools
[Qt] QtWebKit fails to build with OpenGL support on QNX
https://bugs.webkit.org/show_bug.cgi?id=93278
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Noam Rosenthal.
Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
contains opengl. Furthermore, we disable this feature on win32-* as usual,
but now also disable it on QNX.
Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
- qmake/mkspecs/features/features.prf:
- 6:11 AM Changeset in webkit [125890] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Rename WebKitWebView print-requested signal to print
https://bugs.webkit.org/show_bug.cgi?id=94306
Reviewed by Martin Robinson.
WebKitWebView::print-requested is inconsistent with the rest of
the API. It's a true_handled signal that allows users to implement
their own print dialog, or block printing, or rely on
defaults. The signal should be WebKitWebView::print like other
signals (create, close, decide_policy, etc.)
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewPrintFrame):
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass):
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(webViewPrintCallback):
(testWebViewPrint):
(beforeAll):
- 6:00 AM Changeset in webkit [125889] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: enhance external test-runner and add cleanup code
https://bugs.webkit.org/show_bug.cgi?id=94231
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
add 'click on test result to select for next run' feature.
remember the users size for the inspector popup.
refactor server URLs to one location at top of file.
use the same value for both tests and scanner servers.
remove one extra instruction on the page.
refactor clean up code.
close the two popup windows if the test-runner.html is reloaded.
- inspector/front-end/test-runner.html:
- 5:33 AM Changeset in webkit [125888] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()
https://bugs.webkit.org/show_bug.cgi?id=94312
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
eina_strbuf_string_free() frees the contents of a string buffer but not the
buffer, so eina_strbuf_free() must be used to free the buffer.
Contents of the buffer has already been take care by stealing it with
eina_strbuf_string_steal(), so no reason to call eina_strbuf_string_free().
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):
- 5:30 AM Changeset in webkit [125887] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial follow-up fix to r125873: Add missing adoptRef to avoid leaks.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::WeakMap::set):
- 5:25 AM Changeset in webkit [125886] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from DateInputType::m_pickerElement
https://bugs.webkit.org/show_bug.cgi?id=94330
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is describe in bug 94324.
DateInputType::m_pickerElement does not need to be a RefPtr<Node>,
because it is guaranteed to point to a shadow DOM tree of the DateInputType
node, which is guaranteed to exist in the subtree of the DateInputType node.
No tests. No change in behavior.
- html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
(WebCore::DateInputType::createShadowSubtree):
(WebCore::DateInputType::destroyShadowSubtree):
- html/DateInputType.h:
(DateInputType):
- 5:23 AM Changeset in webkit [125885] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Change font family/script on layout tests causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=94327
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
Always set the font on WebCore even if the font family is the same. It
has to be done because the script value might have also changed.
Settings::set*FontFamily() has an implicit UScriptCode
parameter that will set the script back to the defaults.
- ewk/ewk_view.cpp:
(ewk_view_font_family_name_set):
- 5:22 AM Changeset in webkit [125884] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971
Patch by Dan Carney <dcarney@google.com> on 2012-08-17
Reviewed by Kentaro Hara.
Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This update fixes a bad assertion which caused the previous
version to be rolled back.
No tests. No change in functionality.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::mainThreadNormalWorld):
- bindings/v8/DOMWrapperWorld.h:
(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
- bindings/v8/IsolatedWorld.cpp: Removed.
- bindings/v8/IsolatedWorld.h: Removed.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):
- bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):
- 5:18 AM Changeset in webkit [125883] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Remove alloca usage
https://bugs.webkit.org/show_bug.cgi?id=93931
Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Carlos Garcia Campos.
This patch is unifying the approaches for the creation of Edje_Message_Float_Set messages, and getting rid of alloca is part of it, since it is not portable.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::updateThumbPositionAndProportion):
- 5:08 AM Changeset in webkit [125882] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: hovering over an image link in Timeline popup kills popup
https://bugs.webkit.org/show_bug.cgi?id=94213
Reviewed by Pavel Feldman.
- Fixed bug with ElementsPanel PopoverHelper acting on the TimelinePanel (due to which the original issue occurs).
- Image preview added to resource entries popover in the timeline.
- Extracted the core image preview building code into UIUtils.js.
- Drive-by: fixed image centering in the preview element.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._showPopover.showCallback):
(WebInspector.TimelinePanel.prototype._showPopover):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.needsPreviewElement):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
First build the image preview element if necessary, then do everything else.
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
Original generatePopupContent() code plus the preview generation when necessary.
- inspector/front-end/UIUtils.js:
(WebInspector.buildImagePreviewContents.errorCallback):
(WebInspector.buildImagePreviewContents.buildContent):
(WebInspector.buildImagePreviewContents): Extracted from ElementsPanel. Enabled building of preview elements without the dimensions text data.
- inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):
- inspector/front-end/timelinePanel.css:
(.image-preview-container): Fixed centering of the preview container contents.
(.image-preview-container img):
(.image-container):
- 5:06 AM Changeset in webkit [125881] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: decouple extension server from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=94322
Reviewed by Pavel Feldman.
- relay WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged received in ElementsPanel on WebInspector.notifications;
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
- inspector/front-end/ExtensionServer.js:
- 4:42 AM Changeset in webkit [125880] by
-
- 10 edits in trunk
Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444
Patch by Jan Keromnes <janx@linux.com> on 2012-08-17
Reviewed by Pavel Feldman.
Source/WebCore:
Move SourceFrame from being a View to being an Object. This will allow
future ExtensionSourceFrames to share a single iframe ExtensionView.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.wasShown):
(WebInspector.CodeMirrorTextEditor.prototype.willHide):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.detach):
(WebInspector.SourceFrame.prototype.focus):
(WebInspector.SourceFrame.prototype._onTextEditorWasShown):
(WebInspector.SourceFrame.prototype._onTextEditorWillHide):
- inspector/front-end/TextEditor.js:
- inspector/front-end/scriptsPanel.css:
LayoutTests:
Use TextEditor as a View instead of SourceFrame.
- inspector/debugger/reveal-execution-line.html:
- inspector/debugger/source-frame-count.html:
- 3:54 AM Changeset in webkit [125879] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090
Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-17
Reviewed by Vsevolod Vlasov.
Added filtering support to search panel.
Implemented filtering for network panel.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightMatchedRequests):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequestForSearch):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.performFilter):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.performFilter):
(WebInspector.NetworkDataGridNode.prototype._highlightMatchedSubstring):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.showSearchField):
(WebInspector.SearchController.prototype._switchFilterToSearch):
(WebInspector.SearchController.prototype._switchSearchToFilter):
(WebInspector.SearchController.prototype._updateFilterVisibility):
(WebInspector.SearchController.prototype._replaceAll):
(WebInspector.SearchController.prototype._filterCheckboxClick):
(WebInspector.SearchController.prototype._performFilter):
(WebInspector.SearchController.prototype._onFilterInput):
(WebInspector.SearchController.prototype._onSearchInput):
(WebInspector.SearchController.prototype.resetFilter):
- inspector/front-end/inspector.css:
(.filter):
- inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other:not(.filtered-out)):
- 3:46 AM Changeset in webkit [125878] by
-
- 7 edits in trunk
View source doesn't interpret escape characters in hrefs.
https://bugs.webkit.org/show_bug.cgi?id=94216
Patch by Anthony Berent <aberent@chromium.org> on 2012-08-17
Reviewed by Adam Barth.
Source/WebCore:
The cause was that HTMLViewSourceDocument was passing the unparsed content of the href attribute to the DOM as the URL for the link.
The fix is to pass the parsed content of the href attribute to the DOM.
Test: fast/forms/frames/viewsource-link-on-href-value.html extended to test this case.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::processTagToken): Pass parsed URL to AddRange.
(WebCore::HTMLViewSourceDocument::addRange):Added argument for parsed URL, and used this instead of text, to create link.
- html/HTMLViewSourceDocument.h:
(HTMLViewSourceDocument): Add new link argument to addRange for parsed URL, defaulting to "".
LayoutTests:
Extra href added to test containing escape characters
- fast/frames/resources/viewsource-frame-3.html: Added href containing escape characters to test
- fast/frames/resources/viewsource-frame-4.html: Added href containing escape characters to test
- fast/frames/viewsource-link-on-href-value.html: Check escape characters are correctly interpreted in href.
- 3:31 AM WebKitGTK/WebKit2Roadmap edited by
- Update roadmap in preparation for the freeze (diff)
- 3:23 AM Changeset in webkit [125877] by
-
- 3 edits in trunk/Source/WTF
[Qt] QNX build fails due to missing timegm declaration
https://bugs.webkit.org/show_bug.cgi?id=93842
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Simon Hausmann.
On QNX, timegm is declared in nbutils.h and one must link against
nbutils to use it.
- WTF.pri:
- wtf/DateMath.cpp:
- 3:05 AM Changeset in webkit [125876] by
-
- 2 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297
Unreviewd. Temporary disable these tests.
- platform/chromium/TestExpectations:
- 2:50 AM Changeset in webkit [125875] by
-
- 3 edits in trunk/LayoutTests
Fixed fast/forms/file/selected-files-from-history-state.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=94278
Patch by Marja Hölttä <marja@chromium.org> on 2012-08-17
Reviewed by Jochen Eisinger.
- fast/forms/file/selected-files-from-history-state.html: Fixed the test.
- platform/chromium/TestExpectations: Removed the expectation to fail.
- 2:44 AM Changeset in webkit [125874] by
-
- 7 edits in trunk/Source/WebCore
[Forms] Rename SpinButtonElement::StepActionHandler to SpinButtonOwner
https://bugs.webkit.org/show_bug.cgi?id=94311
Reviewed by Kent Tamura.
This patch renames SpinButtonElement::StepActionHandler class to
SpinButtonOwner for adding functions to it for communicating spin
button and its owner.
No new tests. This patch doesn't change behavior.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::~TextFieldInputType):
(WebCore::TextFieldInputType::destroyShadowSubtree):
- html/TextFieldInputType.h:
(TextFieldInputType):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::~DateTimeEditElement):
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):
(WebCore::SpinButtonElement::doStepAction):
- html/shadow/SpinButtonElement.h:
(WebCore::SpinButtonElement::SpinButtonOwner::~SpinButtonOwner):
(SpinButtonElement):
(WebCore::SpinButtonElement::removeSpinButtonOwner):
- 2:42 AM Changeset in webkit [125873] by
-
- 7 edits in trunk/Source
[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
- Target.pri: Add missing JSWeakObjectMap file to build.
Source/WebCore:
The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.
The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use one JSWeakObjectMap per context group and store the
map in a separate context.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::unusedWeakObjectMapCallback):
(Bindings):
(JSC::Bindings::WeakMapImpl::WeakMapImpl):
(JSC::Bindings::WeakMapImpl::~WeakMapImpl):
(JSC::Bindings::WeakMap::~WeakMap):
(JSC::Bindings::WeakMap::set):
(JSC::Bindings::WeakMap::get):
(JSC::Bindings::WeakMap::remove):
- bridge/qt/qt_instance.h:
(WeakMapImpl):
(Bindings):
(WeakMap):
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 2:25 AM Changeset in webkit [125872] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
https://bugs.webkit.org/show_bug.cgi?id=94308
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
The reason is that loadClient.didChangeBackForwardList callback is invoked with zero
arguments which is valid case while page back-forward navigation and means basically
that the back-froward list has changed but items were not added or deleted.
- UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_changed):
- 2:16 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:16 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:14 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:08 AM Changeset in webkit [125871] by
-
- 45 edits in trunk
Web Inspector: build Elements, Resources, Timeline, Audits and Console panels lazily.
https://bugs.webkit.org/show_bug.cgi?id=94222
Reviewed by Vsevolod Vlasov.
Source/WebCore:
There is no need to construct these panels on inspector startup - we can do that lazily.
This change introduces the concept of PanelDescriptor that is sufficient for the panel
representation before it has been selected. It also makes selected panels build lazily.
The next step is to migrate rest of the panels and load the panel code lazily as well.
That should speed up startup time significantly.
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsSidebarTreeElement):
(WebInspector.AuditsSidebarTreeElement.prototype.onselect):
(WebInspector.AuditResultSidebarTreeElement):
(WebInspector.AuditResultSidebarTreeElement.prototype.onselect):
- inspector/front-end/ConsolePanel.js:
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):
- inspector/front-end/Database.js:
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateForcedPseudoStateItems):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onAddAuditCategory):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.showResources):
(InspectorFrontendAPI.enterInspectElementMode):
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.panel):
(WebInspector.InspectorView.prototype.showPanel):
(WebInspector.InspectorView.prototype._keyDownInternal):
- inspector/front-end/NetworkPanel.js:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.name):
(WebInspector.PanelDescriptor.prototype.title):
(WebInspector.PanelDescriptor.prototype.iconURL):
(WebInspector.PanelDescriptor.prototype.setIconURL):
(WebInspector.PanelDescriptor.prototype.panel):
(WebInspector.PanelDescriptor.prototype.lazy):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.cachedResourcesLoaded):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.prototype._createPanelToolbarItem.panelSelected):
(WebInspector.Toolbar.prototype._createPanelToolbarItem):
(WebInspector.Toolbar.prototype._panelSelected):
(WebInspector.Toolbar.prototype._setDropdownVisible):
(WebInspector.ToolbarDropdown):
(WebInspector.ToolbarDropdown.prototype.show):
(WebInspector.ToolbarDropdown.prototype._populate):
- inspector/front-end/inspector.css:
(.toolbar-small .toolbar-icon.custom-toolbar-icon):
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._panelSelected):
(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.openResource):
(WebInspector.showPanel):
(WebInspector.panel):
(WebInspector.inspect.):
(WebInspector.inspect):
(WebInspector._showAnchorLocation):
(WebInspector.showProfileForURL):
(WebInspector.frontendReused):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound):
(initialize_ElementTest.InspectorTest.selectNodeWithId):
(initialize_ElementTest.InspectorTest.expandElementsTree):
- http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.InspectorTest.showPanel):
- http/tests/inspector/inspect-element.html:
- http/tests/inspector/resource-har-pages.html:
- http/tests/inspector/resource-tree/resource-tree-frame-add.html:
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- http/tests/inspector/resource-tree/resource-tree-reload.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/console/command-line-api-inspect.html:
- inspector/debugger/dom-breakpoints.html:
- inspector/debugger/source-frame.html:
- inspector/elements/edit-dom-actions.html:
- inspector/elements/elements-img-tooltip.html:
- inspector/elements/elements-panel-limited-children.html:
- inspector/elements/highlight-node-scaled.html:
- inspector/extensions/extensions-panel.html:
- inspector/extensions/extensions-sidebar.html:
- inspector/styles/force-pseudo-state.html:
- inspector/styles/set-property-boundaries.html:
- inspector/styles/styles-new-API.html:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.stopTimeline):
- 2:02 AM Changeset in webkit [125870] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Add two more crash expectations for a couple of tests that started crashing
after r125710.
Update stale test expectations, removing or adding build type modifiers
or updating the expected failure type.
- platform/gtk/TestExpectations:
- 1:54 AM WebKitGTK/WebKit2Roadmap edited by
- Added bug report for GObject introspection (diff)
- 1:52 AM Changeset in webkit [125869] by
-
- 6 edits2 adds in trunk
Source/WebCore: libwebp-0.2.0: handle alpha channel if present
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
updated the Layout test webp-image-decoding.html
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(outputMode):
switch to premultiplied-RGB if needed
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::decode):
use WebPGetFeatures() instead of WebPGetInfo(),
to detect presence of alpha channel
- platform/image-decoders/webp/WEBPImageDecoder.h:
(WEBPImageDecoder):
add a m_hasAlpha field
LayoutTests: update layout test for new libwebp-0.2.0
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
- fast/images/resources/test2.webp: Added.
lossy+alpha example
- fast/images/resources/test3.webp: Added.
lossless with alpha example
- fast/images/webp-image-decoding-expected.txt:
- fast/images/webp-image-decoding.html:
Updated test. Will now decode test2.webp and test3.webp too.
- 1:35 AM Changeset in webkit [125868] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Enable multiple fields time input UI for Chromium except Android
https://bugs.webkit.org/show_bug.cgi?id=94195
Reviewed by Kent Tamura.
This patch enables multiple fields time input UI for Chromium except
for Android.
No new tests. Existing tests in fast/forms/time-multiple-fields/
covers appearance and functionality of multiple fields time UI.
A manual checking for browser displays multiple fields time input UI
is needed.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore): Changed RuntimeEnabledFeatures::isInputTypeTimeEnabled to true
if ENABLE_INPUT_TYPE_TIME is enabled.
- 1:13 AM Changeset in webkit [125867] by
-
- 1 edit12 adds in trunk/LayoutTests
[Tests] Adding tests for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94196
Reviewed by Kent Tamura.
This patch introduces functional testing for multiple fields time input
UI when both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
are enabled.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Added.
- 1:11 AM Changeset in webkit [125866] by
-
- 15 edits in trunk/Source/WebCore
[Forms] Introduce SpinButtonElement.{cpp,h} into build
https://bugs.webkit.org/show_bug.cgi?id=94289
Reviewed by Kent Tamura.
This patch introduces html/shadow/SpinButtonElement.{cpp,h} into
build, files were copied from TextControlInnerElements.{cpp,h} by
bug 93943.
No new tests. This patch doesn't changes behavior.
- CMakeLists.txt: Added SpinButtonElement.cpp
- GNUmakefile.list.am: Added SpinButtonElement.{cpp,h}
- Target.pri: Added SpinButtonElement.cpp
- WebCore.gypi: Added SpinButtonElement.{cpp,h}
- WebCore.vcproj/WebCore.vcproj: Added SpinButtonElement.{cpp,h}
- WebCore.xcodeproj/project.pbxproj: Added SpinButtonElement.{cpp,h}
- accessibility/AccessibilitySpinButton.h: Replaced include file to SpinButtonElement.h from TextControlInnerElements.h
- html/TextFieldInputType.h: Added include file SpinButtonElement.h
- html/shadow/DateTimeEditElement.h: Replaced include file to SpinButtonElement.h from TextControlInnerElements.h
- html/shadow/SpinButtonElement.cpp: Removed code other than SpinButtonElement.
- html/shadow/SpinButtonElement.h: Removed code other than SpinButtonElement.
- html/shadow/TextControlInnerElements.cpp: Removed code of SpinButtonElement.
- html/shadow/TextControlInnerElements.h: Removed SpinButtonElement.
- rendering/RenderTheme.cpp: Added include file SpinButtonElement.h
- 1:08 AM Changeset in webkit [125865] by
-
- 23 edits18 adds in trunk
Implement UndoManager's V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=93912
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch implements V8 bindings for UndoManager's transact() method.
We keep alive the user objects passed to transact() by storing them in
a hidden property of DOMTransaction's wrapper and registering implicit
references from UndoManager to DOMTransaction.
Tests: editing/undomanager/domtransaction-survives-gc.html
editing/undomanager/undomanager-isolated-world.html
editing/undomanager/undomanager-transact.html
editing/undomanager/undomanager-undo-redo.html
editing/undomanager/undomanager-use-after-free.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMTransaction.cpp: Added.
(WebCore):
(WebCore::DOMTransaction::DOMTransaction):
(WebCore::DOMTransaction::create):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
- bindings/js/DOMTransaction.h: Added.
(WebCore):
(DOMTransaction):
(WebCore::DOMTransaction::undoManager):
(WebCore::DOMTransaction::setUndoManager):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSUndoManagerCustom.cpp: Added.
(WebCore):
(WebCore::JSUndoManager::transact):
- bindings/v8/DOMTransaction.cpp: Added.
(WebCore):
(WebCore::DOMTransaction::DOMTransaction):
(WebCore::DOMTransaction::create):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
(WebCore::DOMTransaction::getFunction):
(WebCore::DOMTransaction::callFunction):
- bindings/v8/DOMTransaction.h: Added.
(WebCore):
(DOMTransaction):
(WebCore::DOMTransaction::undoManager):
(WebCore::DOMTransaction::setUndoManager):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/custom/V8DOMTransactionCustom.cpp: Added.
(WebCore):
(WebCore::V8DOMTransaction::visitDOMWrapper):
- bindings/v8/custom/V8UndoManagerCustom.cpp: Added.
(WebCore):
(WebCore::V8UndoManager::transactCallback):
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::undoManager):
- dom/Element.cpp:
(WebCore::Element::undoManager):
(WebCore::Element::disconnectUndoManager):
- editing/CompositeEditCommand.h:
- editing/DOMTransaction.idl: Added.
- editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::canUndo):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo):
(WebCore::Editor::redo):
- editing/UndoManager.cpp:
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::clearStack):
(WebCore):
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::stop):
(WebCore::UndoManager::~UndoManager):
(WebCore::createUndoManagerEntry):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::registerUndoStep):
(WebCore::UndoManager::registerRedoStep):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
- editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::position):
(WebCore::UndoManager::canUndo):
(WebCore::UndoManager::canRedo):
(WebCore::UndoManager::undoScopeHost):
(WebCore::UndoManager::ownerNode):
- editing/UndoManager.idl:
- editing/UndoStep.h:
(UndoStep):
LayoutTests:
- editing/undomanager/domtransaction-survives-gc-expected.txt: Added.
- editing/undomanager/domtransaction-survives-gc.html: Added.
- editing/undomanager/undomanager-isolated-world-expected.txt: Added.
- editing/undomanager/undomanager-isolated-world.html: Added.
- editing/undomanager/undomanager-transact-expected.txt: Added.
- editing/undomanager/undomanager-transact.html: Added.
- editing/undomanager/undomanager-undo-redo-expected.txt: Added.
- editing/undomanager/undomanager-undo-redo.html: Added.
- editing/undomanager/undomanager-use-after-free-expected.txt: Added.
- editing/undomanager/undomanager-use-after-free.html: Added.
- 12:46 AM pywebsocket: a WebSocket server for layout tests created by
- 12:39 AM Changeset in webkit [125864] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: mark two accessibility tests as failing on GTK. Bug 94200.
- 12:38 AM Changeset in webkit [125863] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: CPU profile view select overlaps with status bar buttons
https://bugs.webkit.org/show_bug.cgi?id=94243
Reviewed by Pavel Feldman.
- use StatusBarComboBox inated of plain select element in the status bar of CPU profile view;
- add StatusBarComboBox.select()
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.get statusBarItems):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox.prototype.selectedOption):
(WebInspector.StatusBarComboBox.prototype.select):
- inspector/front-end/externs.js: drive-by fix: add declaration to suppress compilation error;
(Array.prototype.select):
