⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 24, 2012:

11:51 PM Changeset in webkit [129462] by commit-queue@webkit.org
  • 24 edits
    8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/resources/image1.html: Added.
  • fast/loader/resources/image2.html: Added.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
11:48 PM Changeset in webkit [129461] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=97530
Regression, freeze applied to numeric properties of non-array objects

Reviewed by Filip Pizlo.

Object.freeze has a fast implementation in JSObject, but this hasn't been updated to take into account numeric properties in butterflies.
For now, just fall back to the generic implementation if the object has numeric properties.

Source/JavaScriptCore:

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorFreeze):

  • fallback if the object has a non-zero indexed property vector length.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added a test case for freezing an object with a numeric property.
11:32 PM Changeset in webkit [129460] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

  • platform/gtk/TestExpectations:
11:17 PM Changeset in webkit [129459] by zandobersek@gmail.com
  • 12 edits in trunk

Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
​https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):
(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.run):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
11:12 PM Changeset in webkit [129458] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug in numeric accessors on global environment
​https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

  • Add missing toThisObject calls.
10:27 PM Changeset in webkit [129457] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

SerializedScriptValue isn't aware of indexed storage, but should be
​https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSObject.h:

(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

LayoutTests:

  • fast/js/post-message-numeric-property-expected.txt: Added.
  • fast/js/post-message-numeric-property.html: Added.
  • fast/js/script-tests/post-message-numeric-property.js: Added.

(window.onmessage):

9:52 PM Changeset in webkit [129456] by barraclough@apple.com
  • 7 edits in trunk/Source

Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
​https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

  • runtime/JSGlobalObject.cpp:
    • Call globalObject() instead of unwrappedGlobalObject().
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • Changed to compare this object values, instead of globalObjects - this means we only need to be able to map globalObject -> this, and not vice versa.
  • runtime/JSObject.cpp:

(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):

  • Call globalObject() instead of unwrappedGlobalObject().
  • runtime/JSObject.h:

(JSObject):

  • Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::setWindow):

  • Update the JSDOMWindowShell's structure's globalObject when the window changes.
9:50 PM EFLWebKit edited by Laszlo Gombos
Baseline minimal required tool versions (diff)
9:40 PM Changeset in webkit [129455] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] We should remove DateTimeEditElement::valueAsDouble()
​https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.

(DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.

(DateTimeFieldElement):

  • html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
  • html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

9:33 PM Changeset in webkit [129454] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
​https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

9:30 PM Changeset in webkit [129453] by mark.lam@apple.com
  • 20 edits in trunk/Source

Deleting the classic interpreter and cleaning up some build options.
​https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):

  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):

  • interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

  • interpreter/AbstractPC.h:

(AbstractPC):

  • interpreter/CallFrame.h:

(ExecState):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):
(Interpreter):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • offlineasm/asm.rb:
  • offlineasm/offsets.rb:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):

  • runtime/Options.cpp:

(JSC::Options::initialize):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • wtf/Platform.h:
9:25 PM Changeset in webkit [129452] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Don't use StyleSheetList internally.
​https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):

  • css/StyleSheetList.h:


Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.


(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):

  • dom/Document.h:

(Document):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollec

9:09 PM Changeset in webkit [129451] by weinig@apple.com
  • 11 edits
    3 adds in trunk

Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Target.pri:

Add new files.

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/efl/WebProcessProxyEfl.cpp: Added.

Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):

  • UIProcess/gtk/WebProcessProxyGtk.cpp: Added.

Add stub.

(WebKit::WebProcessProxy::platformConnect):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

  • UIProcess/qt/WebProcessProxyQt.cpp: Added.

(WebKit::WebProcessProxy::platformConnect):
Add stub.

  • UIProcess/win/WebProcessProxyWin.cpp:

(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

  • Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

8:55 PM Changeset in webkit [129450] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

  • platform/cairo/WidgetBackingStoreCairo.cpp:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:
  • plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

  • UIProcess/cairo/BackingStoreCairo.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
8:53 PM Changeset in webkit [129449] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK][EFL] Make sure cairo is built with fontconfig support
​https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
8:26 PM Changeset in webkit [129448] by yosin@chromium.org
  • 4 edits
    1 copy
    3 adds in trunk

Document::adoptNode for multiple fields time input UI should not crash
​https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:

  • fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.
  • dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

  • fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
  • fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.
8:22 PM Changeset in webkit [129447] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
​https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

  • CMakeLists.txt:

Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

8:13 PM Changeset in webkit [129446] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Blackberry] Add a software rendering path for media player
​https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

7:56 PM Changeset in webkit [129445] by benjamin@webkit.org
  • 9 edits in trunk/LayoutTests

We should not expect percent-escaped hostname for invalid URLs
​https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

  • fast/url/invalid-urls-utf8-expected.txt:
  • fast/url/invalid-urls-utf8.html:

Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/script-tests/ipv4.js:
  • fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.

Invalid URLs should not be escaped.

7:30 PM Changeset in webkit [129444] by benjamin@webkit.org
  • 46 edits in trunk

Fix Geolocation error reporting in the test support
​https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

  • platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):

  • platform/mock/GeolocationClientMock.h:

(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):

  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • public/WebGeolocationClientMock.h:

(WebGeolocationClientMock):

  • src/WebGeolocationClientMock.cpp:

(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _geolocationDidFailWithMessage:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

  • DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/mac/MockGeolocationProvider.h:
  • DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider resetError]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider timerFired]):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

LayoutTests:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

Update the tests to use setMockGeolocationPositionUnavailableError() instead
of setMockGeolocationError().

Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
anything for the test coverage.

  • fast/dom/Geolocation/error-clear-watch.html:
  • fast/dom/Geolocation/error-expected.txt:
  • fast/dom/Geolocation/maximum-age-expected.txt:
  • fast/dom/Geolocation/reentrant-error-expected.txt:
  • fast/dom/Geolocation/script-tests/error.js:
  • fast/dom/Geolocation/script-tests/maximum-age.js:

(checkError):
(testNonZeroMaximumAge):

  • fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
  • fast/dom/Geolocation/script-tests/reentrant-error.js:
  • fast/dom/Geolocation/script-tests/watch.js:

(checkError):

  • fast/dom/Geolocation/watch-expected.txt:
7:16 PM Changeset in webkit [129443] by tkent@chromium.org
  • 7 edits
    1 copy
    1 add in trunk/Source

[Chromium] Implement ValidationMessageClient for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=97167

Reviewed by Hajime Morita.

Source/WebCore:

  • page/ValidationMessageClient.h:

Add forward declaration for WTF::String.

Source/WebKit/chromium:

Introduce ValidationMessageClientImpl. However actual popup
implementation should be done in WebViewClient.

  • WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
  • public/WebViewClient.h:

(WebKit::WebViewClient::showValidationMessage): Added.
(WebKit::WebViewClient::hideValidationMessage): Added.

  • src/ValidationMessageClientImpl.cpp: Added.

(WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
(WebKit::ValidationMessageClientImpl::create):
(WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
Make sure that a popup is closed.
(WebKit::ValidationMessageClientImpl::showValidationMessage):
Implementataion of ValidationMessageClient::showValidationMessage.
minimumSecondToShowValidationMessage and secondPerCharacter are same as
the corresponding values in the current Shadow DOM implementation.
(WebKit::ValidationMessageClientImpl::hideValidationMessage):
Implementataion of ValidationMessageClient::hideValidationMessage.
(WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
Implementataion of ValidationMessageClient::isValidationMessageVisible.
(WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
This is a callback function for the timer.

  • src/ValidationMessageClientImpl.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • Initialize m_validationMessage.
  • Add a comment for PageClients.
  • src/WebViewImpl.h:

Add m_validationMessage.

7:07 PM Changeset in webkit [129442] by mihaip@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
​https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with ​http://crrev.com/155205.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:
6:48 PM Changeset in webkit [129441] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
​https://bugs.webkit.org/show_bug.cgi?id=97303

Reviewed by Kent Tamura.

This patch introduces a function DateTimeEditElement::value() for
setting internal text value of TimeInputType with new function
EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
in other date time input types.

We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
to make string value then setting internal text value of multiple
fields time input UI. Although, this steps doesn't work well for
other date/time input types.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/DateTimeFieldsState.cpp:

(WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.

  • html/DateTimeFieldsState.h:

(DateTimeFieldsState): Added declaration of hour23().

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
(WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().

  • html/TimeInputType.h:

(DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::value): Added.

  • html/shadow/DateTimeEditElement.h:

(EditControlOwner): Added a declaration of formatDateTimeFieldsState().
(DateTimeEditElement): Added a declaration of value().

6:26 PM Changeset in webkit [129440] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
​https://bugs.webkit.org/show_bug.cgi?id=97508
<rdar://problem/12361132>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
(like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
context stack afterwards.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitComplexJumpScopes):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/try-try-return-finally-finally.js: Added.

(foo):

  • fast/js/try-try-return-finally-finally-expected.txt: Added.
  • fast/js/try-try-return-finally-finally.html: Added.
6:14 PM Changeset in webkit [129439] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] Intel Mac needs built-in function emulation
​https://bugs.webkit.org/show_bug.cgi?id=96140

Reviewed by Sam Weinig.

Temporarily turn on built-in function emulation for Intel GPUs
on OS X. This is a work-around for a driver bug, and
will be removed once the driver is updated:
​https://bugs.webkit.org/show_bug.cgi?id=97503

This can be tested using the Khronos WebGL conformance
suite, in particular:

conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html

Note that the faceforward built-in will still cause
problems on Intel GPUs, but this would require an unnecessary
change in the ANGLE project (remember, we're going to
remove this code once the driver is fixed).

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

Temporarily add "Intel" to the list of GPUs we do translation
for in the shader compiler.

6:05 PM Changeset in webkit [129438] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
​https://bugs.webkit.org/show_bug.cgi?id=97450

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Yury Semikhatsky.

The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
no-worker thread.

No new test case.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::PageProfilerAgent::recompileScript):
(PageProfilerAgent):
(WebCore::WorkerProfilerAgent::recompileScript):
(WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

5:54 PM Changeset in webkit [129437] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][WK2] TestRunner needs touch events support.
​https://bugs.webkit.org/show_bug.cgi?id=96465

Patch by Nikhil Bansal <​n.bansal@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

Tools:

Simulate touch events in WebkitTestRunner for touch related
layout tests. This patch uses ewk_view_feed_touch_event() to
generate touch events.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::setEvasModifiers):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Touch events support added in WebKitTestRunner for layout tests.

  • platform/efl-wk2/TestExpectations:
5:53 PM Changeset in webkit [129436] by vollick@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore

CCActiveAnimation should handle durations of zero gracefully

5:46 PM Changeset in webkit [129435] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

ValueToInt32 bool case does bad things to registers
​https://bugs.webkit.org/show_bug.cgi?id=97505
<rdar://problem/12356331>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

LayoutTests:

  • fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
  • fast/js/dfg-bool-to-int32-reuse.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.

(foo):

5:38 PM Changeset in webkit [129434] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add cloopDo instruction for debugging the llint C++ backend.
​https://bugs.webkit.org/show_bug.cgi?id=97502.

Reviewed by Geoffrey Garen.

  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
5:28 PM Changeset in webkit [129433] by Patrick Gansterer
  • 5 edits in trunk/Source

Remove String::operator+=()
​https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

  • wtf/Platform.h:
  • wtf/text/WTFString.h:
5:20 PM Changeset in webkit [129432] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

JSArray::putByIndex asserts with readonly property on prototype
​https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Boy, there were some problems:

  • putDirectIndex() should know that it can set the index quickly even if it's a hole and we're in SlowPut mode, since that's the whole point of PutDirect.


  • We should have a fast path for putByIndex().


  • The LiteralParser should not use push(), since that may throw if we're having a bad time.
  • interpreter/Interpreter.cpp:

(JSC::eval):

  • runtime/JSObject.h:

(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

LayoutTests:

  • fast/js/concat-while-having-a-bad-time.html: Added.
  • fast/js/concat-while-having-a-bad-time-expected.txt: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/concat-while-having-a-bad-time.js: Added.
5:12 PM Changeset in webkit [129431] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
5:05 PM Changeset in webkit [129430] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2] TestRunner does not support overridePreference with value "0"
​https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
4:57 PM Changeset in webkit [129429] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Mac] Remove loadFont from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

4:53 PM Changeset in webkit [129428] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
​https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:43 PM Changeset in webkit [129427] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Replace 2 uses of updateLogicalHeight with computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804. This is just a refactoring.

No new tests, behavior should be the same as before.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

4:12 PM Changeset in webkit [129426] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Inlined activation tear-off in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=97487

Reviewed by Filip Pizlo.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h: Activation tear-off is always inlined now, so I

removed its out-of-line implementation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
of JSVariableObject::m_registers. This usually turns into < 10 instructions,
which is close to pure win as compared to the operation function call.

  • runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC):
(JSC::JSActivation::storageOffset):
(JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
share the pointer math helper functions we use internally.

3:23 PM Changeset in webkit [129425] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in ​https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.

  • platform/win/Skipped:
3:18 PM Changeset in webkit [129424] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
​https://bugs.webkit.org/show_bug.cgi?id=96703

Reviewed by Adam Barth.

Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.

No tests because it is not guaranteed that buffers this large can actually be allocated.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

3:14 PM Changeset in webkit [129423] by Antti Koivisto
  • 30 edits
    1 copy
    1 add in trunk/Source

Split stylesheet related code out from Document
​https://bugs.webkit.org/show_bug.cgi?id=97353

Reviewed by Andreas Kling.

Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.

The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
DocumentStyleSheetCollection class. There are no functional changes.

The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.

  • WebCore.xcodeproj/project.pbxproj:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(WebCore::StyleResolver::usesBeforeAfterRules):
(Features):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore):
(WebCore::Document::createStyleResolver):
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore::Document::didRemoveAllPendingStylesheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::styleSheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::reportMemoryUsage):
(WebCore::Document::haveStylesheetsLoaded):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::styleSheetCollection):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
(WebCore::Document::inStyleRecalc):

  • dom/DocumentStyleSheetCollection.cpp: Added.

(WebCore):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h: Added.

(WebCore):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::authorStyleSheets):
(WebCore::DocumentStyleSheetCollection::documentUserSheets):
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::addPendingSheet):
(WebCore::DocumentStyleSheetCollection::hasPendingSheets):
(WebCore::DocumentStyleSheetCollection::usesSiblingRules):
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesRemUnits):
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::insertedIntoDocument):
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearDocumentData):
(WebCore::StyleElement::createSheet):
(WebCore::StyleElement::sheetLoaded):
(WebCore::StyleElement::startLoadingDynamicSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • page/PageGroup.cpp:

(WebCore::PageGroup::resetUserStyleCacheInAllFrames):

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::lineHeight):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):

  • rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::updateBeforeAndAfterContent):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

3:08 PM Changeset in webkit [129422] by kareng@chromium.org
  • 4 edits
    2 copies in branches/chromium/1271

Merge 128999 - Do touch adjustment on GestureTapDown
​https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.

  • DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use. Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

  • touchadjustment/resources/touchadjustment.js:

(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):

  • touchadjustment/touch-links-active-expected.txt: Added.
  • touchadjustment/touch-links-active.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/10988006

3:06 PM Changeset in webkit [129421] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=97485

This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.

  • platform/win/Skipped:
3:05 PM TestExpectations edited by dpranke@chromium.org
add comments about flaky tests (diff)
3:04 PM Changeset in webkit [129420] by Lucas Forschler
  • 5 edits in branches/safari-534.58-branch/Source

Versioning.

2:59 PM Changeset in webkit [129419] by commit-queue@webkit.org
  • 12 edits
    1 delete in trunk/Source

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Source/WebCore:

Revert "[BlackBerry] Reverting implementation for 407 error pages"
This reverts commit fda0a1b6ac40c06c03bb6293b4a7d7353c3ca238.

This revert also reverts commit 0cffe01961fb80204138505bcec29a83818efb73
due to dependency issues.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
  • platform/blackberry/AuthenticationChallengeManager.h:
  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

Source/WebKit/blackberry:

Revert "[BlackBerry] Really fix bug 95488 that user can get the
authentication challenge dialog while the other tab has focus."
​https://bugs.webkit.org/show_bug.cgi?id=97348

This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):

  • Api/WebPage_p.h:

(WebPagePrivate):

2:55 PM Changeset in webkit [129418] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=97439

Reviewed by Kenneth Russell.

Fixes uninitialized member variable.

This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

2:52 PM Changeset in webkit [129417] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Narrow Chromium TestExpectations for some hidpi failures to be Linux-only.
crbug.com/150682

Unreviewed, expectations change.

Also remove a no-longer-failing Mac expectation for
compositing/overflow/overflow-scaled-descendant-overlapping.html

  • platform/chromium/TestExpectations:
2:40 PM Changeset in webkit [129416] by Lucas Forschler
  • 1 copy in tags/Safari-536.27.1

New Tag.

2:38 PM Changeset in webkit [129415] by dmazzoni@google.com
  • 3 edits in branches/chromium/1271

Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html

platform/mac/accessibility/form-control-value-settable.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

  • platform/chromium/accessibility/readonly-expected.txt: Added.
  • platform/chromium/accessibility/readonly.html: Added.
  • platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
  • platform/mac/accessibility/form-control-value-settable.html: Added.

TBR=​dmazzoni@google.com
Review URL: ​https://codereview.chromium.org/10984006

2:35 PM Changeset in webkit [129414] by tony@chromium.org
  • 7 edits in trunk

flex-grow should be 1 when omitted from flex shorthand
​https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html

css3/flexbox/flex-algorithm.html: New test case.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

  • css3/flexbox/flex-algorithm-expected.txt:
  • css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
2:32 PM Changeset in webkit [129413] by benjamin@webkit.org
  • 16 edits
    2 adds
    1 delete in trunk/Source

Add support for query encoding to WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97422

Reviewed by Adam Barth.

Source/WebCore:

Add the Charset conversion on WebCore side.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(CharsetConverter):
(WebCore::CharsetConverter::CharsetConverter):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

Source/WTF:

Expose character conversion through the new abstract class URLQueryCharsetConverter.
URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.

Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
to mitigate that later when moving WTFURL to more templates.

The change fixes 2 of the URL layout tests.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):
ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
That was a mistake on my part, I did not intend that, fixed it now :)

  • wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.

(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):

  • wtf/url/api/URLQueryCharsetConverter.h: Added.

(URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):

  • wtf/url/src/URLCanon.h:

(URLCanonicalizer):

  • wtf/url/src/URLCanonFilesystemurl.cpp:

(WTF::URLCanonicalizer::canonicalizeFileSystemURL):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

  • wtf/url/src/URLCanonFileurl.cpp:

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(WTF::URLCanonicalizer::ReplaceFileURL):

  • wtf/url/src/URLCanonInternal.h:

(URLCanonicalizer):

  • wtf/url/src/URLCanonQuery.cpp:

(WTF::URLCanonicalizer::CanonicalizeQuery):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

  • wtf/url/src/URLCanonRelative.cpp:

(WTF::URLCanonicalizer::resolveRelativeURL):

  • wtf/url/src/URLCanonStdURL.cpp:

(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

  • wtf/url/src/URLUtil.cpp:

(URLUtilities):
(WTF::URLUtilities::canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):

  • wtf/url/src/URLUtil.h:

(URLUtilities):

2:30 PM Changeset in webkit [129412] by benjamin@webkit.org
  • 13 edits
    23 adds
    4 deletes in trunk/Source

Integrate most of GoogleURL in WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97405

Reviewed by Adam Barth.

Source/WebCore:

Loosen KURLWTFURL to be able to run most tests in Debug.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::hasPort):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::query):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::fileSystemPath):

Source/WTF:

This patch brings almost all of the implementatation of Google-URL in WTFURL
with only minor changes.

The changes from the original code are mostly:
-Code cleaning.
-Replace url_parse::Parsed by URLSegments.
-Replace url_parse::Component by URLComponent
-More code cleaning.
-Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
-Use URLCharacterTypes instead of the litany of characters functions.
-Some more code cleaning.
-Fix the style to match WebKit as much as possible.
-Rename the files to match WebKit style.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::segment):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isValid):

  • wtf/url/src/RawURLBuffer.h:
  • wtf/url/src/URLCanon.h: Added.

(URLCanonicalizer):
(CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
(CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
(WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
(URLComponentSource):
(WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
(Replacements):
(WTF::URLCanonicalizer::Replacements::Replacements):
(WTF::URLCanonicalizer::Replacements::SetScheme):
(WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
(WTF::URLCanonicalizer::Replacements::SetUsername):
(WTF::URLCanonicalizer::Replacements::ClearUsername):
(WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
(WTF::URLCanonicalizer::Replacements::SetPassword):
(WTF::URLCanonicalizer::Replacements::ClearPassword):
(WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
(WTF::URLCanonicalizer::Replacements::SetHost):
(WTF::URLCanonicalizer::Replacements::ClearHost):
(WTF::URLCanonicalizer::Replacements::IsHostOverridden):
(WTF::URLCanonicalizer::Replacements::SetPort):
(WTF::URLCanonicalizer::Replacements::ClearPort):
(WTF::URLCanonicalizer::Replacements::IsPortOverridden):
(WTF::URLCanonicalizer::Replacements::SetPath):
(WTF::URLCanonicalizer::Replacements::ClearPath):
(WTF::URLCanonicalizer::Replacements::IsPathOverridden):
(WTF::URLCanonicalizer::Replacements::SetQuery):
(WTF::URLCanonicalizer::Replacements::ClearQuery):
(WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
(WTF::URLCanonicalizer::Replacements::SetRef):
(WTF::URLCanonicalizer::Replacements::ClearRef):
(WTF::URLCanonicalizer::Replacements::IsRefOverridden):
(WTF::URLCanonicalizer::Replacements::sources):
(WTF::URLCanonicalizer::Replacements::components):
(WTF::URLCanonicalizer::Replacements::Placeholder):

  • wtf/url/src/URLCanonEtc.cpp: Added.

(WTF::URLCanonicalizer::removeURLWhitespace):
(URLCanonicalizer):
(WTF::URLCanonicalizer::canonicalSchemeChar):
(WTF::URLCanonicalizer::CanonicalizeScheme):
(WTF::URLCanonicalizer::CanonicalizeUserInfo):
(WTF::URLCanonicalizer::CanonicalizePort):
(WTF::URLCanonicalizer::CanonicalizeRef):

  • wtf/url/src/URLCanonFilesystemurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

  • wtf/url/src/URLCanonFileurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::FileCanonicalizePath):
(WTF::URLCanonicalizer::ReplaceFileURL):

  • wtf/url/src/URLCanonHost.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeHost):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeHostVerbose):

  • wtf/url/src/URLCanonICU.cpp: Added.

(WTF::URLCanonicalizer::IDNToASCII):
(URLCanonicalizer):
(WTF::URLCanonicalizer::readUTFChar):

  • wtf/url/src/URLCanonIP.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeIPAddress):
(URLCanonicalizer):

  • wtf/url/src/URLCanonInternal.cpp: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::AppendInvalidNarrowString):
(WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
(WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
(WTF::URLCanonicalizer::SetupOverrideComponents):
(WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):

  • wtf/url/src/URLCanonInternal.h: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::hexCharToValue):
(WTF::URLCanonicalizer::isDot):
(WTF::URLCanonicalizer::appendURLEscapedCharacter):
(WTF::URLCanonicalizer::doAppendUTF8):
(WTF::URLCanonicalizer::AppendCharToOutput):
(WTF::URLCanonicalizer::AppendUTF8Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedValue):
(WTF::URLCanonicalizer::AppendUTF16Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedChar):
(WTF::URLCanonicalizer::Is8BitChar):
(WTF::URLCanonicalizer::DecodeEscaped):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):
(WTF::URLCanonicalizer::_strtoui64):

  • wtf/url/src/URLCanonMailto.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeMailtoURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceMailtoURL):

  • wtf/url/src/URLCanonPath.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizePath):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizePartialPath):

  • wtf/url/src/URLCanonPathurl.cpp: Added.

(WTF::URLCanonicalizer::canonicalizePathURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplacePathURL):

  • wtf/url/src/URLCanonQuery.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeQuery):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

  • wtf/url/src/URLCanonRelative.cpp: Added.

(WTF::URLCanonicalizer::isRelativeURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::resolveRelativeURL):

  • wtf/url/src/URLCanonStdURL.cpp: Added.

(WTF::URLCanonicalizer::DefaultPortForScheme):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

  • wtf/url/src/URLCharacterTypes.cpp:
  • wtf/url/src/URLCharacterTypes.h:

(WTF::URLCharacterTypes::isComponentChar):
(WTF::URLCharacterTypes::isHexChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isCharacterOfType):
(URLCharacterTypes):

  • wtf/url/src/URLEscape.cpp: Removed.
  • wtf/url/src/URLFile.h: Added.

(URLParser):
(WTF::URLParser::isWindowsDriveSeparator):
(WTF::URLParser::isWindowsDriveLetter):
(WTF::URLParser::findNextSlash):
(WTF::URLParser::doesBeginWindowsDriveSpec):
(WTF::URLParser::doesBeginUNCPath):

  • wtf/url/src/URLParse.cpp: Added.

(WTF::URLParser::ExtractScheme):
(URLParser):
(WTF::URLParser::IsAuthorityTerminator):
(WTF::URLParser::ExtractFileName):
(WTF::URLParser::ExtractQueryKeyValue):
(WTF::URLParser::ParseAuthority):
(WTF::URLParser::ParsePort):
(WTF::URLParser::ParseStandardURL):
(WTF::URLParser::ParsePathURL):
(WTF::URLParser::ParseFileSystemURL):
(WTF::URLParser::ParseMailtoURL):
(WTF::URLParser::parsePathInternal):
(WTF::URLParser::ParseAfterScheme):

  • wtf/url/src/URLParse.h: Added.

(URLParser):

  • wtf/url/src/URLParseFile.cpp: Added.

(WTF):
(WTF::URLParser::ParseFileURL):
(URLParser):

  • wtf/url/src/URLParseInternal.h: Added.

(URLParser):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::countConsecutiveSlashes):

  • wtf/url/src/URLParser.h: Removed.
  • wtf/url/src/URLQueryCanonicalizer.h: Removed.
  • wtf/url/src/URLSegments.cpp:
  • wtf/url/src/URLSegments.h:

(WTF::URLSegments::URLSegments):
(URLSegments):
(WTF::URLSegments::operator=):
(WTF::URLSegments::innerURLSegments):
(WTF::URLSegments::setInnerURLSegments):
(WTF::URLSegments::clearInnerURLSegments):

  • wtf/url/src/URLUtil.cpp: Added.

(URLUtilities):
(WTF::URLUtilities::IsStandard):
(WTF::URLUtilities::FindAndCompareScheme):
(WTF::URLUtilities::Canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
(WTF::URLUtilities::LowerCaseEqualsASCII):
(WTF::URLUtilities::DecodeURLEscapeSequences):
(WTF::URLUtilities::EncodeURIComponent):
(WTF::URLUtilities::CompareSchemeComponent):

  • wtf/url/src/URLUtil.h: Added.

(URLUtilities):

  • wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.

(URLUtilities):

2:18 PM Changeset in webkit [129411] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Exclusions] ExclusionShape API should use logical coordinates for input/output
​https://bugs.webkit.org/show_bug.cgi?id=96156

Patch by Hans Muller <​hmuller@adobe.com> on 2012-09-24
Reviewed by Dirk Schulze.

Source/WebCore:

Correct how ExclusionShapes deal with logical coordinates and enable
shape-inside exclusion layout for vertical writing-modes.

BasicShape's are defined in physical cooordinates, incoming line and box
dimensions are logical coordinates, and the ExclusionShape internals assume
that lines are aligned with the Y axis. The createExclusionShape() method
is responsible for converting the BasicShape to the internal coordinate
system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
methods are responsible for converting their logical line parameters to Y
values in the internal coordinate system. The min,maxYForLogicalLine()
methods do the conversion, based on the WritingMode the ExclusionShape
was created with. The getInclude,ExcludedIntervals() methods return the
logical left and right edges of line segments. No transformation is needed for this.

The ExclusionShape's internal coordinate system is essentially the
"logical" one, except that top/bottom always map to Y, no matter what
the writing-mode is. This is just to simplify writing geometrical shape
algorithms, notably the complex ones for polygons. The bug report includes a
pair of diagrams that clarify how internal coordinates are related to logical
and physical coordinates.

Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html

  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
(WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.cpp:

(WebCore):
(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(LineSegment):
(WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
(WebCore):
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
(WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
(WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes

  • rendering/WrapShapeInfo.h:

(WebCore):

LayoutTests:

Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.

  • fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.
2:13 PM Changeset in webkit [129410] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Rebaseline for r129389
​https://bugs.webkit.org/show_bug.cgi?id=97473

Unreviewed.

Patch by Alec Flett <​alecflett@chromium.org> on 2012-09-24

  • platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/chromium-mac/fast/text/emphasis-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:
2:11 PM Changeset in webkit [129409] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97475

Reviewed by Ojan Vafai.

Using RenderMeter::computeLogicalHeight is part of bug 96804.
Also fix some code to be vertical writing mode aware. This doesn't actually cause
a behavioral difference because we use percentage heights/widths which don't depend on
updateLogicalWidth or computeLogicalHeight. You can still see bugs if you try to set
the min-width on a <meter> node in a vertical writing mode.

No new tests, no behavioral changes.

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
(WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.

  • rendering/RenderMeter.h:

(RenderMeter):

1:58 PM Changeset in webkit [129408] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

Remove unbaked support for :scope pseudo-class.
​https://bugs.webkit.org/show_bug.cgi?id=97467

Reviewed by Antti Koivisto.

It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
​http://dev.w3.org/csswg/selectors4/#the-scope-pseudo

Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
time/energy to fully implement it.

Source/WebCore:

No new tests, removing half-baked feature.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Ditto.

LayoutTests:

  • fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
  • fast/css/style-scoped/scope-pseudo.html: Removed.
1:47 PM Changeset in webkit [129407] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r129343.
​http://trac.webkit.org/changeset/129343
​https://bugs.webkit.org/show_bug.cgi?id=97479

It broke the build (Requested by Ossy_NIGHT on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

  • Source/api.pri:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
1:34 PM Changeset in webkit [129406] by rniwa@webkit.org
  • 10 edits in trunk/Source

suspend/resumeWidgetHierarchyUpdates should be a RAII object
​https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

  • WebCore.exp.in: Export new symbols.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

1:23 PM Changeset in webkit [129405] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role which hasn't been properly implemented on Windows.

  • platform/win/Skipped:
1:21 PM Changeset in webkit [129404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

1:09 PM Changeset in webkit [129403] by cevans@google.com
  • 1 edit in branches/chromium/1271/Source/WebCore/dom/Document.cpp

Merge 129270
BUG=147700
Review URL: ​https://codereview.chromium.org/10957065

1:07 PM Changeset in webkit [129402] by commit-queue@webkit.org
  • 24 edits
    8 deletes in trunk

Unreviewed, rolling out r129388.
​http://trac.webkit.org/changeset/129388
​https://bugs.webkit.org/show_bug.cgi?id=97477

Caused an assertion in a WebKit2 unit test (Requested by
abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:

(WebCore::CachedImage::stillNeedsLoad):
(CachedImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
  • fast/loader/resources/image1.html: Removed.
  • fast/loader/resources/image2.html: Removed.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
1:06 PM Changeset in webkit [129401] by cevans@google.com
  • 3 edits in branches/chromium/1271/Source/WebCore/rendering

Merge 129144
BUG=145530
Review URL: ​https://codereview.chromium.org/10970075

1:04 PM Changeset in webkit [129400] by arv@chromium.org
  • 8 edits
    10 adds in trunk

DOM4 remove method
​https://bugs.webkit.org/show_bug.cgi?id=73885

Reviewed by Ojan Vafai.

This adds the DOM 4 remove method.

​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove

The remove method removes the node from its parent if it has a parent.

Source/WebCore:

Tests: fast/dom/Comment/remove.html

fast/dom/DocumentType/remove.html
fast/dom/Element/remove.html
fast/dom/Text/remove.html

  • dom/CharacterData.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Node.cpp:

(WebCore::Node::remove): The spec says to do nothing if the node has no parent.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.

LayoutTests:

  • fast/dom/Comment/remove-expected.txt: Added.
  • fast/dom/Comment/remove.html: Added.
  • fast/dom/DocumentType/remove-expected.txt: Added.
  • fast/dom/DocumentType/remove.html: Added.
  • fast/dom/Element/remove-expected.txt: Added.
  • fast/dom/Element/remove.html: Added.
  • fast/dom/Text/remove-expected.txt: Added.
  • fast/dom/Text/remove.html: Added.
12:53 PM Changeset in webkit [129399] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Add Select All method to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=97460

Patch by Simon Pena <Simon Pena> on 2012-09-24
Reviewed by Martin Robinson.

Following the same approach used when added Cut, Copy and Paste,
the Select All method is added to the WebKit2 GTK+ API.

This introduces a new macro in the WebKitEditingCommands,
updates the documentation, and includes a new unit test.

  • UIProcess/API/gtk/WebKitEditingCommands.h: Add a new macro for

the Select All command.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the Select All

command in the documentation.

  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Cover the new command

with a unit test.
(testWebViewEditorSelectAll):
(beforeAll):

12:12 PM Changeset in webkit [129398] by roger_fong@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Removing Windows specific results for fast/text/international/float-as-only-child-of-isolate-crash that were added in ​https://bugs.webkit.org/show_bug.cgi?id=87998.
Test now passes properly.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed.
11:56 AM Changeset in webkit [129397] by tommyw@google.com
  • 8 edits in trunk

MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
​https://bugs.webkit.org/show_bug.cgi?id=97456

Reviewed by Adam Barth.

Renamed onnegotationneeded to onnegotiationneeded.

Source/WebCore:

Existing test updated.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::negotiationNeeded):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • dom/EventNames.h:

(WebCore):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
11:52 AM Changeset in webkit [129396] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
11:49 AM Changeset in webkit [129395] by dominik.rottsches@intel.com
  • 7 edits
    155 adds in trunk

[EFL][DRT] Enable Regions support
​https://bugs.webkit.org/show_bug.cgi?id=83897

Reviewed by Kenneth Rohde Christiansen.

.:

Default build setting for CSS regions set to on.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

Activating CSS regions by default for EWK views.

  • ewk/ewk_view.cpp: Switch CSS regions on by default.

(_ewk_view_priv_new):

LayoutTests:

New baselines for CSS regions, some CSS regions test still in TestExpectations.

  • platform/efl-wk2/TestExpectations: fast/regions/css-regions-disabled.html still failing on wk2.
  • platform/efl/TestExpectations: Some remaining CSS regions cases still skipped.
  • platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/autoheight-regions-mark-expected.png: Added.
  • platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Added.
  • platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Added.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
  • platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
  • platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/flow-anonymous-children-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content2-expected.txt: Added.
  • platform/efl/fast/regions/hit-test-float-expected.txt: Added.
  • platform/efl/fast/regions/hit-test-region-expected.txt: Added.
  • platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
  • platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/moved-content-node-crash-expected.txt: Added.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/no-split-line-box-expected.txt: Added.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Added.
  • platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-element-display-change-expected.txt: Added.
  • platform/efl/fast/regions/region-element-display-restriction-expected.txt: Added.
  • platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/efl/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Added.
  • platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/select-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/svg-root-element-collected-expected.txt: Added.
  • platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/text-region-breaks-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-vertical-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Added.
  • platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/webkit-region-rule-expected.txt: Added.
11:42 AM Changeset in webkit [129394] by peter@chromium.org
  • 3 edits in trunk/Source/WebCore

Android's mock scrollbars shows up as a difference in layout test results
​https://bugs.webkit.org/show_bug.cgi?id=96382

Reviewed by Adam Barth.

Remove the exceptions made for layout tests in Android's scrollbar theme.
This will make our actual scrollbars show up in layout test pixel results,
bringing the tests closer to what we actually ship.

An important difference with other platforms is that scrollbars do not
take any width on Android, they're rendered on top of the content. Therefore
each test that has a visible scrollbar does not just need a new pixel
result, but will also need a new text result. This will be handled as part
of a larger rebaselining process.

Will be exercised by every layout test that has a scrollbar.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h:

(ScrollbarThemeChromiumAndroid):

11:39 AM Changeset in webkit [129393] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. [Win] Failing test http/tests/inspector/network/network-xhr-replay.html
​https://bugs.webkit.org/show_bug.cgi?id=96942

  • platform/win/Skipped: Skipping a test for the newly added feature.
11:34 AM Changeset in webkit [129392] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
​https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Rob Buis.

Fix a mistake of the commit 11fdc73c7c74bbd736ed4160248ff59636a01864
Trunk has been changed during reviewing that patch.

No new tests, this is to correct a build error.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::getProtectionSpace):

11:32 AM Changeset in webkit [129391] by zandobersek@gmail.com
  • 7 edits
    3 adds in trunk

[Gtk] Unskip the Shadow DOM layout tests
​https://bugs.webkit.org/show_bug.cgi?id=90776

Reviewed by Ryosuke Niwa.

Source/WebKit/gtk:

Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Unskip Shadow DOM layout tests, adding two required baselines and failure
expectations for tests that still fail.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
  • platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
11:29 AM Changeset in webkit [129390] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - re-enable IDB test that's now passing.
​https://bugs.webkit.org/show_bug.cgi?id=92776

  • platform/chromium/TestExpectations:
11:18 AM Changeset in webkit [129389] by mitz@apple.com
  • 12 edits in trunk

Source/WebCore: Reverted r129176, the fix for <​http://webkit.org/b/97269>, because it introduced a
discrepancy between line breaking and max width computation.

Rubber-stamped by Anders Carlsson.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests: Reveted r129176 and r129185.

Rubber-stamped by Anders Carlsson.

  • platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/mac/fast/text/emphasis-expected.png:
  • platform/mac/fast/text/emphasis-expected.txt:
  • platform/mac/fast/text/sticky-typesetting-features-expected.png:
  • platform/mac/fast/text/sticky-typesetting-features-expected.txt:
  • platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
  • platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
11:13 AM Changeset in webkit [129388] by commit-queue@webkit.org
  • 24 edits
    8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/resources/image1.html: Added.
  • fast/loader/resources/image2.html: Added.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
10:45 AM Changeset in webkit [129387] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 add
    2 deletes in trunk/Source

[GTK] Implement GraphicsLayer using Clutter
​https://bugs.webkit.org/show_bug.cgi?id=73767

Source/WebCore:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

No new tests. This will be covered by pixel tests for Qt/GTK+ accelerated
compositing and 3D transforms.

  • GNUmakefile.list.am:
  • platform/clutter/GRefPtrClutter.cpp: Removed.
  • platform/clutter/GRefPtrClutter.h: Removed.
  • platform/graphics/clutter/PlatformClutterLayerClient.h: Added.

(WebCore):
(PlatformClutterLayerClient):
(WebCore::PlatformClutterLayerClient::~PlatformClutterLayerClient):

  • platform/graphics/clutter/TransformationMatrixClutter.cpp: Added to convert CoglMatrix to

TransformationMatrix.
(WebCore):
(WebCore::TransformationMatrix::operator CoglMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit/gtk:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
(WebKit):

Source/WebKit2:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

Fixed link errors by adding Clutter library and header to WebKit2 build.

  • GNUmakefile.am:

Source/WTF:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

Add ClutterActor and GraphicsLayerActor to GTypedefs.h.

  • wtf/gobject/GTypedefs.h:
10:18 AM Changeset in webkit [129386] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium linux/windows rebaseline for r129370.

  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
10:17 AM Changeset in webkit [129385] by dgrogan@chromium.org
  • 11 edits
    5 adds in trunk

Unprefix IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=96548

Reviewed by Adam Barth.

Source/WebCore:

We are largely compatible with the FF implementation and the w3c test
suite submitted by MS. The w3c test suite doesn't yet check
for lack of prefix; this is mostly to signal to devs that we think our
implementation is stable.

This patch uses the new FeatureObserver to get data about prefixed
vs unprefixed usage.

Tests: storage/indexeddb/unprefix-workers.html

storage/indexeddb/unprefix.html

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.cpp:

(WebCore::WorkerContextIndexedDatabase::indexedDB):

  • Modules/indexeddb/WorkerContextIndexedDatabase.h:

(WorkerContextIndexedDatabase):

  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • bindings/generic/RuntimeEnabledFeatures.h:

Making the auxiliary objects RuntimeEnabled didn't make much sense as
they are useless without the factory, so always enable them.

(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • page/FeatureObserver.h:

LayoutTests:

  • storage/indexeddb/resources/unprefix.js: Added.

(test):

  • storage/indexeddb/unprefix-expected.txt: Added.
  • storage/indexeddb/unprefix-workers-expected.txt: Added.
  • storage/indexeddb/unprefix-workers.html: Added.
  • storage/indexeddb/unprefix.html: Added.
10:10 AM Changeset in webkit [129384] by wjmaclean@chromium.org
  • 34 edits in trunk/LayoutTests

[chromium] Rebaseline gesture highlight test expectation images.
​https://bugs.webkit.org/show_bug.cgi?id=97248

Reviewed by Yuta Kitamura.

Updating image baselines for gesture highlight tests. There are subtle changes in the rendering of
text in the target links, impercetable to the eye but ImageDiff picks them up.

  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png:
9:59 AM Changeset in webkit [129383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script
​https://bugs.webkit.org/show_bug.cgi?id=96746

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

First step towards the 2D canvas instrumentation from the WebGL injected script module side.
We trace and save all calls that affect the 2D canvas context state and it's resources (Gradient and Pattern)
so that we could replay the context and resources states later.
The 2D canvas context state consists of:

  • current transformation matrix
  • current default path
  • current clipping region (affected by the "clip" command)
  • current values of the context attributes (like strokeStyle, fillStyle, etc.)
  • a stack of saved drawing states (affected by the "save" and "restore" commands)
  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

9:36 AM Changeset in webkit [129382] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Skip a few tests unskipped in r129372 and r129375 that still fail
on the bots.

  • platform/efl/TestExpectations:
9:36 AM Changeset in webkit [129381] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time
​https://bugs.webkit.org/show_bug.cgi?id=97442

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

1) The conditional breakpoint popup may not show up the first time we click on the gutter.
This was the case because the popup decoration element would be deleted from the line while
it was being highlighted and appended afterwards. Now we do not remove decorations from the
DOM while highlighting.

2) Also the popup will close itself on any mouse click event, even if it's targeted to the
input box itself. This was due to pointer-events: none; CSS style for the parent element.
Now we just override this style for the input box.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._insertTextNodeBefore):

  • inspector/front-end/inspector.css:

(.source-frame-breakpoint-condition):

9:32 AM Changeset in webkit [129380] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link clicked navigation action
​https://bugs.webkit.org/show_bug.cgi?id=97458

Reviewed by Xan Lopez.

WebKitWebView:is-loading is set to TRUE when the load is started
by using the API. We want to make sure that both URI and
is-loading are updated before load-started is emitted, so we can
update both right before emitting load-started.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewEmitLoadChanged): Update both uri and is-loading
properties before emitting load-changed signal with
WEBKIT_LOAD_STARTED.
(webkit_web_view_load_uri): Don't call
webkitWebViewSetIsLoading().
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

9:25 AM Changeset in webkit [129379] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move some inspector tests from Skipped to TestExpectations with a
proper explanation and related bug report.

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
9:19 AM Changeset in webkit [129378] by jsbell@chromium.org
  • 5 edits in trunk/LayoutTests

IndexedDB: Modernize some esoteric tests
​https://bugs.webkit.org/show_bug.cgi?id=97368

Reviewed by Tony Chang.

Change the logging - but not the flow or assertions - of some of our
more complex tests, to take advantage of our newer helper functions.

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/resources/factory-deletedatabase-interactions.js:
  • storage/indexeddb/resources/open-close-version.js:
9:15 AM Changeset in webkit [129377] by eae@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed chromium rebaseline for video-zoom-controls for r129370.

  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
9:02 AM Changeset in webkit [129376] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move a test that is failing on both WK1 and WK2 to the common
TestExpectations file.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:58 AM Changeset in webkit [129375] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Unskip passing inspector test.
8:58 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
8:47 AM Changeset in webkit [129374] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command
​https://bugs.webkit.org/show_bug.cgi?id=97331

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

8:46 AM Changeset in webkit [129373] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Add setters to WebFilterOperation for IPC pickling
​https://bugs.webkit.org/show_bug.cgi?id=97147

Reviewed by James Robinson.

Source/Platform:

These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.

Test: WebFilterOperationsTest.saveAndRestore

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):

  • chromium/src/WebFilterOperation.cpp:

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

8:44 AM Changeset in webkit [129372] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/Skipped: Unskip a few inspector-related tests which

are currently passing.

8:38 AM Changeset in webkit [129371] by Patrick Gansterer
  • 4 edits in trunk/Source

Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
​https://bugs.webkit.org/show_bug.cgi?id=97412

Reviewed by Adam Barth.

Source/WebCore:

  • css/StylePropertySet.cpp: Removed useless define.

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
(WebKit::WebPageSerializerImpl::endTagToString): Ditto.

8:35 AM Changeset in webkit [129370] by eae@chromium.org
  • 14 edits
    2 adds in trunk

snapToSize rounds the incorrectly for negative locations
​https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

  • platform/FractionalLayoutUnit.h:

(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

  • fast/sub-pixel/snap-negative-location-expected.html: Added.
  • fast/sub-pixel/snap-negative-location.html: Added.
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
8:33 AM Changeset in webkit [129369] by peter@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Allow robots to index bugs on Bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=95688

Reviewed by Eric Seidel.

This allows robots to access show_bug.cgi, thus granting them access to
index contents and discussion on WebKit bugs. All other pages, except
for the site index itself, still have indexing disabled.

  • robots.txt:
8:09 AM Changeset in webkit [129368] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorOverlay.cpp

Merge 129350 - Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

TBR=​pfeldman@chromium.org
BUG=151559
Review URL: ​https://chromiumcodereview.appspot.com/10967070

8:05 AM Changeset in webkit [129367] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

MIPS: store8 functions added to MacroAssembler.

MIPS store8 functions
​https://bugs.webkit.org/show_bug.cgi?id=97243

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2012-09-24
Reviewed by Oliver Hunt.

Add MIPS store8 functions.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lhu): New function.
(MIPSAssembler):
(JSC::MIPSAssembler::sb): New function.
(JSC::MIPSAssembler::sh): New function.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8): New function.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::store16): New function.

7:53 AM Changeset in webkit [129366] by zandobersek@gmail.com
  • 4 edits
    1 delete in trunk

REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=97404

Reviewed by Philippe Normand.

Tools:

Print out the 'didReceiveTitle' information when dumping frame load callbacks.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewTitleChanged):

LayoutTests:

Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.
7:40 AM Changeset in webkit [129365] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use unsigned char for bitfield instead of unsigned.
​https://bugs.webkit.org/show_bug.cgi?id=97447

Patch by Jonathan Liu <​net147@gmail.com> on 2012-09-24
Reviewed by Andreas Kling.

Not all compilers will pad an unsigned bitfield to the smallest size.
Use unsigned char instead of unsigned to reduce padding for compilers
that pad to the underlying type.

No new tests. There is already a compile-time assertion.

  • css/CSSRule.cpp:

(SameSizeAsCSSRule):

  • css/CSSRule.h:

(CSSRule):

7:29 AM BuildingQtOnWindows edited by zeno@webkit.org
Add some information on how to create a sparse-checkout of the WebKit repo. (diff)
7:28 AM Changeset in webkit [129364] by commit-queue@webkit.org
  • 68 edits
    6 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97452

Unreviewed EFL rebaseline.

Rebaseline several test cases in the EFL Skipped file
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/efl/fast/text/basic/011-expected.png:
  • platform/efl/fast/text/basic/011-expected.txt:
  • platform/efl/fast/text/basic/013-expected.png:
  • platform/efl/fast/text/basic/013-expected.txt:
  • platform/efl/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/efl/fast/text/capitalize-boundaries-expected.png:
  • platform/efl/fast/text/capitalize-boundaries-expected.txt:
  • platform/efl/fast/text/cg-fallback-bolding-expected.png:
  • platform/efl/fast/text/drawBidiText-expected.png:
  • platform/efl/fast/text/emphasis-vertical-expected.png:
  • platform/efl/fast/text/emphasis-vertical-expected.txt:
  • platform/efl/fast/text/fallback-traits-fixup-expected.png:
  • platform/efl/fast/text/fallback-traits-fixup-expected.txt:
  • platform/efl/fast/text/firstline/001-expected.png:
  • platform/efl/fast/text/firstline/001-expected.txt:
  • platform/efl/fast/text/firstline/002-expected.png:
  • platform/efl/fast/text/firstline/003-expected.png:
  • platform/efl/fast/text/format-control-expected.png:
  • platform/efl/fast/text/format-control-expected.txt:
  • platform/efl/fast/text/hyphens-expected.png:
  • platform/efl/fast/text/hyphens-expected.txt:
  • platform/efl/fast/text/in-rendered-text-rtl-expected.png:
  • platform/efl/fast/text/international/001-expected.png:
  • platform/efl/fast/text/international/001-expected.txt:
  • platform/efl/fast/text/international/002-expected.png:
  • platform/efl/fast/text/international/002-expected.txt:
  • platform/efl/fast/text/international/003-expected.png:
  • platform/efl/fast/text/international/003-expected.txt:
  • platform/efl/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/efl/fast/text/international/bidi-european-terminators-expected.png:
  • platform/efl/fast/text/international/bidi-explicit-embedding-expected.png:
  • platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/efl/fast/text/international/bidi-innertext-expected.png:
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-listbox-expected.png:
  • platform/efl/fast/text/international/bidi-listbox-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-override-expected.png:
  • platform/efl/fast/text/international/bidi-override-expected.txt: Added.
  • platform/efl/fast/text/international/rtl-caret-expected.png:
  • platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/efl/fast/text/international/wrap-CJK-001-expected.png:
  • platform/efl/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/efl/fast/text/midword-break-hang-expected.png:
  • platform/efl/fast/text/midword-break-hang-expected.txt:
  • platform/efl/fast/text/trailing-white-space-2-expected.png:
  • platform/efl/fast/text/trailing-white-space-expected.png:
  • platform/efl/fast/text/whitespace/024-expected.png:
  • platform/efl/fast/text/whitespace/024-expected.txt:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.png:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt:
7:24 AM Changeset in webkit [129363] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/platform/text/LocaleICU.cpp

Merge 129191 - [Platform] There are memory leak in LocaleICU
​https://bugs.webkit.org/show_bug.cgi?id=97289

Reviewed by Kent Tamura.

This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.

This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(​http://crbug.com/151006) with stack trace of
call path of leaked memory.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. External tool such as Valgrind will check this memory leak.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10958068

7:17 AM Changeset in webkit [129362] by apavlov@chromium.org
  • 2 edits in branches/chromium/1271/Source/WebCore/inspector/front-end

Merge 129348 - Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10963058

7:10 AM Changeset in webkit [129361] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't allow exception in front-end when expanding function scope
​https://bugs.webkit.org/show_bug.cgi?id=97346

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

A missing guard condition is added.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

7:02 AM Changeset in webkit [129360] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/Resources/pagepopups/calendarPicker.js

Merge 129094 - REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
​https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10956071

7:01 AM Changeset in webkit [129359] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip new failing test.
​https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-24

  • platform/qt/Skipped: Skip inspector-protocol/css-getSupportedCSSProperties.html.
6:51 AM Changeset in webkit [129358] by kareng@chromium.org
  • 5 edits in branches/chromium/1271

Merge 128982 - MediaStream API: Rename the RTCIceServer uri parameter to url.
​https://bugs.webkit.org/show_bug.cgi?id=97086

Reviewed by Hajime Morita.

Source/WebCore:

Either the standard has changed or I can't read.
​http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members

Existing tests changed to cover this patch.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection.html:
  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:

TBR=​tommyw@google.com
Review URL: ​https://codereview.chromium.org/10969068

6:39 AM Changeset in webkit [129357] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/forms/select/select-state-restore.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=97449

Unreviewed EFL gardening.

fast/forms/select/select-state-restore.html sometimes times out on
the WebKit2 EFL debug build bot. Add it to TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl-wk2/TestExpectations:
6:34 AM Changeset in webkit [129356] by anilsson@rim.com
  • 13 edits
    2 adds in trunk/Source

[BlackBerry] Add cookie database API
​https://bugs.webkit.org/show_bug.cgi?id=97102

Reviewed by Antonio Gomes.

Source/WebCore:

Add a CookieManager method that takes a list of strings to parse
instead of just one string. Expose CookieParser::parseOneCookie.

Reviewed internally by Otto D. Cheung.

No change in behavior, no new tests.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):
(WebCore):

  • platform/blackberry/CookieParser.h:

(CookieParser):

Source/WebKit:

Add cookie database file to build system.

Reviewed internally by Otto D. Cheung.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The cookie database is exposed through WebCookieJar, which has only two
methods: cookies() and setCookies().

Also add a new WebString::fromUTF8 overload that takes a const char*
and a length, in order to avoid a strlen call when converting from
other string classes to WebString. This is useful for callers of the
new cookie API when converting cookies to WebString.

Reviewed internally by Otto D. Cheung.

PR 209282

  • Api/WebCookieJar.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebCookieJar::WebCookieJar):
(BlackBerry::WebKit::WebCookieJar::cookies):
(BlackBerry::WebKit::WebCookieJar::setCookies):

  • Api/WebCookieJar.h: Added.

(WebKit):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::cookieJar):
(WebKit):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebKit):
(WebPagePrivate):

  • Api/WebString.cpp:

(BlackBerry::WebKit::WebString::fromUtf8):
(WebKit):

  • Api/WebString.h:
6:17 AM Changeset in webkit [129355] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Open resource dialog has too many false positive matches.
​https://bugs.webkit.org/show_bug.cgi?id=97332

Reviewed by Alexander Pavlov.

Source/WebCore:

Improved open resource dialog filtering to make the amount of false
positive search results less.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
6:14 AM Changeset in webkit [129354] by commit-queue@webkit.org
  • 47 edits
    49 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97448

Unreviewed EFL rebaseline.

Rebaseline several test cases in the Skipped file and unskip
them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-expected.txt:
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt:
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/efl/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/efl/svg/as-image/same-image-two-instances-expected.txt:
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.txt:
  • platform/efl/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/efl/svg/batik/masking/maskRegions-expected.txt:
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.png: Added.
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt:
  • platform/efl/svg/dom/css-transforms-expected.png: Added.
  • platform/efl/svg/dom/css-transforms-expected.txt: Added.
  • platform/efl/svg/hixie/error/012-expected.png: Added.
  • platform/efl/svg/hixie/error/012-expected.txt:
  • platform/efl/svg/hixie/error/013-expected.png: Added.
  • platform/efl/svg/hixie/error/013-expected.txt:
  • platform/efl/svg/hixie/mixed/003-expected.png: Added.
  • platform/efl/svg/hixie/mixed/003-expected.txt:
  • platform/efl/svg/hixie/mixed/004-expected.png: Added.
  • platform/efl/svg/hixie/mixed/004-expected.txt:
  • platform/efl/svg/hixie/mixed/005-expected.png: Added.
  • platform/efl/svg/hixie/mixed/005-expected.txt:
  • platform/efl/svg/hixie/mixed/006-expected.png: Added.
  • platform/efl/svg/hixie/mixed/006-expected.txt:
  • platform/efl/svg/hixie/mixed/007-expected.png: Added.
  • platform/efl/svg/hixie/mixed/007-expected.txt:
  • platform/efl/svg/hixie/mixed/008-expected.png: Added.
  • platform/efl/svg/hixie/mixed/008-expected.txt:
  • platform/efl/svg/hixie/mixed/009-expected.png: Added.
  • platform/efl/svg/hixie/mixed/009-expected.txt:
  • platform/efl/svg/hixie/mixed/010-expected.png: Added.
  • platform/efl/svg/hixie/mixed/010-expected.txt:
  • platform/efl/svg/hixie/mixed/011-expected.png: Added.
  • platform/efl/svg/hixie/mixed/011-expected.txt:
  • platform/efl/svg/hixie/perf/007-expected.png: Added.
  • platform/efl/svg/hixie/perf/007-expected.txt:
  • platform/efl/svg/hixie/processing-model/003-expected.png: Added.
  • platform/efl/svg/hixie/processing-model/003-expected.txt:
  • platform/efl/svg/hixie/processing-model/004-expected.png: Added.
  • platform/efl/svg/hixie/processing-model/004-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/hixie/rendering-model/004-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/004-expected.txt:
  • platform/efl/svg/hixie/text/003-expected.png: Added.
  • platform/efl/svg/hixie/text/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.png: Added.
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/svg/in-html/circle-expected.png: Added.
  • platform/efl/svg/in-html/circle-expected.txt:
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/efl/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt:
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/efl/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt:
  • platform/efl/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/efl/svg/wicd/test-rightsizing-a-expected.txt:
  • platform/efl/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.txt:
6:01 AM Changeset in webkit [129353] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
​https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

5:31 AM Changeset in webkit [129352] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so.
​https://bugs.webkit.org/show_bug.cgi?id=97302

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

libewk2UnitTestInjectedBundleSample.so file is created under the
Source directory.
Change install directory for the library to under the build directory.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):

5:20 AM Changeset in webkit [129351] by apavlov@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/inspector/front-end/inspector.css

Merge 129117 - Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
​https://bugs.webkit.org/show_bug.cgi?id=97185

Reviewed by Pavel Feldman.

Restored the effective "white-space: nowrap" for the tree elements.

  • inspector/front-end/inspector.css:

(.nowrap):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10975002

5:14 AM Changeset in webkit [129350] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

5:09 AM Changeset in webkit [129349] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip proper shadow dom test case
​https://bugs.webkit.org/show_bug.cgi?id=97445

Unreviewed EFL gardening.

Skip again fast/dom/shadow/shadowdom-for-object-without-shadow.html
and unskip fast/dom/shadow/shadowdom-for-object-only-shadow.html
instead.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/TestExpectations:
4:55 AM Changeset in webkit [129348] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

4:53 AM Changeset in webkit [129347] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Disable persistence of master switches in the "Overrides" settings tab
​https://bugs.webkit.org/show_bug.cgi?id=97440

Reviewed by Yury Semikhatsky.

Disables enforcement of device metrics, geolocation, and device orientation overrides on Web Inspector start.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._onMetricsCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onDeviceOrientationOverrideCheckboxClicked):

  • inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleDeviceMetricsOverride):
(WebInspector.UserAgentSupport.prototype.toggleGeolocationPositionOverride):
(WebInspector.UserAgentSupport.prototype.toggleDeviceOrientationOverride):

  • inspector/front-end/externs.js:
4:38 AM Changeset in webkit [129346] by commit-queue@webkit.org
  • 13 edits
    8 adds in trunk

Web Inspector: implement testing harness for pure protocol tests.
​https://bugs.webkit.org/show_bug.cgi?id=90675

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

.:

Added export symbols required for Gtk+ to support the Inspector Protocol
testing harness.

  • Source/autotools/symbols.filter:

Source/WebCore:

Implementing the testing harness as the APIs of Internals object not
only reduced platform specific patching of DRTs but also minimized the
the effort required to open up the new dummy inspector Frontend.

The openDummyInspectorFrontend method will return the handle to newly
created DOMWindow. This DOMWindow object can be utilized inside the test
case to communicate using postMessage WebAPI.

The newly created DOMWindow will host the protocol-test.html which
will seed the necessary JS libraries to communicate with the
InspectorBackend.

Test: inspector-protocol/css-getSupportedCSSProperties.html

  • WebCore.exp.in:
  • WebCore.gypi:
  • inspector/InspectorClient.h:

(InspectorClient):

  • testing/Internals.cpp:

(InspectorFrontendClientDummy):
(WebCore::InspectorFrontendClientDummy::~InspectorFrontendClientDummy):
(WebCore):
(WebCore::InspectorFrontendClientDummy::InspectorFrontendClientDummy):
(InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::~InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Adding the export symbol definitions required on Apple Windows and WinCairo
ports to support Inspector Protocol testing harness.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Adding the resources required for the dummy frontend page to load minimal
frontend. These resources provide the mechanism to talk to the Inspector Backend.

Adding the inspector-protocol folder to host the relevant test cases
utilizing the inspector protocol test harness. Added an example test
case for getting all supported CSS properties using the inspector
protocol and searching for a particular property being supported.

  • http/tests/inspector-protocol: Added.
  • http/tests/inspector-protocol/resources: Added.
  • http/tests/inspector-protocol/resources/InspectorTest.js: Added.

(InspectorTest.sendCommand):
(WebInspector.dispatchMessageFromBackend):
(InspectorTest.log):
(InspectorTest.completeTest):

  • http/tests/inspector-protocol/resources/protocol-test.html: Added.
  • http/tests/inspector-protocol/resources/protocol-test.js: Added.

(log):
(closeTest):
(runTest):

  • inspector-protocol: Added.
  • inspector-protocol/css-getSupportedCSSProperties-expected.txt: Added.
  • inspector-protocol/css-getSupportedCSSProperties.html: Added.
4:19 AM Changeset in webkit [129345] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.10.0

Tagging the WebKitGTK+ 1.10.0 release

4:08 AM Changeset in webkit [129344] by keishi@webkit.org
  • 5 edits in trunk

REGRESSION(r127727): Calendar picker focus doesn't loop in calendar-picker.html
​https://bugs.webkit.org/show_bug.cgi?id=97183

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug calendar-picker.html. The page popup behaves fine because
this code is only necessary in calendar-picker.html where the focus can
move outside of the picker because we are just using an iframe.

No new tests. Added tests to calendar-picker-key-operations.html.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype.attachTo):
(CalendarPicker.prototype._handleBodyKeyDown):

LayoutTests:

  • fast/forms/date/calendar-picker-key-operations-expected.txt:
  • fast/forms/date/calendar-picker-key-operations.html:
4:07 AM Changeset in webkit [129343] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build with latest Qt 5

Reviewed by Tor Arne Vestbø.

.:

Define MODULE_BASE_DIR before loading qt_module.prf, which now calls syncqt. MODULE_BASE_DIR is
passed as last parameter (source dir) to syncqt now, so set it to the directory that contains
sync.profile.

  • Source/api.pri:

Tools:

The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
remove them from default_pre.prf once we're past Qt 5 beta2.

  • qmake/mkspecs/features/default_pre.prf:
4:03 AM Changeset in webkit [129342] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.10.0 release

3:19 AM Changeset in webkit [129341] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed follow-up to r129336 -- fixed closure compiler warnings.

  • inspector/front-end/HAREntry.js:
  • inspector/front-end/TimelineModel.js:
3:15 AM Changeset in webkit [129340] by yurys@chromium.org
  • 19 edits
    12 deletes in trunk/LayoutTests

Unreviewed. Update pixel results for 18 tests on Win.

  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Removed.
  • platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/text/textshadow-002-expected.png: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/text/textshadow-010-expected.png: Removed.
  • platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Removed.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
2:39 AM Changeset in webkit [129339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor
​https://bugs.webkit.org/show_bug.cgi?id=96510

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Vsevolod Vlasov.

Sync line heights on adding/removing decorations.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

2:38 AM Changeset in webkit [129338] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Invalid featuring of INPUT_TYPE_COLOR in test_ewk2_view.
​https://bugs.webkit.org/show_bug.cgi?id=97430

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

The tests of ewk_view_context_get and ewk_view_feed_touch_event are not related to
INPUT_TYPE_COLOR. These tests should be moved to outside of INPUT_TYPE_COLOR block.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

2:38 AM Changeset in webkit [129337] by yurys@chromium.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r122243.
​http://trac.webkit.org/changeset/129243
​https://bugs.webkit.org/show_bug.cgi?id=97441

WebFilterOperationsTest.saveAndRestore added in the change is failing.

Source/Platform:

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:
2:23 AM Changeset in webkit [129336] by caseq@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: support saving HAR with resources content
​https://bugs.webkit.org/show_bug.cgi?id=97341

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • add WebInspector.HARWriter that writes HAR with content to a stream;
  • replace Save all as HAR with Save all with Content as HAR in network's panel context menu;
  • remove entries for copying/saving of individual request items to reduce clutter in context menu;
  • a drive-by fix of an exception when invoking context menu not on a network item;

Test: http/tests/inspector/network/har-content.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FileUtils.js:
  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._creator):
(WebInspector.HARWriter):
(WebInspector.HARWriter.prototype.write):
(WebInspector.HARWriter.prototype._onContentAvailable):
(WebInspector.HARWriter.prototype._beginWrite):
(WebInspector.HARWriter.prototype._writeNextChunk):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createStatusBarItems):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll.openCallback):
(WebInspector.NetworkLogView.prototype._exportAll):

LayoutTests:

  • moved StringOutputStream to inspector-test.js for reuse;
  • added test for HARWriter and response content in HAR.
  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):
(initialize_InspectorTest.):

  • http/tests/inspector/network/har-content-expected.txt: Added.
  • http/tests/inspector/network/har-content.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline):

2:15 AM Changeset in webkit [129335] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations for webaudio/biquad-getFrequencyResponse.html

  • platform/chromium/TestExpectations:
1:56 AM Changeset in webkit [129334] by commit-queue@webkit.org
  • 29 edits
    30 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97437

Unreviewed EFL rebaseline.

Rebaseline several test cases from EFL Skipped list
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/efl/svg/batik/text/textOnPath-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPath-expected.txt:
  • platform/efl/svg/batik/text/textProperties2-expected.png: Added.
  • platform/efl/svg/batik/text/textProperties2-expected.txt:
  • platform/efl/svg/hixie/perf/004-expected.png: Added.
  • platform/efl/svg/hixie/perf/005-expected.png: Added.
  • platform/efl/svg/hixie/perf/006-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
1:34 AM Changeset in webkit [129333] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip test cases that started passing after r129303
​https://bugs.webkit.org/show_bug.cgi?id=97433

Unreviewed EFL gardening.

Unskip several ref tests that are marked as unexpected
passes after r129303. r129303 fixed detection of ref
tests that are passing unexpectedly.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/TestExpectations:
1:34 AM Changeset in webkit [129332] by thakis@chromium.org
  • 1 edit
    2 deletes in trunk/Source/WebCore

[chromium] Remove BitLockerSkia. It's apparently not used.
​https://bugs.webkit.org/show_bug.cgi?id=97434

Reviewed by Kent Tamura.

  • platform/graphics/skia/BitLockerSkia.cpp: Removed.
  • platform/graphics/skia/BitLockerSkia.h: Removed.
1:10 AM MinimalFileStorageAlternate edited by mjs@apple.com
(diff)
12:53 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
12:49 AM MinimalFileStorageAlternate created by mjs@apple.com
12:47 AM Changeset in webkit [129331] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10

Merge r126439 - [GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
​https://bugs.webkit.org/show_bug.cgi?id=94572

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-08-23
Reviewed by Carlos Garcia Campos.

Change the name of the tarball to match the name of the library
and to disambiguate it from other WebKit ports.

  • configure.ac: Update the tarball name.
12:41 AM Changeset in webkit [129330] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Skeleton implementation of dialog.showModal()
​https://bugs.webkit.org/show_bug.cgi?id=97425

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-09-24
Reviewed by Kent Tamura.

Source/WebCore:

This adds a basic implementation of showModal(), so it later can be
used to test the top layer, once it is implemented. The main features
of showModal(), modality and the top layer, are not yet implemented.

Test: fast/dom/HTMLDialogElement/dialog-show-modal.html

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::showModal): The same as show(), but throws an error in the cases specified in the spec.
(WebCore):

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • html/HTMLDialogElement.idl:

LayoutTests:

Add a test that showModal() opens the dialog or throws an error in the cases specified in the spec.

  • fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-show-modal.html: Added.
12:24 AM Changeset in webkit [129329] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Regression after r129328
​https://bugs.webkit.org/show_bug.cgi?id=97429

Unreviewed, rolling out r129328.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

Sep 23, 2012:

11:28 PM Changeset in webkit [129328] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Duplicated RenderThemeEfl creation for same page
​https://bugs.webkit.org/show_bug.cgi?id=88391

Reviewed by Gyuyoung Kim.

Other ports return one or two RenderTheme regardless of page.
But, WebKit/Efl can create different theme for each page and
themeForPage creates new RenderTheme whenever it is called with page.
So more than one RenderTheme can be created for a page.

This patches checks whether page already has RenderTheme not to create new
RenderTheme for same page.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

11:27 PM Changeset in webkit [129327] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add setting to toggle developer extensions
​https://bugs.webkit.org/show_bug.cgi?id=96974

Patch by Seokju Kwon <​seokju.kwon@samsung.com> on 2012-09-23
Reviewed by Kenneth Rohde Christiansen.

This is required to allow the user to inspect pages. (Web inspector)

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

9:39 PM Changeset in webkit [129326] by keishi@webkit.org
  • 8 edits
    2 adds in trunk

Add suggestionPicker to CalendarPicker
​https://bugs.webkit.org/show_bug.cgi?id=97201

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added tests for SuggestionPicker.

Source/WebCore:

This adds the suggestionPicker to CalendarPicker. It is not available yet as a datalist UI but it can be used inside ManualTests/forms/calendar-picker.html.

No new tests. Suggestion Picker can be tested in ManualTests/forms/calendar-picker.html.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(openSuggestionPicker):

  • Resources/pagepopups/pickerCommon.js:

(enclosingNodeOrSelfWithClass):

  • Resources/pagepopups/suggestionPicker.css: Added.

(.suggestion-list):
(.suggestion-list-entry):
(.suggestion-list-entry:focus):
(.suggestion-list-entry:focus .label):
(.suggestion-list-entry .content):
(.suggestion-list-entry .title):
(.suggestion-list-entry .label):
(.measuring-width .suggestion-list-entry .label):
(.suggestion-list .separator):

  • Resources/pagepopups/suggestionPicker.js: Added.

(SuggestionPicker):
(SuggestionPicker.validateConfig):
(SuggestionPicker.prototype.cleanup):
(SuggestionPicker.prototype._setColors): Creates css rules that sets highlight colors.
(SuggestionPicker.prototype._createSuggestionEntryElement): Creates an entry that when selected submits the value.
(SuggestionPicker.prototype._createActionEntryElement): Creates an entry that causes an action. (e.x. "Other...")
(SuggestionPicker.prototype._measureMaxContentWidth): Temporarily left align everything to measure the width.
(SuggestionPicker.prototype._fixWindowSize):
(SuggestionPicker.prototype._layout):
(SuggestionPicker.prototype.selectEntry):
(SuggestionPicker.prototype._handleEntryClick):
(SuggestionPicker.prototype._findFirstVisibleEntry):
(SuggestionPicker.prototype._findLastVisibleEntry):
(SuggestionPicker.prototype._handleBodyKeyDown):
(SuggestionPicker.prototype._handleEntryMouseOver):
(SuggestionPicker.prototype._handleMouseOut):

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.

8:47 PM Changeset in webkit [129325] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PutScopedVar should not be marked as clobbering the world
​https://bugs.webkit.org/show_bug.cgi?id=97416

Reviewed by Filip Pizlo.

No performance change.

PutScopedVar doesn't have arbitrary side-effects, so it shouldn't be marked
as such.

  • dfg/DFGNodeType.h:

(DFG):

8:35 PM Changeset in webkit [129324] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-23 Geoffrey Garen <​ggaren@apple.com>

I accidentally the whole 32-bit :(.

Unbreak the DFG in 32-bit with the 32-bit path I forgot in my last patch.

  • dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
8:33 PM Changeset in webkit [129323] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r128239): Mutable ElementAttributeData leak their Attribute vectors.
<​http://webkit.org/b/97423>

Reviewed by Anders Carlsson.

r128239 added a WTF::deleteOwnedPtr() override for ElementAttributeData*, but ElementAttributeData is
a ref-counted object. Fixed this by overriding deref() instead to call the appropriate subclass destructor.

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::deref):

8:28 PM Changeset in webkit [129322] by keishi@webkit.org
  • 3 edits
    2 copies in branches/chromium/1271

Merge 129106 - REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=97166

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug in r127727 so arrow keys work properly.

Test: fast/forms/date/calendar-picker-key-operations.html

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

  • fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
  • fast/forms/date/calendar-picker-key-operations.html: Added.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10968055

7:29 PM Changeset in webkit [129321] by yosin@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/html/TimeInputType.cpp

Merge 129095 - [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
​https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10957058

6:16 PM Changeset in webkit [129320] by tkent@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=96352

Reviewed by Adam Barth.

We have some crash reports with the following stack:

  • HistoryItem::shouldDoSameDocumentNavigationTo.
  • WebFrameImpl::loadHistoryItem ...

We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/10959062

6:02 PM Changeset in webkit [129319] by commit-queue@webkit.org
  • 20 edits in trunk/Source

Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
​https://bugs.webkit.org/show_bug.cgi?id=97306

Patch by Byungwoo Lee <​bw80.lee@gmail.com> on 2012-09-23
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Fix build warning about -Wunused-parameter on MachineStackMarker.cpp,
LLIntSlowPaths.cpp, DatePrototype.cpp, Options.cpp by using
UNUSED_PARAM() macro or remove parameter name.

  • heap/MachineStackMarker.cpp:

(JSC::pthreadSignalHandlerSuspendResume):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

  • runtime/Options.cpp:

(JSC::computeNumberOfGCMarkers):

Source/WebCore:

Fix build warning about -Wunused-parameter on ImageBufferCairo.cpp,
ImageDecoder.h by using ASSERT_UNUSED() macro.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::encodeImage):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::rgbColorProfile):
(WebCore::ImageDecoder::inputDeviceColorProfile):

Source/WebKit/efl:

Fix build warning about -Wunused-parameter on FrameLoaderClientEfl.cpp
by using ASSERT_UNUSED() macro.
Fix build warning aboug -Wparentheses on ewk_frame.cpp by adding
additional brace for the assign statement.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):

  • ewk/ewk_frame.cpp:

(ewk_frame_resources_location_get):

Source/WebKit2:

Fix build warning about -Wunused-parameter on Connection.cpp,
WKEinaSharedString.cpp, ewk_view_loader_client.cpp, WebPage.cpp by
using ASSERT_UNUSED() macro or removing parameter name.
Fix build warning about -Wuninitialized on WebEventFactory.cpp by
continueing the loop at the default switch case not to use the
uninitialized variable.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::WKEinaSharedString):

  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didSameDocumentNavigationForFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):

Source/WTF:

Fix build warning about -Wunused-parameter on FastMalloc.cpp,
OSAllocatorPosix.cpp by using UNUSED_PARAM() macro.
Fix header including order of FastMalloc.cpp.

  • wtf/FastMalloc.cpp:

(WTF::fastMallocSize):

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

5:57 PM Changeset in webkit [129318] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Enable ElementAttributeData sharing for non-HTML elements.
<​http://webkit.org/b/97413>

Reviewed by Anders Carlsson.

Use the whole qualified tag name when creating the ElementAttributeData cache key
instead of just the localName(). This allows sharing and caching of attribute data
for non-HTML elements and makes the code a little cleaner.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Enable the ElementAttributeData sharing path for non-HTML elements.

  • dom/ElementAttributeData.h:

Make immutableAttributeArray() public so Document can call it instead of getting
the raw data address from a const_cast'ed attributeItem(0).

  • dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheEntry::ImmutableAttributeDataCacheEntry):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

Let the immutable attribute data cache use a QualifiedName/attributes key
instead of the AtomicString/attributes we were using before. We still grab the
existingHash() from the QualifiedName::localName() and use that for the actual
HashMap key.

4:37 PM Changeset in webkit [129317] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Sorting a non-array creates propreties (spec-violation)
​https://bugs.webkit.org/show_bug.cgi?id=25477

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We're just calling get() to get properties, which is converting missing properties to
undefined. Hole values should be retained, and moved to the end of the array.

  • runtime/ArrayPrototype.cpp:

(JSC::getOrHole):

  • Helper function, returns JSValue() instead of undefined for missing properties.

(JSC::arrayProtoFuncSort):

  • Implemented per 15.4.4.11, see comments above.

LayoutTests:

Added test cases.

  • fast/js/array-sort-sparse-expected.txt: Added.
  • fast/js/array-sort-sparse.html: Added.
  • fast/js/script-tests/array-sort-sparse.js: Added.

(testSort):

3:48 PM Changeset in webkit [129316] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

CSE for access to closure variables (get_/put_scoped_var)
​https://bugs.webkit.org/show_bug.cgi?id=97414

Reviewed by Oliver Hunt.

I separated loading a scope from loading its storage pointer, so we can
CSE the storage pointer load. Then, I copied the global var CSE and adjusted
it for closure vars.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute): Renamed GetScopeChain => GetScope to
reflect renames from a few weeks ago.

Added a case for the storage pointer load, similar to object storage pointer load.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added an independent node for
the storage pointer.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getScopeLoadElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE): Copied globalVarLoad/StoreElimination
and adapted the same logic to closure vars.

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scope):
(Node):

  • dfg/DFGNodeType.h:

(DFG): GetScopedVar and GetGlobalVar are no longer MustGenerate. I'm not
sure why they ever were. But these are simple load operations so, if they're
unused, they're truly dead.

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Updated for renames and split-out
node for getting the storage pointer.

10:37 AM Changeset in webkit [129315] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Measure the usage of the "X-WebKit-CSP" header in the hopes of dropping the prefix completely.
​https://bugs.webkit.org/show_bug.cgi?id=97408

Patch by Mike West <​mkwst@chromium.org> on 2012-09-23
Reviewed by Adam Barth.

We plan on landing the unprefixed header in webkit.org/b/96765 once the
spec moves to CR. Though we plan to use it for experimentation in the
near future, we'll want to drop the prefixed header completely at some
point in the future. Starting to measure its usage now will give us a
good baseline when we start contemplating that decision.

No new functionality, so no new tests.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/FeatureObserver.h:

Sep 22, 2012:

11:56 PM Changeset in webkit [129314] by weinig@apple.com
  • 3 edits in trunk/Source/WTF

Add explicit conversion operator to RetainPtr for easier use in C++11 environments
​https://bugs.webkit.org/show_bug.cgi?id=97403

Reviewed by Dan Bernstein.

  • wtf/Compiler.h:

Add support for COMPILER_SUPPORTS(CXX_EXPLICIT_CONVERSIONS)

  • wtf/RetainPtr.h:

(RetainPtr):
(WTF::RetainPtr::get):
(WTF::RetainPtr::operator PtrType):
Add the explicit conversion operator and group all the underlying
pointer accessors together.

11:31 PM Changeset in webkit [129313] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for http/tests/loading/redirect-with-no-location-crash.html,
the test started failing on the WebKit2 builder after it was unskipped in r129213.

  • platform/gtk-wk2/TestExpectations:
6:03 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:56 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:53 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:52 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:50 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:49 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:47 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:46 PM MinimalFileStorage edited by mjs@apple.com
(diff)
5:45 PM MinimalFileStorage created by mjs@apple.com
5:29 PM Changeset in webkit [129312] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Install WebProcess XPC services into the right places
​https://bugs.webkit.org/show_bug.cgi?id=97385

Reviewed by Anders Carlsson.

  • Configurations/WebProcessService.xcconfig:

Update INSTALL_PATH to go into WebKit2.framework/Versions/A/XPCServices.

  • Configurations/WebProcessServiceForWebKitDevelopment.xcconfig:

Since this config file is almost identical to WebProcessService.xcconfig,
just #include it and change the one thing that is different, the INFOPLIST_FILE

  • WebKit2.xcodeproj/project.pbxproj:

Follow XPC procedure and copy the services into the right place, WebKit2.framework/Versions/A/XPCServices
in all builds except production builds where it is not necessary. Also add a symlink like everyone else
does.

5:19 PM Changeset in webkit [129311] by mitz@apple.com
  • 4 copies
    1 add in releases/Apple/OS X Lion Update 10.7.5

Added a tag for the OS X Lion Update 10.7.5 release.

OS X Lion v10.7.5 includes JavaScriptCore-7534.57.3, WebCore-7534.57.7, WebKit-7534.57.7, and WebKit2-7534.57.7.

5:12 PM Changeset in webkit [129310] by mitz@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 6.0.1

Added a tag for the Safari 6.0.1 release.

Safari 6.0.1 includes JavaScriptCore-x536.26.7, WebCore-x536.26.14, WebKit-x536.26.14, and WebKit2-x536.26.14.

3:18 PM Changeset in webkit [129309] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Allow setting a custom path to where the plug-in sandbox profiles are being kept
​https://bugs.webkit.org/show_bug.cgi?id=97399

Reviewed by Anders Carlsson.

Add a new default to allow controlling where to look for plug-in sandbox profiles
called "PlugInSandboxProfileDirectoryPath".

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeSandbox):
Use the passed in sandboxProfileDirectoryPath instead of hard coding /usr/share/sandbox/.

(WebKit::PluginProcess::platformInitialize):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Grab the sandboxProfileDirectoryPath from standardUserDefaults and pass it to
the plug-in.

9:17 AM Changeset in webkit [129308] by dmazzoni@google.com
  • 21 edits
    4 copies in trunk

AX: Layout tests would be easier to write if AccessibilityController could find an element by id
​https://bugs.webkit.org/show_bug.cgi?id=97301

Reviewed by Chris Fleizach.

Source/WebCore:

Add a method to get the DOM "id" attribute from an accessible object, only for layout tests.

Makes existing test more cross-platform:
Tests: accessibility/aria-hidden-with-elements.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Adds a new accessibleElementById method to AccessibilityController, to make it
easier to write cross-platform layout tests.

Implemented for Chromium and for Mac (DRT and WKTR).

  • DumpRenderTree/AccessibilityController.cpp:

(getAccessibleElementByIdCallback):
(AccessibilityController::getJSClass):

  • DumpRenderTree/AccessibilityController.h:

(AccessibilityController):

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::findAccessibleElementByIdRecursive):
(AccessibilityController::getAccessibleElementById):
(AccessibilityController::accessibleElementByIdGetterCallback):

  • DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:

(AccessibilityController):

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::accessibleElementById):

  • DumpRenderTree/mac/AccessibilityCommonMac.h: added
  • DumpRenderTree/mac/AccessibilityCommonMac.mm: added

(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(AccessibilityController):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added

(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::findAccessibleObjectById):
(WTR):
(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

LayoutTests:

Modifies an existing test to use the new accessibleElementById
method of AccessibilityController, enabling the test to pass on
both Mac and Chromium.

  • accessibility/aria-hidden-with-elements.html:
  • platform/chromium/TestExpectations:
5:10 AM Changeset in webkit [129307] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, unskip now passing tests.

  • platform/qt/TestExpectations:
4:50 AM Changeset in webkit [129306] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Garden IETestCenter Bugs
​https://bugs.webkit.org/show_bug.cgi?id=97392

Unreviewed EFL gardening.

Unskip a couple of IETestCenter bugs now that they pass.

  • platform/efl/TestExpectations:
4:33 AM QtWebKitGardening edited by Csaba Osztrogonác
add more info to how to build QtWebKit section, fix the URL of the PPA (diff)
4:32 AM Changeset in webkit [129305] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Build is broken with GLib Unicode backend
​https://bugs.webkit.org/show_bug.cgi?id=97308.

Patch by Thierry Reding <​thierry.reding@avionic-design.de> on 2012-09-22
Reviewed by Carlos Garcia Campos.

The TextBreakIteratorGtk implementation uses ubrk_close() to delete
the iterator. However that function is ICU specific and not declared
when using the GLib backend. Instead the iterator can simply be freed
using the delete operator.

This commit is based on work by Martin Schlemmer who posted a fix for
this here:

​http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210

No new tests.

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator):
Free iterator using delete instead of ubrk_close().

3:31 AM Changeset in webkit [129304] by mihnea@adobe.com
  • 8 edits
    3 adds in trunk/LayoutTests

[CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread
​https://bugs.webkit.org/show_bug.cgi?id=97387

Reviewed by Dirk Schulze.

At this moment, accelerated compositing is disabled for elements inside a RenderFlowThread. This patch adds
a specific test in compositing/regions that is expected to fail until ​https://bugs.webkit.org/show_bug.cgi?id=84900
is fixed. The code for the new test is taken out of the existing fast/regions/webkit-flow-renderer-layer.html.

  • compositing/regions/webkit-flow-renderer-layer-compositing-expected.html: Added.
  • compositing/regions/webkit-flow-renderer-layer-compositing.html: Added.
  • fast/regions/webkit-flow-renderer-layer-expected.html:
  • fast/regions/webkit-flow-renderer-layer.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/Skipped:
1:10 AM Changeset in webkit [129303] by zandobersek@gmail.com
  • 5 edits in trunk/Tools

Unexpected reftest passes are only reported when pixel testing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=97242

Reviewed by Dirk Pranke.

LayoutTestRunner should know whether the finished test it's handling is
a reftest. This is necessary when updating result summary for reftests
when pixel testing is not enabled - in these circumstances an unexpectedly
passing reftest was not reported as such due to pixel testing then being
determined by searching for reftest failures in failures list, which were
not found in an empty failure list of a passing test. Now the TestResult
objects have a member variable indicating the test is a reftest whenever
that's the case.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.run):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

1:00 AM Changeset in webkit [129302] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking mathml/presentation/subsup.xhtml as flaky, the flakiness
being observable after r128837.

Adding image failure expectation for fast/text/word-space-with-kerning-2.html,
introduced in r129233.

  • platform/gtk/TestExpectations:
12:26 AM Changeset in webkit [129301] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, unskip now passing tests.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt/Skipped:
12:01 AM Changeset in webkit [129300] by mitz@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

[Qt] New fast/text/kerning-with-TextLayout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=97388

Moved this test into platform/mac, as it is not platform-independent, and TextLayout is currently
used only on OS X.

  • fast/text/kerning-with-TextLayout-expected.html: Removed.
  • fast/text/kerning-with-TextLayout.html: Removed.
  • platform/mac/fast/text/kerning-with-TextLayout-expected.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout-expected.html.
  • platform/mac/fast/text/kerning-with-TextLayout.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout.html.
12:00 AM Changeset in webkit [129299] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip new failing tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:

Sep 21, 2012:

11:43 PM Changeset in webkit [129298] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolled out a line I committed by accident.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

11:34 PM Changeset in webkit [129297] by ggaren@apple.com
  • 18 edits in trunk

Optimized closures that capture arguments
​https://bugs.webkit.org/show_bug.cgi?id=97358

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Previously, the activation object was responsible for capturing all
arguments in a way that was convenient for the arguments object. Now,
we move all captured variables into a contiguous region in the stack,
allocate an activation for exactly that size, and make the arguments
object responsible for knowing all the places to which arguments could
have moved.

This seems like the right tradeoff because

(a) Closures are common and long-lived, so we want them to be small.

(b) Our primary strategy for optimizing the arguments object is to make
it go away. If you're allocating arguments objects, you're already having
a bad time.

(c) It's common to use either the arguments object or named argument
closure, but not both.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::argumentIndexAfterCapture): m_numCapturedVars is gone
now -- we have an explicit range instead.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Move captured arguments
into the captured region of local variables for space efficiency. Record
precise data about where they moved for the sake of the arguments object.

Some of this data was previously wrong, but it didn't cause any problems
because the arguments weren't actually moving.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables): Don't
assume that captured vars are in any particular location -- always ask
the CodeBlock. This is better encapsulation.

(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): I rename things sometimes.

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff): Account for a particularly nasty edge case.

(JSC::Arguments::didTearOffActivation): Don't allocate our slow arguments
data on tear-off. We need to allocate it eagerly instead, since we need
to know about displaced, captured arguments during access before tear-off.

  • runtime/Arguments.h:

(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::argument): Tell our slow arguments array where all arguments
are, even if they are not captured. This simplifies some things, so we don't
have to account explicitly for the full matrix of (not torn off, torn off)

  • (captured, not captured).

(JSC::Arguments::finishCreation): Allocate our slow arguments array eagerly
because we need to know about displaced, captured arguments during access
before tear-off.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::parameterCount):
(FunctionExecutable):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

  • runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registerOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::allocationSize):
(JSC::JSActivation::isValid): This is really the point of the patch. All
the pointer math in Activations basically boils away, since we always
copy a contiguous region of captured variables now.

  • runtime/SymbolTable.h:

(JSC::SlowArgument::SlowArgument):
(SlowArgument):
(SharedSymbolTable):
(JSC::SharedSymbolTable::captureCount):
(JSC::SharedSymbolTable::SharedSymbolTable): AllOfTheThings capture mode
is gone now -- that's the point of the patch. indexIfCaptured gets renamed
to index because we always have an index, even if not captured. (The only
time when the index is meaningless is when we're Deleted.)

LayoutTests:

  • fast/js/dfg-arguments-alias-activation-expected.txt:
  • fast/js/dfg-arguments-alias-activation.html:
9:44 PM Changeset in webkit [129296] by fischman@chromium.org
  • 3 edits
    1 add in trunk

HTMLMediaElement isn't garbage collected between document reloads
​https://bugs.webkit.org/show_bug.cgi?id=97020

Reviewed by Eric Carlson.

.:

Manual test added: ManualTests/audio-freed-during-reload.html

  • ManualTests/audio-freed-during-reload.html:

Source/WebCore:

JS-created (as opposed to DOM-created) Audio nodes never got collected, because they
appear to always hasPendingActivity(), because m_playing is never set to false.

Manual test added: ManualTests/audio-freed-during-reload.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop): set m_playing = false; explicitly.

8:18 PM Changeset in webkit [129295] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Lion and Snow Leopard builds.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessService):

8:04 PM Changeset in webkit [129294] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

RenderMarquee causes ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) : WebCore::FloatRect WebCore::RenderGeometryMap::absoluteRect(const WebCore::FloatRect &) const
​https://bugs.webkit.org/show_bug.cgi?id=92464

Reviewed by Sam Weinig.

Marquees could cause an updateCompositingLayersAfterScroll() to be called when
we're in the middle of updating layer positions. updateCompositingLayersAfterScroll()
does a full RenderLayer tree walk, but its use of RenderGeomeryMap reveals that
it's using layers whose positions haven't been updated yet.

Fix by avoiding the updateCompositingLayersAfterScroll() if we're in the process
of updating a marquee when updating layer positions. We'll do a compositing update
soon anyway.

Tested by fast/events/tabindex-focus-blur-all.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):

  • rendering/RenderLayer.h:

(RenderLayer):

7:22 PM Changeset in webkit [129293] by weinig@apple.com
  • 7 edits
    2 copies
    5 moves
    3 adds in trunk

WebProcess XPC services need have their environment set without disrupting all other XPC services
​https://bugs.webkit.org/show_bug.cgi?id=95161

Reviewed by Anders Carlsson.

Source/WebKit2:

Replace the WebKit2Service with two new XPC services, the WebProcessService, which is only used
when installed on the system, and the WebProcessServiceForWebKitDevelopment which is used at all
other times. We need both services because XPC can't in general be configured to have a custom
environment at runtime, and thus WebProcessServiceForWebKitDevelopment has the ability to re-exec
itself into a desired state. That capability is rather undesirable for installed usage, where we
don't want to allow arbitrary changes to the environment of the service, which would allow breaking
the App Sandbox.

  • Configurations/WebProcessService.xcconfig: Copied from Source/WebKit2/Configurations/WebKit2Service.xcconfig.
  • Configurations/WebProcessServiceForWebKitDevelopment.xcconfig: Renamed from Source/WebKit2/Configurations/WebKit2Service.xcconfig.

Add new configuration files.

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
Add helpful assertions. Without them, we confusingly crash a bit later in HashTable code.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):
Factor out environment additions to this helper function.

(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
Add functionality to setup the webkit development service via re-exec.

(WebKit::createWebProcessService):
Add functionality to connect to the installed WebProcess service.

(WebKit::createProcess):
Factor out posix_spawn based launching into this helper function.

(WebKit::ProcessLauncher::launchProcess):
Call the correct process creation function based on launch data and install state.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files to the project.

  • WebProcess/mac/WebProcessServiceEntryPoints.h: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.h.
  • WebProcess/mac/WebProcessServiceEntryPoints.mm: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.mm.

(WebKit::WebProcessServiceEventHandler):
(WebProcessServiceMain):
(InitializeWebProcessForWebProcessServiceForWebKitDevelopment):
Rename to WebProcessServiceEntryPoints since this is now used for both the WebProcessService and the
WebProcessServiceForWebKitDevelopment.

  • WebProcessService/Info.plist: Copied from Source/WebKit2/WebKit2Service/Info.plist.
  • WebProcessService/WebProcessServiceMain.mm: Renamed from Source/WebKit2/WebKit2Service/MainMacService.mm.

Add main for the WebProcessService which just calls into the WebProcessServiceEntryPoints in WebKit2.framework.

  • WebProcessServiceForWebKitDevelopment/Info.plist: Renamed from Source/WebKit2/WebKit2Service/Info.plist.
  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm: Added.

Add main for the WebProcessServiceForWebKitDevelopment, which can't just call directly into WebProcessServiceEntryPoints
as the framework path might not be set up correctly. This is also where we re-exec ourselves when required.

Tools:

Remove setting the XPC_* environment variables.

  • Scripts/webkitdirs.pm:

(setUpGuardMallocIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):

7:06 PM Changeset in webkit [129292] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Eeeep - broke early boyer in bug#97382
​https://bugs.webkit.org/show_bug.cgi?id=97383

Rubber stamped by Sam Weinig.

missed a child3 -> child2!

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOf):

6:50 PM Changeset in webkit [129291] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix typo in additional-platform-directory patch just landed
​https://bugs.webkit.org/show_bug.cgi?id=97380

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.relative_test_filename):
(Port.relative_perf_test_filename):

6:35 PM Changeset in webkit [129290] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

6:34 PM Changeset in webkit [129289] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Pedantic test in Mozilla's JavaScript test suite fails. function-001.js function-001-n.js
​https://bugs.webkit.org/show_bug.cgi?id=27219

Reviewed by Sam Weinig.

These tests are just wrong.
See ECMA 262 A.5, FunctionDelcaration does not require a semicolon.

  • tests/mozilla/expected.html:
  • tests/mozilla/js1_2/function/function-001-n.js:
  • tests/mozilla/js1_3/Script/function-001-n.js:
  • tests/mozilla/js1_3/regress/function-001-n.js:
6:27 PM Changeset in webkit [129288] by adamk@chromium.org
  • 4 edits
    4 adds in trunk

Remove bogus assertions from ChildListMutationScope
​https://bugs.webkit.org/show_bug.cgi?id=97372

Reviewed by Ryosuke Niwa.

Source/WebCore:

Some asserts (and their accompanying comment) were trying to enforce
proper usage of ChildListMutationScope from WebCore, but in the
presence of MutationEvents they could fail due to arbitrary script
execution.

This change gets rid of those asserts and adds tests exercising
the (pre-existing) codepaths for handling these out-of-order cases.
Without this patch, these tests ASSERT in debug builds.

Tests: fast/mutation/added-out-of-order.html

fast/mutation/removed-out-of-order.html

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):

  • dom/ChildListMutationScope.h:

(WebCore):

LayoutTests:

  • fast/mutation/added-out-of-order-expected.txt: Added.
  • fast/mutation/added-out-of-order.html: Added.
  • fast/mutation/removed-out-of-order-expected.txt: Added.
  • fast/mutation/removed-out-of-order.html: Added.
6:18 PM Changeset in webkit [129287] by barraclough@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Remove redundant argument to op_instanceof
​https://bugs.webkit.org/show_bug.cgi?id=97382

Reviewed by Geoff Garen.

No longer needed after my last change.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInstanceOf):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOf):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
6:13 PM Changeset in webkit [129286] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix WebKit2 sandbox profile.

Instead of using #pragmas, just disable all warnings in DerivedSources.make. I suspect
that passing -traditional to the preprocessor disables support for #pragmas but I'm afraid
to change it to something else.

  • DerivedSources.make:
  • WebProcess/com.apple.WebProcess.sb.in:
6:00 PM Changeset in webkit [129285] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=97380

Reviewed by Ojan Vafai.

There doesn't seem to be a good reason for this restriction and
it's useful to be able to point to directories outside the
checkout for results (e.g., for local failures due to a 10.7.4
install ;).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.relative_test_filename):
(Port.relative_perf_test_filename):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._command_from_driver_input):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_additional_platform_directory):

6:00 PM Changeset in webkit [129284] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r129176): Incorrect line breaking when kerning occurs between a space and the following character
​https://bugs.webkit.org/show_bug.cgi?id=97377

Reviewed by Enrica Casucci.

Source/WebCore:

Test: fast/text/kerning-with-TextLayout.html

When kerning is enabled, the last character in a word may have its advance shortened because
of its trailing space. To account for that, words are measured along with the trailing space,
then the width of a space is subtracted from the result. This doesn’t work when the trailing
space itself has its advance shortened due to the character following it, which can happen
when using the TextLayout optimization. However, when the optimization is used, the advance
of the last character of the word is already adjusted for the trailing space, so there is no
need to measure with that space and subtract its advance.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Changed to not use the trailingSpaceWidth
mechanism when TextLayout is being used.

LayoutTests:

  • fast/text/kerning-with-TextLayout-expected.html: Added.
  • fast/text/kerning-with-TextLayout.html: Added.
5:53 PM Changeset in webkit [129283] by aelias@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Forward-declare WebSize as a struct
​https://bugs.webkit.org/show_bug.cgi?id=97381

Reviewed by James Robinson.

The mismatched "class" forward-declaration for WebSize in this file
will cause a Clang error when it's included in Chromium.

  • chromium/public/WebCompositorSoftwareOutputDevice.h:

(WebKit):

5:46 PM Changeset in webkit [129282] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

5:43 PM Changeset in webkit [129281] by barraclough@apple.com
  • 29 edits in trunk

instanceof should not get the prototype for non-default HasInstance
​https://bugs.webkit.org/show_bug.cgi?id=68656

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Instanceof is currently implemented as a sequance of three opcodes:

check_has_instance
get_by_id(prototype)
op_instanceof

There are three interesting types of base value that instanceof can be applied to:

(A) Objects supporting default instanceof behaviour (functions, other than those created with bind)
(B) Objects overriding the default instancecof behaviour with a custom one (API objects, bound functions)
(C) Values that do not respond to the HasInstance trap.

Currently check_has_instance handles case (C), leaving the op_instanceof opcode to handle (A) & (B). There are
two problems with this apporach. Firstly, this is suboptimal for case (A), since we have to check for
hasInstance support twice (once in check_has_instance, then for default behaviour in op_instanceof). Secondly,
this means that in cases (B) we also perform the get_by_id, which is both suboptimal and an observable spec
violation.

The fix here is to move handing of non-default instanceof (cases (B)) to the check_has_instance op, leaving
op_instanceof to handle only cases (A).

  • API/JSCallbackObject.h:

(JSCallbackObject):

  • API/JSCallbackObjectFunctions.h:

(JSC::::customHasInstance):

  • API/JSValueRef.cpp:

(JSValueIsInstanceOfConstructor):

  • renamed hasInstance to customHasInstance
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • added additional parameters to check_has_instance opcode
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • added additional parameters to check_has_instance opcode
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCheckHasInstance):

  • added additional parameters to check_has_instance opcode
  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • added additional parameters to check_has_instance opcode
  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • added additional parameters to check_has_instance opcode
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • added additional parameters to check_has_instance opcode
  • interpreter/Interpreter.cpp:

(JSC::isInvalidParamForIn):
(JSC::Interpreter::privateExecute):

  • Add handling for non-default instanceof to op_check_has_instance
  • jit/JITInlineMethods.h:

(JSC::JIT::emitArrayProfilingSiteForBytecodeIndex):

  • Fixed no-LLInt no_DFG build
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):

  • check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

  • no need to check for ImplementsDefaultHasInstance.
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):

  • check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

  • no need to check for ImplementsDefaultHasInstance.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
    • Add handling for non-default instanceof to op_check_has_instance
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
    • move check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • renamed hasInstance to customHasInstance
  • runtime/CommonSlowPaths.h:

(CommonSlowPaths):

  • removed opInstanceOfSlow (this was whittled down to one function call!)
  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::customHasInstance):

  • runtime/JSBoundFunction.h:

(JSBoundFunction):

  • renamed hasInstance to customHasInstance, reimplemented.
  • runtime/JSCell.cpp:

(JSC::JSCell::customHasInstance):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):
(JSC):
(JSC::JSObject::defaultHasInstance):

  • runtime/JSObject.h:

(JSObject):

LayoutTests:

  • fast/js/function-bind-expected.txt:
    • check in passing result.
5:31 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
5:31 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
5:30 PM Changeset in webkit [129280] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Simplify and optimize ChildListMutationScope
​https://bugs.webkit.org/show_bug.cgi?id=97352

Reviewed by Ryosuke Niwa.

ChildListMutationScope is one of the most complicated bits of
MutationObserver implementation. This patch aims to simplify it for
clarity and improve its performance (mostly by just doing less).

The big change is to remove the MutationAccumulatorRouter class,
replacing it with lifetime-management logic in ChildListMutationAccumulator
ChildListMutationScope is expected to call getOrCreate() in
its constructor, and each scope holds a RefPtr to the accumulator.
When the last scope holding such a RefPtr is destroyed,
ChildListMutationAccumulator's destructor enqueues the accumulated record.

This greatly reduces the number of lines of code, and condenses
two HashMaps into one. It also reduces hash lookups, which now
occur only on scope creation and when the refcount for a given
accumulator reaches 0 (previously, each childAdded and willRemoveChild
call could result in two hash lookups each).

There are some minor changes as well: the ChildListMutationAccumulator::clear()
method is gone, as it was doing more work than necessary;
DEFINE_STATIC_LOCAL is now used instead of hand-rolled static-management
code; ChildListMutationAccumulator::m_lastAdded is no longer a RefPtr, since it
always points at a Node that's already being ref'd by the accumulator.
Also various minor syntactic cleanups.

No new tests, no change in behavior.

  • dom/ChildListMutationScope.cpp:

(WebCore::accumulatorMap): Reduced two maps to one, and manage its lifetime with DEFINE_STATIC_LOCAL.
(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator): Remove unnecessary call to clear() (which itself has been removed).
(WebCore::ChildListMutationAccumulator::~ChildListMutationAccumulator): Enqueue record if not empty at destruction, and have the accumulator
remove itself from the map.
(WebCore::ChildListMutationAccumulator::getOrCreate): Replaces half of MutationAccumulatorRouter's job.
(WebCore::ChildListMutationAccumulator::childAdded): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::isRemovedNodeInOrder): Simplify RefPtr syntax.
(WebCore::ChildListMutationAccumulator::willRemoveChild): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord): Replace call to clear() with clearing m_lastAdded,
since it's the only bit not cleared by the MutationRecord creation call. Also remove
isEmpty check and replace with asserts now that it's a private method.
(WebCore::ChildListMutationAccumulator::isEmpty): Added more assertions about emptiness.

  • dom/ChildListMutationScope.h:

(WebCore):
(ChildListMutationAccumulator): Extract the inner class to make everything easier to read.
(WebCore::ChildListMutationScope::ChildListMutationScope): Store m_accumulator rather than m_target.
(WebCore::ChildListMutationScope::~ChildListMutationScope): ditto
(WebCore::ChildListMutationScope::childAdded): ditto
(WebCore::ChildListMutationScope::willRemoveChild): ditto
(ChildListMutationScope):

  • html/HTMLElement.cpp: Remove unused ChildListMutationScope.h #include.
5:16 PM Changeset in webkit [129279] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip this test because it relies on sandboxed-iframe-origin-add.html which was removed in ​http://trac.webkit.org/changeset/129262.

  • platform/win/Skipped:
5:13 PM Changeset in webkit [129278] by benjamin@webkit.org
  • 4 edits in trunk

fast/dom/Geolocation/disconnected-frame.html test asserts
​https://bugs.webkit.org/show_bug.cgi?id=97376

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

In GeolocationPermissionRequestManager::cancelRequestForGeolocation, we access an iterator
after its value has been removed from the table.
There are two problems with that:
-The iterator is no longer valid after the container has been modified.
-If it was the last element, the table has been freed and the iterator points to deleted memory.

We solve the issue by keeping a copy of the ID. We could have inverted the order of the calls
but that would make the issue less visible for future change.

Testing covered by fast/dom/Geolocation/disconnected-frame.html.

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):

LayoutTests:

  • platform/wk2/Skipped:
4:58 PM Changeset in webkit [129277] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

BiquadFilterNode must take audio-rate parameter changes into account
​https://bugs.webkit.org/show_bug.cgi?id=97369

Reviewed by Kenneth Russell.

BiquadFilterNode is currently ignoring any timeline or audio-rate changes to its parameters.
We now check if any of its parameters have timeline or audio-rate changes and, if so, take
them into account. Otherwise, we use ordinary parameter smoothing/de-zippering which is
the case when the parameters are adjusted, for example, from a knob or slider in the UI.

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::checkForDirtyCoefficients):

  • Modules/webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::hasSampleAccurateValues):
(BiquadProcessor):

4:58 PM Changeset in webkit [129276] by roger_fong@apple.com
  • 5 edits in trunk/LayoutTests

Unreviewed. Fix Windows specific accessibility test results.
Missed some new lines in ​http://trac.webkit.org/changeset/129255.

  • platform/win/accessibility/aria-toggle-button-with-title-expected.txt:
  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/accessibility/img-fallsback-to-title-expected.txt:
  • platform/win/accessibility/svg-image-expected.txt:
4:47 PM Changeset in webkit [129275] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

Add support for OES_vertex_array_object in chromium
​https://bugs.webkit.org/show_bug.cgi?id=96578

Patch by Brandon Jones <​bajones@google.com> on 2012-09-21
Reviewed by Kenneth Russell.

Source/Platform:

Added code to allow calls to the OES_vertex_array_object extension to interface
properly with the chromium WebGL implementation.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createVertexArrayOES):
(WebKit::WebGraphicsContext3D::deleteVertexArrayOES):
(WebKit::WebGraphicsContext3D::isVertexArrayOES):
(WebKit::WebGraphicsContext3D::bindVertexArrayOES):

Source/WebCore:

Adding basic reference counting to WebGLBuffer objects to satisfy spec requirements
for the OES_vertex_array_object extension. Added code to allow calls to the
OES_vertex_array_object extension to interface properly with the chromium WebGL
implementation.

Test: fast/canvas/webgl/oes-vertex-array-object.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
(WebCore):

  • html/canvas/WebGLVertexArrayObjectOES.h:

(WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::getVertexAttribStateSize):

  • platform/chromium/support/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):

LayoutTests:

Brought over KHRONOS conformance test for OES_vertex_array_object

  • fast/canvas/webgl/oes-vertex-array-object-expected.txt: Added.
  • fast/canvas/webgl/oes-vertex-array-object.html: Added.
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/wk2/Skipped:
4:40 PM Changeset in webkit [129274] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix ARM build.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):

  • offlineasm/armv7.rb:
4:35 PM Changeset in webkit [129273] by bashi@chromium.org
  • 28 edits in trunk

[Chromium] Use OpenTypeVerticalData on Linux
​https://bugs.webkit.org/show_bug.cgi?id=97277

Reviewed by Tony Chang.

Source/WebCore:

Remove HarfBuzz dependency from GlyphPageTreeNodeSkia. Use OpenTypeVerticalData instead.

No new tests. Rebaselined existing tests.

  • WebCore.gyp/WebCore.gyp: Added OpenTypeTypes.h and OpenTypeVerticalData.(cpp|h) for linux and android.
  • platform/graphics/FontCache.cpp:

Inserted a space between > and > in typedef of FontVerticalDataCache so that making some compilers happy.
(WebCore):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData): Moved declaration of m_verticalData to avoid compile warnings.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::verticalData): Added.
(WebCore::FontPlatformData::openTypeTable): Added.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(WebCore):
(FontPlatformData):

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Removed substituteWithVerticalGlyphs().

(WebCore::GlyphPage::fill):

Source/WebKit/chromium:

  • features.gypi: Enable OPENTYPE_VERTICAL on linux and android.

LayoutTests:

Rebaselined vertical writing test expectations.

  • platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-linux/fast/dynamic/text-combine-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-linux/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
4:30 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
4:29 PM Changeset in webkit [129272] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

REGRESSION (r128400): Opening Google Web Fonts page hangs or crashes
​https://bugs.webkit.org/show_bug.cgi?id=97328

Reviewed by Mark Hahnenberg.

It's a bad idea to emit stub code that reallocates property storage when we're in indexed
storage mode. DFGRepatch.cpp knew this and had the appropriate check in one of the places,
but it didn't have it in all of the places.

This change also adds some more handy disassembly support, which I used to find the bug.

  • assembler/LinkBuffer.h:

(JSC):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):

  • jit/JITStubRoutine.h:

(JSC):

4:22 PM Changeset in webkit [129271] by inferno@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/dom/Document.cpp

Merge 129270 - Crash in WebCore::Document::fullScreenChangeDelayTimerFired
BUG=147700
Review URL: ​https://codereview.chromium.org/10969052

4:21 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
4:20 PM Changeset in webkit [129270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::Document::fullScreenChangeDelayTimerFired
​https://bugs.webkit.org/show_bug.cgi?id=97367

Patch by Jeremy Apthorp <​jeremya@chromium.org> on 2012-09-21
Reviewed by Abhishek Arya.

The document could be destroyed during the processing of the
fullscreenchange event, if the document was destroyed as a result of
one of the dispatchEvent calls.

This bug isn't reliably reproducible, so no new tests.

  • dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):

4:18 PM Changeset in webkit [129269] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r120361) Warnings while preprocessing com.apple.WebProcess.sb.in
​https://bugs.webkit.org/show_bug.cgi?id=91079
<rdar://problem/12332660>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb.in:

Add pragma to ignore the invalid preprocessor warnings.

4:16 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
4:15 PM Changeset in webkit [129268] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip fast/dom/Geolocation/disconnected-frame.html until the assertion is fixed

Unreviewed. The test assert in Debug, skip it until this has been fixed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-21

  • platform/wk2/Skipped:
4:07 PM Changeset in webkit [129267] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

No need to pass order file for WebCoreTestSupport build
​https://bugs.webkit.org/show_bug.cgi?id=97363

Reviewed by David Kilzer.

No new tests because no functional change.

  • Configurations/WebCoreTestSupport.xcconfig:
3:59 PM Changeset in webkit [129266] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG CSE assumes that a holy PutByVal does not interfere with GetArrayLength, when it clearly does
​https://bugs.webkit.org/show_bug.cgi?id=97373

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.h:

(Graph):

LayoutTests:

  • fast/js/dfg-holy-put-by-val-interferes-with-get-array-length-expected.txt: Added.
  • fast/js/dfg-holy-put-by-val-interferes-with-get-array-length.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-holy-put-by-val-interferes-with-get-array-length.js: Added.

(foo):

3:51 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
3:47 PM TestExpectations edited by dpranke@chromium.org
delete description of the old syntax (diff)
3:39 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
3:35 PM Changeset in webkit [129265] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: drop support for old TestExpectations syntax
​https://bugs.webkit.org/show_bug.cgi?id=97364

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._collect_matching_tests):
(TestExpectationParser):
(TestExpectationParser._tokenize_line):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(SkippedTests.test_skipped_entry_dont_exist):
(ExpectationSyntaxTests.assert_tokenize_exp):
(ExpectationSyntaxTests.test_bare_name):
(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_comments):
(ExpectationSyntaxTests.test_config_modifiers):
(ExpectationSyntaxTests.test_unknown_config):
(ExpectationSyntaxTests.test_unknown_expectation):
(ExpectationSyntaxTests.test_skip):
(ExpectationSyntaxTests.test_slow):
(ExpectationSyntaxTests.test_wontfix):
(ExpectationSyntaxTests.test_blank_line):
(ExpectationSyntaxTests.test_warnings):
(RebaseliningTest.test_no_get_rebaselining_failures):

3:33 PM Changeset in webkit [129264] by Simon Fraser
  • 2 edits in trunk/Tools

Improve WTR unresponsiveness output a little
​https://bugs.webkit.org/show_bug.cgi?id=97370

Reviewed by Timothy Horton.

Distinguish between conditions that already set the errorMessage,
and unresponsiveness due to slow about:blank loads when WTR
reports unresponsiveness.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

3:30 PM Changeset in webkit [129263] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt

Unreviewed, rolled DEPS.

  • DEPS:
3:27 PM Changeset in webkit [129262] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping http/tests/security/sandboxed-iframe-origin-add.html.
​https://bugs.webkit.org/show_bug.cgi?id=97271

  • platform/win/Skipped:
3:26 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
3:22 PM Changeset in webkit [129261] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to r158060

Unreviewed, rolled DEPS.

  • DEPS:
3:13 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
3:12 PM Changeset in webkit [129260] by crogers@google.com
  • 27 edits in trunk

Add Web Audio support for deprecated/legacy APIs
​https://bugs.webkit.org/show_bug.cgi?id=97050

Reviewed by Eric Carlson.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

The Web Audio API specification has undergone much review and some small API changes
have been made (mostly naming-related changes). This patch adds an ENABLE_LEGACY_WEB_AUDIO
build option to allow ports to support the old names.

Tests changed:
audiobuffersource-playbackrate.html
audiobuffersource.html
note-grain-on-testing.js
oscillator-testing.js

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am:
  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::startGrain):
(WebCore):
(WebCore::AudioBufferSourceNode::noteGrainOn):

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):

  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
(WebCore):
(WebCore::AudioScheduledSourceNode::noteOn):
(WebCore::AudioScheduledSourceNode::noteOff):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/Oscillator.idl:
  • page/FeatureObserver.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • webaudio/audiobuffersource-playbackrate.html:
  • webaudio/audiobuffersource.html:
  • webaudio/resources/note-grain-on-testing.js:

(playGrain):

  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

3:04 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
3:02 PM Changeset in webkit [129259] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: update remaining tests to use the new expectation syntax
​https://bugs.webkit.org/show_bug.cgi?id=97362

Reviewed by Ojan Vafai.

This patch updates all the unit tests that were still using the
old TestExpectations syntax to use the new syntax *except* for
the tests that were specifically testing that we parsed the old
syntax correctly.

Also, a block of tests for the new syntax were duplicated, so
I've deleted the duplicate.

Note that the old syntax is still supported so this change should
produce no visible changes.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_error_on_different_platform):
(MiscTests.test_error_on_different_build_type):
(MiscTests.test_overrides):
(MiscTests.test_overridesdirectory):
(MiscTests.test_overridesduplicate):
(MiscTests.test_more_specific_override_resets_skip):
(SkippedTests.check):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.disabled_test_missing_expectation):
(ExpectationSyntaxTests.disabled_test_missing_colon):
(ExpectationSyntaxTests.disabled_test_too_many_colons):
(ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
(ExpectationSyntaxTests):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(ExpectationSyntaxTests.test_macro):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_slow_and_timeout):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(OldExpectationParserTests):
(OldExpectationParserTests._tokenize):
(OldExpectationParserTests.test_tokenize_extra_colon):
(OldExpectationParserTests.test_tokenize_missing_equal):
(OldExpectationParserTests.test_tokenize_extra_equal):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skip_failing_tests):
(MainTest.test_additional_expectations):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):
(TestExpectationsTestCase.test_invalid_expectations):
(TestExpectationsTestCase.test_tab):

2:57 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
2:57 PM Changeset in webkit [129258] by roger_fong@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed. As in ​https://bugs.webkit.org/show_bug.cgi?id=92916, Windows specific results need to be added for various accessibility tests.

  • platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Added.
  • platform/win/accessibility/canvas-fallback-content-2-expected.txt: Added.
  • platform/win/accessibility/img-fallsback-to-title-expected.txt: Added.
  • platform/win/accessibility/svg-image-expected.txt: Added.
2:46 PM DeprecatingFeatures edited by abarth@webkit.org
(diff)
2:43 PM Changeset in webkit [129257] by pilgrim@chromium.org
  • 11 edits
    2 adds in trunk/Source

[Chromium] remove getFontFamilyForCharacters from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96282

Reviewed by Tony Chang.

Migrating away from PlatformSupport. getFontFamilyForCharacters is
moved to FontCache.h and overridden by the two platforms that
need it (Chromium Linux and Blackberry). New files for the overrides.
Part of a larger refactoring series. See tracking bug 82948.

Source/WebCore:

  • PlatformBlackBerry.cmake:
  • WebCore.gypi:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/FontCache.h:

(SimpleFontFamily):
(FontCache):

  • platform/graphics/blackberry/FontCacheBlackberry.cpp: Added.

(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):

  • platform/graphics/blackberry/skia/PlatformSupport.cpp:

(WebCore):

  • platform/graphics/blackberry/skia/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::getFontDataForCharacters):

  • platform/graphics/chromium/FontCacheChromiumLinux.cpp: Added.

(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getFontDataForCharacters):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

2:40 PM Changeset in webkit [129256] by Lucas Forschler
  • 2 edits in branches/safari-536.27-branch/Source/JavaScriptCore

Enable opportunistic garbage collecting on Windows.

Patch by Roger Fong <​roger_fong@apple.com> on 2012-09-20
Reviewed by Mark Hahnenberg

2:39 PM Changeset in webkit [129255] by roger_fong@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed. Creating some Windows specific tests.
​http://trac.webkit.org/changeset/128652 changed results for these tests on Mac but Windows results should stay the same.

  • platform/win/fast/block/positioning: Added.
  • platform/win/fast/block/positioning/016-expected.txt: Added.
  • platform/win/fast/block/positioning/025-expected.txt: Added.
  • platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
2:27 PM Changeset in webkit [129254] by Chris Fleizach
  • 6 edits
    2 adds in trunk

Source/WebCore: AX: WebKit exposes incorrect bounds for embedded SVG in HTML
​https://bugs.webkit.org/show_bug.cgi?id=96168

Reviewed by Eric Seidel.

Override absoluteFocusRingQuads() for SVG objects because the default
implementation relies on addFocusRingRects(). In addFocusRingRects(), SVG
objects adds local positions for its rects instead of absolute positions.

Test: accessibility/svg-bounds.html

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore):
(WebCore::RenderSVGModelObject::absoluteFocusRingQuads):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

LayoutTests: WebKit exposes incorrect bounds for embedded SVG in HTML
​https://bugs.webkit.org/show_bug.cgi?id=96168

Reviewed by Eric Seidel.

  • accessibility/svg-bounds.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/accessibility/svg-bounds-expected.txt: Added.
2:24 PM Changeset in webkit [129253] by inferno@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/features.gypi

Merge 125155 - Disable iframe seamless for m23.
Review URL: ​https://codereview.chromium.org/10970046

2:06 PM Changeset in webkit [129252] by benjamin@webkit.org
  • 22 edits
    2 adds in trunk

[WK2] Add basic testing support for Geolocation
​https://bugs.webkit.org/show_bug.cgi?id=97278

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • Shared/API/c/WKNumber.h: Fix an unfortunate copy-paste :)
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):
Remove the code forcing the Geolocation permissions. It was working around the normal
Geolocation code and updating all the GeolocationController, which is a terrible idea.

Tools:

Update the Geolocation testing to use the proper API in the UIProcess.

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/GeolocationProviderMock.cpp: Added.

(WTR::startUpdatingCallback):
(WTR::stopUpdatingCallback):
(WTR::GeolocationProviderMock::GeolocationProvierMock):
(WTR::GeolocationProviderMock::setMockGeolocationPosition):
(WTR::GeolocationProviderMock::startUpdating):
(WTR::GeolocationProviderMock::stopUpdating):
(GeolocationProviderMock):
The GeolocationProvider store the location update and deliver them as needed.

WebCore GeolocationController do not support asynchronous update on start/stop. This is not
a problem in this case because all the messages between the WebProcess and the UIProcess are
asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
delivery.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setGeolocationPermission):
(WTR::TestRunner::setMockGeolocationPosition):
From the InjectedBundle, we now pass the information to the UIProcess so that
GeolocationProvider and the TestController can respond appropriately.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::decidePolicyForGeolocationPermissionRequest):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::setMockGeolocationPosition):

  • WebKitTestRunner/TestController.h:

(TestController):
(WTR::TestController::setGeolocationPermission):
(WTR::TestController::isGeolocationPermissionAllowed):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

LayoutTests:

  • platform/wk2/Skipped: Unskip the passing tests.
2:02 PM Changeset in webkit [129251] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk/Source

[BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
​https://bugs.webkit.org/show_bug.cgi?id=97348
Internal PR: 186597.

Internally reviewed by Yong Li, Joe Mason.
Patch by Lianghui Chen <​liachen@rim.com> on 2012-09-21
Reviewed by Yong Li.

Source/WebCore:

Add a singleton AuthenticationChallengeManager to manage authentication
challenge dialog. It does following things:
Record page creation/deletion, so it knows what page is present or not.
Record page visibility change so it knows when to display a dialog or not.
Accept authentication challenge, and decide whether to postpone the

challenge dialog based on whether there is active authentication challenge
dialog already and whether its page is visible or not.

When a challenge result comes back, notify the result to all clients

authenticating for the same protection space, and then start the next
authentication challenge from the same page, if there is one.

When a page becomes visible, start the first authentication challenge

dialog that has been blocked before.

And to support this new AuthenticationChallengeManager, and making the

challenge really asynchronous, NetworkJob has been updated to support
the concept of "freeze", which means buffering all network loading status
change but don't send them to NetworkJob clients.

This is necessary when authentication challenge is asynchronous, as the

previous network loading status will likely come before user make any
decision.

No new tests for platform specific internal change.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/AuthenticationChallengeManager.cpp: Added.

(WebCore):
(ChallengeInfo):
(WebCore::ChallengeInfo::ChallengeInfo):
(AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::resumeAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::startAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::pageExists):
(WebCore::AuthenticationChallengeManager::AuthenticationChallengeManager):
(WebCore::AuthenticationChallengeManager::pageCreated):
(WebCore::AuthenticationChallengeManager::pageDeleted):
(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):
(WebCore::AuthenticationChallengeManager::authenticationChallenge):
(WebCore::AuthenticationChallengeManager::cancelAuthenticationChallenge):
(WebCore::AuthenticationChallengeManager::notifyChallengeResult):
(WebCore::AuthenticationChallengeManager::instance):
(WebCore::AuthenticationChallengeManager::init):

  • platform/blackberry/AuthenticationChallengeManager.h:

(WebCore):
(AuthenticationChallengeManager):

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::~NetworkJob):
(WebCore):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

Source/WebKit/blackberry:

Update WebPage to use new AuthenticationChallengeManager.
Register page creation/deletion and visibility change to the new

AuthenticationChallengeManager.

Initialize AuthenticationChallengeManager in GlobalInitialize() function.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:32 PM Changeset in webkit [129250] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Make Web Inspector work in multiple web process mode
​https://bugs.webkit.org/show_bug.cgi?id=97354

Reviewed by Timothy Hatcher.

  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tell WKView that it's related to original page, making inspector page be in the same process.

1:16 PM Changeset in webkit [129249] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r129248.
​http://trac.webkit.org/changeset/129248
​https://bugs.webkit.org/show_bug.cgi?id=96000

Broke win build

  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • rendering/RenderingAllInOne.cpp:
1:10 PM WebKitGTK/1.10.x edited by jdiggs@igalia.com
(diff)
1:09 PM Changeset in webkit [129248] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

Make RenderingAllInOne.cpp usable for ports other than Apple/Win
​https://bugs.webkit.org/show_bug.cgi?id=96000

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-21
Reviewed by Ryosuke Niwa.

RenderingAllInOne.cpp unconditionally includes RenderThemeWin. This patch separates
it out from the file.

  • Target.pri: Add RenderingAllInOne.cpp to the list of supported all-in-one files.
  • WebCore.vcproj/WebCore.vcproj: Compile RenderThemeWin.cpp separately.
  • rendering/RenderingAllInOne.cpp: Don't include RenderThemeWin.cpp here.
1:03 PM Changeset in webkit [129247] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
​https://bugs.webkit.org/show_bug.cgi?id=96196

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.

Source/WebCore:

No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the new test.
  • platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
12:40 PM Changeset in webkit [129246] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
​https://bugs.webkit.org/show_bug.cgi?id=96932

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

Source/WebCore:

Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.

Test: platform/gtk/accessibility/remapped-aria-crash.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

Added a new test which replicates the recursion and crash.

  • platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
  • platform/gtk/accessibility/remapped-aria-crash.html: Added.
12:35 PM Changeset in webkit [129245] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix test_skip_and_wontfix failure
​https://bugs.webkit.org/show_bug.cgi?id=97225

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(SemanticTests.test_skip_and_wontfix):

12:24 PM Changeset in webkit [129244] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] HTML5 media does not handle SSL certificate failures
​https://bugs.webkit.org/show_bug.cgi?id=93324

Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Eric Carlson.

RIM PR: 116205
Passed FrameLoaderClientBlackBerry's playerId to MMRPlayer::load()
because MMRPlayer::load() added playerId as a new parameter, which
is required to initiate a MediaSSLHandlerStream to deal with
certificate failure when loading a "https" media url.

Internally reviewed by Joe Mason <​jmason@rim.com>.

No new tests since there's no functional change.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

11:47 AM Changeset in webkit [129243] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Add setters to WebFilterOperation for IPC pickling
​https://bugs.webkit.org/show_bug.cgi?id=97147

Reviewed by James Robinson.

Source/Platform:

These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.

Test: WebFilterOperationsTest.saveAndRestore

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):

  • chromium/src/WebFilterOperation.cpp:

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

11:13 AM Changeset in webkit [129242] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.

  • WebKit.gyp:
11:09 AM Changeset in webkit [129241] by barraclough@apple.com
  • 5 edits in trunk

Global Math object should be configurable but isn't
​https://bugs.webkit.org/show_bug.cgi?id=55343

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This has no performance impact.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • Make 'Math' a regular property.

LayoutTests:

Added test case.

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js:
    • Added test case.
10:43 AM Changeset in webkit [129240] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-21

  • DEPS:
10:28 AM Changeset in webkit [129239] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebSocket] Receiving a large message is really slow
​https://bugs.webkit.org/show_bug.cgi?id=97237

Patch by Evan Wallace <​evan.exe@gmail.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

WebSocketChannel always reallocates its internal buffer when it receives
and appends new data which causes dramatic slowdowns for messages over
2 MB in size. This patch changes the internal buffer of WebSocketChannel
from a raw char array to a Vector<char> and uses its amortized append()
method. This brings the time to receive a 5 MB message from 5.2 seconds
to 0.25 seconds.

This patch is only for optimization. No new tests are needed.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::resume):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::skipBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::processFrame):

  • Modules/websockets/WebSocketChannel.h:
9:50 AM Changeset in webkit [129238] by Carlos Garcia Campos
  • 9 edits
    1 copy in trunk

[GTK] Implement ViewState methods in PageClientImpl in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=97202

Reviewed by Martin Robinson.

Source/WebKit2:

Implement isViewWindowActive(), isViewFocused(), isViewVisible()
and isViewInWindow() in PageClientImpl.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewSetFocus): New private method used by WTR to focus the
WebView.

  • UIProcess/API/C/gtk/WKViewPrivate.h: Added.
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewWindowActive): Return
webkitWebViewBaseIsInWindowActive().
(WebKit::PageClientImpl::isViewFocused): Return
webkitWebViewBaseIsFocused().
(WebKit::PageClientImpl::isViewVisible): Return
webkitWebViewBaseIsVisible().
(WebKit::PageClientImpl::isViewInWindow): Return
webkitWebViewBaseIsInWindow().

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseNotifyResizerSize): Updated to not receive the
window as parameter since it's now saved in the instance struct.
(toplevelWindowResizeGripVisibilityChanged): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(toplevelWindowFocusInEvent): Update ViewWindowIsActive flag and
notify the WebPageProxy if it changed.
(toplevelWindowFocusOutEvent): Ditto.
(webkitWebViewBaseSetToplevelOnScreenWindow): Set the toplevel
on-screen window where the view is currently added and notify
WebPageProxy if it changed.
(webkitWebViewBaseRealize): Call
webkitWebViewBaseSetToplevelOnScreenWindow() if the view has been
added to an on-screen window.
(webkitWebViewBaseFinalize): Reset the toplevel on-screen window
to make sure all signals are disconnected when the view is
destroyed.
(webkit_web_view_base_init): Remove unneeded initialization.
(resizeWebKitWebViewBaseFromAllocation): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(webkitWebViewBaseMap): Update ViewIsVisible flag and notify
WebPageProxy if it changed.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseFocusInEvent): Call webkitWebViewBaseSetFocus()
passing true to focus the view.
(webkitWebViewBaseFocusOutEvent): Call webkitWebViewBaseSetFocus()
passing false to unfocus the view.
(webkitWebViewBaseParentSet): Reset the toplevel on-screen window
if the view is re-parented.
(webkit_web_view_base_class_init): Add implementations for map and
parent-set virtual functions.
(webkitWebViewBaseSetFocus): Update the ViewIsFocused and notify
WebPageProxy if it changed.
(webkitWebViewBaseIsInWindowActive):
(webkitWebViewBaseIsFocused):
(webkitWebViewBaseIsVisible):
(webkitWebViewBaseIsInWindow):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Use a GTK_WINDOW_TOPLEVEL instead of
POPUP for this test to make sure the view receives focus change
events.

Tools:

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::focus): Focus the view.

9:45 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
9:44 AM Changeset in webkit [129237] by aestes@apple.com
  • 52 edits in branches/safari-534.58-branch

Source/WebCore: Update Localizable.strings after merging plug-in blacklisting changes.

  • English.lproj/Localizable.strings:

Source/WebKit/mac: Merge r119543.

2012-06-05 Anders Carlsson <​andersca@apple.com>

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

Source/WebKit/win: Merge r116687.

2012-05-10 Anders Carlsson <​andersca@apple.com>

Rename the missing plug-in indicator to the unavailable plug-in indicator
​https://bugs.webkit.org/show_bug.cgi?id=86136

Reviewed by Sam Weinig.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Source/WebKit2: Merge r117634.

2012-05-18 Anders Carlsson <​andersca@apple.com>

Missing plugin msg becomes "insecure plugin version" after Real Player page refresh
​https://bugs.webkit.org/show_bug.cgi?id=86903
<rdar://problem/11477163>

Reviewed by Andreas Kling.

Set blocked to false before returning early when the plug-in doesn't exist.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPluginPath):

Tools: Merge r116716.

2012-05-10 Anders Carlsson <​andersca@apple.com>

WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
​https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>

Reviewed by Sam Weinig.

Update for WK2 API changes.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

WebKitLibraries: Merge r116695.

2012-05-10 Anders Carlsson <​andersca@apple.com>

WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
​https://bugs.webkit.org/show_bug.cgi?id=86150
<rdar://problem/9551196>

Reviewed by Sam Weinig.

Add WKShouldBlockPlugin.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
9:41 AM Changeset in webkit [129236] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build with ENABLE_WEBGL=false
​https://bugs.webkit.org/show_bug.cgi?id=97309

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-21
Reviewed by Eric Seidel.

WebKit no longer builds when WEBGL is not enabled.

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

9:32 AM Changeset in webkit [129235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Media player won't resize for the following source when first source fail to load
​https://bugs.webkit.org/show_bug.cgi?id=97342

Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Yong Li.

As platformPlayer will notify MediaPlayerPrivate for size change
when loading metadata failed (in this case hasVideo() is false),
we should prevent MediaPlayerPrivate to set width and height
attribute of media element, otherwise we won't get the correct
dimension for the following media sources.

Internally reviewed by Max Feil.

Test case: media/video-size.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::resizeSourceDimensions):

9:26 AM Changeset in webkit [129234] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] REGRESSION: 5 tests started to fail with newer Qt5
​https://bugs.webkit.org/show_bug.cgi?id=90687

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

When sending null data via POST method in XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.

The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.

  • platform/qt-5.0/Skipped:
  • platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
  • platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
  • platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
  • platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
9:21 AM Changeset in webkit [129233] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled
​https://bugs.webkit.org/show_bug.cgi?id=97280

Reviewed by Adele Peterson.

Source/WebCore:

Font::width() never applies word spacing to the first character in the TextRun. The
TextLayout optimization tried to achieve this behavior by not applying word spacing to
any character, which led to this bug.

Test: fast/text/word-space-with-kerning-2.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::TextLayout::TextLayout): Changed to use the given font rather than a version
without word spacing.
(WebCore::TextLayout::width): Added a check if the run starts with a space at a non-zero
offset. If that is the case, then the ComplexTextController has added word spacing to that
space, so subtract it here in order to maintain the behavior described above.

LayoutTests:

  • fast/text/word-space-with-kerning-2-expected.html: Added.
  • fast/text/word-space-with-kerning-2.html: Added.
9:14 AM Changeset in webkit [129232] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WTR] Memory leaks in InjectedBundleController::initialize()
​https://bugs.webkit.org/show_bug.cgi?id=97329

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

Fix leaks in InjectedBundleController::initialize() by adopting
strings created with WKStringCreateWithUTF8CString().

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

9:11 AM Changeset in webkit [129231] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
​https://bugs.webkit.org/show_bug.cgi?id=97235

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::keyDown):

8:37 AM Changeset in webkit [129230] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Skip flaky tests to make the bots green
​https://bugs.webkit.org/show_bug.cgi?id=97340

Unreviewed EFL gardening. Skip flaky tests
in order to make the bots green.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-21

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
8:33 AM Changeset in webkit [129229] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Add MIPS build slave to build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=96713

Patch by Gergely Kis <Gergely Kis> on 2012-09-21
Reviewed by Csaba Osztrogonác.

Added a build slave for MIPS, and enabled a builder for
Qt Linux MIPS32R2 little-endian release build.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:59 AM Changeset in webkit [129228] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

Wrong seperator for viewport meta in Popup scripts
​https://bugs.webkit.org/show_bug.cgi?id=97313

Reviewed by Yong Li.

The valid seperator for viewport meta is ',' instead of ';'.

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::generateHTML):

7:32 AM Changeset in webkit [129227] by yurys@chromium.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r129219.
​http://trac.webkit.org/changeset/129219
​https://bugs.webkit.org/show_bug.cgi?id=97338

Presumably broke Apple Mac compilation (Requested by yurys_ on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-21

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InspectorCanvasAgent.cpp:
  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasInstrumentation.h:
  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

7:25 AM Changeset in webkit [129226] by peter@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Switch back to a fixed fifo path for Android
​https://bugs.webkit.org/show_bug.cgi?id=97230

Reviewed by Tony Chang.

Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.

This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):

7:11 AM Changeset in webkit [129225] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk/Source

[chromium] Add test for ScrollingCoordinatorChromium
​https://bugs.webkit.org/show_bug.cgi?id=96657

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-09-21
Reviewed by James Robinson.

Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
fast (non-main thread) scrolling is enabled when necessary and that a proper
compositing layer structure is created for fixed position and accelerated
scrolling layers.

Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault

ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
ScrollingCoordinatorChromiumTest.wheelEventHandler
ScrollingCoordinatorChromiumTest.touchOverflowScrolling

  • WebKit.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp: Added.

(WebKit):
(MockWebViewClient):
(ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
(WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
(WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
(WebKit::TEST_F):

  • tests/data/fixed_position.html: Added.
  • tests/data/non_fast_scrollable.html: Added.
  • tests/data/touch_overflow_scrolling.html: Added.
  • tests/data/wheel_event_handler.html: Added.
7:05 AM Changeset in webkit [129224] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip a test because layoutTestController.setBackingScaleFactor() is missing
on Qt. This test timeouts at the moment, which considerably increase the testing time.

  • platform/qt/Skipped:
6:51 AM Changeset in webkit [129223] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=97330

Reviewed by Xan Lopez.

WebKitWebView:is-loading property allows to monitor when the view
is loading something without having to deal with load-changed
signal and all the details of the load status. This also allows to
know when a new load is started before it goes to STARTED status.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetProperty): Implement getter for is-loading
property.
(webkit_web_view_class_init): Add is-loading property.
(webkitWebViewSetIsLoading): Set whether web view is loading a
page and emit notify signal if the is-loading property has
changed. Also update the active URI when a new load operation has
started.
(webkitWebViewEmitLoadChanged): Set is-loading to FALSE when load
finishes.
(webkitWebViewLoadFailed): Set is-loading to FALSE when load fails.
(webkit_web_view_load_uri): Set is-loading to TRUE.
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_is_loading): Return whether the view is loading a
page.
(webkit_web_view_go_back): Set is-loading to TRUE.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(loadChangedCallback):
(loadFailedCallback):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(testWebViewIsLoading):
(beforeAll):

6:38 AM Changeset in webkit [129222] by anilsson@rim.com
  • 11 edits
    2 deletes in trunk/Source/WebKit

[BlackBerry] Remove obsolete compositing surface code
​https://bugs.webkit.org/show_bug.cgi?id=97314

Reviewed by Antonio Gomes.

Source/WebKit:

Remove compositing surface code from build system.

PR 208038.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The removed code allowed rendering of sublayers to a separate offscreen
surface.

Now that we composite root layer and all sublayers to the window
surface, this code is not needed anymore. In addition, we save some
memory by not allocating the unused offscreen surface.

PR 208038.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
  • WebKitSupport/BackingStoreCompositingSurface.h: Removed.
  • WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::buffer):
(BlackBerry::WebKit::GLES2Context::surfaceSize):
(BlackBerry::WebKit::GLES2Context::swapBuffers):

  • WebKitSupport/GLES2Context.h:

(GLES2Context):

  • WebKitSupport/SurfacePool.cpp:

(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):

  • WebKitSupport/SurfacePool.h:

(SurfacePool):

6:36 AM Changeset in webkit [129221] by peter@chromium.org
  • 8 edits
    2 deletes in trunk

Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
​https://bugs.webkit.org/show_bug.cgi?id=97227

Reviewed by Tony Chang.

Source/WebKit/chromium:

Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.

  • WebKitUnitTests.gyp:
  • tests/ForwardIOStreamsAndroid.cpp: Removed.
  • tests/ForwardIOStreamsAndroid.h: Removed.
  • tests/RunAllTests.cpp:

(main):

Tools:

We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.

Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.

This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. "rm" would fail if one of the earlier files
does not exist, and the "-f" argument doesn't seem to be reliable.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
6:16 AM Changeset in webkit [129220] by commit-queue@webkit.org
  • 10 edits in trunk

[WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
​https://bugs.webkit.org/show_bug.cgi?id=97326

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement scheduleAsynchronousClick() in WebKitTestRunner's
EventSender by sending a "MouseDown" and a "MouseUp" message
asynchronously to the WebProcess.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::createMouseMessageBody):
(WTR):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::scheduleAsynchronousClick):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unskip fast/events/popup-blocking-click-in-iframe.html for
WebKit2 now that WKTR's EventSender implements
scheduleAsynchronousClick.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
5:52 AM Changeset in webkit [129219] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
​https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-21
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

5:49 AM Changeset in webkit [129218] by caseq@chromium.org
  • 10 edits in trunk

Web Inspector: [refactoring] simplify interface to FileOutputStream
​https://bugs.webkit.org/show_bug.cgi?id=97226

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • change OutputStream interface to match that of stream;
  • fix OutputStream implementations (FileOutputStream and those in heap profiler);
  • fix usages in Timeline and HeapProfiler.
  • inspector/front-end/FileUtils.js:

(WebInspector.OutputStream.prototype.write):
(WebInspector.OutputStream.prototype.close):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onProgress):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
(WebInspector.FileOutputStream):
(WebInspector.FileOutputStream.prototype.open.callbackWrapper):
(WebInspector.FileOutputStream.prototype.open):
(WebInspector.FileOutputStream.prototype.write):
(WebInspector.FileOutputStream.prototype.close):
(WebInspector.FileOutputStream.prototype._onAppendDone):

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype.close):
(WebInspector.HeapSnapshotLoader.prototype.write):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotLoaderProxy.prototype.startTransfer):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype.transferChunk.callback):
(WebInspector.HeapProfileHeader.prototype.transferChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype._createFileWriter):
(WebInspector.TimelineModel.prototype.saveToFile.callback):
(WebInspector.TimelineModel.prototype.saveToFile):
(WebInspector.TimelineModelLoader):
(WebInspector.TimelineModelLoader.prototype.write):
(WebInspector.TimelineModelLoader.prototype.close):
(WebInspector.TimelineSaver):
(WebInspector.TimelineSaver.prototype.save):
(WebInspector.TimelineSaver.prototype._writeNextChunk):

LayoutTests:

  • adjust tests to new FileOutputStream interface;
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.StringOutputStream):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.write):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.close):
(initialize_Timeline):

5:49 AM Changeset in webkit [129217] by Simon Hausmann
  • 4 edits in trunk

[Qt] Error out early if we don't have ICU available

Reviewed by Tor Arne Vestbø.

Source/WTF:

  • WTF.pri:

Tools:

  • qmake/mkspecs/features/configure.prf:
5:16 AM Changeset in webkit [129216] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
5:08 AM Changeset in webkit [129215] by Alexandru Chiculita
  • 10 edits
    2 adds in trunk

-webkit-clip-path is applied on elements that are not descendant of the container
​https://bugs.webkit.org/show_bug.cgi?id=97217

Reviewed by Dirk Schulze.

Source/WebCore:

The clip-path was set on the GraphicsContext, but was never restored, thus making all the layers
rendered in the same "group" of save/restore state use the same clip-path.

Test: css3/masking/clip-path-restore.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
clip-path property should create a stacking-context, otherwise the RenderLayers will not be nested,
meaning that the clip-path of the parent is not going to apply correctly.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Added a test to check that the clip-path is removed from the GraphicsContext in the second paint call.
clip-path-circle-relative-overflow had incorrect result before, so I've udpated the results on Mac
and added test expectations for the others.

  • css3/masking/clip-path-restore-expected.html: Added.
  • css3/masking/clip-path-restore.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
5:05 AM Changeset in webkit [129214] by Simon Hausmann
  • 4 edits in trunk

[Qt] Bail out when trying to build WebKit with Qt != 5

Reviewed by Tor Arne Vestbø.

Moved check for Qt version out of default_pre into top-level WebKit.pro,
because we never reach default_pre.prf due to the lack of .qmake.conf support
in older versions of Qt/QMake.

.:

  • WebKit.pro:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
5:00 AM Changeset in webkit [129213] by commit-queue@webkit.org
  • 6 edits in trunk

WebKitTestRunner needs to print frame load delegate information
​https://bugs.webkit.org/show_bug.cgi?id=42705

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

LayoutTests:

Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/wk2/Skipped:
4:35 AM Changeset in webkit [129212] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL] EventSender should mimic CTRL+o emacs shortcut
​https://bugs.webkit.org/show_bug.cgi?id=97224

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Fix bad use of temporary object causing wrong editing
callback dumping.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldInsertText):

Tools:

Add support for mimicking CTRL+o emacs shortcut in EFL's
EventSender in DumpRenderTree and WebKitTestRunner.

  • DumpRenderTree/efl/EventSender.cpp:

(sendKeyDown):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::keyDown):

LayoutTests:

Rebaseline editing/input/emacs-ctrl-o.html test now
that EFL's EventSender supports mimicking CTRL+o
emacs keyboard shortcut and unskip the test for
EFL WK2 now that the output matches the one for
EFL WK1.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/editing/input/emacs-ctrl-o-expected.png:
  • platform/efl/editing/input/emacs-ctrl-o-expected.txt:
3:43 AM BadContent edited by Csaba Osztrogonác
add one more spammer (diff)
3:31 AM Changeset in webkit [129211] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
​https://bugs.webkit.org/show_bug.cgi?id=97317

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-21

  • platform/efl/TestExpectations:
  • platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
3:23 AM Changeset in webkit [129210] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] Re-fix clean builds

Reviewed by Tor Arne Vestbø.

Re-introduce the sanitization for LIBS when creating a module to use
LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
causes build issues when depending system libraries end up in LIBS before
LIBS_PRIVATE.

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/functions.prf:
3:17 AM Changeset in webkit [129209] by commit-queue@webkit.org
  • 3 edits
    24 adds in trunk/LayoutTests

[EFL] Move frame flattening tests to WK1 specific TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97315

Unreviewed EFL gardening.

Generate baselines for frame flattening tests using WK2 since the tests
are passing with it, and move the tests to WebKit1-specific
TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
3:13 AM Changeset in webkit [129208] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove unused functions of LocalizedDate.h
​https://bugs.webkit.org/show_bug.cgi?id=97311

Reviewed by Kentaro Hara.

WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.

No new tests because of no behavior changes.

  • platform/text/Localizer.h:

(Localizer): Moved comments from LocalizedDate.h.

  • platform/text/LocalizedDate.h:

(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.

  • platform/text/LocalizedDateICU.cpp:

(WebCore): ditto.

  • platform/text/LocalizedDateWin.cpp:

(WebCore): ditto.

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore): ditto.

3:08 AM Changeset in webkit [129207] by keishi@webkit.org
  • 5 edits in trunk/Source

Add datalist suggestions into DateTimeChooserParameters
​https://bugs.webkit.org/show_bug.cgi?id=97292

Reviewed by Kent Tamura.

Source/WebCore:

We read datalist suggestions, add them to DateTimeChooserParameters,
and pass them to the page popup.

No new tests. No behavior change yet.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): Read datalist suggestions and add them to DateTimeChooserParameters

  • platform/DateTimeChooser.h:

(DateTimeChooserParameters): Added localizedSuggestionValues so we can show localized values inside the page popup.

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.

3:06 AM Changeset in webkit [129206] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

[Forms] DateTimeEditElement::layout() should take date time format as a parameter
​https://bugs.webkit.org/show_bug.cgi?id=97300

Reviewed by Kent Tamura.

This patch introduces DateTimeEditElement::LayoutParameters struct for
passing four parameters to DateTimeEditElement::layout() for passing
date time format from client of DateTimeEditElement instead of
DateTimeEditElement::layout() takes time or short time format.

This patch is a part of preparation of introducing multiple fields
date/datetime/month/week input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::updateInnerTextValue): Changed to use LayoutParmeters.

  • html/shadow/DateTimeEditElement.cpp: Removed unused include files, LocalizedDate.h and LocalizedNumber.h.

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed parameters to LayoutParmeters.
(WebCore::DateTimeEditElement::LayoutParameters::shouldHaveSecondField): Moved from DateTimeEditBuilder::needSecondField().
(WebCore::DateTimeEditElement::layout): Changed to take LayoutParameters.
(WebCore::DateTimeEditElement::setValueAsDate): ditto
(WebCore::DateTimeEditElement::setEmptyValue): ditto

  • html/shadow/DateTimeEditElement.h: Removed unused classe declarations DateComponents and DateTimeEditLayouter.

(LayoutParameters): Added to bundle parameters for layout().
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Added.

2:44 AM Changeset in webkit [129205] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: render grid scale to the right / at bottom in case box is close to 0 on that axis.
​https://bugs.webkit.org/show_bug.cgi?id=97219

Reviewed by Vsevolod Vlasov.

Otherwise, it is hard to inspect objects close to (0, 0)

  • inspector/InspectorOverlayPage.html:
2:22 AM Changeset in webkit [129204] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r129086.
​http://trac.webkit.org/changeset/129086
​https://bugs.webkit.org/show_bug.cgi?id=97312

Broke input rendering (Requested by shinyak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-21

  • html/BaseButtonInputType.cpp:

(WebCore):

  • html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType):
(BaseButtonInputType):

  • html/FileInputType.cpp:

(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

  • html/InputType.cpp:
  • html/InputType.h:

(InputType):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::updateFromElement):
(WebCore):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::text):

  • rendering/RenderButton.h:

(RenderButton):

2:16 AM Changeset in webkit [129203] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove useless class prototypes from Vibration.h
​https://bugs.webkit.org/show_bug.cgi?id=97304

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-09-21
Reviewed by Kentaro Hara.

Remove two useless class prototype statements in the Vibration.h

  • Modules/vibration/Vibration.h:
1:01 AM Changeset in webkit [129202] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Changed fast/text/international/hebrew-selection.html expectation
from Failure to ImageOnlyFailure to match the actual results.

  • platform/chromium/TestExpectations:
12:58 AM Changeset in webkit [129201] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add MIPS or32 function
​https://bugs.webkit.org/show_bug.cgi?id=97157

Patch by Chao-ying Fu <​fu@mips.com> on 2012-09-21
Reviewed by Gavin Barraclough.

Add a missing or32 function.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::or32): New function.
(MacroAssemblerMIPS):

12:45 AM Changeset in webkit [129200] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark accessibility/loading-iframe-updates-axtree.html as crashing
intermittently on Linux in addition to Win and Mac.

  • platform/chromium/TestExpectations:
12:31 AM Changeset in webkit [129199] by zandobersek@gmail.com
  • 39 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining MathML tests after r129146.

  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.png:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.png:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.png:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.png:
  • platform/gtk/mathml/presentation/underover-expected.txt:
  • platform/gtk/mathml/xHeight-expected.png:
  • platform/gtk/mathml/xHeight-expected.txt:
12:02 AM Changeset in webkit [129198] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Prepare CalendarPicker so we can add another picker, SuggetionPicker
​https://bugs.webkit.org/show_bug.cgi?id=97193

Reviewed by Kent Tamura.

Preparation so we can add another picker to CalendarPicker and switch
between them.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.css:

(.calendar-picker): Added so we can apply these styles just to calendar picker.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.validateConfig): Renamed so each picker can validate the config object.
(initialize):
(closePicker): Call Picker.cleanup().
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype.cleanup): Cleanup event listener on document.body.

  • Resources/pagepopups/pickerCommon.js:

(Picker.prototype.cleanup):

Note: See TracTimeline for information about the timeline view.