⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 28, 2013:

11:23 PM Changeset in webkit [153418] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Don't update the text track override CSS every time a media element is created.
<​http://webkit.org/b/119199>
<rdar://problem/14572855>

Reviewed by Darin Adler.

We should only have to update the CSS if the accessibility caption preferences are changed.
This was forcing a full style recalc in every Document any time a media element is instantiated.

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):

9:37 PM Changeset in webkit [153417] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r153399. <rdar://problem/14549536>

9:27 PM Changeset in webkit [153416] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source/WebKit2

Merged r153404. <rdar://problem/14444331>

9:22 PM Changeset in webkit [153415] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153402. <rdar://problem/14517068>

8:08 PM Changeset in webkit [153414] by aestes@apple.com
  • 2 edits in trunk/Tools

Include <stdio.h> to declare perror()
​https://bugs.webkit.org/show_bug.cgi?id=119198

Reviewed by Andreas Kling.

Silences an implicit declaration warning.

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
6:16 PM Changeset in webkit [153413] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Stop exporting Widget::frameRectsChanged()
​https://bugs.webkit.org/show_bug.cgi?id=119196

Reviewed by Darin Adler.

The definition is inlined in a private header, so there's no need to
export a symbol to link against. On the Mac, since we compile with
-fvisibility-inlines-hidden, removing the symbol from the export file
silences an ld warning about exporting a hidden symbol.

  • WebCore.exp.in: Removed ZN7WebCore6Widget17frameRectsChangedEv.
4:36 PM Changeset in webkit [153412] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Clean up CSSPrimitiveValue::equals a bit
​https://bugs.webkit.org/show_bug.cgi?id=119195

Reviewed by Andreas Kling.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::equals):
This should not change behavior, but is quite a bit clearer.

3:08 PM Changeset in webkit [153411] by Antoine Quint
  • 2 edits in trunk/LayoutTests

fast/forms/input-in-table-cell-no-value.html fails on platform without ENABLE(INPUT_TYPE_DATE)
​https://bugs.webkit.org/show_bug.cgi?id=90987

This test now passes on Mac so we don't need to skip it any longer.

Reviewed by Anders Carlsson.

  • platform/mac/TestExpectations:
11:04 AM Changeset in webkit [153410] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION: Crash when opening Facebook.com
​https://bugs.webkit.org/show_bug.cgi?id=119155

Reviewed by Andreas Kling.

Scope nodes are always objects, so we should be using SpecObjectOther
rather than SpecCellOther. Marking Scopes as CellOther leads to a
contradiction in the CFA, resulting in bogus codegen.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

Jul 27, 2013:

11:48 PM Changeset in webkit [153409] by ryuan.choi@samsung.com
  • 6 edits in trunk

[EFL] Bump required version of EFL to 1.7
​https://bugs.webkit.org/show_bug.cgi?id=119144

Reviewed by Christophe Dumez.

.:

We have supported 1.6 for Tizen build since r137203.
But Tizen now supports 1.7+ after Tizen released 2.0.

  • Source/cmake/OptionsEfl.cmake:

Bumped EFL to 1.7 and removed promotion.

Source/WebCore:

  • platform/efl/FileSystemEfl.cpp: Removed workaround code which was fixed at Eina 1.7

(WebCore::listDirectory):

Tools:

  • MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
10:14 PM Changeset in webkit [153408] by commit-queue@webkit.org
  • 19 edits in trunk/Source

Replace all uses of GraphicsLayer::create function with the one that takes a GraphicsLayerFactory
​https://bugs.webkit.org/show_bug.cgi?id=119186

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-07-27
Reviewed by Anders Carlsson.

Source/WebCore:

Remove GraphicsLayer::create(GraphicsLayerClient*) function since it's
been deprecated by r130072.

  • WebCore.exp.in:
  • WebCore.order:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

Source/WebKit/blackberry:

Replace GraphicsLayer::create calls and add a new function WebPagePrivate::graphicsLayerFactory().

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::graphicsLayerFactory):
(BlackBerry::WebKit::WebPagePrivate::overlayLayer):

  • Api/WebPage_p.h:
  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::addLayer):

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):

Source/WebKit/qt:

  • WebCoreSupport/TextureMapperLayerClientQt.cpp:

(TextureMapperLayerClientQt::setRootGraphicsLayer):

Source/WebKit2:

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):

5:05 PM Changeset in webkit [153407] by ap@apple.com
  • 5 edits in trunk/Source/WebCore

HTMLParserScheduler gets into an inconsistent state when suspended for reasons
other than WillDeferLoading
​https://bugs.webkit.org/show_bug.cgi?id=119172

Reviewed by Sam Weinig.

When loading is not deferred, even a suspended parser will be processing new data
from network, potentially starting its next chunk timer.

Limit suspending to when we can actually enforce it.

Here is what happens for each ReasonForSuspension:

  • JavaScriptDebuggerPaused: continuing to parse is probably wrong, but in practice,

this is unlikely to happen while debugging, and wasn't properly prevented before
this patch anyway.

  • WillDeferLoading: No change in behavior.
  • DocumentWillBecomeInactive: This is about page cache, and documents are only allowed

to be cached when fully loaded.

  • PageWillBeSuspended: This appears to be part of Frame::suspendActiveDOMObjectsAndAnimations()

implementation, I'm guessing that it is appropriate to continue loading.

  • dom/Document.cpp:

(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
Only suspend/resume parsing when loading is deferred. This is not expressed directly,
but it's important to do this to avoid executing JS behind alerts and other modal dialogs.

  • html/parser/HTMLParserScheduler.h: Added m_suspended member variable for assertions.
  • html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
(WebCore::HTMLParserScheduler::scheduleForResume):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):
Update m_suspended and assert as appropriate. No behavior changes for release mode.

  • page/Frame.cpp: (WebCore::Frame::suspendActiveDOMObjectsAndAnimations):

Added a FIXME.

5:04 PM Changeset in webkit [153406] by ap@apple.com
  • 6 edits in trunk/Source/WebCore

Make SuspendableTimer safer
​https://bugs.webkit.org/show_bug.cgi?id=119127

Reviewed by Sam Weinig.

SuspendableTimer now enforces that it stays suspended until resumed (or until stopped
and started again). To ensure this, TimerBase is now a private base class, and parts of
its interface that clients use are reimplemented with suspend/resume in mind.

Derived classes are still allowed to override TimerBase virtual functions (notably
fired() and alignedFireTime()).

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueueTimer): Removed an extraneous WTF_MAKE_NONCOPYABLE,
TimerBase has it already.
(WebCore::DocumentEventQueueTimer::create): Use our normal create() pattern.
(WebCore::DocumentEventQueue::DocumentEventQueue): Made the constructor private, accordingly.
(WebCore::DocumentEventQueue::cancelEvent): Use SuspendableTimer::cancel(), which
is a new name to disambiguate TimerBase::stop() and ActiveDOMObject::stop().
(WebCore::DocumentEventQueue::close): Ditto.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::fired): Now that SuspendableTimer knows whether it's currently
suspended, assert that it's not.
(WebCore::DOMTimer::didStop): Separated ActiveDOMObject::stop() implementation from
additional cleanup, allowing for better SuspendableTimer encapsulation.

  • page/DOMTimer.h: Added FINAL and OVVERIDE specifiers as appropriate.
  • page/SuspendableTimer.h: Added FINAL (and OVERRIDE) qualifiers to ActiveDOMObject

methods. A derived class that wants to override current behavior is most likely not
a timer, and thus shouldn't be a derived class.
(WebCore::SuspendableTimer::isActive): SuspendableTimer with a next fire time is
active even if suspended, we shouldn't overwrite its saved data thinking that it's
inactive.
(WebCore::SuspendableTimer::isSuspended): Exposed to clients (m_suspended is no
longer debug only).

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer): Updated for new variable names.
(WebCore::SuspendableTimer::stop): This is ActiveDOMObject::stop(), which is called
before final destruction. We don't track this state directly, but can approximate
with setting m_suspended, so even if someone tries to start the timer afterwards,
it won't fire.
(WebCore::SuspendableTimer::suspend): Updated for new names.
(WebCore::SuspendableTimer::resume): Ditto.
(WebCore::SuspendableTimer::didStop): No-op default implementation for client hook.
(WebCore::SuspendableTimer::cancel): Equivalent of TimerBase::stop(), which also
works when suspended.
(WebCore::SuspendableTimer::startRepeating): Replacement for TimerBase function with
the same name, which works correctly when suspended. We don't want to actually start
the timer in this case.
(WebCore::SuspendableTimer::startOneShot): Ditto.
(WebCore::SuspendableTimer::repeatInterval): Ditto.
(WebCore::SuspendableTimer::augmentFireInterval): Ditto.
(WebCore::SuspendableTimer::augmentRepeatInterval): Ditto.

4:53 PM Changeset in webkit [153405] by bshafiei@apple.com
  • 2 edits in branches/safari-537-branch/Source/ThirdParty

Merged r153403.

4:44 PM Changeset in webkit [153404] by Chris Fleizach
  • 8 edits in trunk/Source/WebKit2

AX: VoiceOver not working with data detection page overlays
​https://bugs.webkit.org/show_bug.cgi?id=118680

Reviewed by Sam Weinig.

Expose API in BundlePageOverlay so that accessibility attributes can be retrieved through the overlay.
This requires two methods in a new callback struct. One to copy the attribute names, and the other to
copy the attribute values. I've folded both parameterized and non-parameterized attribute names into one method
with a boolean to determine which one should be used. The non-parameterized attributes are not used or passed to the
overlay at this time as there are no clients with such a need.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::setAccessibilityClient):
(PageOverlayClientImpl::PageOverlayClientImpl):
(PageOverlayClientImpl::copyAccessibilityAttributeValue):
(PageOverlayClientImpl::copyAccessibilityAttributeNames):
(WKBundlePageOverlaySetAccessibilityClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::copyAccessibilityAttributeValue):
(WebKit::PageOverlay::copyAccessibilityAttributeNames):

  • WebProcess/WebPage/PageOverlay.h:

(WebKit::PageOverlay::Client::copyAccessibilityAttributeValue):
(WebKit::PageOverlay::Client::copyAccessibilityAttributeNames):
(WebKit::PageOverlay::client):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageOverlayCopyAccessibilityAttributeValue):
(WebKit::WebPage::pageOverlayCopyAccessibilityAttributesNames):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject _convertScreenPointToWindow:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):

4:20 PM Changeset in webkit [153403] by mrowe@apple.com
  • 2 edits in trunk/Source/ThirdParty

Fix builds against an SDK.

  • gtest/xcode/Config/FrameworkTarget.xcconfig: Ensure that gtest.framework is installed

in a location compatible with the SDK generation process.

4:14 PM Changeset in webkit [153402] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

If entering fullscreen for a window fails, don't leave things in a bad state
​https://bugs.webkit.org/show_bug.cgi?id=119179
<rdar://problem/14517068>

Reviewed by Sam Weinig.

On Lion, attempting to take a video fullscreen when the Safari window is already
fullscreen can sometimes fail, and AppKit informs us via windowDidFailToEnterFullScreen:

When this happens we have to undo the work done when entering fullscreen, to
avoid leaving things in a bad state.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):

3:23 PM Changeset in webkit [153401] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Add assertions for CSSPrimitiveValue's m_value.valueID accessor
​https://bugs.webkit.org/show_bug.cgi?id=119180

Reviewed by Andreas Kling.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):
Assert that the CSSPrimitiveValue is holding a CSSValueID before accessing it.

2:40 PM Changeset in webkit [153400] by akling@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION(r153380): Can't open messages on Gmail
​https://bugs.webkit.org/show_bug.cgi?id=119165

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2013-07-27
Reviewed by Andreas Kling.

This bug was caused by r153380. The bug doesn't reproduce as long as WebKit is built by clang 4.2 and later
or final is disabled (it could be clang 4.1 and later but we don't have information about that).

Fix the bug by disabling final on earlier versions of clang. Unfortunately we can only check versions of
Apple clang since clang_major and clang_minor are vendor dependent.

  • wtf/Compiler.h:
1:49 PM Changeset in webkit [153399] by weinig@apple.com
  • 4 edits
    2 adds in trunk

Stop pretending to support <string> for text-align.
​https://bugs.webkit.org/show_bug.cgi?id=119107

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/text-align-string-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Stop pretending to support <string> for text-align.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyTextAlign::applyValue):
ASSERT that only value IDs get passed.

LayoutTests:

  • fast/css/text-align-string-crash-expected.txt: Added.
  • fast/css/text-align-string-crash.html: Added.

Jul 26, 2013:

9:48 PM Changeset in webkit [153398] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Introduce toSVGRectElement(), use it
​https://bugs.webkit.org/show_bug.cgi?id=119126

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGRectElement*> can
be changed with toSVGRectElement().

No new tests, no behavior change.

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromRectElement):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • svg/SVGRectElement.h:

(WebCore::toSVGRectElement):

6:17 PM Changeset in webkit [153397] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

With frame flattening on, too many resize events fired if document is resized in onresize handler.
​https://bugs.webkit.org/show_bug.cgi?id=119075

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-07-26
Reviewed by Simon Fraser.

With ​http://trac.webkit.org/changeset/149287, WebCore also sends resize event in FrameView::setFrameRect. When
flattening an iframe, setFrameRect could be called multiple times from RenderFrameBase::layoutWithFlattening and
we could get multiple resize events. This patch adds a flag in FrameView to disallow sending resize events if
we are inside layoutWithFlattening. The resize event will be sent in performPostLayoutTasks after the iframe
is done laying out.

Manually tested by verifying the rendering slowness in www.hi-pda.com is fixed when frame flattening is enabled.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::setFrameRect):

  • page/FrameView.h:

(WebCore::FrameView::setResizeEventAllowed):
(WebCore::FrameView::resizeEventAllowed):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

5:57 PM Changeset in webkit [153396] by dino@apple.com
  • 10 edits
    2 adds in trunk

Allow new transitions to run even when controller is suspended
​https://bugs.webkit.org/show_bug.cgi?id=119171
<rdar://problem/14511404>

Reviewed by Simon Fraser.

Source/WebCore:

Expose a new property on AnimationController that allows newly created
animations to run even if the controller says it is suspended. See WebKit
ChangeLog for more details.

Test: transitions/created-while-suspended.html

  • WebCore.exp.in: Export the new methods so WebView can use them.
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Initialize new flag to false.
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): Check new flag is not true.
(WebCore::AnimationControllerPrivate::setAllowsNewAnimationsWhileSuspended): Expose setter.
(WebCore::AnimationController::allowsNewAnimationsWhileSuspended): "Public" getter.
(WebCore::AnimationController::setAllowsNewAnimationsWhileSuspended): "Public" setter.

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:

(WebCore::AnimationControllerPrivate::allowsNewAnimationsWhileSuspended):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::CompositeAnimation): Only suspend if new flag is false. Everything else
relies on the m_suspended flag, so the real code change is this one line.

Source/WebKit/mac:

Expose a new SPI on WebView that triggers the (buggy) old behaviour
for animations, such that any newly created animations will start even
when the document is supposedly suspended. It turns out that client content was
unknowingly relying on this behaviour - e.g. suspending a view, loading a
bunch of new content, bringing the view on screen and then unsuspending. In this
situation, we were not running CSS transitions, because the page was suspended.
However, JS was still triggering them, and content was expecting a transitionEnd event.

  • WebView/WebView.mm:

(-[WebView allowsNewCSSAnimationsWhileSuspended]): Calls into AnimationController.
(-[WebView setAllowsNewCSSAnimationsWhileSuspended:]): Ditto.

  • WebView/WebViewPrivate.h: New methods listed above.

LayoutTests:

This is actually a test to make sure this fix didn't break anything. There is no
way to trigger the new behaviour from the test system (or from Safari).

5:24 PM Changeset in webkit [153395] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit/mac

Merged r153379. <rdar://problem/14554723>

5:22 PM Changeset in webkit [153394] by Lucas Forschler
  • 16 edits in branches/safari-537-branch/Source

Merged r153378. <rdar://problem/14549021>

4:54 PM Changeset in webkit [153393] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153349. <rdar://problem/14545393>

4:51 PM Changeset in webkit [153392] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r153366. <rdar://problem/14556358>

4:48 PM Changeset in webkit [153391] by Lucas Forschler
  • 5 edits
    1 copy in branches/safari-537-branch

Merged r153344. <rdar://problem/13439291>

4:46 PM Changeset in webkit [153390] by Lucas Forschler
  • 5 edits
    1 copy in branches/safari-537-branch

Merged r153107. <rdar://problem/14494064>

4:43 PM Changeset in webkit [153389] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153102. <rdar://problem/14433205>

4:41 PM Changeset in webkit [153388] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152905. <rdar://problem/14489987>

4:19 PM Changeset in webkit [153387] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

ASSERT failure in wtf/CheckedBoolean.h line 43 on Windows
​https://bugs.webkit.org/show_bug.cgi?id=119170

Reviewed by Michael Saboff.

Added a copy constructor to CheckedBoolean.

  • wtf/CheckedBoolean.h:

(CheckedBoolean::CheckedBoolean):

4:00 PM Changeset in webkit [153386] by commit-queue@webkit.org
  • 3 edits
    6 adds
    2 deletes in trunk/LayoutTests

[CSS Shapes] New positioning model: support for polygon shape-outside
​https://bugs.webkit.org/show_bug.cgi?id=118085

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-07-26
Reviewed by Dirk Schulze.

Update polygon tests to work for new positioning model and migrate
them to be W3C spec tests. Thus, they have been imported from the
CSSWG repository now.

  • TestExpectations: Remove skip for replaced test.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Added.
  • csswg/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon.html: Removed.
3:54 PM Changeset in webkit [153385] by achristensen@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Added module definition file for building libEGL.
​https://bugs.webkit.org/show_bug.cgi?id=119162

Reviewed by Brent Fulgham.

  • ANGLE.vcxproj/libEGLCommon.props: Added reference to libEGL.def.
2:57 PM Changeset in webkit [153384] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::createMetadataKeyNames): Do not include Media Selection
synbols when building without Media Selection API.

2:21 PM Changeset in webkit [153383] by oliver@apple.com
  • 6 edits in trunk

REGRESSION(FTL?): Crashes in plugin tests
​https://bugs.webkit.org/show_bug.cgi?id=119141

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Re-export getStackTrace

  • interpreter/Interpreter.h:

Source/WebCore:

Getting the correct semantics to appease the inspector is fairly
awful with the iterator system. For the time being lets just revert
to requesting a full stack trace as we did in the past.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

LayoutTests:

Bring back plugin tests

  • platform/mac/TestExpectations:
2:17 PM Changeset in webkit [153382] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

Correct build when targeting a release that does not have the AVCF
Legible Output infrastructure.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Exclude

a soft-link target when the API doesn't exist.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

Correct include options for non-Legible Output supporting environments.
(WebCore::MediaPlayerPrivateAVFoundationCF::processLegacyClosedCaptionsTracks):
Prevent build failure when building with legacy caption support.

2:12 PM Changeset in webkit [153381] by fpizlo@apple.com
  • 6 edits
    6 adds in trunk

REGRESSION: Crash when opening a message on Gmail
​https://bugs.webkit.org/show_bug.cgi?id=119105

Source/JavaScriptCore:

Reviewed by Oliver Hunt and Mark Hahnenberg.

  • GetById patching in the DFG needs to be more disciplined about how it derives the slow path.


  • Fix some dumping code thread safety issues.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::dump):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::getPolymorphicStructureList):
(JSC::DFG::tryBuildGetByIDList):

LayoutTests:

Reviewed by Oliver Hunt and Mark Hahnenberg.

  • fast/js/dfg-get-by-id-unset-then-proto-less-warmup.html: Added.
  • fast/js/dfg-get-by-id-unset-then-proto-more-warmup.html: Added.
  • fast/js/dfg-get-by-id-unset-then-proto.html: Added.
  • fast/js/jsc-test-list
  • fast/js/script-tests/dfg-get-by-id-unset-then-proto-less-warmup.js: Added.

(foo):
(Blah):

  • fast/js/script-tests/dfg-get-by-id-unset-then-proto-more-warmup.js: Added.

(foo):
(Blah):

  • fast/js/script-tests/dfg-get-by-id-unset-then-proto.js: Added.

(foo):
(Blah):

1:41 PM Changeset in webkit [153380] by akling@apple.com
  • 102 edits in trunk

Apply FINAL to the RenderObject hierarchy.
<​http://webkit.org/b/115977>

Mostly from Blink r148795 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=148795>

  • rendering/: Beat things with the FINAL stick.
  • WebCore.exp.in: Export a now-needed symbol.
1:39 PM Changeset in webkit [153379] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Add another method that we need to set aside subviews for
​https://bugs.webkit.org/show_bug.cgi?id=119157
<rdar://problem/14554723>

Reviewed by Beth Dakin.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):

1:09 PM Changeset in webkit [153378] by timothy_horton@apple.com
  • 16 edits in trunk/Source

Add a mode where autosizing fixes the FrameView height to at least the WKView height
​https://bugs.webkit.org/show_bug.cgi?id=119104
<rdar://problem/14549021>

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Export FrameView::setAutoSizeFixedMinimumHeight.
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
Initialize m_autoSizeFixedMinimumHeight to 0.

(WebCore::FrameView::autoSizeIfEnabled):
Increase the FrameView height to m_autoSizeFixedMinimumHeight if necessary,
and do another layout. Store the computed intrinsic content size.

(WebCore::FrameView::setAutoSizeFixedMinimumHeight): Added.

  • page/FrameView.h:

(WebCore::FrameView::autoSizingIntrinsicContentSize): Added.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

Add autoSizingShouldExpandToViewHeight parameter.

  • UIProcess/API/mac/WKView.mm:

(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
Un-deprecate these as they're still useful if not sending a height.

(-[WKView shouldExpandToViewHeightForAutoLayout]):
(-[WKView setShouldExpandToViewHeightForAutoLayout:]):

  • UIProcess/API/mac/WKViewPrivate.h:

New property, forward to WebPageProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setAutoSizingShouldExpandToViewHeight):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::autoSizingShouldExpandToViewHeight):
New property, forward to WebPage.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
If enabled, update the FrameView's autoSizeFixedMinimumHeight.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setAutoSizingShouldExpandToViewHeight):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::autoSizingShouldExpandToViewHeight):
New property; if enabled, set FrameView's autoSizeFixedMinimumHeight,
otherwise reset it to 0.

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Retrieve intrinsic content size explicitly from the FrameView, as
it may not have used it as its final contentsSize if
autoSizeFixedMinimumHeight is set.

Set the WebPage's size in case the load is committed so that the
WebFrameLoaderClient doesn't reset us to the wrong size.

Update autoSizeFixedMinimumHeight if enabled when the view size changes.

12:19 PM Changeset in webkit [153377] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Remove workarounds now that rdar://problem/14390466 is fixed.
​https://bugs.webkit.org/show_bug.cgi?id=119150

Reviewed by Anders Carlsson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::createPlayer): Remove workaround to add legible output
after player is created.
(WebCore::AVFWrapper::createPlayerItem): Remove workaround to delay adding
legible output until player is created.
(WebCore::AVFWrapper::platformLayer): Get rid of unused temporary.

12:06 PM Changeset in webkit [153376] by fpizlo@apple.com
  • 4 edits in trunk/Tools

WKTR should know about the JSC extensions to testRunner
​https://bugs.webkit.org/show_bug.cgi?id=119154

Reviewed by Mark Hahnenberg and Geoffrey Garen.

This makes some fast/js tests pass.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::numberOfDFGCompiles):
(WTR::TestRunner::neverInlineFunction):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
11:17 AM Changeset in webkit [153375] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[mips] Fix LLINT build for mips backend
​https://bugs.webkit.org/show_bug.cgi?id=119152

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-07-26
Reviewed by Oliver Hunt.

  • offlineasm/mips.rb:
11:07 AM Changeset in webkit [153374] by mhahnenberg@apple.com
  • 4 edits
    3 adds in trunk

Setting a large numeric property on an object causes it to allocate a huge backing store
​https://bugs.webkit.org/show_bug.cgi?id=118914

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

There are two distinct actions that we're trying to optimize for:

new Array(100000);

and:

a = [];
a[100000] = 42;

In the first case, the programmer has indicated that they expect this Array to be very big,
so they should get a contiguous array up until some threshold, above which we perform density
calculations to see if it is indeed dense enough to warrant being contiguous.

In the second case, the programmer hasn't indicated anything about the size of the Array, so
we should be more conservative and assume it should be sparse until we've proven otherwise.

Currently both of those cases are handled by MIN_SPARSE_ARRAY_INDEX. We should distinguish
between them for the purposes of not over-allocating large backing stores like we see on
​http://www.peekanalytics.com/burgerjoints/

The way that we'll do this is to keep the MIN_SPARSE_ARRAY_INDEX for the first case, and
introduce a new heuristic for the second case. If we are putting to an index above a certain
threshold (say, 1000) and it is beyond the length of the array, then we will use a sparse
map instead. So for example, in the second case above the empty array has a blank indexing
type and a length of 0. We put-by-val to an index > 1000 and > a.length, so we'll use a sparse map.

This fix is ~800x speedup on the accompanying regression test :-o

  • runtime/ArrayConventions.h:

(JSC::indexIsSufficientlyBeyondLengthForSparseMap):

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):

LayoutTests:

Added new regression test for put-by-val-ing to a blank indexing type with a large index.
This fix is ~800x speedup on this regression test :-o

  • fast/js/regress/put-by-val-large-index-blank-indexing-type.html: Added.
  • fast/js/regress/script-tests/put-by-val-large-index-blank-indexing-type.js: Added.
9:22 AM Changeset in webkit [153373] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed gardening.

  • WebCore.vcxproj/WebCore.vcxproj: Add missing header file to ease code viewing.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
8:19 AM Changeset in webkit [153372] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerTiler fails to render layer after waking up
​https://bugs.webkit.org/show_bug.cgi?id=119146

Reviewed by George Staikos.

When the application is backgrounded, all tiles are freed up to
release memory back to the system. We also mark the contents as dirty
in LayerTiler::deleteTextures() so tiles will be repopulated when
waking up again.

The problem was caused by an optimization to avoid re-rendering tiles
repeatedly until the UI thread catches up with the fact that we have
indeed rendered those tiles (which will happen when the UI thread next
composites a frame).

When contents are dirty, we're not supposed to perform this
optimization (i.e. we're not supposed to skip rendering) because the
appearance of the layer has changed, so we do need to render those
tiles. Unfortunately, the code that was supposed to forget the list of
tiles rendered was in a conditional, "if (frontVisibility)", which
happened to be false sometimes when the app woke up again. So we ended
up perpetually skipping those render jobs, and the UI thread kept
yelling at us to render them.

Fixed by unconditionally dropping the list of tiles rendered when
contents are dirty.

This can't be detected without pixel tests, which BB DRT currently
doesn't support.

JIRA 452460

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerVisibility::clearTilesRendered):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):

7:41 AM Changeset in webkit [153371] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL): Fix lots of crashes in sh4 baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=119148

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-26
Reviewed by Csaba Osztrogonác.

  • jit/JSInterfaceJIT.h: "secondArgumentRegister" is wrong for sh4.
  • llint/LowLevelInterpreter32_64.asm: "move t0, a0" is missing

in nativeCallTrampoline for sh4. Reuse MIPS implementation to avoid
code duplication.

3:33 AM Changeset in webkit [153370] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL): Crash in sh4 baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=119138

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-26
Reviewed by Csaba Osztrogonác.

This crash is due to incomplete report of r150146 and r148474.

  • jit/JITStubsSH4.h:
1:34 AM Changeset in webkit [153369] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

  • Target.pri: Adding missing DFG files to the Qt build.

Jul 25, 2013:

10:54 PM Changeset in webkit [153368] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

GTK and Qt buildfix after the intrusive win buildfix r153360.

  • GNUmakefile.list.am:
  • Target.pri:
9:35 PM Changeset in webkit [153367] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused HTMLTextFormControlElement::textRendererAfterUpdateLayout
​https://bugs.webkit.org/show_bug.cgi?id=119121

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/3255ce725711707fe1fd18be91a6d06789517220.

  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:
8:59 PM Changeset in webkit [153366] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Fix document leak when selection is created inside the document
​https://bugs.webkit.org/show_bug.cgi?id=119122

Reviewed by Andreas Kling.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/b908cb4c8da93316d787de31c93f2a43de332a10

The bug was caused by FrameSelection::m_previousCaretNode holding onto a Node, leaking its document.
Fixed the bug by explicitly clearing it in FrameSelection::prepareForDestruction.

Test: editing/selection/leak-document-with-selection-inside.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::prepareForDestruction):

LayoutTests:

Added a regression test.

  • editing/selection/leak-document-with-selection-inside-expected.txt: Added.
  • editing/selection/leak-document-with-selection-inside.html: Added.
6:48 PM Changeset in webkit [153365] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix build break after r153360.

  • CMakeLists.txt: Add CommonSlowPathsExceptions.cpp.
6:41 PM Changeset in webkit [153364] by roger_fong@apple.com
  • 6 edits in trunk/Source

Unreviewed build fix, AppleWin port.

6:35 PM Changeset in webkit [153363] by bshafiei@apple.com
  • 3 edits in branches/safari-537-branch/Tools

Merged r153353. <rdar://problem/13562022>

6:24 PM Changeset in webkit [153362] by commit-queue@webkit.org
  • 3 edits
    2 moves
    2 adds
    2 deletes in trunk/LayoutTests

[CSS Shapes] New positioning model: support for inset rectangle shape-outside
​https://bugs.webkit.org/show_bug.cgi?id=118083

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-07-25
Reviewed by Dirk Schulze.

Update inset-rectangle tests to work with new positioning model.
Removed some test cases that aren't really needed or aren't applicable
with the new model. These test cases live in the CSS WG's repo now, so
they've been imported here.

  • TestExpectations: Remove skip lines for replaced tests.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html.
  • csswg/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Removed.
5:40 PM Changeset in webkit [153361] by roger_fong@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Followup to r153360.

5:22 PM Changeset in webkit [153360] by msaboff@apple.com
  • 6 edits
    2 adds in trunk/Source/JavaScriptCore

[Windows] Speculative build fix.

Moved interpreterThrowInCaller() out of LLintExceptions.cpp into new CommonSlowPathsExceptions.cpp
that is always compiled. Made LLInt::returnToThrow() conditional on LLINT being enabled.
Roger will add the new files to Windows project in another checkin.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • llint/LLIntExceptions.cpp:
  • llint/LLIntExceptions.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPathsExceptions.cpp: Added.

(JSC::CommonSlowPaths::interpreterThrowInCaller):

  • runtime/CommonSlowPathsExceptions.h: Added.
5:19 PM Changeset in webkit [153359] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing IntendedStructureChange.h,.cpp and

parser/SourceCode.h,.cpp.

5:18 PM Changeset in webkit [153358] by Brent Fulgham
  • 7 edits in trunk/Source/WTF

[Windows] Unreviewed build fix.

  • WTF.vcxproj/WTF.vcxproj: Add missing SixCharacterHash.h,.cpp files.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • wtf/NumberOfCores.h: Add export macro to numberOfProcessorCores.
  • wtf/PrintStream.h: Add export macro to dumpCharacter.
  • wtf/SixCharacterHash.h: Add export macro to sixCharacterHashStringToInteger

and integerToSixCharacterHashString.

  • wtf/text/CString.h: Add export macro to hash and equal methods.

(WTF::CStringHash::hash): Add export macro.

5:13 PM Changeset in webkit [153357] by andersca@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

ASSERT(m_vm->apiLock().currentThreadIsHoldingLock()); fails for Safari on current ToT
​https://bugs.webkit.org/show_bug.cgi?id=119108

Reviewed by Mark Hahnenberg.

Add a currentThreadIsHoldingAPILock() function to VM that checks if the current thread is the exclusive API thread.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase):

  • heap/Heap.cpp:

(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::collect):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/VM.h:

(JSC::VM::currentThreadIsHoldingAPILock):

4:57 PM Changeset in webkit [153356] by akling@apple.com
  • 30 edits in trunk/Source

ChromeClient::focusedNodeChanged() should be focusedElementChanged().
<​http://webkit.org/b/119110>

Reviewed by Anders Carlsson.

Source/WebCore:

Because only Elements can be focused.

  • dom/Document.cpp:

(WebCore::Document::setFocusedElement):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::focusedElementChanged):

  • page/Chrome.cpp:

(WebCore::Chrome::focusedElementChanged):

  • page/Chrome.h:
  • page/ChromeClient.h:

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::focusedElementChanged):

  • WebCoreSupport/ChromeClientBlackBerry.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::focusedElementChanged):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::focusedElementChanged):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::focusedElementChanged):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::focusedElementChanged):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
4:23 PM Changeset in webkit [153355] by kseo@webkit.org
  • 12 edits in trunk/Source

[WK2][Soup] Add private browsing support
​https://bugs.webkit.org/show_bug.cgi?id=118657

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Support private browsing by adding a method to create a private
browsing soup session. This private browsing session uses a
non-persistent cookie jar and does not use the disk cache feature.

No new tests. Covered by existing private browsing tests.

  • platform/network/NetworkStorageSession.h:

(WebCore::NetworkStorageSession::isPrivateBrowsingSession):
Add USE(SOUP) guard to isPrivateBrowsingSession() and m_isPrivate.

  • platform/network/ResourceHandle.h:

Add a factory method to create a private browsing session for soup.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::createPrivateBrowsingCookieJar):

  • platform/network/soup/CookieJarSoup.h:

Add a method to create a non-persistent cookie jar for private browsing.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
Initialize m_isPrivate to false.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
Implement the method by invoking ResourceHandle::createPrivateBrowsingSession.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupSession):
Extract common soup session creation code so that both defaultSession
and createPrivateBrowsingSession can use this function to create a soup
session.
(WebCore::ResourceHandle::defaultSession):
Change to use createSoupSession.
(WebCore::ResourceHandle::createPrivateBrowsingSession):
Create a session which uses a non-persistent cookie jar.

Source/WebKit2:

Support private browsing in WK2 by implementing private browsing
related methods in WebFrameNetworkingContext.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
Add USE(SOUP) guard.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

Add private browsing support methods. Copied from the Mac port.
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
Check if the frame enables private browsing and return the private
browsing session.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensurePrivateBrowsingSession):
Add USE(SOUP) guard.

4:14 PM Changeset in webkit [153354] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL): Most layout tests crashes
​https://bugs.webkit.org/show_bug.cgi?id=119089

Reviewed by Oliver Hunt.

  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution): Move prepareForExecutionImpl call into its own statement. This prevents the GCC-compiled
code to create the PassOwnPtr<JSC::JITCode> (intended as a parameter to the installOptimizedCode call) from the jitCode
RefPtr<JSC::JITCode> parameter before the latter was actually given a proper value through the prepareForExecutionImpl call.
Currently it's created beforehand and therefor holds a null pointer before it's anchored as the JIT code in
JSC::CodeBlock::setJITCode, which later indirectly causes assertions in JSC::CodeBlock::jitCompile.
(JSC::prepareFunctionForExecution): Ditto for prepareFunctionForExecutionImpl.

4:07 PM Changeset in webkit [153353] by mrowe@apple.com
  • 3 edits in trunk/Tools

Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
  • WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework

so they pull the version out of the SDK.

3:36 PM Changeset in webkit [153352] by kseo@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix: use of long long in CoreIPC::ArgumentEncoder and CoreIPC::ArgumentDecoder
​https://bugs.webkit.org/show_bug.cgi?id=118228

Reviewed by Anders Carlsson.

Build fails on some platforms where int64_t and long long are different types.

  • Shared/FileAPI/BlobRegistrationData.cpp:

(WebKit::BlobRegistrationData::encode):
Add explicit casts to int64_t.
(WebKit::BlobRegistrationData::decode):
Use int64_t instead of long long.

3:33 PM Changeset in webkit [153351] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix.

include path.

3:29 PM Changeset in webkit [153350] by zoltan@webkit.org
  • 5 edits in trunk/LayoutTests

[CSS Shapes] Add missing includes to shape-inside polygon tests
​https://bugs.webkit.org/show_bug.cgi?id=119098

Reviewed by Dirk Schulze.

We need to include subpixel-utils.js for tests which use simple-polygon.js, since it uses
SubPixelLayout, otherwise both the result/expected are generating incorrect output.

  • fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html:
  • fast/shapes/shape-inside/shape-inside-regular-polygon16.html:
  • fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html:
  • fast/shapes/shape-inside/shape-inside-regular-polygon8.html:
3:25 PM Changeset in webkit [153349] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Null check m_frame in maximum and minimumScrollPosition
​https://bugs.webkit.org/show_bug.cgi?id=119109
<rdar://problem/14545393>

Reviewed by Darin Adler.

  • page/FrameView.cpp:

(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
Null-check m_frame (and move the early-return after the clamp-to-0
as the revert in r152911 should have).

2:48 PM Changeset in webkit [153348] by andersca@apple.com
  • 5 edits in trunk

Localizable.strings generated by extract-localizable-strings should be UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=119106

Reviewed by Mark Rowe.

Source/WebCore:

  • English.lproj/Localizable.strings:

Re-encode this as UTF-8 and remove the BOM.

  • WebCore.xcodeproj/project.pbxproj:

Set the file encoding of Localizable.strings to UTF-8.

Tools:

Output strings as UTF-8.

  • Scripts/extract-localizable-strings:
2:40 PM Changeset in webkit [153347] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Don't force layout when querying a fixed or non-box margin/padding property
​https://bugs.webkit.org/show_bug.cgi?id=118032

Reviewed by David Hyatt.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/66427d0825fcc2975bd50220cdcaa2504d6f36e5.

This patch avoids layout in ComputedStyleExtractor::propertyValue for margin and padding properties
when they are of fixed length. According to the Blink patch's author, this improves the page load
time of economist.com by 27%.

The actual code change is significantly different from the original Blink patch since we've done
some refactorins in r152938 and r153067 to make this change more self-contained.

Test: fast/css/computed-width-without-renderer.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::zoomAdjustedPaddingOrMarginPixelValue):
(WebCore::paddingOrMarginIsRendererDependent):
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

LayoutTests:

Add a regression test inspired by the one added in
​https://chromium.googlesource.com/chromium/blink/+/ff234b1593b2b493d47f38f687d09a87bc42c9eb.

  • fast/css/computed-width-without-renderer-expected.txt: Added.
  • fast/css/computed-width-without-renderer.html: Added.
2:13 PM Changeset in webkit [153346] by achristensen@apple.com
  • 3 edits
    12 adds
    14 deletes in trunk/Source

Source/ThirdParty/ANGLE: Made Windows build system for ANGLE and removed existing broken build system.
Removed empty src/libGLESv2/shaders directory and old README files.
​https://bugs.webkit.org/show_bug.cgi?id=119103

Reviewed by Brent Fulgham.

  • ANGLE.vcxproj: Added.
  • ANGLE.vcxproj/ANGLEGenerated.vcxproj: Added.
  • ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Added.
  • ANGLE.vcxproj/libEGL.vcxproj: Added.
  • ANGLE.vcxproj/libEGL.vcxproj.filters: Added.
  • ANGLE.vcxproj/libEGLCommon.props: Added.
  • ANGLE.vcxproj/libGLESv2.vcxproj: Added.
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters: Added.
  • ANGLE.vcxproj/libGLESv2Common.props: Added.
  • ANGLE.vcxproj/translator.vcxproj: Added.
  • ANGLE.vcxproj/translator.vcxproj.filters: Added.
  • ANGLE.vcxproj/translatorCommon.props: Added.
  • src/ANGLE.sln: Removed.
  • src/compiler/preprocessor/preprocessor.vcxproj: Removed.
  • src/compiler/preprocessor/preprocessor.vcxproj.filters: Removed.
  • src/compiler/translator_common.vcxproj: Removed.
  • src/compiler/translator_common.vcxproj.filters: Removed.
  • src/compiler/translator_hlsl.vcxproj: Removed.
  • src/compiler/translator_hlsl.vcxproj.filters: Removed.
  • src/libEGL/README: Removed.
  • src/libEGL/libEGL.vcxproj: Removed.
  • src/libEGL/libEGL.vcxproj.filters: Removed.
  • src/libGLESv2/README: Removed.
  • src/libGLESv2/libGLESv2.vcxproj: Removed.
  • src/libGLESv2/libGLESv2.vcxproj.filters: Removed.
  • src/libGLESv2/shaders: Removed.

Source/WebKit: Made Windows build system for ANGLE.
​https://bugs.webkit.org/show_bug.cgi?id=119103

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKit.sln:

Added ANGLEGenerated, libEGL, libGLESv2, and translator projects.
These projects are currently not built.

1:56 PM Changeset in webkit [153345] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Provide ASM implemenation of 8-bit compare-and-swap
​https://bugs.webkit.org/show_bug.cgi?id=119084

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-25
Reviewed by Brent Fulgham.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap): Add a 32-bit X86 Assembly path for
Windows build.

1:52 PM Changeset in webkit [153344] by weinig@apple.com
  • 5 edits
    1 add in trunk

-[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
​https://bugs.webkit.org/show_bug.cgi?id=119099
<rdar://problem/13439291>

Reviewed by Enrica Casucci.

Source/WebCore:

Tests:

API Test: AttributedStringTest_Strikethrough

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):
Set the NSStrikethroughStyleAttributeName attribute when text-decoration: line-through is seen.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/AttributedString.mm:

(TestWebKitAPI::attributedString):
(TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
(TestWebKitAPI::AttributedStringTest_CustomFont::url):
(TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
(TestWebKitAPI::AttributedStringTest_Strikethrough::url):
(TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):

  • TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.

Add tests for attributed strings with strikethrough. Refactor the attributed string tests
to make adding more easier in the future.

1:40 PM Changeset in webkit [153343] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add some missing files:

runtime/VM.h,.cpp; Remove deleted JSGlobalData.h,.cpp.

1:37 PM Changeset in webkit [153342] by Brent Fulgham
  • 3 edits in trunk/Source/WTF

[Windows] Unreviewed build fix.

  • WTF.vcxproj/WTF.vcxproj: Add missing CompilationThread.h,.cpp
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
1:22 PM Changeset in webkit [153341] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make all jit & non-jit combos build cleanly
​https://bugs.webkit.org/show_bug.cgi?id=119102

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::counterValueForOptimizeSoon):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::numberOfDFGCompiles):

1:19 PM Changeset in webkit [153340] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r153333.

  • platform/network/cf/ResourceResponseCFNet.cpp: Remove toTimeT since it is no longer called.
12:36 PM Changeset in webkit [153339] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32 bit portion of load validation logic
​https://bugs.webkit.org/show_bug.cgi?id=118878
Reviewed by NOBODY (Build fix).

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:05 PM Changeset in webkit [153338] by betravis@adobe.com
  • 2 edits in trunk/LayoutTests

[CSS Shapes] Fix typo in simple-polygon.js
​https://bugs.webkit.org/show_bug.cgi?id=119096

Reviewed by Dirk Schulze.

A function name typo was preventing tests and expectations using simple-polygon.js
from generating correct output.

  • fast/shapes/resources/simple-polygon.js:

(polygonXIntercepts): Correctly camel-case function name.

11:20 AM Changeset in webkit [153337] by commit-queue@webkit.org
  • 3 edits
    4 moves in trunk/LayoutTests

[CSS Shapes] New positioning model: support for circle and ellipse shape-outside
​https://bugs.webkit.org/show_bug.cgi?id=118084

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-07-25
Reviewed by Dirk Schulze.

Update circle and ellipse tests to work with new positioning. These
have been rehomed as W3C spec tests, and thus are imported from the
CSSWG's repository.

  • TestExpectations: Remove skip for updated tests.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse.html.
  • csswg/submitted/shapes/shape-outside/w3c-import.log:
11:11 AM Changeset in webkit [153336] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WTF

Fix Windows build after r153134.
​https://bugs.webkit.org/show_bug.cgi?id=119090

Reviewed by Oliver Hunt.

Add USE(PTHREADS) guards around pthread specific code
for now. This will cause isCompilationThread to always
return false on non pthread platforms such as Windows.

We might be able to use the Windows one-time initialization
for this, but this is only available from Windows Vista on.

  • wtf/CompilationThread.cpp:

(WTF::initializeCompilationThreads):

10:55 AM Changeset in webkit [153335] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix after r153315.

Fix build error after we started compiling with c++0x support
in r153315.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::toEdjeGroup):

10:10 AM Changeset in webkit [153334] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

More 32bit build fixes

10:10 AM Changeset in webkit [153333] by andersca@apple.com
  • 8 edits in trunk/Source

Remove lastModifiedDate from ResourceResponse
​https://bugs.webkit.org/show_bug.cgi?id=119092

Reviewed by Andreas Kling.

Source/WebCore:

Computing m_lastResponseDate is costly on some platforms and we already have a better way to
get the last response time, so convert the two call sites that used to call ResourceresponseBase::lastModifiedDate()
over to using lastModified() instead.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit):

  • plugins/PluginStream.cpp:

(WebCore::lastModifiedDate):
(WebCore::PluginStream::startStream):

Source/WebKit2:

Update for WebCore changes.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::lastModifiedDate):
Use ResourceResponse::lastModified() to get the last modified date.

(WebKit::PluginView::Stream::didReceiveResponse):
Call the static lastModified function.

(WebKit::PluginView::manualLoadDidReceiveResponse):
Ditto.

10:10 AM Changeset in webkit [153332] by Christophe Dumez
  • 2 edits in trunk

Unreviewed EFL build fix after r153315.

Use -std=gnu++0x instead of -std=c++0x as we rely on GNU extensions such as
typeof().

  • Source/cmake/WebKitHelpers.cmake:
10:01 AM Changeset in webkit [153331] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Optimize the thread locks for API Shims
​https://bugs.webkit.org/show_bug.cgi?id=118573

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-07-25
Reviewed by Geoffrey Garen.

Remove the thread lock from API Shims if the VM has an exclusive thread (e.g. the VM
only used by WebCore's main thread).

Source/JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):

  • runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WebCore:

No new tests required since no functionality changed.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

9:40 AM Changeset in webkit [153330] by betravis@adobe.com
  • 10 edits in trunk/Source/WebCore

[CSS Shapes] Shape methods and member variables should be guarded with the CSS_SHAPES flag
​https://bugs.webkit.org/show_bug.cgi?id=117277

Reviewed by Alexandru Chiculita.

This patch adds some compile guards that were missing from the RenderStyle and
StyleRareNonInheritedData files. When the compile guard caused parameters to
not be used, the parameters were marked using UNUSED_PARAM.

  • css/CSSPropertyNames.in: Inserting a line to trigger build.
  • rendering/RenderBlock.cpp:

(WebCore::shapeInfoRequiresRelayout):
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):

  • rendering/RenderBox.cpp:

(WebCore::isCandidateForOpaquenessTest):

  • rendering/RenderBox.h:
  • rendering/RenderObject.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresRepaint):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
9:38 AM Changeset in webkit [153329] by Christophe Dumez
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r153218.

Broke the EFL port build with gcc 4.7.

  • interpreter/StackIterator.cpp:

(JSC::printif):

9:24 AM Changeset in webkit [153328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix: add missing #include.
​https://bugs.webkit.org/show_bug.cgi?id=119087

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-25
Reviewed by Allan Sandfeld Jensen.

  • bytecode/ArrayProfile.cpp:
9:13 AM Changeset in webkit [153327] by Carlos Garcia Campos
  • 3 edits
    6 adds in trunk/Source/WebKit2

[GTK] Add support for running unit tests in the web process
​https://bugs.webkit.org/show_bug.cgi?id=118427

Reviewed by Gustavo Noronha Silva.

Some tests, like GObject DOM bindings API tests, run entirely in
the WebProcess, so we just need to start the test from the UI
process and wait until the test finishes running in the
WebProcess. Tests are split in two files, one containing the
actual test that runs in the WebProcess and another one to add the
tests to the glib test system that works as a
proxy. WebProcessTestRunner class starts a private DBus session
bus and starts the tests sending a message to the WebExtension
waiting until it finishes or fails. WebProcess tests are created
by defining a class derived from WebProcessTest class and
implementing the static create method and the virtual runTest
method. The macro REGISTER_TEST is used by the web process tests
to register their test cases. This patch includes the migration
of the WebKitDOMNode test, all other GObject DOM bindings tests
will be migrated in the same way in follow up patches.

  • UIProcess/API/gtk/tests/DOMNodeTest.cpp: Added.

(WebKitDOMNodeTest::create): Create a new WebKitDOMNodeTest.
(WebKitDOMNodeTest::webPageFromArgs): Get the pageID parameter
from the arguments dictionary.
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::runTest): Run the given test.
(registerTests): Register test cases.

  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to

compilation.

  • UIProcess/API/gtk/tests/TestDOMNode.cpp: Added.

(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/TestMain.cpp:

(main): Unset DBUS_SESSION_BUS_ADDRESS environment variable to
make sure that the GLib bus singleton is initialized by the
private DBus session bus created by the tests.

  • UIProcess/API/gtk/tests/WebProcessTest.cpp: Added.

(testsMap): Initialize and get the global map of tests.
(WebProcessTest::add): Add a new test to the map, keeping a
function to create the test.
(WebProcessTest::create): Create a test for the given name.
(methodCallCallback): Handle RunTest DBus method. It creates and
runs the given test.
(webkit_web_extension_initialize):Register the DBus service for
this WebExtension.

  • UIProcess/API/gtk/tests/WebProcessTest.h: Added.
  • UIProcess/API/gtk/tests/WebProcessTestRunner.cpp: Added.

(WebProcessTestRunner::WebProcessTestRunner): Start a private DBus
session bus and get a connection to it.
(WebProcessTestRunner::~WebProcessTestRunner): Stop the private
DBus session bus.
(WebProcessTestRunner::proxyCreatedCallback):
(WebProcessTestRunner::proxy): Create a new proxy to send messages
to the WebExtension if it doesn't exists.
(WebProcessTestRunner::onNameAppeared): Called when the DBus
service has been registered in the WebExtension and it's safe to
create a proxy.
(WebProcessTestRunner::onNameVanished): Called when the DBus
service is unregistered. This happens when the web process crash,
so we just exit here, because the g_asserts in the web process
have already registered the error message.
(WebProcessTestRunner::testFinishedCallback): Called when the
WebProcess tests has finished.
(WebProcessTestRunner::runTest): Send a message to the
WebExtension to start the given test and monitor the service.
(WebProcessTestRunner::finishTest): Save the test result and
finish the main loop.

  • UIProcess/API/gtk/tests/WebProcessTestRunner.h: Added.
7:26 AM Changeset in webkit [153326] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WTF

Fix windows build after FTL upstream

Unreviewed build fix.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

6:53 AM Changeset in webkit [153325] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix on the EFL port.

  • CMakeLists.txt: Added JSCTestRunnerUtils.cpp.
6:50 AM Changeset in webkit [153324] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Add missing store8(TrustedImm32, void*) implementation in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=119083

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-25
Reviewed by Allan Sandfeld Jensen.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::store8):

6:23 AM Changeset in webkit [153323] by allan.jensen@digia.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Fix test build after FTL upstream

Unreviewed build fix.

  • Target.pri:
6:11 AM Changeset in webkit [153322] by allan.jensen@digia.com
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Build fix after FTL.

Un Reviewed build fix.

  • Target.pri:
  • interpreter/StackIterator.cpp:

(JSC::StackIterator::Frame::print):

6:07 AM Changeset in webkit [153321] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after FTL upstream.

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):

5:49 AM Changeset in webkit [153320] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
​https://bugs.webkit.org/show_bug.cgi?id=117282

Patch by Sandeep Shedmake <​sandeep.shedmake@gmail.com> on 2013-07-25
Reviewed by Gustavo Noronha.

  • mr.po: Updated.
5:35 AM Changeset in webkit [153319] by ryuan.choi@samsung.com
  • 7 edits in trunk/Source

Unreviewed, build fix on the EFL port.

Source/JavaScriptCore:

  • CMakeLists.txt:

Added SourceCode.cpp and removed BlackBerry file.

  • jit/JITCode.h:

(JSC::JITCode::nextTierJIT):
Fixed to build break because of -Werror=return-type

  • parser/Lexer.cpp: Includes JSFunctionInlines.h
  • runtime/JSScope.h:

(JSC::makeType):
Fixed to build break because of -Werror=return-type

Source/WTF:

  • wtf/CMakeLists.txt: Added SixCharacterHash.cpp
5:31 AM Changeset in webkit [153318] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fixing after FTL upstream.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::produceCodeBlockFor):

5:29 AM Changeset in webkit [153317] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing implementation of bxxxnz in sh4 LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=119079

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-25
Reviewed by Allan Sandfeld Jensen.

  • offlineasm/sh4.rb:
5:18 AM Changeset in webkit [153316] by rgabor@webkit.org
  • 4 edits in trunk/Source

Unreviewed, build fix on the Qt port.

Source/JavaScriptCore:

  • Target.pri: Add additional build files for the FTL.

Source/WTF:

  • WTF.pro: Add additional build files for the FTL.
5:09 AM Changeset in webkit [153315] by ryuan.choi@samsung.com
  • 2 edits in trunk

[CMAKE] Enforce c++0x for cmake based ports
​https://bugs.webkit.org/show_bug.cgi?id=119081

Reviewed by Gyuyoung Kim.

  • Source/cmake/WebKitHelpers.cmake:

Enforce c++0x for all cmake based ports to fix build break.

5:04 AM Changeset in webkit [153314] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix after FTL upstream..

  • interpreter/StackIterator.cpp:

(JSC::StackIterator::Frame::codeType):
(JSC::StackIterator::Frame::functionName):
(JSC::StackIterator::Frame::sourceURL):
(JSC::StackIterator::Frame::logicalFrame):

4:23 AM Changeset in webkit [153313] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

  • heap/CopyVisitor.cpp: Include CopiedSpaceInlines header so the CopiedSpace::recycleEvacuatedBlock

method is not left undefined, causing build failures on (at least) the GTK port.

4:19 AM Changeset in webkit [153312] by zandobersek@gmail.com
  • 5 edits in trunk/Source

Source/JavaScriptCore: Unreviewed, further build fixing on the GTK port.

  • GNUmakefile.list.am: Add CompilationResult source files to the build.

Source/WTF: Unreviewed, further GTK build fixing.

  • GNUmakefile.am: Make libWTF.la depend on any changes made to the build targets list.
  • GNUmakefile.list.am: Add SixCharacterHash source files to the build.
3:54 AM Changeset in webkit [153311] by zandobersek@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fixing.

  • GNUmakefile.am: Make the shared libjsc library depend on any changes to the build target list.
  • GNUmakefile.list.am: Add additional build targets for files that were introduced by the FTL branch merge.
3:51 AM Changeset in webkit [153310] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix after this error:
error: 'pathName' may be used uninitialized in this function [-Werror=uninitialized]

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):

3:46 AM Changeset in webkit [153309] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

[GTK] Similar fix to r153304.

  • GNUmakefile.list.am:
3:42 AM Changeset in webkit [153308] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

One more buildfix after FTL upstream.

Return a dummy value after RELEASE_ASSERT_NOT_REACHED() to make GCC happy.

  • dfg/DFGLazyJSValue.cpp:

(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::LazyJSValue::strictEqual):

3:24 AM Changeset in webkit [153307] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix "Unhandled opcode localAnnotation" build error in sh4 and mips LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=119076

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-07-25
Reviewed by Allan Sandfeld Jensen.

  • offlineasm/mips.rb:
  • offlineasm/sh4.rb:
2:51 AM Changeset in webkit [153306] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fix.

  • GNUmakefile.list.am: Adding JSCTestRunnerUtils files to the build.
2:29 AM Changeset in webkit [153305] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

Unreviewed. Further build fixing for the GTK port. Adding the forwarding header
for JSCTestRunnerUtils.h as required by the DumpRenderTree compilation.

  • ForwardingHeaders/JavaScriptCore/JSCTestRunnerUtils.h: Added.
2:27 AM Changeset in webkit [153304] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WTF

Build break in debug after r153134: StringImpl.h:640: undefined reference to `WTF::isCompilationThread()
​https://bugs.webkit.org/show_bug.cgi?id=119077

Reviewed by Christophe Dumez.

  • wtf/CMakeLists.txt:

Added CompilationThread.{h/cpp}.

2:08 AM Changeset in webkit [153303] by zandobersek@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Fixing the GTK build after the FTL merging by updating the build targets list.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
1:34 AM Changeset in webkit [153302] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix after FTL upstream.

  • runtime/JSScope.h:

(JSC::needsVarInjectionChecks):

12:53 AM Changeset in webkit [153301] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

One more fix after FTL upstream.

  • Target.pri:
  • bytecode/CodeBlock.h:
  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):

Note: See TracTimeline for information about the timeline view.