Timeline
Jul 21, 2014:
- 11:12 PM Changeset in webkit [171338] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed iOS build fix after r171321.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 9:35 PM Changeset in webkit [171337] by
-
- 4 edits in trunk/Source/WebKit2
[EFL] Add Ewk prefix to enums of ewk_navigation_policy
https://bugs.webkit.org/show_bug.cgi?id=135144
Reviewed by Gyuyoung Kim.
All public enums of ewebkit should start with Ewk prefix.
This patch added Ewk prefix to Ewk_Event_Mouse_Button and Ewk_Event_Modifiers.
In addition, added missing description and default value for Ewk_Event_Modifier.
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(toEwkEventMouseButton):
(toEwkEventModifiers):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(toEventMouseButton): Deleted.
(toEventModifierKeys): Deleted.
- UIProcess/API/efl/ewk_navigation_policy_decision.h:
- UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
- 8:59 PM Changeset in webkit [171336] by
-
- 13 edits in trunk/Source
[iOS][WK2] Improve event throttling for Scroll Events
https://bugs.webkit.org/show_bug.cgi?id=135082
<rdar://problem/17445266>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-21
Reviewed by Simon Fraser.
Source/WebCore:
This patch is composed of two parts. The first part in the WebKit layer
track an approximate measurement of the main thread responsiveness.
The second part in WebCore use that information to avoid sending events
if a page is unresponsive.
In WebCore, this patch only consider scroll events so far. Hopefully the concept
should be easy to generalize.
- loader/EmptyClients.h:
- page/ChromeClient.h:
Chrome client provides us with one information: how long an incoming event should be delayed.
Every port is free to implement whatever logic is suitable for them.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::delayedScrollEventTimerFired):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::sendScrollEvent):
- page/FrameView.h:
Scroll events do not have any associated information so they can be coalesced by just skipping
all input hapenning during the throttling delay.
The implementation is done by using a timer to delay the events.
Source/WebKit2:
In the WebKit layer, we want a measure that is representative of the responsiveness.
In this patch, I use the total delay between a VisibleContentRectUpdate being dispatched
by the UIProcess, and the time RemoteLayerTreeDrawingArea flushes the layer tree.
The value used for eventThrottlingDelay() is computed by averaging the new value with
the old values with a 80/20 split, favoring the old data. Favoring historical data
over the last timing avoid excessively throttling for a single slow frame.
The computation of m_estimatedMainThreadLatency can be improved in the future, this is
a first cut keeping things simple.
With m_estimatedMainThreadLatency in our hands, we can compute our eventThrottlingDelay().
If m_estimatedMainThreadLatency is smaller than a single frame timespan, we have a fast page
and nothing is throttled.
If is it more than a frame, we throttle such that we can at least render two frames
per event dispatch based on the historical data.
The exact values will need some tweaking, but this set ensures well written pages get
60 events per seconds, while slow pages do not waste too much time on events.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::eventThrottlingDelay):
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
- WebProcess/WebPage/ViewUpdateDispatcher.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didFlushLayerTreeAtTime):
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::eventThrottlingDelay):
(WebKit::WebPage::updateVisibleContentRects):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- 8:32 PM Changeset in webkit [171335] by
-
- 2 edits in trunk/Tools
Unreviewed test fix.
- Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
to older Perl 5.8 syntax for iterating over hashes to allow tests to
run on Mountain Lion bots.
- 7:36 PM Changeset in webkit [171334] by
-
- 2 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Add esprima to the WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=135098
Patch by Saam Barati <sbarati@apple.com> on 2014-07-21
Reviewed by Joseph Pecoraro.
This patch includes Esprima into the WebInspector and attaches its
exported function onto the WebInspector namespace object.
- UserInterface/External/Esprima: Added.
- UserInterface/External/Esprima/esprima.js: Added.
(.):
- UserInterface/Main.html:
- 7:15 PM Changeset in webkit [171333] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=135137
build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
Reviewed by Darin Adler.
webkitperl results are binary, handle them the same way we handle bindings test results.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
- 6:26 PM Changeset in webkit [171332] by
-
- 2 edits in trunk/Source/WebCore
Avoid putting empty-sized surfaces into IOSurfacePool
https://bugs.webkit.org/show_bug.cgi?id=135136
<rdar://problem/17478407>
Reviewed by Simon Fraser.
- platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::addSurface):
Avoid adding 0x0 surfaces to the pool, because they will wreak havoc
when their size is used as the key in the CachedSurfaceMap.
Additionally, avoid any empty sizes, because they're just pointless.
- 6:14 PM Changeset in webkit [171331] by
-
- 2 edits in tags/Safari-600.1.1.1/Tools
Merged r171324. <rdar://problem/17750334>
- 6:05 PM Changeset in webkit [171330] by
-
- 3 edits1 copy in tags/Safari-600.1.1.1
Merged r171319. <rdar://problem/17750334>
- 5:58 PM Changeset in webkit [171329] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r170361): In landscape with UI hidden, fixed position elements at top of screen are too low
https://bugs.webkit.org/show_bug.cgi?id=135141
<rdar://problem/17627525>
Reviewed by Benjamin Poulain.
We can't use the WKWebView's UIScrollView contentInsets to determine the unobscured rect
in MobileSafari, because contentInsets can't be changed dynamically while scrolling.
To get around this, MobileSafari sets obscured insets instead (but also sets a fixed
contentInset).
So if the client calls _setObscuredInsets:, always use _obscuredInsets to compute the
content insets.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _computedContentInset]):
(-[WKWebView _setObscuredInsets:]):
- 5:58 PM Changeset in webkit [171328] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor ArrayPrototype to use getLength() and putLength() utility functions.
https://bugs.webkit.org/show_bug.cgi?id=135139.
Reviewed by Oliver Hunt.
- Specialize putProperty() to putLength() because it is only used for setting the length property.
- Added a getLength() utility function to get the value of the length property.
- Use these getLength() and putLength() functions instead of the existing code to get and put the length property. Less code to read, easier to understand.
- runtime/ArrayPrototype.cpp:
(JSC::getLength):
(JSC::putLength):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
(JSC::putProperty): Deleted.
- 5:56 PM Changeset in webkit [171327] by
-
- 2 edits in tags/Safari-600.1.1.1/WebKitLibraries
Merged r171305. <rdar://problem/17743959>
- 5:38 PM Changeset in webkit [171326] by
-
- 4 edits in trunk/Source/WebKit2
Remove global cookie workaround from sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=135138
<rdar://17513375>
Reviewed by Alexey Proskuryakov.
Remove the workaround needed for global cookie access, and silencing
of the associated sandbox violation.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
- 5:37 PM Changeset in webkit [171325] by
-
- 2 edits in trunk/Tools
[Win] Follow-up for r171324.
- Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
perl reports itself as 'cygwin'; native Windows Perl reports as
'MSWin32'. We need to handle both cases.
- 5:29 PM Changeset in webkit [171324] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after r171319.
- Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
only execute on Windows. It will fail on other platforms, so give it a way to
successfully exit.
- 5:26 PM Changeset in webkit [171323] by
-
- 9 edits in trunk
new Int32Array(new ArrayBuffer(100), 1, 1) shouldn't throw an error that says "RangeError: Byte offset and length out of range of buffer"
https://bugs.webkit.org/show_bug.cgi?id=125391
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-07-21
Reviewed by Darin Adler.
Source/JavaScriptCore:
Create own method for verifying byte offset alignment.
- runtime/ArrayBufferView.h:
(JSC::ArrayBufferView::verifyByteOffsetAlignment):
(JSC::ArrayBufferView::verifySubRangeLength):
(JSC::ArrayBufferView::verifySubRange): Deleted.
- runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView<Adaptor>::create):
- runtime/JSDataView.cpp:
(JSC::JSDataView::create):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::create):
LayoutTests:
- fast/canvas/webgl/data-view-crash-expected.txt:
- fast/canvas/webgl/data-view-test-expected.txt:
- fast/canvas/webgl/data-view-test.html:
- 5:10 PM Changeset in webkit [171322] by
-
- 5 edits in trunk/Source/WebKit2
Correct sandbox profiles to fix some excess privileges
https://bugs.webkit.org/show_bug.cgi?id=135134
<rdar://problem/17741886>
<rdar://problem/17739080>
Reviewed by Alexey Proskuryakov.
This cleans up our sandbox profiles to fix a few issues - the profiles
no longer allow us to issue file extension we have the ability to consume,
and tightens some of the other file access rules.
This means we have to addd some rules to allow us to access things
that we previously had access to due to lax file system restrictions.
Some of the features were fixable simply by using entitlements on the
process rather than custom rules.
- Configurations/WebContent-iOS.entitlements:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 5:09 PM Changeset in webkit [171321] by
-
- 8 edits in trunk/Source
WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on
Yosemite
https://bugs.webkit.org/show_bug.cgi?id=135135
Reviewed by Darin Adler.
Source/WebCore:
This patch gets rid of the ChromeClient function that was introduced with
http://trac.webkit.org/changeset/171308 We’ll just enable the Setting instead.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::fixedPositionCreatesStackingContext): Deleted.
- page/ChromeClient.h:
(WebCore::ChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
Source/WebKit/mac:
Get rid of the ChromeClient function, and enable the Setting instead.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 4:44 PM Changeset in webkit [171320] by
-
- 11 edits in trunk/Source
[iOS WK2] Turn off position:fixed behavior when the keyboard is up
https://bugs.webkit.org/show_bug.cgi?id=132537
Reviewed by Benjamin Poulain.
Source/WebCore:
Export RenderObject::localToContainerPoint().
- WebCore.exp.in:
Source/WebKit2:
Make interaction with form elements inside position:fixed less terrible by re-laying out
fixed elements relative to the document while we have an assisted node. This ensures
that all parts of a position:fixed are accessible (e.g. inputs on the right side
of a fixed-width top bar).
- Shared/AssistedNodeInformation.cpp: Add a flag for being inside postion:fixed,
and encode/decode it.
(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):
- Shared/AssistedNodeInformation.h:
(WebKit::AssistedNodeInformation::AssistedNodeInformation):
- UIProcess/PageClient.h: Add isAssistingNode().
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isAssistingNode):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::computeCustomFixedPositionRect): If we have an assisted
node, just use the document rect as the custom fixed position rect.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation): Get the selection rect first,
since we have to fix it up for position:fixed. If the element is inside fixed
position in the main frame, re-set the fixed position rect to the document rect
(which forces a layout), re-fetch elementRect, then set it back. This ensures
that the UI process gets an elementRect which it can zoom to correctly.
- 4:10 PM Changeset in webkit [171319] by
-
- 3 edits2 adds in trunk
Tools: [Win] Extend auto-version.pl to support 5-tuple versions
https://bugs.webkit.org/show_bug.cgi?id=135124
<rdar://problem/17750334>
Reviewed by David Kilzer.
Add test cases for auto-version.pl.
- Scripts/webkitperl/auto-version_unittest: Added.
- Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
WebKitLibraries: [Win] Extend auto-version.pl to handle 5-tuple versions
https://bugs.webkit.org/show_bug.cgi?id=135124
<rdar://problem/17750334>
Reviewed by David Kilzer.
Extend tuple parsing to handle up to five tuples, and as
few as a single tuple. On Windows, the two additional
tuples are unused.
Also corrected regular expression capture logic to use local
blocks, preventing later capture expressions from reusing
previous capture results when the current expression failed
to find a match (GRRR, Perl!).
Clean up code by putting logic into a couple of subroutines.
- win/tools/scripts/auto-version.pl:
- 4:07 PM Changeset in webkit [171318] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: fast/layers/no-clipping-overflow-hidden-added-after-transform.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=135133
- platform/mac/TestExpectations: Marked it as such.
- 3:17 PM Changeset in webkit [171317] by
-
- 6 edits in trunk/Source/WebKit2
Random crashes on the Web Thread due to Timers firing on the wrong thread in the UI process
https://bugs.webkit.org/show_bug.cgi?id=135132
<rdar://problem/17719832>
Reviewed by Simon Fraser.
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::ProcessThrottler):
(WebKit::ProcessThrottler::suspendTimerFired):
- UIProcess/ProcessThrottler.h:
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
We can't use WebCore timers in the UI process because of coexistence concerns
(they fire on the Web Thread if there is one!), so use RunLoop::Timer instead.
- 1:47 PM Changeset in webkit [171316] by
-
- 5 edits2 adds in trunk
[MSE] YouTube video decode error when variant-switching
https://bugs.webkit.org/show_bug.cgi?id=135128
Reviewed by Brent Fulgham.
Source/WebCore:
Test: media/media-source/media-source-overlapping-decodetime.html
When variant-switching, the situation can arise where an existing sample with a presentation
timestamp of N and a decode timestamp of M, and a new sample with a presentation timestamp > N
and the same decode timestamp of M, will keep the new sample from being added to the SampleMap.
This can result in a decode error when samples depending on that new, missing sample are enqueued.
The MSE spec is silent on the issue of overlapping decode timestamps. However, it guarantees that
presentation timestamps are non-overlapping. So instead of using just the decode timestamp as a key
for storing the samples in decode order, use both the decode timestamp and the presentation timestamp.
That ensures that samples with different presentation times but equal decode times are both inserted
into the decode queue, and in the correct order.
- Modules/mediasource/SampleMap.cpp:
(WebCore::SampleIsRandomAccess::operator()): Update the parameter type to match the new KeyType.
(WebCore::SampleMap::addSample): Pass both decodeTime and presentationTime as the key to decodeOrder.
(WebCore::SampleMap::removeSample): Ditto.
(WebCore::DecodeOrderSampleMap::findSampleWithDecodeKey): Renamed from findSampleWithDecodeTime.
(WebCore::DecodeOrderSampleMap::reverseFindSampleWithDecodeKey): renamed from reverseFindSampleWithDecodeTime.
(WebCore::DecodeOrderSampleMap::findSyncSamplePriorToPresentationTime): Use renamed version of above.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findDependentSamples): Ditto.
(WebCore::DecodeOrderSampleMap::findSampleWithDecodeTime): Deleted.
(WebCore::DecodeOrderSampleMap::reverseFindSampleWithDecodeTime): Deleted.
- Modules/mediasource/SampleMap.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::reenqueueMediaForTime): Ditto.
LayoutTests:
- media/media-source/media-source-overlapping-decodetime-expected.txt: Added.
- media/media-source/media-source-overlapping-decodetime.html: Added.
- 12:26 PM Changeset in webkit [171315] by
-
- 2 edits in trunk/Tools
Allow MiniBrowser WK1 to do element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=135125
Reviewed by Simon Fraser.
Allow WK1 windows to go fullscreen using the DOM API.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
fullscreen.
- 12:20 PM Changeset in webkit [171314] by
-
- 6 edits in trunk/Source
[iOS] Handle QuickLook ResourceLoaders in the web process
https://bugs.webkit.org/show_bug.cgi?id=135113
Reviewed by David Kilzer.
Source/WebCore:
No new tests. QuickLook is not testable from WebKit.
- WebCore.exp.in:
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::maybeLoadQuickLookResource): Start loading the ResourceLoader if it is for a QuickLook resource.
- loader/ResourceLoadScheduler.h:
Source/WebKit2:
The QuickLook framework registers a NSURLProtocol to handle loading subresources of the HTML documents it
generates. In order for these loads to succeed, we need to start them in the same process in which QuickLook
generated the main resource.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 12:20 PM Changeset in webkit [171313] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/canvas-putImageData-zero-alpha.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=131787
- platform/mac/TestExpectations: Mark it as such.
- 12:16 PM Changeset in webkit [171312] by
-
- 7 edits1 add in trunk/Source/WebInspectorUI
Back/Forward arrows (modern) are too large.
https://bugs.webkit.org/show_bug.cgi?id=135073
Reviewed by Joseph Pecoraro.
Changes to adjust new forward and back arrow sizes to be more consistent with the
universal design language. Moved WebInspector.Platform definition to its own file.
Refactored handling of image versions inside ImageUtilities.js.
- UserInterface/Base/ImageUtilities.js:
(.restoreImage):
(.generateImage):
(generateColoredImagesForCSS):
Make the default image versioning smarter.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector.contentLoaded.WebInspector.Platform.version.toString): Deleted.
(WebInspector.contentLoaded.WebInspector.Platform.toString): Deleted.
- UserInterface/Base/Platform.js: Added.
Move platform information definition into Platform.js.
- UserInterface/Main.html: Include Platform.js.
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
- UserInterface/Views/FindBanner.css:
(.find-banner > button > .glyph):
(body.mac-platform.legacy .find-banner > button > .glyph):
(.find-banner > button.segmented.left > .glyph):
(body.mac-platform.legacy .find-banner > button.segmented.left > .glyph):
(.find-banner > button.segmented.right > .glyph):
(body.mac-platform.legacy .find-banner > button.segmented.right > .glyph):
(.find-banner > button.segmented):
(body.mac-platform.legacy .find-banner > button.segmented):
- UserInterface/Views/FindBanner.js:
(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
Size of forward and back arrows adjusted.
- 12:15 PM Changeset in webkit [171311] by
-
- 2 edits in trunk/Source/WebCore
Case sensitive file system build fix.
- page/scrolling/ScrollingStateTree.cpp:
- 12:04 PM Changeset in webkit [171310] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
- 11:34 AM Changeset in webkit [171309] by
-
- 3 edits in trunk/LayoutTests
Unreviewed hidpi test gardening.
Use Ahem font to ensure font size predictability.
- fast/forms/hidpi-fieldset-on-subpixel-position-when-legend-is-present-expected.html:
- fast/forms/hidpi-fieldset-on-subpixel-position-when-legend-is-present.html:
- 11:31 AM Changeset in webkit [171308] by
-
- 7 edits in trunk/Source
Put position:fixed elements into layers when a WK1 view is layer-backed
https://bugs.webkit.org/show_bug.cgi?id=135075
Reviewed by Darin Adler.
Source/WebCore:
This patch adds a new ChromeClient function called
requiresAcceleratedCompositingForViewportConstrainedPosition(). Since a view can
go in and out of layer backing, we need a ChromeClient method that can be
dynamically re-evaluated rather than using the existing settings for enabling
accelerated fixed and fixed that creates a stacking context.
Ensure that fixed elements create a stacking context when
requiresAcceleratedCompositingForViewportConstrainedPosition is true.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
New ChromeClient function.
- page/ChromeClient.h:
Source/WebKit/mac:
Returns true when the WebHTMLView has a layer.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
- 11:26 AM Changeset in webkit [171307] by
-
- 3 edits in trunk/Source/WebCore
Add helper functions to dump the scrolling state tree from the debugger
https://bugs.webkit.org/show_bug.cgi?id=135101
Reviewed by Darin Adler.
Add debug-only showScrollingStateTree() functions that take a ScrollingStateTree* and ScrollingStateNode*
for use while debugging.
- page/scrolling/ScrollingStateTree.cpp:
(showScrollingStateTree):
- page/scrolling/ScrollingStateTree.h:
- 11:26 AM Changeset in webkit [171306] by
-
- 3 edits in trunk/Source/WebCore
[iOS WK1] Single touch div scrolling doesn't work in framesets (breaks Word previews)
https://bugs.webkit.org/show_bug.cgi?id=135103
<rdar://problem/11830219>
Reviewed by Darin Adler.
After r166117 all layer flushing starts on the root frame; we no longer flush layers
for each frame during painting. However, flushing GraphicsLayers can set some state
on a subframe RenderLayerCompositor that is now never processed, which breaks scroll
layer registration.
Fix by doing a walk of the Frame tree, and calling didFlushLayers() on subframe RenderLayerCompositors
before calling didFlushLayers() on self.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushLayers):
(WebCore::RenderLayerCompositor::notifySubframesAfterLayerFlush):
(WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers): Drive-by nullptr.
- rendering/RenderLayerCompositor.h:
- 10:44 AM Changeset in webkit [171305] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Correct auto-version.pl script for two-digit version numbers
https://bugs.webkit.org/show_bug.cgi?id=135119
<rdar://problem/17743959>
Reviewed by David Kilzer.
The $MAJOR_VERSION must be the first digit of $BUILD_MAJOR_VERSION,
and $MINOR_VERSION must be the remaining digits.
Also correct regexp (line 90) that was allowing version numbers
larger than three digits to be processed.
- win/tools/scripts/auto-version.pl: Correct regular expression.
- 10:30 AM Changeset in webkit [171304] by
-
- 5 edits in trunk/LayoutTests
Unreviewed hidpi test gardening.
- fast/inline/hidpi-selection-gap-on-subpixel-position-expected.html:
- fast/inline/hidpi-selection-gap-on-subpixel-position.html: Speculative fix.
- fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html:
- fast/inline/hidpi-selection-gap-overlaps-inline-selection.html: Use Ahem.
- 10:14 AM Changeset in webkit [171303] by
-
- 5 edits in trunk/Source/WebKit2
DatabaseProcess doesn't relaunch after crashing.
<rdar://problem/17717343> and https://bugs.webkit.org/show_bug.cgi?id=135117
Reviewed by Alexey Proskuryakov.
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didClose): Tell the WebContext.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::databaseProcessCrashed): Notify supplements, then clear the DatabaseProcessProxy pointer.
- UIProcess/WebContext.h:
- UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::processDidClose): Added. No users right now, but the patch in bug 135035 will need this.
- 9:50 AM Changeset in webkit [171302] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r150169): http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html fails
https://bugs.webkit.org/show_bug.cgi?id=116259
Updating expectations to acknowledge that the test is flaky on WK1 too (it depends
on preceding tests).
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 9:41 AM Changeset in webkit [171301] by
-
- 3 edits in trunk/LayoutTests
Unreviewed hidpi test gardening.
Use Ahem font to ensure font size predictability.
- fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html:
- fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html:
- 8:14 AM Changeset in webkit [171300] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Remove passing tests from TestExpectations file.
- platform/efl/TestExpectations:
- 8:03 AM Changeset in webkit [171299] by
-
- 4 edits in trunk/Source/WebCore
[iOS] a Paused media session is not active
https://bugs.webkit.org/show_bug.cgi?id=135108
Reviewed by Darin Adler.
Activating the shared AudioSession will pause audio playing in another application,
so only report a Playing media sessions as active.
- platform/audio/MediaSessionManager.cpp:
- platform/audio/MediaSessionManager.h:
(WebCore::MediaSessionManager::activeAudioSessionRequired): Renamed from hasActive to make
clear what it does. Only return true for a session that is Playing.
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState): hasActive renamed to activeAudioSessionRequired.
- 7:46 AM EFLWebKit edited by
- Update few information as the latest (diff)
- 2:38 AM Changeset in webkit [171298] by
-
- 2 edits in trunk/Tools
[GTK] Documentation files are added twice to the tarball
https://bugs.webkit.org/show_bug.cgi?id=135115
Reviewed by Sergio Villar Senin.
- gtk/manifest.txt: Remove duplicated rules.
- 2:04 AM Changeset in webkit [171297] by
-
- 4 edits in trunk
[GTK] Simplify make-dist command line arguments
https://bugs.webkit.org/show_bug.cgi?id=134832
Reviewed by Martin Robinson.
.:
- Source/PlatformGTK.cmake: Use --version instead of
--tarball-root when running make-dist.py.
Tools:
Remove --tarball-root and -o command line options and add
--version, since the version can be used to build both, the
tarball root and the output filename. When the version it's not
provided, the pkg-config file is used to get the version. Also
change the default value of build-dir to the current directory,
since it's very common to call make-dist.py from the build dir.
- gtk/make-dist.py:
(get_tarball_root_and_output_filename_from_arguments):
- 1:30 AM Changeset in webkit [171296] by
-
- 2 edits in trunk/Tools
[GTK] Reduce the size of the tarball generated by distcheck
https://bugs.webkit.org/show_bug.cgi?id=134802
Reviewed by Martin Robinson.
Add more rules to the manifest to decide what files to add:
- Do not include platform specific directories of other ports.
- Do not include port specific cmake files.
- Do not include Objective-C sources.
- Do not include .orig and .rej files.
- Do not include mac specific sandbox files.
- Only include the resources we actually build.
- gtk/manifest.txt:
- 1:26 AM Changeset in webkit [171295] by
-
- 112 edits1 add in trunk/LayoutTests
[CSS Blending] Cleanup tests in css3/blending
https://bugs.webkit.org/show_bug.cgi?id=132600
Reviewed by Mihnea Ovidenie.
Summary of changes:
- move common stylesheet classes to blending-style.css.
- remove trailing white spaces.
- replace tabs with spaces.
- remove the 'html' tags for consistency with the most of blending tests.
This patch does not change the txt and png test expectations.
- css3/blending/background-blend-mode-background-attachement-fixed-expected.html:
- css3/blending/background-blend-mode-background-attachement-fixed.html:
- css3/blending/background-blend-mode-background-clip-content-box-expected.html:
- css3/blending/background-blend-mode-background-clip-content-box.html:
- css3/blending/background-blend-mode-background-clip-padding-box-expected.html:
- css3/blending/background-blend-mode-background-clip-padding-box.html:
- css3/blending/background-blend-mode-background-origin-border-box-expected.html:
- css3/blending/background-blend-mode-background-origin-border-box.html:
- css3/blending/background-blend-mode-background-position-percentage-expected.html:
- css3/blending/background-blend-mode-background-position-percentage.html:
- css3/blending/background-blend-mode-background-repeat-no-repeat-expected.html:
- css3/blending/background-blend-mode-background-repeat-no-repeat.html:
- css3/blending/background-blend-mode-background-size-contain-expected.html:
- css3/blending/background-blend-mode-background-size-contain.html:
- css3/blending/background-blend-mode-background-size-cover-expected.html:
- css3/blending/background-blend-mode-background-size-cover.html:
- css3/blending/background-blend-mode-body-image-expected.html:
- css3/blending/background-blend-mode-body-image.html:
- css3/blending/background-blend-mode-body-transparent-color-and-image-expected.html:
- css3/blending/background-blend-mode-body-transparent-color-and-image.html:
- css3/blending/background-blend-mode-body-transparent-image-expected.html:
- css3/blending/background-blend-mode-body-transparent-image.html:
- css3/blending/background-blend-mode-crossfade-image-expected.html:
- css3/blending/background-blend-mode-crossfade-image.html:
- css3/blending/background-blend-mode-data-uri-svg-image-expected.html:
- css3/blending/background-blend-mode-data-uri-svg-image.html:
- css3/blending/background-blend-mode-default-value.html:
- css3/blending/background-blend-mode-different-image-formats.html:
- css3/blending/background-blend-mode-gif-color-2.html:
- css3/blending/background-blend-mode-gif-color.html:
- css3/blending/background-blend-mode-gradient-color.html:
- css3/blending/background-blend-mode-gradient-gradient.html:
- css3/blending/background-blend-mode-gradient-image.html:
- css3/blending/background-blend-mode-image-color-dynamic-expected.html:
- css3/blending/background-blend-mode-image-color-dynamic.html:
- css3/blending/background-blend-mode-image-color.html:
- css3/blending/background-blend-mode-image-image.html:
- css3/blending/background-blend-mode-image-svg.html:
- css3/blending/background-blend-mode-multiple-background-layers.html:
- css3/blending/background-blend-mode-separate-layer-declaration-expected.html:
- css3/blending/background-blend-mode-separate-layer-declaration.html:
- css3/blending/background-blend-mode-single-layer-no-blending.html:
- css3/blending/background-blend-mode-svg-color.html:
- css3/blending/background-blend-mode-svg-expected.html:
- css3/blending/background-blend-mode-svg.html:
- css3/blending/background-blend-mode-tiled-layers.html:
- css3/blending/blend-mode-accelerated-parent-overflow-hidden-expected.html:
- css3/blending/blend-mode-accelerated-parent-overflow-hidden.html:
- css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts.html:
- css3/blending/blend-mode-ancestor-clipping-layer.html:
- css3/blending/blend-mode-background.html:
- css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html:
- css3/blending/blend-mode-body-child-background-color-expected.html:
- css3/blending/blend-mode-body-child-background-color.html:
- css3/blending/blend-mode-body-child-isolate-background-color-expected.html:
- css3/blending/blend-mode-body-child-isolate-background-color.html:
- css3/blending/blend-mode-body-child-isolate-html-background-color-expected.html:
- css3/blending/blend-mode-body-child-isolate-html-background-color.html:
- css3/blending/blend-mode-body-child.html:
- css3/blending/blend-mode-body-element-expected.html:
- css3/blending/blend-mode-body-element.html:
- css3/blending/blend-mode-clip-accelerated-blending-canvas.html:
- css3/blending/blend-mode-clip-accelerated-blending-child-expected.html:
- css3/blending/blend-mode-clip-accelerated-blending-child.html:
- css3/blending/blend-mode-clip-accelerated-blending-double-expected.html:
- css3/blending/blend-mode-clip-accelerated-blending-double.html:
- css3/blending/blend-mode-clip-accelerated-blending-with-siblings-expected.html:
- css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html:
- css3/blending/blend-mode-clip-accelerated-transformed-blending-expected.html:
- css3/blending/blend-mode-clip-accelerated-transformed-blending.html:
- css3/blending/blend-mode-clip-rect-accelerated-blending-expected.html:
- css3/blending/blend-mode-clip-rect-accelerated-blending.html:
- css3/blending/blend-mode-html-element-screen.html:
- css3/blending/blend-mode-isolated-group-1.html:
- css3/blending/blend-mode-isolated-group-2.html:
- css3/blending/blend-mode-isolated-group-3.html:
- css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html:
- css3/blending/blend-mode-isolation-flags-append-non-stacking-context-blending.html:
- css3/blending/blend-mode-isolation-flags-append-stacking-context-blending.html:
- css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending.html:
- css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending.html:
- css3/blending/blend-mode-isolation-flags-turn-off-blending-no-isolation.html:
- css3/blending/blend-mode-isolation-flags-turn-off-blending.html:
- css3/blending/blend-mode-isolation-flags-turn-off-stacking-context.html:
- css3/blending/blend-mode-isolation-flags-turn-on-blending.html:
- css3/blending/blend-mode-isolation-flags-turn-on-stacking-context.html:
- css3/blending/blend-mode-isolation-overflow-hidden-expected.html:
- css3/blending/blend-mode-isolation-overflow-hidden.html:
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html:
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html:
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html:
- css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html:
- css3/blending/blend-mode-layers.html:
- css3/blending/blend-mode-overflow.html:
- css3/blending/blend-mode-parent-of-composited-blended-has-layer.html:
- css3/blending/blend-mode-reflection.html:
- css3/blending/blend-mode-simple-composited.html:
- css3/blending/blend-mode-transform-style.html:
- css3/blending/blend-mode-with-accelerated-sibling.html:
- css3/blending/blend-mode-with-body-expected.html:
- css3/blending/blend-mode-with-body.html:
- css3/blending/blend-mode-with-composited-descendant-should-have-layer.html:
- css3/blending/effect-background-blend-mode-stacking.html:
- css3/blending/isolation-isolate-blended-child-expected.html:
- css3/blending/isolation-isolate-blended-child.html:
- css3/blending/repaint/blend-mode-isolate-stacking-context.html:
- css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html:
- css3/blending/repaint/blend-mode-turn-off-isolation.html:
- css3/blending/resources/blending-style.css: Added.
This file contains classes shared by multiple blending tests.
- css3/blending/resources/dump-layer-tree.js: Added.
- css3/blending/script-tests/background-blend-mode-property-parsing.js:
- css3/blending/script-tests/blend-mode-property-parsing-invalid.js:
- css3/blending/script-tests/blend-mode-property-parsing.js:
- 1:18 AM Changeset in webkit [171294] by
-
- 19 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM bindings test results after r171285.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp:
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp:
- 12:46 AM Changeset in webkit [171293] by
-
- 12 edits in trunk/LayoutTests
[CSS Grid Layout] Rename gridAutoFlow[Row|Column] to gridAutoFlow[Row|Column]Sparse
https://bugs.webkit.org/show_bug.cgi?id=135013
Rename CSS styles in grid layout tests to make the name more explicit.
As the default mode for auto-placement algorithm is "sparse".
Reviewed by Darin Adler.
- fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
- fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
- fast/css-grid-layout/grid-auto-flow-get-set.html:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-auto-flow-sparse.html:
- fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
- fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
- fast/css-grid-layout/grid-item-auto-placement-definite-span.html:
- fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
- fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
- fast/css-grid-layout/resources/grid.css:
(.gridAutoFlowColumnSparse):
(.gridAutoFlowRowSparse):
(.gridAutoFlowColumn): Deleted.
(.gridAutoFlowRow): Deleted.
Jul 20, 2014:
- 11:16 PM Changeset in webkit [171292] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed Fix test crashes when cloning video layer since r171286
https://bugs.webkit.org/show_bug.cgi?id=135112
Unreviewed. Fix crashing tests by conditionalizing inline video layer change.
compositing/video/video-reflection.html [ Crash ]
media/video-layer-crash.html [ Crash ]
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: add conditional
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): ditto
- 10:36 PM Changeset in webkit [171291] by
-
- 3 edits in trunk/Source/WebKit2
Fix warnings caused by unused parameter.
https://bugs.webkit.org/show_bug.cgi?id=134975
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-20
Reviewed by Gyuyoung Kim.
Fix warnings on EwkView.cpp and LegacySessionStateCodingNone.cpp that are caused by unused parameter data.
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
- UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::decodeLegacySessionState):
- 10:34 PM Changeset in webkit [171290] by
-
- 3 edits in trunk/Tools
[EFL] Enable mpg123 feature for gst-plugin-bad.
https://bugs.webkit.org/show_bug.cgi?id=135016
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-20
Reviewed by Laszlo Gombos.
enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
- efl/install-dependencies:
- efl/jhbuild.modules:
- 9:30 PM Changeset in webkit [171289] by
-
- 2 edits in trunk/Source/WebCore
Reduce the chances of a race condition when sharing SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=135060
<rdar://problem/17729444>
Reviewed by Darin Adler.
We currently pass a SharedBuffer wrapped in WebCoreSharedBufferData to ImageIO for image
decoding. This is not thread safe since ImageIO will access this buffer on a separate
thread. We access SharedBuffer::buffer() on the other thread which resizes the Vector
m_buffer if m_size is greater than the vector size. Since the code in SharedBuffer::append()
sets m_size before appending the data to the buffer, m_size is out of sync with the m_buffer
size for the entire duration of the Vector append which could be doing a lot of copying if
the resource is large. While this change does not fix the race condition, we can at least
reduce the chances of SharedBuffer::buffer() calling resize() by setting m_size after the
cector has finished appending.
No new tests because no functional changes.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
- 8:08 PM Changeset in webkit [171288] by
-
- 17 edits in trunk/Source
Disable ff/rw based on canPlayFastForward and canPlayFastRewind.
https://bugs.webkit.org/show_bug.cgi?id=134894
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-20
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in: add symbol for canPlayFastReverse
- html/HTMLMediaElement.cpp: Add two new accessors
(WebCore::HTMLMediaElement::nextScanRate): possibly limit scanRate
(WebCore::HTMLMediaElement::canPlayFastForward): added
(WebCore::HTMLMediaElement::canPlayFastReverse): added
- html/HTMLMediaElement.h: declare two new methods
- platform/graphics/MediaPlayer.cpp: Plumb through two new accessors
(WebCore::MediaPlayer::maxFastForwardRate): added
(WebCore::MediaPlayer::minFastReverseRate): added
- platform/graphics/MediaPlayer.h: Declare new methods
- platform/graphics/MediaPlayerPrivate.h: Added two new methods.
(WebCore::MediaPlayerPrivateInterface::maxFastForwardRate): added
(WebCore::MediaPlayerPrivateInterface::minFastReverseRate): added
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: member to cache ff/rw enabled state
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): observe on item canPlayFastForward canPlayFastReverse
(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayFastForwardDidChange): added
(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayFastReverseDidChange): added
(WebCore::itemKVOProperties): observe canPlayFastForward canPlayFastRewind
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): ditto
- platform/ios/WebVideoFullscreenInterface.h: add new method
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: ditto
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm: ditto
(WebVideoFullscreenInterfaceAVKit::setCanPlayFastReverse): Set value on WebAVPlayerController.
(-[WebAVPlayerController canScanBackward]): Deleted.
(+[WebAVPlayerController keyPathsForValuesAffectingCanScanBackward]): Deleted.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::updateForEventName): update canPlayFastReverse.
Source/WebKit2:
Add setCanPlayFastReverse
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: ditto
- WebProcess/ios/WebVideoFullscreenManager.h: ditto
- WebProcess/ios/WebVideoFullscreenManager.mm: ditto
(WebKit::WebVideoFullscreenManager::setCanPlayFastReverse): ditto
- 7:34 PM Changeset in webkit [171287] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement should registerWithDocument on iOS
https://bugs.webkit.org/show_bug.cgi?id=135084
<rdar://problem/17702531>
Reviewed by Andreas Kling.
Otherwise it won't know when the visibility changes!
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
- 7:30 PM Changeset in webkit [171286] by
-
- 10 edits in trunk/Source
Decrease flicker when enter and exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=134919
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-20
Reviewed by Simon Fraser.
Source/WebCore:
Put AVPlayerLayer in a container layer so moving it between inline and fullscreen
is as easy as adding and removing it from a containter layer; no need to do a layout.
Make sure fullscreen layers are transparent before moving moving the AVPlayerLayer
between inline and fullscreen so you don't briefly see the empty fullscreen layers.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::platformLayer): remove fullscreen special case.
(WebCore::HTMLMediaElement::setVideoFullscreenLayer): no need to recalc style
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: add inline container layer
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
add WebVideoContainerLayer to contain AVPlayerLayer and keep layout correct.
(-[WebVideoContainerLayer setBounds:]): forward setbounds to set child frame.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): create the video container layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): destroy the video container layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): use container layer instead of video layer
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): use transactions to prevent unwanted animation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame): ditto
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::layerTypeForPlatformLayer): WebVideoContainerLayer is a kind of AVPlayerLayer
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController didCleanupFullscreen]): remove video fullscreen layer first
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): make background transparent during transition.
dispatch_async to allow CATransaction to complete before calling didSetupFullscreen()
Source/WebKit2:
Change the sequence of tear down and use transparency to prevent flicker when entering and exiting fullscreen.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm: wait to remove layerHost until didCleanupFullscreen
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen): removed from here
(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): added here
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::didSetupFullscreen): use transparent background during transition
- 7:19 PM Changeset in webkit [171285] by
-
- 17 edits in trunk/Source/WebCore
Move ExceptionCodeDescription.h into the files that actually need it
https://bugs.webkit.org/show_bug.cgi?id=134968
Reviewed by Darin Adler.
No new tests because no functional changes.
- Modules/indexeddb/IDBDatabaseException.cpp:
- Modules/webdatabase/SQLException.cpp:
- bindings/js/JSDOMBinding.cpp:
- bindings/objc/ExceptionHandlers.mm:
- bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
- dom/DOMCoreException.cpp:
- dom/EventException.cpp:
- dom/ExceptionBase.cpp:
- dom/ExceptionCode.h:
- dom/RangeException.cpp:
- fileapi/FileException.cpp:
- inspector/DOMEditor.cpp:
- inspector/InspectorDOMAgent.cpp:
- svg/SVGException.cpp:
- xml/XMLHttpRequestException.cpp:
- xml/XPathException.cpp:
- 5:34 PM Changeset in webkit [171284] by
-
- 4 edits1 add in trunk
Source/WebCore: <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
https://bugs.webkit.org/show_bug.cgi?id=135107
Reviewed by Sam Weinig.
Test: TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm
- page/FrameView.cpp:
(WebCore::FrameView::paintContents): To work around http://webkit.org/b/135106, replace the
paint root with its nearest ancestor that isn’t an inline with culled line boxes, if needed.
Tools: Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
https://bugs.webkit.org/show_bug.cgi?id=135107
Reviewed by Sam Weinig.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
(-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
- 1:11 PM Changeset in webkit [171283] by
-
- 4 edits in trunk/Source/WebCore
Crashes seen in wheel event handling
https://bugs.webkit.org/show_bug.cgi?id=135102
Reviewed by Beth Dakin.
Speculative fix based on guesses about what could be crashing.
The crash seems to be calling ref on an event target, and my guess is that this
has something to do with latching.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformPrepareForWheelEvents): Updated argument types.
(WebCore::EventHandler::handleWheelEvent): Refactored a little and made some local
variables use RefPtr instead of raw pointers. Also added some comments.
- page/EventHandler.h: Changed argument types to RefPtr.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents): Updated argument types.
Also added a FIXME.
- 11:33 AM WikiStart edited by
- (diff)
- 11:31 AM JavaScriptCore edited by
- (diff)
- 11:27 AM FTLJIT edited by
- (diff)
- 11:00 AM Changeset in webkit [171282] by
-
- 2 edits in trunk/Source/WebCore
Print layerIDs in GraphicsLayer dumps
https://bugs.webkit.org/show_bug.cgi?id=135100
Reviewed by Darin Adler.
When calling showGraphicsLayerTree() from the debugger, it's useful to show
layerIDs so they can be correlated with remote layer tree transactions. So
when dumping with debug info, dump the primary layer ID.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
- 9:49 AM Changeset in webkit [171281] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Updated Radar link
- 9:48 AM Changeset in webkit [171280] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/17739804> REGRESSION (r171057): Crash in WebPage::getPositionInformation()
https://bugs.webkit.org/show_bug.cgi?id=135099
Reviewed by David Kilzer.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation): Added a null check.
- 9:45 AM Changeset in webkit [171279] by
-
- 2 edits in trunk/Source/WebCore
[iOS] ignore requests to set volume
https://bugs.webkit.org/show_bug.cgi?id=135081
Applied post-review comments from Darin Adler.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
code on iOS.
- 9:16 AM Changeset in webkit [171278] by
-
- 7 edits in trunk
ES6: Implement Math.sign()
https://bugs.webkit.org/show_bug.cgi?id=134980
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-07-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncSign):
LayoutTests:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/math.js:
- 8:08 AM Changeset in webkit [171277] by
-
- 2 edits in trunk/Tools
Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
<http://webkit.org/b/135096>
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/mac/LayoutTestHelper.m:
(lockDownDiscreteGraphics): Check the return values of
IOServiceOpen() and IOObjectRelease(), and log if not
KERN_SUCCESS.
Jul 19, 2014:
- 9:32 PM Changeset in webkit [171276] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TextContentView calls wrong prototype function in the hidden() function
https://bugs.webkit.org/show_bug.cgi?id=135097
Patch by Saam Barati <sbarati@apple.com> on 2014-07-19
Reviewed by Timothy Hatcher.
Corollary bug to: https://bugs.webkit.org/show_bug.cgi?id=135001
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView.prototype.hidden):
- 5:04 PM Changeset in webkit [171275] by
-
- 3 edits in branches/safari-537.78-branch
Merged r170946. <rdar://problem/17684656>
- 4:59 PM Changeset in webkit [171274] by
-
- 3 edits in branches/safari-537.78-branch
Merged r170135. <rdar://problem/17684651>
- 4:31 PM Changeset in webkit [171273] by
-
- 3 edits1 copy in branches/safari-537.78-branch/Source/WebKit2
Merged r169448. <rdar://problem/17684663>
- 4:19 PM Changeset in webkit [171272] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170513. <rdar://problem/17684622>
- 4:07 PM Changeset in webkit [171271] by
-
- 3 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170028. <rdar://problem/17689801>
- 4:03 PM Changeset in webkit [171270] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r170026. <rdar://problem/17689834>
- 4:00 PM Changeset in webkit [171269] by
-
- 3 edits3 copies in branches/safari-537.78-branch
Merged r169849. <rdar://problem/17684636>
- 3:56 PM Changeset in webkit [171268] by
-
- 3 edits2 copies in branches/safari-537.78-branch
Merged r169848. <rdar://problem/17684630>
- 3:50 PM Changeset in webkit [171267] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebKit2
Merged r169757. <rdar://problem/17684670>
- 3:48 PM Changeset in webkit [171266] by
-
- 2 edits in branches/safari-537.78-branch/Source/WebCore
Merged r169726. <rdar://problem/17684616>
- 1:15 PM Changeset in webkit [171265] by
-
- 2 edits in trunk/Tools
Update.
- Scripts/webkitpy/common/config/watchlist:
- 11:07 AM Changeset in webkit [171264] by
-
- 3 edits in trunk/Source/WebCore
<https://webkit.org/b/135085> Ensure that make_names.pl generates the same result when run multiple times.
Perl 5.18 introduced hash randomization. This results in the iteration order of hashes being different
from one run to the next. To ensure identical output we can iterate over the hash keys in sorted order.
Reviewed by Alexey Proskuryakov.
- bindings/scripts/StaticString.pm:
(GenerateStrings):
(GenerateStringAsserts):
- dom/make_names.pl:
- 9:24 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:16 AM Changeset in webkit [171263] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures. Update some expectations.
- 3:10 AM Changeset in webkit [171262] by
-
- 2 edits in trunk/Source/WTF
[WTF] Add the move constructor, move assignment operator for HashTable
https://bugs.webkit.org/show_bug.cgi?id=130772
Reviewed by Darin Adler.
HashTable has both copy constructor and copy assignment operator, meaning that the move constructor
and move assignment operator are implicitly deleted. This patch defines both to avoid unnecessary
copies when moves can be performed.
- wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):
- 3:08 AM Changeset in webkit [171261] by
-
- 2 edits in trunk/Source/WebCore
Document::unregisterNodeListforInvalidation() and Document::unregisterCollection() have incorrect assertions
https://bugs.webkit.org/show_bug.cgi?id=134869
Reviewed by Darin Adler.
Both methods should assert that the relevant HashMap is either empty if invalidation originates
from Document::invalidateNodeListAndCollectionCaches() or acutally contains the element that is
being invalidated. In the first case the HashMap is empty because its entries were moved out in
the Document::invalidateNodeListAndCollectionCaches().
This was exposed by r170995 (later rolled out in r170999) which introduced move constructor and
move assignment operators for HashTable. The assertions in the titular methods won't be passing
until r170995 relands.
- dom/Document.cpp:
(WebCore::Document::unregisterNodeListForInvalidation):
- 3:02 AM Changeset in webkit [171260] by
-
- 4 edits in trunk/Source/WebKit2
Consistently use uint64_t as the handle parameter type for the SetAcceleratedCompositingWindowId message
https://bugs.webkit.org/show_bug.cgi?id=135047
Reviewed by Darin Adler.
UIProcess' WebPageProxy is handling this parameter as an uint64_t, it should be handled as such
in WebProcess as well.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Also changed the parameter name to match other places.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setAcceleratedCompositingWindowId):
Jul 18, 2014:
- 10:25 PM Changeset in webkit [171259] by
-
- 2 edits in trunk/Source/WebCore
[iOS] ignore requests to set volume
https://bugs.webkit.org/show_bug.cgi?id=135081
Reviewed by Jer Noble.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Do nothing on iOS.
- 9:59 PM Changeset in webkit [171258] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard shouldn't show the full git hash
https://bugs.webkit.org/show_bug.cgi?id=135083
Reviewed by Benjamin Poulain.
Detect Git/Mercurial hash by checking the length.
If it's a hash, use the first 8 characters in the label
while retaining the full length to be used in hyperlinks.
- public/js/helper-classes.js:
(.this.formattedRevisions):
(TestBuild):
- 6:30 PM Changeset in webkit [171257] by
-
- 2 edits in trunk/Source/WebKit2
We don't provide an extension to the temp file used for uploads
https://bugs.webkit.org/show_bug.cgi?id=135079
Reviewed by Sam Weinig.
Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
extensions for the files passed to the content process.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
- 5:52 PM Changeset in webkit [171256] by
-
- 2 edits in trunk/Source/WebKit2
ASSERTion failures in ViewGestureController indicating that we're copying WebBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=135080
<rdar://problem/17734714>
Reviewed by Sam Weinig.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
- 5:51 PM Changeset in webkit [171255] by
-
- 2 edits in trunk/Tools
Revert accidental commit to MiniBrowser to make everything layer backed.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController windowDidLoad]):
- 5:47 PM Changeset in webkit [171254] by
-
- 3 edits2 copies in branches/safari-537.78-branch
Merge r169318.
- 5:21 PM Changeset in webkit [171253] by
-
- 2 edits in trunk/Source/WebKit2
_WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute.
https://bugs.webkit.org/show_bug.cgi?id=135077
When populate InteractionInformationAtPosition's title value, use a link element's innerText if it
doesn't have title attribute.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-07-18
Reviewed by Dan Bernstein.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 5:19 PM Changeset in webkit [171252] by
-
- 25 edits in trunk/Source
[iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
https://bugs.webkit.org/show_bug.cgi?id=135072
<rdar://problem/17528188>
Reviewed by David Kilzer.
Source/WebCore:
No new tests. Content filtering is not testable from WebKit.
- WebCore.exp.in: Exported necessary ContentFilter symbols.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading): Called FrameLoaderClient::contentFilterDidBlockLoad().
(WebCore::DocumentLoader::responseReceived): Created a new ContentFilter.
(WebCore::DocumentLoader::dataReceived): Called FrameLoaderClient::contentFilterDidBlockLoad().
(WebCore::DocumentLoader::setContentFilterForBlockedLoad): Deleted.
(WebCore::DocumentLoader::handleContentFilterRequest): Deleted.
- loader/DocumentLoader.h:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::contentFilterDidBlockLoad):
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy): Removed the check for unblock navigations, as this is now
handled at the WebKit layer.
- platform/ContentFilter.h: ContentFilter no longer needs to be RefCounted, so made various changes in order to
make it compatible with unique_ptr.
- platform/ios/ContentFilterIOS.mm:
(WebCore::scheme): Changed from a public member function to a static inline free function.
(WebCore::ContentFilter::handleUnblockRequestAndDispatchIfSuccessful): Renamed from requestUnblockAndDispatchIfSuccessful.
- platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter): Added a default constructor for use during message decoding.
(WebCore::ContentFilter::addData): Removed calls to ref() and deref(). These were never actually needed since
we were dispatching the block synchronously.
(WebCore::ContentFilter::finishedAddingData): Ditto.
(WebCore::ContentFilter::encode): Encoded m_platformContentFilter to the NSKeyedArchiver if it conforms to NSSecureCoding.
(WebCore::ContentFilter::decode): Decoded m_platformContentFilter from the NSKeyedUnarchiver if it conforms to NSSecureCoding.
(WebCore::ContentFilter::create): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
unblock request and ignore if so.
- WebView/WebFrame.mm:
(-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
If the unblock is successful, reload the main frame.
- WebView/WebFrameInternal.h:
Source/WebKit2:
- Shared/WebCoreArgumentCoders.h: Declared an ArgumentCoder for WebCore::ContentFilter.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ContentFilter>::encode): Encoded the ContentFilter using a NSKeyedArchiver.
(IPC::ArgumentCoder<ContentFilter>::decode): Decoded the ContentFilter using a NSKeyedUnarchiver.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::contentFilterDidBlockLoadForFrame): Called WebFrameProxy::setContentFilterForBlockedLoad().
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad): Reset m_contentFilterForBlockedLoad to nullptr.
(WebKit::WebFrameProxy::contentFilterDidHandleNavigationAction): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
If the unblock is successful, reload the WebPageProxy.
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::setContentFilterForBlockedLoad):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Check if this is navigation represents an unblock
request and ignore if so.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Defined ContentFilterDidBlockLoadForFrame.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::contentFilterDidBlockLoad): Sent ContentFilterDidBlockLoadForFrame to the WebPageProxy.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 5:11 PM Changeset in webkit [171251] by
-
- 2 edits in branches/safari-537.78-branch/Source/JavaScriptCore
Merge patch for <rdar://problem/16589513>
- 5:00 PM Changeset in webkit [171250] by
-
- 5 edits3 adds in trunk
[iOS WK2] position:fixed in iframes with programmatic scroll could end up in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=135078
Source/WebCore:
<rdar://problem/17401823>
Reviewed by Tim Horton.
When the UI-side scrolling tree receives a requested scroll position update, it scrolls
the node (e.g. a frame) then traverses child nodes to update them, e.g. for fixed position.
However, we would always use a viewport rect for the main document (from the scrolling tree),
which is not appropriate for subframes. Subframes should just use their own visible
rect to position fixed children.
Test: platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame.html
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):
Source/WebKit2:
<rdar://problem/17401823>
Reviewed by Tim Horton.
Fix the logging of requested scroll position and frame scale factor.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingTreeTextStream::dump):
LayoutTests:
Reviewed by Tim Horton.
Test with position:fixed inside an iframe that scrolls programmatically.
- platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/autoscrolling-frame-with-fixed.html: Added.
- 4:57 PM Changeset in webkit [171249] by
-
- 1 edit1 add in trunk
Add a manual test for r135044
<https://bugs.webkit.org/show_bug.cgi?id=135044>
Rubber-stamped by Andy Estes.
- ManualTests/ios/typing-in-field-that-clears-on-keyup.html: Added.
- 3:50 PM Changeset in webkit [171248] by
-
- 2 edits in tags/Safari-538.46.41/Source/WebCore
Merged r171215. <rdar://problem/17721209>
- 3:39 PM Changeset in webkit [171247] by
-
- 8 edits in trunk
Add a new 'analyze' target to the makefile. This will make use of a new
'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=135057
<rdar://problem/10193187>
Reviewed by David Kilzer.
- Makefile:
- Makefile.shared:
- Source/Makefile:
- 3:24 PM Changeset in webkit [171246] by
-
- 3 edits in trunk/Source/WebCore
Fixed position elements are misplaced when a WK1 view has contentInsets set
https://bugs.webkit.org/show_bug.cgi?id=135031
-and corresponding-
<rdar://problem/17682335>
Reviewed by Tim Horton.
[NSScrollView documentVisibleRect] includes content that is within the inset-area
of a view, but WebCore is interested in the content that is fully visible, so we
need to factor the inset sizes out of this rect.
Implement contract() to avoid the awkwardness of calling expand() with negative
values.
- platform/graphics/IntSize.h:
(WebCore::IntSize::contract):
Factor out insets
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformVisibleContentSize):
- 3:08 PM Changeset in webkit [171245] by
-
- 2 edits in trunk/Tools
Fix EFL+GTK.
- Scripts/run-jsc-stress-tests:
- 2:30 PM Changeset in webkit [171244] by
-
- 2 edits in tags/Safari-538.46.41/Source/WebCore
Rollout r171236. <rdar://problem/17721209>
- 2:26 PM Changeset in webkit [171243] by
-
- 5 edits in tags/Safari-538.46.41/Source
Versioning.
- 1:58 PM Changeset in webkit [171242] by
-
- 2 edits in trunk/LayoutTests
media/video-seek-with-negative-playback.html is flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=135071
- platform/mac/TestExpectations: Marked it as such.
- 1:54 PM Changeset in webkit [171241] by
-
- 5 edits in trunk
Exception fuzzing should work on iOS
https://bugs.webkit.org/show_bug.cgi?id=135070
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- tests/exceptionFuzz.yaml:
Tools:
- Scripts/jsc-stress-test-helpers/js-exception-fuzz:
(fail):
- Scripts/run-jsc-stress-tests:
- 1:50 PM Changeset in webkit [171240] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Use RetainPtr in _WKRemoteObjectInterface
https://bugs.webkit.org/show_bug.cgi?id=135062
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-18
Reviewed by Anders Carlsson.
Switch to RetainPtr instead of manual memory management of ivars.
- Shared/API/Cocoa/_WKRemoteObjectInterface.h:
- Shared/API/Cocoa/_WKRemoteObjectInterface.mm:
(-[_WKRemoteObjectInterface initWithProtocol:identifier:]):
(-[_WKRemoteObjectInterface identifier]):
(-[_WKRemoteObjectInterface description]):
(-[_WKRemoteObjectInterface dealloc]): Deleted.
- 1:34 PM Changeset in webkit [171239] by
-
- 15 edits in trunk/Source
Take navigation snapshots whenever the current back-forward item is going to change
https://bugs.webkit.org/show_bug.cgi?id=135058
<rdar://problem/17464515>
Reviewed by Dan Bernstein.
Instead of trying to have the UI process figure out when to take navigation snapshots by itself,
snapshot whenever the Web process says that the current back-forward item is going to change.
This fixes snapshotting timing with pushState, and lets us bottleneck snapshotting down to
just two places instead of 5.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
We no longer need to special-case taking navigation snapshots
when the UI process changes the back forward item or upon
didStartProvisionalLoadForFrame, because we'll always snapshot
in willChangeCurrentHistoryItem in all of these cases.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willChangeCurrentHistoryItem):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Add willChangeCurrentHistoryItem message, which comes from the Web process.
When it arrives, take a navigation snapshot.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
Take the pre-swipe navigation snapshot before telling WebPageProxy that we're doing a swipe,
so that it doesn't bail from taking the snapshot because we have a snapshot up.
(WebKit::ViewGestureController::endSwipeGesture):
We no longer need to explicitly disable snapshotting while navigating, because
we will avoid taking the snapshot if there's a snapshot being displayed.
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::~ViewGestureController):
Remove the snapshot if it's still up when ViewGestureController is destroyed.
The Mac version of ViewGestureController is destroyed on Web process crashes
because it is a message receiver, so it is not guaranteed to have the same
lifetime as the WebPageProxy and friends.
(WebKit::ViewGestureController::trackSwipeGesture):
Make use of recordNavigationSnapshot.
(WebKit::ViewGestureController::endSwipeGesture):
Ditto from the Mac version.
- UIProcess/mac/ViewSnapshotStore.h:
(WebKit::ViewSnapshotStore::disableSnapshotting): Deleted.
(WebKit::ViewSnapshotStore::enableSnapshotting): Deleted.
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::recordSnapshot):
Remove the snapshot disabling mechanism and bail from snapshotting if we're
showing a snapshot, as mentioned above.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::willChangeCurrentHistoryItem):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willChangeCurrentHistoryItem):
- WebProcess/WebPage/WebPage.h:
Proxy willChangeCurrentHistoryItem from HistoryController to the UI process.
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::recursiveUpdateForCommit):
(WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
(WebCore::HistoryController::createItem):
Use setCurrentItem instead of duplicating the contents of it inside each of these functions.
(WebCore::HistoryController::setCurrentItem):
(WebCore::HistoryController::replaceCurrentItem):
When setting or replacing the current item, let the FrameLoaderClient know that we're going
to change which history item is "current".
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::willChangeCurrentHistoryItem): Added.
- 12:41 PM Changeset in webkit [171238] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should be able to run helper-based tests in remote mode
https://bugs.webkit.org/show_bug.cgi?id=135064
Reviewed by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
- 12:29 PM Changeset in webkit [171237] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
https://bugs.webkit.org/show_bug.cgi?id=135061
Rubber stamped by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
- 12:17 PM Changeset in webkit [171236] by
-
- 2 edits in tags/Safari-538.46.41/Source/WebCore
Merged r171215. <rdar://problem/17721209>
- 12:15 PM Changeset in webkit [171235] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r171209. <rdar://problem/17720696>
- 12:13 PM Changeset in webkit [171234] by
-
- 2 edits in tags/Safari-600.1.1.1/Source/WebKit2
Merged r171209. <rdar://problem/17720696>
- 12:13 PM Changeset in webkit [171233] by
-
- 2 edits in trunk/Tools
Refactor run-jsc-stress-tests VM copying code to remove some abstractions
https://bugs.webkit.org/show_bug.cgi?id=135059
Reviewed by Mark Lam.
This is meant to make it easier for me to extend the copying functionality to copy things other than
the framework.
- Scripts/run-jsc-stress-tests:
- 12:08 PM Changeset in webkit [171232] by
-
- 5 edits in tags/Safari-600.1.1.1/Source
Versioning.
- 11:58 AM Changeset in webkit [171231] by
-
- 1 copy in tags/Safari-600.1.1.1
New tag.
- 11:55 AM Changeset in webkit [171230] by
-
- 5 edits in tags/Safari-538.46.41/Source
Versioning.
- 11:50 AM Changeset in webkit [171229] by
-
- 1 copy in tags/Safari-538.46.41
New Tag.
- 11:41 AM Changeset in webkit [171228] by
-
- 4 edits in trunk
Fix cloop build.
Source/JavaScriptCore:
- jsc.cpp:
(jscmain):
Tools:
- Scripts/jsc-stress-test-helpers/js-exception-fuzz:
- 11:20 AM Changeset in webkit [171227] by
-
- 3 edits in trunk/Source/WebInspectorUI
Revert r169735 since it broke Timeline, and fix bug 129696 in a more targeted way.
REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until collapse-expand.
https://bugs.webkit.org/show_bug.cgi?id=134845
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.adjustCollapsedRange): Use button isteand of assuming
item.listItemElement will be ready to use. The listItemElement node is lazily created.
- UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild): Don't attach unless _childrenListNode exists.
(TreeOutline.prototype.insertChild): Ditto.
- 11:01 AM Changeset in webkit [171226] by
-
- 2 edits in trunk/LayoutTests
Add timeout for transition end. Speculative layout test fix.
- fast/layers/no-clipping-overflow-hidden-added-after-transform.html:
- 10:21 AM Changeset in webkit [171225] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: Crash when typing into text field that clears itself on iOS
<https://bugs.webkit.org/show_bug.cgi?id=135044>
<rdar://problem/17640443>
Reviewed by Darin Adler.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestAutocorrectionData):
wordRangeFromPosition() returns null in some cases; null check range
before dereferencing it. Moved some variable declarations around to
better match our style.
- 10:14 AM Changeset in webkit [171224] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r171207.
https://bugs.webkit.org/show_bug.cgi?id=135056
Broke multiple tests on Yosemite (Requested by ap on #webkit).
Reverted changeset:
"Fixed position elements are misplaced when a WK1 view has
contentInsets set"
https://bugs.webkit.org/show_bug.cgi?id=135031
http://trac.webkit.org/changeset/171207
- 10:01 AM Changeset in webkit [171223] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Removing failure expectations for tests now passing.
- platform/gtk/TestExpectations: Removed failure expectations.
- 9:53 AM Changeset in webkit [171222] by
-
- 9 edits2 deletes in trunk
Unreviewed, rolling out r171218.
https://bugs.webkit.org/show_bug.cgi?id=135055
Made fast/dom/HTMLObjectElement/beforeload-set-text-
crash.xhtml crash (Requested by ap on #webkit).
Reverted changeset:
"REGRESSION (r169105): Crash in selection"
https://bugs.webkit.org/show_bug.cgi?id=134303
http://trac.webkit.org/changeset/171218
- 8:23 AM Changeset in webkit [171221] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening. Tests passing after SVN r171001
- platform/gtk/TestExpectations: Removed tests that are now passing.
- 7:37 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:12 AM Changeset in webkit [171220] by
-
- 2 edits in trunk/Tools
Fix -vverbose option in sort-export-file script. https://bugs.webkit.org/show_bug.cgi?id=135043
Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-07-18
Reviewed by Tim Horton.
-vverbose option does not work. Option added to getOptionsResult. - Scripts/sort-export-file:
- 6:41 AM Changeset in webkit [171219] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Provide a mechanism to grab the back-forward list for gesture navigation purposes from another WKWebView
https://bugs.webkit.org/show_bug.cgi?id=134999
<rdar://problem/17238025>
Reviewed by Sam Weinig.
In some cases, clients may need to throw a WKWebView with no back-forward list over
another WKWebView, and want to participate in gesture swipe as if they were actually
the page being overlaid.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView setAllowsBackForwardNavigationGestures:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _alternateWebViewForNavigationGestures]):
(-[WKWebViewConfiguration _setAlternateWebViewForNavigationGestures:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Keep an "alternate" WKWebView "for navigation gestures", which ViewGestureController
will use as the real source of back-forward items, and the destination of the swipe navigation.
All swipe delegate callbacks will also fire from the alternate view, because it owns the items
and will be doing the navigation.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::setAlternateBackForwardListSourceView):
(WebKit::ViewGestureController::beginSwipeGesture):
Send navigationGestureDidBegin via the alternate view's WebPageProxy if it exists.
Record a new snapshot on the current page, but copy it to the alternate view if necessary,
so that when swiping forward from the alternate view, it will have the "right" snapshot.
Get the target back forward item from the alternate view.
Send navigationGestureWillEnd via the alternate view's WebPageProxy if it exists.
(WebKit::ViewGestureController::canSwipeInDirection):
Determine if we can swipe in a direction by looking at the alternate view's back-forward list if necessary.
(WebKit::ViewGestureController::endSwipeGesture):
Send navigationGestureDidEnd via the alternate view's WebPageProxy if it exists.
Perform the navigation on the alternate view if necessary.
(WebKit::ViewGestureController::removeSwipeSnapshot):
Send navigationGestureSnapshotWasRemoved via the alternate view's WebPageProxy if it exists.
- UIProcess/mac/ViewGestureController.h:
- 2:50 AM Changeset in webkit [171218] by
-
- 9 edits2 adds in trunk
REGRESSION (r169105): Crash in selection
https://bugs.webkit.org/show_bug.cgi?id=134303
Patch by Radu Stavila <stavila@adobe.com> on 2014-07-18
Reviewed by Ryosuke Niwa.
Source/WebCore:
When splitting the selection between different subtrees, all subtrees must have their selection cleared before
starting to apply the new selection. Otherwise, when selecting objects in a named flow thread and going up
its containing block chain, we can end up in the view's selection root, which has not yet been updated and so
we get inconsistent data.
To achieve this goal, the selection update was split into a "clear" and an "apply" method. The updateSelectionForSubtrees
method first iterates through all subtrees and performs the "clear" method and then starts all over again
and performs the "apply" method.
Also, the selectionStart/End members in RenderView have been renamed to fix problems caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.
Test: fast/regions/selection/crash-deselect.html
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
- rendering/RenderSelectionInfo.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection): Renamed m_selectionStart/End to m_unsplitSelectionStart/End
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees): Added, clears and re-applies selection for all selection subtrees.
(WebCore::RenderView::clearSubtreeSelection): Added, clears selection and returns previously selected information.
(WebCore::RenderView::applySubtreeSelection): Added, updates the selection status of all objects inside the selection tree, compares old and new data and repaints accordingly.
(WebCore::RenderView::getSelection): Renamed m_selectionStart/End to m_unsplitSelectionStart/End
(WebCore::RenderView::setSubtreeSelection): Deleted.
- rendering/RenderView.h:
- rendering/SelectionSubtreeRoot.cpp:
(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot):
- rendering/SelectionSubtreeRoot.h:
(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData):
LayoutTests:
Added test for the crash that occurred in some cases when selecting.
- fast/regions/selection/crash-deselect-expected.txt: Added.
- fast/regions/selection/crash-deselect.html: Added.
- 12:13 AM Changeset in webkit [171217] by
-
- 2 edits in trunk/Tools
Really remove dependency on ShellQuote.
- Scripts/jsc-stress-test-helpers/js-exception-fuzz:
- 12:11 AM Changeset in webkit [171216] by
-
- 3 edits in trunk/Tools
Unreviewed, fix build for platforms that don't have ShellQuote.
- Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
- Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
