Timeline
Oct 20, 2015:
- 11:41 PM Changeset in webkit [191377] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
https://bugs.webkit.org/show_bug.cgi?id=150221
<rdar://problem/23149771>
Reviewed by Darin Adler and Antti Koivisto.
Generalize NetworkCacheStorage API so it can store different types of
metadata alongside the network resources. This is a pre-requirement to
making our NetworkCache smarter by storing information about the
resources.
To keep the code simple, the entry type is now part of the entry key and
we store records of a specific type in a 'type' subfolder. The cache
structure looks like so:
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)
Existing cache entries now that the 'resource' type as these are network
resources.
- NetworkProcess/cache/NetworkCache.cpp:
- NetworkProcess/cache/NetworkCacheKey.cpp:
- NetworkProcess/cache/NetworkCacheKey.h:
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
- NetworkProcess/cache/NetworkCacheStorage.h:
- 11:20 PM Changeset in webkit [191376] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html as flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=150378
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Alexey Proskuryakov.
- platform/mac-wk2/TestExpectations:
- 11:08 PM Changeset in webkit [191375] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=150363
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Alexey Proskuryakov.
- platform/mac-wk2/TestExpectations:
- 10:36 PM Changeset in webkit [191374] by
-
- 10 edits in trunk
run-webkit-tests does not copy all crash logs for layout test failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=150056
Tools:
<rdar://problem/9280656>
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-20
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_all_logs): Generic method to find all crash logs.
(CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
It iterates through log directory and returns all the logs based on timestamp.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
(CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
(CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Modified start_time to start counting before simulator launch
so that we can capture crashes during simualator launch.
(Manager._look_for_new_crash_logs): Browse through list of crashes and append
any test which is not already marked as CRASH to the run_results.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationsModel.get_expectations_string): return PASS in case there
are no expectations defined for this test.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results): Add other_crashes in a separte category in full_results.json.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
from the log directory.
(IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
logs from log directory and merge them with the list of already crashed tests.
LayoutTests:
<rdar://problem/22239750>
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-20
Reviewed by Alexey Proskuryakov.
- fast/harness/results.html: Added the column for Other crashes, this contain
all the newly find crashes from the crash-log directory. Added method forOtherCrashes
which processes othre_crashes section from full_results.json. Also fixed the method
splitExtension to handle the case when there is no extension.
- 10:09 PM Changeset in webkit [191373] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed, rolling out r191370.
https://bugs.webkit.org/show_bug.cgi?id=150384
Broke iOS 9 build (Requested by ap on #webkit).
Reverted changeset:
"Fix build for clang-700.0.59.5 by replacing deprecated calls
to convertScreenToBase: with convertRectFromScreen:."
https://bugs.webkit.org/show_bug.cgi?id=150379
http://trac.webkit.org/changeset/191370
- 9:51 PM Changeset in webkit [191372] by
-
- 2 edits in trunk/Tools
Fix the build
Unreviewed.
My previous patch was missing a necessary space character.
- Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
- 9:25 PM Changeset in webkit [191371] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file
https://bugs.webkit.org/show_bug.cgi?id=150298
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection):
Beep when saving didn't work. Inline CSS and CSS in style attributes aren't curently supported.
- 7:21 PM Changeset in webkit [191370] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix build for clang-700.0.59.5 by replacing deprecated calls to convertScreenToBase: with convertRectFromScreen:.
https://bugs.webkit.org/show_bug.cgi?id=150379
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-10-20
Reviewed by Simon Fraser.
- WebView/WebHTMLView.mm:
(-[WebHTMLView characterIndexForPoint:]):
Convert point to rect, and call convertRectFromScreen:.
(-[WebHTMLView firstRectForCharacterRange:]):
Replace convertBaseToScreen: with convertRectToScreen:.
- 7:12 PM Changeset in webkit [191369] by
-
- 50 edits in trunk/Source/WebCore
Replace 0 and NULL with nullptr in WebCore/loader.
https://bugs.webkit.org/show_bug.cgi?id=149657
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- loader/CookieJar.cpp:
(WebCore::networkingContext):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::frameLoader):
(WebCore::DocumentLoader::popArchiveForSubframe):
(WebCore::DocumentLoader::clearArchiveResources):
(WebCore::DocumentLoader::clearMainResource):
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::clearResource):
- loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
- loader/EmptyClients.h:
- loader/FTPDirectoryParser.cpp:
(WebCore::parseOneFTPLine):
- loader/FTPDirectoryParser.h:
(WebCore::ListResult::clear):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::detachViewsAndDocumentLoader):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- loader/FrameLoader.h:
(WebCore::FrameLoader::stateMachine):
- loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::invalidate):
- loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::updateFromElement):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::releaseResources):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::releaseResources):
- loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::TextResourceDecoder):
- loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::clearClient):
(WebCore::ThreadableLoaderClientWrapper::done):
- loader/appcache/ApplicationCache.cpp:
(WebCore::fallbackURLLongerThan):
(WebCore::ApplicationCache::ApplicationCache):
(WebCore::ApplicationCache::resourceForRequest):
- loader/appcache/ApplicationCache.h:
(WebCore::ApplicationCache::fallbackURLs):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::failedLoadingMainResource):
(WebCore::ApplicationCacheGroup::manifestNotFound):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::setApplicationCache):
- loader/appcache/ApplicationCacheHost.h:
(WebCore::ApplicationCacheHost::candidateApplicationCacheGroup):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::StorageIDJournal::Record::Record):
(WebCore::StorageIDJournal::Record::restore):
(WebCore::ApplicationCacheStorage::loadCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
(WebCore::ApplicationCacheStorage::loadCache):
- loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::disconnectFrameForPageCache):
(WebCore::DOMApplicationCache::willDestroyGlobalObjectInFrame):
(WebCore::DOMApplicationCache::applicationCacheHost):
(WebCore::DOMApplicationCache::scriptExecutionContext):
(WebCore::DOMApplicationCache::toEventType):
- loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::create):
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):
- loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):
(WebCore::MHTMLArchive::generateMHTMLData):
- loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::MHTMLParser::parseArchiveWithHeader):
(WebCore::MHTMLParser::parseNextPart):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
- loader/cache/CachedImageClient.h:
(WebCore::CachedImageClient::imageChanged):
(WebCore::CachedImageClient::newImageAnimationFrameAvailable):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::calculateIncrementalDataChunk):
- loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::clearResourceToRevalidate):
- loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::next):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::canRequest): Return value is bool.
(WebCore::CachedResourceLoader::requestResource):
- loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::document):
(WebCore::CachedResourceLoader::setDocument):
(WebCore::CachedResourceLoader::clearDocumentLoader):
- loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
- loader/cf/ResourceLoaderCFNet.cpp:
(WebCore::ResourceLoader::shouldCacheResponse): Return value is bool.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreatePageURLRecord):
(WebCore::IconDatabase::cleanupSyncThread):
- loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::open):
(WebCore::iconDatabase):
- loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
- loader/icon/PageURLRecord.cpp:
(WebCore::PageURLRecord::~PageURLRecord):
(WebCore::PageURLRecord::setIconRecord):
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
- loader/soup/CachedRawResourceSoup.cpp:
(WebCore::CachedRawResource::getOrCreateReadBuffer):
- 6:53 PM Changeset in webkit [191368] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194.
https://bugs.webkit.org/show_bug.cgi?id=150311
Reviewed by Gyuyoung Kim.
Restore the test_ewk2_context_menu API test to check the context menu whether it works correctly.
- PlatformEfl.cmake:
- 6:41 PM Changeset in webkit [191367] by
-
- 3 edits1 add in trunk/Tools
svn-apply fails to apply binary diffs in some cases
https://bugs.webkit.org/show_bug.cgi?id=64647
Reviewed by Daniel Bates.
- Scripts/VCSUtils.pm:
(decodeGitBinaryPatchDeltaSize): Modified.
We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
- Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
- 6:10 PM Changeset in webkit [191366] by
-
- 3 edits in trunk/Source/WebKit2
_WKThumbnailView should support a snapshot-only mode
https://bugs.webkit.org/show_bug.cgi?id=150106
Reviewed by Tim Horton.
Add a new property to _WKThumbnailView, exclusivelyUsesSnapshot, which causes _WKThumbnailView
to bypass both layer tree reparenting and event suppression on the associated WKView.
Add a new method, -requestSnapshot, which clients can use to force _WKThumbnailView to refresh
on demand.
- UIProcess/API/Cocoa/_WKThumbnailView.h:
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView requestSnapshot]):
Extracted from -_requestSnapshotIfNeeded:.
(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):
- 4:40 PM Changeset in webkit [191365] by
-
- 3 edits in trunk/Source/WebKit2
Build fix.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
- UIProcess/ios/forms/WKFileUploadPanel.mm:
- 4:38 PM Changeset in webkit [191364] by
-
- 3 edits3 adds in trunk
YarrPatternConstructor::containsCapturingTerms() should not assume that its terms.size() is greater than 0.
https://bugs.webkit.org/show_bug.cgi?id=150372
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
LayoutTests:
- js/regress-150372-expected.txt: Added.
- js/regress-150372.html: Added.
- js/script-tests/regress-150372.js: Added.
- 4:15 PM Changeset in webkit [191363] by
-
- 2 edits in trunk/Source/WebKit2
ASSERT when right clicking on SVG Image generating Share menu - can break Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=150374
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-20
Reviewed by Brian Burg.
When there is no absolute URL or downloadable media URL no system share
menu is created, but we were still appending the null context menu to
the list of context menu items.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::shareMenuItem):
Bail early if the context menu is null.
(WebKit::WebContextMenuProxyMac::showContextMenu):
Only append the share context menu item if it is non-null.
This matches ContextMenuController.cpp in WebCore.
- 3:49 PM Changeset in webkit [191362] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebKit2
Build fix.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(photoLibraryIcon):
- 3:38 PM Changeset in webkit [191361] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, GTK API test fix after r191351.
Reverted API change for GTK bindings.
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- 3:02 PM Changeset in webkit [191360] by
-
- 13 edits3 adds in trunk
REGRESSION (r191175): OSR Exit from an inlined tail callee trashes callee save registers
https://bugs.webkit.org/show_bug.cgi?id=150336
Reviewed by Mark Lam.
Source/JavaScriptCore:
During OSR exit, we need to restore and transform the active stack into what the baseline
JIT expects. Inlined call frames become true call frames. When we reify an inlined call
frame and it is a tail call which we will be continuing from, we need to restore the tag
constant callee save registers with what was saved by the outermost caller.
Re-enabled tail calls and restored tests for tail calls.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames): Select whether or not we use the callee save tag register
contents or what was saved by the inlining caller when populating an inlined callee's
callee save registers.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor): This function no longer needs a stack offset.
(JSC::AssemblyHelpers::emitSaveOrCopyCalleeSavesFor): New helper.
- runtime/Options.h: Turned tail calls back on.
- tests/es6.yaml:
- tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
- tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
- tests/stress/tail-call-in-inline-cache.js:
(tail):
- tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
- tests/stress/tail-call-recognize.js:
(callerMustBeRun):
- tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):
LayoutTests:
Added a new regression test and restored tail call test results for js/caller-property.
- js/caller-property-expected.txt:
- js/regress-150336-expected.txt: Added.
- js/regress-150336.html: Added.
- js/script-tests/regress-150336.js: Added.
(bar):
(foo):
(test):
- 3:00 PM Changeset in webkit [191359] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Another GTK build fix after r191351.
- html/HTMLCollection.idl:
- 2:51 PM Changeset in webkit [191358] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, Another GTK build fix after r191351.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elementsForNativeBindings):
(WebCore::HTMLFieldSetElement::elementsForObjC): Deleted.
- html/HTMLFieldSetElement.h:
- html/HTMLFieldSetElement.idl:
- 2:34 PM Changeset in webkit [191357] by
-
- 2 edits in trunk/Source/WebCore
AX: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116
https://bugs.webkit.org/show_bug.cgi?id=150349
Reviewed by Brent Fulgham.
The crash point for this bug says that the parentElement of the firstBody is garbage when it's accessed.
Unfortunately, I could not reproduce this in-situ or with a test.
So my speculative solution is to recalculate those body elements to ensure that they're valid before we access.
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isDataTable):
- 1:54 PM Changeset in webkit [191356] by
-
- 2 edits in trunk/LayoutTests
Take 2 on rebaselining fast/dynamic/insert-before-table-part-in-continuation.html
https://bugs.webkit.org/show_bug.cgi?id=150126
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Zalan Bujtas.
- platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- 1:48 PM Changeset in webkit [191355] by
-
- 12 edits2 adds in trunk
Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
https://bugs.webkit.org/show_bug.cgi?id=150096
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::scriptCommentPattern): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceURL): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceMapURL): Deleted.
- inspector/ContentSearchUtilities.h:
No longer need to search script content.
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::dispatchDidParseSource):
Carry over the sourceURL and sourceMappingURL from the SourceProvider.
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
No longer do content searching.
- parser/Lexer.cpp:
(JSC::Lexer<T>::setCode):
(JSC::Lexer<T>::skipWhitespace):
(JSC::Lexer<T>::parseCommentDirective):
(JSC::Lexer<T>::parseCommentDirectiveValue):
(JSC::Lexer<T>::consume):
(JSC::Lexer<T>::lex):
- parser/Lexer.h:
(JSC::Lexer::sourceURL):
(JSC::Lexer::sourceMappingURL):
(JSC::Lexer::sourceProvider): Deleted.
Give lexer the ability to detect script comment directives.
This just consumes characters in single line comments and
ultimately sets the sourceURL or sourceMappingURL found.
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
- parser/SourceProvider.h:
(JSC::SourceProvider::url):
(JSC::SourceProvider::sourceURL):
(JSC::SourceProvider::sourceMappingURL):
(JSC::SourceProvider::setSourceURL):
(JSC::SourceProvider::setSourceMappingURL):
After parsing a script, update the Source Provider with the
value of directives that may have been found in the script.
Source/WebInspectorUI:
- UserInterface/Test/InspectorProtocol.js:
(InspectorProtocol._sendMessage):
(InspectorProtocol.dispatchMessageFromBackend):
This is only used for tests, so avoid console.log
and just dump directly to the system console.
LayoutTests:
- inspector/debugger/sourceURLs-expected.txt: Added.
- inspector/debugger/sourceURLs.html: Added.
sourceURL and sourceMappingURL detection.
- 1:47 PM Changeset in webkit [191354] by
-
- 7 edits in trunk/Source/WebKit2
Unreviewed, rolling out r191306.
https://bugs.webkit.org/show_bug.cgi?id=150371
"May have caused a significant warm PLT regression" (Requested
by cdumez_ on #webkit).
Reverted changeset:
"[WK2] Generalize NetworkCacheStorage API so it can store
different types of metadata"
https://bugs.webkit.org/show_bug.cgi?id=150221
http://trac.webkit.org/changeset/191306
Patch by Commit Queue <commit-queue@webkit.org> on 2015-10-20
- 1:42 PM WebKitNightlyElCapWorkaround edited by
- (diff)
- 1:42 PM Changeset in webkit [191353] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, GTK build fix after r191351.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementsForNativeBindings):
(WebCore::HTMLFormElement::elementsForObjC): Deleted.
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl:
- 1:38 PM Changeset in webkit [191352] by
-
- 17 edits in trunk/Source/WebCore
Add basic TextStream output for Images
https://bugs.webkit.org/show_bug.cgi?id=150350
Reviewed by Darin Adler.
Add a TextStream output operator for Image, and virtual dump() member functions
that the various image types override to dump their own data.
Add isFoo() functions for each image type (surprising that these didn't already
exist) so we can print the image type.
Make isAnimated() const, and isBitmapImage() private.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dump):
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::dump):
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.cpp:
- platform/graphics/GeneratedImage.h:
- platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::dump):
- platform/graphics/GradientImage.h:
- platform/graphics/Image.cpp:
(WebCore::Image::dump):
(WebCore::operator<<):
- platform/graphics/Image.h:
(WebCore::Image::isGeneratedImage):
(WebCore::Image::isCrossfadeGeneratedImage):
(WebCore::Image::isNamedImageGeneratedImage):
(WebCore::Image::isGradientImage):
(WebCore::Image::isSVGImage):
(WebCore::Image::isAnimated):
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::dump):
- platform/graphics/NamedImageGeneratedImage.h:
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::dump):
- platform/graphics/cg/PDFDocumentImage.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dump):
- svg/graphics/SVGImage.h:
- 11:48 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 11:48 AM Changeset in webkit [191351] by
-
- 27 edits in trunk/Source/WebCore
Use tighter typing for collections / node lists' item() / namedItem() methods
https://bugs.webkit.org/show_bug.cgi?id=150347
Reviewed by Darin Adler.
Use tighter typing for collections / node lists' item() / namedItem() methods.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
- dom/LiveNodeList.h:
- dom/StaticNodeList.cpp:
(WebCore::StaticElementList::item):
- dom/StaticNodeList.h:
- html/CachedHTMLCollection.h:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
(WebCore::HTMLFieldSetElement::elementsForObjC):
- html/HTMLFieldSetElement.h:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::customElementAfter):
- html/HTMLFormControlsCollection.h:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::item):
(WebCore::HTMLFormElement::elements):
(WebCore::HTMLFormElement::elementsForObjC):
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl:
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::namedItem):
(WebCore::HTMLSelectElement::item):
(WebCore::HTMLSelectElement::setOption):
- html/HTMLSelectElement.idl:
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::deleteCell):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::deleteRow):
- html/RadioNodeList.cpp:
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
- html/RadioNodeList.h:
- html/RadioNodeList.idl:
- 11:45 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 11:43 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 11:37 AM Changeset in webkit [191350] by
-
- 3 edits in trunk/Source/JavaScriptCore
GCAwareJITStubRoutineWithExceptionHandler has a stale CodeBlock pointer in its destructor
https://bugs.webkit.org/show_bug.cgi?id=150351
Reviewed by Mark Lam.
We may regenerate many GCAwareJITStubRoutineWithExceptionHandler stubs per one PolymorphicAccess.
Only the last GCAwareJITStubRoutineWithExceptionHandler stub that was generated will get the CodeBlock's aboutToDie()
notification. All other GCAwareJITStubRoutineWithExceptionHandler stubs will still be holding a stale CodeBlock pointer
that they will use in their destructor. The solution is to have GCAwareJITStubRoutineWithExceptionHandler remove its
exception handler in observeZeroRefCount() instead of its destructor. observeZeroRefCount() will run when a PolymorphicAccess
replaces its m_stubRoutine.
- jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount):
(JSC::createJITStubRoutine):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler): Deleted.
- jit/GCAwareJITStubRoutine.h:
- 11:33 AM Changeset in webkit [191349] by
-
- 3 edits2 adds in trunk
Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes
https://bugs.webkit.org/show_bug.cgi?id=150335
Reviewed by Darin Adler.
Source/WebCore:
Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes:
https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 12.3)
https://html.spec.whatwg.org/multipage/infrastructure.html#space-character
Previously, we were uding the wrong stripping function and we were stripping
some non-HTML spaces.
Test: fast/dom/script-for-event-spaces.html
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::isScriptForEventSupported):
LayoutTests:
Add a layout test to check that U+000B does not get stripped from the
script's 'for' / 'event' attributes.
- fast/dom/script-for-event-spaces-expected.txt: Added.
- fast/dom/script-for-event-spaces.html: Added.
- 11:30 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 11:15 AM Changeset in webkit [191348] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html flakily times out on Mavericks WK1
https://bugs.webkit.org/show_bug.cgi?id=150367
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Darin Adler.
- platform/mac-wk1/TestExpectations:
- 11:00 AM Changeset in webkit [191347] by
-
- 2 edits in trunk/Source/WTF
Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10
- wtf/FeatureDefines.h:
- 10:56 AM Changeset in webkit [191346] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Touch a file to trigger a build.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker initWithView:]):
- 10:24 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 10:23 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 10:23 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 10:23 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 10:20 AM WebKitNightlyElCapWorkaround created by
- Initial workaround steps.
- 10:19 AM Changeset in webkit [191345] by
-
- 3 edits in trunk/Tools
Mac Debug EWS never finishes when there are failures
https://bugs.webkit.org/show_bug.cgi?id=150334
Reviewed by Daniel Bates.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 10:16 AM Changeset in webkit [191344] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128
https://bugs.webkit.org/show_bug.cgi?id=150321
Reviewed by Darin Adler.
- css/CSSGrammar.y.in: Typo fix.
- 9:41 AM Changeset in webkit [191343] by
-
- 8 edits in trunk/Source
Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10
- 9:02 AM Changeset in webkit [191342] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r191333.
https://bugs.webkit.org/show_bug.cgi?id=150362
Caused assertions on regression tests (Requested by ap on
#webkit).
Reverted changeset:
"ERROR: Unhandled web process message
'StorageAreaMap:DispatchStorageEvent'"
https://bugs.webkit.org/show_bug.cgi?id=150315
http://trac.webkit.org/changeset/191333
- 8:04 AM Changeset in webkit [191341] by
-
- 2 edits in trunk/Source/WebKit2
[UNIX] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection::connectionDidClose()
https://bugs.webkit.org/show_bug.cgi?id=150361
Reviewed by Martin Robinson.
It doesn't always happen because it depends on how sockets are
closed, and the state of the threads. The problem is that we are
not handling the case when the read fails because we closed the
connection. In that case we log the error and call
Connection::connectionDidClose(). But it was connectionDidClose()
the one closing the socket. So, in this particular case it's not an
error but a normal termination, and we shouldn't try to close the
connection again. Something similar can happen while sending a
message, and we get a broken pipe error, but in that case we are
only printing the error, so it's harmless.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::readyReadHandler): Only print error and call
connectionDidClose() if we are still connected when read fails.
(IPC::Connection::sendOutgoingMessage): Only print error if we are
still connected when send fails.
- 5:03 AM Changeset in webkit [191340] by
-
- 18 edits in trunk/Source/WebKit2
[GTK] Graphics corruption when entering/leaving AC mode quickly
https://bugs.webkit.org/show_bug.cgi?id=150323
Reviewed by Mario Sanchez Prada.
The UI process is notified when entering accelerated compositing
mode after the layers have been flushed and rendered to avoid
flickering. However, this is producing flickering in the GTK+
port, because we use an offscreen redirected window that is
resized to a minimium size to save memory when not in AC mode. The
web process always uses the current size of the redirected window,
so when entering AC mode, contents are rendered into the 1x1
window, then the UI process is notified, the redirected window is
resized to its actual size, and we force a resize to ask the web
process to render again, now at the correct size. Rendering at 1x1
and then resizing the window is what produces the flickering when
entering AC mode, but it's also inefficient, since we need to
render again after the redirected window is resized. So, this
patch adds a WillEnterAcceleratedCompositing message that is sent
to the UI process when the layer tree host is created but before
the contents have been composited and rendered. This is
implemented by the GTK+ port to prepare for entering AC mode, by
resizing the redirected window. When we actually enter AC mode,
the contents have already been rendered in the web process at the
correct size, so we can just use the redirected window surface
instead of the drawing area one, and paint in the web view without
any flickering. We no longer need the forceResize either.
When leaving accelerated compositing mode, we now clear the redirected
window resources after a short delay. This ensures that we have
already rendered the update sent in the ExitAcceleratedCompositingMode
message, but also that entering/leaving AC mode quickly doesn't
produce any redirected window resize.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseClearRedirectedWindowSoon):
(webkitWebViewBaseWillEnterAcceleratedCompositingMode):
(webkitWebViewBaseEnterAcceleratedCompositingMode):
(webkitWebViewBaseExitAcceleratedCompositingMode):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::willEnterAcceleratedCompositingMode):
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::willEnterAcceleratedCompositingMode):
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::forceResize): Deleted.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willEnterAcceleratedCompositingMode):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
- 4:37 AM Changeset in webkit [191339] by
-
- 3 edits in trunk/Tools
[GTK] Enable OpenWebRTC test video/audio sources in tests
This is needed because we can't expect the buildbots to have
webcam/mic devices plugged in.
Rubber-stamped by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- 3:40 AM Changeset in webkit [191338] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix build for ENABLE_PLUGIN_PROCESS_GTK2=OFF
https://bugs.webkit.org/show_bug.cgi?id=150086
Reviewed by Darin Adler.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend):
- 3:07 AM Changeset in webkit [191337] by
-
- 3 edits in trunk/LayoutTests
[Streams API] Update readable-stream-templated tests to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149668
Reviewed by Darin Adler.
- streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
- streams/reference-implementation/readable-stream.html: Updated tests.
- 2:57 AM Changeset in webkit [191336] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: computeMainAxisExtentForChild(child, MainOrPreferredSize, mainSize) in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=149459
Reviewed by Darin Adler.
Source/WebCore:
This was regressed after 189567 where min-height|width:auto
support was added to flex items. The merge from Blink changes
was not correctly done for assertions. In particular we were
asserting if the resolved main size was not strictly greater
than 0, but 0 is actually a valid value.
Test: fast/flexbox/crash-resolved-main-size-zero.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
LayoutTests:
- fast/flexbox/crash-resolved-main-size-zero-expected.txt: Added.
- fast/flexbox/crash-resolved-main-size-zero.html: Added.
- 2:51 AM Changeset in webkit [191335] by
-
- 14 edits1 add in trunk/Source
[Streams API] Rework some readable stream internals that can be common to writable streams
https://bugs.webkit.org/show_bug.cgi?id=150133
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Added RangeError also as native functions.
Source/WebCore:
There are some things in ReadableStream internals that be be used also for Writable Streams so it was necessary
to move some functions and refactor some code that can be shared by both implementations.
Queue was written with the functions declared at the implementation and keeping the improvement of having the
total size calculated instead of having to transverse the whole array.
The strategy is kept as an object and a common method is used to validate it as per spec.
Promises are reworked to keep in an internal slot inside the promise object the resolve and reject
functions. For convinience three functions were written, one to create the promise (and keep internally the
resolve and reject functions), one to resolve and another to reject. Promises can still be created with
Promise.resolve or reject as the resolve and rejectStreamsPromise functions operate under the assumption that
the internal slots might not exist.
invokeOrNoop and promiseInvokeOrNoop were moved to the common code as they will be also used by WritableStream.
Current test set suffices.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/WebCoreJSBuiltinInternals.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
- Modules/streams/ReadableStream.js:
(initializeReadableStream): Reworked queue and strategy.
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader):
(errorReadableStream):
(getReadableStreamDesiredSize):
(cancelReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader): Reworked queue, strategy and promises.
(invokeOrNoop): Deleted.
(promiseInvokeOrNoop): Deleted.
- Modules/streams/StreamInternals.js: Added.
(invokeOrNoop):
(promiseInvokeOrNoop): Moved from ReadableStreamInternals.js.
(validateAndNormalizeQueuingStrategy):
(createNewStreamsPromise):
(resolveStreamsPromise):
(rejectStreamsPromise):
(newQueue):
(dequeueValue):
(enqueueValueWithSize): Added according to the spec.
- bindings/js/WebCoreBuiltinNames.h: Updated private names according to the new slots.
- 2:49 AM Changeset in webkit [191334] by
-
- 24 edits in trunk
Rename the PICTURE_SIZES flag to CURRENTSRC
https://bugs.webkit.org/show_bug.cgi?id=150275
Reviewed by Dean Jackson.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests, since there is no functional change.
- Configurations/FeatureDefines.xcconfig:
- html/HTMLImageElement.cpp:
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
Oct 19, 2015:
- 11:21 PM Changeset in webkit [191333] by
-
- 2 edits in trunk/Source/WebKit2
ERROR: Unhandled web process message 'StorageAreaMap:DispatchStorageEvent'
https://bugs.webkit.org/show_bug.cgi?id=150315
Reviewed by Andreas Kling.
It was introduced in r184930, that keeps the session storage area
maps alive in the UI process when they are destroyed by the web
process. The problem is that we also keep the listeners, so that
events are also dispatched to the listeners of destroyed areas,
and the message handlers were removed in the web process.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createTransientLocalStorageMap): Add a
listener for the new storage map ID when the map is reused.
(WebKit::StorageManager::destroyStorageMap): Always remove
listeners of destroyed maps.
- 11:18 PM Changeset in webkit [191332] by
-
- 3 edits in trunk/Source/WebCore
ASSERTION FAILED: m_state == Initialized in SubresourceLoader::didReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=150327
Reviewed by Antti Koivisto.
This is how it happens:
- print() is called while the document is still loading, so m_shouldPrintWhenFinishedLoading is set to true
- DataURLDecoder::decode() finishes in the work queue thread, the completion handler is scheduled in the main thread
- The load is cancelled 3.1. SubresourceLoader::willCancel sets m_state = Finishing 3.2. DOMWindow::finishedLoading() is called, and since
m_shouldPrintWhenFinishedLoading is true, it does the print.
3.3. Cancellation finishes and ResourceLoader::releaseResources()
is called that sets m_reachedTerminalState = true
So, between 3.1 and 3.3, the state is Finishing, but
m_reachedTerminalState is false. What happens, in the GTK+ port at
least, is that the nested main loop used to make print()
synchronous, processes the DataURLDecoder::decode() completion
handler that was pending. The completion handler returns early if
m_reachedTerminalState is true, but it's not yet in this
particular case. So, it ends up calling didReceiveResponse,
because the decode didn't fail, when the subresource loader state
is Finishing.
I think there are two things here. One is that we shouldn't start
a print that was waiting for the load to finish when it
failed. That would fix the problem. But it's probably a good idea
to also check for cancellation in the DataURLDecoder::decode()
completion handler.
Fixes printing/print-close-crash.html in GTK+ Debug.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL): Return early from
DataURLDecoder::decode() completion handler if the load was cancelled.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::finishedLoading): Do not start a print that
was witing for the load to finish when it failed.
- 9:55 PM Changeset in webkit [191331] by
-
- 13 edits2 adds in trunk
FontCascade::typesettingFeatures() is not privy to font-variant-* nor font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=149775
Reviewed by Darin Adler.
Source/WebCore:
This patch has two pieces:
We used to have a boolean, enableLigatures, which affected how we perform shaping in both our
simple and complex text codepaths. However, in this brave new world of font-feature-settings
and font-variant-*, there are many properties which may affect shaping (and multiple kinds
of ligatures). This patch renames this boolean to requiresShaping, and teaches it about all
the various properties which affect text shaping.
Similarly, one of the places which used this enableLigatures boolean was to tell CoreText
if it should disable ligatures. However, we now have much finer-grained control over
ligatures during font creation. This patch moves the responsibility of dictating which
font features should be enabled entirely to the Font. Therefore, getCFStringAttributes()
doesn't know anything about ligatures anymore; the logic inside font creation is used
instead.
An added benefit of moving all the font feature logic to one place is that we can implement
the feature resolution algorithm described in the CSS3 fonts spec. This patch adds a test to
makes sure that text-rendering, font-feature-settings, and font-variant-* play together
nicely.
Test: fast/text/multiple-feature-properties.html
- platform/graphics/Font.cpp:
(WebCore::Font::applyTransforms):
- platform/graphics/Font.h:
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::FontCascade):
(WebCore::FontCascade::operator=):
(WebCore::FontCascade::update):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::width):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::FontCascade::offsetForPosition):
(WebCore::FontCascade::codePath):
(WebCore::FontCascade::floatWidthForSimpleText):
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::requiresShaping):
(WebCore::FontCascade::computeRequiresShaping):
(WebCore::FontCascade::enableLigatures): Deleted.
(WebCore::FontCascade::computeEnableLigatures): Deleted.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::applyFontTransforms):
- platform/graphics/WidthIterator.h:
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::canRenderCombiningCharacterSequence):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::Font::getCFStringAttributes):
- svg/SVGFontData.h:
LayoutTests:
- fast/text/multiple-feature-properties-expected.html: Added.
- fast/text/multiple-feature-properties.html: Added.
- 9:22 PM Changeset in webkit [191330] by
-
- 5 edits in trunk/Source/WebCore
Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150306
Reviewed by Simon Fraser.
When getting the ImageInterpolationQuality, there is no need to round-trip through
the platform's graphics context. This patch migrates this piece of state to the
existing idiom of having a setter in GraphicsContext.cpp which sets the relevent
state in GraphicsContextState and then calls into a platform-specific setter.
No new tests because there is no behavior change.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setImageInterpolationQuality):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::imageInterpolationQuality):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::convertInterpolationQuality):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.
- 8:39 PM Changeset in webkit [191329] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 8:37 PM Changeset in webkit [191328] by
-
- 1 copy in tags/Safari-601.3.5
New Tag.
- 8:29 PM Changeset in webkit [191327] by
-
- 18 edits in trunk/Source/WebCore
Drop unnecessary Node::toInputElement() virtual function
https://bugs.webkit.org/show_bug.cgi?id=150341
Reviewed by Darin Adler.
Drop unnecessary Node::toInputElement() virtual function and use the
usual is<HTMLInputElement>() / downcast< HTMLInputElement >() instead.
- 7:43 PM Changeset in webkit [191326] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r191324.
https://bugs.webkit.org/show_bug.cgi?id=150352
Shadowing CTM's state is not necessary (Requested by litherum
on #webkit).
Reverted changeset:
"Host GraphicsContext's CTM inside GraphicsContextState"
https://bugs.webkit.org/show_bug.cgi?id=150146
http://trac.webkit.org/changeset/191324
- 7:23 PM Changeset in webkit [191325] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to the committers list.
- Scripts/webkitpy/common/config/contributors.json:
- 5:36 PM Changeset in webkit [191324] by
-
- 12 edits in trunk/Source/WebCore
Host GraphicsContext's CTM inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150146
There are 6 operations which interact with CTMs:
- Get
- Set
- Concatenate
- Scale
- Rotate
- Translate
This patch modifies all these operations so that these operations shadow the
platform's CTM inside GraphicsContextState. This way, we don't have to consult
with the underlying graphics context in order to know the current CTM.
There are currently many places in the Core Graphics ports where we will change
the platform's CTM out from under the GraphicsContext. This patch migrates
those users to going through GraphicsContext, thereby preserving the integrity
of the shadowed state.
No new tests because there is no behavior change.
- platform/graphics/GraphicsContext.cpp: Setters deletate to platform calls.
The getter can just consult with the shadowed state.
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::checkCTMInvariants): Make sure the shadowed state
matches the platform graphics context's state.
- platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
- platform/graphics/cairo/GraphicsContextCairo.cpp: Renaming functions.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::getCTM): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::scale): Deleted.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
Renaming functions.
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp: Renaming functions. Also,
migrate CTM setters to go through GraphicsContext.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::scale): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::getCTM): Deleted.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
- platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::isEssentiallyEqualTo): Equality comparison on floats
is not a good idea. Instead, this function is more valuable. (However, note that
it is expected for values in a CTM to hold values close to 0, which means that
this function might erroneously return false (similar to operator=()).
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
- platform/mac/DragImageMac.mm:
(WebCore::drawAtPoint):
- platform/spi/cg/CoreGraphicsSPI.h:
- 5:17 PM Changeset in webkit [191323] by
-
- 24 edits in trunk/Source
Remove unused support for long presses from WebKit
https://bugs.webkit.org/show_bug.cgi?id=150345
Reviewed by Beth Dakin.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/APIUIClient.h:
(API::UIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(API::UIClient::didRecognizeLongMousePress): Deleted.
(API::UIClient::didCancelTrackingPotentialLongMousePress): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient): Deleted.
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetLongMousePressEnabled):
(WKPreferencesSetLongMousePressEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::WebPageProxy::didRecognizeLongMousePress): Deleted.
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(API::InjectedBundle::PageUIClient::didRecognizeLongMousePress): Deleted.
(API::InjectedBundle::PageUIClient::didCancelTrackingPotentialLongMousePress): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::InjectedBundlePageUIClient::didRecognizeLongMousePress): Deleted.
(WebKit::InjectedBundlePageUIClient::didCancelTrackingPotentialLongMousePress): Deleted.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::WebChromeClient::didRecognizeLongMousePress): Deleted.
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Deleted.
- page/Chrome.cpp:
(WebCore::Chrome::didBeginTrackingPotentialLongMousePress): Deleted.
(WebCore::Chrome::didRecognizeLongMousePress): Deleted.
(WebCore::Chrome::didCancelTrackingPotentialLongMousePress): Deleted.
- page/Chrome.h:
- page/ChromeClient.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Deleted.
(WebCore::EventHandler::clear): Deleted.
(WebCore::EventHandler::handleMousePressEvent): Deleted.
(WebCore::EventHandler::eventMayStartDrag): Deleted.
(WebCore::EventHandler::handleMouseReleaseEvent): Deleted.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Deleted.
(WebCore::EventHandler::recognizeLongMousePress): Deleted.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Deleted.
(WebCore::EventHandler::clearLongMousePressState): Deleted.
(WebCore::EventHandler::handleLongMousePressMouseMovedEvent): Deleted.
(WebCore::EventHandler::handleMouseMoveEvent): Deleted.
(WebCore::EventHandler::handleDrag): Deleted.
- page/EventHandler.h:
- page/Settings.in:
- 5:05 PM Changeset in webkit [191322] by
-
- 2 edits in trunk/LayoutTests
Don't dump GestureEvent constructor attributes for now
Rubber-stamped by Alexey Proskuryakov.
- js/dom/script-tests/global-constructors-attributes.js:
- 5:01 PM Changeset in webkit [191321] by
-
- 2 edits in trunk/Source/WebKit2
Make sure development Safari does not delete the stable Safari cache storage.
https://bugs.webkit.org/show_bug.cgi?id=150343
Reviewed by Antti Koivisto.
Make sure development Safari does not delete the stable Safari disk cache
storage. Development Safari now uses Version 5, while the last stable
Safari uses Version 4. Since the 2 versions can co-exist, it is best not
to drop the old cache version (4) at this point.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):
- 3:32 PM Changeset in webkit [191320] by
-
- 12 edits3 adds in trunk/Source
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Darin Adler.
No new tests, just moving code around.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSWindowSPI.h: Added.
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/Cocoa/WebViewImpl.h: Added.
- UIProcess/Cocoa/WebViewImpl.mm: Added.
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::setDrawsBackground):
(WebKit::WebViewImpl::drawsBackground):
(WebKit::WebViewImpl::setDrawsTransparentBackground):
(WebKit::WebViewImpl::drawsTransparentBackground):
(WebKit::WebViewImpl::acceptsFirstResponder):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused):
(WebKit::WebViewImpl::viewWillStartLiveResize):
(WebKit::WebViewImpl::viewDidEndLiveResize):
(WebKit::WebViewImpl::setFrameSize):
(WebKit::WebViewImpl::disableFrameSizeUpdates):
(WebKit::WebViewImpl::enableFrameSizeUpdates):
(WebKit::WebViewImpl::frameSizeUpdatesDisabled):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setDrawingAreaSize):
(WebKit::WebViewImpl::setContentPreparationRect):
(WebKit::WebViewImpl::updateViewExposedRect):
(WebKit::WebViewImpl::setClipsToVisibleRect):
(WebKit::WebViewImpl::setIntrinsicContentSize):
(WebKit::WebViewImpl::intrinsicContentSize):
(WebKit::WebViewImpl::setViewScale):
(WebKit::WebViewImpl::viewScale):
(WebKit::WebViewImpl::layoutMode):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::supportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSecureInputState):
(WebKit::WebViewImpl::resetSecureInputState):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::hasFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::closeFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenPlaceholderView):
(WebKit::WebViewImpl::createFullScreenWindow):
Move the actual implementation of a number of WKView methods into a
C++ class, WebViewImpl, which WKView calls directly into.
Eventually, we will move all of the logic of WKView into WebViewImpl,
and then duplicate the necessary forwarding in WKWebView and remove
WKWebView's inner WKView.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::updateSecureInputState):
(WebKit::PageClientImpl::resetSecureInputState):
(WebKit::PageClientImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
For now, forward PageClient requests that can be answered by WebViewImpl
to WebViewImpl. Eventually, we'll probably fold PageClientImpl and WebViewImpl
together into one class, and these things will collapse down.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController initWithWindow:webView:]): Deleted.
(-[WKFullScreenWindowController _page]): Deleted.
- UIProcess/mac/WKViewLayoutStrategy.h:
- UIProcess/mac/WKViewLayoutStrategy.mm:
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy invalidate]):
(-[WKViewLayoutStrategy didChangeFrameSize]):
(-[WKViewViewSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy updateLayout]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy didChangeFrameSize]):
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy willDestroyView:]): Deleted.
(-[WKViewViewSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
Make WKViewLayoutStrategy and WKFullScreenWindowController operate in terms of generic
NSViews instead of WKView, so that eventually they will be able to work for either
WKView or WKWebView, and so that they can sit underneath WebViewImpl.
- WebKit2.xcodeproj/project.pbxproj:
- 3:20 PM Changeset in webkit [191319] by
-
- 2 edits in trunk/Source/WebCore
Restore an assertion to the way it was before r191310, which was correct.
- platform/graphics/GraphicsTypes.cpp:
(WebCore::compositeOperatorName):
- 2:39 PM Changeset in webkit [191318] by
-
- 5 edits in trunk/Source
Build fix.
Source/WebCore:
- dom/EventNames.in:
- dom/make_event_factory.pl:
(generateImplementation):
Source/WTF:
- wtf/FeatureDefines.h:
- 2:25 PM Changeset in webkit [191317] by
-
- 3 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r190437. rdar://problem/23166302
- 2:21 PM Changeset in webkit [191316] by
-
- 3 edits in trunk/Source/WebCore
Fix the binding generator after r191176
https://bugs.webkit.org/show_bug.cgi?id=150320
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):
- 1:39 PM Changeset in webkit [191315] by
-
- 12 edits3 deletes in trunk/Source
Unreviewed, rolling out r191307.
https://bugs.webkit.org/show_bug.cgi?id=150338
broke lots of API tests, need time to figure out whats up
(Requested by thorton on #webkit).
Reverted changeset:
"WKView being inside WKWebView leads to weird API issues"
https://bugs.webkit.org/show_bug.cgi?id=150174
http://trac.webkit.org/changeset/191307
- 1:32 PM Changeset in webkit [191314] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r191295, r191297, and r191301.
https://bugs.webkit.org/show_bug.cgi?id=150337
ASSERTs in 5 tests (Requested by litherum on #webkit).
Reverted changesets:
"Host GraphicsContext's CTM inside GraphicsContextState"
https://bugs.webkit.org/show_bug.cgi?id=150146
http://trac.webkit.org/changeset/191295
"[iOS] Build fix after r191295"
http://trac.webkit.org/changeset/191297
"Unreviewed build fix after r191295."
http://trac.webkit.org/changeset/191301
- 1:29 PM Changeset in webkit [191313] by
-
- 12 edits in trunk/Source/JavaScriptCore
FTL should generate a unique OSR exit for each duplicated OSR exit stackmap intrinsic.
https://bugs.webkit.org/show_bug.cgi?id=149970
Reviewed by Filip Pizlo.
When we lower DFG to LLVM, we generate a stackmap intrnsic for OSR
exits. We also recorded the OSR exit inside FTL::JITCode during lowering.
This stackmap intrinsic may be duplicated or even removed by LLVM.
When the stackmap intrinsic is duplicated, we used to generate just
a single OSR exit data structure. Then, when we compiled an OSR exit, we
would look for the first record in the record list that had the same stackmap ID
as what the OSR exit data structure had. We did this even when the OSR exit
stackmap intrinsic was duplicated. This would lead us to grab the wrong FTL::StackMaps::Record.
Now, each OSR exit knows exactly which FTL::StackMaps::Record it corresponds to.
We accomplish this by having an OSRExitDescriptor that is recorded during
lowering. Each descriptor may be referenced my zero, one, or more OSRExits.
Now, no more than one stackmap intrinsic corresponds to the same index inside
JITCode's OSRExit Vector. Also, each OSRExit jump now jumps to a code location.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::validateReferences):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIsUndefined):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::DFG::LowerDFGToLLVM::callStackmap):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::validateReferences): Deleted.
- ftl/FTLOSRExit.h:
(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::computeRecordMap):
- ftl/FTLStackMaps.h:
- 1:18 PM Changeset in webkit [191312] by
-
- 9 edits6 moves1 add in trunk/Source
Unify handling of JavaScriptCore scripts that are used in WebCore
https://bugs.webkit.org/show_bug.cgi?id=150245
Reviewed by Alex Christensen.
Source/JavaScriptCore:
Move all standalone JavaScriptCore scripts that are used by WebCore into the
JavaScriptCore/Scripts directory. Use JavaScriptCore_SCRIPTS_DIR to refer
to the path for these scripts.
- DerivedSources.make:
Define and use JavaScriptCore_SCRIPTS_DIR.
- JavaScriptCore.xcodeproj/project.pbxproj:
Make a new group in the Xcode project and clean up references.
- PlatformWin.cmake:
For Windows, copy these scripts over to ForwardingHeaders/Scripts since they
cannot be used directly from JAVASCRIPTCORE_DIR in AppleWin builds. Do the same
thing for both Windows variants to be consistent about it.
- Scripts/cssmin.py: Renamed from Source/JavaScriptCore/inspector/scripts/cssmin.py.
- Scripts/generate-combined-inspector-json.py: Renamed from Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py.
- Scripts/generate-js-builtins: Renamed from Source/JavaScriptCore/generate-js-builtins.
- Scripts/inline-and-minify-stylesheets-and-scripts.py: Renamed from Source/JavaScriptCore/inspector/scripts/inline-and-minify-stylesheets-and-scripts.py.
- Scripts/jsmin.py: Renamed from Source/JavaScriptCore/inspector/scripts/jsmin.py.
- Scripts/xxd.pl: Renamed from Source/JavaScriptCore/inspector/scripts/xxd.pl.
Source/WebCore:
Use the new JavaScriptCore_SCRIPTS_DIR variable.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
No need to export other variables like InspectorScripts anymore.
- 1:07 PM Changeset in webkit [191311] by
-
- 2 edits in trunk/Source/WebKit2
Try again to fix the 32-bit build.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
- 1:07 PM Changeset in webkit [191310] by
-
- 12 edits2 adds in trunk/Source/WebCore
Add TextStream formatters for FillLayer and all it entails
https://bugs.webkit.org/show_bug.cgi?id=150312
Reviewed by Tim Horton.
Add TextStream output formatters for FillLayer, and all the enum
types used by it.
Drive-by fixes for CompositeOperator and BlendMode string conversions.
compositeOperatorNames was missing the "difference" string, and compositeOperatorName()
would do an OOB memory access if blendOp was zero.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/Length.cpp:
(WebCore::operator<<):
- platform/Length.h:
- platform/LengthSize.cpp: Added.
(WebCore::operator<<):
- platform/LengthSize.h:
- platform/text/TextStream.h:
- rendering/style/FillLayer.cpp:
(WebCore::operator<<):
- rendering/style/FillLayer.h:
- rendering/style/RenderStyleConstants.cpp: Added.
(WebCore::operator<<):
- rendering/style/RenderStyleConstants.h:
- 12:53 PM Changeset in webkit [191309] by
-
- 17 edits in trunk/Source/WebKit2
Extend fast-clicking behavior to trigger on elements that have negligible zoom
https://bugs.webkit.org/show_bug.cgi?id=150248
<rdar://problem/23140069>
Reviewed by Simon Fraser.
Currently, fast-clicking only triggers on pages that have unscalable viewports. To allow more websites to benefit from fast-clicking
behavior, we generalize fast-clicking to also occur when tapping on elements for which double-tap-to-zoom would zoom the element in
or out by an insignificant amount. We define an insignificant amount of zoom to mean that zooming would increase the viewport scale
by less than a configurable threshold, or decrease the viewport scale by more than a configurable threshold. We accomplish this by
temporarily disabling the double tap gesture recognizer for the duration of the tap. This patch refactors some logic used to compute
zoomed viewports to make it possible to predict the change in viewport scale when double tapping to zoom. See the changes in
SmartMagnificationController and ViewGestureGeometryCollector for more details.
There are no new tests, since this patch does not change existing behavior. Instead, this patch adds the machinery needed for zoom-
dependent fast-clicking: by setting the preferences WebKitFastClickingEnabled and WebKitFastClickZoomThreshold, we will be able to tweak
the behavior dynamically.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _contentZoomScale]):
(-[WKWebView _targetContentZoomScaleForRect:currentScale:fitEntireRect:minimumScale:maximumScale:]):
(-[WKWebView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKWebView _viewportIsUserScalable]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary):
- UIProcess/ios/SmartMagnificationController.h:
- UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::adjustSmartMagnificationTargetRectAndZoomScales):
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
(WebKit::SmartMagnificationController::magnify):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _fastClickZoomThreshold]):
(-[WKContentView _allowDoubleTapToZoomForCurrentZoomScale:andTargetZoomScale:]):
(-[WKContentView _disableDoubleTapGesturesUntilTapIsFinishedIfNecessary:allowsDoubleTapZoom:targetRect:isReplaced:minimumScale:maximumScale:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _singleTapRecognized:]):
(cancelPotentialTapIfNecessary):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView webSelectionRects]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary):
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::computeZoomInformationForNode):
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition):
- 12:37 PM Changeset in webkit [191308] by
-
- 2 edits in trunk/Tools
Add new EWS queues to bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=150297
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
- 12:23 PM Changeset in webkit [191307] by
-
- 12 edits3 adds in trunk/Source
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Darin Adler.
No new tests, just moving code around.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSWindowSPI.h: Added.
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/Cocoa/WebViewImpl.h: Added.
- UIProcess/Cocoa/WebViewImpl.mm: Added.
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::setDrawsBackground):
(WebKit::WebViewImpl::drawsBackground):
(WebKit::WebViewImpl::setDrawsTransparentBackground):
(WebKit::WebViewImpl::drawsTransparentBackground):
(WebKit::WebViewImpl::acceptsFirstResponder):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused):
(WebKit::WebViewImpl::viewWillStartLiveResize):
(WebKit::WebViewImpl::viewDidEndLiveResize):
(WebKit::WebViewImpl::setFrameSize):
(WebKit::WebViewImpl::disableFrameSizeUpdates):
(WebKit::WebViewImpl::enableFrameSizeUpdates):
(WebKit::WebViewImpl::frameSizeUpdatesDisabled):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setDrawingAreaSize):
(WebKit::WebViewImpl::setContentPreparationRect):
(WebKit::WebViewImpl::updateViewExposedRect):
(WebKit::WebViewImpl::setClipsToVisibleRect):
(WebKit::WebViewImpl::setIntrinsicContentSize):
(WebKit::WebViewImpl::intrinsicContentSize):
(WebKit::WebViewImpl::setViewScale):
(WebKit::WebViewImpl::viewScale):
(WebKit::WebViewImpl::layoutMode):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::supportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSecureInputState):
(WebKit::WebViewImpl::resetSecureInputState):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::hasFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::closeFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenPlaceholderView):
(WebKit::WebViewImpl::createFullScreenWindow):
Move the actual implementation of a number of WKView methods into a
C++ class, WebViewImpl, which WKView calls directly into.
Eventually, we will move all of the logic of WKView into WebViewImpl,
and then duplicate the necessary forwarding in WKWebView and remove
WKWebView's inner WKView.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::updateSecureInputState):
(WebKit::PageClientImpl::resetSecureInputState):
(WebKit::PageClientImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
For now, forward PageClient requests that can be answered by WebViewImpl
to WebViewImpl. Eventually, we'll probably fold PageClientImpl and WebViewImpl
together into one class, and these things will collapse down.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController initWithWindow:webView:]): Deleted.
(-[WKFullScreenWindowController _page]): Deleted.
- UIProcess/mac/WKViewLayoutStrategy.h:
- UIProcess/mac/WKViewLayoutStrategy.mm:
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy invalidate]):
(-[WKViewLayoutStrategy didChangeFrameSize]):
(-[WKViewViewSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy updateLayout]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy didChangeFrameSize]):
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy willDestroyView:]): Deleted.
(-[WKViewViewSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:mode:]): Deleted.
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:mode:]): Deleted.
Make WKViewLayoutStrategy and WKFullScreenWindowController operate in terms of generic
NSViews instead of WKView, so that eventually they will be able to work for either
WKView or WKWebView, and so that they can sit underneath WebViewImpl.
- WebKit2.xcodeproj/project.pbxproj:
- 12:21 PM Changeset in webkit [191306] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
https://bugs.webkit.org/show_bug.cgi?id=150221
<rdar://problem/23149771>
Reviewed by Darin Adler and Antti Koivisto.
Generalize NetworkCacheStorage API so it can store different types of
metadata alongside the network resources. This is a pre-requirement to
making our NetworkCache smarter by storing information about the
resources.
To keep the code simple, the entry type is now part of the entry key and
we store records of a specific type in a 'type' subfolder. The cache
structure looks like so:
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)
Existing cache entries now that the 'resource' type as these are network
resources.
- NetworkProcess/cache/NetworkCache.cpp:
- NetworkProcess/cache/NetworkCacheKey.cpp:
- NetworkProcess/cache/NetworkCacheKey.h:
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
- NetworkProcess/cache/NetworkCacheStorage.h:
- 12:19 PM Changeset in webkit [191305] by
-
- 8 edits in trunk/Source
Try to fix the iOS build
- Configurations/FeatureDefines.xcconfig:
- 12:11 PM Changeset in webkit [191304] by
-
- 2 edits in trunk/LayoutTests
Rebaselining fast/dynamic/insert-before-table-part-in-continuation.html for win
https://bugs.webkit.org/show_bug.cgi?id=150126
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-19
Reviewed by Zalan Bujtas.
- platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- 12:09 PM Changeset in webkit [191303] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the 32-bit build.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
- 11:59 AM Changeset in webkit [191302] by
-
- 3 edits in trunk/Source/WebKit2
Fix image service menus somewhat
https://bugs.webkit.org/show_bug.cgi?id=150265
Reviewed by Tim Horton.
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
It's a service menu if we have a controlled image.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Use an item provider.
- 11:50 AM Changeset in webkit [191301] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r191295.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::clipOut):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::syncContext):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
- 11:32 AM Changeset in webkit [191300] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add regression tests for TypedArray.prototype functions' error messages.
https://bugs.webkit.org/show_bug.cgi?id=150288
Reviewed by Darin Adler.
Fix a typo in the text passed by TypedArrray.prototype.filter type error message.
Add tests that check the actual error message text for all the TypeArray.prototype
functions that throw.
- builtins/TypedArray.prototype.js:
(filter):
- tests/stress/typedarray-every.js:
- tests/stress/typedarray-filter.js:
- tests/stress/typedarray-find.js:
- tests/stress/typedarray-findIndex.js:
- tests/stress/typedarray-forEach.js:
- tests/stress/typedarray-map.js:
- tests/stress/typedarray-reduce.js:
- tests/stress/typedarray-reduceRight.js:
- tests/stress/typedarray-some.js:
- 11:10 AM Changeset in webkit [191299] by
-
- 37 edits6 adds in trunk/Source
Add magnify and rotate gesture event support for Mac
https://bugs.webkit.org/show_bug.cgi?id=150179
<rdar://problem/8036240>
Reviewed by Darin Adler.
No new tests.
- Configurations/FeatureDefines.xcconfig:
New feature flag.
- Configurations/WebCore.xcconfig:
Don't exclude generated gesture sources; they are already #ifdef-guarded.
- DerivedSources.make:
Add GestureEvent.idl for ENABLE_MAC_GESTURE_EVENTS too.
- WebCore.xcodeproj/project.pbxproj:
Add GestureEvents.cpp.
- bindings/objc/DOMEvents.mm:
(kitClass):
Support DOMGestureEvent on Mac if the new flag is enabled.
- dom/mac/GestureEvents.cpp: Added.
- page/mac/EventHandlerMac.mm:
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
- page/EventHandler.h:
Enable some gesture-related code on Mac if the new flag is enabled.
- platform/PlatformEvent.h:
- Configurations/FeatureDefines.xcconfig:
New feature flag.
- Shared/NativeWebGestureEvent.h: Added.
(WebKit::NativeWebGestureEvent::nativeEvent):
- Shared/WebEvent.h:
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):
- Shared/WebEventConversion.h:
- Shared/mac/NativeWebGestureEventMac.mm: Added.
(WebKit::webEventTypeForNSEvent):
(WebKit::pointForEvent):
(WebKit::NativeWebGestureEvent::NativeWebGestureEvent):
Add and plumb a new native event that wraps a NSEvent of type
NSEventTypeMagnify or NSEventTypeRotate (gesture events).
- Shared/mac/WebGestureEvent.cpp: Added.
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):
- Shared/mac/WebGestureEvent.h: Added.
(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::gestureScale):
(WebKit::WebGestureEvent::gestureRotation):
Add IPC plumbing for WebGestureEvent, which becomes a WebCore::PlatformGestureEvent.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Remove unnecessary iPhone-only WKView code.
Add _gestureEventWasNotHandledByWebCore, SPI which can be overridden
to react when WebCore decides not to handle a gesture event.
- UIProcess/API/mac/WKView.mm:
(-[WKView magnifyWithEvent:]):
Route magnification gesture events to the page, unless we're already
in an active view zoom gesture, in which case we'll bypass the page
and send the event straight to ViewGestureController.
(-[WKView rotateWithEvent:]):
Route rotation gesture events to the page.
(-[WKView _gestureEventWasNotHandledByWebCore:]):
Let ViewGestureController know that WebCore didn't handle a gesture event.
We always give WebCore the first crack at the event if we're not in a zoom,
because it could preventDefault() on the Begin phase event, and that should
prevent pinch-zoom from starting.
- UIProcess/PageClient.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::gestureEventWasNotHandledByWebCore):
Plumb gestureEventWasNotHandledByWebCore back from WebPageProxy to WKView.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):
- UIProcess/WebPageProxy.h:
Forward gesture events to EventDispatcher, and let WKView know when WebCore
passes on handling them.
- UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::hasActiveMagnificationGesture):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::gestureEventWasNotHandledByWebCore):
(WebKit::ViewGestureController::handleMagnificationGestureEvent):
Don't try to start a zoom with anything other than a Begin phase event.
Try to start a zoom with any events that WebCore doesn't handle.
Move dispatch of endMagnificationGesture into ViewGestureController;
there is no reason for that to be in WKView anymore.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::dispatchGestureEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):
- WebProcess/WebPage/WebPage.h:
Dispatch to the main thread and hand off the gesture event to WebCore,
asynchronously informing the UI process of whether the event was handled or not.
- Configurations/FeatureDefines.xcconfig:
New feature flag.
- Configurations/FeatureDefines.xcconfig:
New feature flag.
- 11:01 AM Changeset in webkit [191298] by
-
- 2 edits in trunk/Tools
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580
Reviewed by Carlos Garcia Campos.
The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
So we do not need to skip them anymore.
- Scripts/run-gtk-tests:
(TestRunner): Deleted.
- 10:58 AM Changeset in webkit [191297] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix after r191295
Unreviewed.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::resetPlatformCTM):
- 10:54 AM Changeset in webkit [191296] by
-
- 2 edits in trunk/LayoutTests
Removing Yosemite-only flag for flaky test http/tests/media/video-query-url.html
https://bugs.webkit.org/show_bug.cgi?id=141085
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-19
Reviewed by Alexey Proskuryakov.
- platform/mac-wk2/TestExpectations:
- 10:28 AM Changeset in webkit [191295] by
-
- 11 edits in trunk/Source/WebCore
Host GraphicsContext's CTM inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150146
Reviewed by Simon Fraser.
There are 6 operations which interact with CTMs:
- Get
- Set
- Concatenate
- Scale
- Rotate
- Translate
This patch modifies all these operations so that these operations shadow the
platform's CTM inside GraphicsContextState. This way, we don't have to consult
with the underlying graphics context in order to know the current CTM.
There are currently many places in the Core Graphics ports where we will change
the platform's CTM out from under the GraphicsContext. This patch migrates
those users to going through GraphicsContext, thereby preserving the integrity
of the shadowed state.
No new tests because there is no behavior change.
- platform/graphics/GraphicsContext.cpp: Setters deletate to platform calls.
The getter can just consult with the shadowed state.
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::checkCTMInvariants): Make sure the shadowed state
matches the platform graphics context's state.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Renaming functions.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::getCTM): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::scale): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp: Renaming functions. Also,
migrate CTM setters to go through GraphicsContext.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::drawPatternCallback):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::scale): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::getCTM): Deleted.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::rotate):
(WebCore::GraphicsContextPlatformPrivate::translate):
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
(WebCore::GraphicsContextPlatformPrivate::setCTM):
- platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::isEssentiallyEqualTo): Equality comparison on floats
is not a good idea. Instead, this function is more valuable. (However, note that
it is expected for values in a CTM to hold values close to 0, which means that
this function might erroneously return false (similar to operator=()).
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
- platform/mac/DragImageMac.mm:
(WebCore::drawAtPoint):
- 9:52 AM Changeset in webkit [191294] by
-
- 5 edits in trunk
Null dereference loading Blink layout test fast/forms/color/input-color-onchange-event.html
https://bugs.webkit.org/show_bug.cgi?id=150192
<rdar://problem/23135050>
Reviewed by Darin Adler.
Source/WebCore:
Calling internals.selectColorInColorChooser() with a non-Element would
cause a null dereference. This is because in such case, the implementation
method is passed a null pointer and we would fail to null-check it. This
patch now does the null-check.
No new tests, existing test was updated.
- testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):
LayoutTests:
Import more checks from the corresponding Blink test.
- fast/forms/color/input-color-onchange-event-expected.txt:
- fast/forms/color/input-color-onchange-event.html:
- 9:36 AM Changeset in webkit [191293] by
-
- 3 edits in trunk/LayoutTests
[Streams API] Update readable-stream-reader tests to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149699
Reviewed by Darin Adler.
- streams/reference-implementation/readable-stream-reader-expected.txt: Updated expectations.
- streams/reference-implementation/readable-stream-reader.html: Updated tests.
- 9:34 AM Changeset in webkit [191292] by
-
- 2 edits in trunk/LayoutTests
[Streams API] Update readable-stream-controller-error tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149700
Reviewed by Darin Adler.
- streams/readable-stream-controller-error.html: Updated tests.
- 9:20 AM Changeset in webkit [191291] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix the ENABLE(WEBASSEMBLY) build after r190827
https://bugs.webkit.org/show_bug.cgi?id=150330
Reviewed by Geoffrey Garen.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Removed the duplicated VM argument.
- bytecode/CodeBlock.h:
(JSC::WebAssemblyCodeBlock::create): Added new parameters to finishCreation() calls.
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): Change VM parameter to pointer to match *CodeBlock classes.
- runtime/Executable.cpp:
(JSC::WebAssemblyExecutable::prepareForExecution): Removed extra ")" and pass pointer as it is expected.
- 9:13 AM Changeset in webkit [191290] by
-
- 3 edits in trunk/Source/JavaScriptCore
DoubleRep fails to convert SpecBoolean values.
https://bugs.webkit.org/show_bug.cgi?id=150313
Reviewed by Geoffrey Garen.
This was uncovered by the op_sub stress test on 32-bit builds. On 32-bit builds,
DoubleRep will erroneously convert 'true' to a 'NaN' instead of a double 1.
On 64-bit, the same issue exists but is masked by another bug in DoubleRep where
boolean values will always erroneously trigger a BadType OSR exit.
The erroneous conversion of 'true' to 'NaN' is because the 'true' case in
compileDoubleRep() is missing a jump to the "done" destination. Instead, it
fall through to the "isUndefined" case where it produces a NaN.
The 64-bit erroneous BadType OSR exit is due to the boolean type check being
implemented incorrectly. It was checking if any bits other than bit 0 were set.
However, boolean JS values always have TagBitBool (the 3rd bit) set. Hence, the
check will always fail if we have a boolean value.
This patch fixes both of these issues.
No new test is needed because these issues are already covered by scenarios in
the op_sub.js stress test. This patch also fixes the op_sub.js test to throw an
exception if any failures are encountered (as expected by the stress test
harness). This patch also re-worked the test code to provide more accurate
descriptions of each test scenario for error reporting.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileDoubleRep):
- tests/stress/op_sub.js:
(generateScenarios):
(func):
(initializeTestCases):
(runTest):
(stringify): Deleted.
- 9:10 AM Changeset in webkit [191289] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840
https://bugs.webkit.org/show_bug.cgi?id=150322
Reviewed by Ryosuke Niwa.
- html/HTMLDetailsElement.cpp:
- 3:45 AM Changeset in webkit [191288] by
-
- 6 edits in trunk/Source/WebCore
Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value
https://bugs.webkit.org/show_bug.cgi?id=150163
Reviewed by Darin Adler.
Covered by updated binding tests.
Updating generation of JS built-in function/attribute name to use the ImplementedBy value of the interface if any.
This allows splitting JS built-ins just like is done for IDLs.
Updated accordingly the JS Builtin header include.
- bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Updated to pass function object and not only function name.
(GetAttributeSetterName): Ditto.
(GetFunctionName): Removed unneeded code plus updated to pass function object and not only function name.
(GenerateConstructorHelperMethods): Making direct use of GetJSBuiltinFunctionNameFromString since there is no function object for the constructor.
(GetJSBuiltinFunctionName): Updated to take into accound ImplementedBy value if any.
(GetJSBuiltinFunctionNameFromString):
(GetJSBuiltinScopeName): Returns either the interface name or its ImplementedBy value.
(AddJSBuiltinIncludesIfNeeded): Updating name of the header in case of partial interface.
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface builtinAttribute]):
(-[DOMTestInterface setBuiltinAttribute:]):
(-[DOMTestInterface builtinFunction]):
- bindings/scripts/test/TestSupplemental.idl: Added JSBuiltin attribute and function.
- 3:36 AM Changeset in webkit [191287] by
-
- 14 edits1 add in trunk/Source/WebCore
Binding generator should allow generating private JS functions
https://bugs.webkit.org/show_bug.cgi?id=150167
Reviewed by Darin Adler.
Introducing the "Private" keyword for that purpose.
Applying it to MediaDevices.getUserMedia which can be used directly or through navigator.webkitGetUserMedia
which could be implemented as JS builtin based on it.
"Private" functions are added to the prototype with a corresponding private symbol.
This symbol must be defined in bindings/js/WebCoreBuiltinNames.h.
Adding a getUserMediaFromJS function visible from builtins script.
Implementing MediaDevices.getUserMedia as a JS builtin based on it.
Adding binding generator test.
- CMakeLists.txt: Adding MediaDevices.js.
- DerivedSources.make: Ditto.
- Modules/mediastream/MediaDevices.h:
(WebCore::MediaDevices::getUserMediaFromJS):
- Modules/mediastream/MediaDevices.idl: Marking getUserMediaFromJS private and getUserMedia JSBuiltin.
- Modules/mediastream/MediaDevices.js: Added.
(getUserMedia):
- bindings/js/WebCoreBuiltinNames.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::mediaDevicesBuiltins):
- bindings/scripts/CodeGeneratorGObject.pm: Skipping generation of Private functions.
(SkipFunction):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Disabling addition of private function in table and adding private member field to the prototype.
- bindings/scripts/CodeGeneratorObjC.pm: Skipping generation of Private functions.
(SkipFunction):
- bindings/scripts/IDLAttributes.txt: Adding Private keyword.
- bindings/scripts/test/JS/JSTestObj.cpp: Adding Private keyword test.
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionPrivateMethod):
- bindings/scripts/test/TestObj.idl:
- 3:16 AM Changeset in webkit [191286] by
-
- 8 edits in trunk/Source/JavaScriptCore
Drop !newTarget check since it always becomes true
https://bugs.webkit.org/show_bug.cgi?id=150308
Reviewed by Geoffrey Garen.
In a context of calling a constructor,
newTargetshould not become JSEmpty.
So!newTargetalways becomes true. This patch drops this unneccessary check.
And to ensure the implementation of the constructor is only called under
the context of calling it as a constructor, we change these functions to
static and only use them for constructor implementations of InternalFunction.
- runtime/IntlCollatorConstructor.cpp:
(JSC::constructIntlCollator):
(JSC::callIntlCollator):
- runtime/IntlCollatorConstructor.h:
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::constructIntlDateTimeFormat):
(JSC::callIntlDateTimeFormat):
- runtime/IntlDateTimeFormatConstructor.h:
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::constructIntlNumberFormat):
(JSC::callIntlNumberFormat):
- runtime/IntlNumberFormatConstructor.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
- 3:09 AM Changeset in webkit [191285] by
-
- 5 edits in trunk
[Streams API] Implement ReadableStream tee
https://bugs.webkit.org/show_bug.cgi?id=146315
Reviewed by Darin Adler.
Source/WebCore:
Covered by rebased test.
- Modules/streams/ReadableStream.js:
(tee): Removing not implemented exception throwing.
- Modules/streams/ReadableStreamInternals.js:
(teeReadableStream): Implementing as per spec.
(teeReadableStreamPullFunction): Ditto.
(teeReadableStreamBranch2CancelFunction): Ditto.
LayoutTests:
- streams/reference-implementation/readable-stream-tee-expected.txt:
- 2:48 AM Changeset in webkit [191284] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] ASSERTION FAILED: parent in WebInspectorProxy::platformDetach()
https://bugs.webkit.org/show_bug.cgi?id=150319
Reviewed by Žan Doberšek.
This happens when the inspector is shown/closed very
quickly. Since we start the inspector attached by default, when
the web inspector is created m_isAttached is set to true, so that
when opened, it's attached to the view. If the inspector is closed
before it has been actually attached, the inspector view doesn't
have a parent, even if the m_isAttached is true. So, we should
handle this case instead of asserting. This is what happens in
test http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the view from
its parent container if it was actually attached.
- 2:46 AM Changeset in webkit [191283] by
-
- 30 edits2 adds in trunk
[Streams API] Add skeleton for initial WritableStream support
https://bugs.webkit.org/show_bug.cgi?id=149951
Reviewed by Darin Adler.
Source/WebCore:
This basically adds an empty WritableStream object without initializing the object. It also adds all empty
methods by raising an exception.
The reason why the object is not fully initialized is that it requires some other support and some refactorings
to share more code with ReadableStream and we will make in following patches.
Tests are covered by current set and their expectations are properly updated.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
- Modules/streams/WritableStream.idl: Added all methods and attributes.
- Modules/streams/WritableStream.js:
(initializeWritableStream):
(abort):
(close):
(write):
(closed):
(ready):
(state): Added all by throwing an EvalError.
Source/WebInspectorUI:
- UserInterface/Models/NativeFunctionParameters.js: Added support for WritableStream.
LayoutTests:
Changed expectations to accomodate the WritableStream skeleton, including global-constructors-attributes.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- streams/reference-implementation/bad-strategies-expected.txt:
- streams/reference-implementation/bad-underlying-sinks-expected.txt:
- streams/reference-implementation/brand-checks-expected.txt:
- streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
- streams/reference-implementation/count-queuing-strategy-expected.txt:
- streams/reference-implementation/pipe-through-expected.txt:
- streams/reference-implementation/pipe-to-expected.txt:
- streams/reference-implementation/pipe-to-options-expected.txt:
- streams/reference-implementation/readable-stream-templated-expected.txt:
- streams/reference-implementation/writable-stream-abort-expected.txt:
- streams/reference-implementation/writable-stream-expected.txt:
- 2:13 AM Changeset in webkit [191282] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Implement WebContextMenuProxyEfl::showContextMenu after r191194
https://bugs.webkit.org/show_bug.cgi?id=150310
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-19
Reviewed by Gyuyoung Kim.
showContextMenu() doesn't work correctly after r191194 in EFL port.
This patch implements WebContextMenuProxyEfl::showContextMenu.
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
- UIProcess/efl/WebContextMenuProxyEfl.h:
- 1:56 AM Changeset in webkit [191281] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: console list 'input'/'output' markers are not perceivable
https://bugs.webkit.org/show_bug.cgi?id=133045
Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.
Reviewed by Brian Burg.
- UserInterface/Views/LogContentView.css:
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
(.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
(@media reader): Deleted.
- 12:17 AM Changeset in webkit [191280] by
-
- 2 edits in trunk/Tools
Add historical addresses to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=150227
Reviewed by Darin Adler.
- Scripts/webkitpy/common/config/contributors.json:
- 12:08 AM Changeset in webkit [191279] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Simplify unused return warning in WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=150173
Reviewed by Darin Adler.
- UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::attribute):
(WebKit::adoptWK): Deleted.
Oct 18, 2015:
- 11:49 PM Changeset in webkit [191278] by
-
- 2 edits in trunk/Source/WebKit2
Fix the ENABLE(SECCOMP_FILTERS) build after r187030
https://bugs.webkit.org/show_bug.cgi?id=150172
Reviewed by Alexey Proskuryakov.
- Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::reportUnexpectedSyscall):
- 7:26 PM Changeset in webkit [191277] by
-
- 2 edits in trunk/Tools
[Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
https://bugs.webkit.org/show_bug.cgi?id=150307
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-18
Reviewed by Brent Fulgham.
The DLL build rules have been changed to generate "{Name}Lib.DLL",
but these changes have not yet been applied to the Visual Studio builds.
- MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
- 5:51 PM Changeset in webkit [191276] by
-
- 5 edits2 moves2 adds in trunk
Promise constructor should throw when not called with "new"
https://bugs.webkit.org/show_bug.cgi?id=149380
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implement handling new.target in Promise constructor. And
prohibiting Promise constructor call without "new".
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
(JSC::callPromise):
(JSC::JSPromiseConstructor::getCallData):
- tests/es6.yaml:
- tests/stress/promise-cannot-be-called.js: Added.
(shouldBe):
(shouldThrow):
(Deferred):
(super):
LayoutTests:
Fix js/dom/Promise-types.html. Before this change, it calls the Promise constructor without new and
expects it succeeds. And we move it from js/dom to js since we can execute this without DOM support.
- js/Promise-types-expected.txt: Renamed from LayoutTests/js/dom/Promise-types-expected.txt.
- js/Promise-types.html: Added.
- js/script-tests/Promise-types.js: Renamed from LayoutTests/js/dom/Promise-types.html.
(aPromise.new.Promise):
(debug.string_appeared_here.shouldThrow.Promise):
- resources/standalone-pre.js:
(shouldBeDefined):
- 5:36 PM Changeset in webkit [191275] by
-
- 10 edits in trunk/Source/JavaScriptCore
[ES6] Handle asynchronous tests in tests/es6
https://bugs.webkit.org/show_bug.cgi?id=150293
Reviewed by Darin Adler.
Since JSC can handle microtasks, some of ES6 Promise tests can be executed under the JSC shell.
Some of them still fail because it uses setTimeout that invokes macrotasks with explicit delay.
- tests/es6.yaml:
- tests/es6/Promise_Promise.all.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_Promise.all_generic_iterables.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_Promise.race.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_Promise.race_generic_iterables.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_basic_functionality.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_is_subclassable_Promise.all.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_is_subclassable_Promise.race.js:
(test.asyncTestPassed):
(test):
- tests/es6/Promise_is_subclassable_basic_functionality.js:
(test.asyncTestPassed):
(test):
- 5:29 PM Changeset in webkit [191274] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Console Search should update when console is cleared
https://bugs.webkit.org/show_bug.cgi?id=150141
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-18
Reviewed by Brian Burg.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._logCleared):
Reperform the search if there is a search query.
(WebInspector.LogContentView.prototype._filterMessageElements):
Reperform the current search.
- 4:51 PM Changeset in webkit [191273] by
-
- 2 edits in trunk/LayoutTests
Marking fast/canvas/webgl/oes-texture-float-linear.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=149930
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-18
Reviewed by Darin Adler.
- platform/mac/TestExpectations:
- 4:47 PM Changeset in webkit [191272] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remove WebKitContextMenu related missing annotation warnings
https://bugs.webkit.org/show_bug.cgi?id=150299
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-18
Reviewed by Darin Adler.
The warnings occur currently because when executing g-ir-scanner,
it doesn't consider WebKitContextMenu related .cpp files,
but only .h files.
- PlatformGTK.cmake: Add WebKitContextMenu related cpp files.
- 4:47 PM Changeset in webkit [191271] by
-
- 2 edits in trunk/LayoutTests
Marking webarchive/loading/object.html as flaky due to crashes
https://bugs.webkit.org/show_bug.cgi?id=150241
<rdar://problem/21690723>
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-18
Reviewed by Darin Adler.
- platform/mac-wk2/TestExpectations:
- 4:43 PM Changeset in webkit [191270] by
-
- 4 edits in trunk
Script element with an empty for or event attributes should not execute
https://bugs.webkit.org/show_bug.cgi?id=148855
<rdar://problem/22588156>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline existing W3C HTML test now that more checks are passing.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-for-event-expected.txt:
Source/WebCore:
A script element with an empty for or event attributes should not execute
as per:
https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 12)
Our implementation had a bug where it would not correctly differentiate
an empty attribute from a missing one. This patch fixes this.
No new tests, already covered by existing test.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::isScriptForEventSupported):
- 4:42 PM Changeset in webkit [191269] by
-
- 2 edits in trunk/LayoutTests
Marking media/event-queue-crash.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=114177
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-18
Reviewed by Darin Adler.
- platform/mac/TestExpectations:
- 4:41 PM Changeset in webkit [191268] by
-
- 7 edits in trunk
WebKit must support all JavaScript MIME types in HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=148854
<rdar://problem/22588195>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-languages-02-expected.txt:
Source/WebCore:
WebKit did not execute certain EcmaScript MIME types although the HTML
specification says all user agents should support those:
https://html.spec.whatwg.org/multipage/scripting.html#javascript-mime-type
In particular, the following MIME types are now recognized as valid and
executed: "application/x-ecmascript", "text/javascript1.0",
"text/javascript1.4", "text/javascript1.5", "text/x-javascript",
"text/x-ecmascript".
The new behavior is consistent with Firefox.
No new tests, already covered by existing test.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedJavaScriptMIMETypes):
LayoutTests:
Rebaseline several existing layout tests now that we execute
more JS MIME types.
- fast/html/script-allowed-types-languages-expected.txt:
- fast/tokenizer/004-expected.txt:
- 4:39 PM Changeset in webkit [191267] by
-
- 8 edits in trunk/Source
[Win] Fix the Windows builds.
https://bugs.webkit.org/show_bug.cgi?id=150300
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-18
Reviewed by Darin Adler.
Source/JavaScriptCore:
Add missing files to JavaScriptCore.vcxproj.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Source/WebCore:
Add missing files to WebCore.vcxproj.
Add missing #includes to CSSAllInOne.cpp and HTMLElementsAllInOne.cpp.
No new tests, no behavior change.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- css/CSSAllInOne.cpp:
- html/HTMLElementsAllInOne.cpp:
- 4:36 PM Changeset in webkit [191266] by
-
- 2 edits in trunk/Source/WebCore
Fix the builds with ENABLE_CONTENT_EXTENSIONS=OFF.
https://bugs.webkit.org/show_bug.cgi?id=150302
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-18
Reviewed by Darin Adler.
Add missing #if ENABLE(CONTENT_EXTENSIONS).
No new tests, no behavior change.
- page/UserContentController.h:
- 4:29 PM Changeset in webkit [191265] by
-
- 5 edits in trunk/Source/WebCore
[EFL] Fix debug build break since r191198
https://bugs.webkit.org/show_bug.cgi?id=150277
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-18
Reviewed by Darin Adler.
No new tests, no new behaviours.
Use the correct %"PRIu64" for uint64_t,
instead of %llu.
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::fireVersionChangeEvent):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/legacy/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::processPendingOpenCalls):
(WebCore::IDBDatabaseBackend::openConnectionInternal):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::notifyConnectionsOfVersionChange):
- 4:27 PM Changeset in webkit [191264] by
-
- 4 edits in trunk/Source
Fix the builds with ENABLE_INDEX_DATABASE=OFF.
https://bugs.webkit.org/show_bug.cgi?id=150301
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-18
Reviewed by Darin Adler.
Add missing #if ENABLE(INDEXED_DATABASE).
Source/WebCore:
No new tests, no behavior change.
- page/Page.cpp:
Source/WebKit:
- Storage/WebDatabaseProvider.h:
- 4:24 PM Changeset in webkit [191263] by
-
- 3 edits in trunk/Source/WebCore
[Cocoa] [Win] Remove unused code from GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=150304
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing): Deleted.
- 3:15 PM Changeset in webkit [191262] by
-
- 11 edits2 adds in trunk
Computed style should work correctly with slotted elements that have display:none
https://bugs.webkit.org/show_bug.cgi?id=150237
Source/WebCore:
Reviewed by Andreas Kling..
If an element has display:none we don't normally retain or even compute its style (as it is not rendered).
If getComputedStyle is invoked for such element we resolve the style (along with any ancestors) and cache
it separately to rare data. This path needs to work with slotted elements in shadow trees.
This patch also make computedStyle() iterative rather than recursive.
Test: fast/shadow-dom/computed-style-display-none.html
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
Pass in the parent style instead of invoking computedStyle() recursively.
- dom/Document.h:
- dom/Element.cpp:
(WebCore::beforeOrAfterPseudoElement):
(WebCore::Element::existingComputedStyle):
(WebCore::Element::resolveComputedStyle):
Iterative resolve function that uses composed tree iterator.
(WebCore::Element::computedStyle):
Factor into helpers.
- dom/Element.h:
- dom/Node.cpp:
(WebCore::Node::computedStyle):
Use the composed tree iterator.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption):
Call updateValidity() before calling renderer->updateFromElement(). Calling updateFromElement()
may end up in Element::computedStyle() which can asserts if validity is not up to date.
LayoutTests:
Reviewed by Andreas Kling.
- editing/style/apply-style-atomic-expected.txt:
Rebase.
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
We now also compute style of display:none pseudo elements correctly.
This is a progression and matches other browsers.
- fast/shadow-dom/computed-style-display-none-expected.txt: Added.
- fast/shadow-dom/computed-style-display-none.html: Added.
- 10:19 AM Changeset in webkit [191261] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix after r191260
Unreviewed.
- WebView/WebView.mm:
(+[WebView initialize]):
- 9:36 AM Changeset in webkit [191260] by
-
- 10 edits in trunk/Source
Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"
https://bugs.webkit.org/show_bug.cgi?id=150287
Reviewed by Simon Fraser.
Source/WebCore:
This user default is currently on by default. Therefore, by setting the user default,
users can only disable kerning / ligatures (rather than enable it).
There are a few reasons why we should stop honoring it:
- In the brave new world of font-feature-settings and font-variant-ligatures, there
are many different kinds of ligatures which may be enabled at will. The simplistic
statement of "turn on ligatures" no longer has any meaning.
- If a user wants to disable kerning / ligatures, he/she can do it with a user
stylesheet.
- The default isn't able to be tested with DumpRenderTree or WebKitTestRunner.
- I have never heard of anyone actually using this user default.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::setDefaultKerning): Deleted.
(WebCore::FontCascade::setDefaultLigatures): Deleted.
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::advancedTextRenderingMode):
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView initialize]): Deleted.
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Deleted.
(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded): Deleted.
(WebKit::WebProcessPool::platformInitializeWebProcess): Deleted.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Deleted.
- 6:30 AM Changeset in webkit [191259] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Mark css variables tests to pass
with incorrect result. Because the pass is not verified yet.
- platform/efl/TestExpectations:
- 12:58 AM Changeset in webkit [191258] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Implement WebContextMenuProxyGtk::showContextMenu after r191194
https://bugs.webkit.org/show_bug.cgi?id=150276
Reviewed by Carlos Garcia Campos.
After r191194, showContextMenu signature becomes changed, and the implementation
is moved from the generic file to the Mac port. It poses the compile error in GTK port.
This patch implements WebContextMenuProxyGtk::showContextMenu. The logic is the same
to the old one except for dropping SERVICE_CONTROLS support. This is because
SERVICE_CONTROLS is not related to GTK.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::showContextMenu):
- UIProcess/gtk/WebContextMenuProxyGtk.h:
- 12:11 AM Changeset in webkit [191257] by
-
- 2 edits in trunk/LayoutTests
Fix a copy/paste mistake in the previous commit.
- platform/mac-wk2/TestExpectations:
- 12:08 AM Changeset in webkit [191256] by
-
- 2 edits in trunk/LayoutTests
Add one more flaky Blink test to TestExpectations.
- platform/mac-wk2/TestExpectations:
- 12:02 AM Changeset in webkit [191255] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r191250 and r191253.
https://bugs.webkit.org/show_bug.cgi?id=150296
Broke all the tests on Windows (Requested by ap on #webkit).
Reverted changesets:
"Stop honoring the user default
"WebKitKerningAndLigaturesEnabledByDefault""
https://bugs.webkit.org/show_bug.cgi?id=150287
http://trac.webkit.org/changeset/191250
"Build fix after r191250"
http://trac.webkit.org/changeset/191253
Oct 17, 2015:
- 5:25 PM Changeset in webkit [191254] by
-
- 2 edits in trunk/Source/WTF
Add CPU(X86) to the supported MASM_PROBE CPUs. This was accidentally left out in r191197.
Not reviewed.
- wtf/Platform.h:
- 5:00 PM Changeset in webkit [191253] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix after r191250
Unreviewed.
- WebView/WebView.mm:
(+[WebView initialize]):
- 4:13 PM Changeset in webkit [191252] by
-
- 15 edits16 adds in trunk
Implement the CSS4 'revert' keyword.
https://bugs.webkit.org/show_bug.cgi?id=149702
Reviewed by Simon Fraser.
Source/WebCore:
Added new tests in fast/css and fast/css/variables.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
Add CSSRevertValue to the project and makefiles.
- css/CSSParser.cpp:
(WebCore::parseKeywordValue):
Make sure to handle "revert" in the keyword parsing path (along with inherit/initial/unset).
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
At the parser level, "revert" is just like inherit/initial/unset and gets its own special
singleton value, CSSRevertValue.
- css/CSSRevertValue.cpp: Added.
(WebCore::CSSRevertValue::customCSSText):
- css/CSSRevertValue.h: Added.
(WebCore::CSSRevertValue::create):
(WebCore::CSSRevertValue::equals):
(WebCore::CSSRevertValue::CSSRevertValue):
This value is identical to the inherit/initial/unset values, i.e., its own special value
that can be used to indicate a revert when doing style resolution.
- css/CSSValue.cpp:
(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isUnsetValue):
(WebCore::CSSValue::isRevertValue):
Add the RevertClass to CSSValue and make sure it is handled in all the appropriate methods.
- css/CSSValueKeywords.in:
Add the "revert" keyword to the list of allowed CSS keywords.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createRevertValue):
Add support for a CSSRevertValue singleton, just like inherit/unset/initial.
- css/FontLoader.cpp:
(WebCore::FontLoader::resolveFontStyle):
Add "unset" and "revert" as special keywords to be ignored. This code seems to be turned off,
but patching it anyway.
- css/SelectorChecker.h:
Add a MatchDefault value of 0 to the LinkMatchMask. This enables it to be used as an index
to the correct value in Property (in the style resolution code).
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initForStyleResolve):
Delete any lingering old CascadedProperty rollbacks for UA/user rules.
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
Pass along the MatchResult as an additional parameter, since we need it to lazily compute
the cascade rollbacks if the "revert" keyword is encountered.
(WebCore::StyleResolver::cascadedPropertiesForRollback):
This method will lazily create and return a new CascadedProperties pointer that is cached
in the StyleResolver's state. This will contain only UA rules (for user reverts) and UA/user
rules (for author reverts). These will only be computed at most once for a given element
when doing a reversion, and they will be computed lazily, i.e., only if a revert is
requested.
(WebCore::StyleResolver::applyProperty):
Pass along the LinkMatchMask and the MatchResult to applyProperty. This way we know specifically
which link type we were computing if we have to revert (so that we roll back and look at the
same index in the reverted version). The MatchResult is passed along because it is needed
to build the CascadedProperties rollbacks.
The basic idea is that if a revert is encountered, the level that the rule came from is
checked. If it is UA level, just treat as "unset." If it is author or user level, get
the correct CascadedProperties rollback and repeat the applyProperty using the property
found in the rollback. If the property is not present in the cascade rollback, then the
revert becomes an unset.
(WebCore::StyleResolver::CascadedProperties::hasCustomProperty):
(WebCore::StyleResolver::CascadedProperties::customProperty):
Helpers used by applyProperty to check on custom properties, since they can revert too
just like a regular property can.
(WebCore::StyleResolver::CascadedProperties::setPropertyInternal):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::CascadedProperties::setDeferred):
Passing along the CascadeLevel (UA, User, Author) so that it can be stored in the Property.
This way when we do property application, we always know where the rule came from so
that the reversion can be handled properly.
(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::cascadeLevelForIndex):
(WebCore::StyleResolver::CascadedProperties::addMatches):
When style properties are added, also figure out the CascadeLevel and pass it along to be
stored in the Property. We use the MatchResult's ranges to know where a property comes from.
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedProperties):
Pass along the MatchResult so we know how to build the rollback.
- css/StyleResolver.h:
(WebCore::StyleResolver::State::cascadeLevel):
(WebCore::StyleResolver::State::setCascadeLevel):
(WebCore::StyleResolver::State::authorRollback):
(WebCore::StyleResolver::State::userRollback):
(WebCore::StyleResolver::State::setAuthorRollback):
(WebCore::StyleResolver::State::setUserRollback):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::cascadeLevel):
(WebCore::StyleResolver::setCascadeLevel):
Move CascadedProperties into the header. Add CascadeLevel to Property. Add the level and
rollbacks to the resolver's state.
LayoutTests:
- fast/css/all-keyword-revert-expected.html: Added.
- fast/css/all-keyword-revert.html: Added.
- fast/css/revert-color-expected.html: Added.
- fast/css/revert-color.html: Added.
- fast/css/revert-margins-expected.html: Added.
- fast/css/revert-margins.html: Added.
- fast/css/variables/all-keyword-revert-expected.html: Added.
- fast/css/variables/all-keyword-revert.html: Added.
- fast/css/variables/revert-inheritance-expected.html: Added.
- fast/css/variables/revert-inheritance.html: Added.
- fast/css/variables/revert-no-inheritance-expected.html: Added.
- fast/css/variables/revert-no-inheritance.html: Added.
- fast/css/variables/revert-variable-reference-expected.html: Added.
- fast/css/variables/revert-variable-reference.html: Added.
- 3:40 PM Changeset in webkit [191251] by
-
- 5 edits2 adds in trunk
Delete FontPlatformData::allowsLigatures()
https://bugs.webkit.org/show_bug.cgi?id=150286
Reviewed by Dan Bernstein.
Source/WebCore:
This function is only used to force ligatures on for complex fonts (where "complex"
means "does not support the letter 'a'"). However, ligatures are turned on for all
fonts by default, which means that this function is unnecessary.
Required ligatures, such as those which make these complex scripts legible, are always
enabled, no matter what.
Test: fast/text/required-ligatures.html
- platform/graphics/FontPlatformData.h:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::allowsLigatures): Deleted.
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::Font::getCFStringAttributes):
LayoutTests:
Make sure it's impossible to turn off required ligatures with CSS.
- fast/text/required-ligatures-expected.html: Added.
- fast/text/required-ligatures.html: Added.
- 3:31 PM Changeset in webkit [191250] by
-
- 10 edits in trunk/Source
Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"
https://bugs.webkit.org/show_bug.cgi?id=150287
Reviewed by Simon Fraser.
Source/WebCore:
This user default is currently on by default. Therefore, by setting the user default,
users can only disable kerning / ligatures (rather than enable it).
There are a few reasons why we should stop honoring it:
- In the brave new world of font-feature-settings and font-variant-ligatures, there
are many different kinds of ligatures which may be enabled at will. The simplistic
statement of "turn on ligatures" no longer has any meaning.
- If a user wants to disable kerning / ligatures, he/she can do it with a user
stylesheet.
- The default isn't able to be tested with DumpRenderTree or WebKitTestRunner.
- I have never heard of anyone actually using this user default.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::setDefaultKerning): Deleted.
(WebCore::FontCascade::setDefaultLigatures): Deleted.
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::advancedTextRenderingMode):
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView initialize]): Deleted.
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Deleted.
(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded): Deleted.
(WebKit::WebProcessPool::platformInitializeWebProcess): Deleted.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Deleted.
- 2:32 PM Changeset in webkit [191249] by
-
- 5 edits2 adds in trunk/Source
[Cocoa] Stop using WKAXRegisterRemoteApp
https://bugs.webkit.org/show_bug.cgi?id=150283
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- platform/spi/ios/GraphicsServicesSPI.h: Added declaration of GSSystemRootDirectory.
Source/WebKit2:
- Platform/spi/mac: Added.
- Platform/spi/mac/AppKitSPI.h: Added. Includes declaration of +[NSAccessibilityRemoteUIElement setRemoteUIApp:].
- WebKit2.xcodeproj/project.pbxproj: Added reference to new header. Also changed the path of the Platform/spi/Cocoa group to the corresponding path in the source tree.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerWithAccessibility): Added.
(WebKit::WebProcess::platformInitializeProcess): Use new registerWithAccessibility instead
of WKAXRegisterRemoteApp.
- 1:27 PM Changeset in webkit [191248] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Fix some generational heap growth pathologies
https://bugs.webkit.org/show_bug.cgi?id=150270
Reviewed by Andreas Kling.
When doing generational copying, we would pretend that the size of old space was increased
just by the amount of bytes we copied. In reality, it would be increased by the number of
bytes used by the copied blocks we created. This is a larger number, and in some simple
pathological programs, the difference can be huge.
Fixing this bug was relatively easy, and the only really meaningful change here is in
Heap::updateAllocationLimits(). But to convince myself that the change was valid, I had to
add some debugging code and I had to refactor some stuff so that it made more sense.
This change does obviate the need for m_totalBytesCopied, because we no longer use it in
release builds to decide how much heap we are using at the end of collection. But I added a
FIXME about how we could restore our use of m_totalBytesCopied. So, I kept the logic, for
now. The FIXME references https://bugs.webkit.org/show_bug.cgi?id=150268.
Relanding with build fix.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/CopiedBlock.cpp: Added.
(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::destroy):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):
- heap/CopiedBlock.h:
(JSC::CopiedBlock::didSurviveGC):
(JSC::CopiedBlock::createNoZeroFill): Deleted.
(JSC::CopiedBlock::destroy): Deleted.
(JSC::CopiedBlock::create): Deleted.
(JSC::CopiedBlock::zeroFillWilderness): Deleted.
(JSC::CopiedBlock::CopiedBlock): Deleted.
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::startedCopying):
- heap/Heap.cpp:
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::collectImpl):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::sizeAfterCollect): Deleted.
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::shouldCollect):
(JSC::Heap::isBusy):
(JSC::Heap::collectIfNecessaryOrDefer):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
- 12:38 PM Changeset in webkit [191247] by
-
- 25 edits4 adds in trunk
td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
https://bugs.webkit.org/show_bug.cgi?id=148859
<rdar://problem/22588664>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
as per the latest HTML specification:
https://html.spec.whatwg.org/multipage/tables.html#htmltabledatacellelement
https://html.spec.whatwg.org/multipage/tables.html#htmltableheadercellelement
This patch aligns our behavior with the specification and IE. Firefox and Chrome do not
seem to expose HTMLTableDataCellElement / HTMLTableHeaderCellElement at this time.
The compatibility risk is low, given that the API stays the same and those new
interfaces inherit the pre-existing HTMLTableCellElement interface.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan): Deleted.
- html/HTMLTableCellElement.h:
- html/HTMLTableCellElement.idl:
- html/HTMLTableDataCellElement.h: Added.
- html/HTMLTableDataCellElement.idl: Added.
- html/HTMLTableHeaderCellElement.h: Added.
- html/HTMLTableHeaderCellElement.idl: Added.
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
- html/HTMLTagNames.in:
LayoutTests:
Rebaseline existing tests now that new HTMLTableDataCellElement / HTMLTableHeaderCellElement
types are exposed.
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 12:14 PM Changeset in webkit [191246] by
-
- 3 edits in trunk/Source/WebCore
RenderBlockFlow::xPositionForFloatIncludingMargin/yPositionForFloatIncludingMargin/flipFloatForWritingModeForChild
should all take FloatingObject reference.
https://bugs.webkit.org/show_bug.cgi?id=150267
Reviewed by Simon Fraser.
No change in behaviour.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::xPositionForFloatIncludingMargin):
(WebCore::RenderBlockFlow::yPositionForFloatIncludingMargin):
- 11:49 AM Changeset in webkit [191245] by
-
- 2 edits in trunk/Source/WebCore
Sort the project file.
- WebCore.xcodeproj/project.pbxproj:
- 11:42 AM Changeset in webkit [191244] by
-
- 9 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r191240.
https://bugs.webkit.org/show_bug.cgi?id=150281
Broke 32-bit builds (Requested by smfr on #webkit).
Reverted changeset:
"Fix some generational heap growth pathologies"
https://bugs.webkit.org/show_bug.cgi?id=150270
http://trac.webkit.org/changeset/191240
- 11:34 AM Changeset in webkit [191243] by
-
- 44 edits2 adds in trunk/Source
Enhance TextStream for logging, remove subclasses, log more things
https://bugs.webkit.org/show_bug.cgi?id=150269
Reviewed by Zalan Bujtas.
Remove the various TextStream subclasses that only existed to support indenting,
and output additional types. Add output for more WebCore and WebKit2 types, and
just use TextStream everywhere.
TextStream is enhance to support grouping (open paren and intent), with a
stack-based class to open/end a group.
Remove some SVG-specific duplicate output functions.
Outdent namespace contents of GraphicsTypes.h.
Source/WebCore:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/ViewportArguments.cpp:
(WebCore::operator<<):
- dom/ViewportArguments.h:
- page/ViewportConfiguration.cpp:
(WebCore::operator<<):
(WebCore::ViewportConfiguration::description):
(WebCore::ViewportConfigurationTextStream::ViewportConfigurationTextStream): Deleted.
(WebCore::ViewportConfigurationTextStream::increaseIndent): Deleted.
(WebCore::ViewportConfigurationTextStream::decreaseIndent): Deleted.
(WebCore::dumpProperty): Deleted.
(WebCore::ViewportConfigurationTextStream::writeIndent): Deleted.
(WebCore::ViewportConfigurationTextStream::operator<<): Deleted.
- page/ViewportConfiguration.h:
- page/scrolling/ScrollingConstraints.cpp:
(WebCore::operator<<):
- page/scrolling/ScrollingConstraints.h:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::operator<<):
- page/scrolling/ScrollingCoordinator.h:
- platform/animation/TimingFunction.cpp: Added.
(WebCore::operator<<):
- platform/animation/TimingFunction.h:
- platform/graphics/Color.cpp:
(WebCore::operator<<):
- platform/graphics/Color.h:
- platform/graphics/FloatPoint3D.cpp:
(WebCore::operator<<):
- platform/graphics/FloatPoint3D.h:
- platform/graphics/FloatRoundedRect.cpp:
(WebCore::operator<<):
- platform/graphics/FloatRoundedRect.h:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::operator<<):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsTypes.cpp:
(WebCore::operator<<):
- platform/graphics/GraphicsTypes.h:
- platform/graphics/ca/PlatformCAAnimation.cpp: Added.
(WebCore::operator<<):
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::operator<<):
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::operator<<):
- platform/graphics/filters/FilterOperations.h:
- platform/graphics/filters/PointLightSource.cpp:
(WebCore::operator<<): Deleted.
- platform/graphics/filters/SpotLightSource.cpp:
(WebCore::operator<<): Deleted.
- platform/graphics/transforms/AffineTransform.cpp:
(WebCore::operator<<):
- platform/graphics/transforms/AffineTransform.h:
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::operator<<):
- platform/graphics/transforms/TransformationMatrix.h:
- platform/text/TextStream.cpp:
(WebCore::TextStream::startGroup):
(WebCore::TextStream::endGroup):
(WebCore::TextStream::nextLine):
(WebCore::TextStream::writeIndent):
- platform/text/TextStream.h:
(WebCore::TextStream::operator<<):
(WebCore::TextStream::dumpProperty):
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):
(WebCore::TextStream::GroupScope::GroupScope):
(WebCore::TextStream::GroupScope::~GroupScope):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<): Deleted.
- rendering/svg/SVGRenderTreeAsText.h:
Source/WebKit2:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump):
(WebKit::recursiveDumpNodes):
(WebKit::RemoteScrollingCoordinatorTransaction::description):
(WebKit::RemoteScrollingTreeTextStream::RemoteScrollingTreeTextStream): Deleted.
(WebKit::RemoteScrollingTreeTextStream::increaseIndent): Deleted.
(WebKit::RemoteScrollingTreeTextStream::decreaseIndent): Deleted.
(WebKit::RemoteScrollingTreeTextStream::writeIndent): Deleted.
(WebKit::dumpProperty): Deleted.
(WebKit::RemoteScrollingTreeTextStream::operator<<): Deleted.
(WebKit::RemoteScrollingTreeTextStream::dump): Deleted.
(WebKit::RemoteScrollingTreeTextStream::recursiveDumpNodes): Deleted.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::operator<<):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::description):
(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream): Deleted.
(WebKit::RemoteLayerTreeTextStream::increaseIndent): Deleted.
(WebKit::RemoteLayerTreeTextStream::decreaseIndent): Deleted.
(WebKit::dumpProperty): Deleted.
(WebKit::RemoteLayerTreeTextStream::operator<<): Deleted.
(WebKit::RemoteLayerTreeTextStream::writeIndent): Deleted.
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::operator<<):
- 11:04 AM Changeset in webkit [191242] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=150278
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-17
Reviewed by Brent Fulgham.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 10:52 AM Changeset in webkit [191241] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed typos from r191224.
Not reviewed.
- jit/JITSubGenerator.h:
(JSC::JITSubGenerator::generateFastPath):
- 10:26 AM Changeset in webkit [191240] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Fix some generational heap growth pathologies
https://bugs.webkit.org/show_bug.cgi?id=150270
Reviewed by Andreas Kling.
When doing generational copying, we would pretend that the size of old space was increased
just by the amount of bytes we copied. In reality, it would be increased by the number of
bytes used by the copied blocks we created. This is a larger number, and in some simple
pathological programs, the difference can be huge.
Fixing this bug was relatively easy, and the only really meaningful change here is in
Heap::updateAllocationLimits(). But to convince myself that the change was valid, I had to
add some debugging code and I had to refactor some stuff so that it made more sense.
This change does obviate the need for m_totalBytesCopied, because we no longer use it in
release builds to decide how much heap we are using at the end of collection. But I added a
FIXME about how we could restore our use of m_totalBytesCopied. So, I kept the logic, for
now. The FIXME references https://bugs.webkit.org/show_bug.cgi?id=150268.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/CopiedBlock.cpp: Added.
(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::destroy):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):
- heap/CopiedBlock.h:
(JSC::CopiedBlock::didSurviveGC):
(JSC::CopiedBlock::createNoZeroFill): Deleted.
(JSC::CopiedBlock::destroy): Deleted.
(JSC::CopiedBlock::create): Deleted.
(JSC::CopiedBlock::zeroFillWilderness): Deleted.
(JSC::CopiedBlock::CopiedBlock): Deleted.
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::startedCopying):
- heap/Heap.cpp:
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::collectImpl):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::sizeAfterCollect): Deleted.
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::shouldCollect):
(JSC::Heap::isBusy):
(JSC::Heap::collectIfNecessaryOrDefer):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
- 1:23 AM Changeset in webkit [191239] by
-
- 3 edits in trunk/Source/WebKit2
URTBF after r191194 to fix EFL build.
https://bugs.webkit.org/show_bug.cgi?id=150272
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-17
Reviewed by Csaba Osztrogonác.
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::showContextMenu):
- UIProcess/efl/WebContextMenuProxyEfl.h:
- 12:10 AM Changeset in webkit [191238] by
-
- 2 edits in trunk/Source/WebCore
Finalize bug 149952 patch
https://bugs.webkit.org/show_bug.cgi?id=150238
Reviewed by Darin Adler.
No change in behavior.
- bindings/js/JSDOMConstructor.h:
(WebCore::JSDOMConstructor<JSClass>::finishCreation): Marked as inline.
(WebCore::JSDOMConstructor<JSClass>::getConstructData): Marked as inline.
