⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 16, 2017:

10:26 PM Changeset in webkit [216969] by Chris Dumez
  • 3 edits in trunk/LayoutTests

[macOS Debug wk2] Layout test svg/animations/animations-paused-in-background-page-iframe.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=172183

Reviewed by Andreas Kling.

Fix test flakiness by using shouldBecome() instead of relying on a 30ms timer.

  • svg/animations/animations-paused-in-background-page-iframe-expected.txt:
  • svg/animations/animations-paused-in-background-page-iframe.html:
10:04 PM Changeset in webkit [216968] by ddkilzer@apple.com
  • 7 edits in trunk/Source/WebCore

Remove C-style casts by using xmlDocPtr instead of void*
<​https://webkit.org/b/172189>

Reviewed by Alex Christensen.

  • dom/TransformSource.h: Fix whitespace indentation.

(typedef PlatformTransformSource): Use xmlDocPtr not void*.

  • dom/TransformSourceLibxslt.cpp:

(WebCore::TransformSource::~TransformSource): Remove cast.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::document): Remove cast.

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xmlDocPtrFromNode): Remove casts.

  • xml/parser/XMLDocumentParser.h:

(WebCore::xmlDocPtrForString): Update declaration to return
xmlDocPtr not void*.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd): Change type of local
variable from void* to xmlDocPtr.
(WebCore::xmlDocPtrForString): Update to return xmlDocPtr
not void*.

8:22 PM Changeset in webkit [216967] by commit-queue@webkit.org
  • 29 edits
    3 copies
    2 adds in trunk

Bring Notification.idl up to spec
​https://bugs.webkit.org/show_bug.cgi?id=172156

Patch by Sam Weinig <​sam@webkit.org> on 2017-05-16
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/notifications/notification.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::create):
(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::directionString): Deleted.
(WebCore::Notification::permission): Deleted.
(WebCore::Notification::permissionString): Deleted.

  • Modules/notifications/Notification.h:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationClient.h:
  • Modules/notifications/NotificationDirection.h: Added.
  • Modules/notifications/NotificationPermission.h: Added.
  • Modules/notifications/NotificationPermission.idl: Added.
  • Modules/notifications/NotificationPermissionCallback.h:
  • Modules/notifications/NotificationPermissionCallback.idl:

Bring up to spec, replacing DOMStrings with enums where appropriate and adding
additional readonly properties to Notification to mirror options provided
in construction.

Source/WebKit/mac:

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(generateNotificationID):
(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::hasPendingPermissionRequests):
(WebNotificationClient::checkPermission):
(-[WebNotificationPolicyListener allow]):
(-[WebNotificationPolicyListener deny]):

  • WebView/WebNotification.mm:

(-[WebNotification iconURL]):
(-[WebNotification dir]):
Simplify #ifdefs and update for enum vs String usage.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyDir):

  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::dir):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::checkPermission):

  • WebProcess/WebCoreSupport/WebNotificationClient.h:

Update for enum vs String usage.

LayoutTests:

  • http/tests/notifications/notification-expected.txt: Added.
  • http/tests/notifications/notification.html: Added.

Add test for basic Notification API functionality.

7:33 PM Changeset in webkit [216966] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Do not skip <slot> children when collecting content for innerText.
​https://bugs.webkit.org/show_bug.cgi?id=172113
<rdar://problem/30362324>

Reviewed by Ryosuke Niwa and Brent Fulgham.

Source/WebCore:

"display: contents" elements do not generate renderers but their children might.
This patch ensure that we don't skip them while collecting text content.

Test: fast/text/inner-text-should-include-slot-subtree.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance):

LayoutTests:

  • fast/text/inner-text-should-include-slot-subtree-expected.txt: Added.
  • fast/text/inner-text-should-include-slot-subtree.html: Added.
7:11 PM Changeset in webkit [216965] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

GCController::garbageCollectNowIfNotDoneRecently should request Async Full GCs
​https://bugs.webkit.org/show_bug.cgi?id=172204

Reviewed by Saam Barati.

No new tests because existing tests will tell us if there is a problem.

The goal of this change is to reduce the likelihood that we block for a GC. We want it to be
benchmark-neutral.

It's a 0.14% speed-up on JetStream with 24% probability.

It's a 0.12% slow-down on PLT3 with 43% probability.

So it's neutral on my machine.

  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNowIfNotDoneRecently):

6:17 PM Changeset in webkit [216964] by jiewen_tan@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed, fix LayoutTests/plugins/navigator-plugin-crash.html
<rdar://problem/32236478>

  • plugins/navigator-plugin-crash-expected.txt:
  • plugins/navigator-plugin-crash.html:
6:01 PM Changeset in webkit [216963] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Fix the build

  • TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

5:53 PM Changeset in webkit [216962] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

[macOS] REGRESSION: Drag images for links with right-to-left titles are incorrect (172006)
​https://bugs.webkit.org/show_bug.cgi?id=172006
<rdar://problem/32165137>

Reviewed by Dean Jackson.

  • platform/mac/DragImageMac.mm:

(WebCore::LinkImageLayout::LinkImageLayout):
(WebCore::createDragImageForLink):
(WebCore::LinkImageLayout::addLine): Deleted.

  • platform/spi/cocoa/CoreTextSPI.h:

Set and paint the entire frame as a single unit, making use of the
CTFrameMaximumNumberOfLines attribute to limit the number of lines.
This gives CoreText power over text alignment and makes RTL text lay
out correctly.

5:51 PM Changeset in webkit [216961] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

PageVisibilityStateWithWindowChanges tests sometimes time out
​https://bugs.webkit.org/show_bug.cgi?id=172202
<rdar://problem/29653266>

Reviewed by Dean Jackson.

  • TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.

5:12 PM Changeset in webkit [216960] by msaboff@apple.com
  • 2 edits in trunk/Source/bmalloc

REGRESSION(r216763): JetStream is 1% slower on Mac
​https://bugs.webkit.org/show_bug.cgi?id=172124

Reviewed by Filip Pizlo.

It appears that changing maxScavengeSleepDuration from 512 to 250ms in r216763 is
responsible for the regression.

  • bmalloc/Sizes.h:
4:45 PM Changeset in webkit [216959] by Chris Dumez
  • 24 edits
    13 adds
    2 deletes in trunk

Implement DOMMatrix / DOMMatrixReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=110001

Reviewed by Sam Weinig and Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline web-platform-tests now that more checks are passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-001-expected.txt:

Most checks are now passing. The few remaining failures seem to be due to our
parsing of the input CSS string now matching the specification. This behavior
is not new to this patch as I re-used exactly the same logic as for
WebKitCSSMatrix's parsing of the input string.

  • web-platform-tests/css/geometry-1/DOMMatrix-002-expected.txt:
  • web-platform-tests/css/geometry-1/DOMMatrix-003-expected.txt:
  • web-platform-tests/css/geometry-1/DOMMatrix-a-f-alias-expected.txt:

All checks are now passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt:

Most checks are now passing. The remaining failures are due to DOMMatrixReadOnly's
transformPoint() / toFloat32Array() / toFloat64Array() not being implemented in
this patch. I think we can take care of those in a follow-up.

  • web-platform-tests/css/geometry-1/DOMPoint-002-expected.txt:

Fails differently now that we support DOMMatrix. The test goes further but still
fails because DOMPoint.matrixTransform() is not implemented.

  • web-platform-tests/css/geometry-1/WebKitCSSMatrix-expected.txt:

One more check is passing now that we implement DOMMatrix. The remaining failure is
due to WebKitCSSMatrix not being an alias to DOMMatrix yet. I'd rather do this in a
follow-up.

  • web-platform-tests/css/geometry-1/historical-expected.txt:

A lot of new passes.

  • web-platform-tests/css/geometry-1/structured-serialization-expected.txt:

The test fails differently now that we support DOMMatrix. The test still fails because
we do not support yet the structured serialization of DOMMatrix objects. It appears we
do not support this for other types in this spec either (e.g. DOMPoint). I filed:
​https://bugs.webkit.org/show_bug.cgi?id=172191

  • web-platform-tests/css/geometry-1/DOMMatrix-stringifier-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-stringifier.html: Added.

Import new test from upstream. The WebKitCSSMatrix failures are due to our
WebKitCSSMatrix implementation not complying with the standard. As per the
standard, WebKitCSSMatrix is supposed to become an alias to DOMMatrix. If we
do this aliasing (in a follow-up), then those tests will start passing.

  • web-platform-tests/css/geometry-1/support/dommatrix-test-util.js: Added.

Add missing script that was missed by the importer when I initially imported the test
suite from upstream.

Source/WebCore:

Implement DOMMatrix / DOMMatrixReadOnly as per:

For now, these new types co-exist with WebKitCSSMatrix / SVGMatrix. However, in the future,
WebKitCSSMatrix / SVGMatrix are supposed to become aliases to DOMMatrix.

Most of it has been implemented. What remaining to be implemented is:

  • Make WebKitCSSMatrix / SVGMatrix aliases to DOMMatrix
  • DOMMatrix.fromFloat32Array() / fromFloat64Array()
  • DOMMatrixReadOnly.fromFloat32Array() / fromFloat64Array() / toFloat32Array() / toFloat64Array()
  • DOMMatrixReadOnly.transformPoint().

Tests: imported/w3c/web-platform-tests/css/geometry-1/*

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:

Fix a bug in the bindings generator causing the generator code for
"Constructor(optional (DOMString or sequence<unrestricted double>) init)" to be wrong
and not build.

  • css/DOMMatrix.cpp: Added.

(WebCore::DOMMatrix::DOMMatrix):
(WebCore::DOMMatrix::fromMatrix):
(WebCore::DOMMatrix::multiplySelf):
(WebCore::DOMMatrix::preMultiplySelf):
(WebCore::DOMMatrix::translateSelf):
(WebCore::DOMMatrix::scaleSelf):
(WebCore::DOMMatrix::scale3dSelf):
(WebCore::DOMMatrix::rotateSelf):
(WebCore::DOMMatrix::rotateFromVectorSelf):
(WebCore::DOMMatrix::rotateAxisAngleSelf):
(WebCore::DOMMatrix::skewXSelf):
(WebCore::DOMMatrix::skewYSelf):
(WebCore::DOMMatrix::invertSelf):
(WebCore::DOMMatrix::setMatrixValueForBindings):

  • css/DOMMatrix.h: Added.

(WebCore::DOMMatrix::create):
(WebCore::DOMMatrix::setA):
(WebCore::DOMMatrix::setB):
(WebCore::DOMMatrix::setC):
(WebCore::DOMMatrix::setD):
(WebCore::DOMMatrix::setE):
(WebCore::DOMMatrix::setF):
(WebCore::DOMMatrix::setM11):
(WebCore::DOMMatrix::setM12):
(WebCore::DOMMatrix::setM13):
(WebCore::DOMMatrix::setM14):
(WebCore::DOMMatrix::setM21):
(WebCore::DOMMatrix::setM22):
(WebCore::DOMMatrix::setM23):
(WebCore::DOMMatrix::setM24):
(WebCore::DOMMatrix::setM31):
(WebCore::DOMMatrix::setM32):
(WebCore::DOMMatrix::setM33):
(WebCore::DOMMatrix::setM34):
(WebCore::DOMMatrix::setM41):
(WebCore::DOMMatrix::setM42):
(WebCore::DOMMatrix::setM43):
(WebCore::DOMMatrix::setM44):

  • css/DOMMatrix.idl: Added.
  • css/DOMMatrixInit.h: Added.
  • css/DOMMatrixInit.idl: Added.
  • css/DOMMatrixReadOnly.cpp: Added.

(WebCore::DOMMatrixReadOnly::DOMMatrixReadOnly):
(WebCore::DOMMatrixReadOnly::validateAndFixup):
(WebCore::DOMMatrixReadOnly::fromMatrix):
(WebCore::DOMMatrixReadOnly::isIdentity):
(WebCore::DOMMatrixReadOnly::setMatrixValue):
(WebCore::DOMMatrixReadOnly::translate):
(WebCore::DOMMatrixReadOnly::flipX):
(WebCore::DOMMatrixReadOnly::flipY):
(WebCore::DOMMatrixReadOnly::multiply):
(WebCore::DOMMatrixReadOnly::scale):
(WebCore::DOMMatrixReadOnly::scale3d):
(WebCore::DOMMatrixReadOnly::rotate):
(WebCore::DOMMatrixReadOnly::rotateFromVector):
(WebCore::DOMMatrixReadOnly::rotateAxisAngle):
(WebCore::DOMMatrixReadOnly::skewX):
(WebCore::DOMMatrixReadOnly::skewY):
(WebCore::DOMMatrixReadOnly::inverse):
(WebCore::DOMMatrixReadOnly::toString):

  • css/DOMMatrixReadOnly.h: Added.

(WebCore::DOMMatrixReadOnly::create):
(WebCore::DOMMatrixReadOnly::a):
(WebCore::DOMMatrixReadOnly::b):
(WebCore::DOMMatrixReadOnly::c):
(WebCore::DOMMatrixReadOnly::d):
(WebCore::DOMMatrixReadOnly::e):
(WebCore::DOMMatrixReadOnly::f):
(WebCore::DOMMatrixReadOnly::m11):
(WebCore::DOMMatrixReadOnly::m12):
(WebCore::DOMMatrixReadOnly::m13):
(WebCore::DOMMatrixReadOnly::m14):
(WebCore::DOMMatrixReadOnly::m21):
(WebCore::DOMMatrixReadOnly::m22):
(WebCore::DOMMatrixReadOnly::m23):
(WebCore::DOMMatrixReadOnly::m24):
(WebCore::DOMMatrixReadOnly::m31):
(WebCore::DOMMatrixReadOnly::m32):
(WebCore::DOMMatrixReadOnly::m33):
(WebCore::DOMMatrixReadOnly::m34):
(WebCore::DOMMatrixReadOnly::m41):
(WebCore::DOMMatrixReadOnly::m42):
(WebCore::DOMMatrixReadOnly::m43):
(WebCore::DOMMatrixReadOnly::m44):
(WebCore::DOMMatrixReadOnly::is2D):
(WebCore::DOMMatrixReadOnly::fromMatrixHelper):

  • css/DOMMatrixReadOnly.idl: Added.
  • css/WebKitCSSMatrix.h:
  • css/WebKitCSSMatrix.idl:
  • svg/SVGMatrix.h:
  • svg/SVGMatrix.idl:

LayoutTests:

Drop test I previously added now that a better version landed in web-platform-tests
and was re-imported in this patch.

  • fast/css/matrix-stringifier-expected.txt: Removed.
  • fast/css/matrix-stringifier.html: Removed.
4:44 PM Changeset in webkit [216958] by jmarcell@apple.com
  • 5 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216947. rdar://problem/32200017

4:44 PM Changeset in webkit [216957] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch

Cherry-pick r216892. rdar://problem/31513869

4:44 PM Changeset in webkit [216956] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216257. rdar://problem/32014052

4:19 PM Changeset in webkit [216955] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Start servers before setting-up for testing
​https://bugs.webkit.org/show_bug.cgi?id=172176
<rdar://problem/32225538>

Reviewed by Alexey Proskuryakov.

On-device testing requires that servers are started before ports set-up their
test environments.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.init): Start servers when initializing LayoutTestRunner.
(LayoutTestRunner.run_tests): Move the starting of servers to the initializer.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init): Delay construction of the test runner until we can determine
if servers need to be started.
(Manager.run): Determine if servers need to be started and construct the test runner.
(Manager._run_tests): Move the determination of servers to run into Manager.run.

4:10 PM Changeset in webkit [216954] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MediaStream] AudioSampleBufferList::zeroABL takes byte count, not sample count
​https://bugs.webkit.org/show_bug.cgi?id=172194
<rdar://problem/32233799>

Reviewed by Jer Noble.

  • platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::render): Pass number of bytes to zero,
not number of samples.

4:06 PM Changeset in webkit [216953] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

WorkerRunLoop::Task::performTask() needs to null check context->script() before use.
​https://bugs.webkit.org/show_bug.cgi?id=172193
<rdar://problem/32225346>

Reviewed by Filip Pizlo.

According to ​https://build-safari.apple.com/results/Trunk%20Fuji%20GuardMalloc%20Production%20WK2%20Tests/r216929_459760e0918316187c8e52c6585a3a9ba9181204%20(12066)/results.html,
we see a crash with this crash trace:

Thread 13 Crashed:: WebCore: Worker
0 com.apple.WebCore 0x00000001099607b2 WebCore::WorkerScriptController::isTerminatingExecution() const + 18
1 com.apple.WebCore 0x000000010995ebbf WebCore::WorkerRunLoop::runCleanupTasks(WebCore::WorkerGlobalScope*) + 143
2 com.apple.WebCore 0x000000010995e80f WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*) + 111
3 com.apple.WebCore 0x00000001099621b6 WebCore::WorkerThread::workerThread() + 742
4 com.apple.JavaScriptCore 0x000000010a964b92 WTF::threadEntryPoint(void*) + 178
5 com.apple.JavaScriptCore 0x000000010a964a69 WTF::wtfThreadEntryPoint(void*) + 121
6 libsystem_pthread.dylib 0x00007fffbdb5caab _pthread_body + 180
7 libsystem_pthread.dylib 0x00007fffbdb5c9f7 _pthread_start + 286
8 libsystem_pthread.dylib 0x00007fffbdb5c1fd thread_start + 13

... and the crashing address is:

Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000022

0x0000000000000022 is the offset of m_scheduledTerminationMutex in the
WorkerScriptController. This means that WorkerScriptController::isTerminatingExecution()
is passed a NULL this pointer. This means that it's possible to have a race
where a WorkerRunLoop::Task gets enqueued beyond the Cleanup task that deletes the
context->script(). As a result, WorkerRunLoop::Task::performTask() (called by
runCleanupTasks()) may see a null context->script().

Hence, WorkerRunLoop::Task::performTask() should null check context->script()
before invoking the isTerminatingExecution() query on it.

No new tests because this is already covered by existing tests.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::Task::performTask):

3:49 PM Changeset in webkit [216952] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Modernize WebKit2 getUserMedia passing of parameters
​https://bugs.webkit.org/show_bug.cgi?id=172161

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-16
Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

  • platform/mediastream/RealtimeMediaSourceCenter.h: Using WTF::Function to enable capture Ref<>.

Source/WebKit2:

Passing SecurityOrigin as SecurityOriginData through IPC instead of Strings.
Making more use of Ref<> instead of RefPtr<>.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy):
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo):

  • UIProcess/UserMediaPermissionCheckProxy.h:

(WebKit::UserMediaPermissionCheckProxy::create):
(WebKit::UserMediaPermissionCheckProxy::userMediaDocumentSecurityOrigin):
(WebKit::UserMediaPermissionCheckProxy::topLevelDocumentSecurityOrigin):
(WebKit::UserMediaPermissionCheckProxy::completionHandler):

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState):
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual):
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):

  • UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::enumerateMediaDevicesForFrame):
(WebKit::WebPageProxy::requestNotificationPermission):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::sendUserMediaRequest):
(WebKit::UserMediaPermissionRequestManager::enumerateMediaDevices):

3:27 PM Changeset in webkit [216951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Captions and subtitles not showing up in picture-in-picture for MSE content.
​https://bugs.webkit.org/show_bug.cgi?id=172145

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-05-16
Reviewed by Eric Carlson.

No new tests as this has no affect on the DOM.

Add TextTrackRepresentation code from MediaPlayerPrivateAVFoundationObj to MediaPlayerPrivateMediaSourceAVFObjc.
This moves the TextTrackRepresentation platfrom layer into the fullscreen container layer when going into
pip for fullscreen, allowing the captions to be visible.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenFrame):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::requiresTextTrackRepresentation):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::syncTextTrackBounds):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setTextTrackRepresentation):

3:27 PM Changeset in webkit [216950] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

3:20 PM Changeset in webkit [216949] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

WebCore::leakCGColor() needs CF_RETURNS_RETAINED annotation
<​https://webkit.org/b/172190>

Reviewed by Simon Fraser.

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::leakCGColor): Annotate with CF_RETURNS_RETAINED since
it does not follow the CF naming convention, which means the
expected behavior can't be inferred by the clang static
analyzer.

2:54 PM Changeset in webkit [216948] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

[DFG] Constant Folding Phase should convert MakeRope("", String) => Identity(String)
​https://bugs.webkit.org/show_bug.cgi?id=172115

Reviewed by Saam Barati.

JSTests:

  • stress/constant-folding-should-fold-make-rope-with-empty-strings.js: Added.

(shouldBe):
(unknown):
(readWord1):
(readWord2):
(readWord3):
(readWord4):

Source/JavaScriptCore:

In Fixup phase, we attempt to fold MakeRope to Identity (or reduce arguments) by dropping
empty strings. However, when we are in Fixup phase, we do not have much information about
constant values.

In ARES-6 Babylon, we find that we can constant-fold MakeRope by using constants figured
out by CFA. Without it, Babylon repeatedly produces rope strings. To fix this, we introduce
MakeRope handling in constant folding phase.

It shows 7.5% performance improvement in ARES-6 Babylon steadyState.

Before:

firstIteration: 50.02 +- 14.56 ms
averageWorstCase: 26.52 +- 4.52 ms
steadyState: 8.15 +- 0.23 ms

After:

firstIteration: 49.08 +- 12.90 ms
averageWorstCase: 25.16 +- 3.82 ms
steadyState: 7.58 +- 0.21 ms

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

2:18 PM Changeset in webkit [216947] by commit-queue@webkit.org
  • 5 edits in trunk/Source

RealtimeOutgoingVideoSource should support sinkWants for rotation
​https://bugs.webkit.org/show_bug.cgi?id=172123
<rdar://problem/32200017>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-16
Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

  • Source/webrtc/api/video/i420_buffer.h: Exporting rotate routine.

Source/WebCore:

Covered by manual testing.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::AddOrUpdateSink): Triggering pixel rotation based on sink.
(WebCore::RealtimeOutgoingVideoSource::sendFrame): Doing the rotation using libwebrtc API.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
2:16 PM Changeset in webkit [216946] by commit-queue@webkit.org
  • 12 edits
    8 adds in trunk/PerformanceTests

Update to Speedometer 2.0 w/updated frameworks + new workloads
​https://bugs.webkit.org/show_bug.cgi?id=170513

Patch by Addy Osmani <​addyosmani@gmail.com> on 2017-05-16
Reviewed by Ryosuke Niwa.

Refresh test runner and fix apps to work with it.

  • Speedometer/InteractiveRunner.html:

(parseQueryString): Adds support for startAutomatically query parameter.

  • Speedometer/resources/tests.js:

(triggerEnter): Refactor event triggering behavior for tests.

  • Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html:

(CSS): Drop reference to extraneous stylesheet in Angular TodoMVC.

  • Speedometer/resources/todomvc/architecture-examples/emberjs/assets/todomvc.js:
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html:

(base): Enable Ember TodoMVC to be run from any directory/level.

  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/memory.js:

(localStorageMemory): Correct import path and switch to window.localStorageMemory to fix Ember failures.

  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js:
  • Speedometer/resources/todomvc/architecture-examples/emberjs/tests/index.html:
  • Speedometer/resources/todomvc/architecture-examples/jquery/index.html:
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/LICENSE: Added.

(LICENSE): Add missing metadata and LICENSE files as part of director.js package for jQuery TodoMVC

  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/dist/director.js: Add missing

director.js dependency for jQuery TodoMVC implementation.

  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/dist/director.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/dist/ender.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/package.json: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/index.html: Fix path to built Elm TodoMVC scripts.
2:02 PM Changeset in webkit [216945] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

Unused lambdas in UserMediaPermissionRequestManagerProxy.cpp
<​https://webkit.org/b/172179>

Reviewed by Eric Carlson.

Fixes unused lambda warnings found with newer clang:

Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:309:46: error: lambda capture 'userMediaID' is not used [-Werror,-Wunused-lambda-capture]

auto validateConstraintsHandler = [this, userMediaID, validHandler = WTFMove(validHandler), invalidHandler = WTFMove(invalidHandler), audioConstraints = WebCore::MediaConstraints(audioConstraints), videoConstraints = WebCore::MediaConstraints(videoConstraints)](String&& deviceIdentifierHashSalt) mutable {


Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:318:41: error: lambda capture 'userMediaID' is not used [-Werror,-Wunused-lambda-capture]

auto haveDeviceSaltHandler = [this, userMediaID, frameID, validateConstraintsHandler = WTFMove(validateConstraintsHandler)](uint64_t userMediaID, String&& deviceIdentifierHashSalt, bool originHasPersistentAccess) mutable {


Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:318:54: error: lambda capture 'frameID' is not used [-Werror,-Wunused-lambda-capture]

auto haveDeviceSaltHandler = [this, userMediaID, frameID, validateConstraintsHandler = WTFMove(validateConstraintsHandler)](uint64_t userMediaID, String&& deviceIdentifierHashSalt, bool originHasPersistentAccess) mutable {


Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:362:37: error: lambda capture 'userMediaID' is not used [-Werror,-Wunused-lambda-capture]

auto completionHandler = [this, userMediaID](uint64_t userMediaID, String&& deviceIdentifierHashSalt, bool originHasPersistentAccess) {


  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

  • Remove unused lambdas.
1:26 PM Changeset in webkit [216944] by mmaxfield@apple.com
  • 23 edits
    4 copies
    10 adds in trunk

REGRESSION(r212513): LastResort is platform-dependent, so its semantics should not be required to perform font loading correctly.
​https://bugs.webkit.org/show_bug.cgi?id=168487

Reviewed by Antti Koivisto.

Source/WebCore:

There are three ways a Web author can chain multiple font files together:

  1. Multiple entries in the "src" descriptor in an @font-face rule
  2. Multiple @font-face rules with the same "font-family" descriptor
  3. Multiple entries in the "font-family" property on an element

Before r212513, the code which iterated across #2 and #3 above could have
triggered each item in the chain to download. r212513 tried to solve this
by using LastResort as the interstitial font used during downloads, because
LastResort supports every character and therefore solves #3 above. However,
this change had a few problems:

  1. Previously, our code would try to avoid using the interstitial font for

layout or rendering whenever possible (because one of the chains above may
have named a local font which would be better to use). In order to use the
benefits of LastResort, I had to remove this avoidance logic and make
WebKit try to use the interstitial font as often as possible. However, due
to the large metrics of LastResort, this means that offsetWidth queries
during font loading would be wildly inaccurate, causing Google Docs to break.

  1. It also means that canvas drawing during font loading would actually draw

LastResort, causing Bing maps to break.

  1. LastResort is platform-specific, so only platforms which have it would

actually be able to load fonts correctly.

Instead, we should keep the older logic about avoiding using the
interstitial font so that loading has a better experience for the user.
We solve the unnecessary download problem by giving our loading code a
downloading policy enum, which has two values: allow downloads or forbid
downloads. Whenever our loading code returns the interstitial font, we
continue our search, but we change the policy to forbid downloads.

There is one piece of subtlety, though: It is more common for web authors
to put good fallbacks in the "font-family" property than in the "src"
descriptor inside @font-face. This means that we shouldn't exhaustively
search through the @font-face src list first. Instead, we should look
through the src list until we hit a non-local font, and then immediately
start looking through the other other chains.

Tests: fast/text/font-download-font-face-src-list.html

fast/text/font-download-font-family-property.html
fast/text/font-download-remote-fallback-all.html
fast/text/font-interstitial-invisible-width-while-loading.html
fast/text/font-weight-download-3.html
fast/text/web-font-load-fallback-during-loading-2.html
fast/text/web-font-load-invisible-during-loading.html

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::fontLoadEventOccurred): Implement support for
the font download policy.
(WebCore::CSSFontFace::setStatus): After 3 seconds of loading, we
will start drawing the fallback font. However, for testing, we have an
internal setting to make this switch happen immediately. This patch now
requires that this internal switch happen synchronously.
(WebCore::CSSFontFace::pump): Implement support for the font download
policy.
(WebCore::CSSFontFace::load): Ditto.
(WebCore::CSSFontFace::font): Ditto.

  • css/CSSFontFace.h: Ditto.
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadingFontSoon): Implement support for
synchronous font download timeouts.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontRanges): Implement support for the
font download policy.

  • platform/graphics/Font.cpp: Add new flag which represents if the

interstitial font was created after the 3 second timeout or before.
Previously, we would distinguish between these two cases by knowing
that one font was LastResort and the other font was a fallback. Now that
we're using fallback fonts on both sides of the 3 second timeout, we
now no longer know which one should be invisible. This new enum solves
this problem.
(WebCore::Font::Font):
(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):

  • platform/graphics/Font.h: Ditto.

(WebCore::Font::create):
(WebCore::Font::origin):
(WebCore::Font::visibility):

  • platform/graphics/FontCache.h:
  • platform/graphics/FontCascade.cpp: We try to fall back to a local() font

during downloads, but there might not be one that we can use. Therefore, we
can't use the presence of the interstitial font to detect if we should paint
invisibly. Instead, we can move this logic into the font-specific part of
painting, and consult with the specific font to know if it was created from
a timed-out @font-face rule or not.
(WebCore::FontCascade::drawText):
(WebCore::shouldDrawIfLoading):
(WebCore::FontCascade::drawGlyphBuffer):
(WebCore::FontCascade::drawEmphasisMarks):

  • platform/graphics/FontCascade.h:
  • platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForVariant): Implement the logic
described above where we switch the policy if we encounter the intestitial
font.
(WebCore::FontCascadeFonts::glyphDataForNormalVariant): Ditto.
(WebCore::glyphPageFromFontRanges): Ditto.

  • platform/graphics/FontRanges.cpp: Implement support for the font download

policy.
(WebCore::FontRanges::Range::font):
(WebCore::FontRanges::glyphDataForCharacter):
(WebCore::FontRanges::fontForCharacter):
(WebCore::FontRanges::fontForFirstRange):

  • platform/graphics/FontRanges.h:
  • platform/graphics/FontSelector.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::lastResortFallbackFontForEveryCharacter): Deleted.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::lastResortFallbackFontForEveryCharacter): Deleted.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::lastResortFallbackFontForEveryCharacter): Deleted.

LayoutTests:

  • fast/text/font-download-font-face-src-list-expected.txt: Added.
  • fast/text/font-download-font-face-src-list.html: Copied from LayoutTests/fast/text/font-weight-download-2.html.
  • fast/text/font-download-font-family-property-expected.txt: Added.
  • fast/text/font-download-font-family-property.html: Copied from LayoutTests/fast/text/font-weight-download-2.html.
  • fast/text/font-download-remote-fallback-all-expected.txt: Added.
  • fast/text/font-download-remote-fallback-all.html: Copied from LayoutTests/fast/text/font-weight-download-2.html.
  • fast/text/font-interstitial-invisible-width-while-loading-expected.txt: Added.
  • fast/text/font-interstitial-invisible-width-while-loading.html: Added.
  • fast/text/font-weight-download-2.html:
  • fast/text/font-weight-download-3-expected.txt: Added.
  • fast/text/font-weight-download-3.html: Copied from LayoutTests/fast/text/font-weight-download-2.html.
  • fast/text/web-font-load-fallback-during-loading-2-expected.html: Added.
  • fast/text/web-font-load-fallback-during-loading-2.html: Added.
  • fast/text/web-font-load-fallback-during-loading-expected.html:
  • fast/text/web-font-load-fallback-during-loading.html:
  • fast/text/web-font-load-invisible-during-loading-expected.txt: Added.
  • fast/text/web-font-load-invisible-during-loading.html: Added.
  • http/tests/webfont/fallback-font-while-loading-expected.txt:
  • http/tests/webfont/fallback-font-while-loading.html:
12:54 PM Changeset in webkit [216943] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[WK2][macOS] Support Flash Player DRM features
​https://bugs.webkit.org/show_bug.cgi?id=172157
<rdar://problem/31889297>

Reviewed by Dean Jackson.

Relax the IOKit whitelist to support DRM features needed by
some websites.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
12:36 PM Changeset in webkit [216942] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Another build fix. Added a missing null check.

  • public/v3/components/custom-analysis-task-configurator.js:

(CustomAnalysisTaskConfigurator.prototype._setUploadedFilesIfEmpty):

12:09 PM Changeset in webkit [216941] by Brent Fulgham
  • 5 edits in trunk/Source/WebKit2

[WK2][macOS] Adopt a whitelist for XPC services
​https://bugs.webkit.org/show_bug.cgi?id=172151
<rdar://problem/31916325>

Reviewed by Alex Christensen.

  • DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
12:01 PM Changeset in webkit [216940] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Move setCollapedWhitespaceWidth call to updateLineConstrains.
​https://bugs.webkit.org/show_bug.cgi?id=172178

Reviewed by Antti Koivisto.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::createLineRuns):

11:43 AM Changeset in webkit [216939] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.21.4

Tag Safari-604.1.21.4.

11:27 AM Changeset in webkit [216938] by eric.carlson@apple.com
  • 4 edits
    2 adds
    2 deletes in trunk

[MediaStream] Return default device list until user gives permission to capture
​https://bugs.webkit.org/show_bug.cgi?id=172168
<rdar://problem/31816884>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/media-devices-enumerate-devices.html

  • Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::filterDeviceList): Remove all but the "default" number of
devices of each type.
(WebCore::MediaDevicesRequest::start): Call filterDeviceList.

  • Modules/mediastream/MediaDevicesRequest.h:

LayoutTests:

  • fast/mediastream/MediaDevices-enumerateDevices-expected.txt: Removed.
  • fast/mediastream/MediaDevices-enumerateDevices.html: Removed.
  • fast/mediastream/media-devices-enumerate-devices-expected.txt: Added.
  • fast/mediastream/media-devices-enumerate-devices.html: Added.
11:18 AM Changeset in webkit [216937] by Claudio Saavedra
  • 4 edits in trunk/Source/WebCore

Silent a few warnings about unused parameters
​https://bugs.webkit.org/show_bug.cgi?id=172169

Reviewed by Sam Weinig.

  • page/Page.cpp:

(WebCore::Page::mainFrameLoadStarted):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toData):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::partitionName):

10:52 AM Changeset in webkit [216936] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

WebItemProviderPasteboard should be robust when temporary files are missing path extensions
​https://bugs.webkit.org/show_bug.cgi?id=172170

Reviewed by Tim Horton.

Makes a slight adjustment to the temporary file URLs are handled when using WebItemProviderPasteboard to load
data off of item providers. Previously, we would bail early and not load any data if the temporary URL is
missing an extension. Since the switch to NSItemProviders from UIItemProviders, some types of temporary files
generated by item providers are missing extensions, so this extra check is meaningless.

Covered by existing data interaction unit tests.

  • platform/ios/WebItemProviderPasteboard.mm:

(temporaryFileURLForDataInteractionContent):
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):

10:20 AM Changeset in webkit [216935] by timothy_horton@apple.com
  • 6 edits in trunk

Make it possible to adjust which edges are affected by safe area insets
​https://bugs.webkit.org/show_bug.cgi?id=172149
<rdar://problem/31564729>

Reviewed by Beth Dakin.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _computedContentInset]):
(-[WKWebView _obscuredInsetEdgesAffectedBySafeArea]):
(-[WKWebView _setObscuredInsetEdgesAffectedBySafeArea:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add SPI to adjust which edges are taken into account, and adjust the default.

  • fast/viewport/ios/viewport-fit-auto-expected.txt:
  • fast/viewport/ios/viewport-fit-contain-expected.txt:
10:12 AM Changeset in webkit [216934] by mark.lam@apple.com
  • 3 edits in trunk/LayoutTests

Gardening: rebased parser-syntax-check test results after r216891.
​https://bugs.webkit.org/show_bug.cgi?id=172171

Not reviewed.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
9:19 AM Changeset in webkit [216933] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip LayoutTest media/restricted-audio-playback-with-document-gesture.html on iOS.

Unreviewed test gardening.

  • platform/ios/TestExpectations:
8:30 AM Changeset in webkit [216932] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

Patch

8:08 AM Changeset in webkit [216931] by Claudio Saavedra
  • 9 edits in trunk

[GTK] Tests that always pass when run alone, but fail in the bots
​https://bugs.webkit.org/show_bug.cgi?id=168572

Reviewed by Michael Catanzaro.

PlatformWebView::viewSupportsOptions() is basically a comparison
that checks that the passed options are the ones supported by the
web view. There is no reason for them to be implemented for each
platform differently. In fact doing so causes issues each time a
new option is added, if the corresponding platform implementation
is not updated accordingly.

A consequence of not updating the viewSupportOptions()
implementations when new options are added is that tests that need
these options might fail if they are executed after a test that
didn't need the option, as the webview will be reused even if the
option is not supported. This cannot be spotted when running the
tests individually. See bug #165133 for other example of the same
problem.

Remove the platform implementations and make the comparison a
method of the TestOptions structure, so that the check is in one
Tools:

place. For the time being, only include in the comparison the
options that were checked in the mac platform, which seem to be
the only ones relevant this far (unless newer ones have also been
forgotten).

  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::viewSupportsOptions): Use the method
defined below.

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions): Added.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::viewSupportsOptions): Deleted.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::viewSupportsOptions): Deleted.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::viewSupportsOptions): Deleted.

  • WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::viewSupportsOptions): Deleted.

LayoutTests:

place. For the time being include in the comparison the options
checked in the mac and ios platforms, which seem to be the only
ones relevant this far (unless newer ones have also been
forgotten).

  • platform/gtk/TestExpectations: Unskip an affected test.
6:04 AM Changeset in webkit [216930] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[WPE] GLContextEGL::createWPEContext() should fall back to pbuffer-based contexts when offscreen target provides no native window
​https://bugs.webkit.org/show_bug.cgi?id=172162

Reviewed by Carlos Garcia Campos.

When creating an offscreen GLContext, the underlying implementation might
provide a mock native window that's to be used as the window target upon
which a window-based GLContext should be created. But we should also support
falling back to pbuffer-based GLContexts when the underlying implementation
can't provide such mock targets.

  • platform/graphics/egl/GLContextEGLWPE.cpp:

(WebCore::GLContextEGL::createWPEContext):

5:57 AM Changeset in webkit [216929] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GLib] Use RunLoopSourcePriority::RunLoopDispatcher as the GSocketMonitor's GSource priority
​https://bugs.webkit.org/show_bug.cgi?id=172160

Reviewed by Carlos Garcia Campos.

  • Platform/IPC/glib/GSocketMonitor.cpp:

(IPC::GSocketMonitor::start): Explicitly set the priority for the GSocketMonitor's
GSource object to RunLoopSourcePriority::RunLoopDispatcher, equating it to the
priority that's used in RunLoop for dispatches of the queued functions.

5:51 AM Changeset in webkit [216928] by zandobersek@gmail.com
  • 2 edits in trunk

[WPE] Set and expose ENABLE_DEVELOPER_MODE in build when DEVELOPER_MODE is enabled
​https://bugs.webkit.org/show_bug.cgi?id=172159

Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsWPE.cmake: Expose the ENABLE_DEVELOPER_MODE macro

when the DEVELOPER_MODE configuration options is enabled.

5:49 AM Changeset in webkit [216927] by zandobersek@gmail.com
  • 6 edits in trunk/Source

[GLib] Name more GSource-based RunLoop::Timers
​https://bugs.webkit.org/show_bug.cgi?id=172158

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • platform/glib/MainThreadSharedTimerGLib.cpp:

(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
Specify 'MainThreadSharedTimer' as the name of this GSource-based RunLoop::Timer.

Source/WebKit2:

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
Specify 'CompositingRunLoop' as the name of this GSource-based RunLoop::Timer.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
Specify 'ThreadedDisplayRefreshMonitor' as the name of this GSource-based RunLoop::Timer.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
Specify 'CoordinatedLayerTreeHost' as the name of this GSource-based RunLoop::Timer.

5:47 AM Changeset in webkit [216926] by commit-queue@webkit.org
  • 9 edits in trunk

[Readable Streams API] Implement ReadableStreamBYOBReader releaseLock()
​https://bugs.webkit.org/show_bug.cgi?id=172111

Patch by Romain Bellessort <​romain.bellessort@crf.canon.fr> on 2017-05-16
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Updated test expectations.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated.
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated.

Source/WebCore:

Implemented ReadableStreamBYOBReader releaseLock():

Added tests to check releaseLock behavior.

  • Modules/streams/ReadableStreamBYOBReader.js:

(releaseLock): Implemented.

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamReaderGenericRelease): Aligned with spec.

LayoutTests:

Added tests to check releaseLock() behavior.

  • streams/readable-stream-byob-reader-expected.txt: Updated.
  • streams/readable-stream-byob-reader.js: Added new tests.
3:32 AM Changeset in webkit [216925] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed Windows gardening. Skip svg animation test, since image throttling behaves differently on WK1.

  • platform/win/TestExpectations:
2:40 AM Changeset in webkit [216924] by Yusuke Suzuki
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

Unreviewed, add Objective C files to CMake Mac port
​https://bugs.webkit.org/show_bug.cgi?id=172103

  • shell/PlatformMac.cmake: Added.
2:37 AM Changeset in webkit [216923] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Revert change committed by mistakle in r216922.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::forceRepaint):

2:35 AM Changeset in webkit [216922] by Carlos Garcia Campos
  • 7 edits in trunk

Unreviewed GTK+ gardening. Rebaseline tests after r216817.

  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/client-rects-spanners-complex-expected.txt:
  • platform/gtk/fast/multicol/client-rects-spanners-expected.txt:
  • platform/gtk/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt:
2:24 AM Changeset in webkit [216921] by jfbastien@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

WebAssembly: enforce size limits
​https://bugs.webkit.org/show_bug.cgi?id=165833
<rdar://problem/29760219>

Reviewed by Keith Miller.

Use the same limits as V8.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wasm/WasmLimits.h: Added.
  • wasm/WasmModuleParser.cpp:
  • wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):

2:10 AM Changeset in webkit [216920] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Try to fix GTK+ build with MEDIA_STREAM enabled after r216918.

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):

1:53 AM Changeset in webkit [216919] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several WebRTC tests.

  • platform/gtk/TestExpectations:
1:51 AM Changeset in webkit [216918] by commit-queue@webkit.org
  • 34 edits
    2 deletes in trunk/Source

Remove MediaConstraintsData and MediaConstraintsImpl
​https://bugs.webkit.org/show_bug.cgi?id=172132

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-16
Reviewed by Eric Carlson.

Source/WebCore:

No observable change of behavior.

Removing MediaConstraintsData and MediaConstraintsImpl allows simplifying the code.
Further simplified the code by making MediaConstraints no longer ref counted and now a struct.
Simplified some RealtimeMediaSource subclasses by removing unused MediaConstraints class members.

  • CMakeLists.txt: Removing MediaConstraintsImpl.cpp.
  • Modules/mediastream/MediaConstraintsImpl.cpp: Removed.
  • Modules/mediastream/MediaConstraintsImpl.h: Removed.
  • Modules/mediastream/MediaDevices.cpp:

(WebCore::createMediaConstraints):
(WebCore::MediaDevices::getUserMedia):
(WebCore::createMediaConstraintsImpl): Deleted.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::createMediaConstraints):
(WebCore::MediaStreamTrack::applyConstraints):
(WebCore::createMediaConstraintsImpl): Deleted.

  • Modules/mediastream/MediaTrackConstraints.cpp:

(WebCore::createMediaConstraints):
(WebCore::createMediaConstraintsImpl): Deleted.

  • Modules/mediastream/MediaTrackConstraints.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::allow):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaConstraints.cpp:

(WebCore::addDefaultVideoConstraints):
(WebCore::MediaConstraints::isConstraintSet):
(WebCore::MediaConstraints::setDefaultVideoConstraints):

  • platform/mediastream/MediaConstraints.h:

(WebCore::MediaConstraints::~MediaConstraints): Deleted.
(WebCore::MediaConstraints::MediaConstraints): Deleted.

  • platform/mediastream/MediaStreamConstraintsValidationClient.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::selectSettings):
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::supportedConstraints): Deleted.

  • platform/mediastream/mac/RealtimeIncomingAudioSource.h:
  • platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::supportedConstraints): Deleted.

  • platform/mediastream/mac/RealtimeIncomingVideoSource.h:
  • platform/mock/MockRealtimeMediaSource.h:

(WebCore::MockRealtimeMediaSource::constraints): Deleted.

Source/WebKit2:

Removing MediaConstraintsData and MediaConstraintsImpl allows simplifying the code.
Further simplified the code by making MediaConstraints no longer ref counted and now a struct.

  • Scripts/webkit/messages.py:

(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraints>::encode):
(IPC::ArgumentCoder<MediaConstraints>::decode):
(IPC::ArgumentCoder<MediaConstraintsData>::encode): Deleted.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::sendUserMediaRequest):

  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::applyConstraints):

1:03 AM Changeset in webkit [216917] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[Cocoa] Tell NEFilterSource about the presenting app's PID
​https://bugs.webkit.org/show_bug.cgi?id=172152
<rdar://problem/32197740>

Reviewed by Dan Bernstein.

  • platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::initialize):

  • platform/spi/cocoa/NEFilterSourceSPI.h:
12:50 AM Changeset in webkit [216916] by Manuel Rego Casasnovas
  • 4 edits in trunk

[css-grid] Fix static position of positioned grid items
​https://bugs.webkit.org/show_bug.cgi?id=172108

Reviewed by Sergio Villar Senin.

Source/WebCore:

This patch makes us follow the text on the spec
(​https://drafts.csswg.org/css-grid/#static-position):
"The static position of an absolutely-positioned child

of a grid container is determined as if it were the sole grid item
in a grid area whose edges coincide with the padding edges
of the grid container."

Test: fast/css-grid-layout/absolute-positioning-grid-container-parent.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::prepareChildForPositionedLayout): Modified to avoid
including padding to match the spec behavior.

LayoutTests:

The test is updated as the expected results were wrong.
Note that after this patch we match Chrome and Firefox behavior on this test.

  • fast/css-grid-layout/absolute-positioning-grid-container-parent.html:
12:44 AM Changeset in webkit [216915] by Michael Catanzaro
  • 3 edits in trunk/Source/WebKit2

[SOUP] Remove LATEST_RECORD_VERSION from GnuTLS priority string
​https://bugs.webkit.org/show_bug.cgi?id=172153

Based on discussion with Nikos in ​https://bugzilla.gnome.org/show_bug.cgi?id=782218, we
should remove LATEST_RECORD_VERSION from our GnuTLS priority string. This causes GnuTLS to
use the latest TLS record version (the record format is separate from the TLS protocol
version), which we needed a couple years ago (after dropping SSLv3) for maximum
compatibility with broken web servers. But it's not needed anymore, and is causing new
compatibility problems with other broken web servers, so let's get rid of it.

Reviewed by Carlos Garcia Campos.

  • NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

  • WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

12:27 AM Changeset in webkit [216914] by Yusuke Suzuki
  • 15 edits in trunk

[JSC] Build testapi in non Apple ports
​https://bugs.webkit.org/show_bug.cgi?id=172103

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch makes JSC testapi buildable in non-Apple ports.
We isolate CF related tests in testapi.c. If we do not use
CF, we include JavaScript.h instead of JavaScriptCore.h.

By running the testapi in Linux, we found that contraints
test have a bug: If constraint marker runs after WeakRefs
are destroyed, it accesses destroyed WeakRef. This patch
also fixes it.

  • API/tests/CurrentThisInsideBlockGetterTest.h:
  • API/tests/CustomGlobalObjectClassTest.c:
  • API/tests/ExecutionTimeLimitTest.cpp:
  • API/tests/FunctionOverridesTest.cpp:
  • API/tests/GlobalContextWithFinalizerTest.cpp:
  • API/tests/JSObjectGetProxyTargetTest.cpp:
  • API/tests/MultithreadedMultiVMExecutionTest.cpp:
  • API/tests/PingPongStackOverflowTest.cpp:
  • API/tests/TypedArrayCTest.cpp:
  • API/tests/testapi.c:

(assertEqualsAsCharactersPtr):
(markingConstraint):
(testMarkingConstraintsAndHeapFinalizers):
(testCFStrings):
(main):

  • shell/CMakeLists.txt:

Tools:

Now testapi is drived in JSCOnly, GTK and WPE ports too.

  • Scripts/build-jsc:
  • Scripts/run-javascriptcore-tests:
12:23 AM Changeset in webkit [216913] by jfbastien@apple.com
  • 1 edit
    1 add in trunk/JSTests

WebAssembly: add memory fuzzer
​https://bugs.webkit.org/show_bug.cgi?id=169976
<rdar://problem/31965328>

Reviewed by Keith Miller.

  • wasm/fuzz/memory.js: Added.

(const.insert):
(const.action.string_appeared_here):
(const.performAction):
(catch):

12:11 AM Changeset in webkit [216912] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Compile error, include file is not found.
​https://bugs.webkit.org/show_bug.cgi?id=172105

Reviewed by Brent Fulgham.

Use has_include to detect if include file exists.

  • platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm:
12:09 AM Changeset in webkit [216911] by jfbastien@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WebAssembly: report Memory usage to GC
​https://bugs.webkit.org/show_bug.cgi?id=170690
<rdar://problem/31965310>

Reviewed by Keith Miller.

  • wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::grow):
(JSC::JSWebAssemblyMemory::finishCreation):
(JSC::JSWebAssemblyMemory::visitChildren):

12:07 AM Changeset in webkit [216910] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216893. rdar://problem/32082745

12:07 AM Changeset in webkit [216909] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216790. rdar://problem/32082745

12:07 AM Changeset in webkit [216908] by jfbastien@apple.com
  • 8 edits in trunk

WebAssembly: validate load / store alignment
​https://bugs.webkit.org/show_bug.cgi?id=168836
<rdar://problem/31965349>

Reviewed by Keith Miller.

JSTests:

  • wasm/WASM.js: fix regular expression greed
  • wasm/function-tests/memory-alignment.js: Added.

(const.op.of.WASM.opcodes):

  • wasm/wasm.json: fix formatting

Source/JavaScriptCore:

  • wasm/WasmFunctionParser.h: check the alignment
  • wasm/generateWasm.py: generate the log2 alignment helper

(Wasm):
(isSimple):
(memoryLog2Alignment):

  • wasm/generateWasmOpsHeader.py:

(memoryLog2AlignmentGenerator):

  • wasm/wasm.json: fix formatting

May 15, 2017:

11:19 PM Changeset in webkit [216907] by matthew_hanson@apple.com
  • 15 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216882. rdar://problem/32109397

11:19 PM Changeset in webkit [216906] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216863. rdar://problem/31963192

11:19 PM Changeset in webkit [216905] by matthew_hanson@apple.com
  • 39 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216836. rdar://problem/31899730

11:19 PM Changeset in webkit [216904] by matthew_hanson@apple.com
  • 8 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216323. rdar://problem/31899730

11:06 PM Changeset in webkit [216903] by aestes@apple.com
  • 17 edits
    1 move
    1 add in trunk/Source

Make the application PID available to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=172133

Reviewed by Andreas Kling.

Source/WebCore:

  • CMakeLists.txt:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/RuntimeApplicationChecks.cpp: Added.

(WebCore::presentingApplicationPIDOverride):
(WebCore::presentingApplicationPID): Returns the override PID if set, or getCurrentProcessID()
otherwise.
(WebCore::setPresentingApplicationPID):

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm: Renamed from Source/WebCore/platform/RuntimeApplicationChecks.mm.

Source/WebKit2:

Added uiProcessPID to Web and Networking process creation parameters. The UI process
initializes these to getpid(), and the child processes call WebCore::setPresentingApplicationPID()
at initialization time.

This replaces presenterApplicationPid.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::presenterApplicationPid): Deleted.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

10:35 PM Changeset in webkit [216902] by Antti Koivisto
  • 37 edits in trunk/Source

RenderTheme does not need to be per-page
​https://bugs.webkit.org/show_bug.cgi?id=172116
<rdar://problem/30426457>

Reviewed by Zalan Bujtas.

There are no implementations of RenderTheme::themeForPage that actually care about the page.
It can be replaced with a singleton, simplifying a bunch of code.

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shadowRootCSSText):
(WebCore::MediaControlsHost::base64StringForIconNameAndType):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

Fix a potential crash if we get here when page is null (though it doesn't appear to repro on trunk).

  • css/StyleColor.cpp:

(WebCore::StyleColor::colorFromKeyword):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSystemColor):

  • css/parser/CSSParser.h:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeSystemFont):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createElementRenderer):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::usesMenuList):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::adjustInnerTextStyle):

  • html/InputType.cpp:

(WebCore::InputType::themeSupportsDataListUI):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::shouldHaveCapsLockIndicator):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):

  • html/canvas/CanvasStyle.cpp:

(WebCore::parseColor):
(WebCore::parseColorOrCurrentColor):
(WebCore::CanvasStyle::createFromString):

  • html/canvas/CanvasStyle.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startTimer):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::reset):
(WebCore::MediaControls::reportedError):
(WebCore::MediaControls::updateCurrentTimeDisplay):

  • html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::tryCreate):

  • page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::theme): Deleted.

  • platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::theme):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::focusRingColor):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::defaultTheme): Deleted.

  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

  • rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):

10:14 PM Changeset in webkit [216901] by commit-queue@webkit.org
  • 32 edits in trunk

Do not delete asynchronously decoded frames for large images if their clients are in the viewport
​https://bugs.webkit.org/show_bug.cgi?id=170640

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-05-15
Reviewed by Simon Fraser.

Source/WebCore:

The image flickering problem happens when a large image is visible in the
view port and for some reason, the decoded frame gets destroyed. When this
image is repainted, BitmapImage::draw() does not find a valid decoded frame
for that image. It then requests an async decoding for the image and just
draws nothing in the image rectangle. Drawing no content between two drawing
phases in which the image is drawn causes the unwanted flickering.

To fix this issue we need to protect the decoded frames of all the images
in the view port from being destroyed. When BitmapImage::destroyDecodedData()
is called, it is going to check, through the ImageObserver, whether any
of its clients is visible. And if so, the current decoded frame won't be
destroyed.

Tests: Modifying existing tests.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImageObserver::decodedSizeChanged):
(WebCore::CachedImage::CachedImageObserver::didDraw):
(WebCore::CachedImage::CachedImageObserver::canDestroyDecodedData):
(WebCore::CachedImage::CachedImageObserver::imageFrameAvailable):
(WebCore::CachedImage::CachedImageObserver::changedInRect):
(WebCore::CachedImage::decodedSizeChanged):
(WebCore::CachedImage::didDraw):
(WebCore::CachedImage::canDestroyDecodedData): Finds out whether it's okay
to discard the image decoded data or not.
(WebCore::CachedImage::imageFrameAvailable):
(WebCore::CachedImage::changedInRect):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedImageClient.h:

(WebCore::CachedImageClient::canDestroyDecodedData):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::destroyDecodedDataForAllImages): This function is
currently not used. Use in the internal destroyDecodedDataForAllImages()
but unlike what CachedImage::destroyDecodedData() does, make it destroy
the decoded frames without deleting the image itself.

  • loader/cache/MemoryCache.h:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::canDestroyCurrentFrameDecodedData):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::packImageData):

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::decodedSizeChanged):
(ImageFrameCache::cacheAsyncFrameNativeImageAtIndex): The assertion in this
function is wrong. frameIsCompleteAtIndex() can be false when the an image
decoding is requested but can be true when the decoding finishes.

  • platform/graphics/ImageObserver.h:
  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::frameIsCompleteAtIndex):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::decodedSizeChanged):
(WebCore::PDFDocumentImage::draw):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):

  • platform/graphics/win/ImageDirect2D.cpp:

(WebCore::Image::drawPattern):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::isVisibleInDocumentRect):
(WebCore::RenderElement::isVisibleInViewport):
(WebCore::RenderElement::imageFrameAvailable):
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
(WebCore::RenderElement::shouldRepaintInVisibleRect): Deleted. Function
is renamed to isVisibleInViewport() for better readability.

  • rendering/RenderElement.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

  • svg/graphics/SVGImageClients.h:
  • testing/Internals.cpp:

(WebCore::Internals::destroyDecodedDataForAllImages):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/mac:

Enable the async decoding for large images.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Enable the async decoding for large images.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

  • fast/images/async-image-background-image-repeated.html:
  • fast/images/async-image-background-image.html:
  • fast/images/sprite-sheet-image-draw.html:
8:41 PM Changeset in webkit [216900] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

WPT test importer should not account for slow manual tests
​https://bugs.webkit.org/show_bug.cgi?id=172127

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-15
Reviewed by Ryosuke Niwa.

Making sure manual tests are not triggering updating tests-options.json file.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):
(TestImporter._already_identified_as_resource_file):
(TestImporter.update_tests_options):

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(test_manual_slow_test):

8:19 PM Changeset in webkit [216899] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
​https://bugs.webkit.org/show_bug.cgi?id=172142

Reviewed by Tim Horton.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
around runtime identifiers.

  • Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
7:45 PM Changeset in webkit [216898] by commit-queue@webkit.org
  • 30 edits in trunk/Source

Simplify RealtimeMediaSource data production and state
​https://bugs.webkit.org/show_bug.cgi?id=171999

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-15
Reviewed by Eric Carlson.

Source/WebCore:

RealtimeMediaSource takes 3 booleans:

  • m_isProducingData tells whether data is produced or not. In the case of capturing, it tells whether capture happens.
  • m_muted/m_enabled allows JS or WebKit level to start/stop the source.

Changed MediaStream capture state computation so that capture is reported as follows:

  • m_isProducing is true, capture is happenning and is active
  • m_muted is true, capture is happening but is inactive.

Except in the case of WebRTC incoming sources, for which sources may be created as muted as per the spec,
all sources are unmuted, enabled and not producing data when created.

RealtimeMediaSource is now activable either by calling start/stop or by calling setMuted/setEnabled.
This in turns will set the boolean values accordingly and will call the underlying
startProducingData/stopProducingData methods doing the actual stuff.

Removing from all RealtimeMediaSource subclasses the handling of producing data.
Making more methods non-virtual/member fields private to simplify the model.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::create):
(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::stopProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDestroyed):
(WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas):

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState):

  • platform/mediastream/MediaStreamTrackPrivate.h:

(WebCore::MediaStreamTrackPrivate::startProducingData):
(WebCore::MediaStreamTrackPrivate::stopProducingData):

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::notifyMutedChange):
(WebCore::RealtimeMediaSource::setEnabled):
(WebCore::RealtimeMediaSource::start):
(WebCore::RealtimeMediaSource::stop):
(WebCore::RealtimeMediaSource::requestStop):
(WebCore::RealtimeMediaSource::reset): Deleted.

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::AVMediaCaptureSource):
(WebCore::AVMediaCaptureSource::captureSessionIsRunningDidChange):
(WebCore::AVMediaCaptureSource::reset): Deleted.
(WebCore::AVMediaCaptureSource::isProducingData): Deleted.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::startProducingData):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSource::audioSourceProvider):

  • platform/mediastream/mac/CoreAudioCaptureSource.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::render):
(WebCore::MockRealtimeAudioSource::createMuted): Deleted.

  • platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSource::createMuted): Deleted.

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::create):
(WebCore::RealtimeIncomingAudioSource::RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::~RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::startProducingData):
(WebCore::RealtimeIncomingAudioSource::stopProducingData):
(WebCore::RealtimeIncomingAudioSource::setSourceTrack):

  • platform/mediastream/mac/RealtimeIncomingAudioSource.h:
  • platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::create):
(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
(WebCore::RealtimeIncomingVideoSource::startProducingData):
(WebCore::RealtimeIncomingVideoSource::setSourceTrack):
(WebCore::RealtimeIncomingVideoSource::stopProducingData):
(WebCore::RealtimeIncomingVideoSource::OnFrame):

  • platform/mediastream/mac/RealtimeIncomingVideoSource.h:
  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::setClient):

  • platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::createMutedRemoteSource):
(WebCore::MockMediaEndpoint::unmuteTimerFired):

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::createMuted):
(WebCore::MockRealtimeAudioSource::startProducingData):
(WebCore::MockRealtimeAudioSource::stopProducingData):

  • platform/mock/MockRealtimeAudioSource.h:
  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::startProducingData): Deleted.
(WebCore::MockRealtimeMediaSource::stopProducingData): Deleted.

  • platform/mock/MockRealtimeMediaSource.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::createMuted):
(WebCore::MockRealtimeVideoSource::startProducingData):
(WebCore::MockRealtimeVideoSource::stopProducingData):
(WebCore::MockRealtimeVideoSource::generateFrame):

  • platform/mock/MockRealtimeVideoSource.h:

Source/WebKit2:

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):

  • WebProcess/cocoa/UserMediaCaptureManager.cpp:
6:59 PM Changeset in webkit [216897] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/Websites/browserbench.org

browserbench.org/Speedometer/ should show the benchmark not an index of files
​https://bugs.webkit.org/show_bug.cgi?id=172141

Reviewed by Alexey Proskuryakov.

Renamed Speedometer/Full.html to Speedometer/index.html.
We used to have a .htaccess but it's better to use the same file name convention as other benchmarks.

  • Speedometer/index.html: Renamed from Websites/browserbench.org/Speedometer/Full.html.
6:37 PM Changeset in webkit [216896] by mmaxfield@apple.com
  • 14 edits in trunk/Source/WebCore

Migrate Font constructor from bools to enums
​https://bugs.webkit.org/show_bug.cgi?id=172140

Reviewed by Tim Horton.

In ​https://bugs.webkit.org/show_bug.cgi?id=168487, I'm adding a new flag to Font. We can't
keep having just a pile of bools in this class. Instead, we should be using enums.

No new tests because there is no behavior change.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::font):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • css/CSSSegmentedFontFace.cpp:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::createFont):

  • platform/graphics/Font.cpp:

(WebCore::Font::Font):
(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::description):
(WebCore::Font::mathData):

  • platform/graphics/Font.h:

(WebCore::Font::create):
(WebCore::Font::origin):
(WebCore::Font::isInterstitial):
(WebCore::Font::widthForGlyph):
(WebCore::Font::isCustomFont): Deleted.
(WebCore::Font::isLoading): Deleted.

  • platform/graphics/FontRanges.cpp:
  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformCreateScaledFont):

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::Font::platformInit):

  • platform/graphics/win/SimpleFontDataDirect2D.cpp:

(WebCore::Font::platformInit):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::Font::platformCreateScaledFont):
(WebCore::Font::determinePitch):

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForFontAndText):

6:29 PM Changeset in webkit [216895] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

bmalloc: Bump the size of the deallocator log to 512
​https://bugs.webkit.org/show_bug.cgi?id=172143

Reviewed by Michael Saboff.

This is a speedup on parallel workloads for machines with lots of CPUs.

  • bmalloc/Sizes.h:
5:58 PM Changeset in webkit [216894] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] [l10n] Updated French translation for Webkit/GTK
​https://bugs.webkit.org/show_bug.cgi?id=172093

Patch by Alexandre Franke <​afranke@gnome.org> on 2017-05-15
Rubber-stamped by Michael Catanzaro.

  • fr.po:
5:50 PM Changeset in webkit [216893] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

Correct typo (part of r216790).

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: The check-in missed part of a

regular expression needed to fix the audio playback.

5:41 PM Changeset in webkit [216892] by commit-queue@webkit.org
  • 7 edits in trunk

WebRTC outgoing muted video sources should send black frames
​https://bugs.webkit.org/show_bug.cgi?id=170627
<rdar://problem/31513869>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-15
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Instead of sending one black frame and then another one asynchronously,
we use the timer to send a black frame every second when outgoing source is muted.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingVideoSource::sourceEnabledChanged):
(WebCore::RealtimeOutgoingVideoSource::sendBlackFrames):
(WebCore::RealtimeOutgoingVideoSource::sendBlackFrame): Deleted.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
  • testing/Internals.cpp:

(WebCore::Internals::videoSampleAvailable):

LayoutTests:

  • webrtc/video-mute-expected.txt:
  • webrtc/video-mute.html:
5:21 PM Changeset in webkit [216891] by mark.lam@apple.com
  • 22 edits
    2 deletes in trunk

Rolling out r214038 and r213697: Crashes when using computed properties with rest destructuring and object spread.
​https://bugs.webkit.org/show_bug.cgi?id=172147

Rubber-stamped by Saam Barati.

JSTests:

  • stress/object-rest-deconstruct.js: Removed.
  • stress/object-spread.js: Removed.

Source/JavaScriptCore:

I rolled out every thing in those 2 patches except for the change to make
CodeBlock::finishCreation() return a bool plus its clients that depend on this.
I made this exception because r214931 relies on this change, and this part of
the change looks correct.

  • builtins/BuiltinNames.h:
  • builtins/GlobalOperations.js:

(globalPrivate.speciesConstructor):
(globalPrivate.copyDataProperties): Deleted.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters): Deleted.

  • bytecode/CodeBlock.h:
  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addBitVector):
(JSC::UnlinkedCodeBlock::constantRegisters):
(JSC::UnlinkedCodeBlock::addSetConstant): Deleted.
(JSC::UnlinkedCodeBlock::constantIdentifierSets): Deleted.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue):
(JSC::ObjectSpreadExpressionNode::emitBytecode): Deleted.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createObjectSpreadExpression): Deleted.
(JSC::ASTBuilder::appendObjectPatternRestEntry): Deleted.
(JSC::ASTBuilder::setContainsObjectRestElement): Deleted.

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):
(JSC::SpreadExpressionNode::SpreadExpressionNode):
(JSC::ObjectSpreadExpressionNode::ObjectSpreadExpressionNode): Deleted.

  • parser/Nodes.h:

(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectSpreadExpressionNode::expression): Deleted.
(JSC::ObjectPatternNode::setContainsRestElement): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseProperty):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createSpreadExpression):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):
(JSC::SyntaxChecker::createObjectSpreadExpression): Deleted.

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

Source/WTF:

  • wtf/HashSet.h:

(WTF::=):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
5:07 PM Changeset in webkit [216890] by matthew_hanson@apple.com
  • 15 edits
    3 moves in branches/safari-604.1.21-branch

Cherry-pick r216249. rdar://problem/31764764

4:54 PM Changeset in webkit [216889] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Crash in libxml2.2.dylib: xmlDictReference
<​https://webkit.org/b/172086>
<rdar://problem/23643436>

Reviewed by Daniel Bates.

Speculative fix and code clean-up based on source code
inspection. The fix for the crash is in two parts that change
XSLStyleSheet::parseString():

  1. Always set m_stylesheetDoc to nullptr after freeing it via XSLStyleSheet::clearXSLStylesheetDocument().
  2. Add nullptr check before using m_stylesheetDoc from parent.

Broadly speaking, the changes are:

  • Extract code to reset m_stylesheetDoc into new private XSLStyleSheet::clearXSLStylesheetDocument() method. There is a special contract between m_stylesheetDoc and m_stylesheetDocTaken that wasn't being followed every time. See comment in XSLStyleSheet::compileStyleSheet().
  • XSLStyleSheet::clearDocuments() now calls new clearXSLStylesheetDocument() method. Previously, it was not checking or resetting m_stylesheetDocTaken, and it might have leaked an xmlDocPtr if m_stylesheetDoc was set and m_stylesheetDocTaken was false.
  • XSLStyleSheet::parseString() now calls new clearXSLStylesheetDocument() method. Previously, it did not clear m_stylesheetDoc after freeing it, and it could return early due to a failure in xmlCreateMemoryParserCtxt().
  • In XSLStyleSheet::parseString() use checked arithmetic when calculating 'size' for xmlCreateMemoryParserCtxt() and xmlCtxtReadMemory(). This code used to do an implicit unsigned -> signed integer conversion that could overflow.
  • Always iterate m_children using an 'auto& import' variable.
  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add declaration.
(WebCore::XSLStyleSheet::m_disabled): Add default initializer.
(WebCore::XSLStyleSheet::m_stylesheetDoc): Ditto.
(WebCore::XSLStyleSheet::m_stylesheetDocTaken): Ditto.
(WebCore::XSLStyleSheet::m_parentStyleSheet): Ditto.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet): Get rid of redundant
initializers. Set m_parentStyleSheet if needed.
(WebCore::XSLStyleSheet::~XSLStyleSheet): Call
clearXSLStylesheetDocument() instead of custom code. Switch
m_children fast iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::isLoading): Switch m_children fast
iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::clearDocuments): Call
clearXSLStylesheetDocument() instead of setting m_stylesheetDoc
to nullptr. This might fix an occasional xmlDocPtr leak.
(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add. This
method always sets m_stylesheetDoc to nullptr (after freeing it
if necessary) and sets m_stylesheetDocTaken to false.
(WebCore::XSLStyleSheet::parseString): Call
clearXSLStylesheetDocument(). Prior to this, m_stylesheetDoc
might be left pointing to a freed value, and this method could
return early if xmlCreateMemoryParserCtxt() failed. Switch to
using Checked<> to compute required buffer size to parse XSL
stylesheet, and return early on overflow. Clean up existing
return statements to use boolean expressions. Add nullptr check
for m_parentStyleSheet->m_stylesheetDoc before using it.
(WebCore::XSLStyleSheet::loadChildSheet): Get rid of local
variable by calling loadSheet() from last array element.
(WebCore::XSLStyleSheet::compileStyleSheet): Add debug assert
that m_stylesheetDoc is not nullptr.

4:36 PM Changeset in webkit [216888] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline platform/ios/ios/css/construct-WebKitCSSMatrix.html after r216881.

  • platform/ios/ios/css/construct-WebKitCSSMatrix-expected.txt:
  • platform/ios/ios/css/resources/construct-WebKitCSSMatrix.js:
4:24 PM Changeset in webkit [216887] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Update ARES-6 plan file to use the latest version
​https://bugs.webkit.org/show_bug.cgi?id=172139

Reviewed by Keith Miller.

Include r216538.

  • Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3:46 PM Changeset in webkit [216886] by jer.noble@apple.com
  • 22 edits
    2 adds in trunk

Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
​https://bugs.webkit.org/show_bug.cgi?id=172131

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/restricted-audio-playback-with-document-gesture.html

Move all calls to ScriptController::processingUserGestureForMedia() to the new Document equivalent. In Document,
if the new setting is enabled, return true from processingUserGestureForMedia() if the top-level document has had
a user gesture interaction.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::processingUserGestureForMedia):

  • Modules/mediastream/MediaStream.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::processingUserGestureForMedia):
(WebCore::AudioContext::willBeginPlayback):
(WebCore::AudioContext::willPausePlayback):

  • Modules/webaudio/AudioContext.h:
  • dom/Document.cpp:

(WebCore::Document::processingUserGestureForMedia):

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::audioTrackEnabledChanged):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker):
(WebCore::HTMLMediaElement::processingUserGestureForMedia):

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
(WebCore::MediaElementSession::dataLoadingPermitted):
(WebCore::MediaElementSession::fullscreenPermitted):
(WebCore::MediaElementSession::canShowControlsManager):
(WebCore::MediaElementSession::showPlaybackTargetPicker):

  • page/Settings.in:
  • platform/audio/PlatformMediaSession.h:

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences mediaUserGestureInheritsFromDocument]):
(-[WebPreferences setMediaUserGestureInheritsFromDocument:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaUserGestureInheritsFromDocument):
(WKPreferencesGetMediaUserGestureInheritsFromDocument):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

  • media/restricted-audio-playback-with-document-gesture-expected.txt: Added.
  • media/restricted-audio-playback-with-document-gesture.html: Added.
3:40 PM Changeset in webkit [216885] by pvollan@apple.com
  • 3 edits in trunk/LayoutTests

LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

Start video playback when the 'canplaythrough' event is handled, and stop logging the event,
since the event sequence is not identical on all bots.

  • http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
  • http/tests/media/track-in-band-hls-metadata-crash.html:
3:34 PM Changeset in webkit [216884] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Only ever initialize LibWebRTCProvider's staticFactoryAndThreads() factories once.
​https://bugs.webkit.org/show_bug.cgi?id=172047

Reviewed by Youenn Fablet.

Wrap the initilization of the factories contained in staticFactoryAndThreads() in a call_once to ensure
new factories aren't created every time it's called.

  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::staticFactoryAndThreads):

3:32 PM Changeset in webkit [216883] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Web Inspector: CRASH seen with DOM.setOuterHTML when there is no documentElement
​https://bugs.webkit.org/show_bug.cgi?id=172135
<rdar://problem/32175860>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-15
Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/dom/setOuterHTML-no-document-element.html

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):
Null check the document element which might not exist.

LayoutTests:

  • inspector/dom/setOuterHTML-no-document-element-expected.txt: Added.
  • inspector/dom/setOuterHTML-no-document-element.html: Added.
3:10 PM Changeset in webkit [216882] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

REGRESSION (216471): Infinite repaint-drawing loop when asynchronously decoding incomplete image frames
​https://bugs.webkit.org/show_bug.cgi?id=171900

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-05-15
Reviewed by Tim Horton.

-- Don't destroy incomplete decoded image frames for large images. This
is to avoid flickering while decoding another image frame with the new
data. The old incomplete image frame will be destroyed once the newer one
finishes decoding.

-- Extend the enum ImageFrame::DecodingStatus by adding a new value called
'Decoding'. This new value will never be cached in the ImageFrame::
m_decodingStatus. Add a member m_currentFrameDecodingStatus to BitmapImage.
The purpose of this member is to invalidate the current frame, without
deleting it, when new encoded data is received.

-- Don't wait until the native image is decoded to cache the ImageFrame
decodingStatus. There is a big chance that more data arrives between
starting the decoding and finishing it such that the decoding changes
from Partial to Complete. We need to prevent keeping incomplete ImageFrames
cached because we mistakenly assume they are complete. To fix this issue
we need to know the ImageFrame decodingStatus when the decoding is requested.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::internalStartAnimation): At the beginning of this
function we check whether the next frame is being decoded or not and we
return DecodingActive if it is. Let's handle the second check here also
before requesting the decoding of nextFrame. We need to check whether the
nextFrame has a native image with decoded with the native size or not.
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::setDecodingStatus):
(WebCore::ImageFrame::decodingStatus):

  • platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::isInvalid):
(WebCore::ImageFrame::isPartial):
(WebCore::ImageFrame::isComplete):
(WebCore::ImageFrame::setDecoding): Deleted.
(WebCore::ImageFrame::decoding): Deleted.
(WebCore::ImageFrame::isEmpty): Deleted.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setNativeImage):
(WebCore::ImageFrameCache::cacheMetadataAtIndex):
(WebCore::ImageFrameCache::cacheNativeImageAtIndex):
(WebCore::ImageFrameCache::cacheNativeImageAtIndexAsync):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageFrameCache::stopAsyncDecodingQueue):
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded):
(WebCore::ImageFrameCache::frameDecodingStatusAtIndex):
(WebCore::ImageFrameCache::cacheFrameMetadataAtIndex): Deleted.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::frameIsCompleteAtIndex): Deleted.

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::ImageFrameRequest::operator==):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::dataChanged):

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::destroyIncompleteDecodedData):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Let the caller
decide whether another request for the same image frame is allowed or not.
(WebCore::ImageSource::frameDecodingStatusAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex): Deleted.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameDurationAtIndex):
(WebCore::ImageDecoder::createFrameImageAtIndex):

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::clearFrameBufferCache):
(WebCore::PNGImageDecoder::frameComplete):

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

3:07 PM Changeset in webkit [216881] by Chris Dumez
  • 9 edits
    2 adds in trunk

Align WebKitCSSMatrix stringifier with spec for DOMMatrix
​https://bugs.webkit.org/show_bug.cgi?id=172114

Reviewed by Simon Fraser.

Source/WebCore:

Align WebKitCSSMatrix stringifier with spec for DOMMatrix after:

The following changes were made:

  • Use EcmaScript's ToString() to convert floating point values to string
  • Throw an invalid state error if the matrix contains non-finite values
  • Made WebKitCSSMatrix.toString enumerable as per [1].

[1] ​https://heycam.github.io/webidl/#es-stringifier

Test: fast/css/matrix-stringifier.html

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString):

  • css/WebKitCSSMatrix.h:
  • css/WebKitCSSMatrix.idl:
  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::containsOnlyFiniteValues):

  • platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

  • fast/css/matrix-stringifier-expected.txt: Added.
  • fast/css/matrix-stringifier.html: Added.

Add layout test coverage.

  • fast/dom/Window/custom-constructors-expected.txt:
  • fast/dom/Window/custom-constructors.html:

Rebaseline existing test to reflect behavior change.

2:51 PM Changeset in webkit [216880] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSEnvironmentRecord::allocationSizeForScopeSize() and offsetOfVariable(ScopeOffset) should used checked arithmetic
<​https://webkit.org/b/172134>

Reviewed by Saam Barati.

  • runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::offsetOfVariable): Change to return
size_t and use checked arithmetic.
(JSC::JSEnvironmentRecord::allocationSizeForScopeSize): Change
to use checked arithmetic.

2:36 PM Changeset in webkit [216879] by jcraig@apple.com
  • 4 edits in trunk/Websites/webkit.org

AX: Inaccessible content on webkit.org main page
​https://bugs.webkit.org/show_bug.cgi?id=172106

Reviewed by Joseph Pecoraro.

  • wp-content/themes/webkit/widgets/icon.php: Resolved link title.
  • wp-content/themes/webkit/widgets/post.php: Resolved link title.
  • wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".
2:23 PM Changeset in webkit [216878] by Chris Dumez
  • 2 edits
    35 adds in trunk/LayoutTests/imported/w3c

Import css/geometry-1 web-platform-tests
​https://bugs.webkit.org/show_bug.cgi?id=172130

Reviewed by Youenn Fablet.

Import css/geometry-1 web-platform-tests to gain better test coverage.

  • resources/import-expectations.json:
  • web-platform-tests/css/geometry-1/DOMMatrix-001-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-001.html: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-002-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-002.html: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-003-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-003.html: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-a-f-alias-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-a-f-alias.html: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.html: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.js: Added.

(string_appeared_here.forEach.constr.test):
(string_appeared_here.forEach.constr.assert_equals):
(test):

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMMatrix-newobject.html: Added.
  • web-platform-tests/css/geometry-1/DOMPoint-001-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMPoint-001.html: Added.
  • web-platform-tests/css/geometry-1/DOMPoint-002-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMPoint-002.html: Added.
  • web-platform-tests/css/geometry-1/DOMQuad-001-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMQuad-001.html: Added.
  • web-platform-tests/css/geometry-1/DOMQuad-002-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMQuad-002.html: Added.
  • web-platform-tests/css/geometry-1/DOMRect-001-expected.txt: Added.
  • web-platform-tests/css/geometry-1/DOMRect-001.html: Added.
  • web-platform-tests/css/geometry-1/OWNERS: Added.
  • web-platform-tests/css/geometry-1/WebKitCSSMatrix-expected.txt: Added.
  • web-platform-tests/css/geometry-1/WebKitCSSMatrix.html: Added.
  • web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker-expected.txt: Added.
  • web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker.html: Added.
  • web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker.js: Added.

(test):

  • web-platform-tests/css/geometry-1/historical-expected.txt: Added.
  • web-platform-tests/css/geometry-1/historical.html: Added.
  • web-platform-tests/css/geometry-1/structured-serialization-expected.txt: Added.
  • web-platform-tests/css/geometry-1/structured-serialization.html: Added.
  • web-platform-tests/css/geometry-1/w3c-import.log: Added.
2:21 PM Changeset in webkit [216877] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit2

[WK2][macOS][iOS] Allow Network process to access nsurlstoraged's top level domain data cache
​https://bugs.webkit.org/show_bug.cgi?id=172128
<rdar://problem/30871490>

Reviewed by Alex Christensen.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
1:34 PM Changeset in webkit [216876] by mark.lam@apple.com
  • 15 edits in trunk

WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution().
​https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

  • runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/Options.h:
  • Added the unexpectedExceptionStackTraceLimit option.
  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before the run loop is terminated, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by changing WorkerRunLoop::Task::performTask() to check
!context->script()->isTerminatingExecution() instead of !runLoop.terminated().
Since WorkerThread::stop() always scheduleExecutionTermination() before it
terminates the run loop, !context->script()->isTerminatingExecution() implies
!runLoop.terminated().

The only time that runLoop is terminated without scheduleExecutionTermination()
being called is when WorkerThread::stop() is called before the WorkerThread has
finished creating its WorkerGlobalScope. In this scenario, WorkerThread::stop()
will still terminate the run loop. Hence, after the WorkerGlobalScope is created
(in WorkerThread::workerThread()), we will check if the run loop has been
terminated (i.e. stop() was called). If so, we'll scheduleExecutionTermination()
there, and guarantee that if runloop.terminated() is true, then
context->script()->isTerminatingExecution() is also true.

Solutions that were considered but did not work (recorded for future reference):

  1. In WorkerThread::stop(), call scheduleExecutionTermination() only after it posts the cleanup task and terminate the run loop.

This did not work because this creates a race where the worker thread may run
the cleanup task before WorkerThread::stop() finishes. As a result, the
scriptController may be deleted before we get to invoke scheduleExecutionTermination()
on it, thereby resulting in a use after free.

To make this work, we would have to change the life cycle management strategy
of the WorkerScriptController. This is a more risky change that we would
want to take on at this time, and may also not be worth the gain.

  1. Break scheduleExecutionTermination() up into 2 parts i.e. WorkerThread::stop() will:
    1. set the scriptControllers m_isTerminatingExecution flag before posting the cleanup task and terminating the run loop, and
    2. invoke VM::notifyNeedsTermination() after posting the cleanup task and terminating the run loop.

This requires that we protect the liveness of the VM until we can invoke
notifyNeedsTermination() on it.

This did not work because:

  1. We may end up destructing the VM in WorkerThread::stop() i.e. in the main web frame, but only the worker thread holds the JS lock for the VM.

We can make the WorkerThread::stop() acquire the JS lock just before it
releases the protected VM's RefPtr, but that would mean the main thread
may be stuck waiting a bit for the worker thread to release its JSLock.
This is not desirable.

  1. In practice, changing the liveness period of the Worker VM relative to its WorkerScriptController and WorkerGlobalScope also has unexpected ramifications. We observed many worker tests failing with assertion failures and crashes due to this change.

Hence, this approach is also a more risky change than it appears on the
surface, and is not worth exploring at this time.

In the end, changing WorkerRunLoop::Task::performTask() to check for
!scriptController->isTerminatingExecution() is the most straight forward solution
that is easy to prove correct.

Also fixed a race in WorkerThread::workerThread() where it can delete the
WorkerGlobalScope while WorkerThread::stop() is in the midst of accessing it.
We now guard the the nullifying of m_workerGlobalScope with the
m_threadCreationAndWorkerGlobalScopeMutex as well.

UPDATE: the only new thing in this patch for re-landing (vs one previously landed)
is that instead of nullifying m_workerGlobalScope directly (thereby deleting the
WorkerGlobalScope context), we'll swap it out and delete it only after we've
unlocked the m_threadCreationAndWorkerGlobalScopeMutex. This is needed because
the destruction of the WorkerGlobalScope will cause the main thread to race against
the worker thread to delete the WorkerThread object, and the WorkerThread object
owns the mutex that we need to unlock after nullifying the m_workerGlobalScope
field.

This issue is covered by an existing test that I just unskipped in TestExpectations.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

  • Added a check to do nothing and return early if the scriptController is already terminating execution.
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):

  • workers/WorkerRunLoop.h:
  • Made Task::performTask() private and make Task befriend the WorkerRunLoop class. This ensures that only the WorkerRunLoop may call performTask(). Note: this change only formalizes and hardens a relationship that was already in place before this.
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:
  • Renamed m_threadCreationMutex to m_threadCreationAndWorkerGlobalScopeMutex so that it more accurately describes what it guards.

LayoutTests:

1:20 PM Changeset in webkit [216875] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebKit2

Update json.hpp to v2.1.1
<​https://webkit.org/b/172085>
<rdar://problem/32180980>

Reviewed by Alex Christensen.

  • NetworkProcess/capture/NetworkCaptureEvent.cpp:
  • Define JSON_NOEXCEPTION as 1 to disable exceptions in json.hpp.

(WebKit::NetworkCapture::JSONCoder<String>::encode):
(WebKit::NetworkCapture::JSONCoder<WebCore::SharedBuffer>::encode):

  • Build std::string passing in length to avoid the need for a custom basic_json() constructor, and for efficiency.
  • NetworkProcess/capture/json.hpp:
  • Update to v2.1.1 and remove customizations.
1:16 PM Changeset in webkit [216874] by mmaxfield@apple.com
  • 4 edits
    4 adds in trunk

Unicode characters which can't be rendered in any font are invisible
​https://bugs.webkit.org/show_bug.cgi?id=171942
<rdar://problem/32054234>

Reviewed by Tim Horton.

Source/WebCore:

There are some Unicode characters which don't have any font on the system which can render them.
These characters should be drawn as the .notdef "tofu." This is for security and usability, as
well as what Firefox and Chrome do. However, we still shouldn't draw characters with the
Default_Ignorable_Code_Point property, because this is what CoreText does.

This behavior is also what the Unicode spec recommends: In UTR #36 Unicode Security Considerations:
​http://www.unicode.org/reports/tr36/#Recommendations_General
"If there is no available glyph for a character, never show a simple "?" or omit the character."

Also relevant is the Unicode Standard section 5.3 Unknown and MIssing Characters, starting at page
marked 203 in the following: ​http://www.unicode.org/versions/Unicode9.0.0/ch05.pdf

Tests: fast/text/default-ignorable.html

fast/text/unknown-char-notdef.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::characterMustDrawSomething):

LayoutTests:

  • fast/text/default-ignorable-expected.html: Added.
  • fast/text/default-ignorable.html: Added.
  • fast/text/unknown-char-notdef-expected-mismatch.html: Added.
  • fast/text/unknown-char-notdef.html: Added.
12:54 PM Changeset in webkit [216873] by jmarcell@apple.com
  • 5 edits in tags/Safari-603.3.1.0.1/Source

Versioning.

12:50 PM Changeset in webkit [216872] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

12:44 PM Changeset in webkit [216871] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Disable Picture In Picture API tests on unsupported platforms.
​https://bugs.webkit.org/show_bug.cgi?id=172125
rdar://problem/32199477

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-05-15
Reviewed by Simon Fraser.

The callbacks and allowing picture-in-picture require new SPI.

  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
12:38 PM Changeset in webkit [216870] by jmarcell@apple.com
  • 1 copy in tags/Safari-603.3.1.0.1

New tag.

12:34 PM Changeset in webkit [216869] by beidson@apple.com
  • 2 edits in trunk/Tools

[ios-simulator] API test WKWebView.ClearAppCache is failing.
​https://bugs.webkit.org/show_bug.cgi?id=172120

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.

Restoring that code fixes this.

12:21 PM Changeset in webkit [216868] by timothy_horton@apple.com
  • 4 edits in trunk

Null deref under WebContentReader::readURL when interacting with a file URL
​https://bugs.webkit.org/show_bug.cgi?id=172045
<rdar://problem/25880647>

Reviewed by Wenson Hsieh.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readURL):
The AppSupport soft link was wrong, as there is no such framework in /System/Library/Frameworks.
Thus, any time we hit this codepath, the soft linked function would be null, and calling it would crash.
Instead of just fixing the soft link, remove the code, because it does not seem necessary to
special-case fileURLs to images in the media directory.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):
The text of the file URL is pasted because a textual version of it gets
onto the pasteboard. However, this test would have crashed before. Also
tests that we don't make an <a>.

11:31 AM Changeset in webkit [216867] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

Debugging code was accidentally left in the Plugin sandbox profile.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
11:26 AM Changeset in webkit [216866] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

ASSERTION FAILED: wasRemoved in WebCore::RealtimeMediaSourceCenter::removeDevicesChangedObserver(DevicesChangedObserverToken)
​https://bugs.webkit.org/show_bug.cgi?id=171529
<rdar://problem/31945791>

Reviewed by Jer Noble.

No new tests, fixes a crash in existing tests.

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices): Use a weak ptr.

  • platform/mediastream/RealtimeMediaSourceCenter.cpp:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::observerMap): Use a static hash map for observers because the
source center can change at runtime.
(WebCore::RealtimeMediaSourceCenter::addDevicesChangedObserver):
(WebCore::RealtimeMediaSourceCenter::removeDevicesChangedObserver):
(WebCore::RealtimeMediaSourceCenter::captureDevicesChanged):

11:14 AM Changeset in webkit [216865] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for Search icon of Quick Open dialog
​https://bugs.webkit.org/show_bug.cgi?id=172110

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-15
Reviewed by Michael Catanzaro.

Add a free icon for the Web Inspector in GTK+.

  • UserInterface/Images/gtk/Search.svg: Added.
11:11 AM Changeset in webkit [216864] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for Worker Scripts / Web Sockets
​https://bugs.webkit.org/show_bug.cgi?id=164138

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-15
Reviewed by Michael Catanzaro.

Add more free icons for the Web Inspector in GTK+.

  • UserInterface/Images/gtk/WorkerScript.png: Added.
  • UserInterface/Images/gtk/​WorkerScript@2x.png: Added.
  • UserInterface/Images/gtk/WorkerScriptLarge.png: Added.
  • UserInterface/Images/gtk/​WorkerScriptLarge@2x.png: Added.
  • UserInterface/Views/ResourceIcons.css:

(.script.worker-icon .icon):
(.large .script.worker-icon .icon):
(body:matches(.mac-platform, .windows-platform) .script.worker-icon .icon): Deleted.
(body:matches(.mac-platform, .windows-platform) .large .script.worker-icon .icon): Deleted.

10:24 AM Changeset in webkit [216863] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[iOS WK1] Do not try to dispatch messages to subframes if their documents have not been constructed yet.
​https://bugs.webkit.org/show_bug.cgi?id=172059
<rdar://problem/31963192>

Reviewed by Zalan Bujtas.

On iOS WK1 we can end up in an inconsistent state, where

  1. The web thread is inside a newly-injected iframe's document's constructor and
  2. waiting on a delegate callback on the main thread

while the main thread
(a) Evaluates arbitrary JavaScript that modifies storage which
(b) Triggers an event dispatch.

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents): If the sub-frame's document
is in an inconsistent state, skip it.
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents): Ditto.
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames): Ditto.
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames): Ditto.

8:26 AM Changeset in webkit [216862] by yoon@igalia.com
  • 3 edits in trunk/Source/WebKit2

[WPE] Unreviewed debug build fix
​https://bugs.webkit.org/show_bug.cgi?id=172118

Unreviewed, remove a dead code accidentally committed in r215259.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

Remove deprecated CompositingRunLoop::isCurrent.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::frameComplete):

7:21 AM Changeset in webkit [216861] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Simple line layout: Leading whitespace followed by a <br> produces an extra linebreak.
​https://bugs.webkit.org/show_bug.cgi?id=172076

Reviewed by Antti Koivisto.

Source/WebCore:

When the collapsed whitespace does not fit the line, we need to push it to the next line
so that we can decide whether any soft/hard linebreak should be skipped (to avoid double line breaks) or not.

Test: fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::consumeLineBreakIfNeeded): special handling <br>
(WebCore::SimpleLineLayout::firstFragment): Now we need to deal with leading collapsed whitespace.
(WebCore::SimpleLineLayout::createLineRuns): We need to push even the collapsed whitespace to the next line.

LayoutTests:

  • fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak-expected.html: Added.
  • fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html: Added.
2:14 AM Changeset in webkit [216860] by nael.ouedraogo@crf.canon.fr
  • 7 edits
    1 copy
    2 adds in trunk

Invalid MediaSource duration value should throw TyperError instead of InvalidStateError
​https://bugs.webkit.org/show_bug.cgi?id=171653

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline test results.

  • web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt:

Source/WebCore:

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(​https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectations of corresponding WPT test.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):

LayoutTests:

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(​https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectations of corresponding WPT test.

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
  • platform/mac-elcapitan/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
  • platform/mac/TestExpectations:
2:06 AM Changeset in webkit [216859] by yoon@igalia.com
  • 3 edits
    2 adds in trunk

[CAIRO] Painting an image mask with a matrix above Pixman's limit breaks internal states of Cairo
​https://bugs.webkit.org/show_bug.cgi?id=169094

Reviewed by Žan Doberšek.

Source/WebCore:

It is the same problem which addressed in r212431.
In HiDPI situation, it happens easily due to the size of coordinates.
Also, if this bug happens, it will break the rendering continuously
since we are reusing graphics contexts to render webpages in same
webview.

Test: fast/hidpi/hidpi-long-page-with-inset-element.html

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::pushImageMask):
We can avoid the limit of the Pixman by reducing the source surface's
size, and it will create a minimal pattern matrix.

LayoutTests:

  • fast/hidpi/hidpi-long-page-with-inset-element-expected.html: Added.
  • fast/hidpi/hidpi-long-page-with-inset-element.html: Added.
12:01 AM Changeset in webkit [216858] by jcraig@apple.com
  • 2 edits
    11 adds
    1 delete in trunk/Websites/webkit.org

2017-05-14 James Craig <​jcraig@apple.com>

Upload poster images and working captioned video
​https://bugs.webkit.org/show_bug.cgi?id=172102

Unreviewed. More resources for prefers-reduced-motion post.

  • blog-files/prefers-reduced-motion/axi.htm: Added.
  • blog-files/prefers-reduced-motion/axi.png: Removed.
  • blog-files/prefers-reduced-motion/posters: Added.
  • blog-files/prefers-reduced-motion/posters/apple_env_load.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_env_planeshift.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_ios10.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_shoot.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_shoot_reduced.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_sierra.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/apple_sierra_reduced.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/axi.jpg: Added.
  • blog-files/prefers-reduced-motion/posters/viljami.jpg: Added.
  • blog-files/prefers-reduced-motion/prm.htm: Link to axi.htm video demo.

May 14, 2017:

11:20 PM Changeset in webkit [216857] by pvollan@apple.com
  • 6 edits in trunk

[Win] fast/cookies/local-file-can-set-cookies.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172071

Reviewed by Alexey Proskuryakov.

Source/WebKit/win:

We need to delete all cookies after each test.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferences.cpp:

(WebPreferences::linkPreloadEnabled):
(WebPreferences::clearNetworkLoaderSession):

  • WebPreferences.h:

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

10:51 PM Changeset in webkit [216856] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix with newer Perl versions.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddLegacyCallerOperationIfNeeded): Support for experimental push on scalar (and
other auto-dereferencing) was removed in Perl 5.24. Instead, the LegacyCallers array
has to be dereferenced when pushing new values to it.

10:00 PM Changeset in webkit [216855] by jcraig@apple.com
  • 2 edits in trunk/Websites/webkit.org

2017-05-14 James Craig <​jcraig@apple.com>

AX: All the articles on the WebKit blog are called 'Clickable Link' by VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=172096
<rdar://problem/31624323>

Unreviewed. Fixing broken link titles for screen readers.

  • wp-content/themes/webkit/loop.php: Adding relevant link label for accessibility.
8:45 PM Changeset in webkit [216854] by bshafiei@apple.com
  • 3 edits in tags/Safari-604.1.22.0.1/Source/WebCore

Merged r216807. rdar://problem/32169232

8:44 PM Changeset in webkit [216853] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.22.0.1/Source

Versioning.

8:42 PM Changeset in webkit [216852] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.22.0.1

New tag.

6:09 PM Changeset in webkit [216851] by weinig@apple.com
  • 22 edits
    2 adds
    1 delete in trunk

[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec
​https://bugs.webkit.org/show_bug.cgi?id=172095

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:

Update results.

Source/WebCore:

  • Adds support for the legacycaller WebIDL special annotation.
  • Updates implementation of HTMLAllCollection to match the current HTML spec.

Test: fast/dom/document-all.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLAllCollectionCustom.cpp: Removed.

Removed JSHTMLAllCollectionCustom.cpp

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):
(AddLegacyCallerOperationIfNeeded):
Before code generation, clone all the legacycaller operations and put them
in their own set, so they can form an overload set.

(AddStringifierOperationIfNeeded):
Use IDLParser::cloneType as the FIXME suggested.

(GenerateHeader):
Group call related functionality together and use new IsCallable predicate.

(GenerateOverloadedFunctionOrConstructor):
Generalize a little bit to allow the function being overloaded to be an overloaded legacycaller.

(GenerateImplementation):
Add call to generate the legacycaller code.

(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
Generate the legacycaller definition, using GenerateArgumentsCountCheck, GenerateParametersCheck
and GenerateImplementationFunctionCall to do all the heavy lifting.

(IsCallable):
Add helper predicate for both custom calls and legacycaller.

  • bindings/scripts/IDLParser.pm:

(cloneType):.
(cloneArgument):.
(cloneOperation):
Add cloning functions for IDLArgument and IDLOperation, and make IDLType's
clone feasible for calling outside the package by removing the unneeded
self parameter.

  • bindings/scripts/test/JS/JSTestObj.cpp
  • bindings/scripts/test/JS/JSTestObj.h
  • bindings/scripts/test/TestObj.idl:

Add testing of legacycaller overloading.

  • dom/Document.cpp:

(WebCore::Document::allFilteredByName):

  • dom/Document.h:

Add new collection access for the HTMLAllNamedSubCollection.

  • html/CachedHTMLCollection.h:

(WebCore::nameShouldBeVisibleInDocumentAll):
Update list of tags to match the current spec.

  • html/CollectionType.h:

Add new type for HTMLAllNamedSubCollection.

  • html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):
Specify that DocumentAllNamedItems does not want
the default elementMatches.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedOrIndexedItemOrItems):
(WebCore::HTMLAllCollection::namedItemOrItems):
(WebCore::HTMLAllNamedSubCollection::~HTMLAllNamedSubCollection):
(WebCore::HTMLAllNamedSubCollection::elementMatches):

  • html/HTMLAllCollection.h:

Move implementations from the custom binding, and re-implement to
match the spec. Alternate names to item/namedItem were needed to not
shadow the existing ones in HTMLCollection. HTMLAllNamedSubCollection
is a simple HTMLCollection that matches on a name, following the rules
of document.all about which tags can have name attributes.

  • html/HTMLAllCollection.idl:

Remove custom annotations and add legacycaller which is now supported.

  • html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::~HTMLCollection):
Add DocumentAllNamedItems.

LayoutTests:

  • fast/dom/collection-null-like-arguments-expected.txt:

Update results.

  • fast/dom/document-all-expected.txt: Added.
  • fast/dom/document-all.html: Added.

New test that covers a bunch of missing coverage.

5:46 PM Changeset in webkit [216850] by commit-queue@webkit.org
  • 3 edits
    6 deletes in trunk/Source/WebKit2

[CoordinatedGraphics] Remove unused files and lines
​https://bugs.webkit.org/show_bug.cgi?id=172080

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-05-14
Reviewed by Darin Adler.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Removed.
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Removed.
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Removed.
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Removed.
  • UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h: Removed.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in: Removed.
2:16 PM Changeset in webkit [216849] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Remove unused lambda in TextFragmentIterator::TextFragment::split() and cleanup dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=172089

Reviewed by David Kilzer.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::splitFragmentToFitLine):

  • rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):

1:10 PM Changeset in webkit [216848] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

12:27 PM Changeset in webkit [216847] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

Always reset the assisted node when the main frame commits a new load.
​https://bugs.webkit.org/show_bug.cgi?id=172088

Reviewed by Antti Koivisto.

WebPage::m_assistedNode could extend the lifetime of the document it pointed into
if the main frame was navigated while the assisted node was in one of its subframes.
The life-supported document wouldn't be reachable from JavaScript but nevertheless
would consume memory and other resources.

This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
frame commits a new load.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resetAssistedNodeForFrame):

10:43 AM Changeset in webkit [216846] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

[iOS/macOS Debug WK2] LayoutTests/imported/w3c/web-platform-tests/webrtc/interfaces.html is a flaky crash due to assertion failure
<​https://bugs.webkit.org/show_bug.cgi?id=172094>
<rdar://problem/32184256>

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • Mark test as flaky crash on Debug WK2 builds.
9:36 AM Changeset in webkit [216845] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.21.3

Tag Safari-604.1.21.3.

6:27 AM Changeset in webkit [216844] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed Mac cmake buildfix after r216690, just for fun.

  • PlatformMac.cmake:
4:28 AM Changeset in webkit [216843] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<​https://webkit.org/b/172092>

Unreviewed test gardening.

  • platform/ios-wk1/TestExpectations:
  • This only times out on Release builds.
4:16 AM Changeset in webkit [216842] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<​https://webkit.org/b/172092>

Unreviewed test gardening.

See also Bug 169211 for a similar GTK WK1 timeout.

  • platform/ios-wk1/TestExpectations:
  • Mark as always timing out on all builds.
  • platform/mac-wk1/TestExpectations:
  • Mark flaky on Debug builds.
3:41 AM Changeset in webkit [216841] by ddkilzer@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix unused lambdas in WebKit2
<​https://webkit.org/b/172090>

Reviewed by Chris Dumez.

Fixes unused lambda warnings found with newer clang.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):

  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):

  • Use UNUSED_PARAM() to silence unused lambda warning since 'startTime' is used in Debug builds.
  • NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):

  • Remove unused 'this' from lambda capture.
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

  • Use UNUSED_PARAM() to silence unused lambda warning since 'taskIdentifier' is used in Debug builds.
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):

  • Remove unused 'this' from lambda captures.
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):

  • Remove unused 'fetchOptions' from lambda capture.

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):

  • Remove unused 'this' from lambda capture.
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::forceRepaintIfNeeded):

  • Remove unused 'this' from lambda capture.
  • WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didExitFullscreen):

  • Remove unused 'this' from nested lambda captures.
1:18 AM Changeset in webkit [216840] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix. Added a missing null check.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskConfiguratorPane.prototype.setTestGroups):

12:31 AM Changeset in webkit [216839] by Chris Dumez
  • 11 edits
    1 delete in trunk

Drop PassRefPtr class from WTF
​https://bugs.webkit.org/show_bug.cgi?id=172091

Reviewed by Alex Christensen.

Source/WTF:

Drop PassRefPtr class from WTF as it is no longer used or needed.
Also drop RefPtr::release() for the same reasons.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/CrossThreadCopier.cpp:
  • wtf/CrossThreadCopier.h:
  • wtf/Forward.h:
  • wtf/PassRefPtr.h: Removed.
  • wtf/RefPtr.h:

(WTF::refIfNotNull):
(WTF::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::release): Deleted.

  • wtf/SizeLimits.cpp:
  • wtf/Vector.h:

Tools:

Drop API test coverage.

  • TestWebKitAPI/Tests/WTF/Ref.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::passWithPassRefPtr): Deleted.

May 13, 2017:

11:05 PM Changeset in webkit [216838] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Unused lambda in JSWebKitSubtleCrypto::wrapKey()
<​https://webkit.org/b/172087>

Reviewed by Chris Dumez.

Fixes the following warning with newer clang:

Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]

auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector<uint8_t>& exportedKeyData) mutable {


  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.

10:37 PM Changeset in webkit [216837] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unused lambda capture in JSContextGroupAddMarkingConstraint()
<​https://webkit.org/b/172084>

Reviewed by Saam Barati.

Fixes the following warning with newer clang:

Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:78:11: error: lambda capture 'vm' is not used [-Werror,-Wunused-lambda-capture]

[&vm, constraintCallback, userData]


  • API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint): Remove unused lambda
capture for '&vm'.

10:27 PM Changeset in webkit [216836] by eric.carlson@apple.com
  • 39 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::~MediaDevices): m_deviceChangedToken is a std::optional<>.

  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints): Implement.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): Deleted.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Deleted.

  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

Tools:

The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
implement the "checkUserMediaPermission" callback.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
(TestWebKitAPI::checkUserMediaPermissionCallback):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:

(-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
  • fast/mediastream/apply-constraints-video-expected.txt: Updated.
  • fast/mediastream/apply-constraints-video.html: Ditto.
10:21 PM Changeset in webkit [216835] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] config.rb fails when checking some clang versions
<​https://webkit.org/b/172082>

Reviewed by Mark Lam.

  • offlineasm/config.rb:
  • Add support for quad-dotted version of Apple clang (800.0.12.1).
  • Add support for checking open source clang version (5.0.0).
9:27 PM Changeset in webkit [216834] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

TestExpectations: Remove last refereneces to Legacy Notifications

Unreviewed test gardening fixes these lint warnings:

LayoutTests/TestExpectations:1222 Path does not exist. fast/notifications/notifications-event-stop-propagation.html
LayoutTests/TestExpectations:1223 Path does not exist. fast/notifications/notifications-multi-events.html

Notification support was removed in r216641.

9:04 PM Changeset in webkit [216833] by Chris Dumez
  • 28 edits in trunk

Stop using RefPtr::release()
​https://bugs.webkit.org/show_bug.cgi?id=172074

Reviewed by Geoffrey Garen.

Source/WebCore:

  • css/parser/CSSPropertyParser.cpp:

(WebCore::FontVariantLigaturesParser::finalizeValue):
(WebCore::FontVariantNumericParser::finalizeValue):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

  • platform/audio/ios/AudioFileReaderIOS.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/glib/SharedBufferGlib.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):

  • platform/graphics/gtk/IconGtk.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadPlainTextString):
(WebFrame::loadHTMLString):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::receivedPolicyDecision):

Source/WebKit2:

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createImageBacking):

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createCairoSurface):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilter.cpp:

(WebKit::core):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsMHTMLData):

Source/WTF:

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatchAfter):

Tools:

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

7:20 PM Changeset in webkit [216832] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
7:18 PM Changeset in webkit [216831] by Ryan Haddad
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r216614.

6:07 PM Changeset in webkit [216830] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove flaky expectation for LayoutTest media/media-controls-clone-crash.html.
​https://bugs.webkit.org/show_bug.cgi?id=171978

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:36 PM Changeset in webkit [216829] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-align] Implement the place-self shorthand
​https://bugs.webkit.org/show_bug.cgi?id=168846

Reviewed by Zalan Bujtas.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-self and justify-self) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests.

Test: css3/parse-place-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
(WebCore::CSSPropertyParser::parseShorthand):

  • css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-self alignment shorthand.

  • css3/parse-place-self-expected.txt: Added.
  • css3/parse-place-self.html: Added.
1:46 PM Changeset in webkit [216828] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch/Source

Cherry-pick r214313. rdar://problem/32080658

1:32 PM Changeset in webkit [216827] by commit-queue@webkit.org
  • 24 edits
    1 delete in trunk

Unreviewed, rolling out r216808.
​https://bugs.webkit.org/show_bug.cgi?id=172075

caused lldb to hang when debugging (Requested by smfr on
#webkit).

Reverted changeset:

"Use Mach exceptions instead of signals where possible"
​https://bugs.webkit.org/show_bug.cgi?id=171865
​http://trac.webkit.org/changeset/216808

12:10 PM Changeset in webkit [216826] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r216801.
​https://bugs.webkit.org/show_bug.cgi?id=172072

Many memory corruption crashes on worker threads (Requested by
ap on #webkit).

Reverted changeset:

"WorkerRunLoop::Task::performTask() should check
!scriptController->isTerminatingExecution()."
​https://bugs.webkit.org/show_bug.cgi?id=171775
​http://trac.webkit.org/changeset/216801

11:43 AM Changeset in webkit [216825] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
​https://bugs.webkit.org/show_bug.cgi?id=172065

Reviewed by Simon Fraser.

r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

11:24 AM Changeset in webkit [216824] by Simon Fraser
  • 7 edits
    2 adds in trunk

event.clientX/clientY should be in layout viewport coordinates
​https://bugs.webkit.org/show_bug.cgi?id=172018

Reviewed by Zalan Bujtas.
Source/WebCore:

Fix clientX and clientY on mouse events to be relative to the layout viewport, to match
getBoundingClientRect(), getClientRects() and fixed-position objects.

Also minor cleanup of MouseRelatedEvent to use initializers.

Test: fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::init):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::contentsScrollOffset): Deleted.

  • dom/MouseRelatedEvent.h:

LayoutTests:

  • fast/events/clientXY-in-zoom-and-scroll.html:
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt:
10:33 AM Changeset in webkit [216823] by Chris Dumez
  • 37 edits in trunk/Source/WebKit/win

Drop uses of PassRefPtr in WebKit/win
​https://bugs.webkit.org/show_bug.cgi?id=172067

Reviewed by Yusuke Suzuki.

  • DOMEventsClasses.cpp:

(DOMEvent::DOMEvent):
(DOMEvent::createInstance):

  • DOMEventsClasses.h:

(DOMUIEvent::DOMUIEvent):
(DOMKeyboardEvent::DOMKeyboardEvent):
(DOMMouseEvent::DOMMouseEvent):
(DOMMutationEvent::DOMMutationEvent):
(DOMOverflowEvent::DOMOverflowEvent):
(DOMWheelEvent::DOMWheelEvent):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::createInstance):

  • MemoryStream.h:
  • Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):

  • Plugins/PluginDatabase.h:
  • Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):

  • Plugins/PluginPackage.h:
  • Plugins/PluginStream.h:

(WebCore::PluginStream::create):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::createInstance):

  • WebActionPropertyBag.h:
  • WebArchive.cpp:

(WebArchive::createInstance):
(WebArchive::WebArchive):

  • WebArchive.h:
  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::createInstance):

  • WebBackForwardList.h:
  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::create):

  • WebCoreSupport/EmbeddedWidget.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebFrame.cpp:

(WebFrame::loadData):
(WebFrame::createSubframeWithOwnerElement):

  • WebFrame.h:
  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::createInstance):

  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::createInstance):
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):

  • WebGeolocationPolicyListener.h:
  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::createInstance):

  • WebHistoryItem.h:
  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setFormData):
(WebMutableURLRequest::formData):

  • WebMutableURLRequest.h:
  • WebResource.cpp:

(WebResource::createInstance):

  • WebResource.h:
  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::createInstance):

  • WebScriptWorld.h:
  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::createInstance):

  • WebURLAuthenticationChallengeSender.h:
  • WebView.cpp:

(WebView::setFullScreenElement):

  • WebView.h:
Note: See TracTimeline for information about the timeline view.