Context Navigation

← Previous Period
Next Period →

Timeline

Jan 27, 2020:

11:56 PM Changeset in webkit [255229] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: don't use :matches(:before, :after) after r255059
https://bugs.webkit.org/show_bug.cgi?id=206848

Reviewed by Antti Koivisto.

UserInterface/Views/SpringEditor.css:

(.spring-editor > .spring-timing::before, .spring-editor > .spring-timing::after): Added.
(.spring-editor > .spring-timing:matches(::before, ::after)): Deleted.

11:54 PM Changeset in webkit [255228] by Noam Rosenthal

15 edits
2 adds in trunk

-webkit-image-set should support resolution units other than 'x'
https://bugs.webkit.org/show_bug.cgi?id=100120

Reviewed by Darin Adler.

Source/WebCore:

Leveraged previous work on image-resolution to enable dpi/dppx/dpcm in CSS image-set.
Now the second value of every entry in the image-set is parsed like any resolution,
allowing "x" as a synonim for "dppx.

This changes computed style behavior for image-set - "x" resolution values will be converted
to "dppx". This is in line with the spirit of computed values, though it's not spec'ed particularly.

Tests: fast/hidpi/image-set-units.html

css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::updateDeviceScaleFactor):
(WebCore::CSSImageSetValue::customCSSText const):

Convert values to dppx before sorting them the image set.
Use given CSS units in computed styles instead of hardcoding "x"

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):

Allow conversion of dpi/dppx/dpcm to canonical (dppx).

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeResolution):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):

css/parser/CSSPropertyParserHelpers.h:

Consume any resolution when parsing image-set.

LayoutTests:

Had to modify several image-set parsing tests because of the behavior change in
computed style (x => dppx).

Also added a couple of parsing/rendering tests specifically to test the new behavior
of dpi/dpcm/dppx.

fast/css/cursor-parsing-image-set-expected.txt:
fast/css/cursor-parsing-image-set.html:
fast/css/image-set-parsing-expected.txt:
fast/css/image-set-parsing-invalid-expected.txt:
fast/css/image-set-parsing.html:
fast/css/image-set-setting-expected.txt:
fast/css/image-set-setting.html:
fast/css/image-set-unprefixed.html:
fast/hidpi/image-set-units-expected.html: Added.
fast/hidpi/image-set-units.html: Added.

11:26 PM Changeset in webkit [255227] by Antti Koivisto

2 edits in trunk/Source/WebCore

Correct VTT Cue Style handling to match the specification
https://bugs.webkit.org/show_bug.cgi?id=201086

Unreviewed followup based on a review comment.

html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::checkAndStoreStyleSheet):

10:15 PM Changeset in webkit [255226] by Simon Fraser

15 edits
3 adds in trunk

REGRESSION (r253634): cricbuzz.com media controls vanish depending on page scale
https://bugs.webkit.org/show_bug.cgi?id=206788
rdar://problem/58780584

Reviewed by Tim Horton.
Source/WebCore:

r253634 changed "delegatesPageScaling"'" to a flag on ScrollView. However, this changed behavior
for subframes; Settings are propagated down, but only the main ScrollView had delegatesPageScaling
set on it.

"delegatesPageScaling" is a page-level thing (subframes don't independently zoom), so it
should live on Page. Move it there.

The bug was triggered by incorrectly taking page scale into account for rects in the compositing
overlap map (see RenderLayerCompositor::addToOverlapMap()) in subframes, and those rects
changing on zoom.

Test: compositing/backing/page-scale-overlap-in-iframe.html

page/Frame.cpp:

(WebCore::Frame::frameScaleFactor const):

page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRectWithClip):

page/FrameView.cpp:

(WebCore::FrameView::visibleContentScaleFactor const):

page/Page.cpp:

(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setDelegatesScaling):

page/Page.h:

(WebCore::Page::delegatesScaling const):

platform/ScrollView.cpp:

(WebCore::ScrollView::setDelegatesPageScaling): Deleted.

platform/ScrollView.h:

(WebCore::ScrollView::delegatesPageScaling const): Deleted.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap const):

Source/WebKit:

"delegatesPageScaling" is a page-level thing (subframes don't independently zoom), so it
should live on Page. Move it there.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindIndicatorOverlayClientIOS::drawRect):

Source/WebKitLegacy/mac:

"delegatesPageScaling" is a page-level thing (subframes don't independently zoom), so it
should live on Page. Move it there.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

LayoutTests:

Test only really makes sense on iOS where the viewport tag is respected, but include
macOS results instead of skipping.

compositing/backing/page-scale-overlap-in-iframe-expected.txt: Added.
compositing/backing/page-scale-overlap-in-iframe.html: Added.
platform/ios-wk2/compositing/backing/page-scale-overlap-in-iframe-expected.txt: Added.

9:11 PM Changeset in webkit [255225] by Fujii Hironori

2 edits in trunk/Source/WebKit

[WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in WebKit::CacheStorage::Engine::destroyEngine since r255137
https://bugs.webkit.org/show_bug.cgi?id=206859

Reviewed by Don Olmstead.

After r255137, WinCairo debug WK2 is still failing an assertion
while shutdown, which is ensuring the destructing session isn't
the default session.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::destroyEngine): Conditioned out the
assertion for curl port as well as Soup port does.

8:56 PM Changeset in webkit [255224] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Need a way to mark a DOM attribute as runtime conditionally read-write
https://bugs.webkit.org/show_bug.cgi?id=206836

Patch by Sam Weinig <weinig@apple.com> on 2020-01-27
Reviewed by Chris Dumez.

Adds a new IDL extended attribute, RuntimeConditionallyReadWrite, that works
like EnableAtRuntime, but instead allows the associated attribute to be
converted from read-only to read-write based on the value of a RuntimeEnabledFeature.

bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):
Add check that both runtime enabling and runtime conditional read-write aren't
both specified. For now, that is not supported.

(GenerateRuntimeEnableConditionalString):
Add support for generating the conditional string for RuntimeConditionallyReadWrite.

(GenerateImplementation):
Implement the feature by piggy-backing off the existing runtime enabling, which
deletes the property if the feature is not enabled. For this, if the feature isn't
enabled, we delete the property, and then add it back readonly. In the future, we
should move off of this add-then-delete model, but that is tracked via http://webkit.org/b/206837.

bindings/scripts/IDLAttributes.json:

Add new extended attribute.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjRuntimeConditionallyReadWriteAttributeGetter):
(WebCore::jsTestObjRuntimeConditionallyReadWriteAttribute):
(WebCore::setJSTestObjRuntimeConditionallyReadWriteAttributeSetter):
(WebCore::setJSTestObjRuntimeConditionallyReadWriteAttribute):

bindings/scripts/test/TestObj.idl:

Add new test with result.

7:54 PM Changeset in webkit [255223] by rniwa@webkit.org

3 edits in trunk/LayoutTests

http/tests/loading/remove-child-triggers-parser.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=103115

Reviewed by Alexey Proskuryakov.

Delay the end of the test until the timer fires.

http/tests/loading/remove-child-triggers-parser-expected.txt:
http/tests/loading/remove-child-triggers-parser.html:

7:09 PM Changeset in webkit [255222] by david_quesada@apple.com

2 edits in trunk/Source/WebKit

Support observing a different set of view service state notifications in ApplicationStateTracker
https://bugs.webkit.org/show_bug.cgi?id=201737
rdar://problem/54786414

Reviewed by Chris Dumez.

UIProcess/ApplicationStateTracker.mm:

Make ApplicationStateTracker conditionally (based on a flag to be defined in WebKitAdditions)
use a different pair of notifications when it is in a view service or extension. These
notifications report state changes of the individual scene that hosts the web view, rather
than the state of the overall host application. This allows for more accurate state tracking
for web views in extensions or view services hosted by apps with multiple open scenes.

7:01 PM Changeset in webkit [255221] by Devin Rousso

3 edits in trunk/Source/WebCore

Unreviewed, speculative win build fix after r255191

bindings/js/ScriptController.h:
testing/Internals.cpp:

(WebCore::Internals::evaluateInWorldIgnoringException):
Don't use the ScriptSourceCode so we don't have to export its symbol.

6:20 PM Changeset in webkit [255220] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect
https://bugs.webkit.org/show_bug.cgi?id=206849
<rdar://problem/58887004>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-27
Reviewed by Simon Fraser.

Books currently uses WKView.setShouldClipToVisibleRect and needs to migrate to WKWebView, but it needs to do
so without modifying the other properties in _setMinimumLayoutWidth, which is currently the only other caller
of WebViewImpl::setClipsToVisibleRect. Expose an SPI that only calls WebViewImpl::setClipsToVisibleRect.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView _clipsToVisibleRect]):
(-[WKWebView _setClipsToVisibleRect:]):

6:07 PM Changeset in webkit [255219] by Jonathan Bedard

4 edits in trunk/Source

WebCore: Remove iOS 11 macros from RenderThemeIOS.mm
https://bugs.webkit.org/show_bug.cgi?id=206787

Reviewed by Darin Adler.

Source/WebCore:

No functional changes, covered by existing tests.

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::cachedSystemFontDescription const):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription const):

Source/WTF:

wtf/PlatformHave.h: Add HAVE(SYSTEM_FONT_STYLE_TITLE_0) and HAVE(SYSTEM_FONT_STYLE_TITLE_4).

5:46 PM Changeset in webkit [255218] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Add method to fetch cq+ patches from Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=206774

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-app/ews/common/bugzilla.py:

(Bugzilla._get_commit_queue_patches_from_bug): Method to get cq+ patches for a given bug.
(Bugzilla._is_patch_cq_plus): Method to check if patch has cq+ flag set.
(Bugzilla.get_list_of_patches_for_commit_queue): Method to fetch list of cq+ patches from Bugzilla.
(BugzillaBeautifulSoup.fetch_bug_ids_for_commit_queue):

5:30 PM Changeset in webkit [255217] by Brent Fulgham

3 edits in trunk/Source/WebKit

Remove SecurityServer from WebContent sandboxes
https://bugs.webkit.org/show_bug.cgi?id=206832
<rdar://problem/46235370>

Reviewed by Per Arne Vollan.

We no longer need access to 'com.apple.SecurityServer' and
'com.apple.ocspd' on recent macaOS systems.

Tested by existing test suite.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

5:30 PM Changeset in webkit [255216] by Jonathan Bedard

4 edits in trunk/Source

Fix OpenSource iphoneos arm64e build
https://bugs.webkit.org/show_bug.cgi?id=206703

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

runtime/MachineContext.h:

(JSC::MachineContext::stackPointerImpl): Conditionalize function existence on
USE(DARWIN_REGISTER_MACROS).
(JSC::MachineContext::stackPointer): Use Darwin's register macros if available.
(JSC::MachineContext::setStackPointer): Ditto.
(JSC::MachineContext::instructionPointerImpl): Conditionalize function existence
on USE(DARWIN_REGISTER_MACROS).
(JSC::MachineContext::instructionPointer): Use Darwin's register macros if available.
(JSC::MachineContext::setInstructionPointer): Ditto.
(JSC::MachineContext::linkRegister): Ditto.
(JSC::MachineContext::setLinkRegister): Ditto.
(JSC::MachineContext::linkRegisterImpl): Deleted.

Source/WTF:

wtf/PlatformUse.h: Add USE(DARWIN_REGISTER_MACROS) check.

5:13 PM Changeset in webkit [255215] by Peng Liu

4 edits
1 add in trunk/LayoutTests

REGRSSION: [ High Sierra Catalina ] (r253310) compositing/video/video-border-radius-clipping.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205226

Reviewed by Simon Fraser.

Add a special video with only one frame so that the video element in a test page will always render the exact same pixels.

compositing/video/video-border-radius-clipping-expected.html:
compositing/video/video-border-radius-clipping.html:
media/content/pure-color-green.mp4: Added.
platform/mac-wk1/TestExpectations:

5:13 PM Changeset in webkit [255214] by Devin Rousso

14 edits
4 copies
58 moves
11 adds
1 delete in trunk/Source/WebKit

Web Inspector: consolidate UIProcess/WebProcess files into Inspector folders
https://bugs.webkit.org/show_bug.cgi?id=206721

Reviewed by Alex Christensen and Don Olmstead.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources.make:
PlatformGTK.cmake:
PlatformMac.cmake:
PlatformFTW.cmake:
PlatformWin.cmake:
Sources.txt:
SourcesCocoa.txt:
SourcesGTK.txt:
WebKit.xcodeproj/project.pbxproj:

UIProcess/Inspector/InspectorTargetProxy.h: Renamed from Source/WebKit/UIProcess/InspectorTargetProxy.h.
UIProcess/Inspector/InspectorTargetProxy.cpp: Renamed from Source/WebKit/UIProcess/InspectorTargetProxy.cpp.
UIProcess/Inspector/RemoteWebInspectorProxy.messages.in: Renamed from Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in.
UIProcess/Inspector/RemoteWebInspectorProxy.h: Renamed from Source/WebKit/UIProcess/RemoteWebInspectorProxy.h.
UIProcess/Inspector/RemoteWebInspectorProxy.cpp: Renamed from Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp.
UIProcess/Inspector/WebInspectorProxy.messages.in: Renamed from Source/WebKit/UIProcess/WebInspectorProxy.messages.in.
UIProcess/Inspector/WebInspectorProxy.h: Renamed from Source/WebKit/UIProcess/WebInspectorProxy.h.
UIProcess/Inspector/WebInspectorProxy.cpp: Renamed from Source/WebKit/UIProcess/WebInspectorProxy.cpp.
UIProcess/Inspector/WebInspectorUtilities.h: Renamed from Source/WebKit/UIProcess/WebInspectorUtilities.h.
UIProcess/Inspector/WebInspectorUtilities.cpp: Renamed from Source/WebKit/UIProcess/WebInspectorUtilities.cpp.
UIProcess/Inspector/WebPageDebuggable.h: Renamed from Source/WebKit/UIProcess/WebPageDebuggable.h.
UIProcess/Inspector/WebPageDebuggable.cpp: Renamed from Source/WebKit/UIProcess/WebPageDebuggable.cpp.
UIProcess/Inspector/WebPageInspectorController.h: Renamed from Source/WebKit/UIProcess/WebPageInspectorController.h.
UIProcess/Inspector/WebPageInspectorController.cpp: Renamed from Source/WebKit/UIProcess/WebPageInspectorController.cpp.
UIProcess/Inspector/glib/RemoteInspectorClient.h: Renamed from Source/WebKit/UIProcess/glib/RemoteInspectorClient.h.
UIProcess/Inspector/glib/RemoteInspectorClient.cpp: Renamed from Source/WebKit/UIProcess/glib/RemoteInspectorClient.cpp.
UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp: Renamed from Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp.
UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp: Renamed from Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp.
UIProcess/Inspector/gtk/WebInspectorProxyClient.h: Renamed from Source/WebKit/UIProcess/gtk/WebInspectorProxyClient.h.
UIProcess/Inspector/gtk/WebKitInspectorWindow.h: Renamed from Source/WebKit/UIProcess/gtk/WebKitInspectorWindow.h.
UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp: Renamed from Source/WebKit/UIProcess/gtk/WebKitInspectorWindow.cpp.
UIProcess/Inspector/ios/WKInspectorHighlightView.h: Renamed from Source/WebKit/UIProcess/WKInspectorHighlightView.h.
UIProcess/Inspector/ios/WKInspectorHighlightView.mm: Renamed from Source/WebKit/UIProcess/WKInspectorHighlightView.mm.
UIProcess/Inspector/ios/WKInspectorNodeSearchGestureRecognizer.h: Renamed from Source/WebKit/UIProcess/ios/WKInspectorNodeSearchGestureRecognizer.h.
UIProcess/Inspector/ios/WKInspectorNodeSearchGestureRecognizer.mm: Renamed from Source/WebKit/UIProcess/ios/WKInspectorNodeSearchGestureRecognizer.mm.
UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm: Renamed from Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm.
UIProcess/Inspector/mac/WKInspectorViewController.h: Renamed from Source/WebKit/UIProcess/mac/WKInspectorViewController.h.
UIProcess/Inspector/mac/WKInspectorViewController.mm: Renamed from Source/WebKit/UIProcess/mac/WKInspectorViewController.mm.
UIProcess/Inspector/mac/WKInspectorWKWebView.h: Renamed from Source/WebKit/UIProcess/mac/WKInspectorWKWebView.h.
UIProcess/Inspector/mac/WKInspectorWKWebView.mm: Renamed from Source/WebKit/UIProcess/mac/WKInspectorWKWebView.mm.
UIProcess/Inspector/mac/WebInspectorProxyMac.mm: Renamed from Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm.
UIProcess/Inspector/socket/RemoteInspectorClient.h: Renamed from Source/WebKit/UIProcess/socket/RemoteInspectorClient.h.
UIProcess/Inspector/socket/RemoteInspectorClient.cpp: Renamed from Source/WebKit/UIProcess/socket/RemoteInspectorClient.cpp.
UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.h: Renamed from Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.h.
UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: Renamed from Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.cpp.
UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp: Renamed from Source/WebKit/UIProcess/win/RemoteWebInspectorProxyWin.cpp.
UIProcess/Inspector/win/WebInspectorProxyWin.cpp: Renamed from Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp.

WebProcess/Inspector/RemoteWebInspectorUI.messages.in: Renamed from Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.messages.in.
WebProcess/Inspector/RemoteWebInspectorUI.h: Renamed from Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h.
WebProcess/Inspector/RemoteWebInspectorUI.cpp: Renamed from Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp.
WebProcess/Inspector/WebInspector.messages.in: Renamed from Source/WebKit/WebProcess/WebPage/WebInspector.messages.in.
WebProcess/Inspector/WebInspector.h: Renamed from Source/WebKit/WebProcess/WebPage/WebInspector.h.
WebProcess/Inspector/WebInspector.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebInspector.cpp.
WebProcess/Inspector/WebInspectorClient.h: Renamed from Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.h.
WebProcess/Inspector/WebInspectorClient.cpp: Renamed from Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp.
WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h.
WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp.
WebProcess/Inspector/WebInspectorInterruptDispatcher.messages.in: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in.
WebProcess/Inspector/WebInspectorInterruptDispatcher.h: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.h.
WebProcess/Inspector/WebInspectorInterruptDispatcher.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp.
WebProcess/Inspector/WebInspectorUI.messages.in: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in.
WebProcess/Inspector/WebInspectorUI.h: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorUI.h.
WebProcess/Inspector/WebInspectorUI.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp.
WebProcess/Inspector/WebPageInspectorTarget.h: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.h.
WebProcess/Inspector/WebPageInspectorTarget.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.cpp.
WebProcess/Inspector/WebPageInspectorTargetController.h: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.h.
WebProcess/Inspector/WebPageInspectorTargetController.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.cpp.
WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.h: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h.
WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.cpp: Renamed from Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp.
WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp: Renamed from Source/WebKit/WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp.
WebProcess/Inspector/mac/WebInspectorUIMac.mm: Renamed from Source/WebKit/WebProcess/WebPage/mac/WebInspectorUIMac.mm.
WebProcess/Inspector/win/WebInspectorUIWin.mm: Renamed from Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.mm.

UIProcess/API/APIAttachment.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm:

Add some missing includes.

5:03 PM Changeset in webkit [255213] by Truitt Savell

3 edits in trunk/LayoutTests

animations/animation-direction-reverse.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206671

Unreviewed test gardening.

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/ios/TestExpectations:
platform/mac/TestExpectations:

4:39 PM Changeset in webkit [255212] by Devin Rousso

2 edits in trunk/Source/WebCore

Unreviewed, speculative win build fix after r255191

inspector/agents/page/PageRuntimeAgent.cpp:

Add missing include.

4:28 PM Changeset in webkit [255211] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed, drop unused MESSAGE_CHECK_CONTEXTID() macro in UserMediaCaptureManagerProxy.cpp.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

4:27 PM Changeset in webkit [255210] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: (r253718) [ Mac ] inspector/runtime/executionContextCreated-onEnable.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205956

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

4:15 PM Changeset in webkit [255209] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed build fix after r255167.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::detachRemoteParts):

4:02 PM Changeset in webkit [255208] by Russell Epstein

3 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r255128. rdar://problem/58921492

Tighten up some of the drag state machine logic
https://bugs.webkit.org/show_bug.cgi?id=206798

Reviewed by Wenson Hsieh.

page/EventHandler.h: Added shouldDispatchEventsToDragSourceElement function and renamed the existing dispatchDragSrcEvent function to dispatchEventToDragSourceElement.

page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): Call the renamed dispatchEventToDragSourceElement unconditionally, since it now has the smarts to only dispatch an event when we are supposed to. (WebCore::EventHandler::cancelDragAndDrop): Ditto. (WebCore::EventHandler::dragSourceEndedAt): Call the new shouldDispatchEventsToDragSourceElement function because of the null check it does for dataTransfer, before calling setDestinationOperation on the dataTransfer, since there isn't an obvious ironclad guarantee we might be here without an actual drag fully in process and a dataTransfer object allocated. Also call the renamed dispatchEventToDragSourceElement by its new name. (WebCore::EventHandler::shouldDispatchDragSourceEvents): Added. Checks thre three conditions that affect whether we should dispatch events to the drag source. First that there is a drag source. Second that there is a dataTransfer object, indicating that we got far enough in the logic to actually start a drag. Third that shouldDispatchEvents is true, indicating this is the type of drag that should be visible to the website content and so events should be dispatched. (WebCore::EventHandler::dispatchEventToDragSourceElement): Call shouldDispatchDragSourceEvents before dispatching the event, so that callers don't all have to do that check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255207] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r255114. rdar://problem/58920176

macCatalyst: Don't get any custom cursors in subframes
https://bugs.webkit.org/show_bug.cgi?id=206781
<rdar://problem/58698374>

Reviewed by Simon Fraser.

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::positionInformation): Adjust the hit test to allow child frame content, and reorganize the rest of the code to use the hit frame instead of the main frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255206] by Russell Epstein

9 edits
2 adds in branches/safari-609-branch

Cherry-pick r255108. rdar://problem/58920185

[iOS] Long pressing text inside a selection should update the selection
https://bugs.webkit.org/show_bug.cgi?id=206769
<rdar://problem/58704316>

Reviewed by Tim Horton.

Source/WebCore:

Remove hasSelectionAtPosition, which is no longer needed.

page/Page.cpp: (WebCore::Page::hasSelectionAtPosition const): Deleted.
page/Page.h:

Source/WebKit:

Makes it possible to update the selection using text interaction gestures inside an existing text selection. To
do this, we remove code that was previously required in order to disambiguate text selection and drag gestures.
However, since adopting asynchronous drag interaction SPI, this check has not been necessary.

The only other purpose of this check was to avoid triggering text selection gestures after canceling a drag
that did not begin (i.e. the touch location did not move). Instead of bailing in -textInteractionGestures:
shouldBeginAtPoint: and -hasSelectablePositionAtPoint:, we can achieve the same effect by simply resetting the
text interaction gestures when the drag lift begins (at which point we know the drag interaction is starting).
This also ensures that on iPad, in the case where the drag was cancelled by the page, long pressing may still
trigger text selection.

Test: editing/selection/ios/select-text-in-existing-selection.html

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm: (WebKit::InteractionInformationAtPosition::encode const): (WebKit::InteractionInformationAtPosition::decode):

Remove the hasSelectionAtPosition flag from position information, since we no longer need it.

UIProcess/ios/WKContentViewInteraction.mm: (-[UIGestureRecognizer _wk_cancel]):

Drive-by fix: just ignore the gesture if it is already disabled. This prevents us from causing a gesture
recognizer that was previously disabled to become enabled as a result of calling -_wk_cancel.

(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView cancelActiveTextInteractionGestures]):

Instead of making the text interaction gestures return NO from -gestureRecognizerShouldBegin:, explicitly cancel
the text interaction gestures that may select text.

(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::positionInformation):

Remove the hasSelectionAtPosition flag from position information, since we no longer need it.

LayoutTests:

Add a layout test to verify that it's possible to select text by long pressing inside an existing text
selection. The test is runnable on both iPad and iPhone, since it programmatically prevents dragstart.

editing/selection/ios/select-text-in-existing-selection-expected.txt: Added.
editing/selection/ios/select-text-in-existing-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255205] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r255105. rdar://problem/58920180

macCatalyst: Right clicking on links follows the link, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=206777
<rdar://problem/56586280>

Reviewed by Wenson Hsieh.

UIProcess/ios/WKMouseGestureRecognizer.mm: (-[WKMouseGestureRecognizer createMouseEventWithType:forEvent:]): (-[WKMouseGestureRecognizer touchesEnded:withEvent:]): I got 'button' and 'buttons' backwards.

'button' indicates which button the event is about, so in MouseUp,
it should still be 2.

'buttons' indicate which buttons are still down, so in MouseUp,
it should not include 2. Since we don't currently track mouse button
chording here, we'll just say "none". Leave a FIXME about that.

This makes WebCore's behavior correct, and now it doesn't follow the link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255204] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebKitLegacy

Cherry-pick r255094. rdar://problem/58921473

Remove check-xcfilelists.sh from WebKitLegacy Xcode build target
https://bugs.webkit.org/show_bug.cgi?id=206762
<rdar://problem/58825997>

Reviewed by Alexey Proskuryakov.

When check-xcfilelists.sh got added to the WebKitLegacy Xcode project,
it was also accidentally added to the WebKitLegacy build target. This
caused it to be treated as a "resource", and so was copied to the
output directory in the Resources sub-folder during the build. This
copying is not expected, needed, or desired. Remove
check-xcfilelists.sh from the target, which also removes it from the
Copy Resources build phase, which removes it from the
WebKitLegacy.framework/Resources directory.

WebKitLegacy.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255203] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r255087. rdar://problem/58920164

Fix internal Apple builds after r254411
https://bugs.webkit.org/show_bug.cgi?id=206723
<rdar://problem/58844735>

Reviewed by Maciej Stachowiak.

The default Xcode build configuration has changed between macOS 10.13
and macOS 10.15, such that references to some frameworks when bulding
for the latter don't work when building for the former. Fix this by
explicitly adding support for the desired build location rather than
assuming such support will be provided for us.

Configurations/WTF.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255202] by Russell Epstein

14 edits in branches/safari-609-branch

Cherry-pick r255076. rdar://problem/58920206

[Web Animations] Support multiple CSS Animations with the same name in animation-name
https://bugs.webkit.org/show_bug.cgi?id=206688

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark some new WPT progressions.

web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt:
web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt:
web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement-expected.txt:

Source/WebCore:

AnimationTimeline would keep track of registered CSS Animations by name for a given element in m_elementToCSSAnimationByName which would map one CSSAnimation
per String (the animation-name) for a given Element. However, within the same animation-name property, the name of a given @keyframes rules may appear more
than once, and the CSS Animations specification explains how to handle this scenario.

We now correctly handle this by replacing m_elementToCSSAnimationByName with the new m_elementToCSSAnimationsCreatedByMarkupMap which simply maps an Element
to a ListHashSet of CSSAnimation objects. Removing the string that appeared in animation-name to create this animation requires us to keep the AnimationList
used for the last style update for sorting purposes, since having multiple instances of the same string would not allow disambiguation when sorting the
KeyframeEffectStack.

So we also replace m_cssAnimationNames, a Vector<String>, with m_cssAnimationList, a RefPtr<const AnimationList>, and use this to compare Animation objects
stored in the AnimationList against the backing animation of each CSSAnimation.

Storing the AnimationList on the KeyframeEffectStack also has the benefit of allowing us to use this as the previous state when updating CSS Animations in
AnimationTimeline::updateCSSAnimationsForElement(). We used to rely on the previous RenderStyle provided to that function, but it's possible that this style
is null and we would unnecessarily create additional CSSAnimation objects for animations that actually were retained since the last time CSS Animations were
invalidated. We now use the stored AnimationList on the invalidated element's KeyframeEffectStack and create a new animation list that will replace the old
list stored in the m_elementToCSSAnimationsCreatedByMarkupMap map for that element. We can also compare the old list with the new list to find out which
animations are no longer current.

Finally, we refactor things a bit to have some new aliases AnimationCollection and CSSAnimationCollection instead of using ListHashSet<> in our types.

animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::animationWasAddedToElement): Use the new AnimationCollection alias. (WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement): We no longer need to do any work for CSSAnimation here since the m_elementToCSSAnimationByName map is no more and the m_elementToCSSAnimationsCreatedByMarkupMap that replaces it is updated in updateCSSAnimationsForElement() and elementWasRemoved(). (WebCore::AnimationTimeline::animationsForElement const): Since animations are correctly sorted accounting for their composite order in KeyframeEffectStack, call KeyframeEffectStack::sortedEffects() when we're called with Ordering::Sorted. (WebCore::AnimationTimeline::removeCSSAnimationCreatedByMarkup): New method called by elementWasRemoved() to ensure that when an element is removed, we remove its CSSAnimation objects from the new m_elementToCSSAnimationsCreatedByMarkupMap and also update the AnimationList on the relevant KeyframeEffectStack. (WebCore::AnimationTimeline::elementWasRemoved): Call the new removeCSSAnimationCreatedByMarkup() method before canceling a CSSAnimation. (WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement): Call the new removeCSSAnimationCreatedByMarkup() method before canceling a CSSAnimation. (WebCore::AnimationTimeline::updateCSSAnimationsForElement): Use the AnimationList recoreded on the relevant KeyframeEffectStack to determine which CSSAnimation objects to create, cancel or merely update depending on the AnimationList in the current style.
animation/AnimationTimeline.h:
animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::getAnimations const): Use compareAnimationsByCompositeOrder() to correctly sort CSS Animations since they are no longer guaranteed to be stored in the relevant map in the expected order.
animation/KeyframeEffectStack.cpp: (WebCore::KeyframeEffectStack::ensureEffectsAreSorted): Use the new m_cssAnimationList instead of the old m_cssAnimationNames when sorting effects. (WebCore::KeyframeEffectStack::setCSSAnimationList): (WebCore::KeyframeEffectStack::setCSSAnimationNames): Deleted.
animation/KeyframeEffectStack.h: (WebCore::KeyframeEffectStack::cssAnimationList const): (WebCore::KeyframeEffectStack::cssAnimationNames const): Deleted.
animation/WebAnimation.cpp: (WebCore::WebAnimation::commitStyles): Use the new KeyframeEffectStack::cssAnimationList() instead of the old KeyframeEffectStack::cssAnimationNames().
animation/WebAnimationUtilities.cpp: (WebCore::compareAnimationsByCompositeOrder): Update the composite order comparison utility to use an AnimationList rather than a list of animation names.
animation/WebAnimationUtilities.h:
platform/animation/AnimationList.h: (WebCore::AnimationList::copy const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255201] by Russell Epstein

5 edits in branches/safari-609-branch/Source

Cherry-pick r255046. rdar://problem/58920204

macCatalyst: I-Beam is too conservative, doesn't show up in editable areas with no text
https://bugs.webkit.org/show_bug.cgi?id=206716
<rdar://problem/58359523>

Reviewed by Simon Fraser.

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::lineCaretExtent): (WebKit::populateCaretContext): (WebKit::WebPage::positionInformation): Instead of uniting the caret position for the first and last position on the line to find the I-Beam region, use the bounds of the selection rect for the line, which extends beyond existing text, matching our traditional behavior of showing the I-Beam over blank regions.

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
editing/VisiblePosition.h: Expose the bounds of the possible selection for the line that the given position belongs to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255200] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r255043. rdar://problem/58920158

[EME] Key renewal fails when using AVContentKeyReportGroup
https://bugs.webkit.org/show_bug.cgi?id=206694
<rdar://problem/58628345>

Patch by Jer Noble <jer.noble@apple.com> on 2020-01-23
Reviewed by Eric Carlson.

When a CDMInstanceSession has a AVContentKeyReportGroup, it doesn't have an AVContentKeySession; it has
to get the session from it's parent CDMInstance to request key renewal.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255199] by Russell Epstein

4 edits in branches/safari-609-branch

Cherry-pick r254950. rdar://problem/58856023

REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
<rdar://problem/58544942> and https://bugs.webkit.org/show_bug.cgi?id=206608

Reviewed by Alex Christensen.

Source/WebCore:

Covered by new API test.

bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld): Address a FIXME added in 253519 which had predicted this problem.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255198] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254896. rdar://problem/58920174

[EME] Only emit an array of persistent-usage-records when we discover > 1
https://bugs.webkit.org/show_bug.cgi?id=206205
<rdar://problem/58691769>

Patch by Jer Noble <jer.noble@apple.com> on 2020-01-21
Reviewed by Eric Carlson.

The persistent-usage-record cache should never have more than one record per sessionId, but
that assumption is not enforced in the file format. To not break clients that aren't
expecting a serialized plist array, only emit an array when more than one matching data item
is found.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255197] by Russell Epstein

2 edits in branches/safari-609-branch/Tools

Cherry-pick r254838. rdar://problem/58856018

REGRESSION(r254788): mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla fails
https://bugs.webkit.org/show_bug.cgi?id=206477
<rdar://problem/58714886>

Unreviewed.

In r232603 when we added test specific options, the implementation did not
clear the test specific options before parsing each test inside a yaml
file. It only worked for tests where we ran each js file inside a directory.
This patch makes it also work for yaml files.

Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255196] by Russell Epstein

4 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254834. rdar://problem/58856027

REGRESSION (r250655?): [ Mac Debug ] inspector/runtime/promise-native-getter.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=206303
<rdar://problem/58612520>

Reviewed by Darin Adler.

Rework the test to not be reliant on real world timing.

inspector/runtime/promise-native-getter.html:
inspector/runtime/promise-native-getter-expected.txt:
platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255195] by Russell Epstein

5 edits
1 add in branches/safari-609-branch

Cherry-pick r254788. rdar://problem/58856018

Air O0 should have better stack allocation
https://bugs.webkit.org/show_bug.cgi?id=206436

Reviewed by Tadeu Zagallo.

JSTests:

wasm/stress/dont-stack-overflow-in-air.js: Added.

Source/JavaScriptCore:

This patch adds a simple stack slot allocator to Air O0 to make code
use smaller stack frames. The huge stack frames from the old stack
allocator were leading to stack overflows in some programs. Before,
each Tmp got its own stack slot. The new allocator works similar to O0's
register allocator. This stack allocator linearizes the program and uses live
range end as an opportunity to place the stack slot on a free list of
available stack slots. This patch also fixes an issue in our linearization code
where the head of a block and the tail of another block would share the
same linearization index. This didn't matter for register allocation, but
does matter for the stack allocator. So "live at head", and "live at tail"
now get their own linearization index.

b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp: (JSC::B3::Air::GenerateAndAllocateRegisters::buildLiveRanges): (JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration): (JSC::B3::Air::GenerateAndAllocateRegisters::generate):
b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
b3/air/AirLiveness.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:02 PM Changeset in webkit [255194] by Russell Epstein

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254692. rdar://problem/58811413

REGRESSION (r254291): [ Catalina wk2 Debug ] Flaky ASSERT on fast/images/animated-image-loop-count.html
https://bugs.webkit.org/show_bug.cgi?id=206068
<rdar://problem/58480028>

Patch by Chris Lord <Chris Lord> on 2020-01-16
Reviewed by Chris Dumez.

No new tests, covered by existing tests.

platform/graphics/ImageSource.cpp: (WebCore::ImageSource::startAsyncDecodingQueue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:01 PM Changeset in webkit [255193] by Russell Epstein

8 edits
2 adds in branches/safari-609-branch

Cherry-pick r254559. rdar://problem/58920170

Long continuation chain could lead to stack exhaustion
https://bugs.webkit.org/show_bug.cgi?id=206271
<rdar://problem/41189798>

Reviewed by Simon Fraser.

Source/WebCore:

This patch replaces the recursive approach with an iterative one
to collect absolute quads across continuation.

Test: fast/inline/long-continuation-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteQuads const): (WebCore::RenderBlock::absoluteQuadsIgnoringContinuation const):
rendering/RenderBlock.h:
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::collectAbsoluteQuadsForContinuation const):
rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::absoluteQuadsIgnoringContinuation const):
rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteQuads const): (WebCore::RenderInline::absoluteQuadsIgnoringContinuation const):
rendering/RenderInline.h:

LayoutTests:

fast/inline/long-continuation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:01 PM Changeset in webkit [255192] by Russell Epstein

3 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254546. rdar://problem/58811346

REGRESSION: fast/shadow-dom/link-element-in-shadow-tree.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=171784
<rdar://problem/58123584>

Reviewed by Antti Koivisto.

The timeout is likely caused by the stylesheet not loading within 100ms timeout in the very first test case.
Load and cache the stylesheet before any test cases run to avoid this timeout.

fast/shadow-dom/link-element-in-shadow-tree.html:
platform/mac-wk2/TestExpectations: Removed the flaky test expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:49 PM Changeset in webkit [255191] by Devin Rousso

54 edits
1 move
2 adds in trunk

Web Inspector: unable to evaluate in the isolated world of content scripts injected by safari app extensions
https://bugs.webkit.org/show_bug.cgi?id=206110
<rdar://problem/16945643>

Reviewed by Timothy Hatcher, Joseph Pecoraro, and Brian Burg.

In addition to evaluating in subframe execution contexts, add the ability for Web Inspector
to evaluate in non-normal isolated worlds.

Source/JavaScriptCore:

inspector/protocol/Runtime.json:

Introduce an ExecutionContextType enum instead of isPageContext so the frontend can
decide whether/how to show a picker for that execution context.

Source/WebCore:

Test: inspector/runtime/executionContextCreated-isolated-world.html

bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::type const): Added.
(WebCore::DOMWrapperWorld::isNormal const):
(WebCore::DOMWrapperWorld::name const): Added.

bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):

bindings/js/ScriptController.h:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWorld):

bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::initNormalWorld):
Require that a name is specified when creating an isolated world (except the normal world)
so that Web Inspector has something to show in the execution context picker.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):

inspector/agents/InspectorPageAgent.h:
inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):

inspector/agents/page/PageDebuggerAgent.h:
inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearWindowObjectInWorld):

inspector/agents/page/PageRuntimeAgent.h:
inspector/agents/page/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::didClearWindowObjectInWorld):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
(WebCore::toProtocol): Added.
(WebCore::PageRuntimeAgent::notifyContextCreated):
Allow this instrumentation call to pass through to the agents for non-Normal worlds.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureIsolatedWorld):

html/HTMLPlugInImageElement.cpp:

(WebCore::plugInImageElementIsolatedWorld):

Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::isolatedWorld):
Mark these worlds as Internal.

testing/Internals.idl:
testing/Internals.h:
testing/Internals.cpp:

(WebCore::Internals::evaluateInWorldIgnoringException): Added.

Source/WebInspectorUI:

UserInterface/Models/ExecutionContext.js:

(WI.ExecutionContext):
(WI.ExecutionContext.typeFromPayload): Added.
(WI.ExecutionContext.prototype.get type): Added.
(WI.ExecutionContext.prototype.get isPageContext): Deleted.

UserInterface/Models/ExecutionContextList.js:

(WI.ExecutionContextList.prototype.add):

UserInterface/Models/Frame.js:

(WI.Frame.prototype.addExecutionContext):

UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.executionContextCreated):
The Normal execution context (of which there should only be one) is considered the "page"
execution context.

UserInterface/Protocol/DirectBackendTarget.js:

(WI.DirectBackendTarget):

UserInterface/Protocol/PageTarget.js:

(WI.PageTarget):

UserInterface/Protocol/WorkerTarget.js:

(WI.WorkerTarget):
Default to a Normal execution context.

UserInterface/Views/QuickConsole.js:

(WI.QuickConsole):
(WI.QuickConsole.prototype._displayNameForExecutionContext): Added.
(WI.QuickConsole.prototype._resolveDesiredActiveExecutionContext): Added.
(WI.QuickConsole.prototype._setActiveExecutionContext): Added.
(WI.QuickConsole.prototype._updateActiveExecutionContextDisplay): Added.
(WI.QuickConsole.prototype._populateActiveExecutionContextNavigationItemContextMenu): Added.
(WI.QuickConsole.prototype._handleConsoleSavedResultAliasSettingChanged): Added.
(WI.QuickConsole.prototype._handleEngineeringShowInternalExecutionContextsSettingChanged): Added.
(WI.QuickConsole.prototype._handleFramePageExecutionContextChanged): Added.
(WI.QuickConsole.prototype._handleFrameExecutionContextsCleared): Added.
(WI.QuickConsole.prototype._handleDebuggerActiveCallFrameDidChange): Added.
(WI.QuickConsole.prototype._handleActiveExecutionContextChanged): Added.
(WI.QuickConsole.prototype._handleTransitionPageTarget): Added.
(WI.QuickConsole.prototype._handleTargetRemoved): Added.
(WI.QuickConsole.prototype._handleInspectedNodeChanged): Added.
(WI.QuickConsole.prototype._updateStyles):
(WI.QuickConsole.prototype.get navigationBar): Deleted.
(WI.QuickConsole.prototype._pageTargetTransitioned): Deleted.
(WI.QuickConsole.prototype._initializeMainExecutionContextPathComponent): Deleted.
(WI.QuickConsole.prototype.layout): Deleted.
(WI.QuickConsole.prototype._preferredNameForFrame): Deleted.
(WI.QuickConsole.prototype._selectExecutionContext): Deleted.
(WI.QuickConsole.prototype._updateAutomaticExecutionContextPathComponentTooltip): Deleted.
(WI.QuickConsole.prototype._executionContextPathComponentsToDisplay): Deleted.
(WI.QuickConsole.prototype._rebuildExecutionContextPathComponents): Deleted.
(WI.QuickConsole.prototype._framePageExecutionContextsChanged): Deleted.
(WI.QuickConsole.prototype._frameExecutionContextsCleared): Deleted.
(WI.QuickConsole.prototype._activeExecutionContextChanged): Deleted.
(WI.QuickConsole.prototype._createExecutionContextPathComponent): Deleted.
(WI.QuickConsole.prototype._compareExecutionContextPathComponents): Deleted.
(WI.QuickConsole.prototype._insertOtherExecutionContextPathComponent): Deleted.
(WI.QuickConsole.prototype._removeOtherExecutionContextPathComponent): Deleted.
(WI.QuickConsole.prototype._insertExecutionContextPathComponentForFrame): Deleted.
(WI.QuickConsole.prototype._removeExecutionContextPathComponentForFrame): Deleted.
(WI.QuickConsole.prototype._targetAdded): Deleted.
(WI.QuickConsole.prototype._targetRemoved): Deleted.
(WI.QuickConsole.prototype._pathComponentSelected): Deleted.
(WI.QuickConsole.prototype._pathComponentClicked): Deleted.
(WI.QuickConsole.prototype._debuggerActiveCallFrameDidChange): Deleted.

UserInterface/Views/QuickConsole.css:

(.quick-console > .console-prompt):
(.quick-console > .navigation-bar):
(.quick-console > .navigation-bar .active-execution-context): Added.
(.quick-console > .navigation-bar .active-execution-context > .selector-arrows): Added.
(.quick-console > .navigation-bar .active-execution-context:not(.automatic)): Added.
(.quick-console > .navigation-bar .active-execution-context:not(.automatic) > .selector-arrows): Added.
(.quick-console .execution-context): Deleted.
(.quick-console > .navigation-bar > .hierarchical-path .execution-context): Deleted.
(.quick-console > .navigation-bar > .hierarchical-path .execution-context .separator): Deleted.
(.quick-console > .navigation-bar > .hierarchical-path:not(.automatic-execution-context)): Deleted.
(.quick-console > .navigation-bar > .hierarchical-path:not(.automatic-execution-context) .execution-context): Deleted.
(.quick-console > .navigation-bar > .hierarchical-path:not(.automatic-execution-context) .execution-context .selector-arrows): Deleted.
Replace the WI.HierarchicalPathNavigationItem with a plain WI.NavigationItem that shows
a WI.ContextMenu with all valid execution contexts organized as follows:

Auto - <display name for execution context of inspected DOM node>
----------
Main Frame Normal Execution Context

All User Exection Contexts for the Main Frame
All Internal Exection Contexts for the Main Frame (with the engineering setting)

Frames

Frame Normal Execution Context

All User Exection Contexts for the Frame
All Internal Exection Contexts for the Frame (with the engineering setting)

...

Workers

Worker Execution Context
...

Everything is checkmark selectable other than the separator, "Frames", and "Workers".

UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager):
(WI.RuntimeManager.prototype._frameExecutionContextsCleared): Deleted.
Let the UI (WI.QuickConsole) decide when to automatically update the active execution
context when a frame is removed that owned the active execution context.

UserInterface/Controllers/TargetManager.js:

(WI.TargetManager.prototype.get workerTargets): Added.
(WI.TargetManager.prototype._terminatePageTarget):
Convenience function for getting the list of worker targets.

UserInterface/Views/GroupNavigationItem.js:

(WI.GroupNavigationItem.prototype.update):
(WI.GroupNavigationItem.prototype.didAttach):
Update the items whenever the group updates.

UserInterface/Main.html:
UserInterface/Views/SizesToFitNavigationBar.js: Renamed from Source/WebInspectorUI/UserInterface/Views/QuickConsoleNavigationBar.js.

(WI.SizesToFitNavigationBar):
(WI.SizesToFitNavigationBar.prototype.get sizesToFit):
Rename to allow for other use cases.

UserInterface/Views/ContextMenu.js:

(WI.ContextSubMenuItem.prototype.appendHeader): Added.
Convenience method for creating a disabled item.

UserInterface/Base/Setting.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):
Create an engineering setting that controls whether Internal execution contexts are shown.

UserInterface/Test/InspectorProtocol.js:

(InspectorProtocol.addEventListener):
(InspectorProtocol.removeEventListener): Added.

Localizations/en.lproj/localizedStrings.js:

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::create):

WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserContentWorlds):

WebProcess/InjectedBundle/API/glib/WebKitScriptWorld.cpp:

(webkit_script_world_new):
(webkit_script_world_new_with_name):
Treat isolated worlds created by API calls as User worlds.

Source/WebKitLegacy/mac:

WebView/WebScriptWorld.mm:

(-[WebScriptWorld init]):
Treat isolated worlds created by API calls as User worlds.

Source/WebKitLegacy/win:

WebScriptWorld.cpp:

(WebScriptWorld::createInstance):
Treat isolated worlds created by API calls as User worlds.

LayoutTests:

inspector/runtime/executionContextCreated-isolated-world.html: Added.
inspector/runtime/executionContextCreated-isolated-world-expected.txt: Added.

inspector/runtime/change-execution-context-identifier.html:
inspector/runtime/change-execution-context-identifier-expected.txt:

Don't expect the active execution context to change when the owner frame is removed, as that
is now handled by the UI (WI.QuickConsole) instead of the WI.RuntimeManager.

inspector/runtime/executionContextCreated-onEnable.html:

Ignore internal worlds.

3:48 PM Changeset in webkit [255190] by Truitt Savell

3 edits in trunk/LayoutTests

[macOS iOS ] animations/animation-direction-normal.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206685

Unreviewed test gardening

I removed an old crash expectation for animations/animation-direction-normal.html is ios wk2 expectations.

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/ios-wk2/TestExpectations:
platform/mac/TestExpectations:

3:37 PM Changeset in webkit [255189] by Chris Dumez

14 edits
5 deletes in trunk

Unreviewed, revert r253984 as it appears to be causing assertion leaks.
https://bugs.webkit.org/show_bug.cgi?id=205687

Source/WebKit:

Configurations/WebKit.xcconfig:
Platform/spi/ios/RunningBoardServicesSPI.h: Removed.
Scripts/process-entitlements.sh:
Shared/DependencyProcessAssertion.cpp: Removed.
Shared/DependencyProcessAssertion.h: Removed.
Shared/NativeWebTouchEvent.h:
Shared/ios/DependencyProcessAssertionIOS.mm: Removed.
Sources.txt:
SourcesCocoa.txt:
UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::processWasResumed):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::processTaskStateDidChange):
(WebKit::WebProcess::releaseProcessWasResumedAssertions):

WebKitLibraries:

WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd: Removed.

3:29 PM Changeset in webkit [255188] by jiewen_tan@apple.com

2 edits in trunk/Source/WebKit

Unreviewed, a build fix after r255111

UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

Adding some missing headers.

3:27 PM Changeset in webkit [255187] by Jon Davis

2 edits in trunk/Websites/webkit.org

Add support for table of contents to Web Inspector pages
https://bugs.webkit.org/show_bug.cgi?id=206845

Reviewed by Devin Rousso.

wp-content/plugins/table-of-contents.php:

3:22 PM Changeset in webkit [255186] by stephan.szabo@sony.com

2 edits in trunk/Source/JavaScriptCore

Python 3: generate-js-builtins hits SyntaxWarning for "is 0"
https://bugs.webkit.org/show_bug.cgi?id=206840

Reviewed by Jonathan Bedard.

Scripts/generate-js-builtins.py: Replace is 0 with == 0

3:20 PM Changeset in webkit [255185] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: [iOS] http/wpt/cache-storage/quota-third-party.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206681

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/ios-wk2/TestExpectations:

3:12 PM Changeset in webkit [255184] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS ] inspector/heap/tracking.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206684

Unreviewed test gardening

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/mac-wk1/TestExpectations:

3:10 PM Changeset in webkit [255183] by Jon Davis

3 edits in trunk/Websites/webkit.org

Fix submenu behavior for narrow viewports
https://bugs.webkit.org/show_bug.cgi?id=206835

Reviewed by Devin Rousso.

wp-content/themes/webkit/header.php:
wp-content/themes/webkit/style.css:

(@media only screen and (max-width: 920px) header .menu > .menu-item:hover > .sub-menu,):
(@media only screen and (max-width: 920px) header .menu > .menu-item > .menu-toggle:checked ~ .sub-menu): Deleted.

3:07 PM Changeset in webkit [255182] by Truitt Savell

2 edits in trunk/LayoutTests

[iOS Release] compositing/video/poster.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206678

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/ios-wk2/TestExpectations:

3:05 PM Changeset in webkit [255181] by Truitt Savell

2 edits in trunk/LayoutTests

[Mac wk2 Release] fast/html/marquee-child-wrap.html flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206704

Reviewed by Jonathan Bedard.

Added a scrollDelay to the test.

fast/html/marquee-child-wrap.html:

2:59 PM Changeset in webkit [255180] by Truitt Savell

3 edits in trunk/LayoutTests

[ macOS iOS ] animations/play-state-paused.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206682

Unreviewed test gardening

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/ios-wk2/TestExpectations:
platform/mac/TestExpectations:

2:54 PM Changeset in webkit [255179] by Noam Rosenthal

2 edits in trunk/Tools

Unreviewed. Adding myself back as a reviewer.

Scripts/webkitpy/common/config/contributors.json:

2:51 PM Changeset in webkit [255178] by Chris Dumez

5 edits in trunk/Source/WebKit

Unreviewed, revert r254210 as it seems to be causing process assertion leaks.
https://bugs.webkit.org/show_bug.cgi?id=205836

Shared/AuxiliaryProcess.cpp:

(WebKit::AuxiliaryProcess::initializeConnection):

Shared/AuxiliaryProcess.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

WebProcess/WebProcess.h:

2:29 PM Changeset in webkit [255177] by Truitt Savell

2 edits in trunk/LayoutTests

[iOS] legacy-animation-engine/animations/stop-animation-on-suspend.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206667

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/ios-wk2/TestExpectations:

2:17 PM Changeset in webkit [255176] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206680

Unreviewed test gardening

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/mac-wk1/TestExpectations:

2:05 PM Changeset in webkit [255175] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION (r254699): [ iOS ] fast/forms/validationMessage.html is flaky and timing out
https://bugs.webkit.org/show_bug.cgi?id=206630

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/ios-wk2/TestExpectations:

2:00 PM Changeset in webkit [255174] by Truitt Savell

2 edits in trunk/LayoutTests

[ macOS WK1 ] fast/forms/textarea/textarea-state-restore.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206679

Unreviewed test gardening

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/mac-wk1/TestExpectations:

1:50 PM Changeset in webkit [255173] by Brent Fulgham

3 edits in trunk/Source/WebKit

Remove last bits of location services rules
https://bugs.webkit.org/show_bug.cgi?id=206023
<rdar://problem/58452505>

Reviewed by Per Arne Vollan.

Remove the user preferences that were allowed by the sandbox back when location services
were used in the process.

Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

1:49 PM Changeset in webkit [255172] by Truitt Savell

2 edits in trunk/LayoutTests

[ iOS Release ] http/tests/security/contentSecurityPolicy/module-eval-blocked-in-external-script.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=206616

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/ios-wk2/TestExpectations:

1:46 PM Changeset in webkit [255171] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r250009): testair crashes in (anonymous namespace)::matchAll
<https://webkit.org/b/206797>
<rdar://problem/58893221>

Reviewed by Yusuke Suzuki.

b3/air/testair.cpp:

((anonymous namespace)::matchAll): Don't replace str in the
body of the for loop since match references it.

1:41 PM Changeset in webkit [255170] by Ryan Haddad

4 edits in trunk/Source/WebCore

Crash in WebCore::HTMLMediaElement::detachMediaSource()
https://bugs.webkit.org/show_bug.cgi?id=206766

Patch by Peng Liu <Peng Liu> on 2020-01-27
Reviewed by Jer Noble.

Use WeakPtr<HTMLMediaElement> in MediaSource instead of a raw pointer.
In addition, we need to detach a MediaSource from an HTMLMediaElement before the HTMLMediaElement forgets the reference to the MediaSource.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::attachToElement):

Modules/mediasource/MediaSource.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

1:37 PM Changeset in webkit [255169] by Ryan Haddad

4 edits in trunk/Source

Unreviewed, rolling out r255159.

Broke the watchOS build.

Reverted changeset:

"Fix OpenSource iphoneos arm64e build"
https://bugs.webkit.org/show_bug.cgi?id=206703
https://trac.webkit.org/changeset/255159

1:36 PM Changeset in webkit [255168] by Truitt Savell

2 edits in trunk/LayoutTests

[Mac wk2 Release] imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state.html flaky fail
https://bugs.webkit.org/show_bug.cgi?id=206746

Unreviewed test gardening

Patch by Jason Lawrence <Jason_Lawrence> on 2020-01-27

platform/mac-wk2/TestExpectations:

1:31 PM Changeset in webkit [255167] by Andres Gonzalez

24 edits
1 copy
1 add in trunk/Source/WebCore

Crash in AXIsolatedObject destruction.
https://bugs.webkit.org/show_bug.cgi?id=206828

Reviewed by Chris Fleizach.

The previous AXCoreObject::detach method became detachRemoteParts,

since this method detaches all references to and from other objects.

The new AXCoreObject::detach method performs three distinctive

operations:

Detaches the platform wrapper.
Detaches all remote references to and from other objects.
Sets the object ID to InvalidAXID.

The detachPlatformWrapper method allows for platform-specific

customizations.

Added accessibility/isolatedtree/mac/AXIsolatedobject.mm.

PlatformMac.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):

accessibility/AXObjectCache.h:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::detachRemoteParts):
(WebCore::AccessibilityNodeObject::detach): Became detachRemoteParts.

accessibility/AccessibilityNodeObject.h:
accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::detachRemoteParts):
(WebCore::AccessibilityObject::detach): Became detachRemoteParts.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::detachWrapper):
(WebCore::AXCoreObject::detach):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::detachRemoteParts):
(WebCore::AccessibilityRenderObject::detach): Became detachRemoteParts.

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::detachRemoteParts):
(WebCore::AccessibilityScrollView::detach): Became detachRemoteParts.

accessibility/AccessibilityScrollView.h:
accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::detachPlatformWrapper):

accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::detachWrapper): Deleted, no longer used in COCOA platforms.

accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::detachPlatformWrapper):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::detachRemoteParts):
(WebCore::AXIsolatedObject::detach): Became detachRemoteParts.
(WebCore::AXIsolatedObject::disconnect): Replaced with AXCoreObject::detach.

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::removeTreeForPageID):
(WebCore::AXIsolatedTree::applyPendingChanges):

accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:

(WebCore::AXIsolatedObject::detachPlatformWrapper):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::detachWrapper): Deleted, no longer used in COCOA platforms.

accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::detachPlatformWrapper):

accessibility/win/AccessibilityObjectWin.cpp:

(WebCore::AccessibilityObject::detachPlatformWrapper):

1:29 PM Changeset in webkit [255166] by youenn@apple.com

2 edits in trunk/LayoutTests/imported/w3c

[iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206683
<rdar://problem/58841339>

Reviewed by Eric Carlson.

web-platform-tests/webrtc/RTCDTMFSender-helper.js:

Move from async_test to promise_test to improve repeatability of the tests.

1:29 PM Changeset in webkit [255165] by Ryan Haddad

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r255161.

Broke the watchOS build.

Reverted changeset:

"Crash in WebCore::HTMLMediaElement::detachMediaSource()"
https://bugs.webkit.org/show_bug.cgi?id=206766
https://trac.webkit.org/changeset/255161

1:25 PM Changeset in webkit [255164] by Truitt Savell

3 edits in trunk/LayoutTests

[ Macos iOS ] http/tests/workers/service/basic-timeout.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206834

Unreviewed test gardening.

Patch by Jacob Uphoff <Jacob Uphoff> on 2020-01-27

platform/ios/TestExpectations:
platform/mac-wk2/TestExpectations:

1:14 PM Changeset in webkit [255163] by Keith Rollin

2 edits in trunk/Tools

Fix internal builds
https://bugs.webkit.org/show_bug.cgi?id=206790
<rdar://problem/58888951>

Reviewed by Maciej Stachowiak.

TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In
some circumstances, this file can include <os/thread_self_restrict.h>,
which in turn includes <machine/cpu_capabilities.h>. This latter file
does not exist at a standard location, and the build fails due to not
being able to find the file. Fix this by adding a path to it to the
build command line.

DumpRenderTree/mac/Configurations/Base.xcconfig:

12:54 PM Changeset in webkit [255162] by commit-queue@webkit.org

12 edits
2 adds
2 deletes in trunk

Support 'allow="fullscreen"' feature policy
https://bugs.webkit.org/show_bug.cgi?id=206806
<rdar://problem/55640448>

Patch by Jer Noble <jer.noble@apple.com> on 2020-01-27
Reviewed by Youenn Fablet.

Source/WebCore:

Test: http/tests/fullscreen/fullscreen-feature-policy.html

The unprefixed version of the Fullscreen API has deprecated the 'allowfullscreen' iframe
attribute in favor of the 'allow="fullscreen"' style attribute used by Feature Policy.
Add support for such, including the specified handling for the legacy 'allowfullscreen'
attribute.

Note: this patch will (intentionally) change the default behavior of <iframe>s. Previously
any <iframe> without the "allowfullscreen" attribute would not be allowed to enter fullscreen
mode. After this patch, <iframes> without the legacy attribute or an explicit fullscreen
Feature Policy will be allowed to enter fullscreen so long as their origin is the same as
the top document (and that all parent iframes are also allowed to enter fullscreen).

dom/FullscreenManager.cpp:

(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::isFullscreenEnabled const):
(WebCore::isAttributeOnAllOwners): Deleted.
(WebCore::FullscreenManager::fullscreenIsAllowedForElement const): Deleted.

dom/FullscreenManager.h:
html/FeaturePolicy.cpp:

(WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

html/FeaturePolicy.h:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::featurePolicy const):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):
(WebCore::isSyncXHRAllowedByFeaturePolicy): Deleted.

LayoutTests:

fullscreen/full-screen-enabled-prefixed.html:
fullscreen/full-screen-enabled.html:
fullscreen/full-screen-frameset-expected.txt: Removed.
fullscreen/full-screen-frameset.html: Removed.
fullscreen/full-screen-iframe-not-allowed.html:
fullscreen/full-screen-restrictions.html:
http/tests/fullscreen/fullscreen-feature-policy-expected.txt: Added.
http/tests/fullscreen/fullscreen-feature-policy.html: Added.

12:29 PM Changeset in webkit [255161] by Peng Liu

4 edits in trunk/Source/WebCore

Crash in WebCore::HTMLMediaElement::detachMediaSource()
https://bugs.webkit.org/show_bug.cgi?id=206766

Reviewed by Jer Noble.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::attachToElement):

Modules/mediasource/MediaSource.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

12:18 PM Changeset in webkit [255160] by rmorisset@apple.com

2 edits in trunk/Tools

Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
https://bugs.webkit.org/show_bug.cgi?id=206833

Reviewed by Jonathan Bedard.

Just a trivial fix to the arguments validation code of the script.

Scripts/set-webkit-configuration:

12:07 PM Changeset in webkit [255159] by Jonathan Bedard

4 edits in trunk/Source

Fix OpenSource iphoneos arm64e build
https://bugs.webkit.org/show_bug.cgi?id=206703

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

runtime/MachineContext.h:

Source/WTF:

wtf/PlatformUse.h: Add USE(DARWIN_REGISTER_MACROS) check.

11:54 AM Changeset in webkit [255158] by commit-queue@webkit.org

54 edits
4 adds in trunk

Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
https://bugs.webkit.org/show_bug.cgi?id=204713

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-01-27
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-throttling-outside-viewport.html

requestAnimationFrame is throttled by a timer although its callback are
serviced by the page RenderingUpdate. This led to excessive rAF firing
which makes it more than the preferred frame per seconds.

The solution is to have two throttling types:

1) Page throttling (or full throttling) which slows down all the steps of

RenderingUpdate for the main document and all the sub-documents.

2) Document throttling (or partial throttling) which only slows down the

rAF of a certain document.

Headers.cmake:
WebCore.xcodeproj/project.pbxproj:

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animationInterval const):
(WebCore::DocumentTimeline::updateThrottlingState): Deleted.

animation/DocumentTimeline.h:

There is no need to have DocumentTimeline throttling. It is already
throttled when the page RenderingUpdate is throttled.

dom/Document.cpp:

(WebCore::Document::requestAnimationFrame):
(WebCore::Document::updateLastHandledUserGestureTimestamp):
LowPowerMode throttling is now handled by the page. So remove its handling
in the Document side.

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::page const):
(WebCore::ScriptedAnimationController::preferredScriptedAnimationInterval const):
(WebCore::ScriptedAnimationController::interval const):
(WebCore::ScriptedAnimationController::isThrottled const):
(WebCore::ScriptedAnimationController::isThrottledRelativeToPage const):
(WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const):
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::throttlingReasonToString): Deleted.
(WebCore::throttlingReasonsToString): Deleted.
(WebCore::ScriptedAnimationController::addThrottlingReason): Deleted.
(WebCore::ScriptedAnimationController::removeThrottlingReason): Deleted.
(WebCore::ScriptedAnimationController::animationTimerFired): Deleted.

dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::addThrottlingReason):
(WebCore::ScriptedAnimationController::removeThrottlingReason):
Get rid of the rAF throttling timer. Service the rAF callback only when
the period from the current time stamp till the last service time stamp
is greater than the preferred rAF interval .

page/FrameView.cpp:

(WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState):
ThrottlingReason is now defined outside ScriptedAnimationController.

page/Page.cpp:

(WebCore::Page::renderingUpdateThrottlingEnabled const):
(WebCore::Page::renderingUpdateThrottlingEnabledChanged):
(WebCore::Page::isRenderingUpdateThrottled const):

(WebCore::Page::preferredRenderingUpdateInterval const):
Calculate the preferred RenderingUpdate interval from the throttling
reasons.

(WebCore::Page::setIsVisuallyIdleInternal):
(WebCore::Page::handleLowModePowerChange):
Call adjustRenderingUpdateFrequency() when isLowPowerModeEnabled or
IsVisuallyIdle is toggled.

(WebCore::updateScriptedAnimationsThrottlingReason): Deleted.

page/Page.h:

page/RenderingUpdateScheduler.cpp:

(WebCore::RenderingUpdateScheduler::adjustFramesPerSecond):
(WebCore::RenderingUpdateScheduler::adjustRenderingUpdateFrequency):
Change the preferredFramesPerSecond of the DisplayRefreshMonitor if the
throttling is not aggressive e.g. 10_s. Otherwise use the timer.

(WebCore::RenderingUpdateScheduler::scheduleTimedRenderingUpdate):
Call adjustFramesPerSecond() when DisplayRefreshMonitor is created.

(WebCore::RenderingUpdateScheduler::startTimer):

page/RenderingUpdateScheduler.h:

page/Settings.yaml:
page/SettingsBase.cpp:

(WebCore::SettingsBase::renderingUpdateThrottlingEnabledChanged):

page/SettingsBase.h:

Add a setting to enable/disable RenderingUpdateThrottling.

platform/graphics/AnimationFrameRate.h: Added.

(WebCore::preferredFrameInterval):
(WebCore::preferredFramesPerSecond):

platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setPreferredFramesPerSecond):

platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::monitorForClient):
Rename createMonitorForClient() to monitorForClient() since it may return
a cached DisplayRefreshMonitor.

(WebCore::DisplayRefreshMonitorManager::setPreferredFramesPerSecond):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
(WebCore::DisplayRefreshMonitorManager::windowScreenDidChange):
No need to call registerClient(). This function was just ensuring the
DisplayRefreshMonitor is created. scheduleAnimation() does the same thing.

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient): Deleted.
(WebCore::DisplayRefreshMonitorManager::registerClient): Deleted.

platform/graphics/DisplayRefreshMonitorManager.h:

(WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager): Deleted.

platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):

platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler setPreferredFramesPerSecond:]):
Set the preferredFramesPerSecond of the CADisplayLink.

Source/WebKit:

Create an IPC message on the DrawingArea to send a message from the
WebProcess to the UIProcess to setPreferredFramesPerSecond of the
DisplayRefreshMonitor.

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRenderingUpdateThrottlingEnabled):
(WKPreferencesGetRenderingUpdateThrottlingEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:

Add a WKPreference key for RenderingUpdateThrottlingEnabled.

UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:

UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(-[WKOneShotDisplayLinkHandler setPreferredFramesPerSecond:]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setPreferredFramesPerSecond):
Set the preferredFramesPerSecond of the CADisplayLink.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::setPreferredFramesPerSecond):
Delegate the call to RemoteLayerTreeDrawingArea.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setPreferredFramesPerSecond):
Send the IPC message from the WebProcess to the UIProcess.

Source/WebKitLegacy/mac:

Add a WKPreference key for RenderingUpdateThrottling.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences renderingUpdateThrottlingEnabled]):
(-[WebPreferences setRenderingUpdateThrottlingEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a WKPreference key for RenderingUpdateThrottling.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::renderingUpdateThrottlingEnabled):
(WebPreferences::setRenderingUpdateThrottlingEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
WTR. In some cases, the page may not get visually active while it's
waiting for rAF. Throttling tests will have to explicitly turn it on.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

fast/animation/css-animation-throttling-lowPowerMode.html:
fast/animation/request-animation-frame-throttle-subframe.html:
fast/animation/request-animation-frame-throttling-detached-iframe.html:

Enable RenderingUpdateThrottling for these tests.

fast/animation/request-animation-frame-throttling-lowPowerMode-expected.txt:
fast/animation/request-animation-frame-throttling-lowPowerMode.html:

Ensure the actual rAF interval is > 30ms for lowPowerMode.

fast/animation/request-animation-frame-throttling-outside-viewport-expected.txt: Added.
fast/animation/request-animation-frame-throttling-outside-viewport.html: Added.
fast/animation/resources/frame-with-animation-2.html: Added.

Test the OutsideViewport throttling case.

http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html:

Enable RenderingUpdateThrottling for this test.

11:33 AM Changeset in webkit [255157] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
https://bugs.webkit.org/show_bug.cgi?id=206807

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

11:16 AM Changeset in webkit [255156] by Kate Cheney

4 edits in trunk

Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
https://bugs.webkit.org/show_bug.cgi?id=206601
<rdar://problem/58696521>

Reviewed by Alex Christensen.

Source/WebKit:

This patch also deletes the temporary files SQLite creates when
constructing a new database.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):

Tools:

This patch caused some API tests to fail which relied on the ITP files
always existing. Now the tests ensure the respective file exists when
switching between in-memory and database storage before running the tests.

TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(ensureITPFileIsCreated):
(TEST):

11:09 AM Changeset in webkit [255155] by Brent Fulgham

2 edits in trunk/Source/WebKit

Remove locationd entitlements from the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=206022
<rdar://problem/58452443>

Reviewed by Per Arne Vollan.

Now that we have removed mach connections related to 'com.apple.locationd', we should also
remove the process entitlements.

No new tests. There are no changes to behavior.

Scripts/process-entitlements.sh:

10:54 AM Changeset in webkit [255154] by Devin Rousso

4 edits in trunk/LayoutTests

REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206362
<rdar://problem/58649476>

Reviewed by Brian Burg.

Tentative fix. Modifying the iceCandidateFilteringEnabled WebCore setting causes any
existing/pending ICE candidates to immediately fire icecandidate events. Wait to change
the setting using Page.overrideSetting until after the JavaScript has set up the various
connections so that it's guaranteed to not miss any icecandidate events. Additionally
remove the default 10s timeout in case the debug build is too slow.

inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
platform/mac-wk1/TestExpectations:

10:39 AM Changeset in webkit [255153] by Chris Dumez

3 edits in trunk/LayoutTests

REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206675
<rdar://problem/58839955>

Reviewed by Said Abou-Hallawa.

Rewrite test to stop relying on ordering between requestAnimationFrame() and setTimeout().

fast/animation/request-animation-frame-expected.txt:
fast/animation/request-animation-frame.html:

10:16 AM Changeset in webkit [255152] by Diego Pino Garcia

50 edits
40 adds in trunk/LayoutTests

[WPE] Gardening, update baselines and synchronize with GTK
https://bugs.webkit.org/show_bug.cgi?id=206826

Unreviewed gardening.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:
platform/wpe/accessibility/roles-exposed-expected.txt:
platform/wpe/css1/text_properties/text_indent-expected.txt:
platform/wpe/css2.1/t1601-c547-indent-01-d-expected.txt:
platform/wpe/fast/backgrounds/background-leakage-expected.txt:
platform/wpe/fast/backgrounds/background-leakage-transforms-expected.txt:
platform/wpe/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
platform/wpe/fast/block/float/intruding-painted-twice-expected.txt:
platform/wpe/fast/borders/mixed-border-styles-expected.txt:
platform/wpe/fast/borders/mixed-border-styles-radius-expected.txt:
platform/wpe/fast/borders/mixed-border-styles-radius2-expected.txt:
platform/wpe/fast/css/hsl-color-expected.txt:
platform/wpe/fast/css/hsla-color-expected.txt:
platform/wpe/fast/css/percentage-non-integer-expected.txt:
platform/wpe/fast/css/shadow-multiple-expected.txt:
platform/wpe/fast/css/viewport-units-dynamic-expected.txt:
platform/wpe/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
platform/wpe/fast/loader/text-document-wrapping-expected.txt:
platform/wpe/fast/multicol/client-rects-expected.txt:
platform/wpe/fast/multicol/client-rects-spanners-complex-expected.txt:
platform/wpe/fast/multicol/client-rects-spanners-expected.txt:
platform/wpe/fast/multicol/newmulticol/client-rects-expected.txt:
platform/wpe/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/wpe/fast/overflow/float-in-relpositioned-expected.txt:
platform/wpe/fast/parser/open-comment-in-textarea-expected.txt:
platform/wpe/fast/ruby/select-ruby-expected.txt:
platform/wpe/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
platform/wpe/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
platform/wpe/fast/writing-mode/border-styles-vertical-lr-expected.txt:
platform/wpe/fast/writing-mode/english-bt-text-expected.txt:
platform/wpe/fast/writing-mode/text-orientation-basic-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any.worker-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.any.worker-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-parse-noscript-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-text-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/editing/editing-0/autocapitalization/autocapitalize-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-generated-content-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-sans-fieldset-display-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/abspos-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/media_fragment_seek-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads.sub.tentative-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads.sub.tentative-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/svg/import/paths-dom-01-f-manual-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-percentage-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-percentage-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-003-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/textpath-shape-001-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/websockets/unload-a-document/002-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/websockets/unload-a-document/004-expected.txt: Added.
platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
platform/wpe/js/dom/navigator-maxtouchpoints-expected.txt: Added.
platform/wpe/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
platform/wpe/tables/mozilla/bugs/bug157890-expected.txt:
platform/wpe/tables/mozilla/marvin/x_td_nowrap-expected.txt:
platform/wpe/tables/mozilla/marvin/x_th_nowrap-expected.txt:
platform/wpe/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
platform/wpe/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
platform/wpe/webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt:

9:40 AM Changeset in webkit [255151] by Antti Koivisto

7 edits in trunk/Source/WebCore

Correct VTT Cue Style handling to match the specification
https://bugs.webkit.org/show_bug.cgi?id=201086
<rdar://problem/54658121>

Reviewed by Brent Fulgham.

The VTT specification requires that only data-URLs are permitted in STYLE blocks.

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

Fix selectorText for function version of ::cue().

css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::completeURL const):

Don't allow non-data URLs in WebVTT parser mode.

css/parser/CSSParserContext.h:

(WebCore::CSSParserContext::completeURL const): Deleted.

css/parser/CSSParserMode.h:

(WebCore::isStrictParserMode):

html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectStyleSheet):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):

Instead of simply validating the original stylesheet, build a new sanitized stylesheet text
from the stylesheet parsed in WebVTT mode. This sanitized stylesheet is then used as the
input for the style system.

html/track/WebVTTParser.h:

9:26 AM Changeset in webkit [255150] by Ryan Haddad

55 edits
4 deletes in trunk

Unreviewed, rolling out r255131.

Caused assertion failures on iOS debug bots.

Reverted changeset:

"Throttling requestAnimationFrame should be controlled by
RenderingUpdateScheduler"
https://bugs.webkit.org/show_bug.cgi?id=204713
https://trac.webkit.org/changeset/255131

8:51 AM Changeset in webkit [255149] by graouts@webkit.org

14 edits
2 copies in trunk

[Web Animations] Add support for the options parameter to getAnimations()
https://bugs.webkit.org/show_bug.cgi?id=202191
<rdar://problem/55697751>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark some WPT progressions. In the CSS Animations case, we are returning the expected animations but not quite sorted as expected.

web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt:
web-platform-tests/web-animations/interfaces/Animatable/getAnimations-expected.txt:

Source/WebCore:

Add support for the GetAnimationsOptions dictionary as a parameter to Animatable.getAnimations(). When it is provided
and has its sole "subtree" property set to "true", we call Document.getAnimations() and filter out animations that are
not targeting elements that are either this element, one of its descendants, one of its pseudo-elements or one of its
descendants' pseudo-elements.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
animation/Animatable.idl:
animation/GetAnimationsOptions.h: Added.
animation/GetAnimationsOptions.idl: Added.
dom/Element.cpp:

(WebCore::Element::getAnimations):

dom/Element.h:

8:31 AM Changeset in webkit [255148] by Jonathan Bedard

2 edits in trunk/Tools

webkitpy: Replace StringIO.StringIO in statusserver.py
https://bugs.webkit.org/show_bug.cgi?id=206825

Reviewed by Aakash Jain.

Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._upload_attachment_to_server): The Python 3 compatible StringIO
object cannot be referenced as StringIO.StringIO

8:28 AM Changeset in webkit [255147] by Chris Dumez

2 edits in trunk/Source/WebKit

NetworkProcessProxy: MESSAGE_CHECK identifiers sent over IPC
https://bugs.webkit.org/show_bug.cgi?id=206814
<rdar://problem/58783422>

Reviewed by David Kilzer.

MESSAGE_CHECK identifiers sent over IPC in NetworkProcessProxy class.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFetchWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteDataForOrigins):

8:16 AM Changeset in webkit [255146] by Jonathan Bedard

2 edits in trunk/Source/WebCore

WebCore: Remove iOS 11 macros from NetworkStorageSessionCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=206786

Reviewed by Darin Adler.

No functional changes, covered by existing tests.

platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::cookiesForURL):
(WebCore::setHTTPCookiesForURL):

8:00 AM Changeset in webkit [255145] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Remove internal fields in promise assertion for 32bits
https://bugs.webkit.org/show_bug.cgi?id=206823

Patch by Paulo Matos <Paulo Matos> on 2020-01-27
Reviewed by Mark Lam.

This assertion was removed for 64bits under bug 201159 but left around
in 32bits.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):

7:44 AM Changeset in webkit [255144] by Jonathan Bedard

2 edits in trunk/Source/WebCore

WebCore: Remove iOS 11 macros from WebItemProviderPasteboard.h
https://bugs.webkit.org/show_bug.cgi?id=206719

Reviewed by Tim Horton.

No functional changes, covered by existing tests.

platform/ios/WebItemProviderPasteboard.h:

7:25 AM Changeset in webkit [255143] by Alan Bujtas

11 edits in trunk/Source/WebCore

[LFC][IFC] Display::Run has physical geometry only.
https://bugs.webkit.org/show_bug.cgi?id=206810
<rdar://problem/58905455>

Reviewed by Antti Koivisto.

Since in LFC the Display::Runs are used for painting and hittesting but never for layout,
the geometry is always physical.

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

layout/displaytree/DisplayRun.h:

(WebCore::Display::Run::rect const):
(WebCore::Display::Run::topLeft const):
(WebCore::Display::Run::left const):
(WebCore::Display::Run::right const):
(WebCore::Display::Run::top const):
(WebCore::Display::Run::bottom const):
(WebCore::Display::Run::width const):
(WebCore::Display::Run::height const):
(WebCore::Display::Run::setWidth):
(WebCore::Display::Run::setTop):
(WebCore::Display::Run::setlLeft):
(WebCore::Display::Run::moveVertically):
(WebCore::Display::Run::moveHorizontally):
(WebCore::Display::Run::expandVertically):
(WebCore::Display::Run::expandHorizontally):
(WebCore::Display::Run::Run):
(WebCore::Display::Run::logicalRect const): Deleted.
(WebCore::Display::Run::logicalTopLeft const): Deleted.
(WebCore::Display::Run::logicalLeft const): Deleted.
(WebCore::Display::Run::logicalRight const): Deleted.
(WebCore::Display::Run::logicalTop const): Deleted.
(WebCore::Display::Run::logicalBottom const): Deleted.
(WebCore::Display::Run::logicalWidth const): Deleted.
(WebCore::Display::Run::logicalHeight const): Deleted.
(WebCore::Display::Run::setLogicalWidth): Deleted.
(WebCore::Display::Run::setLogicalTop): Deleted.
(WebCore::Display::Run::setLogicalLeft): Deleted.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::hitTest):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

rendering/RenderTreeAsText.cpp:

(WebCore::writeTextBox):

rendering/line/LineLayoutTraversal.h:

(WebCore::LineLayoutTraversal::Box::logicalRect const): Deleted.

rendering/line/LineLayoutTraversalDisplayRunPath.h:

(WebCore::LineLayoutTraversal::linePosition):
(WebCore::LineLayoutTraversal::DisplayRunPath::rect const):
(WebCore::LineLayoutTraversal::DisplayRunPath::logicalRect const): Deleted.

6:14 AM Changeset in webkit [255142] by cathiechen

2 edits in trunk/Source/WebKitLegacy/mac

The value of AspectRatioOfImgFromWidthAndHeight for legacy mac isn't correct
https://bugs.webkit.org/show_bug.cgi?id=206822

Reviewed by Frédéric Wang.

The value should be WebKitAspectRatioOfImgFromWidthAndHeightEnabled

WebView/WebPreferenceKeysPrivate.h:

4:01 AM Changeset in webkit [255141] by graouts@webkit.org

7 edits in trunk

[Web Animations] Update all DocumentTimeline objects when updating animations
https://bugs.webkit.org/show_bug.cgi?id=206819

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark a single new WPT progression.

web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement-expected.txt:

Source/WebCore:

Developers can create additional DocumentTimeline objects in JavaScript using that class's constructor, and an animation can be
assigned to that timeline after its creation. Until now we would only update an timeline created by a Document when that document's
animations were updated. Now we keep track of all DocumentTimeline objects that are created for a given Document as a vector of weak
references, and we update all of them when updating a document's animations.

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::~DocumentTimeline):

animation/DocumentTimeline.h:
dom/Document.cpp:

(WebCore::Document::updateAnimationsAndSendEvents):
(WebCore::Document::addTimeline):
(WebCore::Document::removeTimeline):

dom/Document.h:

3:20 AM Changeset in webkit [255140] by Antti Koivisto

2 edits in trunk/LayoutTests

[Mac wk2 Release] fast/dom/frame-src-javascript-url-async.html flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206701
<rdar://problem/58847864>

Reviewed by Antoine Quint.

fast/dom/frame-src-javascript-url-async.html:

The test assumed that in

the frame javascript could not have run before the body script executes. However parser might yield before the
script tag or data might come from network in chunks that don't cover the full script. In this case frame load
may start and src execute before the body script runs.

Fix by document.writing the iframe tag.

1:18 AM BuildingGtk edited by vjaquez@igalia.com

recommend to export JHBUILD_WIPE_ON_CHANGE (diff)

12:54 AM Changeset in webkit [255139] by mark.lam@apple.com

2 edits in trunk/Source/WTF

Make getVTablePointer() an inline function to be compliant with WebKit style guidelines.
https://bugs.webkit.org/show_bug.cgi?id=206816

Reviewed by Darin Adler.

Convert getVTablePointer() from a macro into an inline template function. This
makes the naming compliant with WebKit style guidelines.

wtf/PointerPreparations.h:

(WTF::getVTablePointer):

12:10 AM Changeset in webkit [255138] by commit-queue@webkit.org

9 edits in trunk/LayoutTests/imported/w3c

Re-sync web-platform-tests/fetch/api/policies from upstream
https://bugs.webkit.org/show_bug.cgi?id=206574

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-27
Reviewed by Darin Adler.

web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html:
web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-expected.txt:
web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker-expected.txt:
web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.html:
web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js:
web-platform-tests/fetch/api/policies/referrer-origin.js:

(promise_test):

web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html:

Jan 26, 2020:

10:30 PM Changeset in webkit [255137] by Fujii Hironori

2 edits in trunk/Source/WebKit

[WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067
https://bugs.webkit.org/show_bug.cgi?id=206817

Reviewed by Darin Adler.

Since r255067 (Bug 206700), the assertion is failing in
NetworkProcess::destroySession while shutdown, which is ensuring
the destructing session isn't the default session.

Covered by existing tests.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::destroySession): Conditioned out the
assertion for curl port as well as Soup port does.

10:27 PM Changeset in webkit [255136] by Darin Adler

4 edits in trunk/Source/WebCore

Move DOMCacheEngine::errorToException back out of header and into .cpp file
https://bugs.webkit.org/show_bug.cgi?id=206815

Reviewed by Mark Lam.

This is a follow-up to a recent build fix that moved a function, errorToException,
out of a .cpp file and into a header file. This reverses that since we don't need
this function to be inlined.

Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::convertToException): Moved this function from the header
and renamed it from errorToException to match the other function more closely. Also
use the pattern where the switch statement has no default, so we get a warning if
we don't cover all the enum values.
(WebCore::DOMCacheEngine::convertToExceptionAndLog): Updated for new function name.

Modules/cache/DOMCacheEngine.h: Removed the definition of errorToException and

replaced it with the declaration of it under its new name, convertToException.

Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches): Updated for new function name.

8:38 PM Changeset in webkit [255135] by Chris Dumez

11 edits
1 copy in trunk/Source/WebKit

Frequent sync BackForwardBackListCount/BackForwardForwardListCount IPC on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=206438

Reviewed by Darin Adler.

Frequent sync BackForwardBackListCount/BackForwardForwardListCount IPC on reddit.com. When scrolling on reddit.com,
you frequently see 2 consecutive sync IPCs (WebPageProxy::BackForwardBackListCount then WebPageProxy::BackForwardForwardListCount)
from the WebContent process to the UIProcess. Those are bad for performance. This happens every time the script on the page accesses
history.length, which is unfortunate, since this history length rarely changes.

To address the issue, the following changes were made:

Merge BackForwardBackListCount / BackForwardForwardListCount IPCs into a single BackForwardListCounts IPC which returns both the back & forward counts, since we often need both (e.g. when accessing history.length) and since gettings those counts is very cheap compared to the cost of a sync IPC.
Cache those counts in WebBackForwardListProxy and blow away the cached counts whenever the back/forward list changes. In the common case (where the back/forward list rarely changes), we now see a single sync IPC instead of many (verified on reddit.com).

No new tests, merely a performance improvement.

UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::backListCount const):
(WebKit::WebBackForwardListProxy::forwardListCount const):
(WebKit::WebBackForwardListProxy::cacheListCountsIfNecessary const):
(WebKit::WebBackForwardListProxy::clearCachedListCounts):
(WebKit::WebBackForwardListProxy::close):
(WebKit::WebBackForwardListProxy::clear):

WebProcess/WebPage/WebBackForwardListProxy.h:

3:28 PM Changeset in webkit [255134] by Alexey Shvayka

6 edits in trunk

Invalid ranges in character classes should be banned in unicode patterns
https://bugs.webkit.org/show_bug.cgi?id=206768

Reviewed by Darin Adler.

JSTests:

test262/expectations.yaml: Mark 18 test cases as passing.

Source/JavaScriptCore:

In ES5, grammar of CharacterRange was ambiguous, resulting in invalid ranges
like /[\d-a]/ being allowed. As of ES2015, invalid ranges are SyntaxError in
unicode patterns, yet still allowed in regular ones to avoid breaking the web.
(https://tc39.es/ecma262/#sec-patterns-static-semantics-early-errors-annexb)

This change adds SyntaxError for unicode patterns and updates explanatory
comments. ErrorCode::CharacterClassOutOfOrder is renamed for consistency
with newly added error code and ErrorCode::ParenthesesTypeInvalid.

yarr/YarrErrorCode.cpp:

(JSC::Yarr::errorMessage):
(JSC::Yarr::errorToThrow):

yarr/YarrErrorCode.h:
yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parseCharacterClass):

2:47 PM Changeset in webkit [255133] by youenn@apple.com

10 edits
1 add in trunk/Source

Use ObjectIdentifier for remote RealtimeMediaSource
https://bugs.webkit.org/show_bug.cgi?id=206808
<rdar://problem/58705405>

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

WebCore.xcodeproj/project.pbxproj:
platform/mediastream/RealtimeMediaSourceIdentifier.h: Added.

Source/WebKit:

Use ObjectIdentifier instead of uint64_t.
This is clearer and prevents receiving identifier of value zero from IPC.
Remove related message checks.

Scripts/webkit/messages.py:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):
(WebKit::UserMediaCaptureManagerProxy::end):
(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::setMuted):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):
(WebKit::UserMediaCaptureManagerProxy::clone):
(WebKit::UserMediaCaptureManagerProxy::requestToEnd):

UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::Source::sourceID const):
(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::captureFailed):
(WebKit::UserMediaCaptureManager::sourceMutedChanged):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::storageChanged):
(WebKit::UserMediaCaptureManager::ringBufferFrameBoundsChanged):
(WebKit::UserMediaCaptureManager::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::remoteVideoSampleAvailable):
(WebKit::UserMediaCaptureManager::sourceEnded):
(WebKit::UserMediaCaptureManager::applyConstraintsSucceeded):
(WebKit::UserMediaCaptureManager::applyConstraintsFailed):
(WebKit::UserMediaCaptureManager::cloneVideoSource):

WebProcess/cocoa/UserMediaCaptureManager.h:
WebProcess/cocoa/UserMediaCaptureManager.messages.in:

2:15 PM Changeset in webkit [255132] by Darin Adler

4 edits in trunk/Source/WebKit

Protect against crashes during WKWebView init function when methods are called before the view is fully initialized
https://bugs.webkit.org/show_bug.cgi?id=206799
rdar://problem/58871371

Reviewed by Sam Weinig.

Part way through creating WKWebView, some methods can be called and they need to be careful
not to use anything that may not be initialized yet.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView dealloc]): Check _page for null, since this might happen if the superclass's
init method returned nil.

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _frameOrBoundsChanged]): Check _page for null, since this might be called
before object initialization is complete.
(-[WKWebView setSemanticContentAttribute:]): Ditto.

UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView setFrameSize:]): Check _impl for null since this might be called before
oject initialization is complete.
(-[WKWebView setUserInterfaceLayoutDirection:]): Ditto.
(-[WKWebView renewGState]): Ditto.

1:35 PM Changeset in webkit [255131] by commit-queue@webkit.org

55 edits
4 adds in trunk

Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
https://bugs.webkit.org/show_bug.cgi?id=204713

Patch by Said Abou-Hallawa <Said Abou-Hallawa> on 2020-01-26
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-throttling-outside-viewport.html

The solution is to have two throttling types:

1) Page throttling (or full throttling) which slows down all the steps of

RenderingUpdate for the main document and all the sub-documents.

2) Document throttling (or partial throttling) which only slows down the

rAF of a certain document.

Headers.cmake:
WebCore.xcodeproj/project.pbxproj:

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animationInterval const):
(WebCore::DocumentTimeline::updateThrottlingState): Deleted.

animation/DocumentTimeline.h:

There is no need to have DocumentTimeline throttling. It is already
throttled when the page RenderingUpdate is throttled.

dom/Document.cpp:

dom/ScriptedAnimationController.cpp:

dom/ScriptedAnimationController.h:

page/FrameView.cpp:

(WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState):
ThrottlingReason is now defined outside ScriptedAnimationController.

page/Page.cpp:

(WebCore::Page::renderingUpdateThrottlingEnabled const):
(WebCore::Page::renderingUpdateThrottlingEnabledChanged):
(WebCore::Page::isRenderingUpdateThrottled const):

(WebCore::Page::preferredRenderingUpdateInterval const):
Calculate the preferred RenderingUpdate interval from the throttling
reasons.

(WebCore::Page::setIsVisuallyIdleInternal):
(WebCore::Page::handleLowModePowerChange):
Call adjustRenderingUpdateFrequency() when isLowPowerModeEnabled or
IsVisuallyIdle is toggled.

(WebCore::updateScriptedAnimationsThrottlingReason): Deleted.

page/Page.h:

page/RenderingUpdateScheduler.cpp:

(WebCore::RenderingUpdateScheduler::scheduleTimedRenderingUpdate):
Call adjustFramesPerSecond() when DisplayRefreshMonitor is created.

(WebCore::RenderingUpdateScheduler::startTimer):

page/RenderingUpdateScheduler.h:

page/Settings.yaml:
page/SettingsBase.cpp:

(WebCore::SettingsBase::renderingUpdateThrottlingEnabledChanged):

page/SettingsBase.h:

Add a setting to enable/disable RenderingUpdateThrottling.

platform/graphics/AnimationFrameRate.h: Added.

(WebCore::preferredFrameInterval):
(WebCore::preferredFramesPerSecond):

platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setPreferredFramesPerSecond):

platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::monitorForClient):
Rename createMonitorForClient() to monitorForClient() since it may return
a cached DisplayRefreshMonitor.

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient): Deleted.
(WebCore::DisplayRefreshMonitorManager::registerClient): Deleted.

platform/graphics/DisplayRefreshMonitorManager.h:

(WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager): Deleted.

platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):

platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler setPreferredFramesPerSecond:]):
Set the preferredFramesPerSecond of the CADisplayLink.

platform/ios/LowPowerModeNotifierIOS.mm:

(-[WebLowPowerModeObserver initWithNotifier:]):
Set the initial state of the low power mode.

Source/WebKit:

Create an IPC message on the DrawingArea to send a message from the
WebProcess to the UIProcess to setPreferredFramesPerSecond of the
DisplayRefreshMonitor.

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRenderingUpdateThrottlingEnabled):
(WKPreferencesGetRenderingUpdateThrottlingEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:

Add a WKPreference key for RenderingUpdateThrottlingEnabled.

UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:

UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(-[WKOneShotDisplayLinkHandler setPreferredFramesPerSecond:]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setPreferredFramesPerSecond):
Set the preferredFramesPerSecond of the CADisplayLink.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::setPreferredFramesPerSecond):
Delegate the call to RemoteLayerTreeDrawingArea.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setPreferredFramesPerSecond):
Send the IPC message from the WebProcess to the UIProcess.

Source/WebKitLegacy/mac:

Add a WKPreference key for RenderingUpdateThrottling.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences renderingUpdateThrottlingEnabled]):
(-[WebPreferences setRenderingUpdateThrottlingEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a WKPreference key for RenderingUpdateThrottling.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::renderingUpdateThrottlingEnabled):
(WebPreferences::setRenderingUpdateThrottlingEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

fast/animation/css-animation-throttling-lowPowerMode.html:
fast/animation/request-animation-frame-throttle-subframe.html:
fast/animation/request-animation-frame-throttling-detached-iframe.html:

Enable RenderingUpdateThrottling for these tests.

fast/animation/request-animation-frame-throttling-lowPowerMode-expected.txt:
fast/animation/request-animation-frame-throttling-lowPowerMode.html:

Ensure the actual rAF interval is > 30ms for lowPowerMode.

fast/animation/request-animation-frame-throttling-outside-viewport-expected.txt: Added.
fast/animation/request-animation-frame-throttling-outside-viewport.html: Added.
fast/animation/resources/frame-with-animation-2.html: Added.

Test the OutsideViewport throttling case.

http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html:

Enable RenderingUpdateThrottling for this test.

1:11 PM Changeset in webkit [255130] by eric.carlson@apple.com

2 edits
1 add in trunk/LayoutTests

media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=206629
<rdar://problem/58816827>

Reviewed by Dean Jackson.

Attempt to de-flake this test by decreasing the controller auto-hide interval and
using a base64 encoded video file to make it load and finish more quickly.

media/content/test.mp4.js: Added.

(base64MP4URL): Base64 encoded five frame, four second long MPEG-4 video.

media/modern-media-controls/media-controller/media-controller-auto-hide.html:

4:17 AM Changeset in webkit [255129] by commit-queue@webkit.org

5 edits in trunk

Improve compatibility with hyperlink auditing spec
https://bugs.webkit.org/show_bug.cgi?id=188852

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-26
Reviewed by Youenn Fablet.

Source/WebCore:

The hyperlink auditing algorithm indicates the fetch should be done
using no-referrer [1], so remove the code to set the referrer HTTP
header.

Tests: http/tests/navigation/ping-attribute/anchor-cross-origin.html

http/tests/navigation/ping-attribute/area-cross-origin.html

[1] https://html.spec.whatwg.org/multipage/links.html#hyperlink-auditing (Step 3)

loader/PingLoader.cpp:

(WebCore::PingLoader::sendPing):

LayoutTests:

Update improved test results.

http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt:
http/tests/navigation/ping-attribute/area-cross-origin-expected.txt:

Jan 25, 2020:

10:33 PM Changeset in webkit [255128] by Darin Adler

3 edits in trunk/Source/WebCore

Tighten up some of the drag state machine logic
https://bugs.webkit.org/show_bug.cgi?id=206798

Reviewed by Wenson Hsieh.

page/EventHandler.h: Added shouldDispatchEventsToDragSourceElement function and renamed

the existing dispatchDragSrcEvent function to dispatchEventToDragSourceElement.

page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop): Call the renamed dispatchEventToDragSourceElement
unconditionally, since it now has the smarts to only dispatch an event when we are supposed to.
(WebCore::EventHandler::cancelDragAndDrop): Ditto.
(WebCore::EventHandler::dragSourceEndedAt): Call the new shouldDispatchEventsToDragSourceElement
function because of the null check it does for dataTransfer, before calling setDestinationOperation
on the dataTransfer, since there isn't an obvious ironclad guarantee we might be here without an
actual drag fully in process and a dataTransfer object allocated. Also call the renamed
dispatchEventToDragSourceElement by its new name.
(WebCore::EventHandler::shouldDispatchDragSourceEvents): Added. Checks thre three conditions that
affect whether we should dispatch events to the drag source. First that there is a drag source.
Second that there is a dataTransfer object, indicating that we got far enough in the logic to
actually start a drag. Third that shouldDispatchEvents is true, indicating this is the type of
drag that should be visible to the website content and so events should be dispatched.
(WebCore::EventHandler::dispatchEventToDragSourceElement): Call shouldDispatchDragSourceEvents
before dispatching the event, so that callers don't all have to do that check.

9:43 PM Changeset in webkit [255127] by beidson@apple.com

20 edits in trunk/Source

Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t
https://bugs.webkit.org/show_bug.cgi?id=206784

Reviewed by Alex Christensen.

Source/WebKit:

Refactor: No behavior change.

Scripts/webkit/messages.py:

Shared/AuxiliaryProcess.cpp:

(WebKit::AuxiliaryProcess::initialize):

Shared/ContentWorldShared.h:

(WebKit::pageContentWorldIdentifier):

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

Shared/WebUserContentControllerDataTypes.cpp:

(WebKit::WebUserScriptData::decode):
(WebKit::WebUserStyleSheetData::decode):
(WebKit::WebScriptMessageHandlerData::decode):

Shared/WebUserContentControllerDataTypes.h:

UIProcess/API/APIContentWorld.cpp:

(API::ContentWorld::pageContentWorld):
(API::ContentWorld::defaultClientWorld):
(API::ContentWorld::ContentWorld):
(API::ContentWorldBase::generateIdentifier): Deleted.

UIProcess/API/APIContentWorld.h:

(API::ContentWorldBase::identifier const):
(API::ContentWorldBase::worldData const):
(API::ContentWorldBase::ContentWorldBase):

UIProcess/API/APIUserContentWorld.cpp:

(API::UserContentWorld::UserContentWorld):

UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::removeUserContentWorldUses):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):

WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::worldMap):
(WebKit::WebUserContentController::worldForIdentifier):
(WebKit::WebUserContentController::addUserContentWorld):
(WebKit::WebUserContentController::addUserContentWorlds):
(WebKit::WebUserContentController::removeUserContentWorlds):
(WebKit::WebUserContentController::addUserScripts):
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeAllUserScripts):
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::removeUserStyleSheet):
(WebKit::WebUserContentController::removeAllUserStyleSheets):
(WebKit::WebUserContentController::addUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeUserScriptMessageHandler):
(WebKit::WebUserContentController::removeAllUserScriptMessageHandlers):

WebProcess/UserContent/WebUserContentController.h:
WebProcess/UserContent/WebUserContentController.messages.in:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::runJavaScriptInMainFrameScriptWorld):
(WebKit::WebPage::runJavaScriptInFrame):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Source/WTF:

wtf/ObjectIdentifier.h:

(WTF::ObjectIdentifier::generate):
(WTF::ObjectIdentifier::generateThreadSafe):
(WTF::ObjectIdentifier::enableGenerationProtection): To allow restricting generating an identifier to the UIProcess.

2:34 PM Changeset in webkit [255126] by mark.lam@apple.com

62 edits in trunk/Source

Introduce a getVTablePointer() utility function.
https://bugs.webkit.org/show_bug.cgi?id=206804
<rdar://problem/58872290>

Reviewed by Yusuke Suzuki and Oliver Hunt.

Source/WebCore:

Updated CodeGeneratorJS to use getVTablePointer() and rebased test results.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSReadOnlySetLike.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSSetLike.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEnabledForContext.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJSNewlyCreated):

Source/WTF:

With getVTablePointer(), we can abstract away how we get a vtable function pointer
without assuming the way it is signed for ARM64E. With this, we can remove the
WTF_PREPARE_VTBL_POINTER_FOR_INSPECTION macro which assumes how a vtable function
pointer is signed.

wtf/PointerPreparations.h:

12:13 PM Changeset in webkit [255125] by mark.lam@apple.com

4 edits in trunk

Add some tests for dynamically allocated StaticStringImpls.
https://bugs.webkit.org/show_bug.cgi?id=206802

Reviewed by Darin Adler.

Source/WTF:

Removed some unnecessary explicit specialization of the charactersAreAllASCII()
template function.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createStaticStringImpl):

Tools:

TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::doStaticStringImplTests):
(TestWebKitAPI::TEST):

12:07 PM Changeset in webkit [255124] by Darin Adler

2 edits in trunk/LayoutTests

REGRESSION: [ Mac WK2 ] animations/suspend-resume-animation-events.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206615

Reviewed by Alexey Proskuryakov.

animations/suspend-resume-animation-events.html: Make test slightly less timing

dependent.

12:02 PM Changeset in webkit [255123] by aakash_jain@apple.com

3 edits in trunk/Tools

webkit-patch upload should not submit automatically to old EWS
https://bugs.webkit.org/show_bug.cgi?id=206801

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/steps/submittoews.py:

11:14 AM Changeset in webkit [255122] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Regression (r255103): media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls.html
https://bugs.webkit.org/show_bug.cgi?id=206800

Unreviewed test gardening; the test which this was copied from, placard-support-airplay-fullscreen.html, is skipped on
iOS test bots due to a lack of AirPlay test support.

Patch by Jer Noble <jer.noble@apple.com> on 2020-01-25

platform/ios/TestExpectations:

9:12 AM Changeset in webkit [255121] by Diego Pino Garcia

5 edits in trunk/LayoutTests

[GTK] Gardening of media related tests
https://bugs.webkit.org/show_bug.cgi?id=206796

Unreviewed gardening.

platform/gtk/TestExpectations:
platform/gtk/media/audio-repaint-expected.txt:
platform/gtk/media/controls-styling-strict-expected.txt:
platform/gtk/media/media-controls-play-button-updates-expected.txt:

9:03 AM Changeset in webkit [255120] by mark.lam@apple.com

15 edits in trunk/Source

Move singleton Intl string locales out of JSGlobalObject.
https://bugs.webkit.org/show_bug.cgi?id=206791
<rdar://problem/58889037>

Source/JavaScriptCore:

Reviewed by Yusuke Suzuki and Andy Wagoner.

We were creating an instance of these for each JSGlobalObject when they can be a
global singleton since they are always initialized with the same intl data
(barring a mid-flight change in intl settings, which we don't support even in the
existing code).

It turns out that intlPluralRulesAvailableLocales() wasn't called anywhere.
IntlPluralRules code currently just uses intlNumberFormatAvailableLocales().
To document that this is intentional, we do the following:

have IntlPluralRules code call intlPluralRulesAvailableLocales(), and
have intlPluralRulesAvailableLocales() call intlNumberFormatAvailableLocales() for its implementation.

See https://bugs.webkit.org/show_bug.cgi?id=206791#c7 and
https://bugs.webkit.org/show_bug.cgi?id=206791#c8.

In addMissingScriptLocales(), I'm deliberately naming the string with underscores
because it's much easier to read pa_PK_String and see that it refers to "pa-PK"
as opposed to paPKString. Ditto for zh_CN_String, zh_HK_String, zh_SG_String,
and zh_TW_String.

runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):

runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):

runtime/IntlObject.cpp:

(JSC::convertICULocaleToBCP47LanguageTag):
(JSC::addMissingScriptLocales):
(JSC::intlCollatorAvailableLocales):
(JSC::intlDateTimeFormatAvailableLocales):
(JSC::intlNumberFormatAvailableLocales):
(JSC::defaultLocale):

runtime/IntlObject.h:
runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):

runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructorFuncSupportedLocalesOf):

runtime/JSGlobalObject.cpp:

(JSC::addMissingScriptLocales): Deleted.
(JSC::JSGlobalObject::intlCollatorAvailableLocales): Deleted.
(JSC::JSGlobalObject::intlDateTimeFormatAvailableLocales): Deleted.
(JSC::JSGlobalObject::intlNumberFormatAvailableLocales): Deleted.
(JSC::JSGlobalObject::intlPluralRulesAvailableLocales): Deleted.

runtime/JSGlobalObject.h:

Source/WTF:

Reviewed by Yusuke Suzuki.

Fix a bug in StringImpl::createStaticStringImpl(): I forgot to set its hash value
when I introduced it. StaticStringImpls require that its hash code be set ahead
of time, and cannot be mutated at runtime. See the comment in the definition of
StaticStringImpl in StringImpl.h.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::createStaticStringImpl):

8:51 AM Changeset in webkit [255119] by pvollan@apple.com

13 edits
1 add in trunk

[Cocoa] Media mime types map should be created in the UI process
https://bugs.webkit.org/show_bug.cgi?id=206478

Reviewed by Darin Adler.

Source/WebCore:

Creating this map in the WebContent process will access the launch services daemon, which will be blocked.
This patch creates the map in the UI process and sends it to the WebContent process as part of the WebProcess
creation parameters.

API test: WebKit.MimeTypes

platform/MIMETypeRegistry.cpp:

(WebCore::overriddenMimeTypesMap):
(WebCore::commonMediaTypes):
(WebCore::commonMimeTypesMap):
(WebCore::typesForCommonExtension):

platform/MIMETypeRegistry.h:
testing/Internals.cpp:

(WebCore::Internals::mediaMIMETypeForExtension):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Send the mime type map from the UI process to the WebContent process as part of the
WebProcess creation parameters.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.

(TEST):

7:57 AM Changeset in webkit [255118] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Layout logic should be driven by the type of the inline box
https://bugs.webkit.org/show_bug.cgi?id=206792
<rdar://problem/58889080>

Reviewed by Antti Koivisto.

Use the type of the inline box to decide what layout functions to call and not whether the
box has children or it establishes a formatting context.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::nextInPreOrder):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const):

6:16 AM Changeset in webkit [255117] by Antti Koivisto

16 edits in trunk

[LFC][Integration] Re-enable line layout integration
https://bugs.webkit.org/show_bug.cgi?id=206795
<rdar://problem/58853907>

Reviewed by Zalan Bujtas.

Source/WebCore:

page/RuntimeEnabledFeatures.h:

Source/WebKit:

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Tools:

DumpRenderTree/TestOptions.h:

LayoutTests:

fast/dom/Range/getBoundingClientRect-expected.txt:
platform/ios/fast/text/hyphenate-limit-lines-expected.txt:
platform/ios/fast/text/whitespace/pre-break-word-expected.txt:
platform/ios/fast/text/word-break-expected.txt:
platform/mac/fast/text/hyphenate-limit-lines-expected.txt:
platform/mac/fast/text/whitespace/pre-break-word-expected.txt:
platform/mac/fast/text/word-break-expected.txt:

6:14 AM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

4:27 AM Changeset in webkit [255116] by youenn@apple.com

12 edits in trunk

HTMLMediaElement should not remove the media session at DOM suspension time
https://bugs.webkit.org/show_bug.cgi?id=206661
<rdar://problem/58800787>

Source/WebCore:

Reviewed by Eric Carlson.

https://trac.webkit.org/changeset/233560 made it so that, on HTMLMediaElement suspension,
its media session is stopped.
This was done to ensure updateNowPlayingInfo is not called synchronously but asynchronously.
The issue is that, once the media session is stopped, it is removed from the media session vector.
On updating the ready state after suspension, and playing, we try to look into the media session vector and do not find the session.
This triggers the ASSERT.

Partially revert the behavior by calling the same code as clientWillPausePlayback
but make sure updateNowPlayingInfo is calling asynchronously when suspending the media element.
Introduce clientWillBeDOMSuspended for that purpose.

Update mediaPlayerReadyStateChanged to enqueue a task to do the update if the media element is suspended.

Covered by test no longer crashing in debug.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):

platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::processClientWillPausePlayback):
(WebCore::PlatformMediaSession::clientWillPausePlayback):
(WebCore::PlatformMediaSession::clientWillBeDOMSuspended):

platform/audio/PlatformMediaSession.h:
platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::sessionWillEndPlayback):

platform/audio/PlatformMediaSessionManager.h:
platform/audio/cocoa/MediaSessionManagerCocoa.h:
platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(MediaSessionManagerCocoa::sessionWillEndPlayback):

platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillEndPlayback):

Tools:

Reviewed by Eric Carlson.

TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:

(TestWebKitAPI::TEST):
Suspend/resume Active DOM Objects from time to time as would do scrolling.
This allows pending tasks to be executed asynchronously when not scrolling.

Jan 24, 2020:

8:24 PM Changeset in webkit [255115] by rniwa@webkit.org

2 edits in trunk/LayoutTests

[iOS] REGRESSION(r254699) : fast/forms/interactive-validation-remove-node-in-handler.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=206669

Reviewed by Wenson Hsieh.

The timeout was caused by the invalidation bubble in interactive-validation-prevented.html never getting closed.
Address the issue by explicitly dismissing the invalidation bubble by setting a value to the input element.

fast/forms/interactive-validation-prevented.html:

6:09 PM Changeset in webkit [255114] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

macCatalyst: Don't get any custom cursors in subframes
https://bugs.webkit.org/show_bug.cgi?id=206781
<rdar://problem/58698374>

Reviewed by Simon Fraser.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::positionInformation):
Adjust the hit test to allow child frame content, and reorganize the
rest of the code to use the hit frame instead of the main frame.

5:37 PM Changeset in webkit [255113] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Null Ptr Deref READ @ WebCore::RenderMultiColumnFlow::lastMultiColumnSet const
https://bugs.webkit.org/show_bug.cgi?id=206106

Patch by Jack Lee <Jack Lee> on 2020-01-24
Reviewed by Ryosuke Niwa.

Could not write a reproducible fast test case for this.

rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::lastMultiColumnSet const):

rendering/updating/RenderTreeBuilderMultiColumn.cpp:

(WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant):

5:35 PM Changeset in webkit [255112] by mark.lam@apple.com

6 edits
1 add in trunk

IntlObject's cached strings should be immortal and safe for concurrent access.
https://bugs.webkit.org/show_bug.cgi?id=206779
<rdar://problem/58831763>

Reviewed by Yusuke Suzuki.

JSTests:

stress/numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js: Added.

Source/JavaScriptCore:

In IntlObject's numberingSystemsForLocale(), we have a never destroyed
cachedNumberingSystems which is a singleton vector of Strings which are shared
multiple VMs. Hence, the strings in this vector should be a StaticStringImpl
so that it will be immortal, and can be access concurrently from multiple VMs
on different threads without any ref/deref'ing race issues.

runtime/IntlObject.cpp:

(JSC::numberingSystemsForLocale):

Source/WTF:

Add a factory for creating a dynamically allocated StaticStringImpl.

Note: StaticStringImpl is guaranteed to have the same shape as StringImpl.
The only difference is that s_refCountFlagIsStaticString is set on the refCount
for StaticStringImpl. Since the client will use the StaticStringImpl as a
StringImpl, we implement the factory by using StringImpl::createInternal() for
simplicity, and set the s_refCountFlagIsStaticString flag thereafter.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::createStaticStringImpl):

wtf/text/StringImpl.h:

5:28 PM Changeset in webkit [255111] by jiewen_tan@apple.com

2 edits in trunk/Source/WebKit

Unreviewed, a speculative test fix after r255041

UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getAttestation const):

5:22 PM Changeset in webkit [255110] by ysuzuki@apple.com

2 edits in trunk/JSTests

REGRESSION (r254964-r254970?): Catalina Debug JSC bot timing out while running tests
https://bugs.webkit.org/show_bug.cgi?id=206785

Unreviewed, skipping the test if $buildType is "debug".

stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js:

5:12 PM Changeset in webkit [255109] by Alan Coon

1 copy in tags/Safari-609.1.15.2

Tag Safari-609.1.15.2.

5:08 PM Changeset in webkit [255108] by Wenson Hsieh

9 edits
2 adds in trunk

[iOS] Long pressing text inside a selection should update the selection
https://bugs.webkit.org/show_bug.cgi?id=206769
<rdar://problem/58704316>

Reviewed by Tim Horton.

Source/WebCore:

Remove hasSelectionAtPosition, which is no longer needed.

page/Page.cpp:

(WebCore::Page::hasSelectionAtPosition const): Deleted.

page/Page.h:

Source/WebKit:

Makes it possible to update the selection using text interaction gestures inside an existing text selection. To
do this, we remove code that was previously required in order to disambiguate text selection and drag gestures.
However, since adopting asynchronous drag interaction SPI, this check has not been necessary.

The only other purpose of this check was to avoid triggering text selection gestures after canceling a drag
that did not begin (i.e. the touch location did not move). Instead of bailing in -textInteractionGestures:
shouldBeginAtPoint: and -hasSelectablePositionAtPoint:, we can achieve the same effect by simply resetting the
text interaction gestures when the drag lift begins (at which point we know the drag interaction is starting).
This also ensures that on iPad, in the case where the drag was cancelled by the page, long pressing may still
trigger text selection.

Test: editing/selection/ios/select-text-in-existing-selection.html

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Remove the hasSelectionAtPosition flag from position information, since we no longer need it.

UIProcess/ios/WKContentViewInteraction.mm:

(-[UIGestureRecognizer _wk_cancel]):

Drive-by fix: just ignore the gesture if it is already disabled. This prevents us from causing a gesture
recognizer that was previously disabled to become enabled as a result of calling -_wk_cancel.

(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView cancelActiveTextInteractionGestures]):

Instead of making the text interaction gestures return NO from -gestureRecognizerShouldBegin:, explicitly cancel
the text interaction gestures that may select text.

(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::positionInformation):

Remove the hasSelectionAtPosition flag from position information, since we no longer need it.

LayoutTests:

Add a layout test to verify that it's possible to select text by long pressing inside an existing text
selection. The test is runnable on both iPad and iPhone, since it programmatically prevents dragstart.

editing/selection/ios/select-text-in-existing-selection-expected.txt: Added.
editing/selection/ios/select-text-in-existing-selection.html: Added.

5:07 PM Changeset in webkit [255107] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] (Regression) LayoutTests/fast/text/whitespace/029.html fails
https://bugs.webkit.org/show_bug.cgi?id=206773
<rdar://problem/58883388>

Reviewed by Simon Fraser.

While line break is an inline box, it does not have inline content so do not try to cast it to Container.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):

4:49 PM Changeset in webkit [255106] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Update EditorState from WebProcess when requesting context menu
https://bugs.webkit.org/show_bug.cgi?id=206775
<rdar://problem/56305573>

Reviewed by Wenson Hsieh.

When generating a context menu, AppKit calls -validRequestorForSendType:returnType:
which queries the editor state in WebViewImpl::validRequestorForSendAndReturnTypes.
Without updating the editor state, the first time you right click on a link,
the Services menu item did not appear because we were looking at a stale editor state.
Verified manually this fixes the bug.

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleSelectionServiceClick):

4:45 PM Changeset in webkit [255105] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

macCatalyst: Right clicking on links follows the link, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=206777
<rdar://problem/56586280>

Reviewed by Wenson Hsieh.

UIProcess/ios/WKMouseGestureRecognizer.mm:

(-[WKMouseGestureRecognizer createMouseEventWithType:forEvent:]):
(-[WKMouseGestureRecognizer touchesEnded:withEvent:]):
I got 'button' and 'buttons' backwards.

'button' indicates which button the event is about, so in MouseUp,
it should still be 2.

'buttons' indicate which buttons are still down, so in MouseUp,
it should not include 2. Since we don't currently track mouse button
chording here, we'll just say "none". Leave a FIXME about that.

This makes WebCore's behavior correct, and now it doesn't follow the link.

4:34 PM Changeset in webkit [255104] by rniwa@webkit.org

2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/requestidlecallback/callback-xhr-sync.html is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206676
<rdar://problem/58839631>

Add a flaky test expectation.

TestExpectations:

4:23 PM Changeset in webkit [255103] by commit-queue@webkit.org

4 edits
2 adds in trunk

AirPlay placard not visible when AirPlay is entered in fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=206772
<rdar://problem/57098851>

Patch by Jer Noble <jer.noble@apple.com> on 2020-01-24
Reviewed by Eric Carlson.

Test: media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls.html

The AirPlay and Picture-in-picture placards should always become visible, regardless of
whether the <video> element uses the native media controls. So "disabling" the PlacardSupport
object should not remove the listeners for presentation mode and route change events. Instead
merely remember whether the object is disabled, so that the "error placard" will only be shown
if controls are enabled, and PiP and AirPlay placards will always be shown.

Modules/modern-media-controls/media/placard-support.js:

(PlacardSupport.prototype.enable):
(PlacardSupport.prototype.disable):
(PlacardSupport.prototype._updatePlacard):

3:40 PM Changeset in webkit [255102] by Russell Epstein

4 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r255039. rdar://problem/58855996

Background thread with ITP Database should lock when the network process is suspended
https://bugs.webkit.org/show_bug.cgi?id=206593
rdar://problem/58713379

Reviewed by Chris Dumez.

This patch adds a function to hang the background queue when the
NetworkProcess is preparing to suspend.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::suspend): (WebKit::WebResourceLoadStatisticsStore::resume):
NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::prepareToSuspend): (WebKit::NetworkProcess::resume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255101] by Russell Epstein

2 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r254996. rdar://problem/58856010

OptimizeAssociativeExpressionTrees should reset value owners before running
https://bugs.webkit.org/show_bug.cgi?id=206670
<rdar://problem/58535628>

Reviewed by Robin Morisset.

We have a crash inside OptimizeAssociativeExpressionTrees and we don't know
how to reproduce it. Also, based on Mark's auditing of the crash site's
assembly, Mark thinks we're crashing on a "currupt" basic block.

After I audited the code, I saw that we rely on value owners in this phase.
However, we don't actually reset them before running the phase. This patch
adds that as a speculative fix for the crash we're seeing.

b3/B3OptimizeAssociativeExpressionTrees.cpp: (JSC::B3::OptimizeAssociativeExpressionTrees::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255100] by Russell Epstein

6 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254991. rdar://problem/58856021

[Web Animations] Make AnimationList ref-counted
https://bugs.webkit.org/show_bug.cgi?id=206664

Reviewed by Antti Koivisto.

platform/animation/AnimationList.cpp:
platform/animation/AnimationList.h: (WebCore::AnimationList::create): (WebCore::AnimationList::copy): (WebCore::AnimationList::AnimationList): Deleted.
rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::ensureAnimations): (WebCore::RenderStyle::ensureTransitions):
rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255099] by Russell Epstein

3 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r254962. rdar://problem/58856037

Restore nullification of DFG::Plan::m_vm when the plan is cancelled.
https://bugs.webkit.org/show_bug.cgi?id=206633
<rdar://problem/58811967>

Reviewed by Robin Morisset.

In r253243, I replaced the nullification of Plan::m_vm in Plan::cancel() with
code to decorate the m_vm pointer with a nuke bit. The thinking is that keeping
the VM pointer in nuked form allows us to do certain assertions, as well as
implementing code in support of keeping Box<Identifier>s alive. It is only
correct to use the nuked VM pointer if and only if the VM is guaranteed to
outlive the Plan. r253243 guarantees this condition.

In r254464, I replaced the use of Box<Identifier> with CacheableIdentifier.
This obviated all the support code added above, and rolled out most of it.
However, I opted to keep the nuked VM pointer in the DFG::Plan to as a debugging
aid (it's nice to be able to know which VM the Plan came from).

However, r254464 also undid the guarantee that the VM will outlive the Plan.
As a result, a nuked VM pointer is no longer guaranteed to point to a valid VM.
Some worker layout tests, run on an ASAN build, detected that the pointer is
pointing to an already freed VM and failed with a crash.

This patch fixes this issue by completely reverting the nuked VM pointer code,
and restores nullification of the m_vm pointer in Plan::cancel().

dfg/DFGPlan.cpp: (JSC::DFG::Plan::computeCompileTimes const): (JSC::DFG::Plan::cancel):
dfg/DFGPlan.h: (JSC::DFG::Plan::vm const): (JSC::DFG::Plan::unnukedVM const): Deleted. (JSC::DFG::Plan::nuke): Deleted. (JSC::DFG::Plan::unnuke): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255098] by Russell Epstein

3 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254951. rdar://problem/58856000

Make a Ref to WindowEventLoop when the timer to run tasks fires
https://bugs.webkit.org/show_bug.cgi?id=206568

Reviewed by Antti Koivisto.

Keep WindowEventLoop alive explicitly while invoking EventLoop::run.

dom/WindowEventLoop.cpp: (WebCore::WindowEventLoop::WindowEventLoop): (WebCore::WindowEventLoop::didReachTimeToRun):
dom/WindowEventLoop.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255097] by Russell Epstein

3 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254938. rdar://problem/58856028

Fix SDK availability macros
https://bugs.webkit.org/show_bug.cgi?id=206463
<rdar://problem/58581906>

Reviewed by Timothy Hatcher.

Bug 197841 updated WebKit.xcconfig with regards to when it runs a
header post-processing script. This post-processing script grovels
over our exported headers, changing macros like WK_API_AVAILABLE to
the standard API_AVAILABLE. Because of the change in Bug 197841, the
script was no longer being run when preparing macOS 10.15 SDKs, which
was breaking those SDKs. Fix this by reverting the change, allowing
the macros to be replaced for macOS 10.15.

We also need to touch WKFoundation.h in order to support incremental
builds. If we don't, then the version of WKFoundation.h that was
exported in the previous build and that was incorrectly post-processed
would remain incorrectly post-processed. Touch the file so that it
will get re-exported and re-post-processed.

No new tests - no added or changed functionality.

Configurations/WebKit.xcconfig:
Shared/API/Cocoa/WKFoundation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [255096] by Russell Epstein

4 edits in branches/safari-609-branch/Tools

Cherry-pick r254318. rdar://problem/58856031

TestController::platformLibraryPathForTesting() returns inner pointer to autoreleased NSString
<https://webkit.org/b/206018>
<rdar://problem/58449733>

Reviewed by Darin Adler.

WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
Use WTF::AutodrainedPool to fix remaining autoreleasePool leaks.
WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformLibraryPathForTesting):
WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformLibraryPathForTesting):
Retain NSString since these methods return an inner pointer. This also only needs to be initialized once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [255095] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Crash in AXIsolatedObject::tagName.
https://bugs.webkit.org/show_bug.cgi?id=206765

Reviewed by Chris Fleizach.

Fixes crash in AXIsolatedObject::tagName.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): Was missing the isolatedCopy when caching the tagName.

2:19 PM Changeset in webkit [255094] by Keith Rollin

2 edits in trunk/Source/WebKitLegacy

Remove check-xcfilelists.sh from WebKitLegacy Xcode build target
https://bugs.webkit.org/show_bug.cgi?id=206762
<rdar://problem/58825997>

Reviewed by Alexey Proskuryakov.

When check-xcfilelists.sh got added to the WebKitLegacy Xcode project,
it was also accidentally added to the WebKitLegacy build target. This
caused it to be treated as a "resource", and so was copied to the
output directory in the Resources sub-folder during the build. This
copying is not expected, needed, or desired. Remove
check-xcfilelists.sh from the target, which also removes it from the
Copy Resources build phase, which removes it from the
WebKitLegacy.framework/Resources directory.

WebKitLegacy.xcodeproj/project.pbxproj:

1:58 PM Changeset in webkit [255093] by jiewen_tan@apple.com

2 edits in trunk/Source/WebKit

Unreviewed, a build fix after r255056

UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getAttestation const):

1:18 PM Changeset in webkit [255092] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r255089.

Breaks tvOS build.

Reverted changeset:

"WebCore: Remove iOS 11 macros from
WebItemProviderPasteboard.h"
https://bugs.webkit.org/show_bug.cgi?id=206719
https://trac.webkit.org/changeset/255089

12:57 PM Changeset in webkit [255091] by Alan Coon

5 edits in branches/safari-609.1.15-branch/Source/WebKit

Cherry-pick r254552. rdar://problem/58812968

REGRESSION (r253394): After swiping back during a navigation, WKWebView gets stuck with the forward content, stops repainting
https://bugs.webkit.org/show_bug.cgi?id=206268
<rdar://problem/58536702>

Reviewed by Simon Fraser.

UIProcess/ViewGestureController.cpp: (WebKit::ViewGestureController::endSwipeGesture):
UIProcess/ViewGestureController.h:
UIProcess/ios/ViewGestureControllerIOS.mm: (WebKit::ViewGestureController::beginSwipeGesture): (WebKit::ViewGestureController::endSwipeGesture): (WebKit::ViewGestureController::removeSwipeSnapshot):
UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::beginSwipeGesture): (WebKit::ViewGestureController::removeSwipeSnapshot): After r253394, we start loading the destination page in willEndSwipeGesture, when we know the gesture will complete, instead of in endSwipeGesture, when it is actually done.

This means that if we decide that we should tear down the snapshot immediately,
this can now happen in the window between willEndSwipeGesture and endSwipeGesture.

However, removeSwipeSnapshot has numerous dependencies on endSwipeGesture
(especially on iOS, where there are /also/ dependencies in the other direction -
endSwipeGesture will never be called after removeSwipeSnapshot because
of the gestureID mismatch).

Regardless, it does not make sense to remove the snapshot while the animation
is still running. So, if something causes removeSwipeSnapshot to be called
before endSwipeGesture, we just set a bit and call it inside endSwipeGesture instead.

This ends up putting the snapshot removal ordering back as it was before r253394.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:54 PM Changeset in webkit [255090] by Alan Coon

8 edits in branches/safari-609.1.15-branch/Source

Versioning.

12:40 PM Changeset in webkit [255089] by Jonathan Bedard

2 edits in trunk/Source/WebCore

WebCore: Remove iOS 11 macros from WebItemProviderPasteboard.h
https://bugs.webkit.org/show_bug.cgi?id=206719

Reviewed by Tim Horton.

No functional changes, covered by existing tests.

platform/ios/WebItemProviderPasteboard.h:

12:26 PM Changeset in webkit [255088] by Caio Lima

7 edits in trunk/Source/JavaScriptCore

[ARMv7][JIT] Implement checkpoint support
https://bugs.webkit.org/show_bug.cgi?id=206611

Reviewed by Yusuke Suzuki.

This patch is adding code path to properly support checkpoint on ARMv7.

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

We changed the scratch buffer population to properly handle
callee-saved registers on 32-bits. For more details, check comments on
source code.

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

We are adding back regCS1 to be used as GPRReg on DFG and
scratch registers. This was necessary because some code generated by
GetByVal IC requires at least 9 registers available.
Given that, we also added such register to dfgCalleeSaveRegisters
set.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitPutByValWithCachedId):

jit/RegisterSet.cpp:

(JSC::RegisterSet::dfgCalleeSaveRegisters):

llint/LowLevelInterpreter.asm:

12:25 PM Changeset in webkit [255087] by Keith Rollin

2 edits in trunk/Source/WTF

Fix internal Apple builds after r254411
https://bugs.webkit.org/show_bug.cgi?id=206723
<rdar://problem/58844735>

Reviewed by Maciej Stachowiak.

The default Xcode build configuration has changed between macOS 10.13
and macOS 10.15, such that references to some frameworks when bulding
for the latter don't work when building for the former. Fix this by
explicitly adding support for the desired build location rather than
assuming such support will be provided for us.

Configurations/WTF.xcconfig:

12:00 PM Changeset in webkit [255086] by keith_miller@apple.com

3 edits in trunk/Source/JavaScriptCore

JSC should produce a module map.
https://bugs.webkit.org/show_bug.cgi?id=206717

Reviewed by Mark Lam.

Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.modulemap:

11:33 AM Changeset in webkit [255085] by youenn@apple.com

8 edits in trunk

Add support for MediaRecorder.requestData
https://bugs.webkit.org/show_bug.cgi?id=206731

LayoutTests/imported/w3c:

Reviewed by Eric Carlson.

web-platform-tests/mediacapture-record/idlharness.window-expected.txt:

Source/WebCore:

Reviewed by Eric Carlson.

Add support for requestData that fetches any available data.
Expose MediaRecorder stream.
Covered by updated tests.

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::requestData):

Modules/mediarecorder/MediaRecorder.h:
Modules/mediarecorder/MediaRecorder.idl:

LayoutTests:

Reviewed by Eric Carlson.

http/wpt/mediarecorder/MediaRecorder-dataavailable.html:

11:30 AM Changeset in webkit [255084] by Jon Davis

2 edits in trunk/Websites/webkit.org

Fix editing permissions for the Web Inspector Editor role
https://bugs.webkit.org/show_bug.cgi?id=206761

Reviewed by Devin Rousso.

wp-content/plugins/web-inspector-pages.php:

11:12 AM Changeset in webkit [255083] by commit-queue@webkit.org

3 edits
2 adds in trunk

Nullptr deref in WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation when an element is inserted before legend under multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=206109

Patch by Jack Lee <Jack Lee> on 2020-01-24
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/forms/fieldset/fieldset-crash-insert-before-legend-under-multicol.html

rendering/updating/RenderTreeBuilderBlockFlow.cpp:

(WebCore::RenderTreeBuilder::BlockFlow::attach):

LayoutTests:

fast/forms/fieldset/fieldset-crash-insert-before-legend-under-multicol-expected.txt: Added.
fast/forms/fieldset/fieldset-crash-insert-before-legend-under-multicol.html: Added.

10:57 AM Changeset in webkit [255082] by Matt Lewis

5 edits in trunk/Tools

Remove Apple windows 7 queues.
https://bugs.webkit.org/show_bug.cgi?id=206702

Reviewed by Jonathan Bedard.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Removed Windows 7 queues from config and from dashboard.

10:53 AM Changeset in webkit [255081] by pvollan@apple.com

13 edits
1 delete in trunk

Unreviewed, rolling out r255050.

Introduced crashes on bots

Reverted changeset:

"[Cocoa] Media mime types map should be created in the UI
process"
https://bugs.webkit.org/show_bug.cgi?id=206478
https://trac.webkit.org/changeset/255050

10:40 AM Changeset in webkit [255080] by Andres Gonzalez

5 edits in trunk/Source/WebCore

Implementation of AXIsolatedObject::isStaticText and isLandmark methods.
https://bugs.webkit.org/show_bug.cgi?id=206745

Reviewed by Chris Fleizach.

isStaticText moved from the AXObject class to the base AXCoreObject so

that it is used by isolated objects as well.

Implemented isLandmark.
Ordered alphabetically the setProperty calls for most IsXXX

properties in initializeAttributeData for easier identification.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::isStaticText const):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::isLandmark const): Deleted, inline in header file.
(WebCore::AXIsolatedObject::isStaticText const): Deleted, implemented in AXCoreObject.

accessibility/isolatedtree/AXIsolatedObject.h:

10:29 AM Changeset in webkit [255079] by commit-queue@webkit.org

2 edits
5 adds in trunk/LayoutTests

[GTK][WPE] Websockets close-on-x tests are failing
https://bugs.webkit.org/show_bug.cgi?id=206392

Unreviewed gardening.

Rebaseline after libsoup commit 35f1bac5.

Patch by Lauro Moura <Lauro Moura> on 2020-01-24

platform/gtk/TestExpectations:
platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Added.
platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Added.
platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Added.
platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Added.
platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Added.

10:13 AM Changeset in webkit [255078] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GTK][WPE] Several WPT fetch tests are failing
https://bugs.webkit.org/show_bug.cgi?id=206416

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-24
Reviewed by Frédéric Wang.

It is better to skip these as more tests can be added
and this feature is not enabled on WPE/GTK.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

9:58 AM Changeset in webkit [255077] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r255052.
https://bugs.webkit.org/show_bug.cgi?id=206758

"Broke production builds" (Requested by rmorisset on #webkit).

Reverted changeset:

"Break the dependency between jsc and DerivedSources"
https://bugs.webkit.org/show_bug.cgi?id=206720
https://trac.webkit.org/changeset/255052

9:35 AM Changeset in webkit [255076] by graouts@webkit.org

14 edits in trunk

[Web Animations] Support multiple CSS Animations with the same name in animation-name
https://bugs.webkit.org/show_bug.cgi?id=206688

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark some new WPT progressions.

web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt:
web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt:
web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement-expected.txt:

Source/WebCore:

AnimationTimeline would keep track of registered CSS Animations by name for a given element in m_elementToCSSAnimationByName which would map one CSSAnimation
per String (the animation-name) for a given Element. However, within the same animation-name property, the name of a given @keyframes rules may appear more
than once, and the CSS Animations specification explains how to handle this scenario.

We now correctly handle this by replacing m_elementToCSSAnimationByName with the new m_elementToCSSAnimationsCreatedByMarkupMap which simply maps an Element
to a ListHashSet of CSSAnimation objects. Removing the string that appeared in animation-name to create this animation requires us to keep the AnimationList
used for the last style update for sorting purposes, since having multiple instances of the same string would not allow disambiguation when sorting the
KeyframeEffectStack.

So we also replace m_cssAnimationNames, a Vector<String>, with m_cssAnimationList, a RefPtr<const AnimationList>, and use this to compare Animation objects
stored in the AnimationList against the backing animation of each CSSAnimation.

Storing the AnimationList on the KeyframeEffectStack also has the benefit of allowing us to use this as the previous state when updating CSS Animations in
AnimationTimeline::updateCSSAnimationsForElement(). We used to rely on the previous RenderStyle provided to that function, but it's possible that this style
is null and we would unnecessarily create additional CSSAnimation objects for animations that actually were retained since the last time CSS Animations were
invalidated. We now use the stored AnimationList on the invalidated element's KeyframeEffectStack and create a new animation list that will replace the old
list stored in the m_elementToCSSAnimationsCreatedByMarkupMap map for that element. We can also compare the old list with the new list to find out which
animations are no longer current.

Finally, we refactor things a bit to have some new aliases AnimationCollection and CSSAnimationCollection instead of using ListHashSet<> in our types.

animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement): Use the new AnimationCollection alias.
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement): We no longer need to do any work for CSSAnimation here since the
m_elementToCSSAnimationByName map is no more and the m_elementToCSSAnimationsCreatedByMarkupMap that replaces it is updated in updateCSSAnimationsForElement()
and elementWasRemoved().
(WebCore::AnimationTimeline::animationsForElement const): Since animations are correctly sorted accounting for their composite order in KeyframeEffectStack,
call KeyframeEffectStack::sortedEffects() when we're called with Ordering::Sorted.
(WebCore::AnimationTimeline::removeCSSAnimationCreatedByMarkup): New method called by elementWasRemoved() to ensure that when an element is removed, we remove
its CSSAnimation objects from the new m_elementToCSSAnimationsCreatedByMarkupMap and also update the AnimationList on the relevant KeyframeEffectStack.
(WebCore::AnimationTimeline::elementWasRemoved): Call the new removeCSSAnimationCreatedByMarkup() method before canceling a CSSAnimation.
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement): Call the new removeCSSAnimationCreatedByMarkup() method before canceling a CSSAnimation.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Use the AnimationList recoreded on the relevant KeyframeEffectStack to determine which CSSAnimation
objects to create, cancel or merely update depending on the AnimationList in the current style.

animation/AnimationTimeline.h:
animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::getAnimations const): Use compareAnimationsByCompositeOrder() to correctly sort CSS Animations since they are no longer guaranteed
to be stored in the relevant map in the expected order.

animation/KeyframeEffectStack.cpp:

(WebCore::KeyframeEffectStack::ensureEffectsAreSorted): Use the new m_cssAnimationList instead of the old m_cssAnimationNames when sorting effects.
(WebCore::KeyframeEffectStack::setCSSAnimationList):
(WebCore::KeyframeEffectStack::setCSSAnimationNames): Deleted.

animation/KeyframeEffectStack.h:

(WebCore::KeyframeEffectStack::cssAnimationList const):
(WebCore::KeyframeEffectStack::cssAnimationNames const): Deleted.

animation/WebAnimation.cpp:

(WebCore::WebAnimation::commitStyles): Use the new KeyframeEffectStack::cssAnimationList() instead of the old KeyframeEffectStack::cssAnimationNames().

animation/WebAnimationUtilities.cpp:

(WebCore::compareAnimationsByCompositeOrder): Update the composite order comparison utility to use an AnimationList rather than a list of animation names.

animation/WebAnimationUtilities.h:
platform/animation/AnimationList.h:

(WebCore::AnimationList::copy const):

9:18 AM Changeset in webkit [255075] by Jonathan Bedard

2 edits in trunk/Tools

run-webkit-tests: Handle case where device socket make handle invalid
https://bugs.webkit.org/show_bug.cgi?id=206707

Reviewed by Stephanie Lewis.

Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.NonBlockingFileFromSocket.close): Catch IOError when closing file.

8:42 AM Changeset in webkit [255074] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Painting] Add Display::Run cleanup to TextPainter::clearGlyphDisplayLists
https://bugs.webkit.org/show_bug.cgi?id=206744
<rdar://problem/58867112>

Reviewed by Antti Koivisto.

rendering/TextPainter.cpp:

(WebCore::TextPainter::clearGlyphDisplayLists):

8:32 AM Changeset in webkit [255073] by Jonathan Bedard

4 edits in trunk/Source/WTF

WTF: Remove old iOS version macros
https://bugs.webkit.org/show_bug.cgi?id=206634
<rdar://problem/58818561>

Reviewed by Darin Adler.

wtf/PlatformEnable.h: Remove iOS 12 version macro.
wtf/PlatformHave.h: Ditto.
wtf/PlatformUse.h: Ditto.

7:58 AM Changeset in webkit [255072] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Add missing sysctl-read permission (already available in macOS sandbox)
https://bugs.webkit.org/show_bug.cgi?id=206713
<rdar://problem/57665153>

Reviewed by Per Arne Vollan.

Correct a sandbox violation encountered when attempting to log the system hostname.
This was already handled properly on macOS, but the rule was not added to the iOS sandbox.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

7:26 AM Changeset in webkit [255071] by Antti Koivisto

5 edits in trunk/Source/WebCore

[LFC][Integration] Clear inline item caches on low memory notification
https://bugs.webkit.org/show_bug.cgi?id=206740
<rdar://problem/58773905>

Reviewed by Zalan Bujtas.

Clear inline item caches on low memory notification.

layout/inlineformatting/InlineFormattingState.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::releaseCaches):
(WebCore::LayoutIntegration::LineLayout::releaseInlineItemCache):

layout/integration/LayoutIntegrationLineLayout.h:

Remove inline capacity. It is rarely optimal and we can afford the heap allocation.

page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):

7:14 AM Changeset in webkit [255070] by Adrian Perez de Castro

9 edits in trunk/Source

Fix various non-unified build issues introduced since r254751
https://bugs.webkit.org/show_bug.cgi?id=206736

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

tools/CompilerTimingScope.cpp: Add missing inclusions of wtf/Vector.h and wtf/text/WTFString.h

Source/WebCore:

No new tests needed.

Modules/cache/DOMCacheEngine.cpp: Move errorToException() function out from the file to

make it usable from DOMCacheStorage.cpp

Modules/cache/DOMCacheEngine.h:

(WebCore::DOMCacheEngine::errorToException): Added.

Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches): Adapt to use DOMCacheEngine::errorToException().

platform/graphics/cairo/ImageBufferUtilitiesCairo.cpp: Add missing RefPtrCairo.h inclusion.

Source/WebKit:

WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp: Add missing WebFrame.h inclusion.

7:14 AM Changeset in webkit [255069] by clopez@igalia.com

2 edits in trunk/Tools

[GTK] API test runner fails with error: too many open files.
https://bugs.webkit.org/show_bug.cgi?id=206743

Reviewed by Carlos Garcia Campos.

The API test runner for google tests was leaking file descriptors because
it was not closing the file descriptor of the pseudo-terminal of the child,
which was referred in the parent because of the forkpty() call.
This was causing a small but constant increase of open file descriptors,
until the point it reached the limit of maximum open files (1024 usually)
causing this error.

Fix that by closing the reference to the fd of the child's pseudo-terminal.

glib/api_test_runner.py:

(TestRunner._run_google_test):

6:36 AM Changeset in webkit [255068] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][Integration] LineLayout::paint should take advantage of the glyph display list cache
https://bugs.webkit.org/show_bug.cgi?id=206727
<rdar://problem/58809696>

Reviewed by Antti Koivisto.

layout/displaytree/DisplayInlineContent.cpp:

(WebCore::Display::InlineContent::~InlineContent):

layout/displaytree/DisplayInlineContent.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

6:11 AM Changeset in webkit [255067] by don.olmstead@sony.com

16 edits
3 copies
3 moves
3 deletes in trunk/Source/WebKit

Centralize AuxiliaryProcessMainBase implementations
https://bugs.webkit.org/show_bug.cgi?id=206700

Reviewed by Carlos Garcia Campos.

Non-Cocoa ports share a common usage of AuxiliaryProcessMainBase but the implementations
don't share a lot of code. This patch centralizes the code and the naming used.

NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

NetworkProcess/EntryPoint/win/NetworkProcessMain.cpp:

(main):

NetworkProcess/NetworkProcessMain.h: Renamed from Source/WebKit/NetworkProcess/win/NetworkProcessMainWin.h.
NetworkProcess/curl/NetworkProcessMainCurl.cpp: Renamed from Source/WebKit/NetworkProcess/win/NetworkProcessMainWin.cpp.

(WebKit::initializeAuxiliaryProcess<NetworkProcess>):
(WebKit::NetworkProcessMain):

NetworkProcess/soup/NetworkProcessMainSoup.cpp:

(WebKit::NetworkProcessMain):
(WebKit::NetworkProcessMainUnix): Deleted.

NetworkProcess/unix/NetworkProcessMainUnix.h: Removed.
PlatformFTW.cmake:
PlatformGTK.cmake:
PlatformWPE.cmake:
PlatformWin.cmake:
PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:

(main):

PluginProcess/PluginProcessMain.h: Renamed from Source/WebKit/PluginProcess/unix/PluginProcessMainUnix.h.
PluginProcess/unix/PluginProcessMainUnix.cpp:

(WebKit::PluginProcessMain):
(WebKit::PluginProcessMainUnix): Deleted.

Shared/AuxiliaryProcessMain.h: Renamed from Source/WebKit/Shared/unix/AuxiliaryProcessMain.h.
WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

WebProcess/EntryPoint/win/WebProcessMain.cpp:

(main):

WebProcess/WebProcessMain.h: Renamed from Source/WebKit/WebProcess/win/WebProcessMainWin.h.
WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMain):
(WebKit::WebProcessMainUnix): Deleted.

WebProcess/playstation/WebProcessMainPlayStation.cpp: Renamed from Source/WebKit/WebProcess/unix/WebProcessMainUnix.h.

(WebKit::WebProcessMain):

WebProcess/win/WebProcessMainWin.cpp:

(WebKit::WebProcessMain):
(WebKit::WebProcessMainWin): Deleted.

WebProcess/wpe/WebProcessMainWPE.cpp:

(WebKit::WebProcessMain):
(WebKit::WebProcessMainUnix): Deleted.

webkitglib-symbols.map:

5:53 AM Changeset in webkit [255066] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] More unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=206693

Unreviewed gardening.

Patch by Lauro Moura <Lauro Moura> on 2020-01-24

platform/gtk/TestExpectations:

3:32 AM Changeset in webkit [255065] by Pablo Saavedra

2 edits in trunk/LayoutTests

Layout Test animations/no-style-recalc-during-accelerated-animation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=206733

Unreviewed test gardening.

platform/gtk/TestExpectations:

3:18 AM Changeset in webkit [255064] by commit-queue@webkit.org

2 edits
4 moves
3 adds
2 deletes in trunk/LayoutTests

Import 2 sets of grid-align-tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=206492

Patch by Rossana Monteriso <rmonteriso@igalia.com> on 2020-01-24
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Add outdated grid-align tests, checked and adapted to the WPT project, to the css-grid/alignment folder for imported tests.
Add also blue-100.png support file inside the css/support folder.
Correct the test description inside <p>, for grid-align-stretching-replaced-items.html.

web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-lr.html:
web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-rl.html:
web-platform-tests/css/css-grid/alignment/grid-align-stretching-replaced-items.html:
web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-lr-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-align-content-vertical-rl-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-align-stretching-replaced-items-expected.txt:
web-platform-tests/css/support/blue-100.png:

LayoutTests:

Remove outdated grid-align tests, that are being replaced by newer tests, adapted to the WPT project and imported
to the corresponding css-grid folder inside WebKit.

fast/css-grid-layout/grid-align-content-vertical-lr-expected.txt: Removed.
fast/css-grid-layout/grid-align-content-vertical-rl-expected.txt: Removed.
fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt: Removed.
fast/css-grid-layout/grid-align-stretching-replaced-items.html: Removed.
fast/css-grid-layout/grid-align-content-vertical-lr.html: Removed.
fast/css-grid-layout/grid-align-content-vertical-rl.html: Removed.

3:17 AM Changeset in webkit [255063] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix number of callee saved register count on MIPS
https://bugs.webkit.org/show_bug.cgi?id=206732

Patch by Paulo Matos <Paulo Matos> on 2020-01-24
Reviewed by Žan Doberšek.

MIPS has been issuing illegal instruction errors due to stack corruption.
This is caused by an incorrect number of CalleeSaveRegisterCount
that should be set to 3 since r254674.

llint/LowLevelInterpreter.asm:

2:52 AM Changeset in webkit [255062] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed WPE dependency bump.

wpe/jhbuild.modules: Bump the libwpe checkout commit to include fixes

for configuration errors that can occur with older (but still supported)
CMake versions.

1:03 AM Changeset in webkit [255061] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed GTK gardening. Mark /webkit/WebKitWebPage/get-uri as flaky

TestWebKitAPI/glib/TestExpectations.json:

12:47 AM Changeset in webkit [255060] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[GTK] Reduce the maximum time we wait for draw events in DrawingMonitor
https://bugs.webkit.org/show_bug.cgi?id=206662

Reviewed by Carlos Alberto Lopez Perez.

1 second is too much, we can wait up to 100_ms instead and wait for the next frame after 16_ms. We should also
ensure there's a draw event since this is called from dispatchAfterEnsuringDrawing().

UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:

(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::start):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::didDraw):

12:37 AM Changeset in webkit [255059] by Antti Koivisto

9 edits
2 adds in trunk

:matches() doesn't combine correctly with pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=206654

Reviewed by Simon Fraser.

Source/WebCore:

:matches() has been renamed to :is() in the spec (https://www.w3.org/TR/selectors-4/#matches).
Update the :matches implementation to spec behavior regarding pseudo element handling.

"Pseudo-elements cannot be represented by the matches-any pseudo-class; they are not valid within :is()."

Selectors like

::matches(foo, .parent .child)::first-letter

should work while

::matches(:first-letter)

shoudn't match anything.

Test: fast/selectors/matches-with-pseudo-element.html

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively const):
(WebCore::SelectorChecker::checkOne const):

Don't provide pseudoId into ::matches subselectors. Pseudo elements are not suppported inside ::matches.
If one if found, fail that subselector.

css/SelectorChecker.h:

LayoutTests:

TestExpectations:

Unskip fast/css/first-letter-and-float-crash.html which no longer hits assert due to this.

fast/selectors/matches-with-pseudo-element-expected.html: Added.
fast/selectors/matches-with-pseudo-element.html: Added.
fast/css/currentColor-on-before-after-pseudo-elements.html:
fast/css/matches-specificity-5.html:
fast/selectors/pseudo-element-inside-matches-expected.html:
fast/selectors/pseudo-element-inside-matches.html:

Update the existing tests to match the behavior.

12:23 AM Changeset in webkit [255058] by youenn@apple.com

13 edits in trunk

Make sure fetch tasks go to network if service worker never gets to activated
https://bugs.webkit.org/show_bug.cgi?id=206648

Reviewed by Chris Dumez.

Source/WebCore:

In case worker context process crashes, the SWServerWorker gets set to NotRunning.
If the SWServerWorker has pending activating completion handlers, they will never be called until the worker is destroyed.
But the worker may never be destroyed until its registration is destroyed.
This may trigger service worker fetch task hangs.

To fix this, make sure to call activating completion handlers whenever the SWServerWorker state is changed to either Terminating or NotRunning.

Covered by updated test.

workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::~SWServerWorker):
(WebCore::SWServerWorker::whenActivated):
(WebCore::SWServerWorker::setState):

workers/service/server/SWServerWorker.h:

Source/WebKit:

In case activating completion handlers are not called, the fetch task timeout should kick in and make the load go to network process.
The issue is that our code was using the context connection to do so.
If the fetch task is waiting for the worker activation, the context connection might not be set and the timeout will be a no-op.

To fix this, the fetch task will do as if its context is closed when the timeout fires.
The fetck task now has a weak pointer to the WebSWServerConnection and will use to terminate the service worker as done previously.

We no longer handle all ongoing fetch tasks of the ongoing service worker.
Each individual fetch task timeout provides the same level of protection.
The service worker will anyway get terminated which will race to finalize the service worker fetch tasks with each of their timeout.

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::createFetchTask):
(WebKit::WebSWServerConnection::fetchTaskTimedOut):

NetworkProcess/ServiceWorker/WebSWServerConnection.h:
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::fetchTaskTimedOut):

LayoutTests:

http/wpt/service-workers/service-worker-spinning-activate.https-expected.txt:
http/wpt/service-workers/service-worker-spinning-activate.https.html:

12:19 AM Changeset in webkit [255057] by youenn@apple.com

2 edits in trunk/Source/WebCore

Make sure DOMCacheStorage::retrieveCaches always calls its completionHandler
https://bugs.webkit.org/show_bug.cgi?id=206647

Reviewed by Chris Dumez.

Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches):
In case of context being stopped, make sure the completion handler is still called.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed