Timeline

Nov 22, 2020:

7:26 PM Changeset in webkit [270165] by Diego Pino Garcia

• 5 edits
  1 add in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Updated expectations and baselines after 270164.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/editing/selection/simple-line-layout-caret-is-gone-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Updated after r270103.
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Updated after r270103.

6:52 AM Changeset in webkit [270164] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

[LFC][Integration] Convert some remaining InlineBox access to use inline iterator
​https://bugs.webkit.org/show_bug.cgi?id=219244

Reviewed by Zalan Bujtas.

• dom/Position.cpp:

(WebCore::hasInlineRun):
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
(WebCore::hasInlineBoxWrapper): Deleted.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::getLeadingCorner const):

• rendering/RenderText.cpp:

(WebCore::RenderText::topOfFirstText const): Deleted.

• rendering/RenderText.h:

5:52 AM Changeset in webkit [270163] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Only process floats that fit the current line.
​https://bugs.webkit.org/show_bug.cgi?id=219239

Reviewed by Antti Koivisto.

Now that we process floats as soft wrap opportunities, all the intrusive logic can be removed.
Any float that we put on the line is considered intrusive and shrinks the available space.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineCandidate::InlineContent::operator() const):
(WebCore::Layout::LineCandidate::reset):
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::constraintsForLine):
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::handleFloatOrInlineContent):
(WebCore::Layout::LineBuilder::rebuildLine):
(WebCore::Layout::LineCandidate::InlineContent::continuousContent const): Deleted.
(WebCore::Layout::LineCandidate::FloatContent::list const): Deleted.
(WebCore::Layout::LineCandidate::FloatContent::intrusiveWidth const): Deleted.
(WebCore::Layout::LineCandidate::FloatContent::append): Deleted.
(WebCore::Layout::LineCandidate::FloatContent::reset): Deleted.
(WebCore::Layout::LineBuilder::nextContentForLine): Deleted.
(WebCore::Layout::LineBuilder::commitFloats): Deleted.
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

5:11 AM Changeset in webkit [270162] by Philippe Normand

• 4 edits in trunk/LayoutTests

Unreviewed GLib gardening

Skip WebSpeech-related tests on GTK and WPE because these ports
don't support WebSpeech yet.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

4:02 AM Changeset in webkit [270161] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GStreamer] Gardening webspeech related crash

Unreviewed test gardening.

• platform/glib/TestExpectations:

12:30 AM Changeset in webkit [270160] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Fix getIndexedParameter indexing crash
​https://bugs.webkit.org/show_bug.cgi?id=218601

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Like in setBoundIndexedTransformFeedbackBuffer ASSERT, the index should
always be smaller than size for indexing to be safe, so bail if the index
is greater than or equal to size.

• html/canvas/WebGLTransformFeedback.cpp:

(WebCore::WebGLTransformFeedback::getBoundIndexedTransformFeedbackBuffer):

LayoutTests:

Add testcase.

• fast/canvas/webgl/getIndexedParameter-crash-expected.txt: Added.
• fast/canvas/webgl/getIndexedParameter-crash.html: Added.