Timeline
Mar 7, 2021:
- 7:45 PM Changeset in webkit [274061] by
-
- 3 edits2 adds in trunk/LayoutTests
[GLIB] Gardening and updating baselines
Unreviewed test gardening.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash-expected.txt: Added.
- platform/wpe/TestExpectations:
- 6:02 PM Changeset in webkit [274060] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix -Wunused-parameter warning after r274033
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForModel const):
- 5:48 PM Changeset in webkit [274059] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix -Wreturn-type warning after r273891
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::trackMatchesKind):
- 2:45 PM Changeset in webkit [274058] by
-
- 6 edits in trunk
[iOS] maild hits a simulated crash when ENABLE(APP_HIGHLIGHTS) is defined
https://bugs.webkit.org/show_bug.cgi?id=222893
<rdar://problem/74230060>
Reviewed by Tim Horton.
Source/WebKit:
Fix the simulated crash by not initializing the shared callout bar and installing menu items for new app
highlight actions in the case where the web view is unparented. Additionally, avoid this work in the case where
the selection is not a range.
Test: AppHighlights.AvoidForcingCalloutBarInitialization
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView didMoveToWindow]):
Call
-setUpAppHighlightMenusIfNeededto ensure that we still add app highlight menu items in the case where
we avoided it previously, due to the web view being unparented. Note that if we're being unparented (i.e.
self.windowhas just becomenil), we will return early from-setUpAppHighlightMenusIfNeeded.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionChanged]):
(-[WKContentView setUpAppHighlightMenusIfNeeded]):
(-[WKContentView setUpAppHighlightMenus]): Deleted.
Rename
setUpAppHighlightMenustosetUpAppHighlightMenusIfNeeded, and declare it in the header so that we
can call into it from-didMoveToWindowabove.
Tools:
Add an API test to verify that we don't attempt to initialize the platform callout bar.
- TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:
- 12:32 PM Changeset in webkit [274057] by
-
- 6 edits in trunk
[GPU Process] Recording transparency layer should reset the alpha of lastDrawingState
https://bugs.webkit.org/show_bug.cgi?id=222855
Reviewed by Simon Fraser.
Source/WebCore:
After appending BeginTransparencyLayer item, the alpha of lastDrawingState
should be reset. So any subsequent setAlpha() should be accumulated even
if the new alpha equals to the last alpha which was set in lastDrawingState.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::beginTransparencyLayer):
(WebCore::DisplayList::Recorder::endTransparencyLayer):
- platform/graphics/displaylists/DisplayListRecorder.h:
(WebCore::DisplayList::Recorder::ContextState::cloneForTransparencyLayer const):
LayoutTests:
- gpu-process/TestExpectations:
- 12:26 PM Changeset in webkit [274056] by
-
- 2 edits in trunk/LayoutTests
[Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
https://bugs.webkit.org/show_bug.cgi?id=220018
Reviewed by Sam Weinig.
Mojave is no longer supported on ToT and this test has been passing reliably on the bots.
- platform/mac-wk2/TestExpectations:
- 12:16 PM Changeset in webkit [274055] by
-
- 8 edits in trunk
Correctly handle "auto" values when blending z-index
https://bugs.webkit.org/show_bug.cgi?id=222870
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Add an extra 72 PASS results. We now pass all the z-index interpolation tests.
Another test has new failures, but this is expected, this test behaves the same way
across Firefox and Chrome as well.
- web-platform-tests/css/css-transitions/animations/z-index-interpolation-expected.txt:
- web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt:
Source/WebCore:
Create a dedicated wrapper for z-index such that we can handle "auto" values
instead of just blending an int.
- animation/CSSPropertyAnimation.cpp:
(WebCore::ZIndexPropertyWrapper::ZIndexPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
LayoutTests:
Fix the test animations/stacking-context-unchanged-while-running.html which made the
wrong assumption about blending of z-index with auto values. We now make this test
expect an "auto" value and update the helper to know how to deal with "auto" values
for "z-index".
- animations/resources/animation-test-helpers.js:
(getPropertyValue):
(comparePropertyValue):
- animations/stacking-context-unchanged-while-running.html:
- 11:50 AM Changeset in webkit [274054] by
-
- 5 edits in trunk
Use counters for pending events
https://bugs.webkit.org/show_bug.cgi?id=218556
Patch by Rob Buis <rbuis@igalia.com> on 2021-03-07
Reviewed by Ryosuke Niwa.
Source/WebCore:
Use counters for pending events instead of flags since
it is allowed to schedule multiple events:
https://html.spec.whatwg.org/multipage/images.html#update-the-image-data
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::clearImageWithoutConsideringPendingLoadEvent):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
- loader/ImageLoader.h:
(WebCore::ImageLoader::hasPendingBeforeLoadEvent const):
(WebCore::ImageLoader::hasPendingActivity const):
LayoutTests:
The onerror can be called multiple times, after the first call
container will have no parent, so protect against that in
subsequent calls.
- fast/dom/modify-node-and-while-in-the-callback-too-crash.html:
- 10:16 AM Changeset in webkit [274053] by
-
- 6 edits in trunk/Source
Move new color(), lab() and lch() color functions behind runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=222869
Reviewed by Simon Fraser.
Source/WebCore:
Add checking for new experimental feature flag for the new CSS Color 4 color types.
As the flag is on by default, there is no change in behavior. This is just to allow
ports to disable the feature if they need to.
- css/parser/CSSParserContext.cpp:
(WebCore::operator==):
- css/parser/CSSParserContext.h:
(WebCore::CSSParserContextHash::hash):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseHWBParameters):
(WebCore::CSSPropertyParserHelpers::parseLabParameters):
(WebCore::CSSPropertyParserHelpers::parseLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypes):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForLabParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForXYZParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
Add experimental feature flag for the new CSS Color 4 color types.
- 9:41 AM Changeset in webkit [274052] by
-
- 4 edits in trunk/Tools
Transition Cocoa DumpRenderTree to allow any preference keys, not just hard coded supported ones
https://bugs.webkit.org/show_bug.cgi?id=222868
Reviewed by Simon Fraser.
This allows any preference key in a WebPreference*.yaml to be used for Cocoa WebKitLegacy
tests in the comment header command, just like WebKitTestRunner.
- DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
Update defaults to only the default values that don't match
defaults in WebPreference*.yaml files and experimental features
that are not supported in but still declare support in the file.
- DumpRenderTree/TestRunner.h:
Remove unimplemented function declaration.
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
(setDefaultsToConsistentValuesForTesting):
(prepareConsistentTestingEnvironment):
(resetWebPreferencesToConsistentValues): Deleted.
(webPreferenceFeatureValue): Deleted.
Replace most explicit reseting with the combination of _resetForTesting, automatic
enabling experimental features, and use of _set<type>PreferenceForTestingWithValue
from TestOptions.
Mar 6, 2021:
- 9:35 PM Changeset in webkit [274051] by
-
- 2 edits in trunk/Source/WebKit
[WebAuthn] Expand WebAuthn Process's sandbox profile on iOS
https://bugs.webkit.org/show_bug.cgi?id=222858
<rdar://problem/74772012>
Reviewed by Brent Fulgham.
Allows WebAuthn process to use AAA again.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:
- 9:11 PM Changeset in webkit [274050] by
-
- 5 edits2 adds in trunk
Only positive integers are allowed as values of orphans and widows
https://bugs.webkit.org/show_bug.cgi?id=222875
<rdar://problem/72996948>
Reviewed by Ryosuke Niwa.
Source/WebCore:
See https://drafts.csswg.org/css-break-3/#widows-orphans
Test: fast/multicol/negative-widow-value-crash.html
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::widows const):
(WebCore::RenderStyle::orphans const):
(WebCore::RenderStyle::setWidows):
(WebCore::RenderStyle::setOrphans):
(WebCore::RenderStyle::initialWidows):
(WebCore::RenderStyle::initialOrphans):
- rendering/style/StyleRareInheritedData.h:
LayoutTests:
- fast/multicol/negative-widow-value-crash-expected.txt: Added.
- fast/multicol/negative-widow-value-crash.html: Added.
- 9:04 PM Changeset in webkit [274049] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r274033) [GLIB] Bots exiting early after lots of failures due to render tree differences
https://bugs.webkit.org/show_bug.cgi?id=222878
Reviewed by Wenson Hsieh.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForModel const):
Invert the logic (to the sane direction, I have no idea why I typed it this way),
so that we don't require compositing for everything if ENABLE(MODEL_ELEMENT) is false.
- 6:37 PM Changeset in webkit [274048] by
-
- 8 edits in trunk/Source/WebCore
[LFC][IFC] Provide a better estimate on the number of inline level boxes per line for LineBox.
https://bugs.webkit.org/show_bug.cgi?id=222821
Reviewed by Antti Koivisto.
Let's counting the number of inline level box on the line. It is a much better estimate than the number of runs even
if it misses some inline boxes when they span over multiple lines (the fail rate is ~1% on nytimes.com).
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::build):
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
(WebCore::Layout::Line::appendLineBreak):
- layout/inlineformatting/InlineLine.h:
(WebCore::Layout::Line::inlineLevelBoxCount const):
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::LineBox):
- layout/inlineformatting/InlineLineBox.h:
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
- layout/inlineformatting/InlineLineBuilder.h:
- 6:28 PM Changeset in webkit [274047] by
-
- 2 edits in trunk/Websites/perf.webkit.org
[perf dashboard] Modernize TimeSeries and TimeSeriesView
https://bugs.webkit.org/show_bug.cgi?id=222872
Reviewed by Dewei Zhu.
Declare instance fields in class declarations, use const/let instead of var, and use generators
for forward and backward iterations instead of manually implementing the iterator protocol.
This patch also splits FilteredTimeSeriesView out of TimeSeriesView.
- public/v3/models/time-series.js:
(TimeSeries): Moved the declaration of _data instance field to the class declaration.
(TimeSeries.prototype.constructor): Deleted.
(TimeSeries.prototype.extendToFuture):
(TimeSeries.prototype.valuesBetweenRange):
(TimeSeries.prototype.findById):
(TimeSeries.prototype.findPointAfterTime):
(TimeSeriesView): Declared the instance fields in the class declaration.
(TimeSeriesView.prototype.constructor): Removed filteredData from the argument since it's split
out to FilteredTimeSeriesView now.
(TimeSeriesView.prototype.get _data): Added. An abstraction needed for FilteredTimeSeriesView.
(TimeSeriesView.prototype._findIndexForPoint): Ditto. Moved out of the constructor.
(TimeSeriesView.prototype.filter): Return a FilteredTimeSeriesView.
(TimeSeriesView.prototype.viewTimeRange): Use _subRange to return either TimeSeriesView or
FilteredTimeSeriesView which ever is needed.
(TimeSeriesView.prototype._subRange): An abstraction needed for FilteredTimeSeriesView.
(TimeSeriesView.prototype.Symbol.iterator): Made this a generator instead of implementing
the iterator protocol directly.
(TimeSeriesView.prototype._reverse): Ditto.
(FilteredTimeSeriesView): Added.
(FilteredTimeSeriesView.prototype.constructor): Added. Assert that afterEndingIndex is less than
the length of the filtered data. This assertion was missing in TimeSeries prior to this patch
when filteredData is specified.
(FilteredTimeSeriesView.prototype.get _data): Added.
(FilteredTimeSeriesView.prototype._subRange): Added. Instantiate FilteredTimeSeriesView with
the same filtered data.
(FilteredTimeSeriesView.prototype._findIndexForPoint): Moved from TimeSeriesView's constructor.
(FilteredTimeSeriesView.prototype._buildPointIndexMap): Moved from TimeSeriesView.
- 6:25 PM Changeset in webkit [274046] by
-
- 3 edits in trunk/Websites/perf.webkit.org
[perf dashboard] Some browser tests are flaky or failing
https://bugs.webkit.org/show_bug.cgi?id=222874
Reviewed by Dewei Zhu.
There were two tests in TimeSeriesChart tests that were intermittently failing due to the test
not reliably waiting for the iframe's resize to take effect and not waiting for the time series'
fetching logic to run 'til completion before waiting for canvas charts to be re-drawn. Fixing
these by adding code to wait for these conditons.
All browser tests for markup-component.js was broken in r274036 as
requirefunction is not
available in browsers. Added a workaround in BrowsingContext to add a make assert.ok function
using expect(~).to.be.true().
- browser-tests/index.html:
(BrowsingContext.prototype.constructor):
(waitForElementResize): Added.
- browser-tests/time-series-chart-tests.js: Fixed bugs in the tests.
- 5:02 PM Changeset in webkit [274045] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r274041.
https://bugs.webkit.org/show_bug.cgi?id=222873
Broke the build instead of fixing it
Reverted changeset:
"Fix the build"
https://trac.webkit.org/changeset/274041
- 4:27 PM Changeset in webkit [274044] by
-
- 2 edits in trunk/Websites/perf.webkit.org
[perf dashboard] Modernize DataModelObject and LabeledObject
https://bugs.webkit.org/show_bug.cgi?id=222871
Reviewed by Dewei Zhu.
Use const/let instead of var, async/await instead of Promise.then, and Map instead
of a regular object for a dictionary.
Also define instance fields in the class declaration instead of simply adding them
in the class constructors, and set the default parameter values instead of relying
on the unspecified argument being undefined.
- public/v3/models/data-model.js:
(DataModelObject.ensureSingleton):
(DataModelObject.namedStaticMap):
(DataModelObject.ensureNamedStaticMap):
(DataModelObject.findById):
(DataModelObject.listForStaticMap):
(DataModelObject.async cachedFetch):
(DataModelObject):
(LabeledObject.sortByName):
(DataModelObject.cachedFetch): Deleted.
- 4:25 PM Changeset in webkit [274043] by
-
- 4 edits in trunk/Websites/perf.webkit.org
[perf dashboard] Modernize MeasurementSet
https://bugs.webkit.org/show_bug.cgi?id=222857
Reviewed by Dewei Zhu.
Modernized MeasurementSet by using new instance field syntax, let/const instead of var,
async/await instead of then/catch, and Map instead of an object as a dictionary.
- public/v3/models/measurement-set.js:
(Array.prototype.includes): Deleted this polyfill which was needed for an old node.js.
(MeasurementSet): Moved the initialization of instance variables here. Also use Map
for this._allFetches instead of using a regular object as a dictionary.
(MeasurementSet.findSet): Use Map for MeasurementSet mapping.
(MeasurementSet.prototype.findClusters): Use const and let instead of var.
(MeasurementSet.prototype.async fetchBetween): Use async & await instead of Promise.then.
(MeasurementSet.prototype._ensureClusterPromise): Use let/const instead of var.
(MeasurementSet.prototype._urlForCache): Renamed from _constructUrl and removed the argument
for useCache since this function is now only used for feteching JSON caches.
(MeasurementSet.async _fetchPrimaryCluster): Use async/await and let/const. Consolidated
the API call to re-generate new JSON files and inlined API path here.
(MeasurementSet.async _fetchSecondaryCluster): Use async/await.
(MeasurementSet._addFetchedCluster): Use let/const instead of var.
(MeasurementSet.async fetchSegmentation): Use async/await and let/const.
(MeasurementSet.async _cachedClusterSegmentation): Ditto.
(MeasurementSet.prototype.async _invokeSegmentationAlgorithm): Ditto.
- unit-tests/measurement-set-tests.js:
(beforeEach): Updated the logic to reset measurement sets since the static variable was
renamed in MeasurementSet.findSet above.
- unit-tests/resources/mock-v3-models.js:
(MockModels.inject): Ditto.
- 11:09 AM Changeset in webkit [274042] by
-
- 3 edits in trunk/Tools
webkit-patch won't parse rdar://nnnnnnnn URLs in ChangeLogs
<https://webkit.org/b/222863>
Reviewed by Simon Fraser.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry):
- Update regex.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_fuzzy_radar_matchnone):
- Move test cases that used to fail into another test.
(test_fuzzy_radar_match_format_without_context): Add.
- Rename from test_fuzzy_radar_match_format_1().
(test_fuzzy_radar_match_format_1):
- Rename to test_fuzzy_radar_match_format_without_context().
(test_fuzzy_radar_match_format_2):
- Combine with test_fuzzy_radar_match_format_without_context().
(test_fuzzy_radar_match_format_with_context): Add.
- Rename from test_fuzzy_radar_match_format_3().
(test_fuzzy_radar_match_format_3):
- Rename to test_fuzzy_radar_match_format_with_context().
- 11:03 AM Changeset in webkit [274041] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the build
Unreviewed.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- 10:45 AM Changeset in webkit [274040] by
-
- 5 edits in trunk
Simplify DumpRenderTree WebPreferences reset
https://bugs.webkit.org/show_bug.cgi?id=218024
<rdar://problem/70764568>
Reviewed by Simon Fraser.
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(WebPreferencesPrivate::WebPreferencesPrivate):
(-[WebPreferences encodeWithCoder:]):
(-[WebPreferences _valueForKey:]):
(-[WebPreferences _setStringValue:forKey:]):
(-[WebPreferences _setStringArrayValueForKey:forKey:]):
(-[WebPreferences _setIntegerValue:forKey:]):
(-[WebPreferences _setUnsignedIntValue:forKey:]):
(-[WebPreferences _setFloatValue:forKey:]):
(-[WebPreferences _setBoolValue:forKey:]):
(-[WebPreferences _setLongLongValue:forKey:]):
(-[WebPreferences _setUnsignedLongLongValue:forKey:]):
(-[WebPreferences _startBatchingUpdates]):
(-[WebPreferences _stopBatchingUpdates]):
(-[WebPreferences _batchUpdatePreferencesInBlock:]):
(-[WebPreferences _resetForTesting]):
(-[WebPreferences _postPreferencesChangedNotification]):
(-[WebPreferences _postPreferencesChangedAPINotification]):
(-[WebPreferences _invalidateCachedPreferences]):
(WebPreferencesPrivate::~WebPreferencesPrivate): Deleted.
- WebView/WebPreferencesPrivate.h:
Add new helpers for testing to reset and batch updates.
Tools:
Use new _batchUpdatePreferencesInBlock and _resetForTesting to simplify and
improve the performance of resetting preferences.
_batchUpdatePreferencesInBlock makes it so we only trigger the recalculation
of WebCore::Settings once per test, rather than linearly with the number of
settings that we reset.
_resetForTesting will allow us to remove explicit resetting of preferences
that use the existing default value (though this change does not utilize
that yet, to limit the number of changes in this commit).
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
(setWebPreferencesForTestOptions):
(resetWebViewToConsistentState):
- 10:21 AM Changeset in webkit [274039] by
-
- 3 edits2 adds in trunk
[RenderTreeBuilder] Invalidate beforeChild when parent changes to RubyBase
https://bugs.webkit.org/show_bug.cgi?id=222862
<rdar://problem/73659871>
Reviewed by Antti Koivisto.
Source/WebCore:
The beforeChild value becomes invalid when the ruby subtree requires a ruby base and the child is going to
be attached under this newly constrcuted ruby base (the child and the beforeChild will not end up in the same subtree).
Test: fast/ruby/crash-when-attaching-to-base.html
- rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::attach):
LayoutTests:
- fast/ruby/crash-when-attaching-to-base-expected.txt: Added.
- fast/ruby/crash-when-attaching-to-base.html: Added.
- 8:28 AM Changeset in webkit [274038] by
-
- 38 edits in trunk
Improve blending of Length and other Length-related types
https://bugs.webkit.org/show_bug.cgi?id=222816
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add an extra 153 PASS results. We now pass all the column-gap, row-gap, border-image-slice,
max-height and max-width interpolation tests.
- web-platform-tests/css/css-align/animation/column-gap-composition-expected.txt:
- web-platform-tests/css/css-align/animation/column-gap-interpolation-expected.txt:
- web-platform-tests/css/css-align/animation/row-gap-composition-expected.txt:
- web-platform-tests/css/css-align/animation/row-gap-interpolation-expected.txt:
- web-platform-tests/css/css-backgrounds/animations/background-position-interpolation-expected.txt:
- web-platform-tests/css/css-backgrounds/animations/background-position-origin-interpolation-expected.txt:
- web-platform-tests/css/css-backgrounds/animations/background-size-interpolation-expected.txt:
- web-platform-tests/css/css-backgrounds/animations/border-image-slice-interpolation-expected.txt:
- web-platform-tests/css/css-backgrounds/animations/border-radius-interpolation-expected.txt:
- web-platform-tests/css/css-box/animation/margin-bottom-composition-expected.txt:
- web-platform-tests/css/css-box/animation/margin-left-composition-expected.txt:
- web-platform-tests/css/css-box/animation/margin-right-composition-expected.txt:
- web-platform-tests/css/css-box/animation/margin-top-composition-expected.txt:
- web-platform-tests/css/css-box/animation/padding-bottom-composition-expected.txt:
- web-platform-tests/css/css-box/animation/padding-left-composition-expected.txt:
- web-platform-tests/css/css-box/animation/padding-right-composition-expected.txt:
- web-platform-tests/css/css-box/animation/padding-top-composition-expected.txt:
- web-platform-tests/css/css-flexbox/animation/flex-basis-composition-expected.txt:
- web-platform-tests/css/css-position/animations/bottom-composition-expected.txt:
- web-platform-tests/css/css-position/animations/left-composition-expected.txt:
- web-platform-tests/css/css-position/animations/right-composition-expected.txt:
- web-platform-tests/css/css-position/animations/top-composition-expected.txt:
- web-platform-tests/css/css-shapes/animation/shape-margin-composition-expected.txt:
- web-platform-tests/css/css-sizing/animation/max-height-composition-expected.txt:
- web-platform-tests/css/css-sizing/animation/max-height-interpolation-expected.txt:
- web-platform-tests/css/css-sizing/animation/max-width-composition-expected.txt:
- web-platform-tests/css/css-sizing/animation/max-width-interpolation-expected.txt:
- web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
We improve the blending behavior of a number of CSS properties that are represented as Length
or a type built upon Length, such as LengthSize, LengthBox or GapLength.
We remove the NonNegativeLengthPropertyWrapper class and instead allow LengthPropertyWrapper to
be passed some flags: one that indicates whether the CSS property supports <length-percentage>
values and one that indicates whether negative values are supported. We use those flags to
several CSS properties that are using LengthPropertyWrapper to ensure they have the correct
blending behavior.
We also take the code from the canInterpolateBetweenLengths lambda in LengthBoxPropertyWrapper's
canInterpolate override and refactor it into the canInterpolateLengths static method so that we
may use it across LengthPropertyWrapper and LengthVariantPropertyWrapper.
As for LengthVariantPropertyWrapper, we also update its canInterpolate() override to call into
type-specific static canInterpolateLengthVariants() methods which are implemented for LengthSize
and GapLength.
Finally, we update the blend() method for Length to return the from/to values as-is when progress
is 0 or 1, respectively.
- animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::canInterpolateLengths):
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::canInterpolateLengthVariants):
(WebCore::LengthVariantPropertyWrapper::LengthVariantPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::NonNegativeLengthPropertyWrapper::NonNegativeLengthPropertyWrapper): Deleted.
- platform/Length.cpp:
(WebCore::blend):
LayoutTests:
Adjust expectations of a couple of WPT tests with platform-specific results.
We also add console logging for a non-WPT test, transitions/transition-to-from-undefined.html, which tests
transitions between properties that cannot be interpolated and thus don't yield a transition.
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-box/animation/padding-bottom-composition-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-box/animation/padding-top-composition-expected.txt:
- transitions/transition-to-from-undefined-expected.txt:
- 6:42 AM Changeset in webkit [274037] by
-
- 18 edits3 adds4 deletes in trunk
BooleanConstructor should be inlined in DFG / FTL
https://bugs.webkit.org/show_bug.cgi?id=220322
Reviewed by Yusuke Suzuki.
JSTests:
Reorganize tests so the every UseKind / needsTypeCheck / invert combination is covered.
- microbenchmarks/array-filter-boolean-constructor.js: Added.
- stress/dfg-branch.js: Added.
- stress/dfg-to-boolean.js: Added.
- stress/logical-not-masquerades-as-undefined.js: Removed.
- stress/logical-not-masquerades.js: Removed.
- stress/logical-not.js: Removed.
- stress/value-to-boolean.js: Removed.
Source/JavaScriptCore:
array.filter(Boolean)is a rather popular idiom for removing falsy items from an array.
Also,Boolean(X)is sometimes used for explicit type casting.
This patch introduces ToBoolean DFG node and reorganizes compileLogicalNot(node) into
compileToBoolean(node, bool invert), leveraging already existing emitConvertValueToBoolean().
This approach is better than emitting LogicalNot<KnownBooleanUse>(LogicalNot(X)) as it results
in cleaner DFG node tree and is ~7% faster w/o FTL. Also, it enables adding a op_to_boolean
bytecode that will be generated for very common!!Xpatterns, reducing instruction count.
Just as LogicalNot, BooleanConstructor should handle masquerader objects, because Annex B
patches ToBoolean abstract op [1], preventing us from emitting simpler code.
This change advances provided microbenchmark by 110%, and is neutral for other ToBoolean cases.
[1]: https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot-to-boolean
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGMayExit.cpp:
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToBooleanString):
(JSC::DFG::SpeculativeJIT::compileToBooleanStringOrOther):
(JSC::DFG::SpeculativeJIT::compileStringZeroLength): Deleted.
(JSC::DFG::SpeculativeJIT::compileLogicalNotStringOrOther): Deleted.
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::compileToBoolean):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot): Deleted.
(JSC::DFG::SpeculativeJIT::compileLogicalNot): Deleted.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::compileToBoolean):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot): Deleted.
(JSC::DFG::SpeculativeJIT::compileLogicalNot): Deleted.
- dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToBoolean):
- 6:31 AM Changeset in webkit [274036] by
-
- 32 edits1 add in trunk/Websites/perf.webkit.org
Make server test run with new node version
https://bugs.webkit.org/show_bug.cgi?id=222463
Change assert.equal to assert.strictEqual since node deprecated this API
Add a new function console.assert to make sure it will throw an error
Reviewed by Ryosuke Niwa.
- public/v3/models/repository.js:
(Repository.sortByNamePreferringOnesWithURL):
(Repository):
- server-tests/admin-platforms-tests.js:
- server-tests/admin-reprocess-report-tests.js:
- server-tests/api-build-requests-tests.js:
(return.TestServer.remoteAPI.getJSON.string_appeared_here.then):
- server-tests/api-commits-tests.js:
(assertCommitIsSameAsOneSubmitted):
(return.TestServer.remoteAPI.getJSON.string_appeared_here.then):
- server-tests/api-manifest-tests.js:
(return.TestServer.remoteAPI.getJSON.string_appeared_here.then):
- server-tests/api-measurement-set-tests.js:
- server-tests/api-report-commits-tests.js:
(emptyReport.then):
(async initialReportCommits):
(async setUpTestsWithExpectedStatus):
(async testWithExpectedFailure):
- server-tests/api-report-tests.js:
(emptyReport.then):
- server-tests/api-test-groups.js:
- server-tests/api-update-triggerable-tests.js:
(update.then):
(then.response.db.selectAll.string_appeared_here.then):
(then.db.selectAll.string_appeared_here.then):
(then.Manifest.fetch.then):
- server-tests/api-upload-root-tests.js:
- server-tests/api-uploaded-file-tests.js:
(return.TestServer.remoteAPI.getJSON.string_appeared_here.then):
- server-tests/privileged-api-add-build-requests-tests.js:
(async createAnalysisTask):
(const.commitSet.of.updatedGroups.0.requestedCommitSets):
- server-tests/privileged-api-create-analysis-task-tests.js:
- server-tests/privileged-api-create-test-group-tests.js:
(createAnalysisTask):
(return.createAnalysisTask.string_appeared_here.then):
(return.addTriggerableAndCreateTask.string_appeared_here.then):
(string_appeared_here.then):
- server-tests/privileged-api-upate-run-status.js:
- server-tests/privileged-api-update-test-group-tests.js:
(async createAnalysisTask):
- server-tests/privileged-api-upload-file-tests.js:
(TestServer.testConfig.uploadFileLimitInMB.1.then):
- server-tests/resources/common-operations.js:
(async assertThrows):
- server-tests/resources/temporary-file.js:
(TemporaryFile.makeTemporaryFileOfSizeInMB):
- server-tests/tools-buildbot-triggerable-tests.js:
(assertRequestAndResolve):
(then.refetchManifest.then):
(getBuilderNameToIDMapPromise.then):
- server-tests/tools-os-build-fetcher-tests.js:
- server-tests/tools-sync-buildbot-integration-tests.js:
(assertAndResolveRequest):
- tools/js/assert-override.js: Added.
(makeConsoleAssertThrow):
- tools/js/buildbot-syncer.js:
(BuildbotBuildEntry.prototype.initialize):
(BuildbotBuildEntry.prototype.buildRequestStatusIfUpdateIsNeeded):
(BuildbotBuildEntry):
(BuildbotSyncer.prototype.scheduleRequest):
(BuildbotSyncer._loadConfig):
(BuildbotSyncer._parseRepositoryGroup):
(BuildbotSyncer._validateAndMergeConfig):
(BuildbotSyncer):
- tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype._validateRequests):
- tools/js/markup-component.js:
(const.MarkupDocument.new.MarkupDocument.prototype._idForClone):
(const.MarkupDocument.new.MarkupDocument.prototype.markup):
- tools/js/os-build-fetcher.js:
(prototype._addOwnedCommitsForBuild):
- tools/js/remote.js:
(NodeRemoteAPI.prototype.configure):
- tools/js/v3-models.js:
- unit-tests/commit-set-tests.js:
- 4:59 AM Changeset in webkit [274035] by
-
- 3 edits2 adds in trunk
[RenderTreeBuilder] Readjust the first child when it is the multicolumn container
https://bugs.webkit.org/show_bug.cgi?id=222851
<rdar://problem/73392642>
Reviewed by Simon Fraser.
Source/WebCore:
When a newly constructed renderer is supposed to be first child of its soon-to-be parent but
the parent establishes a multicolumn context (so its first child is a RenderMultiColumnFlow) this
renderer should be attached under the column container instead.
Test: fast/multicol/readjust-first-child-on-attach.html
- rendering/updating/RenderTreeBuilderBlockFlow.cpp:
(WebCore::RenderTreeBuilder::BlockFlow::attach):
LayoutTests:
- fast/multicol/readjust-first-child-on-attach-expected.txt: Added.
- fast/multicol/readjust-first-child-on-attach.html: Added.
- 4:53 AM Changeset in webkit [274034] by
-
- 6 edits in trunk/Source
dlopen_preflight is failing (temporarily) but obsolete
https://bugs.webkit.org/show_bug.cgi?id=222829
Reviewed by Jer Noble.
I hit a bug where dlopen_preflight was failing in a particular build.
That is now fixed, but as I was discussing it with the dyld team
they said we should stop using it. The rationale was that it only
made sense during the PowerPC to Intel transition, and it is as
expensive as dlopen now.
Source/WebCore:
- platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::isAvailable const): Remove the preflight opening
of the AVFoundation framework.
- platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:
(WebCore::AVStreamDataParserMIMETypeCache::isAvailable const):
Source/WTF:
- wtf/PlatformUse.h: No need for preflight linking code.
- wtf/cocoa/SoftLinking.h:
- 3:13 AM Changeset in webkit [274033] by
-
- 43 edits1 copy5 adds in trunk
<model> should create a model-owning compositing layer
https://bugs.webkit.org/show_bug.cgi?id=222798
Reviewed by Simon Fraser.
Source/JavaScriptCore:
- inspector/protocol/LayerTree.json:
Add a compositing reason for <model>.
Source/WebCore:
Test: model-element/model-element-graphics-layers.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setContentsToModel):
- platform/graphics/Model.cpp: Added.
(WebCore::Model::create):
(WebCore::Model::Model):
(WebCore::operator<<):
- platform/graphics/Model.h: Added.
(WebCore::Model::encode const):
(WebCore::Model::decode):
Add Model, a wrapper for the model.
For now, it just wraps a SharedBuffer.
In the future, it may contain other things, like file paths, identifiers, etc.
- Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::model const):
- Modules/model-element/HTMLModelElement.h:
HTMLModelElement can now vend a Model instead of just a SharedBuffer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayer):
(WebCore::GraphicsLayerCA::setContentsToModel):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
Allow a GraphicsLayer to be given a Model as contents (as we do for e.g. Image and other things).
For simplicity's sake, and because anything more is unnecessary, just re-create
the ModelLayer when the model changes.
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentChanged):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::contentChanged):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::logReasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForModel const):
- rendering/RenderLayerCompositor.h:
- rendering/RenderModel.cpp:
(WebCore::RenderModel::requiresLayer const):
(WebCore::RenderModel::updateFromElement):
(WebCore::RenderModel::update):
- rendering/RenderModel.h:
Require compositing for <model>, and add a custom layer type.
- inspector/agents/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
Add a compositing reason for <model>.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WI.LayerTreeDetailsSidebarPanel.prototype._populateListOfCompositingReasons):
(WI.LayerTreeDetailsSidebarPanel):
- UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype._updateReasonsList):
(WI.Layers3DContentView):
Add a compositing reason for <model>.
Source/WebKit:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::description const):
- SourcesCocoa.txt:
- UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
- WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::create):
(WebKit::PlatformCALayerRemote::populateCreationProperties):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::populateCreationProperties):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.h: Added.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.mm: Added.
(WebKit::PlatformCALayerRemoteModelHosting::create):
(WebKit::PlatformCALayerRemoteModelHosting::PlatformCALayerRemoteModelHosting):
(WebKit::PlatformCALayerRemoteModelHosting::clone const):
(WebKit::PlatformCALayerRemoteModelHosting::populateCreationProperties):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerDidEnterContext):
Create a new PlatformCALayerRemote subclass that knows about Model, and
passes its model along in the layer creation properties.
For now, the special model layer type will just make a plain layer.
Future patches will replace it with model-specific rendering.
LayoutTests:
- model-element/model-element-graphics-layers-expected.txt: Added.
- model-element/model-element-graphics-layers.html: Added.
- model-element/model-element-renderer-expected.txt:
- model-element/model-element-renderer-no-source-expected.txt:
Add a test ensuring that we make a compositing layer via layer dump, and update
existing tests that also happen to reveal this via render tree dump as well.
Mar 5, 2021:
- 11:52 PM Changeset in webkit [274032] by
-
- 2 edits in trunk/LayoutTests
[GPU Process] Tests under imported/blink/fast/canvas are now fixed by r273956
https://bugs.webkit.org/show_bug.cgi?id=222341
Reviewed by Said Abou-Hallawa.
- gpu-process/TestExpectations:
- 10:33 PM Changeset in webkit [274031] by
-
- 8 edits in trunk/Source
[iOS] Implement additional accessibility support for image overlays
https://bugs.webkit.org/show_bug.cgi?id=222811
<rdar://problem/73203775>
Reviewed by Tim Horton and Devin Rousso.
Source/WebCore:
Add a helper method to check whether a given
Nodeis a text node inside an image overlay. See WebKit ChangeLog
for more detail.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::isImageOverlayText):
- html/HTMLElement.h:
Source/WebKit:
Adds additional support for accessible image extraction. See below for more details.
- UIProcess/ios/WKContentViewInteraction.h:
(WebKit::SuppressInteractionToken::SuppressInteractionToken): Deleted.
(WebKit::SuppressInteractionToken::~SuppressInteractionToken): Deleted.
Remove
SuppressInteractionToken, along with its only use as a member onWKContentView. This was used to
temporarily suppress the image extraction interaction when editing, but is now no longer necessary, since we're
removing all dependence on this interaction object.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setIsEditable:]):
Remove
_suppressImageExtractionToken.
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
There's no need to cancel the regular text interaction in favor of the image extraction interaction after this
patch, since the former will be used for both. However, we do need to temporarily suppress regular text
interaction while image extraction is still pending, to avoid prematurely selecting the entire image element.
To do this, we keep track of the element pending image extraction (
_elementPendingImageExtraction), and avoid
allowing text interactions to begin if we're over this exact element.
(-[WKContentView _singleTapIdentified:]):
We don't need to explicitly cancel the image extraction interaction on single tap anymore; this behavior will
automatically fall out of using default text interactions for image extraction.
(-[WKContentView _didStartProvisionalLoadForMainFrame]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
Remove explicit image extraction cancellation here as well, and instead bail from the drag only if we're about
to proceed with the image extraction gesture (which is indicated by the argument to the completion handler).
See comment below.
(-[WKContentView _doAfterPendingImageExtraction:]):
Add an enum flag to the completion handler block here, to determine whether or not we'll want to immediately
proceed with image extraction. The value of this flag will be determined by the hit-test after updating the page
with image extraction results inWebPage::updateWithImageExtractionResult.
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageExtraction:]):
(-[WKContentView _contextMenuInteraction:configurationForMenuAtLocation:completion:]):
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageExtraction]): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateWithImageExtractionResult):
Remove a FIXME and implement hit-testing logic, to return whether or not the given location hit-tests to the
image overlay we've just injected.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setFocusedFrameBeforeSelectingTextAtLocation):
(WebKit::elementPositionInformation):
Avoid extracting image data for a position information request, if the hit-tested node is actually a text node
in an image overlay, instead of an image.
(WebKit::selectionPositionInformation):
(WebKit::WebPage::positionInformation):
Allow text interactions to begin in user-agent shadow roots. This matches behavior on macOS, and was
(presumably) initially disallowed on iOS to avoid activating the editable text interaction
(UIWKTextInteractionAssistant), as opposed to block text selection interactions, when long pressing text
inside textareas and text fields. However, since we only use the normal text interaction assistant now for both
non-editable and editable text, this distinction no longer matters.
- 7:28 PM Changeset in webkit [274030] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, suppress warning as it is done in DFGOperations.cpp
We are intentionally using this feature to reduce size of JIT memory.
- dfg/DFGOSRExit.cpp:
- 7:28 PM Changeset in webkit [274029] by
-
- 3 edits in trunk/Source/WebCore
Inline isDisabledFormControl() in isDisabledOrReadOnly() by making it final rather than duplicating code
https://bugs.webkit.org/show_bug.cgi?id=222783
Reviewed by Simon Fraser.
Inline isDisabledFormControl into isDisabledOrReadOnly by making it final and defining in the header file
instead of manually duplicating the code as done in r272299.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isDisabledFormControl const): Deleted.
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isDisabledFormControl const): Moved the definition here.
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly const): Call isDisabledFormControl instead of
duplicating the code as done in r272299.
- 7:14 PM Changeset in webkit [274028] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] Replaced and non-replaced inline level box should not be called inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=222817
Reviewed by Darin Adler.
Not every inline level box is an inline box (but every inline box is an inline level box).
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
(WebCore::Layout::Line::appendReplacedInlineLevelBox):
(WebCore::Layout::Line::appendNonReplacedInlineBox): Deleted.
(WebCore::Layout::Line::appendReplacedInlineBox): Deleted.
- layout/inlineformatting/InlineLine.h:
- 6:56 PM Changeset in webkit [274027] by
-
- 3 edits in trunk/Source/WebKit
[IPC Hardening] Protect against bad navigationID in WebPageProxy::didDestroyNavigation()
https://bugs.webkit.org/show_bug.cgi?id=222842
<rdar://problem/75119560>
Reviewed by Darin Adler.
- UIProcess/WebNavigationState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didDestroyNavigation):
- 6:55 PM Changeset in webkit [274026] by
-
- 2 edits in trunk/Source/WebKit
Potential crash under NotificationPermissionRequestManagerProxy::invalidateRequests()
https://bugs.webkit.org/show_bug.cgi?id=222841
Reviewed by Darin Adler.
Make sure we copy the HashMap before iterating over it and calling deny() on the requests.
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
- 6:26 PM Changeset in webkit [274025] by
-
- 2 edits in trunk/Source/WebCore
CanvasRenderingContext2DBase::canDrawTextWithParams() needs to resolve styles before using the drawingContext
https://bugs.webkit.org/show_bug.cgi?id=221257
<rdar://problem/73878095>
Reviewed by Ryosuke Niwa.
Simply call fontProxy() (which internally resolves styles) before calling drawingContext().
Test: fast/text/canvas-synchronous-events.html
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::canDrawTextWithParams):
- 6:25 PM Changeset in webkit [274024] by
-
- 10 edits in trunk/Source/JavaScriptCore
[JSC] Simplify OSRExit side state materialization
https://bugs.webkit.org/show_bug.cgi?id=222648
Reviewed by Keith Miller.
Currently, JIT probe with lambda function has memory leaking issue. So we must not use it in production code.
To avoid the future use, we rename probe to probeDebug.
And to avoid using probe function in OSR exit side state materialization, we simplify the OSRExit side state materialization code,
and making it just a function call. To achieve that, we materialize exit values into scratch buffer before restoring them to
the stack. This aligns DFG to what FTL is doing. And DFG and FTL can use the same materialization operation function.
Caio helped me to fix 32bit issue in DFG.
- assembler/MacroAssembler.cpp:
(JSC::MacroAssembler::probeDebug):
(JSC::MacroAssembler::probe): Deleted.
- assembler/MacroAssembler.h:
- assembler/testmasm.cpp:
(JSC::testClearBits64WithMask):
(JSC::testClearBits64WithMaskTernary):
(JSC::testShiftAndAdd):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::testProbeModifiesStackValues):
- b3/air/testair.cpp:
- dfg/DFGOSRExit.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
(JSC::DFG::OSRExit::compileExit):
- dfg/DFGOSRExit.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- 6:07 PM Changeset in webkit [274023] by
-
- 2 edits in trunk/Source/WebCore/PAL
[Win] Fix compile error
https://bugs.webkit.org/show_bug.cgi?id=222802
<rdar://problem/75052309>
Reviewed by Dean Jackson.
Declare CTFontTransformOptions if associated header file has not been included.
- pal/spi/win/CoreTextSPIWin.h:
- 5:23 PM Changeset in webkit [274022] by
-
- 10 edits in trunk/Source
Update ApplicationCacheStorage::originsWithCache() to return a HashSet<SecurityOriginData> instead of a Vector<Ref<SecurityOrigin>>
https://bugs.webkit.org/show_bug.cgi?id=222828
Reviewed by Darin Adler.
Update ApplicationCacheStorage::originsWithCache() to return a HashSet<SecurityOriginData> instead of a Vector<Ref<SecurityOrigin>>.
Using a HashSet makes sure we do not return duplicates (which do occur as per ApplicationCacheStorage implementation) and makes typing
more consistent with other similar storage functions. Using SecurityOriginData is more lightweight and sufficient for our use cases.
It also takes care of a FIXME comment in WebsiteDataStore::fetchDataAndApply about switching to SecurityOriginData.
Source/WebCore:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::calculateUsageForOrigin):
(WebCore::ApplicationCacheStorage::originsWithCache):
(WebCore::ApplicationCacheStorage::deleteCacheForOrigin):
(WebCore::ApplicationCacheStorage::diskUsageForOrigin):
- loader/appcache/ApplicationCacheStorage.h:
Source/WebKit:
This patch also updates WebsiteDataStore::fetchDataAndApply() to crossThreadCopy() the securityOriginData before sending them from
the data store queue to the main thread. The previous code as sending SecurityOrigins and WebsiteData to the main thread without
any isolated copy, which was fragile and would not have been thread-safe if ApplicationCacheStorage::originsWithCache() had cached
the origins it returned for example.
Also update WebsiteDataStore::removeData() to make sure we crossThreadCopy() the origins before sending them from the main thread
to the data store queue. This code did not look thread-safe.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageClearApplicationCacheForOrigin):
(WKBundlePageGetAppCacheUsageForOrigin):
(WKBundlePageCopyOriginsWithApplicationCache):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache diskUsageForOrigin:]):
(+[WebApplicationCache deleteCacheForOrigin:]):
(+[WebApplicationCache originsWithCache]):
- WebCoreSupport/WebApplicationCacheQuotaManager.mm:
(-[WebApplicationCacheQuotaManager usage]):
- 5:03 PM Changeset in webkit [274021] by
-
- 15 edits in trunk/Source
Make HTMLMediaElement::clearMediaCacheForOrigins() take in SecurityOriginData objects
https://bugs.webkit.org/show_bug.cgi?id=222832
Reviewed by Geoffrey Garen.
Make HTMLMediaElement::clearMediaCacheForOrigins() take in SecurityOriginData instead of
SecurityOrigin objects. The call site has SecurityOriginData objects and there was a FIXME
comment about switching clearMediaCacheForOrigins() to SecurityOriginData.
SecurityOriginData also has the benefits of being lighter weight, and it can be sent over
IPC, while being sufficient for our use cases here.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaCacheForOrigins):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::clearMediaCacheForOrigins):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerFactory::clearMediaCacheForOrigins const):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::clearMediaCacheForOrigins):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::clearMediaCacheForOrigins):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::clearMediaCacheForOrigins):
- WebProcess/GPU/media/RemoteMediaPlayerManager.h:
- 4:11 PM Changeset in webkit [274020] by
-
- 5 edits in trunk/LayoutTests
Add leak tests for Range and StaticRange
https://bugs.webkit.org/show_bug.cgi?id=222786
Reviewed by Dean Jackson.
Added test cases for Range and StaticRange.
- fast/dom/reference-cycle-leaks-expected.txt
- fast/dom/reference-cycle-leaks.html:
- platform/ios-wk2/fast/dom/reference-cycle-leaks-expected.txt:
- platform/mac-wk2/fast/dom/reference-cycle-leaks-expected.txt:
- 4:10 PM Changeset in webkit [274019] by
-
- 15 edits in trunk/Source
Update HTMLMediaElement::originsInMediaCache() to return SecurityOriginData instead of SecurityOrigin objects
https://bugs.webkit.org/show_bug.cgi?id=222820
Reviewed by Darin Adler.
Update HTMLMediaElement::originsInMediaCache() to return SecurityOriginData instead of SecurityOrigin
objects. The caller only needs SecurityOriginData objects and there was a FIXME comment about switching
to SecurityOriginData. SecurityOriginData is beneficial here because it is a smaller object and it
can be easily passed over IPC.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::originsInMediaCache):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::originsInMediaCache):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerFactory::originsInMediaCache const):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::originsInMediaCache):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache):
Source/WebKit:
Also update the code at WebsiteDataStore::fetchDataAndApply() to crossThreadCopy() the originDatas
before sending them to the main thread. The previous code was passing both the SecurityOrigins
and the WebsiteDatas from the data store queue to the main thread without isolated copy, which was
fragile. For example, if HTMLMediaElement::originsInMediaCache() was caching the security origins
it returned, the code would not have been thread safe.
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::originsInMediaCache):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::originsInMediaCache):
- WebProcess/GPU/media/RemoteMediaPlayerManager.h:
- 4:08 PM Changeset in webkit [274018] by
-
- 2 edits in trunk/Source/WebKit
Use WTF::DestructionThread::MainRunLoop for CallbackAggregators in WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=222831
Reviewed by Geoffrey Garen.
Use WTF::DestructionThread::MainRunLoop for CallbackAggregators in WebsiteDataStore to make sure
the CallbackAggregators get destroyed on the main thread. Previously, the code was letting the
CallbackAggregators get destroyed on any thread and then dispatching to the main thread in their
destructor their WebsiteDataStore data member to make sure it gets destroyed on the main thread.
It is simpler and safer to have the CallbackAggregators get destroyed on the main thread.
Also add threading assertions whenever the pendingCallbacks is used since this counter is not
atomic.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
- 4:08 PM Changeset in webkit [274017] by
-
- 2 edits in trunk/Source/WebKit
Fix potential thread safety issue in WebsiteDataStore::fetchDataAndApply()
https://bugs.webkit.org/show_bug.cgi?id=222830
Reviewed by Geoffrey Garen.
The previous code was passing SecurityOriginData objects from the data store queue to the main
thread without isolated copy. This code would not be thread-safe if the function we got the
origins from would keep a copy of the origins (e.g. caching). To make this more robust from a
thread-safety standpoint, we now crossThreadCopy() to origins before passing them to the main
thread.
I also updated these to construct the WebsiteData on the data store queue instead of the main
thread for consistency with other cases inside WebsiteDataStore::fetchDataAndApply().
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
- 4:02 PM Changeset in webkit [274016] by
-
- 2 edits in trunk/LayoutTests
Change test to not ASSERT in Debug
https://bugs.webkit.org/show_bug.cgi?id=221442
Patch by Rob Buis <rbuis@igalia.com> on 2021-03-05
Reviewed by Ryosuke Niwa.
Change test to not ASSERT in Debug.
- ipc/pasteboard-write-custom-data.html:
- 3:49 PM Changeset in webkit [274015] by
-
- 3 edits in trunk/Source/WebCore
[Payment Request] expose
dispatchIfShowinginMockPaymentCoordinator.cppfor WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=222833
<rdar://problem/74525927>
Reviewed by Wenson Hsieh.
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::dispatchIfShowing): added.
(WebCore::dispatchIfShowing): Deleted.
- 3:47 PM Changeset in webkit [274014] by
-
- 5 edits in branches/safari-612.1.5-branch
Cherry-pick r273997. rdar://problem/75115235
Regression(r268097): WKWebView.URL is nil in the processDidTerminate delegate
https://bugs.webkit.org/show_bug.cgi?id=222809
Reviewed by Michael Catanzaro.
Source/WebKit:
There was a PageLoadState::Transaction in resetStateAfterProcessTermination() that
was previously making sure we would not clear the WebView's URL before calling the
processDidTerminate client delegate. Now that we call the client delegate in a
separate function (WebPageProxy::dispatchProcessDidTerminate), we need to make move
the PageLoadState::Transaction to the caller in
WebProcessProxy::processDidTerminateOrFailedToLaunch(), so that its scope covers
both resetStateAfterProcessTermination() & dispatchProcessDidTerminate() calls.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resetStateAfterProcessTermination):
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:47 PM Changeset in webkit [274013] by
-
- 2 edits in branches/safari-612.1.5-branch/Source/WebCore
Cherry-pick r273866. rdar://problem/75115229
Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()
https://bugs.webkit.org/show_bug.cgi?id=222681
Reviewed by Wenson Hsieh.
Skip the loop when m_downstreamEnd.isNull() or im_downstreamEnd.isOrphan() is true
to avoid dereferencing a nullptr.
No new tests since we don't have any reproduction for this crash,
and it's not obvious how we're getting into that state.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:29 PM Changeset in webkit [274012] by
-
- 8 edits in trunk
[Payment Request] if
requestShipping: falsethen we should not show anyPaymentShippingOptionin the Apple Pay sheet
https://bugs.webkit.org/show_bug.cgi?id=222810
<rdar://problem/74550889>
Reviewed by Andy Estes and Tim Horton.
Source/WebCore:
When constructing a
PaymentRequest, the spec has logic for ensuring thatshippingOptions
is an array by overriding[[details]].shippingOptionsifrequestShipping: true[1]. It
also won't update[[details]].shippingOptionsunlessupdate.ShippingOptionsis provided
andrequestShipping: true[2]. Currently, this means that ifrequestShipping: false, we
don't perform any validation of[[details]].shippingOptionsand even provide that data to
the Apple Pay sheet. Since there is no way to look at the selected (or even the list of)
shipping option withoutrequestShipping: true, we now clear[[details]].shippingOptions
ifrequestShipping: false.
[1]: https://www.w3.org/TR/payment-request/#constructor
[2]: https://www.w3.org/TR/payment-request/#update-a-paymentrequest-s-details-algorithm
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::checkAndCanonicalizeDetails):
LayoutTests:
- http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html:
- http/tests/inspector/paymentrequest/payment-request-internal-properties.https-expected.txt:
- http/tests/paymentrequest/updateWith-shippingOptions.https.html:
- http/tests/ssl/applepay/PaymentRequest.https.html:
- http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
- 3:07 PM Changeset in webkit [274011] by
-
- 9 edits4 moves in trunk
[GTK] Clean up GTK-specific text checker stuff
https://bugs.webkit.org/show_bug.cgi?id=222818
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-03-05
Reviewed by Don Olmstead.
Source/WebKit:
This moves the GTK-specific classes WebTextChecker and WebTextCheckerClient into
GTK-specific directories.
This also moves most of WKTextChecker, except for WKTextCheckerSetTestingMode, which is
cross-platform. This is not quite how we normally do it -- normally we try to have one
cross-platform header with platform-specific conditionals and only separate out platform-
specific source files -- but in this case the header is almost entirely GTK-specific, so it
makes sense to do it this way.
This also exposes WKTextCheckerSetContinuousSpellCheckingEnabled and uses it in
UIScriptControllerGtk, which is needed for bug #181916.
This code is all pretty messy, especially the WKTextCheckerClient (which actually has its
own WKTextCheckerSetContinuousSpellCheckingEnabled!), but now it's a *platform-specific*
mess, which is a small improvement.
- SourcesGTK.txt:
- UIProcess/API/C/WKTextChecker.cpp:
(WKTextCheckerSetTestingMode):
(WKTextCheckerSetClient): Deleted.
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged): Deleted.
(WKTextCheckerGrammarCheckingEnabledStateChanged): Deleted.
(WKTextCheckerCheckSpelling): Deleted.
(WKTextCheckerChangeSpellingToWord): Deleted.
- UIProcess/API/C/WKTextChecker.h:
- UIProcess/API/C/gtk/WKTextCheckerGtk.cpp:
(WKTextCheckerSetClient):
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
(WKTextCheckerGrammarCheckingEnabledStateChanged):
(WKTextCheckerCheckSpelling):
(WKTextCheckerChangeSpellingToWord):
(WKTextCheckerSetContinuousSpellCheckingEnabled):
- UIProcess/API/C/gtk/WKTextCheckerGtk.h:
- UIProcess/gtk/WebTextChecker.cpp: Renamed from Source/WebKit/UIProcess/WebTextChecker.cpp.
(WebKit::WebTextChecker::singleton):
(WebKit::WebTextChecker::WebTextChecker):
(WebKit::WebTextChecker::setClient):
(WebKit::updateStateForAllContexts):
(WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):
- UIProcess/gtk/WebTextChecker.h: Renamed from Source/WebKit/UIProcess/WebTextChecker.h.
(WebKit::WebTextChecker::client):
- UIProcess/gtk/WebTextCheckerClient.cpp: Renamed from Source/WebKit/UIProcess/WebTextCheckerClient.cpp.
(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):
(WebKit::WebTextCheckerClient::spellingUIIsShowing):
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
(WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
(WebKit::WebTextCheckerClient::guessesForWord):
(WebKit::WebTextCheckerClient::learnWord):
(WebKit::WebTextCheckerClient::ignoreWord):
- UIProcess/gtk/WebTextCheckerClient.h: Renamed from Source/WebKit/UIProcess/WebTextCheckerClient.h.
Tools:
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
- WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
(WTR::UIScriptControllerGtk::setContinuousSpellCheckingEnabled):
- 2:56 PM Changeset in webkit [274010] by
-
- 4 edits in trunk
[GTK] Remove ADD_WHOLE_ARCHIVE_TO_LIBRARIES
https://bugs.webkit.org/show_bug.cgi?id=222826
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-03-05
Reviewed by Don Olmstead.
.:
I don't know why it's no longer needed, but GTK links without it, so it can go away.
- Source/cmake/OptionsGTK.cmake:
Tools:
- TestWebKitAPI/PlatformGTK.cmake:
- 2:34 PM Changeset in webkit [274009] by
-
- 2 edits in trunk/Tools
[webkitscmpy] Standardize timezone of mock svn server (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=222762
<rdar://problem/75058478>
Unreviewed follow-up fix.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py:
(Svn.request): Only import dateutils when using it.
- 2:31 PM Changeset in webkit [274008] by
-
- 4 edits2 adds in trunk
word-wrap/overflow-wrap "overwrite" hyphens
https://bugs.webkit.org/show_bug.cgi?id=222548
<rdar://problem/75061741>
Reviewed by Antti Koivisto.
Source/WebCore:
According to https://drafts.csswg.org/css-text-3/#overflow-wrap-property
"overflow-wrap/word-wrap property specifies whether the UA may break at otherwise disallowed points within a line to prevent overflow,
when an otherwise-unbreakable string is too long to fit within the line box."
which means that in case of "hyphen: auto", we should only try to break the content at arbitrary position when there's no prior hyphenation opportunity.
This patch turns WordBreakRule into and OptionSet so that we can put both the hyphenation and arbitrary position break runles in there and prioritize them
in tryBreakingTextRun (check for the hyphenation value first/break the content at hyphenation position and do arbitrary position only
if no hyphenation opportunities are found).
Test: fast/inline/hyphenation-when-overflow-wrap-is-break-word.html
- layout/inlineformatting/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):
(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):
- layout/inlineformatting/InlineContentBreaker.h:
LayoutTests:
- fast/inline/hyphenation-when-overflow-wrap-is-break-word-expected.html: Added.
- fast/inline/hyphenation-when-overflow-wrap-is-break-word.html: Added.
- 2:28 PM Changeset in webkit [274007] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r269627?): ASSERTION FAILED: &layoutState().establishedFormattingState(layoutBox.formattingContextRoot()) == this in WebCore::Layout::FormattingState::boxGeometry
https://bugs.webkit.org/show_bug.cgi?id=219905
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Skip this test on debug since it frequently asserts.
- 1:37 PM Changeset in webkit [274006] by
-
- 1 copy in tags/Safari-612.1.6.1
Tag Safari-612.1.6.1.
- 1:35 PM Changeset in webkit [274005] by
-
- 8 edits in branches/safari-612.1.6-branch/Source
Versioning.
WebKit-7612.1.6.1
- 1:21 PM WebKitGTK/2.32.x edited by
- (diff)
- 1:21 PM Changeset in webkit [274004] by
-
- 1 copy in tags/Safari-612.1.6
Tag Safari-612.1.6.
- 1:18 PM Changeset in webkit [274003] by
-
- 1 delete in tags/Safari-612.1.6
Delete tag.
- 1:16 PM Changeset in webkit [274002] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] fast/selectors/selection-window-inactive-text-shadow.html flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=221011
Uneviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test expectations to Pass ImageOnlyFailure until test is fixed.
- 1:15 PM Changeset in webkit [274001] by
-
- 1 copy in branches/safari-612.1.6-branch
New branch.
- 1:11 PM Changeset in webkit [274000] by
-
- 1 copy in tags/Safari-612.1.6
Tag Safari-612.1.6.
- 1:11 PM Changeset in webkit [273999] by
-
- 6 edits in trunk/Tools
[run-webkit-tests] Delete old results server code
https://bugs.webkit.org/show_bug.cgi?id=222393
<rdar://problem/74722220>
Rubber-stamped by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._end_test_run): Remove upload code.
(Manager._save_json_files): Renamed from _upload_json_files.
(Manager._upload_json_files): Renamed to _save_json_files.
(Manager.upload_results): Deleted.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.init): Remove buildbot arguments.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator):
(JSONResultsGenerator.init): Remove buildbot arguments.
(JSONResultsGenerator.get_json): Remove concept of builder.
(JSONResultsGenerator.upload_json_files): Deleted.
(JSONResultsGenerator._get_svn_revision): Deleted.
(JSONResultsGenerator._get_archived_json_results): Deleted.
(JSONResultsGenerator._insert_generic_metadata): Deleted.
(JSONResultsGenerator._convert_json_to_current_version): Deleted.
(JSONResultsGenerator._convert_tests_to_trie): Deleted.
(JSONResultsGenerator._remove_items_over_max_number_of_builds): Deleted.
(JSONResultsGenerator._normalize_results_json): Deleted.
(JSONResultsGenerator._is_results_all_of_type): Deleted.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.setUp):
(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Remove arguments used to upload to old results database.
- 1:09 PM Changeset in webkit [273998] by
-
- 8 edits in trunk/Source
Versioning.
WebKit-7612.1.7
- 12:53 PM Changeset in webkit [273997] by
-
- 5 edits in trunk
Regression(r268097): WKWebView.URL is nil in the processDidTerminate delegate
https://bugs.webkit.org/show_bug.cgi?id=222809
Reviewed by Michael Catanzaro.
Source/WebKit:
There was a PageLoadState::Transaction in resetStateAfterProcessTermination() that
was previously making sure we would not clear the WebView's URL before calling the
processDidTerminate client delegate. Now that we call the client delegate in a
separate function (WebPageProxy::dispatchProcessDidTerminate), we need to make move
the PageLoadState::Transaction to the caller in
WebProcessProxy::processDidTerminateOrFailedToLaunch(), so that its scope covers
both resetStateAfterProcessTermination() & dispatchProcessDidTerminate() calls.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessTermination):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
(TEST):
- 12:49 PM Changeset in webkit [273996] by
-
- 4 edits in trunk/Source/WebKit
Fix potential thread-safety issue in WebsiteDataStore::fetchDataAndApply()
https://bugs.webkit.org/show_bug.cgi?id=222807
Reviewed by Geoffrey Garen.
Fix an issue when WebsiteDataStore::fetchDataAndApply() failed to create an isolated
copy of the WebsiteDataRecords before passing them to its internal dispatch queue.
Also add more threading assertions to help catch issues since we have crashes in this
area of the code.
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::isolatedCopy const):
- UIProcess/WebsiteData/WebsiteDataRecord.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
- 12:47 PM Changeset in webkit [273995] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix the build with recent SDKs.
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController loadView]):
- 12:24 PM Changeset in webkit [273994] by
-
- 3 edits in trunk/LayoutTests
[ iOS/macOS wk2 ] imported/w3c/web-platform-tests/webrtc/protocol/candidate-exchange.https.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=222808
Uneviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations: Updating test expectations as Pass Failure unti test can be fixed.
- platform/mac-wk2/TestExpectations: Updating test expectations as Pass Failure unti test can be fixed.
- 12:00 PM Changeset in webkit [273993] by
-
- 3 edits in trunk/Tools
Don't open a new window in MiniBrowser if already opening a file from the command line
https://bugs.webkit.org/show_bug.cgi?id=222776
Patch by Cameron McCormack <Cameron McCormack> on 2021-03-05
Reviewed by Dean Jackson.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
(-[BrowserAppDelegate application:openFile:]):
- 11:54 AM Changeset in webkit [273992] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: border color of "grid" badge should match color of corresponding outline
https://bugs.webkit.org/show_bug.cgi?id=222747
<rdar://problem/75042342>
Reviewed by BJ Burg.
- UserInterface/Views/DOMTreeElement.css:
(.tree-outline.dom .badge-css-grid):
Drive-by: decrease the font size and align the badge in the middle of the selected tree element (i.e. keep 1px space
above and below the badge).
(body:not(.window-inactive, .window-docked-inactive) .tree-outline.dom:focus-within li.selected .badge-css-grid):
(@media (prefers-color-scheme: dark) .tree-outline.dom .badge-css-grid):
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._updateGridBadgeStatus):
For text and background color, only use the hue of the selected color to keep "grid" text always readable.
- 11:51 AM Changeset in webkit [273991] by
-
- 11 edits in branches/safari-612.1.5-branch/Source/WebCore
Cherry-pick r273935. rdar://problem/75101642
"precustomized" state of custom elements can become HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=221652
Reviewed by Darin Adler.
The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on
!isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element.
This is problematic after r266269 since that change re-purposes CustomElementState::Failed
on a custom element as "precustomized" state instead of introducing another enum value in
CustomElementState as RareDataBitFields has no more bits available.
This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that
to check whether JSHTMLUnknownElement should be created for a given element or not. Note that
HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking
a virtual function proved to incur too much runtime cost.
- dom/Node.h: (WebCore::Node::isUnknownElement const): Added. (WebCore::Node::isHTMLUnknownElement const): Added. (WebCore::Node::isSVGUnknownElement const): Added. (WebCore::Node::isMathMLUnknownElement const): Added. (WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement.
- dom/make_names.pl: (printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement returns true instead of isCustomElementUpgradeCandidate returning false.
- html/HTMLElement.h: (WebCore::HTMLElement::isHTMLUnknownElement const): Deleted.
- html/HTMLUnknownElement.h:
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument.
- mathml/MathMLElement.h:
- mathml/MathMLUnknownElement.h: (WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement.
- svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Added ConstructionType as an argument.
- svg/SVGElement.h:
- svg/SVGUnknownElement.h: (WebCore::SVGUnknownElement::SVGUnknownElement): Set NodeFlag::IsUnknownElement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [273990] by
-
- 2 edits in branches/safari-612.1.5-branch/Source/WebKit
Cherry-pick r273543. rdar://problem/75101709
REGRESSION (r269824): macCatalyst WKWebView shows chunks of other tiles in the middle of content
https://bugs.webkit.org/show_bug.cgi?id=222460
<rdar://problem/74102753>
Reviewed by Simon Fraser.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer): Reinstate some code that was accidentally deleted in r269824 that ensures that we do not use an in-use IOSurface as our front buffer, so that we don't paint into it while it's being composited in the render server.
Also, add some comments, since this code is all a little confusing
with its fronts and backs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [273989] by
-
- 2 edits in branches/safari-612.1.5-branch/Source/WebCore
Cherry-pick r273498. rdar://problem/75101801
[iOS] Crash when playing Dolby Atmos audio tracks with AVAudioTimePitchAlgorithmTimeDomain
https://bugs.webkit.org/show_bug.cgi?id=222420
<rdar://74612532>
Reviewed by Eric Carlson.
CoreAudio throws an assertion when using the TimeDomain pitch-correction algorithm on tracks
with > 2 channels. To work around this assertion for now, only set the pitch-correction
algorithm when the playbackRate is set to a non 0 or 1 value.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPreservesPitch): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPitchCorrectionAlgorithm): (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [273988] by
-
- 5 edits in branches/safari-612.1.5-branch/Source/WebKit
Cherry-pick r273286. rdar://problem/75101889
[Cocoa] Send sandbox extensions for Network Extension services in load parameters
https://bugs.webkit.org/show_bug.cgi?id=222284
<rdar://problem/74402532>
Reviewed by Brent Fulgham.
Currently, sandbox extensions for Network Extension services are sent from the UI process to the WebContent process when the
policy decision is made, but that is not soon enough in all cases. They should also be sent as part of the load parameters.
- Shared/Cocoa/LoadParametersCocoa.mm: (WebKit::LoadParameters::platformEncode const): (WebKit::LoadParameters::platformDecode):
- Shared/LoadParameters.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::addPlatformLoadParameters):
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:49 AM Changeset in webkit [273987] by
-
- 2 edits in trunk/Tools
[ews] Add python 3 support in send_email
https://bugs.webkit.org/show_bug.cgi?id=222806
Reviewed by Jonathan Bedard.
- CISupport/ews-build/send_email.py:
(send_email):
- 11:26 AM Changeset in webkit [273986] by
-
- 2 edits in trunk/Source/WebCore
Canvas: drawImage should normalize srcRect before checking if it's empty
https://bugs.webkit.org/show_bug.cgi?id=222774
Reviewed by Dean Jackson.
From 4.12.5.1.14 Drawing images, step 4:
"The source rectangle is the rectangle whose corners are the four
points (sx, sy), (sx+sw, sy), (sx+sw, sy+sh), (sx, sy+sh)."
When a negative height/width is given, e.g. y:100 and height:-50, it
should be treated like the rect with y:50, height: 50 (i.e. normalized), to
avoid FloatRect:isEmpty returning true.
Covered by existing test:
imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.negativedir.html
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImage):
- 11:19 AM Changeset in webkit [273985] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Test platform/mac/media/encrypted-media/fps-encrypted-event.html times out when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221847
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: The test is frequently failing on EWS, so re-add a timeout expectation.
- 11:12 AM Changeset in webkit [273984] by
-
- 13 edits in trunk
[CMake] Bump cmake_minimum_required version to 3.12 or later
https://bugs.webkit.org/show_bug.cgi?id=221727
<rdar://problem/74454980>
Reviewed by Konstantin Tokarev.
.:
Updates the minimum version to 3.12. In CMake 3.12 OBJECT library functionality was
expanded to the point where they can successfully be used as a replacement for
--whole-archive within WebKit. The check in JSCOnly for the minimum version before
using hidden visibility was removed accordingly.
- CMakeLists.txt:
- Source/cmake/OptionsJSCOnly.cmake:
Source/JavaScriptCore:
Sync cmake_minimum_required version for AppleWin internal builds.
- CMakeLists.txt:
Source/WebCore:
Sync cmake_minimum_required version for AppleWin internal builds.
- CMakeLists.txt:
Source/WebKitLegacy:
Sync cmake_minimum_required version for AppleWin internal builds.
- CMakeLists.txt:
Source/WebKitLegacy/win:
Sync cmake_minimum_required version for AppleWin internal builds.
- WebKitQuartzCoreAdditions/CMakeLists.txt:
Source/WTF:
Sync cmake_minimum_required version for AppleWin internal builds.
- CMakeLists.txt:
- 10:53 AM Changeset in webkit [273983] by
-
- 2 edits in trunk/Tools
Unreviewed Dashboard Fix.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 10:51 AM Changeset in webkit [273982] by
-
- 3 edits2 adds in trunk
sticky position incorrect behavior in table with dir=RTL
https://bugs.webkit.org/show_bug.cgi?id=221624
<rdar://problem/74403616>
Reviewed by Zalan Bujtas.
Source/WebCore:
We use scroll offsets when computing sticky constraints, so we should also use them
when computing layer positions in the scrolling tree.
Test: fast/css/sticky/sticky-in-rtl-overflow.html
- page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
LayoutTests:
- fast/css/sticky/sticky-in-rtl-overflow-expected.html: Added.
- fast/css/sticky/sticky-in-rtl-overflow.html: Added.
- 10:34 AM Changeset in webkit [273981] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Test fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html times out when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221794
Reviewed by Dean Jackson.
- platform/wk2/TestExpectations: Remove expectation now that it passes on the bots.
- 10:15 AM Changeset in webkit [273980] by
-
- 3 edits in trunk/Tools
[ews] Run ews unit-tests with Python 3
https://bugs.webkit.org/show_bug.cgi?id=222800
Reviewed by Jonathan Bedard.
- CISupport/ews-build/steps.py:
(RunEWSUnitTests):
- CISupport/ews-build/steps_unittest.py: Updated unit-tests.
- 10:07 AM Changeset in webkit [273979] by
-
- 2 edits in trunk/Tools
Mark myself as committer in contributors.json.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 9:55 AM Changeset in webkit [273978] by
-
- 2 edits in trunk/LayoutTests
[ Big Sur Wk2 ] imported/w3c/web-platform-tests/server-timing/server_timing_header-parsing.https.html is flakey text failing
https://bugs.webkit.org/show_bug.cgi?id=221487
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating flakey test expectations to Pass Failure until test can be fixed.
- 9:43 AM Changeset in webkit [273977] by
-
- 2 edits in trunk/Source/WebCore
Refactor CSSPropertyAnimation to specify fewer wrappers and use value() functions
https://bugs.webkit.org/show_bug.cgi?id=222751
Reviewed by Dean Jackson.
We clean up CSSPropertyAnimation by removing a few dedicated wrappers which added little value
over passing in parameters to existing wrappers: PropertyWrapperColor, PropertyWrapperAcceleratedOpacity,
PropertyWrapperAcceleratedTransform, PropertyWrapperScale, PropertyWrapperRotate and PropertyWrapperTranslate
are out. For most of those we introduce the new AcceleratedPropertyWrapper to replace them.
Additionally, there is a value() method that can be used instead of using m_getter in lots of places,
which makes the code much more readable.
- animation/CSSPropertyAnimation.cpp:
(WebCore::AcceleratedPropertyWrapper::AcceleratedPropertyWrapper):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::PropertyWrapperColor::PropertyWrapperColor): Deleted.
(WebCore::PropertyWrapperAcceleratedOpacity::PropertyWrapperAcceleratedOpacity): Deleted.
(WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform): Deleted.
- 9:38 AM Changeset in webkit [273976] by
-
- 5 edits in trunk/Tools
[webkitscmpy] Correct BitBucket timestamp conversion
https://bugs.webkit.org/show_bug.cgi?id=222766
<rdar://problem/75063548>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request): Bitbucket timestamps are in milliseconds.
- Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.commit): Bitbucket timestamps are in milliseconds.
- 9:20 AM Changeset in webkit [273975] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Test fast/mediastream/media-element-current-time.html fails when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221826
Reviewed by Dean Jackson.
- platform/mac-wk2/TestExpectations: Remove expectation since the test passes on the bots.
- 9:16 AM Changeset in webkit [273974] by
-
- 8 edits in trunk/Source/WebCore
[LFC][IFC] Transition LineBox::InlineLevelBoxList from a list of std::unique_ptr<InlineLevelBox> to a list of InlineLevelBox objects
https://bugs.webkit.org/show_bug.cgi?id=222761
Reviewed by Antti Koivisto.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
- layout/inlineformatting/InlineFormattingContextQuirks.cpp:
(WebCore::Layout::InlineFormattingContext::Quirks::inlineLevelBoxAffectsLineBox const):
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::addInlineLevelBox):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::nonRootInlineLevelBoxes):
(WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox):
(WebCore::Layout::LineBox::InlineLevelBox::createAtomicInlineLevelBox):
(WebCore::Layout::LineBox::InlineLevelBox::createInlineBox):
(WebCore::Layout::LineBox::InlineLevelBox::createLineBreakBox):
(WebCore::Layout::LineBox::InlineLevelBox::createGenericInlineLevelBox):
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::showInlineTreeAndRuns):
- 8:33 AM Changeset in webkit [273973] by
-
- 7 edits in trunk/Tools
[webkitscmpy] Standardize timezone of mock svn server
https://bugs.webkit.org/show_bug.cgi?id=222762
<rdar://problem/75058478>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version, add dateutils.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py:
(Svn.request): Lock timezone of SVN server.
- Scripts/webkitpy/init.py: Move dateutils to webkitcorepy.
- 8:24 AM Changeset in webkit [273972] by
-
- 4 edits1 add in trunk
OpGetPrivateName needs to be listed in FOR_EACH_OPCODE_WITH_VALUE_PROFILE
https://bugs.webkit.org/show_bug.cgi?id=222775
<rdar://74982634>
Reviewed by Michael Saboff.
JSTests:
- stress/private-name-assignment-in-constructor.js: Added.
(Foo):
Source/JavaScriptCore:
Right now valueProfileForBytecodeIndex incorrectly returns null for op_get_private_name.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::valueProfileForBytecodeIndex):
- bytecode/Opcode.h:
- 8:20 AM Changeset in webkit [273971] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix after r273966.
- platform/win/DragImageCGWin.cpp:
(WebCore::scaleDragImage):
- 8:15 AM Changeset in webkit [273970] by
-
- 12 edits12 adds in trunk
AVIF decoding support
https://bugs.webkit.org/show_bug.cgi?id=207750
Reviewed by Philippe Normand.
This patch brings an initial support of AVIF image format to the gtk port.
AVIF is a new royalty-free image format derived from the keyframes of AV1 video.
FireFox and Chromium-variant browsers already support it. Its specification can be found
at https://rawcdn.githack.com/AOMediaCodec/av1-avif/67a92add6cd642a8863e386fa4db87954a6735d1/index.html
This patch aims to land a build option for AVIF and a basic decoding ability
for still images by using libavif. Animated AVIF images will be covered later.
.:
- Source/cmake/FindAVIF.cmake: Added to find libavif.
- Source/cmake/OptionsGTK.cmake: A build option, USE_AVIF is added.
Source/WebCore:
A mimetype and a decoder for AVIF are newly added. The new tests verify
if an avif image can be decoded and properly rendered. Only the gtk port performs
these tests for now.
Tests: fast/images/avif-as-image.html
fast/images/avif-image-decoding.html
- PlatformGTK.cmake: Add AVIFImageDecoder.cpp and AVIFImageReader.cpp as build targets
- platform/MIMETypeRegistry.cpp: avif mimetype added.
(WebCore::MIMETypeRegistry::supportedImageMIMETypes):
- platform/image-decoders/ScalableImageDecoder.cpp:
(WebCore::ScalableImageDecoder::create): AVIF file signature added.
- platform/image-decoders/avif/AVIFImageDecoder.cpp: Added.
(WebCore::AVIFImageDecoder::AVIFImageDecoder):
(WebCore::AVIFImageDecoder::frameBufferAtIndex): Decode a frame of avif image.
The first frame is decoded for now.
(WebCore::AVIFImageDecoder::setFailed):
(WebCore::AVIFImageDecoder::tryDecodeSize): Parses header of avif images.
(WebCore::AVIFImageDecoder::decode):
- platform/image-decoders/avif/AVIFImageDecoder.h: Added.
- platform/image-decoders/avif/AVIFImageReader.cpp: Added.
(WebCore::AVIFImageReader::AVIFImageReader):
(WebCore::AVIFImageReader::~AVIFImageReader):
(WebCore::AVIFImageReader::parseHeader): Actual parsing of the header with libavif
(WebCore::AVIFImageReader::decodeFrame): Actual decoding of an avif frame.
- platform/image-decoders/avif/AVIFImageReader.h: Added.
- platform/image-decoders/avif/AVIFUniquePtr.h: Added a smart pointer template for avifDecoder.
(WebCore::AVIFPtrDeleter<avifDecoder>::operator() const):
Tools:
- gtk/install-dependencies: Add dependencies of libavif for jhbuild
- gtk/jhbuild.modules: Add libavif for jhbuild
LayoutTests:
The new tests verify if an avif image can be decoded and properly rendered.
Only the gtk port performs these tests for now.
- TestExpectations: Skip avif tests for non-gtk ports
- fast/images/avif-as-image-expected.html: Added.
- fast/images/avif-as-image.html: Added.
- fast/images/avif-image-decoding-expected.txt: Added.
- fast/images/avif-image-decoding.html: Added.
- fast/images/resources/green-313x313.avif: Added.
- platform/gtk/TestExpectations: The gtk port should pass the tests.
- 8:10 AM Changeset in webkit [273969] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix after r273966.
- platform/win/DragImageCGWin.cpp:
(WebCore::scaleDragImage):
- 8:10 AM Changeset in webkit [273968] by
-
- 2 edits in trunk/Source/WebCore/PAL
Fix my iOS Simulator build.
https://bugs.webkit.org/show_bug.cgi?id=222041
- pal/spi/cocoa/AVStreamDataParserSPI.h:
My build couldn't find what CMSampleBufferRef was supposed to mean, so I include CoreMedia.h.
I have no idea why all the bots build successfully.
- 7:50 AM Changeset in webkit [273967] by
-
- 21 edits in trunk/Source
[GPU Process] Remote control command should only go to the current NowPlaying session
https://bugs.webkit.org/show_bug.cgi?id=222759
<rdar://problem/75053393>
Reviewed by Jer Noble.
Source/WebCore:
Don't register a remote command listener for every web process, or every remote control
commands will go to every web process. Instead, register a single listener for the
GPU process and route commands to only the current NowPlaying process.
Tested manually.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): Drive-by: SkipForward
and SkipBackwards should seek relative to current time.
- platform/NowPlayingManager.cpp:
(WebCore::NowPlayingManager::setSupportedRemoteCommands): New, pass through to the
command listener.
- platform/NowPlayingManager.h:
- platform/RemoteCommandListener.cpp:
(WebCore::RemoteCommandListener::addSupportedCommand): m_registeredCommands -> m_supportedCommands.
(WebCore::RemoteCommandListener::removeSupportedCommand): Ditto.
(WebCore::RemoteCommandListener::setSupportedCommands): Ditto. Schedule update.
(WebCore::RemoteCommandListener::updateSupportedCommands):
- platform/RemoteCommandListener.h:
- platform/audio/NowPlayingInfo.h:
(WebCore::NowPlayingInfo::operator== const): Add operator so we can avoid updating
when nothing has changed.
(WebCore::NowPlayingInfo::operator!= const):
- platform/audio/cocoa/MediaSessionManagerCocoa.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo): Always set string properties
so we don't show stale information after switching to a session that doesn't provide
all of the same properties.
(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo): Only update when we have
new state.
- platform/mac/MediaRemoteSoftLink.h:
- platform/mac/MediaRemoteSoftLink.mm: Soft link kMRMediaRemoteCommandInfoPreferredIntervalsKey.
Source/WebKit:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::clearNowPlayingInfo): Track being the active
NowPlaying process.
(WebKit::GPUConnectionToWebProcess::setNowPlayingInfo): Ditto.
(WebKit::GPUConnectionToWebProcess::updateSupportedRemoteCommands): Pass supported
commands and seeking to NowPlayingManager so it can pass them to the remote command
listener.
(WebKit::GPUConnectionToWebProcess::createRemoteCommandListener): We only ever need
one listener.
(WebKit::GPUConnectionToWebProcess::releaseRemoteCommandListener): Ditto.
(WebKit::GPUConnectionToWebProcess::dispatchMessage): Dispatch RemoteRemoteCommandListenerProxy
messages.
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/media/RemoteRemoteCommandListenerProxy.cpp:
(WebKit::RemoteRemoteCommandListenerProxy::RemoteRemoteCommandListenerProxy): Don't
create a remote command listener, we only need one for the GPU process.
(WebKit::RemoteRemoteCommandListenerProxy::updateSupportedCommands): New.
(WebKit::RemoteRemoteCommandListenerProxy::didReceiveRemoteControlCommand): Deleted.
- GPUProcess/media/RemoteRemoteCommandListenerProxy.h:
(WebKit::RemoteRemoteCommandListenerProxy::create):
(WebKit::RemoteRemoteCommandListenerProxy::supportsSeeking const):
(WebKit::RemoteRemoteCommandListenerProxy::supportedCommands const):
(WebKit::RemoteRemoteCommandListenerProxy::identifier const):
- GPUProcess/media/RemoteRemoteCommandListenerProxy.messages.in:
- WebProcess/GPU/media/RemoteRemoteCommandListener.cpp:
(WebKit::RemoteRemoteCommandListener::RemoteRemoteCommandListener): Use m_process
instead of calling WebProcess::singleton().
(WebKit::RemoteRemoteCommandListener::~RemoteRemoteCommandListener): Ditto.
(WebKit::RemoteRemoteCommandListener::didReceiveRemoteControlCommand): Use client(),
m_client is now private.
(WebKit::RemoteRemoteCommandListener::updateSupportedCommands):
- WebProcess/GPU/media/RemoteRemoteCommandListener.h:
- 7:44 AM Changeset in webkit [273966] by
-
- 92 edits in trunk
Reduce use of CFRetain() / CFRelease() / CFAutoRelease() in WebKit
https://bugs.webkit.org/show_bug.cgi?id=222760
Reviewed by Darin Adler.
Reduce use of CFRetain() / CFRelease() / CFAutoRelease() in WebKit by using RetainPtr<>.
Source/JavaScriptCore:
- API/JSContext.mm:
(-[JSContext name]):
- API/JSValue.mm:
(valueToObjectWithoutCopy):
(valueToString):
- inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::deserializeMessage):
Source/WebCore:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXTextMarkerRange):
(WebCore::AXTextMarkerRangeStart):
(WebCore::AXTextMarkerRangeEnd):
(WebCore::textMarkerForVisiblePosition):
(WebCore::textMarkerForCharacterOffset):
(WebCore::startOrEndTextMarkerForRange):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(nextTextMarkerForCharacterOffset):
(previousTextMarkerForCharacterOffset):
(-[WebAccessibilityObjectWrapper textMarkerForFirstPositionInTextControl:]):
(AXAttributeStringSetElement):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processText):
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
- page/mac/EventHandlerMac.mm:
(WebCore::selfRetainingNSScrollViewScrollWheel):
- page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
- platform/cf/MainThreadSharedTimerCF.cpp:
(WebCore::sharedTimer):
(WebCore::MainThreadSharedTimer::restartSharedTimer):
(WebCore::MainThreadSharedTimer::invalidate):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::exernalDeviceDisplayNameForPlayer):
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::initialize):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::patternReleaseCallback):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
- platform/graphics/cg/PatternCG.cpp:
(WebCore::patternReleaseCallback):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::autoActivateFont):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::FontCascade::getPlatformGlyphAdvances):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
- platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):
- platform/ios/wak/WebCoreThread.mm:
(SendDelegateMessage):
(RunWebThread):
(WebThreadUnlockGuardForMail):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(WebCore::speechSynthesisGetVoiceIdentifiers):
(WebCore::speechSynthesisGetDefaultVoiceIdentifierForLocale):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
- platform/mac/PluginBlocklist.mm:
(WebCore::PluginBlocklist::create):
- platform/mac/WebGLBlocklist.mm:
(WebCore::WebGLBlocklist::create):
- platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::attachPrimingTrimsIfNeeded):
(WebCore::AudioSampleBufferCompressor::provideSourceDataNumOutputPackets):
- platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::setCompressionSessionProperty):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formRead):
(WebCore::formCanRead):
(WebCore::formSchedule):
(WebCore::formUnschedule):
- platform/network/cf/NetworkStorageSessionCFNetWin.cpp:
(WebCore::createPrivateStorageSession):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::setClientCertificateInSSLProperties):
(WebCore::ResourceHandle::createCFURLConnection):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/win/DragImageCGWin.cpp:
(WebCore::createCgContextFromBitmap):
(WebCore::scaleDragImage):
- platform/win/WebCoreBundleWin.cpp:
(WebCore::createWebKitBundle):
(WebCore::webKitBundle):
- rendering/RenderThemeMac.mm:
(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
- testing/cocoa/WebArchiveDumpSupport.h:
- testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createXMLStringFromWebArchiveData):
- testing/cocoa/WebViewVisualIdentificationOverlay.mm:
(identificationFont):
Source/WebKit:
- Platform/mac/StringUtilities.mm:
(WebKit::nsStringFromWebCoreString):
(WebKit::formattedPhoneNumberString):
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeCocoaOverrides):
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forURL):
(WebKit::PasteboardTypes::forImages):
(WebKit::PasteboardTypes::forImagesWithArchive):
(WebKit::PasteboardTypes::forSelection):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::acceptsFirstMouse):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::validAttributesForMarkedText):
(WebKit::WebViewImpl::performKeyEquivalent):
- UIProcess/Inspector/ios/WKInspectorHighlightView.mm:
(layerPathWithHole):
(layerPath):
- UIProcess/_WKTouchEventGenerator.mm:
(-[_WKTouchEventGenerator dealloc]):
(-[_WKTouchEventGenerator _sendHIDEvent:]):
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _EVOrganizationName]):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::webProcessLoaderAccessibilityBundlePath):
Source/WebKitLegacy/ios:
- Misc/WebUIKitSupport.mm:
(LoadWebLocalizedStrings):
- WebView/WebPDFViewIOS.mm:
(-[WebPDFView finishedLoadingWithDataSource:]):
- WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
Source/WebKitLegacy/mac:
- Misc/WebLocalizableStrings.mm:
- Misc/WebNSDataExtras.mm:
(-[NSString _web_capitalizeRFC822HeaderFieldName]):
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::preferredBundleLocalizationName):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView status:]):
- WebCoreSupport/WebProgressTrackerClient.mm:
(WebProgressTrackerClient::progressEstimateChanged):
- WebInspector/WebNodeHighlightView.mm:
(layerPathWithHole):
(layerPath):
- WebView/WebFrame.mm:
(createUniqueWebDataURL):
- WebView/WebView.mm:
(+[WebView _setCacheModel:]):
Source/WebKitLegacy/win:
- CFDictionaryPropertyBag.cpp:
(ConvertVariantToCFType):
(CFDictionaryPropertyBag::Read):
(CFDictionaryPropertyBag::Write):
- MarshallingHelpers.cpp:
(MarshallingHelpers::PathStringToFileCFURLRef):
(MarshallingHelpers::FileCFURLRefToPathString):
(MarshallingHelpers::BSTRToCFURLRef):
(MarshallingHelpers::BSTRToCFStringRef):
(MarshallingHelpers::LPCOLESTRToCFStringRef):
(MarshallingHelpers::intToCFNumberRef):
(MarshallingHelpers::safeArrayToStringArray):
(MarshallingHelpers::safeArrayToIntArray):
(MarshallingHelpers::safeArrayToIUnknownArray):
- MarshallingHelpers.h:
- WebApplicationCache.cpp:
(WebApplicationCache::originsWithCache):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
- WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
(WebDownload::setDestination):
(WebDownload::willSendRequest):
- WebHistory.cpp:
(createUserInfoFromArray):
- WebLocalizableStrings.cpp:
(createWebKitBundle):
Source/WTF:
- wtf/cocoa/NSURLExtras.mm:
(WTF::decodePercentEscapes):
(WTF::URLByTruncatingOneCharacterBeforeComponent):
(WTF::URLWithData):
(WTF::URLByRemovingComponentAndSubsequentCharacter):
Tools:
- DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
(createCoreAnimationLayer):
- DumpRenderTree/mac/AccessibilityCommonMac.mm:
(+[NSString stringWithJSStringRef:]):
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontIOS):
(dumpRenderTree):
(invalidateAnyPreviousWaitToDumpWatchdog):
(setWaitToDumpWatchdog):
(dump):
(runTest):
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(takeWindowSnapshot):
(createBitmapContextFromWebView):
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL):
(TestRunner::setWaitToDump):
- FontWithFeatures/FontWithFeatures/main.cpp:
(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(+[NSString stringWithJSStringRef:]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
(+[NSString stringWithJSStringRef:]):
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventWithInfo:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::cfString):
(WTR::UIScriptControllerMac::replaceTextAtRange):
- 7:31 AM Changeset in webkit [273965] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Bubblewrap sandbox should not break X11 forwarding
https://bugs.webkit.org/show_bug.cgi?id=221990
Patch by Michael Catanzaro <Michael Catanzaro> on 2021-03-05
Reviewed by Carlos Alberto Lopez Perez.
If $DISPLAY points to a TCP socket, or a Unix socket on a different host, then we cannot
isolate the web process from the network and must grant access to the host network
namespace.
Also, clean up some related code by adding PLATFORM(X11) guards where appropriate and
removing a redundant display type check.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindWayland):
(WebKit::shouldUnshareNetwork):
(WebKit::bubblewrapSpawn):
- 7:05 AM Changeset in webkit [273964] by
-
- 14 edits in trunk
Allow CSS font-styling for canvas without RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=222665
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/html/canvas/element/drawing-text-to-the-canvas/2d.text.draw.fontface.notinpage-expected.txt: Now passes
Source/WebCore:
Refactor CSSPrimitiveValue::computeNonCalcLengthDouble to allow for
its use without requiring CSSToLengthConversionData and RenderStyle.
No new tests, already covered by existing tests.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeUnzoomedNonCalcLengthDouble):
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
- css/CSSPrimitiveValue.h:
- css/CSSToLengthConversionData.h:
(WebCore::CSSToLengthConversionData::propertyToCompute const):
(WebCore::CSSToLengthConversionData::renderView const):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::FontProxy::initialize):
- html/canvas/CanvasRenderingContext2DBase.h:
- html/canvas/OffscreenCanvasRenderingContext2D.cpp:
(WebCore::OffscreenCanvasRenderingContext2D::setFont):
- style/StyleFontSizeFunctions.cpp:
(WebCore::Style::computedFontSizeFromSpecifiedSize):
(WebCore::Style::computedFontSizeFromSpecifiedSizeForSVGInlineText):
(WebCore::Style::fontSizeForKeyword):
- style/StyleFontSizeFunctions.h:
- style/StyleResolveForFontRaw.cpp:
(WebCore::Style::resolveForFontRaw):
- style/StyleResolveForFontRaw.h:
- 5:15 AM Changeset in webkit [273963] by
-
- 3 edits in trunk/Tools
[GTK] Clang warnings in MiniBrowser build
https://bugs.webkit.org/show_bug.cgi?id=222797
Patch by Philippe Normand <pnormand@igalia.com> on 2021-03-05
Reviewed by Carlos Garcia Campos.
Fix unused-value warnings.
- MiniBrowser/gtk/BrowserCellRendererVariant.c:
(browser_cell_renderer_variant_init):
- MiniBrowser/gtk/BrowserTab.c:
(runColorChooserCallback):
- 4:16 AM Changeset in webkit [273962] by
-
- 16 edits in trunk
[WASM-Function-References] Update ref.func to produce (ref $t)
https://bugs.webkit.org/show_bug.cgi?id=222779
Patch by Dmitry Bezhetskov <dbezhetskov> on 2021-03-05
Reviewed by Yusuke Suzuki.
Make ref.func to produce non nullable reference type which
incorporates signature index. Since in JSC signature index represents
type of the function from Type section we use it instead of type_idx
for representing type of function references.
JSTests:
- wasm/wasm.json:
Source/JavaScriptCore:
- runtime/OptionsList.h:
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addTableGrow):
(JSC::Wasm::AirIRGenerator::addTableFill):
(JSC::Wasm::AirIRGenerator::unify):
- wasm/WasmFormat.h:
(JSC::Wasm::isValueType):
(JSC::Wasm::isSubtype):
(JSC::Wasm::isRefType):
- wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::checkBranchTarget):
(JSC::Wasm::FunctionParser<Context>::unify):
(JSC::Wasm::FunctionParser<Context>::parseExpression):
- wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
- wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseGlobal):
- wasm/generateWasmOpsHeader.py:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- wasm/wasm.json:
- 4:05 AM Changeset in webkit [273961] by
-
- 5 edits1 add in trunk
XRFrame getViewerPose has emulatedPosition set properly
https://bugs.webkit.org/show_bug.cgi?id=222785
Patch by Imanol Fernandez <imanol> on 2021-03-05
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Update getViewerPose_emulatedPosition test expectations.
- web-platform-tests/webxr/getViewerPose_emulatedPosition.https-expected.txt: Added.
Source/WebCore:
emulatedPosition in set in WebXR DOM code and OpenXR platform, but not set in FakeWebXRDevice.
Tested by getViewerPose_emulatedPosition.html.
- testing/WebFakeXRDevice.cpp:
(WebCore::SimulatedXRDevice::frameTimerFired): set emulatedPosition
LayoutTests:
Update getViewerPose_emulatedPosition test expectations.
- platform/wpe/TestExpectations:
- 3:53 AM Changeset in webkit [273960] by
-
- 2 edits in trunk/Source/WebKit
Add support for gstreamer's h264 stateless codecs
https://bugs.webkit.org/show_bug.cgi?id=222787
Patch by Guido Günther <agx@sigxcpu.org> on 2021-03-05
Reviewed by Philippe Normand.
Manually tested, there is currently no automatic tests for it
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindV4l):
- 3:15 AM Changeset in webkit [273959] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, final (hopefully) WPE/GTK follow-up to r273951
Rubber-stamped by Xabier Rodriguez-Calvar.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerSampleFromLibWebRTCVideoFrame): Move WARN_UNUSED_RETURN to header file
and fix pessimizing-move warning.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
- 2:54 AM Changeset in webkit [273958] by
-
- 4 edits in trunk
[css-flexbox] Fix mainAxisLengthIsDefinite for orthogonal items with percentage sizes
https://bugs.webkit.org/show_bug.cgi?id=222684
Reviewed by Javier Fernandez.
Source/WebCore:
r260055 fixed a crash in flexbox code by not caching the definiteness of the logical height of the flexbox
container in case of having orthogonal items because in that case, the logical heights of the flex container
and the flex item are not in the same axis. That made a lot of sense, however we should still let the method
return whether or not the child main axis is definite instead of unconditionally return false.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childMainSizeIsDefinite const):
LayoutTests:
- TestExpectations: Unskipped flexbox-basic-canvas-vert-001v.xhtml which is now passing.
- 2:50 AM Changeset in webkit [273957] by
-
- 18 edits3 adds in trunk
Implement WebXRBoundedReferenceSpace bounds geometry
https://bugs.webkit.org/show_bug.cgi?id=222737
Patch by Imanol Fernandez <imanol> on 2021-03-05
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Update WebXRBoundedReferenceSpace test expectations.
- web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https-expected.txt: Added.
Source/WebCore:
Having bounds geometry in WebXRBoundedReferenceSpace enables WebXR room-scale applications. XR systems may have limited
real world spatial ranges in which users can freely move around while remaining tracked. WebXR Applications can query
these boundaries and alter application behavior or content placement to ensure the user can complete the experience while
remaining within the boundary.
Tested by WebXR WPT tests.
- Modules/webxr/WebXRBoundedReferenceSpace.cpp:
(WebCore::WebXRBoundedReferenceSpace::boundsGeometry): Call updateIfNeeded
(WebCore::WebXRBoundedReferenceSpace::getOffsetReferenceSpace): Use Exception instead of null RefPtr<>
(WebCore::WebXRBoundedReferenceSpace::updateIfNeeded): Updates boundsGeometry vector when data changed.
(WebCore::WebXRBoundedReferenceSpace::quantize): Utility method to avoid fingerprinting.
- Modules/webxr/WebXRBoundedReferenceSpace.h:
- Modules/webxr/WebXRBoundedReferenceSpace.idl: Add CustomToJSObject
- Modules/webxr/WebXRReferenceSpace.cpp:
(WebCore::WebXRReferenceSpace::getOffsetReferenceSpace): Use Exception instead of null RefPtr<>
- Modules/webxr/WebXRReferenceSpace.h:
- Modules/webxr/WebXRReferenceSpace.idl: Add CustomToJSObject
- Modules/webxr/WebXRSpace.idl: Add CustomToJSObject
- Sources.txt: Add CustomToJSObject implementations
- bindings/js/JSWebXRReferenceSpaceCustom.cpp: Added.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/JSWebXRSpaceCustom.cpp: Added.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- platform/xr/PlatformXR.h: Add StageParameters to FrameData.
- platform/xr/openxr/PlatformXROpenXR.cpp: Implement boundsGeometry using OpenXR.
(PlatformXR::OpenXRDevice::initializeReferenceSpace):
(PlatformXR::OpenXRDevice::requestFrame):
(PlatformXR::OpenXRDevice::collectEnabledFeatures):
(PlatformXR::OpenXRDevice::pollEvents):
(PlatformXR::OpenXRDevice::resetSession):
(PlatformXR::OpenXRDevice::updateStageParameters):
- platform/xr/openxr/PlatformXROpenXR.h:
- testing/WebFakeXRDevice.cpp: Implement boundsGeometry for tests.
(WebCore::SimulatedXRDevice::setNativeBoundsGeometry):
(WebCore::SimulatedXRDevice::frameTimerFired):
(WebCore::WebFakeXRDevice::setBoundsGeometry):
- testing/WebFakeXRDevice.h:
LayoutTests:
Update WebXRBoundedReferenceSpace test expectations.
- platform/wpe/TestExpectations:
- 2:18 AM Changeset in webkit [273956] by
-
- 9 edits in trunk
[GPU Process] RemoteImageBuffer recording GraphicsContext should report its backend RenderingMode
https://bugs.webkit.org/show_bug.cgi?id=222772
Reviewed by Simon Fraser.
Source/WebCore:
This will allow compositing the 2D canvas elements when GPU rendering is
enabled for 2D canvas.
- platform/graphics/GraphicsContextImpl.h:
(WebCore::GraphicsContextImpl::renderingMode const):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext const):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext const):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::renderingMode const):
- platform/graphics/displaylists/DisplayListRecorder.h:
(WebCore::DisplayList::Recorder::Delegate::renderingMode const):
Source/WebKit:
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
LayoutTests:
- gpu-process/TestExpectations:
- 2:14 AM Changeset in webkit [273955] by
-
- 4 edits in trunk
WPT test css/css-flexbox/flex-minimum-height-flex-items-023.html fails
https://bugs.webkit.org/show_bug.cgi?id=214292
Reviewed by Javier Fernandez.
Source/WebCore:
CSS flex specs define how to compute the main axis automatic minimum size of a flex item in order to
provide a more reasonable minimum size (as grid does). So far we've considered "automatic minimum size"
as either min-{width|height}:auto. However the css-sizing-3 specs mention that for the block size
either min-content, max-content or fit-content are (unless otherwise specified) equivalent to the
automatic size (see https://drafts.csswg.org/css-sizing-3/#valdef-width-min-content).
This means that we need to expand our check to consider those intrinsic sizes as automatic whenever the
block axis of the flex item is the flexbible box main size.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::shouldApplyMinSizeAutoForChild const): Consider intrinsic sizes as automatic
in case the child block axis is the flex container main axis.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Let intrinsic sizes be handled by the code
that computes min-size:auto.
LayoutTests:
- TestExpectations: Unskipped the test that passes now.
- 2:07 AM Changeset in webkit [273954] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, WPE/GTK build fix after r273953
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerSampleFromLibWebRTCVideoFrame):
- 1:54 AM Changeset in webkit [273953] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Unreviewed follow-up to r273951
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerSampleFromLibWebRTCVideoFrame): Add &&, forgotten during review cycle.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
- 1:50 AM Changeset in webkit [273952] by
-
- 4 edits in trunk
Fix flex-aspect-ratio-009.html
https://bugs.webkit.org/show_bug.cgi?id=222780
Patch by Rob Buis <rbuis@igalia.com> on 2021-03-05
Reviewed by Sergio Villar Senin.
Source/WebCore:
Since CSS aspect-ratio does not rely on intrinsic size for
calculating the ratio, the check for intrinsic height should
not apply to it.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childCrossSizeShouldUseContainerCrossSize const):
LayoutTests:
Enable test that passes now.
- 1:38 AM Changeset in webkit [273951] by
-
- 9 edits in trunk
REGRESSION(r273309) [GStreamer] webrtc/captureCanvas-webrtc-software-h264-baseline.html is flaky crashing inside libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=222451
Patch by Philippe Normand <pnormand@igalia.com> on 2021-03-05
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The main issue here was related with bad memory management in the VideoFrameLibWebRTC
implementation, the video converter was writing to a buffer allocated by the libwebrtc
aligned-malloc allocator and that was triggering various issues. There's little benefit of
using a buffer pool anyway since we end-up doing buffer copies.
The patch also includes a bunch of coding style fixes, a few smart-pointer improvements, and
improved error handling in the decoder factory, which was previously handling warnings only.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerSampleFromLibWebRTCVideoFrame):
(WebCore::GStreamerVideoFrameLibWebRTC::create):
(WebCore::LibWebRTCVideoFrameFromGStreamerSample):
(WebCore::GStreamerVideoFrameLibWebRTC::ToI420):
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
(WebCore::GStreamerVideoFrameLibWebRTC::GStreamerVideoFrameLibWebRTC):
(WebCore::GStreamerVideoFrameLibWebRTC::takeSample):
- platform/mediastream/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeIncomingVideoSourceLibWebRTC::OnFrame):
- platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingVideoSourceLibWebRTC::videoSampleAvailable):
- platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoder::handleError):
(WebCore::GStreamerVideoDecoder::pullSample):
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerEncodedImageBuffer::create):
(WebCore::GStreamerEncodedImageBuffer::getBuffer const):
(WebCore::GStreamerEncodedImageBuffer::getVideoResolution const):
(WebCore::GStreamerEncodedImageBuffer::GStreamerEncodedImageBuffer):
LayoutTests:
- platform/glib/TestExpectations: Update expectations for webrtc h264 tests that are
slightly less broken now.
Mar 4, 2021:
- 11:05 PM Changeset in webkit [273950] by
-
- 4 edits in trunk/Source
Add internal preference to disable HTTPS upgrade
https://bugs.webkit.org/show_bug.cgi?id=222778
Patch by Alex Christensen <achristensen@webkit.org> on 2021-03-04
Reviewed by Simon Fraser.
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Source/WTF:
This is needed for an internal performance benchmark, which serves canned content from a local http server
pretending to be from different domains that are in our internal HTTPS upgrade list because the real server
supports HTTPS. That internal benchmark should eventually change, but that's not going to happen this year.
This is also likely going to be useful for QA purposes to be able to easily tell on an internal build
whether HTTPS upgrade is breaking something.
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 9:47 PM Changeset in webkit [273949] by
-
- 3 edits in trunk/Source/WebKit
Fix clean build after r273946
https://bugs.webkit.org/show_bug.cgi?id=222706
- DerivedSources-output.xcfilelist:
- WebKit.xcodeproj/project.pbxproj:
- 9:46 PM Changeset in webkit [273948] by
-
- 3 edits in branches/safari-612.1.5-branch/Source/WebKit
Cherry-pick r273485. rdar://problem/75075088
Temporarily stop enforcing notification filtering
https://bugs.webkit.org/show_bug.cgi?id=222386
<rdar://problem/73987767>
Reviewed by Brent Fulgham.
Temporarily stop enforcing notification filtering on macOS and iOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:48 PM Changeset in webkit [273947] by
-
- 7 edits1 move in trunk/Source/WebCore
[iOS] Add legacy prefix to the form controls UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=222741
<rdar://problem/75039764>
Reviewed by Ryosuke Niwa.
Followup to r273839. Rename the iOS form controls UA stylesheet to
indicate it contains outdated styles.
- DerivedSources-input.xcfilelist:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- css/legacyFormControlsIOS.css: Renamed from Source/WebCore/css/formControlsIOS.css.
Removed redundant comment after the rename.
- style/InspectorCSSOMWrappers.cpp:
(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):
- style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):
- style/UserAgentStyle.h:
- 8:41 PM Changeset in webkit [273946] by
-
- 2 edits2 deletes in trunk/Source/WebKit
Remove the HTTPSUpgradeEnabled experimental feature
https://bugs.webkit.org/show_bug.cgi?id=222706
Reviewed by Simon Fraser.
- DerivedSources.make:
- Scripts/generate-https-upgrade-database.sh: Removed.
- Shared/HTTPSUpgrade/HTTPSUpgradeList.txt: Removed.
- 8:36 PM Changeset in webkit [273945] by
-
- 1 copy in tags/Safari-612.1.5.2.2
Tag Safari-612.1.5.2.2.
- 8:36 PM Changeset in webkit [273944] by
-
- 2 edits in trunk/Source/WebCore
Make RegistrableDomain() private constructor take the String as an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=222767
Reviewed by Alex Christensen.
Make RegistrableDomain() private constructor take the String as an rvalue reference.
Most call sites have an rvalue reference and it reduces ref counting churn this way.
- platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::uncheckedCreateFromRegistrableDomainString):
(WebCore::RegistrableDomain::uncheckedCreateFromHost):
(WebCore::RegistrableDomain::RegistrableDomain):
- 8:36 PM Changeset in webkit [273943] by
-
- 3 edits in branches/safari-612.1.5.2-branch/Source/WebKit
Cherry-pick r273485. rdar://problem/75075050
Temporarily stop enforcing notification filtering
https://bugs.webkit.org/show_bug.cgi?id=222386
<rdar://problem/73987767>
Reviewed by Brent Fulgham.
Temporarily stop enforcing notification filtering on macOS and iOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:35 PM Changeset in webkit [273942] by
-
- 8 edits in branches/safari-612.1.5.2-branch/Source
Versioning.
WebKit-7612.1.5.2.2
- 8:33 PM Changeset in webkit [273941] by
-
- 5 edits in trunk/Source/WebKit
NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains() can take domains as an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=222768
Reviewed by Geoffrey Garen.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForRegistrableDomains):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 8:17 PM Changeset in webkit [273940] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
https://bugs.webkit.org/show_bug.cgi?id=222610
Reviewed by Chris Dumez.
- inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.objc_protocol_import_expression_for_member):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):
(ObjCGenerator.protocol_to_objc_expression_for_member):
(ObjCGenerator.payload_to_objc_expression_for_member):
- 7:21 PM WebKitGTK/2.32.x edited by
- (diff)
- 6:57 PM Changeset in webkit [273939] by
-
- 4 edits in trunk/Source
[Payment Request] remove some unnecessary WebKitAdditions hooks
https://bugs.webkit.org/show_bug.cgi?id=222765
<rdar://problem/75060894>
Reviewed by Andy Estes.
Source/WebCore:
- Modules/applepay/ApplePaySession.cpp:
Source/WebKit:
- Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
- 5:50 PM Changeset in webkit [273938] by
-
- 2 edits in trunk/Source/WebCore
Deploy Ref<T> in SVGUseElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=222637
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2021-03-04
Reviewed by Ryosuke Niwa.
Remove usage of raw pointers in a few functions here
that showed issues in 222397.
Thanks to Darin Adler for the initial version of this patch
and Ryosuke Niwa for refinements.
- svg/SVGUseElement.cpp:
(WebCore::disassociateAndRemoveClones):
(WebCore::removeDisallowedElementsFromSubtree):
(WebCore::removeSymbolElementsFromSubtree):
- 5:45 PM Changeset in webkit [273937] by
-
- 1 copy in tags/Safari-611.1.21.0.4
Tag Safari-611.1.21.0.4.
- 5:44 PM Changeset in webkit [273936] by
-
- 1 copy in tags/Safari-611.1.21.1.5
Tag Safari-611.1.21.1.5.
- 5:28 PM Changeset in webkit [273935] by
-
- 11 edits in trunk/Source/WebCore
"precustomized" state of custom elements can become HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=221652
Reviewed by Darin Adler.
The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on
!isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element.
This is problematic after r266269 since that change re-purposes CustomElementState::Failed
on a custom element as "precustomized" state instead of introducing another enum value in
CustomElementState as RareDataBitFields has no more bits available.
This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that
to check whether JSHTMLUnknownElement should be created for a given element or not. Note that
HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking
a virtual function proved to incur too much runtime cost.
- dom/Node.h:
(WebCore::Node::isUnknownElement const): Added.
(WebCore::Node::isHTMLUnknownElement const): Added.
(WebCore::Node::isSVGUnknownElement const): Added.
(WebCore::Node::isMathMLUnknownElement const): Added.
(WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement.
- dom/make_names.pl:
(printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement
returns true instead of isCustomElementUpgradeCandidate returning false.
- html/HTMLElement.h:
(WebCore::HTMLElement::isHTMLUnknownElement const): Deleted.
- html/HTMLUnknownElement.h:
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument.
- mathml/MathMLElement.h:
- mathml/MathMLUnknownElement.h:
(WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement.
- svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement): Added ConstructionType as an argument.
- svg/SVGElement.h:
- svg/SVGUnknownElement.h:
(WebCore::SVGUnknownElement::SVGUnknownElement): Set NodeFlag::IsUnknownElement.
- 5:18 PM Changeset in webkit [273934] by
-
- 6 edits in trunk/Tools
Undeprecate many more webkit-patch commands
https://bugs.webkit.org/show_bug.cgi?id=222745
Patch by Sam Sneddon <Sam Sneddon> on 2021-03-04
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/tool/commands/download.py:
(ChangeStyleLocal):
- Scripts/webkitpy/tool/commands/queries.py:
(SuggestReviewers):
- Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone):
- Scripts/webkitpy/tool/commands/suggestnominations.py:
(SuggestNominations):
- Scripts/webkitpy/tool/commands/upload.py:
(Post):
(Prepare):
(MarkBugFixed):
- 4:45 PM Changeset in webkit [273933] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Some tests in imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements fail when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221697
Unreviewed test gardening.
Remove the tests which are consistently passing on bots from the test expectations.
- platform/wk2/TestExpectations:
- 4:43 PM Changeset in webkit [273932] by
-
- 2 edits in trunk/LayoutTests
Unreivewed test gardening, remove failure expectation for some tests that are consistently passing.
- platform/ios-wk2/TestExpectations:
- 4:18 PM Changeset in webkit [273931] by
-
- 17 edits1 add in trunk
Don't trust parsing information to tell us if we've emitted op_call_eval
https://bugs.webkit.org/show_bug.cgi?id=222694
rdar://74778016
Reviewed by Yusuke Suzuki.
JSTests:
- stress/eval-liveness-should-not-come-from-parser.js: Added.
(foo):
Source/JavaScriptCore:
In the DFG, op_call_eval can't be inlined. Not inlining is required for how
eval is currently implemented in the DFG. For CodeBlocks with eval in them,
the scope register is also alive everywhere.
When doing spread of arguments in eval, we end up emitting a call varargs
instead of a direct eval. This seems like a spec bug:
https://bugs.webkit.org/show_bug.cgi?id=222671
However, this leads to something that had eval textually in it leading to
us reporting the scope register is always alive, even if op_call_eval isn't
in the bytecode stream. This leads to a validation error, since the DFG
isn't actually keeping this scope register alive everywhere, because
op_call_eval isn't in the bytecode stream.
This patch fixes this by having a bit indicating if op_call_eval is in
the bytecode stream or not.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeIndex):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::usesCallEval const):
(JSC::CodeBlock::usesEval const): Deleted.
- bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::usesEval const): Deleted.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::usesCallEval const):
(JSC::UnlinkedCodeBlock::setUsesCallEval):
(JSC::UnlinkedCodeBlock::usesEval const): Deleted.
- bytecode/UnlinkedCodeBlockGenerator.h:
(JSC::UnlinkedCodeBlockGenerator::usesCallEval const):
(JSC::UnlinkedCodeBlockGenerator::setUsesCallEval):
(JSC::UnlinkedCodeBlockGenerator::usesEval const): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::isThisUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isNewTargetUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isSuperUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isSuperCallUsedInInnerArrowFunction):
- dfg/DFGGraph.h:
- runtime/CachedTypes.cpp:
(JSC::CachedCodeBlock::usesCallEval const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedCodeBlock<CodeBlockType>::encode):
(JSC::CachedCodeBlock::usesEval const): Deleted.
- runtime/CodeCache.cpp:
(JSC::generateUnlinkedCodeBlockImpl):
- runtime/EvalExecutable.h:
(JSC::EvalExecutable::executableInfo const): Deleted.
- runtime/ModuleProgramExecutable.h:
- runtime/ProgramExecutable.h:
- runtime/ScriptExecutable.h:
(JSC::ScriptExecutable::usesEval const): Deleted.
- 4:14 PM Changeset in webkit [273930] by
-
- 2 edits in trunk/Tools
Reduce unnecessary logging in ews-app
https://bugs.webkit.org/show_bug.cgi?id=222764
Reviewed by Jonathan Bedard.
- CISupport/ews-app/ews/views/retrypatch.py:
(RetryPatch.post):
- 4:12 PM Changeset in webkit [273929] by
-
- 10 edits in trunk/Source/WebKit
Validate documentState of FrameState when setting and getting it
https://bugs.webkit.org/show_bug.cgi?id=222587
Patch by Sihui Liu <sihui_liu@appe.com> on 2021-03-04
Reviewed by Geoffrey Garen.
In rdar://48634553, strings of documentState can be invalid when they are encoded in encodeFrameStateNode
in UI process. To get a better idea of when the strings become invalid, add checks for documentState when
getting and setting it.
No test as no behavior change.
- Shared/SessionState.cpp:
(WebKit::FrameState::encode const):
(WebKit::FrameState::decode):
(WebKit::FrameState::validateDocumentState const):
(WebKit::FrameState::setDocumentState):
- Shared/SessionState.h:
(WebKit::FrameState::FrameState):
(WebKit::FrameState::~FrameState):
(WebKit::FrameState::documentState const):
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
- UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(encodeFrameState):
(decodeFrameState):
- UIProcess/Cocoa/SessionStateCoding.h:
- UIProcess/LegacySessionStateCoding.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionState const):
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeFrameStateNode):
(WebKit::decodeBackForwardTreeNode):
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFrameState):
(WebKit::applyFrameState):
- 3:58 PM Changeset in webkit [273928] by
-
- 6 edits in trunk/Source/WebCore
Non-unified build fixes, early March 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=222755
Unreviewed non-unified build fixes.
- dom/EventContext.cpp:
- html/canvas/ImageBitmapRenderingContext.cpp:
- inspector/agents/worker/WorkerNetworkAgent.cpp:
- page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
- rendering/RenderModel.cpp:
- 3:46 PM Changeset in webkit [273927] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Test platform/mac/media/encrypted-media/fps-encrypted-event.html times out when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221847
Reviewed by Simon Fraser.
- platform/mac-wk2/TestExpectations: The test no longer times out. Remove expectation.
- 3:37 PM Changeset in webkit [273926] by
-
- 3 edits in trunk/Tools
Add Apple Silicon Devices to Big Sur builders and testers.
https://bugs.webkit.org/show_bug.cgi?id=222616
Reviewed by Aakash Jain.
- CISupport/build-webkit-org/config.json:
- CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 3:30 PM Changeset in webkit [273925] by
-
- 16 edits1 copy in branches/safari-612.1.5-branch
Cherry-pick r273784. rdar://problem/75059445
REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS
https://bugs.webkit.org/show_bug.cgi?id=222582
<rdar://problem/74877450>
Reviewed by Per Arne Vollan.
Source/WebKit:
Simply apply the iOS codepath to macOS.
There is also an additional change here to the Mac sandbox.
On Big Sur and earlier, before this patch, com.apple.mobileassetd was allowed,
and com.apple.mobileassetd.v2 was disallowed. After this patch, they both are
allowed, but only with the com.apple.webkit.extension.mach extension.
On other OSes, before this patch, nothing was allowed, whereas after this patch,
only com.apple.mobileassetd.v2 is allowed with the com.apple.webkit.extension.mach
extension.
Test: WebKit.MobileAssetSandboxCheck
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _grantAccessToAssetServices]): (-[WKWebView _revokeAccessToAssetServices]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _grantAccessToAssetServices]): Deleted. (-[WKWebView _revokeAccessToAssetServices]): Deleted.
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::grantAccessToAssetServices): (WebKit::WebPageProxy::revokeAccessToAssetServices):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::grantAccessToAssetServices): Deleted. (WebKit::WebPageProxy::revokeAccessToAssetServices): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::revokeAccessToAssetServices):
- WebProcess/com.apple.WebProcess.sb.in:
- WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices):
- WebProcess/playstation/WebProcessPlayStation.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices):
- WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/MobileAssetSandboxCheck.mm: Copied from Source/WebKit/WebProcess/win/WebProcessWin.cpp. (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:22 PM Changeset in webkit [273924] by
-
- 2 edits in trunk/Source/WebKit
Fix the build after r273904
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::setPreferenceValue):
auto's evilness rears its head again. -mutableCopy returnsid, so
we infer RetainPtr<id>, so depending on what headers are included
we get ambiguous selector errors. De-auto to fix.
- 3:14 PM Changeset in webkit [273923] by
-
- 3 edits in trunk/Source/WebKit
Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty
https://bugs.webkit.org/show_bug.cgi?id=222701
Reviewed by Geoffrey Garen.
Clean up API::ResourceLoadStatisticsThirdParty / API::ResourceLoadStatisticsFirstParty:
- Make constructors private since there is a create() factory function.
- Mark constructor as explicit since they take a single parameter.
- Update ResourceLoadStatisticsFirstParty constructor to take parameter as a const reference instead of passing it by value.
- Add assertions to make sure those are constructed and destroyed on the main thread.
- UIProcess/API/APIResourceLoadStatisticsFirstParty.h:
- UIProcess/API/APIResourceLoadStatisticsThirdParty.h:
- 3:06 PM Changeset in webkit [273922] by
-
- 9 edits1 copy1 add in trunk/Source/WebCore
[Payment Request] increment the current version
https://bugs.webkit.org/show_bug.cgi?id=222742
<rdar://problem/74502674>
Reviewed by Wenson Hsieh.
- Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:
(WebCore::PaymentAPIVersion::current):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodModeChange):
- Modules/paymentrequest/PaymentRequestUtilities.h: Added.
- Modules/paymentrequest/PaymentRequestUtilities.cpp: Added.
(isValidDecimalMonetaryValue):
- Modules/paymentrequest/PaymentRequest.cpp:
(isValidDecimalMonetaryValue): Deleted.
- Modules/applepay/ApplePaySession.cpp:
(convertAndValidateTotal):
(convertAndValidate):
(validateAmount): Deleted.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
Move
isValidDecimalMonetaryValueso it can be used in other files.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 3:06 PM Changeset in webkit [273921] by
-
- 5 edits4 adds in branches/safari-611.1.21.0-branch
Cherry-pick r273901. rdar://problem/75058982
window proxy of detached iframe doesn't respect updates to global values
https://bugs.webkit.org/show_bug.cgi?id=206445
Reviewed by Chris Dumez.
Source/WebCore:
According to the html spec the frame should only be needing for
COOP access violation reporting, which we don't support. This
patch removes our old behavior of blocking stores to windows that
have been detached.
I also removed some stale caching code from
getOwnPropertySlotByIndex since it's only accessed once now.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore::JSDOMWindow::doPutPropertySecurityCheck): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::putByIndex):
LayoutTests:
- fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable-eval.html: Added.
- fast/frames/iframe-detached-window-still-writable-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable.html: Added.
- http/tests/dom/cross-origin-detached-window-properties-expected.txt:
- http/tests/dom/cross-origin-detached-window-properties.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:04 PM Changeset in webkit [273920] by
-
- 5 edits4 adds in branches/safari-611.1.21.1-branch
Cherry-pick r273901. rdar://problem/75058990
window proxy of detached iframe doesn't respect updates to global values
https://bugs.webkit.org/show_bug.cgi?id=206445
Reviewed by Chris Dumez.
Source/WebCore:
According to the html spec the frame should only be needing for
COOP access violation reporting, which we don't support. This
patch removes our old behavior of blocking stores to windows that
have been detached.
I also removed some stale caching code from
getOwnPropertySlotByIndex since it's only accessed once now.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore::JSDOMWindow::doPutPropertySecurityCheck): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::putByIndex):
LayoutTests:
- fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable-eval.html: Added.
- fast/frames/iframe-detached-window-still-writable-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable.html: Added.
- http/tests/dom/cross-origin-detached-window-properties-expected.txt:
- http/tests/dom/cross-origin-detached-window-properties.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:51 PM Changeset in webkit [273919] by
-
- 2 edits in trunk/LayoutTests
Garden encrypted media tests
https://bugs.webkit.org/show_bug.cgi?id=221687
Reviewed by Simon Fraser.
- platform/mac-wk2/TestExpectations: All but platform/mac/media/encrypted-media/fps-clearkey-crash.html are now passing. Remove expectations.
- 2:16 PM Changeset in webkit [273918] by
-
- 4 edits2 adds in trunk
[LFC][IFC] LineStatus::availableWidth should always be a valid number
https://bugs.webkit.org/show_bug.cgi?id=222752
<rdar://problem/75028043>
Reviewed by Antti Koivisto.
Source/WebCore:
A NaN available width value can confuse the line breaking logic. This patch ensures we always provide a valid value.
Test: fast/inline/crash-when-negative-spacing-produce-nan.html
- layout/inlineformatting/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processInlineContent):
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):
LayoutTests:
- fast/inline/crash-when-negative-spacing-produce-nan-expected.txt: Added.
- fast/inline/crash-when-negative-spacing-produce-nan.html: Added.
- 2:05 PM Changeset in webkit [273917] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r273906.
Broke internal build
Reverted changeset:
"[Cocoa] REGRESSION(r272752): fix some internal builds that
use WTFString::WTFString(NSString *)"
https://bugs.webkit.org/show_bug.cgi?id=222610
https://commits.webkit.org/r273906
- 1:43 PM Changeset in webkit [273916] by
-
- 13 edits2 deletes in trunk/Source
Remove the HTTPSUpgradeEnabled experimental feature
https://bugs.webkit.org/show_bug.cgi?id=222706
Reviewed by Simon Fraser.
Source/WebKit:
- NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Removed.
- NetworkProcess/NetworkHTTPSUpgradeChecker.h: Removed.
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const): Deleted.
- NetworkProcess/NetworkLoadChecker.h:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
- NetworkProcess/NetworkResourceLoadParameters.h:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::networkHTTPSUpgradeChecker): Deleted.
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersShared):
Source/WTF:
It was a good experimental implementation, but the feature is now implemented in makeSecureIfNecessary
and turned on and off by WKWebViewConfiguration.upgradeKnownHostsToHTTPS.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 1:06 PM Changeset in webkit [273915] by
-
- 3 edits in trunk/Source/WebKit
[iOS] Add support for a new image-extraction-related responder action
https://bugs.webkit.org/show_bug.cgi?id=222743
<rdar://problem/75001149>
Reviewed by Devin Rousso.
Add support for the new action, such that we return
YESif and only if we're in an editable context, and also
such that we return a non-null target for the new action.
- UIProcess/ios/WKContentViewInteraction.h:
Add a fallback definition for
FOR_EACH_ADDITIONAL_WKCONTENTVIEW_ACTION, which can be used by WebKitAdditions
to inject additional responder actions when generating selector forwarding code betweenWKContentViewand
WKWebView.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
- 1:00 PM Changeset in webkit [273914] by
-
- 2 edits in trunk/LayoutTests
[GPUP] Some media tests are flaky when media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=221693
Unreviewed test gardening.
Remove the tests which are consistently passing on bots from the test expectations.
- platform/wk2/TestExpectations:
- 12:42 PM Changeset in webkit [273913] by
-
- 3 edits in trunk/Tools
[ews] Add python 3 support - part 5
https://bugs.webkit.org/show_bug.cgi?id=222744
Reviewed by Jonathan Bedard.
- CISupport/ews-build/steps.py:
(CheckPatchRelevance._patch_is_relevant): Ensure that in python 3, path and changes are bytes. This is because buildbot
stores patch as bytes, as mentioned in https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979
- CISupport/ews-build/steps_unittest.py: Updated one unit-test to test binary patch.
- 12:16 PM WebKitGTK/2.32.x edited by
- (diff)
- 12:12 PM Changeset in webkit [273912] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Persist CSS Grid overlay colors
https://bugs.webkit.org/show_bug.cgi?id=222319
<rdar://problem/74647242>
Patch by Razvan Caliman <Razvan Caliman> on 2021-03-04
Reviewed by Devin Rousso.
Save and restore CSS Grid overlay colors edited by a user.
- UserInterface/Controllers/OverlayManager.js:
(WI.OverlayManager):
(WI.OverlayManager.prototype.showGridOverlay):
(WI.OverlayManager.prototype.getGridColorForNode):
(WI.OverlayManager.prototype.setGridColorForNode):
(WI.OverlayManager.prototype._handleMainResourceDidChange):
- UserInterface/Views/CSSGridSection.js:
(WI.CSSGridSection.prototype.layout):
- 11:52 AM Changeset in webkit [273911] by
-
- 2 edits in branches/safari-611.1.21.1-branch/Source/WebCore
Cherry-pick r273842. rdar://problem/75049285
Crash under SubresourceLoader::notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=222683
<rdar://70342402>
Reviewed by Geoffrey Garen.
We were crashing doing a null-dereference of m_documentLoader under
SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader
similarly to what is already done elsewhere in ResourceLoader.
No new tests, I do not know how to reproduce this.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::notifyDone):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [273910] by
-
- 8 edits in branches/safari-611.1.21.1-branch/Source
Versioning.
WebKit-7611.1.21.1.5
- 11:46 AM Changeset in webkit [273909] by
-
- 2 edits in branches/safari-611.1.21.0-branch/Source/WebCore
Cherry-pick r273842. rdar://problem/75049263
Crash under SubresourceLoader::notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=222683
<rdar://70342402>
Reviewed by Geoffrey Garen.
We were crashing doing a null-dereference of m_documentLoader under
SubresourceLoader::notifyDone(). This adds null checks for m_documentLoader
similarly to what is already done elsewhere in ResourceLoader.
No new tests, I do not know how to reproduce this.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::notifyDone):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:44 AM Changeset in webkit [273908] by
-
- 8 edits in branches/safari-611.1.21.0-branch/Source
Versioning.
WebKit-7611.1.21.0.4
- 11:41 AM Changeset in webkit [273907] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r272629.
- UIProcess/Cocoa/WKBlankOverlayView.mm:
- 11:40 AM Changeset in webkit [273906] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
https://bugs.webkit.org/show_bug.cgi?id=222610
Reviewed by Chris Dumez.
- inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.objc_protocol_import_expression_for_member):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):
(ObjCGenerator.protocol_to_objc_expression_for_member):
(ObjCGenerator.payload_to_objc_expression_for_member):
- 11:30 AM Changeset in webkit [273905] by
-
- 3 edits3 adds in trunk
In case of POST navigation redirected by a 302, the 'Origin' header is kept in the redirected request
https://bugs.webkit.org/show_bug.cgi?id=222653
<rdar://problem/74983521>
Reviewed by Alex Christensen.
Source/WebCore:
Remove Origin header if the navigation request goes from POST to GET.
This aligns with other browsers and removes some known interop issues.
This is consistent with WebKit not sending Origin headers for GET navigations.
Test: http/wpt/fetch/navigation-post-to-get-origin.html
- loader/DocumentLoader.cpp:
(WebCore::isRedirectToGetAfterPost):
(WebCore::DocumentLoader::willSendRequest):
LayoutTests:
- http/wpt/fetch/echo-origin.py: Added.
- http/wpt/fetch/navigation-post-to-get-origin-expected.txt: Added.
- http/wpt/fetch/navigation-post-to-get-origin.html: Added.
- 11:02 AM Changeset in webkit [273904] by
-
- 11 edits in trunk
[macOS][WK2] Changing the system language does not update navigator.language
https://bugs.webkit.org/show_bug.cgi?id=222619
Reviewed by Per Arne Vollan.
Source/WebKit:
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::setAppleLanguagesPreference):
Fix a memory leak for newArguments.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
If CFPREFS_DIRECT_MODE is not enabled, we need to listen for AppleLanguagePreferencesChangedNotification
inside the WebProcess. This used to happen implicitly inside WTF::platformUserPreferredLanguages() but
it is now explicit since we don't want/need it when using CFPREFS_DIRECT_MODE.
(WebKit::setPreferenceValue):
- If preference is AppleLanguages, set it for the volatile domain to match what we do in XPCServiceMain.mm. This is needed because the preference in the volatile domain seems to take precedence.
- Call WTF::languageDidChange() when the AppleLanguages preference gets updated so that language change listeners get notified of the language change (e.g. we fire a languagechange event at the Window).
Source/WebKitLegacy/mac:
We need to listen for AppleLanguagePreferencesChangedNotification on mac WK1.
This used to happen implicitly inside WTF::platformUserPreferredLanguages() but
it is now explicit since we don't want/need it when using CFPREFS_DIRECT_MODE in WK2.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WTF:
Update WTF::languageDidChange() to clear preferredLanguages() on Cocoa platforms
so that we get updated values from the system the next time
platformUserPreferredLanguages() is called.
platformUserPreferredLanguages() used to implicitly register a AppleLanguagePreferencesChangedNotification
listener. We've now made this registering opt-in by moving it to a separate
listenForLanguageChangeNotifications() function. This function is getting called
on Mac WK1 and WK2 when CFPREFS_DIRECT_MODE is disabled (legacy).
When CFPREFS_DIRECT_MODE is enabled in WK2, we don't want/need to listen for this
notification because the AppleLanguages preference gets pushed by the UIProcess
down to the WebProcesses. Even though we could listen for this notification,
the WebProcess would not have the latest AppleLanguages preference when receiving
the notification. This would cause us to fire the languagechange event at the
Window too early and navigator.language would keep returning the old language.
For WK2 with CFPREFS_DIRECT_MODE enabled, we now explicitly call
WTF::languageDidChange() when the "AppleLanguages" preference gets sync'd from
the UIProcess instead.
- wtf/Language.cpp:
(WTF::languageDidChange):
(WTF::platformLanguageDidChange):
- wtf/Language.h:
- wtf/cf/LanguageCF.cpp:
(WTF::languagePreferencesDidChange):
(WTF::platformLanguageDidChange):
(WTF::listenForLanguageChangeNotifications):
(WTF::platformUserPreferredLanguages):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
(TEST):
- 10:41 AM Changeset in webkit [273903] by
-
- 14 edits in trunk/Source
Set ownership of IOSurfaces from the GPUProcess instead of the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=222391
Source/WebCore:
<rdar://problem/74748353>
Reviewed by Simon Fraser.
Replace use of IOSurfaceSetOwnership() SPI with IOSurfaceSetOwnershipIdentity().
Both do the same thing but IOSurfaceSetOwnershipIdentity() only requires an identity token
for the new owner (instead of a control port). As a result, IOSurfaceSetOwnershipIdentity()
requires a lot less priviledges and can now be used directly in the GPUProcess instead of
the WebProcess.
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::setOwnershipIdentity):
Source/WebCore/PAL:
<rdar://74748353>
Reviewed by Simon Fraser.
Add declaration for new IOSurfaceSetOwnershipIdentity() SPI, for the open source
SDK.
- pal/spi/cocoa/IOSurfaceSPI.h:
Source/WebKit:
<rdar://problem/74748353>
Reviewed by Simon Fraser.
Replace use of IOSurfaceSetOwnership() SPI with IOSurfaceSetOwnershipIdentity().
Both do the same thing but IOSurfaceSetOwnershipIdentity() only requires an identity token
for the new owner (instead of a control port). As a result, IOSurfaceSetOwnershipIdentity()
requires a lot less priviledges and can now be used directly in the GPUProcess instead of
the WebProcess.
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):
- GPUProcess/graphics/RemoteImageBuffer.h:
(WebKit::RemoteImageBuffer::setProcessOwnership):
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::createImageBuffer):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::prepareForDisplay):
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::setProcessOwnership):
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h:
Source/WTF:
<rdar://74748353>
Reviewed by Simon Fraser.
Add HAVE_IOSURFACE_SET_OWNERSHIP_IDENTITY feature flag to protect uses of the
new IOSurfaceSetOwnershipIdentity() SPI.
- wtf/PlatformHave.h:
- 10:28 AM Changeset in webkit [273902] by
-
- 3 edits in trunk/LayoutTests
Followup (r273764): Use different container sizes in background-svg-image-loading.html
https://bugs.webkit.org/show_bug.cgi?id=222679
Reviewed by Antti Koivisto.
This will force different SVGImageForContainers in SVGImageCache one for
each SVGImage client (<div> element in this test).
- fast/css/background-svg-image-loading-expected.html:
- fast/css/background-svg-image-loading.html:
- 10:26 AM Changeset in webkit [273901] by
-
- 5 edits4 adds in trunk
window proxy of detached iframe doesn't respect updates to global values
https://bugs.webkit.org/show_bug.cgi?id=206445
Reviewed by Chris Dumez.
Source/WebCore:
According to the html spec the frame should only be needing for
COOP access violation reporting, which we don't support. This
patch removes our old behavior of blocking stores to windows that
have been detached.
I also removed some stale caching code from
getOwnPropertySlotByIndex since it's only accessed once now.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::doPutPropertySecurityCheck):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::putByIndex):
LayoutTests:
- fast/frames/iframe-detached-window-still-writable-eval-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable-eval.html: Added.
- fast/frames/iframe-detached-window-still-writable-expected.txt: Added.
- fast/frames/iframe-detached-window-still-writable.html: Added.
- http/tests/dom/cross-origin-detached-window-properties-expected.txt:
- http/tests/dom/cross-origin-detached-window-properties.html:
- 10:19 AM Changeset in webkit [273900] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Audits Tab: nothing happens when clicking "Start" button in the content area placeholder text
https://bugs.webkit.org/show_bug.cgi?id=222740
rdar://75008042
Patch by Razvan Caliman <Razvan Caliman> on 2021-03-04
Reviewed by Devin Rousso.
- UserInterface/Views/AuditTestContentView.js:
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
- 10:10 AM Changeset in webkit [273899] by
-
- 2 edits in trunk/LayoutTests
Garden GPU Process TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=222729
Reviewed by Said Abou-Hallawa.
- gpu-process/TestExpectations: Complete filing bugs for failing tests.
Remove expectations for some tests which are now passing on the bot.
- 10:08 AM Changeset in webkit [273898] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] inspector/page/empty-or-missing-resources.html is a flakey timeout
https://bugs.webkit.org/show_bug.cgi?id=222692
Unreviewed test gardening.
- platform/mac/TestExpectations: Updating test expectations until test flakiness can be resolved.
- 10:00 AM Changeset in webkit [273897] by
-
- 14 edits in trunk
Introduce "websocket", "fetch", and "other" resource types to WKContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=222709
<rdar://problem/71552078>
Patch by Alex Christensen <achristensen@webkit.org> on 2021-03-04
Reviewed by Youenn Fablet.
Source/WebCore:
"raw" didn't give the desired granularity. This keeps support for "raw", but splits it into 3 subcategories:
"websocket" which only applies to WebSocket requests,
"fetch" which applies to XMLHTTPRequest and fetch API requests.
"other" which applies to other "raw" requests, such as beacons.
Covered by API tests.
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::validateURL):
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getTypeFlags):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::subresourcesAllowReuse const):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
- loader/ResourceLoadInfo.cpp:
(WebCore::ContentExtensions::toResourceType):
(WebCore::ContentExtensions::readResourceType):
(WebCore::ContentExtensions::readLoadType):
(WebCore::ContentExtensions::ResourceLoadInfo::getResourceFlags const):
- loader/ResourceLoadInfo.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
(TEST):
(webSocketAcceptValue):
- TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::statusText):
- 9:57 AM Changeset in webkit [273896] by
-
- 2 edits in trunk/Source/WebCore
Adjust progress parameter before calling blend() for discrete interpolations
https://bugs.webkit.org/show_bug.cgi?id=222736
Reviewed by Antti Koivisto.
In the case of discrete interpolation, we must treat progress as 0 for progress < 0.5
and 1 otherwise. Currently we do it separately in at two places. So that we don't do
it in more places, let's do this directly in CSSPropertyAnimation::blendProperties()
so that the progress is already set before any of the blend() methods are called.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::blendProperties):
- 9:55 AM Changeset in webkit [273895] by
-
- 8 edits2 deletes in trunk
[GPUProcess] MediaController is using a ClockCM
https://bugs.webkit.org/show_bug.cgi?id=222094
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Fix test failures.
- html/MediaController.cpp: Some minor clean-up.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
A minor clean-up.
Source/WebCore/PAL:
Remove
ClockCMand useClockGenericinstead becauseClockCM::currentTime()
always returns NaN when "Media in GPU Process" is enabled.
- PAL.xcodeproj/project.pbxproj:
- pal/PlatformMac.cmake:
- pal/system/mac/ClockCM.h: Removed.
- pal/system/mac/ClockCM.mm: Removed.
LayoutTests:
- platform/wk2/TestExpectations:
- 9:49 AM Changeset in webkit [273894] by
-
- 2 edits in trunk/Source/WebCore
AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unnecessarily creating a NSArray twice
https://bugs.webkit.org/show_bug.cgi?id=222732
Reviewed by Eric Carlson.
Before the patch, [m_audioSession availableInputs] was called twice.
This creates two NSArray which is not create from a memory standpoint.
There is also the risk that the two NSArrays have two different size, in which case Vector::uncheckedAppend would fail.
Cannot be easily tested, no observable change expected.
- platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices const):
- 9:49 AM Changeset in webkit [273893] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Use NO_MAIN_THREAD_WRAPPING to compile libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=222717
<rdar://problem/74988599>
Reviewed by Eric Carlson.
- Configurations/libwebrtc.xcconfig:
This prevents creating socket server in Web Process.
- 9:48 AM Changeset in webkit [273892] by
-
- 5 edits in trunk/Source/WebKit
REGRESSION (r273732): ASSERTION FAILED: Completion handler should always be called under WebKit::RemoteRealtimeMediaSourceProxy::~RemoteRealtimeMediaSourceProxy
https://bugs.webkit.org/show_bug.cgi?id=222691
<rdar://problem/75006211>
Reviewed by Eric Carlson.
Make sure to return a ApplyConstraints completed message in all cases.
Call completion handler when source gets destroyed.
Covered by existing tests.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
(WebKit::RemoteRealtimeMediaSourceProxy::~RemoteRealtimeMediaSourceProxy):
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
- WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
(WebKit::RemoteRealtimeVideoSource::gpuProcessConnectionDidClose):
- 8:44 AM Changeset in webkit [273891] by
-
- 30 edits in trunk
Update camera and microphone capture state control WKWebView API
https://bugs.webkit.org/show_bug.cgi?id=222166
Reviewed by Eric Carlson.
Source/WebCore:
Introduce the possibility to mute either camera and/or microphone capture independently.
Covered by existing tests.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):
(WebCore::MediaStreamTrack::updateToPageMutedState):
(WebCore::trackMatchesKind):
(WebCore::MediaStreamTrack::endCapture):
- Modules/mediastream/MediaStreamTrack.h:
- dom/Document.cpp:
(WebCore::Document::stopMediaCapture):
- dom/Document.h:
- page/MediaProducer.h:
- page/Page.cpp:
(WebCore::Page::stopMediaCapture):
- page/Page.h:
Source/WebKit:
Introduce KVO states for microphone and camera capture states.
Add two APIs to set microphone and camera state.
This allows to mute/unmute or stop microphone or camera state.
We needed to introduce muting of either microphone or camera since this was tied together before the patch.
These two APIs take a completion handler.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _cameraCaptureState]):
(-[WKWebView _microphoneCaptureState]):
(-[WKWebView setMicrophoneCaptureState:completionHandler:]):
(-[WKWebView setCameraCaptureState:completionHandler:]):
(-[WKWebView _stopMediaCapture]):
(-[WKWebView _mediaCaptureState]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/MediaUtilities.h:
- UIProcess/Cocoa/MediaUtilities.mm:
(WebKit::toWKMediaCaptureStateDeprecated):
(WebKit::toWKMediaCaptureState): Deleted.
- UIProcess/Cocoa/PageClientImplCocoa.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::microphoneCaptureChanged):
(WebKit::PageClientImplCocoa::cameraCaptureChanged):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::mediaCaptureStateDidChange):
- UIProcess/PageClient.h:
(WebKit::PageClient::microphoneCaptureChanged):
(WebKit::PageClient::cameraCaptureChanged):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::~UserMediaPermissionRequestManagerProxy):
(WebKit::UserMediaPermissionRequestManagerProxy::stopCapture):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMuted):
(WebKit::WebPageProxy::stopMediaCapture):
(WebKit::WebPageProxy::updateReportedMediaCaptureState):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setMuted):
(WebKit::WebPageProxy::stopMediaCapture):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_lastNavigationWasAppBound):
(WebKit::WebPage::setMuted):
(WebKit::WebPage::stopMediaCapture):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Updaed according renaming of _WKMediaCaptureState in _WKMediaCaptureStateDeprecated.
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::wkMediaCaptureStateString):
(TestWebKitAPI::waitUntilCaptureState):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
(-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
- TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
(-[SpeechRecognitionUIDelegate _webView:mediaCaptureStateDidChange:]):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::isDoingMediaCapture const):
- 8:32 AM Changeset in webkit [273890] by
-
- 3 edits2 adds in trunk
Handle the case of synchronous failure in loading blob.
https://bugs.webkit.org/show_bug.cgi?id=222724
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Test: http/tests/fetch/blob-in-unload-event-handler.html
- fileapi/Blob.cpp:
(WebCore::Blob::stream):
In case of synchronous failure, wait for the stream to be started to error it.
LayoutTests:
- http/tests/fetch/blob-in-unload-event-handler-expected.txt: Added.
- http/tests/fetch/blob-in-unload-event-handler.html: Added.
- 8:26 AM Changeset in webkit [273889] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] LineBox::m_rootInlineBox does not need to be a UniqueRef
https://bugs.webkit.org/show_bug.cgi?id=222705
Reviewed by Antti Koivisto.
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::m_rootInlineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::logicalRectForRootInlineBox const):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox):
- 6:23 AM Changeset in webkit [273888] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] InlineContentBuilder::createDisplayNonRootInlineBoxes should check if the line has inline boxes at all
https://bugs.webkit.org/show_bug.cgi?id=222707
Reviewed by Antti Koivisto.
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):
- 6:22 AM Changeset in webkit [273887] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] Make LineBox::m_inlineLevelBoxRectMap a non-root inline level box map
https://bugs.webkit.org/show_bug.cgi?id=222704
Reviewed by Antti Koivisto.
Let's not trigger hash lookup for the most common inlineLevelBoxForLayoutBox() call (when we lookup the root inline box
as the parent of a text content).
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::addInlineLevelBox):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineLevelBoxForLayoutBox):
- 5:53 AM Changeset in webkit [273886] by
-
- 3 edits2 adds in trunk
Null check platformData when decoding
https://bugs.webkit.org/show_bug.cgi?id=221442
Patch by Rob Buis <rbuis@igalia.com> on 2021-03-04
Reviewed by Ryosuke Niwa.
Source/WebKit:
Null check platformData when decoding.
Test: ipc/pasteboard-write-custom-data.html
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<PasteboardCustomData::Entry>::decode):
LayoutTests:
Add test for this.
- ipc/pasteboard-write-custom-data-expected.txt: Added.
- ipc/pasteboard-write-custom-data.html: Added.
- 5:22 AM Changeset in webkit [273885] by
-
- 12 edits2 adds in trunk/Source/WebCore
[Nicosia] Move shared scrolling animation code into a ScrollingTreeScrollingNodeDelegate
https://bugs.webkit.org/show_bug.cgi?id=222714
Patch by Martin Robinson <mrobinson@igalia.com> on 2021-03-04
Reviewed by Žan Doberšek.
No new tests. This should not change behavior.
- PlatformMac.cmake: Remove delegate parent class from Mac-specific list.
- PlatformPlayStation.cmake: Added new class to source list.
- Sources.txt: Added delegate parent class to shared source list.
- SourcesGTK.txt: Added new class.
- SourcesWPE.txt: Ditto.
- WebCore.xcodeproj/project.pbxproj: Remove source file from project, since
it is now in Sources.txt.
- page/scrolling/ScrollingTreeScrollingNodeDelegate.cpp: Changed import to include.
- page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
Moved shared code to ScrollingTreeScrollingNodeDelegate.
- page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h: Ditto.
- page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp: Ditto.
- page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h: Dito.
- page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp: Added
shared code from ScrollingTreeFrameScrollingNodeNicosia and ScrollingTreeOverflowScrollingNodeNicosia
- page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.h: Added.
- 5:18 AM Changeset in webkit [273884] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r273644 ): [GStreamer] new webrtc failures
https://bugs.webkit.org/show_bug.cgi?id=222649
Patch by Philippe Normand <pnormand@igalia.com> on 2021-03-04
Reviewed by Xabier Rodriguez-Calvar.
Since the mediastreamsrc element maintains static source pads, it now needs to remove pads
left unused resulting from a track removal.
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcRemovePad):
(webkitMediaStreamSrcRemoveTrackByType):
- 5:01 AM Changeset in webkit [273883] by
-
- 2 edits in trunk/Tools
Detect unrecognized options in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=221186
Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2021-03-04
Reviewed by Keith Miller.
run-javascriptcore-tests saves unrecognized arguments to pass
through to build-jsc even when --no-build is used. However, when
we're not building, nothing will ever use or look at the extra
arguments. This means that those arguments are silently eaten
up and, consequently, typos in option names can go undetected.
Change the script to fail when --no-build has been passed and
there are unrecognized options.
- Scripts/run-javascriptcore-tests:
- 3:26 AM Changeset in webkit [273882] by
-
- 20 edits in trunk
initial value for border-image-outset should be 0
https://bugs.webkit.org/show_bug.cgi?id=222721
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Pass one extra WPT test.
- web-platform-tests/css/css-backgrounds/inheritance.sub-expected.txt:
- web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
Source/WebCore:
The initial value for border-image-outset was a Length with Fixed type (0px)
instead of Relative type (0).
- rendering/style/NinePieceImage.h:
- style/StyleBuilderCustom.h:
(WebCore::Style::ApplyPropertyBorderImageModifier::applyInitialValue):
LayoutTests:
Update some tests to make the correct assumption on the border-image-ouset initial value.
- css3/calc/reflection-computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-border-image-expected.txt:
- fast/css/getComputedStyle/computed-style-border-image.html:
- fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
- fast/reflections/reflection-computed-style-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/ios/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- 1:39 AM Changeset in webkit [273881] by
-
- 3 edits3 adds in trunk
FileReader::enqueueTask should validate that its context is not stopped before executing the task
https://bugs.webkit.org/show_bug.cgi?id=222472
Source/WebCore:
Reviewed by Alex Christensen.
The event loop might run tasks even though active dom objects are stopped.
Protect from this by adding a check since m_state checks are not sufficient.
A follow-up patch should probably try to neuter FileReader if it is stopped.
Covered by http/wpt/filereader/filereader-stop.html.
- fileapi/FileReader.cpp:
(WebCore::FileReader::fireEvent):
(WebCore::FileReader::enqueueTask):
LayoutTests:
<rdar://problem/74753571>
Reviewed by Alex Christensen.
- http/wpt/filereader/filereader-stop.html: Added.
- 1:39 AM Changeset in webkit [273880] by
-
- 3 edits in trunk/Source/WebCore
Make the data backing generated global AtomString values accessible
https://bugs.webkit.org/show_bug.cgi?id=222552
Reviewed by Darin Adler.
Modify name header generation script to make the const string data public.
No new tests because there is no behavior change.
- bindings/scripts/StaticString.pm:
(GenerateStrings):
- dom/make_names.pl:
- 1:32 AM Changeset in webkit [273879] by
-
- 4 edits4 adds in trunk
Can not read blobs in sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=170075
<rdar://problem/31282427>
Reviewed by Alex Christensen.
Source/WebCore:
In case of blob with an opaque origin, get the document that created the blob and use the document for mixed content check.
Further refactoring should be done once specs are updated to clarify this.
See https://github.com/w3c/webappsec-mixed-content/issues/41 for more information.
Tests: http/wpt/fetch/blob-of-opaque-origin-iframe.html
http/wpt/fetch/blob-of-opaque-origin-worker.html
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::isMixedContent):
LayoutTests:
- http/wpt/fetch/blob-of-opaque-origin-iframe-expected.txt: Added.
- http/wpt/fetch/blob-of-opaque-origin-iframe.html: Added.
- http/wpt/fetch/blob-of-opaque-origin-worker-expected.txt: Added.
- http/wpt/fetch/blob-of-opaque-origin-worker.html: Added.
- platform/win/TestExpectations:
- 1:09 AM Changeset in webkit [273878] by
-
- 7 edits in trunk/Source/WebKit
IPC stream feature should use client/server naming instead of sender/receiver
https://bugs.webkit.org/show_bug.cgi?id=222592
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-03-04
Reviewed by Antti Koivisto.
Attempt to simplify already complicated implementation of the stream
implementation. Uses of "sender" and "receiver" were a leftover from
early phase of the implementation.
Rename all remaining instances of "sender" with "client".
Rename all remaining instances of "receiver" with "server".
No new tests, a refactor.
- Platform/IPC/StreamClientConnection.cpp:
(IPC::StreamClientConnection::StreamClientConnection):
(IPC::StreamClientConnection::setWakeUpSemaphore):
(IPC::StreamClientConnection::wakeUpServer):
- Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::send):
(IPC::StreamClientConnection::trySendDestinationIDIfNeeded):
(IPC::StreamClientConnection::tryAcquire):
(IPC::StreamClientConnection::release):
- Platform/IPC/StreamConnectionBuffer.cpp:
(IPC::StreamConnectionBuffer::StreamConnectionBuffer):
(IPC::StreamConnectionBuffer::operator=):
(IPC::StreamConnectionBuffer::encode const):
- Platform/IPC/StreamConnectionBuffer.h:
(IPC::StreamConnectionBuffer::clientOffset):
(IPC::StreamConnectionBuffer::serverOffset):
(IPC::StreamConnectionBuffer::clientWaitSemaphore):
(IPC::StreamConnectionBuffer::maximumSize):
- Platform/IPC/StreamServerConnection.cpp:
(IPC::StreamServerConnectionBase::tryAquire):
(IPC::StreamServerConnectionBase::release):
- Platform/IPC/StreamServerConnection.h:
(IPC::StreamServerConnectionBase::sharedClientOffset):
(IPC::StreamServerConnectionBase::sharedServerOffset):
- 1:00 AM Changeset in webkit [273877] by
-
- 24 edits in trunk
Adding new test conditions for WebGL should be simpler
https://bugs.webkit.org/show_bug.cgi?id=222593
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-03-04
Reviewed by Kenneth Russell.
Source/WebCore:
Replace Internals functions:
Internals.setFailNextGPUStatusCheck()
Internals.simulateContextChanged()
with
Internals.simulateEventForWebGLContext(SimulatedWebGLContextEvent, WebGLRenderingContext)
Most envisioned test simulation environment triggers do not need parameters. It is simpler
to implement the triggers from one call site.
No new tests, a refactor.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::simulateEventForTesting):
- html/canvas/WebGLRenderingContextBase.h:
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::simulateEventForTesting):
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::simulateEventForTesting):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- testing/Internals.h:
- testing/Internals.idl:
Implement the feature by replacing
Internals.setFailNextGPUStatusCheck()
Internals.simulateContextChanged()
with
Internals.simulateEventForWebGLContext(SimulatedWebGLContextEvent, WebGLRenderingContext)
with eventName taking invented events that can happen to a
webgl context:
"GPUStatusFailure" and "ContextChange".
Future commits will add at least "Timeout".
The Internals function name was chosen not to contain "ForTesting" suffix, as
all the functions in the class should have that suffix.
The function names in the implementation path for the feature contains
"ForTesting" in order to highlight the feature not being in the normal
path.
Source/WebKit:
Replace simulateContextChanged and
setFailNextGPUStatusCheck with simulateEventForTesting.
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::simulateEventForTesting):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
Tools:
Add SimulateEventForTesting(String eventName) to manually
implemented RemoteGraphicsContextGL functions.
Use manually generated function because next commit for
timeout implementation will add some logic to RemoteGraphicsContextGL
while forwarding rest of the events to the underlying GraphicsContextGL.
- Scripts/generate-gpup-webgl:
LayoutTests:
- fast/canvas/webgl/webglcontextchangedevent.html:
Replace internals.simulateContextChanged(context) with
internals.simulateEventForWebGLContext("ContextChange", context)
- fast/canvas/webgl/lose-context-on-status-failure.html:
Similarly replace internals.setFailNextGPUStatusCheck(context) with
internals.simulateEventForWebGLContext("GPUStatusFailure", context).
- 12:48 AM Changeset in webkit [273876] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: contentSize >= 0 in WefbCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=222711
Unreviewed test gardening.
- TestExpectations: Adding a test that is ASSERTing in Debug builds since it was imported.
