Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 6, 2002:

6:27 PM Changeset in webkit [1103] by sullivan

• 8 edits in trunk/WebKit

Some improvements to the bookmark changed notifications.

• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendChangeNotificationForBookmark:childrenChanged:]): (-[IFBookmarkGroup _setTopBookmark:]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): Send bookmark that changed and whether its children changed as part of change notifications, so clients can choose to do less unnecessary work.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): Check for the no-change case and bail out without sending notification when you find it.

Fixed 2919147 (Organize Bookmarks menu item doesn't do anything).

First check-in of Bookmarks window. You can remove one or more bookmarks,
and you can edit the title & address of existing bookmarks, but that's all
so far. Removed the Erase All Bookmarks item from the Debug menu since you
can do it easily from the Bookmarks window now. Added keyboard equivalents
for the Bookmarks, History, and Activity Viewer windows in the style of
Mail. Also miscellaneous cleanups.

• BookmarksController.h: Added.
• BookmarksController.m: Added. (-[BookmarksController shouldCascadeWindows]): (-[BookmarksController _receivedBookmarksChangedNotification:]): (-[BookmarksController _setUpToolbar]): (-[BookmarksController windowDidLoad]): (-[BookmarksController dealloc]): (-[BookmarksController _removeAllBookmarks]): (-[BookmarksController _removeSelectedBookmarks:]): (-[BookmarksController outlineView:child:ofItem:]): (-[BookmarksController outlineView:isItemExpandable:]): (-[BookmarksController outlineView:numberOfChildrenOfItem:]): (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): (-[BookmarksController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BookmarksController toolbarAllowedItemIdentifiers:]): (-[BookmarksController toolbarDefaultItemIdentifiers:]): (-[BookmarksController toolbarDidRemoveItem:]): (-[BookmarksController toolbarWillAddItem:]): (-[BookmarksController validateUserInterfaceItem:]): New class that manages the Bookmarks window.

• AppController.h:
• AppController.m: (-[AppController dealloc]): release bookmarks controller. (-[AppController showBookmarks:]): create bookmarks controller if necessary, and tell it to show its window.

• BrowserWindow.m: Changed static strings to #defines. (-[BrowserWindow setUpToolbar]): Remove call that explicitly sets toolbar display mode; we've no reason to override the default.

• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove Erase All Bookmarks.

• English.lproj/Bookmarks.nib: New nib file for Bookmarks window.

• English.lproj/MainMenu.nib: Wired up "Organize Bookmarks..." and "Bookmarks" menu items; added keyboard shortcuts for Window menu items.

• GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Changed two isEquals to isEqualToStrings. (-[GlobalHistory _anyURLsSelected]): Replaced anyDatesSelected with this. (-[GlobalHistory updateButtons]): Allow Add to Bookmarks to be enabled even if some dates are selected; just ignore them (at least one non-date has to be selected). (-[GlobalHistory addSelectedItemsToBookmarks:]): Removed obsolete comment.

• Resources/Images/delete.tiff: New image, stolen for mail, used in Bookmarks window.

• WebBrowser.pbproj/project.pbxproj: Updated for new files.

4:40 PM Changeset in webkit [1102] by darin

• 55 edits
  3 adds in trunk

i * Makefile.am: Generate the PFE precompiled headers to be used

by automake compiles. Currently these don't have any dependency
tracking, but I'm sure Maciej can fix that if he wants to.

• configure.in: Go from "xNDEBUG" to "NDEBUG" now that precompiled headers aren't in the way. Pass in the --load-pch option to all the various compiles so they get the precompiled headers.

• Tests/libiftest/Makefile.am: Generate a top_srcdir.h file rather than passing it in on the command line. This works around a PFE bug with -D, Radar 2921026.
• Tests/libiftest/IFTestDirectory.c: Use top_srcdir.h.
• Tests/libiftest/.cvsignore: Ignore top_srcdir.h.

• Tests/qt/qpoint-test.cpp: (main): Take out an unused variable and all the USING_BORROWED_QPOINT code.

• Tools/Makefile.am: Don't built the HotSpots directory for now, since it runs into a PFE bug and we usually use the application version now.

• Tools/Scripts/check-non-ASCII: Skip preprocessor directives.
• Tools/Scripts/cvs-abandon: Tweak.

JavaScriptCore:

• JavaScriptCorePrefix.h: Added.
• JavaScriptCore.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

WebFoundation:

Reviewed by Ken Kocienda:

• WebFoundationPrefix.h: Added.
• WebFoundation.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

• AuthenticationManager.subproj/IFAuthenticationManager.m:
• CookieManager.subproj/IFCookie.m:
• Misc.subproj/IFNSStringExtensions.m:
• Misc.subproj/WebFoundationDebug.m: Add undefs to work around PFE problem with inline functions, Radar 2920554.

• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: Fix include to work with normal Project Builder way of dealing with frameworks. Switch from xNDEBUG to NDEBUG.

• CacheLoader.subproj/IFURLLoad.m:
• CookieManager.subproj/IFCookie.m:
• Database.subproj/IFURLFileDatabase.m:
• Misc.subproj/IFError.m:
• Misc.subproj/IFMonitor.h:
• Misc.subproj/IFMonitor.m:
• Misc.subproj/IFRecursiveReadWriteLock.h: Use import instead of include.

• Misc.subproj/IFCFNetworkExtensions.m: Added.
• Misc.subproj/IFCFRunLoopExtensions.m: Added.
• Misc.subproj/IFCFNetworkExtensions.c: Removed.
• Misc.subproj/IFCFRunLoopExtensions.c: Removed. Renamed so we could share the Objective-C precompile. No need to compile this code as plain C, even though it doesn't use any Objective-C features.

• Misc.subproj/WebFoundationDebug.h: Get rid of format attribute because of bug

2920557. Switch from xNDEBUG to NDEBUG.

WebCore:

• WebCorePrefix.h: Added.

• .cvsignore: Ignore the .pfe files in this directory.

• khtml/dom/dom_doc.cpp:
• khtml/dom/dom_text.cpp: Added namespace directives as a clean workaround for a conflict with the struct named Comment in <Carbon/AIFF.h>

• kwq/KWQFont.mm:
• kwq/KWQFontMetrics.mm:
• kwq/KWQKGlobal.mm:
• kwq/KWQListImpl.mm:
• kwq/KWQPtrDictImpl.h:
• kwq/KWQVectorImpl.mm:
• kwq/kwqdebug.h:
• kwq/qt/qcolor.h:
• kwq/qt/qcombobox.h:
• kwq/qt/qregion.h:
• kwq/qt/qstring.h:
• kwq/qt/qwidget.h: Remove old workaround for conflicts with Fixed, Rect, and Boolean. It does not good with a precompiled header anyway, and there is a more elegant small fix in the KDE code itself.

• kwq/qt/qpoint.h:
• kwq/KWQPointArray.mm: (QPointArray::setPoints): Work around bug with va_arg and PFE by not using varargs here.

• kwq/KWQRect.mm: (QRect::unite): (QRect::operator&): Use std::min and std::max instead of defining our own MIN and MAX, which conflict with something in one of the headers we are precompiling (error message did not make it clear which).

• kwq/KWQView.mm: (-[KWQHTMLView layout]), (-[KWQHTMLView drawRect:]): Switch from xNDEBUG to NDEBUG.

• kwq/Makefile.am: Remove stuff for getting at the header inside the ApplicationServices and QD frameworks, since that code is now in WebKit.

• kwq/kwqdebug.h: Get rid of format attribute because of bug 2920557. Switch from xNDEBUG to NDEBUG.

• kwq/kwqdebug.mm: Switch from xNDEBUG to NDEBUG.

• kwq/qt/qstring.h: Define QT_VERSION in here instead of on the command line to work around a PFE bug with -D, Radar 2921026.

WebKit:

• WebKitPrefix.h: Added.
• WebKit.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

• Misc.subproj/WebKitDebug.h: Get rid of format attribute because of bug

2920557. Switch from xNDEBUG to NDEBUG.

• Misc.subproj/WebKitDebug.m: Add undef to work around PFE problem with inline functions, Radar 2920554.

• Plugins.subproj/IFPluginView.mm: Changed how we work around the bug in the CGS defines.

• WebCoreSupport.subproj/IFCachedTextRenderer.h: Change include of the private QD header to use the form that works with more-normal way of getting at the private bits of frameworks.

• WebCoreSupport.subproj/IFCachedTextRenderer.m: Use the header <CoreGraphics/CoreGraphicsPrivate.h> instead of <CoreGraphics/CGFontPrivate.h>.

• Misc.subproj/IFCache.mm:
• WebView.subproj/IFLoadProgress.mm:
• WebView.subproj/IFWebFrame.mm:
• WebView.subproj/IFWebFramePrivate.mm:
• WebView.subproj/IFWebView.mm: Changed includes to imports.

WebBrowser:

• WebBrowserPrefix.h: Added.
• WebBrowser.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

• Debug/CacheController.m: Renamed to make it Objective C rather than Objective C++.
• Debug/CacheController.mm: Removed.

• main.m: Use the real CFA2UC. Use import instead of include.
• _CFA2UC.c: Remove our copy.

• Debug/DOMTree.mm:
• Debug/RenderTree.mm:
• Preferences.subproj/ActiveContentPreferences.h:
• Preferences.subproj/AppearancePreferences.h:
• Preferences.subproj/GeneralPreferences.h:
• Preferences.subproj/SecurityPreferences.h:
• Preferences.subproj/TextPreferences.h:
• Preferences.subproj/WBPreferences.h:
• Test/PageLoadTestLogger.m: Use import instead of include.

4:14 PM Changeset in webkit [1101] by cblu

• 8 edits in trunk/WebKit

Made start and stop work cleaner.

Now observe defaults changes so that plug-ins
are disabled or enabled immediately (2871725).

• Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]):
• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView start]): (-[IFPluginView stop]): (-[IFPluginView drawRect:]): (-[IFPluginView windowWillClose:]): (-[IFPluginView defaultsHaveChanged:]):

3:56 PM Changeset in webkit [1100] by rjw

• 3 edits in trunk/WebKit

Fixed width measurement regression. We lost the final ROUND_TO_INT
in the width measurement funtion after the move from WebCore.

1:49 PM Changeset in webkit [1099] by rjw

• 19 edits in trunk

Changes to support dhmtl.
Changes to support targeting (regression after 3.0 merge).

9:31 AM Changeset in webkit [1098] by sullivan

• 3 edits in trunk/WebKit

• Resources/url_icon.tiff: New bookmarks/history icon, looks more like the springy @ sign as seen from above, less like text.

May 3, 2002:

5:27 PM Changeset in webkit [1097] by darin

• 6 edits in trunk/WebCore

• khtml/css/cssstyleselector.cpp:
• khtml/dom/css_value.cpp:
• khtml/xml/dom_stringimpl.cpp: Put in some namespace-related statements to more-elegantly work around the conflicts between Macintosh and khtml identifiers.

4:05 PM Changeset in webkit [1096] by sullivan

• 17 edits in trunk/WebKit

Along with small corresponding WebBrowser change,
fixed 2919172 (Bookmarks aren't saved between sessions).

• Bookmarks.subproj/IFBookmark_Private.h: Declarations for new private methods.
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark _numberOfDescendants]): New private method, counts deep; used only for debugging messages at this time. (-[IFBookmark _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmark _dictionaryRepresentation]): New private methods used to save/load bookmarks. Stub implementations; subclasses must implement.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf _dictionaryRepresentation]): New methods.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList _dictionaryRepresentation]): (-[IFBookmarkList _numberOfDescendants]): New methods. (-[IFBookmarkList _setGroup:]): Recurse on children.

• Bookmarks.subproj/IFBookmarkGroup.h: New _loading instance variable.

• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _setTopBookmark:]): Renamed from _resetTopBookmark, now has potentially non-nil argument. (-[IFBookmarkGroup initWithFile:]), (-[IFBookmarkGroup removeBookmark:]): Updated for name change. (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): Don't send notifications while loading bookmarks from disk. (-[IFBookmarkGroup _loadBookmarkGroupGuts]), (-[IFBookmarkGroup loadBookmarkGroup]), (-[IFBookmarkGroup _saveBookmarkGroupGuts]), (-[IFBookmarkGroup saveBookmarkGroup]): New methods, load/save bookmarks and report timings.

• History.subproj/IFURIEntry.m: (-[IFURIEntry dictionaryRepresentation]), (-[IFURIEntry initFromDictionaryRepresentation:]): Handle nil URL case, which bookmarks run into.

• WebKit.pbproj/project.pbxproj: version wars

• AppController.m: (-[AppController applicationWillTerminate:]): Save bookmarks at quit time.

• WebBrowser.pbproj/project.pbxproj: version wars

2:52 PM Changeset in webkit [1095] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/IFCachedTextRenderer.m: Remove some of the unused code. I was going to wait and let Richard do it next week, but I was unable to control my urge to hack on it.

12:03 PM Changeset in webkit [1094] by darin

• 3 edits in trunk/WebKit

• Resources/url_icon.tiff: Improved icon. Could be better.

11:42 AM Changeset in webkit [1093] by darin

• 1 edit in trunk/WebKit/Resources/url_icon.tiff

Revert icon, oops.

11:36 AM Changeset in webkit [1092] by darin

• 26 edits
  8 adds
  5 deletes in trunk

WebCore:

• kwq/IFTextRenderer.h: Added.
• kwq/IFTextRendererFactory.h: Added.
• kwq/IFTextRendererFactory.m: Added. These three are the new API for supplying text rendering machinery for WebCore. The implementation is in WebKit. Later we might want to flesh out the default implementation in WebCore so that it works OK by itself.

• khtml/rendering/font.cpp: (Font::width): Function is now "width" without an underscore. We don't really need to hide the overload we added in this case.

• kwq/qt/qfont.h: Simplify a lot. Doesn't hold an NSFont any more.
• kwq/KWQFont.mm: (QFont::QFont): Eliminated the concept of "default font". Also, a QFont no longer holds an NSFont object. That's handled inside IFTextRenderer machinery. (QFont::~QFont): Simplify since we don't have an NSFont. (QFont::setFamily): Simplify since we don't have an NSFont. (QFont::setPixelSize): Simplify since we don't have an NSFont. (QFont::setPixelSizeFloat): Simplify since we don't have an NSFont. (QFont::setWeight): Simplify since we don't have an NSFont. (QFont::weight): Fix a bug where it would return Normal for a QFont that was both bold and italic. (QFont::setItalic): Simplify since we don't have an NSFont. (QFont::italic): Simplify since we have real "bool". (QFont::bold): Simplify since we have real "bool". (QFont::operator=): Simplify since we don't have an NSFont. (QFont::operator==): Rewrite since we don't have an NSFont.

• kwq/qt/qfontmetrics.h: Simplify a little. The _width() method is now just an overload of the width() method. The main change was removing the include of Cocoa.h.
• kwq/KWQFontMetrics.mm: Move most of the code out of here into WebKit. (QFontMetrics::ascent): Get it from the renderer. (QFontMetrics::descent): Get it from the renderer. (QFontMetrics::lineSpacing): Get it from the renderer. (QFontMetrics::width): Get it from the renderer. (QFontMetrics::boundingRect): Combine width and height that came from the renderer. (QFontMetrics::size): Combine width and height that came from the renderer.

• kwq/Makefile.am: Add IFTextRendererFactory.m, remove KWQTextStorage.mm and KWQTextContainer.mm.
• kwq/KWQMetrics.h: Removed.
• kwq/KWQTextContainer.h: Removed.
• kwq/KWQTextContainer.mm: Removed.
• kwq/KWQTextStorage.h: Removed.
• kwq/KWQTextStorage.mm: Removed.

• kwq/KWQPainter.mm: Move most of the code out of here into WebKit. (QPainter::drawText): Call the renderer to do it. (QPainter::drawUnderlineForText): Call the renderer to do it.

• libwebcore.exp: Export the IFTextRendererFactory class.

WebKit:

• Misc.subproj/WebKitDebug.h: Add WEBKIT_LOG_MEMUSAGE, WEBKIT_LOG_FONTCACHE, and WEBKIT_LOG_FONTCACHECHARMISS for font code moved here from WebCore.

• Resources/url_icon.tiff: New URL icon?

• WebCoreSupport.subproj/IFCachedTextRenderer.h: Added.
• WebCoreSupport.subproj/IFCachedTextRenderer.m: Added.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Added.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Added. This has code moved here from WebCore.

• WebKit.pbproj/project.pbxproj: Add the new source files.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setURLString:]): Use copy instead of initWithString.
• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initWithTitle:image:group:]): Use copy instead of stringWithString. (-[IFBookmarkList setTitle:]): Use copy instead of stringWithString.
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use mutableCopy instead of stringWithString.
• WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Use copy instead of stringWithString.

11:07 AM Changeset in webkit [1091] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebDatabase.m

• AuthenticationManager.subproj/IFAuthenticationRequest.m: (-[IFAuthenticationRequest initWithURL:realm:username:passwordSentInClear:previousFailures:callback:]):
• AuthenticationManager.subproj/IFAuthenticationResult.m: (-[IFAuthenticationResult initWithUsername:password:]):
• Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Simplify code by using [copy] instead of [NSString initWithString:].

May 2, 2002:

4:57 PM Changeset in webkit [1090] by sullivan

• 17 edits
  2 adds in trunk/WebKit

• Bookmarks.subproj/IFBookmark.h:
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark setTitle:]): (-[IFBookmark setImage:]): (-[IFBookmark setURLString:]): (-[IFBookmark insertChild:atIndex:]): (-[IFBookmark removeChild:]): (-[IFBookmark _parent]): (-[IFBookmark _group]):
• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]):
• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): (-[IFBookmarkLeaf setImage:]): (-[IFBookmarkLeaf setURLString:]):
• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList setTitle:]): (-[IFBookmarkList setImage:]): (-[IFBookmarkList removeChild:]): (-[IFBookmarkList insertChild:atIndex:]):
• Bookmarks.subproj/IFBookmark_Private.h: Made _parent and _group private; made setTitle, setImage, setURLString, insertChild:atIndex:, and removeChild: public.

• Bookmarks.subproj/IFBookmarkGroup_Private.h: Added.
• WebKit.pbproj/project.pbxproj: Changed for new file.

3:31 PM Changeset in webkit [1089] by sullivan

• 4 edits in trunk/WebKit

Implemented removing the root node bookmark (i.e.,
removing all bookmarks with one call).

• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): New method, releases old topBookmark and creates new one. (-[IFBookmarkGroup initWithFile:]): Call _resetTopBookmark. (-[IFBookmarkGroup removeBookmark:]): If the bookmark being removed is the top one, call _resetTopBookmark.

Added "Erase All Bookmarks" menu item to Debug menu, which will be
handy in the interim between making bookmarks persistent and making
them organizable (they are neither yet).

Along the way, made DebugUtilities be a shared instance instead of
a collection of class methods, to make some innards easier to
implement.

• Debug/DebugUtilities.h: new class method sharedDebugUtilities; changed other class methods to instance methods; made _debugMenu an instance variable.

• Debug/DebugUtilities.m: (-[DebugUtilities dealloc]): release _debugMenu. (+[DebugUtilities sharedDebugUtilities]): New method. (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]): (-[DebugUtilities pathForDebugBookmarks]): (-[DebugUtilities loadDebugBookmarks]): (-[DebugUtilities conditionallyDisplayPageLoadTestWindow]): Changed class methods to instance methods. Also updated private AppController method name that had changed, causing the debug bookmarks to become disabled with my last checkin. (-[DebugUtilities eraseAllBookmarks:]): New method. (-[DebugUtilities createDebugMenu]): Add "Erase All Bookmarks" menu item, with -eraseAllBookmarks as callback.

• AppController.m: (-[AppController awakeFromNib]): use sharedDebugUtilities where a class method used to work.

12:53 PM Changeset in webkit [1088] by sullivan

• 18 edits in trunk/WebKit

Some more implementation of bookmarks code, enough to support
adding bookmarks to the Bookmarks menu (but not yet enough to
support persistent bookmarks).

• Bookmarks.subproj/IFBookmark_Private.h:
• Bookmarks.subproj/IFBookmark.h:
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark numberOfChildren]): New public method, stub implementation. (-[IFBookmark _removeChild:]): New private method, stub implementation.

• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup updateBookmark:title:image:URLString:]): Changed "URL" to "URLString" in several places, added a "with" to some parameter names; added addNewBookmarkToBookmark public method; added notification that's sent when bookmarks are added or removed.

• Bookmarks.subproj/IFBookmarkLeaf.h:
• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initWithURLString:title:image:group:]): Added image parameter.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList numberOfChildren]): New method. (-[IFBookmarkList _removeChild:]): Implemented.

Fixed 2917086 (Add Bookmark is not yet implemented). You
can now add bookmarks to the Bookmarks menu, and they work.
However, they aren't yet persistent, and there's only a flat
list that you can't yet reorder.

• AppController.h: Added instance variables for bookmarks stuff; added +standardBookmarks method.

• AppController.m: (-[AppController awakeFromNib]): Move history notification setup from here to -webHistory; added call to _updateBookmarksInMenu, and FIXME about doing this lazily eventually. (-[AppController dealloc]): release bookmarks. (-[AppController webHistory]): Moved history notification setup to here. (-[AppController menuTitleForURL:withTitle:]): Improved assert.

(-[AppController _setUpStringTruncator]):
(-[AppController _historyFilePath]):
(-[AppController _receivedHistoryChangedNotification:]):
(-[AppController _insertHistoryEntry:intoMenu:atIndex:]):
(-[AppController _insertItemsForDate:intoMenu:atIndex:withRunningTotal:limit:]):
(-[AppController _insertSubmenu:forDate:atIndex:]):
(-[AppController _takeLocationFromHistoryEntry:]):
(-[AppController _addHistoryToMenu]):
(-[AppController _updateHistoryInMenu]):
Added leading underscores to private methods, updated callers.

(-[AppController _standardBookmarksFilePath]):
(-[AppController _removeBookmarksFromMenu]):
(-[AppController _takeLocationFromBookmark:]):
(-[AppController _insertBookmark:intoMenu:atIndex:]):
(-[AppController _addBookmarksToMenu]):
(-[AppController _updateBookmarksInMenu]):
(-[AppController _receivedBookmarksChangedNotification:]):
(-[AppController standardBookmarks]): New methods.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument addBookmark:]): New method; accessed from menu item. (-[BrowserDocument validateUserInterfaceItem:]): Enable Add Bookmark menu item only when there's a currentURL.

• English.lproj/MainMenu.nib: Wire up some bookmark-related stuff.

• WebBrowser.pbproj/project.pbxproj: Version wars?

Apr 30, 2002:

4:50 PM Changeset in webkit [1087] by sullivan

• 3 edits
  19 adds in trunk/WebKit

Fixed silly bug Darin noticed by inspection where I was
doing string == @"" instead of [string length] == 0.

• BrowserWindow.m: (-[BrowserWindow setStatus:]):

Added initial set of files/API and some of the code for
bookmarks support. Nobody calls it yet, but it compiles.
I wanted to get this in before I ran into project file
merge conflicts.

• Bookmarks.subproj/IFBookmark.h: Added.
• Bookmarks.subproj/IFBookmark_Private.h: Added.
• Bookmarks.subproj/IFBookmark.m: Added. (-[IFBookmark dealloc]): (-[IFBookmark title]): (-[IFBookmark _setTitle:]): (-[IFBookmark image]): (-[IFBookmark _setImage:]): (-[IFBookmark isLeaf]): (-[IFBookmark URLString]): (-[IFBookmark _setURLString:]): (-[IFBookmark children]): (-[IFBookmark _insertChild:atIndex:]): (-[IFBookmark parent]): (-[IFBookmark _setParent:]): (-[IFBookmark group]): (-[IFBookmark _setGroup:]):
• Bookmarks.subproj/IFBookmarkGroup.h: Added.
• Bookmarks.subproj/IFBookmarkGroup.m: Added. (+[IFBookmarkGroup bookmarkGroupWithFile:]): (-[IFBookmarkGroup initWithFile:]): (-[IFBookmarkGroup dealloc]): (-[IFBookmarkGroup topBookmark]): (-[IFBookmarkGroup insertBookmark:atIndex:ofBookmark:]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:title:image:URL:isLeaf:]): (-[IFBookmarkGroup updateBookmark:title:image:URL:]): (-[IFBookmarkGroup file]): (-[IFBookmarkGroup loadBookmarkGroup]): (-[IFBookmarkGroup saveBookmarkGroup]):
• Bookmarks.subproj/IFBookmarkLeaf.h: Added.
• Bookmarks.subproj/IFBookmarkLeaf.m: Added. (-[IFBookmarkLeaf dealloc]): (-[IFBookmarkLeaf title]): (-[IFBookmarkLeaf _setTitle:]): (-[IFBookmarkLeaf image]): (-[IFBookmarkLeaf _setImage:]): (-[IFBookmarkLeaf isLeaf]): (-[IFBookmarkLeaf URLString]): (-[IFBookmarkLeaf _setURLString:]):
• Bookmarks.subproj/IFBookmarkList.h: Added.
• Bookmarks.subproj/IFBookmarkList.m: Added. (-[IFBookmarkList initWithTitle:image:group:]): (-[IFBookmarkList dealloc]): (-[IFBookmarkList title]): (-[IFBookmarkList _setTitle:]): (-[IFBookmarkList image]): (-[IFBookmarkList _setImage:]): (-[IFBookmarkList isLeaf]): (-[IFBookmarkList children]): (-[IFBookmarkList _insertChild:atIndex:]):

• WebKit.pbproj/project.pbxproj: Updated for new files.

Apr 29, 2002:

4:34 PM Changeset in webkit [1086]

• 8 copies in tags/Alexander-2

This commit was manufactured by cvs2svn to create tag 'Alexander-2'.

4:34 PM Changeset in webkit [1085] by rjw

• 4 edits in trunk/WebKit

Fix to 2915688. I wasn't checking if the main document error had an error, only
the resource errors.

10:06 AM Changeset in webkit [1084] by rjw

• 3 edits in trunk/WebKit

Restored file, line, and function to log messages.

Apr 26, 2002:

12:23 PM Changeset in webkit [1083] by darin

• 6 edits in trunk/WebCore

• kwq/make-mac-encodings.c: (main): One more place that needed a workaround for Radar 2912404 (kCFStringEncodingInvalidId is negative even though CFStringEncoding is unsigned).

• kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Do this ourselves so we don't rely on WebFoundation.
• kwq/Makefile.am: Don't do a -I for WebFoundation.

10:11 AM Changeset in webkit [1082] by darin

• 12 edits
  16 adds in trunk/WebCore

Check in some old changes from my TiBook so I can trash the source tree.

Pay no attention to the man who is not supposed to be working.

• Tools/Scripts/find-unused-symbols: Added. Only partly done.
• configure.in: Some small tweaks.

WebCore:

Pay no attention to the man who is not supposed to be working.

• khtml/Makefile.am:
• khtml/css/Makefile.am:
• khtml/ecma/Makefile.am:
• khtml/html/Makefile.am:
• khtml/java/Makefile.am:
• khtml/misc/Makefile.am:
• khtml/rendering/Makefile.am:
• khtml/xml/Makefile.am: Don't generate empty .moc files or khtmldata.h; there's no reason not to just check them in instead. Also tweak a few build rules to use automatic make variables.

• khtml/ecma/kjs_window.moc: Added.
• khtml/html/html_documentimpl.moc: Added.
• khtml/html/htmltokenizer.moc: Added.
• khtml/java/kjavaapplet.moc: Added.
• khtml/java/kjavaappletcontext.moc: Added.
• khtml/java/kjavaappletserver.moc: Added.
• khtml/java/kjavaappletwidget.moc: Added.
• khtml/java/kjavadownloader.moc: Added.
• khtml/java/kjavaprocess.moc: Added.
• khtml/khtmlview.moc: Added.
• khtml/misc/khtmldata.h: Added.
• khtml/rendering/render_form.moc: Added.
• khtml/rendering/render_frames.moc: Added.
• khtml/rendering/render_replaced.moc: Added.
• khtml/xml/dom_docimpl.moc: Added.
• khtml/xml/xml_tokenizer.moc: Added.

• kwq/kwqdebug.mm: Make some globals private.

Apr 25, 2002:

11:37 PM Changeset in webkit [1081] by mjs

• 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

WebFoundation:

Reviewed by: Darin Adler

Changes to authentication to allow the IFAuthenticationHandler
protocol to be asynchronous, so it's cancellable and suitable for
use by sheets. Fixes the following Radar bugs:

2874727 - IFAuthenticationHandler protocol is unsuitable for
clients that want to prompt using a sheet
2874730 - IFAuthenticationHandler protocol does not allow for cancellation
2876170 - Authentication handling blocks a loader thread indefinitely

In addition there is a lot of assorted code cleanup.

• AuthenticationManager.subproj/IFAuthenticationHandler.h:
• AuthenticationManager.subproj/IFAuthenticationHandlerDispatcher.h:
• AuthenticationManager.subproj/IFAuthenticationHandlerDispatcher.m: (-[IFAuthenticationDispatchState dealloc]): (dispatchStartAuthentication): (dispatchCancelAuthentication): (dispatchAuthenticationDone): (dispatchAuthenticationHandlerBusy): (-[IFAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[IFAuthenticationHandlerDispatcher IFAuthenticationRequest:authenticationDone:]): (-[IFAuthenticationHandlerDispatcher IFAuthenticationRequestAuthenticationHandlerBusy:]): (-[IFAuthenticationHandlerDispatcher _dispatchCancelAuthentication:]): (-[IFAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[IFAuthenticationHandlerDispatcher _dispatchAuthenticationHandlerBusy:]): (-[IFAuthenticationHandlerDispatcher initWithAuthenticationHandler:]): (-[IFAuthenticationHandlerDispatcher dealloc]): (-[IFAuthenticationHandlerDispatcher hasHandler:]): (-[IFAuthenticationHandlerDispatcher startAuthentication:]): (-[IFAuthenticationHandlerDispatcher cancelAuthentication:]):
• AuthenticationManager.subproj/IFAuthenticationManager.m: (-[IFAuthenticationRequestState initWithHandlersCopy:index:httpRequest:authenticationRequest:callback:context:]): (-[IFAuthenticationRequestState dealloc]): (-[IFAuthenticationManagerPrivate init]): (-[IFAuthenticationManagerPrivate dealloc]): (-[IFAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[IFAuthenticationManager _tryRequest:]): (-[IFAuthenticationManager IFAuthenticationRequest:authenticationDone:]): (-[IFAuthenticationManager _addCredentialsToInitialHTTPRequest:]): (-[IFAuthenticationManager _addCredentialsToRetryHTTPRequest:afterFailureResponse:withCallback:context:]): (-[IFAuthenticationManager _cancelAddCredentialsToRetryHTTPRequest:]):
• AuthenticationManager.subproj/IFAuthenticationManagerCallback.h:
• AuthenticationManager.subproj/IFAuthenticationRequest.m: (-[IFAuthenticationRequest _authenticationHandlerBusy]): (-[IFAuthenticationRequest authenticationDone:]):
• AuthenticationManager.subproj/IFAuthenticationRequestPrivate.h:
• WebFoundation.pbproj/project.pbxproj: Added new files to the build.

• Misc.subproj/IFCFRunLoopExtensions.h, Misc.subproj/IFCFRunLoopExtensions.c: Added. (IFCallFromCFRunLoop): New convenience wrapper for a one-shot run loop callback. (IFCallFromRunLoopCFRunLoopTimerCallBack): Helper function for the above. (IFCallFromCFRunLoopContextRetain): Likewise. (IFCallFromCFRunLoopContextRelease): Likewise. (IFCallFromCFRunLoopContextCopyDescription): Likewise.

• Misc.subproj/IFNSDictionaryExtensions.h,Misc.subproj/IFNSDictionaryExtensions.m: (-[NSMutableDictionary _IF_setObject:forUncopiedKey:]): New helper function to put things in dictionaries without copying the key.

WebBrowser:

• AuthenticationHandler.h, AuthenticationHandler.m: Changed to conform to new improved IFAuthenticationHandler protocol.

(-[AuthenticationHandler init]):
(-[AuthenticationHandler readyToStartAuthentication:]):
(-[AuthenticationHandler startAuthentication:]):
(-[AuthenticationHandler cancelAuthentication:]):
(-[AuthenticationHandler showAuthenticationPanel]):

• WebBrowser.pbproj/project.pbxproj: I touched it.

6:55 PM Changeset in webkit [1080] by darin

• 15 edits in trunk/WebKit

• History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate _loadHistoryGuts:]): Use NSDictionary instead of NSObject to avoid a cast.

• WebView.subproj/IFLocationChangeHandler.h: Add NSObject as a required protocol so we can retain and release.
• WebView.subproj/IFWebController.h: Add NSObject as a required protocol so we can retain and release.

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): (-[IFWebDataSource _setLoading:]): (-[IFWebDataSource _setController:]): (-[IFWebDataSource _setLocationChangeHandler:]):
• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Removed NSObject * casts that were used to work around the problem fixed above.

6:54 PM Changeset in webkit [1079] by darin

• 5 edits in trunk/WebCore

• kwq/KWQMetrics.h: Add NSObject to required protocols for the KWQLayoutFragment protocol so we can retain and release.

• kwq/KWQTextStorage.mm: (-[KWQTextStorage _buildFragmentForString:]): Removed a cast to NSObject * that worked around the lack of the above.

5:30 PM Changeset in webkit [1078] by cblu

• 9 edits in trunk/WebKit

• MIME.subproj/IFDownloadHandler.h:
• MIME.subproj/IFDownloadHandler.mm: (+[IFDownloadHandler launchURL:]):

Added the above method as a way to universally launch an URL
within WebKit

• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController URLPolicyForURL:]):

We handle http, https and file URL's

• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource initWithURL:]): (-[IFWebDataSource startLoading:]):

The IFURLHandle is now lazilly allocated.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):

We only load a data source if the URL policy is IFURLPolicyUseContentPolicy

5:01 PM Changeset in webkit [1077] by rjw

• 27 edits in trunk

Fixed problem with errors potentially being reported on
wrong data source by moving collected errors from frame
to datasource.

Little changes in preparation for events.

2:50 PM Changeset in webkit [1076] by darin

• 6 edits in trunk/WebCore

Add a workaround for Radar 2912404 (kCFStringEncodingInvalidId is negative even
though CFStringEncoding is unsigned)

• kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName): (KWQCFStringEncodingFromMIB):
• kwq/KWQtextcodec.mm: (QTextCodec::codecForMib): (QTextCodec::codecForName):
• kwq/make-charset-table.pl: Add casts to (CFStringEncoding) wherever we use kCFStringEncodingInvalidId.

11:05 AM Changeset in webkit [1075] by darin

• 23 edits in trunk

WebCore:

Rework plugin code to prepare to move more of it into WebKit.

• khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): Create a widget for the applet using the new simpler API.

• kwq/kdecore/kconfig.h:
• kwq/KWQKConfigBase.mm: Eliminate KConfigBase. Set things up so we are poised to handle the other non-plugin config keys easily in the future.

• kwq/KWQKHTMLPart.mm: (KHTMLPart::requestObject): Use the new simpler IFPluginWidgetCreate API instead of the older WCPluginWidget one.

• kwq/qt/qstring.h: Add simpler conversions to/from NSString.
• kwq/KWQString.mm: (QString::fromNSString): New.

• kwq/WCPluginWidget.h: Made this API simpler both for the C++ side and the Objective-C side. There's now no class, and only one function that needs to be supplied (normally by WebKit).
• kwq/WCJavaAppletWidget.h: Same thing for the Java case.

• kwq/WCJavaAppletWidget.mm: (IFSetJavaAppletViewCreationFunction): New. (IFJavaAppletWidgetCreate): New. Most of the code that was in here is now moved into WebKit.
• kwq/WCPluginWidget.mm: (IFSetPluginViewCreationFunction): New. (IFPluginWidgetCreate): New. Most of the code that was in here is now moved into WebKit.

• libwebcore.exp: Update for new function names.

WebKit:

Rework plugin code to prepare to move more of here from WebCore.

• Plugins.subproj/IFPluginView.mm: (IFPluginViewCreate): New. Does all the work of creating an NSView for a plug-in, including stuff previously done in WebCore. (IFJavaAppletViewCreate): Same as above, for Java applets. (+[IFPluginView load]): Set up the function pointers using the new improved WebCore API.

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView load]): Remove this setup because now there's no separate call to set up a null plug-in.

9:45 AM Changeset in webkit [1074] by sullivan

• 4 edits in trunk/WebKit

Fixed 2911915 (Exception in -[IFWebView mouseMoved])

• WebView.subproj/IFWebView.mm: (-[IFWebView mouseDown:]): Changed "mouseUp" to "mouseDown" in exception message.

(-[IFWebView mouseMoved:]): Removed bogus event-type checking
that caused this method to (always?) throw an exception when
invoked.

Apr 24, 2002:

6:15 PM Changeset in webkit [1073] by cblu

• 18 edits in trunk

Renamed [IFWebDataSource frame] to [IFWebDataSource webFrame]

Labyrinth/WebBrowser/ChangeLog
Labyrinth/WebBrowser/FrameProgressEntry.m
Labyrinth/WebBrowser/IFWebFrameAdditions.m
Labyrinth/WebBrowser/LoadProgressMonitor.m
Labyrinth/WebBrowser/LocationChangeHandler.m
Labyrinth/WebBrowser/WebController.m
Labyrinth/WebBrowser/WebBrowser.pbproj/project.pbxproj
Labyrinth/WebCore/ChangeLog
Labyrinth/WebCore/kwq/KWQKHTMLPart.mm
Labyrinth/WebCore/kwq/external.h Labyrinth/WebKit/ChangeLog
Labyrinth/WebKit/WebKit.pbproj/project.pbxproj
Labyrinth/WebKit/WebView.subproj/IFBaseWebControllerPrivate.mm
Labyrinth/WebKit/WebView.subproj/IFMainURLHandleClient.mm
Labyrinth/WebKit/WebView.subproj/IFWebDataSource.h
Labyrinth/WebKit/WebView.subproj/IFWebDataSource.mm
Labyrinth/WebKit/WebView.subproj/IFWebDataSourcePrivate.mm

4:02 PM Changeset in webkit [1072] by rjw

• 7 edits in trunk/WebKit

Changed ordering of messages so activity viewer doesn't get -1 bytesSoFar
for cancelled messages.

3:47 PM Changeset in webkit [1071]

• 8 copies in tags/Alexander-1

This commit was manufactured by cvs2svn to create tag 'Alexander-1'.

3:47 PM Changeset in webkit [1070] by sheridan

• 8 edits in trunk

added release markers to the changelogs
"Alexander 0.3c2 (v1)"

9:49 AM Changeset in webkit [1069] by darin

• 13 edits
  1 delete in trunk/WebCore

Get rid of all NEED_BOGUS_XXX.

• khtml/java/Makefile.am: Remove -DNEED_BOGUS_TEXTSTREAMS and -DNEED_BOGUS_X_DEFINES.
• khtml/rendering/Makefile.am: Remove -DNEED_BOGUS_X_DEFINES.
• khtml/xml/Makefile.am: Remove -DNEED_BOGUS_TEXTSTREAMS.
• kwq/Makefile.am: Remove -DNEED_BOGUS_X_DEFINES and KWQKJavaEmbed.mm.
• kwq/KWQKJavaEmbed.mm: Removed.

• kwq/KWQDef.h: Remove XEvent define (inside NEED_BOGUS_X_DEFINES).

• kwq/qt/qtextstream.h: Don't look at NEED_BOGUS_TEXTSTREAMS.
• kwq/KWQtextstream.mm: Don't look at NEED_BOGUS_TEXTSTREAMS.

• khtml/java/javaembed.h: Made this just a QWidget typedef for now.
• khtml/java/kjavaappletwidget.cpp: ifdef out the unused setWindow function.

Apr 23, 2002:

3:43 PM Changeset in webkit [1068] by darin

• 8 edits in trunk/WebCore

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat):
• khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Remove our 72/96 dpi changes. They weren't doing much good. But this doesn't fix all the 72/96 dpi issues. It's just the start.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: Remove some unused stuff: charset(), setCharset(), availableFamilies(), fontSizes(), SCREEN_RESOLUTION.

3:25 PM Changeset in webkit [1067] by cblu

• 9 edits in trunk/WebKit

WebKit:

• WebKit.pbproj/project.pbxproj:

Took IFDownloadHandler.h out of the public headers.

• WebView.subproj/IFLocationChangeHandler.h:

Removed deprecated methods.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):

Don't call locationChangeStarted anymore.

WebBrowser:

• LocationChangeHandler.m:

Removed locationChangeStarted and downloadingWithHandler as they are
deprecated.

2:00 PM Changeset in webkit [1066] by cblu

• 12 edits
  1 add
  3 deletes in trunk/WebKit

• MIME.subproj/IFDownloadHandler.h:
• MIME.subproj/IFDownloadHandler.m: Removed.
• MIME.subproj/IFDownloadHandler.mm: Added. (-[IFDownloadHandler initWithDataSource:]): (-[IFDownloadHandler dealloc]):
• MIME.subproj/IFDownloadHandlerPrivate.h: Removed.
• MIME.subproj/IFDownloadHandlerPrivate.m: Removed.

Made IFDownloadHandler a private class that retains the data source
and saves the data to disk.

• WebKit.pbproj/project.pbxproj:

Removed IFDownloadHandlerPrivate

• WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):

Only send locationChangeCommitted if its shown inline.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):

Save data with IFDownloadHandler

(-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

If its a download, set the provisionalDataSource on the frame to nil.

• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource webFrame]): (-[IFWebDataSource pageTitle]): (-[IFWebDataSource contentPolicy]):

Added some accessor methods. Spelling fix pageTitle.

11:39 AM Changeset in webkit [1065] by kocienda

• 9 edits in trunk

2002-04-23 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fix for Radar 2908403 (Fix names in WebFoundation extensions code)

Extensions code in WebFoundation now is in its own namespace.
Where we have added categories to existing Foundation and AppKit
classes, the categories begin with the IF prefix. All method names
begin with the _IF_ prefix.

The files here were changed to use the new names.

In addition, private methods on publicly WebFoundation classes
now have an underscopre prepended to their names.

• Tests/CookieManager/wkcookiemanager-test.m: (main)
• Tests/WebFoundation-Misc/ifnsarrayextensions-test.m: (main)
• Tests/WebFoundation-Misc/ifnscalendardateextensions-test.m: (main)
• Tests/WebFoundation-Misc/ifnsobjectextensions-test.m: (main)
• Tests/WebFoundation-Misc/ifnsstringextensions-test.m: (main)
• Tests/WebFoundation-Misc/ifnsthreadextensions-test.m: (-[ThreadTest run:]): (main)
• Tools/HotSpots/hotspots.m: (ProcessLine) (SortByValueInDictionary): (DumpTables) (PrintCallGraphForFrame):
• Tools/wftool/main.m: (main)

• WebCore/kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs])

• WebBrowser/AppController.m: (-[AppController _addHistoryToMenu])
• WebBrowser/BrowserWindow.m: (-[BrowserWindow controlTextDidEndEditing:])
• WebBrowser/GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]) (-[GlobalHistory expandToday])

• WebFoundation/AuthenticationManager.subproj/IFAuthenticationHandlerDispatcher.m: (-[IFAuthenticationHandlerDispatcher checkIfReadyToStartAuthentication:]):
• WebFoundation/AuthenticationManager.subproj/IFAuthenticationManager.m: (-[IFAuthenticationManager removeAuthenticationHandler:]): (IFNSURLRemoveAnythingAfterPath): (IFNSURLCanonicalRoot): (AddAuthenticationHeader): (-[IFAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[IFAuthenticationManager _tryRequest:]): (-[IFAuthenticationManager _retryWaitingRequests]): (-[IFAuthenticationManager IFAuthenticationRequest:authenticationDone:]): (-[IFAuthenticationManager _addCredentialsToInitialHTTPRequest:]): (-[IFAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[IFAuthenticationManager _addCredentialsToRetryHTTPRequest:afterFailureResponse:withCallback:context:]): (-[IFAuthenticationManager _cancelAddCredentialsToRetryHTTPRequest:]):
• WebFoundation/AuthenticationManager.subproj/IFAuthenticationManagerPrivate.h:
• WebFoundation/AuthenticationManager.subproj/IFAuthenticationRequest.m: (-[IFAuthenticationRequest _readyToStartAuthenticationDone:]):
• WebFoundation/AuthenticationManager.subproj/IFAuthenticationRequestPrivate.h:
• WebFoundation/CacheLoader.subproj/IFFileURLHandle.m: (+[IFFileURLHandle canInitWithURL:]): (-[IFFileURLHandle contentLength]):
• WebFoundation/CacheLoader.subproj/IFFileURLProtocolHandler.m: (+[IFFileURLProtocolHandler canInitWithURL:]):
• WebFoundation/CacheLoader.subproj/IFHTTPURLHandle.m: (+[IFHTTPURLHandle canInitWithURL:]): (-[IFHTTPURLHandle setResponseHeaders:]):
• WebFoundation/CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canInitWithURL:]): (-[IFHTTPURLProtocolHandler endLoadInBackground]): (-[IFHTTPURLProtocolHandler dealloc]): (-[IFHTTPURLProtocolHandler requestURL]): (-[IFHTTPURLProtocolHandler addIfModifiedSinceHeader:]): (-[IFHTTPURLProtocolHandler addCookieHeaders:]): (-[IFHTTPURLProtocolHandler addAuthenticationHeaders:andCall:]): (-[IFHTTPURLProtocolHandler addRequestMessageBody:]): (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:]): (-[IFHTTPURLProtocolHandler setRedirectedURL:]): (-[IFHTTPURLProtocolHandler cacheObjectIsValid:]): (-[IFHTTPURLProtocolHandler cacheObjectRequiresRevalidation:]): (-[IFHTTPURLProtocolHandler shouldCacheResourceData]): (-[IFHTTPURLProtocolHandler parseCacheControlAttributes:]):
• WebFoundation/CacheLoader.subproj/IFURLHandle.m: (_sendCallbacks): (-[IFURLHandleInstanceVariables initWithHandle:]): (-[IFURLHandle cancelLoadInBackground]): (+[IFURLHandle initialize]): (-[IFURLHandle _submittedAttributes]): (-[IFURLHandle _setAttribute:forKey:]): (-[IFURLHandle _setContentLength:]): (-[IFURLHandle _loadType]): (-[IFURLHandle _backgroundLoadDidBegin]): (-[IFURLHandle _backgroundLoadDidBegin:]): (-[IFURLHandle _didLoadData:]): (-[IFURLHandle _backgroundLoadComplete]): (-[IFURLHandle _backgroundLoadFailedWithResultCode:]): (-[IFURLHandle _didRedirectToURL:]): (+[IFURLHandle _registerDefaults]): (-[IFURLHandle _cacheable]): (-[IFURLHandle _setCacheable:]): (-[IFURLHandle _setStatusCode:]): (-[IFURLHandle _setResultCode:]): (-[IFURLHandle _setFinalURL:]): (-[IFURLHandle _postCallback:]): (-[IFURLHandle _sendCallbacks]): (-[IFURLHandle _notifyClientsDidBeginLoading]): (-[IFURLHandle _notifyClientsDidCancelLoading]): (-[IFURLHandle _notifyClientsDataDidBecomeAvailable]): (-[IFURLHandle _notifyClientsDidFinishLoading]): (-[IFURLHandle _notifyClientsDidFailLoading]): (-[IFURLHandle _notifyClientsDidRedirectToURL]):
• WebFoundation/CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadDidBegin): (IFURLHandleBackgroundLoadComplete): (IFURLHandleBackgroundLoadFailedWithResultCode): (IFURLHandleDidRedirectToURL):
• WebFoundation/CacheLoader.subproj/IFURLHandlePrivate.h:
• WebFoundation/CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad doubleAttributeForKey:]): (-[IFURLLoad updateHandles]): (-[IFURLLoad succeeded]): (-[IFURLLoad failedWithResultCode:]): (+[IFURLLoad initialize]): (-[IFURLLoad didBeginLoading:]):
• WebFoundation/CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager initWithDefaultStack]): (-[IFURLLoadManager requestWithURLHandle:]): (-[IFURLLoadManager _syncCachesNotification:]):
• WebFoundation/CookieManager.subproj/IFCookie.m: (setDefaultsFromOriginURL): (setDomain): (-[IFCookie _cookieToV0HeaderSegment]): (+[IFCookie requestHeadersFromCookieArray:]): (+[IFCookie cookieWithV0Spec:forURL:]): (+[IFCookie cookieArrayFromResponseHeaders:forURL:]): (-[IFCookie compareForHeaderOrder:]):
• WebFoundation/CookieManager.subproj/IFCookieManager.m: (-[IFCookieManager cookieRequestHeadersForURL:]): (-[IFCookieManager _cookieRequestHeadersForURL:withExtraCookies:]): (-[IFCookieManager description]):
• WebFoundation/CookieManager.subproj/IFCookieManagerPrivate.h:
• WebFoundation/Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase removeAllObjects]): (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase open]):
• WebFoundation/Misc.subproj/IFMultipartForm.m: (-[IFMultipartForm encodeMultipartForm]):
• WebFoundation/Misc.subproj/IFNSArrayExtensions.h:
• WebFoundation/Misc.subproj/IFNSArrayExtensions.m: (-[NSArray _IF_mappedArrayWithSelector:]): (-[NSArray _IF_mappedArrayWithFunction:context:]): (-[NSArray _IF_filteredArrayWithSelector:]): (-[NSArray _IF_arrayByRemovingIfSelector:]): (-[NSArray _IF_filteredArrayWithSelector:withObject:]): (-[NSArray _IF_doesEveryElementSatisfyPredicate:]): (-[NSArray _IF_indexOfObjectSatisfyingPredicate:withObject:]): (-[NSArray _IF_encodeWWWFormURLData]):
• WebFoundation/Misc.subproj/IFNSCalendarDateExtensions.h:
• WebFoundation/Misc.subproj/IFNSCalendarDateExtensions.m: (-[NSCalendarDate _IF_compareDay:]): (-[NSCalendarDate _IF_isToday]):
• WebFoundation/Misc.subproj/IFNSDictionaryExtensions.h:
• WebFoundation/Misc.subproj/IFNSDictionaryExtensions.m: (-[NSDictionary _IF_doubleForKey:]): (-[NSDictionary _IF_floatForKey:]): (-[NSDictionary _IF_unsignedLongForKey:]): (-[NSDictionary _IF_longForKey:]): (-[NSDictionary _IF_unsignedIntForKey:]): (-[NSDictionary _IF_intForKey:]): (-[NSDictionary _IF_unsignedShortForKey:]): (-[NSDictionary _IF_shortForKey:]): (-[NSDictionary _IF_boolForKey:]): (-[NSDictionary _IF_encodeWWWFormURLData]): (-[NSMutableDictionary _IF_setDouble:forKey:]): (-[NSMutableDictionary _IF_setFloat:forKey:]): (-[NSMutableDictionary _IF_setUnsignedLong:forKey:]): (-[NSMutableDictionary _IF_setLong:forKey:]): (-[NSMutableDictionary _IF_setUnsignedInt:forKey:]): (-[NSMutableDictionary _IF_setInt:forKey:]): (-[NSMutableDictionary _IF_setUnsignedShort:forKey:]): (-[NSMutableDictionary _IF_setShort:forKey:]): (-[NSMutableDictionary _IF_setBool:forKey:]):
• WebFoundation/Misc.subproj/IFNSFileManagerExtensions.h:
• WebFoundation/Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _IF_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]): (-[NSFileManager _IF_createIntermediateDirectoriesForPath:attributes:]): (-[NSFileManager _IF_fileExistsAtPath:isDirectory:traverseLink:]): (-[NSFileManager _performRemoveFileAtPath:]): (-[NSFileManager _IF_backgroundRemoveFileAtPath:]):
• WebFoundation/Misc.subproj/IFNSMutableDataExtensions.h:
• WebFoundation/Misc.subproj/IFNSMutableDataExtensions.m: (-[NSMutableData _IF_appendFormat:]): (-[NSMutableData _IF_appendEncodedString:format:arguments:]): (-[NSMutableData _IF_appendEncodedString:format:]):
• WebFoundation/Misc.subproj/IFNSObjectExtensions.h:
• WebFoundation/Misc.subproj/IFNSObjectExtensions.m: (-[NSObject _IF_performBooleanSelector:]): (-[NSObject _IF_performBooleanSelector:withObject:]): (-[NSObject _IF_encodeWWWFormURLData]):
• WebFoundation/Misc.subproj/IFNSStringExtensions.h:
• WebFoundation/Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_isCaseInsensitiveEqualToString:]): (-[NSString _IF_hasCaseInsensitiveSuffix:]): (-[NSString _IF_countOfString:]): (-[NSString _IF_looksLikeDomainName]): (-[NSString _IF_looksLikeIPAddress]): (-[NSString _IF_domainMatches:]): (-[NSString _IF_splitAtNonDateCommas]): (-[NSString _IF_parseAsKeyValuePair]): (-[NSString _IF_parseAsKeyValuePairHandleQuotes:]): (-[NSString _IF_stringByTrimmingWhitespace]): (-[NSString _IF_hasSubstring:atIndex:]): (-[NSString _IF_encodeStringBase64]): (-[NSString _IF_encodeWWWFormURLData]): (-[NSString _IF_encodeWWWFormURLData:]): (-[NSString _IF_mimeTypeFromContentTypeHeader]): (-[NSString _IF_characterSetFromContentTypeHeader]):
• WebFoundation/Misc.subproj/IFNSThreadExtensions.h:
• WebFoundation/Misc.subproj/IFNSThreadExtensions.m: (+[NSThread _joinableThreadBody:]): (+[NSThread _IF_createJoinableThreadWithSelector:toTarget:withObject:]): (+[NSThread _IF_joinThread:]): (+[NSThread _IF_sleep:]):
• WebFoundation/Misc.subproj/IFNSURLExtensions.h:
• WebFoundation/Misc.subproj/IFNSURLExtensions.m: (+[NSURL _IF_URLWithScheme:user:password:host:port:path:parameter:query:fragment:]):

• WebKit/History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate findIndex:forDay:]): (-[IFWebHistoryPrivate arrayRepresentation]): (-[IFWebHistoryPrivate _loadHistoryGuts:]):

8:49 AM Changeset in webkit [1064] by kocienda

• 4 edits in trunk/WebCore

2002-04-23 Kenneth Kocienda <​kocienda@apple.com>

• kwq/KWQPixmap.mm: (QPixmap::QPixmap): Fixed unneeded leak of an NSImage in the case where we are still covering for a double-release bug in AppKit. No need to add insult to injury. :)

Apr 22, 2002:

6:37 PM Changeset in webkit [1063] by darin

• 4 edits in trunk/WebCore

Fix width of non-breaking spaces. There's code to hack this
at the KDE level for fonts that don't have non-breaking space
characters, but we need it even for fonts that do.

Not sure why this worked better on Puma, but now it's fine on
both Puma and Jaguar.

• kwq/KWQFontMetrics.mm: (ConvertCharactersToGlyphs): New. Turns non-breaking spaces into normal spaces if needed. (-[KWQLayoutInfo drawString:atPoint:withFont:color:]), (-[KWQLayoutInfo _initializeCaches]), (_rectForString): Change to call ConvertCharactersToGlyphs instead of ATSUConvertCharToGlyphs.

6:08 PM Changeset in webkit [1062] by cblu

• 7 edits in trunk/WebKit

WebFoundation:

• Misc.subproj/IFError.h:
• Misc.subproj/IFError.m: (+[IFError initialize]):

Removed old WebKit errors, added IFCantShowMIMEType.

WebKit:

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

Send an IFError when we're asked to show content we can't handle.

• WebView.subproj/IFWebDataSourcePrivate.mm:

Cleaning

WebBrowser:

• LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]):

Cleaned this up a little.

5:09 PM Changeset in webkit [1061] by cblu

• 8 edits in trunk/WebKit

WebBrowser:

• LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]):

A nil type means that this is a file URL.

WebKit:

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm:

Fixed frames which I broke in the previous commit. We now set the content policy
on all child frames instead of just the main frame.

3:19 PM Changeset in webkit [1060] by darin

• 3 edits in trunk/WebCore

Updated log.

3:14 PM Changeset in webkit [1059] by darin

• 7 edits
  2 deletes in trunk/WebCore

• kwq/qt/qpixmap.h:
• kwq/KWQPixmap.mm: (QPixmap::QPixmap): Clear needsCopyOnWrite flag in all the constructors other than the copy constructor. Set it in the copy constructor. (QPixmap::~QPixmap): Simplify. (QPixmap::mask): Always return 0 rather than leaking a QBitmap each time, since Qt uses 0 to mean "no mask". (QPixmap::isNull): Simplify. (QPixmap::resize): Do the copy here if we need it, and do the setScalesWhenResized: call in here instead of trying to do it elsewhere. (QPixmap::xForm): Only copy the pixmap once. (QPixmap::operator=): Set the needsCopyOnWrite flag. Also change the retain/release idiom around so we don't need to check for self-assignment.

• khtml/ecma/Makefile.am: Don't build kjs_debugwin any more.
• khtml/ecma/kjs_debugwin.cpp: Removed.
• khtml/ecma/kjs_debugwin.h: Removed.

11:28 AM Changeset in webkit [1058] by cblu

• 20 edits in trunk

WebBrowser:

• LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]): Initial implementation of Alex's interaction with out content policy API. Simply made Alex show types that we handle inline and save types we don't

• WebController.m: Removed some deprecated methods.

WebKit:

• MIME.subproj/IFMIMEHandler.h:
• MIME.subproj/IFMIMEHandler.m: (+[IFMIMEHandler showableMIMETypes]): (+[IFMIMEHandler saveFileWithPath:andData:]): (+[IFMIMEHandler saveAndOpenFileWithPath:andData:]):

Added the above factory methods.

• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):

Save the content policy and download path on the datasource.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Made IFMainURLHandleClient use our new content policy API rather than
IFDownloadHandler.

• WebView.subproj/IFWebController.h:

Removed some deprecated methods.

• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _downloadPath]): (-[IFWebDataSource _setDownloadPath:]): (-[IFWebDataSource _contentPolicy]): (-[IFWebDataSource _setContentPolicy:]):

Added the above methods.

WebCore:

Added a new method to WCPluginDatabase allHandledMIMETypes.
It returns an array of the mime types that plug-ins handle.

• kwq/WCPluginDatabase.h:
• kwq/WCPluginDatabase.mm: (-[WCPluginDatabase allHandledMIMETypes]):

9:35 AM Changeset in webkit [1057] by darin

• 2 edits in trunk/WebKit

Fix ChangeLog typo.

7:39 AM Changeset in webkit [1056] by darin

• 4 edits in trunk/WebKit

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Fix the fix. It was bumping argsCount even when not putting an argument into the array.

12:02 AM Changeset in webkit [1055] by mjs

• 4 edits in trunk/WebKit

Fix a plugins memory trasher that was making Alexander crash on
the abcnews.com test page in cvs-torture-test:

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Use a new maxArguments variable to size the argument and value arrays - with the old code argsCount would end up twice the size it should be, and the arguments would all get written past the end of the argument array.

Apr 20, 2002:

7:52 AM Changeset in webkit [1054] by darin

• 9 edits in trunk/WebCore

Problems loading iframes seemed to be due to NSURL objects that
were not normalized, so I made the NSURL creation all be done
by KURL, which fixed the problem.

• kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame), (KHTMLPart::submitForm), (KHTMLPart::khtmlMouseReleaseEvent):
• kwq/KWQKjobclasses.mm: Call getNSURL instead of creating NSURLs by converting to strings.

• kwq/kdecore/kurl.h:
• kwq/KWQKURL.mm: (KURL::getNSURL): New.

Apr 19, 2002:

3:09 PM Changeset in webkit [1053] by kocienda

• 21 edits
  2 adds in trunk

2002-04-19 Kenneth Kocienda <​kocienda@apple.com>

WebFoundation:

Changes to support submission of forms using HTTP POST.

These changes focus on adding the form data to a post request.

• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler addRequestMessageBody:]):
• ChangeLog:
• WebFoundation.pbproj/project.pbxproj:

WebCore:

Changes to support submission of forms using HTTP POST.

These changes move us over to using the new WebKit interface for creating
WebDataSource instances, one that passes a handle rather than just a URL,
enabling the specific request method to be communicated to WebFoundation.
This fixes:

Radar 2903602 (IFWebDataSource API must passes attributes and flags to IFURLHandle)

Fixed handling of password fields:

Radar 2903605 (WebCore form processing drops out password input data)

Added some hacks to get form <input type=image ...> working correctly:

Radar 2907198 (Forms not getting submitted correctly when <input type=image>)

• khtml/rendering/render_form.cpp: (RenderImageButton::RenderImageButton), (RenderImageButton::~RenderImageButton), (RenderImageButton::printObject):
• khtml/rendering/render_form.h:
• kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame), (KHTMLPart::submitForm), (KHTMLPart::khtmlMouseReleaseEvent):
• kwq/KWQNSTextField.mm: (-[KWQNSTextField setPasswordMode:]), (-[KWQNSTextField textDidChange:]), (-[KWQNSTextField stringValue]):
• kwq/Makefile.am:
• kwq/KWQInvisibleButton.h: Added
• kwq/KWQInvisibleButton.mm: Added

WebKit:

Changes to support submission of forms using HTTP POST.

These changes move us over to using the new WebKit interface for creating
WebDataSource instances, one that passes a handle rather than just a URL,
enabling the specific request method to be communicated to WebFoundation.
This fixes:

Radar 2903602 (IFWebDataSource API must passes attributes and flags to IFURLHandle)

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSource.mm: (IFWebDataSourceMake), (-[IFWebDataSource initWithURL:]), (-[IFWebDataSource initWithHandle:]):
• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]):

9:57 AM Changeset in webkit [1052] by rjw

• 6 edits in trunk/WebKit

Updated comments to reflect new API.

8:45 AM Changeset in webkit [1051] by darin

• 6 edits in trunk/WebKit

• Plugins.subproj/IFPluginView.h: Re-add the attributes and values arrays, since they need to live the life of the plugin.
• Plugins.subproj/IFPluginView.mm: (newCString): New function to make a C++ new-allocated C string from an NSString. (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Move code to allocate the arrays back here. (-[IFPluginView dealloc]): Deallocate the arrays and their contents. (-[IFPluginView start]): Simplify now that it does no work.

Apr 18, 2002:

8:18 PM Changeset in webkit [1050] by cblu

• 6 edits in trunk/WebKit

2002-04-18 Chris Blumenberg <​cblu@apple.com>

Made stop and start work better. Fixed a bug darin made.

• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView start]), (-[IFPluginView stop]):

8:07 PM Changeset in webkit [1049] by rjw

• 7 edits in trunk/WebKit

Fixed typo.

8:02 PM Changeset in webkit [1048] by rjw

• 12 edits
  2 adds in trunk/WebKit

New API for content policy.

4:01 PM Changeset in webkit [1047] by darin

• 7 edits in trunk

Oops. Take out -Wstrict-prototypes, put back -Wmissing-prototypes.

3:54 PM Changeset in webkit [1046] by darin

• 7 edits in trunk

Take out -Wmissing-prototypes
because system headers are triggering it when we don't have
precompiled headers on.

3:38 PM Changeset in webkit [1045] by darin

• 98 edits in trunk

• Makefile.am: Pass the -f flag to ln so it doesn't fail when there's already a link there.

• configure.in: Use gcc3 and g++3 so we always get gcc 3.0, no matter how the system is configured. Besides the fact that gcc 3.0 includes more in -Wall, turned on the following additional warnings that were not on before:

-W
-Wbad-function-cast
-Wformat-security
-Wmissing-format-attribute
-Wstrict-prototypes
-Wwrite-strings

Also removed the -fno-coalesce-static-vtables flag for C++
and removed explicit mention of C++ warnings that are part of
-Wall in gcc 3.0 at least.

• Tests/harness.c: (main): Const string fix.
• Tests/kde/kurl-test.cpp: (testURL): Std namespace and const string fix.
• Tests/libiftest/IFTestDirectory.c: (IFSetUpTestDirectory): Const string fix.
• Tests/libiftest/IFTestDirectory.h: Const string fix.

• Tests/qt/qarray-test.cpp:
• Tests/qt/qbuffer-test.cpp:
• Tests/qt/qchar-test.cpp:
• Tests/qt/qcstring-test.cpp:
• Tests/qt/qdate-test.cpp:
• Tests/qt/qdatetime-test.cpp:
• Tests/qt/qdict-test.cpp:
• Tests/qt/qdir-test.cpp:
• Tests/qt/qfile-test.cpp:
• Tests/qt/qlist-test.cpp:
• Tests/qt/qmap-test.cpp:
• Tests/qt/qpoint-test.cpp:
• Tests/qt/qptrdict-test.cpp:
• Tests/qt/qrect-test.cpp:
• Tests/qt/qregexp-test.cpp:
• Tests/qt/qsize-test.cpp:
• Tests/qt/qsortedlist-test.cpp:
• Tests/qt/qstack-test.cpp:
• Tests/qt/qstring-test.cpp:
• Tests/qt/qstringlist-test.cpp:
• Tests/qt/qtime-test.cpp:
• Tests/qt/qvaluelist-test.cpp:
• Tests/qt/qvector-test.cpp: Add "using namespace std" to each test as a simple std namespace fix.

WebFoundation:

Reviewed by Maciej

Fixes for compiling with gcc3 and more warnings.

• WebFoundation.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).

• CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle percentComplete]): Rearrange code to avoid a cast to (float) that gcc3 didn't like.

• Database.subproj/IFNDBMDatabase.m: (-[IFNDBMDatabase objectForKey:]): Mark some variables volatile to make gcc3 happy about their values and the use of longjmp. Good catch on the compiler's part.

• Database.subproj/IFURLFileDatabase.m: Work around bug 2905545 so we can have -W on for all the rest of WebFoundation. (URLFileReaderInit): Mark this as (void) so it's not a non-prototyped function. (-[IFURLFileReader initWithPath:]): Don't assign to self so gcc3 is not unhappy about the use of it with longjmp. (-[IFURLFileDatabase objectForKey:]): Mark some variables volatile to make gcc3 happy about their values and the use of longjmp.

• Misc.subproj/IFNSObjectExtensions.m: (-[NSObject performBooleanSelector:]), (-[NSObject performBooleanSelector:withObject:]): Do a new implementation that does't make the compiler unhappy about type casts.

• Misc.subproj/IFNSThreadExtensions.m: Work around bug 2905545 so we can have -W on for all the rest of WebFoundation. (InitJoinableThreads): Mark this as (void) so it's not a non-prototyped function.

JavaScriptCore:

Reviewed by Maciej

• JavaScriptCore.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).

WebCore:

Fixes for compiling with gcc3 and more warnings.

• khtml/html/.cvsignore: Add kentities.c; I could have sworn I did this already.
• khtml/html/Makefile.am: Remove erroneous duplicate definition of CLEAN_FILES.

• libwebcore.exp:
• libwebcoretests.exp: Rebuilt these lists from scratch. Almost everything in here is different since the C++ name mangling rules changed.

• khtml/css/cssparser.cpp:
• khtml/misc/htmlhashes.cpp: Disable inlining in part of this file as a workaround for Radar 2905890.

• kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add casts to int needed to make gcc3 happy.
• kwq/KWQArrayImpl.mm: Add missing #include of <string.h>.

• kwq/KWQBitmap.mm:
• kwq/KWQFrame.mm:
• kwq/KWQLineEdit.mm: Removed some unused copy constructors and assignment operators to avoid warnings in them.

• kwq/KWQButton.mm: (QButton::setText):
• kwq/KWQListBox.mm: (QListBox::~QListBox), (QListBox::clear), (QListBox::setSelectionMode), (QListBox::currentItem), (QListBox::insertItem), (QListBox::setSelected), (QListBox::isSelected), (QListBoxItem::width), (QListBoxItem::height):
• kwq/KWQScrollView.mm: (QScrollView::setContentsPos), (QScrollView::addChild), (QScrollView::resizeContents), (QScrollView::viewportToContents), Use local variables to work around Radar 2905835.

• kwq/KWQCString.mm: (operator<<):
• kwq/KWQPoint.mm: (operator<<):
• kwq/KWQRect.mm: (operator<<):
• kwq/KWQSize.mm: (operator<<):
• kwq/qt/qarray.h:
• kwq/qt/qcstring.h:
• kwq/qt/qdatetime.h:
• kwq/qt/qdict.h:
• kwq/qt/qlist.h:
• kwq/qt/qmap.h:
• kwq/qt/qpainter.h:
• kwq/qt/qpoint.h:
• kwq/qt/qptrdict.h:
• kwq/qt/qrect.h:
• kwq/qt/qsize.h:
• kwq/qt/qstack.h:
• kwq/qt/qvaluelist.h:
• kwq/qt/qvector.h: Say std::ostream instead of just ostream.

• kwq/KWQCharsets.mm: Fix a const problem.

• kwq/KWQDateTime.mm: (QTime::elapsed), (QTime::restart): Use int instead of uint, since these functions try to handle values that are less than 0. (operator<<): Say std::ostream instead of just ostream.
• kwq/KWQTextArea.mm: (RangeOfParagraph): Fix an int/uint issue.

• kwq/KWQFile.mm: (QFile::KWQFilePrivate::KWQFilePrivate), (QFile::KWQFilePrivate::~KWQFilePrivate): Use new/delete instead of malloc/free so we don't get void * warnings.

• kwq/KWQFontMetrics.mm: (IFFillStyleWithAttributes), (-[KWQLayoutInfo drawString:atPoint:withFont:color:]), (-[KWQLayoutInfo _initializeCaches]), (_rectForString):
• kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate), (RelativeURLKeyRetainCallBack), (RelativeURLKeyReleaseCallBack), (RelativeURLKeyEqualCallBack), (RelativeURLKeyHashCallBack), (KURL::normalizeURLString), (KURL::normalizeRelativeURLString):
• kwq/KWQPainter.mm: (QPainter::save):
• kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[URLLoadClient IFURLHandle:didRedirectToURL:]): Add type casts where necessary to make the stricter gcc3 happy.

• kwq/KWQPixmap.mm: (QPixmap::QPixmap): Explicitly initialize the underlying QPaintDevice. (QPixmap::size), (QPixmap::rect): Add type casts where necessary to make the stricter gcc3 happy.

• kwq/KWQPtrDictImpl.mm: (KWQPtrDictImpl::KWQPtrDictPrivate::KWQPtrDictPrivate): Say std::bad_alloc instead of just bad_alloc. (invokeDeleteFuncOnValue), (KWQPtrDictImpl::clear): Pass a pointer to a function pointer rather than a function pointer to avoid a warning about turning function pointers into void *.

• kwq/KWQRegion.mm: (QRegion::_initialize), (QRegion::~QRegion): Use new/delete rather than calloc/free so we don't get void * warnings. (QRegion::boundingRect): Add type casts.

• kwq/KWQString.mm: (QString::fromStringWithEncoding): Add cast. (QString::setNum): use %ld and %lu rather than %D and %U. (QString::fill), (QString::convertToQCString): Add casts.

• kwq/KWQTextStorage.mm: (-[KWQTextStorage _buildFragmentForString:]): Add a cast to make gcc3 happy.

• kwq/KWQVariant.mm: Say "friend class" instead of "friend".

• kwq/KWQVectorImpl.mm: (KWQVectorImpl::KWQVectorPrivate::KWQVectorPrivate): Say std::bad_alloc instead of just bad_alloc. (KWQVectorImpl::data): Replace the old autorelease trick with a new one that doesn't require mixing malloc with NSData.

• kwq/KWQView.mm: (-[KWQHTMLView mouseUp:]), (-[KWQHTMLView mouseDown:]): Add casts to make gcc3 happy.

• kwq/KWQWidget.mm: (QWidget::frameGeometry), (QWidget::mapToGlobal), (QWidget::minimumSizeHint): Add casts to make gcc3 happy. Also another workaround for Radar 2905835.

• kwq/WCPlugin.mm: (-[WCPlugin load]): Add tons of type casts so we don't have to mix void * with function pointer types.

• kwq/WCPluginWidget.h:
• kwq/WCPluginWidget.mm: (WCIFPluginMakeFunction), (WCIFNullPluginMakeFunction): Change types so we don't have to mix void * with function pointer types. This caught a mistake where WCIFNullPluginMakeFunction was returning the wrong function pointer.

• kwq/external.h: Add some missing interfaces that the pickier gcc3 needed to see.

• kwq/kwqdebug.mm: Don't compile the file if xNDEBUG is set. Otherwise we get a warning in here.

• kwq/npapi.h: Use function pointer types for function pointers and transition vectors so we don't have to mix void * with function pointer types.

• kwq/npapi.mm: (NPN_GetURLNotify), (NPN_GetURL), (NPN_PostURLNotify), (NPN_PostURL), (NPN_NewStream), (NPN_Write), (NPN_DestroyStream), (NPN_Status), (NPN_GetValue), (NPN_SetValue), (NPN_InvalidateRect), (NPN_InvalidateRegion), (NPN_ForceRedraw): Use local variables to work around Radar 2905835. (functionPointerForTVector), (tVectorForFunctionPointer): Change types around so we don't have to mix void * with function pointer types.

WebKit:

Fixes for compiling with gcc3 and more warnings.

• WebKit.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).

• Plugins.subproj/IFPluginView.mm: Avoid warnings about malloc by not using it. (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Keep the arguments dictionary around instead of keeping the C format version of it around. Also don't bother keeping the C string form of the MIME type around, and simplify some other stuff in here. (-[IFPluginView dealloc]): Corresponding changes since we keep a different set of things. (-[IFPluginView newStream:mimeType:notifyData:]): Use [mimeType cString]. (-[IFPluginView start]): Build the lists of attributes and values in here. Do it using [NSString cString] for simplicity and don't keep the lists around after we're done with them. (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]): Use [filenameClassic cString].

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]), (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]), (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]), (-[IFWebDataSource _setLoading:]), (-[IFWebDataSource _setController:]), (-[IFWebDataSource _setLocationChangeHandler:]):
• WebView.subproj/IFWebView.mm: (-[IFWebView provisionalDataSourceChanged:]), (-[IFWebView mouseUp:]), (-[IFWebView mouseDown:]): Add type casts required by pickier gcc3.

• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Add type cast required by pickier gcc3. (-[IFWebView _stopPlugins]): Use local variable to work around Radar 2905835.

WebBrowser:

Fixes for compiling with gcc3 and more warnings.

• WebBrowser.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).

• InternetConfigUtilities.m: (stringValueForICKey), (setStringValue): Some const string fixes.
• Preferences.subproj/TextPreferences.m: (-[TextPreferences changeFont:]): Remove a cast that makes gcc3 unhappy.
• _CFA2UC.c: (NSGiantRaise): Const string fix. (gcompg): Old-style function prototype fix. (initialguess): Remove a cast that makes gcc3 unhappy.

11:49 AM Changeset in webkit [1044] by cblu

• 6 edits in trunk/WebKit

Moved plugin instance creation to the start method in IFPluginView.

• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView dealloc]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView start]), (-[IFPluginView stop]), (-[IFPluginView drawRect:]), (-[IFPluginView windowBecameKey:]), (-[IFPluginView windowResignedKey:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]):

Apr 17, 2002:

6:00 PM Changeset in webkit [1043]

• 1 copy
  2 deletes in tags/JavaScriptCore-3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-3'.

6:00 PM Changeset in webkit [1042]

• 10 copies in tags/Alex0_3c1

This commit was manufactured by cvs2svn to create tag 'Alex0_3c1'.

6:00 PM Changeset in webkit [1041] by mjs

• 4 edits in trunk/JavaScriptCore

Reviewed by: Darin Adler <Darin Adler>

• kjs/testkjs.cpp: Don't include <iostream.h> to avoid gcc3 warning.

4:37 PM Changeset in webkit [1040] by darin

• 9 edits
  1 add
  1 delete in trunk/WebCore

Fix build problem.

• Makefile.am: Don't build this directory before subdirs, because we link at this level. Move the kentities.c build out of here, because it needs to be done before khtml/html.
• khtml/html/Makefile.am: Move kentities.c build rules here.

• kentities.gperf: Removed.
• khtml/html/kentities.gperf: Added.

• .cvsignore: Don't ignore kentities.c.
• khtml/html/.cvsignore: Ignore kentities.c.

4:12 PM Changeset in webkit [1039] by darin

• 17 edits
  2 adds
  3 deletes in trunk

top level:

• configure.in: Update for new organization of WebCore.

• Tools/HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: Switch to gcc3 and turn on more warnings.
• Tools/HotSpotFinder/SamplingData.m: (-[SamplingDataAccumulator processFunction:depth:]): Fix a signed/unsigned warning.

WebCore:

• .cvsignore: Ignore new generated files at this level.

• include/*: Removed. We don't need this hack any more.
• src/*: Removed. Sources are now in their new locations.
• src/libwebcore.exp: Removed. This is now in its new location.
• src/libwebcoretests.exp: Removed. This is now in its new location.

• Makefile.am: Build khtml and kwq subdirs, don't build src and include. Also add the rules that used to be in src about linking the library and the rules that used to be in src/kdelibs/kdecore about building the kentitices.c file.

• dummy.mm: Moved here from src by hand.
• kentities.gperf: Moved here from src/kdelibs/kdecore by hand.

• khtml/html/Makefile.am: Add WebCore directory to includes so the include of "kentities.c" will work.

• kwq/KWQKHTMLPart.mm:
• kwq/KWQKJavaEmbed.mm:
• kwq/KWQKloader.mm: Correct includes so we don't need a -I for each of the subdirectories.

• kwq/khtml/java/javaembed.h: Removed. We use the one in the real khtml directory.

• kwq/kwqdebug.h: Rolled over Chris's changes, which were done after the cvs surgery was done.

WebKit:

• WebKit.pbproj/project.pbxproj: Update header search paths to find WebCore in the new location and eliminate WebCore/include.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Update header search paths to find WebCore in the new location and eliminate WebCore/include.

12:53 PM Changeset in webkit [1038] by cblu

• 13 edits in trunk

Added a debug bit mask for plugins and downloads.

• MIME.subproj/IFDownloadHandlerPrivate.m: (-[IFDownloadHandlerPrivate _openFile]), (-[IFDownloadHandlerPrivate _saveFile]), (-[IFDownloadHandler _initWithURLHandle:mimeHandler:]):
• Misc.subproj/WebKitDebug.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView stop]), (-[IFPluginView sendUpdateEvent]), (-[IFPluginView becomeFirstResponder]), (-[IFPluginView resignFirstResponder]), (-[IFPluginView mouseDown:]), (-[IFPluginView mouseUp:]), (-[IFPluginView mouseEntered:]), (-[IFPluginView mouseExited:]), (-[IFPluginView keyUp:]), (-[IFPluginView keyDown:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]), (-[IFPluginView getURLNotify:target:notifyData:]), (-[IFPluginView getURL:target:]), (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]), (-[IFPluginView postURL:target:len:buf:file:]), (-[IFPluginView newStream:target:stream:]), (-[IFPluginView write:len:buffer:]), (-[IFPluginView destroyStream:reason:]), (-[IFPluginView status:]), (-[IFPluginView getValue:value:]), (-[IFPluginView setValue:value:]), (-[IFPluginView invalidateRect:]), (-[IFPluginView invalidateRegion:]), (-[IFPluginView forceRedraw]):
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

• src/kwq/kwqdebug.h:

7:56 AM Changeset in webkit [1037] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Changed another Georgia that I missed to Times New Roman.

Apr 16, 2002:

10:58 PM Changeset in webkit [1036] by darin

• 6 edits in trunk/WebKit

• WebView.subproj/IFWebDataSource.mm:
• WebView.subproj/IFWebDataSourcePrivate.mm: Touch these files to try to make Jersey build again.

6:07 PM Changeset in webkit [1035] by darin

• 28 edits
  2 adds
  1 delete in trunk

WebCore:

• src/kdelibs/khtml/khtml_part.cpp: Added. Not used yet, but maybe we'll use part of it some time soon.

• src/kdelibs/khtml/khtml_part.h: Reenabled this file, and made changes so it could be used instead of our own header.
• src/kwq/KWQKHTMLPart.h: Removed.

• src/kwq/KWQKHTMLPart.mm: (KHTMLPart::KHTMLPart): Add parameter to match KDE. (KHTMLPart::settings): Add const to match KDE. (KHTMLPart::scheduleRedirection): Add parameter to match KDE. (KHTMLPart::encoding): Add const to match KDE. (KHTMLPart::urlCursor): Update return value to match KDE. (KHTMLPart::urlSelected): Add parameter to match KDE. (KHTMLPart::requestObject): Put plugins array on private object. (KHTMLPart::frames): Remove const to match KDE. (KHTMLPart::documentSource): Add const to match KDE. (KHTMLPart::setTitle): Put dataSource on private object. (KHTMLPart::setDataSource): New, not inline any more. (KHTMLPart::getDataSource): New, not inline any more.

• src/libwebcore.exp: Update for function name changes.

• src/kwq/khtml/khtml_settings.h:
• src/kwq/KWQKHTMLSettings.mm: (KHTMLSettings::changeCursor): Add const.

• src/kwq/KWQView.mm: (-[KWQHTMLView layout]): No need to check xmlDocImpl() and renderer() for NULL now, because KHTMLView::layout does.

• src/kwq/KWQKloader.mm: (Loader::load): Use type instead of id.

WebKit:

• WebView.subproj/IFBaseWebControllerPrivate.mm: Include khtml_part.h instead of KWQKHTMLPart.h.

• WebView.subproj/IFWebFrame.mm: Include khtml_part.h instead of KWQKHTMLPart.h.

• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentTextFromDOM]): Remove an unneeded cast and an extra retain/autorelease.

4:46 PM Changeset in webkit [1034] by darin

• 8 edits in trunk/WebKit

• WebView.subproj/IFWebFrame.h:
• WebView.subproj/IFWebFrame.mm:
• WebView.subproj/IFWebFramePrivate.h: Change view/setView back to be id, rather than IFWebView. In the future, the view may be some other kind of object.

3:37 PM Changeset in webkit [1033] by sullivan

• 4 edits in trunk/WebKit

Fixed bug Chris noticed where Alexander wasn't putting up
an error sheet on failed page visits.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Don't set provisionalDataSource to nil until after sending it locationChangeDone.

3:30 PM Changeset in webkit [1032] by darin

• 16 edits in trunk/WebKit

• WebView.subproj/IFBaseWebController.mm: Remove special release handling because data sources now retain the controller as long as they are loading.

• WebView.subproj/IFWebDataSource.mm: Remove special release handling because data sources now retain themselves as long as they are loading.

• WebView.subproj/IFWebFrame.mm: Remove special release handling, because data sources now retain the controller as long as they are loading, and the controller retains the frame.

• WebView.subproj/IFWebDataSourcePrivate.h: Add a "loading" boolean.
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setLoading:]): Change the "loading" state, retaining or releasing this object and the controller as necessary. (-[IFWebDataSource _updateLoading]): Update the loading state; called when some part of loading is done to see if it's all done. (-[IFWebDataSource _setController:]): Retain the new controller and release the old controller when loading. (-[IFWebDataSource _setPrimaryLoadComplete:]): Call _updateLoading. (-[IFWebDataSource _startLoading:]): Call _setLoading:YES. (-[IFWebDataSource _addURLHandle:]): Call _setLoading:YES. (-[IFWebDataSource _removeURLHandle:]): Call _updateLoading.

• WebView.subproj/IFWebFrame.h: Use the real type, IFWebView, for setView and view.
• WebView.subproj/IFWebFramePrivate.h: Formatting tweak.
• WebKit.pbproj/project.pbxproj: Version wars.

3:30 PM Changeset in webkit [1031] by darin

• 15 edits in trunk/WebCore

• src/kwq/kio/jobclasses.h:
• src/kwq/KWQKjobclasses.mm: (TransferJob::setError): New.

• src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidCancelLoading:]), (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Set an error code so that the load will abort intead of continuing.

• src/kwq/KWQKHTMLPart.mm: Removed some unused code.

3:22 PM Changeset in webkit [1030] by sullivan

• 4 edits in trunk/WebKit

• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _setController:]): removed a mistaken retain/release pair here for Darin.

More code restructuring. BrowserDocument no longer implements
the IFWebController protocol; its WebController object does all
the progress handling now.

Also made BrowserDocument stop loading on close for Darin, which fixes
a problem he discovered.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]), (-[BrowserDocument dealloc]), (-[BrowserDocument close]), (-[BrowserDocument _webController]), (-[BrowserDocument goToURL:withFrameLoadType:]), (-[BrowserDocument isLoading]):
• BrowserDocumentPrivate.h:
• LoadProgressEntry.h:
• LoadProgressEntry.m: (-[LoadProgressEntry status]):
• LoadProgressMonitor.m: (-[LoadProgressMonitor addEntryForFrame:withType:stage:isMain:]):
• LocationChangeHandler.h:
• LocationChangeHandler.m: (-[LocationChangeHandler initWithFrame:forBrowserDocument:]), (-[LocationChangeHandler _webController]), (-[LocationChangeHandler _saveScrollPosition]), (-[LocationChangeHandler _scrollToTop]), (-[LocationChangeHandler _restoreScrollPosition]), (-[LocationChangeHandler locationChangeStarted]), (-[LocationChangeHandler locationChangeCommitted]), (-[LocationChangeHandler displayError:withStage:]), (-[LocationChangeHandler locationChangeDone:]), (-[LocationChangeHandler receivedPageTitle:forDataSource:]):
• WebController.h:
• WebController.m: (-[WebController initWithBrowserDocument:]), (-[WebController dealloc]), (-[WebController resetDocument]), (-[WebController document]), (-[WebController loadMonitor]), (-[WebController receivedProgress:forResource:fromDataSource:]), (-[WebController receivedError:forResource:partialProgress:fromDataSource:]), (-[WebController setStatusText:forDataSource:]), (-[WebController provideLocationChangeHandlerForFrame:]), (-[WebController pluginNotFoundSheetEnded:returnCode:contextInfo:]), (-[WebController pluginNotFoundForMIMEType:pluginPageURL:]), (-[WebController startedDownloadWithHandler:]), (-[WebController receivedProgress:forDownloadHandler:]), (-[WebController receivedError:forDownloadHandler:partialProgress:]): Much code moved from here to there; some code moved from there to here; callers updated to call the code on this object that used to be on that object, and vice-versa.

11:50 AM Changeset in webkit [1029] by darin

• 5 edits in trunk/WebKit

Change default font to "Times New Roman 11" rather than
"Georgia 12" to be more like Macintosh Internet Explorer.

• WebView.subproj/IFPreferences.mm:

A little simplifying of private pointers.

• MIME.subproj/IFDownloadHandler.h:
• MIME.subproj/IFDownloadHandler.m:

11:47 AM Changeset in webkit [1028] by darin

• 31 edits in trunk/WebKit

A little simplifying of private pointers.

10:43 AM Changeset in webkit [1027] by darin

• 83 edits in trunk/WebKit

Change headers so they don't include so much.
Also change IF_LOAD_TYPE to IFLoadType.

8:18 AM Changeset in webkit [1026] by kocienda

• 23 edits
  4 deletes in trunk

2002-04-16 Kenneth Kocienda <​kocienda@apple.com>

Moved IFError class from WebKit to WebFoundation.

Labyrinth:

Updated test and tool code to track this change.

• Tests/WebFoundationC/ifurlhandlec-test.c: (ResourceDidFailLoadingCallBack):
• Tools/wftool/WFTool.m: (-[WFTool IFURLHandle:resourceDidFailLoadingWithResult:]):

WebBrowser:

Updated includes due to this change.

• BrowserDocument.m:
• FrameProgressEntry.m:
• LoadProgressEntry.m:
• LocationChangeHandler.m:
• WebBrowser.pbproj/project.pbxproj:

WebCore:

Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. These files were
modified due to this change.

• src/kwq/KWQKHTMLPart.mm: (WCSetIFWebDataSourceMakeFunc):
• src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Removed now unneeded file and function pointer symbol entry
since WebCore code never needs to create an IFError now that
those objects are created at a lower level (in WebFoundation).

• src/kwq/WCError.h: Removed.
• src/libwebcore.exp:

WebFoundation:

Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. These files were
modified due to this change.
I added some additional API to the C glue to make IFError objects
accessible from C code.

• CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandleInstanceVariables dealloc]), (-[IFURLHandleSynchronousClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[IFURLHandle notifyClientsDidFailLoading]):
• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFErrorGetErrorCode), (IFErrorGetErrorDescription), (IFErrorGetFailingURL):
• CacheLoader.subproj/IFURLHandleCallBackClient.m: (-[IFURLHandleCallBackClient IFURLHandle:resourceDidFailLoadingWithResult:]):
• CacheLoader.subproj/IFURLHandleClient.h:
• Misc.subproj/IFError.h:
• Misc.subproj/IFError.m: (+[IFError initialize]), (+[IFError errorWithCode:]), (+[IFError errorWithCode:failingURL:]), (-[IFError initWithErrorCode:]), (-[IFError errorDescription]), (-[IFError description]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Moved IFError class from WebKit to WebFoundation.
Updated includes due to this change.
Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. The URL client was
modified due to this change.

• Misc.subproj/IFError.h: Removed.
• Misc.subproj/IFError.m: Removed.
• Plugins.subproj/IFPluginView.mm:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFBaseWebControllerPrivate.mm:
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
• WebView.subproj/IFWebFramePrivate.mm:

Apr 15, 2002:

5:55 PM Changeset in webkit [1025] by mjs

• 3 edits in trunk/JavaScriptCore

Retroactively reviewed Darin's last two commits.

4:43 PM Changeset in webkit [1024] by darin

• 511 edits
  2 adds in trunk

Merged KDE 3.0 final code in and:

JavaScriptCore:

• kjs/internal.cpp:
• kjs/property_map.cpp:
• kjs/ustring.h: Removed some unneeded <config.h> includes so we are more similar to the real KDE sources.

Merged changes from KDE 3.0 final and did some build fixes.

• JavaScriptCore.pbproj/project.pbxproj: Added nodes2string.cpp.

• kjs/grammar.*: Regenerated.
• kjs/*.lut.h: Regenerated.

WebCore:

• src/kdelibs/khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Remove some minor gratuitous diffs vs. KDE.

• src/kdelibs/khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Richard updated to reflect changes in KDE.

• src/kdelibs/khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl): Fix comment.
• src/kdelibs/khtml/css/cssstyleselector.cpp: Remove some gratuitous diffs vs. KDE.
• src/kdelibs/khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): Remove unneeded copy from KWQ's early days.
• src/kdelibs/khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute), (HTMLTablePartElementImpl::parseAttribute): Remove unneeded copy from KWQ's early days.
• src/kdelibs/khtml/html/htmltokenizer.cpp: (HTMLTokenizer::processToken): Redo the APPLE_CHANGES ifdef here.
• src/kdelibs/khtml/khtmlpart_p.h: Update to latest kde.
• src/kdelibs/khtml/khtmlview.cpp: (KHTMLView::KHTMLView): Add ifdef APPLE_CHANGES. (KHTMLView::~KHTMLView): Add ifdef APPLE_CHANGES. (KHTMLView::print): Remove code left in here during merge process.
• src/kwq/KWQKHTMLPart.mm: Remove unused setFontSizes(), fontSizes(), and resetFontSizes(). After the merge is landed, remove more.
• src/libwebcore.exp: Export updateStyleSelector() for WebKit.

Fix text to it displays at the right font size.

• src/kdelibs/khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Apply the same SCREEN_RESOLUTION hack here that we do elsewhere.
• src/kdelibs/khtml/rendering/font.cpp: (Font::width): Use kMin instead of max (oops). (Font::update): Turn off font database chicanery.
• src/kwq/KWQKHTMLPart.mm: (KHTMLPart::zoomFactor): Use zoom factor 100, not 1.

More fixes so text displays (still at wrong font size).

• src/kdelibs/khtml/rendering/font.cpp: (max): New helper. (Font::drawText): Simplified implementation for now. (Font::width): Simplified implementation for now.
• src/kwq/KWQColorGroup.mm: Reinstated QCOLOR_GROUP_SIZE.

• src/kwq/qt/qfontmetrics.h: Removed charWidth and changed _width to take QChar *.
• src/kwq/KWQFontMetrics.mm: Removed charWidth and changed _width to take QChar *.

Merged changes from KDE 3.0 final. Other fixes to get things compiling.

• src/kdelibs/khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setProperty): Fix unused variable.
• src/kdelibs/khtml/khtmlview.cpp: (KHTMLView::contentsContextMenuEvent): Fix unused variable.
• src/kdelibs/khtml/rendering/font.cpp: (Font::drawText), (Font::width), (Font::update): Disable special "nsbp" logic for now. We can reenable it if necessary.
• src/kdelibs/khtml/rendering/render_replaced.cpp: Fix mismerge.
• src/kdelibs/khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint): Fix unused variable.
• src/kwq/KWQApplication.mm: (QDesktopWidget::width), (QApplication::desktop): Fix mismerge.
• src/kwq/KWQColorGroup.mm: Fix QCOLOR_GROUP_SIZE.
• src/kwq/KWQFontMetrics.mm: (QFontMetrics::lineSpacing): New. (QFontMetrics::width): Remove unused optimization.
• src/kwq/qt/qfontmetrics.h: Add lineSpacing().

Merged changes from previous merge pass.

2002-03-25 Darin Adler <Darin Adler>

Last bit of making stuff compile and link. Probably will drop the merge now
and take it up again when it's time to merge in KDE 3.0 final.

• src/kwq/KWQEvent.mm: (QFocusEvent::reason): New.
• src/kwq/KWQPainter.mm: (QPainter::drawText): New overload.

2002-03-25 Darin Adler <Darin Adler>

• src/kdelibs/khtml/rendering/font.cpp: (Font::width): Make it call _width so we don't lose the optimization.

• src/kwq/KWQApplication.mm: (QDesktopWidget::screenNumber): New. (QDesktopWidget::screenGeometry): New. (QApplication::style): New.
• src/kwq/KWQColorGroup.mm: (QColorGroup::highlight): New. (QColorGroup::highlightedText): New.
• src/kwq/KWQFont.mm: (QFont::setPixelSize): New.
• src/kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth): New.
• src/kwq/KWQKGlobal.mm: (KGlobal::locale): Implement. (KLocale::KLocale): New. (KLocale::languageList): New.
• src/kwq/KWQKHTMLPart.mm: (KHTMLPart::sheetUsed): New. (KHTMLPart::setSheetUsed): New. (KHTMLPart::zoomFactor): New.
• src/kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFontSize): New.
• src/kwq/KWQScrollView.mm: (QScrollView::childX): New. (QScrollView::childY): New.

• src/kwq/qt/qapplication.h: style() returns a QStyle &.
• src/kwq/qt/qpalette.h: Add Highlight and HighlightedText.

2002-03-24 Darin Adler <Darin Adler>

More compiling. Still won't link.

• src/kdelibs/khtml/khtmlview.cpp: Disable printing and drag and drop code.
• src/kdelibs/khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Temporarily turn off our smarter underlining since it relies on access to the string, and TextSlave doesn't have that any more. (RenderText::nodeAtPoint): Get rid of a workaround we don't need any more for a bug that was fixed by KDE folks.
• src/kwq/KWQApplication.mm: (QApplication::desktop): Make the desktop be a QDesktopWidget.
• src/kwq/qt/qnamespace.h: Add MetaButton.
• src/kwq/qt/qtooltip.h: Add a maybeTip virtual function member and a virtual destructor.

2002-03-24 Darin Adler <Darin Adler>

Some fixes to get more stuff to compile.

• src/kdelibs/khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): Don't try to look at the private m_bComplete to display "complete". Just do "loading" and "loaded".
• src/kdelibs/khtml/khtmlpart_p.h: #ifdef this all out for APPLE_CHANGES.
• src/kdelibs/khtml/rendering/font.cpp: (Font::update): Add an explicit cast to int to avoid float -> int warning.
• src/kdelibs/khtml/rendering/render_table.cpp: (RenderTable::calcColMinMax): Add an explicit cast to int to avoid uint compared with int warning.
• src/kdelibs/khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Use sheetUsed() and setSheetUsed() functions on KHTMLPart intead of getting at private fields the way the real KDE code does.

• src/kwq/KWQKHTMLPart.h: Declare zoomFactor(), sheetUsed(), and setSheetUsed().
• src/kwq/KWQStyle.h: Add PM_DefaultFramWidth as another metric.
• src/kwq/kdecore/klocale.h: Add languageList().
• src/kwq/khtml/khtml_settings.h: Add mediumFontSize().
• src/kwq/qt/qapplication.h: Add style() and QDesktopWidget.
• src/kwq/qt/qevent.h: Add reason().
• src/kwq/qt/qfont.h: Add setPixelSize(int).
• src/kwq/qt/qfontmetrics.h: Add charWidth() and _charWidth() functions.
• src/kwq/qt/qpainter.h: Add drawText() overload with position parameter.
• src/kwq/qt/qpalette.h: Add highlight() and highlightedText().
• src/kwq/qt/qscrollview.h: Add childX() and childY().

• src/kwq/KWQApplication.mm: Change KWQDesktopWidget to QDesktopWidget.

WebKit:

• WebView.subproj/IFPreferences.h:
• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Remove the old WebKitFontSizes preference. (-[IFPreferences mediumFontSize]), (-[IFPreferences setMediumFontSize:]): New.

• WebView.subproj/IFWebView.mm: (-[IFWebView reapplyStyles]): Call updateStyleSelector() instead of recalcStyle().

Merged changes from previous merge branch.

2002-03-25 Darin Adler <Darin Adler>

• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Add WebKitMediumFontSizePreferenceKey.

WebBrowser:

• Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Just get and set the new mediumFontSize preference rather than doing the whole fontSizes preference dance.

4:17 PM Changeset in webkit [1023] by darin

• 5 edits in branches/kde_3_0_merge/WebCore

• src/kdelibs/khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Remove some minor gratuitous diffs vs. KDE.

4:09 PM Changeset in webkit [1022] by rjw

• 5 edits in branches/kde_3_0_merge/WebCore

Updated to reflect changes in KDE.

2:57 PM Changeset in webkit [1021] by darin

• 8 edits in branches/kde_3_0_merge/WebKit

WebKit:

• WebView.subproj/IFPreferences.h:
• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Remove the old WebKitFontSizes preference. (-[IFPreferences mediumFontSize]), (-[IFPreferences setMediumFontSize:]): New.

• WebView.subproj/IFWebView.mm: (-[IFWebView reapplyStyles]): Call updateStyleSelector() instead of recalcStyle().

WebBrowser:

• Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Just get and set the new mediumFontSize preference rather than doing the whole fontSizes preference dance.

2:56 PM Changeset in webkit [1020] by darin

• 22 edits in branches/kde_3_0_merge/WebCore

• src/kdelibs/khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl): Fix comment.
• src/kdelibs/khtml/css/cssstyleselector.cpp: Remove some gratuitous diffs vs. KDE.
• src/kdelibs/khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): Remove unneeded copy from KWQ's early days.
• src/kdelibs/khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute), (HTMLTablePartElementImpl::parseAttribute): Remove unneeded copy from KWQ's early days.
• src/kdelibs/khtml/html/htmltokenizer.cpp: (HTMLTokenizer::processToken): Redo the APPLE_CHANGES ifdef here.
• src/kdelibs/khtml/khtmlpart_p.h: Update to latest kde.
• src/kdelibs/khtml/khtmlview.cpp: (KHTMLView::KHTMLView): Add ifdef APPLE_CHANGES. (KHTMLView::~KHTMLView): Add ifdef APPLE_CHANGES. (KHTMLView::print): Remove code left in here during merge process.
• src/kwq/KWQKHTMLPart.mm: Remove unused setFontSizes(), fontSizes(), and resetFontSizes(). After the merge is landed, remove more.
• src/libwebcore.exp: Export updateStyleSelector() for WebKit.

2:55 PM Changeset in webkit [1019] by darin

• 6 edits in branches/kde_3_0_merge/JavaScriptCore

• kjs/internal.cpp:
• kjs/property_map.cpp:
• kjs/ustring.h: Removed some unneeded <config.h> includes so we are more similar to the real KDE sources.

2:02 PM Changeset in webkit [1018] by darin

• 2 deletes in branches/kde/JavaScriptCore/kjs

These files don't belong in the tree.

1:34 PM Changeset in webkit [1017] by sullivan

• 4 edits in trunk/WebKit

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]): Moved a line of code to prevent pluginNotFound message from being sent twice.

Fixed 2896326 -- Alexander should show an error when pluginNotFoundForMIMEType: pluginPageURL: is called

Also made the minimum change required to use Alexander without running into
assertions, until the locationChangeHandler changes are finished.

• BrowserDocument.m: (-[BrowserDocument _saveScrollPosition]), (-[BrowserDocument _restoreScrollPosition]): Commented out guts of these methods, which were triggering an assertion. (The assertion is being triggered by the in-flux state of the locationChangeHandler stuff.)

(-[BrowserDocument locationChangeStartedForFrame:]),
(-[BrowserDocument locationChangeCommittedForFrame:]),
(-[BrowserDocument locationChangeDone:forFrame:]):
Changed wording of WEBKITDEBUG messages.

(-[BrowserDocument pluginNotFoundSheetEnded:returnCode:contextInfo:]),
(-[BrowserDocument pluginNotFoundForMIMEType:pluginPageURL:]):
Implementation for sheet that appears if plugin isn't found.

1:21 PM Changeset in webkit [1016] by rjw

• 3 edits in trunk/WebKit

Fixed (removed) experimental code.

1:15 PM Changeset in webkit [1015] by darin

• 10 edits in branches/kde_3_0_merge/WebCore

Fix text to it displays at the right font size.

• src/kdelibs/khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Apply the same SCREEN_RESOLUTION hack here that we do elsewhere.
• src/kdelibs/khtml/rendering/font.cpp: (Font::width): Use kMin instead of max (oops). (Font::update): Turn off font database chicanery.
• src/kwq/KWQKHTMLPart.mm: (KHTMLPart::zoomFactor): Use zoom factor 100, not 1.

1:12 PM Changeset in webkit [1014] by rjw

• 1 edit in trunk/WebKit/Misc.subproj/WebKitDebug.m

Fixed compile problem.

1:05 PM Changeset in webkit [1013] by rjw

• 1 edit in trunk/WebKit/Misc.subproj/WebKitDebug.m

removerd o

12:56 PM Changeset in webkit [1012] by rjw

• 23 edits
  4 adds in trunk/WebKit

Changes to IFLocationChangeHandler.

Experimental allocator code, not to be used, not thread safe.!

12:26 PM Changeset in webkit [1011] by cblu

• 10 edits in trunk/WebKit

• MIME.subproj/IFContentHandler.m: (-[IFContentHandler HTMLDocument]):

Made sure I didn't unnecessarily allocate html document strings

• MIME.subproj/IFDownloadHandler.h:
• MIME.subproj/IFDownloadHandler.m: (-[IFDownloadHandler suggestedFilename]), (-[IFDownloadHandler openAfterDownload:]):

Added the mentioned API's

• MIME.subproj/IFDownloadHandlerPrivate.h:
• MIME.subproj/IFDownloadHandlerPrivate.m: (-[IFDownloadHandlerPrivate init]), (-[IFDownloadHandlerPrivate dealloc]), (-[IFDownloadHandlerPrivate _suggestedFilename]), (-[IFDownloadHandlerPrivate _cancelDownload]), (-[IFDownloadHandlerPrivate _storeAtPath:]), (-[IFDownloadHandlerPrivate _finishedDownload]), (-[IFDownloadHandlerPrivate _openAfterDownload:]), (-[IFDownloadHandlerPrivate _openFile]), (-[IFDownloadHandlerPrivate _saveFile]), (-[IFDownloadHandler _initWithURLHandle:mimeHandler:]):

Cleaned up and added a lot error checking code to IFDownloadHandlerPrivate

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]), (-[IFNullPluginView drawRect:]):

Made sure I didn't unnecessarily allocate images

• Resources/plugin_document_template.html:

Plugins now have 100% of the window

12:23 PM Changeset in webkit [1010] by darin

• 15 edits in branches/kde_3_0_merge/WebCore

More fixes so text displays (still at wrong font size).

• src/kdelibs/khtml/rendering/font.cpp: (max): New helper. (Font::drawText): Simplified implementation for now. (Font::width): Simplified implementation for now.
• src/kwq/KWQColorGroup.mm: Reinstated QCOLOR_GROUP_SIZE.

• src/kwq/qt/qfontmetrics.h: Removed charWidth and changed _width to take QChar *.
• src/kwq/KWQFontMetrics.mm: Removed charWidth and changed _width to take QChar *.

11:30 AM Changeset in webkit [1009] by darin

• 28 edits in branches/kde_3_0_merge

JavaScriptCore:

Merged changes from KDE 3.0 final and did some build fixes.

• JavaScriptCore.pbproj/project.pbxproj: Added nodes2string.cpp.

• kjs/grammar.*: Regenerated.
• kjs/*.lut.h: Regenerated.

WebCore:

Merged changes from KDE 3.0 final. Other fixes to get things compiling.

• src/kdelibs/khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setProperty): Fix unused variable.
• src/kdelibs/khtml/khtmlview.cpp: (KHTMLView::contentsContextMenuEvent): Fix unused variable.
• src/kdelibs/khtml/rendering/font.cpp: (Font::drawText), (Font::width), (Font::update): Disable special "nsbp" logic for now. We can reenable it if necessary.
• src/kdelibs/khtml/rendering/render_replaced.cpp: Fix mismerge.
• src/kdelibs/khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint): Fix unused variable.
• src/kwq/KWQApplication.mm: (QDesktopWidget::width), (QApplication::desktop): Fix mismerge.
• src/kwq/KWQColorGroup.mm: Fix QCOLOR_GROUP_SIZE.
• src/kwq/KWQFontMetrics.mm: (QFontMetrics::lineSpacing): New. (QFontMetrics::width): Remove unused optimization.
• src/kwq/qt/qfontmetrics.h: Add lineSpacing().

10:32 AM Changeset in webkit [1008] by darin

• 57 edits in branches/kde_3_0_merge

Add changes from KDE 3.0rc2 to 3.0 final.

9:50 AM Changeset in webkit [1007] by darin

• 486 edits
  2 adds in branches/kde_3_0_merge

Merged in changes from 3.0rc3 merge.

Apr 12, 2002:

7:28 PM Changeset in webkit [1006]

• 19 copies in branches/kde_3_0_merge

This commit was manufactured by cvs2svn to create branch
'kde_3_0_merge'.

7:28 PM Changeset in webkit [1005]

• 19 copies in tags/KDE_3_0_MERGE_ANCHOR

This commit was manufactured by cvs2svn to create tag
'KDE_3_0_MERGE_ANCHOR'.

7:28 PM Changeset in webkit [1004] by cblu

• 3 edits in trunk/WebKit

Fixed build failure. Forgot to make IFDownloadHandler.h
a public header.

• WebKit.pbproj/project.pbxproj:

6:03 PM Changeset in webkit [1003] by cblu

• 15 edits
  4 adds in trunk/WebKit

First implementation of IFDownloadHandler and IFDownloadHandlerPrivate.

Added:

• (void) startedDownloadWithHandler:(IFDownloadHandler *)downloadHandler
• (void) receivedProgress:(IFLoadProgress *)progress forDownloadHandler$
• (void) receivedError:(IFError *)error forDownloadHandler:(IFDownloadH$

to Alex's WebController.

Apr 11, 2002:

2:28 PM Changeset in webkit [1002] by cblu

• 24 edits
  4 adds in trunk

Added support for non-html content. Non-html content is embedded in a
contrived HTML document.

• English.lproj/IFError.strings:
• MIME.subproj/IFContentHandler.h: Added.
• MIME.subproj/IFContentHandler.m: Added. (-[IFContentHandler initWithMIMEHandler:URL:]), (-[IFContentHandler HTMLDocument]), (-[IFContentHandler dealloc]):
• MIME.subproj/IFMIMEDatabase.h:
• MIME.subproj/IFMIMEDatabase.m: (-[IFMIMEDatabase MIMEHandlerForMIMEType:]), (setMimeHandlers):
• MIME.subproj/IFMIMEHandler.h:
• MIME.subproj/IFMIMEHandler.m: (-[IFMIMEHandler initWithMIMEType:handlerType:handlerName:]), (-[IFMIMEHandler description]):
• Misc.subproj/IFError.h:
• Misc.subproj/IFError.m: (+[IFError initialize]):
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView dealloc]), (-[IFPluginView stop]):
• Resources/plugin_document_template.html: Added.
• Resources/text_document_template.html: Added.
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFMainURLHandleClient.h:
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]), (-[IFMainURLHandleClient dealloc]), (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]), (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

Apr 10, 2002:

8:32 PM Changeset in webkit [1001] by cblu

• 7 edits in trunk/WebKit

Cleaned up stream deallocations.

• Plugins.subproj/IFPluginStream.h:
• Plugins.subproj/IFPluginStream.m: (-[IFPluginStream initWithURL:mimeType:notifyData:]), (-[IFPluginStream incrementOffset:]), (-[IFPluginStream dealloc]):
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView IFURLHandleResourceDidCancelLoading:]), (-[IFPluginView IFURLHandle:resourceDidFailLoadingWithResult:]):

3:40 PM Changeset in webkit [1000] by darin

• 1 delete in branches/kde_3_0_rc_3_merge/WebCore/src/kdelibs/kjs

Remove kjs from its old location.

2:29 PM Changeset in webkit [999]

• 38 copies
  11 deletes in tags/KDE_3_0

This commit was manufactured by cvs2svn to create tag 'KDE_3_0'.

2:29 PM Changeset in webkit [998] by darin

• 1 delete in branches/kde/WebCore/src/kdelibs/kjs

Get kjs out of here since it's in JavaScriptCore now.

2:28 PM Changeset in webkit [997] by darin

• 333 edits in branches/kde/WebCore

More KDE 3.0 final sources.

2:16 PM Changeset in webkit [996] by darin

• 41 edits in branches/kde/JavaScriptCore/kjs

KDE 3.0 final versions of some files.

1:33 PM Changeset in webkit [995] by cblu

• 11 edits in trunk/WebKit/Plugins.subproj

Jersey Test

11:48 AM Changeset in webkit [994] by sullivan

• 4 edits in trunk/WebKit

Fixed 2891396 -- window fills with garbage if you resize or hide/show toolbar
before loading first page

• WebView.subproj/IFWebView.mm: (-[IFWebView drawRect:]): Made webview fill rect with white if there's no widget.

Fixed 2883815 -- JavaScript window-opening preference should mention ad suppression
Fixed 2890818 -- If Alexander window is opened when home page is invalid, sheet appears
behind window
Fixed 2896685 -- Crash in CFStringAppendCString putting up alert dialog if nonexistent file
has spaces in name

• BrowserDocument.m: (-[BrowserDocument goHome:]): Changed comments, added assert (-[BrowserDocument displayError:forFrame:withStage:]): Made error message be a parameter to format string @"%@" instead of a format string with no parameters, to handle the case where error message contains % characters that look like format characters.
• BrowserWindow.m: (-[BrowserWindow _goToInitialURLFromTimer:]): New method, called from timer, just goes to initial URL. (-[BrowserWindow windowDidLoad]): Use timer to go to initial URL, to ensure that window is visible before sheet-displaying code runs.

• Preferences.subproj/ActiveContentPreferences.nib: Added another sentence of fine print to JavaScript preferences.

11:06 AM Changeset in webkit [993] by cblu

• 2 edits in trunk/WebKit/Plugins.subproj

Jersey test

Apr 9, 2002:

4:45 PM Changeset in webkit [992] by cblu

• 7 adds in trunk/WebKit/Plugins.subproj

• Moved plug-in streams to IFPluginStream
• Put IFPluginNullEventSender to it own file.

4:44 PM Changeset in webkit [991] by cblu

• 9 edits in trunk/WebKit

• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView start]), (-[IFPluginView stop]), (-[IFPluginView dealloc]), (-[IFPluginView findSuperview:]), (-[IFPluginView sendUpdateEvent]), (-[IFPluginView drawRect:]), (-[IFPluginView isFlipped]), (-[IFPluginView viewHasMoved:]), (-[IFPluginView windowBecameKey:]), (-[IFPluginView windowResignedKey:]), (-[IFPluginView windowWillClose:]), (-[IFPluginView IFURLHandleResourceDidBeginLoading:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]), (-[IFPluginView IFURLHandleResourceDidCancelLoading:]), (-[IFPluginView IFURLHandle:resourceDidFailLoadingWithResult:]), (-[IFPluginView IFURLHandle:didRedirectToURL:]), (-[IFPluginView forceRedraw]), (IFPluginMake), (+[IFPluginView load]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFLoadProgress.h:

Cleaned up the IFPluginView code. Moved a lot of things around.

Added support for plug-in file download progress.

Apr 8, 2002:

5:17 PM Changeset in webkit [990] by mjs

• 3 edits in trunk/WebCore

Added bug number to the last ChangeLog entry:

Fix Radar 2896001 (crashes in KURL):

5:14 PM Changeset in webkit [989] by mjs

• 5 edits in trunk/WebCore

• src/kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate): Initialize refCount to 0 in the copy constructor.

2:14 PM Changeset in webkit [988]

• 19 copies in tags/TINDERBOX

This commit was manufactured by cvs2svn to create tag 'TINDERBOX'.

2:14 PM Changeset in webkit [987]

• 19 copies in tags/ALEXANDER_0_2

This commit was manufactured by cvs2svn to create tag
'ALEXANDER_0_2'.

2:14 PM Changeset in webkit [986] by mjs

• 3 edits in trunk/JavaScriptCore

Retroactively reviewed Darin's change.

2:08 PM Changeset in webkit [985] by cblu

• 16 edits in trunk

• src/kwq/KWQKHTMLPart.mm: (KHTMLPart::requestObject):
• src/kwq/WCPluginWidget.h:
• src/kwq/WCPluginWidget.mm: (WCPluginWidget::WCPluginWidget):

• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView drawRect:]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView getURLNotify:target:notifyData:]):

Support new stream requests from plug-ins that are relative URL's.

1:12 PM Changeset in webkit [984] by darin

• 7 edits in trunk

Re-added -Wno-format-y2k.

12:39 PM Changeset in webkit [983] by rjw

• 7 edits in trunk/WebKit

Added logs for Shelley to note start and completion of document load.
-WebKitLogLevel 0x1000. Also, as a bonus, note time to load.

11:51 AM Changeset in webkit [982] by cblu

• 10 edits in trunk/WebKit

• Plugins.subproj/IFNullPluginView.h:
• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]), (-[IFNullPluginView drawRect:]):
• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController pluginNotFoundForMIMEType:pluginPageURL:]):
• WebView.subproj/IFWebController.h:

Added pluginNotFoundForMIMEType: pluginPageURL: to WebKit. This gets called
by IFNullPluginView when a plug-in for a certain mime type is requested but
not installed.

10:58 AM Changeset in webkit [981] by rjw

• 6 edits in trunk/WebKit

i Added frameForView:

Cleaned up out-of-date comments.