⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 6, 2002:

9:39 PM Changeset in webkit [1287] by darin
  • 9 edits in trunk
  • Makefile.am: Update warning flags for compatibility with new C++.
  • configure.in: Update warning flags for compatibility with new C++.
  • Tools/DiskCachePeek/DiskCachePeek.pbproj/project.pbxproj: Project Builder wants what it wants.

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebKit:

  • WebKit.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
  • WebCoreSupport.subproj/IFTextRenderer.m: (FillStyleWithAttributes): Remove workaround we copied from AppKit, because it's a workaround for a bug that was fixed in Puma.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.
3:58 PM Changeset in webkit [1286] by cblu
  • 4 edits in trunk/WebKit

2002-06-06 Chris Blumenberg <​cblu@apple.com>

Added support for key codes and other encodings.
Send activate to make Java happy.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyMessageForEvent:]): added (-[IFPluginView keyUp:]): use above. (-[IFPluginView keyDown:]): use above. (-[IFPluginView windowBecameKey:]): send activate. (-[IFPluginView windowResignedKey:]): send activate.
11:55 AM Changeset in webkit [1285] by sullivan
  • 4 edits in trunk/WebKit

Previous commit didn't seem to take for some reason; trying again.

  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList removeChild:]): Added assert. (-[IFBookmarkList insertChild:atIndex:]): Set the group of the new child, and added assert.

Added Undo in the Bookmarks window for removing items and for changing
the titles and addresses of items. Also changed the image used for
Stop in the Bookmarks window per a conversation with Don and Chris
yesterday.

  • fixed 2927231 -- should be able to Undo deleting bookmarks
  • fixed 2948496 -- should be able to Undo title & address changes in Bookmarks window
  • BookmarksController.m: (-[UndoRemoveInfo initWithBookmark:]), (-[UndoRemoveInfo dealloc]), (+[UndoRemoveInfo infoWithBookmark:]): New little helper class that hangs onto the info needed to put removed bookmarks back in the right places.

(-[BookmarksController _redoRemoveBookmarks:]),
(-[BookmarksController _undoRemoveBookmarks:]): New methods
(-[BookmarksController removeSelectedBookmarks:]): Register for undo.

(-[BookmarksController _undoTitleChange:]),
(-[BookmarksController _changeTitleForBookmark:to:]),
(-[BookmarksController _undoAddressChange:]),
(-[BookmarksController _changeAddressForBookmark:to:]),
New methods used for undo/redo.

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
Register for Undo, but only if the value has actually changed.

(-[BookmarksController windowWillClose:]): Empty undo/redo stack.

  • Resources/Images/red_globe.tiff: Added, used by Stop in Downloads window.
  • Resources/Images/green_globe.tiff: Added, to be used by Resume in Downloads window.
  • Resources/Images/stop.tiff: Removed.
  • DownloadMonitor.m: (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use new Stop image.
  • WebBrowser.pbproj/project.pbxproj: Updated for new image files.
8:18 AM Changeset in webkit [1284] by darin
  • 9 edits in trunk/WebKit
  • MIME.subproj/IFContentHandler.m: (-[IFContentHandler initWithURL:MIMEType:MIMEHandlerType:]): Add call to [super init]. (-[IFContentHandler useTemplate:withGlobal:]): New helper function. Also got rid of <title> from templates, since there's no need for us to provide a fake title if it's just the URL. (-[IFContentHandler HTMLDocument]): Reduce use of copied and pasted code. (-[IFContentHandler dealloc]): Add call to [super dealloc].
  • Resources/image_document_template.html: Remove <title>.
  • Resources/plugin_document_template.html: Remove <title>.
  • Resources/text_document_template.html: Remove <title>.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Remove some unneeded type casts.

Jun 5, 2002:

5:45 PM Changeset in webkit [1283] by mjs
  • 6 edits in trunk/WebKit

Fixed Radar 2936155 - crash in IFAuthenticationPanel

  • Panels.subproj/IFAuthenticationPanel.m: (-[IFAuthenticationPanel runAsSheetOnWindow:withRequest:]): Add some assertions.

(-[IFAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
Avoid referencing instance variables after performing a selector
that might release this object. Also, add some assertions.

  • Panels.subproj/IFPanelAuthenticationHandler.m: (-[IFPanelAuthenticationHandler startAuthentication:]): Tweak whitespace.
5:33 PM Changeset in webkit [1282] by darin
  • 14 edits in trunk/WebCore

Some fixes to speed up the citibank.com page, and other related changes.

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Only do a layout if it's actually needed. This speeds things up immensely, and I'm pretty sure it's correct.
  • kwq/KWQListImpl.h: To speed things up, get rid of the "private part" level of indirection. This is particularly vital for list iterators, which are created and destroyed a lot on the stack. Also made trivial functions be inline.
  • kwq/KWQListImpl.mm: (copyList): Now a static function rather than a member of the now-defunct private class. (KWQListImpl::KWQListImpl): Set up all the new members that used to be in the separate private object. (KWQListImpl::~KWQListImpl): Update the iterator-detaching code to do it the new way, with intrusive list. Also, use clear() instead of having our own code to delete the list -- note this is only used after the level above us does a clear() anyway. (KWQListImpl::clear): Use a loop to delete all the nodes rather than making a delete of one node recursively delete the next -- iteration is more efficient, and also easier to understand in this case. Also update all the iterators so they don't point to deleted nodes. (KWQListImpl::containsRef): Update to return the count, rather than just a true or false value, since that's how the class is defined. (KWQListImpl::assign): Delete the items if asked to (fixes a FIXME). Also use a new swap member function since there's more to swap now. (KWQListImpl::addIterator): Rewrite to use an intrusive linked list. (KWQListImpl::removeIterator): Rewrite to use an intrusive linked list; this makes it much faster since it doesn't have to search the list. (KWQListImpl::swap): Implement this private member function used by assign. (KWQListIteratorImpl::KWQListIteratorImpl): Set up the new members that used to be in the separate private object.
  • kwq/qt/qlist.h: Re-add the operator= definition. This would cause a storage leak, although I haven't actually observed the leak.
  • kwq/qt/qbuffer.h: Initialize opened to false. This was causing a test failure.
  • kwq/KWQDictImpl.h:
  • kwq/KWQDictImpl.mm: Streamline implementation a bit by getting rid of unneeded copy constructor definition and making trivial constructor for iterator inline.
  • kwq/KWQPtrDictImpl.h: Remove unneeded include.
  • WebCore-tests.exp: Update for changes in the entry points used by the tests.
4:49 PM Changeset in webkit [1281] by rjw
  • 4 edits in trunk/WebKit

Fixed snafu in recursion over frame tree.

4:49 PM Changeset in webkit [1280] by rjw
  • 8 edits in trunk/WebCore

Fixed 2938552. This required an implementation of KHTMLPart::frames which
is used by the JS window.frames property.

2:22 PM Changeset in webkit [1279] by darin
  • 4 edits in trunk/JavaScriptCore

Fix problem seen as build failure on Jersey.

  • Makefile.am: JavaScriptCore-stamp needs to be a dependency, not a source file, because it doesn't have a corresponding object file. Making it a dependency causes things to compile in the right order.
2:14 PM Changeset in webkit [1278] by rjw
  • 8 edits in trunk/WebCore

Fixed window.top JS property (2939353). This caused funny recursion problems at www.megapixel.net and other pages that try to pop frames.

1:25 PM Changeset in webkit [1277] by rjw
  • 6 edits in trunk/WebCore

Cleaned up call to frameNamed:. Now use frame relative naming.
Fixed various frame related bugs (including www.heinz.com).

1:24 PM Changeset in webkit [1276] by rjw
  • 5 edits in trunk/WebKit

i Normalized frame naming. (We still don't support cross

window name lookups.)

Jun 4, 2002:

4:47 PM Changeset in webkit [1275] by rjw
  • 8 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::timerEvent): (KWQKHTMLPartImpl::redirectURL):

Renamed redirectJS to redirectURL to more correctly reflect it's
function.

(KWQKHTMLPartImpl::urlSelected):

Fixed 2935505. We now pop out of a frame if a link is clicked in a frame
and that frame is the only frame in a frameset. This emulates the behavior of IE.

  • kwq/KWQKHTMLPartImpl.h:
  • kwq/external.h:
4:27 PM Changeset in webkit [1274] by cblu
  • 11 edits in trunk/WebKit

WebBrowser:

Added the Downloads window!

  • AppController.h:
  • AppController.m: (-[AppController showReleaseNotes:]): no changes (-[AppController showDownloads:]): added for menu item
  • DownloadMonitor.h:
  • DownloadMonitor.m: Removed protocol conforming (-[DownloadMonitor init]): (+[DownloadMonitor sharedDownloadMonitor]): (-[DownloadMonitor windowDidLoad]): added (-[DownloadMonitor updateProgressUI]): added (-[DownloadMonitor _findEntryForDataSource:]): minor clean up (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:]): spawns progress timer (-[DownloadMonitor validateUserInterfaceItem:]): added (-[DownloadMonitor makeSelectedDownloadsPerformSelector:]): added (-[DownloadMonitor openSelectedDownloads:]): added (-[DownloadMonitor alwaysOpenSelectedDownloads:]): added (-[DownloadMonitor stopSelectedDownloads:]): added (-[DownloadMonitor revealSelectedDownloads:]): added (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): added (-[DownloadMonitor toolbarAllowedItemIdentifiers:]): added (-[DownloadMonitor toolbarDefaultItemIdentifiers:]): added
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: Made DownloadProgressEntry own the download entry subview (-[DownloadProgressEntry _initWithResource:progress:error:dataSource:]): (-[DownloadProgressEntry dealloc]): (-[DownloadProgressEntry URLStringResized:]): added (-[DownloadProgressEntry awakeFromNib]): added (-[DownloadProgressEntry updateProgressUI]): added (-[DownloadProgressEntry open]): added (-[DownloadProgressEntry alwaysOpen]): added (-[DownloadProgressEntry stop]): added (-[DownloadProgressEntry reveal]): added (-[DownloadProgressEntry view]): added
  • English.lproj/DownloadEntry.nib: Added.
  • English.lproj/Downloads.nib: Added.
  • English.lproj/MainMenu.nib: added Downloads to menu
  • ListView.h: Added.
  • ListView.m: Added. Simple class that appends views to each other. Implements selection. (-[ListView initWithFrame:]): (-[ListView dealloc]): (-[ListView drawRect:]): (-[ListView acceptsFirstResponder]): (-[ListView mouseDown:]): (-[ListView isFlipped]): (-[ListView isOpaque]): (-[ListView validateUserInterfaceItem:]): (-[ListView addViewToList:]): (-[ListView isSelectedView:]): (-[ListView setDelegate:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]): Better filename from URL algorithm
  • ResourceProgressEntry.h: Made error and statusString public
  • Resources/Images/always_open.tiff: Added.
  • Resources/Images/open.tiff: Added.
  • Resources/Images/reveal.tiff: Added.
  • Resources/Images/stop.tiff: Added.
  • WebBrowser.pbproj/project.pbxproj:

WebKit:

  • MIME.subproj/IFDownloadHandler.mm: Use public methods
  • WebView.subproj/IFWebDataSource.h: Made downloadPath public
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource downloadPath]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm:
3:49 PM Changeset in webkit [1273] by rjw
  • 10 edits in trunk

More exclusion for pre 6C48.

3:33 PM Changeset in webkit [1272] by darin
  • 9 edits in trunk/JavaScriptCore

Improve the speed of the JavaScript string append operation by growing
the capacity so we don't need to reallocate the string every time.

Also fix script execution so it doesn't use recursion to advance from
one statement to the next, using iteration instead.

  • Makefile.am: Stop using BUILT_SOURCES to build JavaScriptCore-stamp, because this causes the Project Builder project to build *before* the subdir. Intead, use an all-am rule in a way more similar to all our other directories.
  • kjs/grammar.y: Link the SourceElementsNode in the opposite direction, so we can walk the list and execute each element instead of using recursion to reverse the list.
  • kjs/grammar.cpp: Check in new generated file.
  • kjs/nodes.cpp: (SourceElementsNode::execute): (SourceElementsNode::processFuncDecl): (SourceElementsNode::processVarDecls): Use loops instead of recursion.
  • kjs/ustring.h: Don't initialize all UChar objects to 0. This was wasting a *huge* amount of time.
  • kjs/ustring.cpp: (UString::Rep::create): Add a "capacity" along with the length. (UString::append): Include 50% extra capacity when appending. (UString::operator=): Reuse the buffer if possible rather than always creating a new one.
3:16 PM Changeset in webkit [1271] by kocienda
  • 7 edits in trunk

2002-06-04 Kenneth Kocienda <​kocienda@apple.com>

  • WebCore/kwq/kwqdebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
  • WebFoundation/Misc.subproj/WebFoundationDebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
  • WebKit/Misc.subproj/WebKitDebug.h: Added a line of stderr output into the assertion failure code so that we have some idea of what happened.
3:06 PM Changeset in webkit [1270] by rjw
  • 4 edits in trunk/WebKit

Excluded call to new API until everyone has moved to >= 6C48.

12:17 PM Changeset in webkit [1269] by darin
  • 2 edits in trunk/WebKit

Fix stray chars in log.

11:55 AM Changeset in webkit [1268] by rjw
  • 21 edits in trunk

Changes to support progressive image loading. Currently disabled
until 2945218 is fixed.

11:03 AM Changeset in webkit [1267] by darin
  • 2 edits in trunk/WebKit

oops, forgot to save ChangeLog

11:02 AM Changeset in webkit [1266] by darin
  • 4 edits in trunk/WebKit
  • fixed 2932862 -- exception -[NSCFArray getObjects:range:]: index (137) beyond bounds (10)
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _stopPlugins]): (-[IFWebView _removeSubviews]): Make a copy of the subviews list so that changes to the list don't screw up the iterating logic.
10:34 AM Changeset in webkit [1265] by sullivan
  • 10 edits in trunk/WebKit

Made changes here while working on Undo for removing history entries.

  • History.subproj/IFWebHistory.h: New methods addEntries: and removeEntries:, deleted method removeEntriesForDay: (use removeEntries: instead).
  • History.subproj/IFWebHistory.m: (-[IFWebHistory addEntries:]), (-[IFWebHistory removeEntries:]): New methods, each takes an array of entries. Useful for doing multiple things at a time to minimize notifications. (-[IFWebHistory removeEntriesForDay:]): deleted this now-unnecessary method.
  • History.subproj/IFWebHistoryPrivate.h:
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntries:]): (-[IFWebHistoryPrivate removeAllEntries]): (-[IFWebHistoryPrivate addEntries:]): Private implementations for the public changes.
  • fixed 2867813 -- should be able to Undo deleting history entries.
  • fixed awkwardness where item in Bookmarks window would have its name selected for edit when you made a multiple selection.
  • GlobalHistory.h: added _performingUndoableAction ivar; removed removeAll.
  • GlobalHistory.m: (-[GlobalHistory receivedEntriesChangedNotification:]): if not _performingUndoableAction, throw away undo/redo stacks when change comes in.

(-[GlobalHistory windowWillClose:]):
Throw away undo/redo stacks when window closes, to minimize
memory use.

(-[GlobalHistory removeSelectedItems:]):
Collect up items to remove and then remove them in one batch;
register for undo with _undoRemoveEntries. No longer special-case
removeAll.

(-[GlobalHistory _undoRemoveEntries:]):
Restore items previously removed; register for undo with
_removeEntries (since we don't restore selection, for various
reasons to boring to go into here).

(-[GlobalHistory _removeEntries:]): Remove again items previously
restored; register for undo with _undoRemoveEntries.

(-[GlobalHistory selectAll:]): Removed obsolete comment.

  • OutlineViewPlus.m: (-[OutlineViewPlus mouseDown:]): Only edit the clicked cell if it's the only selected row.
10:19 AM Changeset in webkit [1264] by darin
  • 3 edits in trunk/WebKit
  • fixed 2943513 -- move StringTruncator into WebKit from WebBrowser so we don't need text measuring API exported
  • WebKit.pbproj/project.pbxproj: No longer export the text renderer headers as Private.
10:14 AM Changeset in webkit [1263] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Exported IFStringTruncator.h as Private.
10:09 AM Changeset in webkit [1262] by darin
  • 3 edits
    4 adds in trunk/WebKit

Moved the string truncator class here from WebBrowser so we don't have to
export our text machinery.

  • WebKit.pbproj/project.pbxproj:
  • Misc.subproj/IFStringTruncator.h: Added.
  • Misc.subproj/IFStringTruncator.m: Added.
9:47 AM Changeset in webkit [1261] by darin
  • 4 edits in trunk/WebCore
  • fixed 2943897 -- Initial uncached load of amazon.com renders partial page.
  • khtml/khtml_part.cpp: (KHTMLPart::setEncoding): Put the code that reloads the page when the encoding is changed back inside APPLE_CHANGES. This was causing partial loads because of how it interacts with our way of saving up text and not decoding until we discover what the encoding is.

Jun 3, 2002:

10:23 PM Changeset in webkit [1260] by darin
  • 10 edits
    2 deletes in trunk/WebCore
  • LICENSE: Add 2002.
  • kwq/KWQApplication.mm:
  • kwq/kdecore/kapplication.h:
  • kwq/qt/qapplication.h: Found a way to simplify the application objects by making more of the functions static so we don't need to actually allocate an object.
  • kwq/Makefile.am:
  • kwq/KWQKApplication.mm: Removed.
  • kwq/kdecore/kapp.h: Removed.
8:40 PM Changeset in webkit [1259] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): Remove the "fix" for the nonexistent storage leak. Richard showed me the error of my ways.
6:01 PM Changeset in webkit [1258] by darin
  • 4 edits
    3 deletes in trunk/WebCore

A few more unused things.

  • kwq/Makefile.am: Removed KWQKProcess.mm
  • kwq/KWQKProcess.mm: Removed.
  • kwq/KWQStrList.h: Removed.
  • kwq/kdecore/kprocess.h: Removed.
5:53 PM Changeset in webkit [1257] by darin
  • 3 edits
    2 adds in trunk/WebCore

Forgot one file.

  • kwq/qt/qframe.h: Added.
5:19 PM Changeset in webkit [1256] by darin
  • 163 edits
    2 adds
    4 deletes in trunk/WebCore
  • acconfig.h: Remove APPLE_CHANGES (done in compiler invocation), _KWQ_ (not needed any more), _KWQ_PEDANTIC_ (not needed any more), and _KWQ_IOSTREAM_ (set by KWQDef.h now).
  • configure.in: Remove explict gcc3 and g++3; not needed on Jaguar. Remove APPLE_CHANGES, _KWQ_, _KWQK_PEDANTIC_, and _KWQ_IOSTREAM_. Do an AC_SUBST on COMMON_CFLAGS so the flags are used to generate the .pfe files. Add conditional stuff so that WebCore exports less and the Tests subdirectory is not build in Deployment style builds.
  • Makefile.am: Only build Tests subdir when configure.in says it should.
  • Tests/draw/*: Removed.
  • Tests/qt/qbuffer-test.cpp: (main): Update for QBuffer changes.
  • Tests/qt/qrect-test.cpp: (main): Remove unused variable.
  • Tools/jersey/README: Fix newlines.
  • Tools/jersey/html/advanced.html: Fix newlines.

WebCore:

Get rid of many unneeded APPLE_CHANGES.
Also get rid of _KWQ_ and _KWQ_PEDANTIC_.

  • WebCore.exp: Don't export DomShared::ref/deref any more.
  • WebCore-tests.exp: Changed around as needed due to changes in the classes being tested.
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: Simplified APPLE_CHANGES for better merging.
  • khtml/dom/dom_misc.h:
  • khtml/dom/dom_misc.cpp:
  • khtml/dom/html_document.cpp:
  • khtml/khtmlview.cpp:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/misc/helper.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_text.cpp:
  • khtml/xml/xml_tokenizer.h:
  • kwq/qt/qtextedit.h: Remove now-unneeded APPLE_CHANGES.
  • khtml/misc/loader.cpp: (CachedImage::pixmap): Turned off more of the QMovie code.
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/xml/dom_elementimpl.h:
  • kwq/KWQKHTMLPart.mm: Formatting and other minor tweaks.
  • kwq/KWQApplication.mm: (QApplication::sendEvent): Implemented.
  • kwq/KWQChar.mm: (QChar::direction): Improved implementation.
  • kwq/KWQCollection.h: Removed.
  • kwq/KWQIcon.h: Removed.
  • kwq/Makefile.am: Removed following files.
  • kwq/KWQKCompletionBox.mm: Removed.
  • kwq/KWQKFactory.mm: Removed.
  • kwq/KWQListBox.mm: Removed.
  • kwq/KWQKImageIO.mm: Removed.
  • kwq/KWQObject.mm: (QObject::event): Added, does nothing. (QObject::inherits): Put in real implementation (good enough for us).
  • kwq/WCWebDataSource.h: Removed extern declaration of global.
  • kwq/KWQCursor.mm: (QCursor::handle): Made the handle be an NSCursor *.
  • kwq/external.h: Moved [IFWebView setFrameSize:] here. Got rid of IFAnimatedImage.
  • kwq/KWQDef.h: Remove unused Q_INT8, Q_INT16, Q_UINT8, Q_UINT16, QCOORD, WFlags, WId, ASSERT, CHECK_PTR, Q_EXPORT, Q_PACKED, QT_STATIC_CONST, QT_STATIC_CONST_IMPL. Define _KWQ_IOSTREAM_ only when NDEBUG is not defined.
  • kwq/KWQBuffer.mm:
  • kwq/KWQCString.mm:
  • kwq/KWQCollection.mm:
  • kwq/KWQCompletion.h:
  • kwq/KWQCompletion.mm:
  • kwq/KWQFrame.h:
  • kwq/KWQFrame.mm:
  • kwq/KWQHBox.mm:
  • kwq/KWQKFileItem.mm:
  • kwq/KWQKIconLoader.mm:
  • kwq/KWQKLineEdit.mm:
  • kwq/KWQKProtocolManager.mm:
  • kwq/KWQLabel.mm:
  • kwq/KWQListBox.h:
  • kwq/KWQMovie.mm:
  • kwq/KWQWidget.mm:
  • kwq/KWQxml.mm:
  • kwq/qt/qbuffer.h:
  • kwq/kdecore/kdebug.h:
  • kwq/kdecore/kglobal.h:
  • kwq/kdecore/kglobalsettings.h:
  • kwq/kdecore/kiconloader.h:
  • kwq/kdecore/kstaticdeleter.h:
  • kwq/kdecore/kstringhandler.h:
  • kwq/kdeui/kcombobox.h:
  • kwq/kdeui/kcompletionbox.h:
  • kwq/kdeui/klineedit.h:
  • kwq/kdeui/klistbox.h:
  • kwq/kdeui/kmessagebox.h:
  • kwq/kio/kfileitem.h:
  • kwq/kio/kimageio.h:
  • kwq/kio/kmimetype.h:
  • kwq/kio/kprotocolmanager.h:
  • kwq/kio/netaccess.h:
  • kwq/qt/qxml.h:
  • kwq/kparts/browserinterface.h:
  • kwq/kparts/factory.h:
  • kwq/kparts/part.h:
  • kwq/qt/qarray.h:
  • kwq/qt/qcollection.h:
  • kwq/qt/qcstring.h:
  • kwq/qt/qcursor.h:
  • kwq/qt/qdict.h:
  • kwq/qt/qhbox.h:
  • kwq/qt/qlabel.h:
  • kwq/qt/qlist.h:
  • kwq/qt/qmap.h:
  • kwq/qt/qmovie.h:
  • kwq/qt/qobject.h:
  • kwq/qt/qpaintdevicemetrics.h:
  • kwq/qt/qpainter.h:
  • kwq/qt/qpoint.h:
  • kwq/qt/qradiobutton.h:
  • kwq/qt/qrect.h:
  • kwq/qt/qregion.h:
  • kwq/qt/qscrollview.h:
  • kwq/qt/qsize.h:
  • kwq/qt/qstack.h:
  • kwq/qt/qstringlist.h:
  • kwq/qt/qtextedit.h:
  • kwq/qt/qvaluelist.h:
  • kwq/qt/qvector.h:
  • kwq/qt/qwidget.h:
  • kwq/qt/qxml.h: Removed unused stuff.
  • kwq/KWQListBox.mm:
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQPoint.mm:
  • kwq/KWQRadioButton.mm:
  • kwq/KWQRect.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollView.mm:
  • kwq/KWQSize.mm:
  • kwq/KWQStringList.mm:
  • kwq/KWQbrowserinterface.mm: Simplified.
  • kwq/kdecore/kurl.h: Added include to match what's expected by clients.
  • kwq/qt/qobjectlist.h: Added. Empty file to make includers happy.
  • kwq/khtml/khtml_printsettings.h: Added. Empty file.
  • kwq/qt/qobjectlist.h: Added. Empty file.
  • kwq/kio/kssl/ksslkeygen.h: Define just enough to make callers happy.
  • kwq/qt/qobject.h: Added event().
  • kwq/kparts/part.h: Added bool return type to event().
  • kwq/qt/qvector.h: Added QGVector base class.
2:35 PM Changeset in webkit [1255] by sullivan
  • 4 edits in trunk/WebKit

Richard told me which line to change to fix 2944237
(Stop item in View menu enabled on startup if you have
no home page.)

  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource isLoading]): Don't return YES if !_private->loading.
  • fixed 2943189 -- Single-click to edit in Bookmarks window should wait for double-click interval.
  • OutlineViewPlus.h: new _startEditTimerOnMouseUp instance variable
  • OutlineViewPlus.m: (-[OutlineViewPlus _cancelEditOnMouseUp]): clear _startEditTimerOnMouseUp as well as cancelling timer.

(-[OutlineViewPlus dragImageForRows:event:dragImageOffset:]):
clear _startEditTimerOnMouseUp variable.

(-[OutlineViewPlus mouseDown:]): Don't start timer until mouseUp,
since double-click interval is defined from mouseUp to mouseDown;
use _startEditTimerOnMouseUp variable beforehand so dragging can
cancel pending edit.

  • BrowserDocument.m: (-[BrowserDocument isLoading]): Tweaked this method while debugging another problem; liked the new formulation better.

Jun 2, 2002:

4:16 PM Changeset in webkit [1254] by darin
  • 4 edits in trunk/JavaScriptCore
  • COPYING.LIB: Fix line endings. It was using CRs.

Jun 1, 2002:

12:40 PM Changeset in webkit [1253] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): Remove an assert I added, since it is firing, and instead fixed the storage leak that inspired me to put the assert in.
9:32 AM Changeset in webkit [1252] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQPtrDictImpl.mm: (KWQPtrDictPrivate::~KWQPtrDictPrivate): Fix compile error.

May 31, 2002:

11:07 PM Changeset in webkit [1251] by darin
  • 7 edits in trunk/WebCore

Fix infinite loop while cancelling bug that was caused by dictionary
iterators not getting updated when keys are removed.

  • kwq/KWQPtrDictImpl.mm: (KWQPtrDictPrivate::KWQPtrDictPrivate): Set iterators list to 0. (KWQPtrDictPrivate::~KWQPtrDictPrivate): Tell iterators dict is gone. (KWQPtrDictImpl::remove): Tell each iterator that the item was removed. (KWQPtrDictIteratorPrivate::KWQPtrDictIteratorPrivate): Insert the iterator into a list with a head stored in the dict. (KWQPtrDictIteratorPrivate::~KWQPtrDictIteratorPrivate): Remove the iterator from the list. (KWQPtrDictIteratorPrivate::remove): Remove the key from the iterator's private storage. (KWQPtrDictIteratorPrivate::dictDestroyed): Clear out the dict pointer and set the count to 0.
  • kwq/KWQPtrDictImpl.h: Move private classes out so they can get at each other without being friends of each other.
  • kwq/qt/qptrdict.h: Simplify a bit.
8:57 PM Changeset in webkit [1250] by darin
  • 7 edits in trunk/WebCore
  • khtml/khtmlview.h: Add KWQKHTMLPartImpl as friend class, remove khtml_part.h include that we added inside APPLE_CHANGES.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::end): Reinstate a line of code that required friend status.
  • kwq/KWQView.mm: Add include of khtml_part.h.
6:11 PM Changeset in webkit [1249] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebViewPrivate.mm: Add include to prepare for change to WebCore that will make it required.
5:04 PM Changeset in webkit [1248] by darin
  • 4 edits in trunk/WebCore
  • kwq/kwqdebug.h: Don't use displayableString; it's an SPI and those are no nos inside WebCore.
5:03 PM Changeset in webkit [1247] by darin
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.h: Fixed the line endings (they were Macintosh CRs instead of Unix LFs). Also made all the methods be private for now since there's no need to have them be public.
  • WebCoreSupport.subproj/IFImageRenderer.m: Fixed the line endings (they were Macintosh CRs instead of Unix LFs). Some minor code tweaks too sharing a bit more code.
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRendererWithSize:]): Return an IFImageRenderer rather than just an NSImage, since an NSImage does not satisfy WebCoreImageRenderer.
11:33 AM Changeset in webkit [1246] by darin
  • 14 edits
    1 delete in trunk/WebCore
  • kwq/kio/jobclasses.h: Removed SimpleJob and made Job just enough for TransferJob to inherit from it. Removed unused stuff and made url() return an NSURL rather than a KURL.
  • kwq/KWQKjobclasses.mm: Removed much of the code, and reworked what remains to simplify it.
  • kwq/KWQKloader.mm: Update users of TransferJob::url since it now returns an NSURL rather than a KURL.
  • kwq/kio/job.h: Simplify.
  • kwq/KWQKJob.mm: Simplify.
  • kwq/kio/scheduler.h: Emptied this file out.
  • kwq/KWQKScheduler.mm: Removed.
  • kwq/Makefile.am: Removed KWQKScheduler.mm.
7:35 AM Changeset in webkit [1245] by darin
  • 82 edits
    6 adds
    19 deletes in trunk/WebCore

Remove some unused stuff; total of 1000s of lines.

  • Makefile.am: Removed some strange uses of "./" and improved stamp-related rules.
  • WebCore-tests.exp: Removed QDir functions.
  • khtml/Makefile.am: Removed java subdirectory.
  • khtml/java/*: Removed.
  • khtml/rendering/render_applet.cpp: Rearrange APPLE_CHANGES so that we use our own KJavaAppletWidget rather than a QWidget.
  • kwq/khtml/java/kjavaappletcontext.h: Added.
  • kwq/khtml/java/kjavaappletwidget.h: Added.
  • kwq/KWQKJavaAppletWidget.mm: Added. Replaces WCJavaAppletWidget.mm.
  • kwq/KWQsignals.mm: Removed java-related signals.
  • khtml/css/Makefile.am:
  • khtml/misc/Makefile.am: Improve stamp-related rules.
  • khtml/misc/loader.cpp: Move around and add ifdefs so we don't need as much KWQ code. Maybe revisit this later -- related to the KDE implementation of animated and progressive loading images, which we probably don't need, but it may integrate slightly better than doing our hacks inside QPixmap.
  • kwq/KWQApplication.mm:
  • kwq/KWQFontInfo.mm:
  • kwq/KWQInputDialog.mm:
  • kwq/KWQKFileDialog.mm:
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKWin.mm:
  • kwq/KWQKWinModule.mm:
  • kwq/KWQKstddirs.mm:
  • kwq/KWQPixmap.mm: Simplified, removed unused code, minor tweaks.
  • kwq/Makefile.am: Removed all the old files, added some new ones.
  • kwq/KWQBitmap.mm: Removed.
  • kwq/KWQBrush.mm: Removed.
  • kwq/KWQDCOPClient.mm: Removed.
  • kwq/KWQDataStream.h: Removed.
  • kwq/KWQDir.mm: Removed.
  • kwq/KWQFontDatabase.mm: Removed.
  • kwq/KWQImage.mm: Removed.
  • kwq/KWQKInstance.mm: Removed.
  • kwq/KWQPaintDevice.mm: Removed.
  • kwq/KWQPart.mm: Removed.
  • kwq/KWQasyncimageio.mm: Removed.
  • kwq/KWQasyncio.mm: Removed.
  • kwq/KWQbrowserextension.mm: Removed.
  • kwq/WCJavaAppletWidget.h: Removed.
  • kwq/WCJavaAppletWidget.mm: Removed.
  • kwq/qt/qdatastream.h: Removed.
  • kwq/qt/qdir.h: Removed.
  • kwq/qt/qlayout.h: Removed.
  • kwq/KWQCursor.mm: (QCursor::handle): Return the cursor object as an integer rather than just returning 0; makes the code that uses handle() more likely to work although it introduces a 64-bit cleanliness problem.
  • kwq/KWQEvent.mm: Initialize event type in QEvent subclasses.
  • kwq/WebCoreImageRenderer.h: Added NSObject and NSCopying protocols to the WebCoreImageRenderer protocol.
  • kwq/kwqdebug.h: Use displayableString in DEBUG_OBJECT for better logging.
  • kwq/dcop/dcopclient.h:
  • kwq/kdecore/kstddirs.h:
  • kwq/kdecore/kwin.h:
  • kwq/kdecore/kwinmodule.h:
  • kwq/kfile/kfiledialog.h:
  • kwq/kparts/browserextension.h:
  • kwq/kparts/event.h:
  • kwq/qt/qapplication.h:
  • kwq/qt/qasyncimageio.h:
  • kwq/qt/qasyncio.h:
  • kwq/qt/qbitmap.h:
  • kwq/qt/qbrush.h:
  • kwq/qt/qbutton.h:
  • kwq/qt/qcheckbox.h:
  • kwq/qt/qcollection.h:
  • kwq/qt/qcolor.h:
  • kwq/qt/qcombobox.h:
  • kwq/qt/qcursor.h:
  • kwq/qt/qdrawutil.h:
  • kwq/qt/qevent.h:
  • kwq/qt/qfont.h:
  • kwq/qt/qfontdatabase.h:
  • kwq/qt/qfontinfo.h:
  • kwq/qt/qimage.h:
  • kwq/qt/qinputdialog.h:
  • kwq/qt/qintcache.h:
  • kwq/qt/qintdict.h:
  • kwq/qt/qpaintdevice.h:
  • kwq/qt/qpixmap.h:
  • kwq/qt/qstring.h: Removed lots of unused stuff, including old conditionals and the like.
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent): Add missing parenthesis.
7:05 AM Changeset in webkit [1244] by darin
  • 5 edits in trunk/JavaScriptCore
  • Makefile.am:
  • kjs/Makefile.am: Slight improvements to rules that touch stamp files.
7:05 AM Changeset in webkit [1243] by darin
  • 5 edits in trunk/WebKit
  • Misc.subproj/WebKitDebug.h: Use displayableString in DEBUG_OBJECT for nicer logging.
  • WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): (-[IFWebView keyUp:]): Use DEBUG_OBJECT so we don't get exceptions when the key characters are not simple ASCII characters.

May 30, 2002:

6:48 PM Changeset in webkit [1242] by rjw
  • 6 edits in trunk/WebKit

API and comment cleanup.

5:41 PM Changeset in webkit [1241] by mjs
  • 36 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): #ifdef'd out some parts of this code that are broken (but fortunately also unnecessary) in our project.
  • kwq/KWQKConfigBase.mm: (KConfig::KConfig): Changes to support JavaScript window opening pref. (KConfig::readUnsignedNumEntry): Likewise.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::openURLInFrame): Implemented.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): Implemented. (KHTMLPartBrowserExtension::openURLRequest): Implemented by calling openURLInFrame on the part. (KHTMLPartBrowserExtension::createNewWindow): Implemented by calling new WebController openNewWindowWIthURL method.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::isJavaScriptEnabled): Handle renaming of pref.
  • kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Fixes to set cursor properly even if none was set.
  • kwq/external.h: Declare some new WebKit methods.
  • kwq/kparts/browserextension.h: Make formerly empty methods pure virtual.
  • kwq/khtml/khtml_ext.h: Declare some virtual methods.

WebKit:

WebKit parts of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

  • WebView.subproj/IFWebController.h: Added openNewWindowWithURL: method for the benefit of JavaScript.
  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController openNewWindowWithURL:]): No-op default implementation.
  • WebView.subproj/IFDynamicScrollBarsView.h:
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView setCursor:]): Fix cursor handling. (-[IFDynamicScrollBarsView resetCursorRects]): Likewise.
  • WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Likewise. (-[IFWebView setCursor:]): Likewise.
  • WebView.subproj/IFPreferences.h:
  • WebView.subproj/IFPreferences.mm: (-[IFPreferences javaScriptEnabled]): Renamed from jScriptEnabled. (-[IFPreferences setJavaScriptEnabled:]): Renamed from setJScriptEnabled. (-[IFPreferences javaScriptCanOpenWindowsAutomatically]): New method. (-[IFPreferences setJavaScriptCanOpenWindowsAutomatically:]): Likewise.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): Create a dummy provisional data source if none is provided, so we always have a part for the frame.

WebBrowser:

2:52 PM Changeset in webkit [1240] by darin
  • 61 edits
    6 adds
    1 delete in trunk

WebCore:

Cut down our copied and pasted code even more.

  • WebCore.exp: Change what's exported for things that moved from KHTMLPart into KWQKHTMLPartImpl.
  • khtml/.cvsignore:
  • khtml/css/.cvsignore:
  • khtml/dom/.cvsignore:
  • khtml/ecma/.cvsignore:
  • khtml/html/.cvsignore:
  • khtml/java/.cvsignore:
  • khtml/misc/.cvsignore:
  • khtml/rendering/.cvsignore:
  • khtml/xml/.cvsignore: Some .cvsignore hygiene.
  • khtml/khtml_part.cpp: Use a lot more of this file, rather than using a copy inside the kwq directory. Now we have KWQKHTMLPartImpl for the part that does need to be in kwq.
  • khtml/khtml_part.h: Add KWQKHTMLPartImpl pointer, remove most of the other APPLE_CHANGES.
  • khtml/khtmlpart_p.h: Remove almost all of the APPLE_CHANGES.
  • kwq/KWQKHTMLPart.mm: Changed everything from being part of KHTMLPart to be a separate KWQKHTMLPartImpl class. Minimized copied and pasted code; still more to do.
  • kwq/KWQKHTMLPartImpl.h: Added. Interface so KHTMLPart can call into kwq as necessary.
  • khtml/misc/Makefile.am: Added loader.cpp.
  • khtml/misc/loader.cpp: Added from KDE 3.0. Rolled most of the changes from KWQKloader.mm in here. The kwq-specific part is now in a KWQLoaderImpl class.
  • khtml/misc/loader.h: Replace LoaderPrivate with KWQLoaderImpl.
  • khtml/misc/loader.moc: Added empty file.
  • kwq/KWQKloader.mm: Changed everything to be a separate KWQLoaderImpl class. Minimized copied and pasted code.
  • kwq/KWQLoaderImpl.h: Added. Interface so loader can call into kwq as necessary.
  • kwq/loader.moc: Removed empty file.
  • kwq/kparts/historyprovider.h: Add HistoryProvider::insert.
  • kwq/KWQKHistoryProvider.mm: Add HistoryProvider::insert.
  • kwq/KWQKLocale.mm: (KLocale::language): Simplify.
  • kwq/KWQListBox.h:
  • kwq/KWQNSTextField.h: Use import instead of include for Cocoa.h.
  • kwq/KWQScrollView.mm: (QScrollView::contentsToViewport): Implement this.
  • kwq/external.h: Add declarations so this can be included cleanly.
  • kwq/khtml/khtml_pagecache.h: Put a no-op cache in here so we don't have to do so many APPLE_CHANGES ifdefs.
  • kwq/kparts/part.h: Put ref/deref and event/customEvent in here so they don't need to be added to KHTMLPart.
  • kwq/kio/scheduler.h: Add <qtimer.h> include to help us build (not sure if it's really needed.
  • kwq/kparts/partmanager.h: Add <qdatetime.h> include to help us build (not sure if it's really needed.

WebKit:

Use methods in KWQKHTMLPartImpl that were moved there from KHTMLPart.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]):
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentText]):
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView provisionalDataSourceChanged:]):
2:01 PM Changeset in webkit [1239] by mjs
  • 4 edits in trunk/JavaScriptCore
  • THANKS: Demangled.
11:55 AM Changeset in webkit [1238] by cblu
  • 6 edits in trunk/WebKit

Use NSWorkspace methods instead of Launch Services and Finder functions.

  • MIME.subproj/IFDownloadHandler.h:
  • MIME.subproj/IFDownloadHandler.mm:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
9:15 AM Changeset in webkit [1237]
  • 7 copies
    1 delete in tags/Alexander-7

This commit was manufactured by cvs2svn to create tag 'Alexander-7'.

9:15 AM Changeset in webkit [1236] by sheridan
  • 8 edits in trunk

Alex-7 version

8:38 AM Changeset in webkit [1235] by rjw
  • 4 edits in trunk/WebKit

Added 'canDraw' check to ensure that we can render
an image frame.

May 29, 2002:

10:13 PM Changeset in webkit [1234] by rjw
  • 10 edits
    3 adds in trunk/WebCore

Changes to support animated image rendering.
Moved image rendering into webkit.

10:12 PM Changeset in webkit [1233] by rjw
  • 13 edits
    8 adds in trunk/WebKit

Changes to support animated image rendering.
Moved image rendering into webkit.
Still need to implement preferences stubs and
start/stop stubs.

1:26 PM Changeset in webkit [1232] by sullivan
  • 4 edits in trunk/WebKit

Removed acceptsFirstMouse override, this fixes at least:

2930713 -- clicking on an empty part of window to bring it to front
takes focus away from page address field

2938028 -- Link cursor doesn't appear when browser window not
frontmost, but clicks activate links

  • WebView.subproj/IFWebView.mm:

May 28, 2002:

5:00 PM Changeset in webkit [1231] by rjw
  • 6 edits in trunk/WebCore

Moved cancellation check before creation on job instance,
preventing leak.

4:55 PM Changeset in webkit [1230] by sullivan
  • 16 edits in trunk/WebKit

Made -[IFBookmark group] and -[IFBookmark parent] public
methods, and renamed them to not use leading underscores,
as part of support for revealing a particular bookmark in
the Bookmarks window.

  • Bookmarks.subproj/IFBookmark_Private.h: removed _group and _parent.
  • Bookmarks.subproj/IFBookmark.h: added group and parent.
  • fixed 2923488 -- Silent failure when bookmark URL is invalid URL
  • fixed 2935830 (urls in Bookmarks should be "canonicalized" like urls in location field)
  • fixed 2935388 (errors in Activity window shouldn't show numeric error codes)
  • IFBookmarkAdditions.h: Added.
  • IFBookmarkAdditions.m: Added. (-[IFBookmark goTo]): New category, adds browser-specific behavior to IFBookmark. The first and only method so far goes to the bookmark's address; if the address string can't be turned into a valid URL, the user is told and given an opportunity to fix the address.
  • AppController.h:
  • AppController.m: (-[AppController showBookmarks:]): Moved initialization of _bookmarksController ivar out of here. (-[AppController _takeLocationFromBookmark:]): Now calls -[IFBookmark goTo]. (-[AppController bookmarksController]): New public method, initializes _bookmarksController ivar if necessary.
  • BookmarksController.h:
  • BookmarksController.m: (-[BookmarksController _goToSelectedItem:]): Now calls -[IFBookmark goTo]. (-[BookmarksController _expandAncestorsOfBookmark:]): New method, ensures that each ancestor folder of the specified bookmark is expanded in the outline view. (-[BookmarksController revealBookmark:]): New method, expands the bookmark's ancestors, then selects the bookmark and scrolls to reveal as necessary. (-[BookmarksController _editSelectedColumnWithID:]): New helper method, edits the contents of the specified column for the selected row. (-[BookmarksController editSelectedAddress]), (-[BookmarksController editSelectedName]): New methods, they call _editSelectedColumnWithID: for different columns. (-[BookmarksController _toggleEdit:]): Now calls editSelectedName.
  • IFErrorAdditions.m: (-[IFError errorSummary]): Removed error code from the string this method returns.
  • WebBrowser.pbproj/project.pbxproj: Updated for new files; also added new WebKit Additions group and moved some existing files into it.
4:17 PM Changeset in webkit [1229] by rjw
  • 7 edits in trunk/WebCore

Fixed edge case cancellation problem (actually happens a lot).
No new loads are allowed after a data source has been
set as "stopping".

3:11 PM Changeset in webkit [1228] by rjw
  • 4 edits in trunk/WebKit

Backed out band-aid add to fixed malformed resources URLs.

3:10 PM Changeset in webkit [1227] by rjw
  • 7 edits in trunk/WebCore

Fixed reporting of malformed resources URLs. This fixed
exceptions that were being thrown because nil handles were
being added to datasource handle array.

2:07 PM Changeset in webkit [1226] by cblu
  • 4 edits in trunk/WebKit

* empty log message *

1:18 PM Changeset in webkit [1225] by rjw
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed double free of mapped file bytes (it's freed
by munmap).

11:34 AM Changeset in webkit [1224] by cblu
  • 15 edits in trunk

WebBrowser:

Drag & Drop of file and URL support for the location field.

  • LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Added URL and file drag types (-[LocationFieldEditor draggingEntered:]): new (-[LocationFieldEditor draggingUpdated:]): new (-[LocationFieldEditor prepareForDragOperation:]): new (-[LocationFieldEditor performDragOperation:]): new (-[LocationFieldEditor concludeDragOperation:]): support for URL and file types

WebKit:

  • Plugins.subproj/IFPluginDatabase.h:
  • Plugins.subproj/IFPluginDatabase.m: (-[IFPluginDatabase pluginForMimeType:]): renamed (-[IFPluginDatabase pluginForExtension:]): renamed (-[IFPluginDatabase pluginForFilename:]): renamed (findPlugins):
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: support for above renamed (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _addURLHandle:]): fix for a nil handle being added to an array

WebCore:

Added framework-header-stamp

  • .cvsignore:

WebFoundation:

Fix for 2938040 - This flash movie at macboy.com doesn't load

  • Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_looksLikeAbsoluteURL]):
10:39 AM Changeset in webkit [1223] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (hasMissingGlyphs): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer convertCharacters:length:toGlyphs:]): Free buffer after calling ATSUConvertCharToGlyphs; old code was using buffer after freeing it. (-[IFTextRenderer widthForString:]): Handle case where string is longer than LOCAL_GLYPH_BUFFER_SIZE. (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawString:atPoint:withColor:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer slowFloatWidthForCharacters:length:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer floatWidthForCharacters:length:]): Remove extra rounding. The caller that converts the width to an integer already does the rounding. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Fix off by one error that caused us to include one extra character in each glyph map block. Also use recordSize instead of assuming records are sizeof(ATSLayoutRecord).

May 27, 2002:

2:32 PM Changeset in webkit [1222] by sullivan
  • 7 edits in trunk

Part of fix for 2922772 -- page title & location field don't
show redirected URLs.

  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource wasRedirected]): Fixed this method, now that we have a client that relies on it. Its logic was backwards, and it didn't handle the null _finalURL case.

WebBrowser part of fix for 2922772 -- page title & location field don't
show redirected URLs.

  • BrowserDocument.h: added BrowserDocumentRedirectedNotification
  • BrowserDocument.m: (-[BrowserDocument currentURL]): Return redirectedURL if appropriate.
  • BrowserWindow.m: (-[BrowserWindow windowDidLoad]): register for BrowserDocumentRedirectedNotification (-[BrowserWindow frameLoadRedirected:]): Update location field if appropriate.
  • LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectTo:forDataSource:]): Send BrowserDocumentRedirectedNotification and title-changed messages if the frame is the top-level frame.
12:55 PM Changeset in webkit [1221] by sullivan
  • 3 edits
    1 add in trunk/WebCore
  • Resources/linkCursor.tiff: Added. Maciej forgot to cvs add this new file. I stole the one from haircut.

Added FIXME.

  • BrowserDocument.m: (-[BrowserDocument displayName]):
1:58 AM Changeset in webkit [1220] by mjs
  • 4 edits in trunk/WebCore

Fixed the vexing and long-standing:

Radar 2894699 - Crash at: ​http://cb.apple.com/jsplugins.html

  • khtml/ecma/kjs_navigator.cpp: This crash was caused by Plugin and MimeType objects referring to data that was held and refcounted by PluginBase, without holding a ref. I fixed it by making these individual items participate in the refcounting as well.

May 26, 2002:

10:59 PM Changeset in webkit [1219] by mjs
  • 4 edits in trunk/WebKit

Fixed Radar 936147 - debug output in console "keyUp: NSEvent: type=KeyUp"

  • WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Turned NSLog into WEBKITDEBUGLEBEL. (-[IFWebView keyUp:]): Likewise.
10:01 PM Changeset in webkit [1218] by mjs
  • 21 edits in trunk

WebCore:

Webcore part of fix for:

Radar 2884085 - add support for changing cursor over links

  • Makefile.am: Install tiff of link cursor.
  • kwq/qt/qcursor.h, kwq/KWQCursor.mm: (QCursor::QCursor): Change QCursor to contain an NSCursor. (QCursor::~QCursor): Likewise. (QCursor::operator=): Likewise. (QCursor::handle): Likewise.
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]): NSCursor extension method that provides the link cursor. (KCursor::handCursor): Use the link cursor instead of the default arrow cursor.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::changeCursor): Return TRUE; we always want cursor tracking.
  • kwq/KWQView.h, kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Remember the new cursor and invalidate cursor rects. (-[KWQHTMLView resetCursorRects]): Establish cursor rect for currently set cursor, if not default.
  • kwq/KWQWidget.mm: (QWidget::setCursor): Call setCursor: on the underlying NSView, if implemented. (QWidget::cursor): Implemented. (QWidget::unsetCursor): Implemented.

WebKit:

WebKit part of fix for:

Radar 2884085 - add support for changing cursor over links

Also, fix handling of mouseMoved events.

  • WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Clip mouseMoved events to the view rect, otherwise mouseover effects might happen for elements past the edge of the window. (-[IFWebView setCursor:]): Implement. (-[IFWebView resetCursorRects]): Implement.
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Added NSCursor *cursor field.

May 25, 2002:

3:47 AM Changeset in webkit [1217] by mjs
  • 9 edits
    6 adds
    2 deletes in trunk

WebCore:

Changed WebCore to build as a framework, not a dylib, so resources
can be added to it.

  • Makefile.am: Actual changes to build WebCore.framework
  • Resources/Info.plist: Added.
  • English.lproj/InfoPlist.strings: Added.
  • WebCore-tests.exp: Added.
  • WebCore.exp: Added.
  • libwebcore.exp: Removed.
  • libwebcoretests.exp: Removed.
  • .cvsignore: Updated.

WebKit:

  • WebKit.pbproj/project.pbxproj: Link against WebCore.framework, not libwebcore.dylib.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Link against WebCore.framework, not libwebcore.dylib.

Top level:

Link against WebCore.framework, not libwebcore.dylib.

  • Tests/kde/Makefile.am:
  • Tests/khtmlview/WebViewTest/WebViewTest.pbproj/project.pbxproj:
  • Tests/qt/Makefile.am:

May 24, 2002:

3:12 PM Changeset in webkit [1216] by mjs
  • 3 edits
    3 adds in trunk/JavaScriptCore

Added license and acknowledgements.

  • AUTHORS: Added.
  • COPYING.LIB: Added.
  • THANKS: Added.
9:57 AM Changeset in webkit [1215]
  • 6 copies
    1 delete in tags/Alexander_0_3

This commit was manufactured by cvs2svn to create tag
'Alexander_0_3'.

9:57 AM Changeset in webkit [1214] by sheridan
  • 8 edits in trunk

modified changelogs with 0.3 markers

8:45 AM Changeset in webkit [1213]
  • 6 copies
    1 delete in tags/Alexander-6

This commit was manufactured by cvs2svn to create tag 'Alexander-6'.

8:45 AM Changeset in webkit [1212] by sheridan
  • 8 edits in trunk

Alexander-6 version

May 23, 2002:

3:44 PM Changeset in webkit [1211] by mjs
  • 15 edits in trunk

WebCore:

Fixes for the following (the first bug also requires WebKit and
WebBrowser changes):

Radar 2896391 - command-click should open link in new window
Radar 2935858 - two mails for each mailto:

  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Set flag for Meta key in addition to Control, Shift and Alt, since the Command key is treated as Meta.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::urlSelected): Open a new window if the user command-clicked. (KHTMLPart::khtmlMouseMoveEvent): Clean up use of braces and ifdefs to make prepare-ChangeLog happy. (KHTMLPart::khtmlMouseReleaseEvent): Remove code that tried to process link click events here. This made link clicks get processed twice, now that mouse events are hooked up for real.
  • kwq/external.h: prototype openNewWindowWithURL: method.

WebKit:

WebKit part of the fix for:

Radar 2896391 - command-click should open link in new window

  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController openNewWindowWithURL:]): Default implementation silently does nothing.
  • WebView.subproj/IFWebController.h: Add openNewWindowWithURL: method.
  • WebView.subproj/IFWebView.mm: (-[IFWebView _addModifiers:toState:]): Split out modifier key handling to here. Treat Command as Meta. (-[IFWebView mouseUp:]): Use new method to set key modifiers for mouse events. (-[IFWebView mouseDown:]): Use new method to set key modifiers for mouse events. (-[IFWebView keyDown:]): Use new shared code for key modifiers. (-[IFWebView keyUp:]): Use new shared code for key modifiers.

WebBrowser:

WebBrowser part of the fix for:

Radar 2896391 - command-click should open link in new window

  • WebController.m: (-[WebController openNewWindowWithURL:]): Implement this new IFWebController method by opening a new browser window.
3:23 PM Changeset in webkit [1210] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Maciej Stachowiak

Fix for this bug:

Radar 2935882 (IFURLFileReader class has unbalanaced release count on an NSData ivar)

IFURLFileReader can create an ivar that points to a data using an method that
returns an autoreleased object. Then, without retaining the data anywhere
internally, it releases the data in its dealloc method.

This has been fixed. Now the retain/release count is guaranteed to be balanced

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:])
3:11 PM Changeset in webkit [1209] by kocienda
  • 5 edits in trunk/WebCore

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

More work to fix this bug:

Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)

There was yet two more cases where the refresh timers were getting clobbered.
Fixed.

  • khtml/ecma/kjs_window.cpp: (WindowQObject::parentDestroyed)
  • khtml/khtmlview.cpp: (KHTMLView::clear)
3:01 PM Changeset in webkit [1208] by rjw
  • 4 edits in trunk/WebCore

Fixed crasher 2935757. I still need to investigate the root cause
of this problem.

11:36 AM Changeset in webkit [1207] by kocienda
  • 17 edits in trunk

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

Fixes for these bugs:

Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)
Radar 2935472 (Non-standard html pages don't always get decoded)

WebCore

  • khtml/khtml_part.cpp: Don't kill all timers. Just kill the ones for this object. (KHTMLPart::~KHTMLPart):
  • khtml/khtml_part.h: Modified interface to slotData to add a flag for when all data for a load has been received.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't kill all timers. Just kill the ones for this object.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::slotData): Senses when text encoding is not available, but all data has been received. (KHTMLPart::write): Ditto (KHTMLPart::scheduleRedirection):
  • libwebcore.exp: Changed symbol for slotData

WebKit:

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient setContentPolicy:]): Updated method to use new processData interface. (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Senses when all data has been received for a load. (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Modified interface to add a flag for when all data for a load has been received.
9:38 AM Changeset in webkit [1206] by sheridan
  • 8 edits in trunk

changing version number back to "unofficial"
tree is open

6:13 AM Changeset in webkit [1205]
  • 6 copies
    1 delete in tags/Alexander-5

This commit was manufactured by cvs2svn to create tag 'Alexander-5'.

6:13 AM Changeset in webkit [1204] by mjs
  • 17 edits
    20 adds in trunk

WebKit:

Move authentication panel to WebKit and make it a sheet, fixing:

Radar 2876445 - Authentication panel should be a sheet
Radar 2876449 - The Alexander authentication panel should be moved
to WebKit for use as a standard one

  • Panels.subproj/English.lproj/IFAuthenticationPanel.nib: Added.
  • Panels.subproj/IFAuthenticationPanel.h: Added.
  • Panels.subproj/IFAuthenticationPanel.m: Added.
  • Panels.subproj/IFPanelAuthenticationHandler.h: Added.
  • Panels.subproj/IFPanelAuthenticationHandler.m: Added.
  • Panels.subproj/IFStandardPanels.h: Added.
  • Panels.subproj/IFStandardPanels.m: Added.
  • Panels.subproj/IFStandardPanelsPrivate.h: Added.
  • WebKit.pbproj/project.pbxproj: Add new files to build.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Notify of load start. (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): Notify of load end. (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): Likewise. (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Notify that old URL is no longer loading, but new one is.
  • WebView.subproj/IFBaseWebControllerPrivate.h:
  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _didStartLoading:]): New private method used to track what URLs are loading on behalf of this controller. (-[IFBaseWebController _didStopLoading:]): Likewise.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): Notify of load start. (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Notify of load end. (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Notify of load end and start.

WebCore:

Notify when loads of sub-URLs start and stop, so panels for these
can be attached to the right windows.

  • kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[URLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[URLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[URLLoadClient IFURLHandle:didRedirectToURL:]):
  • kwq/external.h:

May 22, 2002:

10:18 PM Changeset in webkit [1203] by cblu
  • 6 edits in trunk/WebKit

Fixed download data source leaks when downloads are cancelled.

  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
6:35 PM Changeset in webkit [1202] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Removed activate events as this was causing problems
for the QT plug-in.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView windowBecameKey:]): (-[IFPluginView windowResignedKey:]):

WebBrowser:

Added licensing code.

  • WebBrowser.pbproj/project.pbxproj:
  • _CFA2UC.c: Added. (NSGiantRaise): (iszero): (newGiant): (data_to_giant): (giant_with_data): (bitlen): (bitval): (isone): (gcompg): (gtog): (int_to_giant): (negg): (iaddg): (normal_addg): (normal_subg): (reverse_subg): (addg): (subg): (gshiftleft): (bdivg): (mulg): (binvaux): (binvg): (initialguess): (mulndigits): (gsquare): (newtondivide): (gsane): (stablemodg): (modg): (absg): (gshiftright): (extractbits): (gmersennemod): (GiantAuxMul): (GiantGrammarMul): (make_base): (ell_even): (ell_odd): (sequalg): (elliptic): (elliptic_simple): (which_curve): (new_key): (new_giant_from_hexstr): (CFValidate): (MyCFCopyRegularEthernetAddrString): (Alexander_CFA2UC): (GetEthernetAddr):
  • main.m: (main):
6:33 PM Changeset in webkit [1201]
  • 1 copy
    2 deletes in tags/JavaScriptCore-5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-5'.

6:33 PM Changeset in webkit [1200]
  • 1 copy
    2 deletes in tags/JavaScript-5

This commit was manufactured by cvs2svn to create tag 'JavaScript-5'.

6:33 PM Changeset in webkit [1199] by mjs
  • 4 edits in trunk/JavaScriptCore

JavaScriptCore-5

4:10 PM Changeset in webkit [1198] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-22 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Richard Williamson

Removed an assertion that was causing problems with cache object removals.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabaseOp initWithCode:key:object:]):
3:45 PM Changeset in webkit [1197] by rjw
  • 6 edits in trunk/WebCore

Additional additional callback when resource is first loaded.

3:43 PM Changeset in webkit [1196] by mjs
  • 3 edits in trunk/JavaScriptCore

Added retroactive review comments.

1:31 PM Changeset in webkit [1195] by cblu
  • 4 edits in trunk/WebKit

Fixed crasher caused by not retaining.
Fixed targeting bug.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView getURLNotify:target:notifyData:]): (-[IFPluginView getURL:target:]): (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]): (-[IFPluginView postURL:target:len:buf:file:]):
11:34 AM Changeset in webkit [1194] by rjw
  • 4 edits in trunk/WebKit

Changed semantics of isLoading to only return YES if
the datasource is loading resources related to the intial
load. Other resources loaded later by JS will not be
accounted for by isLoading.

12:39 AM Changeset in webkit [1193] by cblu
  • 22 edits
    2 deletes in trunk/WebKit

WebBrowser:

  • Added an array to the defaults for MIME types for downloaded files that we open after download.
  • Made sure we check for IFContentPolicySave when checking if a data source is a download data source.
  • Set policy to IFContentPolicySave for types not in the defaults.
  • Defaults.plist:
  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:]):
  • WebController.m: (-[WebController receivedProgress:forResource:fromDataSource:]): (-[WebController receivedError:forResource:partialProgress:fromDataSource:]):

WebKit:

  • Removed obsolete MIME/download related code.
  • Minor clean-ups.
  • Made WebKit support all text/* MIME types.
  • Now send NPP_URLNotify when pages requested by plug-ins are loaded.
  • Simplified NPP_Get/NPP_Post code.
  • MIME.subproj/IFContentHandler.h:
  • MIME.subproj/IFContentHandler.m:
  • MIME.subproj/IFDownloadHandler.mm:
  • MIME.subproj/IFMIMEDatabase.h: Removed.
  • MIME.subproj/IFMIMEDatabase.m: Removed.
  • MIME.subproj/IFMIMEHandler.h:
  • MIME.subproj/IFMIMEHandler.m: (+[IFMIMEHandler MIMEHandlerTypeForMIMEType:]): (+[IFMIMEHandler canShowMIMEType:]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView dealloc]): (-[IFPluginView frameStateChanged:]): (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): (-[IFPluginView getURLNotify:target:notifyData:]): (-[IFPluginView getURL:target:]): (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]): (-[IFPluginView postURL:target:len:buf:file:]): (-[IFPluginView invalidateRect:]): (-[IFPluginView invalidateRegion:]): (-[IFPluginView forceRedraw]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient processData:isComplete:]):
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):
12:09 AM Changeset in webkit [1192] by mjs
  • 4 edits in trunk/JavaScriptCore

Fixed Radar 2928775 - Sherlock crashes sitting in stocks channel

  • kjs/internal.cpp: (InterpreterImp::InterpreterImp): Set the interp pointer earlier, in case garbage collection takes place while creating the global values.

May 21, 2002:

6:51 PM Changeset in webkit [1191] by rjw
  • 4 edits in trunk/WebKit

Fixed baseline regression. Obvious of sites that have tables w/ backgrounds,
i.e. www.slashdot.org.

5:36 PM Changeset in webkit [1190] by rjw
  • 19 edits in trunk

Lots of changes for DHTML.
Bugs fixes, and fixes to regressions.

Changes to support additional DHTML events.

2:54 PM Changeset in webkit [1189] by kocienda
  • 5 edits in trunk/WebCore

2002-05-21 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2924728 (post form fails at pt.apple.com; succeeds at macosx.apple.com)

Posted forms are now submitted with the IFURLHandleFlagLoadFromOrigin
load flag set. This prevents a potential bug which may cause a page
with a form that uses itself as an action to be returned from the
cache without submitting.

  • kwq/KWQKHTMLPart.mm: (KHTMLPart::submitForm)
1:48 PM Changeset in webkit [1188] by cblu
  • 8 edits in trunk/WebKit

WebFoundation:

Fix for 2925907 - [IFURLHandle resourceData] returns nil until load is complete

  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle resourceData]):

WebKit:

Content policy can now be sent at a later time to avoid blocking.

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
10:25 AM Changeset in webkit [1187] by cblu
  • 5 edits in trunk/WebKit

Move the tracking rect after the view has moved.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewHasMoved:]):

Fixed logging.

  • Plugins.subproj/npapi.m: (NPN_UserAgent): (NPN_MemAlloc): (NPN_MemFree): (NPN_MemFlush): (NPN_ReloadPlugins):
7:50 AM Changeset in webkit [1186] by kocienda
  • 7 edits in trunk

2002-05-21 Kenneth Kocienda <​kocienda@apple.com>

Merged these four include files into the precompiled header.
These are used for the enhanced assertion/debuggin support I
added yesterday.

<signal.h>
<sys/types.h>
<sys/time.h>
<sys/resource.h>

  • WebCore/WebCorePrefix.h
  • WebFoundation/WebFoundationPrefix.h
  • WebKit/WebFoundationPrefix.h
  • WebFoundation/WebFoundation.pbproj/project.pbxproj: PB decided that this file changed in some cryptic way.

May 20, 2002:

6:19 PM Changeset in webkit [1185] by cblu
  • 8 edits in trunk/WebKit

Added support for plug-ins to send URL requests to certain targets.

Added frameNamed to IFWebFrame.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView getURLNotify:target:notifyData:]): (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]):
5:51 PM Changeset in webkit [1184] by darin
  • 3 edits
    1 add in trunk/WebCore

Forgot one file.

  • khtml/khtml_part.moc: Added.
5:30 PM Changeset in webkit [1183] by darin
  • 47 edits
    25 adds
    2 deletes in trunk/WebCore

Use more of the original khtml_part.cpp; a step in the direction of factoring
our code out so more of it can go in WebKit and we don't need external.h.

  • khtml/Makefile.am:
  • khtml/khtml_part.cpp:
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: Start compiling khtml_part.cpp and using khtmlpart_p.h again.
  • kwq/KWQKHTMLPart.mm: Remove code that was identical to khtml_part.cpp. We aren't going to use the "copy and hack our copy" approach on this class for the long termk, and this is the first step in cleaning things up.
  • khtml/khtml_ext.h: Removed.
  • khtml/khtml_factory.h: Removed.
  • khtml/misc/loader.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Remove some APPLE_CHANGES ifdefs we don't need any more.
  • kwq/KWQDateTime.mm: Simplify things like copy constructors.
  • kwq/kdeui/kcursor.h:
  • kwq/KWQKCursor.mm: Add handCursor.
  • kwq/KWQKHTMLFactory.mm: Put in real implementations, not just placeholders.
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKInstance.mm:
  • kwq/KWQPart.mm:
  • kwq/KWQbrowserextension.mm: Empty these files out, nothing in them is needed any more.
  • kwq/khtml/khtml_settings.h:
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::isJavaEnabled): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::isJavaScriptDebugEnabled): Moved settings here from KWQKHTMLPart.mm
  • kwq/kdecore/kurl.h:
  • kwq/KWQKURL.mm: (KURL::encodedHtmlRef): (KURL::htmlRef): Placeholders for these two, called in KHTMLPart, but maybe not really needed.
  • kwq/KWQKloader.mm: (Cache::preloadScript): (Cache::preloadStyleSheet): Empty functions for these, called in KHTMLPart but no implementation needed.
  • kwq/qt/qtimer.h:
  • kwq/KWQTimer.mm: (QTimer::isActive): (QTimer::start): (QTimer::stop): More timer functions.
  • kwq/qt/qscrollview.h: Add one more function.
  • kwq/kdecore/kinstance.h: Simplify.
  • kwq/kdeui/kaction.h: Simplify.
  • kwq/khtml/khtml_factory.h: Simplify.
  • kwq/kparts/browserextension.h: Simplify.
  • kwq/kparts/part.h: Simplify.
  • kwq/qt/qdatetime.h: Simplify.
  • kwq/kdecore/klibloader.h: Added.
  • kwq/khtml/khtml_ext.h: Added.
  • kwq/kparts/partmanager.h: Added. Nearly-empty files with just simple placeholders so we can compile more.
  • kwq/dcop/kdatastream.h: Added.
  • kwq/kdecore/kmultipledrag.h: Added.
  • kwq/kdecore/ktempfile.h: Added.
  • kwq/kdecore/kurldrag.h: Added.
  • kwq/kdeui/kstdaction.h: Added.
  • kwq/kdeui/kxmlguifactory.h: Added.
  • kwq/khtml/khtml_find.h: Added.
  • kwq/khtml/khtml_iface.h: Added.
  • kwq/khtml/khtml_pagecache.h: Added.
  • kwq/khtml/khtml_run.h: Added.
  • kwq/kio/kssl/ksslcertchain.h: Added.
  • kwq/kio/kssl/ksslinfodlg.h: Added.
  • kwq/kio/ktrader.h: Added.
  • kwq/qt/private/qucomextra_p.h: Added.
  • kwq/qt/qclipboard.h: Added.
  • kwq/qt/qmetaobject.h: Added. Empty files just so includes of these names will compile.
  • libwebcoretests.exp: Remove one export that's no longer needed.
4:43 PM Changeset in webkit [1182] by rjw
  • 10 edits in trunk/WebCore

Added support for onChange and window.location, i.e.:
​http://javascript.internet.com/navigation/menu-automatic.html

4:27 PM Changeset in webkit [1181] by kocienda
  • 7 edits in trunk

2002-05-20 Kenneth Kocienda <​kocienda@apple.com>

Now includes <sys/time.h> to prevent possible build breakage
in the inclusion of <sys/resource.h>

  • WebCore/kwq/kwqdebug.h
  • WebKit/Misc.subproj/WebKitDebug.h
  • WebFoundation/Misc.subproj/WebFoundationDebug.h
3:42 PM Changeset in webkit [1180] by kocienda
  • 4 edits in trunk/WebCore

2002-05-20 Kenneth Kocienda <​kocienda@apple.com>

Changed assertion failure code to send a SIGQUIT instead
of raising an NSException.

  • kwq/kwqdebug.h
3:24 PM Changeset in webkit [1179] by kocienda
  • 3 edits in trunk/WebKit

2002-05-20 Kenneth Kocienda <​kocienda@apple.com>

Changed assertion failure code to send a SIGQUIT instead
of raising an NSException.

  • Misc.subproj/WebKitDebug.h
2:54 PM Changeset in webkit [1178] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-20 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: John Sullivan

Fix for this bug:

Radar 2931078 (IFURLFileDatabase initialization is not threadsafe)

In addition, I have added several assertion checks to the code. Note
that each of these assertion checks is of the "failure should be impossible"
variety.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): (-[IFURLFileDatabaseOp initWithCode:key:object:]): (-[IFURLFileDatabaseOp perform:]): (databaseInit): (-[IFURLFileDatabase initWithPath:]): (-[IFURLFileDatabase setObject:forKey:]): (-[IFURLFileDatabase removeObjectForKey:]): (-[IFURLFileDatabase objectForKey:]): (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase performRemoveObjectForKey:]): (-[IFURLFileDatabase lazySync:]):
1:56 PM Changeset in webkit [1177] by cblu
  • 21 edits in trunk/WebKit

WebFoundation:

Added _IF_looksLikeAbsoluteURL.

  • Misc.subproj/IFNSStringExtensions.h:
  • Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_looksLikeAbsoluteURL]):

WebKit:

Summary:

  • Drag & Drop support.
  • A whole lot of plug-in clean-up and minor bug fixes.

Moved the following functions from npapi to IFPlugin.

  • Plugins.subproj/IFPlugin.m: (functionPointerForTVector): (tVectorForFunctionPointer):

Only supply mouse coords when active.

  • Plugins.subproj/IFPluginNullEventSender.h:
  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]): (-[IFPluginNullEventSender dealloc]): (-[IFPluginNullEventSender sendNullEvents]):

Minor clean-ups

  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream dealloc]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):

Removed the isMouseDown flag from the following functions
as it was unnecessary.

Cleaned up logging.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView modifiersForEvent:]): (-[IFPluginView getCarbonEvent:withEvent:]): (-[IFPluginView sendUpdateEvent]): (-[IFPluginView becomeFirstResponder]): (-[IFPluginView resignFirstResponder]): (-[IFPluginView mouseDown:]): (-[IFPluginView mouseUp:]): (-[IFPluginView mouseExited:]): (-[IFPluginView setWindow]): (-[IFPluginView start]): (-[IFPluginView stop]):

URLForString now uses _IF_looksLikeAbsoluteURL.

(-[IFPluginView URLForString:]):

Implemented the following:

(-[IFPluginView invalidateRect:]):
(-[IFPluginView invalidateRegion:]):
(-[IFPluginView forceRedraw]):

Put implementation of GetValue SetValue in npapi.

  • Plugins.subproj/npapi.h:
  • Plugins.subproj/npapi.m: (NPN_GetValue): (NPN_SetValue):

Added drag & drop support.

  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): (-[IFWebView setCanDragFrom:]): (-[IFWebView canDragFrom]): (-[IFWebView setCanDragTo:]): (-[IFWebView canDragTo]): (-[IFWebView draggingEntered:]): (-[IFWebView prepareForDragOperation:]): (-[IFWebView performDragOperation:]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]):
12:15 PM Changeset in webkit [1176] by sullivan
  • 17 edits
    4 adds in trunk/WebKit
  • fixed 2923492 -- No way to put separators in Bookmarks menu
  • fixed 2927561 -- Added child of bookmarks folder should be first, not last
  • fixed 2927575 -- New bookmark should have blank URL
  • fixed 2927589 -- "Modify" and "Remove" should be "Edit" and "Delete"
  • fixed 2923220 -- Bookmarks window should reopen at launch if it was open at quit
  • fixed bug where bookmark window would sometimes start with a horiz scrollbar
  • fixed bug where deleting nested bookmark would leave last row selected
  • PreferenceKeys.h: define ShowBookmarksPreferenceKey
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Open bookmarks window if preference says to. (-[AppController _insertBookmark:intoMenu:atIndex:]): Handle separators.
  • BookmarksController.m: (-[BookmarksController windowDidLoad]): Set self as delegate so we will receive windowWillClose:; setAutoresizesOutlineColumn:NO so column widths won't change at launch. (-[BookmarksController removeSelectedBookmarks:]): Reselect previously selected item if it's still valid (-[BookmarksController _newItemWithTitle:image:URLString:type:]): Change isLeaf parameter to bookmark type. Handle separators (don't edit title of newly-created separator). If expanded folder is selected, make new item first. (-[BookmarksController _newSeparator:]): Implemented. (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): Return "--" as string to represent separator, for now. (-[BookmarksController _newFolder:]), (-[BookmarksController _newBookmark:]): (-[BookmarksController outlineView:isItemExpandable:]): (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): (-[BookmarksController outlineView:shouldEditTableColumn:item:]): Replaced uses of isLeaf with bookmarkType. (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Handle separator item. (-[BookmarksController toolbarAllowedItemIdentifiers:]): Include "New Separator" item. (-[BookmarksController showWindow:]): Set "bookmarks showing" preference to YES. (-[BookmarksController windowWillClose:]): Set "bookmarks showing" preference to NO.
  • BrowserDocument.m: (-[BrowserDocument addBookmark:]): Replaced use of isLeaf with bookmarkType.
  • GlobalHistory.m: (-[GlobalHistory addSelectedItemsToBookmarks:]): Replaced use of isLeaf with bookmarkType.
  • Resources/Images/new_separator.tiff: Added.
  • WebBrowser.pbproj/project.pbxproj: Updated for new file.

May 19, 2002:

9:02 AM Changeset in webkit [1175] by darin
  • 16 edits in trunk/WebCore
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): Add missing break statement so borders don't draw strangely.
  • khtml/rendering/render_style.h: Remove unneeded QColor workaround, now that we handle invalid colors properly.
  • kwq/KWQColor.mm: (createStaticConstructorAutoreleasePool): New solution to the problem of autorelease at static constructor time. (getNamedColors): Function that creates this dictionary when needed rather than creating it inside an init function. (QColor::QColor): Share code with setRgb, get rid of _initialize. (hex2int): Return -1 for bad digit rather than 0. (decodeColorFromHexColorString): Make more robust and simpler. (QColor::setNamedColor): Set color to invalid rather than black when the passed in name is empty or unrecognized. (QColor::red), (QColor::green), (QColor::blue): Round instead of truncating. (QColor::setRgb): Set color to invalid if r, g, or b is out of range. (QColor::operator=): Simplify. (QColor::operator==): Handle invalid colors correctly. (QColor::getNSColor): Return black of invalid colors.
  • kwq/KWQCursor.mm: Simplify cursor globals.
  • kwq/KWQPainter.mm: (QPainter::_setColorFromBrush): Use getNSColor() to handle invalid colors correctly. (QPainter::_setColorFromPen): Use getNSColor() to handle invalid colors correctly. (QPainter::drawLine): Add code to respect style and width and handle endpoints in a way that will make the lines look like Qt users expect. (QPainter::drawText): Use getNSColor() to handle invalid colors correctly. (QPainter::drawUnderlineForText): Use getNSColor() to handle invalid colors correctly. (QPainter::fillRect): Use getNSColor() to handle invalid colors correctly.
  • kwq/KWQPen.mm: (QPen::QPen): (QPen::setStyle): Remove use of MPenStyle.
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): Add comments.
  • kwq/qt/qcolor.h: Simplify ifdefs, remove cname, _initialize, globals_init, and initGlobalColors.
  • kwq/qt/qnamespace.h: Remove AlignTop, AlignBottom, SingleLine, ExpandTabs, DontPrint, DashDotLine, DashDotDotLine, MPenStyle, WResizeNoRease, WRepaintNoErase, color0, color1, darkRed, darkGreen, darkBlue, darkCyan, darkMagenta, darkYellow. Simplify the QColor and QCursor globals.
  • kwq/qt/qpen.h: QPainter is no longer a friend class. Remove linest.

May 17, 2002:

6:35 PM Changeset in webkit [1174] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): OK. This time it's correct.
6:22 PM Changeset in webkit [1173] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Roll the change out while I see why it causes a crash.
5:59 PM Changeset in webkit [1172] by cblu
  • 1 delete in trunk/WebKit/Plugins.subproj/IFPluginStream.m

Replacing IFPluginStream.m with IFPluginStream.mm.

5:55 PM Changeset in webkit [1171] by cblu
  • 2 adds in trunk/WebKit/Plugins.subproj

Adding this file.

5:54 PM Changeset in webkit [1170] by cblu
  • 11 edits in trunk/WebKit

WebKit:

  • Made IFPluginStream the URL handle client instead of IFPluginView.
  • Added support for NPP_PostURL and NPP_PostNotify.
  • Possible fix for 2928558.
  • Plugins.subproj/IFPluginStream.h:
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]):NSURL for url instead of NSString (-[IFPluginView dealloc]): (-[IFPluginView setWindow]): (-[IFPluginView start]): (-[IFPluginView stop]): (-[IFPluginView webDataSource]):Accessor for IFPluginStream. (-[IFPluginView webController]):Accessor for IFPluginStream. (-[IFPluginView URLForString:]): (-[IFPluginView getURLNotify:target:notifyData:]): (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]): (-[IFPluginView postURL:target:len:buf:file:]): (-[IFPluginView destroyStream:reason:]): (-[IFPluginView status:]): (-[IFPluginView NPP_NewStream]): Accessor for IFPluginStream. (-[IFPluginView NPP_WriteReady]):Accessor for IFPluginStream. (-[IFPluginView NPP_Write]): Accessor for IFPluginStream. (-[IFPluginView NPP_StreamAsFile]): Accessor for IFPluginStream. (-[IFPluginView NPP_DestroyStream]): Accessor for IFPluginStream. (-[IFPluginView NPP_URLNotify]): Accessor for IFPluginStream.
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: Use new IFPluginView init method (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]):
  • WebKit.pbproj/project.pbxproj:

Tools:

Use rm -rf to remove Labyrinth.

  • Tools/jersey/bin/jersey.pl:
  • Tools/jersey/html/cgi-bin/j.pl:
10:57 AM Changeset in webkit [1169] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Remove an old incorrect fix for a style leak in here and put in a new correct fix.

May 16, 2002:

3:43 PM Changeset in webkit [1168] by rjw
  • 5 edits in trunk/WebCore

Fixed 2896350. Ignore DPI in images and render directly at pixel size.

12:47 PM Changeset in webkit [1167] by rjw
  • 11 edits in trunk

Fixed 2925638. Don't send last progress message from resourceDataDidBecomeAvailable,
it is sent from IFURLHandleResourceDidFinishLoading, avoiding duplication.

11:10 AM Changeset in webkit [1166]
  • 6 copies
    1 delete in tags/Alexander-4

This commit was manufactured by cvs2svn to create tag 'Alexander-4'.

11:10 AM Changeset in webkit [1165] by rjw
  • 4 edits in trunk/WebKit
  1. I was being overly aggressive about

finding substitute glyphs.

10:45 AM Changeset in webkit [1164] by darin
  • 4 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]): Use this new getCarbonPath function rather than hardcoding assumptions about "/tmp" being ":private:tmp". (getCarbonPath): New.
9:00 AM Changeset in webkit [1163] by darin
  • 4 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]): Fixed log statement so development builds work again.
8:45 AM Changeset in webkit [1162] by darin
  • 4 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView mouseUp:]): Remove unused variable that breaks optimized builds.

May 15, 2002:

11:23 PM Changeset in webkit [1161] by darin
  • 8 edits in trunk/WebKit

Another quick events cleanup pass.

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]): Use [IFPluginView getCarbonEvent:].
  • Plugins.subproj/IFPluginView.h: Make almost all methods private.
  • Plugins.subproj/IFPluginView.mm: (+[IFPluginView getCarbonEvent:]): New. (-[IFPluginView getCarbonEvent:]): New, calls class method. (-[IFPluginView modifiersForEvent:isMouseDown:]): Reversed sense of btnState. This flag is set if the mouse is up, not if the mouse is down. (-[IFPluginView getCarbonEvent:withEvent:isMouseDown:]): New. (-[IFPluginView getCarbonEvent:withEvent:]): New. (-[IFPluginView sendActivateEvent:]): Now takes parameter for activate vs. deactivate and uses [getCarbonEvent:]. (-[IFPluginView sendUpdateEvent]): Uses [getCarbonEvent:]. (-[IFPluginView becomeFirstResponder]): Uses [getCarbonEvent:]. (-[IFPluginView resignFirstResponder]): Uses [getCarbonEvent:]. (-[IFPluginView mouseDown:]): Uses [getCarbonEvent:withEvent:isMouseDown:]. (-[IFPluginView mouseUp:]): Uses [getCarbonEvent:withEvent:isMouseDown:]. (-[IFPluginView mouseEntered:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView mouseExited:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView keyUp:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView keyDown:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView start]): Call [sendActivateEvent:YES]. (-[IFPluginView windowBecameKey:]): Call [sendActivateEvent:YES]. (-[IFPluginView windowResignedKey:]): Call [sendActivateEvent:NO].
5:22 PM Changeset in webkit [1160] by rjw
  • 4 edits in trunk/WebKit

Fixed problem dealing w/ characters in range 0x7f - 0xa0.

4:58 PM Changeset in webkit [1159] by cblu
  • 10 edits in trunk/WebKit

Fixed Flash mouse-down, mouse-over Flash bug.
Added support for modifiers (control-click etc) (2884451).
A lot of events clean-up.

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (newCString): (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView start]): (-[IFPluginView drawRect:]): (-[IFPluginView isFlipped]): (-[IFPluginView currentModifiers]): (-[IFPluginView modifiersForEvent:isMouseDown:]): (-[IFPluginView sendActivateEvent]): (-[IFPluginView sendUpdateEvent]): (-[IFPluginView becomeFirstResponder]): (-[IFPluginView resignFirstResponder]): (-[IFPluginView mouseDown:]): (-[IFPluginView mouseUp:]): (-[IFPluginView mouseEntered:]): (-[IFPluginView mouseExited:]): (-[IFPluginView keyUp:]): (-[IFPluginView keyDown:]): (-[IFPluginView windowBecameKey:]): (-[IFPluginView windowResignedKey:]):

Case-sensitivity issue with an include.

  • WebView.subproj/IFWebView.mm:
4:21 PM Changeset in webkit [1158] by rjw
  • 4 edits in trunk/WebCore

Alerts, useful for validating that js handlers work.
Validated that onsubmit is working.

2:00 PM Changeset in webkit [1157] by darin
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp

Oops.

1:59 PM Changeset in webkit [1156] by darin
  • 7 edits in trunk/WebCore
  • kwq/qt/qguardedptr.h: Fix reversed sense of check in isNull. Fixes a bug that was causing a lot of DHTML not to work.
12:45 PM Changeset in webkit [1155] by kocienda
  • 4 edits in trunk/WebCore

2002-05-15 Kenneth Kocienda <​kocienda@apple.com>

  • kwq/KWQInvisibleButton.h: Changed an #include of Cocoa.h to an #import
12:03 PM Changeset in webkit [1154] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListImpl::KWQListPrivate::copyList): Take out unnecessary line of code. (KWQListImpl::KWQListPrivate::~KWQListPrivate): Delete the iterator nodes also, not just the item nodes. Fixes a storage leak. (KWQListIteratorImpl::KWQListIteratorPrivate::KWQListIteratorPrivate): Change interface to take a list pointer so we don't rely on the undefined behavior of &* on a null pointer. (KWQListImpl::addIterator): Set up the prev pointer of the old head of the list. This was causing the crash I was debugging. (KWQListIteratorImpl::operator=): Simpler implementation.
10:05 AM Changeset in webkit [1153] by darin
  • 7 edits in trunk
  • Makefile.am: Use all-am and clean-am instead of all and clean because it's better and to make "make check" at the top level work right.

May 14, 2002:

8:35 PM Changeset in webkit [1152] by sullivan
  • 14 edits in trunk/WebKit

Work to support copying bookmarks, needed for drag & drop
in Bookmarks window.

  • Bookmarks.subproj/IFBookmark.h: Make IFBookmark conform to NSCopying.
  • Bookmarks.subproj/IFBookmark.m: (-[IFBookmark copyWithZone:]): insist that subclasses implement this.
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup insertBookmark:atIndex:ofBookmark:]): Removed this unnecessary method.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf copyWithZone:]): New method.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList copyWithZone:]): New method.

Fixed 2921730 -- Can't rearrange bookmarks in Bookmarks window

You can now drag and drop willy-nilly in the Bookmarks window to
rearrange items. It's currently using a private pasteboard type,
so you can't drop items from elsewhere or drag the bookmarks out
of the list. I know of one bug (dropping an item inside itself
makes it poof into nothingness) which I'll write up in a moment.

  • BookmarksController.m: (-[BookmarksController windowDidLoad]): register for our dragged type. (-[BookmarksController _anyAncestorOfRow:inArray:]): New helper method, used to avoid copying a folder deep and some of its children at the same time. (-[BookmarksController outlineView:writeItems:toPasteboard:]): Write list of rows to pasteboard, after eliminating items whose ancestors are also in set. (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Move a drop on a leaf bookmark to be after the leaf bookmark. (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Do the move, by inserting copies of the moved items and then removing the originals.
  • OutlineViewPlus.m: (-[OutlineViewPlus setAcceptsFirstMouse:]): (-[OutlineViewPlus acceptsFirstMouse:]): Removed debugging messages I accidentally left in here.
7:32 PM Changeset in webkit [1151] by rjw
  • 4 edits in trunk/WebKit

Fixed exception in log code.

6:59 PM Changeset in webkit [1150] by rjw
  • 15 edits in trunk

Fixed 2926153, not getting correct messages after cancel.
Fixed leak of mouse events (Darin wanted this ASAP).

Added another symbol for stack based event constructor.
Change to support onLoad.

5:19 PM Changeset in webkit [1149] by cblu
  • 15 edits in trunk

WebCore:

Changed slotData to slotData(NSString *encoding, const char *bytes, int length)

  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::slotData):
  • libwebcore.exp:

WebKit:

Removed retain of the URL handle. This was causing everything to leak.

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:]):
5:08 PM Changeset in webkit [1148] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Remove code that makes us the first responder. That's up to the higher levels, not the web view.
1:53 PM Changeset in webkit [1147] by darin
  • 4 edits in trunk/WebCore

Fixed 2925291 -- CSS2 test page causes infinite recursion, crash

  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): Add code to detect the case of a render object that uses text cell style but is not itself a text style, and make sure we don't try to nest such an object inside an infinite number of tables.
12:16 PM Changeset in webkit [1146] by sullivan
  • 4 edits in trunk/WebKit
  • History.subproj/IFURIEntry.h: Oops, deleted the prototype for setLastVisitedDate accidentally, which made Jersey sad.
11:07 AM Changeset in webkit [1145] by sullivan
  • 9 edits
    1 delete in trunk/WebKit

Fixed 2919027 -- Need to remove unused code in WebKit/History.subproj

  • History.subproj/IFAttributedURL.h: Removed.
  • History.subproj/IFBackForwardList.h: Removed large #ifdef.
  • History.subproj/IFURIEntry.h,
  • History.subproj/IFURIEntry.m: Removed all mention of unused fields comment, creationDate, modificationDate
  • WebKit.pbproj/project.pbxproj: Updated for removed file.
6:52 AM Changeset in webkit [1144] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListIteratorImpl::KWQListIteratorImpl): Add a missing check for a null pointer.
  • kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Remove an unnecessary call to "toFirst", because new iterators already default to pointing to the first element of the list.

May 13, 2002:

11:16 PM Changeset in webkit [1143] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Detach all the iterators from the list when the list is destroyed. I thought this was done before, but it seems not.
10:43 PM Changeset in webkit [1142] by cblu
  • 16 edits in trunk/WebKit

Added support for setting the content policy on the location change handler
and data source at any time instead of depending on an immediate response.

  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient setContentPolicy:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setContentPolicy:]):
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
7:57 PM Changeset in webkit [1141] by darin
  • 13 edits in trunk/WebCore

Fixed bug 2922884 (JavaScript object leak creating Image object from JavaScript).
There was a reference loop created when a document contained a variable that
referenced an image, because images held references to the document; the C++
kind that do not participate in the JavaScript garbage collection.

  • khtml/ecma/kjs_html.h: Use a QGuardedPtr to the DocumentImpl instead of using a Document object.
  • khtml/ecma/kjs_html.cpp: (Image::tryPut): Change because the "doc" pointer is now a pointer to the DocumentImpl, not the Document. Also check for 0, since it's now a QGuardedPtr that can become 0. (Image::Image): Newly out of line. Changed because the "doc" pointer is now a pointer to the DocumentImpl, not the Document.

Since the solution used QGuardedPtr, I had to implement it.

  • kwq/qt/qguardedptr.h: Put the implementation in a new KWQGuardedPtrBase class, with only the bare minimum in a template. This new implementation uses iterators on a QPtrList, which means there's not much code needed.
  • kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Rewrite to use a QPtrListIterator to a dummy list in the QObject. This reuses code nicely, but a custom-coded solution would be a bit more efficient.
  • kwq/qt/qobject.h:
  • kwq/KWQObject.mm: (QObject::QObject): Create the one-element list that's used by the QGuardedPtr instances.

Since the above code needed to copy a QPtrListIterator, I needed to support that.

  • kwq/qt/qlist.h: Move the iterator's copy constructor out of the private part, and implement it. This class was strange in that it has a public assignment operator, but a private unimplemented copy constructor. Implementing it was trivial, though, so this was no obstacle.
7:56 PM Changeset in webkit [1140] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/value.h: Fix comment typos.
7:30 PM Changeset in webkit [1139] by mjs
  • 3 edits in trunk/WebKit
  • Makefile.am: Make WebCore precompiled headers depend on config.h to fix build breakage from last change.

WebKit:

  • WebKitPrefix.h: Gratuitous change to make the prefix file rebuild.
5:27 PM Changeset in webkit [1138] by mjs
  • 5 edits
    2 deletes in trunk/WebCore

Removed libjpeg dependency. Turns out we don't need it.

  • configure.in: Don't check for libjpeg.
  • Updates/update: Don't bother with the libjpeg update.
  • Updates/install-libjpeg.sh: Removed.

WebCore:

Removed libjpeg dependency. Turns out we don't need it.

  • Makefile.am: Remove -ljpeg from link line.
  • khtml/misc/loader_jpeg.cpp: Removed.
  • khtml/misc/loader_jpeg.h: Removed.
  • khtml/misc/Makefile.am: Remve loader_jpeg from build.
11:22 AM Changeset in webkit [1137] by cblu
  • 11 edits in trunk/WebKit
  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController URLPolicyForURL:]):

Use [IFURLHandle canInitWithURL] instead of hard-coded URL schemes.

  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate init]): (-[IFWebDataSource _setDownloadPath:]):

Removed _contentPolicy as contentPolicy is public.

Initialize contentPolicy in [IFWebDataSourcePrivate init].

May 10, 2002:

4:08 PM Changeset in webkit [1136] by rjw
  • 4 edits in trunk/WebCore

Made log output match webkit logging.

4:07 PM Changeset in webkit [1135] by rjw
  • 8 edits
    1 add in trunk/WebKit

Logging changes.

3:28 PM Changeset in webkit [1134] by cblu
  • 13 edits in trunk

WebKit:

Added support for non-html non-file URL data sources.
Added the init methods below. Removed initWithHandle.

  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (IFWebDataSourceMake): (-[IFWebDataSource initWithURL:]): (-[IFWebDataSource initWithURL:attributes:]): (-[IFWebDataSource startLoading:]):

WebCore:

Changed WCIFWebDataSourceMake to wrap around [IFWebDataSource initWithUR

L: attributes: flags:]

instead of initWithHandle.

  • kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame): (KHTMLPart::submitForm):
  • kwq/WCWebDataSource.h:
  • libwebcore.exp:
3:16 PM Changeset in webkit [1133] by darin
  • 3 edits in trunk/WebCore

Fixed 2923728 (ellipsizing text method is taking a lot of CPU time) by writing a
new string truncator that uses fast text measurement.

  • AppController.m: (-[AppController awakeFromNib]): Remove _setUpStringTruncator.
  • BrowserDocument.h: Remove _cachedPageName; it was not doing any good.
  • BrowserDocument.m: (-[BrowserDocument dealloc]): No need to release _cachedPageName. (-[BrowserDocument pageName]): No need to use _cachedPageName. (-[BrowserDocument _updateWindowTitles]): Name change.
  • StringTruncator.h: Rewrite. Only the name is the same.
  • StringTruncator.m: (+[StringTruncator centerTruncateString:length:omitCount:toBuffer:]): Does the work of removing the middle of a string. (+[StringTruncator centerTruncateString:toWidth:]): Convenience cover version that uses the menu font. (+[StringTruncator centerTruncateString:toWidth:withFont:]): The code to do the truncating.
  • TextCell.m: (-[TextCell drawInteriorWithFrame:inView:]): Use the new truncator interface that takes a font, not the old one that took an attributes dictionary.
  • WebBrowser.pbproj/project.pbxproj: Some little tweak.
3:11 PM Changeset in webkit [1132] by darin
  • 11 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.h: Moved most of the stuff from here into the .m file so this header can be included by clients. Also added floatWidthForCharacters:length:.
  • WebCoreSupport.subproj/IFTextRenderer.m: (freeWidthMap): Check for NULL. (freeGlyphMap): Check for NULL. (-[IFTextRenderer slowFloatWidthForCharacters:length:]): Renamed, and made it return the float. (-[IFTextRenderer floatWidthForCharacters:length:]): Renamed, and made it return the float. (-[IFTextRenderer widthForCharacters:length:]): Do rounding here.
  • WebCoreSupport.subproj/IFTextRendererFactory.h:
  • WebCoreSupport.subproj/IFTextRendererFactory.m: Make the interface slightly easier to use by using the specific types.
  • WebKit.pbproj/project.pbxproj: Exported the headers.
2:51 PM Changeset in webkit [1131] by kocienda
  • 5 edits in trunk/WebKit

2002-05-10 Kenneth Kocienda <​kocienda@apple.com>

Fixed build breakage caused by my previous checkin.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])
2:25 PM Changeset in webkit [1130] by sullivan
  • 8 edits
    1 add in trunk/WebKit

Fixed 2922756 (@ image in History window is a little too tall)
Fixed 2923790 (bookmark folders need folder icons)

  • Resources/bookmark_folder.tiff: New image (small folder, copied from elsewhere)
  • Resources/url_icon.tiff: Shrunk this one a little bit.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList image]): Return the default image if no custom image is set.
  • History.subproj/IFURIEntry.m: (-[IFURIEntry image]): If the default image's file isn't found, don't try to create an NSImage, because it will come out horribly broken and evil if you do (I ran into this while adding the bookmark folder image; most of Alexander's menus did not appear at all because the bookmark folder image was using a bogus NSImage).
  • WebKit.pbproj/project.pbxproj: Updated for new files.

Fixed 2922745 (Bookmark and History window should use same font size)
Fixed 2923792 (All buttons in Bookmarks window look the same)

  • Resources/Images/new_bookmark.tiff: Added.
  • Resources/Images/new_folder.tiff: Added.
  • Resources/Images/pencil.tiff: Added. New images for buttons in Bookmarks window. new_folder was stolen from Finder; pencil was stolen from Mail; new_bookmark is a Sullivan Original™.
  • AppController.m: (-[AppController _addBookmarksToMenu]): (-[AppController _updateBookmarksInMenu]): Remove count of bookmarks from debug timing message since it wasn't counting deep.
  • BookmarksController.m: (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use the right images for the right buttons.
  • English.lproj/Bookmarks.nib: Change the font size to match History window.
  • WebBrowser.pbproj/project.pbxproj: Updated for new files.
2:07 PM Changeset in webkit [1129] by kocienda
  • 8 edits in trunk/WebKit

2002-05-10 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Maciej Stachowiak

WebFoundation:

This set of changes enhances the IFError object with two new pieces of
information:

1) An error domain, to help separate error codes from different
sources that may overlap

2) An indicator of whether the error should be treated as "terminal" by
code that receives and handles the error.

I have added a couple of other cleanups in this class, as described by
the bugs noted below.

The other code in this set of changes was modified to use the new interface
and features of IFError.

Fixes for these four bugs:

Radar 2923998 (Change IFError private data into a pointer to a private data object)
Radar 2924002 (IFError should include an error domain)
Radar 2924013 (IFError initialization is not threadsafe)
Radar 2924280 (IFError should contain a new field which tells whether the error is terminal)

  • CacheLoader.subproj/IFFileURLProtocolHandler.m: (-[IFFileURLProtocolHandler fileLoadThread])
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]) (-[IFHTTPURLProtocolHandler retryWithRedirectedURL:]) (-[IFHTTPURLProtocolHandler handleReadStreamEvent:event:]) (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:]) (-[IFHTTPURLProtocolHandler determineErrorAndFail])
  • CacheLoader.subproj/IFURLCacheLoaderConstants.:h
  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithResultCode:inDomain:isTerminal:]) (-[IFURLHandle _setError:]) (-[IFURLHandle _notifyClientsDidFailLoading])
  • CacheLoader.subproj/IFURLHandleC.h:
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
  • CacheLoader.subproj/IFURLHandlePrivate.h:
  • CacheLoader.subproj/IFURLLoad.h:
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (-[IFURLLoad scheduleOriginLoad]) (-[IFURLLoad beginOriginLoad]) (_loadSweeper)
  • Misc.subproj/IFError.h:
  • Misc.subproj/IFError.m: (-[IFErrorPrivate dealloc]) (classInitialize) (+[IFError errorWithCode:inDomain:failingURL:isTerminal:]) (-[IFError initWithErrorCode:inDomain:failingURL:isTerminal:]) (-[IFError dealloc]) (-[IFError errorCode]) (-[IFError errorDomain]) (-[IFError terminalError]) (-[IFError errorDescription]) (-[IFError failingURL]) (-[IFError description])

WebKit:

This code was modified to use the new interface and features of IFError.
These features and changes are described in these four bug reports:

Radar 2923998 (Change IFError private data into a pointer to a private data object)
Radar 2924002 (IFError should include an error domain)
Radar 2924013 (IFError initialization is not threadsafe)
Radar 2924280 (IFError should contain a new field which tells whether the error is terminal)

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView IFURLHandle:resourceDidFailLoadingWithResult:])
  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _receivedProgress:forResource:fromDataSource:]) (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:])
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])
1:52 PM Changeset in webkit [1128]
  • 1 copy
    2 deletes in tags/JavaScriptCore-4

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-4'.

1:52 PM Changeset in webkit [1127] by mjs
  • 5 edits in trunk/JavaScriptCore

JavaScriptCore-4

9:41 AM Changeset in webkit [1126] by mjs
  • 9 edits in trunk/JavaScriptCore

Reviewed by: Ken Kocienda and Darin Adler

Fixed the following bug:

Radar 2890573 - JavaScriptCore needs to be thread-safe

Actually this is only a weak form of thread-safety - you can safely
use different interpreters from different threads at the same
time. If you try to use a single interpreter object from multiple
threads, you need to provide your own locking.

  • kjs/collector.h, kjs/collector.cpp: (Collector::lock, Collector::unlock): Trivial implementation of a recursive mutex. (Collector::allocate): Lock around the body of this function. (Collector::collect): Likewise. (Collector::finalCheck): Likewise. (Collector::numInterpreters): Likewise. (Collector::numGCNotAllowedObjects): Likewise. (Collector::numReferencedObjects): Likewise.
  • kjs/internal.cpp: (Parser::parse): use a mutex to lock around the whole parse, since it uses a bunch of global state. (InterpreterImp::InterpreterImp): Grab the Collector lock here, both the mutually exclude calls to the body of this function, and to protect the s_hook static member which the collector pokes at. (InterpreterImp::clear): Likewise.
  • kjs/ustring.cpp: (statBufferKeyCleanup, statBufferKeyInit, UString::ascii): Convert use of static variable
  • kjs/value.cpp: (ValueImp::ValueImp, ValueImp::mark, ValueImp::marked, ValueImp::setGcAllowed): Grab the GC lock around any flag changes.

May 9, 2002:

8:18 PM Changeset in webkit [1125] by rjw
  • 5 edits in trunk/WebCore

i Added new method to avoid creation of NSString.

8:18 PM Changeset in webkit [1124] by rjw
  • 6 edits in trunk/WebKit

Tuned implementation more. Cleaned up and factored code.

6:35 PM Changeset in webkit [1123] by sullivan
  • 6 edits in trunk/WebKit
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): Gave these two methods return values of the new bookmark created, to make callers' lives easier.

More work on bookmarks; you can now create new ones and new folders
from the Bookmarks window. You still can't reorder them by dragging.
There are many details wrong still, including some obvious ones.

Fixed these radar bugs along the way:
2921389 -- No way to create a folder in Bookmarks window
2923495 -- Shouldn't be able to create bookmarks with no title and/or URL string

Also improved what Activity Viewer shows for errors that had no description
(was "(null)", now is "error").

  • AppController.m: (-[AppController _insertBookmark:intoMenu:atIndex:]): Made this method handle non-leaf bookmarks (i.e., folders)
  • BookmarksController.m: (-[BookmarksController _collapseSelectionToSingleRow]): New helper routine that always ends up with a single row selected (unless outline view is empty).

(-[BookmarksController _removeSelectedBookmarks:]):
Call _collapseSelectionToSingleRow after removing selected items.

(-[BookmarksController _toggleEdit:]):
New method, turns edit mode on or off for the selected item.

(-[BookmarksController _findParentRowOfRow:]):
New helper routine for finding the row index that's the parent of
a given row.

(-[BookmarksController _newItemWithTitle:image:URLString:isLeaf:]):
Bottleneck for new-item-creating methods, finds appropriate place to
insert new item based on current selection, inserts it, selects it,
and puts its name into edit mode.

(-[BookmarksController _newSeparator:]):
New method, placeholder for now.

(-[BookmarksController _newFolder:]):
(-[BookmarksController _newBookmark:]):
Implement by calling _newItemWithTitle:

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
If new value after trimming whitespace is empty, ignore it.

(-[BookmarksController outlineView:shouldEditTableColumn:item:]):
Don't allow address cell of folder rows to be edited.

(-[BookmarksController toolbarAllowedItemIdentifiers:]):
New set of buttons is: New Bookmark, New Folder, Modify, Remove

(-[BookmarksController validateUserInterfaceItem:]):
Disable Modify when nothing is selected.

  • English.lproj/Bookmarks.nib: I don't remember what I changed here, possibly nothing real.
  • IFErrorAdditions.h: Added.
  • IFErrorAdditions.m: Added. (-[IFError errorSummary]): New category on IFError, implements just this one method, which returns a string of the form "<error description> (<error code>)" and handles the case where there's no description.
  • FrameProgressEntry.m: (-[FrameProgressEntry statusString]): use errorSummary.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]): use errorSummary.
  • GlobalHistory.m: (-[GlobalHistory showWindow:]): Changed an NSLog to a WEBKITDEBUG
  • WebBrowser.pbproj/project.pbxproj: Updated for new files.
12:42 PM Changeset in webkit [1122]
  • 1 copy
    34 deletes in tags/WebFoundation-5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-5'.

12:42 PM Changeset in webkit [1121]
  • 1 copy
    34 deletes in tags/WebFoundation-4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-4'.

12:42 PM Changeset in webkit [1120] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Chris Blumenberg

Fix for this bug:

Radar 2922673 (Remove use of private NSData interface in IFURLFileDatabase.m)

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): Code now uses new Jaguar public API
12:25 PM Changeset in webkit [1119] by kocienda
  • 4 edits in trunk/WebCore

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2890624 (need to remove workaround for double free of image data from QPixmap)

The appropriate, bug-free AppKit code is now available to us on Jaguar.
Rolling out the workaround.

  • kwq/KWQPixmap.mm: (QPixmap::QPixmap)
9:43 AM Changeset in webkit [1118] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Tiny little string copying cleanup suggested by Darin.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open]): small string copying cleanup.
9:35 AM Changeset in webkit [1117] by kocienda
  • 4 edits in trunk/WebKit/Misc.subproj

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fixes for these two bugs:

Radar 2859001 (Maintain usage calculation for on-disk cache)
Radar 2859009 (On-disk cache must be able to be truncated to a specific size)

Now, the on-disk database keeps track of the amount of data it stores and can enforce
a usage quota. This new system should work quite well as long as there is a one-to-one
mapping between processes and on-disk cache paths.

Further guarantees for synchronous access to a cache from multiple processes will be
offered if (when) we switch over to using the sleepycat Berkeley DB for the disk cache
implementation.

  • CacheLoader.subproj/IFURLDiskCache.m: (-[IFURLDiskCache initWithSizeLimit:path:]): Added code that calls into new database methods (-[IFURLDiskCache dealloc]): Added missing call to [super dealloc] (-[IFURLDiskCache setSizeLimit:]): New (-[IFURLDiskCache usage]): New
  • Database.subproj/IFDatabase.h:
  • Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Added code to track size limit and usage (-[IFDatabase isOpen]): Added code to track size limit and usage (-[IFDatabase count]): New (-[IFDatabase sizeLimit]): New (-[IFDatabase setSizeLimit:]): New (-[IFDatabase usage]): New
  • Database.subproj/IFNDBMDatabase.h: Removed.
  • Database.subproj/IFNDBMDatabase.m: Removed.
  • Database.subproj/IFURLFileDatabase.h:
  • Database.subproj/IFURLFileDatabase.m: (+[IFURLFileDatabase uniqueFilePathForKey:]): Moved to private category (-[IFURLFileDatabase writeSizeFile:]): New (-[IFURLFileDatabase readSizeFile]): New (-[IFURLFileDatabase truncateToSizeLimit:]): New (-[IFURLFileDatabase initWithPath:]): Added code to deal with size reckoning (-[IFURLFileDatabase removeAllObjects]): Added code to deal with size reckoning (-[IFURLFileDatabase performSetObject:forKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase performRemoveObjectForKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase open]): Added code to deal with size reckoning (-[IFURLFileDatabase close]): Added code to deal with size reckoning (-[IFURLFileDatabase sync]): Added code to deal with size reckoning (-[IFURLFileDatabase count]): New (-[IFURLFileDatabase setSizeLimit:]): New
  • WebFoundation.pbproj/project.pbxproj: PB has its way again.
9:19 AM Changeset in webkit [1116]
  • 8 copies in tags/Alexander-3

This commit was manufactured by cvs2svn to create tag 'Alexander-3'.

9:19 AM Changeset in webkit [1115] by sheridan
  • 8 edits in trunk

Alexander-3 versioning

May 8, 2002:

8:05 PM Changeset in webkit [1114] by rjw
  • 6 edits in trunk/WebKit

Added optimizations for text rendering.

5:11 PM Changeset in webkit [1113] by darin
  • 7 edits in trunk/WebKit
  • Misc.subproj/IFCache.h: Add more JavaScript object statistics.
  • Misc.subproj/IFCache.mm: (+[IFCache javaScriptInterpretersCount]): New. (+[IFCache javaScriptNoGCAllowedObjectsCount]): New. (+[IFCache javaScriptReferencedObjectsCount]): New.
  • WebKit.pbproj/project.pbxproj: Rearranged two files, dunno why.
5:11 PM Changeset in webkit [1112] by darin
  • 5 edits in trunk/JavaScriptCore
  • kjs/collector.h:
  • kjs/collector.cpp: (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects): Add three new functions so we can see a bit more about leaking JavaScriptCore.
1:22 PM Changeset in webkit [1111] by cblu
  • 8 edits in trunk/WebKit

Cleaned up mach-o plug-in support.

Changed the init method in IFPlugin to initWithPath.

  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): (-[IFPlugin load]):
  • Plugins.subproj/IFPluginDatabase.m: (findPlugins):
11:37 AM Changeset in webkit [1110] by darin
  • 2 edits in trunk/WebKit/WebView.subproj

Forgot include.

11:29 AM Changeset in webkit [1109] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use _IF_stringByTrimmingWhitespace.

May 7, 2002:

4:51 PM Changeset in webkit [1108] by rjw
  • 8 edits in trunk/WebKit

First pass at font substitution. Find a substitute font to
use when the specified font doesn't have glyphs for the characters that
need to be drawn.

Works correctly but hasn't been optimized yet, VERY slow.
Will optimize this evening and tomorrow. Try www.yahoo.co.jp,
it will take a long time to render be eventually will draw correctly.

4:36 PM Changeset in webkit [1107] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQFontMetrics.mm: Fixed storage leak by initializing refCount.
2:41 PM Changeset in webkit [1106] by darin
  • 3 edits
    4 adds
    2 deletes in trunk/WebKit

Oops. These files don't belong at the top level.

  • IFWebCoreViewFactory.h: Removed.
  • IFWebCoreViewFactory.m: Removed.
  • WebCoreSupport.subproj/IFWebCoreViewFactory.h: Added.
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: Added.
  • WebKit.pbproj/project.pbxproj:
2:10 PM Changeset in webkit [1105] by darin
  • 23 edits
    26 adds
    13 deletes in trunk

WebCore:

Move more plugin code into WebKit.

Stop using IF for anything in WebCore to help make it clear what's part of
the BSD licensed stuff and what's part of our proprietary stuff.

  • libwebcore.exp: Names of what exported changed.
  • kwq/Makefile.am: Source file names changed.
  • kwq/IFTextRenderer.h: Renamed to WebCoreTextRenderer.
  • kwq/IFTextRendererFactory.h: Renamed to WebCoreTextRendererFactory.
  • kwq/IFTextRendererFactory.m: Renamed to WebCoreTextRendererFactory.
  • kwq/WebCoreTextRenderer.h: Renamed from IFTextRenderer.
  • kwq/WebCoreTextRendererFactory.h: Renamed from IFTextRendererFactory.
  • kwq/WebCoreTextRendererFactory.m: Renamed from IFTextRendererFactory.
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.mm: Updated for IF -> WebCore name change.
  • kwq/WebCoreViewFactory.h: Added.
  • kwq/WebCoreViewFactory.m: Added.
  • kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): Use the new [WebCoreViewFactory pluginsInfo] so we don't have to have the plugin database in WebCore any more.
  • kwq/WCJavaAppletWidget.h:
  • kwq/WCJavaAppletWidget.mm: (IFJavaAppletWidgetCreate):
  • kwq/WCPluginWidget.h:
  • kwq/WCPluginWidget.mm: (IFPluginWidgetCreate): Remove creation function machinery, and use the WebCoreViewFactory instead.
  • kwq/WCPlugin.h: Moved to WebKit.
  • kwq/WCPlugin.mm: Moved to WebKit.
  • kwq/WCPluginDatabase.h: Moved to WebKit.
  • kwq/WCPluginDatabase.mm: Moved to WebKit.
  • kwq/npapi.h: Moved to WebKit.
  • kwq/npapi.mm: Moved to WebKit.

WebKit:

Move more plugin code here from WebCore.

  • IFWebCoreViewFactory.h: Added.
  • IFWebCoreViewFactory.m: Added.
  • Plugins.subproj/IFPlugin.h: Moved from WebCore.
  • Plugins.subproj/IFPlugin.m: Moved from WebCore.
  • Plugins.subproj/IFPluginDatabase.h: Moved from WebCore.
  • Plugins.subproj/IFPluginDatabase.m: Moved from WebCore.
  • Plugins.subproj/npapi.h: Moved from WebCore.
  • Plugins.subproj/npapi.m: Moved from WebCore.
  • WebKit.pbproj/project.pbxproj: Source file names changed
  • MIME.subproj/IFMIMEDatabase.m:
  • MIME.subproj/IFMIMEHandler.m:
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: Updated for WC -> IF name change.
  • WebCoreSupport.subproj/IFCachedTextRenderer.h: Renamed to IFTextRenderer.
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Renamed to IFTextRenderer.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Renamed to IFTextRendererFactory.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Renamed to IFTextRendererFactory.
  • WebCoreSupport.subproj/IFTextRenderer.h: Renamed from IFCachedTextRenderer.
  • WebCoreSupport.subproj/IFTextRenderer.m: Renamed from IFCachedTextRenderer.
  • WebCoreSupport.subproj/IFTextRendererFactory.h: Renamed from IFCachedTextRendererFactory.
  • WebCoreSupport.subproj/IFTextRendererFactory.m: Renamed from IFCachedTextRendererFactory. Renamed to take "Cached" out of the name now that the simpler name is available.
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Create shared IFWebCoreViewFactory. (-[IFWebView delayLayout:]): Use WEBKITDEBUG, not KWQDEBUG. (-[IFWebView notificationReceived:]): Use WEBKITDEBUG, not KWQDEBUG.
8:56 AM Changeset in webkit [1104] by darin
  • 4 edits in trunk/WebKit
  • Tools/Scripts/cvs-fix-patch: Tweak error handling a tiny bit, make usage error go to stderr, and make it not touch the file if dift -f doesn't end up fixing anything.
  • Tools/Scripts/mv-if-different: Added. Useful to overwrite a file with a new version without touching the mod date if they are equal.
  • Tools/Scripts/set-alex-version: Use mv-if-different so we don't touch files if we aren't changing anything.

WebFoundation:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]):

WebKit:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • WebCoreSupport.subproj/IFCachedTextRendererFactory.m: (-[IFFontCacheKey isEqual:]):
  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController _frameNamed:fromFrame:]):

WebBrowser:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • AppController.m: (-[AppController handleGURLEvent:withReplyEvent:]):
  • BookmarksController.m: (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
  • BrowserWindow.m: (-[BrowserWindow setLocationFieldText:]): (-[BrowserWindow toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BrowserWindow toolbarWillAddItem:]):
  • Debug/DOMTree.mm: (-[DOMTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
  • Debug/RenderTree.mm: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]):
  • StopAndGoButton.m: (-[StopAndGoButton setActiveImageSet:]):
  • Test/PageLoadTestController.m: (-[PageLoadTestController tableView:objectValueForTableColumn:row:]):
Note: See TracTimeline for information about the timeline view.