Context Navigation

← Previous Period
Next Period →

Timeline

Jul 7, 2002:

2:57 AM Changeset in webkit [1518] by mjs

20 edits in trunk

WebCore:

WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working

khtml/ecma/kjs_window.cpp: (Window::scheduleClose): In AppleChanges
khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Call kwq implementations, because we need to remember the openedByJS state across location changes, which in our case means replacing the part. (KHTMLPart::setOpenedByJS): Likewise.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openedByJS): Implement by calling bridge. (KWQKHTMLPartImpl::setOpenedByJS): Likewise. (KWQKHTMLPartImpl::close): Likewise.
kwq/KWQKHTMLPartImpl.h: Prototype new PartImpl methods.
kwq/WebCoreBridge.h: Prototype new bridge methods.

WebKit:

WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openedByScript]): Implement by calling controller. (-[IFWebCoreBridge setOpenedByScript:]): Likewise.
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _openedByScript]): Implement. (-[IFWebController _setOpenedByScript:]): Implement.

Jul 6, 2002:

12:41 AM Changeset in webkit [1517] by darin

7 edits in trunk/WebCore

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::write): Remove reference to nonexistent class in a comment.
kwq/KWQKHTMLPartImpl.h: Remove unused and unimplemented getDataSource().

Jul 5, 2002:

11:06 AM Changeset in webkit [1516] by darin

10 edits in trunk/WebKit

Fix crashes I saw with zombies enabled caused by messing with windows that are
in the process of being destroyed.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): Remove windowWillClose notification because we use viewDidMoveToWindow instead. (-[IFPluginView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
WebView.subproj/IFHTMLViewPrivate.h: Need a boolean flag to tell window changes before the first time we are installed from window changes afterward.
WebView.subproj/IFImageView.m: (-[IFImageView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.

Jul 4, 2002:

6:15 PM Changeset in webkit [1515] by mjs

5 edits in trunk/WebCore

Say "Go to" instead of "Link to" for links that won't open a new
window. Also, the code is now set up to change the status text
when modifier keys are pressed, but the code is disabled for now
because it's impossible to do reliably.

khtml/khtml_part.cpp: (KHTMLPart::overURL): (KHTMLPart::khtmlMouseMoveEvent):
khtml/khtml_part.h:

6:08 PM Changeset in webkit [1514] by mjs

4 edits in trunk/WebKit

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]): Pass the modifier flags along for mouse move events.

1:21 PM Changeset in webkit [1513] by sullivan

4 edits in trunk/WebKit

WebKit:

WebView.subproj/IFDynamicScrollBarsView.h: Updated FIXME to mention bug number.

WebBrowser:

finished a few details for 2953570 and 2953580 -- Open and Reveal in Downloads window don't handle missing-file case well
fixed 2981774 -- Status bar text not centered vertically
removed vestiges of ancient mechanism for swapping browser window view between webview & search modes

English.lproj/Browser.nib: Made the status bar a few pixels shorter. We may decide that it looks bad for it to be a different height than the favorites bar, but Don wanted to try this. Also made IFWebView a direct subview of the window's contentView, and eliminated the extra views that were part of the ancient web/search mode mechanism.

BrowserWindow.h: Removed tabView outlet.

BrowserWindow.m: (-[BrowserWindow toggleFavoritesBarWithAnimation:]): (-[BrowserWindow toggleStatusBarWithAnimation:]): Made these methods use webView instead of tabView.

DownloadMonitor.m: (-[DownloadMonitor _canOpenSelectedDownloads]): (-[DownloadMonitor _canStopSelectedDownloads]): (-[DownloadMonitor _canRevealSelectedDownloads]): (-[DownloadMonitor _canForgetSelectedDownloads]): Renamed these from "_totalSelectedAndXXXXable" and made them return BOOLs rather than ints, since that's all the callers cared about. Made them (except _canReveal) return as soon as a single valid entry is found (_canReveal has to make sure there is exactly one valid entry). Made _canOpen and _canReveal return YES even if file doesn't exist, so that the user will get the explanatory message if they click on Open or Reveal in this case.

(-[DownloadMonitor validateUserInterfaceItem:]):
Updated for method name and return-value changes; restructured so that it returns
as soon as the right selector is checked, rather than continuing to check against
other selectors.

(-[DownloadMonitor _showMissingFileErrorForOperation:andFile:]): Removed this
method; it was constructing messages using substitution patterns that might
not work in other languages.

(-[DownloadMonitor openSelectedDownloads:]):
Made the error message handle the multiple-missing-files case properly; let
all openable items be opened regardless of how many unopenable items there are
(formerly bailed at the first unopenable item). Moved sheet-displaying code
for this case into here.

(-[DownloadMonitor revealSelectedDownloads:]): Moved sheet-displaying code
for this case into here.

Jul 3, 2002:

3:58 PM Changeset in webkit [1512] by cblu

8 edits in trunk/WebKit

Fix for 2975750
Removed Java workaround since that will be fixed soon.

Plugins.subproj/IFPlugin.h:
Plugins.subproj/IFPlugin.m: (-[IFPlugin _openResourceFile]): added (-[IFPlugin _closeResourceFile:]): added (-[IFPlugin _getPluginInfo]): rename (-[IFPlugin initWithPath:]): simplified (-[IFPlugin load]): calls _openResourceFile (-[IFPlugin unload]): calls _closeResourceFile
Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): removed Java workaround

3:18 PM Changeset in webkit [1511] by darin

4 edits in trunk/WebKit

top level:

Site/Internal/Design/IFRenamings.txt: Update a bit more, preparing for the team to review.

WebKit:

Misc.subproj/IFException.h: Use Objective C header style rather than plain C.

WebBrowser:

NSViewAdditions.h:
NSViewAdditions.m: Change name of this category to match the file name to smooth things over for the IF -> Web renaming.

12:34 PM Changeset in webkit [1510] by darin

5 edits in trunk/WebCore

A small KURL speed improvement.

khtml/misc/loader.cpp: (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript): Don't do the isMalformed check, because it's expensive and has no clear benefit. There's no harm in caching null results for malformed URLs.

kwq/KWQKURL.mm: (KURL::KURL): Make the default constructor faster by not running all the normalize code on the empty string.

11:30 AM Changeset in webkit [1509]

3 copies in tags/Alexander-11

This commit was manufactured by cvs2svn to create tag 'Alexander-11'.

11:30 AM Changeset in webkit [1508] by sheridan

8 edits in trunk

Alex-11 and 0.4 versions & changelog markers

9:06 AM Changeset in webkit [1507] by darin

7 edits in trunk/WebKit

Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler finishedLoading]):
WebView.subproj/IFWebController.h: A couple places where it still said IFContentPolicyOpenExternally.

5:20 AM Changeset in webkit [1506] by mjs

17 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

khtml/ecma/kjs_window.h:
khtml/ecma/kjs_window.cpp: (Window::get): Make ScreenLeft and ScreenTop synonyms for ScreenX and ScreenY respectively.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::setView): Set the real part's view too.
kwq/kdecore/kwin.h: Remove unneeded fields.
kwq/KWQKWin.mm: (KWin::info): Implemented.
kwq/qt/qwidget.h:
kwq/KWQWidget.mm: (QWidget::winId): Return long instead of int, to make sure there is room for a pointer even on 64-bit architectures. (QWidget::mapToGlobal): Use the top level widget to map.

WebKit:

WebKit part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Pass the real document view to the newly created bridge, since it will be ready by now and is needed by JavaScript.

4:18 AM Changeset in webkit [1505] by mjs

4 edits in trunk/WebKit

Plugins.subproj/IFPluginView.mm: (-[IFPluginView status:]): Fix build problem. Why doesn't compiling catch these more reliably?

1:59 AM Changeset in webkit [1504] by rjw

13 edits in trunk

kwq/KWQScrollView.mm: (QScrollView::addChild): Fixed regression that caused IFWebView frame origin to sometimes never be set correctly. (khtml sets the x origin to -500000 during initialization, and it was never getting set correctly). This problem manifested itself as blank white frames.

kwq/KWQWidget.mm: (QWidget::internalSetGeometry):

Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_printViewHierarchy:]): Debugging help.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Added setLayouted(false).

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Tweaks attempting to fix frame drawing problems.

1:43 AM Changeset in webkit [1503] by mjs

19 edits in trunk

top level:

Site/static/javascript/javascript_window_status.html:

WebCore:

WebKit part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

Also fixed:

Radar 2980091 - KHTMLPart::findFrame() and KHTML::frameExists()
should search all frames, not just child frames

khtml/khtml_part.cpp: (KHTMLPart::overURL): Unifdef most of this, but adjust the wording. (KHTMLPart::setStatusBarText): Implement by calling KWQKHTMLPartImpl.
khtml/khtml_part.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frameExists): Search all frames, not just child frames. (KWQKHTMLPartImpl::findFrame): Search all frames, not just child frames. (KWQKHTMLPartImpl::setStatusBarText): Implemented by calling WebCoreBridge.
kwq/KWQKHTMLPartImpl.h:
kwq/WebCoreBridge.h: Declare new setStatusText method
kwq/kparts/part.h: Remove setStatusBarText method.

WebKit:

WebCore part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge setStatusText:]): Connect bridge status text setting to window context.
WebView.subproj/IFWebController.h:

WebBrowser:

Fixed Radar 2980081 - Status bar should center-truncate status messages

BrowserWindow.h:
BrowserWindow.m: (-[BrowserWindow windowDidResize:]): (-[BrowserWindow dealloc]): (-[BrowserWindow setStatus:]):

Remove dataSource argument:

WebController.m: (-[BrowserWebController setStatusText:]): (-[BrowserWebController statusText]):

Jul 2, 2002:

9:43 PM Changeset in webkit [1502] by cblu

8 edits in trunk/WebKit

WebKit:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

WebView.subproj/IFWebControllerPolicyHandler.h:
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _shouldShowDataSource:]): support for IFFileURLPolicyReveal.

WebBrowser:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

WebController.m: (-[BrowserWebController unableToImplementURLPolicyForURL:error:]): removed old comments (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): use IFFileURLPolicyReveal for files we don't open and IFFileURLPolicyOpenExternally for directories

9:38 PM Changeset in webkit [1501] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Fixed a syntax error caused by a "just before committing" edit.

9:30 PM Changeset in webkit [1500] by darin

4 edits in trunk/WebKit

fixed 2952837 -- image not rendered if height or width attributes specified incorrectly

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Set the size of both the image and the image representation.

8:52 PM Changeset in webkit [1499] by cblu

8 edits in trunk/WebKit

Can't call startLoading on a frame if setProvisionalDataSource

returned NO.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView

loadURL:inTarget:withNotifyData:andHandleAttributes:]):

WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame loadURL:attributes:flags:withParent:]):
WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:]):

7:49 PM Changeset in webkit [1498] by cblu

5 edits in trunk/WebKit

Fixed asseration failure caused by an iframe not having a correct mime type.
We now assume that local files without extensions are html files.

WebView.subproj/IFWebControllerPrivate.mm: (+[IFWebController _MIMETypeForFile:]):

5:52 PM Changeset in webkit [1497] by cblu

32 edits
6 adds in trunk/WebKit

WebFoundation:

CacheLoader.subproj/IFURLCacheLoaderConstants.h: removed IFErrorCode enum
Misc.subproj/IFError.h:
Misc.subproj/IFError.m: (classInitialize): removed WebKit error descriptions (-[IFError description]): no changes (+[IFError addErrorsFromDictionary:]): added, allows WebKit to register errors

WebKit:

Moved all policy methods to IFWebControllerPolicyHandler.h
Moved all file URL error checking to WebKit
Implemented file URL policy methods
Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally

Misc.subproj/IFWebKitErrors.h: Added.
WebKit.pbproj/project.pbxproj:
WebView.subproj/IFLocationChangeHandler.h: removed content policy stuff
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): IFContentPolicySaveAndOpenExternally rename (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): call the policy handler for content policy stuff
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forDataSource:]): sends a unableToImplementContentPolicy: (+[IFWebController canShowFile:]): now calls _MIMETypeForFile
WebView.subproj/IFWebControllerPolicyHandler.h: Added.
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally

WebBrowser:

Moved all policy methods to IFWebControllerPolicyHandler
Moved all file URL error checking to WebKit
Implemented file URL policy methods
Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally
BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): load frame only if setProvisionalDataSource returns YES
BrowserWindow.h:
BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:]): removed file URL error checking
DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]): minor clean-up
LocationChangeHandler.m: removed content policy methods
WebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally

3:44 PM Changeset in webkit [1496] by rjw

4 edits in trunk/WebKit

WebView.subproj/IFRenderNode.mm: (-[IFRenderNode initWithRenderObject:khtml::]): Fixed regression that prevented showing of nodes in subframes.

2:45 PM Changeset in webkit [1495] by darin

4 edits in trunk/WebKit

WebKit:

Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]), (-[IFPluginView start]), (-[IFPluginView stop]): Fix unused variable issue that affects deployment builds.

WebBrowser:

LocationChangeHandler.m: Improve comments.

2:28 PM Changeset in webkit [1494] by sullivan

4 edits in trunk/WebKit

Remove unnecessary code to fill with white from here; this code
path has changed. Now it just bails out early in the case where
there's no widget.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView drawRect:]):

1:57 PM Changeset in webkit [1493] by sullivan

4 edits in trunk/WebKit

Made IFWebView fill with white when there's no document view. This fixes:

2978210 -- problems with "hide status bar"
2978742 -- Resizing initially-empty Alexander window results in garbage in window

WebView.subproj/IFWebView.mm: (-[IFWebView drawRect:]):

10:39 AM Changeset in webkit [1492] by darin

4 edits in trunk/WebCore

fixed 2978806 -- Crash going to ebay home page

khtml/ecma/kjs_navigator.cpp: (PluginBase::PluginBase): Check to be sure that we are not at the end of the "tokens" collection before dereferencing the iterator.

8:16 AM Changeset in webkit [1491] by darin

5 edits in trunk/WebKit

WebView.subproj/IFMainURLHandleClient.mm: Fix comment.

8:12 AM Changeset in webkit [1490] by darin

4 edits in trunk/WebKit

fixed 2975790 - Ads on salon.com scribble all over page

Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): New, sets up the window, but does not call NPP_SetWindow again. (-[IFPluginView setWindow]): Call [setUpWindowAndPort] then call NPP_SetWindow. (-[IFPluginView start]): Register for changes to the bounds or frame of any of our superviews, not just one particular one. Also, don't bother to register for notification when the window resizes. Finally, use the constants for the names of the notifications, not literal strings. (-[IFPluginView layout]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow. (-[IFPluginView viewHasMoved:]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow.

Jul 1, 2002:

7:23 PM Changeset in webkit [1489] by mjs

11 edits
2 adds in trunk

WebCore:

Fixed Radar 2953256 - JavaScript window.moveTo() and
window.moveBy() methods do not work

This was done by creating a class to wrap an NSWindow as a
QWidget, which should be useful for many other window-related
features.

kwq/KWQWidget.mm: (QWidget::x): Implement in terms of the virtual frameGeometry() method. (QWidget::y): Likewise. (QWidget::width): Likewise. (QWidget::height): Likewise. (QWidget::size): Likewise. (QWidget::pos): Likewise. (QWidget::topLevelWidget): Implement by creating a KWQWindowWidget (QWidget::isVisible): Added FIXME comment.
kwq/KWQWindowWidget.h: Added.
kwq/KWQWindowWidget.mm: Added. (KWQWindowWidget::fromNSWindow): Static method that maintains a dictionary of top-level widgets, and creates them on demand. (deleteOnWindowClose): Delete top level widget on close. (KWQWindowWidget::KWQWindowWidget): (KWQWindowWidget::~KWQWindowWidget): (KWQWindowWidget::sizeHint): Implemented using NSWindow. (KWQWindowWidget::minimumSizeHint): Likewise. (KWQWindowWidget::frameGeometry): Likewise. (KWQWindowWidget::topLevelWidget): Likewise. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::mapFromGlobal): Likewise. (KWQWindowWidget::setCursor): No-op implementation. (KWQWindowWidget::internalSetGeometry): Implemented using NSWindow.
kwq/Makefile.am: Add new files to build.
kwq/qt/qwidget.h: Make methods virtual as needed.

WebKit:

WebView.subproj/IFWebView.mm: (-[IFWebView window]): If the view hasn't been added to a window yet, get the window from the WindowContext.

4:31 PM Changeset in webkit [1488] by rjw

5 edits in trunk/WebKit

i * WebView.subproj/IFMainURLHandleClient.mm:

(-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
Ensure that _didStopLoading is called for both error case and
non-error case.

4:07 PM Changeset in webkit [1487] by rjw

5 edits in trunk/WebKit

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): A completion message was being sent, as well as an error message. This, no doubt confused Alexander. No only send either the final error message or the completion message.

2:17 PM Changeset in webkit [1486] by darin

8 edits in trunk/WebKit

Ken fixed the load message sequencing problem in WebFoundation, so now we can
go back to the original versions of the asserts.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Roll out the stuff that's ifdef'd and marked with bug 2954901.

12:31 PM Changeset in webkit [1485] by darin

8 edits in trunk/WebKit

WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): After a closer reading of the NSScrollView source code, I see that we don't need to explicitly do tile or setNeedsDisplay: because the setters take care of that, so I made this simpler. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Replace the anti- recursion hack that I erroneously removed earlier.

WebView.subproj/IFTextView.h: Removed the isRTF flag.
WebView.subproj/IFTextView.m: (-[IFTextView provisionalDataSourceChanged:]): Do nothing here. (-[IFTextView dataSourceUpdated:]): Check the MIME type here.

12:01 PM Changeset in webkit [1484] by rjw

6 edits in trunk/WebKit

Fixed 2976913.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Augmented debugging info. (-[IFHTMLView setNeedsDisplay:]): Augmented debugging info. (-[IFHTMLView setNeedsLayout:]): Removed overload of this method to also set display flag. Why was this added? (-[IFHTMLView setNeedsToApplyStyles:]): Augmented debugging info. (-[IFHTMLView drawRect:]): Augmented debugging info.
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _timedLayout:]): If the view size is zero (width or height) force a layout now, rather than depending on the lazy layout that will happen in display. If the view size is 0,0 the AppKit will optimize out the display.

11:15 AM Changeset in webkit [1483] by cblu

4 edits in trunk/WebKit

WebKit:

Minor cleanup

Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): (-[IFNullPluginView dealloc]):

WebBrowser:

Add support for delete, clear and stop menu items and keyboard shortcuts
in Downloads.

DownloadMonitor.m: (-[DownloadMonitor validateUserInterfaceItem:]): (-[DownloadMonitor stopLoading:]): added (-[DownloadMonitor clear:]): added (-[DownloadMonitor didDoubleClick]): (-[DownloadMonitor didHitDeleteKey]): added
ListView.m: (-[ListView keyDown:]): look for delete key (-[ListView validateUserInterfaceItem:]):
WebBrowser.pbproj/project.pbxproj:

10:00 AM Changeset in webkit [1482] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-01 Kenneth Kocienda <kocienda@apple.com>

Fix for this bug:

Radar 2967062 (alexander has fit on exit)

We no longer sync the contents of the cache to disk at quit time. I also
shortented the amount of time of disk cache waits before
declaring "idle time" from 5 seconds to 1 second. This might
need some tuning, but it should keep the disk cache queue with i
writes pending from getting too long, while not stepping on more i
time-critical things like page rendering.

CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager initWithDefaultStack]) (-[IFURLLoadManager loadDidFinish:])
Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]) (-[IFURLFileDatabase setTimer])

9:19 AM Changeset in webkit [1481] by darin

16 edits in trunk

top level:

Tools/CommitLogEditor/.cvsignore: Added.

WebCore:

khtml/css/cssparser.cpp:
khtml/misc/htmlhashes.cpp: Remove workaround for a PFE bug that no longer affects us.

khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_nodeimpl.cpp: Remove some unneeded APPLE_CHANGES.

WebCore.exp: One less symbol to export.

WebKit:

Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): Fix off-by one error that would cause a memory trasher if we had a 255-character string.

WebView.subproj/IFHTMLView.mm:
WebView.subproj/IFRenderNode.mm: Touch these files so we don't have to do a full build of WebKit for my WebCore changes.

5:35 AM Changeset in webkit [1480] by mjs

7 edits in trunk/WebKit

WebKit:

Build fixes (don't know why a plain build didn't catch these):

Plugins.subproj/IFPluginView.mm: openNewWindowWithURL: is not a method of the controller any more, nor are the status-related calls.
WebView.subproj/IFWebController.h: Un-ifdef the status calls.

WebBrowser:

Build fixes:

BrowserDocument.h,
BrowserDocument.m: (-[BrowserDocument highestPriorityStatusMessage]): Make this public. (-[BrowserDocument _updateStatusInBrowserWindow]): Adjust for rename.
WebController.m: (-[BrowserWebController statusTextForDataSource:]): Implemented.

1:48 AM Changeset in webkit [1479] by mjs

4 edits in trunk/WebKit

WebKit:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Show the window.

WebBrowser:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

BrowserDocument.m: (-[BrowserDocument setShouldStartEmpty]): Ensure the window exists, so that there are a frame and web view ready in time.

1:18 AM Changeset in webkit [1478] by mjs

4 edits in trunk/WebKit

Fix Radar 2953256 - Auth sheet appears detached when clicking
directly on auth link with Alex not running

Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels frontmostWindowLoadingURL:]): Don't consider windows that are not visible.

Jun 29, 2002:

10:31 PM Changeset in webkit [1477] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Fix calculation of oneTileRect. I think this is finally correct now.

4:28 PM Changeset in webkit [1476] by mjs

26 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

kwq/WebCoreBridge.h: Add new calls needed for window size/position/feature getting and setting.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set properties on window after creating it using new bridge calls; make it visible.
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Support scrollbars feature too.
kwq/kparts/browserextension.h: Include scrollbar setting stuff.

WebKit:

WebKit part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

Also, renamed IFScriptContextHandler protocol to IFWindowContext,
and made it a settable handler like the others rather than
something implemented by the controller, so it can be used w/o
subclassing.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]): Forward to the WindowContext. (-[IFWebCoreBridge areToolbarsVisisble]): Likewise. (-[IFWebCoreBridge setToolbarsVisible:]): Likewise. (-[IFWebCoreBridge areScrollbarsVisible]): Likewise. (-[IFWebCoreBridge setScrollbarsVisible:]): Likewise. (-[IFWebCoreBridge isStatusBarVisisble]): Likewise. (-[IFWebCoreBridge setStatusBarVisible:]): Likewise. (-[IFWebCoreBridge setWindowFrame:]): Likewise. (-[IFWebCoreBridge window]): Likewise.
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: (-[IFWebController setWindowContext:]): Setter for new WindowContext handler (-[IFWebController windowContext]): Likewise.
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release window context.
WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Open new windows via WindowContext.

WebBrowser:

WebBrowser part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

BrowserDocument.m: (-[BrowserDocument init]): Set the WebController as it's own WindowContext too.
BrowserWindow.h:
BrowserWindow.m: (-[BrowserWindow _saveFrameIfAllowed]): Don't save the frame if the last (-[BrowserWindow setFrameWithoutAutosaving:]): Change window size and position but without saving the frame; if this is a size change and not just a move, avoid saving the frame until the next user resize. (-[BrowserWindow windowDidResize:]): More stuff for the above. (-[BrowserWindow isFavoritesBarVisible]): Implemented. (-[BrowserWindow setFavoritesBarVisible:]): Implemented. (-[BrowserWindow isStatusBarVisible]): Implemented. (-[BrowserWindow setStatusBarVisible:]): Implemented. (-[BrowserWindow isToolbarVisible]): Implemented. (-[BrowserWindow setToolbarVisible:]): Implemented.
WebController.h:
WebController.m: (-[BrowserWebController openNewWindowWithURL:]): Don't initially show the window even if no URL is set, so initial parameters can be set properly. (-[BrowserWebController areToolbarsVisible]): Implemented. (-[BrowserWebController setToolbarsVisible:]): Implemented. (-[BrowserWebController isStatusBarVisible]): Implemented. (-[BrowserWebController setStatusBarVisible:]): Implemented. (-[BrowserWebController window]): Implemented. (-[BrowserWebController setFrame:]): Implemented.

Jun 28, 2002:

4:53 PM Changeset in webkit [1475] by darin

6 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.h: Renamed statusOfCache to patternColorLoadStatus for clarity.
WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer copyWithZone:]): Add FIXME. (-[IFImageRenderer tileInRect:fromPoint:]): Add optimization for the case where a single draw of the image will cover the entire area to be tiled. Also add comments and make other small improvements.

3:32 PM Changeset in webkit [1474]

2 copies
34 deletes in tags/WebFoundation-6~8

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~8'.

3:32 PM Changeset in webkit [1473]

2 copies
34 deletes in tags/WebFoundation-6~7

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~7'.

3:32 PM Changeset in webkit [1472]

2 copies
34 deletes in tags/WebFoundation-6~6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~6'.

3:32 PM Changeset in webkit [1471]

2 copies
34 deletes in tags/WebFoundation-6~5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~5'.

3:32 PM Changeset in webkit [1470] by kocienda

1 edit in branches/jaguar-branch/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-28 Kenneth Kocienda <kocienda@apple.com>

Fix for these two bugs:

Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

Radar 2968370 (Crash in Pictures channel)

I fixed the fact that load failure messages were not being moved over to
the one thread that can safely call into CFNetwork.

In the process of doing this, I cleaned up this internal interface:

-(void)_backgroundLoadFailedWithResultCode:(IFURLHandleResult)errorCode inDomain:(IFErrorCodeDomain)domain isTerminal:(BOOL)terminal;

is now:

-(void)_backgroundLoadFailedWithError:(IFError *)error;

CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithError:])
CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
CacheLoader.subproj/IFURLHandlePrivate.h:
CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (initLoader) (-[IFURLLoad setError:]) (-[IFURLLoad performFailed]) (_handleLoadRequests) (_loadSweeper)
Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc])
WebFoundation.pbproj/project.pbxproj

2:13 PM Changeset in webkit [1469] by rjw

16 edits in trunk

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

khtml/rendering/font.cpp: (Font::floatWidth): (Font::floatCharacterWidth):
khtml/rendering/font.h:
khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):
kwq/KWQFontMetrics.mm: (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):
kwq/WebCoreTextRenderer.h:
kwq/qt/qfontmetrics.h:

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Cleaned up use of loadStatus.
WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

1:20 PM Changeset in webkit [1468] by cblu

10 edits in trunk/WebKit

WebBrowser:

Bugs fixes for Downloads

DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor init]): init totals ivars (-[DownloadMonitor _findEntryForView:]): added (-[DownloadMonitor _makeSelectedDownloadsPerformSelector:]): prepended a "_" (-[DownloadMonitor sheetDidDismiss:returnCode:contextInfo:]): cancel downloads before quit (-[DownloadMonitor _updateTotals]): added, updates totals ivars (-[DownloadMonitor validateUserInterfaceItem:]): simplified, reveal allowed only for 1 item (-[DownloadMonitor didDoubleClick]): added, calls reveal (-[DownloadMonitor openSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor stopSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor revealSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector
DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): only stops active downloads (-[DownloadProgressEntry reveal]): allowed for items currently downloading
ListView.m: (-[ListView mouseDown:]): watch for double-click

WebKit:

WebView.subproj/IFMainURLHandleClient.h:
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient downloadHandler]): added (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): removed [downloadHandler cancel]
WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource stopLoading]): call [downloadHandler cancel] here so clean up is done immediately.

Jun 27, 2002:

5:07 PM Changeset in webkit [1467] by cblu

4 edits in trunk/WebCore

Added an APPLE_CHANGES to fix 2894742. The attributes of an EMBED tag
must override the attributes of PARAM tags.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):

4:25 PM Changeset in webkit [1466] by rjw

6 edits in trunk/WebKit

Fixed tiling of progressively loaded images.

WebCoreSupport.subproj/IFImageRenderer.h:
WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): (-[IFImageRenderer loadStatus]): (-[IFImageRenderer tileInRect:fromPoint:]):

4:09 PM Changeset in webkit [1465] by rjw

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Fixed uninitialized variable warning. Compile being too aggressive, broke deployment build.

2:59 PM Changeset in webkit [1464] by cblu

4 edits in trunk/WebKit

Fixed plug-in positioning.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView

initWithFrame:plugin:url:baseURL:mime:arguments:]): added some logging.

(-[IFPluginView setWindow]): Use the window's content view as the

guide for the port's coordinates. Also added a workaround for Java.

2:39 PM Changeset in webkit [1463] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-27 Kenneth Kocienda <kocienda@apple.com>

Fix for this bug:

Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]):

2:05 PM Changeset in webkit [1462] by darin

5 edits in trunk/WebKit

Fixed DOM tree viewer.

WebView.subproj/IFDOMNode.mm: (-[IFDOMNode initWithDOMNode:DOM::]): A typo got in here somehow, leading to an infinite loop.

2:01 PM Changeset in webkit [1461] by darin

4 edits in trunk/WebCore

fixed 2973342 -- copied text seems to have an extra blank line between paragraphs

khtml/khtml_part.cpp: (KHTMLPart::selectedText): Get rid of code that was adding an extraneous newline at the ends of various types of nodes, including <P>.

1:22 PM Changeset in webkit [1460] by darin

4 edits
2 deletes in trunk/WebKit

fixed 2973212 -- bad arg string != nil in _IF_URLWithString

WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Get rid of essentially-dead code that computed but did not use a URL. Also order operations so that we first set the flag to say that we're loading, then tell the location change handler, and only then ask for the actual I/O to being.

WebView.subproj/IFBaseLocationChangeHandler.h: Removed.
WebView.subproj/IFBaseLocationChangeHandler.m: Removed.

1:19 PM Changeset in webkit [1459] by darin

10 edits in trunk/WebCore

Fix Java. My changes this morning broke it.

khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Re-add required APPLE_CHANGES. Pass arguments to KJavaAppletWidget::processArguments.
kwq/khtml/java/kjavaappletwidget.h: Added KJavaAppletWidget::processArguments.
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::processArguments): Added.

Some QFont fixes.

kwq/qt/qfont.h: Remove unused setPixelSizeFloat.
kwq/KWQFont.mm: Change to keep family names in a set. Since there are only a small number of family names ever encountered, this is a bit of a memory win. (QFont::QFont): Don't retain the family name. (QFont::~QFont): Don't release the family name. (QFont::setFamily): Put the family name in a set, and use the one from the set. (QFont::operator=): Don't retain or release. (QFont::operator==): Use == to compare the name.

12:28 PM Changeset in webkit [1458]

3 copies in tags/Alexander-10

This commit was manufactured by cvs2svn to create tag 'Alexander-10'.

12:28 PM Changeset in webkit [1457] by sheridan

8 edits in trunk

Alex-10 version

11:14 AM Changeset in webkit [1456] by rjw

12 edits in trunk

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint().

kwq/WebCoreTextRenderer.h:

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint(). Stubbed
only, no support for new parameters yet.

Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
WebCoreSupport.subproj/IFTextRenderer.h:
WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]): (-[IFTextRenderer widthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):

9:29 AM Changeset in webkit [1455] by rjw

9 edits in trunk

Removed old methods and references.

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): Fixed final fragment rendering glitch.

Removed calls to old method.

kwq/KWQPainter.mm: (QPainter::drawText):
kwq/WebCoreTextRenderer.h: Removed old methods.

9:17 AM Changeset in webkit [1454] by darin

23 edits in trunk

WebCore:

khtml/rendering/render_applet.cpp: Remove include of <iostream.h> to avoid bloat. (RenderApplet::RenderApplet): Remove APPLE_CHANGES. (RenderApplet::processArguments): Remove APPLE_CHANGES. This file is now back to 100% the same as the KDE original.

kwq/khtml/java/kjavaappletwidget.h: Added a bit of stuff so we match the interface of the KDE original and don't need APPLE_CHANGES.
kwq/KWQKJavaAppletWidget.mm: Remove include of <iostream.h> to avoid bloat. (KJavaAppletWidget::KJavaAppletWidget): Update for parameters that match the KDE original. (KJavaAppletWidget::~KJavaAppletWidget): Added. (KJavaAppletWidget::setBaseURL): Added. (KJavaAppletWidget::setParameter): Put strings into an NSMutableDictionary. (KJavaAppletWidget::showApplet): Use the new baseURL and parameters dictionary.

kwq/WebCoreViewFactory.h: Add baseURL parameter.
kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Add baseURL parameter.

kwq/kdecore/kurl.h: Fix NSURL definition to fit idiom.
kwq/qt/qmap.h: Added the const version of the [] operator.

khtml/ecma/kjs_navigator.cpp: Tweak whitespace.
khtml/html/html_documentimpl.cpp: Tweak to make it a little closer to original.

kwq/KWQKCookieJar.h: Reduce includes.
kwq/KWQKCookieJar.mm: Move includes in here.

kwq/WebCoreCookieAdapter.h: Fix comment that emacs munged.

WebKit:

WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Pass baseURL as a separate parameter.

WebView.subproj/IFBaseLocationChangeHandler.m: Fix a typo. I think this file might be unneeded, but I won't delete it until I hear from Chris.

8:54 AM Changeset in webkit [1453] by rjw

4 edits in trunk/WebKit

Fix selection in 'slow' code path (non-base characters and font substitution).

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]):

8:25 AM Changeset in webkit [1452] by rjw

4 edits in trunk/WebKit

Implemented auto scrolling.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseDragged:]):

8:20 AM Changeset in webkit [1451] by rjw

9 edits in trunk

Implement selectAll.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView selectAll:]):

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectAll]): Select all using the part.

6:52 AM Changeset in webkit [1450] by rjw

2 edits in trunk/WebKit

Forgot to commit ChangeLog.

2:42 AM Changeset in webkit [1449] by mjs

12 edits
8 adds in trunk

WebCore:

WebCore part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

kwq/KWQKCookieJar.h: Added.
kwq/KWQKCookieJar.mm: Added. (KWQKCookieJar::cookie): C++ veneer over WebCoreCookieAdapter call. (KWQKCookieJar::setCookie): Likewise. (KWQKCookieJar::cookieEnabled): Likewise.
kwq/Makefile.am: Add new files to build.
kwq/WebCoreCookieAdapter.h: Added.
kwq/WebCoreCookieAdapter.m: Added. (+[WebCoreCookieAdapter sharedAdapter]): Method to return shared instance, al la the WebCoreFactory classes. (-[WebCoreCookieAdapter init]): Establish self as shared instance. (-[WebCoreCookieAdapter cookiesEnabled]): No-op implementation. (-[WebCoreCookieAdapter cookiesForURL:]): Likewise. (-[WebCoreCookieAdapter setCookies:forURL:]): Likewise.
WebCore.exp: Export WebCoreCookieAdapter class.
khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Call appropriate KWQCookieJar method.
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::cookie): Call appropriate KWQCookieJar method. (HTMLDocumentImpl::setCookie): Likewise

WebKit:

WebKit part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

WebCoreSupport.subproj/IFCookieAdapter.h: Added.
WebCoreSupport.subproj/IFCookieAdapter.m: Added. (+[IFCookieAdapter createSharedAdapter]): Set up an instance of IFCookieAdapter as the WebCoreCookieAdapter shared instance. (-[IFCookieAdapter cookiesEnabled]): Implement in terms of WebFoundation stuff. (-[IFCookieAdapter cookiesForURL:]): Likewise. (-[IFCookieAdapter setCookies:forURL:]): Likewise.
WebKit.pbproj/project.pbxproj: Add new files to build.
WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Hook up the cookie adapter just like the various factory classes.

12:29 AM Changeset in webkit [1448] by cblu

15 edits in trunk

WebCore:

Fix to support sending PARAM tags to the Java plug-in.

khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): removed APPLE_CHANGES (RenderApplet::layout): removed APPLE_CHANGES
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): removed setView (KJavaAppletWidget::showApplet): call setView here
kwq/WebCoreViewFactory.h:
kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed
kwq/khtml/java/kjavaappletwidget.h: added KJavaApplet

WebKit:

Support for Java.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): set DOCBASE argument
WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed

WebBrowser:

Removed some logging.

DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):

Jun 26, 2002:

9:42 PM Changeset in webkit [1447] by rjw

14 edits in trunk

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases. Still need to work on
TextSlave::checkSelectionPoint. Fixed redraw region
problems.

khtml redraw the entire visible region when selection changes.
This could be optimzed.

khtml/rendering/font.cpp: (Font::drawText): (Font::width):
khtml/rendering/render_text.cpp: (TextSlave::printSelection):
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::selectedTextBackgroundColor):
kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
kwq/WebCoreTextRenderer.h:
kwq/qt/qpainter.h:

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases.

Still need to work on:

'slow' drawing cases, i.e. runs with non-base characters

or runs requiring font substitution.

Select All menu item.
Auto scrolling.

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:]): (-[IFTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]):

3:47 PM Changeset in webkit [1446] by darin

4 edits in trunk/WebKit

fixed 2969280 -- if trailing / not specified for site, relative URLs are incorrectly expanded

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Update the URL for the case where we've already been redirected before we receive any data.

3:14 PM Changeset in webkit [1445] by mjs

8 edits in trunk/WebCore

Implement KHTMLPart::findFrame() to fix the following Radar bugs:

Radar 2943177 - infinite JavaScript loop sfcu.org online bill paying
Radar 2950580 - Unknown JavaScript properties on the Window object return self instead

of Undefined

khtml/khtml_part.cpp: (KHTMLPart::findFrame):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::findFrame):
kwq/KWQKHTMLPartImpl.h:

3:03 PM Changeset in webkit [1444] by darin

10 edits in trunk/WebKit

fixed 2971532 -- crash with null KHTMLView at gramicci.com

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView reapplyStyles]): Handle widget == 0 case. (-[IFHTMLView layout]): Handle widget == 0 case.

Fixed a crash I have seen many times where a data source tries
to use its parent to locate the controller after its parent is
deallocated.

WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Use _parentDataSourceWillBeDeallocated instead of _setController:nil.

WebView.subproj/IFWebFramePrivate.h: Add _parentDataSourceWillBeDeallocated.
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _parentDataSourceWillBeDeallocated]): Does both a _setController:nil, and a _setParent:nil on both data sources.

1:44 PM Changeset in webkit [1443] by sullivan

5 edits in trunk/WebKit

fixed 2971024 -- wrong item is bookmarked

-[IFWebDataSource redirectedURL] was returning the URL of a
sub-page resource.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Removed evil call to _setFinalURL here. It had no right to live.

12:35 PM Changeset in webkit [1442] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]): Fix NSBitmapImageRep leak.

12:01 PM Changeset in webkit [1441] by darin

5 edits in trunk/WebCore

fixed 2969378 -- "A with hat" characters (Unicode 00C2) showing up at Zingermans.com

kwq/KWQCharsets.mm: (buildDictionaries): Put UTF-16 in the dictionary, but pointing at the string encoding for UTF-8. This mimics what Internet Explorer does.

kwq/KWQtextcodec.mm: (QTextCodec::fromUnicode): Fix implementation so it will convert the specified encoding instead of always Latin-1.

11:53 AM Changeset in webkit [1440] by cblu

10 edits in trunk/WebKit

WebKit:

added "complete" to progress methods to indicate last progress message

Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): added a draw test
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

WebBrowser:

added "complete" to progress methods to indicate last progress message

DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):
WebController.m: (-[WebController receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]):

10:53 AM Changeset in webkit [1439] by rjw

8 edits in trunk/WebKit

Fixed recursion problems. +[NSFont findFontLike:forString:withRange:inLanguage:]
will alternate between suggested fonts with bogus answers. The work
around involves adding an explicit flag indicating whether or not
font substitution should be attempted.

Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
WebCoreSupport.subproj/IFTextRenderer.h:
WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:attemptFontSubstitution:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]):

9:40 AM Changeset in webkit [1438] by darin

4 edits in trunk/WebKit

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateUserInterfaceItem:]): Switch to this instead of validateMenuItem: so that a Copy toolbar button would work.

9:16 AM Changeset in webkit [1437] by darin

8 edits in trunk/WebCore

Fixed (or at least worked around) a crash I saw where KWQKHTMLPartImpl::end was
making calls after the KHTMLView was gone. This is specific to our APPLE_CHANGES
code; it's handled differently in KDE.

khtml/khtml_part.h: Added detachView.
khtml/khtml_part.cpp: (KHTMLPart::detachView): Added. Nils out the view pointer.
khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Call m_part->detachView().
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::end): Don't try to make calls to the view if it's nil.

Jun 25, 2002:

7:50 PM Changeset in webkit [1436] by rjw

8 edits in trunk/WebKit

Disable the copy menu item when IFHTMLView is key
and has no selection.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateMenuItem:]): Disable menu if selection is empty. (-[IFHTMLView copy:]): Factored code that gets the bridge.
WebView.subproj/IFHTMLViewPrivate.h: Added _bridge.
WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _bridge]): We need to access the bridge from the view to get the part's selection.

7:26 PM Changeset in webkit [1435] by rjw

8 edits in trunk/WebCore

Support for khtml style selection drawing. Ugly,
we'll want to make this more Mac like.

khtml/rendering/font.cpp: (Font::drawText):

Enable khtml code path. Removed APPLE_CHANGES

kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth):

Implemented in terms of width().

kwq/KWQPainter.mm: (QPainter::drawText):

Implemented.

kwq/qt/qfontmetrics.h:

Added QFontMetrics::charWidth.

4:32 PM Changeset in webkit [1434] by cblu

4 edits in trunk/WebKit

Remove downloaded file if cancelled.

Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler cancel]):

3:16 PM Changeset in webkit [1433] by rjw

16 edits in trunk

Support for rudimentary plain text 'copy'.

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
WebView.subproj/IFHTMLView.mm: (-[IFHTMLView copy:]):
WebView.subproj/IFWebViewPrivate.h:
WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _controller]):

Support for rudimentary plain text 'copy'.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]):

1:18 PM Changeset in webkit [1432] by rjw

13 edits in trunk

Enabled progressive image loading code.

WebCoreSupport.subproj/IFImageRenderer.h:
WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]):

Enabled progressive image loading code.

khtml/misc/loader.cpp: (CachedImage::data):
kwq/KWQPixmap.mm: (QPixmap::QPixmap):

11:56 AM Changeset in webkit [1431] by rjw

4 edits in trunk/WebKit

Extended our text measurement rounding work-around for integer-float
mismatch to round on word boundaries as well as spaces.

10:38 AM Changeset in webkit [1430] by darin

8 edits in trunk/WebKit

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Don't remove the URL handle from the data source until we've finished the loading process in KDE code. This may fix 2968527.

WebCoreSupport.subproj/IFTextRenderer.m: Keep around commented printfs so I can do the "dump all strings as they are rendered" again.

WebKit.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.

10:31 AM Changeset in webkit [1429] by darin

4 edits in trunk/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.

10:30 AM Changeset in webkit [1428] by darin

26 edits in trunk/WebCore

Removed remaining uses of BORROWED defines.
Made some simplifications and formatting fixes. All safe.

kwq/KWQArrayImpl.h:
kwq/KWQArrayImpl.mm:
kwq/KWQChar.mm:
kwq/KWQCharsets.mm:
kwq/KWQFile.mm:
kwq/KWQKCursor.mm:
kwq/KWQKHTMLPart.mm:
kwq/KWQListImpl.h:
kwq/KWQMapImpl.mm:
kwq/KWQString.mm:
kwq/KWQValueListImpl.mm:
kwq/KWQVectorImpl.h:
kwq/KWQtextcodec.mm:
kwq/make-charset-table.pl:
kwq/make-mac-encodings.c:
kwq/qt/qfile.h:
kwq/qt/qregexp.h:
kwq/qt/qtextcodec.h:

WebCore-tests.exp: Small change to exports for the array test.

7:30 AM Changeset in webkit [1427] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Remove stray NSLog.

12:33 AM Changeset in webkit [1426] by darin

6 edits in trunk/WebKit

fixed 2968298 -- IFImageRenderer crash at download.com

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): Override this instead of [init]. This is the designated initializer and all the others call this. (-[IFImageRenderer copyWithZone:]): Override to nil out fields that can't be shared by the copy.

Fix leaks.

History.subproj/IFURIEntry.m: (-[IFURIEntry initWithURL:title:image:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry dealloc]): Release _displayTitle. Fixes a leak. (-[IFURIEntry setTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry setDisplayTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry initFromDictionaryRepresentation:]): Lose the extra retain for _lastVisitedDate. Fixes a leak.

Jun 24, 2002:

9:50 PM Changeset in webkit [1425] by darin

4 edits in trunk/WebKit

Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels didStopLoadingURL:inWindow:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.

6:59 PM Changeset in webkit [1424] by rjw

4 edits in trunk/WebKit

Changed our usage of +[NSFont findFontLike:forString:withRange:inLanguage:]
after talking with Aki. We were erroneously passing a complete
string rather than a character cluster. Fixed 2964793.

WebCoreSupport.subproj/IFTextRenderer.m: (findLengthOfCharacterCluster): (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawGlyphs:numGlyphs:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer _drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]):

4:21 PM Changeset in webkit [1423] by darin

4 edits in trunk/WebKit

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Take ownership before doing the setWidget. The other way the widget was getting deleted.

4:08 PM Changeset in webkit [1422] by cblu

7 edits in trunk/WebCore

* empty log message *

3:06 PM Changeset in webkit [1421] by cblu

12 edits in trunk/WebKit

WebKit:

Plugins.subproj/IFPlugin.h:
Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): Close resource files when done. (-[IFPlugin load]): Remove Java plug-in workaround, load as mach-o
Plugins.subproj/IFPluginView.h:
Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): take NSURLs (-[IFPluginView dealloc]): release baseURL
WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): take NSURLs (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):

WebCore:

Changed the plug-in view constructor to take NSURL's rather
than URL strings.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestObject):
kwq/WebCoreViewFactory.h:
kwq/WebCoreViewFactory.m:

12:20 PM Changeset in webkit [1420] by darin

10 edits in trunk/WebKit

Remove some unused stuff. Other minor cleanup.

WebView.subproj/IFDynamicScrollBarsView.h: Remove breakRecursionCycle, don't declare updateScrollers or resetCursorRects.

WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): Make this work even for a view that doesn't allow scrolling, turning off both scrollers in that case. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Call updateScrollers unconditionally, letting it decide what to do, rather than looking at allowsScrolling. Also, no need to use a boolean to break the recursion cycle, now that updateScrollers does no work if none is needed. (-[IFDynamicScrollBarsView setCursor:]): Do nothing if the cursor is not changing. Also handle arrowCursor case here. (-[IFDynamicScrollBarsView resetCursorRects]): Call discardCursorRects so the old rects won't keep accumulating. (-[IFDynamicScrollBarsView setAllowsScrolling:]): Always call updateScrollers, not just when turning scrolling off.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]): Remove unneeded NSWindowWillCloseNotification and isFlipped field. (-[IFHTMLView removeNotifications]): Moved here from NSWindowWillCloseNotification. (-[IFHTMLView viewWillMoveToWindow:]): Remove all the notifications when the view is removed from the window. (-[IFHTMLView setNeedsLayout:]): Call setNeedsDisplay in the YES case, so the callers don't all have to. (-[IFHTMLView isFlipped]): Just return YES. No need to store it. (-[IFHTMLView windowResized:]): Add a FIXME, since this is not the way we want to handle view resizing for the long run.
WebView.subproj/IFHTMLViewPrivate.h: Remove isFlipped.

12:13 PM Changeset in webkit [1419] by darin

22 edits in trunk

WebCore:

khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Put APPLE_CHANGES later in the sequence so we don't deref the part before the code gets to run.

kwq/kwqdebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

WebKit:

Fix the last of the "leak the world" problems. The KHTMLView was leaking
in IFHTMLView.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView dealloc]): Call _reset instead of _stopPlugins, so we get rid of the widget too. (-[IFHTMLView viewWillMoveToWindow:]): Use _reset now instead of the old _stopPlugins; also check that the window isn't already nil so we don't do a reset as part of our first install. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the new widgetOwned flag to tell if the widget should be deleted instead of deciding based on whether the dataSource is the main document.

WebView.subproj/IFHTMLViewPrivate.h: Add a widgetOwned boolean and a private _takeOwnershipOfWidget method. Combine _resetWidget and _stopPlugins into a single _reset call. Remove _removeSubviews.

WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): New name for the combination of _resetWidget and _stopPlugins. Now it decides whether to delete the widget based on the widget owned flag, so it is safe to call even for non-main-document views. (-[IFHTMLView _takeOwnershipOfWidget]): Sets widgetOwned to NO.

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame reset]): Use _resetWidget under its new name _reset.

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Don't bother doing explicit _stopPlugins and _removeSubviews. It's now the view's own responsibility to do this in viewWillMoveToWindow:. Call _takeOwnershipOfWidget after attaching the widget to the RenderPart.

WebView.subproj/IFImageView.m: (-[IFImageView viewWillMoveToWindow:]): Added. Break the reference cycle by stopping animated IFImageRenderer here instead of waiting for dealloc.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): Fix a warning by changing the printf format string to match the parameter type.

Misc.subproj/WebKitDebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

Jun 23, 2002:

11:17 AM Changeset in webkit [1418] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use hasAlpha instead of isOpaque because the latter does not work (Radar 2966937).

Jun 21, 2002:

5:24 PM Changeset in webkit [1417] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Add back the higher-speed case where we draw directly for opaque animated images.

4:40 PM Changeset in webkit [1416] by darin

18 edits in trunk

WebCore:

kwq/KWQFont.mm: Made it store a copy of the family name instead of storing a reference to the mutable CFString.

kwq/KWQPainter.mm: (QPainter::drawPixmap): Simplified. (QPainter::drawTiledPixmap): Used the new [tileInRect:].

kwq/WebCoreImageRenderer.h: Added [tileInRect:], removed [drawInRect:], and also removed view parameter from [beginAnimation].

kwq/qt/qpixmap.h: Removed unneeded getImageRenderer().

WebKit:

Cache the patterns we make for tiled images for added speed.

WebCoreSupport.subproj/IFImageRenderer.h: Removed declarations of methods inherited from WebCoreImageRenderer. Added patternColor field.

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer dealloc]): Release patternColor. (-[IFImageRenderer beginAnimationInRect:fromRect:]): Get the view with [NSView focusView] rather than taking a parameter that's used only for the animating case. (-[IFImageRenderer tileInRect:fromPoint:]): New. Caches the pattern in the patternColor field.

WebView.subproj/IFImageView.m: (-[IFImageView drawRect:]): No need to pass view to image renderer any more.

10:38 AM Changeset in webkit [1415] by darin

3 edits in trunk/WebCore

Added bug number:

fixed 2964718 -- crash in KWQCheckCacheObjectStatus

10:24 AM Changeset in webkit [1414] by darin

4 edits in trunk/WebKit

Fix rendering of non-opaque animated images.

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use [NSView displayRect:] instead of drawing explicitly so that views behind us get a chance to draw too. This is less efficient than just drawing for opaque images, but NSImage doesn't offer a way to find out if the image is opaque. Also, this changes things a bit because beginAnimationInView gets called again, so we don't have to reschedule the timer.

10:20 AM Changeset in webkit [1413] by darin

6 edits in trunk/WebCore

kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): Handle case of nil object. Add comments. Remove questionable use of floating point abs() to convert always positive int to uint.

Jun 20, 2002:

6:27 PM Changeset in webkit [1412] by rjw

8 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]):

Added minimum 1/60th second duration per frame.

WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):

Only display scrollview if scrollers changed.

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Explicity turn on copiesOnScroll. This may cause problems w/
plugins. Need to verify once plugins are no longer crashing.

4:35 PM Changeset in webkit [1411] by darin

41 edits
2 deletes in trunk

WebCore:

kwq/KWQKCharsets.mm: Removed unneeded parts.
kwq/KWQStyle.mm: Removed.
kwq/KWQToolTip.mm: Removed.
kwq/KWQVariant.mm: Simplified.
kwq/Makefile.am: Removed KWQStyle.mm and KWQToolTip.mm.

kwq/KWQRefPtr.h: Streamlined implementation that inlines a bit less and is more efficient for creating empty pointers.

kwq/KWQStyle.h: Removed unused stuff.

kwq/kdecore/kcharsets.h: Removed unneeded parts.
kwq/qt/qsortedlist.h: Removed unneeded parts.
kwq/qt/qtooltip.h: Removed unneeded parts.
kwq/qt/qvariant.h: Removed unneeded parts.

khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove unneeded APPLE_CHANGES -- no need to nil something out in a destructor.

WebKit:

Fix for leak where sub-frame IFHTMLViews would not call _stopPlugins.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewWillMoveToWindow:]):
WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewWillMoveToWindow:]): Use this viewWillMoveToWindow instead of removeFromSuperview; it's a more reliable way to handle cases where the view is removed from the view hierarchy.

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

WebView.subproj/IFLocationChangeHandler.h: Add dataSource parameters for the methods that don't have them so this can be "delegate" style.
WebView.subproj/IFWebController.h: Pass a dataSource instead of a frame when asking for a location change handler.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Pass dataSource for locationChangeDone.

WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Pass dataSource for locationChangeStarted.

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]): Pass a dataSource instead of a frame when asking for a location change handler.

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Pass dataSource for locationChangeCommitted. (-[IFWebFrame _isLoadComplete]): Pass dataSource for locationChangeDone.

force-clean-timestamp: Give this mechanism a try. I'm not sure we really need a clean build right now.

WebView.subproj/IFWebDataSource.mm: Simplify.

WebBrowser:

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor monitorLocationChangeHandler:forFrame:]): (-[LoadProgressMonitor setError:forLocationChangeHandler:frame:]): Changed to pass frames around, since the location change handler can't store a frame any more.

LocationChangeHandler.h: Updated for new API that's delegate style, where the data source is passed into all methods rather than being retained.
LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): A frame isn't passed any more. (-[LocationChangeHandler dealloc]): No frame to release. (-[LocationChangeHandler _mainFrame]): Get from document, not frame. (-[LocationChangeHandler _loadMonitor]): Get from document, not frame. (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler receivedPageTitle:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]): (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]): Use passed dataSource rather then the frame.

WebController.m: (-[WebController provideLocationChangeHandlerForDataSource:]): No frame to pass in any more.

WebBrowser.pbproj/project.pbxproj: Project Builder had some axe to grind.

1:27 PM Changeset in webkit [1410] by kocienda

21 edits in trunk/WebKit

2002-06-20 Kenneth Kocienda <kocienda@apple.com>

A more complete fix for this bug:

Radar 2942728 (Link to Yahoo! Finance stocks page fails, says URL is "not a valid location")

I added a new +(NSURL)_IF_URLWithString: method to IFNSURLExtensions.
This is now the suggested way to create a URL from a string.

WebBrowser:

AppController.m: (-[AppController handleGURLEvent:withReplyEvent:])
BookmarksController.m: (-[BookmarksController outlineView:writeItems:toPasteboard:])
BrowserDocument.m: (-[BrowserDocument goHome:])
BrowserDocumentController.m: (-[BrowserDocumentController URLFromShortcutFile:])
BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:])
Debug/DebugUtilities.m: (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]) (-[IFWebHistory populateHistoryWithTestData:])
GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:])
IFBookmarkAdditions.m: (-[IFBookmark goTo])
LocationFieldEditor.m: (-[LocationFieldEditor concludeDragOperation:]) (-[LocationFieldEditor paste:])
ResourceProgressEntry.m: (-[ResourceProgressEntry URL])
Scripting.subproj/Scripting.m: (-[GetURLCommand performDefaultImplementation]) (-[OpenURLCommand performDefaultImplementation])
Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]) (-[PageLoadTestRunner loadTestSuiteFile:])
WebBrowser.pbproj/project.pbxproj:

WebKit:

History.subproj/IFURIEntry.m: (-[IFURIEntry initFromDictionaryRepresentation:])
History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles URLsFromPasteboard:])
History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate updateURL:title:displayTitle:forURL:])
Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:])
Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]) (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:])
WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:])
WebKit.pbproj/project.pbxproj:
WebView.subproj/IFWebDataSource.h:
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:])
WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:])

WebFoundation:

AuthenticationManager.subproj/IFAuthenticationManager.m: (IFNSURLGetParent):
CacheLoader.subproj/IFFileURLProtocolHandler.m: (+[IFFileURLProtocolHandler canonicalizeURL:]):
CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]): (-[IFHTTPURLProtocolHandler URLFromLocationHeader]): (-[IFHTTPURLProtocolHandler requestURL]):
CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager canonicalizeCacheURL:]):
CookieManager.subproj/IFCookie.m: (setDefaultsFromOriginURL):
Misc.subproj/IFNSStringExtensions.h:
Misc.subproj/IFNSStringExtensions.m:
Misc.subproj/IFNSURLExtensions.h:
Misc.subproj/IFNSURLExtensions.m: (CreateURLStringByAddingPercentEscapes): (+[NSURL _IF_URLWithString:]): (+[NSURL _IF_URLWithString:relativeToURL:]): (+[NSURL _IF_URLWithScheme:user:password:host:port:path:parameter:query:fragment:]):

12:58 PM Changeset in webkit [1409]

3 copies in tags/Alexander-9

This commit was manufactured by cvs2svn to create tag 'Alexander-9'.

12:58 PM Changeset in webkit [1408] by sheridan

8 edits in trunk

Alexander-9 version & ChangeLog tags

Jun 19, 2002:

5:09 PM Changeset in webkit [1407] by rjw

5 edits in trunk/WebCore

kwq/KWQScrollView.mm: (QScrollView::addChild):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

kwq/KWQWidget.mm: (QWidget::internalSetGeometry):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

2:28 PM Changeset in webkit [1406] by rjw

16 edits in trunk

khtml/khtmlview.cpp: (KHTMLView::~KHTMLView):

Tweak

khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

Call stopAnimations when a image changes, i.e. may be changed
by JS.

kwq/KWQPixmap.mm: (QPixmap::stopAnimations):

Call image renderer's stopAnimation.

kwq/qt/qpixmap.h: Added stopAnimations.

Break image renderer reference cycle. When a view is removed from the view
hierarchy active image renderers are told to stop animating,
which will, in turn, cause them to release their view. We leverage
the existing _stopPlugins mechanism.

WebCoreSupport.subproj/IFImageRenderer.h:
WebCoreSupport.subproj/IFImageRenderer.m: (+[IFImageRenderer stopAnimationsInView:]): (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): (-[IFImageRenderer frameView]): (-[IFImageRenderer stopAnimation]):
WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _stopPlugins]):

2:18 PM Changeset in webkit [1405] by sullivan

8 edits in trunk/WebKit

fixed 2960677 -- attempt to insert nil key; content policy set twice on particular page.

The problem here was a bad URL not being propogated through the error-handling machinery
correctly because the url handle was nil, but used to get its string.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]):
WebView.subproj/IFWebControllerPrivate.mm: Use IFError init method that takes failingURL.

(-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):
(-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
Check [error failingURL] when resource handle is nil.

fixed 2962304 -- No URL shown in Activity Window for certain error types

WebController.m: (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Get the URL's string from [error failingURL] when handle is nil. This obviates earlier workaround.

12:49 PM Changeset in webkit [1404] by darin

1 edit in trunk/WebCore/kwq/KWQWidget.mm

Oops.

12:46 PM Changeset in webkit [1403] by darin

22 edits
1 add in trunk

WebCore:

fixed 2956444 -- mac os x feedback form missing textarea

kwq/WebCoreFrameView.h: Added.

kwq/KWQWidget.mm: (QWidget::setCursor): Checked for cursor-setting call based on the WebCoreFrameView protocol instead of using an informal protocol. Also walk up the view chain so the cursor actually gets set. (QWidget::internalSetGeometry): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QScrollView.

kwq/KWQScrollView.mm: (-[NSView _KWQ_isScrollView]): Gave these KWQ names instead of IF names. (-[NSView _KWQ_getDocumentView]): Gave these KWQ names instead of IF names. (QScrollView::addChild): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QWidget.

Other changes:

kwq/kwqdebug.h: Cloned improved assert code from WebFoundation.

kwq/KWQTextArea.h: Removed unused isReadOnly/setReadOnly.
kwq/KWQTextArea.mm: Removed unused isReadOnly/setReadOnly.

kwq/WebCoreViewFactory.h: Removed extraneous import and WebCoreCursorSetting API from here.

kwq/KWQTextEdit.mm: Tweaked.
kwq/kparts/part.h: Tweaked.

WebKit:

Fixed a storage leak and made some other changes to go along with
corresponding WebCore changes.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient didStartLoadingWithURL:]): Added. (-[IFResourceURLHandleClient didStopLoading]): Added. (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Use didStartLoadingWithURL and didStopLoading to cure problems where the handle would be left in the data sources list of loading handles.

WebView.subproj/IFDynamicScrollBarsView.h: Changed to conform to the WebCoreFrameView protocol.

Misc.subproj/WebKitDebug.h: Cloned improved assert code from WebFoundation.

WebView.subproj/IFDynamicScrollBarsView.m: Fixed comment.

11:51 AM Changeset in webkit [1402] by cblu

4 edits in trunk/WebKit

WebKit:

Call setWindow in layout so that plug-in content is drawn without
needing to resize.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView layout]): (-[IFPluginView viewHasMoved:]):

WebBrowser:

Fix for 2956361 - use redirected name for downloaded files
Simplified mime parsing in Defaults.plist

Defaults.plist:
DownloadProgressEntry.m: (-[DownloadProgressEntry _initWithResource:progress:error:dataSource:]):
LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]):

7:37 AM Changeset in webkit [1401] by kocienda

7 edits in trunk

2002-06-19 Kenneth Kocienda <kocienda@apple.com>

I just played alchemical voodoo magic number games with the linker to
make all our frameworks and Alexander prebound.

Is voodoo our fate here? ....will B & I come to save us?
We poor humble groundlings yearn for the light of truth!

JavaScriptCore/ChangeLog
JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj: Now has -seg1addr 0x8000000
WebBrowser/ChangeLog
WebBrowser/WebBrowser.pbproj/project.pbxproj
WebFoundation/ChangeLog
WebFoundation/WebFoundation.pbproj/project.pbxproj: Now has -seg1addr 0x6000000
WebKit/ChangeLog
WebKit/WebKit.pbproj/project.pbxproj: Now has -seg1addr 0x7000000

Jun 18, 2002:

10:50 PM Changeset in webkit [1400] by cblu

8 edits in trunk/WebKit

WebKit:

Fix for 2961733 - Progress of plug-in files not shown in activity window
Plugin classed must call _IF_superviewWithName: not _IF_parentWebView

Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
Plugins.subproj/IFPluginStream.mm: minor cleanup (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): (-[IFPluginView layout]):

WebBrowser:

Renamed content policy API's to include the data source.

WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): (-[WebController receivedProgress:forResourceHandle:fromDataSource:]):

9:40 PM Changeset in webkit [1399] by cblu

32 edits in trunk/WebKit

WebBrowser:

Only have "View Source", "Save As" and "Print" menu items enabled
if currently at a web page and that web page is not loading.

Renamed content policy API's to include the data source.

BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]):
LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]):
WebBrowser.pbproj/project.pbxproj:

WebKit:

Enabled the viewing of plug-in content inline
(aka direct links to plugin media). Made IFPluginView a
IFDocumentView and IFPluginStream a IFDocumentRespresentation.

Renamed content policy API's to include the data source.

Plugins.subproj/IFPluginDatabase.h:
Plugins.subproj/IFPluginDatabase.m: (+[IFPluginDatabase installedPlugins]): registers plugins as IFDocument*
Plugins.subproj/IFPluginStream.h:
Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream init]): added for IFDocumentRepresentation (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): removed load initiliazatoin (-[IFPluginStream dealloc]): (-[IFPluginStream startLoad]): added (-[IFPluginStream stop]): (-[IFPluginStream receivedData:]): added as the base implementation (-[IFPluginStream receivedError]): added as the base implementation (-[IFPluginStream finishedLoadingWithData:]): added as the base implementation (-[IFPluginStream receivedData:withDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream receivedError:withDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream finishedLoadingWithDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): call receivedData (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): call finishedLoadingWithData (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): call receivedError (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): call receivedError (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
Plugins.subproj/IFPluginView.h:
Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]): removed special-case code for NP_FULL mose (-[IFPluginView start]): (-[IFPluginView initWithFrame:]): added for IFDocumentView (-[IFPluginView provisionalDataSourceChanged:]): added for IFDocumentView (-[IFPluginView provisionalDataSourceCommitted:]): added for IFDocumentView (-[IFPluginView dataSourceUpdated:]): added for IFDocumentView (-[IFPluginView layout]): added for IFDocumentView (-[IFPluginView removeFromSuperview]): call stop (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): (-[IFPluginView pluginInstance]): added
WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): call new init method (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]): call new init method
WebKit.pbproj/project.pbxproj:
WebView.subproj/IFLocationChangeHandler.h: content policy method name changes
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): content policy method name changes
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forDataSource:]): content policy method name changes
WebView.subproj/IFWebDataSourcePrivate.h:

1:49 PM Changeset in webkit [1398] by kocienda

14 edits in trunk

2002-06-18 Kenneth Kocienda <kocienda@apple.com>

Fix for this bug:

Radar 2928483 (activity viewer does not show all the pieces of a web page when the page is cached)

WebCore/khtml/misc/loader.cpp: (DocLoader::requestImage): Added APPLE_CHANGES call to the KWQCheckCacheObjectStatus function

described below

(DocLoader::requestStyleSheet): ditto
(DocLoader::requestScript): ditto

WebCore/kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): New function that informs WebKit of the

fact that a URL was loaded from the WebCore/khtml cache.

WebCore/kwq/KWQLoaderImpl.h: Added prototype for KWQCheckCacheObjectStatus
WebCore/kwq/WebCoreBridge.h: Added KWQCheckCacheObjectStatus to WebCoreBridge protocol

WebKit/WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge objectLoadedFromCache:size:]): New method that sends the appropriate progress indication.

9:28 AM Changeset in webkit [1397] by darin

5 edits in trunk/WebCore

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove an NSLog I left in by accident.

Jun 17, 2002:

7:35 PM Changeset in webkit [1396] by rjw

20 edits in trunk

Fixed window.open regression.
Partial fix to targeting frame of new name.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected):

Partial fix to frame not found problem.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

Fix for window.open regression.

kwq/WebCoreBridge.h: Changed return type of openNewWindowWithURL:

Fixed window.open regression.
Partial fix to targeting frame of new name.

WebCoreSupport.subproj/IFWebCoreBridge.h:
WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]):

Return the newly created bridge.

(-[IFWebCoreBridge receivedData:withDataSource:]):

Use setDataSource: method

(-[IFWebCoreBridge startLoadingResource:withURL:]):

No change.

(-[IFWebCoreBridge setDataSource:]):

New method.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]):

Selection support.

(-[IFHTMLView mouseDragged:]):

Selection support.

WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): Only change representation if it hasn't been pre-bound, or if it's class changed.

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]):

More hackery to support window.open.

WebController.m: (-[WebController openNewWindowWithURL:]):

Cleanup.

4:49 PM Changeset in webkit [1395] by darin

24 edits in trunk

Fixed many of the reasons that we were leaking the world. But we still leak
KHTMLPart objects, so there must be more problems.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]): Add missing autorelease. Without this, we leak the world. (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Weaken assert. It was firing before.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Don't retain the dataSource any more. Without this, we leak the world.

WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release the policy handler too. Without this, we leak the world.

WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Release resourceData, representation, downloadPath, encoding, and contentType. Without this, we leak the world.

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Release the dummy data source after setting it up so it doesn't leak.

WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLViewPrivate dealloc]): Don't release the controller, we didn't retain it. (-[IFHTMLView _resetWidget]): Delete the provisional widget too.

WebView.subproj/IFWebDataSourcePrivate.h: Remove unused "children" array.

WebCoreSupport.subproj/IFImageRenderer.m: Fix comment.
WebView.subproj/IFHTMLView.mm: Fix comments.

4:48 PM Changeset in webkit [1394] by darin

11 edits in trunk/WebCore

Fixed a storage leak.

kwq/WebCoreBridge.mm: (-[WebCoreBridge documentTextFromDOM]): Add a missing autorelease.

Remove a bunch of loader-related APPLE_CHANGES.

khtml/misc/loader.h: Remove KWQURLLoadClient and KWQLoaderImpl.
khtml/misc/loader.cpp: (Loader::Loader): Remove unneeded KWQLoaderImpl object. (Loader::~Loader): Remove unneeded KWQLoaderImpl object. (Loader::servePendingRequests): Call KWQServeRequest instead of KWQLoaderImpl::serveRequest. (Loader::slotFinished): Remove unneeded KWQLoaderImpl::objectFinished.

kwq/KWQLoaderImpl.h:
kwq/KWQKloader.mm: (KWQServeRequest): Replaces the KWQLoaderImpl class. The rest of what was in this class was obsolete.

3:45 PM Changeset in webkit [1393] by rjw

4 edits in trunk/WebKit

Fixed call to renamed progress method.

Plugins.subproj/IFPluginStream.mm:

1:29 PM Changeset in webkit [1392] by cblu

6 edits in trunk/WebKit

WebBrowser:

Implemented save as.

BrowserDocument.m: (-[BrowserDocument dataRepresentationOfType:]): return main data source's data

(-[BrowserDocument fileType]): added. Return [dataSource fileType]
(-[BrowserDocument _isDocumentHTML]): removed obsolete comments.

WebBrowser.pbproj/project.pbxproj:

WebKit:

WebView.subproj/IFWebDataSource.h:
WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource contentType]): no changes (-[IFWebDataSource fileType]): added. Returns extension based on MIME.

1:23 PM Changeset in webkit [1391] by rjw

19 edits in trunk

Fixed www.2cpu.com regression. QWidget::_displayRect was displaying the wrong
view. This was a regression that would impact all DHTML.

khtml/khtmlview.cpp: (KHTMLView::timerEvent):
kwq/KWQScrollView.mm: (QScrollView::updateContents):
kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::endEditing):
kwq/qt/qwidget.h:

Added explicit complete check for resources, rather
than depend on bytesSoFar == totalToLoad.

WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient receivedProgressWithHandle:complete:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):

12:47 PM Changeset in webkit [1390] by cblu

4 edits in trunk/WebKit

Fix for 2939881. No more overwritting of one's files.

Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler receivedData:]): (-[IFDownloadHandler finishedLoading]):

11:18 AM Changeset in webkit [1389] by rjw

11 edits in trunk/WebKit

Fixed IFImageViews not drawing correctly.

Changed compeletion to explicity use IFURLHandleResourceDidFinishLoading, rather
than depend on bytesSoFar == totalToLoad.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

11:12 AM Changeset in webkit [1388] by darin

4 edits in trunk/WebCore

Fixed bug where some images would get left behind when scrolling. Turned out it
was all the tiled images that were getting left behind.

kwq/KWQPainter.mm: (QPainter::drawTiledPixmap): Fixed to get the view for coordinates from [NSView focusView] the way drawPixmap does, rather than using data->widget->getView(), which gives the scroll view instead of the scrolled view.

Jun 16, 2002:

6:48 PM Changeset in webkit [1387] by darin

11 edits in trunk

WebCore:

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frames): Fixed this function to get from frames to parts properly. It was still assuming that [WebCoreBridge childFrames] would return a list of WebCoreBridge objects, but now it returns WebCoreFrame objects.

kwq/WebCoreFrame.h: Added [WebCoreFrame bridge] for the case above. Note that it always gives the "committed" bridge, not the provisional one.

WebKit:

WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Added.

10:27 AM Changeset in webkit [1386] by darin

26 edits
7 adds in trunk

WebCore:

Add a separate WebCoreFrame alongside WebCoreBridge to facilitate
handling of frames with no HTML content in them. This probably fixes
frames named "_blank".

Also fixed the build, because a clean build failed.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::submitForm): (KWQKHTMLPartImpl::parentPart): Work with WebCoreFrame objects instead of WebCoreBridge objects when dealing with frame operations -- loading new URLs mainly.

kwq/WebCoreBridge.h: Removed frame-related operations, now they are on WebCoreFrame. Broke out WebCoreResourceLoader into its own file. Added comments.

kwq/WebCoreFrame.h: Added.

kwq/WebCoreResourceLoader.h: Added.
kwq/KWQKloader.mm: Include WebCoreResourceLoader.h now that it's broken out.

WebCore-tests.exp: Tests still need QString::latin1(), although we don't need to export it for WebKit any more.

WebKit:

WebCoreSupport.subproj/IFResourceURLHandleClient.m:
WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge frame]): Added. (-[IFWebCoreBridge parent]): Changed name from parentFrame, to emphasize that this gives a WebCoreBridge. (-[IFWebCoreBridge childFrames]): Return IFWebCoreFrame objects. (-[IFWebCoreBridge childFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge descendantFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge createChildFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]): Use the loadURL operation in IFWebCoreFrame. (-[IFWebCoreBridge mainFrame]): Return IFWebCoreFrame object. (-[IFWebCoreBridge frameNamed:]): Return IFWebCoreFrame object.

WebCoreSupport.subproj/IFWebCoreFrame.h: Added.
WebCoreSupport.subproj/IFWebCoreFrame.m: Added.
WebKit.pbproj/project.pbxproj: Update for added files.

WebView.subproj/IFHTMLViewPrivate.h: Made this includable from plain Objective C.

WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Create the IFWebCoreFrame.

WebView.subproj/IFWebFramePrivate.h: Add _bridgeFrame method for getting IFWebCoreFrame.
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): Release the IFWebCoreFrame. (-[IFWebFrame _bridgeFrame]): Added.

12:46 AM Changeset in webkit [1385] by darin

3 edits in trunk/WebCore/kwq

Forgot to save file.

12:45 AM Changeset in webkit [1384] by darin

18 edits
6 adds in trunk

WebCore:

Moved the IFURLHandleClient subclass to WebKit, so it can some day be merged
with the one for the frames themselves; this one is for resources.

kwq/kio/jobclasses.h:
kwq/KWQKjobclasses.mm: (TransferJob::setHandle): Replaced the old TransferJob::begin with this.

kwq/KWQLoaderImpl.h: Remove setClient.
kwq/KWQKloader.mm: (-[WebCoreResourceLoader initWithLoader:job:]): Added. (-[WebCoreResourceLoader dealloc]): Added. (-[WebCoreResourceLoader addData:]): Added. (-[WebCoreResourceLoader cancel]): Added. (-[WebCoreResourceLoader finish]): Added. (KWQLoaderImpl::serveRequest): Use [WebCoreBridge startLoadingResource:withURL:].
khtml/misc/loader.cpp: (Loader::load): Removed unneeded call to setClient.

kwq/WebCoreBridge.h: Remove unneeded methods. Added [WebCoreBridge startLoadingResource:withURL:].

WebKit:

Moved the IFURLHandleClient subclass here from WebCore, so it can some day be merged
with the one for the frames themselves; this one is for resources.

WebCoreSupport.subproj/IFResourceURLHandleClient.h: Added.
WebCoreSupport.subproj/IFResourceURLHandleClient.m: Added.
WebKit.pbproj/project.pbxproj: Added IFResourceURLHandleClient.h and .m.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge startLoadingResource:withURL:]): Added. Removed all the old methods, with their guts moved into IFResourceURLHandleClient.

12:04 AM Changeset in webkit [1383] by darin

11 edits in trunk

WebCore:

Fix frame-related calls. I was always searching all the frames, which was disastrous.
Also do name changes.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected): Use descendantFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::requestFrame): Use childFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::frameExists): Use childFrameNamed rather than frameNamed.

kwq/KWQScrollView.mm: (QScrollView::addChild): Asserts I used while debugging.

kwq/WebCoreBridge.h: Add new calls. Change names of old ones to include the word frame consistently. (Also bits of new work that will do no harm, but are not really needed yet.)

WebKit:

Update for frame-related changes in WebCore.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): Look at provisional data source first. (-[IFWebCoreBridge dealloc]): Release the data source. (-[IFWebCoreBridge parentFrame]): Renamed. (-[IFWebCoreBridge childFrames]): Renamed. (-[IFWebCoreBridge childFrameNamed:]): Added. (-[IFWebCoreBridge descendantFrameNamed:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Don't call _didStopLoading twice when we finish loading.

Also changed controller getters to call [dataSource controller] and got rid of the
[IFWebCoreBridge controller] method.

Jun 15, 2002:

10:27 PM Changeset in webkit [1382] by rjw

22 edits in trunk/WebKit

Misc.subproj/IFNSViewExtras.h:
Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_superviewWithName:]): (-[NSView _IF_parentWebView]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Call _receiveProgress instead of directly calling handler.
Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]):

Handle changing top frame correctly. Parent may be nil.

(-[IFWebCoreBridge didFinishLoadingWithHandle:]):

Added non-terminal error case.

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceCommitted:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

WebView.subproj/IFMainURLHandleClient.mm:
WebView.subproj/IFWebControllerPrivate.mm: Comment changes.

9:12 PM Changeset in webkit [1381] by darin

6 edits in trunk/WebCore

kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): Rolled out an assert I added by accident that will break Deployment builds.

9:03 PM Changeset in webkit [1380] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFWebCoreBridge.mm: Added a lot of assertions that I had used while debugging. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Commented out the line of code that calls [serverRedirectTo:forDataSource:]. Our old code was sending this to the web controller (that was a bug). But if we send it to the location change handler, then we confuse Alexander. We may return to this later, uncomment it, and change the interface so the client can tell what is being redirected. We'll need to do that if we want the activity window to show redirected URLs at the time of the redirect.

8:27 PM Changeset in webkit [1379] by darin

6 edits in trunk/WebCore

kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Fixed the order so the URL handles are removed before we send notifications as before my change. This seems to fix the rest of the breakage.

7:31 PM Changeset in webkit [1378] by darin

6 edits in trunk/WebCore

kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Fix bridge/m_bridge typo that was responsible for at least some of the breakage I caused.

3:15 PM Changeset in webkit [1377] by rjw

12 edits in trunk

2002-06-15 Richard Williamson <rjw@apple.com>

Fixed factoring problem.

kwq/KWQScrollView.mm: (-[NSView _IF_getDocumentView]): (-[NSView _IF_isScrollView]): (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::resizeContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents):
kwq/qt/qscrollview.h:

Fixed _bridge not accounting for provisional data source,
broke access to window.frames during load.

WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): (-[IFWebCoreBridge children]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

2:44 PM Changeset in webkit [1376] by darin

4 edits in trunk/WebKit

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't turn negative numbers into 0 for margins. This was a mistake.

2:44 PM Changeset in webkit [1375] by darin

4 edits in trunk/WebCore

kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Implement the rule where a negative number means "don't set the margin".

2:34 PM Changeset in webkit [1374] by darin

109 edits
2 deletes in trunk/WebCore

kwq/kio/jobclasses.h: Removed import of WebFoundation.h.
kwq/KWQKjobclasses.mm: Added import of IFURLHandle.h.
kwq/KWQKloader.mm: Added import of IFError.h and IFURLHandle.h.

kwq/WCLoadProgress.h: Removed.
kwq/WCWebDataSource.h: Removed.
kwq/KWQKHTMLPart.mm: Removed import of WCWebDataSource.h.

*.mm: Changed all includes to imports using a perl script.

2:02 PM Changeset in webkit [1373] by darin

51 edits
1 delete in trunk

WebCore:

fixed 2942808 -- remove all calls to WebKit from WebCore

More work on the bridge. Now we don't call anything in WebKit explicitly,
although there are still implicit connections that need to be fixed.

WebCore.exp: Remove exports that are no longer needed, now that WebKit is using the bridge to get at more things.

khtml/misc/loader.h:
khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript): (CachedImage::CachedImage): Remove the extra parameter to the CachedObject constructor. We don't need it any more, so we can remove all these APPLE_CHANGES.

kwq/KWQKHTMLPart.mm: Remove getDataSource.

kwq/KWQLoaderImpl.h: Remove destructor.
kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Keep the bridge around instead of the data source. (-[KWQURLLoadClient dealloc]): Release the bridge instead of the data source. Also put another workaround for 2954901 here, like in WebKit. (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient doneWithHandle:error:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::setClient): (KWQLoaderImpl::serveRequest): Use the bridge to do all the heavy lifting, and put lots of common code into a doneWithHandle:error: method. Also store the URL so the redirect code works properly for multiple redirects and add asserts like the ones in IFMainURLHandleClient. (KWQLoaderImpl::objectFinished): Add a comment.

kwq/WebCoreBridge.h: Make header so it can be included from plain Objective C, not just Objective C++. Add a bunch of methods for bridging in to WebCore as opposed to out of WebCore. Add new methods for bridging out from WebCore too for all the progress hooks. Put all the subclass responsibility methods into a protocol in such a way that we don't need to implement them in the base class, and subclasses can set things up so they get errors if they forget to implement anything.

kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:]): Added. (-[WebCoreBridge addData:withEncoding:]): Added. (-[WebCoreBridge closeURL]): Added. (-[WebCoreBridge end]): Added. (-[WebCoreBridge setURL:]): Added. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Added. (-[WebCoreBridge documentTextFromDOM]): Added. (-[WebCoreBridge scrollToBaseAnchor]): Added.

kwq/external.h: Removed.

WebKit:

fixed 2942808 -- remove all calls to WebKit from WebCore

Update to use the WebCore bridge for more things, reducing
dependencies in both directions. Besides using the bridge for all the
remaining WebCore to WebKit calls, almost no WebKit code deals with
KHTMLPart directly any more, instead the other side of the bridge handles it.

Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Remove unneeded casts. (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Use the new IFProgress methods to simplify code.

WebCoreSupport.subproj/IFWebCoreBridge.h: Use the new WebCoreBridge protocol so we get a compiler error if we forget to implement anything. Add a method for IFWebDataSource that gets the WebCoreBridge if it has an IFHTMLRepresentation, and nil otherwise.
WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): Add; does checking so that it returns nil if the representation is not an IFHTMLRepresentation. This is now used almost everywhere so we don't have to do so much type casting. (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]): Remove a stray use of [IFWebCoreBridge dataSource] so we can remove it. (-[IFWebCoreBridge receivedData:withDataSource:]): Use the new [WebCoreBridge openURL:] and [WebCoreBridge addData:] methods from the other side of the bridge so we don't have to deal with the KHTMLPart directly. (-[IFWebCoreBridge addHandle:]): Added. (-[IFWebCoreBridge removeHandle:]): Added. (-[IFWebCoreBridge didStartLoadingWithHandle:]): Added. (-[IFWebCoreBridge receivedProgressWithHandle:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Added. (-[IFWebCoreBridge didCancelLoadingWithHandle:]): Added. (-[IFWebCoreBridge didFailBeforeLoadingWithError:]): Added. (-[IFWebCoreBridge didFailToLoadWithHandle:error:]): Added. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Added.

WebView.subproj/IFHTMLRepresentation.h: Remove unneeded declarations.
WebView.subproj/IFHTMLRepresentation.mm: Remove [IFHTMLRepresentation part].
WebView.subproj/IFHTMLRepresentationPrivate.h: Remove [IFHTMLRepresentation part].

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Use the bridge.

WebView.subproj/IFHTMLViewPrivate.mm: Remove a bunch of unused stuff that was there for the render and document tree viewers. I had removed it once before but it got re-added as a side effect of the reorganization process.

WebView.subproj/IFLoadProgress.h: Remove the unused IFLoadType -- we can add it back if we find that it's needed. It didn't do much good to have it here and only partly implemented, and I don't think it's needed. Added some convenient interfaces for creating IFLoadProgress objects.

WebView.subproj/IFLoadProgress.mm: Get rid of WCSetIFLoadProgressMakeFunc stuff. (-[IFLoadProgress init]): Added. (-[IFLoadProgress initWithBytesSoFar:totalToLoad:]): Remove type part. (-[IFLoadProgress initWithURLHandle:]): Added. (+[IFLoadProgress progress]): Added. (+[IFLoadProgress progressWithBytesSoFar:totalToLoad:]): Added. (+[IFLoadProgress progressWithURLHandle:]): Added.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): Add more workaround for 2954901. (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Remove unneeded type casts and simplify by using new IFLoadProgress methods. Also simplify access to _bridge by using [IFWebDataSource _bridge].

WebView.subproj/IFWebControllerPrivate.mm:
WebView.subproj/IFWebFrame.mm: Remove unneeded include of KHTMLPart header.

WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentTextFromDOM]):
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Use bridge.

1:04 PM Changeset in webkit [1372] by darin

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

WebFoundation.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now.

CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
CacheLoader.subproj/IFNetworkSettings.m:
CacheLoader.subproj/IFURLLoad.m:
CacheLoader.subproj/IFURLLoadManager.m:
CookieManager.subproj/IFCookieManager.m:
Database.subproj/IFURLFileDatabase.m:
Misc.subproj/IFError.m:
Misc.subproj/IFFileTypeMappings.m:
Misc.subproj/IFNSThreadExtensions.m: Use PTHREAD_ONCE_INIT now that the warning is fixed; also make some minor improvements to how it's used, making some globals static rather than extern.

12:59 PM Changeset in webkit [1371] by darin

7 edits in trunk/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now. Also, since this project is all C++, only use WARNING_CFLAGS with flags that are appropriate for C++; don't bother breaking out C vs. C++.

kjs/collector.cpp: Now that the system warning is fixed, use PTHREAD_MUTEX_INITIALIZER and PTHREAD_COND_INITIALIZER.
kjs/internal.cpp: Use PTHREAD_MUTEX_INITIALIZER.
kjs/ustring.cpp: Use PTHREAD_ONCE_INIT.

4:55 AM Changeset in webkit [1370] by mjs

4 edits in trunk/WebCore

Get current bits per pixel from CoreGraphics, thereby fixing

Radar 2943736 - JavaScript screen.colorDepth and

screen.pixelDepth properties always returns 32,

regardless of real depth

kwq/KWQPaintDeviceMetrics.mm: (QPaintDeviceMetrics::depth):

4:39 AM Changeset in webkit [1369] by mjs

7 edits in trunk

Made Development build mode mean what Unoptimized used to mean.

Removed Unoptimized build mode.

Added a Mixed build mode which does what Deployment used to. All

this to fix:

Radar 2955367 - Change default build style to "Unoptimized"

2:55 AM Changeset in webkit [1368] by mjs

5 edits in trunk/WebCore

Removed product and vendor properties, thereby fixing:

Radar 2943751 - JavaScript navigator.product property is

"Konqueror/khtml"

Radar 2943753 - JavaScript navigator.vendor property is "KDE"

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Return undefined for the above

mentioned properties.

Implemented functionality needed for missing Screen properties,

thereby fixing the following

bugs:

Radar 2943730 - JavaScript screen.availHeight property is not

implemented

Radar 2943732 - JavaScript screen.availLeft property is not

implemented

Radar 2943734 - JavaScript screen.availTop property not implemented
Radar 2943735 - JavaScript screen.availWidth property is not

implemented

kwq/KWQKWinModule.mm: (KWinModule::workArea): Return the correct screen size to fix the

above bugs.

2:42 AM Changeset in webkit [1367] by mjs

5 edits in trunk/WebKit

Added temporary workardound for Radar 2954901 by making the

assertion more lenient.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]):

Jun 14, 2002:

7:28 PM Changeset in webkit [1366] by rjw

11 edits in trunk/WebKit

i Removed redundant private _isDocumentHTML method.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
WebView.subproj/IFWebDataSourcePrivate.h:
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

7:12 PM Changeset in webkit [1365] by rjw

7 edits in trunk/WebCore

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
kwq/external.h:

7:12 PM Changeset in webkit [1364] by rjw

45 edits in trunk/WebKit

Added handlers to IFWebController. Should eventually be possible to use
IFWebController w/o subclassing.

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

Fixed many incorrect references to datasource reps.

Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):
WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): (-[IFWebCoreBridge createNewFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]):
WebView.subproj/IFDocument.h:
WebView.subproj/IFHTMLRepresentation.h:
WebView.subproj/IFHTMLRepresentationPrivate.h:
WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewWillStartLiveResize]): (-[IFHTMLView viewDidEndLiveResize]):
WebView.subproj/IFImageView.m:
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: (-[IFWebController createFrameNamed:for:inParent:allowsScrolling:]): (-[IFWebController setResourceProgressHandler:]): (-[IFWebController resourceProgressHandler]): (-[IFWebController setPolicyHandler:]): (-[IFWebController policyHandler]): (+[IFWebController defaultURLPolicyForURL:]):
WebView.subproj/IFWebControllerPrivate.h:
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
WebView.subproj/IFWebDataSource.h:
WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource representation]): (-[IFWebDataSource isDocumentHTML]): (-[IFWebDataSource documentTextFromDOM]):
WebView.subproj/IFWebDataSourcePrivate.h:
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): (-[IFWebDataSource _setRepresentation:]): (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _isDocumentHTML]):
WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

5:14 PM Changeset in webkit [1363] by darin

2 edits in trunk/WebKit

real, not read

5:13 PM Changeset in webkit [1362] by darin

5 edits
4 adds
2 deletes in trunk/WebKit

Panels.subproj/IFStandardPanels.m: Use the read PTHREAD_ONCE_INIT, remove the workaround for 2905545.

IFWebCoreBridge.h: Moved into WebCoreSupport.subproj.
IFWebCoreBridge.mm: Moved into WebCoreSupport.subproj.
WebCoreSupport.subproj/IFWebCoreBridge.h: Moved from top level.
WebCoreSupport.subproj/IFWebCoreBridge.mm: Moved from top level.

WebKit.pbproj/project.pbxproj: Update for new file locations. Also pass -no-c++filt so we get mangled names (more useful for .exp files), and remove PFE_FILE_C_DIALECTS.

5:12 PM Changeset in webkit [1361] by cblu

15 edits in trunk/WebKit

WebBrowser:

Only allow source to be shown if HTML

BrowserDocument.m: (-[BrowserDocument _isDocumentHTML]): added (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument viewSource:]):

WebKit:

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): If content type is the default type and there is no extension, assume HTML.

(-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):

WebView.subproj/IFWebDataSource.h:
WebView.subproj/IFWebDataSource.mm:

Made isDocumentHTML public. Changed where needed.

(-[IFWebDataSource isDocumentHTML]):
(-[IFWebDataSource documentSource]):
(-[IFWebDataSource documentTextFromDOM]):

WebView.subproj/IFWebDataSourcePrivate.h:
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

4:45 PM Changeset in webkit [1360] by darin

4 edits in trunk/WebKit

Panels.subproj/IFStandardPanels.m: Fix what I broke last time.

4:32 PM Changeset in webkit [1359] by darin

8 edits in trunk/WebKit

Panels.subproj/IFStandardPanels.m: (-[IFStandardPanelsPrivate frontmostWindowLoadingURL:]): Change to call webView instead of view. Not sure why anyone was able to compile this.

Plugins.subproj/IFNullPluginView.mm: Remove include of obsolete WCPluginWidget.h.

WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation part]): Call part instead of KHTMLPart. Not sure why anyone was able to compile this.

4:31 PM Changeset in webkit [1358] by darin

4 edits in trunk/WebCore

kwq/KWQDateTime.mm: Add ifdefs needed to make Deployment build compile.

4:15 PM Changeset in webkit [1357] by darin

67 edits
6 adds
2 deletes in trunk

WebCore:

Add the new bridge class that connects us to WebCore in a nicer way.
Started to use it for some things. More to come.

WebKit.pbproj/project.pbxproj:
IFWebCoreBridge.h: Added.
IFWebCoreBridge.mm: Added.

Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler initWithDataSource:]): Call [super init]. (-[IFDownloadHandler dealloc]): Call [super dealloc].
Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]): Call [super init]. (-[IFPluginNullEventSender dealloc]): Call [super dealloc].
WebView.subproj/IFDOMNode.mm: (-[IFDOMNode dealloc]): Call [super dealloc].
WebView.subproj/IFImageView.m: (-[IFImageView dealloc]): Call [super dealloc].
WebView.subproj/IFRenderNode.mm: (-[IFRenderNode dealloc]): Call [super dealloc].

WebView.subproj/IFHTMLRepresentation.h: Moved variables into a private structure so this class can be made public.
WebView.subproj/IFHTMLRepresentationPrivate.h: Added. Has _bridge method.
WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation init]): Call [super init]. Also use the new private structure, and allocate the IFWebCoreBridge. (-[IFHTMLRepresentation dealloc]): Release the private structure and the IFWebCoreBridge. Also, call [super dealloc]. (-[IFHTMLRepresentation _bridge]): Private method to get to the bridge. (-[IFHTMLRepresentation receivedData:withDataSource:]): Use IFWebCoreBridge.

WebView.subproj/IFWebViewPrivate.h: Add _setMarginWidth and _setMarginHeight.

WebView.subproj/IFWebDataSourcePrivate.h: Tweak.
WebView.subproj/IFWebDataSource.mm: Tweak.
History.subproj/IFWebHistoryPrivate.m: Tweak.

WebKit:

Worked on eliminating calls to WebKit. About 3/4 done.

WebCore.exp: Export new WebCoreBridge class, fewer other things.

WebCorePrefix.h: #include <ostream> in debug builds; we couldn't before because of a PFE bug that has since been fixed (2920556).

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Add a comment explaining our latest change here.

khtml/khtml_part.cpp: (KHTMLPart::~KHTMLPart): Fix storage leak by deleting m_hostExtension.

khtml/misc/loader.h: Set type properly on client member so we don't have to do so much casting.

kwq/KWQKHTMLPartImpl.h: Add getBridge and setBridge, remove setDataSource.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Eliminate m_dataSource. (KWQKHTMLPartImpl::openURLInFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::urlSelected): Use WebCoreBridge. (KWQKHTMLPartImpl::requestFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::requestObject): Move WebCoreViewFactory code here; we don't need an entire WCPluginWidget file just for this function. (KWQKHTMLPartImpl::submitForm): Use WebCoreBridge. (KWQKHTMLPartImpl::frameExists): Use WebCoreBridge. (KWQKHTMLPartImpl::frames): Use WebCoreBridge. (KWQKHTMLPartImpl::setTitle): Use WebCoreBridge. (KWQKHTMLPartImpl::getDataSource): Use WebCoreBridge. (KWQKHTMLPartImpl::parentPart): Use WebCoreBridge.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Use WebCoreBridge.

kwq/KWQKloader.mm: Move the part of external.h that we still use in here, with the expectation of eliminating it soon. Also renamed URLLoadClient to KWQURLLoadClient so we don't hog namespace.

kwq/qt/qscrollview.h:
kwq/KWQScrollView.mm: Used helper functions to do the "documentView" selector thing more consistently.

kwq/KWQWidget.mm: Get interface for changing the cursor from WebCoreViewFactory.h instead of from external.h.

kwq/WebCoreViewFactory.h:
kwq/Makefile.am: Remove WCPluginWidget.mm, add WebCoreBridge.mm.
kwq/WCPluginWidget.h: Removed.
kwq/WCPluginWidget.mm: Removed.
kwq/WebCoreBridge.h: Added.
kwq/WebCoreBridge.mm: Added.

kwq/qt/qarray.h: Use <ostream> instead of <iostream>.
kwq/qt/qcstring.h: Remove <iostream> include since we include <qarray.h>.
kwq/qt/qdatetime.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.
kwq/qt/qlist.h: Use <ostream> instead of <iostream>.
kwq/qt/qmap.h: Use <ostream> instead of <iostream>.
kwq/qt/qpoint.h: Use <iosfwd> instead of <iostream>.
kwq/qt/qsize.h: Use <iosfwd> instead of <iostream>.
kwq/qt/qvaluelist.h: Use <ostream> instead of <iostream>.
kwq/qt/qvector.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.

3:26 PM Changeset in webkit [1356] by rjw

32 edits in trunk

Lots of frame related cleanup. Added attempt to get
nested scrollbars to work correctly with window's resize
corner. Still not quite right.

Name change [IFWebFrame view] -> [IFWebFrame webView].

WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):
WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewDidEndLiveResize]):
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate _clearControllerReferences:]):
WebView.subproj/IFWebFrame.h:
WebView.subproj/IFWebFrame.mm: (-[IFWebFrame init]): (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): (-[IFWebFrame setWebView:]): (-[IFWebFrame webView]): (-[IFWebFrame setProvisionalDataSource:]): (-[IFWebFrame reset]):
WebView.subproj/IFWebFramePrivate.h:
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): (-[IFWebFramePrivate setWebView:]): (-[IFWebFrame _timedLayout:]): (-[IFWebFrame _transitionProvisionalToCommitted]): (-[IFWebFrame _setState:]): (-[IFWebFrame _isLoadComplete]):

Name change [IFWebFrame view] -> [IFWebFrame webView].

BrowserDocument.m: (-[BrowserDocument mainWebView]): (-[BrowserDocument setMainWebView:]):
BrowserWindow.m: (-[BrowserWindow frameLoadStarted:]): (-[BrowserWindow frameLoadCommitted:]): (-[BrowserWindow frameLoadRedirected:]):
LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _scrollToTop]): (-[LocationChangeHandler _restoreScrollPosition]):

Name change view -> webView.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
kwq/external.h:

1:54 PM Changeset in webkit [1355] by cblu

4 edits in trunk/WebCore

Put #ifndef APPLE_CHANGES around one line that
was causing EMBED and OBJECT tags to not have render objects.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach):

12:58 PM Changeset in webkit [1354] by rjw

8 edits in trunk/WebKit

WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]):

Added notification so we can intelligently add/remove
mouse move observation when the window becomes/resigns
main. Also added window close observation so we can
clean up other observers.

(-[IFHTMLView viewWillStartLiveResize]):\

Backed out removal of scroll bars during resize.

(-[IFHTMLView viewDidEndLiveResize]):

Backed out removal of scroll bars during resize.

(-[IFHTMLView windowWillClose:]):
Clean up observers.
(-[IFHTMLView windowDidBecomeMain:]):
Add mouse move observer.
(-[IFHTMLView windowDidResignMain:]):
Remove mouse move observer.
(-[IFHTMLView mouseMovedNotification:]):

Only pay attention to mouse moves for this window.

WebView.subproj/IFImageView.m: (-[IFImageView layout]):

Removed unnecessary scroll view setDrawBackground calls.

WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Added calls to scroll view setDrawBackground when the view
rect is valid.

11:22 AM Changeset in webkit [1353] by cblu

64 edits in trunk

Enabled displaying of text, images and RTF
Fixed drag & drop
Committing Richard's changes to KWQPainter
Upated types that Alex can open.
Uncommented textFromDOM call.

Jun 13, 2002:

3:46 PM Changeset in webkit [1352]

5 copies
2 deletes in tags/JavaScriptCore-5_1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-5_1'.

3:46 PM Changeset in webkit [1351] by mjs

3 edits in branches/jaguar-branch/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Remove C++ warning flags that are making JavaScriptCore die in the B & I build.

3:24 PM Changeset in webkit [1350]

5 copies
2 deletes in tags/JavaScriptCore-5~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-5~1'.

3:24 PM Changeset in webkit [1349] by mjs

4 edits in branches/jaguar-branch/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Remove C++ warning flags that a

making JavaScriptCore die in the B & I build.

12:31 PM Changeset in webkit [1348] by sullivan

11 edits
4 adds in trunk/WebKit

Various changes to better support the pasteboard.

Bookmarks.subproj/IFBookmark.h,
Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkOfType:]): New method.

Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf init]): start out with a non-nil _entry (-[IFBookmarkLeaf setTitle:]): added assert (-[IFBookmarkLeaf setURLString:]): added assert

History.subproj/IFURLsWithTitles.h,
History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles arrayWithIFURLsWithTitlesPboardType]), (+[IFURLsWithTitles writeURLs:andTitles:toPasteboard:]), (+[IFURLsWithTitles titlesFromPasteboard:]), (+[IFURLsWithTitles URLsFromPasteboard:]): New file with methods for reading/writing pasteboard entry representing a list of URLs with associated titles. Used by Bookmarks window and History window in Alexander.

History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntryForURLString:]): refactored to turn a WEBKITDEBUG into a more-appropriate WEBKIT_ASSERT.

WebKit.pbproj/project.pbxproj: Updated for new files.

Many changes for copy/paste & dragging support, and random little tweaks.

fixed 2927606 -- Should be able to drag items from History window to Bookmarks

BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Added IFURLsWithTitlesPboardType and NSURLPboardType.

(-[BookmarksController _selectedBookmarks]): Renamed from
_selectedBookmarksWithoutRedundantDescendants, and removed the descendant-filtering
code from here (used by some callers instead).
(-[BookmarksController removeSelectedBookmarks:]): Filter results of _selectedBookmarks.
(-[BookmarksController outlineView:writeItems:toPasteboard:]): Added support for writing
BookmarkDictionaryListPboardType, IFURLsWithTitlesPboardType, NSURLPboardType, and
NSStringPboardType.
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
Split code that sets the drag operation from code that retargets the drop; added support
for NSURLPboardType and IFURLsWithTitlesPboardType.
(+[BookmarksController _addBookmarksFromURLsWithTitlesOnPasteboard:to:]):
New convenience routine.
(-[BookmarksController paste:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Add support for
NSURLPboardType and IFURLsWithTitlesPboardType.
(-[BookmarksController copy:]): Just calls outlineView:writeItems:toPasteboard: now
instead of duplicating code.
(-[BookmarksController validateMenuItem:]),
(-[BookmarksController validateUserInterfaceItem:]): Removed all code that modified titles
of Cut/Copy/Paste/Clear items after realizing that this can't work with the Cocoa
responder chain model (no guarantee that the modified titles will be unmodified in other
contexts).

BrowserWindow.m: (-[BrowserWindow windowWillHandleKeyEvent:]): Returns NO always now; this means that BrowserWindow will no longer try to handle Page Up/Down, arrow keys, etc. We can remove this method entirely (and some other stuff) when 2955757 is addressed.

GlobalHistory.m: (-[GlobalHistory _entriesFromMixedItems:collapseDates:]): New convenience method that returns an array of history entries from an array containing a potential mix of history entries and calendar dates. (-[GlobalHistory outlineView:writeItems:toPasteboard:]): New method, writes these types to pasteboard: IFURLsWithTitlesPboardType, NSURLPboardType, NSStringPboardType (-[GlobalHistory _selectedItems]), (-[GlobalHistory removeSelectedItems:]): Broke _selectedItems out of removeSelectedItems. (-[GlobalHistory copy:]): New method, calls outlineView:writeItems:toPasteboard: with the selected items. (-[GlobalHistory validateUserInterfaceItem:]): Enable "Copy" if at least one item is selected.

LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Swapped NSURLPboardType and NSStringPboardType so that NSURLPboardType is preferred. (-[LocationFieldEditor concludeDragOperation:]): Use #defines for pasteboard types instead of strings; fix broken use of NSURLPboardType.

ResourceProgressEntry.m: (-[ResourceProgressEntry setProgress:]): Improved an error message.

9:12 AM Changeset in webkit [1347] by kocienda

2 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <kocienda@apple.com>

Fixed typo in ChangeLog comment.

9:00 AM Changeset in webkit [1346] by kocienda

5 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <kocienda@apple.com>

Fixed uninitialized varible that broke the build.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])

3:53 AM Changeset in webkit [1345] by rjw

4 edits in trunk/WebCore

More cleanup to deal with special case of provisional view
not being in a scrollview.

3:32 AM Changeset in webkit [1344] by rjw

6 edits in trunk/WebCore

kwq/KWQWidget.mm: (QWidget::setCursor): restored code
kwq/external.h: removed definitions no longer needed
khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): tweaked size

3:31 AM Changeset in webkit [1343] by rjw

23 edits in trunk/WebKit

Lots of cleanup. Fixed most regressions.
Added removal of scrollbars during resizing,
not sure if it's the correct behavior, but it makes resizing
much smoother. Let's see what people think.

1:22 AM Changeset in webkit [1342] by cblu

3 edits
4 adds
1 delete in trunk/WebKit

Removed MIME.subproj. Moved IFDownloadHandler to Misc.

MIME.subproj/IFDownloadHandler.h: Removed.
MIME.subproj/IFDownloadHandler.mm: Removed.
Misc.subproj/IFDownloadHandler.h: Added.
Misc.subproj/IFDownloadHandler.mm: Added. (-[IFDownloadHandler initWithDataSource:]): (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): (-[IFDownloadHandler cancel]):
WebKit.pbproj/project.pbxproj:

1:13 AM Changeset in webkit [1341] by cblu

11 edits
6 deletes in trunk/WebKit

Fixed downloads.
Now write out download files as data comes in.
Removed useless lproj's.

Dutch.lproj/InfoPlist.strings: Removed.
Dutch.lproj/Localizable.strings: Removed.
French.lproj/InfoPlist.strings: Removed.
French.lproj/Localizable.strings: Removed.
German.lproj/InfoPlist.strings: Removed.
German.lproj/Localizable.strings: Removed.
Italian.lproj/InfoPlist.strings: Removed.
Italian.lproj/Localizable.strings: Removed.
Japanese.lproj/InfoPlist.strings: Removed.
Japanese.lproj/Localizable.strings: Removed.
MIME.subproj/IFDownloadHandler.h:
MIME.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): added (-[IFDownloadHandler cancel]): added
Spanish.lproj/InfoPlist.strings: Removed.
Spanish.lproj/Localizable.strings: Removed.
WebKit.pbproj/project.pbxproj:
WebView.subproj/IFMainURLHandleClient.h:
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:]): removed unused BOOL (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Jun 12, 2002:

8:33 PM Changeset in webkit [1340] by cblu

75 edits
34 adds
4 deletes in trunk

Couldn't run ChangeLog because it hung with the massize diffs, so here's
a hand-made one.

Changes to support inline views.

Modified Files:

WebBrowser/BrowserDocument.m
WebBrowser/LocationChangeHandler.m
WebBrowser/Debug/DebugUtilities.m WebCore/WebCore.exp
WebCore/kwq/KWQKHTMLPart.mm
WebCore/kwq/KWQKHTMLPartBrowserExtension.mm
WebCore/kwq/KWQKloader.mm WebCore/kwq/KWQScrollView.mm
WebCore/kwq/KWQView.h WebCore/kwq/KWQView.mm
WebCore/kwq/KWQWidget.mm WebCore/kwq/external.h
WebKit/ChangeLog WebKit/Plugins.subproj/IFNullPluginView.mm
WebKit/Plugins.subproj/IFPluginDatabase.h
WebKit/Plugins.subproj/IFPluginDatabase.m
WebKit/Plugins.subproj/IFPluginView.mm
WebKit/WebCoreSupport.subproj/IFImageRenderer.h

WebKit/WebCoreSupport.subproj/IFWebCoreViewFactory.m

WebKit/WebKit.pbproj/project.pbxproj
WebKit/WebView.subproj/IFDOMNode.mm
WebKit/WebView.subproj/IFDynamicScrollBarsView.m
WebKit/WebView.subproj/IFMainURLHandleClient.h
WebKit/WebView.subproj/IFMainURLHandleClient.mm
WebKit/WebView.subproj/IFRenderNode.mm
WebKit/WebView.subproj/IFWebController.h
WebKit/WebView.subproj/IFWebController.mm
WebKit/WebView.subproj/IFWebControllerPrivate.h
WebKit/WebView.subproj/IFWebControllerPrivate.mm
WebKit/WebView.subproj/IFWebDataSource.h
WebKit/WebView.subproj/IFWebDataSource.mm
WebKit/WebView.subproj/IFWebDataSourcePrivate.h
WebKit/WebView.subproj/IFWebDataSourcePrivate.mm
WebKit/WebView.subproj/IFWebFrame.mm
WebKit/WebView.subproj/IFWebFramePrivate.h
WebKit/WebView.subproj/IFWebFramePrivate.mm
WebKit/WebView.subproj/IFWebView.h
WebKit/WebView.subproj/IFWebView.mm
WebKit/WebView.subproj/IFWebViewPrivate.h
WebKit/WebView.subproj/IFWebViewPrivate.mm

Added Files:

WebKit/Misc.subproj/IFNSViewExtras.h
WebKit/Misc.subproj/IFNSViewExtras.m
WebKit/WebView.subproj/IFDocument.h
WebKit/WebView.subproj/IFHTMLRepresentation.h
WebKit/WebView.subproj/IFHTMLRepresentation.mm
WebKit/WebView.subproj/IFHTMLView.h
WebKit/WebView.subproj/IFHTMLView.mm
WebKit/WebView.subproj/IFHTMLViewPrivate.h
WebKit/WebView.subproj/IFHTMLViewPrivate.mm
WebKit/WebView.subproj/IFImageRepresentation.h
WebKit/WebView.subproj/IFImageRepresentation.m
WebKit/WebView.subproj/IFImageView.h
WebKit/WebView.subproj/IFImageView.m
WebKit/WebView.subproj/IFTextRepresentation.h
WebKit/WebView.subproj/IFTextRepresentation.m
WebKit/WebView.subproj/IFTextView.h
WebKit/WebView.subproj/IFTextView.m

Removed Files:

WebKit/MIME.subproj/IFContentHandler.h
WebKit/MIME.subproj/IFContentHandler.m

WebKit/MIME.subproj/IFMIMEHandler.h

WebKit/MIME.subproj/IFMIMEHandler.m

3:09 PM Changeset in webkit [1339] by kocienda

7 edits in trunk

2002-06-12 Kenneth Kocienda <kocienda@apple.com>

Made assertion failure console message bolder and easier to see.

WebFoundation/Misc.subproj/WebFoundationDebug.h
WebKit/Misc.subproj/WebKitDebug.h
WebCore/kwq/kwqdebug.h

9:26 AM Changeset in webkit [1338] by darin

4 edits in trunk/JavaScriptCore

kjs/nodes.cpp: (Node::finalCheck): A bit of APPLE_CHANGES so we can compile with KJS_DEBUG_MEM defined if we want to.

Jun 11, 2002:

4:52 PM Changeset in webkit [1337] by darin

7 edits in trunk/WebKit

WebView.subproj/IFMainURLHandleClient.mm: Add lots of assertions that allowed me to find the "leak the world" bug that Ken fixed in WebFoundation. These are a good idea anyway.

Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): Use cStringLength to get the length for the cString rather than assuming that length will be right. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Add a FIXME.

4:51 PM Changeset in webkit [1336] by darin

3 edits in trunk/WebCore

Change log should have said: Remove the workaround for CFURL bug 2891336.

4:48 PM Changeset in webkit [1335] by darin

4 edits in trunk/WebCore

kwq/KWQKURL.mm: (RelativeURLKeyRetainCallBack): Use a ref count. (RelativeURLKeyReleaseCallBack): Use a ref count instead of assuming there will never be more than one reference. (KURL::normalizeRelativeURLString): Use a ref count. (operator==): Don't put URLs on the autorelease pool just to compare them.

2:16 PM Changeset in webkit [1334] by sullivan

16 edits in trunk/WebKit

Made methods that convert bookmarks to and from
property-list-compatible dictionaries public so they
can be used in the Bookmarks window for cut/paste.

Bookmarks.subproj/IFBookmark.h:
Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): New method

(-[IFBookmark initFromDictionaryRepresentation:withGroup:]):
(-[IFBookmark dictionaryRepresentation]):

Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _loadBookmarkGroupGuts]): (-[IFBookmarkGroup _saveBookmarkGroupGuts]):
Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf dictionaryRepresentation]):
Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList dictionaryRepresentation]):
Bookmarks.subproj/IFBookmarkSeparator.m: (-[IFBookmarkSeparator initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkSeparator dictionaryRepresentation]):
Bookmarks.subproj/IFBookmark_Private.h: Removed leading underscores from _initFromDictionaryRepresentation and _dictionaryRepresentation, and made them public.

-fixed 2921580 -- Need Cut/Copy/Paste support in Bookmarks window
-fixed 2952869 -- Alexander offers to undo Bookmark address change
when nothing changed
-made Activity, Bookmarks, and History window set the initial first
responder to their outline views, so Select All and keyboard navigation
work without requiring an initial click.
-eliminated unsightly gray line above outline views in Activity, Bookmarks,
and History windows

ActivityViewer.m: (-[ActivityViewer _setUpWindow]): Make outline view be first responder.

BookmarksController.h: Add ivars for _droppablePasteboardTypes and _pasteablePasteboardTypes; maybe these will be the same eventually.

BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Return array of the types we handle, lazily creating the array if necessary. (-[BookmarksController windowDidLoad]): Use _droppablePasteboardTypes; make outline view be first responder. (-[BookmarksController dealloc]): release new ivars (-[BookmarksController _selectedBookmarksWithoutRedundantDescendants]), (-[BookmarksController removeSelectedBookmarks:]): Extracted _selectedBookmarks... from removeSelectedBookmarks. (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): Fixed copy/paste error that was the cause of 2952869 (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Call [NSPasteboard availableTypeFromArray:] instead of making dangerous assumptions. (-[BookmarksController _setSelectionToBookmarks:]), (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): extracted _setSelectionToBookmarks: into its own function, and used availableTypeFromArray:

(-[BookmarksController copy:]),
(-[BookmarksController paste:]),
(-[BookmarksController clear:]),
(-[BookmarksController cut:]): New methods; the last three are Undoable

(-[BookmarksController _numberOfBookmarksOnPasteboard:]): New helper method used
to set title of Paste menu item.

(-[BookmarksController validateMenuItem:]): New method, used for items whose titles
change (i.e. Cut/Copy/Paste/Clear)
(-[BookmarksController validateUserInterfaceItem:]): No change, just moved.

English.lproj/ActivityViewer.nib,
English.lproj/Bookmarks.nib,
English.lproj/History.nib: Made outline views one pixel taller to avoid unsightly gray line at top.

GlobalHistory.h:
GlobalHistory.m: (-[selectAll:]): Removed unnecessary method. (-[GlobalHistory validateUserInterfaceItem:]): Removed validation for selectAll; let outline view handle it. (-[GlobalHistory showWindow:]): Make outline view be first responder.

1:50 PM Changeset in webkit [1333] by darin

5 edits
10 adds in trunk/WebKit

WebKit:

WebView.subproj/IFDOMNode.h: Added.
WebView.subproj/IFDOMNode.mm: Added.
WebView.subproj/IFRenderNode.h: Added.
WebView.subproj/IFRenderNode.mm: Added. These contain all the interesting bits of the code for the render and DOM tree viewers, mostly moved here from WebBrowser.

WebView.subproj/IFWebViewPrivate.mm: Remove the methods in here that aren't declared in the header and are only used for the render and DOM tree viewers.

WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

Removed all C and Objective C++, making this all Objective C again, which
helps make build times faster.

_CFA2UC.c: Removed.

WebBrowserPrefix.h: Removed code to handle non-Objective C, and also removed <config.h>.

Debug/DOMTree.m: Renamed from DOMTree.mm. Also changed to use IFDOMNode from WebKit for all the interesting bits.
Debug/DOMTree.mm: Renamed to DOMTree.m.
Debug/DOMTree.h: Put dataSource in object as a step toward making this not leak some day.

Debug/RenderTree.m: Renamed from RenderTree.mm. Also changed to use IFRenderNode from WebKit for all the interesting bits.
Debug/RenderTree.mm: Renamed to RenderTree.m.
Debug/RenderTree.h: Put dataSource in object as a step toward making this not leak some day.

WebBrowser.pbproj/project.pbxproj: Change files around. Add warnings that weren't allowed in C++; this project is now all Objective C. Remove C and Objective C++ from PFE dialects list. Remove header search paths.

main.m: Use "../config.h" to get at config.h. In the long run, we can just get rid of this.

Debug/DebugUtilities.m: Unimportant tweaks.

Jun 10, 2002:

5:05 PM Changeset in webkit [1332] by darin

5 edits
1 add in trunk/WebKit

Makefile.am: Do a clean before building if the force-clean-timestamp file is newer than the previous-clean-timestamp. Edit force-clean-timestamp (doesn't matter what you change as long as you change it) to force a clean build in WebKit.
force-clean-timestamp: Added.
.cvsignore: Ignore previous-clean-timestamp.

3:18 PM Changeset in webkit [1331] by darin

6 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.h: Remove the flavor of floatWidthForCharacters without the applyRounding boolean.

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Remove logic about characters in the 0x7F-0xA0 range, since it's already handled by the time we get around to drawing. (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): Pass in the applyRounding boolean when calling through to slowFloatWidthForCharacters. Move logic about characters in the 0x7F-0xA0 range from here into [extendCharacterToGlyphMapToInclude:]. (-[IFTextRenderer widthForCharacters:length:]): Call the version of floatWidthForCharacters that takes the applyRounding parameter; this was the only client of the flavor that didn't take the parameter. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Add the logic about characters in the 0x7F-0xA0 range into here.

1:45 PM Changeset in webkit [1330] by darin

4 edits in trunk/WebCore

khtml/css/cssstyleselector.cpp: Fix uninitialized variable warning.

1:09 PM Changeset in webkit [1329] by rjw

8 edits in trunk/WebKit

i Tweaks to new rounding code.

Added Cocoa-exact width measurement emulation flag to support IFStringTruncator.

Remove code that was already conditionally excluded calls to support
non-specified advance drawing (we now depend on tweaked advances).

Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
WebCoreSupport.subproj/IFTextRenderer.h:
WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer initWithFont:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:length:]): (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]):

1:08 PM Changeset in webkit [1328]

1 copy
112 deletes in branches/unlabeled-1.4.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.56'.

1:08 PM Changeset in webkit [1327]

1 copy
111 deletes in branches/unlabeled-1.3.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.56'.

1:08 PM Changeset in webkit [1326] by darin

141 edits
1 add in trunk

JavaScriptCore:

Merged in changes from KDE 3.0.1.

kjs/collector.cpp:
kjs/date_object.cpp:
kjs/function.cpp:
kjs/internal.cpp:
kjs/lookup.h:
kjs/object.cpp:
kjs/operations.cpp:
kjs/regexp.cpp:
kjs/regexp_object.cpp:
kjs/regexp_object.h:
kjs/string_object.cpp:
kjs/testkjs.cpp:
kjs/ustring.cpp:
kjs/value.cpp:
kjs/value.h: Do the merge, and add APPLE_CHANGES as needed to make things compile.

kjs/date_object.lut.h: Re-generated.

WebCore:

Merged in changes from KDE 3.0.1.

kwq/kdecore/kurl.h:
kwq/KWQKURL.mm: (operator==): New, needed by some 3.0.1 code.

kwq/qt/qpalette.h: Add QPalette::NColorGroups and QColorGroup::NColorRoles.
kwq/KWQPalette.mm: Simplify by getting rid of "private" indirection. (QPalette::color): New, needed by some 3.0.1 code.
kwq/KWQColorGroup.mm: Simplify by getting rid of "private" indirection.

kwq/qt/qstring.h:
kwq/KWQString.mm: (QConstString::QConstString): Change parameter to const QChar * to match Qt so we compile.

kwq/qt/qtextedit.h:
kwq/KWQTextEdit.mm: (QTextEdit::setTabStopWidth): Add unimplemented placeholder, needed by some 3.0.1 code.

kwq/qt/qvaluelist.h:
kwq/KWQValueListImpl.h:
kwq/KWQValueListImpl.mm: Simplify implementation.

WebCore-tests.exp: Update for changes in QValueList implementation.

kwq/kdecore/klibloader.h: Add include of <kio/global.h> to make something compile.

kwq/khtml/java/kjavaappletcontext.h: Add JType and constructor that takes DCOPObject*.

kwq/kio/global.h: Add KIO::CacheControl.

khtml/css/css_ruleimpl.cpp:
khtml/css/css_ruleimpl.h:
khtml/css/css_stylesheetimpl.cpp:
khtml/css/css_stylesheetimpl.h:
khtml/css/css_valueimpl.cpp:
khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp:
khtml/css/cssparser.h:
khtml/css/cssstyleselector.cpp:
khtml/css/cssstyleselector.h:
khtml/css/html4.css:
khtml/dom/css_rule.cpp:
khtml/dom/css_rule.h:
khtml/dom/css_stylesheet.cpp:
khtml/dom/css_stylesheet.h:
khtml/dom/css_value.cpp:
khtml/dom/dom2_events.cpp:
khtml/dom/dom2_range.cpp:
khtml/dom/dom2_range.h:
khtml/dom/dom2_views.cpp:
khtml/dom/dom_doc.cpp:
khtml/dom/dom_element.cpp:
khtml/dom/dom_exception.h:
khtml/dom/dom_node.cpp:
khtml/dom/dom_string.cpp:
khtml/dom/dom_text.cpp:
khtml/dom/dom_xml.cpp:
khtml/dom/html_base.cpp:
khtml/dom/html_block.cpp:
khtml/dom/html_document.cpp:
khtml/dom/html_element.cpp:
khtml/dom/html_element.h:
khtml/dom/html_form.cpp:
khtml/dom/html_head.cpp:
khtml/dom/html_image.cpp:
khtml/dom/html_inline.cpp:
khtml/dom/html_list.cpp:
khtml/dom/html_misc.cpp:
khtml/dom/html_object.cpp:
khtml/dom/html_table.cpp:
khtml/ecma/kjs_html.cpp:
khtml/ecma/kjs_proxy.cpp:
khtml/ecma/kjs_traversal.cpp:
khtml/ecma/kjs_window.cpp:
khtml/html/html_baseimpl.cpp:
khtml/html/html_formimpl.cpp:
khtml/html/html_miscimpl.h:
khtml/html/html_objectimpl.cpp:
khtml/html/html_objectimpl.h:
khtml/html/htmlparser.cpp:
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp:
khtml/html/htmltokenizer.h:
khtml/khtml_part.cpp:
khtml/khtmlpart_p.h:
khtml/khtmlview.cpp:
khtml/misc/helper.cpp:
khtml/misc/khtmllayout.h:
khtml/misc/loader.cpp:
khtml/misc/loader.h:
khtml/misc/loader_client.h:
khtml/misc/shared.h: Added.
khtml/rendering/bidi.cpp:
khtml/rendering/break_lines.cpp:
khtml/rendering/font.cpp:
khtml/rendering/render_applet.cpp:
khtml/rendering/render_applet.h:
khtml/rendering/render_container.cpp:
khtml/rendering/render_form.cpp:
khtml/rendering/render_form.h:
khtml/rendering/render_frames.cpp:
khtml/rendering/render_image.cpp:
khtml/rendering/render_object.cpp:
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp:
khtml/rendering/render_replaced.h:
khtml/rendering/render_root.cpp:
khtml/rendering/render_style.cpp:
khtml/rendering/render_style.h:
khtml/rendering/render_table.cpp:
khtml/rendering/render_table.h:
khtml/rendering/render_text.cpp:
khtml/rendering/render_text.h:
khtml/xml/dom2_eventsimpl.h:
khtml/xml/dom2_rangeimpl.h:
khtml/xml/dom2_traversalimpl.cpp:
khtml/xml/dom2_traversalimpl.h:
khtml/xml/dom2_viewsimpl.h:
khtml/xml/dom_docimpl.cpp:
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_stringimpl.cpp:
khtml/xml/dom_stringimpl.h:
khtml/xml/xml_tokenizer.h: Merge in 3.0.1 changes and add APPLE_CHANGES as necessary to get it to compile.

12:44 PM Changeset in webkit [1325] by darin

2 edits
1 delete in trunk/WebKit

WebCoreSupport.subproj/IFCachedTextRenderer.m: Removed.

10:21 AM Changeset in webkit [1324] by sullivan

4 edits in trunk/WebKit

Fixed leaks in History mechanism, found by overriding
release, retain, autorelease, and dealloc and watching
the spam fly.

History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate addEntry:]): Make autoreleased array for entries on a given date. (-[IFWebHistoryPrivate _loadHistoryGuts:]): autorelease entries as they are generated from data on disk.

Added workaround for NSOutlineView leak, by collapsing items
just before removing them from the history view.

GlobalHistory.m: (-[GlobalHistory removeSelectedItems:]):

9:47 AM Changeset in webkit [1323]

16 copies in tags/KDE_3_0_1

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_1'.

9:47 AM Changeset in webkit [1322] by darin

1 add in branches/kde/WebCore/khtml/misc/shared.h

File that's new in 3.0.1

9:20 AM Changeset in webkit [1321] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fix a typo where I left the S off of DRAW_WITHOUT_ADVANCES.

9:14 AM Changeset in webkit [1320] by darin

217 edits in branches/kde

Check in the KDE 3.0.1 sources.

9:01 AM Changeset in webkit [1319] by darin

1 delete in branches/kde/WebCore/khtml/java

Remove java subdir from kde branch.

9:00 AM Changeset in webkit [1318] by darin

1 delete in branches/kde/WebCore/src

Get rid of old-location files from the kde branch.

3:23 AM Changeset in webkit [1317] by rjw

4 edits in trunk/WebKit

90% solution to round-off problem. khtml breaks measures text on space
boundaries during layout. It assumes integer measurement, CG uses float
measurements. Some common fonts have non-integer space width. So,
differences in between drawing advances and measurement of space characters
can easily accumulate enough to be visually apparent. We may still accumulate
differences across words, although it's much less visible than for spaces.
As a next step we can fudge the advances of words to force
integer widths, although I think, given how khtml work, just accounting for
consistency in measuring and drawing spaces may be sufficient.
Many sites that looked flaky before now render correctly.

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]):

Force rounding of advance for space characters.

(-[IFTextRenderer floatWidthForCharacters:length:]):

Force rounding of measurement for space characters.

Jun 9, 2002:

10:32 PM Changeset in webkit [1316] by sullivan

14 edits in trunk/WebKit

WebKit part of fix for 2949646 (Can't drag & drop bookmarks
into auto-expanded folder). To get this to work right, I gave
each bookmark a unique (per-session) identifier.

While working on this, I found and fixed some leaks of bookmarks.

Bookmarks.subproj/IFBookmark.h: New -[identifier] method and _identifier ivar.

Bookmarks.subproj/IFBookmark.m: (+[IFBookmark _generateUniqueIdentifier]): (-[IFBookmark init]): (-[IFBookmark dealloc]): Remember unique identifier in each bookmark as it is created; delete when dealloc'd.

(-[IFBookmark identifier]): Return unique identifier.

(-[IFBookmark _setParent:]): Don't retain parent, to avoid
circular ownership.

(-[IFBookmark _setGroup:]): Tell coming and going group.

Bookmarks.subproj/IFBookmarkGroup.h: New +[bookmarkForIdentifier] method and _bookmarksByID ivar.

Bookmarks.subproj/IFBookmarkGroup_Private.h: Declarations of _removedBookmark: and _addedBookmark:
Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup initWithFile:]): alloc _bookmarksByID. (-[IFBookmarkGroup dealloc]): release _bookmarksByID. (-[IFBookmarkGroup _setTopBookmark:]): Don't bail out early; would now cause leak. (-[IFBookmarkGroup _removedBookmark:]): New method, removes bookmark from _bookmarksByID. (-[IFBookmarkGroup _addedBookmark:]): New method, adds bookmark to _bookmarksByID. (-[IFBookmarkGroup bookmarkForIdentifier:]): Looks up bookmark from _bookmarksByID dictionary. (-[IFBookmarkGroup _loadBookmarkGroupGuts]): autorelease newTopbookmark; this had been leaking.

Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): autorelease children before adding them to parent; this had been leaking.

WebBrowser part of fix for 2949646 (Can't drag & drop bookmarks into
auto-expanded folder).

While working on this, I found and fixed some other unreported bugs, including
leaks of bookmarks.

BookmarksController.m: (-[BookmarksController windowDidLoad]): Use BookmarkIDListPboardType rather than RowListPboardType.

(-[BookmarksController _endEditing]),
(-[BookmarksController _toggleEdit:]): Broke _endEditing out of _toggleEdit so
it could be called by itself.

(-[BookmarksController _safeRemoveBookmark:]): Workaround for NSOutlineView bug
where removing expanded items leaks.

(-[BookmarksController removeSelectedBookmarks:]),
(-[BookmarksController _redoRemoveBookmarks:]): Call _endEditing to avoid problem
when removing a bookmark that's being edited; call _safeRemoveBookmark to prevent
leak.

(-[BookmarksController _anyAncestorOfRow:inArray:]): removed.
(-[BookmarksController _identifierOfBookmarkOrAnyAncestor:inArray:]):
Changed name from _rowOrAnyAncestor:inArray:, now deals with array of bookmark
identifiers rather than array of row numbers.

(-[BookmarksController outlineView:writeItems:toPasteboard:]),
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Reworked to use
array of bookmark identifiers rather than array of row numbers.

Preferences.subproj/English.lproj/ActiveContentPreferences.nib: Added 2nd sentence to "allow JavaScript to open windows automatically" preference at Maciej's wise suggestion.

9:40 PM Changeset in webkit [1315] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fixed a possible uninitialized variable problem that the compiler and Don caught.

2:16 PM Changeset in webkit [1314] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Add code to handle drawing when are more than LOCAL_GLYPH_BUFFER_SIZE advances. I ran into this loading <http://jersey.apple.com/data/20020606-074404M0.html>. Also fix handling of advances for the obscure case where we hit a non-base character, slowPackGlyphsForCharacters fails, and substituteFontforCharacters returns nil.

Jun 7, 2002:

11:48 PM Changeset in webkit [1313] by darin

11 edits in trunk

Makefile.am: Use new shared "embed.am" file so we don't need four copies of the embedding rules for WebFoundation, JavaScriptCore, WebCore, and WebKit.

5:53 PM Changeset in webkit [1312] by mjs

6 edits in trunk/WebCore

Tests/libiftest/Makefile.am: Make libiftest a static lib, to avoid concerns over non-libtool libraries named .dylib.

WebCore:

Makefile.am: Rename libwebcore.dylib to libwebcore.a; since this target is just a fake for dependency purposes, it doesn't matter what it's called.
.cvsignore: Update ignorance.

4:04 PM Changeset in webkit [1311]

2 copies
38 deletes in branches/jaguar-branch

This commit was manufactured by cvs2svn to create branch
'jaguar-branch'.

4:04 PM Changeset in webkit [1310]

1 copy
39 deletes in tags/WebFoundation-6~4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~4'.

4:04 PM Changeset in webkit [1309]

1 copy
39 deletes in tags/WebFoundation-6~3

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~3'.

4:04 PM Changeset in webkit [1308]

1 copy
39 deletes in tags/WebFoundation-6~2

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~2'.

4:04 PM Changeset in webkit [1307]

1 copy
39 deletes in tags/WebFoundation-6~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~1'.

4:04 PM Changeset in webkit [1306]

1 copy
39 deletes in tags/WebFoundation-6_1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6_1'.

4:04 PM Changeset in webkit [1305]

1 copy
39 deletes in tags/WebFoundation-6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6'.

4:04 PM Changeset in webkit [1304]

2 copies
38 deletes in tags/JAGUAR_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'JAGUAR_BRANCH_ANCHOR'.

4:04 PM Changeset in webkit [1303] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2949680 (IFURLFileDatabase will not work properly with hard disk quotas)

Rearranges calls through to the code that expires files from the disk cache
when the quota is exceeded. Now, files are deleted before writing a new cache
entry, rather than writing the file first, and deleting files to get back under
the quota.

Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:])

3:59 PM Changeset in webkit [1302] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2948819 (Disk cache emptying can be cut off by quitting program)

We kick a thread to delete the disk cache (in order for the cache emptying
function to return immediately). This involves moving the disk cache
directory aside and creating a new (empty) disk cache directory. If a user
quits the apps before the aside directory is completely deleted, it is
orphaned.

This patch does a check upon next startup for such orphaned files and
resumes the delete operation.

Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open])
Misc.subproj/IFNSFileManagerExtensions.h:
Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_deleteBackgroundRemoveLeftoverFiles:])

3:58 PM Changeset in webkit [1301] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936755 (.size can get out of synch with actual cache size on disk)

Four separate fixes to make sure the .size file stays in sync with the
cumulative size of the cache files on disk.

These fixes are:

1) Check that usage decrease when a file is removed is only done when removal succeeds.
2) Account for a cache file that gets rewritten to disk with a different size

than the file it is replacing.

3) Remove pending disk operations when the user clears the cache.
4) Make sure usage gets set back to zero on a cache clear.

Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase writeSizeFile:]) (-[IFURLFileDatabase removeAllObjects]) (-[IFURLFileDatabase performSetObject:forKey:]) (-[IFURLFileDatabase performRemoveObjectForKey:])

3:48 PM Changeset in webkit [1300] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-07 Kenneth Kocienda <kocienda@apple.com>

Reviewed by: Darin Adler

Fix for this bug:

Radar 2936676 (IFURLFileDatabase should be smarter about expiring cache files)

This patch adds code to generate a list of cache files sorted by file system
access time. This list is then used to expire least recently used cache
files first.

Database.subproj/IFURLFileDatabase.m: (compare_atimes): New function (IFPtrEqual): New function (IFFileAccessTimeRelease): New function (CreateArrayListingFilesSortedByAccessTime): New function (-[IFURLFileDatabase truncateToSizeLimit:]): Uses new functions

3:42 PM Changeset in webkit [1299] by darin

18 edits in trunk/WebCore

Makefile.am: I was running into failures in the embed rule, so I made it always remove the framework before copying the new one in. This is better for cases where a header was removed, too, so maybe we should do this in the other directories.

kwq/KWQDrawUtil.mm:
kwq/KWQKComboBox.mm:
kwq/KWQKConfigBase.mm:
kwq/KWQKDebug.mm:
kwq/KWQKMessageBox.mm:
kwq/KWQKMimeType.mm:
kwq/KWQKPrinter.mm:
kwq/KWQKURL.mm:
kwq/KWQMapImpl.mm:
kwq/KWQObject.mm:
kwq/KWQRegExp.mm:
kwq/KWQRegion.mm:
kwq/KWQScrollView.mm:
kwq/KWQStringList.mm: Remove repeated default values for parameters -- the new compiler won't allow these and they are illegal C++.

3:42 PM Changeset in webkit [1298] by darin

3 edits in trunk/WebKit

MIME.subproj/IFContentHandler.m: (-[IFContentHandler HTMLDocument]): Fix a warning that shows up with the new C++ compiler (not sure why it is not showing up with the old one).

3:02 PM Changeset in webkit [1297] by cblu

4 edits in trunk/WebKit

Allow plug-ins to make a NPP_*URLNotify request when
the target is _self, _top, _parent or _current. This goes
against the plug-in documentation, but mimics IE.
Need for iTools.

Plugins.subproj/IFPluginView.mm: (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]):

2:23 PM Changeset in webkit [1296] by mjs

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by: Ken Kocienda

Fixed the following bugs:

Radar 2854498 - Cookies are not saved between sessions
Radar 2862120 - -[IFCookie dictionaryRepresentation] is not yet implemented
Radar 2949513 - Session-only cookies should not be saved persistently
Radar 2949514 - Cookies need to be synchronized between multiple processes

Also, I moved the optimistic first try code for creating
directories and files with intermediate directories from the call
points to the functions themselves.

CookieManager.subproj/IFCookie.h:
CookieManager.subproj/IFCookie.m: (setExpires): (-[IFCookie dictionaryRepresentation]): (+[IFCookie _requestHeadersFromCookieArray:]): (+[IFCookie _cookieArrayFromResponseHeaders:forURL:]): (-[IFCookie _compareForHeaderOrder:]): (-[IFCookie _key]): (-[IFCookie _isExpired]):
CookieManager.subproj/IFCookieManager.m: (-[IFCookieManagerPrivate init]): (-[IFCookieManagerPrivate dealloc]): (-[IFCookieManager _registerForCookiePreferenceNotification]): (-[IFCookieManager _connectToCookieStorage]): (setUpOnLoadThread): (runningOnLoadThread): (-[IFCookieManager _scheduleSetupOnLoadThread]): (-[IFCookieManager _waitForLoadThreadSetup]): (-[IFCookieManager _continueSetCookies:context:]): (-[IFCookieManager _internalInit]): (-[IFCookieManager _cookieRequestHeadersForURL:withExtraCookies:]): (-[IFCookieManager cookies]): (-[IFCookieManager setCookie:]): (-[IFCookieManager deleteCookie:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:]): (-[IFCookieManager description]):
CookieManager.subproj/IFCookiePrivate.h:
CookieManager.subproj/IFCookieStorage.h: Added.
CookieManager.subproj/IFCookieStorage.m: Added. (-[IFCookieStoragePrivate init]): (-[IFCookieStoragePrivate dealloc]): (-[IFCookieStorage _updateCookiesFromServer]): (-[IFCookieStorage _connectionDidDie:]): (-[IFCookieStorage _establishConnection]): (-[IFCookieStorage init]): (-[IFCookieStorage initWithNotificationObject:]): (-[IFCookieStorage dealloc]): (-[IFCookieStorage setCookies:]): (-[IFCookieStorage deleteCookies:]): (-[IFCookieStorage cookies]): (-[IFCookieStorage cookiesMatchingDomain:path:secure:]):
CookieManager.subproj/IFCookieStorageServer.h: Added.
CookieManager.subproj/IFCookieStorageServer.m: Added. (-[IFCookieStorageServerPrivate init]): (-[IFCookieStorageServerPrivate dealloc]): (-[IFCookieStorageServer _checkForCookieExpiration:]): (-[IFCookieStorageServer _updateExpirationTimer:]): (-[IFCookieStorageServer _saveCookies]): (-[IFCookieStorageServer _saveCookiesIfScheduled]): (-[IFCookieStorageServer _scheduleSave]): (-[IFCookieStorageServer _notifyChanged]): (-[IFCookieStorageServer _setCookiesWithoutSaving:]): (-[IFCookieStorageServer init]): (-[IFCookieStorageServer dealloc]): (-[IFCookieStorageServer setCookies:]): (-[IFCookieStorageServer deleteCookies:]): (-[IFCookieStorageServer cookies]): (makeCookie): (-[IFCookieStorageServer loadCookies]):
Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase open]):
Misc.subproj/IFNSArrayExtensions.h:
Misc.subproj/IFNSArrayExtensions.m:
Misc.subproj/IFNSFileManagerExtensions.m: (-[NSFileManager _IF_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _IF_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]):
WebFoundation.pbproj/project.pbxproj:

1:02 PM Changeset in webkit [1295] by darin

6 edits in trunk/WebCore

kwq/KWQPtrDictImpl.h: Use CoreFoundation.h -- new compiler is picky about the difference between struct and typedef.

kwq/KWQValueListImpl.h: Add a friend declaration that we need because the new compiler is more strict.

fix 2949882 -- joecartoon.com crashes

khtml/ecma/kjs_window.cpp: (Window::get): Turn off some code that doesn't work for us -- similar to code elsewhere in this file that was also turned off.

12:59 PM Changeset in webkit [1294] by darin

3 edits in trunk/WebKit

WebKit.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.

12:59 PM Changeset in webkit [1293] by darin

4 edits in trunk/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Don't use any warning flags for C that won't work for C++, because PFE uses the C warning flags on a C++ compile.

12:49 PM Changeset in webkit [1292] by cblu

60 edits
9 adds
4 deletes in trunk

Summary

Made IFWebController a class.
Fixed all places where IFWebController was referred to as a protocol.
Renamed IFBaseWebController files to IFWebController.
IFWebController.h replaces IFWebBaseController.h.

Added support for IEPL plug-ins.

WebCore:

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[URLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
kwq/external.h:

WebKit:

Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels _didStartLoadingURL:inController:]): (-[IFStandardPanels _didStopLoadingURL:inController:]):
Panels.subproj/IFStandardPanelsPrivate.h:
Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
Plugins.subproj/IFPlugin.h:
Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): (-[IFPlugin initWithPath:]): (-[IFPlugin load]): (-[IFPlugin description]):
Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
Plugins.subproj/IFPluginView.h:
Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView webController]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/IFBaseWebController.h: Removed.
WebView.subproj/IFBaseWebController.mm: Removed.
WebView.subproj/IFBaseWebControllerPrivate.h: Removed.
WebView.subproj/IFBaseWebControllerPrivate.mm: Removed.
WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
WebView.subproj/IFWebController.h:
WebView.subproj/IFWebController.mm: Added. (-[IFWebController init]): (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController dealloc]): (-[IFWebController setDirectsAllLinksToSystemBrowser:]): (-[IFWebController directsAllLinksToSystemBrowser]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController setStatusText:forDataSource:]): (-[IFWebController statusTextForDataSource:]): (-[IFWebController openNewWindowWithURL:]): (-[IFWebController receivedProgress:forResource:fromDataSource:]): (-[IFWebController receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController provideLocationChangeHandlerForFrame:]): (-[IFWebController receivedPageTitle:forDataSource:]): (-[IFWebController serverRedirectTo:forDataSource:]): (-[IFWebController _frameForDataSource:fromFrame:]): (-[IFWebController frameForDataSource:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController frameNamed:]): (-[IFWebController mainFrame]): (-[IFWebController pluginNotFoundForMIMEType:pluginPageURL:]): (-[IFWebController provideLocationChangeHandlerForFrame:andURL:]): (-[IFWebController URLPolicyForURL:]): (-[IFWebController unableToImplementURLPolicyForURL:error:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): (-[IFWebController stopAnimatedImages]): (-[IFWebController startAnimatedImages]): (-[IFWebController stopAnimatedImageLooping]): (-[IFWebController startAnimatedImageLooping]):
WebView.subproj/IFWebControllerPrivate.h: Added.
WebView.subproj/IFWebControllerPrivate.mm: Added. (-[IFWebControllerPrivate init]): (-[IFWebControllerPrivate _clearControllerReferences:]): (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResource:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResource:fromDataSource:]): (-[IFWebController _receivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResource:partialProgress:fromDataSource:]): (-[IFWebController _didStartLoading:]): (-[IFWebController _didStopLoading:]):
WebView.subproj/IFWebDataSource.h:
WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource controller]):
WebView.subproj/IFWebDataSourcePrivate.h:
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
WebView.subproj/IFWebFrame.h:
WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): (-[IFWebFrame controller]): (-[IFWebFrame setController:]): (-[IFWebFrame frameNamed:]):
WebView.subproj/IFWebFramePrivate.h:
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setController:]): (-[IFWebFrame _setController:]):
WebView.subproj/IFWebView.h:
WebView.subproj/IFWebView.mm: (-[IFWebView controller]):
WebView.subproj/IFWebViewPrivate.h:
WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _setController:]):