Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 7, 2002:

11:24 PM Changeset in webkit [1774] by mjs

• 19 edits in trunk

WebCore:

WebCore work for:

• fixed 2956008 - Need API for getting/setting text encoding for current page

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Handle the possibility of override encoding - one that's not just a hint from the server but should override
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withEncoding:]): Adjust for slotData interface change. (-[WebCoreBridge addData:withOverrideEncoding:]): New method that allows passing override encoding as a CFStringEncoding. (-[WebCoreBridge textEncoding]): Return the current text encoding.

WebKit:

WebKit work for:

• fixed 2956008 - Need API for getting/setting text encoding for current page

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Handle override encoding, if any.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Remember the flags and attributes.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Initialize overrideEncoding (-[WebDataSourcePrivate dealloc]): Release attributes (-[WebDataSource _setOverrideEncoding:]): Added. (-[WebDataSource _overrideEncoding]): Added. (-[WebDataSource _flags]): Added. (-[WebDataSource _attributes]): Added.
• WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Pass proper forceRefresh value to data source based on load type (but the data source will ignore it). (-[WebFrame reload:]): Made this work a bit better. Now instead of crashing, it will actually reload, but it won't force a refresh (and may not handle the back/forward issues properly).
• WebView.subproj/WebDocument.h: Defined new WebDocumentTextEncoding protocol.
• WebView.subproj/WebHTMLView.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView textEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setTextEncoding:]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView usingDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol.

WebBrowser:

• fixed 2957200 - Text Encoding submenu is not yet implemented

• AppController.h:
• AppController.m: (-[AppController applicationDidFinishLaunching:]): Install standard Text Encoding menu items.
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Validate the menu items properly, based on whether the current view can change encodings. (-[BrowserWindowController changeTextEncoding:]): Hook up to new WebKit API.
• English.lproj/MainMenu.nib: Add Default item to encoding menu, hook it up to AppController.
• TextEncodingMenu.h: Added. Stolen from Mail.
• TextEncodingMenu.m: Added. Stolen from Mail.
• WebBrowser.pbproj/project.pbxproj: Added new files.

6:19 PM Changeset in webkit [1773] by hyatt

• 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

Fix build bustage.

6:15 PM Changeset in webkit [1772] by hyatt

• 12 edits in trunk/WebCore

Adding support for a separate fixed font size to WebCore.
Your fixed font size pref will now be honored when the
generic monospace family is used.

• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/rendering/font.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
• kwq/WebCoreSettings.h:
• kwq/WebCoreSettings.m: (-[WebCoreSettings setFixedFontSize:]): (-[WebCoreSettings fixedFontSize]):
• kwq/khtml/khtml_settings.h:

1:30 PM Changeset in webkit [1771] by darin

• 4 edits in trunk/WebCore

• fixed 3017499 -- One-click crasher at hondamotorcycle.com

• kwq/KWQKURL.mm: (operator==): Just compare the strings. Faster and safer.

12:33 PM Changeset in webkit [1770] by sullivan

• 3 edits in trunk/WebKit

• fixed 3017245 -- Shift-Delete should go forward

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Check for shift-delete.

12:19 PM Changeset in webkit [1769] by rjw

• 9 edits in trunk

Fixed scrollview related drawing turd problems.
(3000844 and 2896459).

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
• WebView.subproj/WebView.m: (-[WebView setFrame:]):

Removed debug log.

• kwq/KWQFrame.mm: (QFrame::setFrameStyle):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):

12:03 PM Changeset in webkit [1768] by darin

• 8 edits in trunk

top level:

• Tests/WebFoundation-Misc/ifnsurlextensions-test.m: New test that tests more of the code in WebNSExtras.
• Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: New output for new test. Matches the old for canonicalize test cases.

WebFoundation:

• fixed 3017633 -- IPv6 URL support needed
• fixed 2876174 -- Some URL functions should be moved to IFNSURLExtensions and have test cases added

• Misc.subproj/WebNSURLExtras.h: Removed _web_extractHTTPBaseURLString and _web_URLWithScheme:user:password:host:port:path:parameter:query:fragment:, renamed _web_URLWithoutFragment to _web_URLByRemovingFragment.
• Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): Added. Used by the component-related functions. (StringByAddingPercentEscapes): Broken out from URLStringByAddingPercentEscapes. (URLStringByAddingPercentEscapes): Add code to handle the IPv6 case but make sure we escape any other bracket characters in the string. (+[NSURL _web_URLWithComponents:]): Added. (-[NSURL _web_URLComponents]): Added. These use the CFURL functions for breaking URLs into components, but makes them easier to use from AppKit by using autoreleased NSString objects and also fixes some anomalies in the CFURL functions. (-[NSURL _web_URLByRemovingFragment]): Simpler implementation, new name. (-[NSURL _web_URLByRemovingUserAndQueryAndFragment]): Added. Replaces WebNSURLRemoveUserAndSubresourceInfo. (-[NSURL _web_URLByRemovingPasswordAndPath]): Added. Replaces WebNSURLCanonicalRoot. (-[NSURL _web_URLByRemovingLastPathComponent]): Added. Replaces WebNSURLGetParent. (-[NSURL _web_canonicalize]): Rewrote to use _web_URLComponents.

• CacheLoader.subproj/WebFileProtocolHandler.m: (+[WebFileProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (+[WebHTTPProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.

• AuthenticationManager.subproj/WebAuthenticationManager.m: Remove WebNSURLRemoveUserAndSubresourceInfo, WebNSURLCanonicalRoot, and WebNSURLGetParent, and use equivalent functions from WebNSURLExtras.

• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_hasCaseInsensitivePrefix:]): Added.

WebCore:

• kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::decompose): Use CFURLCopyPath instead calling _NSParseStringToGenericURLComponents.

WebKit:

• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call _web_URLWithoutFragment by its new name _web_URLByRemovingFragment.

11:03 AM Changeset in webkit [1767] by cblu

• 4 edits in trunk/WebKit

Fixed: 3018632 - the show javascript files inline bug

• WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): support application/x-javascript
• WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): support application/x-javascript

10:43 AM Changeset in webkit [1766] by sullivan

• 7 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): Changed name from _web_superviewWithName: and made it take a Class object instead of a string.

• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
• Plugins.subproj/WebPluginView.m: (-[WebPluginView start]): (-[WebPluginView layout]): Updated callers of _web_superviewWithName:

• WebKit.pbproj/project.pbxproj: Changed WebNSViewExtras.h from Public to Private

WebBrowser:

• BrowserNSViewExtras.h,
• BrowserNSViewExtras.m: Remove superviewOfClass now that it's in WebKit

• ActivityViewer.m: (-[ActivityViewer bestSizeForWindowContent]): Use _web_superviewOfClass:

9:28 AM Changeset in webkit [1765] by rjw

• 1 edit in trunk/WebCore/kwq/WebCoreBridge.mm

Fixed compile problem.

9:22 AM Changeset in webkit [1764] by rjw

• 4 edits in trunk/WebCore

Turned off temporary debugging I accidentally checked in.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):

Aug 6, 2002:

10:46 PM Changeset in webkit [1763] by hyatt

• 6 edits in trunk/WebCore

Make user stylesheet changes dynamic. Web documents will now
update as the user stylesheet is applied and unapplied. Altered
how reapplyStyles works a bit.

• khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setUserStyleSheet):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]):

9:19 PM Changeset in webkit [1762] by hyatt

• 5 edits in trunk/WebCore

Enable user stylesheet support. It works from a fresh start but
is not yet completely dynamic.

• khtml/khtml_part.cpp: (KHTMLPart::setUserStyleSheet):
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::userStyleSheet):

9:12 PM Changeset in webkit [1761] by darin

• 12 edits in trunk

WebCore:

• fixed 2965321 -- Crash on window close in kthml::Loader::cancelRequests from particular page

• khtml/misc/loader.cpp: (Loader::servePendingRequests): Look at return value from KWQServeRequest instead of assuming it will always succeed.
• kwq/KWQLoaderImpl.h: Add return value for KWQServeRequest.
• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Return false if we fail to make either the NSURL or the WebResourceHandle. Also make sure that we delete the job if necessary.

WebKit:

Fix assert I saw while fixing bug 2965321.

• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Create a suitable resource identifier from the failing URL in the WebError for cases where we fail before we are able to construct a resource handle.

8:58 PM Changeset in webkit [1760] by sullivan

• 4 edits in trunk/WebCore

• force-clean-timestamp: Edited this file to force a make clean in WebCore after discovering that it was necessary the hard way. I'm not sure which earlier checkin made this be required.

8:39 PM Changeset in webkit [1759] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Fix crash in overURL, another case just like bug 3006336.

8:29 PM Changeset in webkit [1758] by darin

• 3 edits in trunk/WebKit

• fixed 2970516 -- Activate Events don't appear to be coming in to the Java Applet.plugin correctly.

• Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Use activeFlag to set modifiers, not activMask, which is an event mask.

7:05 PM Changeset in webkit [1757] by rjw

• 11 edits in trunk/WebCore

Frame resizing related changes. Frames are now resizable
w/ a resize bar. Still need to draw frame borders.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared):
• kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameStyle): (QFrame::frameWidth):
• kwq/KWQWidget.mm: (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::flushDrawing): (QWidget::enableFlushDrawing): (QWidget::disableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::displayRect):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
• kwq/qt/qframe.h:
• kwq/qt/qwidget.h:

5:57 PM Changeset in webkit [1756] by sullivan

• 4 edits in trunk/WebKit

WebKit:

Add mechanism to store userStyleSheet preferences in WebKit in
preparation for Dave wiring up the implementation.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetEnabled]), (-[WebPreferences setUserStyleSheetEnabled:]), (-[WebPreferences userStyleSheetLocation]), (-[WebPreferences setUserStyleSheetLocation:]): New methods, read and write UserDefaults values.

(+[WebPreferences load]): Set initial values for
userStyleSheetEnabled and userStyleSheetLocation

WebBrowser:

Updated to use userStyleSheet preferences from WebKit.

• Defaults.plist,
• PreferenceKeys.h: Remove preference keys for ApplyStyleSheet since this is in WebKit now.

• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences setStylesheetPathPreference:]), (-[AppearancePreferences stylesheetPathPreference]), (-[AppearancePreferences updateStylesheetViews]), (-[AppearancePreferences toggleApplyStylesheet:]): Update to use WebKit preferences API; remove local storage.

4:28 PM Changeset in webkit [1755] by mjs

• 16 edits in trunk

WebCore:

Removed some APPLE_CHANGES no longer needed after the part change.

• khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Don't call impl version. (KHTMLPart::setOpenedByJS): Don't call impl version.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: Removed openedByJS and setOpenedByJS.
• kwq/WebCoreBridge.h: Don't prototype setOpenedByScript: and openedByScript methods now that they are not needed.

WebKit:

Removed some APPLE_CHANGES no longer needed after the part change.

• WebCoreSupport.subproj/WebBridge.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.

3:37 PM Changeset in webkit [1754] by darin

• 8 edits in trunk/WebKit

WebKit:

• fixed 3017761 -- dataSource != nil assertion navigating at yahoo.com

• WebView.subproj/WebLocationChangeHandler.h:
• WebView.subproj/WebLocationChangeHandler.m: Change client redirect calls to pass the frame, not the data source. At the time a client redirect is requested, it's not even clear yet which data source will be involved. We may want to make some of the other calls pass frames, also, aside from the "start", "committed", "done", calls, which must specify the data source.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Pass frame, not data source. (-[WebBridge reportClientRedirectCancelled]): Pass frame, not data source.

WebBrowser:

Update for change to client redirect API.

• LocationChangeHandler.m: (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler clientRedirectCancelledForFrame:]): We get the frame now, not the data source.

1:16 PM Changeset in webkit [1753] by hyatt

• 7 edits in trunk/WebCore

Make checkboxes and radio buttons use the small control
size. Tweak their baselines to not use font metrics and
to line up properly. (voodooextreme.com nearly renders
the left column correctly now.)

• khtml/rendering/render_form.cpp: (RenderCheckBox::baselinePosition): (RenderRadioButton::baselinePosition):
• khtml/rendering/render_form.h:
• kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox):
• kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton):

12:54 PM Changeset in webkit [1752] by darin

• 52 edits in trunk/WebKit

WebFoundation:

• lots of files: Changed url to URL in many places and renamed URL-related methods.

WebKit:

• lots of files: Changed url to URL in many places and renamed URL-related methods.

WebBrowser:

• lots of files: Changed url to URL in many places and renamed URL-related methods.

11:09 AM Changeset in webkit [1751] by sullivan

• 4 edits in trunk/WebCore

WebCore:

WebCore part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

• khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): inside APPLE_CHANGES, remove use of KHTML limits for zoom factor; this is a client responsibility in our model.

WebBrowser:

WebBrowser part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

• BrowserDocument.h:
• BrowserDocument.m: Define min/max text multiplier values, and ratio (-[BrowserDocument canMakeTextLarger]), (-[BrowserDocument canMakeTextSmaller]): New methods, check that there's a page and that the new size wouldn't be too big/small.

(-[BrowserDocument makeTextLarger:]),
(-[BrowserDocument makeTextSmaller:]):
New methods, set web controller's text multiplier.

(-[BrowserDocument validateUserInterfaceItem:]):
Disable makeTextLarger and makeTextSmaller when appropriate.

11:00 AM Changeset in webkit [1750] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Put in a check for nil that I missed.

10:13 AM Changeset in webkit [1749] by darin

• 26 edits in trunk

WebCore:

• fixed 2948805 -- Need WebKit API for larger/smaller font feature

• khtml/khtml_part.cpp: (KHTMLPart::clear): Head in the direction of using the m_frames and m_objects arrays, by turning some APPLE_CHANGES code on. (KHTMLPart::checkCompleted): More code turned on here. (KHTMLPart::checkEmitLoadEvent): And more code turned on here. (KHTMLPart::parentPart): Remove APPLE_CHANGES version. We can use the original now. (KHTMLPart::setZoomFactor): Remove APPLE_CHANGES. We want this function now.
• khtml/khtml_part.h: Remove some APPLE_CHANGES to make xmlDocImpl public. No longer needed.
• khtml/khtmlpart_p.h: Remove a bunch of APPLE_CHANGES.
• kwq/KWQKHTMLPartImpl.h: Remove parentPart(), add getDocument() and getRenderer().
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Use parentPart() instead of [bridge parent]. (KWQKHTMLPartImpl::requestFrame): Set up a ChildFrame in the m_frames array. (KWQKHTMLPartImpl::layout): Use getRenderer(). (KWQKHTMLPartImpl::getDocument): Added. (KWQKHTMLPartImpl::getRenderer): Added.
• kwq/WebCoreBridge.h: Add [setParent:], remove [parent].
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setParent:]): Added. (-[WebCoreBridge reapplyStyles]): Use getDocument(). (-[WebCoreBridge forceLayout]): Use getRenderer(). (-[WebCoreBridge drawRect:withPainter:]): Use getRenderer(). (-[WebCoreBridge copyDOMTree:]): Use getDocument(). (-[WebCoreBridge copyRenderTree:]): Use getRenderer(). (-[WebCoreBridge completeURLForDOMString:]): Use getDocument(). (-[WebCoreBridge elementAtPoint:]): Use getRenderer(). (-[WebCoreBridge setTextSizeMultiplier:]):
• kwq/khtml/khtml_ext.h: Add dummy setEnabled function to make khtml_part.cpp compile.
• kwq/kparts/part.h: Add real parent() and setParent() implementation.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Call setParent:.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Initialize the text size multiplier to 1.
• WebView.subproj/WebDataSource.h: Removed [redirectedURL], deprecated [inputURL], added [URL].
• WebView.subproj/WebDataSource.m: (-[WebDataSource URL]): Added. Returns current URL, without requiring separate logic for the redirected and not-yet-redirected cases.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Use [WebDataSource URL].
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Use [WebDataSource URL].

WebBrowser:

• BrowserDocument.m: (-[BrowserDocument currentURL]): Use [WebDataSource URL]. (-[BrowserDocument provisionalURL]): Use [WebDataSource URL].
• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): Use [WebDataSource URL].
• DownloadMonitor.m: (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): Use [WebDataSource URL].
• FrameProgressEntry.m: (-[FrameProgressEntry URL]): Use [WebDataSource URL].

9:21 AM Changeset in webkit [1748] by sullivan

• 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Add default value for fixed width size (-[WebPreferences fixedFontSize]), (-[WebPreferences setFixedFontSize:]): New methods.

WebBrowser:

WebBrowser part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

• Preferences.subproj/TextPreferences.h:
• Preferences.subproj/TextPreferences.m: (-[TextPreferences updateFontSampleField:]): (-[TextPreferences updateFontSampleFields]): (-[TextPreferences chooseFont:]): (-[TextPreferences chooseStandardFont:]): (-[TextPreferences changeFont:]): (-[TextPreferences initializeFromDefaults]): Removed serif and sans-serif code, replaced with standard font. Made font sizes independent of each other.

• Preferences.subproj/English.lproj/TextPreferences.nib: Futzed with Interface Builder.

8:36 AM Changeset in webkit [1747] by darin

• 3 edits in trunk/WebKit

• fixed 3017536 -- Change default font to Lucida Grande 14 pt.

• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Changed default font and sans serif font family names to Lucida Grande. Changed default font size to 14 point.

Aug 5, 2002:

11:04 PM Changeset in webkit [1746] by mjs

• 9 edits in trunk

WebCore:

Fixed crashers and leaks that come up when changing the view
associated with a part.

• khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't zero out the part's view, because that will mess up setting a new one.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Destroy the old view if we own it.

WebKit:

fixed 2974993 - window.open does not return the right window object
fixed 3017140 - WebKit creates a new KHTMLPart per page; should
reuse it like KHTML does

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Don't swap the part at this point. Now it gets reused.

10:23 PM Changeset in webkit [1745] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Fix tyops that broke Development build.

9:54 PM Changeset in webkit [1744] by darin

• 9 edits in trunk

WebCore:

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::requestObject): Add some nil checks before making calls with nil NSURL objects. But we also have to figure out how to report some kind of error in these cases, because the current behavior is not so good.

WebKit:

• .cvsignore: Ignore WebCore-combined.exp.

9:35 PM Changeset in webkit [1743] by mjs

• 13 edits
  1 add in trunk

JavaScriptCore:

• fixed 3007072 - need to be able to build fat

• JavaScriptCore.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebFoundation:

• fixed 3007072 - need to be able to build fat

• WebFoundation.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebCore:

• fixed 3007072 - need to be able to build fat

• WebCore.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebKit:

• fixed 3007072 - need to be able to build fat

• WebKit.pbproj/project.pbxproj: Fixed DeploymentFat build.
• Makefile.am: Build WebCore-combined.exp for Development and Mixed build.
• WebKit-tests.exp: Added.
• WebKit.exp: Remove test-only function.

WebBrowser:

• fixed 3007072 - need to be able to build fat

• WebBrowser.pbproj/project.pbxproj: Fixed DeploymetFat build.

9:21 PM Changeset in webkit [1742] by darin

• 23 edits in trunk

WebCore:

• fixed 3016374 -- Change font default from small back to medium

• khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Change back to basing everything on mediumFontSize() as opposed to a defaultFontSize that was the same as "small". (CSSStyleSelector::applyRule): Default is m_fontSizes[3] again.
• khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute): Shift all the sizes up one, so 3 is now medium. It's important that 3 be the same as the default.
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach): Change the default back to medium.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Change the default back to [3].
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFontSize): Change name back.
• kwq/khtml/khtml_settings.h: Change name back to medium.

Do a little bit of wiring for the "text size multiplier" feature.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]): Added.

WebKit:

Do the wiring for the "text size multiplier" feature. The rest of the work will probably be done
at the WebCore level.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setFrame:]): Set the text size multiplier.
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setTextSizeMultiplier:]): Added. Calls _textSizeMultiplierChanged on the main frame. (-[WebController textSizeMultiplier]): Added.
• WebView.subproj/WebControllerPrivate.h: Added textSizeMultiplier instance variable.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): Added. Calls setTextSizeMultiplier: on the bridge, and _textSizeMultiplierChanged on all the child frames.

9:15 PM Changeset in webkit [1741] by cblu

• 5 edits in trunk/WebKit

WebKit:

Renamed icon loader delegate method to include the icon loader.

• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]):
• WebView.subproj/WebDataSourcePrivate.m:

WebBrowser:

Rendezvous changes:
Properly get host's IP address.
Load and display host's favicon.

• English.lproj/Rendezvous.nib:
• RendezvousController.m: (-[RendezvousController windowDidLoad]): (-[RendezvousController _attributedStringWithImage:]): (-[RendezvousController goToHostDoubleAction:]): (-[RendezvousController tableView:objectValueForTableColumn:row:]): (-[RendezvousController netServiceBrowser:didFindService:moreComing:]): (-[RendezvousController netServiceBrowser:didRemoveService:moreComing:]): (+[RendezvousController _URLForNetService:]): (-[RendezvousController netServiceDidResolveAddress:]): (-[RendezvousController iconLoader:receivedPageIcon:]):

7:38 PM Changeset in webkit [1740] by rjw

• 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRendererFactory.m

Added a comment.

7:35 PM Changeset in webkit [1739] by rjw

• 3 edits in trunk/WebKit

Added additional check to find appropriate fonts with available
weight, rather than always using a weight of 5.

Regarding "kCGErrorFailure : can't find name id 4 for font id 8395" errors:
CG appears to be lying to us about some fonts, Verdana in particular.
It claims to have an available Verdana font w/ the correct traits, but spits errors
when we request that font. Further, the Font Panel behaves oddly when you request
Verdana. The panel displays the font but if you select the font it doesn't
'stick'. A mystery.

• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):

6:23 PM Changeset in webkit [1738] by darin

• 7 edits in trunk

top level:

• Tests/WebFoundation-Misc/ifnsstringextensions-test.chk:
• Tests/WebFoundation-Misc/ifnsstringextensions-test.m: (main): Added test cases for _web_stringByCollapsingNonPrintingCharacters.

WebFoundation:

• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_stringByCollapsingNonPrintingCharacters]): Added. Collapses any non-printing characters into single spaces, and trims them from the ends too.

WebCore:

• fixed 3009321 -- bookmark and history menus show black square for (tm)

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseSpecial): Call fixUpChar. (HTMLTokenizer::parseText): Call fixUpChar. (HTMLTokenizer::parseTag): Call fixUpChar.

WebKit:

• fixed 2986567 -- suppress return characters from title in title bar, status bar, menu items

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]): Call _web_stringByCollapsingNonPrintingCharacters.

5:23 PM Changeset in webkit [1737] by rjw

• 3 edits
  1 add in trunk/WebKit

Added exported symbols file.

• WebKit.exp: Added.
• WebKit.pbproj/project.pbxproj:

4:19 PM Changeset in webkit [1736] by darin

• 4 edits in trunk/WebCore

• fixed 3016795 -- ​http://www.google.co.il/ fails to decode

• kwq/make-charset-table.pl: Added a hack that makes us treat for iso-8859-8-e and iso-8859-8-i the same as iso-8859-8; may not be exactly right, but it's probably OK modulo the actual bidi support.

3:47 PM Changeset in webkit [1735] by darin

• 8 edits in trunk/WebKit

WebFoundation:

• fixed 3015360 -- google.com, click on images link, stop icon spins forever

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentLengthReceived]): Fixed race condition where sizes of objects would jump down to 0 by returning the length of resourceData here instead of the mark. (-[WebResourceHandle _setLoad:]): Added. (-[WebResourceHandle _load]): Added. (-[WebResourceHandle _notifyClientsDidCancelLoading]): Do the WebResourceHandleDidBeginLoading calls outside the lock/unlock also.

• CacheLoader.subproj/WebResourceHandlePrivate.h: Added _setLoad: and _load.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad handleCount]): Add call to checkForNewHandles. (-[WebResourceLoad _submittedAttributes]): Added. (-[WebResourceLoad cleanup]): Pass the load to loadDidFinish, rather than passing a handle.

• CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManagerInstanceVariables init]): (-[WebResourceLoadManagerInstanceVariables dealloc]): (-[WebResourceLoadManager invalidateURL:]): (-[WebResourceLoadManager addLoad:forHandle:]): (-[WebResourceLoadManager requestWithURLHandle:]): (-[WebResourceLoadManager cancelRequestWithURLHandle:]): (-[WebResourceLoadManager loadDidFinish:]):

• CacheLoader.subproj/WebResourceLoadManager.m: Added new WebResourceLoadKey class, rather than trying to trick handles themselves into acting as keys. This works better for the case where a single load is shared by two handles. There's no telling which will be cancelled first, so there's no obvious choice for which to use as the key. (-[WebResourceLoadManager requestWithURLHandle:]): Rewrote for new scheme. I think it's a little less tricky than before, but it's also more terse. (-[WebResourceLoadManager cancelRequestWithURLHandle:]): Rewrote this too. (-[WebResourceLoadManager loadDidFinish:]): This too.

• CacheLoader.subproj/WebResourceLoadManagerPrivate.h: Change parameter type of loadDidFinish to WebResourceLoad. Removed unused cancelAllRequestsWithURL and cancelAllRequestsInGroup.

• CacheLoader.subproj/WebResourceLoadPrivate.h: Removed unused removeAllHandles, cancelIfServingOneHandle, and added _submittedAttributes.

• CacheLoader.subproj/WebResourceLoad.h: Removed canonicalURL.
• CacheLoader.subproj/WebFileProtocolHandler.m:
• CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m:
• CacheLoader.subproj/WebHTTPResourceLoader.m:
• CacheLoader.subproj/WebResourceLoadQueue.m: [WebResourceLoad url] now always returns a canonical URL. Got rid of [WebResourceLoad canonicalURL] and updated callers.

• CacheLoader.subproj/WebResourceLoadManager.h: Tweak.
• Misc.subproj/WebNSDictionaryExtras.m: Fix definitions to match header.

WebKit:

• fixed 3014122 -- spinner never stops spinning when iframe has URL with bad path

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Initialize the state in WebFramePrivate init instead.
• WebView.subproj/WebFramePrivate.h: Remove WebFrameStateUninitialized.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Set initial state to WebFrameStateComplete. (-[WebFrame _transitionToLayoutAcceptable]): Remove WebFrameStateUninitialized case. (-[WebFrame _transitionToCommitted]): Remove WebFrameStateUninitialized case. (-[WebFrame _isLoadComplete]): Remove WebFrameStateUninitialized case.

• WebView.subproj/WebDataSource.h: Tweak.
• WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]): Move downloadHandler logic from here into _stopLoading. (-[WebDataSource isLoading]): Rewrite for simplicity.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Move downloadHandler logic here from stopLoading. Also make this work even if handles are removed from the list during the stop process. (-[WebDataSource _recursiveStopLoading]): Simplify a lot by using WebFrame's stopLoading. (-[WebDataSource _setTitle:]): Use the committed boolean rather than the state to check if the title change should be sent to the location change handler.

9:07 AM Changeset in webkit [1734] by mjs

• 3 edits in trunk/WebKit

• Misc.subproj/WebKitDebug.h: Put WEBKIT_ASSERT_NOT_REACHED() inside the appropriate #ifdef, and remove the various _log macros, which are onsolete in WebKit.

4:30 AM Changeset in webkit [1733] by mjs

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Simplified a bit.

4:08 AM Changeset in webkit [1732] by mjs

• 15 edits in trunk

WebCore:

Merged KHTMLPart::end method with khtml original.

• khtml/khtml_part.cpp: (KHTMLPart::end): Remove call to impl. Use original version, but clear KURL cache and call slotFinishedParsing as well.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::end): Removed. (KWQKHTMLPartImpl::gotoBaseAnchor): Removed. No longer needed.
• kwq/KWQKURL.mm: (KURL::encodedHtmlRef): Implemented. (KURL::htmlRef): Implemented.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToBaseAnchor]): Removed. No longer needed.

WebKit:

Some changes related to re-merging the KHTMLPart end() method:

• Misc.subproj/WebKitDebug.h: Added WEBKIT_ASSERT_NOT_REACHED().
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Replace NSException with ASSERT_NOT_REACHED (this is an internal consistency check, not an argument check on a public API, so an assert is more appropriate than an exception). (-[WebFrame _transitionToCommitted]): Likewise. (-[WebFrame _isLoadComplete]): Likewise; also, remove bridge call to scrollToBaseAnchor:, since that will now happen automatically when calling end.

2:07 AM Changeset in webkit [1731] by mjs

• 8 edits in trunk/WebCore

Merged KHTMLPart::openURL method with khtml original.

• khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't call the impl version. Leave most of this #ifdef'd, except the parts that look useful.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Removed.

1:13 AM Changeset in webkit [1730] by mjs

• 11 edits in trunk/WebCore

Merged KHTMLPart::begin method with khtml original.

• khtml/khtml_part.cpp: (KHTMLPart::begin): Restore this method and don't call the impl version. ifdef out the parts that don't compile.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Removed.
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::showAnimations): Implemented; always return false. (KHTMLSettings::userStyleSheet): Implemented; always return empty string.
• kwq/kdecore/kurl.h: Implemented isValid as inline method.

Aug 4, 2002:

4:13 PM Changeset in webkit [1729] by hyatt

• 4 edits in trunk/WebCore

Fix my bungled CSS for input fields in the user agent style
sheet.

• khtml/css/html4.css:

Aug 3, 2002:

1:21 PM Changeset in webkit [1728] by darin

• 4 edits in trunk/WebCore

• fixed 2943519 - • is rendered as an asterisk rather than a bullet

• khtml/html/htmltokenizer.cpp: (fixUpChar): Replaced the macro of this name by an inline function that follows the Unicode specification. The macro was both making Windows Latin 1 extensions character codes (like 149 for bullet) work, but also mapping to characters that were suitable for Qt. Since OS X has no problem with the real Unicode values, we don't need that hack.

Aug 2, 2002:

10:53 PM Changeset in webkit [1727] by darin

• 46 edits
  6 adds in trunk

WebCore:

• fixed 3015522 -- crash decoding ​http://www.haaretz.co.il/

• khtml/misc/decoder.cpp: (Decoder::setEncoding): Put some hacks for handling Hebrew text encoding inside ifndef APPLE_CHANGES. It's not clear that these or the equivalent are needed for WebCore (they are related to the as-yet unimplemented bidirectional text support) and they were making us crash.

• fixed 2949235 -- checkboxes in wrong place until you scroll away and back

I fixed this once before, then removed that fix in favor of a simpler one.
But the simpler one didn't work, and I didn't test it properly. Now I have
a fix that works without the drawbacks of the original.

• khtml/rendering/render_replaced.cpp: (RenderWidget::layout): Remove the call to move the widget aside. This does no good because it's only called if the widget is told it needs to layout, which only happens if it's resized.

• khtml/rendering/render_root.cpp: (RenderRoot::layout): Call a KWQ function so we can do some work at layout time.

• kwq/KWQKHTMLPartImpl.mm: (moveWidgetsAside): Added. Function used recursively to move all widgets aside. (KWQKHTMLPartImpl::layout): Added. Called at layout time; moves all the widgets aside. They are moved back when print functions are called.

WebCore support for feature where client redirects are treated as if the
page was continuing to load. A big part of this was changing redirection
so that it uses QTimer, allowing us to use more of the original KHTMLPart
code. I added a feature to QTimer that KWQKHTMLPartImpl uses to monitor
what KHTMLPart does with the timer.

• kwq/qt/qobject.h: Changed "slots" definition so that all slots are public (to help KWQSlot get at them). Added a prefix for the slot and signal strings, so that we can detect the case where it's trying to connect a slot to another slot. Implement the convenience version of connect here in the header. Implement blockSignals. Remove setTarget. Make target mutable. Add new m_signalListHead and m_signalsBlocked.
• kwq/KWQObject.mm: (QObject::findSignal): Added. Helper function that locates a signal by name. (QObject::connect): Connects a signal to a slot using the new KWQSignal and KWQSlot. (QObject::disconnect): Disconnects, similar to the above. (QObject::QObject): Initialize target, m_signalListHead, and m_signalsBlocked. (QObject::~QObject): Assert that m_signalListHead is 0.

• khtml/khtml_part.cpp: (KHTMLPart::init): Move the code that connects the redirection timer out of APPLE_CHANGES. (KHTMLPart::~KHTMLPart): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::restoreURL): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::openURL): Move the APPLE_CHANGES so the code that stops the redirection timer will run. (KHTMLPart::closeURL): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::scheduleRedirection): Remove most of this function from the APPLE_CHANGES. We still probably need to revisit the handling of m_bComplete.

• kwq/KWQSignal.h: Added.
• kwq/KWQSignal.mm: Added.
• kwq/KWQSlot.h: Added.
• kwq/KWQSlot.mm: Added.
• WebCore.pbproj/project.pbxproj: Added KWQSignal.h/mm, KWQSlot.h/mm.

• khtml/misc/loader.h: Simplify APPLE_CHANGES ifdefs since all slots are now public.

• force-clean-timestamp: Touch this since header files were changed.

• khtml/ecma/kjs_window.cpp: (Window::get): Disable the "name" part of this. We can re-enable it if we need it, but every QObject had a name because of this one piece of code, and I don't think it was effectively setting the frame name. (Window::put): Disable the "name" part of this for the same reason. (History::getValueProperty): Disable the "length" part of this. It was calling some unimplemented stuff. We can re-enable this and implement what we need in KWQ then.

• khtml/rendering/render_form.h: Remove RenderTextArea::performAction, because I changed this one case to use the new connect machinery. We can convert all the other form items to use the new machinery, and then eliminate performAction altogether.
• khtml/rendering/render_form.cpp: (RenderSubmitButton::RenderSubmitButton): Remove unneeded setTarget. For the moment, connect takes care of this, and in the long run we won't need to set the target at all. (RenderLineEdit::RenderLineEdit): Ditto.

• khtml/rendering/render_frames.h:
• khtml/rendering/render_frames.cpp: Put partLoadingErrorNotify inside ifndef APPLE_CHANGES because it uses a bunch of Qt stuff that's not used anywhere else, and we never call it.

• kwq/KWQKHTMLPartImpl.h: Remove scheduleRedirection, timerEvent, and m_redirectionTimer, add redirectionTimerStartedOrStopped and layout.
• kwq/KWQKHTMLPartImpl.mm: (redirectionTimerMonitor): Added. Small stub that calls redirectionTimerStartedOrStopped. (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set up a monitor on the redirection timer. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove now-unneeded killTimer call. (KWQKHTMLPartImpl::jumpToSelection): Simplify by using dynamic_cast instead of render_name(). (KWQKHTMLPartImpl::redirectionTimerStartedOrStopped): Added. Calls bridge to report client redirect events whenever the redirection timer is started or stopped.

• kwq/qt/qtextedit.h: Define a KWQSignal for textChanged, and a function that calls it.
• kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Set up a KWQSignal for textChanged.
• kwq/KWQTextArea.mm: (-[KWQTextArea textDidEndEditing:]): Instead of calling emitAction, call textChanged, which will emit the signal using the new signal machinery.

• kwq/qt/qtimer.h:
• kwq/KWQTimer.mm: (+[KWQTimerTarget targetWithQTimer:]): Added. Used to implement QTimer in terms of NSTimer. (-[KWQTimerTarget timerFired:]): Added. Used to implement QTimer in terms of NSTimer. (QTimer::QTimer): Added. (QTimer::isActive): Implemented. (QTimer::start): Implemented. (QTimer::stop): Implemented. (QTimer::setMonitor): Implemented. (QTimer::fire): Implemented.

• kwq/WebCoreBridge.h: Changed name of gotoAnchor to scrollToAnchor. Added client redirect methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToAnchor:]): Changed name.

WebKit:

WebKit support for feature where client redirects are treated as if the
page was continuing to load.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Added. Passes the client redirect along to the location change handler. (-[WebBridge reportClientRedirectCancelled]): Passes client redirect cancel along to the location change handler. (-[WebBridge dataSourceChanged]): Remove hack related to dummy data source. (-[WebBridge dataSource]): Remove hack related to dummy data source.

• WebView.subproj/WebLocationChangeHandler.h: Added client redirect methods. Added class for base implementation of protocol. Updated stale comment.
• WebView.subproj/WebLocationChangeHandler.m: Added. Provides base implementation of the WebLocationChangeHandler protocol so that clients don't need to implement all the methods if they are only interested in some of them.
• WebKit.pbproj/project.pbxproj: Added WebLocationChangeHandler.m.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call scrollToAnchor under its new name.

• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebIconLoader.m:
• WebView.subproj/WebControllerPolicyHandler.m:
• WebView.subproj/WebControllerPolicyHandlerPrivate.h: Replaced MyCompanyName with the actual name of our company.

WebBrowser:

• fixed 2948387 -- stop button flashes to "go" twice while loading citibank.com

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): Call _setInstantRedirectPending:NO when it's a load of the main frame. (-[LocationChangeHandler receivedPageTitle:forDataSource:]): Make this call through to the load monitor even for frames other than the main one. (-[LocationChangeHandler serverRedirectTo:forDataSource:]): Make this call through to the load monitor even for frames other than the main one. (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forDataSource:]): Added. Call _setInstantRedirectPending:YES when it's a no-delay redirect of the main frame. (-[LocationChangeHandler clientRedirectCancelledForDataSource:]): Added. Call _setInstantRedirectPending:NO when it's the main frame, and also post a notification.

• BrowserDocument.h: Added BrowserDocumentClientRedirectCancelledNotification and _instantRedirectPending instance variable.
• BrowserDocument.m: (-[BrowserDocument isLoading]): Return YES if _instantRedirectPending. (-[BrowserDocument _setInstantRedirectPending:]): Set _instantRedirectPending.
• BrowserDocumentPrivate.h: Declare _setInstantRedirectPending.

• BrowserWindowController.h: Renamed frameLoadRedirected to mainFrameRedirected.
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Connect the new BrowserDocumentClientRedirectCancelledNotification to frameLoadPossiblyFinished. (-[BrowserWindowController mainFrameRedirected]): Renamed from frameLoadRedirected and removed the parameter since it is called only for the main frame. (-[BrowserWindowController frameLoadPossiblyFinished:]): Renamed from frameLoadFinished since a frame load is not necessarily finished when this is called. Also move the work back in here from respondToFrameLoadFinished to undo my previous attempt at this feature.

• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner init]): Connect the new BrowserDocumentClientRedirectCancelledNotification to pageLoadPossiblyDone. (-[PageLoadTestRunner pageLoadPossiblyDone:]): Renamed from pageLoadDone since the page load is not necessarily finished when this is called. Also move the work back in here from respondToPageLoadDone to undo my previous attempt at this feature.

• BrowserNSControlExtras.h:
• BrowserNSControlExtras.m:
• ContextMenuHandler.h:
• ContextMenuHandler.m:
• TitleBarButton.h:
• TitleBarButton.m: Replaced MyCompanyName with the actual name of our company.

5:45 PM Changeset in webkit [1726] by hyatt

• 19 edits in trunk/WebCore

Lots of form control changes.

• Inputs and textareas now respond to setFont and can have their font set by the Web page explicitly. These fields emulate the WinIE behavior of defaulting to the UI system font and only picking up new fonts if they are explicitly specified on the element itself.
• Buttons and selects use the small versions now.
• Stopped trying to align controls along baselines of their interior text. Konqueror is the only browser that does this, and it looks bad on many pages. With this patch controls align along their bottom borders (which extend slightly below the baseline of surrounding text). This matches Gecko, MacIE, and WinIE behavior.
• Stopped using monospace for textareas and inputs.
• Fixed a bug with inputs not calling setScrollable on their cells.

• khtml/css/html4.css:
• khtml/rendering/render_form.cpp: (RenderSubmitButton::calcMinMaxWidth): (RenderSubmitButton::baselinePosition): (RenderLineEdit::baselinePosition): (RenderSelect::baselinePosition):
• khtml/rendering/render_form.h:
• kwq/KWQButton.mm: (QButton::QButton): (QButton::sizeHint):
• kwq/KWQComboBox.mm: (QComboBox::init):
• kwq/KWQLineEdit.mm: (QLineEdit::cursorPosition): (QLineEdit::setFont):
• kwq/KWQNSTextField.mm: (-[KWQNSTextField initWithFrame:widget:]):
• kwq/KWQView.mm: (-[KWQNSButtonCell cellSizeForBounds:]): (+[KWQNSButton initialize]):
• kwq/WebCoreTextRendererFactory.h:
• kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory fontWithFamily:traits:size:]):
• kwq/qt/qbutton.h:
• kwq/qt/qlineedit.h:

2:44 PM Changeset in webkit [1725] by sullivan

• 3 edits in trunk/WebKit

• fixed 3015705 -- Command-up-arrow and -down-arrow should go to beginning and end of web page

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Added checks for command key.

Aug 1, 2002:

6:51 PM Changeset in webkit [1724] by rjw

• 11 edits in trunk/WebKit

Effort towards 3014555 (going back to frame), but not fixed.
Need to think more about appropriate solution and compromises.

• History.subproj/WebBackForwardList.h:
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList backEntryAtIndex:]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:parent:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem parent]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setParent:]): (-[WebHistoryItem setDisplayTitle:]):
• WebCoreSupport.subproj/WebBridge.m:
• WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame _scrollToTop]):

4:44 PM Changeset in webkit [1723] by cblu

• 3 edits in trunk/WebKit

WebKit:

Only send command key events if the plug-in is in the responder chain.

• Plugins.subproj/WebPluginView.m: (-[WebPluginView isInResponderChain]): (-[WebPluginView performKeyEquivalent:]): (-[WebPluginView setWindow]): added some more logging

WebBrowser:

Fixed: 2897678 - send urls from LS to new windows

• AppController.m: (-[AppController handleGURLEvent:withReplyEvent:]):

3:40 PM Changeset in webkit [1722] by darin

• 4 edits in trunk/WebCore

• fixed 2841277 -- support for charset=gb2312

• kwq/character-sets.txt: Added "euc-cn" to the list of aliases for "gb2312", since that's the name used by CFStringEncoding for that character set.

2:48 PM Changeset in webkit [1721] by mjs

• 7 edits in trunk/WebCore

Remove KWQKHTMLPartImpl's setBaseURL method and m_baseURL field,
since nothing should really need them any more.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Set base URL on document, if it exists. (KWQKHTMLPartImpl::requestFrame): Get base URL from document. (KWQKHTMLPartImpl::requestObject): Ditto. (KWQKHTMLPartImpl::frames): Ditto. (KWQKHTMLPartImpl::setBaseURL): Removed.

2:26 PM Changeset in webkit [1720] by cblu

• 3 edits in trunk/WebKit

Only send command keyDown once by ignoring the keyDown that comes after performKeyEquivalent.

• Plugins.subproj/WebPluginView.m: (-[WebPluginView keyDown:]):

2:09 PM Changeset in webkit [1719] by cblu

• 3 edits in trunk/WebKit

Fixed: 2970530 - Command keys are not getting passed in to plugins

• Plugins.subproj/WebPluginView.m: (-[WebPluginView performKeyEquivalent:]):

1:31 PM Changeset in webkit [1718] by rjw

• 18 edits in trunk

WebKit:

More back/forward word. Support for restoring scroll position.
We still have a big remaining issue. We don't record the entire
frame tree in back/forward items. This means going back or forward
to a frame will looose the context of the containing frameset,
see 3014555.

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList currentEntry]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem anchor]): (-[WebHistoryItem setAnchor:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]):
• WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]): (-[WebController goBack]): (-[WebController goForward]):
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame _goToItem:withFrameLoadType:]): (-[WebFrame _restoreScrollPosition]): (-[WebFrame _scrollToTop]):

WebBrowser:

Removed old obsolete restore scroll position code.

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]):

WebCore:

Added method to allow WebKit to direct khtml to
goto to an anchor point. Need for back/forward.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge gotoAnchor:]):

WebFoundation:

Convenience method to remove fragment (target anchor)
from URL.

• Misc.subproj/WebNSURLExtras.h:
• Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithoutFragment]):

1:09 PM Changeset in webkit [1717] by kocienda

• 4 edits in trunk/WebCore

Tweaked WebCore cache settings. The WebCore cache will now grow
to 1 MB (was 512k). The maximum cacheable item is 16k instead of 40k.

• khtml/misc/loader.cpp

11:19 AM Changeset in webkit [1716] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Added socket loader to get uncached HTTP content without using CFNetwork.

Zoom!

11:03 AM Changeset in webkit [1715] by cblu

• 3 edits in trunk/WebKit

Fixed:
2938010 - PLUGINS: right-click support
2938011 - PLUGINS: extended key events support
2970523 - Arrow key events not correctly passed to applets

• Plugins.subproj/WebPluginView.m: (-[WebPluginView modifiersForEvent:]): (-[WebPluginView getCarbonEvent:withEvent:]): (-[WebPluginView mouseDown:]): (-[WebPluginView keyUp:]): (-[WebPluginView keyDown:]): (-[WebPluginView menuForEvent:]):

10:47 AM Changeset in webkit [1714]

• 3 copies in tags/Alexander-15

This commit was manufactured by cvs2svn to create tag 'Alexander-15'.

10:47 AM Changeset in webkit [1713] by sheridan

• 8 edits in trunk

Alex-15 versions & changelog markers

8:18 AM Changeset in webkit [1712] by gramps

• 3 edits in trunk/WebKit

Fixed deployment build compile problem.

2:59 AM Changeset in webkit [1711] by mjs

• 8 edits in trunk/WebCore

Restored the original KHTMLPart::write() now that none of our
changes in the impl version are beneficial in any way.

• khtml/khtml_part.cpp: (KHTMLPart::write): Restore original code in lieue of calling impl version.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Remove initialization of m_decodingStarted, since it is now gone. (KWQKHTMLPartImpl::write): Removed.

2:36 AM Changeset in webkit [1710] by mjs

• 7 edits in trunk/WebCore

Removed m_documentSource and remaining ill-conceived uses thereof.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Don't initialize it. (KWQKHTMLPartImpl::write): Don't use it.

1:30 AM Changeset in webkit [1709] by mjs

• 13 edits in trunk

WebCore:

Remove stuff formerly useful for "View Reconstructed Source"
feature but now useless.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::documentSource): Removed.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge documentTextFromDOM]): Removed.

WebKit:

Remove stuff formerly useful for "View Reconstructed Source"
feature but now useless.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource documentTextFromDOM]): Removed.

12:52 AM Changeset in webkit [1708] by mjs

• 16 edits in trunk/WebKit

Changed things around so that WebFrame, not WebDataSource, owns
WebBridge. This allows us to remove the dummy data source.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Remove all dummy data source-related crud, but call _changeBridge to create the initial bridge. (-[WebFrame setProvisionalDataSource:]): Remove dummy data source-related epicycles.
• WebView.subproj/WebFramePrivate.h: Add bridge member to private class.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setDataSource:]): Don't remove old data source from frame, this is no longer needed and may even be harmful. (-[WebFrame _transitionToCommitted]): Remove much now-unneeded code. (-[WebFrame _isLoadComplete]): Get location change handler from controller. Don't call end on the bridge if the document is not html. (-[WebFrame _changeBridge]): Free the old bridge and make a new one. (-[WebFrame _bridge]): Get it directly, not from the data source.

• WebView.subproj/WebDataSourcePrivate.h: Remove everything related to the `dummy' concept.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setFinalURL:]): Reorder code a bit. (-[WebDataSource _bridge]): Get bridge from frame. (-[WebDataSource _commitIfReady]): No more need to set the bridge's frame. (-[WebDataSource _makeRepresentation]): Set data source on the rep. (-[WebDataSource _startLoading:]): Get location change handler from controller. (-[WebDataSource _setTitle:]): Likewise. (-[WebDataSource receivedPageIcon:]): Likewise. (-[WebDataSource _loadIcon]): Likewise.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]): Get location change handler from the controller.

• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Change *and* commit the data source. This could probably be collapsed down to one method now.

• WebView.subproj/WebDocument.h: Added setDataSource: method to the WebDocumentRepresenation protocol. For now it is only useful for the HTML representation, but could potentially be useful for other representation classes. It should also allow the data source to be removed as a parameter from other methods, but I have not done that yet. It may be even better still to pass the data source as a paremeter to the init method.

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Remove allocation of bridge. (-[WebHTMLRepresentation dealloc]): Remove release of bridge. (-[WebHTMLRepresentation setDataSource:]): Store unretained reference to the data source's frame's bridge.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _bridge]): Fetch the bridge from the frame, not the data source.
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation setDataSource:]): Added empty implementation.
• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]): Added empty implementation.
• Plugins.subproj/WebPluginStream.m: (-[WebPluginStream setDataSource:]): Added empty implementation.

Jul 31, 2002:

2:57 PM Changeset in webkit [1707] by darin

• 13 edits in trunk/WebCore

• kwq/qt/qptrvector.h:
• kwq/qt/qvector.h:
• kwq/KWQVectorImpl.h:
• kwq/KWQVectorImpl.mm:
• force-clean-timestamp: New implementation of QVector that does not use CFArray. Should fix some data() anomalies. Shares wierdnesses with the original Qt class.

• WebCore-tests.exp: Remove old QVector entry points and add new ones.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Did a tiny optimization by initializing the QString rather than first assigning and then initializing. Also reworded some comments and rearranged code to make it clearer that m_decodingStarted is now used only to decide when to call determineParseMode.

• khtml/css/cssparser.cpp: Removed the APPLE_CHANGES around a change that's fine for non-Apple use as well.

Jul 30, 2002:

7:38 PM Changeset in webkit [1706] by mjs

• 13 edits in trunk

WebCore:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

• fixed 3008682 - Alexander cannot run Mozilla-PLT

• khtml/misc/decoder.cpp: (Decoder::decode): Don't drop the accumulated buffer if the document happens to be unicode!
• kwq/KWQCString.mm: (operator==): Fix reversed logic when comparing an empty QCString to a const char *.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Set complete flag later so that initializing it to false doesn't clobber setting it. (KWQKHTMLPartImpl::begin): Initialize complete flag to false. (KWQKHTMLPartImpl::write): Don't buffer things up for the decoder - the decoder does that internally.
• kwq/WebCoreBridge.h, kwq/WebCoreBridge.mm: Remove setURL: method.

WebKit:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

• fixed 3008682 - Alexander cannot run Mozilla-PLT

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Don't call setURL: to set a URL that we got from a redirect; just pass it directly to openURL:. The inputURL is irrelevant.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setFinalURL:]): Don't call setURL: on the bridge; instead, assert that the data source is committed, because it would be a mistake to get a redirect after having received data.

7:14 PM Changeset in webkit [1705] by rjw

• 4 edits in trunk/WebCore

Don't create unnecessary unicode string. Of the
95695 unnecessary unicode allocations we do loading
the base test, this usage accounted for 7185. Most
of the others come from DOMString to QConstString to
QString to unicode() conversion during parsing. All
that unnecessary work needs to be removed.

• kwq/KWQColor.mm: (decodeColorFromHexColorString):

4:53 PM Changeset in webkit [1704] by hyatt

• 4 edits in trunk/WebCore

Ok, this time i've got it. I hope. I think. Fingers crossed.
Putting the table recalc check back in one more time. :)

• khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):

4:30 PM Changeset in webkit [1703] by hyatt

• 4 edits in trunk/WebCore

Backing myself out again. No crashes, but now pages stall.
#*^&*#@%*&!!!!

• khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):

4:07 PM Changeset in webkit [1702] by hyatt

• 5 edits in trunk/WebCore

Putting my table patch back in. Also optimizing the code
to avoid deleting and recreating the same colinfo over
and over again. Now colinfos can recalc their own
information.

• khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::recalcColInfo): (RenderTable::addColInfo): (RenderTable::calcMinMaxWidth):
• khtml/rendering/render_table.h:

3:38 PM Changeset in webkit [1701] by rjw

• 4 edits in trunk/WebCore

Inline critical function.

• kwq/KWQString.mm: (compareToLatinCharacter):

2:03 PM Changeset in webkit [1700] by rjw

• 3 edits in trunk/WebKit

i Remove annoying log, it's really annoying. Added FIX ME

comment instead.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):

12:05 PM Changeset in webkit [1699] by rjw

• 4 edits in trunk/WebCore

Wow! Avoid creation of unicode string when only a single character
is needed. Simple change for big gains, 7% - 10% improvement
on cached pages. Other similar gains may remain to be had.

• khtml/css/cssparser.cpp:

12:04 PM Changeset in webkit [1698] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3012083 "Looked for URLs on the pasteboard, but found none" spam dragging nil-target bookmark

• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]): This method was getting data for types on the pasteboard without first checking whether the types were on the pasteboard, a no-no. Restructured this method and tweaked it here and there also.

(-[NSView _web_dragOperationForDraggingInfo:]): moved a fast
test in front of a slow test

WebBrowser:

• fixed 3011887 -- dropping favorite on a favorites folder makes copy but should move

• FavoriteButton.m: (-[FavoriteButton determineDragOperation:]): New helper routine to decide between move & copy based on drag source and option key state. (-[FavoriteButton draggingEntered:]), (-[FavoriteButton draggingUpdated:]): use determineDragOperation.

• ToolbarButtonItem.m: (+[ToolbarButtonItem itemWithIdentifier:button:action:]): tweaked this while investigating some other bug.

11:04 AM Changeset in webkit [1697] by darin

• 4 edits in trunk/WebCore

• khtml/css/makevalues: Fail if we don't find gperf.

3:00 AM Changeset in webkit [1696] by hyatt

• 4 edits in trunk/WebCore

Back myself out. I seem to have stumbled onto another bug.
Until I figure it out, turn this back off.

• khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):

1:51 AM Changeset in webkit [1695] by hyatt

• 4 edits in trunk/WebCore

Fix for 3000604, 2902173, 2921313. Ensure that tables recalc their
column widths like they are supposed to. This fixes livepage.apple.com,
applemuseum.com, and many other pages (that didn't have bugs filed).
Yay!

• khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):

Jul 29, 2002:

6:15 PM Changeset in webkit [1694] by rjw

• 6 edits in trunk/WebKit

Removed setDirectsAllLinksToSystemBrowser: method, not needed
and antiquated by the policy APIs.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m:

6:12 PM Changeset in webkit [1693] by hyatt

• 6 edits in trunk/WebCore

Fix for 3008660, arstechnica regression. Move the acquisition
of the document's text color (and the addition of CSS properties)
to the attach() call instead of the constructor. The table won't
add the properties until it is building its render object.

Also removing the #ifndef around the layout scheduler. This fixes
:hover feedback and reflows from things like the marquee on
livepage.apple.com.

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::id): (HTMLTableElementImpl::attach):
• khtml/html/html_tableimpl.h:
• khtml/rendering/render_object.h:

6:08 PM Changeset in webkit [1692] by rjw

• 15 edits in trunk/WebKit

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (+[WebHistoryItem entryWithURL:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): (-[WebController setUseBackForwardList:]): (-[WebController useBackForwardList]): (-[WebController goBack]): (-[WebController goForward]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setProvisionalDataSource:]): (-[WebFrame _goToURL:withFrameLoadType:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _goBack]): (-[WebView _goForward]):

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

• History.subproj/WebHistoryItem.h:
• BackForwardListEntry.h: Removed.
• BackForwardListEntry.m: Removed.
• BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):
• BrowserWebController.m:
• LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]):
• WebBrowser.pbproj/project.pbxproj:

1:54 PM Changeset in webkit [1691] by darin

• 23 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.cpp: (operator<<):
• Tests/qt/qregexp-test.cpp: (operator<<):
• Tests/qt/qstring-test.cpp: (operator<<):
• Tests/qt/qstringlist-test.cpp: (operator<<): Added output streaming so the tests work even without the implicit conversion of QString to const char *.

WebCore:

• fixed 3010875 -- Find only works for latin characters
• dealt with part of 2948387 -- stop button flashes to "go" twice while loading citibank.com

• force-clean-timestamp: Make everyone do a make clean because dependencies won't do the right thing.

• khtml/khtml_part.h:
• khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Changed the APPLE_CHANGES ifdefs around in this function so we can start using it again. (KHTMLPart::jumpToSelection): Removed. The bridge goes straight to the impl.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]): Go straight to the impl.

• WebCore-tests.exp: One new export needed for tests with change to qstring.h.

• kwq/qt/qevent.h:
• kwq/KWQEvent.mm: Removed unused stuff.

• kwq/KWQKHTMLPartImpl.h: Removed redirectURL(); we now use KHTMLPart::slotRedirect().

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Call latin1() explicitly in here for m_documentSource. It was being done implicitly before. (KWQKHTMLPartImpl::scheduleRedirection): Get rid of 1-second minimum delay for meta refresh. (KWQKHTMLPartImpl::timerEvent): Call KHTMLPart::slotRedirect() instead of redirectURL(), because they were identical, so we don't need our own copy.

• kwq/kdeui/kmessagebox.h:
• kwq/KWQKMessageBox.mm: (KMessageBox::questionYesNo): Added dontAskAgain string parameter. Before, it was being turned into a bool!

• kwq/KWQKProtocolManager.mm: Tweak and add FIXME.

• kwq/qt/qstring.h: Remove implicit conversion to const char *, which causes only pain.
• kwq/KWQString.mm: (QString::find): Add caseSensitive parameter to the QString overload of this. (QString::contains): Add a QString version of this.

• kwq/character-sets.txt: Add the MIB number for ISO-10646-J-1.
• kwq/make-charset-table.pl: Remove special case for ISO-10646-J-1 MIB number.

1:38 PM Changeset in webkit [1690] by rjw

• 14 edits in trunk

Fixed 3009074. Added [WebHTMLView jumpToSelection:] and related user interface
item validation.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):

Fixed 3009074. Added KHTMLPart::jumpToSelection and related scaffolding (part impl, bridge, etc.)

• khtml/khtml_part.cpp: (KHTMLPart::jumpToSelection):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::jumpToSelection):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]):

12:35 PM Changeset in webkit [1689] by rjw

• 4 edits in trunk/WebKit

Fixed 3009085. Implemented takeFindStringFromSelection: on WebHTMLView and WebTextView.
Also added user interface item validation for that method.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView hasSelection]): (-[WebHTMLView takeFindStringFromSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):
• WebView.subproj/WebTextView.m: (-[WebTextView canTakeFindStringFromSelection]): (-[WebTextView takeFindStringFromSelection:]):

11:55 AM Changeset in webkit [1688] by rjw

• 4 edits in trunk/WebCore

Fixed 3009067. We were not correctly testing the first character of the node string. Fixed in KWQString.
This highlighted another problem. KWQ does not support unichar * string find w/ case sensitive argument.
KWQString implements QString::find(const char *chs, int index, bool caseSensitive), so QStrings passed
will be auto-cast to char *. Filed 3010875 to track that issue.

• kwq/KWQString.mm: (compareToLatinCharacter): (QString::find):

8:19 AM Changeset in webkit [1687] by cblu

• 3 edits in trunk/WebKit

WebKit:

Fixed:
2971845 - text view uses default "user font" (Helvetica), not fonts chosen in Alexander preferences

• WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): add observer (-[WebTextView dealloc]): remove observer (-[WebTextView setFixedWidthFont]): added, checks defaults (-[WebTextView dataSourceUpdated:]): calls setFixedWidthFont (-[WebTextView searchFor:direction:caseSensitive:]): no changes (-[WebTextView defaultsChanged:]): calls setFixedWidthFont

WebBrowser:

Fixed:
3006975 - Typing in address field should replace favicon with generic
3009771 - Bookmark title for dragged icon from location field is sometimes incorrect
3009755 - Dragged icon from location field needs to include title

• BrowserWindowController.m: (-[BrowserWindowController bookmarkTitleForLocationField:]): use pageName
• FavoriteButton.h:
• FavoriteButton.m: (-[FavoriteButton imageForDraggingFromEvent:]): made public (-[FavoriteButton mouseDown:]): use imageForDraggingFromEvent
• LocationTextField.h:
• LocationTextField.m: (-[LocationTextField dealloc]): release cached icon and string (-[LocationTextField _setIcon:save:]): added, caches icon (-[LocationTextField setIcon:]): calls _setIcon:save: (-[LocationTextField mouseDown:]): calls imageForDraggingFromEvent (-[LocationTextField setStringValue:]): caches string (-[LocationTextField textDidChange:]): sets generic icon

Jul 27, 2002:

9:14 AM Changeset in webkit [1686] by cblu

• 19 edits in trunk/WebKit

WebKit:

Implemented click policy, support for option-click
Implemented dragging of links and images from WebHTMLView

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): added, moved from WebBrowser (-[NSView _web_dragOperationForDraggingInfo:]): don't accept drag if source == destination
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicy URL]): needed for click policy (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:toPath:]): added, simply downloads a URL
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): calls [WebController _downloadURL:toPath:]
• WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): calls _continueAfterCheckingDragForEvent (-[WebHTMLView mouseUp:]): calls _continueAfterClickPolicyForEvent (-[WebHTMLView draggingSourceOperationMaskForLocal:]): added (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): added, starts download
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterClickPolicyForEvent:]): added, implements click policy (-[WebHTMLView _continueAfterCheckingDragForEvent:]): added, checks if mouse event is a drag

WebBrowser:

Support for option-click.
Moved _web_dragShouldBeginFromMouseDown:withExpiration: to WebKit

• BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]): support for option and command click
• FavoriteButton.m: (-[FavoriteButton mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:
• LocationTextField.m: (-[LocationTextField mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:

Jul 26, 2002:

6:37 PM Changeset in webkit [1685] by hyatt

• 4 edits in trunk/WebCore

WebFoundation:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

As per discussion with gramps, simply removing the plist lookup
for the agent and hardcoding it to Gecko for now.

• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler defaultUserAgent]):
• ChangeLog:
• Defaults.plist:

WebCore:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

• ChangeLog:
• kwq/KWQKProtocolManager.mm: (KProtocolManager::userAgentForHost):

4:18 PM Changeset in webkit [1684] by rjw

• 2 edits in trunk/WebKit

Fixed comment in changelog.

4:18 PM Changeset in webkit [1683] by rjw

• 3 edits in trunk/WebKit

WebframeLoadType enum first value was explicitly set, so 0 was used.
I assumed 0 was unitialized, and depended on that to not execute some 'transitional'
back/forward. This problem broke back/forward.

• WebView.subproj/WebFramePrivate.h:

3:27 PM Changeset in webkit [1682] by hyatt

• 4 edits in trunk/WebCore

Fix for 2944382, NOWRAP was being incorrectly applied in KHTML.
It was being ignored incorrectly if a fixed width was specified
on a cell. This width on the cell is actually irrelevant and
should not have been checked, since NOWRAP will affect the
whole column and not just a specific cell.

• khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):

3:17 PM Changeset in webkit [1681] by sullivan

• 8 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

• WebView.subproj/WebController.h:
• added goForward to windowContext protocol. This is temporary, just like goBack here is temporary; they can be migrated into the new back-forward-in-WebKit design together.
• WebView.subproj/WebView.m: (-[WebView keyDown:]): call _goBack and _goForward for command-arrow keys

• WebView.subproj/WebViewPrivate.h,
• WebView.subproj/WebViewPrivate.m: (-[WebView _goForward]): add _goForward, parallel to _existing goBack.

WebBrowser:

WebBrowser part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

• fixed 3009385 -- standard command-arrow shortcuts don't work in Alexander outline views
• fixed 3009388 -- left and right arrow should collapse/expand in Alexander outline views

• BrowserWebController.m: (-[BrowserWebController goForward]): Added, parallel to existing goBack. This is a temporary place for this API, awaiting WebKit cleanup.

• Defaults.plist: Set NSAllowSimpleArrowItemExpandDefault to true; gotta love that this exists.

• English.lproj/MainMenu.nib: Change menu shortcuts for Back, Forward, and Last Search Results to use brackets instead of arrows

• Help/KeyShortcuts.html: Update to match arrow -> bracket changes.

12:59 PM Changeset in webkit [1680] by cblu

• 6 edits in trunk/WebKit

Fixed crash in unknown_text
Fixed full-window plug-ins. I think darin broken this :)
Cleaned up WebPluginStream a bit

• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
• Plugins.subproj/WebPluginStream.m: (-[WebPluginStream getFunctionPointersFromPluginView:]): (-[WebPluginStream initWithURL:pluginPointer:notifyData:attributes:]): (-[WebPluginStream startLoad]): (-[WebPluginStream stop]): (-[WebPluginStream setUpGlobalsWithHandle:]): (-[WebPluginStream receivedError:]): (-[WebPluginStream receivedData:withDataSource:]): (-[WebPluginStream receivedError:withDataSource:]): (-[WebPluginStream WebResourceHandle:dataDidBecomeAvailable:]): (-[WebPluginStream WebResourceHandleDidCancelLoading:]): (-[WebPluginStream WebResourceHandle:didFailLoadingWithResult:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainHandle]): added, WebPluginStream needs this

Jul 25, 2002:

8:44 PM Changeset in webkit [1679] by rjw

• 9 edits in trunk/WebKit

More incremental changes for back/forward migration.

• BackForwardListEntry.h:
• BackForwardListEntry.m:

More incremental changes for back/forward migration.

• History.subproj/WebBackForwardList.h:
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList addEntry:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goBackToIndex:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList currentEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goForwardToIndex:]): (-[WebBackForwardList canGoBack]): (-[WebBackForwardList canGoForward]): (-[WebBackForwardList description]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem target]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]):
• History.subproj/WebHistoryList.m:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setLoadType:]): (-[WebFrame _setLoadType:]): (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted]):

7:26 PM Changeset in webkit [1678] by cblu

• 12 edits
  4 adds in trunk/WebKit

Made some WebPolicy API's private
Added support for download link/image to disk

• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]):
• WebView.subproj/WebControllerPolicyHandlerPrivate.h: Added.
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

6:14 PM Changeset in webkit [1677] by cblu

• 9 edits in trunk/WebKit

Fixed crasher caused by not retaining the content policy.

• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

5:56 PM Changeset in webkit [1676] by cblu

• 23 edits
  1 add in trunk/WebKit

WebKit:

Made policy APIs return a WebPolicy object.
Added click policy.

• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (+[WebController defaultURLPolicyForURL:]):
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPolicyHandler.m: Added. (-[WebPolicy initWithPolicyAction:]): (-[WebPolicy policyAction]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (-[WebContentPolicy initWithContentPolicyAction:andPath:]): (-[WebContentPolicy dealloc]): (-[WebContentPolicy path]): (-[WebClickPolicy initWithClickPolicyAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]): (-[WebClickPolicy dealloc]): (-[WebClickPolicy path]):
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource contentPolicy]): (-[WebDataSource fileType]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setContentPolicy:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _isReadyForData]):
• WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementFileURLPolicy:error:forDataSource:]): (-[WebDefaultPolicyHandler unableToImplementURLPolicy:error:forURL:]): (-[WebDefaultPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]): (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

WebBrowser:

Made policy APIs return a WebPolicy object.

• BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]):
• BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:]): (-[BrowserWebController unableToImplementURLPolicy:error:forURL:]): (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[BrowserWebController unableToImplementFileURLPolicy:error:forDataSource:]): (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): (-[BrowserWebController unableToImplementContentPolicy:error:forDataSource:]): (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]):
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithResource:progress:error:dataSource:]):

5:17 PM Changeset in webkit [1675] by darin

• 3 edits in trunk/WebCore

Remove bogus change log entry that I checked in by accident.

5:04 PM Changeset in webkit [1674] by darin

• 19 edits in trunk

top level:

• configure.in: Add DeploymentFat build style.

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Add DeploymentFat build style.

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Add DeploymentFat build style.

WebCore:

• WebCore.pbproj/project.pbxproj: Add DeploymentFat build style.

• fixed 3007532 -- Main documentation frame doesn't load on Apple docs page

This was caused by my recent fix for the "checkboxes in wrong place" bug.
While discussing that bug fix with Richard, I realized that I needed to do the
work at layout time, not print time. Luckily, this code ends up being simpler
than the original solution.

• khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): Take out size limits based on X limits. (RenderWidget::layout): Move widgets off into far away coordinate space when layout happens. They get moved back on to the right position during the print process.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: Removed paint, buildViewsNotYetAddedSet, viewsNotYetAdded, and addedWidget.
• kwq/KWQScrollView.mm: (QScrollView::addChild): Removed call to addedWidget.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Put the call to the renderer to print back in here, since it's simple again.

• kwq/KWQWidget.mm: (QWidget::internalSetGeometry): Left in a couple of asserts that were useful in narrowing this one down.

WebKit:

• WebKit.pbproj/project.pbxproj: Add DeploymentFat build style.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Add DeploymentFat build style.

3:53 PM Changeset in webkit [1673] by hyatt

• 4 edits in trunk/WebCore

Floated images using "align" should have margins to prevent the text from running right
up against them. Matches IE and Mozilla behavior.

• khtml/css/html4.css:

3:36 PM Changeset in webkit [1672] by hyatt

• 4 edits in trunk/WebCore

Fix <blockquote> tags to have top and bottom margins of 1em. This matches the <blockquote>
behavior in Gecko.

• khtml/css/html4.css:

3:17 PM Changeset in webkit [1671] by darin

• 23 edits in trunk

WebFoundation:

WebFoundation part of fix for 3006054 -- assert error failingURL != nil

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): Call absoluteString. (IFErrorGetFailingURL): Change result type to CFStringRef.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): Call absoluteString.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:isTerminal:]): Call absoluteString.
• Misc.subproj/WebError.h:
• Misc.subproj/WebError.m: (+[WebError errorWithCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError failingURL]): Change type to NSString. (-[WebError description]): Don't call absoluteString.

WebCore:

• fixed 2965269 -- sizes reported to progress handler from KWQCheckCacheObjectStatus for images are wrong
• fixed 3006054 -- assert error failingURL != nil

• khtml/misc/loader.h: Add dataSize() and m_dataSize.
• khtml/misc/loader.cpp: (CachedImage::CachedImage): Initialize m_dataSize. (CachedImage::data): Update m_dataSize.

• kwq/kio/jobclasses.h:
• kwq/KWQKjobclasses.mm: Store a KURL instead of an NSURL, because KURL can hold any string.

• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Send an error with [WebCoreBridge reportError:] if the URL is so bad we can't construct an NSURL from it. This is the only case in all our code where we need to have failingURL accept a string. (KWQCheckCacheObjectStatus): If the object is an image, use the dataSize() rather than size(). The size() is a (bad) estimate of how much memory is used in the case of an image, but we want to report the size of the original data.

• kwq/WebCoreBridge.h: Add a [reportError:] method.

WebKit:

WebKit part of fix for 3006054 -- assert error failingURL != nil

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]): New. Passes the error to the controller associated with the dataSource.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Call absoluteString. (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.
• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Call absoluteString.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]): Call absoluteString.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.

WebBrowser:

WebBrowser part of fix for 3006054 -- assert error failingURL != nil

• BrowserWebController.m: (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
• DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): Call absoluteString.
• LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Don't call absoluteString. Also use _web_URLWithString to make a URL to parse out the host part. (-[LocationChangeHandler genericMessageForError:]): Don't call absoluteString.

3:11 PM Changeset in webkit [1670] by hyatt

• 4 edits in trunk/WebCore

Fix for huge white space problem on appleturns.com, bug 2947818. Vertical-align
was being applied to block-level elts in violation of the CSS2 spec. Vertical-align
is only supposed to apply to inline-level elts and table cells. getVerticalPosition
will now bail if the element is block-level.

• khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):

12:50 PM Changeset in webkit [1669] by cblu

• 4 edits in trunk/WebKit

WebKit:

Remove reloadImage until its implemented.

• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

WebBrowser:

Remove reloadImage until its implemented.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

12:38 PM Changeset in webkit [1668] by cblu

• 15 edits in trunk

WebCore:

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): renamed

WebKit:

Renamed elementInfoAtPoint to elementAtPoint

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (+[WebDefaultContextMenuHandler addMenuItemWithTitle:action:target:toArray:]): renamed (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Added WebBrowser specific contextual menu items.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument setSaveDataSource:]): set the current data source to save (-[BrowserDocument dataRepresentationOfType:]): uses the current data source
• ContextMenuHandler.h: Added.
• ContextMenuHandler.m: Added. (-[ContextMenuHandler dealloc]): (-[ContextMenuHandler _addMenuItemWithAction:fromArray:toArray:]): (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler _document]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]):
• WebBrowser.pbproj/project.pbxproj:

12:41 AM Changeset in webkit [1667] by hyatt

• 5 edits in trunk/WebCore

Fix for bug 2992158, the calendar on www.blog.org in the upper
right was shoved offscreen (and causing a horizontal scrollbar
to be necessary). KHTML was not recomputing the margins for
the table when it became displaced by the float. It was also
mispositioning the float itself.

• khtml/rendering/render_box.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addOverHangingFloats):

Jul 24, 2002:

6:38 PM Changeset in webkit [1666] by cblu

• 4 edits in trunk/WebKit

tiny change

• WebView.subproj/WebDefaultContextMenuHandler.m:

6:34 PM Changeset in webkit [1665] by cblu

• 9 edits in trunk/WebKit

Added implmentations for a few context menu items.

• WebView.subproj/WebController.h:
• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler validateUserInterfaceItem:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler reloadImage:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

4:11 PM Changeset in webkit [1664] by rjw

• 4 edits in trunk/WebKit

Removed vestigal locationChangeHandler ivar.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):

3:59 PM Changeset in webkit [1663] by hyatt

• 4 edits in trunk/WebCore

Fix for bug 2953423, viamichelin.com lays out incorrectly.
Remove a completely bogus optimization in the KHTML code that
attempted to bail when the specified width was 0. This was
a very basic problem, and it should fix other pages that were
laying out incorrectly as well.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout):

3:54 PM Changeset in webkit [1662] by cblu

• 3 edits in trunk/WebKit

Call [self _locationChangeHandler] instead of _private-locationChangeHandler

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource receivedPageIcon:]):

3:41 PM Changeset in webkit [1661] by rjw

• 3 edits in trunk/WebKit

Implemented find for text views.

3:36 PM Changeset in webkit [1660] by cblu

• 7 edits in trunk/WebKit

Implemented initial contextual menus. All disabled right now.

• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): added (-[WebDefaultContextMenuHandler addMenuItemWithTitle:action:toArray:]): added (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): create menu items
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

2:22 PM Changeset in webkit [1659] by darin

• 4 edits in trunk/WebCore

• khtml/khtml_part.cpp: (KHTMLPart::clear): Remove code that reset m_frameNameId, to complete Maciej's change to fix bug 3006354.

2:14 PM Changeset in webkit [1658] by cblu

• 8 edits in trunk/WebKit

More renaming for WebDefaultPolicyHandler.

• WebView.subproj/WebController.m: (-[WebController policyHandler]):
• WebView.subproj/WebDefaultPolicyHandler.h:
• WebView.subproj/WebDefaultPolicyHandler.m:

2:07 PM Changeset in webkit [1657] by cblu

• 3 edits
  4 adds
  2 deletes in trunk/WebKit

Renamed WebDefaultControllerPolicyHandler to WebDefaultPolicyHandler.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultControllerPolicyHandler.h: Removed.
• WebView.subproj/WebDefaultControllerPolicyHandler.m: Removed.
• WebView.subproj/WebDefaultPolicyHandler.h: Added.
• WebView.subproj/WebDefaultPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):

1:55 PM Changeset in webkit [1656] by cblu

• 14 edits
  4 adds in trunk/WebKit

More plumbing for contextual menu support.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setContextMenuHandler:]): added (-[WebController contextMenuHandler]): added
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): alloc WebDefaultContextMenuHandler (-[WebControllerPrivate dealloc]): dealloc WebDefaultContextMenuHandler (-[WebController _defaultContextMenuHandler]):
• WebView.subproj/WebDefaultContextMenuHandler.h: Added.
• WebView.subproj/WebDefaultContextMenuHandler.m: Added. (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): new
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): call contextMenuHandlers
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setController:]): added comment (-[WebHTMLView _controller]): added

1:37 PM Changeset in webkit [1655] by darin

• 25 edits in trunk

top level:

• Site/Internal/Quality/fontsizes.html: Added test cases for "+/-" and "0".

WebCore:

• fixed 2906567 -- Font size calculations should use 96 dpi instead of 72 dpi
• fixed 3005932 -- fonts specified in 'ex' units rendered waaaaaaay too large

• khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Use a default font size that's the same as small, rather than a "medium font size". Don't multiply the values from settings by the scaling factor. (CSSStyleSelector::applyRule): Make the default font size here for nodes with no parents be small (m_fontSizes[2]) rather than medium (m_fontSizes[3]).

• khtml/html/html_inlineimpl.cpp: (parseFontSizeNumber): Added. Tolerant of non-numeric characters after the numeric size. Also distinguishes a size like "0" from something that's not a numeric size at all. (HTMLFontElementImpl::parseAttribute): Use parseFontSizeNumber, but also make size 3 be the same as CSS_VAL_SMALL, not CSS_VAL_MEDIUM. This mistake (using CSS_VAL_MEDIUM) led to all kinds of strangeness in the KHTML code, including mishandling of 0 and the need to create CSS_VALKONQ_XXX_LARGE. Also change code so that 0 is treated as CSS_VAL_SMALL (same as 3) rather than CSS_VAL_XX_SMALL. This makes 0 between -1 and +1.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Make default font size be small (fontSizes()[2]) rather than medium (fontSizes()[3]).
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): Make default font size be CSS_VAL_SMALL, not CSS_VAL_MEDIUM.

• kwq/qt/qfontmetrics.h:
• kwq/KWQFontMetrics.mm: (QFontMetrics::xHeight): Added.
• kwq/WebCoreTextRenderer.h: Added xHeight.

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat): Use xHeight rather than computing the height of an actual letter 'x'.
• khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition): Use xHeight rather than computing the height of an actual letter 'x'.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]): Fixed backwards if that prevented font changes from being reflected in the browser window.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::defaultFontSize):
• kwq/WebCoreSettings.h:
• kwq/WebCoreSettings.m: (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings defaultFontSize]): Replace mediumFontSize with defaultFontSize.

• WebCore.pbproj/project.pbxproj: Rearrange some of the files.

WebKit:

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Added. Calls [NSFont xHeight].

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): Renamed minimumFont to defaultFont, and changed it from 11 to 16. Also changed default monospaced font to Courier instead of Monaco.

WebBrowser:

• Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Change to use new WebPreferences mediumFontSize (since default is the same as small, not medium).

• BrowserDocument.m: (-[BrowserDocument reapplyStyles:]): Use setNeedsDisplay: instead of display. It's impolite and unnecessary to do an explicit display.

• WebBrowser.pbproj/project.pbxproj: Small name tweak.

1:14 PM Changeset in webkit [1654] by rjw

• 12 edits in trunk

Support for find in HTML, find in text view coming soon.

• WebView.subproj/WebDocument.h:
• WebView.subproj/WebHTMLView.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:]):
• WebView.subproj/WebTextView.h:
• WebView.subproj/WebTextView.m: (-[WebTextView searchFor:direction:caseSensitive:]):

Support for find in HTML.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:]):

10:31 AM Changeset in webkit [1653] by darin

• 19 edits in trunk/WebCore

• fixed 2949235 -- checkboxes in wrong place until you scroll away and back

The problem here was that we put views in when we print, but we never removed them.
I added code to keep track of existing views, and remove them if they are not re-added.

• kwq/KWQKHTMLPartImpl.h: Add paint, addedWidget, buildViewsNotAddedSet, and viewsNotYetAdded. It might be nice to find a different place to hang this that is not included by the KHTML code. But I think that having this on the bridge would be worse.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::paint): Added. Removes any views that are not explicitly added by RenderWidget during the print process. (KWQKHTMLPartImpl::addedWidget): Added. Called by KWQScrollView to tell us a view was added. (KWQKHTMLPartImpl::buildViewsNotYetAddedSet): Added. Used to build the initial set of views.

• kwq/KWQScrollView.mm: (QScrollView::addChild): Added call to KWQKHTMLPartImpl::addedWidget.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Calls KWQKHTMLPartImpl::paint.

• kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry), (KWQWindowWidget::mapToGlobal), (KWQWindowWidget::mapFromGlobal), (KWQWindowWidget::internalSetGeometry): Fixed logic to work properly for windows not on main screen.

• khtml/khtml_part.cpp: Moved the boundary of an existing ifndef APPLE_CHANGES so that KHTMLPart::show() and hide() are not compiled, mainly for clarity.
• khtml/rendering/render_replaced.cpp: (RenderWidget::detach): Removed unneeded APPLE_CHANGES.

• kwq/KWQWindowWidget.h: Removed some unneeded virtual functions.
• kwq/qt/qscrollview.h: Removed some unneeded virtual functions, made others non-virtual.
• kwq/qt/qwidget.h: Removed some unneeded virtual functions, made others non-virtual.
• kwq/KWQWidget.mm: Removed a lot of unused and unneeded stuff.

• force-clean-timestamp: Needed to do this because I changed header files.

8:26 AM Changeset in webkit [1652] by darin

• 4 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.cpp: (main): Added a test case for a relative URL with a leading space in it.
• Tests/kde/kurl-test.chk: Added the expected result.

WebCore:

• fixed 3006329 - space should be stripped from beginning of relative url

• kwq/KWQKURL.mm: (KURL::normalizeRelativeURLString): Added a call to stripWhiteSpace.

2:37 AM Changeset in webkit [1651] by mjs

• 5 edits in trunk/WebCore

Made frame names globally unique, not just unique per parent frame

• this is needed to avoid triggering the assertion in 3006354 (Assertion failure on salon.com). Clearing my cache made the assertion go away by itself, but it seems good to avoid the possibility of triggering it in the future.

• khtml/khtmlpart_p.h: Make m_partNameId static.
• khtml/khtml_part.cpp: Initialize it here.

12:19 AM Changeset in webkit [1650] by darin

• 5 edits in trunk/WebCore

• 3006336 -- crash in _NSDescriptionWithLocaleFunc

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Don't use the result of getNSString() on a C++ temporary object. We could also fix this by doing retain autorelease in getNSString().

Jul 23, 2002:

11:58 PM Changeset in webkit [1649] by cblu

• 14 edits in trunk

WebCore:

More plumbing for contextual menu support.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): renamed (-[WebCoreBridge elementInfoAtPoint:]): renamed
• kwq/qt/qpixmap.h: added an accessor to the WebCoreImageRenderer

WebKit:

More plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementInfoAtPoint:]): added

9:01 PM Changeset in webkit [1648] by darin

• 10 edits in trunk

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebCore:

• WebCore.pbproj/project.pbxproj: Fix file reference types to be more consistent.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag): Changed indenting to use spaces, makes our diff with KDE smaller. (HTMLTokenizer::end): Remove unneeded APPLE_CHANGES.

• kwq/KWQDOMNode.cpp: Tweak.
• kwq/KWQDOMNode.h: Tweak.

WebKit:

• WebKit.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Fix file reference types to be more consistent.

7:46 PM Changeset in webkit [1647] by hyatt

• 4 edits in trunk/WebCore

Fix bug 2803155 - images not displayed on ​http://bscw.gmd.de.
My fix is to use our newfound quirks mode to implement a comment
parsing quirk (this is how Mozilla handles this same issue).
Only in quirks mode, the tokenizer will treat <!--> atomically as
a complete comment.

This is bug 34302 on bugs.kde.org, for those who are curious.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

6:33 PM Changeset in webkit [1646] by cblu

• 13 edits
  2 adds in trunk

WebCore:

Initial plumbing for contextual menu support.

• WebCore.pbproj/project.pbxproj:
• kwq/KWQDOMNode.cpp: Added. (isImage):
• kwq/KWQDOMNode.h: Added.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _URLForDOMString:]): added (-[WebCoreBridge _elementInfoForMouseEvent:]): added

WebKit:

Initial plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge elementInfoForMouseEvent:]): added
• WebView.subproj/WebController.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): added

6:22 PM Changeset in webkit [1645] by rjw

• 4 edits in trunk/WebCore

Turn on find related code in part in preparation for
implementing find in WebKit.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext):

5:55 PM Changeset in webkit [1644] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Fix paths for newly added files.

5:53 PM Changeset in webkit [1643] by hyatt

• 6 edits in trunk/WebCore

Fixing two bugs here. The first is bug with @import sheets not inheriting strict parsing mode from their parent sheet.
This means all @import sheets are being treated as strict mode!

The second bug is in KWQ. We were never calling determineParseMode, so we always defaulted to strict mode, and therefore
were highly intolerant of unitless numbers on absolutely positioned blocks. This fixes many problems, notably www.netscape.com
and ZDNet.com on the cvs-base tests.

• khtml/css/cssparser.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write):

5:19 PM Changeset in webkit [1642] by rjw

• 16 edits
  2 adds in trunk/WebKit

Use one LocationChangeHandler.
Cleaned up (a little) fallback URL code. This code
is still a convoluted and could be further untaggled.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument tryMultipleURLs:]): (-[BrowserDocument _goToNextFallbackURL]):
• BrowserDocumentPrivate.h:
• BrowserWebController.h:
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadRedirected:]): (-[BrowserWindowController frameLoadTryingFallback]):
• LocationChangeHandler.h:
• LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): (-[LocationChangeHandler dealloc]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]):

Cleaned up LocationChangeHandler. We now have one per controller.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController policyHandler]): (-[WebController setLocationChangeHandler:]): (-[WebController locationChangeHandler]):
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):

(-[WebDataSource _setIsDummy:)
(-[WebDataSource _isDummy]):
Hack on hack. MJS will remove when the dummy data source hack is removed.

(-[WebDataSource _locationChangeHandler]):
(-[WebDataSource _removeFromFrame]):
(-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
(-[WebFrame setProvisionalDataSource:]):

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]):

Added default policy handler. This is used if no policy handler is
set on the controller.

• WebView.subproj/WebDefaultControllerPolicyHandler.h: Added.
• WebView.subproj/WebDefaultControllerPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
• WebView.subproj/WebFrame.m:

4:24 PM Changeset in webkit [1641] by darin

• 4 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.chk: Updated test results to match what real web browsers need to do rather than what the RFC says for paths beginning with "../" or "./".
• Tests/kde/kurl-test.cpp: (main): Add comments for tests where the results are not matching the RFC.

WebCore:

• fixed 3004818 -- relative urls are assembled incorrectly at ticketmaster
• fixed 2999279 -- Invalid URI in request at subpage of swatch.com

The issue here is URLs with paths that start with "/../". RFC 2396 says one
thing, and that's what CFURL does. But real web browsers do another thing.

• kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate): Clean up a bit by removing unneeded init(). (escapeQString): Don't make a copy of the passed-in QString. (pathEndsWithSlash): Don't make a copy of the passed-in QString. (copyEscapedPath): Make this a static function instead of extern. (KURL::KWQKURLPrivate::decompose): Add the new "../" and "./" logic.

4:09 PM Changeset in webkit [1640] by hyatt

• 5 edits in trunk/WebCore

• khtml/rendering/font.cpp: Fix deployment build bustage by including <algorithm>.

• khtml/rendering/render_frames.cpp: (RenderPartObject::calcReplacedWidth): Fix a bug with ​http://www.moveabletype.com's top portion not showing up (bug 2986714). A hack was being improperly applied to fixed width plugins, when it should have only been applied to variable width plugins.

11:48 AM Changeset in webkit [1639] by darin

• 7 edits in trunk

WebCore:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

WebKit:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

11:45 AM Changeset in webkit [1638] by darin

• 33 edits
  1 add in trunk

top level:

• Tests/kde/kurl-test.cpp: (main): Add a lot of new tests. One of them demonstrates the issue underlying bug 3004818. The others are taken straight from the URI RFC (2396).
• Tests/kde/kurl-test.chk: Expected results for new tests.

• autogen.sh: Add the new WebCore timestamp file.

WebCore:

Changes require a make clean because of the Project Builder bug.
So I added the "make clean timestamp" hackery.

• .cvsignore: Ignore the new clean timestamp.
• force-clean-timestamp: Added.
• Makefile.am: Add rules for making clean happen.

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Fix NULL dereference bug in here that I ran into. Code later down in the same function has the check for NULL, so clearly this is just a bug.

• khtml/rendering/font.cpp: (Font::drawText): Simplify by using new drawText that takes a QChar array, no need to make a QConstString.
• khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Simplify by using new drawUnderlineForText that takes a QChar array, no need to make a QConstString.

• kwq/WebCoreTextRenderer.h: Change underline-drawing to use a UniChar array.

• kwq/qt/qpainter.h:
• kwq/KWQPainter.mm: (QPainter::drawText): Change to take QChar array instead of a QString, but also discovered a bizarre overloading thing that was happening before and dealt with that by adding a new drawText that still does take a QString. (QPainter::drawUnderlineForText): Change to take QChar array.

• kwq/qt/qcolor.h: Mark constructor explicit, so we don't get subtle strangess like where the string to draw was being converted to a QColor.

• khtml/css/cssstyleselector.cpp: No need for APPLE_CHANGES for this change any more.

• kwq/kdecore/kcharsets.h:
• kwq/KWQKCharsets.mm: Remove unused functions.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: Remove unused functions.

• kwq/qt/qfont.h:
• kwq/KWQFont.mm: Simplify.

• kwq/KWQPaintDeviceMetrics.mm: Simplify.

• kwq/qt/qtextcodec.h:
• kwq/KWQtextcodec.mm: (QTextCodec::codecForName): Remove unused parameter.

WebKit:

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawUnderlineForCharacters:stringLength:atPoint:withColor:]): Change API to take character array instead of a string.

• WebKit.pbproj/project.pbxproj: Took "subproj" off the names of some groups.

10:54 AM Changeset in webkit [1637] by hyatt

• 5 edits in trunk/WebCore

The STYLE element was ignoring both the media and type
attributes (unlike its cousin, the LINK element). This
patch implements support for media and type and further
stops us from loading stylesheets that we should have no
business parsing.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLStyleElementImpl::parseAttribute): (HTMLStyleElementImpl::insertedIntoDocument): (HTMLStyleElementImpl::removedFromDocument): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):
• khtml/html/html_headimpl.h:

9:34 AM Changeset in webkit [1636]

• 3 copies in tags/Alexander-14

This commit was manufactured by cvs2svn to create tag 'Alexander-14'.

9:34 AM Changeset in webkit [1635] by sheridan

• 8 edits in trunk

Alex-14 versioning

12:34 AM Changeset in webkit [1634] by hyatt

• 4 edits in trunk/WebCore

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Oops. I accidentally removed the call to an ancestor class attach function. What made this subtle is that it deliberately skipped over a couple of base classes and called the one three superclasses up. When I went to put it back in, I messed up and called the base class instead of the distant ancestor.

Silly me. marvel.com and matadorrecords.com should be ok now.

Jul 22, 2002:

10:26 PM Changeset in webkit [1633] by darin

• 13 edits
  2 adds in trunk/WebCore

• khtml/rendering/render_text.cpp: (TextSlave::printSelection): Add comments to APPLE_CHANGES. (TextSlave::printDecoration): Add comments to APPLE_CHANGES. (TextSlave::checkSelectionPoint): Add comments to APPLE_CHANGES.

• khtml/xml/dom_stringimpl.cpp: Add comments to APPLE_CHANGES.

• khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::end): Remove APPLE_CHANGES.
• kwq/KWQsignals.mm: Add a new signal dummy function.

• kwq/WebCoreJavaScript.h: Fix header.
• kwq/WebCoreJavaScript.mm: Fix header.

• kwq/WebCoreSettings.h: Added. Not used yet.
• kwq/WebCoreSettings.m: Added. Not used yet.
• WebCore.pbproj/project.pbxproj: Added WebCoreSettings.h and .m.

• English.lproj/InfoPlist.strings: Fixed a spelling error.

• kwq/WebCoreTextRendererFactory.h: Tweak.

10:04 PM Changeset in webkit [1632] by mjs

• 6 edits in trunk/WebCore

Fixed Radar 3004897 - assert at mapquest

• khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::attach): Put back frame name uniqueness check. Lack of this check was causing duplicate frames to be left floating in space.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Add an assertion that no frame of the requested name already exists.

6:05 PM Changeset in webkit [1631] by hyatt

• 6 edits in trunk/WebCore

Fix for bug 3004889, plugin content on stylesheet pages not
showing up. The rendering tree needed to perform an update
when all children had arrived, and this was being handled by
the parser. With async rendering construction, I had to store
this in the content node instead, so it could do the update
once the render object was built at a later date.

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::attach):
• khtml/html/html_objectimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag):

3:30 PM Changeset in webkit [1630] by hyatt

• 11 edits in trunk/WebCore

This checkin adds support for querying the selected style set,
for querying the preferred style set, and for changing the
selected style set dynamically. With this checkin, a Web page
in Alexander now has the capability to present its own alternate
stylesheet UI in the page and to toggle between sets using script.

• khtml/dom/css_stylesheet.cpp: (DocumentStyle::preferredStylesheetSet): (DocumentStyle::setSelectedStylesheetSet): (DocumentStyle::selectedStylesheetSet):
• khtml/dom/css_stylesheet.h: Added new methods to the DocumentStyle interface as per Hixie's proposed spec.

• khtml/dom/dom_doc.cpp:
• khtml/dom/dom_doc.h:
• khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (DOMDocument::tryPut): (DOMDocument::putValue):
• khtml/ecma/kjs_dom.h: Implement the JS binding glue for the new properties.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): (DocumentImpl::preferredStylesheetSet): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector):
• khtml/xml/dom_docimpl.h: The implementation of the new properties. Also fixed a bug caused by the 3.02 merge in the stylesheet filtering code in recalcStyleSelector.

1:19 PM Changeset in webkit [1629] by rjw

• 10 edits in trunk/WebKit

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController backForwardList]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]):

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument goToURL:]): (-[BrowserDocument _backForwardList]): (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):

10:44 AM Changeset in webkit [1628] by cblu

• 3 edits in trunk/WebKit

WebKit:

Strip white space before and after URL string 2998696

• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]):

WebBrowser:

Added document icon.

• WebBrowser.pbproj/project.pbxproj:
• document.icns: Added.

7:59 AM Changeset in webkit [1627] by kocienda

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: import of removed WebFrame bridge header was left in, causing a build break.

7:01 AM Changeset in webkit [1626] by mjs

• 17 edits
  4 deletes in trunk

WebCore:

Merged WebCoreBridge and WebCoreFrameBridge.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::urlSelected): Use bridge, not frameBridge. (KWQKHTMLPartImpl::submitForm): Use bridge, not frameBridge. (KWQKHTMLPartImpl::findFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::frames): Use bridge, not frameBridge.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Free RenderPart if set. (-[WebCoreBridge renderPart]): Moved here from WebFrameBridge. (-[WebCoreBridge setRenderPart:]): Moved here from WebFrameBridge. (-[WebCoreBridge copyRenderNode:khtml::copier:]): No more need to get render part from frame bridge. (-[WebCoreBridge installInFrame:]): No more need to get render part from frame bridge.
• kwq/WebCoreFrameBridge.h: Removed.
• kwq/WebCoreFrameBridge.mm: Removed.
• WebCore.exp: Removed WebCoreFrameBridge.
• WebCore.pbproj/project.pbxproj: Removed WebCoreFrameBridge.

WebKit:

Merged WebBridge and WebFrameBridge.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Return bridges, not frameBridges. (-[WebBridge descendantFrameNamed:]): Return bridge, not frameBridge. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return a bridge, not a frameBridge. (-[WebBridge mainFrame]): Return a bridge, not a frameBridge. (-[WebBridge frameNamed:]):Return a bridge, not a frameBridge. (-[WebBridge loadURL:attributes:flags:withParent:]): Moved from WebFrameBridge. (-[WebBridge loadURL:]): Moved from WebFrameBridge. (-[WebBridge postWithURL:data:]): Moved from WebFrameBridge.
• WebCoreSupport.subproj/WebFrameBridge.h: Removed.
• WebCoreSupport.subproj/WebFrameBridge.m: Removed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Don't create a WebFrameBridge.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): No longer dealloc frameBridge, since we don't have one. (-[WebFrame _transitionToCommitted]): Pass along the frame's render part, if any. (-[WebFrame _frameBridge]): Removed.
• WebKit.pbproj/project.pbxproj: Removed deleted files.

4:45 AM Changeset in webkit [1625] by mjs

• 8 edits in trunk/WebKit

Change WebBridge to hold on to a WebFrame instead of a
WebDataSource. Since we will no longer ever have a bridge for a
provisional data source, we'll just bind the bridge to a
frame. Which means we can merge the bridge and the frame bridge
next.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: Changed below methods to work with direct knowledge of the frame but not the bridge (mostly a simplification). (-[WebBridge frame]): (-[WebBridge parent]): (-[WebBridge childFrames]): (-[WebBridge descendantFrameNamed:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge openNewWindowWithURL:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge mainFrame]): (-[WebBridge frameNamed:]): (-[WebBridge receivedData:withDataSource:]): (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge setFrame:]): (-[WebBridge dataSourceChanged]): (-[WebBridge dataSource]): (-[WebBridge openedByScript]): (-[WebBridge setOpenedByScript:]):

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Set bridge's frame and notify that the data source changed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Set bridge's frame.
• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _bridge]): Method to get the bridge.

1:32 AM Changeset in webkit [1624] by mjs

• 11 edits in trunk

WebCore:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• kwq/KWQScrollView.mm: Remove mention of provisional widget from comment.
• kwq/WebCoreFrameBridge.h: Remove commitedBridge method, and remove comment about provisionality from bridge method.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Remove bogus comment about provisional/committed transition. (KWQKHTMLPartImpl::findFrame): Call bridge, not committedBridge. (KWQKHTMLPartImpl::frames): Likewise.

WebKit:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge descendantFrameNamed:]): Don't bother with the provisional bridge - no such thing. (-[WebBridge setDataSource:]): Assert the data source is committed.
• WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge bridge]): Return committed bridge always, and remove committed bridge method.

Jul 21, 2002:

10:38 PM Changeset in webkit [1623] by darin

• 109 edits
  1 add in trunk

JavaScriptCore:

• kjs/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

WebCore:

• khtml/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

• WebCore.pbproj/project.pbxproj: Add KWQStyle.mm, remove KWQStyle.h, moving contents into qstyle.h.

• kwq/KWQApplication.mm: (QApplication::globalStrut): Remove _logNotYetImplemented().

• kwq/KWQButton.mm: (QButton::QButton): Use plain release, not autorelease.
• kwq/KWQComboBox.mm: (QComboBox::init): Use plain release, not autorelease.
• kwq/KWQListBox.mm: (QListBox::QListBox): Use plain release, not autorelease.
• kwq/KWQPainter.mm: (QPainter::drawArc): Use plain release, not autorelease.

• kwq/KWQKHTMLPartBrowserExtension.mm: Remove import of KWQKHTMLPartImpl.h, now that it's always part of khtml_part.h.
• kwq/KWQKHTMLPartImpl.cpp: Simplify.
• kwq/KWQKHTMLPartImpl.h: Add wrapper to allow multiple inclusion. Don't include khtml_part.h any more, since that file now includes this one to minimize changes to KDE code that needs to get to functions in here.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::onURL), (KHTMLPart::nodeActivated), (KHTMLPart::setStatusBarText): Moved here from khtml_part.cpp.
• kwq/KWQLoaderImpl.mm: Include khtml_part.h instead of KWQKHTMLPartImpl.h.

• kwq/KWQPushButton.mm: (buttonFontMetrics), (QPushButton::fontMetrics): Added. Used by the form code to size buttons.
• kwq/KWQStyle.mm: Added. (QStyle::sizeFromContents): Added. Used by the form code to size buttons.

• kwq/KWQStyle.h: Removed.
• kwq/qt/qstyle.h: Moved contents of KWQStyle.h in here.
• kwq/qt/qwidget.h: Include <qstyle.h> rather than KWQStyle.h.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]): Call straight to impl.

• kwq/kdeui/klineedit.h: Add KLineEdit::frameWidth().
• kwq/qt/qnamespace.h: Remove GUIStyle, MacStyle, and WindowsStyle.
• kwq/qt/qpaintdevice.h: Add QInternal, QInternal::Printer, and QPaintDevice::devType().
• kwq/qt/qpainter.h: Add QPainter::device().
• kwq/qt/qpushbutton.h: Add QPushButton::fontMetrics().

6:59 PM Changeset in webkit [1622] by mjs

• 14 edits in trunk

WebCore:

Fix a recent regression that made JavaScript window closing
crash. Window closing was counting on delayed dealloc/destruction
of things associated with the window, but now that we have made
deallocs more synchronous, we need to add an explicit delay in
this case.

Also, change some fprintf diagnostics of things that should never
happen into assertions, since I actually ran into one.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::end): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::scheduleClose): Renamed from close, changed to schedule window closing from the run loop rather than doing it immediately.
• khtml/ecma/kjs_window.cpp: (Window::scheduleClose): Adjusted for above rename.

WebKit:

Fix a regression in my recent refactoring that broke JavaScript
window opening, by doing some trickery to make a frame's initial
dummy data source committed.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Create dummy data source as committed, not provisional.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Allow the documentView to be nil if there is no webView either; this is temporarily needed to handle the special initial dummy data source, which will be going away soon.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): Add temporary special case to avoid sending empty NSData to the representation, to avoid triggering WebCore assertions.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:]): Get the committed data source, not the provisional one.

6:55 PM Changeset in webkit [1621] by hyatt

• 5 edits in trunk/WebCore

Alternate stylesheet support. Fixed numerous bugs in the handling of alternate sheets and implemented the ability to select alternate sheets per 14.3.2 of the HTML4 spec.

2:23 PM Changeset in webkit [1620] by cblu

• 6 edits in trunk/WebKit

WebKit:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file) in 3 places where we accept drags.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): no changes (-[NSView _web_acceptableDragTypes]): added (-[NSView _web_bestURLForDraggingInfo:]): added (-[NSView _web_dragOperationForDraggingInfo:]): added
• WebKit.pbproj/project.pbxproj: made WebNSViewExtras.h public
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): calls _web_acceptableDragTypes (-[WebView draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[WebView concludeDragOperation:]): calls _web_bestURLForDraggingInfo

WebBrowser:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file)
in 3 places where we accept drags.

• BrowserNSViewExtras.h:
• BrowserNSViewExtras.m: removed locationField specific drag methods
• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): calls _web_acceptableDragTypes (-[LocationFieldEditor draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor concludeDragOperation:]): calls _web_bestURLForDraggingInfo
• LocationTextField.m: (-[LocationTextField awakeFromNib]): calls _web_acceptableDragTypes (-[LocationTextField draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField concludeDragOperation:]): calls _web_bestURLForDraggingInfo

10:54 AM Changeset in webkit [1619] by cblu

• 4 edits in trunk/WebKit

WebKit:

• We were loading icons when page loads ended in error. Fixed.
• Special-case file URLs once instead of twice by moving NSWorkspace call out of WebIconLoader

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): removed file URL special-case
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): check for document error, send file

WebBrowser:

• Comparison between a float and int was causing download history to be erased
• Set the dock mini window to display # of active downloads

• DownloadMonitor.h: renamed _hourlyTimer to _removeExpiredTimer
• DownloadMonitor.m: (-[DownloadMonitor dealloc]): (-[DownloadMonitor updateProgressUI]): set mini dock title (-[DownloadMonitor windowDidLoad]):

4:00 AM Changeset in webkit [1618] by mjs

• 11 edits in trunk

top level:

• Tests/ObjcUnit/Makefile.am: Remove products from symroots on `make clean'.
• Tests/TestPlugin/Makefile.am: Remove products from symroots on `make clean'.
• Tests/WebFoundation-CacheLoader/Makefile.am: Remove products from symroots on `make clean'.

Tools:

• CommitLogEditor/Makefile.am: Remove products from symroots on `make clean'.
• HotSpotFinder/Makefile.am: Remove products from symroots on `make clean'.

JavaScriptCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebFoundation:

• Makefile.am: Remove products from symroots on `make clean'.

WebCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebKit:

• Makefile.am: Remove products from symroots on `make clean'.

WebBrowser:

• Makefile.am: Remove products from symroots on `make clean'.

3:21 AM Changeset in webkit [1617] by mjs

• 4 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:37 AM Changeset in webkit [1616] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:11 AM Changeset in webkit [1615] by mjs

• 6 edits in trunk/WebKit

More refactoring. Change bridge to get the data source via a
method instead of straight from the ivar, and in the method,
assert that the data source is not nil and is not
provisional. Turns out no one was using it while provisional,
which is great. This means we can eliminate the provisional
concept from the bridge interface as the next step.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSource]): New method to get data source - assert it is not nil, and committed. (-[WebBridge frame]): Get data source from method. (-[WebBridge childFrames]): Likewise. (-[WebBridge descendantFrameNamed:]): Likewise. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Likewise. (-[WebBridge openNewWindowWithURL:]): Likewise. (-[WebBridge areToolbarsVisible]): Likewise. (-[WebBridge setToolbarsVisible:]): Likewise. (-[WebBridge areScrollbarsVisible]): Likewise. (-[WebBridge setScrollbarsVisible:]): Likewise. (-[WebBridge isStatusBarVisible]): Likewise. (-[WebBridge setStatusBarVisible:]): Likewise. (-[WebBridge setWindowFrame:]): Likewise. (-[WebBridge window]): Likewise. (-[WebBridge setTitle:]): Likewise. (-[WebBridge setStatusText:]): Likewise. (-[WebBridge mainFrame]): Likewise. (-[WebBridge frameNamed:]): Likewise. (-[WebBridge receivedData:withDataSource:]): Likewise. (-[WebBridge startLoadingResource:withURL:]): Likewise. (-[WebBridge objectLoadedFromCache:size:]): Likewise. (-[WebBridge setDataSource:]): Likewise. (-[WebBridge openedByScript]): Likewise. (-[WebBridge setOpenedByScript:]): Likewise. (-[WebBridge setIconURL:]): Likewise. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _isCommitted]): New private method to check if a data source is committed, for the benefit of WebBridge assertions.

12:46 AM Changeset in webkit [1614] by hyatt

• 6 edits in trunk/WebCore

Apologies for the lack of the changelog info. I need help setting that up on my laptop. I did edit the changelog, and you can see it there. This is a fix to speed up list boxes.

Jul 20, 2002:

9:59 PM Changeset in webkit [1613] by darin

• 4 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Turn stricter warnings back on now that we don't use C++ any more.

• Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Fix cast that stricter warning didn't like. (-[WebPluginView sendUpdateEvent]): Fix cast that stricter warning didn't like. (-[WebPluginView frameStateChanged:]): Remove unneeded cast that stricter warning didn't like.

9:40 PM Changeset in webkit [1612]

• 16 copies in tags/KDE_3_0_2

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_2'.

9:40 PM Changeset in webkit [1611] by darin

• 207 edits in branches/kde

Check in KDE 3.0.2 sources again, this time on the right server.

9:39 PM Changeset in webkit [1610] by darin

• 9 deletes in branches/kde

No Makefiles in kde branch.

7:48 PM Changeset in webkit [1609] by hyatt

• 10 edits in trunk/WebCore

Fixing the FOUC problem.

7:37 PM Changeset in webkit [1608] by darin

• 3 edits in trunk/WebKit

• fixed 2999643 -- Leak of NSSet in -[IFStandardPanels _didStartLoadingURL:inController:]

This is another case of the leak I fixed a month ago. I don't know how I managed to
overlook this other code path with the identical bug.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStopLoadingURL:inController:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.

7:22 PM Changeset in webkit [1607] by darin

• 8 edits in trunk

WebCore:

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::~CSSImportRuleImpl): Fix a potential leak by doing setParent(0) here just as is done in CSSMediaRuleImpl.

• kwq/WebCoreBridge.h: Fix a misspelling of visible.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge areToolbarsVisible]): (-[WebBridge isStatusBarVisible]): Fix misspelling of visible.

WebBrowser:

• fixed 2999637 -- CFStringRef leak in -[IFWebDataSource(IFPrivate) _setTitle:]

• BrowserDocument.m: (-[BrowserDocument pageName]): Remove inexplicable "retain" call.

• fixed another storage leak

• LocationTextField.m: (-[LocationTextField setIcon:]): Release the icon when done.

6:22 PM Changeset in webkit [1606] by mjs

• 19 edits in trunk

WebCore:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

• fixed 3003672 - Assertion failure related to iconloader on metafilter

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): Changed to handle both "icon" and "SHORTCUT ICON" links properly.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::setIconURL): Moved here from KWQKHTMLPartImpl to do it more the way KDE does. (KHTMLPartBrowserExtension::setTypedIconURL): New method for handling moz-style icon links, which include a type as well as a URL.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::loadIcon): Removed.
• kwq/WebCoreBridge.h: Prototype setIcon: and setIcon:withType: methods.
• kwq/khtml/khtml_ext.h: Prototype new methods.
• kwq/kparts/browserextension.h: Make setIcon pure virtual instead of a no-op.

WebKit:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

Also, we don't start loading the icon the moment khtml finds one
in the document any more, instead we wait until the document is
done loading, in case there are both "icon" and "SHORTCUT ICON"
link tags.

• fixed 3003672 - Assertion failure related to iconloader on metafilter

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIconURL:]): Forward to the data source. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Release iconURL. (-[WebDataSource _setDefaultIconURLIfUnset]): Renamed from _loadPageIconIfNecessary, and changed to only set iconURL rather than actually loading. (-[WebDataSource _setPrimaryLoadComplete:]): Call _loadIcon instead of _loadPageIconIfNecessary, since we defer all loads to this point. (-[WebDataSource _loadIcon]): Load current iconURL if set. (-[WebDataSource _setIconURL:]): Set iconURL if not set already (since typed icons are higher priority). (-[WebDataSource _setIconURL:withType:]): Set the iconURL.

2:12 PM Changeset in webkit [1605] by darin

• 12 edits in trunk/WebKit

• fixed 2999616 -- Possible leak in +[IFPluginDatabase installedPlugins]

• Plugins.subproj/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Move the code into an init function. (pluginLocations): Simplified. (-[WebPluginDatabase init]): Added. Cleaned up a bit, and made it release the WebPlugin objects -- this was the leak. (-[WebPluginDatabase dealloc]): Added.

• Plugins.subproj/WebPluginDatabase.h: Tweaked formatting.

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebPluginStream startLoad]): (-[WebPluginStream stop]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): (-[WebSubresourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebSubresourceClient WebResourceHandle:didFailLoadingWithResult:]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _addResourceHandle:]): (-[WebDataSource _removeResourceHandle:]): Changed code that called it a URLHandle to say resourceHandle.

• WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Add an autorelease pool here since this is called from a timer and AppKit does not use an explicit autorelease pool in that case. This makes the "world leak check" work better, and is mildly helpful in other cases too. Radar 3003650 is a request for the AppKit team to fix this, but this workaround will do for now.

Jul 19, 2002:

5:00 PM Changeset in webkit [1604] by darin

• 28 edits in trunk/WebKit

WebFoundation:

• CacheLoader.subproj/WebResourceClient.h: Renamed a couple of the client protocol methods to remove a double mention of the word "resource".

• CacheLoader.subproj/WebResourceCallbackClient.m:
• CacheLoader.subproj/WebResourceHandle.m: Updated for the above name change.

• WebFoundation.pbproj/project.pbxproj: Moved the C APIs to their own group.

WebKit:

• fixed 3001951 -- Massive memory leak after running base or static PLT

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _makeRepresentation]): Add a missing release.

Reduced our use of autorelease. This allows the page load test to detect leaks of the
world much more easily. We may later find we need to use the "retain autorelease" idiom
in a few more places, but I did a lot of testing and that did not show up.

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _setTopBookmark:]): Use a plain release. (-[WebBookmarkGroup _loadBookmarkGroupGuts]): Use a plain release.
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList copyWithZone:]): Use a plain release.
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): Use a plain release.
• Plugins.subproj/WebPluginView.m: (-[WebPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Use a plain release.
• WebView.subproj/WebController.m: (-[WebController createFrameNamed:for:inParent:allowsScrolling:]): Use a plain release. (-[WebController setWindowContext:]): Use a plain release. (-[WebController setResourceProgressHandler:]): Use a plain release. (-[WebController setDownloadProgressHandler:]): Use a plain release. (-[WebController setPolicyHandler:]): Use a plain release.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use plain release.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Use plain release. (-[WebDataSource _setPrimaryLoadComplete:]): Use plain release. (-[WebDataSource _setTitle:]): Use plain release.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Use plain release. (-[WebFrame reset]): Invalidate and release the timer.
• WebView.subproj/WebFramePrivate.h: Keep a reference to the timer.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Invalidate and release the timer. Use plain release. (-[WebFramePrivate setName:]): Use plain release. (-[WebFramePrivate setWebView:]): Use plain release. (-[WebFramePrivate setDataSource:]): Use plain release. (-[WebFramePrivate setProvisionalDataSource:]): Use plain release. (-[WebFrame _scheduleLayout:]): Keep a reference to the timer. (-[WebFrame _timedLayout:]): Release and nil the timer.
• WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:rect:view:children:]): Use plain release.
• WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): Use plain release.
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Use plain release.

Other changes to make the new page load test feature work.

• Misc.subproj/WebKitStatistics.h:
• Misc.subproj/WebKitStatistics.m: (+[WebKitStatistics HTMLRepresentationCount]): Added a stat for WebHTMLRepresentation objects.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Bump the count. (-[WebHTMLRepresentation dealloc]): Decrement the count.

Renaming.

• Misc.subproj/WebCoreStatistics.h:
• Misc.subproj/WebKitStatisticsPrivate.h:
• Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]): Renamed to include the word cache now that the class does not.

• Plugins.subproj/WebPluginStream.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebMainResourceClient.m: Updated for the WebFoundation renaming.

WebBrowser:

• fixed 3002602 -- make Page Load Test close windows, check for leaked JS interpreters before and after

• AppController.m:
• Debug/CacheController.m: Update for WebCoreStatistics method name changes.

• BrowserWebController.m: Tweak.

• Test/PageLoadTest.nib: Add new button to control whether we do "leak the world" checking.

• Test/PageLoadTestController.h: New action and outlet for leak the world button.
• Test/PageLoadTestController.m: (-[PageLoadTestController init]): New notification for leak the world message. (-[PageLoadTestController windowDidLoad]): Add code for leak the world button and new default. (-[PageLoadTestController toggleCheckForWorldLeaks:]): Added. (-[PageLoadTestController detectedWorldLeak:]): Added. Puts up sheet. (-[AppController pageLoadTestController]): Moved global in here so it can be more private.

• Test/PageLoadTestLogger.m: Updated for url -> URL method name change.

• Test/PageLoadTestRunner.h: Add method to control leak the world checking. Also do url -> URL.
• Test/PageLoadTestRunner.m: (-[NSWindow closeIfBrowserWindow]): Added. Used to close all browser windows for leak the world checking. (-[PageLoadTestRunner init]): Default for checkForWorldLeaks is YES. (-[PageLoadTestRunner clearCacheWithURL:]): Update for empty cache method name change. (-[PageLoadTestRunner addLeakToArray:count:name:]): Added. Helper for constructing string. (-[PageLoadTestRunner closeBrowserWindows]): Added. (-[PageLoadTestRunner finishCheckingForWorldLeaks]): Added; done after a delay. (-[PageLoadTestRunner checkForWorldLeaks]): Do the leak check. (-[PageLoadTestRunner checkForWorldLeaksNow]): Do the leak check without delay. (-[PageLoadTestRunner testDone]): Check for leaks when the test is done. (-[PageLoadTestRunner start]): Check for world leak objects before the test starts. (-[PageLoadTestRunner pageLoadStarted:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner pageLoadDone:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner setCheckForWorldLeaks:]): Added.

2:19 PM Changeset in webkit [1603] by cblu

• 9 edits in trunk

top level:

• Site/favicon.ico: Removed.

WebCore:

Per darin, only define loadIcon in KWQKHTMLPartImpl

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
• khtml/khtml_part.cpp:
• khtml/khtml_part.h:

WebKit:

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadPageIconIfNecessary]): use the correct relative string to request favicon.ico

12:58 PM Changeset in webkit [1602] by cblu

• 4 edits in trunk/WebKit

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem image]): call [WebIconLoader defaultIcon]
• Misc.subproj/WebIconLoader.m: (+[WebIconLoader defaultIcon]): move bundle image loading code from [WebHistoryItem image] to here.

12:36 PM Changeset in webkit [1601] by cblu

• 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Fixed build failure by making WebIconLoader.h public

12:04 PM Changeset in webkit [1600] by cblu

• 22 edits
  2 adds in trunk

top level:

• Site/favicon.ico: Added.

WebCore:

Added support favicons.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): added an APPLE_CHANGES
• khtml/khtml_part.cpp: (KHTMLPart::loadIcon): added
• khtml/khtml_part.h: added loadIcon
• kwq/KWQKHTMLPartImpl.h: added loadIcon
• kwq/KWQKHTMLPartImpl.mm: added loadIcon (KWQKHTMLPartImpl::loadIcon):
• kwq/WebCoreBridge.h: added loadIcon

WebKit:

Added support favicons.

• Misc.subproj/WebIconLoader.h: Added.
• Misc.subproj/WebIconLoader.m: Added. (-[WebIconLoaderPrivate dealloc]): (+[WebIconLoader defaultIcon]): (-[WebIconLoader initWithURL:]): (-[WebIconLoader dealloc]): (-[WebIconLoader setDelegate:]): (-[WebIconLoader startLoading]): (-[WebIconLoader startLoadingOnlyFromCache]): (-[WebIconLoader stopLoading]): (-[WebIconLoader WebResourceHandleDidBeginLoading:]): (-[WebIconLoader WebResourceHandleDidCancelLoading:]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): (-[WebIconLoader WebResourceHandle:resourceDataDidBecomeAvailable:]): (-[WebIconLoader WebResourceHandle:resourceDidFailLoadingWithResult:]): (-[WebIconLoader WebResourceHandle:didRedirectToURL:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadIcon:]): added
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _loadPageIconIfNecessary]): added (-[WebDataSource _setPrimaryLoadComplete:]): start loading icon (-[WebDataSource _stopLoading]): stop icon loader (-[WebDataSource receivedPageIcon:]): added (-[WebDataSource _loadIcon:]): added
• WebView.subproj/WebLocationChangeHandler.h:

WebBrowser:

Added support favicons.

• BrowserDocument.m: (-[BrowserDocument _receivedPageIcon:]): added
• BrowserDocumentPrivate.h:
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController frameLoadCommitted:]): switch to default icon (-[BrowserWindowController mouseDownInRightButton:]): (-[BrowserWindowController setPageIcon:]): added
• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:forDataSource:]): added
• LocationTextField.h:
• LocationTextField.m: (-[LocationTextField setDisplayAttributes]): (-[LocationTextField setIcon:]): set the icon size to 16x16
• Resources/Images/url_icon.tiff: Removed.
• TextFieldWithControls.h:
• TextFieldWithControls.m: renamed _completeImage to _backgroundImage (-[TextFieldWithControls dealloc]): (-[TextFieldWithControls backgroundImage]): (-[TextFieldWithControls setFrameSize:]): (-[TextFieldWithControls showRightButton:]): (-[TextFieldWithControls setLeftCapImage:]): (-[TextFieldWithControls setRightCapImage:]): (-[TextFieldWithControls setMiddleImage:]): (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): (-[TextFieldWithControls setRightButtonImage:withOrigin:]):
• WebBrowser.pbproj/project.pbxproj:

11:16 AM Changeset in webkit [1599] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Forgot to export WebKitStatistics.h so it can be used by WebBrowser.

11:02 AM Changeset in webkit [1598] by darin

• 15 edits
  3 adds in trunk

WebCore:

• khtml/css/makeprop: Fail if we don't find gperf.
• khtml/misc/makeattrs: Fail if we don't find gperf.
• khtml/misc/maketags: Fail if we don't find gperf.

WebKit:

Added some stats that we can use to sniff out "leak the world" problems.

• Misc.subproj/WebKitStatistics.h: Added.
• Misc.subproj/WebKitStatistics.m: Added.
• Misc.subproj/WebKitStatisticsPrivate.h: Added.

• WebKit.pbproj/project.pbxproj: Added new files.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge init]): Bump count. (-[WebBridge dealloc]): Decrement count.
• WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): Bump count. (-[WebController dealloc]): Decrement count.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:): Bump count. (-[WebDataSource dealloc]): Decrement count.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Bump count. (-[WebFrame dealloc]): Decrement count.
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Bump count. (-[WebView dealloc]): Decrement count.

3:43 AM Changeset in webkit [1597] by mjs

• 6 edits in trunk/WebKit

More refactoring: Use assertions to make sure a provisional data
source's bridge is never used - and then fix the places where it
would have been used. :-)

• WebView.subproj/WebDataSource.m: (-[WebDataSource documentTextFromDOM]): Return nil if the document is not committed.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Don't tell the bridge to stop if we're provisional, because we won't have one. (-[WebDataSource _setFinalURL:]): Don't try to set the bridge URL if we are not committed - it will get set at commit time. (-[WebDataSource _removeFromFrame]): Assert that the data soource is committed - a provisional data source should never be removed from a frame because it should never be in a frame in the first place. (-[WebDataSource _bridge]): Assert that the view is committed. (-[WebDataSource _commitIfReady]): Do nothing if already committed. (-[WebDataSource _receivedData:]): Notice that first byte was read, if appropriate, and commit when ready.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:didRedirectToURL:]): Simplify code by using [WebDataSource _receivedData:]

2:33 AM Changeset in webkit [1596] by mjs

• 4 edits in trunk/WebCore

• kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]): Assert that this bridge is either for the main frame, or that it's frame has a render part. If neither of these conditions is met, the view will never get installed in the view hiearchy leading to nasty silent failure; and this condition should be guaranteed.

2:13 AM Changeset in webkit [1595] by mjs

• 4 edits in trunk/WebKit

Fix a regression caused by a previous commit that broke frames.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Instead setting the data source implicitly here, and doing other special first-time init, simply assert that we have a data source. (-[WebBridge setDataSource:]): Do the extra work when setting the data source here instead.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): After making the representation, set the data source, because we no longer pass the first data chunk _before_ transitioning to committed, instead we do it right after, so the logic in WebBridge to do it implicitly was not going to cut it.

Jul 18, 2002:

10:10 PM Changeset in webkit [1594] by mjs

• 6 edits in trunk/WebKit

More refactoring: Simplify a bit more by moving more logic into
the data source.

• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _gotFirstByte]): Removed. (-[WebDataSource _setGotFirstByte]): Removed. (-[WebDataSource _isReadyForData]): Removed. (-[WebDataSource _receivedData:]): Commit if appropriate, and pass data to representation and documentView.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]): Change the check back to policy != None, because the first chunk will trigger a commit in the policy == Show case, so there is no need to worry about it.

9:37 PM Changeset in webkit [1593] by mjs

• 7 edits in trunk/WebKit

Rename some methods for clarity. These two methods are defined by
the end state, not the start state (in fact,
transitionToLayoutAcceptable does most of it's work when it starts
in the cimmitted state, not provisional).

• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Renamed from _transitionProvisionalToLayoutAcceptable. (-[WebFrame _transitionToCommitted]): Renamed from _transitionProvisionalToLayoutAcceptable.

And adjust all the calls to them:

• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):

9:13 PM Changeset in webkit [1592] by mjs

• 18 edits in trunk/WebKit

Even more exciting refactoring. Change the rules for committing
the data source and creating the representation so that both
happen when the first byte has been received _and_ the content
policy has been set to show. Previously these actions happened at
different times. Now we maintain the invariant that the data
source has a representation if and only if it is committed.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Simplify further by putting more of the work in WebDataSource.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

• WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: Move makeRepresentation method to private file.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): If the policy is set to show, commit if we have already gotten the first byte. (-[WebDataSource _commitIfReady]): Create representation and commit if we have the first byte and have a policy of show. (-[WebDataSource _gotFirstByte]): Method to check if this data source has gotten the first byte yet. Commit here if ready. (-[WebDataSource _setGotFirstByte]): Method to report that some data has been received. (-[WebDataSource _makeRepresentation]): Make and set up teh document view too. (-[WebDataSource _isReadyForData]): Return TRUE if policy is set (and if the policy is Show, if we have also received the first byte.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Don't call the datasource (it now calls us)
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]):

• WebView.subproj/WebView.h, WebView.subproj/WebView.m: move makeDocumentViewForDataSource...
• WebView.subproj/WebViewPrivate.h, WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): To here.

5:06 PM Changeset in webkit [1591] by hyatt

• 4 edits in trunk/WebCore

• khtml/css/css_valueimpl.cpp: Changed the QRegExps used for font family matching to statics. Helped out one page on the base tests a fair bit. Overall (spread over all 40 pages) it's not that big though.

12:05 PM Changeset in webkit [1590] by mjs

• 3 edits in trunk/WebKit

Avoid throwing an exception while stopping animations. Image
renders were getting into the array multiple times, which means
the code that iterated over the array backwards could throw an
exception, because callling removeObject: on the array would remove
all instances of the object.

This probably fixes the following crashers, and a bunch of huge leaks:

Radar 2999853 - Uninitialized memory access in plugins on theonion.com
Radar 2999892 - Crash disconnecting view from next view chain on theonion.com
Radar 2999911 - Infinite loop in [WebHTMLView dealloc], resulting in crash

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer scheduleFrame]): Move adding to array of image renderers from here... (-[WebImageRenderer beginAnimationInRect:fromRect:]): To here.

11:22 AM Changeset in webkit [1589] by hyatt

• 4 edits in trunk/WebCore

Small change that gives us 25% speedup (uncached) on the cvs-base suite.

• khtml/css/cssstyleselector.cpp: Optimized CLASS style comparison to avoid allocing QStrings when the CLASS attribute only contains one entry (as opposed to a list of entries).

9:35 AM Changeset in webkit [1588]

• 3 copies in tags/Alexander-13

This commit was manufactured by cvs2svn to create tag 'Alexander-13'.

9:35 AM Changeset in webkit [1587] by sheridan

• 8 edits in trunk

markers & version for Alex-13

1:46 AM Changeset in webkit [1586] by mjs

• 7 edits in trunk/WebKit

Yet still more refactoring in preparation for the KHTMLPart
change. This is preparing things to change the commit rule to
require receiving at least one byte of data, and having the
content policy set to Show.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Remove more code since makeRepresentation now does most of the work.
• WebView.subproj/WebDataSource.m: (-[WebDataSource makeRepresentation]): Tell the WebView (if any) to create the documentView now too.
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView makeDocumentViewForDataSource:]): Hook document view up to data source.

12:47 AM Changeset in webkit [1585] by mjs

• 5 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Bail early if not loading. (-[WebDataSource _commit]): Method to mark when the data source is committed (it now knows whether it's committed or provisional). This will be useful for adding assertions later on about what operations may happen only when committed, and which can only happen when provisional.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Call data source's _commit method.

Jul 17, 2002:

8:55 PM Changeset in webkit [1584] by rjw

• 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Made WebDocument.h public.

8:13 PM Changeset in webkit [1583] by rjw

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: Removed unnecessary (and incorrect) lockFocus.

3:24 PM Changeset in webkit [1582] by mjs

• 14 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Move more of the work of creating and setting the representation and document view into WebDataSource and WebView.

• WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: (+[(id <WebDocumentRepresentation>) createRepresentationForMIMEType:]): Removed. (-[WebDataSource makeRepresentation]): A method to build the right kind of representation for the content type.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Method to get the right representation class for the current content type. (-[WebDataSource _bridge]): Move here from WebBridge.[mh], so we can later add an assertion that the data source is not provisional.

• WebView.subproj/WebHTMLViewPrivate.m: #import WebDataSourcePrivate.h
• WebView.subproj/WebView.h, WebView.subproj/WebView.m: (+[(id <WebDocumentRepresentation>) createDocumentViewForMIMEType:]): Removed. (-[WebView makeDocumentViewForMIMEType:]): Method to build the right kind of document view for the specified MIME type.

3:02 PM Changeset in webkit [1581] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Take out bogus check for nil path -- a URL with a nil path is OK, for example "about:blank". Also improved log message.

Jul 16, 2002:

9:26 PM Changeset in webkit [1580] by darin

• 5 edits in trunk/WebKit

WebKit:

• History.subproj/WebBackForwardList.m: Replace MyCompanyName with Apple Computer. (-[WebBackForwardList init]): Fix strange [super init] logic to be standard.
• History.subproj/WebHistoryItem.h: Replace MyCompanyName with Apple Computer.
• Misc.subproj/WebDownloadHandler.h: Replace MyCompanyName with Apple Computer.

WebBrowser:

• LocationTextField.h: Replace MyCompanyName with Apple Computer.
• LocationTextField.m: Replace MyCompanyName with Apple Computer.

9:15 PM Changeset in webkit [1579] by darin

• 7 edits in trunk/WebKit

• fixed 2997891 -- Alexander confused about base page URL for relative links

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient WebResourceHandle:didRedirectToURL:]): Don't tell the bridge the URL changed. The bridge doesn't care about redirects for subresources (and if it did, we'd need some way to tell it that this was a subresource redirect).

• WebCoreSupport.subproj/WebBridge.m: Formatting tweaks.
• WebCoreSupport.subproj/WebImageRenderer.m: Formatting tweaks.
• WebView.subproj/WebView.m: Formatting tweaks.

7:39 PM Changeset in webkit [1578] by rjw

• 3 edits in trunk/WebKit

Really, stop animation if last frame has zero duration, like IE.
Was checking adjustedFrameDuration, which is never zero.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer unadjustedFrameDuration]): (-[WebImageRenderer frameDuration]): (-[WebImageRenderer nextFrame:]):

6:14 PM Changeset in webkit [1577] by mjs

• 2 edits in trunk/WebKit

WebKit:
Corrected bug number in previous ChangeLog message.

5:48 PM Changeset in webkit [1576] by mjs

• 15 edits in trunk

WebCore:

Moved URL mouseover status to KWQKHTMLPartImpl, and made it
responsive to modifier key presses, if enabled. Fixes:

Radar 2980152 - Link mouseover status messages are not localizable
Radar 2982043 - Link mouse-over status should change in response to modifier keys

• khtml/khtml_part.cpp: (KHTMLPart::overURL): Remove extensive APPLE_CHANGES, and just call the impl method.
• kwq/KWQKHTMLPartImpl.h: Prototype overURL method.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Construct status messages using format strings for localizability; change message in response to modifiers if modifier tracking is enabled.
• kwq/WebCoreBridge.h: Prototype modifierTrackingEnabled method.

WebKit:

WebKit part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge modifierTrackingEnabled]): Implemented by checking bit on WebHTMLView class.
• WebKit.pbproj/project.pbxproj: Install WebHTMLViewPrivate as a Private header.
• WebView.subproj/WebHTMLViewPrivate.h: Prototype new modifier tracking SPI.
• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _setModifierTrackingEnabled:]): Method to inform WebHTMLView that modifier tracking is working. (+[WebHTMLView _modifierTrackingEnabled]): Obligatory getter. (+[WebHTMLView _postFlagsChangedEvent:]): Method to report flagsChanged events. Creates corresponding fake mouseMoved event and sends it as a notification.

WebBrowser:

WebBrowser part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

• AppController.m: (-[AppController awakeFromNib]): Enable modifier tracking.
• BrowserWindowController.m: (-[BrowserWindowController windowWillHandleKeyEvent:]): Post NSFlagsChanged events to WebHTMLView.

5:11 PM Changeset in webkit [1575] by rjw

• 5 edits in trunk/WebCore

Fixed field length test. We were testing >= instead of >.

• kwq/KWQNSTextField.mm: (-[KWQNSTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]):

4:17 PM Changeset in webkit [1574] by darin

• 10 edits in trunk

WebCore:

• fixed 2997244 -- crash when visiting cnn.com followed by another page

Turns out the requestFrame code I've been tinkering with used to be
dead code until we accidentally re-triggered the code path.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Remove APPLE_CHANGES that were causing us to reuse the same frame which were an attempt to fix a frame targeting problem that was actually elsewhere.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Remove the code that handles the case of an already-existing frame with the same name. This is handled at a higher level.

• kwq/WebCoreBridge.h: Remove now-unneeded childFrameNamed method.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: Remove childFrameNamed since it's not needed, and every one of these bridge methods adds potential confusion. (-[WebBridge descendantFrameNamed:]): Make this look for descendants in the provisional data sources first. This is the same change Richard made to childFrameNamed, but it turns out that this is the method that's really used.

2:11 PM Changeset in webkit [1573] by kocienda

• 1 delete in branches/jaguar-branch/WebKit

Removed all the files that "magically" showed up on the branch as
a result of the Web* renaming. We don't want any renamed files on
the branch.

11:59 AM Changeset in webkit [1572] by darin

• 5 edits in trunk/WebCore

• fixed 2998692 -- crash when you type "googl" into the page address

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Check for a nil part here to restore the old behavior. Whether that's OK or not is another question that I'd prefer to deal with later.

9:17 AM Changeset in webkit [1571] by darin

• 163 edits
  4 adds
  126 deletes in trunk

top level:

• many files: Renamed IF* -> Web*.

Tools:

• various files: Renamed IF* -> Web*.

WebFoundation:

• almost every file: Renamed IF* -> Web*.

WebCore:

• almost every file: Renamed IF* -> Web*.

WebKit:

• almost every file: Renamed IF* -> Web*.

WebBrowser:

• almost every file: Renamed IF* -> Web*.

6:56 AM Changeset in webkit [1570] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-16 Ken Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2997750 (Sherlock crashes at launch - reproducible on my machine 100%)

This is a bug that only occurs when a zer-length cache file is encountered.
The NSUnarchiver init method does not handle this situation, and throws an exception.
Hence, calls to NSUnarchiver must be done inside an NS_DURING. Note that this change
merely expands the scope of the already-existing NS_DURING to include
the NSUnarchiver init method.

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase objectForKey:])

Jul 15, 2002:

10:19 PM Changeset in webkit [1569] by rjw

• 10 edits in trunk/WebKit

Removed dependence on window resize notification. We now
use the IFWebView setFrame: method to trigger layouts. Much
cleaner.

Cleaned up image animation timer scheduler.

Stop animation if last frame has zero duration, like IE.

Change minimum duration to 1/30th (used if zero frame duration is
specified). This is closer to what I see in IE empirically.

• WebCoreSupport.subproj/IFImageRenderer.h:
• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]): (-[IFImageRenderer _scheduleFrame]): (-[IFImageRenderer nextFrame:]): (-[IFImageRenderer beginAnimationInRect:fromRect:]):
• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]): (-[IFHTMLView removeNotifications]):
• WebView.subproj/IFWebView.mm: (-[IFWebView setFrame:]): (-[IFWebView viewWillStartLiveResize]): (-[IFWebView viewDidEndLiveResize]):

6:01 PM Changeset in webkit [1568] by mjs

• 4 edits in trunk/WebKit

WebKit:

Fixed Radar 2957209 - Change "JavaScript can open new windows
automatically" preference to off by default

• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Switch default for "Allow JavaScript to open new windows automatically to FALSE.

WebBrowser:

Fixed Radar 2957209 - Change "JavaScript can open new windows
automatically" preference to off by default

• Preferences.subproj/English.lproj/ActiveContentPreferences.nib: Tweak wording to make more sense now that the pref defaults to off.

5:43 PM Changeset in webkit [1567] by darin

• 4 edits in trunk/WebKit

More weaning from C++.

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): Use malloc instead of new. (-[IFPluginView dealloc]): Use free instead of delete.

5:33 PM Changeset in webkit [1566] by darin

• 30 edits in trunk/WebKit

top level:

• Site/Internal/Design/IFRenamings.txt: Better naming proposals.

WebKit:

Fixes so we are ready to compile as Objective C, not C++.
The C++ front end misses a lot of things the C front end catches.

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]): Add missing cast.
• Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Use [IFLoadProgress initWithURLHandle:] instead of getting at private fields.
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): Remove unused windowFrame. (-[IFPluginView start]): Don't use a variable within a for statement. Add missing cast.
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Use [IFWebFrame _setProvisionalDataSource:] so we don't have to get at the protected field _private.
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): Use [IFProgress bytesSoFar] so we don't have to get at the protected field bytesSoFar.
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Add missing cast. (-[IFWebFrame _setProvisionalDataSource:]): Added.

• WebView.subproj/IFHTMLRepresentation.mm:
• WebView.subproj/IFHTMLViewPrivate.h:
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebFramePrivate.h:
• WebView.subproj/IFWebViewPrivate.h: Make data in private class @public, since the main class needs to get at it directly.

3:23 PM Changeset in webkit [1565] by darin

• 4 edits in trunk/WebCore

A teeny weeny bit of refactoring.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge stateForEvent:]): Replaces addModifiers:toState:. (-[WebCoreBridge mouseUp:]): Use stateForEvent:. (-[WebCoreBridge mouseDown:]): Use stateForEvent:. (-[WebCoreBridge mouseMoved:]): Use stateForEvent:.

2:22 PM Changeset in webkit [1564] by rjw

• 18 edits
  2 adds in trunk

Added isFrameSet method.

• WebCore.pbproj/project.pbxproj:
• khtml/khtml_part.cpp: (KHTMLPart::isFrameSet):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.mm:
• kwq/KWQKHTMLPartImpl.cpp: Added. (KWQKHTMLPartImpl::isFrameSet):
• kwq/KWQKHTMLPartImpl.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]):

Only adjustFrames in parent if parent is a frame set.
(Anywhere from 2% to 6% gain, depending on what you believe.)

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

• WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Increment initial layout from 1.5 seconds to 1.85 seconds.

2:06 PM Changeset in webkit [1563] by darin

• 5 edits in trunk/WebKit

top level:

• Site/Internal/Design/IFRenamings.txt: Update with naming proposals for recently added identifiers.

WebKit:

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Tweak a comment that included the word WebController, to smooth things over a tiny bit for the coming renaming.

WebBrowser:

Finished renaming WebController to BrowserWebController to head
off name conflict in the coming renaming.

• WebController.h:
• WebController.m: Removed. Used cvs surgery to rename.

• BrowserWebController.h:
• BrowserWebController.m: Used cvs surgery to rename to these names. Then changed references to the file name to use the new name.

• BrowserDocument.h:
• BrowserDocument.m:
• Debug/DebugUtilities.m:
• LocationChangeHandler.m:
• WebBrowser.pbproj/project.pbxproj: Change all references to use BrowserWebController instead of WebController.

8:53 AM Changeset in webkit [1562] by darin

• 4 edits
  1 delete in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Removed KWQKPrinter.mm.
• kwq/KWQKPrinter.mm: Removed.

8:50 AM Changeset in webkit [1561] by darin

• 13 edits
  1 delete in trunk/WebCore

top level:

• Tests/qt/*.cpp: Removed unnecessary includes of <config.h>.

WebCore:

• WebCore.pbproj/project.pbxproj: Removed unused qpopupmenu.h.
• kwq/kdecore/ksimpleconfig.h: Removed unnecessary include of <config.h>.
• kwq/kio/global.h: Removed unnecessary include of <config.h>.
• kwq/kio/kprinter.h: Emptied out this file.
• kwq/qt/qpopupmenu.h: Removed.
• kwq/qt/qstylesheet.h: Removed unnecessary include of <config.h>.
• kwq/qt/qtextedit.h: Removed unnecessary include of <config.h>.

8:39 AM Changeset in webkit [1560] by darin

• 11 edits in trunk

WebCore:

• kwq/qt/qfontmetrics.h: Remove unused, and not properly implemented, empty constructor. Add some const that was missing. Remove most of the parameters of size().
• kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth): Add const. (QFontMetrics::floatWidth): Add const. (QFontMetrics::floatCharacterWidth): Add const. (QFontMetrics::size): Remove unused parameters.

• kwq/WebCoreTextRenderer.h: Remove two unused drawString methods and one unused widthForCharacters method.

WebKit:

• WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer widthForCharacters:length:]): Remove implementation of some unused methods, including at least one that was never used.

1:28 AM Changeset in webkit [1559] by mjs

• 5 edits
  4 adds in trunk/WebKit

WebFoundation:

Fixed the following bugs by implementing proper dispatching for
cookie accept handlers:

Radar 2896356 - cookie "ask for each site" not implemented yet
Radar 2921437 - IFCookieAcceptHandler protocol not suitable for use with a sheet, not cancellable
Radar 2921444 - CookieManager C wrappers need to use proper context object

• AuthenticationManager.subproj/IFAuthenticationHandlerDispatcher.m: (-[IFAuthenticationHandlerDispatcher IFAuthenticationRequestAuthenticationHandlerBusy:]):
• AuthenticationManager.subproj/IFAuthenticationManager.h:
• CacheLoader.subproj/IFHTTPURLProtocolHandler.h:
• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler initWithURLLoad:]): (-[IFHTTPURLProtocolHandler endLoadInBackground]): (-[IFHTTPURLProtocolHandler dealloc]): (-[IFHTTPURLProtocolHandler didAddCredentials:toRequest:context:]): (-[IFHTTPURLProtocolHandler addAuthenticationHeaders:andCall:]): (-[IFHTTPURLProtocolHandler pause]): (-[IFHTTPURLProtocolHandler processPausedEventQueue]): (-[IFHTTPURLProtocolHandler unpause]): (-[IFHTTPURLProtocolHandler continueAfterBytesAvailable]): (-[IFHTTPURLProtocolHandler continueAfterEndEncountered]): (-[IFHTTPURLProtocolHandler handleReadStreamEvent:event:]): (-[IFHTTPURLProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]): (-[IFHTTPURLProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:andCall:]): (-[IFHTTPURLProtocolHandler setResponseHeaders:]): (-[IFHTTPURLProtocolHandler IFCookieManager:doneSettingCookies:]): (-[IFHTTPURLProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]):
• CookieManager.subproj/IFCookieAcceptHandler.h:
• CookieManager.subproj/IFCookieAcceptHandlerC.h: Added.
• CookieManager.subproj/IFCookieAcceptHandlerC.m: Added. (-[IFCallBackCookieAcceptHandler initWithCallBacks:context:]): (+[IFCallBackCookieAcceptHandler handlerWithCallBacks:context:]): (-[IFCallBackCookieAcceptHandler dealloc]): (-[IFCallBackCookieAcceptHandler readyToStartCookieAcceptCheck:]): (-[IFCallBackCookieAcceptHandler startCookieAcceptCheck:]): (-[IFCallBackCookieAcceptHandler cancelCookieAcceptCheck:]): (IFCookieAcceptHandlerCreate):
• CookieManager.subproj/IFCookieAcceptHandlerDispatcher.h: Added.
• CookieManager.subproj/IFCookieAcceptHandlerDispatcher.m: Added. (-[IFCookieAcceptDispatchState initWithDispatcher:request:]): (-[IFCookieAcceptDispatchState dealloc]): (dispatchStartCookieAcceptCheck): (dispatchCancelCookieAcceptCheck): (dispatchCookieAcceptCheckDone): (dispatchCookieAcceptHandlerBusy): (-[IFCookieAcceptHandlerDispatcher _dispatchStartCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher _IFCookieAcceptRequest:checkDone:]): (-[IFCookieAcceptHandlerDispatcher _IFCookieAcceptRequestCookieAcceptHandlerBusy:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCancelCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCookieAcceptCheckDone:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCookieAcceptHandlerBusy:]): (-[IFCookieAcceptHandlerDispatcher initWithCookieAcceptHandler:]): (-[IFCookieAcceptHandlerDispatcher dealloc]): (-[IFCookieAcceptHandlerDispatcher hasHandler:]): (-[IFCookieAcceptHandlerDispatcher startCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher cancelCookieAcceptCheck:]):
• CookieManager.subproj/IFCookieAcceptRequest.h: Added.
• CookieManager.subproj/IFCookieAcceptRequest.m: Added. (-[IFCookieAcceptRequestPrivate dealloc]): (-[IFCookieAcceptRequest _initWithURL:cookies:callback:]): (-[IFCookieAcceptRequest _cookieAcceptHandlerBusy]): (-[IFCookieAcceptRequest init]): (-[IFCookieAcceptRequest dealloc]): (-[IFCookieAcceptRequest url]): (-[IFCookieAcceptRequest cookies]): (-[IFCookieAcceptRequest cookieAcceptCheckDone:]):
• CookieManager.subproj/IFCookieAcceptRequestC.h: Added.
• CookieManager.subproj/IFCookieAcceptRequestC.m: Added. (IFCookieAcceptRequestCopyURL): (IFCookieAcceptRequestCopyCookies): (IFCookieAcceptRequestCheckDone):
• CookieManager.subproj/IFCookieAcceptRequestPrivate.h: Added.
• CookieManager.subproj/IFCookieConstants.h:
• CookieManager.subproj/IFCookieManager.h:
• CookieManager.subproj/IFCookieManager.m: (-[IFCookieAcceptRequestState initWithRequest:dispatcher:continuation:context:]): (-[IFCookieAcceptRequestState dealloc]): (-[IFCookieManagerPrivate init]): (-[IFCookieManagerPrivate dealloc]): (-[IFCookieManager _IFCookieAcceptRequest:checkDone:]): (-[IFCookieManager _IFCookieAcceptRequestCookieAcceptHandlerBusy:]): (-[IFCookieManager _invokeAcceptHandlersForCookies:forURL:andCall:context:]): (-[IFCookieManager _checkIfCookiesAccepted:forURL:andCall:context:]): (-[IFCookieManager _continueSetCookies:context:]): (-[IFCookieManager setCookie:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:setDelegate:context:]): (-[IFCookieManager cancelSetCookiesFromResponseHeadersWithContext:]): (-[IFCookieManager addAcceptHandler:]): (-[IFCookieManager removeAcceptHandler:]):
• CookieManager.subproj/IFCookieManagerC.h:
• CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerAddAcceptHandler): (IFCookieManagerRemoveAcceptHandler):
• CookieManager.subproj/IFCookieStorage.h:
• CookieManager.subproj/IFCookieStorage.m: (-[IFCookieStorage _updateDomainsFromServer]): (-[IFCookieStorage _establishConnection]): (-[IFCookieStorage init]): (-[IFCookieStorage addAcceptedDomain:]): (-[IFCookieStorage removeAcceptedDomain:]): (-[IFCookieStorage acceptedDomains]): (-[IFCookieStorage addRejectedDomain:]): (-[IFCookieStorage removeRejectedDomain:]): (-[IFCookieStorage rejectedDomains]):
• CookieManager.subproj/IFCookieStorageServer.h:
• CookieManager.subproj/IFCookieStorageServer.m: (-[IFCookieStorageServerPrivate init]): (-[IFCookieStorageServerPrivate dealloc]): (-[IFCookieStorageServer _saveCookiesIfScheduled]): (-[IFCookieStorageServer _scheduleSaveCookies]): (-[IFCookieStorageServer _saveDomains]): (-[IFCookieStorageServer _saveDomainsIfScheduled]): (-[IFCookieStorageServer _scheduleSaveDomains]): (-[IFCookieStorageServer _notifyCookiesChanged]): (-[IFCookieStorageServer _notifyDomainsChanged]): (-[IFCookieStorageServer _setCookiesWithoutSaving:]): (-[IFCookieStorageServer setCookies:]): (-[IFCookieStorageServer deleteCookies:]): (-[IFCookieStorageServer addAcceptedDomain:]): (-[IFCookieStorageServer removeAcceptedDomain:]): (-[IFCookieStorageServer acceptedDomains]): (-[IFCookieStorageServer addRejectedDomain:]): (-[IFCookieStorageServer removeRejectedDomain:]): (-[IFCookieStorageServer rejectedDomains]): (-[IFCookieStorageServer loadCookies]):
• Misc.subproj/IFNSValueExtensions.h: Added.
• Misc.subproj/IFNSValueExtensions.m: Added. (+[NSValue _IF_valueWithSelector:]): (-[NSValue _IF_selectorValue]):
• Misc.subproj/WebFoundationDebug.h:
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

WebKit part of fix for Radar 2896356 - cookie "ask for each site" not implemented yet

• Panels.subproj/IFPanelCookieAcceptHandler.h: Added.
• Panels.subproj/IFPanelCookieAcceptHandler.m: Added. (-[IFPanelCookieAcceptHandler init]): (-[IFPanelCookieAcceptHandler dealloc]): (-[IFPanelCookieAcceptHandler readyToStartCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler startCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler cancelCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler doneWithCheck:returnCode:contextInfo:]):
• Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels setUseStandardCookieAcceptPanel:]): (-[IFStandardPanels useStandardCookieAcceptPanel]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed Radar 2896356 - cookie "ask for each site" not implemented yet

• AppController.m: (-[AppController awakeFromNib]):

12:16 AM Changeset in webkit [1558] by mjs

• 11 edits in trunk/WebKit

More workarounds for the Objective C++ typecasting bug.

• WebView.subproj/IFDOMNode.mm: (-[IFDOMNode initWithWebView:]):
• WebView.subproj/IFHTMLViewPrivate.mm: (-[NSView _IF_stopIfPluginView]):
• WebView.subproj/IFRenderNode.mm: (-[IFRenderNode initWithWebView:]):
• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame reset]):

Jul 14, 2002:

11:51 PM Changeset in webkit [1557] by darin

• 5 edits in trunk/WebCore

WebCore:

• kwq/WebCoreFrame.mm: (-[WebCoreFrame dealloc]): Fix NULL-dereferencing problem that was hidden by the "leak the world" bug in WebBrowser.

WebBrowser:

Fix "leak the world" bug.

• BrowserDocument.m: (-[BrowserDocument close]): Having the web controller as its own window context creates a reference cycle. As with the other similar cases here, break the cycle by explicitly setting it to nil.

10:55 PM Changeset in webkit [1556] by mjs

• 5 edits in trunk/WebCore

Assign getView() results to variable of appropriate type to work
around apparent ObjC++ compiler bug. I wonder why other people
aren't running into this (and why I haven't run into it before).

• kwq/KWQButton.mm: (QButton::setText): (QButton::text):
• kwq/KWQLineEdit.mm: (QLineEdit::setEchoMode): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setMaxLength): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited):

10:08 PM Changeset in webkit [1555] by darin

• 5 edits in trunk/WebCore

• WebCore-tests.exp: Tests needed access to QPoint, QString, and KURL symbols that were formerly exported for the benefit of WebKit.

• kwq/KWQPixmap.mm: I needed to touch something since .exp files don't cause a rebuild, so I fixed a comment in here.

4:49 PM Changeset in webkit [1554] by darin

• 61 edits
  4 adds
  1 delete in trunk

WebCore:

Changes to WebCore that allow WebKit to work through Objective C without going
straight to the KHTML headers. Also remove a bunch of unused stuff, especially
in QPainter.

• WebCore.exp: Export the new classes WebCoreCache and WebCoreJavaScript. Don't export any C++ symbols at all.

• WebCore.pbproj/project.pbxproj: Remove KWQWMatrix.mm, add WebCoreCache.* and WebCoreJavaScript.*.

• khtml/khtml_part.cpp: Put more unused code inside ifndef APPLE_CHANGES.
• khtml/khtmlview.cpp: Put unused code inside #ifndef APPLE_CHANGES
• khtml/khtmlview.h: Put unused virtual functions inside #ifndef APPLE_CHANGES.
• khtml/misc/loader.cpp: (CachedImage::tiled_pixmap): Change this so it always returns pixmap(). Handling it at this level is better than changing all the callers for now.
• khtml/rendering/render_box.cpp: (RenderBox::printBackground): Took out the APPLE_CHANGES now that tiled_pixmap() always just returns pixmap().
• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Put some unused code inside APPLE_CHANGES.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame): Made it get the view using the bridge, since we don't have a [widget] method on the frame any more. (KWQKHTMLPartImpl::findFrame): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available. (KWQKHTMLPartImpl::frames): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available.

• kwq/qt/qpixmap.h: Put an empty version of QWMatrix in here. We don't actually ever need a real matrix, just a class to let us compile.

• kwq/qt/qpainter.h: Moved QWMatrix into qpixmap.h. Removed constructors that take QPixmap and QWidget. Removed unused variants of drawText. Removed unused setClipping, setClipRect, hasClipping, translate, scale, begin, end, and device functions.
• kwq/KWQPainter.mm: (QPainter::QPainter): Remove the constructors that take a paint device, widget, or pixmap. We can get away without them. (QPainter::save): Simplify. Also remove the optimization for painters without stacks, since having an empty stack is very inexpensive. (QPainter::restore): Simplify. (QPainter::_drawPoints): Move paintingDisabled check in here. (QPainter::drawText): Removed many unused drawText variants.

• kwq/KWQView.h: Tweaked.
• kwq/KWQView.mm: Removed [KWQView drawRect:].

• kwq/KWQWMatrix.mm: Removed.

• kwq/qt/qwidget.h: Removed paint() virtual function.
• kwq/KWQWidget.mm: Removed QWidget::paint().

• kwq/WebCoreBridge.h: Added new methods installInFrame:, removeFromFrame, mouseDown:, mouseUp:, mouseMoved:, mouseDragged:, copyDOMTree:, and copyRenderTree:.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Call removeFromFrame. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Don't return the view any more, also set bridgeOwnsKHTMLView to YES. (-[WebCoreBridge copyDOMNode:DOM::copier:]): Added helper method for copyDOMTree. (-[WebCoreBridge copyDOMTree:]): Added method to be used by IFDOMNode to get at DOM tree without using C++. (-[WebCoreBridge copyRenderNode:khtml::copier:]): Added helper method for copyRenderTree. (-[WebCoreBridge copyRenderTree:]): Added method to be used by IFRenderNode to get at render tree without using C++. (-[WebCoreBridge removeFromFrame]): Added. Deletes the view if we own it. We don't want to wait for dealloc time to do this, since a lingering view might be visible. (-[WebCoreBridge installInFrame:]): Added. Does a set of things we need to do at the time we commit a provisional data source. (-[WebCoreBridge addModifiers:toState:]): Moved here from IFHTMLView. (-[WebCoreBridge mouseUp:]): Added. Used to get a mouse up event to the KHTMLView. (-[WebCoreBridge mouseDown:]): Added. Used to get a mouse down event to the KHTMLView. (-[WebCoreBridge mouseMoved:]): Added. Used to get a mouse moved event to the KHTMLView. (-[WebCoreBridge mouseDragged:]): Added. Used to get a mouse moved event to the KHTMLView in the case where we are dragging -- perhaps could be merged with mouseMoved.

• kwq/WebCoreCache.h: Added. Allows control of the WebCore cache; previously done directly in IFCache in WebKit.
• kwq/WebCoreCache.mm: Added.

• kwq/WebCoreFrame.h: Remove widget method. Change semantics of bridge method to return provisional bridge if available, which corresponds to what the widget method did before. Added a committedBridge method that has the semantics that bridge did before.

• kwq/WebCoreJavaScript.h: Added. Returns statistics about the state of JavaScript objects; previously done directly in IFCache in WebKit.
• kwq/WebCoreJavaScript.mm: Added.

WebKit:

Wean WebKit completely from getting at the C++ parts of WebCore.
We probably don't need to use C++ at all for WebKit any more.

• WebKit.pbproj/project.pbxproj: Remove all the header search paths; we don't need any special ones now.

• WebKitPrefix.h: Remove <config.h>; we don't need it any more.

• Misc.subproj/IFCache.h: Rename getStatistics to statistics.
• Misc.subproj/IFCache.mm: (+[IFCache statistics]): (+[IFCache empty]): (+[IFCache setDisabled:]): Call through WebCoreCache instead of going directly to khtml::Cache. (+[IFCache javaScriptObjectsCount]): (+[IFCache javaScriptInterpretersCount]): (+[IFCache javaScriptNoGCAllowedObjectsCount]): (+[IFCache javaScriptReferencedObjectsCount]): (+[IFCache garbageCollectJavaScriptObjects]): Call through WebCoreJavaScript instead of going directly to kjs::Collector.

• WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Change to return bridge from the provisional data source if it exists. (-[IFWebCoreFrame committedBridge]): Do what [bridge] used to do, always returning the bridge from the committed data source and never the provisional one.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't store the provisional widget. It's stored in the bridge for the provisional data source. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the bridge method installInFrame: to do most of the work that used to be here. The rest is don in removeFromFrame which is called elsewhere. (-[IFHTMLView mouseUp:]): Use the bridge's mouseUp method. (-[IFHTMLView mouseDown:]): Use the bridge's mouseDown method. (-[IFHTMLView mouseMovedNotification:]): Use the bridge's mouseMoved method. (-[IFHTMLView mouseDragged:]): Use the bridge's mouseDragged method.

• WebView.subproj/IFHTMLViewPrivate.h: Remove the widget, widgetOwned, and provisionalWidget instance variables, and the _widget and _provisionalWidget methods.
• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): Remove the code that deleted the widget and the provisional widget. This is now handled elsewhere.

• WebView.subproj/IFDOMNode.mm: Redo to use the copyDOMTree feature of the bridge.
• WebView.subproj/IFRenderNode.mm: Redo to use the copyRenderTree feature of the bridge.

• WebView.subproj/IFRenderNode.h: Use an NSRect instead of four integers (the switch to floating point is OK).

• WebView.subproj/IFWebDataSourcePrivate.h: Add private _removeFromFrame method.
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _removeFromFrame]): Set the controller and location change handler references to nil, and also call [WebCoreBridge removeFromFrame].
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setDataSource:]): Use _removeFromFrame where we formerly would set the controller and location change handler references to nil.

• WebCoreSupport.subproj/IFWebCoreBridge.h: Tweak.

WebBrowser:

• Debug/CacheController.m: (-[CacheController refreshWebCoreStatisticsMatrix]): Change name of method from getStatistics to statistics.

Jul 13, 2002:

9:33 PM Changeset in webkit [1553] by darin

• 6 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/IFAuthenticationManager.m: (-[IFAuthenticationManager dealloc]): Fix leak by adding call to [super dealloc].

WebKit:

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView dealloc]):
• WebView.subproj/IFImageRepresentation.m: (-[IFImageRepresentation dealloc]): Fix leaks by adding calls to [super dealloc].

WebBrowser:

• Debug/DOMTree.m: (-[DOMTreeDataSource dealloc]):
• Debug/DebugUtilities.m: (-[DebugUtilities dealloc]):
• Debug/RenderTree.m: (-[RenderTreeDataSource dealloc]):
• Debug/ViewTree.m: (-[ViewTreeDataSource dealloc]):
• ListView.m: (-[ListView dealloc]): Fix leaks by adding calls to [super dealloc].

9:27 PM Changeset in webkit [1552] by darin

• 23 edits
  2 deletes in trunk

top level:

• Site/Internal/Design/IFRenamings.txt: Update with new proposals.

WebFoundation:

• AuthenticationManager.subproj/IFAuthenticationManagerCallback.h:
• AuthenticationManager.subproj/IFAuthenticationManagerPrivate.h:
• Misc.subproj/IFCFRunLoopExtensions.m: Changed to use #import instead of #include.

• Database.subproj/IFURLFileDatabase.m: Renamed private struct IFFileAccessTime to FileAccessTime (PointerEqual): Renamed from IFPtrEqual. (FileAccessTimeRelease): Renamed from IFFileAccessTimeRelease.

• Misc.subproj/IFNSThreadExtensions.m: Renamed IFNSJoinableThreadContext to IFJoinableThreadContext for clarity, since there is no NSJoinableThread. (InitJoinableThreads):

WebCore:

• WebCore.pbproj/project.pbxproj: Add a few files that are sources although they should not be compiled for any target.

• kwq/qt/qpushbutton.h: Simplified.
• kwq/KWQPushButton.mm: (QPushButton::QPushButton): Implemented text parameter.

WebKit:

• Misc.subproj/IFNSEventExtras.h: Removed.
• Misc.subproj/IFNSEventExtras.m: Removed.
• WebKit.pbproj/project.pbxproj: Removed IFNSEventExtras.*.

• WebCoreSupport.subproj/IFWebCoreBridge.mm:
• WebView.subproj/IFWebFrame.mm:
• WebView.subproj/IFWebFramePrivate.h:
• WebView.subproj/IFWebFramePrivate.mm: Renamed all bridgeFrame to frameBridge for greater clarity.

• WebView.subproj/IFHTMLView.mm: Updated comments and commented-out code.

• WebView.subproj/IFWebDataSource.h: Fix comment that mentioned IFDefaultWebController.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Fix exception string that cited the wrong state name.

8:55 PM Changeset in webkit [1551] by darin

• 71 edits
  130 adds
  1 delete in trunk

top level:

• embed.am: Removed.

Tools:

• Scripts/embed-in-alex: Added. Replaces the rules in embed.am as the way to make our frameworks embed themselves in Alex so we can rebuild a framework and re-run Alex with the changes without building Alex too.

• Scripts/create-forwarding-header: Added. Mainly useful for the one-time job of making forwarding headers for WebCore, but saving for possible use in the future.

• Scripts/commit-log-editor: Make Tools log show up after top level, but before things like JavaScriptCore.

JavaScriptCore:

• Makefile.am: Don't use embed.am any more.
• JavaScriptCore.pbproj/project.pbxproj: Use embed-into-alex instead of make embed.

WebFoundation:

• Makefile.am: Remove include of embed.am.

• WebFoundation.pbproj/project.pbxproj: Remove unneeded ApplicationServices framework search path. Use embed-into-alex instead of make embed.

WebCore:

• ForwardingHeaders/*: Added. New approach to headers to try to make Project Builder's header dependency support work even for includes like #include <render/render_object.h>.
• kwq/kjs/*: Removed. Now part of ForwardingHeaders.

• Makefile.am: Remove embed.am support.

• WebCore.pbproj/project.pbxproj: Remove other search paths, and add ForwardingHeaders directory as a search path. Add qucomextra_p.h.

• khtml/ecma/kjs_navigator.cpp: Made gratuitous changes to touch this file to make things build without requiring clean rebuild.

• khtml/rendering/render_form.cpp: Removed many unneeded QObject:: qualifiers from inside APPLE_CHANGES to touch this file to make things build without requiring clean rebuild.

• kwq/KWQButton.mm: (QButton::setText), (QButton::text):
• kwq/KWQColor.mm: (QColor::setNamedColor):
• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::stdFontName), (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName), (KHTMLSettings::sansSerifFontName), (KHTMLSettings::cursiveFontName), (KHTMLSettings::fantasyFontName), (KHTMLSettings::encoding):
• kwq/KWQKLocale.mm: (i18n):
• kwq/KWQKMessageBox.mm: (KMessageBox::error), (KMessageBox::warningYesNo): (KMessageBox::questionYesNo), (KMessageBox::sorry):
• kwq/KWQListBox.mm: (-[KWQBrowserDelegate browser:willDisplayCell:atRow:column:]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]): Wean from QSTRING_TO_NSSTRING and NSSTRING_TO_QSTRING.

• kwq/KWQComboBox.mm: (QComboBox::insertItem): Wean from QSTRING_TO_NSSTRING. Note that this now stores a copy of the string in the array. The old version was unsafe if anyone later modified the QString that was passed in.

• kwq/KWQFontMetrics.mm: (QFontMetrics::width):
• kwq/KWQPainter.mm: (QPainter::drawUnderlineForText), (QPainter::drawText): Wean from QSTRING_TO_NSSTRING_LENGTH and _FAST_QSTRING_TO_NSSTRING. We still have speed as high as before, in the "length" case slightly faster.

• kwq/qt/qstring.h: Remove QSTRING_TO_NSSTRING family of macros.

• kwq/KWQInvisibleButton.mm:
• kwq/KWQKHTMLPart.mm:
• kwq/KWQKHTMLPartBrowserExtension.mm:
• kwq/KWQKJavaAppletWidget.mm:
• kwq/KWQKloader.mm:
• kwq/KWQView.mm:
• kwq/KWQsignals.mm:
• kwq/WebCoreBridge.mm:
• kwq/kdecore/kconfig.h:
• kwq/kdecore/klibloader.h:
• kwq/kdecore/klocale.h:
• kwq/khtml/khtml_ext.h:
• kwq/khtml/khtml_factory.h:
• kwq/kio/kmimetype.h: Remove subdirectory prefix from imports to match Project Builder include scheme.

• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]):
• kwq/KWQKLocale.mm: (i18n):
• kwq/KWQKstddirs.mm: (locate): Use bundleForClass instead of bundleWithIdentifier to avoid any potential problems with multiple versions of the framework installed on the same system.

• kwq/KWQKLineEdit.mm: (KLineEdit::completionBox): Remove _logNotYetImplemented, since this is implemented well enough for our needs now, and if we need to implement it later, it will become clear from the application behavior. This should be the destiny of most of these.

• kwq/kdecore/kglobal.h: Simplify.
• kwq/KWQKGlobal.mm: Simplify.
• kwq/qt/qlineedit.h: Simplify.
• kwq/KWQLineEdit.mm: Simplify.

• kwq/KWQPaintDeviceMetrics.mm: Remove unneeded import.
• kwq/qt/qbutton.h: Remove unneeded destructor.

WebKit:

• History.subproj/IFURIEntry.m: (-[IFURIEntry image]): Use [IFURIEntry class] instead of [self class] so we get the icon from the WebKit bundle even if someone subclasses IFURIEntry.
• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): Use bundleForClass instead of bundleWithIdentifier so things work even if we have two copies of WebKit installed on the same machine.

• Makefile.am: Remove include of embed.am.

• WebKit.pbproj/project.pbxproj: Use embed-into-alex instead of make embed. Also change bundle identifier to com.apple.WebKit instead of com.apple.webkit to match standard used by our other frameworks. (Checked that we no longer have any hard-coding of the bundle identifier anywhere in our code.)

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Remove unneeded build phase.

3:01 PM Changeset in webkit [1550] by rjw

• 24 edits in trunk

Fixed 2981849 - frames don't always draw correctly.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge childFrameNamed:]): Check provisional data source first.

• WebView.subproj/IFHTMLViewPrivate.h:
• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _adjustFrames]): Added method to adjust frame geometry.

• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _layoutChildren]): Added method to adjust child frame geometries.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Removed unnecessary drawing now that frame geometry is calculated directly.

• kwq/KWQPainter.mm: Added disable drawing mode. (QPainter::drawRect): (QPainter::drawLine): (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::drawLineSegments): (QPainter::drawPolyline): (QPainter::drawPolygon): (QPainter::drawConvexPolygon): (QPainter::drawPixmap): (QPainter::drawTiledPixmap): (QPainter::drawText): (QPainter::drawUnderlineForText): (QPainter::fillRect): (QPainter::setPaintingDisabled):

• kwq/KWQWidget.mm: (QWidget::frameGeometry): Use the IFWebView's geometry.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _drawRect:withPainter:]): (-[WebCoreBridge drawRect:]): (-[WebCoreBridge adjustFrames:]): Added adjustFrames:. Factored some code.

• kwq/qt/qpainter.h: Added setPaintingDisabled.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): (HTMLIFrameElementImpl::attach): Removed uniqueness check. Need to revisit vis-a-vis provisional ds.

Jul 12, 2002:

10:33 PM Changeset in webkit [1549] by darin

• 93 edits
  2 adds in trunk

JavaScriptCore:

• kjs/ustring.h: Since <sys/types.h> includes ushort and uint now, had to change the includes here to be compatible with that.

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Remove unused build phase.

WebCore:

• WebCore.pbproj/project.pbxproj: Add WebCoreFrame.mm, also export all the WebCore headers as Private so WebKit can see them.

• khtml/khtmlview.cpp: (KHTMLView::drawContents): Remove APPLE_CHANGES since we don't use this function any more.

• kwq/KWQDef.h: Since <sys/types.h> now includes ushort and uint, update code here to take that into account.

• kwq/KWQKHTMLPartImpl.h: Added getView().
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::getView): Added. Used by bridge.

• kwq/qt/qpainter.h:
• kwq/KWQPainter.mm: Simplify a bit, and remove some unused stuff.

• kwq/WebCoreBridge.h: Add reapplyStyles, forceLayout, drawRect:.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]): Added. (-[WebCoreBridge forceLayout]): Added. (-[WebCoreBridge drawRect:]): Added.

• kwq/WebCoreFrame.h: Make this a class as well as an interface.
• kwq/WebCoreFrame.mm: Added.

• WebCore.exp: Since WebCoreFrame is now a class as well as a protocol, export it so we can subclass.

WebKit:

About 1/3 of the remaining work to wean WebKit from its special relationship with WebCore
onto explicit interfaces.

• Misc.subproj/IFCache.mm:
• WebView.subproj/IFDOMNode.mm:
• WebView.subproj/IFRenderNode.mm: Mark imports from inside WebCore with #ifndef WEBKIT_INDEPENDENT_OF_WEBCORE. Once these are all gone, the task is done.

• Plugins.subproj/IFPlugin.h:
• WebCoreSupport.subproj/IFCookieAdapter.h:
• WebCoreSupport.subproj/IFImageRenderer.h:
• WebCoreSupport.subproj/IFImageRendererFactory.h:
• WebCoreSupport.subproj/IFResourceURLHandleClient.m:
• WebCoreSupport.subproj/IFTextRenderer.h:
• WebCoreSupport.subproj/IFTextRendererFactory.h:
• WebCoreSupport.subproj/IFWebCoreBridge.h:
• WebCoreSupport.subproj/IFWebCoreViewFactory.h: Use #import <WebCore/> for getting at WebCore headers so we don't need to use -I.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Call setRenderPart on the WebCoreFrame rather than on the IFWebFrame.

• WebCoreSupport.subproj/IFWebCoreFrame.h: Subclass from the WebCoreFrame class.
• WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame HTMLView]): Add a cast. (-[IFWebCoreFrame widget]): Remove overzealous assert.

• WebKit.pbproj/project.pbxproj: Rearranged things a bit. Removed unneeded build phase.

• WebView.subproj/IFDocument.h:
• WebView.subproj/IFDynamicScrollBarsView.h:
• WebView.subproj/IFWebController.h:
• WebView.subproj/IFWebControllerPolicyHandler.h: Changed a few stray #include statements to #import statements.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceCommitted:]): Move the logic for setting up the renderPart in here from IFWebView. (-[IFHTMLView reapplyStyles]): Use the bridge. (-[IFHTMLView layout]): Use the bridge. (-[IFHTMLView drawRect:]): Use the bridge.

• WebView.subproj/IFHTMLViewPrivate.h: Remove _takeOwnershipOfWidget which is no longer needed.
• WebView.subproj/IFHTMLViewPrivate.mm: (-[NSView _IF_stopIfPluginView]): Added. Use to clean up _reset a bit. (-[IFHTMLView _reset]): Use makeObjectsPerformSelector: for simplicity.

• WebView.subproj/IFImageView.h: Remove unneeded IFWebDataSource declaration.
• WebView.subproj/IFImageView.m: Just formatting tweaks.

• WebView.subproj/IFWebControllerPrivate.mm: Removed unneeded import.
• WebView.subproj/IFWebDataSource.mm: Removed unneeded import.
• WebView.subproj/IFWebDataSourcePrivate.mm: Removed unneeded import.
• WebView.subproj/IFWebFrame.mm: Removed unneeded import.

• WebView.subproj/IFWebFramePrivate.h: Remove renderPart field and related declarations.
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): No need to let go of renderPart any more. (-[IFWebFrame _transitionProvisionalToCommitted]): Move logic into IFHTMLView.

• WebView.subproj/IFWebView.h: Be a bit more specific about the type of documentView.

4:28 PM Changeset in webkit [1548] by cblu

• 4 edits in trunk/WebKit

WebKit:

Only accept drags of 1 file.

• WebView.subproj/IFWebView.mm: (-[IFWebView draggingEntered:]):

WebBrowser:

Only accept drags of 1 file.

• LocationFieldEditor.m: (-[LocationFieldEditor _dragOperationForDraggingInfo:]): added (-[LocationFieldEditor draggingEntered:]): returns _dragOperationForDraggingInfo (-[LocationFieldEditor draggingUpdated:]): returns _dragOperationForDraggingInfo (-[LocationFieldEditor concludeDragOperation:]): removed comment

1:16 PM Changeset in webkit [1547] by darin

• 13 edits in trunk/WebKit

top level:

• configure.in: Don't play games with RANLIB; we don't need that any more and it just messes things up in the libiftest directory.

• Tests/libiftest/Makefile.am: Remove all the explicit options and just let libiftest.a be built as the default kind of library (static, I assume).

WebKit:

Fix cancelling. My recent check-in broke it for downloads.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient receivedError:forHandle:]): Helper function to save code. (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use an error for cancel rather than -1,-1 progress.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient receivedProgressWithHandle:complete:]): Remove -1,-1 handling here; instead we treat it as an error. (-[IFMainURLHandleClient receivedError:forHandle:]): Remove most of the parameters since they are things we can compute ourselves. (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use an error for cancel rather than -1,-1 progress.

• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): Remove the -1,-1 cancel handling; we use an error instead. (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): Remove the -1,-1 cancel handling; we use an error instead. (-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Remove the _isStopping check. We want to do the additional work even if already stopping. (-[IFWebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]): Remove the _isStopping check. We want to do the additional work even if already stopping.

• WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Use NSDeleteCharacter.

11:54 AM Changeset in webkit [1546] by darin

• 10 edits in trunk/WebKit

WebFoundation:

• Misc.subproj/IFNSDictionaryExtensions.h:
• Misc.subproj/IFNSDictionaryExtensions.m: (-[NSDictionary _IF_objectForMIMEType:]): Added. Looks in the dictionary first by the full MIME type, then by the part leading up to the "/". Used in WebKit for the dictionaries for representation and view classes.

WebKit:

• WebView.subproj/IFWebDataSource.mm: (+[IFWebDataSource registerRepresentationClass:forMIMEType:]): Use self instead of [self class]. (+[IFWebDataSource createRepresentationForMIMEType:]): Use the new _IF_objectForMIMEType to simplify and use hash table instead of linear search.
• WebView.subproj/IFWebDataSourcePrivate.mm: (+[IFWebDataSource _repTypes]): Use initWithObjectsAndKeys for brevity and a tiny tiny bit of efficiency. (+[IFWebDataSource _canShowMIMEType:]): Use the new _IF_objectForMIMEType to simplify and use hash table instead of linear search.
• WebView.subproj/IFWebView.mm: (+[IFWebView registerViewClass:forMIMEType:]): Use self instead of [self class]. (+[IFWebView createViewForMIMEType:]): Use the new _IF_objectForMIMEType to simplify and use hash table instead of linear search.
• WebView.subproj/IFWebViewPrivate.mm: (+[IFWebView _canShowMIMEType:]): Use the new _IF_objectForMIMEType to simplify and use hash table instead of linear search.

11:19 AM Changeset in webkit [1545] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Re-added JavaScriptCore, which I removed by accident.

10:35 AM Changeset in webkit [1544] by darin

• 28 edits
  9 adds
  14 deletes in trunk

top level:

Top level part of making WebCore build with Project Builder
instead of using automake.

• Makefile.am: Remove rules for building .pfe files. Add new one-time-commands and force-clean-timestamp features, so I don't have to send out instructions to everyone about how to make things build.
• configure.in: Remove options for using .pfe files. Remove Objective C++ support. Also remove WebCore/khtml/dom, WebCore/khtml/xml, WebCore/khtml/rendering, Test/khtmlview, Tools/wftool, and Tools/HotSpots, from the list of directories where we need to make makefiles.

• force-clean-timestamp: Added.
• one-time-commands: Added.

• .cvsignore: Don't ignore things we don't create. Do ignore the new one-time-commands-timestamp and previous-clean-timestamp.

• Tests/Makefile.am: Removed khtmlview.
• Tests/khtmlview/*: Removed.

• Tests/CookieManager/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
• Tests/CookieManager/objc-dummy.m: Added.
• Tests/CookieManager/objc-dummy.mm: Removed.
• Tests/kde/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
• Tests/kde/objc-dummy.m: Added.
• Tests/kde/objc-dummy.mm: Removed.
• Tests/qt/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
• Tests/qt/objc-dummy.m: Added.
• Tests/qt/objc-dummy.mm: Removed.

• Updates/automake-1.5-mac-ported.diff: Removed, since we can use standard automake.
• Updates/automake-1.5.tar.gz: Removed.
• Updates/install-automake.sh: Removed.
• Updates/update: Removed call to install-automake.sh.

• Tests/WebFoundation-Misc/ifnsstringextensions-test.chk: Change result to match new behavior of the _IF_domainMatches method.

• Site/Internal/Design/IFRenamings.txt: Updated for recent changes.

Tools:

• Scripts/commit-log-editor: Always sort top level first.

• Makefile.am: Take out the wftool subdir.
• wftool/.cvsignore: Removed.

WebCore:

Build WebCore with Project Builder instead of make.
Also wean WebCore from peeking inside the WebKit bundle.

• WebCore.pbproj/.cvsignore: Added.
• WebCore.pbproj/project.pbxproj: Added.

• Makefile.am: Removed rules about building the framework, and just use pbxbuild instead.

• dummy.mm: Removed.

• khtml/Makefile.am: Removed everything but SUBDIRS.
• khtml/css/Makefile.am: Removed everything but the rules for generated sources.
• khtml/dom/Makefile.am: Removed.
• khtml/ecma/Makefile.am: Removed everything but the rules for generated sources.
• khtml/html/Makefile.am: Removed everything but the rules for generated sources.
• khtml/misc/Makefile.am: Removed everything but the rules for generated sources.
• khtml/rendering/Makefile.am: Removed.
• khtml/xml/Makefile.am: Removed.
• kwq/Makefile.am: Removed everything but the rules for generated sources.

• kwq/KWQKLocale.mm: (i18n): Look in WebCore bundle, not WebKit bundle.
• kwq/KWQKstddirs.mm: (locate): Look in WebCore bundle, not WebKit bundle. Also, always assume we are looking for html4.css. (locateLocal): Don't waste code making a bad path, just return empty string.

• kwq/qt/qpixmap.h:
• kwq/KWQPixmap.mm: Changed convertToImage() to an inline since we never need to implement it.

• kwq/KWQKDebug.mm: Removed.
• kwq/KWQKImageIO.mm: Removed.
• kwq/kdecore/kcmdlineargs.h: Emptied out the file.
• kwq/kdecore/kdebug.h: Made the do-nothing code here all be inlines for smaller code size.

• kwq/KWQScrollBar.h: Fixed header guard.

• .cvsignore:
• kwq/.cvsignore:
• khtml/dom/.cvsignore: Removed.
• khtml/rendering/.cvsignore: Removed.
• khtml/xml/.cvsignore: Removed.
• kwq/kdecore/.cvsignore: Removed.
• kwq/qt/.cvsignore: Removed. Don't ignore things we don't generate any more.

• kwq/kjs/collector.h: Added.
• kwq/kjs/internal.h: Added.
• kwq/kjs/interpreter.h: Added.
• kwq/kjs/lookup.h: Added.
• kwq/kjs/object.h: Added. Used so that khtml can see the headers from JavaScriptCore.

WebKit:

• WebKit.pbproj/project.pbxproj: Don't include the html4.css file from WebCore any more. WebCore handles this on its own now. Also, don't include the document templates; we don't use them any more.

• Resources/image_document_template.html: Removed.
• Resources/plugin_document_template.html: Removed.
• Resources/text_document_template.html: Removed.

• Makefile.am: Small tweak to the force-clean-timestamp logic.

Jul 11, 2002:

5:47 PM Changeset in webkit [1543] by darin

• 4 edits in trunk/JavaScriptCore

• JavaScriptCore.pbproj/project.pbxproj: To make the build of WebCore work without using -I to peek at JavaScriptCore sources, made all the Public sources Private so they are all in one directory. Also, made lookup.h be Private.

5:45 PM Changeset in webkit [1542] by cblu

• 4 edits in trunk/WebKit

2986548 - Crash if you drop URL of frameset page onto frame
2953421 - document dragged into frame should replace frameset

• WebView.subproj/IFWebView.mm: (-[IFWebView draggingEntered:]): removed obsolute comment (-[IFWebView performDragOperation:]): moved implementation from here (-[IFWebView concludeDragOperation:]): to here, added support for NSURL drags

5:43 PM Changeset in webkit [1541] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFWebViewPrivate.mm: (+[IFWebView _viewTypes]): Changed back to a mutable dictionary. Oops.

4:51 PM Changeset in webkit [1540] by sullivan

• 7 edits in trunk/WebKit

WebKit:

• fixed 2980779 -- no scroll bar in history window

• WebKit.pbproj/project.pbxproj: Removed nonexistent .h file from project list (IFGrabBag.h)

• WebView.subproj/IFDynamicScrollBarsView.h: Renamed field allowsScrolling to disallowsScrolling
• WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): (-[IFDynamicScrollBarsView setAllowsScrolling:]): (-[IFDynamicScrollBarsView allowsScrolling]): Removed initWithFrame override, whose only purpose was to set allowsScrolling to the "default" value (but not good enough for load-from-nib case). Changed all users of allowsScrolling to !disallowsScrolling instead.

WebBrowser:

• made History menu show all history, not just most recent
• futzed around with some view positions
• fixed 2988910 -- Favorites bar does not show links until restart
• made Favorites bar do fewer unnecessary relayouts

• BrowserWindow.m: (-[BrowserWindow toggleFavoritesBarWithAnimation:]): (-[BrowserWindow toggleStatusBarWithAnimation:]): Tweaked some constants.

• Defaults.plist: Changed default number of items in History menu (now used only for flat part of menu) to 10.

• English.lproj/Browser.nib: Pushed some pixels

• English.lproj/MainMenu.nib: Changed "Show All History" to "Show History in Window" since the menu now shows all history

• FavoritesBar.h: Added _lastWidth and _buttonHeight ivars
• FavoritesBar.m: (-[FavoritesBar _refreshButtons]): Use _buttonHeight ivar instead of measuring height, since bar might be shrunken down into nothingness. (-[FavoritesBar _favoritesViewFrameChanged:]): Only lay out again if width has changed (-[FavoritesBar initWithView:]): set _buttonHeight based on initial height

• GlobalHistory.m: (-[GlobalHistory _insertItemsForDate:intoMenu:atIndex:withRunningTotal:limit:]): add no-limit case (-[GlobalHistory _insertSubmenu:withTitle:atIndex:]): generalized slightly from old _insertSubmenu:forDate:atIndex: (-[GlobalHistory _addHistoryToMenu]): add all history, but limit flat part of menu; only add submenu for today if there are more today entries than fit in flat part; don't add separator after today's entries if there are no submenus; use _insertSubmenu:withTitle:atIndex: instead of _insertSubmenu:forDate:atIndex:

• NSViewAdditions.h:
• NSViewAdditions.m: (-[NSView retileAllScrollViews]): New method to work around AppKit bug involving scroll bar placement.

• WebBrowser.pbproj/project.pbxproj: The Preferences group had fallen inside Search at some point in the past; rescued it.

1:08 PM Changeset in webkit [1539] by cblu

• 10 edits in trunk/WebKit

• Plugins.subproj/IFPluginNullEventSender.h:
• Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initWithPluginView:]): renamed, simplified (-[IFPluginNullEventSender stop]): call plugin debug function
• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): call new initWithPluginView (-[IFPluginView windowWillClose:]): added back to fix plugin view leak (-[IFPluginView NPP_HandleEvent]): added

10:19 AM Changeset in webkit [1538] by darin

• 14 edits in trunk/WebKit

• fixed 2930872 -- option-arrow keys should page up and down
• fixed 2924727 -- Delete does not go to previous page

• WebView.subproj/IFHTMLView.mm: Disable the keyDown and keyUp methods here. We don't really need to pass these events to KHTMLView at the moment. See the comment in this file for further explanation. This paves the way to handle keys other than arrow keys in IFWebView.

• WebView.subproj/IFWebController.h: Add temporary goBack method to IFWindowContext. See comment for more.

• WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Add handling for option arrow keys, space (page down), shift-space (page up), and delete (go back). Also make this call super if the key is not handled so keys make their way back to the superview in the application.

• WebView.subproj/IFWebViewPrivate.h: Add _pageLeft, _pageRight, _goBack.
• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _pageHorizontally:]): Added. (-[IFWebView _pageLeft]): Added. (-[IFWebView _pageRight]): Added. (+[IFWebView _viewTypes]): Simplify. (-[IFWebView _goBack]): Added. Calls [IFWindowContext goBack].

12:56 AM Changeset in webkit [1537]

• 3 copies in tags/Alexander-12

This commit was manufactured by cvs2svn to create tag 'Alexander-12'.

12:56 AM Changeset in webkit [1536] by mjs

• 5 edits in trunk/WebCore

Fixed Radar 2953254 - JavaScript window.scroll() and
window.scrollBy() do not work

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Handle Scroll the same as ScrollBy.
• kwq/KWQScrollView.mm: (QScrollView::scrollBy): Implement this method, since it's needed for JS scrolling.

Jul 10, 2002:

11:48 PM Changeset in webkit [1535] by darin

• 4 edits in trunk/WebKit

• fixed 2973738 -- box characters

To be consistent with other browsers, we need to draw nothing for 0000-001F.
We were drawing boxes.

• WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): Add the skipControlCharacters parameter. If YES, don't include glyphs for characters in the 0000-001F range. (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): Pass skipControlCharacters:YES. (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): Skip control characters when creating the glyph array. (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): Pass skipControlCharacters:YES. (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Skip control characters when computing the width. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Pass skipControlCharacters:NO.

11:23 PM Changeset in webkit [1534] by darin

• 7 edits in trunk/WebCore

• fixed 2978796 -- Client-side image map not working

• kwq/KWQRegion.mm: (QRegion::QRegion): Implement constructor that takes a QPointArray.

• kwq/qt/qarray.h: Fix some const loopholes.

• kwq/KWQCString.mm: (QCString::find): Use const char * instead of char *. (QCString::contains): Use const char * instead of char *. (QCString::right): Use const char * instead of char *. (QCString::mid): Use const char * instead of char *.

10:49 PM Changeset in webkit [1533] by darin

• 11 edits in trunk/WebKit

• fixed 2986273 -- assert currentURL isEqual:[handle redirectedURL] ? [handle redirectedURL] : [handle url]

Since cancel prevents further notification from getting through, currentURL can get
out of sync before cancelling, so we can't assert in the cancel function.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): Remove assert.

• WebView.subproj/IFMainURLHandleClient.h: Remove unnecessary includes. Change type of dataSource to IFWebDataSource from id. Change url to currentURL to match IFResourceURLHandleClient.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:]): Simplify. (-[IFMainURLHandleClient didStartLoadingWithURL:]): Copied here from IFResourceURLHandleClient as a first step toward using a common superclass some day. (-[IFMainURLHandleClient didStopLoading]): Copied here from IFResourceURLHandleClient as a first step toward using a common superclass some day. (-[IFMainURLHandleClient dealloc]): Add an assert. (-[IFMainURLHandleClient receivedProgressWithHandle:complete:]): Removed most of the parameters to make this match the one in IFResourceURLHandleClient. (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): Use didStartLoadingWithURL. (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use receivedProgressWithHandle and didStopLoading. (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): Use receivedProgressWithHandle and didStopLoading. (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Use receivedProgressWithHandle. (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Use receivedProgressWithHandle and didStopLoading. (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Use didStopLoading and didStartLoadingWithURL.

10:32 PM Changeset in webkit [1532] by mjs

• 14 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2953250 - JavaScript window.focus() and window.blur()
methods don't work

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Call the appropriate things on focus and blur.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::unfocusWindow): Implemented by calling bridge.
• kwq/KWQKHTMLPartImpl.h, kwq/KWQWidget.mm: (QWidget::setActiveWindow): Implemented by ordering the window front and making it key.
• kwq/WebCoreBridge.h: Prototype new bridge method.

WebKit:

WebKit part of fix for:

Radar 2953250 - JavaScript window.focus() and window.blur()
methods don't work

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge unfocusWindow]): Use private AppKit interface to cycle windows if the window is the key window.

10:07 PM Changeset in webkit [1531] by darin

• 4 edits in trunk/WebCore

• fixed 2979153 -- charset sjis page is gibberish

• kwq/character-sets.txt: Add x-sjis as an alias for Shift JIS.

9:59 PM Changeset in webkit [1530] by darin

• 4 edits in trunk/WebKit

• fixed 2983025 -- crash in sendEvent on pages with flash playing

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView removeTrackingRect]): New, removes tracking rect and releases window. (-[IFPluginView resetTrackingRect]): New, adds tracking rect and retains window. (-[IFPluginView start]): Use resetTrackingRect. (-[IFPluginView stop]): Use removeTrackingRect. (-[IFPluginView viewWillMoveToWindow:]): Call removeTrackingRect because the window will change by the time we get to viewDidMoveToWindow. (-[IFPluginView viewDidMoveToWindow]): Call resetTrackingRect. (-[IFPluginView viewHasMoved:]): Call resetTrackingRect.

9:12 PM Changeset in webkit [1529] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _scrollToBottomLeft]): Fix this to use the document view to define what the bottom left is, not the content view (which is often much smaller than the document).

6:44 PM Changeset in webkit [1528] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixes for:
2981866 - Download doesn't appear in Downloads window if link was command-clicked
2965312 - Download progress not shown when clicking on download link with Alex not running

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): retain the downloadProgressHandler before calling requestContentPolicy as the web controller may be released in requestContentPolicy

WebBrowser:

Fixes for:
2981866 - Download doesn't appear in Downloads window if link was command-clicked
2965312 - Download progress not shown when clicking on download link with Alex not running

• BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]): added (-[BrowserDocument close]): calls above
• WebController.m: (-[BrowserWebController haveContentPolicy:andPath:forDataSource:]): moved super call to first line

5:38 PM Changeset in webkit [1527] by darin

• 6 edits in trunk/WebCore

• kwq/KWQPixmap.mm: (QPixmap::QPixmap): Restore the imageRenderer == nil case to fix a regression related to resized images. Otherwise, isNull was returning true for all images. In copy constructor, set needCopyOnWrite on both the source and destination; setting it on the destination was not enough. (QPixmap::receivedData): Create the imageRenderer if it's nil. (QPixmap::operator=): Set needCopyOnWrite on both the source and destination.

• kwq/qt/qpixmap.h: Make needCopyOnWrite mutable so we can set it on the source when copying or assigning.

3:08 PM Changeset in webkit [1526] by cblu

• 20 edits in trunk/WebKit

WebKit:

Fix for:
2976311 - Download fails if you close the window that started the download
2976308 - Can't navigate in window while download started in that window is in progress

• WebView.subproj/IFMainURLHandleClient.h:
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient _receivedProgress:forResourceHandle:fromDataSource:complete:]): added, sends progress to correct handler (-[IFMainURLHandleClient _receivedError:forResourceHandle:partialProgress:fromDataSource:]): added, sends progress to correct handler (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): calls _receivedProgress (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): calls _receivedProgress (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): calls _receivedProgress (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): calls _receivedError
• WebView.subproj/IFWebController.h:
• WebView.subproj/IFWebController.mm: (-[IFWebController setDownloadProgressHandler:]): added (-[IFWebController downloadProgressHandler]): added
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): removed download special-casing

WebBrowser:

Fix for:
2976311 - Download fails if you close the window that started the download
2976308 - Can't navigate in window while download started in that window is in progress

• BrowserDocument.m: (-[BrowserDocument init]): set the downloadProgressHandler to the download monitor (-[BrowserDocument close]): set the downloadProgressHandler to nil
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]): renamed, made private (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): added, calls _monitorDownload (-[DownloadMonitor receivedError:forResourceHandle:partialProgress:fromDataSource:]): added, calls _monitorDownload
• WebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): removed download special-casing (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): removed download special-casing

1:50 PM Changeset in webkit [1525] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fix the underlying cause of a deadlock problem that I saw. It's important that IFURLHandle
drops its references to the handle clients on the thread that it's using for client notification
rather than the thread it happens to be deallocated on.

Also fix things so that the notifications can be sent without holding the lock the whole time,
by making a copy of the client array and any parameters, and fix one small problem related to this.

Use makeObjectsPerformSelector in a lot more places, and do a few other cleanups.

• CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandleSynchronousClient initWithHandle:monitor:]): Remove unneeded [self release] in the case where self is nil. (-[IFURLHandle _didRedirectToURL:]): Lock around changes to the redirectedURL so we don't access the object from the callback thread when it's invalid. (-[IFURLHandle _notifyClientsDidBeginLoading]): Do notifications outside the lock. (-[IFURLHandle _notifyClientsDidCancelLoading]): Do notifications outside the lock. Also empty out the clients array because we are at an end state. It's important to empty it out here from the thread we are calling back on rather than from dealloc on whatever thread that is called on. (-[IFURLHandle _notifyClientsDataDidBecomeAvailable]): Do notifications outside the lock. (-[IFURLHandle _notifyClientsDidFinishLoading]): Do notifications outside the lock. Also empty out the clients array because we are at an end state. It's important to empty it out here from the thread we are calling back on rather than from dealloc on whatever thread that is called on. (-[IFURLHandle _notifyClientsDidFailLoading]): Do notifications outside the lock. Also empty out the clients array because we are at an end state. It's important to empty it out here from the thread we are calling back on rather than from dealloc on whatever thread that is called on. (-[IFURLHandle _notifyClientsDidRedirectToURL]): Do notifications outside the lock.

• AuthenticationManager.subproj/IFAuthenticationManager.m: (-[IFAuthenticationManager _retryWaitingRequests]): Remove unnecessary copy/autorelease since we are the sole owner of the waitingRequests array.

• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler setRedirectedURL:]): Use makeObjectsPerformSelector for simplicity. Also remove the exception handler since the handles accessor now does a copy/autorelease. (-[IFHTTPURLProtocolHandler setResponseHeaders:]): Use makeObjectsPerformSelector for simplicity. Also remove the exception handler since the handles accessor now does a copy/autorelease.

• CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad handles]): Return a copied auto-released version. (-[IFURLLoad updateHandles]): Use makeObjectsPerformSelector for simplicity.

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase sync]): Remove unnecessary checks for nil and empty array in cases that the nil behavior of Objective C already takes care of. Use makeObjectsPerformSelector for simplicity.

• Misc.subproj/IFFileTypeMappings.m: (-[IFFileTypeMappingsPrivate init]): Create a reverse mapping dictionary too, so we can map in both directions quickly. Also fix a storage leak in the failure case. (-[IFFileTypeMappings _init]): Fix a storage leak in the failure case. (-[IFFileTypeMappings MIMETypeForExtension:]): Use the new reverse dictionary.

• Misc.subproj/IFNSArrayExtensions.h: Add _IF_makeObjectsPerformSelector:withObject:withObject:.
• Misc.subproj/IFNSArrayExtensions.m: Fix name in comment for the benefit of the renamings script. (-[NSArray _IF_makeObjectsPerformSelector:withObject:withObject:]): Added. Stole the algorithm from NSArray.m.

• Misc.subproj/IFNSObjectExtensions.m: Fix name in comment for the benefit of the renamings script.

11:57 AM Changeset in webkit [1524] by mjs

• 5 edits
  1 delete in trunk/WebKit

• WebView.subproj/IFGrabBag.h: Removed.
• WebView.subproj/IFWebController.h: Move IFContextMenuHandler here.

11:05 AM Changeset in webkit [1523] by darin

• 8 edits in trunk/WebKit

Did some tweaks that weren't really necessary. But at least one is a significant
improvement so I decided to commit rather then just discarding the changes.

• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark title]): Take out special case for separator. (-[IFBookmark setTitle:]): Take out special case for separator. (-[IFBookmark image]): Take out special case for separator. (-[IFBookmark setImage:]): Take out special case for separator. (-[IFBookmark setURLString:]): Take out special case for non-leaf. (-[IFBookmark children]): Take out request for concrete implementation; this is not useful since it's specific to one subclass. (-[IFBookmark numberOfChildren]): Take out request for concrete implementation; this is not useful since it's specific to one subclass. (-[IFBookmark _numberOfDescendants]): Take out request for concrete implementation; this is not useful since it's specific to one subclass. (-[IFBookmark insertChild:atIndex:]): Take out special case for non-list. (-[IFBookmark removeChild:]): Take out special case for non-list. (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): Refactored to eliminate repeated code.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf copyWithZone:]): Use allocWithZone to be more pedantically correct.

• Bookmarks.subproj/IFBookmarkSeparator.m: (-[IFBookmarkSeparator title]): Override to return nil. (-[IFBookmarkSeparator image]): Override to return nil.

10:58 AM Changeset in webkit [1522] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::setBaseURL): Call setBaseURL on the underlying document all the time, not just when we add a missing "/" character.

10:31 AM Changeset in webkit [1521] by darin

• 7 edits in trunk/WebKit

• Misc.subproj/WebKitDebug.m: Remove workaround for long-ago fixed C compiler bug.

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyUp:]), (-[IFPluginView keyDown:]): Simplify keyboard scrolling code by passing along all events that the plug-in doesn't handle rather than special-casing certain events. Also use super rather than nextResponder to pass along the scroll events (super will do nextResponder).

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView keyDown:]), (-[IFHTMLView keyUp:]): Use super rather than nextResponder to pass along scroll events (super will do nextResponder).

Jul 8, 2002:

5:09 PM Changeset in webkit [1520] by cblu

• 14 edits
  2 adds in trunk/WebKit

WebKit:

Fixes for:
2955757 - Keyboard scrolling code needs to move to WebKit
2937231 - Left and right arrows should scroll the content area

• Misc.subproj/IFNSEventExtras.h: Added.
• Misc.subproj/IFNSEventExtras.m: Added. (-[NSEvent _IF_isScrollEvent]): new
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyUp:]): if plug-in doesn't accept it, send to nextResponder (-[IFPluginView keyDown:]): if plug-in doesn't accept it, send to nextResponder
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView keyDown:]): calls _IF_isScrollEvent, if so send to nextResponder (-[IFHTMLView keyUp:]): calls _IF_isScrollEvent, if so send to nextResponder
• WebView.subproj/IFWebView.mm: (-[IFWebView acceptsFirstResponder]): added (-[IFWebView window]): no changes (-[IFWebView keyDown:]): added, does the scroll
• WebView.subproj/IFWebViewPrivate.h:
• WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _contentView]): added (-[IFWebView _scrollVerticallyBy:]): added, moved from BrowserWindow.m (-[IFWebView _scrollHorizontallyBy:]): added, moved from BrowserWindow.m (-[IFWebView _pageVertically:]): added, moved from BrowserWindow.m (-[IFWebView _scrollLineVertically:]): added, moved from BrowserWindow.m (-[IFWebView _scrollLineHorizontally:]): added, moved from BrowserWindow.m (-[IFWebView _pageDown]): added, moved from BrowserWindow.m (-[IFWebView _pageUp]): added, moved from BrowserWindow.m (-[IFWebView _scrollToTopLeft]): added, moved from BrowserWindow.m (-[IFWebView _scrollToBottomLeft]): added, moved from BrowserWindow.m (-[IFWebView _lineDown]): added, moved from BrowserWindow.m (-[IFWebView _lineUp]): added, moved from BrowserWindow.m (-[IFWebView _lineLeft]): added, moved from BrowserWindow.m (-[IFWebView _lineRight]): added, moved from BrowserWindow.m

WebBrowser:

Fixes for:
2955757 - Keyboard scrolling code needs to move to WebKit
2937231 - Left and right arrows should scroll the content area

• BrowserWindow.m: (-[BrowserWindow windowDidLoad]): no changes (-[BrowserWindow windowWillHandleKeyEvent:]): causes scroll in _largestNonFramesetWebView (-[BrowserWindow mouseDownInRightSearchButton:]): no changes (-[IFWebView _area]): added (-[IFWebView _largestNonFramesetWebView]): added

11:18 AM Changeset in webkit [1519] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFWebCoreBridge.mm: Fix compiles under newer compiler (Jaguar 6C89 and newer) by adding missing include.