Context Navigation

← Previous Period
Next Period →

Timeline

Sep 7, 2002:

4:55 PM Changeset in webkit [1993] by cblu

3 edits in trunk/WebKit

WebKit:

Made the wizzy scaling an experiment.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]):

WebBrowser:

Text field/location bar combo
Added a defaults key "Experiments" as a way to toggle experimental features, behaviors etc.
Added an "Experiments" debug menu item. Vague, but couldn't think of a better title.
The text field/location bar combo is an "Experiment".

"Experiments" is off by default.

AppController.m: (-[AppController enableExperiments:]): toggle the default
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController setActivity:]): set _previousActivity so we know if we were searching or loading (-[BrowserWindowController textFieldToUpdateProgress]): added, returns the current text field that is showing a progress bar (-[BrowserWindowController setProgressBarValue:]): added, calls setProgressBarValue on current text field (-[BrowserWindowController incrementProgressBarBy:]): added, calls incrementProgressBarBy on current text field
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]):
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor initWithBrowserDocument:]): set _maxIncrement to the default (-[LoadProgressMonitor _setProgressBarValueToZero]): added (-[LoadProgressMonitor _stopProgressBar]): added (-[LoadProgressMonitor _incrementProgressBarWithProgress:previousProgress:isFrame:]): added, progress algorithm here (-[LoadProgressMonitor monitorResource:withProgress:error:dataSource:]): call _incrementProgressBarWithProgress:previousProgress:isFrame: (-[LoadProgressMonitor finishedLoadingFrame:]): call _stopProgressBar
LocationTextField.m: (-[LocationTextField setDisplayAttributes]): set progress images
PreferenceKeys.h:
Resources/Images/Location_Left_Progress.tif: Added.
Resources/Images/Location_Middle_Progress.tif: Added.
Resources/Images/Location_Right_Progress.tif: Added.
Resources/Images/Search_Left_Progress.tif: Added.
Resources/Images/Search_Middle_Progress.tif: Added.
Resources/Images/Search_Right_Progress.tif: Added.
SearchTextField.m: (-[SearchTextField setDisplayAttributes]): set progress images
TextFieldWithControls.h:
TextFieldWithControls.m: (-[TextFieldWithControls becomeFirstResponder]): call setIsShowingProgressBar:NO (-[TextFieldWithControls textDidEndEditing:]): call setIsShowingProgressBar:YES (-[TextFieldWithControls dealloc]): release progress images (-[TextFieldWithControls backgroundImage]): added logic for showing progress bar (-[TextFieldWithControls setLeftProgressImage:]): added (-[TextFieldWithControls setRightProgressImage:]): added (-[TextFieldWithControls setMiddleProgressImage:]): added (-[TextFieldWithControls isShowingProgressBar]): added (-[TextFieldWithControls setIsShowingProgressBar:]): added (-[TextFieldWithControls setProgressBarValue:]): added (-[TextFieldWithControls incrementProgressBarBy:]): added
WebBrowser.pbproj/project.pbxproj:

Sep 6, 2002:

6:06 PM Changeset in webkit [1992] by mjs

4 edits in trunk/WebCore

Fix another instance of the same problem:

kwq/KWQString.mm: (QString::detach):

6:04 PM Changeset in webkit [1991] by mjs

4 edits in trunk/WebCore

Fix optimized build:

kwq/KWQString.mm: (QString::detachInternal): Uselessly Initialize newData to NULL since the compiler can't tell that FATAL won't return.

5:45 PM Changeset in webkit [1990] by darin

29 edits in trunk

WebCore:

kwq/WebCoreResourceLoader.h: Define WebCoreResourceHandle protocol.

kwq/kio/jobclasses.h:
kwq/KWQKjobclasses.mm:
kwq/KWQLoaderImpl.mm: (KWQServeRequest):
kwq/WebCoreBridge.h: Use WebCoreResourceHandle instead of WebResourceHandle.

kwq/KWQString.mm: (QString::fill): Fix case where the new string is going to be empty, but the old string was not. Before, it leaked a handle.

kwq/character-sets.txt: Updated to 2002-06-14 version from 2001-08-23 version.
kwq/mac-encodings.txt: Updated encoding names to include ones gleaned from the I18N-Charset-1.17 Perl module.

kwq/KWQCharsets.mm: Formatting tweaks.

WebKit:

Almost weaned WebKit entirely from the handleDidBeginLoading and handleDidCancelLoading
loading callbacks. We are planning to remove both of them.

Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Call _didStartLoading here so we don't need to rely on handleDidBeginLoading any more. (-[WebNetscapePluginStream stop]): Call cancel here so we don't need to rely on handleDidCancelLoading any more. (-[WebNetscapePluginStream handleDidBeginLoading:]): Empty out. (-[WebNetscapePluginStream handleDidFinishLoading:]): Nil out resource here. (-[WebNetscapePluginStream handleDidCancelLoading:]): Empty out. (-[WebNetscapePluginStream cancel]): Put cancel code here. (-[WebNetscapePluginStream handleDidFailLoading:withError:]): Nil out resource here.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]): Change to use WebCoreResourceHandle.

WebCoreSupport.subproj/WebSubresourceClient.h: Change to use WebCoreResourceHandle.
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Release handle too, now that we have it. (-[WebSubresourceClient receivedProgressWithComplete:]): Moved up here and removed handle parameter. (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Do work here so we don't need to rely on handleDidBeginLoading any more. (-[WebSubresourceClient receivedError:]): Removed handle parameter. (-[WebSubresourceClient handleWillUseUserAgent:forURL:]): (-[WebSubresourceClient handleDidBeginLoading:]): Emptied out. (-[WebSubresourceClient handleDidCancelLoading:]): Updated, still needs to be emptied out. (-[WebSubresourceClient handleDidFinishLoading:]): Nil out handle. (-[WebSubresourceClient handleDidFailLoading:withError:]): Nil out handle. (-[WebSubresourceClient cancel]): New method, used by WebCore.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): Moved up in the file to fix build failure.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Call didStartLoadingWithURL so we don't have to rely on handleDidBeginLoading. (-[WebDataSource _stopLoading]): Call didCancelWithHandle so we don't have to rely on handleDidCancelLoading.

WebView.subproj/WebMainResourceClient.h: Add didStartLoadingWithURL and didCancelWithHandle to the public methods.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient handleDidBeginLoading:]): Empty out. (-[WebMainResourceClient didCancelWithHandle:]): Move the bulk of handleDidCancelLoading here. (-[WebMainResourceClient handleDidCancelLoading:]): Empty out.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Move the mouse up a little bit so it's "on" the dragged area, but not over the text.

4:22 PM Changeset in webkit [1989] by rjw

13 edits in trunk

Added support for khtml's justified text drawing. Additional padding is distributed
to space widths. (Sites like www.osnews.com now render correctly.)

Change word end rounding hack to use ceil of word width. I'm still noticing a spacing anomaly
that is fixed by a reload. Occasionally text runs are still crammed together, but a reload uses
correct spacing. This anomaly is often visible on www.arstechnica.com. Still investigating.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[WebTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

Tweaks to dragged image.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Start using khtml's 'toAdd' parameter to justify text.

khtml/rendering/font.cpp: (Font::drawText):

Normalize all calls to get width to minimize use of
ObjC. Will make it easier to use IMPL cache later.

kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):

Pass additional 'toAdd' parameter.

kwq/KWQPainter.mm: (QPainter::drawText):
kwq/qt/qpainter.h:

Remove methods now that width calls are normalized to single
method.

kwq/WebCoreTextRenderer.h:

4:12 PM Changeset in webkit [1988]

4 copies in tags/Alexander-22~1

This commit was manufactured by cvs2svn to create tag
'Alexander-22~1'.

4:12 PM Changeset in webkit [1987] by rjw

3 edits in trunk/WebKit

Fixed symbol lookup problem. NSLookupAndBindSymbol() dies horribly
if symbol is missing. Use NSIsSymbolNameDefined() first to check if
symbol is present.

WebCoreSupport.subproj/WebTextRendererFactory.m:

3:56 PM Changeset in webkit [1986] by darin

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Leak fixes and other related changes.

CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables prepareCallbacks]): Retain the callbackData to give it a more normal lifetime. (-[WebResourceHandleInstanceVariables dealloc]): Release response to fix a leak, and callbackData to match the change above. (-[WebResourceHandle _sendCallbacks]): Handle fail in a way that is parallel to finish, rather than parallel to cancel. And put the rule about not delivering any more callbacks after the end state at this level instead of in each function. (-[WebResourceHandle _notifyClientDidBeginLoading]): Remove unnecessary locking. (-[WebResourceHandle _notifyClientDidCancelLoading]): Ditto. (-[WebResourceHandle _notifyClientDidRedirectToURL]): Ditto. (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]): Ditto. (-[WebResourceHandle _notifyClientDidFailLoading]): Ditto. (-[WebResourceHandle _notifyClientDidFinishLoading]): Ditto.
CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler dealloc]): Release responseDataGuard to fix a leak.

Misc.subproj/WebQueue.m: (-[WebQueue take]): Rewrite the wait loop for clarity. Add code to update tail when taking the last element from the queue; fixes a bug. (-[WebQueue remove:]): Add code to update tail when removing the last element.

CacheLoader.subproj/WebResourceLoadQueue.m: -[WebResourceLoadQueue put:]): Tweak.

CacheLoader.subproj/WebResourceLoad.m: (_loadBegin): Add an autorelease pool. (_loadSweeper): Add an autorelease pool.

Database.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): Remove unneeded release of nil. (-[WebFileDatabase objectForKey:]): Tweak and remove an unnecessary "volatile".

Misc.subproj/WebSystemBits.m: (WebSetThreadPriority): Use FATAL instead of printf.

1:34 PM Changeset in webkit [1985] by darin

8 edits in trunk/WebKit

Fix some minor anomalies and leaks.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:target:parent:title:]): Use copy, not retain. (-[WebHistoryItem dealloc]): Release the anchor, fix leak. (-[WebHistoryItem setURL:]): Check for URLs that are equal, not just ==. (-[WebHistoryItem setTitle:]): Copy, not retain. (-[WebHistoryItem setTarget:]): Copy, not retain. (-[WebHistoryItem setParent:]): Copy, not retain. (-[WebHistoryItem setDisplayTitle:]): Copy, not retain. (-[WebHistoryItem setAnchor:]): Copy, not retain.
WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): Release the URL, call super, fix leaks. (-[WebPolicy _setPath:]): Use copy, not retain.
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release downloadProgressHandler, contextMenuHandler, locationChangeHandler, fix leaks.

Some fun with Richard's new code.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Center image around mouse instead of putting it up and to the right. Add more X space than Y space.

1:21 PM Changeset in webkit [1984] by rjw

5 edits in trunk/WebKit

i * WebView.subproj/WebHTMLView.m:

(-[WebHTMLView mouseDragged:]):

More fun and games with dragged links.
Draw both a label and url (in a smaller font)
into the dragged image.

Misc.subproj/WebStringTruncator.h:
Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):

Added right string truncator. Not optimized, but not used
very often. Currently just for dragged link experiment.

11:57 AM Changeset in webkit [1983]

3 copies in tags/Alexander-22

This commit was manufactured by cvs2svn to create tag 'Alexander-22'.

11:57 AM Changeset in webkit [1982] by sheridan

8 edits in trunk

Alex-22 markers & version

7:17 AM Changeset in webkit [1981] by kocienda

3 edits in trunk/WebKit

Declaration and initialization of variable on one line caused unused variable
warning when building under deployment since the only use of the variable was
in a debug statement.

Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:])

Sep 5, 2002:

11:15 PM Changeset in webkit [1980] by darin

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Change all logging to use the new logging.

Misc.subproj/WebAssertions.h: Add real definition of WebLogChannel.
Misc.subproj/WebAssertions.m: (WebLog): Implement.

Misc.subproj/WebFoundationDebug.h: Removed.
Misc.subproj/WebFoundationDebug.m: Removed.
Misc.subproj/WebFoundationLogging.h: Added.
Misc.subproj/WebFoundationLogging.m: Added.
Misc.subproj/WebFoundationPrivate.h: Removed WebFoundationDebug.h.
WebFoundation.pbproj/project.pbxproj: Removed and added files.

AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m:
CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m:
CacheLoader.subproj/WebCacheObject.m:
CacheLoader.subproj/WebDiskCache.m:
CacheLoader.subproj/WebFileProtocolHandler.m:
CacheLoader.subproj/WebHTTPProtocolHandler.m:
CacheLoader.subproj/WebMemoryCache.m:
CacheLoader.subproj/WebProtocolHandler.m:
CacheLoader.subproj/WebResourceData.m:
CacheLoader.subproj/WebResourceHandle.m:
CacheLoader.subproj/WebResourceHandleInternal.m:
CacheLoader.subproj/WebResourceHandlePrivate.m:
CacheLoader.subproj/WebResourceLoad.m:
CacheLoader.subproj/WebResourceLoadManager.m:
CacheLoader.subproj/WebResourceLoadQueue.m:
CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m:
CookieManager.subproj/WebCookie.m:
CookieManager.subproj/WebCookieAcceptHandlerDispatcher.m:
CookieManager.subproj/WebCookieManager.m:
CookieManager.subproj/WebCookieStorage.m:
Database.subproj/WebFileDatabase.m:
Misc.subproj/WebBinaryHeap.m:
Misc.subproj/WebHostNameResolver.m:
Misc.subproj/WebNSStringExtras.m:
Misc.subproj/WebQueue.m:
Misc.subproj/WebReadWriteLock.m:
Misc.subproj/WebRecursiveReadWriteLock.m: Update to use new log macro.

8:10 PM Changeset in webkit [1979] by rjw

3 edits in trunk/WebKit

Experiment w/ dragging link label as drag image.
Needs some visual tweaking, but good concept, I think.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:29 PM Changeset in webkit [1978] by rjw

13 edits in trunk

Add the first child text node of the element to the
element dictionary. This will be used as a link 'label'.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

Use the first text child node of the link element
as the title for a dragged link. We'll use this for
the dragged image later too.

WebView.subproj/WebController.h:
WebView.subproj/WebController.m:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

6:22 PM Changeset in webkit [1977] by mjs

4 edits in trunk/JavaScriptCore

First baby step towards moving List away from garbage collection.

kjs/types.h: Add needsMarking boolean and make List inherit from Value privately instead of publicly.

5:58 PM Changeset in webkit [1976] by rjw

3 edits in trunk/WebKit

Correctly save of document state in current
document when going back.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]):

5:11 PM Changeset in webkit [1975] by rjw

3 edits in trunk/WebKit

Fixed 3043505. Disallows drag drops on originating view.

WebView.subproj/WebView.m: (-[WebView draggingEntered:]):

4:56 PM Changeset in webkit [1974] by darin

48 edits in trunk/WebKit

Update to use the new style of assertions.
A few places still use the WebKitDebug.h, for logging.

Bookmarks.subproj/WebBookmark.m:
Bookmarks.subproj/WebBookmarkGroup.m:
Bookmarks.subproj/WebBookmarkLeaf.m:
Bookmarks.subproj/WebBookmarkList.m:
Bookmarks.subproj/WebBookmarkSeparator.m:
History.subproj/WebHistory.m:
History.subproj/WebHistoryList.m:
History.subproj/WebHistoryPrivate.m:
History.subproj/WebURLsWithTitles.m:
Misc.subproj/WebDownloadHandler.m:
Misc.subproj/WebIconDatabase.m:
Misc.subproj/WebIconLoader.m:
Misc.subproj/WebKitDebug.h:
Misc.subproj/WebStringTruncator.m:
Panels.subproj/WebAuthenticationPanel.m:
Plugins.subproj/WebPlugin.m:
Plugins.subproj/WebPluginDatabase.m:
Plugins.subproj/WebPluginNullEventSender.m:
Plugins.subproj/WebPluginStream.m:
Plugins.subproj/WebPluginView.m:
Plugins.subproj/npapi.m:
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebCookieAdapter.m:
WebCoreSupport.subproj/WebImageRenderer.m:
WebCoreSupport.subproj/WebImageRendererFactory.m:
WebCoreSupport.subproj/WebSubresourceClient.m:
WebCoreSupport.subproj/WebTextRenderer.m:
WebCoreSupport.subproj/WebTextRendererFactory.m:
WebCoreSupport.subproj/WebViewFactory.m:
WebView.subproj/WebController.m:
WebView.subproj/WebControllerPrivate.m:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultPolicyHandler.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebPreferences.m:
WebView.subproj/WebViewPrivate.m: Use new assertions.

4:35 PM Changeset in webkit [1973] by rjw

7 edits in trunk

Removed debugging.

khtml/khtml_part.cpp: (KHTMLPart::closeURL):

Removed debugging.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]):

4:18 PM Changeset in webkit [1972] by rjw

19 edits in trunk

Added support for saving/restoring document state
in back/forward list.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]):
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem documentState]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):

Lookup post Jaguar CG SPI. Can now run and build
w/o patched CG.

WebCoreSupport.subproj/WebTextRendererFactory.m:

Changed image links to drag file contents.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Always call KHTMLPart::closeURL when a new document is loaded.

Added support for saving and restoring document state in
the back/forward list. Document state includes form data.

khtml/khtml_part.cpp: (KHTMLPart::openURL): (KHTMLPart::closeURL): (KHTMLPart::begin):
kwq/KWQKHTMLPartImpl.h:
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::saveDocumentState): (KWQKHTMLPartImpl::restoreDocumentState):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentState]): (-[WebCoreBridge restoreDocumentState]):

2:04 PM Changeset in webkit [1971] by kocienda

6 edits in trunk/WebKit

WebFoundation:

Another change likes the ones I have been doing.

This time the WebError object has been removed from WebResourceHandle and WebResourceLoad.
They now rely on the WebError object in WebResourceResponse. All WebFoundation code
has been updated accordingly.

CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode) (IFURLHandleGetError)
CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:])
CacheLoader.subproj/WebResourceHandle.h:
CacheLoader.subproj/WebResourceHandle.m:
CacheLoader.subproj/WebResourceHandleInternal.h:
CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidFailLoading])
CacheLoader.subproj/WebResourceHandlePrivate.h:
CacheLoader.subproj/WebResourceHandlePrivate.m:
CacheLoader.subproj/WebResourceLoad.h:
CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:isTerminal:]) (-[WebResourceLoad dealloc])
CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders])

WebKit:

The WebError object has been removed from WebResourceHandle.
Objects of that class now rely on the WebError object in WebResourceResponse.

This code has been updated to ask WebResourceResponse for it WebError object,
rather than asking WebResourceHandle.

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:])
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:])

1:38 PM Changeset in webkit [1970] by cblu

4 edits in trunk/WebKit

Fixed 3021365 - Crash failing to load plugin from local file

Plugins.subproj/WebPluginStream.h:
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]): (-[WebNetscapePluginStream receivedError:]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleDidReceiveData:data:]):

12:39 PM Changeset in webkit [1969] by kocienda

7 edits in trunk/WebKit

WebFoundation:

The first use of the WebResourceResponse object. This is just a baby step, though.
I only use one variable in the new class, the statusCode, but all the code in
the framework has been updated to use the statusCode from the response object.
All other references to status codes, be they in WebResourceHandle, or
WebResourceLoad, have been eliminated. More changes like this, where I rely
more and more on WebResourceResponse are to come.

CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleGetStatusCode): Call through to response object to get status code.
CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: Ditto. (-[WebCFNetworkHTTPProtocolHandler continueAfterBytesAvailable]):Ditto. (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]):Ditto.
CacheLoader.subproj/WebResourceHandle.h: Added accessor for WebResourceResponse ivar.
CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): Call through to response object to get status code. (-[WebResourceHandle loadInForeground:]): Ditto. (-[WebResourceHandle response]): Added.
CacheLoader.subproj/WebResourceHandleInternal.h: Add WebResourceResponse ivar. Remove statusCode ivar.
CacheLoader.subproj/WebResourceHandleInternal.m: Remove handle support for its own status code ivar. (-[WebResourceHandleInstanceVariables initWithHandle:]): (+[WebResourceHandle _registerDefaults]):
CacheLoader.subproj/WebResourceHandlePrivate.h: Declare method to set a WebResourceResponse on a handle.
CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didLoadData:]): Call through to response object to get status code. (-[WebResourceHandle _backgroundLoadComplete]): Ditto. (-[WebResourceHandle _backgroundLoadFailed]): Ditto. (-[WebResourceHandle _didRedirectToURL:]): Ditto. (-[WebResourceHandle _setResponse:]): Added
CacheLoader.subproj/WebResourceLoad.h: Remove load support for its own status code ivar. Add WebResourceResponse ivar.
CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Create new WebResourceResponse ivar. (-[WebResourceLoad cancel]): Call through to response object to get status code. (-[WebResourceLoad succeeded]): Ditto. (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:isTerminal:]): Ditto. (-[WebResourceLoad addHandle:]): Set WebResourceResponse on the handle when it is added. (-[WebResourceLoad _beginLoad]): Call through to response object to get status code. (-[WebResourceLoad _beginOriginLoad]): Ditto. (-[WebResourceLoad dealloc]): Release new WebResourceResponse instance. (_loadThrottler): Call through to response object to get status code.
CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): Added (-[WebResourceResponse contentLength]): Implementation does not work yet, but nobody relies on it yet.
CacheLoader.subproj/WebResourceResponsePrivate.h: Removed life-cycle methods I am going to try to do without.
WebFoundation.pbproj/project.pbxproj:

WebKit:

The first use of the WebResourceResponse object. This is just a baby step, though.
I only use one variable in the new class, the statusCode, but all the code in
the framework has been updated to use the statusCode from the response object.

Each of these methods was modified to call through to a WebResourceResponse to get
the status code.

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:])
WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:])
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:])

12:34 PM Changeset in webkit [1968] by rjw

3 edits in trunk/WebKit

Only disable timed expiration of CG glyph cache if SPI is available.
(per Bertrand's request)

WebCoreSupport.subproj/WebTextRendererFactory.m:

7:13 AM Changeset in webkit [1967] by sullivan

3 edits in trunk/WebKit

WebKit:

Resources/url_icon.tiff: New generic icon from Steve Lemay. The @ sign lives, but does not spring.

WebBrowser:

new art from Steve Lemay
removed all unused images from Alexander

LocationTextField.m: (-[LocationTextField setDisplayAttributes]):
SearchTextField.m: (-[SearchTextField setDisplayAttributes]): Updated to use new names for left/middle/right images, so I don't have to keep changing the names of the incoming art.

Resources/Images/Back.tif:
Resources/Images/BackPressed.tif:
Resources/Images/Go.tif:
Resources/Images/GoPressed.tif:
Resources/Images/Search_SnapBack.tif:
Resources/Images/Search_SnapBackPressed.tif:
Resources/Images/ShowFavorites.tif:
Resources/Images/Stop.tif:
Resources/Images/StopPressed.tif:
Resources/Images/Reload.tif:
Resources/Images/ReloadPressed.tif: New and improved.

Resources/Images/Location_Left.tif: Added.
Resources/Images/Location_Middle.tif: Added.
Resources/Images/Location_Right.tif: Added.
Resources/Images/Search_Left.tif: Added.
Resources/Images/Search_Middle.tif: Added.
Resources/Images/Search_Right.tif: Added. New names for left/middle/right text field images; note that the search middle is now different than the location field middle (different shadowing)

Resources/Images/RightCapBack.tiff: Removed.
Resources/Images/favoritesCaret.tiff: Removed.
Resources/Images/find.tiff: Removed.
Resources/Images/find2_green.gif: Removed.
Resources/Images/find_go.tiff: Removed.
Resources/Images/find_green.gif: Removed.
Resources/Images/find_red_0.gif: Removed.
Resources/Images/find_red_1.gif: Removed.
Resources/Images/find_red_2.gif: Removed.
Resources/Images/find_red_3.gif: Removed.
Resources/Images/find_red_4.gif: Removed.
Resources/Images/find_red_5.gif: Removed.
Resources/Images/find_red_6.gif: Removed.
Resources/Images/find_red_7.gif: Removed.
Resources/Images/leftCapFlat.tiff: Removed.
Resources/Images/leftCapRound.tiff: Removed.
Resources/Images/leftCapRoundWithGlass.tiff: Removed.
Resources/Images/leftCapRoundWithGlassAndMenu.tiff: Removed.
Resources/Images/middleTextField.tiff: Removed.
Resources/Images/rightCapFlat.tiff: Removed.
Resources/Images/rightCapRound.tiff: Removed.
Resources/Images/spin_0.tiff: Removed.
Resources/Images/spin_1.tiff: Removed.
Resources/Images/spin_10.tiff: Removed.
Resources/Images/spin_11.tiff: Removed.
Resources/Images/spin_2.tiff: Removed.
Resources/Images/spin_3.tiff: Removed.
Resources/Images/spin_4.tiff: Removed.
Resources/Images/spin_5.tiff: Removed.
Resources/Images/spin_6.tiff: Removed.
Resources/Images/spin_7.tiff: Removed.
Resources/Images/spin_8.tiff: Removed.
Resources/Images/spin_9.tiff: Removed.
Resources/Images/stopSquare.tiff: Removed.
Resources/Images/web2_green.gif: Removed.
Resources/Images/web2_red_0.gif: Removed.
Resources/Images/web2_red_1.gif: Removed.
Resources/Images/web2_red_10.gif: Removed.
Resources/Images/web2_red_11.gif: Removed.
Resources/Images/web2_red_2.gif: Removed.
Resources/Images/web2_red_3.gif: Removed.
Resources/Images/web2_red_4.gif: Removed.
Resources/Images/web2_red_5.gif: Removed.
Resources/Images/web2_red_6.gif: Removed.
Resources/Images/web2_red_7.gif: Removed.
Resources/Images/web2_red_8.gif: Removed.
Resources/Images/web2_red_9.gif: Removed.
Resources/Images/web_go.tiff: Removed.
Resources/Images/web_green.gif: Removed.
Resources/Images/web_red_0.gif: Removed.
Resources/Images/web_red_1.gif: Removed.
Resources/Images/web_red_2.gif: Removed.
Resources/Images/web_red_3.gif: Removed.
Resources/Images/web_red_4.gif: Removed.
Resources/Images/web_red_5.gif: Removed.
Resources/Images/web_red_6.gif: Removed.
Resources/Images/web_red_7.gif: Removed. Out with the old unused images.

WebBrowser.pbproj/project.pbxproj: Updated for file changes.

Sep 4, 2002:

11:24 PM Changeset in webkit [1966] by darin

5 edits in trunk/WebKit

One more pass of refinement on that last change.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): Replace the last entry instead of just ignoring if this one matches.

History.subproj/WebHistoryList.h: Add replaceEntryAtIndex. Remove addURL: and removeURL:.

History.subproj/WebHistoryList.m: (-[WebHistoryList addEntry:]): Call removeEntry: rather than using an entire pasted copy here. (-[WebHistoryList removeEntry:]): Use a hash of the URL and the URL rather than relying on the fact that WebHistoryItem hashes and does isEqual based on the URL only. (-[WebHistoryList replaceEntryAtIndex:withEntry:]): Added. Used by the code above.

11:05 PM Changeset in webkit [1965] by darin

4 edits in trunk/WebKit

Fix bug where doing a reload adds an entry to the back/forward list.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): If URL, target, and parent all match, then don't add an entry.

WebKit.pbproj/project.pbxproj: Let Project Builder be the boss; I guess this means Chris is still using the old version.

6:56 PM Changeset in webkit [1964] by cblu

5 edits in trunk/WebKit

don't set nil data on the web file db
store absolute URLs in the db, not base URL/path combination URLs
support for multiple hosts with the same built-in icon

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): renamed some dictionaries (-[WebIconDatabase iconForSiteURL:withSize:]): call _builtInIconsForHost (-[WebIconDatabase _updateFileDatabase]): check for nil (-[WebIconDatabase _hasIconForSiteURL:]): call _pathForBuiltInIconForHost (-[WebIconDatabase _pathForBuiltInIconForHost:]): new (-[WebIconDatabase _builtInIconsForHost:]): call _pathForBuiltInIconForHost
Misc.subproj/WebIconDatabasePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): use absolute URL

5:02 PM Changeset in webkit [1963] by cblu

5 edits in trunk/WebKit

WebKit:

Made the icon DB take a a path for built-in icons so that we only load them when necessary.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForSiteURL:withSize:]): (-[WebIconDatabase _hasIconForSiteURL:]): (-[WebIconDatabase _builtInIconsForHost:]): (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]):
Misc.subproj/WebIconDatabasePrivate.h:
WebKit.pbproj/project.pbxproj:

WebBrowser:

Added the built-in site icons to the Alexander.app package.

AppController.m: (-[AppController _installBuiltInIcons]):
Resources/SiteIcons/Icons.plist: Added.
Resources/SiteIcons/amazon.tiff: Added.
Resources/SiteIcons/apple.tiff: Added.
Resources/SiteIcons/cnet.tiff: Added.
Resources/SiteIcons/cnn.tiff: Added.
Resources/SiteIcons/ebay.tiff: Added.
Resources/SiteIcons/espn.tiff: Added.
Resources/SiteIcons/msn.tiff: Added.
Resources/SiteIcons/nyt.tiff: Added.
Resources/SiteIcons/pbskids.tiff: Added.
Resources/SiteIcons/yahoo.tiff: Added.
WebBrowser.pbproj/project.pbxproj:

2:42 PM Changeset in webkit [1962] by darin

3 edits in trunk/WebKit

Fix unused variable warnings for deployment builds.

Plugins.subproj/WebPluginView.m: Add ifndef NDEBUG around variable used only in log statements.

1:50 PM Changeset in webkit [1961] by darin

14 edits in trunk/WebKit

WebKit:

Removed the now-unnecessary iconURL from bookmarks and history.

Bookmarks.subproj/WebBookmark.h:
Bookmarks.subproj/WebBookmark.m:
Bookmarks.subproj/WebBookmarkGroup.h:
Bookmarks.subproj/WebBookmarkGroup.m:
Bookmarks.subproj/WebBookmarkLeaf.h:
Bookmarks.subproj/WebBookmarkLeaf.m:
History.subproj/WebHistory.h:
History.subproj/WebHistory.m:
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m:
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: Removed iconURL instance variables, methods, and parameters.

WebBrowser:

Update users of bookmark or history APIs from WebKit that no longer take an iconURL.

BookmarksController.m: (-[BookmarksController _blessOrCreateFavoritesRoot]):
BookmarksViewController.m: (-[BookmarksViewController newItemWithTitle:URLString:type:positionIgnoresSelection:]):
LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]): Removed iconURL parameters.

1:42 PM Changeset in webkit [1960] by darin

14 edits
1 add in trunk/WebKit

Did some minor plugin cleanup, mostly to make sure we don't
change pages while a plugin is tracking.

Plugins.subproj/WebPluginView.h: Add sendEvent and sendUpdateEvent. Remove the NPP_HandleEvent method.
Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView sendEvent:]): Sets up the "defersCallbacks" state, then sends the event.

Plugins.subproj/WebNetscapePluginViewPrivate.h: Added. This stuff was shared in a different way before, and it hadn't even been renamed.
WebKit.pbproj/project.pbxproj: Added file.
Plugins.subproj/npapi.m: Use the new private header.

Plugins.subproj/WebPluginNullEventSender.h: Hold a reference to the view.
Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): Retain the view. (-[WebNetscapePluginNullEventSender dealloc]): Release the view. (-[WebNetscapePluginNullEventSender sendNullEvents]): Use sendEvent:. (-[WebNetscapePluginNullEventSender stop]): No need for shouldStop.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Don't set contentPolicy to an enum value, when it's an object reference. (-[WebDataSourcePrivate dealloc]): Release contentPolicy to fix a leak.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Set draggedURL to nil in the else case, it was uninitialized before. Also center the icon better when dragging, but shouldn't we be dragging something more than the icon here?

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]): Add a call to release. Doesn't really plug a leak, but cleaner this way.

Plugins.subproj/WebPlugin.m: Tweaks.
WebView.subproj/WebMainResourceClient.m: Tweaks only.

10:04 AM Changeset in webkit [1959] by kocienda

9 edits in trunk/WebKit

WebFoundation:

Modified API and behavior so that WebResourceHandle objects no longer
buffer data as it is loaded. The responsibility to buffer data is now
passed to WebResourceClient objects, and I modified the code to
perform that buffering where necessary.

There was also an API change to the WebResourceClient protoccol.

(void)handleDidFinishLoading:(WebResourceHandle *)handle data:(NSData *)data;

has become

(void)handleDidFinishLoading:(WebResourceHandle *)handle;

This reflects the fact that WebResourceHandle no longer has the data to pass
in this callback (and may not be able to ask other objects in the framework to
provide the data so that it may be presented in the callback).

I also added a new WebResourceResponse class, although it is not wired up
to anything yet.

CacheLoader.subproj/IFURLHandleC.h:
CacheLoader.subproj/IFURLHandleC.m:
CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handleDidFinishLoading:])
CacheLoader.subproj/WebResourceClient.h:
CacheLoader.subproj/WebResourceHandle.h:
CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle contentLengthReceived])
CacheLoader.subproj/WebResourceHandleInternal.h:
CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables initWithHandle:]) (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFinishLoading])
CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didLoadData:])
CacheLoader.subproj/WebResourceResponse.h: Added.
CacheLoader.subproj/WebResourceResponse.m: Added.
CacheLoader.subproj/WebResourceResponsePrivate.h: Added.
CacheLoader.subproj/WebResourceSynchronousClient.h:
CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceSynchronousClient initWithMonitor:realClient:]) (-[WebResourceSynchronousClient dealloc]) (-[WebResourceSynchronousClient resourceData]) (-[WebResourceSynchronousClient handleDidFinishLoading:]) (-[WebResourceSynchronousClient handleDidReceiveData:data:])
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Made more adjustments for API and behavior change that occurred in WebFoundation,
now that WebResourceHandle objects no buffer resource data as it is loaded. Where
necessary, the WebKit objects now do their own buffering, however, in many cases,
buffering is not necessary to maintain correct behavior.

Misc.subproj/WebIconLoader.m: (-[WebIconLoaderPrivate dealloc]): Release new buffered resource data object. (-[WebIconLoader initWithURL:]): Allocate new buffered resource data object. (-[WebIconLoader handleDidFinishLoading:]): Modify API to remove data parameter. (-[WebIconLoader handleDidReceiveData:data:]): Buffer data as it is received.
Plugins.subproj/WebPluginStream.h: Added new buffered resource data object.
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:attributes:]): Allocate new buffered resource data object. (-[WebNetscapePluginStream dealloc]): Release new buffered resource data object. (-[WebNetscapePluginStream receivedData:]): Buffer data as it is received (when necessary maintain correct behavior). (-[WebNetscapePluginStream handleDidFinishLoading:]): Modify API to remove data parameter.
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Modify API to remove data parameter.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Modify API to remove data parameter. (-[WebMainResourceClient handleDidReceiveData:data:]): Buffer data as it is received (when necessary maintain correct behavior).

9:08 AM Changeset in webkit [1958] by cblu

3 edits in trunk/WebKit

WebKit:

Fixed: 3043024 - Built-in icons should match on *whatever.com or *whatever.whatever
implemented wizzy scaling, but ifdef'd it out

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call _builtItIconsForHost (-[WebIconDatabase _hasIconForSiteURL:]): call _builtItIconsForHost (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconByScalingIcon:toSize: (-[WebIconDatabase _builtItIconsForHost:]): use better host matching (-[WebIconDatabase _cachedIconFromArray:withSize:]): call _iconByScalingIcon:toSize: (-[WebIconDatabase _iconByScalingIcon:toSize:]): renamed, ifdef'd out wizzy scaling

WebBrowser:

Release alloc'd image.

AppController.m: (-[AppController _installBuiltItIcons]):

8:32 AM Changeset in webkit [1957] by kocienda

7 edits in trunk/WebKit

Changed WebKit so that it no longer relies on WebResourceHandle to buffer
resource data as it is loaded. Instead, this buffering task has been moved
out to the WebResourceClient, WebMainResourceClient in this case. This
change is a "proof of concept" for the upcoming change where the API in
WebFoundation for buffering resource data in WebResourceHandle will be
removed altogether.

WebView.subproj/WebDataSource.m: (-[WebDataSource data]): Changed to call WebMainResourceClient when resource data is needed.
WebView.subproj/WebMainResourceClient.h: Added mutable data ivar.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Added mutable data ivar. (-[WebMainResourceClient dealloc]): Release new mutable data ivar. (-[WebMainResourceClient resourceData]): Added accessor method. (-[WebMainResourceClient handleDidReceiveData:data:]): Append received data to the new mutable data object.

8:04 AM Changeset in webkit [1956] by darin

10 edits in trunk/WebCore

WebCore.pbproj/project.pbxproj:
kwq/KWQObject.mm:
kwq/KWQPainter.mm:
kwq/KWQTimer.mm:
kwq/WebCoreCookieAdapter.h:
kwq/WebCoreImageRenderer.h:
kwq/WebCoreImageRendererFactory.h: Tweaks, no substantive changes.

Sep 3, 2002:

3:37 PM Changeset in webkit [1955] by sullivan

3 edits in trunk/WebKit

Resources/url_icon.tiff: New image (still a placeholder) from HI. For the moment the default page icon is the legendary @-sign-on-a-spring. I've been promised a replacement by tomorrow sometime.

12:41 PM Changeset in webkit [1954] by sullivan

5 edits
1 delete in trunk/WebKit

WebKit:

removed small folder image used for bookmark lists; it is now up to clients to display an icon for bookmark lists.

Bookmarks.subproj/WebBookmarkList.h: Removed _icon ivar
Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList dealloc]): Don't release _icon (-[WebBookmarkList icon]): just return nil
Resources/bookmark_folder.tiff: Removed.
WebKit.pbproj/project.pbxproj: Updated for removed file.

WebBrowser:

made Favorites bar handle folder icons
made bookmarks view start with all top-level folders expanded
fixed bug where bookmarks outline would sometimes have horizontal scroll bar (which you couldn't get rid of)
fixed bug where bookmarks window (Debug menu) wouldn't start with outline view focused (so some menu items were disabled)

Resources/Images/folder16.tiff: Added. Small folder icon.
Resources/Images/folder32.tiff: Added. Bigger folder icon.
WebBrowser.pbproj/project.pbxproj: Updated for new images.

BookmarksController.m: (-[BookmarksController imageForBookmark:]): return small folder icon

BookmarksViewController.m: (-[BookmarksViewController expandTopLevelItems]): New method. (-[BookmarksViewController awakeFromNib]): Call expandTopLevelItems.

BookmarksWindowController.m: (-[BookmarksWindowController windowDidLoad]): set outline view as first responder; this handled in the mode-switching code in the bookmarks-in-browser-window case.

FavoriteButton.m: (-[FavoriteButton buttonImageFromBookmark]): New method, extracted from setBookmark and updated to handle large folder icons (will probably be consolidated with [BookmarksController imageForBookmark:] soon) (-[FavoriteButton setBookmark:]): call buttonImageFromBookmark

12:01 PM Changeset in webkit [1953] by cblu

18 edits in trunk/WebKit

WebKit:

Moved the default icon method to WebIconDatabase
Removed "icon URL" from the location change handler API

History.subproj/WebHistoryItem.m: (-[WebHistoryItem icon]): don't worry about iconForSiteURL:withSize: returning nil
Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): return defaultIconWithSize if none found (-[WebIconDatabase defaultIconWithSize:]): added, loads, caches default icon (-[WebIconDatabase _hasIconForSiteURL:]): added, called by webdatasource to determine if icon is necessary
Misc.subproj/WebIconDatabasePrivate.h: added _hasIconForSiteURL
Misc.subproj/WebIconLoader.h: removed default icon method
Misc.subproj/WebIconLoader.m: removed default icon method
Resources/url_icon.tiff: resized to 32 x 32
WebKit.exp: export symbol for a dictionary key
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): call _hasIconForSiteURL
WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call defaultIconWithSize
WebView.subproj/WebLocationChangeHandler.h:
WebView.subproj/WebLocationChangeHandler.m: (-[WebLocationChangeHandler receivedPageIcon:forDataSource:]): renamed

WebBrowser:

Moved the default icon method to WebIconDatabase
Removed "icon URL" from the location change handler API

ABHomePagesController.m: (-[ABHomePagesController tableView:willDisplayCell:forTableColumn:row:]): call defaultIconWithSize
BrowserWindowController.m: (-[BrowserWindowController frameLoadCommitted:]): call defaultIconWithSize (-[BrowserWindowController setUpFavoritesBar]): call defaultIconWithSize
LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:forDataSource:]): renamed, don't use icon URL anymore
LocationTextField.m: (-[LocationTextField setDisplayAttributes]): call defaultIconWithSize (-[LocationTextField textDidChange:]): call defaultIconWithSize
RendezvousController.m: (-[RendezvousController _iconForServiceDictionary:]): call defaultIconWithSize
TitleBarButton.m: (-[TitleBarButton initWithFrame:]): call defaultIconWithSize
WebBrowser.pbproj/project.pbxproj:

9:50 AM Changeset in webkit [1952] by kocienda

11 edits in trunk/WebKit

WebFoundation:

More work on WebFoundation refactoring. This change concentrates on two
major areas:

1) Cleaning up the WebResourceHandle class by separating out the methods

of this class into separate files based on method visibility.

2) Added a new WebResourceRequest class that serves to collect the

information about a load request instead of having this information
sprinkled through the WebResourceHandle class.

With this initial WebResourceRequest revision, there isn't very much extra or
different about the API or the way clients use WebFoundation. Further changes
are planned very soon. These upcoming changes and will modify and enhance the API.

Note that these changes, while they touch a lot of code, should not break any
functionality of the framework or of Alexander.

WebKit:

Modify calls into WebFoundation to use the new WebResourceRequest class,
and the modified API that kicks off load requests using WebResourceHandle.
More changes are planned for this code as the WebFoundation API modifications
progress.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:])
Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:])
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:])
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:])

WebBrowser:

Small tweaks to use new WebFoundation WebResourceRequest object when requesting
the "original URL" for a load.

BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]) (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:])
WebBrowser.pbproj/project.pbxproj

9:30 AM Changeset in webkit [1951] by darin

4 edits in trunk/WebKit

Fix a reproducible crash pulling down the Go menu.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Add a missing retain.

WebKit.pbproj/project.pbxproj: Project Builder wants what it wants.

Sep 2, 2002:

11:28 PM Changeset in webkit [1950] by cblu

8 edits
3 adds in trunk/WebKit

WebKit:

First implementation of the icon DB.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): calls retainIconForSiteURL: or releaseIconForSiteURL: (-[WebHistoryItem initWithURL:target:parent:title:]): call _retainIconInDatabase: (-[WebHistoryItem dealloc]): call _retainIconInDatabase: (-[WebHistoryItem icon]): call iconForSiteURL:withSize: (-[WebHistoryItem setURL:]): call _retainIconInDatabase: (-[WebHistoryItem initFromDictionaryRepresentation:]): call _retainIconInDatabase:
Misc.subproj/WebIconDatabase.h: Added.
Misc.subproj/WebIconDatabase.m: Added. (+[WebIconDatabase sharedIconDatabase]): (-[WebIconDatabase init]): (-[WebIconDatabase iconForSiteURL:withSize:]): (-[WebIconDatabase setIcon:forSiteURL:]): (-[WebIconDatabase setIcon:forHost:]): (-[WebIconDatabase retainIconForSiteURL:]): (-[WebIconDatabase releaseIconForSiteURL:]): (-[WebIconDatabase delayDatabaseCleanup]): (-[WebIconDatabase allowDatabaseCleanup]): (-[WebIconDatabase applicationWillTerminate:]): (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconForIconURL:]): (-[WebIconDatabase _iconsForIconURL:]): (-[WebIconDatabase _iconForFileURL:withSize:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forSiteURL:]): (-[WebIconDatabase _setBuiltInIcon:forHost:]): (-[WebIconDatabase _retainIconForIconURL:]): (-[WebIconDatabase _releaseIconForIconURL:]): (-[WebIconDatabase _retainFutureIconForSiteURL:]): (-[WebIconDatabase _releaseFutureIconForSiteURL:]): (-[WebIconDatabase _retainOriginalIconsOnDisk]): (-[WebIconDatabase _releaseOriginalIconsOnDisk]): (-[WebIconDatabase _sendNotificationForSiteURL:]): (-[WebIconDatabase _addObject:toSetForKey:inDictionary:]): (-[WebIconDatabase _uniqueIconURL]): (-[WebIconDatabase _cachedIconFromArray:withSize:]): (-[WebIconDatabase _scaleIcon:toSize:]):
Misc.subproj/WebIconDatabasePrivate.h: Added.
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (+[WebIconLoader iconForFileAtPath:]): (-[WebIconLoader startLoading]): (-[WebIconLoader handleDidFinishLoading:data:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):

WebBrowser:

Start using the icon DB.

AppController.m: (-[AppController _installBuiltItIcons]): (-[AppController awakeFromNib]): call _installBuiltItIcons, there might be a better place for this.
LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:fromURL:forDataSource:]): use the icon db instead of the passed icon
WebBrowser.pbproj/project.pbxproj:

4:35 PM Changeset in webkit [1949] by hyatt

4 edits in trunk/WebCore

Tweak the damage rect testing to account for the fact that a child
layer may fall entirely outside the bounds of its parent layer.

khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

Aug 31, 2002:

9:44 AM Changeset in webkit [1948] by darin

7 edits in trunk/WebCore

fixed 3038336 -- repro crash in QTextDecoder trying to display UTF-16 file

kwq/mac-encodings.txt: Hook up the UTF-16 encoding to the name iso-10646-ucs-2. We have a long way to go to get this right. There are almost certainly going to be other bugs with 16-bit character pages.

kwq/KWQKHTMLSettings.mm: (KHTMLSettings::encoding): Just return "latin1", not "NSISOLatin1StringEncoding".

kwq/KWQString.mm: (QString::fromStringWithEncoding): Pass true for the "pay attention to BOM" flag.

khtml/rendering/render_object.cpp: Take out unneeded APPLE_CHANGES.

Aug 30, 2002:

2:52 PM Changeset in webkit [1947] by kocienda

4 edits in trunk/WebKit

Removed one last reference to the now-removed WebDefaultMIMEType symbol.
I missed it earlier.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:])

2:24 PM Changeset in webkit [1946] by kocienda

5 edits in trunk/WebCore

Fixed a problem in this function where broken UTF-8 would cause a crash.

WebCore.pbproj/project.pbxproj:
kwq/KWQString.mm: (QString::fromStringWithEncoding)

1:13 PM Changeset in webkit [1945] by kocienda

5 edits in trunk/WebKit

WebFoundation:

Failed to remove debugging spam before my last checkin. Sorry.

CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentType])
CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager requestWithURLHandle:])
Misc.subproj/WebFileTypeMappings.m: (-[WebFileTypeMappings MIMETypeForExtension:])

WebKit:

Failed to remove debugging spam before my last checkin. Sorry.

WebKit.pbproj/project.pbxproj:
WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:])

1:08 PM Changeset in webkit [1944] by kocienda

4 edits in trunk/WebKit

WebFoundation:

Begin to refactor WebFoundation in preparation for some planned API changes.
This change removes all WebResourceHandle subclasses, pushing the functionality
that was contained in those classes to the corresponding WebProtocolHandler
subclasses. To make this work, I also did a small amount of mime type cleanup, and
as a bonus, I (unintentionally) managed to fix these two bugs:

Radar 3034795 (README fiel displays as HTML even though it's plain text)
Radar 3035320 (iana.org character sets page displays as HTML even though it's MIME type text/plain)

Bonus! :-)

Removed:

CacheLoader.subproj/WebAboutResource.h
CacheLoader.subproj/WebAboutResource.m
CacheLoader.subproj/WebFileResourceHandle.h
CacheLoader.subproj/WebFileResourceHandle.m
CacheLoader.subproj/WebHTTPResourceHandle.h
CacheLoader.subproj/WebHTTPResourceHandle.m

WebKit:

WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): Small tweak to account for change in behavior of a WebFoundation method upon which this method depends. The WebFoundation now returns nil when it cannot find a suitable mime type rather than returning a default. This function now checks for a nil return value and sets @"application/octet-stream" in that case.

12:03 PM Changeset in webkit [1943] by rjw

1 edit in trunk/WebCore/force-clean-timestamp

Force clean for decoder.h buffer class change.

11:51 AM Changeset in webkit [1942] by rjw

4 edits in trunk/WebCore

Removed debugging log.

kwq/KWQString.mm: (QString::fromStringWithEncoding):

11:45 AM Changeset in webkit [1941] by rjw

9 edits in trunk

Made decoder more robust wrt nulls in content. Changed use
of QCString to null safe QString rather than modify
content.

khtml/misc/decoder.cpp: (Decoder::decode): (Decoder::flush):
khtml/misc/decoder.h:
kwq/KWQString.mm: (QString::fromStringWithEncoding):

Change link dragging behavior. Drags URL, not URL contents.
Still need to generate better image for dragging, will copy OmniWeb
and drag link text.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

10:50 AM Changeset in webkit [1940] by darin

17 edits in trunk/WebCore

fixed 3027407 -- Console error refers to closed bug

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Update bug number from 2959902 to 2942073.

fixed 3027532 -- can't tab into or out of textareas

kwq/KWQTextArea.h: Add setFont:.
kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Make a KWQTextAreaTextView. (-[KWQTextArea textDidChange:]): Send text changed messages when the text is changed, not when done editing. I did this for KWQNSTextField a while ago; it's tragic that AppKit leads us to have two separate classes for these nearly identical purposes. (-[KWQTextArea setFont:]): Call setFont on the text view. (-[KWQTextArea becomeFirstResponder]): Call makeFirstResponder on the text view. (-[KWQTextArea nextKeyView]): Do that voodoo, just like KWQNSTextField. (-[KWQTextArea previousKeyView]): Ditto. (-[KWQTextArea nextValidKeyView]): Ditto. (-[KWQTextArea previousValidKeyView]): Ditto. (-[KWQTextAreaTextView insertTab:]): Select the next key view. We don't get this automatically because this is not a field editor. But being a field editor leads to other unwanted behavior. (-[KWQTextAreaTextView insertBacktab:]): Ditto. (-[KWQTextAreaTextView becomeFirstResponder]): Select all on entry. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Don't draw insertion point when we are not the first responder. (-[KWQTextAreaTextView selectedTextAttributes]): Don't draw the selection when we are not the first responder.

kwq/qt/qtextedit.h:
kwq/KWQTextEdit.mm: (QTextEdit::setFont): Call -[KWQTextArea setFont:]. (QTextEdit::focusPolicy): Always return TabFocus, because the top level widget is not an NSControl so QWidget::focusPolicy does not suffice.

kwq/qt/qwidget.h: Make focusPolicy virtual.

kwq/qt/qfont.h:
kwq/KWQFont.mm: (QFont::getNSFont): Add this helper function so we don't have to repeat this in multiple places.

kwq/KWQLineEdit.mm: (QLineEdit::setFont): Use QFont::getNSFont.

force-clean-timestamp: For you poor bastards who aren't using the new Project Builder yet.

10:21 AM Changeset in webkit [1939] by darin

11 edits in trunk

JavaScriptCore:

JavaScriptCore.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebFoundation:

WebFoundation.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebCore:

WebCore.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebKit:

WebKit.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebBrowser:

WebBrowser.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

Aug 29, 2002:

4:43 PM Changeset in webkit [1938] by hyatt

13 edits in trunk/WebCore

Begin connecting the layer system. The root box and the <html>
box now construct layers for themselves. Those layers are
connected in a layer tree properly and they correctly update
their positions.

Implemented all the code for layer construction and for keeping
the layer tree in sync with the render object tree.

The goal is to get the layer tree fully constructed and correct
(with lots of testing) before actually switching over to it for
painting.

This change requires a clean of WebCore.

force-clean-timestamp:
khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::~RenderBox): (RenderBox::setPos): (RenderBox::positionChildLayers):
khtml/rendering/render_box.h:
khtml/rendering/render_container.cpp: (RenderContainer::~RenderContainer): (RenderContainer::addChild): (RenderContainer::removeChildNode):
khtml/rendering/render_container.h:
khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml):
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.h:
khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot):

12:17 PM Changeset in webkit [1937]

3 copies in tags/Alexander-21

This commit was manufactured by cvs2svn to create tag 'Alexander-21'.

12:17 PM Changeset in webkit [1936] by sheridan

8 edits in trunk

Alex-21 versions & markers

Aug 28, 2002:

11:32 PM Changeset in webkit [1935] by hyatt

5 edits in trunk/WebCore

Implement the flattening algorithm that walks the layer
hierarchy and produces the correct layer list for back
to front painting. (Still under construction. Not used yet.)

khtml/rendering/render_layer.cpp: (sortByZOrder): (RenderLayer::RenderZTreeNode::constructLayerList):
khtml/rendering/render_layer.h:

10:37 PM Changeset in webkit [1934] by darin

4 edits in trunk/WebKit

fixed 3036440 -- Crash running PLT with "Check for 'world leaks'" enabled

WebView.subproj/WebDataSourcePrivate.h: Add defersCallbacks boolean.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setController:]): Don't try to look at the controller before, it might already be deallocated. (-[WebDataSource _defersCallbacksChanged]): Use a boolean to record whether the "defers callbacks" state changed since last time and do no work if it didn't. This replaces the check in _setController:.

6:00 PM Changeset in webkit [1933] by rjw

4 edits in trunk/WebCore

More tweaks to ccs.
Added underline to visited links.
Made outline for active normal and visited links gray.

khtml/css/html4.css:

5:05 PM Changeset in webkit [1932] by rjw

8 edits in trunk

Tell CG to not use time expiration of glyph cache and increase it's
size.

THIS CHANGE REQUIRES THAT YOU INSTALL THE CG ROOT.

WebCoreSupport.subproj/WebTextRendererFactory.m:

Fixed outline of for active link style.

khtml/css/html4.css:
kwq/KWQPainter.mm: (QPainter::drawLine):

3:32 PM Changeset in webkit [1931] by hyatt

7 edits in trunk/WebCore

Adding knowledge to the style system of auto z-indices. The old
code doesn't use this yet, but the new layering code will.

Also wrote the ztree construction function (not used yet) and
stubbed out the display list flattening routines.

khtml/rendering/render_layer.cpp: (RenderLayer::convertToLayerCoords): (RenderLayer::constructZTree): (RenderLayer::constructLayerList):
khtml/rendering/render_layer.h:
khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData):
khtml/rendering/render_style.h:

11:02 AM Changeset in webkit [1930] by darin

4 edits in trunk/WebCore

fixed 2977587 -- JavaScript code that reads the values of text areas misses the last line if no trailing CR

kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]):

10:42 AM Changeset in webkit [1929] by rjw

3 edits in trunk/WebKit

Fixed selection horkage I introduced with drag
fix yesterday.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

1:54 AM Changeset in webkit [1928] by hyatt

4 edits in trunk/WebCore

Putting design notes and API details for the layering system
into the header file.

khtml/rendering/render_layer.h:

12:30 AM Changeset in webkit [1927] by darin

5 edits in trunk/WebCore

kwq/mac-encodings.txt: Sort all the character set names alphabetically, and use all lower case.
kwq/make-charset-table.pl: Require lower-case sorted lists of character set names.

12:09 AM Changeset in webkit [1926] by darin

4 edits in trunk/WebCore

fixed 3032148 -- Button not disabled in page

kwq/KWQWidget.mm: (QWidget::setEnabled): Call setEnabled: on the NSView if it implements it.

12:04 AM Changeset in webkit [1925] by darin

4 edits in trunk/WebCore

fixed 3030212 -- Problems rendering pages that specify "x-mac-roman" character set (like our Danish help pages)

kwq/mac-encodings.txt: Added x-mac-roman as an alias for macintosh.

Aug 27, 2002:

9:17 PM Changeset in webkit [1924] by darin

4 edits in trunk/WebCore

force-clean-timestamp: Dave's changes require a full build. I found out the hard way, by debugging for a while.

6:37 PM Changeset in webkit [1923] by rjw

13 edits in trunk

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): (-[WebHTMLView mouseDragged:]): (-[WebHTMLView mouseMovedNotification:]):
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m:

Fixed active link style. Cleaned up and fixed drag initiation
for links and images. Dotted lines not drawing correcly, but
other styles are applied correctly.

WebKit.exp:
History.subproj/WebHistory.h:
History.subproj/WebHistory.m:

Added some constants.

WebCoreSupport.subproj/WebTextRendererFactory.m:

Code to change CG caching policy. Not enabled until
we receive a root from CG team.

kwq/WebCoreBridge.h:

Fixed constants to conform to WebKit. These need to be shared.

6:35 PM Changeset in webkit [1922] by hyatt

8 edits
2 adds in trunk/WebCore

Change relative positioned blocks so that they are treated as special objects and
painted last along with absolutely positioned blocks and floaters. Note that the
entire special object system is fundamentally flawed, and it needs to be replaced
with a real layering subsystem.

This checkin at least gets relatively positioned divs painting correctly some of
the time (in the cases where the containing blocks of absolute and relative positioned
divs happen to be the same). It does not, however, deal with the problem of ensuring
correct stacking of positioned elements with different containing blocks.

render_layer.h and .cpp include a new implementation (not used yet, just the beginnings)
of a layering subsystem that I am going to be working on over the next few days
that will eventually be responsible for handling event dispatching and painting and that
will also understand how to deal with form controls and other objects that have Cocoa
views.

WebCore.pbproj/project.pbxproj:
khtml/rendering/render_box.cpp: (RenderBox::RenderBox):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::printObject): (RenderFlow::printSpecialObjects): (RenderFlow::layoutSpecialObjects): (RenderFlow::layoutBlockChildren): (RenderFlow::insertSpecialObject):
khtml/rendering/render_flow.h:
khtml/rendering/render_layer.cpp: Added. (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::addChild): (RenderLayer::removeChild):
khtml/rendering/render_layer.h: Added.

5:14 PM Changeset in webkit [1921] by darin

4 edits in trunk/WebCore

fixed 3031952 -- null-dereference in dispatchToUInt32 closing window

khtml/ecma/kjs_window.cpp: (History::getValueProperty): Use Undefined(), not Value() for an error result. Value() is pure evil.

4:25 PM Changeset in webkit [1920] by darin

9 edits in trunk/WebCore

fixed 3021018 -- Crash selecting from popup just after choosing radio button

kwq/KWQComboBox.mm: (QComboBox::QComboBox): Pass the widget in when creating the cell. (-[KWQPopUpButtonCell initWithWidget:]): Store a widget pointer. (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Get to the bridge and tell it to defer loading while we track the mouse.

kwq/KWQKHTMLPartImpl.h: Add bridgeForWidget.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewForWidget): Use nodeForWidget and partForNode. (KWQKHTMLPartImpl::bridgeForWidget): Added. Use nodeForWidget and partForNode. (KWQKHTMLPartImpl::partForNode): Move code here from nextKeyViewForWidget. (KWQKHTMLPartImpl::nodeForWidget): Move code here from nextKeyViewForWidget.

kwq/WebCoreBridge.h: Add defersLoading and setDefersLoading. Both are already in WebKit.

3:52 PM Changeset in webkit [1919] by darin

7 edits in trunk/WebKit

fixed 3031583 -- directory.apple.com now gives "unsupported" redirect

WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Don't create the resource handle here. It's a bit too early.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Create the resource handle here, now that we have a controller to get a user agent from.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleWillUseUserAgent:forURL:]): Add an assert that will catch any future problems of this kind.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge defersLoading]): Added. New call for use in WebCore. (-[WebBridge setDefersLoading:]): Added. New call for use in WebCore.

Aug 26, 2002:

5:19 PM Changeset in webkit [1918] by hyatt

4 edits in trunk/WebCore

Fix for 3026006. Ensure that TABLES inside <div>s with align="right"
are properly positioned. <div align="right"> was completely
unimplemented. This patch implements it for the common cases
(nested divs, tables within divs, and paragraphs).

khtml/css/html4.css:

2:33 PM Changeset in webkit [1917] by darin

11 edits in trunk/WebKit

Add machinery for deferring callbacks. Not used yet.

WebView.subproj/WebControllerPrivate.h: Add methods.
WebView.subproj/WebControllerPrivate.m: (-[WebController _defersCallbacks]): Returns old state. (-[WebController _setDefersCallbacks:]): Changes state and calls _defersCallbacksChanged on the main frame.

WebView.subproj/WebFramePrivate.h: Add _defersCallbacksChanged.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _defersCallbacksChanged]): Calls _defersCallbacksChanged on both data sources.

WebView.subproj/WebDataSourcePrivate.h: Add _defersCallbacksChanged.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setController:]): Call _defersCallbacksChanged if changing the controller changes the state. (-[WebDataSource _addResourceHandle:]): Call setDefersCallbacks:YES on the new handle if we are already attached to a controller that defers callbacks. (-[WebDataSource _defersCallbacksChanged]): Call setDefersCallbacks on all the handles, and call _defersCallbacksChanged on the child frames as well.

WebView.subproj/WebDataSource.m: (-[WebDataSource controller]): We need to know about all controller changes, so it's unacceptable to consult our parent about the controller. But we already do know about it and this code was unnecessary. Leave the old code around as an assert only.

2:21 PM Changeset in webkit [1916] by darin

4 edits in trunk/WebCore

khtml/rendering/render_list.cpp: Make file match the original KDE more closely (no substantive change).

1:50 PM Changeset in webkit [1915] by rjw

12 edits
2 adds in trunk

WebBrowser:

History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (+[WebHistory webHistoryWithFile:]): Stage 1, set the shared history instance. This'll move to WebKit soon.

WebView.subproj/WebView.m: (-[WebView setFrame:]): Only force display if in live resize.

WebKit

Fixed for 2883623 (visited links only). Will change
w/ stage 2 of history move to webkit.

GlobalHistory.m: (-[GlobalHistory awakeFromNib]):

WebCore:

WebCore.exp:

Added WebCoreHistory

WebCore.pbproj/project.pbxproj:

Added WebCoreHistory

kwq/KWQKHistoryProvider.mm: Use WebCoreHistory to determine visited link.

kwq/WebCoreHistory.h: Added.
kwq/WebCoreHistory.m: Added.

Stage 1. Use WebKit's WebHistory. Writing
of history and initialization still handled
by Alex until stage 2.

(+[WebCoreHistory setSharedHistory:]):
(+[WebCoreHistory sharedHistory]):
(-[WebCoreHistory containsURL:]):

kwq/KWQString.mm: (QString::compare):

Optimization, use strcmp when both src and dst have valid ascii.

1:35 PM Changeset in webkit [1914] by hyatt

5 edits in trunk/WebCore

Patch drawText to understand right-aligned drawing.
Fixed <ul> bullets so that they position properly.
Fixed bugs with horizontal and vertical positioning of <ol> bullets.

khtml/rendering/render_list.cpp: (RenderListMarker::printObject):
kwq/KWQPainter.mm: (QPainter::drawText):

7:27 AM Changeset in webkit [1913] by sullivan

5 edits in trunk/WebKit

WebKit:

fixed bug where dragging a separator in the Bookmarks window would hit an assertion.

Bookmarks.subproj/WebBookmarkSeparator.m: (-[WebBookmarkSeparator initWithGroup:]): Removed obsolete assertion that group is not nil.
Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initWithTitle:group:]): Removed a similar obsolete assertion here.
Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initWithTitle:group:]): Removed a similar obsolete assertion here.

WebBrowser:

fixed bug where new separator would not be scrolled into view if necessary.

BookmarksController.m: (-[BookmarksController _focusOnNewlyCreatedBookmark:]): Scroll to reveal new item.

Aug 24, 2002:

11:41 PM Changeset in webkit [1912] by darin

5 edits in trunk/WebCore

fixed 3032072 -- Crash on reload in DOM::DocumentImpl::~DocumentImpl [unified]()

This was a tough one to debug.
Turned out to be a subtle bug in our new QConstString implementation.

kwq/KWQString.mm: (QStringData::makeAscii): Don't invalidate the Unicode buffer unless the ASCII buffer is taking over the internal buffer from the Unicode. In other cases, it's important not to invalidate the Unicode because it can result in the Unicode being freed and re-created when unicode() is called, which is disastrous in the QConstString case because we can't free the Unicode. (QStringData::makeUnicode): Make the corresponding change for ASCII too. In this case, it's just an optimization, not a bug fix. (QString::insert), (QString::remove), (QString::fill), (QString::operator+=): Mark the other string invalid whenever we modify either the ASCII or the Unicode string. This was handled correctly for some operations before, but not all, and it now matters because makeAscii and makeUnicode will now allow this state.

Fixed a separate QString problem; I think I may have introduced this one.

kwq/KWQString.mm: (QString::getNSString): Since by ASCII, we actually mean ISO Latin 1, we can't use [NSString stringWithCString:]. Use CFStringCreateWithCString instead, pass CFStringCreateWithCString as the encoding, and use autorelease. We shouldn't really use the term ASCII in this class for the 8-bit-per-character buffer. Something more like Latin1 would be a more accurate way to refer to it. Maybe I'll do that renaming after talking to Richard about it on Monday.

Fixed a small storage leak.

khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cleanup): Added braces to fix obviously-incorrect if/else grouping.

Aug 23, 2002:

2:25 PM Changeset in webkit [1911] by darin

4 edits in trunk/WebKit

WebKit:

WebView.subproj/WebFrame.m: (-[WebFrame reset]): Remove unneeded call to _reset.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]): Add code that removes the KHTML stuff from the frame when switching to another type of view. It would be better to do this at some other level, but without this code, we end up leaving the entire KHTMLView behind when we switch to a non-HTML page.

WebBrowser:

Debugging tool to make it easy to reproduce problems like 3021018, where
a page transition happens while you are holding a menu down.

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add "Go to about:blank Soon menu item". (-[BrowserDocument goToAboutBlankSoon:]): Implementation.

10:28 AM Changeset in webkit [1910] by darin

4 edits in trunk/WebCore

Got the kurl-test in the Tests directory working again.

kwq/KWQKURL.mm: (KURL::KURL): Fixed problem where relative path resolution code for "../" could eat up the host name too, treating it as part of the path.

10:16 AM Changeset in webkit [1909] by darin

6 edits in trunk/WebCore

fixed 3032058 -- Links on local developer doc pages all broken (all local files?)

kwq/KWQKURL.mm: (KURL::getNSURL): Re-added a workaround for CFURL bug 2908969. We have to hack to make NSURL take "file:/" URLs.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Add a nil check. I ran into this because my frame failed to load.

3:24 AM Changeset in webkit [1908] by mjs

6 edits in trunk/WebCore

A few more KURL changes that reduce it down to background noise
level.

For me this gave another 1-2% improvement on cvs-base.

kwq/kdecore/kurl.h:
kwq/KWQKURL.mm: (KURL::KURL): In the relative constructor, do all work in a char array for the relative path case, and leave it up to ::parse to create a QString. (KURL::parse): Do all work in a char array, only creating a QString at the end if needed. Also, take an optional pointer to the QString that the char * was created from, and if the final processed URL is the same as the original, assign the original instead of creating a new QString. (KURL::setProtocol): Adjust for prase() interface change. (KURL::setHost): Likewise. (KURL::setPort): Likewise. (KURL::setRef): Likewise. (KURL::setQuery): Likewise. (KURL::setPath): Likewise. (appendEscapingBadChars): Instead of taking and returning a QString like the old escapeBadChars, copy from and write into existing C string buffers.

Aug 22, 2002:

11:14 PM Changeset in webkit [1907] by darin

4 edits in trunk/WebCore

force-clean-timestamp: Without this, I crash on startup.

8:39 PM Changeset in webkit [1906] by mjs

7 edits in trunk/WebCore

top level:

Fix test results to no longer reflect KURL or CFURL oddities that
we are not emulating.

Tests/kde/kurl-test.chk:
Tests/kde/kurl-test.cpp: (testURL): Replay mistaken n with \n.

WebCore:

Brand new KURL implementation which avoids CFURL, CFString, and
all that other allocation-happy goodness and instead does as much
work as possible with raw ASCII buffers.

For me this gave a ~5% performance improvement on cvs-base.

kwq/KWQKURL.mm: (KURL::KURL): (KURL::hasPath): (KURL::protocol): (KURL::host): (KURL::port): (KURL::pass): (KURL::user): (KURL::ref): (KURL::query): (KURL::path): (KURL::setProtocol): (KURL::setHost): (KURL::setPort): (KURL::setRef): (KURL::setQuery): (KURL::setPath): (KURL::prettyURL): (KURL::decode_string): (escapeBadChars): (KURL::parse): (KURL::getNSURL):
kwq/kdecore/kurl.h:
khtml/khtml_part.cpp: (KHTMLPart::end): Don't call KURL::clearCaches() any more.

5:11 PM Changeset in webkit [1905] by darin

5 edits in trunk/WebCore

kwq/KWQButton.mm: (QButton::~QButton): Disconnect the view from the widget by doing setTarget:nil.
kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Ditto.

4:57 PM Changeset in webkit [1904] by hyatt

4 edits in trunk/WebCore

Add vertical margins for checkboxes and radios. A later rule
in the file was overriding my earlier attempt to set up these margins.

khtml/css/html4.css:

4:50 PM Changeset in webkit [1903] by rjw

6 edits in trunk/WebCore

New faster char * append (actually insert) for mjs.

kwq/KWQString.mm: (QString::insert):
kwq/qt/qstring.h:

3:37 PM Changeset in webkit [1902] by rjw

10 edits in trunk/WebKit

i Changed public string from #define to extern NSString.

WebKit.exp:
WebView.subproj/WebController.h:
WebView.subproj/WebController.m:
WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterCheckingDragForEvent:]):

12:14 PM Changeset in webkit [1901] by darin

6 edits in trunk/WebCore

Some small QString improvements.

kwq/qt/qstring.h: Add printf attribute to sprintf member function.
kwq/KWQString.mm: Remove extra \n characters from QSTRING_FAILURE calls. Change some fprintf to QSTRING_FAILURE. Change some QSTRING_FAILURE to KWQ_ASSERT. (QStringData::makeAscii): Fix bug where it would update _maxAscii with a new size even when it didn't allocate a new buffer. (QStringData::makeUnicode): Fix bug where it would update _maxUnicode with a new size even when it didn't allocate a new buffer. (QString::utf8): Fix bug where it assumed the UTF-8 form of a string has the same length as the Unicode version. Also save one allocation by doing it right into the QCString. (QString::local8Bit): Just call utf8(). (QString::setNum): Have all these call our sprintf. (QString::sprintf): Format once to get the length. Then do the second format right into the string buffer. This way we don't have to do any allocation at all, nor use CFString.

11:22 AM Changeset in webkit [1900] by kocienda

4 edits in trunk/WebKit

Passing the main load's attributes to the subresource loads causes
breakage (most visible when we POST).

Right now, we just rely on flags to handle "back/forward" loads, so
the attributes were not actually being used.

A better fix needs to be put in place when the soon-to-be-done
attributes/flags rework is done.

WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]):

10:52 AM Changeset in webkit [1899]

3 copies in tags/Alexander-20

This commit was manufactured by cvs2svn to create tag 'Alexander-20'.

10:52 AM Changeset in webkit [1898] by vicki

8 edits in trunk

Alex-20

8:01 AM Changeset in webkit [1897] by darin

4 edits in trunk/WebCore

Fixed a one-click crasher that Ken and Don told me about.

kwq/KWQObject.mm: (QObject::QObject): Initialize m_eventFilterObject.

Aug 21, 2002:

6:21 PM Changeset in webkit [1896] by rjw

27 edits in trunk/WebKit

Simple name change. Plugin -> NetscapePlugin in anticipation
of other plugin related API.

Removed vestigal WebDocumentLoading.

Plugins.subproj/WebPlugin.h:
Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]):
Plugins.subproj/WebPluginDatabase.h:
Plugins.subproj/WebPluginDatabase.m: (+[WebNetscapePluginDatabase installedPlugins]): (-[WebNetscapePluginDatabase pluginForMimeType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginWithFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
Plugins.subproj/WebPluginNullEventSender.h:
Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
Plugins.subproj/WebPluginStream.h:
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:attributes:]):
Plugins.subproj/WebPluginView.h:
Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView provisionalDataSourceChanged:]): (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): (-[WebNetscapePluginView destroyStream:reason:]):
WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory pluginsInfo]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (+[WebController canShowMIMEType:]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView provisionalDataSourceChanged:]): (-[WebHTMLView provisionalDataSourceCommitted:]): (-[WebHTMLView dataSourceUpdated:]):
WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):
WebView.subproj/WebImageView.h:
WebView.subproj/WebTextView.h:
WebView.subproj/WebView.h:
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

Still need to muck with cvs server to change file names.

4:37 PM Changeset in webkit [1895] by darin

4 edits in trunk/WebCore

fixed 3021908 -- text areas should be plain text only

kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): setRichText:NO (-[KWQTextArea dealloc]): Release the text view so we don't leak.

4:31 PM Changeset in webkit [1894] by darin

4 edits in trunk/WebCore

kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:]): Use bounds, not visibleRect. Seems to work better.

3:11 PM Changeset in webkit [1893] by sullivan

5 edits in trunk/WebCore

commented out (with FIXME 2935687) the code that was advertising in the status bar that shift-command would open a link behind the current window, since it doesn't.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL):

2:02 PM Changeset in webkit [1892] by darin

5 edits in trunk/WebCore

Fix for two problems with password fields.

1) Return wasn't working.

2) They were wrapping instead of scrolling.

kwq/KWQNSTextField.mm: (-[KWQNSTextField setUpTextField:]): Shared initialization, needed by both the text field and the secure field. This includes the two things we needed for the password text field; wiring up action properly and setScrollable:YES. (-[KWQNSTextField initWithFrame:]): Use setUpTextField. (-[KWQNSTextField setPasswordMode:]): Use setUpTextField.

1:36 PM Changeset in webkit [1891] by hyatt

4 edits in trunk/WebCore

Fix for 3015372, tables and blocks nested inside other tables
don't center. This fixes a lot of sites, from the forum
sites to the www.ve3d.com voodooextreme site.

khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute):

12:51 PM Changeset in webkit [1890] by darin

11 edits
2 adds in trunk/WebCore

fixed 3027927 -- selected text fields do not cause the web view to scroll to reveal them

kwq/KWQNSTextField.mm: (-[KWQNSTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible]. (-[KWQSecureTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible].

kwq/KWQNSViewExtras.h: Added. New scrolling functions.
kwq/KWQNSViewExtras.m: Added. New scrolling functions.
WebCore.pbproj/project.pbxproj: Added KWQNSViewExtras.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Make sure superview and position is set up properly before we try to tab to something.
kwq/KWQWidget.mm: (QWidget::setFocus): Make sure superview and position is set up properly before we try to focus something.

Unrelated change.

kwq/KWQInvisibleButton.h:
kwq/KWQInvisibleButton.mm: Add KWQ prefix to the name of the private Objective C class to avoid potential conflicts.

10:15 AM Changeset in webkit [1889] by darin

21 edits in trunk/WebCore

Implemented baseline alignment for form elements. We decided that this was better
than what we're currently doing. But it will look even better when the font of the
text field matches the font of the surrounding text, so we should consider that.

I also nudged the text down one pixel in popup menus, to match buttons. I think we
probably should suggest that this be done in Aqua by default (buttons and popup menus
already match in the normal size; this is the small size).

khtml/rendering/render_form.h: Remove some APPLE_CHANGES.
khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): Use the widget's concept of the baseline position (the new QWidget::baselinePosition function). (RenderButton::baselinePosition): Just call the inherited version. (RenderSubmitButton::baselinePosition): Remove our ifdef because we want what the original code said, which was just calling the inherited version. (RenderLineEdit::baselinePosition): Removed our added method since we want to just call the inherited version. (RenderSelect::baselinePosition): Just call the inherited version for the pop up menu case. For the list box, just left the old code alone until someone can take a look at it.

kwq/qt/qwidget.h: Added new virtual baselinePosition function.
kwq/KWQWidget.mm: (QWidget::baselinePosition): Default for baseline is the bottom.

kwq/qt/qlineedit.h:
kwq/KWQLineEdit.mm: (QLineEdit::baselinePosition): Compute the baseline based on how NSTextField does it. Compared to the other widgets this was easy, because the cell's drawingRectForBounds gives you the place where the top of the line is. It does use defaultLineHeightForFont, which is not used by other widgets, but that's no real problem.

kwq/qt/qbutton.h:
kwq/KWQButton.mm: Moved all the code that's push-button specific into QPushButton.

kwq/qt/qpushbutton.h:
kwq/KWQPushButton.mm: (QPushButton::QPushButton): Set the bezel style of the button. (QPushButton::sizeHint): Moved here from QButton. (QPushButton::frameGeometry): Moved here from QButton. (QPushButton::setFrameGeometry): Moved here from QButton. (QPushButton::baselinePosition): Compute the baseline based on how NSButton does it. The rule for the style of button we use is "centered vertically in the available space, offset by kThemePushButtonSmallTextOffset", so I had to hardcode the value of kThemePushButtonSmallTextOffset; I called it VERTICAL_FUDGE_FACTOR (2).

kwq/qt/qcombobox.h:
kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell drawInteriorWithFrame:inView:]): Custom cell class that nudges the text down one pixel. (QComboBox::QComboBox): Attach the custom cell class. (QComboBox::baselinePosition): Compute the baseline based on how NSPopUpButton does it. The rule for the style of pop-up button we use is "CELLOFFSET pixels down from the top", so I had to hardcode the value of CELLOFFSET; I called it VERTICAL_FUDGE_FACTOR (2).

force-clean-timestamp: Yes, again.

12:47 AM Changeset in webkit [1888] by hyatt

3 edits in trunk/WebKit

Raising the layout delay from 0.75 to 1.00. This should be
a little more conservative and matches the value used by Gecko.

WebView.subproj/WebPreferences.m: (+[WebPreferences load]):

Aug 20, 2002:

10:23 PM Changeset in webkit [1887] by darin

5 edits in trunk/JavaScriptCore

Three small changes to things that showed up in the sample.

5% speed increase on cvs-js-performance test.

kjs/simple_number.h: Check if double is an integer with d == (double)(int)d instead of remainder(d, 1) == 0, saving a function call each time.

kjs/ustring.cpp: (UString::find): Compare the first character before calling memcmp for the rest. (UString::rfind): Ditto. (KJS::operator==): Don't do a strlen before starting to compare the characters.

5:16 PM Changeset in webkit [1886] by hyatt

3 edits in trunk/WebKit

Lower the paint/layout delay from 1.85 to 0.75, since we've
gotten a lot faster.

WebView.subproj/WebPreferences.m: (+[WebPreferences load]):

4:03 PM Changeset in webkit [1885] by darin

5 edits in trunk/WebCore

fix 3028936 -- fields are not submitting the correct data if they are selected when you submit

kwq/KWQNSTextField.mm: (-[KWQNSTextField controlTextDidChange:]): Call widget->textChanged and set edited to true here. The old code had two problems. First, it only sent textChanged from controlTextDidEndEditing. Second, it overrode textDidChange without calling super, preventing controlTextDidChange from being sent to the delegate.

3:56 PM Changeset in webkit [1884] by darin

3 edits in trunk/JavaScriptCore

Fix log typos.

3:27 PM Changeset in webkit [1883] by sullivan

4 edits in trunk/WebKit

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]): Fixed uninitialized variable that Maciej's deployment build found.

2:58 PM Changeset in webkit [1882] by sullivan

3 edits in trunk/WebKit

Fixed problem with previous checkin that was causing
drag-and-drop for files to fail (at least).

WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:]): pass isDirectory, not YES, to fileURLPolicyForMIMEType:inFrame:isDirectory:

2:53 PM Changeset in webkit [1881] by mjs

4 edits in trunk/JavaScriptCore

kjs/object.cpp: Don't reference other ValueImps in the destructor, they may ha ve already been destroyed, and will have GC_ALLOWED set already in any case.

2:16 PM Changeset in webkit [1880] by sullivan

14 edits in trunk/WebKit

WebKit:

WebKit part of fixes for:

3027491 -- failure loading frame's resource leads to misbehaving panel
3027494 -- failure loading frame's resource leads to error message in Alex, silence in IE
3027697 -- alert box for missing file covered by browser window; should be a sheet
3014123 -- error sheet when iframe has URL with bad path

Cleaned up the WebPolicy APIs to pass frames and URLs consistently. Also cleaned
up _shouldShowURL: (formerly _shouldShowDataSource:) method quite a bit.

WebView.subproj/WebControllerPolicyHandler.h:
WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]):
WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:inFrame:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:inFrame:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementPolicy:error:forURL:inFrame:]):
WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]): Made various Policy-related methods pass the frame and when necessary the URL instead of the dataSource (or not even that in some broken cases). Collapsed the three unableToImplementXXXPolicy: methods into one.

WebView.subproj/WebFramePrivate.h: Change _shouldShowDataSource: to _shouldShowURL:
WebView.subproj/WebFramePrivate.m: (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): New helper method. (-[WebFrame _shouldShowURL:]): use case statements instead of nested ifs; use handleUnimplementablePolicy: to reduce duplicated code; update for API changes; eliminate non-useful local variables.

WebBrowser:

WebBrowser part of fixes for:

3027491 -- failure loading frame's resource leads to misbehaving panel
3027494 -- failure loading frame's resource leads to error message in Alex, silence in IE
3027697 -- alert box for missing file covered by browser window; should be a sheet
3014123 -- error sheet when iframe has URL with bad path

BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): now pass frame to URLPolicyForURL:inFrame:

BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]): add frame parameter to match changed API (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): New method, replaces unableToImplementURLPolicy:error:forURL:, unableToImplementFileURLPolicy:error:forDataSource:, and unableToImplementContentPolicy:error:forDataSource:. Don't display error to user if it's not in the main frame. This matches the behavior of other browsers, and matches what Alexander does when a non-main-frame page fails to load.

(-[BrowserWebController fileURLPolicyForMIMEType:inFrame:isDirectory:]):
(-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]):
Updated signatures to match WebKit API changes.

12:55 PM Changeset in webkit [1879] by hyatt

5 edits in trunk/WebCore

Fix background positioning so that it works with table cells.
This fixes the tabs on www.msn.com.

khtml/rendering/render_box.cpp: (RenderBox::printBackground):
khtml/rendering/render_table.h:

12:51 PM Changeset in webkit [1878] by darin

3 edits in trunk/WebKit

fixed 3023076 -- Strange font chosen, widths screwed up, when text includes 007F characters

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Treat 007F as a control character, skipping it just as we do other control characters.

12:32 PM Changeset in webkit [1877] by darin

4 edits in trunk/WebKit

WebKit:

WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Lock in here, in anticipation of actually using the name in the user agent string.

WebBrowser:

BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Set up the application name to be used in the user agent string. For now, there is a dummy string in there.

12:15 PM Changeset in webkit [1876] by darin

23 edits in trunk

WebCore:

WebCore part of support for tabbing into and out of the toolbar.

kwq/KWQKHTMLPartImpl.h: Renamed static nextKeyView to nextKeyViewForWidget. Added nextKeyViewInFrameHierarchy.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrameHierarchy): New name for the old nextKeyView. (KWQKHTMLPartImpl::nextKeyView): Added. Does all the logic for handling views outside the frame hierarchy that used to be only in the static nextKeyView. (KWQKHTMLPartImpl::nextKeyViewForWidget): New name for the static nextKeyView, which now just does the widget-specific bits. Removed null check in here that's no longer needed.

kwq/KWQNSTextField.mm: Update to call nextKeyViewForWidget.

kwq/WebCoreBridge.h: Added nextKeyViewInsideWebViews, previousKeyViewInsideWebViews, nextKeyViewOutsideWebViews, and previousKeyViewOutsideWebViews.

kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebViews]): Call nextKeyViewInFrameHierarchy. (-[WebCoreBridge previousKeyViewInsideWebViews]): Call nextKeyViewInFrameHierarchy.

Introduced QString to sprong. See <http://www.goat.demon.co.uk/sprong.html>.
A few other tweaks to QString API; wean it from mutable strings.

kwq/qt/qstring.h:
kwq/KWQString.mm: Sprongify it. (QString::setBufferFromCFString): Add a fixed-size buffer to avoid malloc. (QString::getCFString): Replace getCFMutableString with this. (QString::getNSString): Use NSString directly.

kwq/KWQDictImpl.mm:
kwq/KWQKURL.mm:
kwq/KWQStringList.mm:
kwq/KWQtextcodec.mm:
kwq/WebCoreBridge.mm: Use getCFString, not getCFMutableString.

WebKit:

WebKit part of support for tabbing into and out of the toolbar.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge nextKeyViewOutsideWebViews]): Ask the main WebView for its nextKeyView on behalf of WebCore. (-[WebBridge previousKeyViewOutsideWebViews]): Ask the main WebView for its previousKeyView on behalf of WebCore.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): When we are being tabbed-into, make the first or last view in the bridge first responder, instead of taking it ourselves.

WebView.subproj/WebView.m: (-[WebView becomeFirstResponder]): Always make the document view the first responder instead of taking it ourselves.

WebBrowser:

fixed 2868093 -- Can't tab between toolbar items and main view

BrowserWindowController.m: (-[BrowserWindowController dealloc]): Cancel lingering perform requests. Good for the new one I added, but also for the status one. (-[BrowserWindowController clearStatus]): Don't bother calling centerTruncateString on @"". (-[BrowserWindowController leftmostToolbarKeyboardLoopItem]): Added. part of hack to make the toolbar loop stitch together with the rest of the views. (-[BrowserWindowController rebuildKeyboardLoop]): Added. Adds the web view into the keyboard loop along with the toolbar. (-[BrowserWindowController windowShouldRebuildKeyboardLoopSoon:]): Schedules a call to rebuildKeyboardLoop. We don't do the work right away because we need to wait until the toolbar is done with its loop calculations.

TextField.h: New methods for the window delegate.
TextField.m: (-[TextField windowShouldRebuildKeyboardLoopSoon]): Call windowShouldRebuildKeyboardLoopSoon on the window delegate. (-[TextField setNextKeyView:]): Call windowShouldRebuildKeyboardLoopSoon because a change in our next key view means that the toolbar is wiring up the keyboard loop. (-[TextField viewDidMoveToWindow]): Call windowShouldRebuildKeyboardLoopSoon because we are going back on screen, which means that the toolbar is likely coming back.

Aug 19, 2002:

7:53 PM Changeset in webkit [1875] by darin

4 edits in trunk/WebCore

force-clean-timestamp: Richard's changes require a clean build.

7:11 PM Changeset in webkit [1874] by rjw

8 edits in trunk/WebCore

QString rewrite. Much faster now.
QString has an inline rep, QStringData, which
has an inline character buffer. reps are
referenced indirectly via a handle. inline
reps are detached when necessary. Typical
stack based usage requires no allocations
for small string. Attempts are made to avoid
costly conversions between ascii and unicode.
Extensive diagnostics can be enable by
defining QSTRING_DEBUG_ALLOCATIONS and calling
_printQStringAllocationStatistics().

There appear to be a few small lingering leaks
that I need to track down.

WebCore-tests.exp:

Added symbols for qstring-test.cpp.

khtml/css/cssstyleselector.cpp:

Removed old string optimization hack.

kwq/KWQString.mm:

Rewrite.
(_isOnStack):
(countInstance):
(allocatedBuffers):
(ALLOC_CHAR):
(REALLOC_CHAR):
(DELETE_CHAR):
(ALLOC_QCHAR):
(REALLOC_QCHAR):
(DELETE_QCHAR):
(_printQStringAllocationStatistics):
(ucstrcmp):
(ucstrncmp):
(ucstrnicmp):
(ok_in_base):
(QStringData::QStringData):
(QStringData::initialize):
(QStringData::operator new):
(QStringData::operator delete):
(QString::makeSharedNullHandle):
(QString::makeSharedNull):
(QStringData::~QStringData):
(QStringData::ascii):
(QStringData::increaseAsciiSize):
(QStringData::unicode):
(QStringData::increaseUnicodeSize):
(QStringData::makeAscii):
(QStringData::makeUnicode):
(QString::setBufferFromCFString):
(QString::fromStringWithEncoding):
(QString::fromCFMutableString):
(QString::fromCFString):
(QString::fromNSString):
(QString::getCFMutableString):
(QString::getNSString):
(QString::~QString):
(QString::QString):
(QString::operator=):
(QString::at):
(QString::unicode):
(QString::compare):
(QString::startsWith):
(QString::endsWith):
(QString::latin1):
(QString::isNull):
(QString::find):
(QString::findRev):
(QString::contains):
(QString::toShort):
(QString::toUShort):
(QString::toInt):
(QString::toUInt):
(QString::toLong):
(QString::toULong):
(QString::toDouble):
(QString::findArg):
(QString::arg):
(QString::left):
(QString::right):
(QString::mid):
(QString::copy):
(QString::lower):
(QString::stripWhiteSpace):
(QString::simplifyWhiteSpace):
(QString::deref):
(QString::setUnicode):
(QString::setLatin1):
(QString::sprintf):
(QString::append):
(QString::insert):
(QString::detachInternal):
(QString::detach):
(QString::remove):
(QString::replace):
(QString::forceUnicode):
(QString::setLength):
(QString::truncate):
(QString::fill):
(QString::operator+=):
(QString::convertToQCString):
(operator==):
(QConstString::QConstString):
(QConstString::~QConstString):
(_initializeHandleNodeBlock):
(_allocatePageNode):
(_initializeHandleNodes):
(_allocateNode):
(allocateHandle):
(freeHandle):

kwq/qt/qstring.h: Rewrite

2:59 PM Changeset in webkit [1873] by mjs

6 edits
1 add in trunk/WebCore

Makefile.am: Added new mechanism to clean only the objects that depend on JavaScript.
force-js-clean-timestamp: Touched since I changed JSC just now.
.cvsignore: Ignore previous-js-clean-timestamp.

2:54 PM Changeset in webkit [1872] by darin

4 edits in trunk/WebCore

Fixed tab cycle on slashdot.org and elsewhere by being stricter about what is
included in the tab cycle.

kwq/KWQWidget.mm: (QWidget::focusPolicy): Use the same rule as AppKit.

2:36 PM Changeset in webkit [1871] by hyatt

5 edits in trunk/WebCore

Tweak baselines to look a little better for form controls.
This will be redone by Darin to really baseline align... this
is just temporary.

Also adding 3px margins to <input> and <textarea> and <select>.

khtml/css/html4.css:
khtml/rendering/render_form.cpp: (RenderButton::baselinePosition): (RenderSelect::baselinePosition):

2:29 PM Changeset in webkit [1870] by darin

5 edits in trunk/WebCore

fixed 3027791 -- Crash when pressing "tab" after going to http://slashdot.org/

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Add null check.

2:14 PM Changeset in webkit [1869] by mjs

5 edits in trunk/JavaScriptCore

Fixed the bug that made sony.com menus come out wrong and made
aa.com crash (Radar 3027762).

Mode most methods inline.

kjs/completion.cpp:
kjs/completion.h:

1:46 PM Changeset in webkit [1868] by cblu

3 edits in trunk/WebKit

Fixed 3025019: "only-if-cached" attribute fetches data from network if cached but expired

Misc.subproj/WebIconLoader.m: (-[WebIconLoader iconFromCache]):

1:11 PM Changeset in webkit [1867] by darin

8 edits in trunk/WebCore

Put in more robust version of the next/previous key view checking
that matches what I did in WebHTMLView.

kwq/KWQNSTextField.h: Add inNextValidKeyView instance variable.
kwq/KWQNSTextField.mm: (-[KWQNSTextField dealloc]): No need to nil out widget. (-[KWQNSTextField nextKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQNSTextField previousKeyView]): Only do the computation when called from previousValidKeyView. (-[KWQNSTextField nextValidKeyView]): Set boolean. (-[KWQNSTextField previousValidKeyView]): Set boolean. (-[KWQSecureTextField nextKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQSecureTextField previousKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQSecureTextField nextValidKeyView]): Set boolean. (-[KWQSecureTextField previousValidKeyView]): Set boolean.

Unrelated change.

kwq/mac-encodings.txt: Add an encoding name of gb18030, since I saw mention of it in bug 3002016.

11:59 AM Changeset in webkit [1866] by darin

11 edits in trunk

WebCore:

Support so that WebKit can tab into a web view's fields.

kwq/KWQKHTMLPartImpl.h: Made another nextKeyView() version public.
kwq/WebCoreBridge.h: Add new methods, change parameters to one existing one.
kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): Remove width and height parameters. The passed-in view already has the correct width and height. (-[WebCoreBridge nextKeyView]): Call nextKeyView() with node == 0. (-[WebCoreBridge previousKeyView]): Call nextKeyView() with node == 0.

WebKit:

fixed 2863025 -- Need to implement TABing between widgets in forms

Implemented tabbing into a web view's fields. I now consider the task of
tabbing between widgets done. But there are many loose ends, each with its
own bug report.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView dealloc]): Set _private to nil so we can properly handle calls that come from NSView dealloc. (-[WebHTMLView provisionalDataSourceChanged:]): No need to pass width and height to createKHTMLViewWithNSView any more. Also, just pass self rather than making the roung trip to the WebFrame and the WebView back here. (-[WebHTMLView nextKeyView]): Added. Calls the bridge version when we are called from nextValidKeyView, the normal version the rest of the time. (-[WebHTMLView previousKeyView]): Added. Calls the bridge version when we are called from nextValidKeyView, the normal version the rest of the time. (-[WebHTMLView nextValidKeyView]): Set inNextValidKeyView and call super. (-[WebHTMLView previousValidKeyView]): Set inNextValidKeyView and call super.
WebView.subproj/WebHTMLViewPrivate.h: Add inNextValidKeyView flag.

9:53 AM Changeset in webkit [1865] by darin

61 edits
3 deletes in trunk/WebCore

First cut at implementation of "tab to change focus": Lots of loose ends, but it's
going well.

kwq/KWQNSTextField.h: Change initWithWidget to initWithQLineEdit.
kwq/KWQNSTextField.mm: (-[KWQNSTextField initWithQLineEdit:]): Keep a QLineEdit pointer so we don't cast later. (-[KWQNSTextField dealloc]): Sets widget to 0 to make nextKeyView and previousKeyView return nil while deallocating. (-[KWQNSTextField setPasswordMode:]): Pass widget when creating secure text field so it can handle the next/previous links properly. (-[KWQNSTextField nextKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQNSTextField previousKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQTextFieldCell isOpaque]): Added. Returns NO; fixes focus rectangle updating. (-[KWQSecureTextField initWithQWidget:]): Added. (-[KWQSecureTextField dealloc]): Added. Sets widget to 0 to make nextKeyView and previousKeyView return nil while deallocating. (-[KWQSecureTextField nextKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQSecureTextField previousKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView.

kwq/KWQKHTMLPartImpl.h: Add KWQSelectionDirection. Change name of getBridge() to bridge(), getDocument() to document(), getRenderer() to renderer(), getBridgeForFrameName() to bridgeForFrameName(). Also added nextKeyView family of member functions.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Added. (KWQKHTMLPartImpl::nextKeyView): Added.

kwq/qt/qwidget.h: Remove unneeded parameters from constructor. Also added a constructor that takes an NSView.
kwq/KWQWidget.mm: (QWidget::QWidget): Don't store focus policy (it was uninitialized before). (QWidget::focusPolicy): Return TabFocus for any widget that has a view with a first responder, NoFocus for any other. (QWidget::setFocusPolicy): Do nothing. (QWidget::setFocusProxy): Do nothing.

kwq/qt/qobject.h: Store the event filter object when installEventFilter is called. This is used to find the RenderWidget for a QWidget by the new tabbing code.
kwq/KWQObject.mm: Removed event-filter functions. Two are now inlines, one deleted.

Other changes related to KWQKHTMLPartImpl improvements.

kwq/KWQKHTMLPartBrowserExtension.mm:
kwq/KWQKHTMLPartImpl.mm:
kwq/KWQLoaderImpl.mm:
kwq/WebCoreBridge.mm: Update for KWQKHTMLPartImpl member name changes.

Various improvements for other widget implementations.

kwq/qt/qbutton.h:
kwq/KWQButton.mm: Stop using KWQNSButton. Instead just use a button adapter object, and a plain old NSButton. (QButton::QButton): Put all the NSButton setup in here. (QButton::~QButton): Release the adapter here. (QButton::clicked): Move this in here because it's virtual now so that QCheckBox can override it. (-[KWQButtonAdapter initWithQButton:]): Added. (-[KWQButtonAdapter action:]): Just call clicked().

kwq/qt/qpushbutton.h: Don't pass unused parent pointer to QButton constructor.
kwq/KWQPushButton.mm: (QPushButton::QPushButton): Don't pass unused parent pointer to QButton contructor.

kwq/qt/qcheckbox.h:
kwq/KWQCheckBox.mm: Just use NSButton, not KWQNSButton. (QCheckBox::clicked): Move the state-changed logic here; used to be in KWQNSButton.

kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): Don't pass unused parent pointer to QButton contructor.

kwq/qt/qcombobox.h:
kwq/KWQComboBox.mm: (QComboBox::QComboBox): Removed extra constructor. Make a plain NSPopUpButton, and use an adapter object, rather than having a KWQNSComboBox. (QComboBox::~QComboBox): Release the adapter. (QComboBox::insertItem): New implementation. No need to keep an items array around, because the menu does that just fine. (QComboBox::clear): Remove the items from the pop-up button directly. (-[KWQComboBoxAdapter initWithQComboBox:]): Added. (-[KWQComboBoxAdapter action:]): Just call activated().

kwq/kdeui/kcombobox.h: Empty this out and make it use only inlines.

khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Remove the setSize()/doneLoading() optimization for QComboBox because the new simpler QComboBox implementation obviates the speed problem this was originally intended to fix.

kwq/qt/qlineedit.h:
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Call initWithQLineEdit instead of initWithWidget. Also don't take an unused parent pointer parameter.

kwq/kdeui/klineedit.h: Empty this out and make it use only inlines.

kwq/qt/qframe.h: Remove unused parent pointer from constructor.
kwq/KWQFrame.mm: Remove unneeded constructor.
kwq/KWQHBox.mm: (QHBox::QHBox): Don't pass unused parent pointer to QFrame.
kwq/KWQLabel.mm: (QLabel::QLabel): Don't pass unused parent pointer to QFrame.
kwq/qt/qscrollview.h: Make constructor inline.
kwq/KWQScrollView.mm: Remove unneeded constructor.
kwq/KWQWindowWidget.h: Remove unneeded constructor.

WebCore.pbproj/project.pbxproj: Remove KWQKComboBox.mm, KWQKLineEdit.mm, and KWQScrollBar.h.
kwq/KWQKComboBox.mm: Removed.
kwq/KWQKLineEdit.mm: Removed.
kwq/KWQScrollBar.h: Removed. Unused.

kwq/KWQTextArea.h: Change initWithWidget to initWithQTextEdit.
kwq/KWQTextArea.mm: (-[KWQTextArea initWithQTextEdit:]): Changed name.
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Call initWithQTextEdit instead of initWithWidget.

kwq/KWQView.h: Eliminated KWQNSButton, KWQNSComboBox, and KWQNSScrollView.
kwq/KWQView.mm: Ditto.

Housekeeping.

force-clean-timestamp: Yes, again.

khtml/khtml_part.h: Rearrange APPLE_CHANGES a bit.

kwq/qt/qvaluelist.h: Added -- as well as ++ for the const iterator, and fixed some minor const issues. At one point I needed this for the focus changes, but not any more.

1:54 AM Changeset in webkit [1864] by mjs

5 edits in trunk/JavaScriptCore

Maintain stack of old "arguments" property values for functions
implicitly on the system stack instead of explicitly in the
FunctionImp. This eliminates only a trivial number of GC
allocations (less than 200) but eliminates one of the two cases
where a ListImp * is stored directly, paving the way to separate
List from Value.

kjs/function.h: Remove argStack, pushArgs and popArgs.
kjs/function.cpp: (FunctionImp::FunctionImp): Don't initalize argStack. (FunctionImp::~FunctionImp): Remove comment about argStack. (FunctionImp::mark): Don't mark the argStack. (FunctionImp::call): Save old "arguments" property in a Value, where it will be GC-protected, rather than keeping a list, and restore the old value when done executing.

Aug 18, 2002:

5:31 PM Changeset in webkit [1863] by darin

4 edits in trunk/JavaScriptCore

kjs/internal.cpp: (KJS::printInfo): Remove one more CompletionType that Maciej missed.

5:20 PM Changeset in webkit [1862] by darin

15 edits in trunk/WebKit

WebFoundation:

Step 5 of adding user-agent API.

Add API to pass user agent into WebFoundation when creating a WebResourceHandle,
or to compute the user agent for each URL in a WebResourceClient method.

Also renamed the WebResourceClient methods to be more like delegate methods in AppKit.

CacheLoader.subproj/WebHTTPResourceLoader.m: (-[WebHTTPProtocolHandler addUserAgentHeader:]): Treat nil for user agent as "no user-agent header". (-[WebHTTPProtocolHandler createWFLoadRequest]): Treat nil for user agent as "no user-agent header".
CacheLoader.subproj/WebResourceCallbackClient.m: Updated methods for new names. Added nil-returning handleWillUseUserAgent:forURL:.
CacheLoader.subproj/WebResourceClient.h: New names.
CacheLoader.subproj/WebResourceHandle.h: Added userAgent parameter to init function.
CacheLoader.subproj/WebResourceHandle.m: Updated method for new names. (-[WebResourceHandleInstanceVariables dealloc]): Store originalUserAgent so we don't ask the handle twice about that same URL. Could do a bit more of this if needed. (-[WebResourceHandle _originalCanonicalURL]): Renamed canonicalURL to this for clarity. (-[WebResourceHandle _originalUserAgent]): Added. (-[WebResourceHandle _userAgentForURL:]): Made this actually call handleWillUseUserAgent:forURL:. Now we have no hard-coded user-agent string in WebFoundation at all.
CacheLoader.subproj/WebResourceHandlePrivate.h: Added _originalUserAgent.
CacheLoader.subproj/WebResourceLoad.h: Added userAgent, originalUserAgent.
CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad userAgent]): Return this rather than recomputing it. (-[WebResourceLoad dealloc]): Release this. (-[WebResourceLoad _originalUserAgent]): Return this rather than recomputing it. (-[WebResourceLoad didRedirectToURL:cacheRedirect:]): Store userAgent when we update URL. (-[WebResourceLoad _cacheKey]): Allow userAgent of nil.
CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Allow userAgent of nil, and get it, don't compute it. (-[WebResourceLoadKey isEqual:]): Handle userAgent of nil properly.

WebKit:

Update WebResourceClient instances for new API, including adding
the handleWillUseUserAgent:forURL: method.

Misc.subproj/WebIconLoader.m:
Plugins.subproj/WebPluginStream.m:
WebCoreSupport.subproj/WebSubresourceClient.m:
WebView.subproj/WebMainResourceClient.m: These were all the clients that needed updating.

WebView.subproj/WebController.m: (-[WebController setUserAgent:]): Lock so that we can set the user agent even though another thread could be calling userAgentForURL:. (-[WebController userAgentForURL:]): Ditto.

WebView.subproj/WebControllerPrivate.h: Add lock.
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Create lock. (-[WebControllerPrivate dealloc]): Release lock.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Improve comment.

5:11 PM Changeset in webkit [1861] by mjs

6 edits in trunk/JavaScriptCore

Remove stray references to CompletionType and CompletionImp.

kjs/completion.h:
kjs/object.cpp:
kjs/value.h:

3:57 PM Changeset in webkit [1860] by darin

3 edits in trunk/WebKit

Misc.subproj/WebIconLoader.m: (-[WebIconLoader iconFromCache]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): Don't process each icon twice. We need to have the loader as a client even for the synchronous case because of the user agent issue, but that causes double work.

12:21 AM Changeset in webkit [1859] by mjs

9 edits
2 adds in trunk/JavaScriptCore

Separated Completion from Value and made it a pure stack
object. This removed another 160,000 of the remaining 580,000
garbage collected object allocations.

6% speed increas on cvs-js-performance test.

kjs/completion.cpp: Added. New implementation that doesn't require a ValueImp *. (Completion::Completion): (Completion::complType): (Completion::value): (Completion::target): (Completion::isValueCompletion):
kjs/completion.h: Added.
kjs/function.cpp: (GlobalFuncImp::call): Removed some (apparently mistaken) uses of Completion as a Value.
kjs/internal.cpp:
kjs/internal.h:
kjs/types.cpp: Removed Completion stuff.
kjs/types.h: Removed Completion stuff.
JavaScriptCore.pbproj/project.pbxproj: Added new header.

Aug 16, 2002:

8:30 PM Changeset in webkit [1858] by darin

17 edits in trunk

WebCore:

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::userAgent): Call bridge's userAgentForURL: method.
kwq/WebCoreBridge.h: Added userAgentForURL: to the protocol

WebKit:

Step 3 in adding user agent API to WebKit and WebFoundation.
Add the calls to WebKit to configure the user-agent string.
Change WebCore to get the user-agent from WebKit via the bridge.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge userAgentForURL:]): Added. Calls [WebController userAgentForURL:].

WebView.subproj/WebController.h: Add three new methods.
WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Store an application name that will be used to build up the user-agent string. (-[WebController setUserAgent:]): Set an override user agent; mainly useful for testing user-agent strings different from the one WebKit supplies. (-[WebController userAgentForURL:]): Public API for getting the user agent string that the WebController will use for a particular URL.

WebView.subproj/WebControllerPrivate.h: Add fields for the user-agent parameters.
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release both strings when the controller goes away.

8:08 PM Changeset in webkit [1857] by darin

3 edits in trunk/WebKit

Missed one call to [WebResourceHandle initWithURL:].

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): Change to call [WebResourceHandle initWithClient:URL:] with nil for the client.

8:04 PM Changeset in webkit [1856] by darin

6 edits in trunk/WebKit

Oops. Forgot to save in Project Builder before committing.

Plugins.subproj/WebPluginStream.m:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m:

8:02 PM Changeset in webkit [1855] by darin

11 edits
1 delete in trunk/WebCore

Step 2 in adding user agent API to WebKit and WebFoundation.
In this step, I change WebCore so that it the KWQKHTMLPartImpl
is responsible for fetching the user agent. Later it will
get the user agent from WebKit via the bridge.

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Get the user agent from the part, not KProtocolManager.
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::initScript): Get the user agent from the part, not KProtocolManager.

kwq/KWQKHTMLPartImpl.h: Add userAgent member function.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::userAgent): Added.

WebCore.pbproj/project.pbxproj: Removed KWQKProtocolManager.mm.
kwq/KWQKProtocolManager.mm: Removed.
kwq/kio/kprotocolmanager.h: Made empty.

8:01 PM Changeset in webkit [1854] by darin

9 edits in trunk/WebKit

top level:

Tests/WebFoundationC/ifurlhandlec-test.c: (run): Keep this test compiling. It won't run any more, though.

WebFoundation:

Step 1 in adding user agent API to WebKit and WebFoundation.
In this step, I change WebResourceHandle's API so that there's only
one client per handle, passed in at init time. I haven't changed the
internals of WebResourceHandle yet.

CacheLoader.subproj/IFHTTPURLHandleC.m: Remove IFHTTPURLHandleCreate.
CacheLoader.subproj/IFURLHandleC.m: Remove IFURLHandleCreate.

CacheLoader.subproj/WebHTTPResourceHandle.m: Remove unneeded init methods that just did the same thing the superclass would have.

CacheLoader.subproj/WebResourceHandle.h: Remove addClient and removeClient methods. Add client parameter to all the init methods.
CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceSynchronousClient run:]): Don't addClient here. Caller is responsible for that. (-[WebResourceHandle loadInForeground:]): Add client to the clients list. (-[WebResourceHandle initWithClient:URL:]): Pass client parameter through. (-[WebResourceHandle initWithClient:URL:cached:]): Pass client parameter through. (-[WebResourceHandle initWithClient:URL:attributes:flags:]): Rearrange the function. The only substantive change is that the passed-in client is added to the clients list.

WebFoundation.exp: Don't export _IFHTTPURLHandleCreate and _IFURLHandleCreate any more.

WebKit:

Update for change to the WebResourceHandle API where the client is
passed in at init time.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader iconFromCache]): Pass self as client when creating handle for foreground "only if cached" load. Also don't put the handle into the class's data structure in this case. (-[WebIconLoader startLoading]): Pass self as client when creating handle instead of making a separate addClient call. Also fix potential leak if this is called when we are already loading. (-[WebIconLoader stopLoading]): Release the handle and nil it out right here.
Plugins.subproj/WebPluginStream.m: (-[WebPluginStream startLoad]): Pass client when creating handle rather than doing an addClient afterward. (-[WebPluginStream stop]): Don't do a removeClient.
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]):
WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Pass client when creating handle.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Since client is not created in init, don't bother creating it here.

3:29 PM Changeset in webkit [1853] by sullivan

5 edits
2 adds in trunk/WebKit

WebKit:

Split searchability out from WebTextView so it could be used
elsewhere (specifically, in DOM window).

Misc.subproj/WebSearchableTextView.h: Added.
Misc.subproj/WebSearchableTextView.m: Added. (-[WebSearchableTextView searchFor:direction:caseSensitive:]): (-[NSString findString:selectedRange:options:wrap:]): New class, split out from WebTextView, which now inherits from it.

WebView.subproj/WebTextView.h:
WebView.subproj/WebTextView.m: Took out the searching stuff and put it in WebSearchableTextView; made WebTextView inherit from WebSearchableTextView.

WebKit.pbproj/project.pbxproj: Added new files, made WebSearchableTextView.h be Private.

WebBrowser:

Made Find on Page work in DOM window; useful for debugging.

Debug/DOMTree.h: Turned DOMTree into an NSWindowController, and implement protocol ProvidesSearchTarget
Debug/DOMTree.m: (-[DOMTree windowNibName]): standard NSWindowController stuff. (-[DOMTree targetForSearch]): return the textview (-[DOMTree awakeFromNib]): set properties of the textview; for some reason, Interface Builder won't let you make an NSTextView be a custom subview class in the nib, so you have to use a custom class, so you can't set the standard NSTextView settings in the nib. (-[DOMTree itemSelected:]): Fixed typo, removed unnecessary return value.

Debug/DebugUtilities.m: (-[BrowserDocument showDOMTree:]): removed nib-loading line since NSWindowControllers do this automatically.

Debug/DOMTree.nib: Made text view be a WebSearchableTextView; also tweaked layout just a little (so "#document" doesn't clip by default, e.g.)

12:21 PM Changeset in webkit [1852] by darin

6 edits in trunk/JavaScriptCore

Fix the Development build.

kjs/object.cpp: Take out a use of ReferenceType.

kjs/ustring.h: Added a bit more inlining.
kjs/ustring.cpp: Moved the function out of here.

12:10 PM Changeset in webkit [1851] by mjs

4 edits in trunk/WebCore

force-clean-timestamp: Need to rebuild for JavaScriptCore changes.

12:07 PM Changeset in webkit [1850] by mjs

11 edits in trunk/JavaScriptCore

Final step of the Reference change. Completely separate Reference
from Value, and eliminate ReferenceImp.

18% speedup on cvs-js-performance test.

kjs/internal.cpp, kjs/internal.h: Remove ReferenceImp.
kjs/nodes.cpp: (Node::evaluateReference): Use Reference::makeValueReference(), not ConstReference.
kjs/reference.cpp: (Reference::Reference): New implementation, handles both regular and value references. (Reference::makeValueReference): Incorporate functionality of ConstReference into this class. (Reference::getBase): New implementation (incorporates error vase for value references). (Reference::getPropertyName): New implementation (incorporates error case for value references). (Reference::putValue): New implementation (incorporates error case for value references). (Reference::deleteValue): New implementation (incorporates error case for value references). (Reference::getValue): New implementation (incorporates special case for value references). (Reference::isMutable): New implementation.
kjs/reference.h: New implementation that merges ReferenceImp into the stack object.
kjs/value.h, kjs/value.cpp: Removed all reference-related method.

11:15 AM Changeset in webkit [1849] by sullivan

4 edits in trunk/WebKit

WebKit:

fixed 3025394 -- Bookmarks & History items do not remember their icons across launches
fixed 3025421 -- Dragging from location field proxy icon to favorites bar loses page icon
part of fix for 3026279 -- Bookmarks should lose their favIcons when the URL is edited

Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[WebBookmarkLeaf dictionaryRepresentation]): Removed the #ifdeffed-out code for storing iconURL in dictionary; this was unnecessary because it is also done by the lower-level WebHistoryItem.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setIcon:]): New method, extracted from -icon for clarity. (-[WebHistoryItem icon]): Fixed problem where once an icon was set it would never be changed, even if the iconURL is changed. Also, use _setIcon for clarity and to fix retainCount bugs. (-[WebHistoryItem dictionaryRepresentation]): Removed the #ifdef around the line that stores the URL in the dictionary. Gramps decided that this architecture is OK after all.

WebBrowser:

part of fix for 3026279 -- Bookmarks should lose their favIcons when the URL is edited

BookmarksController.m: (-[BookmarksController _changeAddressForBookmark:to:withIconURL:]): Added iconURL parameter to this method; use new iconURL and remember old one in Undo info. (-[BookmarksController _undoAddressChange:]): Now resets the iconURL as well as the address. (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): pass nil for new iconURL when address is changed. Also canonicalize URL if possible to minimize clobbering favIcons with insignificant address changes; this has the nice side benefit of instantly displaying the URL-ized form of the user-entered text in the Bookmarks window, a feature that Maciej has long thought would be useful.

OutlineViewPlus.m: (-[OutlineViewPlus textDidEndEditing:]): Revert change I made yesterday that broke the tabbing case; added comment.

11:04 AM Changeset in webkit [1848] by darin

10 edits in trunk/WebCore

fixed 3023851 -- screen garbage created by scrolling text

Our implementation of clipRegion didn't reflect the clip that was
already set for the view, so we drew outside the view. To fix it,
I eliminated the clipRegion call and changed clients to use a new
addClip call instead that doesn't require getting the clip in the
form of a region (which is not really possible with CoreGraphics).

khtml/rendering/render_box.cpp: (RenderBox::calcClip): Call addClip instead of clipRegion(), intersect(), setClipRegion().

kwq/qt/qpainter.h: Added addClip(), removed clipRegion(), setClipRegion().
kwq/KWQPainter.mm: (QPainter::addClip): Calls [NSBezierPath clipRect:].

kwq/qt/qregion.h: Went back to a single-path implementation, since we don't need intersect() any more. Also removed isNull() and setClip().
kwq/KWQRegion.mm: (QRegion::QRegion): New simpler versions. (QRegion::~QRegion): Release the path. (QRegion::operator=): Copy the other path. (QRegion::contains): Call [containsPoint:]. (QRegion::translate): Call [transformUsingAffineTransform:]. (QRegion::boundingRect): Call [bounds].

10:29 AM Changeset in webkit [1847] by darin

3 edits in trunk/WebKit

Fixed broken build.

Misc.subproj/WebTestController.m: Added empty placeholder methods.

9:51 AM Changeset in webkit [1846] by darin

4 edits in trunk/JavaScriptCore

fixed 3026184 -- Hang going to http://aa.com/ while executing JavaScript

kjs/simple_number.h: (SimpleNumber::value): Fixed conversion to a negative number. The technique of using division was no good. Instead, or in the sign bits as needed.

8:47 AM Changeset in webkit [1845] by darin

5 edits in trunk/WebCore

fixed 3026042 -- hide frames button at developer documentation doesn't work

This regression was introduced by the anchor changes we made just after
the Alexander-15 release.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Make decisions about special handling for links with anchors based on the target frame, not the current frame.

5:31 AM Changeset in webkit [1844] by mjs

4 edits in trunk/JavaScriptCore

kjs/reference_list.h: Must include headers with "", not <>. D'oh!

5:04 AM Changeset in webkit [1843] by mjs

4 edits in trunk/WebCore

force-clean-timestamp: rebuild for JavaScriptCore changes.

5:01 AM Changeset in webkit [1842] by mjs

4 edits in trunk/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Install reference.h and reference_list.h so WebCore compiles (duh).

3:25 AM Changeset in webkit [1841] by mjs

8 edits
3 adds in trunk/JavaScriptCore

Next step: reimplement ReferenceList from scratch, and store it as
an actual Reference object, so ReferenceList no longer depends on
Reference being a Value or having a ReferenceImp. A resizing
vector might be even better the way this is used.

Also moved Reference to its own header and implementation file in
preparation for reimplementing it.

JavaScriptCore.pbproj/project.pbxproj:
kjs/nodes.cpp: (ForInNode::execute):
kjs/reference.cpp: Added. (Reference::Reference): (Reference::dynamicCast): (ConstReference::ConstReference):
kjs/reference.h: Added.
kjs/reference_list.cpp: Added. (ReferenceList::ReferenceList): (ReferenceList::operator=): (ReferenceList::swap): (ReferenceList::append): (ReferenceList::~ReferenceList): (ReferenceList::begin): (ReferenceList::end): (ReferenceListIterator::ReferenceListIterator): (ReferenceListIterator::operator!=): (ReferenceListIterator::operator->): (ReferenceListIterator::operator++):
kjs/reference_list.h:
kjs/types.cpp:
kjs/types.h:

3:17 AM Changeset in webkit [1840] by mjs

5 edits in trunk/JavaScriptCore

Fix Development build - some NDEBUG code had to be changed for the
Value/Reference split.

kjs/internal.cpp: (KJS::printInfo):
kjs/nodes.cpp: (FunctionCallNode::evaluate):

1:20 AM Changeset in webkit [1839] by hyatt

5 edits in trunk/WebCore

Fix for the intuit.com and eweek.com <form><tr> bgcolor problem.
Improve the error handling of the parser so that it doesn't
lose attributes when errors like this occur in a page.

khtml/html/htmlparser.cpp: (KHTMLParser::~KHTMLParser): (KHTMLParser::reset): (KHTMLParser::parseToken): (KHTMLParser::insertNode):
khtml/html/htmlparser.h:

12:48 AM Changeset in webkit [1838] by mjs

3 edits
1 add in trunk/JavaScriptCore

kjs/reference_list.h: Added file I forgot to check in last time.

12:43 AM Changeset in webkit [1837] by mjs

11 edits in trunk/JavaScriptCore

Phase 1 of optimization to stop allocating references through the
collector. This step clearly splits evaluating to a reference and
evaluating to a value, and moves all of the reference-specific
operations from Value to Reference. A special ConstReference class
helps out for the one case where you need special reference
operations if the result is a reference, and not otherwise.

Also, Reference now inherits privately from Value, and there is a
new ReferenceList class that inherits privately from List, so the
uses of Reference and Value are now completely orthogonal. This
means that as the next step, their implementations can be
completely disentangled.

This step has no actual performance impact.

kjs/collector.cpp: (Collector::collect):
kjs/nodes.cpp: (Node::evaluateReference): (ResolveNode::evaluate): (ResolveNode::evaluateReference): (ElementNode::evaluate): (PropertyValueNode::evaluate): (AccessorNode1::evaluate): (AccessorNode1::evaluateReference): (AccessorNode2::evaluate): (AccessorNode2::evaluateReference): (ArgumentListNode::evaluateList): (NewExprNode::evaluate): (FunctionCallNode::evaluate): (PostfixNode::evaluate): (DeleteNode::evaluate): (VoidNode::evaluate): (TypeOfNode::evaluate): (PrefixNode::evaluate): (UnaryPlusNode::evaluate): (NegateNode::evaluate): (BitwiseNotNode::evaluate): (LogicalNotNode::evaluate): (MultNode::evaluate): (AddNode::evaluate): (ShiftNode::evaluate): (RelationalNode::evaluate): (EqualNode::evaluate): (BitOperNode::evaluate): (BinaryLogicalNode::evaluate): (ConditionalNode::evaluate): (AssignNode::evaluate): (CommaNode::evaluate): (VarDeclNode::evaluate): (ExprStatementNode::execute): (IfNode::execute): (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (ReturnNode::execute): (WithNode::execute): (CaseClauseNode::evaluate): (SwitchNode::execute): (ThrowNode::execute):
kjs/nodes.h:
kjs/types.cpp: (ConstReference::ConstReference):
kjs/types.h:
kjs/value.h:

Aug 15, 2002:

11:11 PM Changeset in webkit [1836] by darin

4 edits in trunk/WebCore

fixed 2983959 -- pages that try to use JavaScript to focus fail to do so

kwq/KWQWidget.mm: (QWidget::setFocus): Call makeFirstResponder.

10:35 PM Changeset in webkit [1835] by darin

19 edits in trunk/WebCore

Give the same good loving to the check boxes and radio buttons.
I'm not saying our rules for where to position them are great, but
the rules are implemented cleanly and thus easier to tweak.

Got rid of the old Action system altogether, using signals now.

khtml/rendering/render_form.h: Remove now-unneeded APPLE_CHANGES.
khtml/rendering/render_form.cpp: (RenderButton::baselinePosition): All the buttons now share a single version of this call, since none need any special baseline hacking at the moment. (RenderSubmitButton::baselinePosition): Just call the RenderButton version.

kwq/KWQCheckBox.mm: (QCheckBox::sizeHint): Use 12x12, not 22x22. (QCheckBox::frameGeometry): Adjust for margins. (QCheckBox::setFrameGeometry): Adjust for margins.
kwq/KWQRadioButton.mm: (QRadioButton::sizeHint): Use 12x12, not 22x22. (QRadioButton::frameGeometry): Adjust for margins. (QRadioButton::setFrameGeometry): Adjust for margins.

kwq/qt/qcombobox.h:
kwq/KWQComboBox.mm: (QComboBox::QComboBox): Set up the activated signal.
kwq/KWQView.mm: (-[KWQNSComboBox action:]): Emit the activated signal.

kwq/KWQListBox.h:
kwq/KWQListBox.mm: (-[KWQBrowserDelegate browserSingleClick:]): Send a selectionChanged signal and a clicked signal instead of a ACTION_LISTBOX_CLICKED. (QListBox::QListBox): Set up the clicked and selectionChanged signals.

kwq/qt/qobject.h: Remove Actions, ACTION_TEXT_AREA_END_EDITING, ACTION_LISTBOX_CLICKED, ACTION_COMBOBOX_CLICKED, emitAction, performAction, and target.
kwq/KWQObject.mm: (QObject::connect): Remove the target hack, no longer needed. (QObject::QObject): Remove target initialization.

kwq/KWQSlot.mm: (KWQSlot::KWQSlot), (KWQSlot::call): Added selected and selectionChanged slots.

kwq/KWQTextArea.mm: (-[KWQTextArea textDidEndEditing:]): Removed code to emit the ACTION_TEXT_AREA_END_EDITING action, which was no longer used.

force-clean-timestamp: Yes, again.

5:09 PM Changeset in webkit [1834] by darin

69 edits in trunk/WebCore

fixed 3017376 -- button height is too tall

Reworked how widget sizing and positioning is done for a few of the most important
widget types.

khtml/rendering/render_form.h: Remove more of the performAction hackery.
khtml/rendering/render_form.cpp: (RenderCheckBox::calcMinMaxWidth): Get size from widget. (RenderRadioButton::calcMinMaxWidth): Get size from widget. (RenderSubmitButton::RenderSubmitButton): Remove old unneeded APPLE_CHANGES. (RenderSubmitButton::baselinePosition): Put the bottom of the button on the baseline without any magic numbers. (RenderLineEdit::baselinePosition): Put the bottom of the text field two pixels below the baseline without any other magic numbers. (RenderLineEdit::calcMinMaxWidth): Get size from widget. (RenderSelect::baselinePosition): Put the bottom of the menu on the baseline without any magic numbers. List box case is untouched for now.

kwq/qt/qbutton.h:
kwq/KWQButton.mm: (QButton::QButton): Move most of the setup into KWQNSButton. (QButton::sizeHint): Use cellSize, account for margins. (QButton::frameGeometry): Adjust for margins. (QButton::setFrameGeometry): Adjust for margins.
kwq/qt/qcheckbox.h:
kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox): QButton takes care of most of the setup now. (QCheckBox::sizeHint): Added. (QCheckBox::frameGeometry): Adjust for margins. (QCheckBox::setFrameGeometry): Adjust for margins.
kwq/qt/qcombobox.h:
kwq/KWQComboBox.mm: (QComboBox::init): KWQNSComboBox takes care of most of the setup now. (QComboBox::sizeHint): Adjust for margins. (QComboBox::frameGeometry): Adjust for margins. (QComboBox::setFrameGeometry): Adjust for margins.
kwq/qt/qlineedit.h:
kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Added. (QLineEdit::frameGeometry): Adjust for margins. (QLineEdit::setFrameGeometry): Adjust for margins.
kwq/qt/qradiobutton.h:
kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): QButton takes care of most of the setup now. (QRadioButton::sizeHint): Added. (QRadioButton::frameGeometry): Adjust for margins. (QRadioButton::setFrameGeometry): Adjust for margins.

kwq/qt/qwidget.h:
kwq/KWQWidget.mm: (QWidget::setFrameGeometry): New name for internalSetGeometry, now public.

fixed 3010695 -- Slashdot.org starts with password field focused, but shouldn't

Added KWQSecureTextField to work around the bug.

kwq/KWQNSTextField.h: Made formatter and other details private.
kwq/KWQNSTextField.mm: (+[KWQNSTextField initialize]): Set up custom cell class that works around focus border. (-[KWQNSTextField initWithFrame:]): Put the work in here, since this is NSView's designated initializer. (-[KWQNSTextField initWithWidget:]): Now just calls [init] which calls [initWithFrame], and then sets the widget. (-[KWQNSTextField action:]): Use the returnPressed signal instead of ACTION_TEXT_FIELD. (-[KWQNSTextField controlTextDidEndEditing:]): Use textChanged signal instead of ACTION_TEXT_FIELD_END_EDITING. (-[KWQNSTextField dealloc]): Release the secureField (was a leak). (-[KWQNSTextField updateSecureFieldFrame]): Added. Used to keep secure field in the right place. (-[KWQNSTextField setFrameSize:]): Added. Calls updateSecureFieldFrame. (-[KWQNSTextField setPasswordMode:]): Change all the details, but this does the same thing it used to. (-[KWQNSTextField selectText:]): Only call selectText on one of the two field, since it causes the field to grab focus and we don't want to do that twice. (-[KWQNSTextField setStringValue:]): Set the string value in both fields any time someone gives us a new value. (-[KWQNSTextField setFont:]): Set the font in both fields any time someone gives us a new font. (-[KWQTextFieldCell cellSizeForBounds:]): Add space for focus border. (-[KWQTextFieldCell drawWithFrame:inView:]): Inset by focus border. (-[KWQTextFieldCell editWithFrame:inView:editor:delegate:event:]): Inset by focus border. (-[KWQTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): Inset by focus border. (-[KWQSecureTextField selectText:]): Override to do nothing while in setFrameSize to work around bug in AppKit. (-[KWQSecureTextField setFrameSize:]): Set flag to trigger selectText check.

fixed 3025166 -- check boxes and radio buttons on google.com's preferences pages are not "linked"

We were not emitting onClicked for check boxes.

kwq/KWQView.h: No need to pass frames any more. Default is empty.
kwq/KWQView.mm: (-[KWQView initWithFrame:]): Do most of the work in here. (-[KWQView initWithWidget:]): Just call [init] and set up widget. (-[KWQNSButton initWithFrame:]): Do most of the work in here. Remove the special cell class, and always use a small control with the small system font. (-[KWQNSButton initWithWidget:]): Just call [init] and set up widget. (-[KWQNSButton action:]): Call the clicked() signal instead of ACTION_BUTTON_CLICKED. (-[KWQNSButton stateChanged:]): Call the stateChanged() signal instead of ACTION_CHECKBOX_CLICKED. (-[KWQNSComboBox initWithFrame:]): Do most of the work in here. (-[KWQNSComboBox initWithWidget:]): Just call [init] and set up widget. (-[KWQNSScrollView initWithWidget:]): Just call [init] and set up widget.

fixed 3025211 -- find person in Apple directory never displays person information

When I enabled the code to wait and not redirect until loads are complete, that
broke this case, because we didn't have enough hooked up to notice loads completing.
I hooked everything up and its working now.

khtml/khtml_part.h: Add started().
khtml/khtml_part.cpp: (KHTMLPart::restoreURL): Un-ifdef emission of started(). (KHTMLPart::openURL): Un-ifdef emission of started(). (KHTMLPart::end): Don't do an explicit call to slotFinishedParsing(). We actually hook up a signal for this now. (KHTMLPart::slotChildCompleted): Un-ifdef the rest of the code here.

khtml/xml/dom_docimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
khtml/xml/xml_tokenizer.h: Do the necessary setup so we can use KWQSignal for finishedParsing.

kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::started): Added. Calls slotChildStarted on parent. (KHTMLPart::completed): Added slotParentCompleted calls.

kwq/qt/qobject.h: Add sender() and KWQObjectSenderScope.
kwq/KWQObject.mm: (KWQObjectSenderScope::KWQObjectSenderScope): Added. Sets sender() and saves the old value. (KWQObjectSenderScope::~KWQObjectSenderScope): Added. Resets sender().

kwq/KWQSignal.h:
kwq/KWQSlot.h:
kwq/KWQSignal.mm: (KWQSignal::call): Added overloads for calling signals with int and QString parameters. Also set up sender() using KWQObjectSenderScope.

kwq/KWQSlot.mm: (KWQSlot::KWQSlot), (KWQSlot::call): Add support for one signal (calls through to whatever is connected to that signal's slot) and six new slots.

kwq/KWQsignals.mm: (Tokenizer::Tokenizer): Construct the finishedParsing signal. (Tokenizer::finishedParsing): Emit the finishedParsing signal.

fixed 3025170 -- right sides of borders placed incorrectly around table cells

There was some silly code that I just removed.

khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Turn off the half-assed collapse borders stuff here.

other changes

force-clean-timestamp: Big changes; full rebuild needed.

khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Make the code to kill the timers be unconditional, just in case.

kwq/KWQCharsets.mm: (buildDictionaries): Remove UTF-16 special case since it's now in the character sets table.

kwq/qt/qpoint.h:
kwq/KWQPoint.mm: (QPoint::QPoint): Converts from NSPoint. (QPoint::operator NSPoint): Converts to NSPoint.
kwq/qt/qrect.h:
kwq/KWQRect.mm: (QRect::QRect): Converts from NSRect. (QRect::isEmpty): Fix backwards logic. (QRect::operator NSRect): Converts to NSRect.
kwq/qt/qsize.h:
kwq/KWQSize.mm: (QSize::QSize): Converts from NSSize. (QSize::operator NSSize): Converts to NSSize.

kwq/qt/qpushbutton.h:
kwq/KWQPushButton.mm: Removed unused methods.

kwq/KWQRegion.mm: Use new QPoint/NSPoint/QRect/NSRect functions.

kwq/KWQScrollView.mm: (QScrollView::addChild): Update comment.

kwq/KWQTextArea.h:
kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Do most of the work in here. (-[KWQTextArea initWithWidget:]): Just call [init] and set up widget.

kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Don't pass an empty frame any more.

kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: Update for name change.

kwq/WebCoreTestController.h: Placeholder for the feature I should be working on.

4:14 PM Changeset in webkit [1833] by sullivan

3 edits in trunk/WebKit

WebKit:

fixed 3025770 -- "New Bookmark" button hits assertion and crashes

Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf setURLString:]): Instead of asserting that parameter is not nil, handle the nil case by converting to empty string. This was another regression from yesterday's favIcon changes.

WebBrowser:

fixed remaining case in 3015942 -- Using Bookmarks New Separator button causes loss of keyboard focus
fixed 3023789 -- Find dialog should hide on deactivate to match Mail/TextEdit

BookmarksController.m: (-[BookmarksController _focusOnNewlyCreatedBookmark:]): Make outline view first responder here.

OutlineViewPlus.m: (-[OutlineViewPlus textDidEndEditing:]): restructured a little.

English.pbproj/Find.nib: checked "Hide on deactivate" checkbox; actually I checked this in accidentally with my previous checkin, so this comment is late.

12:51 PM Changeset in webkit [1832] by darin

6 edits in trunk/JavaScriptCore

Tweaks and small bug fixes to Maciej's excellent new fixnum optimization.
Also updated or removed comments that call it "fixnum" instead of "simple number".

kjs/simple_number.h: Change constant names so they don't SHOUT the way macro names do. Added constants for shift, min, and max. Fixed off-by-1 error that prevented us from using the extreme values on either end. Base the range of numbers on a fixed 32 bits constant rather than the size of a long, because code elsewhere depends on positive numbers fitting into both "unsigned" and "UInt32" while assuming it doesn't need to check; we can easily change this later. Used int types rather than long for essentially the same reason. Fixed the value-extraction function so it will work for negative numbers even if the shift is logical, not arithmetic, by using division instead. Renamed functions to be quite terse since they are inside a class.

kjs/value.h:
kjs/value.cpp: (ValueImp::dispatchToObject): Call NumberImp::toObject in a "non-virtual" way rather than repeating the code here. (ValueImp::dispatchToUInt32): Handle the negative number case correctly. (ValueImp::dispatchGetBase): Call ValueImp::getBase in a "non-virtual" way rather than repeating the code here. (ValueImp::dispatchGetPropertyName): Call ValueImp::getPropertyName in a "non-virtual" way rather than repeating the code here. (ValueImp::dispatchPutValue): Call ValueImp::putValue in a "non-virtual" way rather than repeating the code here. (ValueImp::dispatchDeleteValue): Call ValueImp::deleteValue in a "non-virtual" way rather than repeating the code here. (Number::Number): Fixed a bug where the double-based constructor was casting to long, so wouldn't do the "remainder" check.

11:17 AM Changeset in webkit [1831]

3 copies in tags/Alexander-19

This commit was manufactured by cvs2svn to create tag 'Alexander-19'.

11:17 AM Changeset in webkit [1830] by sheridan

8 edits in trunk

alex-19 versions

10:01 AM Changeset in webkit [1829] by sullivan

4 edits in trunk/WebKit

WebKit:

Disabled support for storing favIcon URLs in bookmarks; Gramps realized
this is an architecture problem that needs a better solution, and he
didn't want to ship Alex-18 with this problem.

Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf dictionaryRepresentation]):
History.subproj/WebHistoryItem.m: (-[WebHistoryItem dictionaryRepresentation]): Commented out the code that added the iconURLString in the dictionary used for writing out file. This dictionary is also used on the pasteboard, so this change causes the favIcon not to be remembered when you drag from proxy icon to favorites bar.

WebBrowser:

Fixed some of the brokenness with favIcons caused by yesterday's
favIcon checkin. I'm going to change the API for the bookmark
sheet to make this cleaner, but this is the quick fix so that
Alex-18 won't be too broken.

BookmarksController.h:
BookmarksController.m: (-[BookmarksController displayNewBookmarksSheetForURLs:titles:iconURLStrings:inWindow:]): Change iconURLs parameter to iconURLStrings so there's an easy way to represent nil URLs (with empty strings).

(-[BookmarksController _newBookmarkSheetDidEnd:returnCode:contextInfo:]): Convert from URL
strings back to URLs for the purpose of creating bookmarks.

BrowserDocument.m: (-[BrowserDocument _mainDataSourceHasChanged]): Set the iconURL to nil here. Formerly it was only set when the incoming page specified one, which meant that future pages that don't specify an iconURL (favIcon) would use the leftover one for some purposes, like when creating a new bookmark.

(-[BrowserDocument addBookmark:]): Pass non-nil iconURLStrings even when iconURL is nil,
since the API demands three parallel arrays.

ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]): Pass an array of strings instead of URLs for the titles (did this ever work?); pass non-nil iconURLStrings even when iconURL is nil, since the API demands three parallel arrays.

GlobalHistory.m: (-[GlobalHistory addSelectedItemsToBookmarks:]): pass always non-nil iconURLStrings instead of adding sometimes-nil iconURLs to array; this would have failed in any case where the favIcon was nil.

NewBookmarksController.h:
NewBookmarksController.m: (-[NewBookmarksController initWithURLs:titles:iconURLStrings:]): Change array from URLs to strings, assert that iconURLStrings is same length as other two arrays.

8:41 AM Changeset in webkit [1828]

3 copies in tags/Alexander-18

This commit was manufactured by cvs2svn to create tag 'Alexander-18'.

8:41 AM Changeset in webkit [1827] by sheridan

8 edits in trunk

Alex-18 versions

5:05 AM Changeset in webkit [1826] by mjs

4 edits in trunk/WebCore

force-clean-timestamp: Need to rebuild for JavaScriptCore changes.

5:02 AM Changeset in webkit [1825] by mjs

8 edits
1 add in trunk/JavaScriptCore

Phase 2 of fixnum optimization. Store any integral number that
will fit in two bits less than a long inside the ValueImp *
itself, thus avoiding the need to deal with the garbage collector
at all for these types. Such numbers comprised .5 million of the
1.7 million ValueImps created during the cvs-js-performance test,
so traffic through the garbage collector should be

20% improvement on cvs-js-performance. This may also show up on
cvs-base, but I did not compare and I am too lazy to make clean in
WebCore yet again.

This also significantly reduces memory footprint on
JavaScript-heavy pages. Size after going through
cvs-js-performance suite is now down from 22 MB to 17.5 MB.

JavaScriptCore.pbproj/project.pbxproj:
kjs/simple_number.h: Added. Some inline static methods for handling simple numbers that are stored in the pointer.
kjs/ustring.h:
kjs/ustring.cpp: (UString::from): Added new overload for long.
kjs/value.cpp: (ValueImp::marked): Add special case for simple numbers. (ValueImp::setGcAllowed): Likewise. (ValueImp::toInteger): Call dispatch version of toUInt32(unsigned&), not the real method. (ValueImp::toInt32): Likewise. (ValueImp::toUInt32): Likewise. (ValueImp::toUInt16): Likewise. (ValueImp::dispatchType): Add special case for simple numbers. (ValueImp::dispatchToPrimitive): Likewise. (ValueImp::dispatchToBoolean): Likewise. (ValueImp::dispatchToNumber): Likewise. (ValueImp::dispatchToString): Likewise. (ValueImp::dispatchToObject): Likewise. (ValueImp::dispatchToUInt32): Likewise. (ValueImp::dispatchGetBase): Likewise. (ValueImp::dispatchGetPropertyName): Likewise. (ValueImp::dispatchPutValue): Likewise. (ValueImp::dispatchDeleteValue): Likewise. (Number::Number): Create a simple number instead of a full-blown ValueImp when possible. (Number::value): Likewise.
kjs/value.h:

3:08 AM Changeset in webkit [1824] by mjs

11 edits in trunk/JavaScriptCore

Phase one of the "fixnum" optimization (storing small enough
integers in the pointer). This just paves the way for the change
by making all the virtual functions of ValueImp private and adding
non-virtual dispatchers which can call the virtual function or
handle fixnums specially.

Also, I marked every place that should need a special case with a
FIXNUM comment.

kjs/bool_object.cpp: (BooleanObjectImp::construct): Call dispatch method not the real method.
kjs/internal.h: Make toUInt32 private to make sure no one calls it directly on a NumberImp*.
kjs/nodes.cpp: (ForInNode::execute): Call dispatch method not the real method.
kjs/object.cpp: (ObjectImp::propList): Call dispatch method not the real method.
kjs/object.h:
kjs/string_object.cpp: (StringProtoFuncImp::call): Call dispatch method not the real method. (StringObjectImp::construct): Call dispatch method not the real method.
kjs/value.h:
kjs/value.cpp: (ValueImp::marked): Put a comment about required FIXNUM change. (ValueImp::setGcAllowed): Likewise. (ValueImp::dispatchType): Just call the virtual method for now. (ValueImp::dispatchToPrimitive): Likewise. (ValueImp::dispatchToBoolean): Likewise. (ValueImp::dispatchToNumber): Likewise. (ValueImp::dispatchToString): Likewise. (ValueImp::dispatchToObject): Likewise. (ValueImp::dispatchToUInt32): Likewise. (ValueImp::dispatchGetBase): Likewise. (ValueImp::dispatchGetPropertyName): Likewise. (ValueImp::dispatchGetValue): Likewise. (ValueImp::dispatchPutValue): Likewise. (ValueImp::dispatchDeleteValue): Likewise.

Aug 14, 2002:

9:32 PM Changeset in webkit [1823] by darin

4 edits in trunk/JavaScriptCore

Another pass of tweaks, including one bug fix.

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): Use malloc, not new. (ArrayInstanceImp::get): Use a local variable so we don't rely on the optimizer to avoid indexing twice. (ArrayInstanceImp::hasProperty): Use a local variable, and also check against UndefinedImp::staticUndefined rather than doing type() != UndefinedType.

8:19 PM Changeset in webkit [1822] by mjs

4 edits in trunk/JavaScriptCore

Simplified array handling by using NULL to represent empty cells
instead of the Undefined object, so we can use calloc, realloc and
memset instead of loops. Inspired by a suggestion of Darin's.

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): (ArrayInstanceImp::~ArrayInstanceImp): (ArrayInstanceImp::get): (ArrayInstanceImp::hasProperty): (ArrayInstanceImp::deleteProperty): (ArrayInstanceImp::setLength): (ArrayInstanceImp::mark):

5:59 PM Changeset in webkit [1821] by mjs

5 edits in trunk/JavaScriptCore

Fix major JavaScript memory leak. run-plt says cvs-base improved
by 2% and cvs-js-performance improved by 7%. However, this was
within the possible noise level in each case.

The fix was to store ValueImp *'s in the array instead of Value
objects, since the Value wrapper will keep a ref and make the
object immortal.

kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): (ArrayInstanceImp::get): (ArrayInstanceImp::put): (ArrayInstanceImp::hasProperty): (ArrayInstanceImp::deleteProperty): (ArrayInstanceImp::setLength): (ArrayInstanceImp::mark):
kjs/array_object.h:

5:48 PM Changeset in webkit [1820] by cblu

27 edits in trunk/WebKit

WebKit:

Support for showing favicons in bookmarks and history.

Renamed "image" to "icon" in all places.

Made history and bookmarks take and save an icon URL

Bookmarks.subproj/WebBookmark.h:
Bookmarks.subproj/WebBookmark.m: (-[WebBookmark icon]): (-[WebBookmark iconURL]): (-[WebBookmark setIconURL:]):
Bookmarks.subproj/WebBookmarkGroup.h:
Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _setTopBookmark:]): (-[WebBookmarkGroup addNewBookmarkToBookmark:withTitle:iconURL:URLString:type:]): (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:iconURL:URLString:type:]):
Bookmarks.subproj/WebBookmarkLeaf.h:
Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[WebBookmarkLeaf dictionaryRepresentation]): (-[WebBookmarkLeaf copyWithZone:]): (-[WebBookmarkLeaf icon]): (-[WebBookmarkLeaf iconURL]): (-[WebBookmarkLeaf setIconURL:]): (-[WebBookmarkLeaf setURLString:]):
Bookmarks.subproj/WebBookmarkList.h:
Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initWithTitle:group:]): (-[WebBookmarkList dealloc]): (-[WebBookmarkList copyWithZone:]): (-[WebBookmarkList icon]):
Bookmarks.subproj/WebBookmarkSeparator.m: (-[WebBookmarkSeparator icon]):
History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (-[WebHistory updateURL:title:displayTitle:iconURL:forURL:]):
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem iconURL]): (-[WebHistoryItem icon]): (-[WebHistoryItem setIconURL:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]):
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate updateURL:title:displayTitle:iconURL:forURL:]):
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (+[WebIconLoader iconLoaderWithURL:]): (-[WebIconLoader initWithURL:]): (-[WebIconLoader URL]): (-[WebIconLoader _icons]): (-[WebIconLoader delegate]): (-[WebIconLoader iconFromCache]): (-[WebIconLoader startLoading]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]):
WebCoreSupport.subproj/WebBridge.m:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
WebView.subproj/WebLocationChangeHandler.h:
WebView.subproj/WebLocationChangeHandler.m: (-[WebLocationChangeHandler receivedPageIcon:fromURL:forDataSource:]):

WebBrowser:

Support for showing favicons in bookmarks and history.

Renamed "image" to "icon" in all places.

Made history and bookmarks take and save an icon URL

BookmarksController.h:
BookmarksController.m: (-[BookmarksController imageForBookmark:]): (-[BookmarksController _newItemWithTitle:iconURL:URLString:type:positionIgnoresSelection:]): (-[BookmarksController _newFolder:]): (-[BookmarksController _newSeparator:]): (-[BookmarksController _newBookmark:]): (-[BookmarksController _blessOrCreateFavoritesRoot]): (-[BookmarksController _newBookmarkSheetDidEnd:returnCode:contextInfo:]): (-[BookmarksController displayNewBookmarksSheetForURLs:titles:iconURLs:inWindow:]):
BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument dealloc]): (-[BrowserDocument addBookmark:]): (-[BrowserDocument _setInstantRedirectPending:]): (-[BrowserDocument setIcon:]): (-[BrowserDocument iconURL]): (-[BrowserDocument setIconURL:]):
BrowserWindow.h:
BrowserWindowController.m: (-[BrowserWindowController windowIconURL]): (-[BrowserWindowController bookmarkIconURLForLocationField:]):
ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):
FavoriteButton.m: (-[FavoriteButton initWithBookmark:andFrame:]):
GlobalHistory.m: (-[GlobalHistory outlineView:willDisplayCell:forTableColumn:item:]): (-[GlobalHistory _addHistoryEntry:toMenu:]): (-[GlobalHistory addSelectedItemsToBookmarks:]):
LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]): (-[LocationChangeHandler receivedPageIcon:fromURL:forDataSource:]):
LocationTextField.h:
LocationTextField.m: (-[LocationTextField mouseDown:]):
NewBookmarksController.h:
NewBookmarksController.m: (-[NewBookmarksController initWithURLs:titles:iconURLs:]):
TitleBarButton.m: (-[TitleBarButton startDragIfNecessaryForEvent:URL:]):

3:30 PM Changeset in webkit [1819] by hyatt

4 edits in trunk/WebCore

ROFL. The KHTML table code had a hardcoded "20" being
subtracted out of table heights instead of using the
actual margins on the <body> element. This patch
removes the hardcoded "20" and replaces it with the
actual <body> margins.

khtml/rendering/render_table.cpp: (RenderTable::layoutRows):

2:59 PM Changeset in webkit [1818] by hyatt

4 edits in trunk/WebCore

Fix marginwidth and marginheight on the <body> element.
These attributes were not applying the correct margins,
which would cause many many pages to mis-render!

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):

2:45 PM Changeset in webkit [1817] by hyatt

5 edits in trunk/WebCore

Ensure that a rendering object gets built for <fieldset>
elements. Content inside a <fieldset> was being discarded
and not rendered.

This fixes the top frame on blogger comment posting so that
it shows up properly.

khtml/html/html_formimpl.cpp: (HTMLFieldSetElementImpl::attach):
khtml/html/html_formimpl.h:

8:07 AM Changeset in webkit [1816] by darin

19 edits in trunk/WebKit

Remove some unused things. Fix minor problems.

Plugins.subproj/WebPluginNullEventSender.m:
Plugins.subproj/WebPluginView.m:
WebCoreSupport.subproj/WebTextRenderer.m: Fixed places that were using the C++ bool instead of the Objective C BOOL.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): Remove old code related to the dummy data source.

WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Remove _changeBridge, since we don't any more. Hoist the creation of the bridge up here.
WebView.subproj/WebFramePrivate.h: Remove _changeBridge.
WebView.subproj/WebFramePrivate.m: Remove _changeBridge.

WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLView.h:
WebView.subproj/WebImageRepresentation.h:
WebView.subproj/WebTextRepresentation.h:
WebView.subproj/WebTextView.h: Don't re-declare methods that are part of protocols we implement.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't add the mouse moved observer until the view gets put into a window. (-[WebHTMLView addMouseMovedObserver]): Added. (-[WebHTMLView removeMouseMovedObserver]): Added. (-[WebHTMLView viewWillMoveToWindow:]): Remove observer if we were in the main window. (-[WebHTMLView viewDidMoveToWindow]): Add observer if we are now in the main window.
WebView.subproj/WebHTMLViewPrivate.h: Add _frame method. Remove unused controller and cursor instance variables.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frame]): Added. (-[WebHTMLView _bridge]): Call _frame.

WebView.subproj/WebTextRepresentation.m: Add now-needed import.

WebView.subproj/WebHTMLRepresentation.m: Tweak.

7:39 AM Changeset in webkit [1815] by darin

2 edits in trunk/WebKit

Fix a log entry.

7:19 AM Changeset in webkit [1814] by darin

6 edits in trunk/WebCore

Fix the build.

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Add braces and fix a syntax error.

kwq/mac-encodings.txt: Add comments. Make utf-16 be a synonym for utf-8 rather than having it actually try to treat things as 16-bit. We will have to revisit this, but for now it makes zingermans.com work again.

kwq/make-charset-table.pl: Allow comments.

2:02 AM Changeset in webkit [1813] by mjs

4 edits in trunk/WebCore

Fixed a JavaScript object leak that was plaguing ign.com and
livepage.apple.com, among other things.

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Create a Value wrapper for a newly allocated DOMNode object that's not used past this function so it gets GC'd properly. (KJS::HTMLElement::putValue): Likewise.

1:23 AM Changeset in webkit [1812] by mjs

4 edits in trunk/WebCore

khtml/ecma/kjs_window.cpp: Fix to build clean after JavaScriptCore live class changes (this way of handling it is kind of a hack, but kjs is unhappy to have Boolean defined so it can't unconditionally include CoreFoundation.h in collector.h; will fix better later).

Aug 13, 2002:

11:38 PM Changeset in webkit [1811] by mjs

14 edits in trunk

JavaScriptCore:

Add the ability to determine the classes of live JavaScript
objects, to help with leak fixing.

kjs/collector.h, kjs/collector.cpp: (Collector::liveObjectClasses):

WebCore:

Add the ability to determine the classes of live JavaScript
objects, to help with leak fixing.

kwq/WebCoreJavaScript.h:
kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript liveObjectClasses]):

WebKit:

Add the ability to determine the classes of live JavaScript
objects, to help with leak fixing.

Misc.subproj/WebCoreStatistics.h:
Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptLiveObjectClasses]):

WebBrowser:

Add display of classes of live JavaScript objects to Caches
window, to help with leak fixing.

Debug/CacheController.h:
Debug/CacheController.m: (-[CacheController refreshJavaScriptStatisticsMatrix]):
Debug/CacheController.nib:

10:01 PM Changeset in webkit [1810] by hyatt

6 edits in trunk/WebCore

An initial implementation of percentage height table cells.
This implementation will properly distribute space among
rows with percentage table cells, although there could be
issues with percentage height cells that span rows.

I have also fixed replaced elements so that they understand when they
are a percentage height and contained within a percentage height
cell that they can grow. This fixes the textarea on bloggers'
comment posting page so that it sizes properly.

There are many issues remaining with this implementation;
blocks need to be taught how to flex when they specify a percent
height. There is also some sort of rounding error with tables
that specify a height of 100% that I haven't yet figured out.
(This error was present before my changes, and it's still present
after my changes.)

Also, percentage height tables seem to "lock" to the largest size
they've ever been and don't properly relayout when they become
smaller. Again, this bug existed before my changes.

khtml/rendering/render_box.cpp: (RenderBox::calcReplacedHeight):
khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::calcRowHeight): (RenderTable::layout): (RenderTable::layoutRows): (RenderTable::print): (RenderTableCell::RenderTableCell):
khtml/rendering/render_table.h:

4:49 PM Changeset in webkit [1809] by darin

9 edits
1 add
1 delete in trunk/WebCore

Character set handling improvements. In total, this adds 92 new character encoding
names to the list we know how to handle (299, up from 207), so it probably makes
some pages work that didn't work before. It probably also adds character encoding
names that are never used in practice.

kwq/character-sets.txt: Took out all but one of our changes. We now handle aliases that are not in this file by adding them to mac-encodings.txt.
kwq/mac-encodings.txt: Added. Lists CFStringEncoding values and IANA names for them. We keep this file small by using the aliasing in character-sets.txt, and we also continue to get MIB numbers from character-sets.txt.
kwq/make-charset-table.pl: Rewrote to read from new format mac-encodings.txt file, and check for new kinds of errors.

kwq/.cvsignore: Don't ignore the make-mac-encodings files any more, since we don't compile that any more.
kwq/Makefile.am: Remove rules for compiling and running make-mac-encodings.
kwq/make-mac-encodings.c: Removed.

10:06 AM Changeset in webkit [1808] by darin

5 edits in trunk/WebCore

fixed 3023439 -- support for windows-874 charset for thai

kwq/character-sets.txt: Added cp874 and windows-874.
kwq/make-charset-table.pl: Fix bug where it would right out a bad MIB enum for the many Macintosh character sets without associated MIB numbers.

9:45 AM Changeset in webkit [1807] by darin

7 edits in trunk/WebCore

Some QRegion fixes inspired by Dave's clipping work.

kwq/qt/qregion.h: Add setClip, remove getNSBezierPath.
kwq/KWQRegion.mm: (NSMakePoint): Added. Helper function; could go in a header some day. (NSMakeRect): Added. Helper function; could go in a header some day. (MakeQRect): Added. Helper function; could go in a header some day. (QRegion::QRegion): Make a paths array instead of a single path. Also, change things so we actually copy the paths. The old code might translate a path that was shared by two QRegion objects. (QRegion::intersect): Merge the paths arrays of the two passed-in paths. (QRegion::contains): Return true only if all paths in the array contain the point. (QRegion::isNull): Return true if any of the paths in the array are empty. (QRegion::translate): Translate all the paths in the array. (QRegion::boundingRect): Return the intersection of the bounding rects of all the paths in the array. (QRegion::setClip): Call setClip on the first path, and addClip on the others.

kwq/KWQPainter.mm: (QPainter::setClipRegion): Use QRegion::setClip().

12:39 AM Changeset in webkit [1806] by mjs

4 edits in trunk/JavaScriptCore

Small speed improvement. 3% faster on cvs-js-performance, no
measurable change on cvs-static-urls.

kjs/collector.cpp: (Collector::collect): Combine 3 loops over all objects into one, to reduce flat time and improve locality of reference.

Aug 12, 2002:

11:55 PM Changeset in webkit [1805] by hyatt

4 edits in trunk/WebCore

Reverting a change that I unintentionally checked in last
week. I wasn't yet ready to land it. It may work, but I
want to test it more first.

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

5:55 PM Changeset in webkit [1804] by hyatt

7 edits in trunk/WebCore

Implement clipping. The one thing that still needs
to be done is that the intersect method in KWQRegion.mm
needs to be implemented. Even without that, this gets
the ticker on livepage.apple.com clipping properly.

kwq/KWQPainter.mm: (QPainter::xForm): (QPainter::save): (QPainter::restore): (QPainter::setClipRegion):
kwq/qt/qregion.h:

4:57 PM Changeset in webkit [1803] by hyatt

8 edits in trunk/WebCore

Make the news ticker on livepage.apple.com scroll properly.
It still doesn't clip though. Fixing this involved correctly
dirtying the render tree when dynamic DOM changes occurred
(this was a bug in KHTML's DOM), as well as providing an
implementation of the MSIE offsetWidth extension that took
inlines into account (KHTML's impl was always returning a width
of 0 for inlines).

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
khtml/rendering/render_flow.cpp: (RenderFlow::offsetWidth): (RenderFlow::offsetHeight):
khtml/rendering/render_flow.h:
khtml/rendering/render_object.h:
khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):

3:27 PM Changeset in webkit [1802] by darin

4 edits in trunk/WebCore

khtml/misc/loader.cpp: (Cache::insertInLRUList): Add missing piece of the last check-in.

3:15 PM Changeset in webkit [1801] by darin

12 edits in trunk

WebCore:

At Ken's urging, fixed the loader cache to be more efficient.
Gives 1% on the cvs-base test.

force-clean-timestamp: This requires a full rebuild.

khtml/misc/loader.h:
khtml/misc/loader.cpp: (CachedObject::~CachedObject): No longer inline, which is fine since it was a virtual function anyway. Remove from the LRU list. (CachedObject::setRequest): Add to the LRU list if it qualifies now. (CachedObject::ref): Remove from the LRU list. (CachedObject::deref): Add to the LRU list if it qualifies now. (CachedCSSStyleSheet::ref): Call CachedObject::ref. (CachedCSSStyleSheet::deref): Call CachedObject::deref. (CachedScript::ref): Call CachedObject::ref. (CachedScript::deref): Call CachedObject::deref. (CachedImage::ref): Call CachedObject::ref. (CachedImage::deref): Call CachedObject::deref. (Cache::init): No "LRU list" to create. (Cache::clear): No "LRU list" to delete. (Cache::requestImage): Call moveToHeadOfLRUList. (Cache::requestStyleSheet): Call moveToHeadOfLRUList. (Cache::requestScript): Call moveToHeadOfLRUList. (Cache::flush): New algorithm. (Cache::removeCacheEntry): Call removeFromLRUList. (Cache::removeFromLRUList): Added. (Cache::moveToHeadOfLRUList): Added. (Cache::insertInLRUList): Added.

kwq/KWQLoaderImpl.mm: (KWQCheckIfReloading):
kwq/WebCoreBridge.h: Change dataSourceIsReloading to isReloading.

WebKit:

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isReloading]): Change dataSourceIsReloading to isReloading.

1:15 PM Changeset in webkit [1800] by hyatt

6 edits in trunk/WebCore

Fix for the crash (assert) at mlb.com (3014322). recalcStyle was
re-entrant, causing the render tree to be reconstructed
while in the process of being destroyed.

Also patched object frame to only fire load/unload if
render objects exist (since the plugin cannot load without
the render object initializing it anyway).

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): (HTMLObjectElementImpl::detach):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle):
khtml/xml/dom_docimpl.h:

1:14 PM Changeset in webkit [1799] by darin

33 edits in trunk

top level:

Tests/WebFoundation-Misc/ifnsurlextensions-test.m: (TestURLCommon): Add tests for the new WebNSURLExtras methods.

Tests/libiftest/IFCheckLeaks.c: (IFCheckLeaksAtExit): Remove workaround for CFPreferences race condition; it's now in WebFoundation.

JavaScriptCore:

Speed improvements. 19% faster on cvs-js-performance, 1% on cvs-static-urls.

Use global string objects for length and other common property names rather
than constantly making and destroying them. Use integer versions of get() and
other related calls rather than always making a string.

Also get rid of many unneeded constructors, destructors, copy constructors, and
assignment operators. And make some functions non-virtual.

kjs/internal.h:
kjs/internal.cpp: (NumberImp::toUInt32): Implement. (ReferenceImp::ReferenceImp): Special case for numeric property names. (ReferenceImp::getPropertyName): Moved guts here from ValueImp. Handle numeric case. (ReferenceImp::getValue): Moved guts here from ValueImp. Handle numeric case. (ReferenceImp::putValue): Moved guts here from ValueImp. Handle numeric case. (ReferenceImp::deleteValue): Added. Handle numeric case.

kjs/array_object.h:
kjs/array_object.cpp: All-new array implementation that stores the elements in a C++ array rather than in a property map. (ArrayInstanceImp::ArrayInstanceImp): Allocate the C++ array. (ArrayInstanceImp::~ArrayInstanceImp): Delete the C++ array. (ArrayInstanceImp::get): Implement both the old version and the new overload that takes an unsigned index for speed. (ArrayInstanceImp::put): Implement both the old version and the new overload that takes an unsigned index for speed. (ArrayInstanceImp::hasProperty): Implement both the old version and the new overload that takes an unsigned index for speed. (ArrayInstanceImp::deleteProperty): Implement both the old version and the new overload that takes an unsigned index for speed. (ArrayInstanceImp::setLength): Added. Used by the above to resize the array. (ArrayInstanceImp::mark): Mark the elements of the array too. (ArrayPrototypeImp::ArrayPrototypeImp): Pass the length to the array instance constructor.

kjs/bool_object.cpp:
kjs/date_object.cpp:
kjs/error_object.cpp:
kjs/function.cpp:
kjs/function_object.cpp:
kjs/math_object.cpp:
kjs/nodes.cpp:
kjs/nodes.h:
kjs/number_object.cpp:
kjs/object_object.cpp:
kjs/regexp_object.cpp:
kjs/string_object.cpp:

kjs/nodes2string.cpp: (SourceStream::operator<<): Add a special case for char now that you can't create a UString from a char implicitly.

kjs/object.h:
kjs/object.cpp: (ObjectImp::get): Call through to the string version if the numeric version is not implemented. (ObjectImp::put): Call through to the string version if the numeric version is not implemented. (ObjectImp::hasProperty): Call through to the string version if the numeric version is not implemented. (ObjectImp::deleteProperty): Call through to the string version if the numeric version is not implemented.

kjs/types.h:
kjs/types.cpp: (Reference::Reference): Added constructors for the numeric property name case.

kjs/ustring.h: Made the constructor that turns a character into a string be explicit so we don't get numbers that turn themselves into strings.
kjs/ustring.cpp: (UString::UString): Detect the empty string case, and use a shared empty string. (UString::find): Add an overload for single character finds. (UString::rfind): Add an overload for single character finds. (KJS::operator==): Fix bug where it would call strlen(0) if the first string was not null. Also handle non-ASCII characters consistently with the rest of the code by casting to unsigned char just in case.

kjs/value.h: Make ValueImp and all subclasses non-copyable and non-assignable.
kjs/value.cpp: (ValueImp::toUInt32): New interface, mainly useful so we can detect array indices and not turn them into strings and back. (ValueImp::toInteger): Use the new toUInt32. Probably can use more improvement. (ValueImp::toInt32): Use the new toUInt32. Probably can use more improvement. (ValueImp::toUInt16): Use the new toUInt32. Probably can use more improvement. (ValueImp::getBase): Remove handling of the Reference case. That's in ReferenceImp now. (ValueImp::getPropertyName): Remove handling of the Reference case. That's in ReferenceImp now. (ValueImp::getValue): Remove handling of the Reference case. That's in ReferenceImp now. (ValueImp::putValue): Remove handling of the Reference case. That's in ReferenceImp now. (ValueImp::deleteValue): Added. Used so we can do delete the same way we do put.

WebFoundation:

CacheLoader.subproj/WebHTTPResourceLoader.m: (-[WebHTTPProtocolHandler createWFLoadRequest]): Fix handling of paths with queries and some other subtle path and port number handling issues by using _web_hostWithPort and _web_pathWithQuery.

Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_hostWithPort]): Added. (-[NSURL _web_pathWithQuery]): Added.

CacheLoader.subproj/WebResourceLoad.m: (initLoader): Get some random preference before creating threads. This makes it impossible to run into the CFPreferences race condition.

WebCore:

force-clean-timestamp: Need a full build because of KJS changes.
khtml/ecma/kjs_window.h: Need to store an Object, not an ObjectImp, because there's no way to copy an ObjectImp. KJS changes caught this mistake.

9:12 AM Changeset in webkit [1798] by mjs

5 edits in trunk/WebKit

WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: Remove private _flags and _attributes accessors, now that Ken added public versions.
WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Remove sole use thereof.

2:35 AM Changeset in webkit [1797] by darin

4 edits in trunk/WebCore

WebCore:

re-fixed 2948387 -- stop button flashes to "go" two extra times while loading citibank.com

It turns out Maciej and I rebroke this when we made the "completed" code run.
There was a related APPLE_CHANGES that had to be removed so that we do each redirect only once.
Doing the redirect multiple times sent confusing signals to the web browser.

khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): Remove APPLE_CHANGES so we don't try to redirect until the page is complete.

WebBrowser:

Fixed a small thing related to bug 2948387.

BrowserDocument.m: (-[BrowserDocument displayName]): Leave title saying "Loading" as long as _instantRedirectPending is YES.

Aug 10, 2002:

5:31 PM Changeset in webkit [1796]

3 copies in tags/Alexander-17

This commit was manufactured by cvs2svn to create tag 'Alexander-17'.

5:31 PM Changeset in webkit [1795] by kocienda

8 edits in trunk

Rolled version number to Alex-17

11:28 AM Changeset in webkit [1794] by kocienda

4 edits in trunk/WebCore

Check box in target setting panel to enable prebinding.

WebCore.pbproj/project.pbxproj

11:24 AM Changeset in webkit [1793] by kocienda

18 edits in trunk

WebFoundation:

Added a new constant WebResourceHandleUseCachedObjectIfPresent.
This constant is used during reload so that a cached object
is returned regardless of its expiration.

CacheLoader.subproj/WebCacheLoaderConstants.h: Added constant.
CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m: (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Added check for new WebResourceHandleUseCachedObjectIfPresent constant.
CacheLoader.subproj/WebResourceLoad.m:

Also added a change to improve the percentage of cache hits:

(-[WebResourceLoad succeeded]): Use originalURL for caching. This will mean that
the cache is checked for what the user typed in, or has in their bookmarks. This
improves cache hits quite a bit.

WebCore:

Added an extra function which checks with WebKit to see if
the load is a reload. If it is, the WebCore cache is bypassed.

khtml/misc/loader.cpp: (DocLoader::requestImage): Added acall to new KWQCheckIfReloading function. (DocLoader::requestStyleSheet): Ditto. (DocLoader::requestScript): Ditto.
kwq/KWQLoaderImpl.h:
kwq/KWQLoaderImpl.mm: (KWQCheckIfReloading): New function which checks with WebKit to see if the load is a reload.
kwq/WebCoreBridge.h:

WebKit:

Added support for "stale mode" (loads triggered by use of back/forward), and
added support for reload.

Also added a bridge function so the WebCore cache can tell if a load is a reload.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceIsReloading]): New method.
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Use same flags that were used for main resource load.
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource attributes]): New accessor. (-[WebDataSource flags]): New accessor.
WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Reload adds WebResourceHandleFlagLoadFromOrigin flag to load.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Adds flags so that WebFoundation can tell when back/forward has been used.

WebBrowser:

Fix for this bug:

Radar 2870727 ("Refresh" in Alexander doesn't bypass cache)

BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): Removed code that prevented the call through to reload from being called, now that I have hooked up the code so that reload is handled properly.

Aug 9, 2002:

9:32 PM Changeset in webkit [1792] by darin

3 edits in trunk/JavaScriptCore

Some string speedups. Makes sony.com cached 11% faster on Development, but
the improvement for Deployment should be greater.

9:31 PM Changeset in webkit [1791] by darin

13 edits in trunk

JavaScriptCore:

Some string speedups. Makes sony.com cached 11% faster.

kjs/ustring.h: Made it possible for UChar objects to be uninitialized, which gives a speed boost. Inlined CString's +=, UString's destructor, +=, and +.
kjs/ustring.cpp: (UString::UString): Optimize const char * version, which showed up heavily in performance analysis. Added new two-UString version, which makes the + operator fast. (UString::ascii): Remove thread safety changes. Change static buffer to remember its size, and to always be at least 4096 bytes long; that way we never have to reallocate unless it's for a long string. Also make code to extract the characters significantly faster by getting rid of two pointer dereferences per character. (UString::is8Bit): Avoid one pointer dereference per character. (UString::toDouble): Use ascii() instead of cstring() to avoid copying the string.

kjs/collector.cpp: Remove unneeded APPLE_CHANGES.
kjs/regexp.cpp: Remove ifdefs around some APPLE_CHANGES that we want to keep, because they just fix warnings.
kjs/value.h: Remove obsolete APPLE_CHANGES comment.

JavaScriptCore.pbproj/project.pbxproj: Project Builder decided to move a line around in the file.

WebCore:

force-clean-timestamp: JavaScriptCore headers changed that require a full build here.

5:04 PM Changeset in webkit [1790] by mjs

4 edits in trunk/JavaScriptCore

Fix my last change to actually call the versions of the lock functions
that are recursive and initialize as needed.

kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::evaluate):

4:24 PM Changeset in webkit [1789] by mjs

7 edits in trunk/JavaScriptCore

fixed 2948835 - JavaScriptCore locking is too fine grained, makes it too slow

kjs/collector.cpp: (Collector::allocate): (Collector::collect): (Collector::finalCheck): (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects):
kjs/collector.h:
kjs/internal.cpp: (initializeInterpreterLock): (lockInterpreter): (unlockInterpreter): (Parser::parse): (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::evaluate):
kjs/value.cpp: (ValueImp::ValueImp): (ValueImp::setGcAllowed):

4:12 PM Changeset in webkit [1788] by darin

9 edits in trunk/WebCore

fixed 3018063 -- frame problems at directory.apple.com
fixed 3021484 -- Go to "xxxx" mouseover status message should not show ".."

Basically, we had no frame targeting for forms. I made the form code share
the same frame targeting code we use for clicking on URLs.

khtml/khtml_part.cpp: (KHTMLPart::openURLInFrame): Don't compile this function at all any more.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Call the impl's openURLRequest instead of calling the part's openURLInFrame. Clearer.

kwq/KWQKHTMLPartImpl.h: Remove openURLInFrame, add openURLRequest. Change urlSelected args parameter to a const reference. Add private getBridgeForFrameName helper function.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::getBridgeForFrameName): Moved rules for choosing a frame here from urlSelected so they can be shared. (KWQKHTMLPartImpl::openURLRequest): Use getBridgeForFrameName instead of having our own different code for finding the right frame. (KWQKHTMLPartImpl::urlSelected): Move frame choosing code into getBridgeForFrameName. (KWQKHTMLPartImpl::submitForm): Use getBridgeForFrameName instead of always ignoring the target and using our own frame. (KWQKHTMLPartImpl::overURL): Take base targeting into account when making the status bar messages, and use the completed URL, not the partial, for the message.

2:23 PM Changeset in webkit [1787] by darin

5 edits in trunk/WebCore

fixed 2945441 -- base target is ignored

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Add code to respect the base target in the document. It would be way better to use more of the KHTML code instead of copying it a line at a time into KWQ -- that can come later when the fire drill is over.

11:01 AM Changeset in webkit [1786]

3 copies in tags/Alexander-16

This commit was manufactured by cvs2svn to create tag 'Alexander-16'.

11:01 AM Changeset in webkit [1785] by sheridan

8 edits in trunk

Alex-16 versioning

9:10 AM Changeset in webkit [1784] by darin

4 edits in trunk/WebCore

fixed 3020594 -- crash in KWQKHTMLPartImpl::end() visiting particular page

khtml/khtml_part.cpp: (KHTMLPart::end): Our hacked alternative to a signal requires a NULL check.

12:25 AM Changeset in webkit [1783] by cblu

5 edits in trunk/WebKit

%5 gain on cvs-static related to loading page icons:

WebKit:

Cache icon image for HTML files
resize the icon only in WebIconLoader instead of in multiple places elsewhere

Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (+[WebIconLoader _resizeImage:]): (+[WebIconLoader defaultIcon]): call _resizeImage (+[WebIconLoader iconForFileAtPath:]): added, caches html icon (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): call _resizeImage
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): call iconForFileAtPath

WebBrowser:

resize the page icon in WebIconLoader instead of in multiple places elsewhere
call resetNoDragRect less often

LocationTextField.h:
LocationTextField.m: (-[LocationTextField _setIcon:save:]): no need to resize
TitleBarButton.m: (-[TitleBarButton setImage:]): no need to resize (-[TitleBarButton resetNoDragRect]): renamed (-[TitleBarButton updateFrame]): no need to call resetNoDragRect (-[TitleBarButton viewDidEndLiveResize]): added, call resetNoDragRect (-[TitleBarButton windowDidEndSheet:]): call resetNoDragRect (-[TitleBarButton windowDidDeminiaturize:]): call resetNoDragRect (-[TitleBarButton setTitle:]): call resetNoDragRect

Aug 8, 2002:

10:32 PM Changeset in webkit [1782] by mjs

3 edits in trunk/WebKit

Fix to get onLoad to fire, so the iBench test works.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return the bridge for the new child frame.

10:32 PM Changeset in webkit [1781] by mjs

8 edits in trunk/WebCore

Fix to get onLoad to fire, so the iBench test works.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Put back some needed code that was ifdef'd out (the part that emits completed()). (KHTMLPart::slotChildCompleted): Enabled; ifdef'd out part. (KHTMLPart::frame): Enabled.
khtml/khtml_part.h:
kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::completed): Hack to get completed signal delivered to parent. (KWQKHTMLPartImpl::requestFrame): Initialize m_part
kwq/WebCoreBridge.h: createChildFrameNamed method now returns the bridge for the child frame.

9:21 PM Changeset in webkit [1780] by darin

3 edits in trunk/WebKit

WebKit.pbproj/project.pbxproj: Change the group name back to Debug.

1:46 PM Changeset in webkit [1779] by rjw

13 edits in trunk

Added flag to turn on/off buffered text drawing to help
determine if we get any speed boost. Run from console
with "-BufferTextDrawing YES" to enable buffered text
drawing.

Moved buffered text drawing out of web core.

WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
WebCoreSupport.subproj/WebTextRendererFactory.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):

Move stuff out of core into kit.

kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
kwq/WebCoreTextRendererFactory.h:
kwq/WebCoreTextRendererFactory.m:

12:37 PM Changeset in webkit [1778] by darin

15 edits
4 adds in trunk

top level:

Tests/WebFoundation-Misc/ifnsurlextensions-test.m: Added code to check the new URL extras methods against the old original versions, which are pasted in here for now.
Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: Updated result to match the changes to _web_URLByRemovingLastPathComponent, and to reflect the new "compare with old original versions" testing.

WebFoundation:

Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingLastPathComponent]): Changed behavior when the path is "/" to return the same URL with a path of "", to match the behavior of the old WebNSURLGetParent. I had hoped this would fix bug 3019790, but it did not.

WebCore:

fixed 3019353 -- Japanese (Autodetect) encoding not properly supported

kwq/make-charset-table.pl: Add a "japanese-autodetect" entry to the table explicitly, with a hardcoded encoding value. This should be good enough.

kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
kwq/WebCoreEncodings.h:
kwq/WebCoreSettings.h:
kwq/WebCoreSettings.m: Change "fixed font size" to "default fixed font size".

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

kwq/WebCoreTestController.h: Added.
kwq/WebCoreTestController.m: Added.
WebCore.exp: Mention new class.
WebCore.pbproj/project.pbxproj: Mention new files.

WebKit:

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

Misc.subproj/WebTestController.h: Added.
Misc.subproj/WebTestController.m: Added.
WebKit.pbproj/project.pbxproj: Mention new files.
WebKit.exp: Mention new class.

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: Changed "fixed font size" to "default fixed font size".

WebBrowser:

Some fixes to the text encoding menus.

Preferences.subproj/TextPreferences.m: (-[TextPreferences takeDefaultCharacterSetFrom:]): Update the text encoding menu when the character set is changed, because the section that includes that character set shows up at the top. (-[TextPreferences awakeFromNib]): Pass the TextPreferences object as the target for the menu items, because it's not going to be in the responder chain.

AppController.h: Added updateTextEncodingMenu.
AppController.m: (-[AppController applicationDidFinishLaunching:]): Call updateTextEncodingMenu. (-[AppController updateTextEncodingMenu]): Put the code to set up the text encoding menu in here, so it can be called when the default encoding changes.

TextEncodingMenu.h: Added target and preferred encoding parameters.
TextEncodingMenu.m: (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Add target setting. (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Remove old items before adding new so this can be reused on a menu. Fixed a bug in the original Mail code that causes an extra separator to be left at the bottom when the chosen group is the last one in the list.

LocationChangeHandler.m: Add an import that is needed now that I removed some unneeded imports from AppController.h.

11:51 AM Changeset in webkit [1777] by cblu

3 edits in trunk/WebKit

WebFoundation:

Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_carbonPathForPath:]): added (-[NSFileManager _web_startupVolumeName]): added
WebFoundation.pbproj/project.pbxproj: made WebNSFileManagerExtras.h a private header

WebKit:

Plugins.subproj/WebPluginStream.m: (-[WebPluginStream finishedLoadingWithData:]): call [NSFileManager _web_carbonPathForPath:]

WebBrowser:

Fixed:

3015546 - title bar button should be draggable
3015545 - title bar button should have command-click pop-up menu

BrowserNSViewExtras.h:
BrowserNSViewExtras.m: (-[NSView draggingImage]): added, not used yet (-[NSView startDragFromEvent:withPasteBoard:andImage:]): dragOffset correction
BrowserWindow.h:
BrowserWindowController.m: (-[BrowserWindowController windowURL]): added, called by TitleBarButton (-[BrowserWindowController windowShouldGoToURL:]): added, called by TitleBarButton
ListView.h:
ListView.m:
TitleBarButton.m: (-[TitleBarButton initWithFrame:]): add observers (-[TitleBarButton dealloc]): remove observers (-[TitleBarButton drawRect:]): coord fix (-[TitleBarButton userChoseMenuItem:]): added (-[TitleBarButton _drawPathRepresentingPopUpMenuForEvent:andURL:]): added (-[TitleBarButton _startDragIfNecessaryForEvent:andURL:]): added (-[TitleBarButton mouseDown:]): call new methods above (-[TitleBarButton _resetWindowButtons:]): added (-[TitleBarButton resetFrame]): calls _resetWindowButtons (-[TitleBarButton windowDidEndSheet:]): added (-[TitleBarButton windowDidDeminiaturize:]): added

3:22 AM Changeset in webkit [1776] by mjs

10 edits
2 adds in trunk

WebCore:

Added an SPI that can be used to get at the WebCore
charset-name/encoding table; this is useful for a couple of things
in WebKit.

kwq/WebCoreEncodings.h: Added.
kwq/WebCoreEncodings.mm: Added. (+[WebCoreEncodings charsetNameForEncoding:]): (+[WebCoreEncodings encodingForCharsetName:]):
WebCore.exp: Export the new class.
WebCore.pbproj/project.pbxproj: Add new files.

WebKit:

fixed 2957197 - Need API for getting/setting default text encoding

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Set default encoding if no other is set.
WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Added support for default text encoding pref. (-[WebPreferences defaultTextEncoding]): Likewise. (-[WebPreferences setDefaultTextEncoding:]): Likewise.

WebBrowser:

fixed 2896313 - Default text encoding preference is not yet implemented

English.lproj/MainMenu.nib: Added separator after Default item
Preferences.subproj/English.lproj/TextPreferences.nib: Made the pop-up wider so it would fit the widest encoding
Preferences.subproj/TextPreferences.h:
Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Implemented. (-[TextPreferences takeDefaultCharacterSetFrom:]): Implemented. (-[TextPreferences awakeFromNib]): Add encoding items to pop-up button, remove empty dummy item. (-[TextPreferences initializeFromDefaults]): Initialize pop-up too.
TextEncodingMenu.h:
TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithAction:]): Add a selector parameter so we can use a different one for the real menu and the default pop-up. (_addItemToMenuForEncoding): Likewise.
AppController.m: (-[AppController applicationDidFinishLaunching:]): Pass selector when adding encoding menu items.

1:18 AM Changeset in webkit [1775] by rjw

13 edits
2 adds in trunk

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

WebCoreSupport.subproj/WebGlyphBuffer.h: Added.
WebCoreSupport.subproj/WebGlyphBuffer.m: Added. (-[WebGlyphBuffer initWithFont:color:]): (-[WebGlyphBuffer font]): (-[WebGlyphBuffer color]): (-[WebGlyphBuffer reset]): (-[WebGlyphBuffer dealloc]): (-[WebGlyphBuffer drawInView:]): (-[WebGlyphBuffer addGlyphs:advances:count:at::]):
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
WebCoreSupport.subproj/WebTextRendererFactory.h:
WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory coalesceTextDrawing]): (-[WebTextRendererFactory startCoalesceTextDrawing]): (-[WebTextRendererFactory endCoalesceTextDrawing]): (-[WebTextRendererFactory glyphBufferForFont:andColor:]): (-[WebTextRendererFactory dealloc]):
WebKit.pbproj/project.pbxproj:

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
kwq/WebCoreTextRendererFactory.h:
kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory endCoalesceTextDrawing]): (-[WebCoreTextRendererFactory startCoalesceTextDrawing]):

Context Navigation

Timeline

Sep 7, 2002:

Sep 6, 2002:

Sep 5, 2002:

Sep 4, 2002:

Sep 3, 2002:

Sep 2, 2002:

Aug 31, 2002:

Aug 30, 2002:

Aug 29, 2002:

Aug 28, 2002:

Aug 27, 2002:

Aug 26, 2002:

Aug 24, 2002:

Aug 23, 2002:

Aug 22, 2002:

Aug 21, 2002:

Aug 20, 2002:

Aug 19, 2002:

Aug 18, 2002:

Aug 16, 2002:

Aug 15, 2002:

Aug 14, 2002:

Aug 13, 2002:

Aug 12, 2002:

Aug 10, 2002:

Aug 9, 2002:

Aug 8, 2002:

Download in other formats: