Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 8, 2002:

10:22 PM Changeset in webkit [2288] by darin

• 7 edits in trunk/WebKit

• fixed 3069764 -- REGRESSION: Plug-ins sometimes don't respond to update events, causes disappearing

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView drawRect:]): Set the visible region of the port to the port bounds to work around the fact that NSWindow tries to help us by doing a BeginUpdate call. This ensures we can draw where we think we are dirty, not just where Carbon thinks we are dirty.

• Plugins.subproj/WebNetscapePluginDocumentView.m: Tweak includes.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Tweak includes.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Tweak.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

10:16 PM Changeset in webkit [2287] by darin

• 7 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Project Builder wanted to set encodings for new files. Maybe Richard is not using the new Project Builder on all his machines?

• kwq/KWQString.mm: (_allocateNode): Fix typo in comment.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Tweak.

8:04 PM Changeset in webkit [2286] by darin

• 17 edits in trunk/WebKit

WebKit:

Make WebFrame do the entire frame hierarchy, instead of having the
parent and child pointers in the data source.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Get children from the frame, not the data source. (-[WebBridge setFrame:]): Do the setParent: call on the bridge here, instead of in dataSourceChanged, since the parent relationship is now established even without having the data source. (-[WebBridge dataSourceChanged]): Remove the setParent: call. (-[WebBridge loadRequest:]): Remove the parent parameter. It's already set up at this point so we don't need to set it. (-[WebBridge loadURL:referrer:]): Don't pass a parent. (-[WebBridge postWithURL:referrer:data:contentType:]): Don't pass a parent. (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't pass a parent. (-[WebBridge addBackForwardItemWithURL:anchor:]): Get the parent frame by just calling the parent method instead of the more roundabout way that it was doing it before.

• WebView.subproj/WebController.m: (-[WebController _frameForDataSource:fromFrame:]): Get the children list from the frame, no need to ask the data source. And no need to deal with the provisional data source, since those can't have children any more. (-[WebController _frameForView:fromFrame:]): Ditto.

• WebView.subproj/WebControllerPrivate.h: Change parent parameter when creating a new frame to be a frame, not a data source.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate _clearControllerReferences:]): Get the children list from the frame. (-[WebControllerPrivate dealloc]): Rename the _reset method _controllerWillBeDeallocated to be more concrete. More simplification can happen here later. (-[WebController createFrameNamed:for:inParent:allowsScrolling:]): Call _addChild on the parent frame rather than calling addFrame on the parent data source.

• WebView.subproj/WebDataSource.h: Remove the parent, children, frameNamed, frameNames, and frameExists methods.
• WebView.subproj/WebDataSource.m: (-[WebDataSource controller]): Remove the assertion here about parents, since we don't have a parent pointer any more. (-[WebDataSource isLoading]): Get the list of children from the frame.

• WebView.subproj/WebDataSourcePrivate.h: Remove the parent pointer and the frames dictionary, also remove the _setParent: and addFrame: methods.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Don't release the frames list. (-[WebDataSource _recursiveStopLoading]): Get the frames list from the frame. (-[WebDataSource _layoutChildren]): Ditto. (-[WebDataSource _defersCallbacksChanged]): Ditto.

• WebView.subproj/WebFrame.h: Add parent and children methods.
• WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Call _detachFromParent. (-[WebFrame setProvisionalDataSource:]): Set the encoding of the data source to match the encoding of the parent's data source. This used to be done in [WebDataSource _setParent:]. Further simplification can probably be done here. (-[WebFrame reload]): Remove the call to [WebDataSource _setParent:]. (+[WebFrame _frameNamed:fromFrame:]): Get the children from the frame. (-[WebFrame frameNamed:]): Get the parent from the frame. (-[WebFrame parent]): Added. (-[WebFrame children]): Added.

• WebView.subproj/WebFramePrivate.h: Added parent and children fields, changed reset to _controllerWillBeDeallocated, changed _parentDataSourceWillBeDeallocated to _detachFromParent, added _addChild method. Further simplification can probably be done here.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Release the children array. (-[WebFrame _controllerWillBeDeallocated]): Renamed from reset. Now just calls _detachFromParent. (-[WebFrame _detachFromParent]): Does all the work that reset and _parentDataSourceWillBeDeallocated used to do. (-[WebFrame _setDataSource:]): Call _detachFromParent on all the children and release them before setting up the new data source. (-[WebFrame _transitionToCommitted]): Get the parent from self instead of the data source. (-[WebFrame _isLoadComplete]): Ditto. (+[WebFrame _recursiveCheckCompleteFromFrame:]): Get the children from self instead of the data source. (-[WebFrame _textSizeMultiplierChanged]): Ditto. (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Remove the call to [WebDataSource _setParent:]. (-[WebFrame _addChild:]): Added. Puts the child in a children list, and also sets the override encoding of the child based on our data source's override encoding.

WebBrowser:

Update for the WebKit change that moved the children list to the frame
instead of the data source.

• BrowserWebFrameExtras.h: Remove the parentFrame method, since the parent method on WebFrame now does the same thing.
• BrowserWebFrameExtras.m: (-[WebFrame _topFrame]): Use parent.
• BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]): Call the children method on the frame now, not the data source.
• LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): Get the parent directly from the frame now, no need to go through the data source. (-[LoadProgressMonitor titleChangedForFrame:]): Use the parent method, not parentFrame.

7:41 PM Changeset in webkit [2285] by sullivan

• 3 edits in trunk/WebKit

WebKit:

--2002-10-08 John Sullivan <​sullivan@apple.com>

• WebKit.pbproj/project.pbxproj: Project Builder says I changed it only by setting "hasScannedForEncodings" to 1 -- version wars again?

WebBrowser:

• fixed 3070645 -- Editable items in "Library" column should be drop targets
• made "Library" column unstriped -- I stripified it earlier without realizing that it wasn't supposed to be stripulated.

You can now drop bookmarks from one top-level group into another, and they move
(unless you hold the option key down).

• BookmarksViewController.m: (-[BookmarksViewController awakeFromNib]): register drag types for table view (-[BookmarksViewController menuFolderTitle]): new convenience method (-[BookmarksViewController complainAboutTryingToMoveFavorites]): tweaked wording (-[BookmarksViewController complainAboutTryingToMoveBookmarksMenu]): new method (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): new method, decide what can be dropped and where (-[BookmarksViewController tableView:acceptDrop:row:dropOperation:]): new method, handle the drop; both of these methods are currently overly complicated (-[BookmarksViewController outlineView:acceptDrop:item:childIndex:]): handle trying to move menu root as well as favorites root

• English.lproj/Localizable.strings: update localizations

4:54 PM Changeset in webkit [2284] by hyatt

• 4 edits in trunk/WebCore

This was an unintentional checkin. backing out.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeNamedItem):

4:42 PM Changeset in webkit [2283] by rjw

• 3 edits in trunk/WebKit

Removed unnecessary (and incorrect) include.
The *.m files in DOM.subproj might be removed,
they are empty now.

• DOM.subproj/WebDOMDocument.m:

4:27 PM Changeset in webkit [2282] by rjw

• 9 edits in trunk

i Added bridge method set the selection.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]):

Added selection API.

• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]):

4:07 PM Changeset in webkit [2281] by rjw

• 11 edits in trunk

Add accessor for DOM document.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]):

Added bridge method to get the DOM document.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]):
• kwq/WebCoreDOM.h:

3:47 PM Changeset in webkit [2280] by rjw

• 11 edits in trunk/WebCore

More DOM implementation.

• khtml/dom/dom_text.h:
• khtml/dom/dom_xml.h:
• khtml/xml/dom_textimpl.h:
• khtml/xml/dom_xmlimpl.h:
• kwq/WebCoreDOM.h:
• kwq/WebCoreDOMNode.mm: (DOM::CharacterDataImpl::createInstance): (DOM::TextImpl::createInstance): (DOM::ProcessingInstructionImpl::createInstance): (-[WebCoreDOMCharacterData data]): (-[WebCoreDOMCharacterData setData:]): (-[WebCoreDOMCharacterData length]): (-[WebCoreDOMCharacterData substringData::]): (-[WebCoreDOMCharacterData appendData:]): (-[WebCoreDOMCharacterData insertData::]): (-[WebCoreDOMCharacterData deleteData::]): (-[WebCoreDOMText splitText:]): (+[WebCoreDOMCDATASection CDATASectionWithImpl:DOM::]): (-[WebCoreDOMProcessingInstruction data]): (-[WebCoreDOMProcessingInstruction setData:]):
• kwq/WebCoreDOMPrivate.h:
• kwq/WebDOMElement.h:

3:07 PM Changeset in webkit [2279] by rjw

• 15 edits in trunk

Made getAttributeNodeNamed match spec, changed
to getAttributeNode.

• DOM.subproj/WebDOMElement.h:

Implemented WebCoreDOMElement.
Fixed extra deref of impl in subclasses
of WebCoreDOMNode.

• khtml/dom/dom_element.h:
• khtml/dom/dom_node.h:
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument initWithImpl:DOM::]):
• kwq/WebCoreDOMNode.mm: (DOM::NodeListImpl::createInstance): (DOM::NamedNodeMapImpl::createInstance): (DOM::AttrImpl::createInstance): (DOM::ElementImpl::createInstance): (-[WebCoreDOMNodeList length]): (-[WebCoreDOMNodeList item:]): (-[WebCoreDOMAttr initWithImpl:DOM::]): (+[WebCoreDOMDocumentFragment documentFragmentWithImpl:DOM::]): (-[WebCoreDOMElement tagName]): (-[WebCoreDOMElement setAttribute::]): (-[WebCoreDOMElement removeAttribute:]): (-[WebCoreDOMElement getAttributeNode:]): (-[WebCoreDOMElement removeAttributeNode:]): (-[WebCoreDOMElement getElementsByTagName:]): (-[WebCoreDOMElement getAttributeNS::]): (-[WebCoreDOMElement setAttributeNS:::]):
• kwq/WebDOMDocument.h:
• kwq/WebDOMElement.h:

2:40 PM Changeset in webkit [2278] by sullivan

• 9 edits
  2 deletes in trunk/WebKit

WebKit:

• WebKit part of fix for 3069150 -- eliminate "separator" feature from Bookmarks

• Bookmarks.subproj/WebBookmarkSeparator.h: Removed.
• Bookmarks.subproj/WebBookmarkSeparator.m: Removed. Removed class

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]):
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkPrivate.h:
• English.lproj/StringsNotToBeLocalized.txt: Removed all references to class.

• WebKit.pbproj/project.pbxproj: Updated for removed files.

WebBrowser:

• WebBrowser part of fix for 3069150 -- eliminate "separator" feature from Bookmarks
• fixed 3070014 -- Library view needs "New Folder" button
• fixed 3050660 -- the 5 editing items in the Bookmarks menu before the bookmarks should be moved or made a submenu
• fixed 3069152 -- eliminate the ability to create new empty bookmarks

• OutlineViewPlus.h:
• OutlineViewPlus.m: (-[OutlineViewPlus keyDown:]): Add delegate handling of keyDown events like that in TableViewPlus so I could remove the ugly hack of out-of-sight buttons handling Delete and Return as keyboard shortcuts.

• BookmarksController.m: (-[BookmarksController imageForBookmark:]): Remove bookmark separator handling. (-[BookmarksController addMenuItemForBookmark:toMenu:]): Remove bookmark separator handling.

• BookmarksViewController.h:
• BookmarksViewController.m: (-[BookmarksViewController removeSelectedBookmarks]): removed sender parameter; no longer used as IBAction. (-[BookmarksViewController handleKeyDown:inSourceColumn:]): new bottleneck method for handling Return and Delete (and forward delete) keys pressed in either table view or outline view. (-[BookmarksViewController tableView:keyDown:]): now calls handleKeyDown:inSourceColumn: (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): Remove bookmark separator handling. (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): Remove bookmark separator handling. (-[BookmarksViewController outlineView:keyDown:]): new delegate method, calls handleKeyDown:inSourceColumn: (-[BookmarksViewController delete:]): No sender parameter for removeSelectedBookmarks anymore (-[BookmarksViewController validateUserInterfaceItem:]): Removed case for removeSelectedBookmarks since it's never auto-validated now

• BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): Remove bookmark separator handling.

• English.lproj/Browser.nib: added New Folder button; removed ugly hack of out-of-sight buttons handling Delete and Return; put table view and outline view in boxes to handle New Folder button and future changes.

• English.lproj/Localizable.strings: update localizations

• English.lproj/MainMenu.nib: removed editing items from Bookmarks menu

• FavoriteButton.m: (-[FavoriteButton setBookmark:]): Remove bookmark separator handling. (-[FavoriteButton menu]): Remove bookmark separator handling.

• FavoritesBar.m: (-[FavoritesBar performDragOperation:]): Remove bookmark separator handling.

2:16 PM Changeset in webkit [2277] by rjw

• 17 edits
  7 adds
  2 deletes in trunk

Fixes to the DOM API.

• DOM.subproj/WebDOMDocument.h:
• DOM.subproj/WebDOMDocument.m:
• DOM.subproj/WebDOMNode.h:
• DOM.subproj/WebDOMNode.m:
• DOM.subproj/WebDOMNamedNodeMap.h: Removed.
• DOM.subproj/WebDOMNamedNodeMap.m: Removed.
• WebKit.pbproj/project.pbxproj:

First cut at ObjC stubs for DOM API. Finished the
main classes. Need to finish
WebDOMElement, WebDOMElement, WebDOMElement,
WebDOMCDATASection, WebDOMText, WebDOMComment,
WebDOMCharacterData and

• WebCore.pbproj/project.pbxproj:
• khtml/dom/dom_doc.h:
• khtml/dom/dom_element.h:
• khtml/dom/dom_node.h:
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreDOM.h: Added.
• kwq/WebCoreDOMDocument.mm: Added. (DOM::DOMImplementationImpl::createInstance): (DOM::DocumentTypeImpl::createInstance): (DOM::DocumentImpl::createInstance): (domStringToNSString): (NSStringToDOMString): (+[WebCoreDOMDocumentType documentTypeWithImpl:DOM::]): (-[WebCoreDOMDocumentType initWithImpl:DOM::]): (-[WebCoreDOMDocumentType dealloc]): (-[WebCoreDOMDocumentType DOM::]): (-[WebCoreDOMDocumentType name]): (-[WebCoreDOMDocumentType entities]): (-[WebCoreDOMDocumentType notations]): (-[WebCoreDOMDocumentType publicId]): (-[WebCoreDOMDocumentType systemId]): (-[WebCoreDOMDocumentType internalSubset]): (+[WebCoreDOMImplementation implementionatWithImpl:DOM::]): (-[WebCoreDOMImplementation initWithImpl:DOM::]): (-[WebCoreDOMImplementation dealloc]): (-[WebCoreDOMImplementation DOM::]): (-[WebCoreDOMImplementation hasFeature::]): (-[WebCoreDOMImplementation createDocument:::]): (+[WebCoreDOMDocument documentWithImpl:DOM::]): (-[WebCoreDOMDocument initWithImpl:DOM::]): (-[WebCoreDOMDocument dealloc]): (-[WebCoreDOMDocument DOM::]): (-[WebCoreDOMDocument doctype]): (-[WebCoreDOMDocument implementation]): (-[WebCoreDOMDocument documentElement]): (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]): (-[WebCoreDOMDocument createDocumentFragment]): (-[WebCoreDOMDocument createTextNode:]): (-[WebCoreDOMDocument createComment:]): (-[WebCoreDOMDocument createCDATASection:]): (-[WebCoreDOMDocument createProcessingInstruction::]): (-[WebCoreDOMDocument createAttribute:]): (-[WebCoreDOMDocument createAttributeNS::]): (-[WebCoreDOMDocument createEntityReference:]): (-[WebCoreDOMDocument getElementById:]): (-[WebCoreDOMDocument getElementsByTagName:]): (-[WebCoreDOMDocument getElementsByTagNameNS::]): (-[WebCoreDOMDocument importNode::]):
• kwq/WebCoreDOMNode.mm: Added. (DOM::NamedNodeMapImpl::createInstance): (DOM::AttrImpl::createInstance): (+[WebCoreDOMNode nodeWithImpl:DOM::]): (-[WebCoreDOMNode initWithImpl:DOM::]): (-[WebCoreDOMNode DOM::]): (-[WebCoreDOMNode dealloc]): (-[WebCoreDOMNode nodeName]): (-[WebCoreDOMNode nodeValue]): (-[WebCoreDOMNode setNodeValue:]): (-[WebCoreDOMNode nodeType]): (-[WebCoreDOMNode parentNode]): (-[WebCoreDOMNode firstChild]): (-[WebCoreDOMNode lastChild]): (-[WebCoreDOMNode previousSibling]): (-[WebCoreDOMNode nextSibling]): (-[WebCoreDOMNode ownerDocument]): (-[WebCoreDOMNode insert:before:]): (-[WebCoreDOMNode replace:child:]): (-[WebCoreDOMNode removeChild:]): (-[WebCoreDOMNode hasChildNodes]): (-[WebCoreDOMNode cloneNode:]): (-[WebCoreDOMNode normalize]): (-[WebCoreDOMNode isSupported::]): (-[WebCoreDOMNode namespaceURI]): (-[WebCoreDOMNode prefix]): (-[WebCoreDOMNode setPrefix:]): (-[WebCoreDOMNode localName]): (+[WebCoreDOMNodeList nodeListWithImpl:DOM::]): (-[WebCoreDOMNodeList initWithImpl:DOM::]): (-[WebCoreDOMNodeList DOM::]): (-[WebCoreDOMNodeList dealloc]): (+[WebCoreDOMNamedNodeMap namedNodeMapWithImpl:DOM::]): (-[WebCoreDOMNamedNodeMap initWithImpl:DOM::]): (-[WebCoreDOMNamedNodeMap DOM::]): (-[WebCoreDOMNamedNodeMap dealloc]): (-[WebCoreDOMNamedNodeMap length]): (-[WebCoreDOMNamedNodeMap getNamedItem:]): (-[WebCoreDOMNamedNodeMap setNamedItem:]): (+[WebCoreDOMAttr attrWithImpl:DOM::]): (-[WebCoreDOMAttr initWithImpl:DOM::]): (-[WebCoreDOMAttr DOM::]): (-[WebCoreDOMAttr dealloc]): (-[WebCoreDOMAttr name]): (-[WebCoreDOMAttr specified]): (-[WebCoreDOMAttr value]): (-[WebCoreDOMAttr ownerElement]): (+[WebCoreDOMCDATASection CDATASectionWithImpl:DOM::]): (-[WebCoreDOMCDATASection initWithImpl:DOM::]): (-[WebCoreDOMCDATASection DOM::]): (-[WebCoreDOMCDATASection dealloc]):
• kwq/WebCoreDOMPrivate.h: Added.
• kwq/WebDOMDocument.h: Added.
• kwq/WebDOMElement.h: Added.
• kwq/WebDOMNode.h: Added.

2:12 PM Changeset in webkit [2276] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Some changes to make some progress on this bug:

Radar 3015613 (Search results disappear when backtracking)

This set of changes does not fix this bug, but it does provide much of the WebFoundation
support we'll need for a complete fix. In order to finish the fix, we need to make
some API changes in WebKit.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _cacheKey]): Add HTTP request method to cache key.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): Explicitly set defaults for requestCachePolicy and responseCachePolicy.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldCacheResponse:]): Do not unconditionally determine that HEAD, POST, PUT, and DELETE methods are uncacheable. This change is made so we can show cached results when a user uses back/forward or history to do navigation.

WebKit:

Use WebFrameLoadType variable to set the request cache policy for the WebResourceRequest.
This will help us to provide cached results for POST requests when the user navigates
using the back/forward list or history for navigation, while making sure we do not
use cached results when the user pokes the submit button for a form they have
submitted previously.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:])

1:54 PM Changeset in webkit [2275] by cblu

• 4 edits in trunk/WebKit

WebFoundation:

• Sniff file resources for HTML if we can't determine a MIME type.
• Assume resources without content types or extensions are HTML.

• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse contentType]): Cleaned up, make HTML assumption
• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_isExtensionDefinite]): added, returns YES for common extensions that should be correct.
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler didLoadData:]): sniff if !_web_isExtensionDefinite

WebKit:

Moved assumption that a resource without a content type or extension is HTML to WebFoundation.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

12:52 PM Changeset in webkit [2274] by hyatt

• 7 edits in trunk/WebCore

Fix a bug in my event handling code for layers. This makes
the links on ESPN.com work again (bug 3051636). Yay!

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeNamedItem):
• kwq/qt/qrect.h:

10:51 AM Changeset in webkit [2273] by cblu

• 4 edits in trunk/WebKit

Minor plug-in code clean-up.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]):

8:08 AM Changeset in webkit [2272] by cblu

• 4 edits in trunk/WebKit

Partial fix for 2967073 - should open all TEXT type files, at least

• WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): Sniff for HTML in the fail case.

Oct 7, 2002:

5:00 PM Changeset in webkit [2271] by darin

• 5 edits in trunk/WebCore

• fixed 3037353 -- align="middle" elements not horizontally centered

• khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute):
• khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute): Handle "middle" same as center in these two places.

3:20 PM Changeset in webkit [2270] by darin

• 9 edits in trunk

WebFoundation:

WebFoundation part of implementation of multipart forms posting.

• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]): Remove obsolete support for non-NSData form data. Use the contentType in the request, if present.

• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Add contentType and setContentType methods; convenience for setting the Content-Type header.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest _headerForKey:]): Added. (-[WebResourceRequest userAgent]): Use _headerForKey. (-[WebResourceRequest referrer]): Ditto. (-[WebResourceRequest contentType]): Added. Use _headerForKey. (-[WebResourceRequest setContentType:]): Added.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove requestData.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.

WebCore:

WebCore part of implementation of multipart forms posting.

• kwq/WebCoreBridge.h: Add a contentType parameter to the bridge's [postWithURL:referrer:data:] method.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::submitForm): Extract the content type from the args, and pass it along to the bridge.

WebKit:

WebKit part of implementation of multipart forms posting.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge postWithURL:referrer:data:contentType:]): Add a contentType parameter to match change in WebCore API. Put the contentType value into the request.

3:01 PM Changeset in webkit [2269] by cblu

• 3 edits in trunk/WebKit

• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]): Don't override document view and rep types for types that have already been registered.

2:06 PM Changeset in webkit [2268] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Add a port to the background thread's run loop so it will not exit
the run method constantly.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:])

2:06 PM Changeset in webkit [2267] by darin

• 4 edits in trunk/JavaScriptCore

Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.

• kjs/collector.cpp: (Collector::allocate): Implement a new policy of doing a garbage collect every 1000 allocations. The old policy was both complicated and misguided. (Collector::collect): Zero out the "number of allocations since last collect".

1:29 PM Changeset in webkit [2266] by darin

• 13 edits in trunk

WebCore:

• fixed 3011025 -- Page up/down is not working when text area has focus

• kwq/KWQTextArea.mm: (-[KWQTextArea needsPanelToBecomeKey]): Return YES so we are considered a valid key view even when in normal tabbing mode. This fixes a problem with tabbing backwards into a text area. (-[KWQTextAreaTextView scrollPageUp:]): Added. Passes a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[KWQTextAreaTextView scrollPageDown:]): Ditto.

• kwq/KWQNSTextField.mm: Remove unnecessary overrides of textDidEndEditing. Turns out the real fix was to override display to do nothing as a workaround for bug 2753974.

WebKit:

WebKit part of the page up/down fix.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView scrollPoint:]): If we are called from the handling of a page up or page down keyboard event, then ignore the specific scrolling requested, and do our idea of page up and page down. This guarantees that we will get the smarter idea of how to page from WebView instead of the one that's hardcoded into NSTextView.

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Use scrollPageUp:, scrollPageDown:, scrollLineUp:, and scrollLineDown: instead of _pageUp, _pageDown, _lineUp, and _lineDown. This lets other classes see and use these selectors, which is useful when passing calls up the responder chain.
• WebView.subproj/WebViewPrivate.h: Remove the private methods that are being changed to match the NSResponder keyboard methods.
• WebView.subproj/WebViewPrivate.m: (-[WebView scrollPageUp:]): Rename from _pageUp, and also pass a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[WebView scrollPageDown:]): Ditto. (-[WebView scrollLineUp:]): Rename from _lineUp. (-[WebView scrollLineDown:]): Rename from _lineDown.

1:02 PM Changeset in webkit [2265] by rjw

• 1 edit in trunk/WebCore/force-clean-timestamp

Force build, sorry. PB doesn't seem to be behaving.

12:38 PM Changeset in webkit [2264] by rjw

• 16 edits in trunk

'Re'play the delegate messages when an item is loaded from
the WebCore cache.

Note that the client will NOT receive a willSendRequest: message. The client
presumably already did any request substitution before the object was loaded
into the cache. Allowing the delegate to override the request and replace
the object in the WebCore cache would introduce significant complexity.

Fixes 3069138.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]):

Added response to WebCore's CachedObject. This allows us to correctly
emulated the WebResourceLoadDelegate API when 're'loading an item
from the WebCore cache.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (Loader::receivedResponse):
• khtml/misc/loader.h:
• kwq/KWQLoaderImpl.h:
• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse):
• kwq/WebCoreBridge.h:
• kwq/WebCoreResourceLoader.h:

11:35 AM Changeset in webkit [2263] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed problem in the disk cache where disk writes, once they start, were not being
preempted by future activity through the cache (as it should). The issue here is
that the disk cache was simply "borrowing" the thread that was used to call into
the disk cache to schedule a timer. This turned out to be bad, since that thread
was raised to maximum priority some time ago.

I fixed this by giving the disk cache its own (minimum priority) thread to
write files. This will insulate it from unrelated threading changes in other code.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:]) (databaseInit) (-[WebFileDatabase setTimer]) (-[WebFileDatabase setObject:forKey:])

Oct 6, 2002:

3:17 PM Changeset in webkit [2262] by darin

• 4 edits in trunk/JavaScriptCore

I noticed some broken lists at mapblast.com and tracked it down to this.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Don't truncate the list; only extend the length if it's not already long enough. (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn the ifdefs on.

12:23 PM Changeset in webkit [2261] by darin

• 4 edits in trunk/WebCore

• fixed 3046737 -- infinite loop in font name matching code on some pages

• kwq/KWQString.mm: (QString::replace): Removed the incorrect early exit if the passed in string was the empty string.

Oct 5, 2002:

8:27 AM Changeset in webkit [2260] by darin

• 3 edits in trunk/WebKit

• fixed 3068323 -- nil object inserted in dictionary exception on mouse move

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Add some assertions in the hope of finding if my assumptions about this are wrong, and use the version of the dictionary setter that does nothing if it's passed nil when putting in the frame found by name.

Oct 4, 2002:

10:58 PM Changeset in webkit [2259] by darin

• 4 edits in trunk/WebCore

Tests:

• harness.c: (main): Stop using debug versions of frameworks. This was causing us problems we'd see only in the test programs, and we didn't see the text of the asserts. We can turn this back on again if we make it so we can see what's wrong.

• WebFoundation-Misc/ifnsurlextensions-test.chk: Update for new expected results that handle "../" properly.

• kde/kurl-test.chk: Update for canonicalization, which was added a while back without updating this test.

WebFoundation:

• fixed 3064420 -- NSURLExtras function does not resolve "../" URLs at top level the way the web expects

• Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:relativeToURL:]): Added code to detect URL results that have paths that start with /../ and remove the extra levels. Tested with the Tests directory.

• English.lproj/StringsNotToBeLocalized.txt: Added the string used as a localization exception.

WebCore:

• kwq/KWQKURL.mm: (KURL::parse): Fix code that adds "" to file URLs. The code was including the extra slashes as part of the path, which they are not. Verified with the tests in the Tests directory.

9:34 PM Changeset in webkit [2258] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Add a couple more localization exceptions for newly added strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Add a localization exception for the WebKit bundle identifier.

9:28 PM Changeset in webkit [2257] by darin

• 3 edits
  1 add in trunk/WebKit

WebFoundation:

• Misc.subproj/WebLocalizableStrings.h: Implement the real version of the UI_STRING macro. It uses the FRAMEWORK_NAME preprocessor define to find the appropriate bundle global, and passes that along with the key into the WebLocalizedString function.
• Misc.subproj/WebLocalizableStrings.m: Add the definition for the WebFoundationLocalizableStrings bundle global. (WebLocalizedString): Added. Locates the bundle, then creates a string object, then calls localizedStringForKey to find the localized version of the string in the bundle's localizable strings.
• WebFoundation.exp: Export WebLocalizedString.

• WebFoundation.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebFoundation.

WebKit:

• Misc.subproj/WebKitLocalizableStrings.m: Added. Contains the definition of the WebKitLocalizableStringsBundle.
• WebKit.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebKit.

8:31 PM Changeset in webkit [2256] by darin

• 5 edits in trunk

• fixed 2992187 -- Should use curly quotes in status bar messages, window titles, and error dialogs

• BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): (-[BrowserWindowController goToToolbarLocation:]): Change the last two straight apostrophes to curly ones.

7:00 PM Changeset in webkit [2255] by rjw

• 4 edits
  9 adds in trunk/WebKit

Stubs for DOM level 2 core API.

• DOM.subproj/WebDOMDocument.h: Added.
• DOM.subproj/WebDOMDocument.m: Added.
• DOM.subproj/WebDOMElement.h: Added.
• DOM.subproj/WebDOMElement.m: Added.
• DOM.subproj/WebDOMNamedNodeMap.h: Added.
• DOM.subproj/WebDOMNamedNodeMap.m: Added.
• DOM.subproj/WebDOMNode.h: Added.
• DOM.subproj/WebDOMNode.m: Added.
• WebKit.pbproj/project.pbxproj:

• WebView.subproj/WebHTMLViewPrivate.m: tweak.

Removed import of header that was removed earlier.

• BookmarksController.m:

6:40 PM Changeset in webkit [2254] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Add the last few exceptions. We now have a completely-clean run of extract-localizable-strings in WebKit!

4:46 PM Changeset in webkit [2253] by darin

• 4 edits in trunk/WebKit

• fixed 3060140 -- REGRESSION: frames of animated gif drawn in wrong position.

I got the "fromRect" and "toRect" parameters backwards when I made the changes
to fix bug 3050810.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]): Reverse targetRect and imageRect.

• WebKit.pbproj/project.pbxproj: Mark some new files as UTF-8 because Project Builder asked me to.

3:43 PM Changeset in webkit [2252] by darin

• 2 edits
  2 deletes in trunk/WebKit

• Panels.subproj/WebPanelCookieAcceptHandler.h: Removed.
• Panels.subproj/WebPanelCookieAcceptHandler.m: Removed.

3:39 PM Changeset in webkit [2251] by rjw

• 3 edits in trunk/WebKit

Danger Will Robinson. We have to poseAsClass: as early as possible
so that any NSViews will be created with the appropriate poser.
This problem manifested itself with SimpleViewer failing
immediately. NSViews were created by loading a nib before
WebHTMLView class initialization occured. After posing the
already instantiated instances of NSView had a %NSView class,
causing many things to break.

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

2:27 PM Changeset in webkit [2250] by darin

• 3 edits in trunk/JavaScriptCore

Fixed problems parsing numbers that are larger than a long with parseInt.

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2249] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2248] by rjw

• 6 edits in trunk/WebKit

Ensure that we return non-nil request from handle:willSendRequest:
even when WK's laod delegate is nil.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

1:43 PM Changeset in webkit [2247] by darin

• 7 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add dprintf, NSLog, and NSException to the list of tokens that introduce non-localizable strings, and added handling for square brackets.

WebFoundation:

• CacheLoader.subproj/WebResourceLoad.m: (_loadSweeper):
• Database.subproj/WebFileDatabase.m: (-[WebFileReader initWithPath:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Changed logging code to take advantage of the fact that we once-again support %@.

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]): Fixed logging code to eliminate a leak.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler debugStringForCacheAttributeValue:]): Changed this code to just call description instead of using string formatting.

• English.lproj/StringsNotToBeLocalized.txt: Add more exceptions. We now have a completely-clean run of extract-localizable-strings in WebFoundation!

• English.lproj/Localizable.strings: Re-generated.

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]): Use ERROR instead of NSLog here. (-[WebAuthenticationPanel setUpForRequest:]): Mark some strings for localization.

• WebKit.pbproj/project.pbxproj: Change the encoding on a lot more files to UTF-8.

• English.lproj/StringsNotToBeLocalized.txt: Added some new exceptions.
• English.lproj/Localizable.strings: Re-generated.

WebBrowser:

More progress on localization.

• English.lproj/StringsNotToBeLocalized.txt: Added a few strings.

• GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Marked a string for localization.

• FrameProgressEntry.m: (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): Added an assert in case we run into an issue like the one from earlier today.

• English.lproj/Localizable.strings: Re-generated.

1:32 PM Changeset in webkit [2246] by rjw

• 2 edits in trunk/WebKit/WebView.subproj

Actually checkin.

11:51 AM Changeset in webkit [2245] by rjw

• 4 edits
  2 deletes in trunk/WebKit

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebView:]): (-[DOMTree itemSelected:]):

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDOMNode.h: Removed.
• WebView.subproj/WebDOMNode.m: Removed.

Oct 3, 2002:

7:48 PM Changeset in webkit [2244] by rjw

• 10 edits in trunk/WebKit

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient handle:didReceiveResponse:]):

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument close]):

7:35 PM Changeset in webkit [2243] by rjw

• 4 edits in trunk/WebKit

Create the activity entry in resourceRequest:didReceiveResponse:fromDataSource:
rather than resourceRequest:willSendRequest:fromDataSource:.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]):

Always call resourceRequest:willSendRequest: on resourceProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

7:11 PM Changeset in webkit [2242] by rjw

• 4 edits in trunk/WebKit

Add calls to downloadProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):

6:38 PM Changeset in webkit [2241] by rjw

• 5 edits in trunk/WebKit

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): Hack to prevent handle creation with nil delegate, still perform frame complete check.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Removed unused code.

(-[WebMainResourceClient handle:willSendRequest:]):
Copy the request, ugh.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]): Clean up activity value changes.

• FrameProgressEntry.m: (-[FrameProgressEntry trackSubresource:withIdentifier:forDataSource:]): (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]): Update key when request changes. May be removed if with go with opaque identifier.

• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor entryForKey:dataSource:]): Accessor method for ResourceProgressEntry.

Copy request if a different instance is returned.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]):

5:43 PM Changeset in webkit [2240] by darin

• 4 edits in trunk/WebCore

• fixed 3065730 -- Crash loading "My T-Mobile" page (in khtml::Decoder::decode)

• khtml/misc/decoder.cpp: (Decoder::decode): Fixed a mistake that would cause the loop to run off the end of the buffer, introduced back on 2002-08-30.

5:31 PM Changeset in webkit [2239] by darin

• 11 edits in trunk

WebCore:

Add API to execute JavaScript.

• kwq/WebCoreBridge.h: Add method.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge executeJavaScriptFromString:]): Call through to KHTML. But only if the document is not nil. We need to figure out what to do in the case where the document is nil.

WebKit:

Add API for executing JavaScript.

• WebView.subproj/WebController.h: Add method.
• WebView.subproj/WebController.m: (-[WebController executeJavaScriptFromString:]): Call through to WebCore to do the heavy lifting.

WebBrowser:

Fixed most of 2980477 -- javascript: URLs don't work when typed
into the page address field or in bookmarks

They work now, but only if the frontmost window is not empty.

• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Rename, change to take a policy parameter instead of a boolean, and add code for the javascript: case. (-[WebBookmark goTo]): Pass ReuseAvailableWindow. (-[WebBookmark goToInNewWindow]): Pass CreateWindow. (-[WebBookmark goToUsingNewWindowAccordingToEvent:]): Choose policy based on both the command key and the shift key.

• BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Add add code for the javascript: case.

3:53 PM Changeset in webkit [2238] by darin

• 7 edits
  1 delete in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Do all the remaining TODO items for this script.

WebFoundation:

• English.lproj/Localizable.strings: Added. Generated by script.
• English.lproj/StringsNotToBeLocalized.txt: Updated with many more entries.

• Misc.subproj/WebError.m: Switch from NSLocalizedStringFromTable to UI_STRING.
• Misc.subproj/WebNSStringExtras.m: Switch from dummy WebLocalizedStringWithKeyAndValue to UI_STRING.

• Misc.subproj/WebQueue.m: (+[WebQueue newNode]): Just use malloc.

• English.lproj/WebError.strings: Removed.
• Misc.subproj/WebMultipartForm.h: Removed.
• Misc.subproj/WebMultipartForm.m: Removed.

• WebFoundation.pbproj/project.pbxproj: Changed encoding of many files to UTF-8. Removed files. Added Localizable.strings and StringsNotToBeLocalized.txt.

WebKit:

• English.lproj/Localizable.strings: Generated by the script.
• English.lproj/StringsNotToBeLocalized.txt: Added many more strings to ignore.
• English.lproj/WebError.strings: Removed.

• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebView.m: Use UI_STRING instead of NSLocalizedString.

• WebKit.pbproj/project.pbxproj: Changed encodings of some files to UTF-8. Removed WebError.strings.

WebBrowser:

• BrowserWebController.m: (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): Added. Also put in strings for when the control key is down. (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Factor out the actual string change here. More work on this is required.

• ABHomePagesController.m:
• BookmarkToolbarItem.m:
• BookmarksController.m:
• BookmarksViewController.m:
• BookmarksWindowController.m:
• BrowserWebBookmarkExtras.m:
• BrowserWebController.m:
• BrowserWebErrorExtras.m:
• BrowserWindowController.m:
• ContextMenuHandler.m:
• DownloadMonitor.m:
• DownloadProgressEntry.m:
• FavoriteButton.m:
• FindPanelController.m:
• FrameProgressEntry.m:
• GlobalHistory.m:
• HTMLSourceDocument.m:
• LoadProgressMonitor.m:
• LocationChangeError.m:
• RendezvousController.m:
• Preferences.subproj/AppearancePreferences.m: Switch from NSLocalizedString to UI_STRING

• DateCell.m: Replace the dummy NSLocalizedStringWithKeyAndValue with UI_STRING.
• ResourceProgressEntry.m: (-[ResourceProgressEntry _committedStatus]): Got rid of FIXME: Localize, and put in use of UI_STRING.

• English.lproj/StringsNotToBeLocalized.txt: Add some more exceptions.
• English.lproj/Localizable.strings: Check in script-generated file for now.

• BrowserStrings.h: Removed.

• WebBrowser.pbproj/project.pbxproj: Changed encodings for many files to UTF-8. Also added StringsNotToBeLocalized.txt, although not in any target.

3:06 PM Changeset in webkit [2237] by rjw

• 13 edits
  1 delete in trunk/WebKit

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• BrowserWebController.m:

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• Misc.subproj/WebKit.h:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebResourceProgressDelegate.h: Removed.

2:53 PM Changeset in webkit [2236] by rjw

• 26 edits
  2 deletes in trunk/WebKit

Changed to reflect new WebResourceLoadDelegate API.

• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]):
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withBytesLoaded:bytesExpected:error:dataSource:complete:]): (-[DownloadMonitor resourceRequest:willSendRequest:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]):
• FrameProgressEntry.m: (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]):
• LoadProgressMonitor.m:

Changed to reflect new WebResourceLoadDelegate API.

• Misc.subproj/WebIconLoader.m:
• Misc.subproj/WebKit.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (-[WebSubresourceClient receivedProgressWithComplete:]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgressForResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgressForResourceHandle:bytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:fromDataSource:]):
• WebView.subproj/WebLoadProgress.h: Removed.
• WebView.subproj/WebLoadProgress.m: Removed.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceProgressDelegate.h:

Always send a handle:willSendRequest: before sending a request,
including first time. This will allow WebKit clients to intervene
on every load should they so choose.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]):

12:27 PM Changeset in webkit [2235]

• 3 copies in tags/Alexander-26

This commit was manufactured by cvs2svn to create tag 'Alexander-26'.

12:27 PM Changeset in webkit [2234] by sheridan

• 8 edits in trunk

Alex-26 version

Oct 2, 2002:

5:37 PM Changeset in webkit [2233] by mjs

• 8 edits in trunk/WebKit

• Added "remember my password" checkbox (underlying feature not yet implemented).

• Fixed a bug that caused a crash when cancelling the auth sheet.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Added "remember this password" checkbox.
• Panels.subproj/WebAuthenticationPanel.h:
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel logIn:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): Pass proper remembered value with credential. (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]): Pass proper remembered value with credential.
• WebKit.pbproj/project.pbxproj: Project Builder had its way with this file.

4:52 PM Changeset in webkit [2232] by darin

• 23 edits in trunk

WebCore:

Moved "overURL" handling out of WebCore into WebKit and Alex.
Also separated the two levels of the "element dictionary" so they
don't rely on having the same keys.

• khtml/khtml_part.h: Revert the APPLE_CHANGES to overURL.
• khtml/khtml_part.cpp: (KHTMLPart::overURL): Removed the APPLE_CHANGES and just ifdef'd out the whole thing for our version. (KHTMLPart::khtmlMouseMoveEvent): Get rid of the APPLE_CHANGES and don't do any of the status bar setup.

• kwq/KWQKHTMLPartImpl.h: Remove overURL.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

• kwq/WebCoreBridge.h: Change keys so they don't match the WebKit ones so we don't accidentally rely on that. Add WebCoreElementLinkTarget.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Add code to set up WebCoreElementLinkTarget.

WebKit:

Machinery so we can handle mouseover feedback at the browser level.

• WebView.subproj/WebWindowOperationsDelegate.h: Added mouseDidMoveOverElement:modifierFlags:.

• WebKit.exp: Export WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.h: Add WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.m: Ditto.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView removeMouseMovedObserver]): Send a callback when we stop tracking the mouse altogether. (-[WebHTMLView viewDidMoveToWindow]): Only set up the mouse moved observer if we are the top-level HTML view. (-[WebHTMLView windowDidBecomeMain:]): Ditto. (-[WebHTMLView mouseMovedNotification:]): Handle mouse over if we are over any subview of the HTML view. Also send the callback.

• WebView.subproj/WebHTMLViewPrivate.h: Added lastMouseOverElementWasNotNil, _mouseOverElement:modifierFlags: and _insideAnotherHTMLView.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Copy over each element separately so we don't rely on keys matching. Find the target frame given the target string, and include it in the dictionary. (-[WebHTMLView _mouseOverElement:modifierFlags]): Added. Calls the window operations delegate method, but doesn't call it over and over again if the information is still "nil". (-[WebHTMLView _insideAnotherHTMLView]): Added. (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Added. Helper for the _elementAtPoint method which could be moved to WebNSDictionaryExtras some day.

WebBrowser:

• fixed 2935687 -- cmd-shift-click should open new window behind
• fixed 3050456 -- Click modifier actions are decided by WebBrowser, but status messages come from WebCore

• BrowserWebController.m: (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Added. Contains the same logic that used to be in WebCore for mouseover messages, but translated into WebKit-ese as opposed to WebCore-ese.

• WebBrowser.pbproj/project.pbxproj: Change encoding of BrowserWebController.m to UTF-8. Be careful if you open this file without having the project open in Project Builder.

4:14 PM Changeset in webkit [2231] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Implemented HTTP-specific subclass for WebResourceResponse.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): (IFURLHandleGetResultCode):
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancel]):
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• Misc.subproj/WebError.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]):
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]): (-[WebHTTPProtocolHandler setResponseMetadata:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]): (-[WebHTTPProtocolHandler cacheableAttributesWithDefaults:]):
• ProtocolHandlers.subproj/WebHTTPResourceResponse.h:
• ProtocolHandlers.subproj/WebHTTPResourceResponse.m:
• ProtocolHandlers.subproj/WebHTTPResourceResponsePrivate.h: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Implemented HTTP-specific subclass for WebResourceResponse.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): Add import for WebHTTPResourceResponse.

1:53 PM Changeset in webkit [2230] by darin

• 8 edits in trunk/WebKit

WebFoundation:

Add return value to willSendRequest callback.

• CacheLoader.subproj/WebResourceHandleDelegate.h: Add return value.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]): Call _notifyClientWillSendRequest to do the work of sending the willSendRequest message in the canonical URL case, to avoid duplicate code.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]): Keep the returned request.

• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]):
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]): Update to return the request.

WebKit:

Add return value to willSendRequest callback.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:willSendRequest:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:willSendRequest:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update to return the request.

12:47 PM Changeset in webkit [2229] by darin

• 11 edits in trunk/WebKit

Use the text encoding name from the response and got rid of
[WebDataSource encoding]. Also remove the "first chunk" logic since we
now get a separate callback for the response.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Get the encoding name from the response, or fall back on the default.

• WebView.subproj/WebDataSource.h: Removed encoding.
• WebView.subproj/WebDataSource.m: Ditto.

• WebView.subproj/WebDataSourcePrivate.h: Removed _setEncoding.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release encoding any more.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): No isFirstChunk to initialize. (-[WebMainResourceClient handle:didReceiveResponse:]): Moved the response handling in here, including the policy logic. (-[WebMainResourceClient handle:didReceiveData:]): This has only what's left.

12:12 PM Changeset in webkit [2228] by cblu

• 14 edits in trunk/WebKit

WebKit:

Replaced contentType on WebDataSource to response.

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): (-[WebNetscapePluginStream setResponse:]): (-[WebNetscapePluginStream setDataSource:]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource response]): (-[WebDataSource fileType]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _representationClass]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setContentPolicy:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]):
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

WebBrowser:

Replaced contentType on WebDataSource to response.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]):

11:59 AM Changeset in webkit [2227] by darin

• 11 edits in trunk/WebKit

WebKit:

More work on "open window behind".

• WebView.subproj/WebControllerPolicyDelegate.h: Add new OpenNewWindowBehind constants to the enums.

• WebView.subproj/WebWindowOperationsDelegate.h: Add a behind: parameter to the openNewWindowWithURL method.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): In the new WebClickPolicyOpenNewWindowBehind case, pass YES for behind.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]):
• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass NO for behind.

WebBrowser:

More work on "open window behind".

• BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:behind:]): Add new behind parameter to match change to window operations delegate in WebKit. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Use the WebClickPolicyOpenNewWindowBehind policy if the shift key and command key are down.

10:39 AM Changeset in webkit [2226] by darin

• 7 edits in trunk/WebKit

Cut down on unnecessary use of WebFoundation private stuff.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Remove unnecessary use of [WebResourceHandle _request].
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Remove assert about status code, since status codes are going away.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Use currentURL for logging. (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Ditto.

10:03 AM Changeset in webkit [2225] by darin

• 6 edits in trunk/WebKit

WebKit:

• WebView.subproj/WebControllerPolicyDelegate.h: Change modifierMask to modifierFlags to match NSEvent.
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:]): Ditto.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Ditto.

WebBrowser:

Start of the "open window behind" feature.

• BrowserDocument.m: (-[BrowserDocument close]): Move a cancel here from the BrowserWebController resetDocument method that really didn't belong there. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Rearrange this function so that the part that is just "go to a particular WebResourceRequest" is clearly separated, in preparation for using a method in WebController some day.

• BrowserDocumentController.h: Add URLWindowPolicy enum, and use it as the parameter for goToURL and tryMultipleURLs.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:behind:): Remove display: parameter, and add behind: parameter. (-[BrowserDocumentController _goToEachURL:referrer:windowPolicy:]): Update to take a windowPolicy parameter instead of separate booleans. (-[BrowserDocumentController goToEachURL:]): Use windowPolicy. (-[BrowserDocumentController openDocument:]): Use windowPolicy. (-[BrowserDocumentController goToURL:]): Use windowPolicy. (-[BrowserDocumentController goToURL:referrer:windowPolicy:]): Use windowPolicy. (-[BrowserDocumentController tryMultipleURLs:windowPolicy:]): Use windowPolicy.

• BrowserWebController.m: (-[BrowserWebController resetDocument]): Move cancel to BrowserDocument close. (-[BrowserWebController openNewWindowWithURL:referrer:]): Use windowPolicy. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Use windowPolicy. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Update name to match change in WebKit.

• ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]):
• AppController.m: (-[AppController application:openFile:]): (-[AppController handleGURLEvent:withReplyEvent:]):
• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]):
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Update to use windowPolicy.

9:46 AM Changeset in webkit [2224] by darin

• 5 edits in trunk/WebKit

Get rid of uses of canonicalURL.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Start with normal URL. The change to the canonical URL will come in as a redirect. (-[WebSubresourceClient handle:didReceiveData:]): Remove assert. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):Start with normal URL. The change to the canonical URL will come in as a redirect.

9:23 AM Changeset in webkit [2223] by kocienda

• 3 edits in trunk/WebKit

Added import of WebHTTPResourceRequest.h to get access to methods
which have moved to the HTTP-sepcific request category.

• WebView.subproj/WebDataSourcePrivate.m

Oct 1, 2002:

5:21 PM Changeset in webkit [2222] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• WebKit.exp: added .objc_class_name_WebTextRendererFactory so I could use it from WebBrowser.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:referrer:]): Just changed whitespace so the .exp change would be built.

WebBrowser:

• finished implementing the "etched text" look in the status bar. I had to do some Cocoa API trickery to access WebTextRenderer stuff in order to make it fast; I'll get this cleaned up soon. (Note that this makes a 1-2% speedup in cvs-base)

• BrowserWindowController.h: remove statusField outlet; we always use statusStringView now

• BrowserWindowController.m: (-[BrowserWindowController clearStatus]): remove statusField (-[BrowserWindowController setStatus:]): always use statusStringView

• PreferenceKeys.h: eliminate preference key for etched text
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove menu item to toggle etched text

• English.lproj/Browser.nib: reposition string view slightly

• EtchedStringView.m: (+[EtchedStringView textRenderer]): new method, get (and lazily create) WebTextRenderer used to draw all status bar strings. (+[EtchedStringView lightColor]): new method, get (and lazily create) the whitish color (+[EtchedStringView darkColor]): new method, get (and lazily create) the blackish color (-[EtchedStringView drawRect:]): use WebTextRenderer drawing code.

Also removed some old methods used by the AppKit drawing code.

3:42 PM Changeset in webkit [2221] by cblu

• 3 edits in trunk/WebKit

Fixed build breakage.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setWindow]):

3:28 PM Changeset in webkit [2220] by darin

• 4 edits in trunk/WebCore

• fixed 3055076 -- window.scroll does a window.scrollby, not a window.scrollto

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Moved a case so that the scroll code would scroll to, not by.

3:25 PM Changeset in webkit [2219] by kocienda

• 7 edits in trunk/WebKit

WebFoundation:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• CacheLoader.subproj/IFHTTPURLHandleC.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebProtocolHandler.h: Added partOfRequest:withClass:createIfDoesNotExist: method.
• CacheLoader.subproj/WebProtocolHandler.m: (+[WebProtocolHandler partOfRequest:withClass:createIfDoesNotExist:]):
• CacheLoader.subproj/WebResourceLoad.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebResourceLoadManager.m: Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Removed HTTP-protocol-specific fields and methods.
• CacheLoader.subproj/WebResourceRequest.m: Ditto. (-[WebResourceRequest initWithURL:]): Deal with fact that HTTP-protocol-specific fields and methods have been removed. (-[WebResourceRequest copyWithZone:]): Ditto. Copy protocol-specific parts. (-[WebResourceRequest copyWithURL:]): Ditto. Ditto. :) (-[WebResourceRequest _partWithClass:createIfDoesNotExist:]): Added implementation. (-[WebResourceRequest dealloc]): Deal with fact that HTTP-protocol-specific fields and methods have been removed.
• CacheLoader.subproj/WebResourceRequestPrivate.h: Added.
• Misc.subproj/WebFoundation.h: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.m: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• WebFoundation.pbproj/project.pbxproj

WebKit:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• WebCoreSupport.subproj/WebBridge.m: Now imports WebHTTPResourceRequest.h.
• WebCoreSupport.subproj/WebSubresourceClient.m: Ditto.
• WebView.subproj/WebMainResourceClient.m: Ditto.

WebBrowser:

• BrowserDocument.m: Now imports WebHTTPResourceRequest.h to get at protocol-specific request information.

2:49 PM Changeset in webkit [2218] by cblu

• 3 edits in trunk/WebKit

• Added debug drawing
• removed unnecessary ifdef'ing.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView drawRect:]):

10:49 AM Changeset in webkit [2217] by kocienda

• 6 edits in trunk/WebKit

WebFoundation:

Reorganization of code in WebResourceResponse. This moves the code to the
point where the next change will be to break out HTTP-specific response
information into its own subclass.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Call protocol handler to get the right class for the response. (-[WebResourceLoad succeeded]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse textEncodingName]): Changed name from characterSet. (-[WebResourceResponse userAgent]): (-[WebResourceResponse headers]): (-[WebResourceResponse resultCode]): (-[WebResourceResponse _resourceData]): (-[WebResourceResponse _setTextEncodingName:]): Changed name from _setCharacterSet:. (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]):

WebKit:

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Fixed Development build breakage. Call to [response statusCode] now calls the handle's private method to get the status code.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Calls new textEncodingName method, replacing call to characterSet.

10:12 AM Changeset in webkit [2216] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

This change focuses on "status codes". Status codes are an enum that describe
the state of a handle's load (e.g. loading, finished, cancelled).

Removed status code from WebResourceResponse, and moved it to WebResourceHandle.
The status code is now available as private API on WebResourceHandle. This
change made it possible to make some nice cleanups and simplifications.

The great majority of these changes merely move the method calls from the old
design of calling WebResourceResponse to access the status code to calling
the WebResourceHandle to get the status code.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:]) (-[WebResourceHandle cancel])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _didLoadData:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _load]) (-[WebResourceHandle _statusCode]) (-[WebResourceHandle _setStatusCode:])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel]) (-[WebResourceLoad isCancelled]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad _beginLoad]) (_loadThrottler)
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse _setResourceData:])
• CacheLoader.subproj/WebResourceResponsePrivate.h:

WebKit:

• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Status code moved from WebResourceResponse to WebResourceHandle private API.

9:17 AM Changeset in webkit [2215] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate run:])

WebKit:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

All of the changes here update code that depends on WebResourceHandle. The
changes move the code to the modified API.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])

8:41 AM Changeset in webkit [2214] by cblu

• 20 edits in trunk/WebKit

Fixed copyright comments.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m:
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m:
• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/npapi.h:
• Plugins.subproj/npapi.m:

7:38 AM Changeset in webkit [2213] by kocienda

• 19 edits in trunk/WebKit

WebFoundation:

Big set of changes to move the code closer to the proposed WebFoundation API. Major work includes:

• Implemented new callbacks for WebResourceHandleDelegate. All delegates of WebResourceHandle were updated to reflect this change.

• Modified the way WebProtocolHandler creates protocol-specific responses.

• Move WebResourceHandle API much closer to the final proposal. The public API on this class is very thin now. Some private methods are still available to code inside Intrigue (to ease the transition), and the dependencies on these private methods will be reduced over time.

• WebResourceRequest and WebResourceResponse classes are now closer to their proposed APIs, but work remains to be done with them.

• Synchronous loading code received a large rewrite.

And an extra:

• Sped up implementation of file protocol handler. This protocol handler no longer kicks a thread for each file load.

• CacheLoader.subproj/IFHTTPURLHandleC.h:
• CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod) (IFHTTPURLHandleGetRequestHeaders)
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode) (IFURLHandleGetURL) (IFURLHandleGetCanonicalURL) (IFURLHandleGetStatusCode) (IFURLHandleGetResultCode) (IFURLHandleGetContentType) (IFURLHandleGetError) (IFURLHandleGetContentLength) (IFURLHandleGetContentLengthReceived) (IFURLHandleGetPercentComplete)
• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit])
• CacheLoader.subproj/WebProtocolHandler.h:
• CacheLoader.subproj/WebProtocolHandler.m: (-[WebProtocolHandler responseClass]) (-[WebProtocolHandler responseMetadataAvailable]) (-[WebProtocolHandler setResponseMetadata:])
• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]) (-[WebResourceCallbackClient handle:didReceiveResponse:])
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:delegate:])
• CacheLoader.subproj/WebResourceHandleDelegate.h:
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables prepareCallbacks]) (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _sendCallbacks]) (-[WebResourceHandle _notifyClientWillSendRequest]) (-[WebResourceHandle _notifyClientDidReceiveResponse]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _request]) (-[WebResourceHandle _response]) (-[WebResourceHandle _redirectedURL])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]) (-[WebResourceLoad didLoadBytes:length:]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad cacheObjectCheckingRedirects:]) (-[WebResourceLoad didRedirectToURL:permanent:]) (-[WebResourceLoad originalRequest]) (-[WebResourceLoad _beginLoad]) (-[WebResourceLoad _cacheKey]) (-[WebResourceLoad description]) (-[WebResourceLoad dealloc])
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]) (+[WebResourceLoadKey keyWithLoad:]) (-[WebResourceLoadKey hash]) (-[WebResourceLoadManager requestWithURLHandle:])
• CacheLoader.subproj/WebResourceLoadQueue.m: (-[WebResourceLoadQueue put:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest canonicalURL]) (-[WebResourceRequest protocolHandlerClass]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest copyWithURL:])
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse contentType])
• CacheLoader.subproj/WebResourceSynchronousClient.h:
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithRequest:monitor:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate started]) (-[WebResourceHandleSynchronousDelegate handle]) (-[WebResourceHandleSynchronousDelegate response]) (-[WebResourceHandleSynchronousDelegate result]) (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveResponse:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebFoundationLogging.h:
• Misc.subproj/WebFoundationLogging.m:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_isCaseInsensitiveEqualToString:]
• ProtocolHandlers.subproj/WebAboutProtocolHandler.h:
• ProtocolHandlers.subproj/WebAboutProtocolHandler.m: (-[WebAboutProtocolHandler beginLoad]) (-[WebAboutProtocolHandler responseClass]) (-[WebAboutProtocolHandler responseMetadataAvailable]) (-[WebAboutProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addAuthenticationHeaders:andCall:]) (-[WebCFNetworkHTTPProtocolHandler continueAfterBytesAvailable]) (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]) (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:])
• ProtocolHandlers.subproj/WebFileProtocolHandler.h:
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler initWithResourceLoad:]) (-[WebFileProtocolHandler dealloc]) (-[WebFileProtocolHandler didLoadData:]) (-[WebFileProtocolHandler beginLoad]) (-[WebFileProtocolHandler endLoad]) (-[WebFileProtocolHandler responseClass]) (-[WebFileProtocolHandler responseMetadataAvailable]) (-[WebFileProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]) (-[WebHTTPProtocolHandler responseMetadataAvailable]) (-[WebHTTPProtocolHandler setResponseMetadata:]) (-[WebHTTPProtocolHandler shouldCacheResponse:]) (-[WebHTTPProtocolHandler URL]) (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:])
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]) (-[WebSimpleHTTPProtocolHandler _examineHeaders])
• WebFoundation.exp
• WebFoundation.pbproj/project.pbxproj

WebKit:

Many changes to coincide with API work in WebFoundation. Most of the modifications
here have to do with changes for the new callback scheme.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]) (-[WebIconLoader handle:willSendRequest:]): New method. A no-op here. (-[WebIconLoader handle:didReceiveResponse:]): Ditto.
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView stop]): Fix for Deployment build breakage.
• Plugins.subproj/WebPluginStream.h: Add response ivar.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Tweak method name for new API. (-[WebNetscapePluginStream receivedData:withHandle:]): (-[WebNetscapePluginStream handle:willSendRequest:]): New method. Replaces old redirect callback. (-[WebNetscapePluginStream handle:didReceiveResponse:]): New method. Set the response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.h: Add response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Release response ivar. (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Set the request user agent here. (-[WebSubresourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebSubresourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebSubresourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• WebView.subproj/WebDataSourcePrivate.h: Add _setRequest method.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Call didStartLoadingWithURL with request URL instead of handle URL. (-[WebDataSource _setRequest:]): Add implementation.
• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Tweaks for new WebFoundation API and method names.
• WebView.subproj/WebMainResourceClient.h: Add response ivar.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Set user agent on request here. (-[WebMainResourceClient dealloc]): Release response ivar. (-[WebMainResourceClient didCancelWithHandle:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handleDidFinishLoading:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebMainResourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebMainResourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto.

WebBrowser:

Updated a couple methods to reflect changes in WebFoundation API names.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): Call for the URL on the handles response instead of the URL of the handle itself. (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• DownloadMonitor.m: (-[DownloadMonitor receivedError:forResourceHandle:partialProgress:fromDataSource:]): Request accessor for handle is now private; reflect that in method name (i.e. add an underscore).

Sep 30, 2002:

10:30 PM Changeset in webkit [2212] by cblu

• 11 edits
  7 adds
  3 deletes in trunk/WebKit

A ton o' plugin view clean-up and arch changes. Turned WebPluginView into WebBaseNetscapePluginView. New classes WebNetscapePluginEmbeddedView and WebNetscapePluginDocumentView are subclasses of WebBaseNetscapePluginView. WebNetscapePluginDocumentView handles non-HTML plug-in content and WebNetscapePluginEmbeddedView is the WebHTMLView subview.

Found that we leak the world on complex pages with plug-ins such as macromedia.com and marvel.com when closing the window. Still need to figure this out.

• Plugins.subproj/WebBaseNetscapePluginView.h: Added.
• Plugins.subproj/WebBaseNetscapePluginView.m: Added. (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView modifiersForEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView isInResponderChain]): (-[WebBaseNetscapePluginView performKeyEquivalent:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setUpWindowAndPort]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView plugin]): (-[WebBaseNetscapePluginView setMIMEType:]): (-[WebBaseNetscapePluginView setBaseURL:]): (-[WebBaseNetscapePluginView setArguments:]): (-[WebBaseNetscapePluginView setMode:]): (-[WebBaseNetscapePluginView initWithFrame:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView isFlipped]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewHasMoved:]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView defaultsHaveChanged:]): (-[WebBaseNetscapePluginView frameStateChanged:]): (-[WebBaseNetscapePluginView pluginInstance]): (-[WebBaseNetscapePluginView pluginURLFromCString:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): (-[WebBaseNetscapePluginView newStream:target:stream:]): (-[WebBaseNetscapePluginView write:len:buffer:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView invalidateRect:]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView forceRedraw]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.m: Added. (-[WebNetscapePluginDocumentView initWithFrame:]): (-[WebNetscapePluginDocumentView dealloc]): (-[WebNetscapePluginDocumentView drawRect:]): (-[WebNetscapePluginDocumentView dataSource]): (-[WebNetscapePluginDocumentView setDataSource:]): (-[WebNetscapePluginDocumentView dataSourceUpdated:]): (-[WebNetscapePluginDocumentView setNeedsLayout:]): (-[WebNetscapePluginDocumentView layout]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h: Added.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Added. (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): (-[WebNetscapePluginEmbeddedView start]): (-[WebNetscapePluginEmbeddedView dataSource]):
• Plugins.subproj/WebNetscapePluginViewPrivate.h: Removed.
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream startLoad]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleWillUseUserAgent:forURL:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): (-[WebNetscapePluginStream handleDidRedirect:toURL:]):
• Plugins.subproj/WebPluginView.h: Removed.
• Plugins.subproj/WebPluginView.m: Removed.
• Plugins.subproj/npapi.m: (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):

2:39 PM Changeset in webkit [2211] by hyatt

• 4 edits in trunk/WebCore

Fix the case sensitivity problem with attribute names
in HTML. They are now lower-cased when being queried
from the DOM. Bug 3058145.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::attrName):

1:25 PM Changeset in webkit [2210] by hyatt

• 4 edits in trunk/WebCore

Make sure to keep the fix checked in for 1.18. That fix is
good.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

1:03 PM Changeset in webkit [2209] by hyatt

• 4 edits in trunk/WebCore

Backing out change to render_table.cpp. The original logic
(in version 1.16) is correct.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

11:09 AM Changeset in webkit [2208] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Remove the ill-advised "don't even create a WebDataSource if WebResourceHandle can't handle this request" code.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Rearrange checks so we won't get confused if we can't create a handle.

10:52 AM Changeset in webkit [2207] by darin

• 13 edits in trunk/WebCore

• kwq/qt/qobject.h: Add the destroyed signal.
• kwq/KWQObject.mm: (QObject::connect): Remove names of parentDestroyed and slotWidgetDestructed from the list of "slots OK to fail to connect without complaining". (QObject::QObject): Initialize the destroyed signal.

• kwq/qt/qguardedptr.h:
• kwq/KWQGuardedPtr.mm:
• kwq/KWQSignal.h:
• kwq/KWQSlot.h: Rearrange includes so qobject.h can include KWQSignal.h.

• kwq/KWQSignal.mm: Tweak.

• kwq/KWQSlot.mm: Added support for the parentDestroyed slot in KJS::WindowQObject and the slotWidgetDestructed slot in khtml::RenderWidget.

10:08 AM Changeset in webkit [2206] by darin

• 2 edits
  1 add in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Added.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Added.

9:26 AM Changeset in webkit [2205] by darin

• 3 edits in trunk/WebKit

• fixed crashing part of 3063517 -- crash loading .png in separate window

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't try to start if the NPP_New is 0. This indicates the the plugin hasn't been loaded.

8:49 AM Changeset in webkit [2204] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Remove extra quotes in use of ASSERT_ARG.

Sep 29, 2002:

10:03 PM Changeset in webkit [2203] by darin

• 11 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Don't be case sensitive about filename extensions.

• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebView.m: Don't use WebFoundation.h -- faster building to just import what we really use.

WebBrowser:

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): Don't be case sensitive about filename extensions.

• Preferences.subproj/SecurityPreferences.m: Don't use WebFoundation.h -- faster building to just import what we really use.

10:04 AM Changeset in webkit [2202] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: 2978258 - quake3arena.com sends me to the flash=false site
The page has a flash plugin that once loaded, requests the flash=true page. If the plugin doesn't load, the meta refresh tag to the flash=false page fires after 3 seconds. This is how this site's flash detection works.

The reason this doesn't work for us is because the flash movie is at the bottom of the page. Plugins don't start until the initial drawRect. Since the movie is at the bottom of the page and out of site, the plugin never gets the drawRect and thus, never starts. We now start plug-ins when they are added to the window.

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Fixed click then click and drag causes crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView drawRect:]): don't start plug-in here (-[WebNetscapePluginView viewDidMoveToWindow]): start it here
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): don't provide "Download Link To Disk" and "Open Link In New Window" items for URLs we cant handle.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): clean-up (-[WebHTMLView mouseDragged:]): Don't allow drag if the frame has a provisional data source because this view may be released and the drag callbacks might reference this released view.

WebBrowser:

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Added "Open With QuickTime Player" context menu for URLs ending with .mov.
• Only show "Open With*" items for http URLs.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler openWithiTunes:]): (-[ContextMenuHandler openWithQuickTime:]):

Sep 28, 2002:

4:57 PM Changeset in webkit [2201] by darin

• 6 edits in trunk/WebCore

Turn -Werror back on. There must have been some miscommunication
about the fat build; this was supposed to have been on.

• WebCore.pbproj/project.pbxproj: Add -Werror back.

• kwq/WebCoreHistory.h: Add missing method to fix warning.
• kwq/KWQKHistoryProvider.mm: Tweak.

1:38 PM Changeset in webkit [2200] by darin

• 6 edits in trunk/WebCore

Give the next fat build a better chance of working with the
new gcc without turning warnings off.

• khtml/css/cssparser.cpp: Use a macro to disable inlining.
• khtml/html/htmltokenizer.cpp: Ditto.
• khtml/misc/htmlhashes.cpp: Ditto.

12:49 PM Changeset in webkit [2199] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Catch a request that we can't use here instead of failing later.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Added an assert so the failure was less confusing; good idea to leave it in.

12:35 PM Changeset in webkit [2198] by cblu

• 4 edits in trunk/WebKit

Support for latest Flash plug-in. It requests a javascript URL for every plug-in instance. Until javascript URLs work, we return an error to the plug-in.

Fixed: 3035582 - flash animations don't work after upgrading flash
Fixed: 3021936 - links in flash at foggypetronasracing.com doesn't work

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Make the request here and return nil if we can't create a handle with it. (-[WebNetscapePluginStream dealloc]): release the request (-[WebNetscapePluginStream startLoad]): use the request when creating the handle

1:06 AM Changeset in webkit [2197] by darin

• 4 edits in trunk/WebCore

• fixed 3022441 -- scroll bar is missing in window created with window.open

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): The checks for extra parameters to window.open were using isNull, which checks for a null ValueImp pointer, not an "Undefined".

12:39 AM Changeset in webkit [2196] by darin

• 15 edits in trunk

WebCore:

• fixed 2886111 -- changing font or size preference causes open windows to redraw incorrectly

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fix logic about when a recalc of the minWidth and maxWidth is needed.

Fixed bug where changing the text size multiplier would cause the
window to redraw twice -- once with the text size changed, and then
later with the layout changed.

• khtml/khtmlview.h: Added unscheduleRelayout.
• khtml/khtmlview.cpp: (KHTMLView::unscheduleRelayout): Added.

• kwq/KWQKHTMLPartImpl.h: Added forceLayout.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::forceLayout): Call both layout and unscheduleRelayout.

• kwq/WebCoreBridge.h: Add setNeedsLayout.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayout]): Call KWQKHTMLPartImpl::forceLayout. (-[WebCoreBridge setTextSizeMultiplier:]): Call forceLayout.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsLayout]): Added.

Sep 27, 2002:

9:22 PM Changeset in webkit [2195] by cblu

• 4 edits in trunk/WebKit

Fixed KJS crasher caused by nil plug-in returned from WebPlugin.
Got the RealPlayer plug-in loaded, nothing playing yet.

• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for nil plug-in names/descriptions (-[WebNetscapePlugin stringByResolvingSymlinksAndAliasesInPath:]): new, resolves old-style aliases (-[WebNetscapePlugin initWithPath:]): call stringByResolvingSymlinksAndAliasesInPath

5:45 PM Changeset in webkit [2194] by darin

• 4 edits in trunk/WebCore

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fixed a > that should have been a < that prevented tables from changing sizes when table minimum widths changed.

5:16 PM Changeset in webkit [2193] by darin

• 2 edits in trunk/WebKit/WebView.subproj

• LocationChangeError.m: (-[LocationChangeHandler displayLocationChangeError:]): Add back the WebErrorCodeCancelled case.

4:44 PM Changeset in webkit [2192] by rjw

• 4 edits in trunk/WebKit

i Fix 3058315: crash in WebHTMLRepresentation receivedData:withDataSource

​http://www.u2.com/lite/ does some whacky things with its framset's onLoad
handler. The fix ensures that data isn't sent to the bridge once
the bridge has been dealloced.

• WebKit.pbproj/project.pbxproj: Nothing changed. PB dorkiness.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedData:withDataSource:]):

Fix related to 3058315.

• LoadProgressMonitor.m: (-[LoadProgressMonitor receivedUpdateForKey:URLString:bytesLoaded:bytesExpected:error:dataSource:isComplete:]):

2:34 PM Changeset in webkit [2191] by darin

• 9 edits in trunk/WebCore

• fixed 2937198 -- Checkboxes and radiobuttons don't align with title control in forms

• kwq/qt/qcheckbox.h: Add baselinePosition override.
• kwq/KWQCheckBox.mm: Tweak the size constants. (QCheckBox::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

• kwq/qt/qradiobutton.h: Add baselinePosition override.
• kwq/KWQRadioButton.mm: Tweak the size constants. (QRadioButton::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

2:31 PM Changeset in webkit [2190] by cblu

• 14 edits in trunk

WebCore:

WebPlugin clean up.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreViewFactory.h:

WebKit:

Fixed: 3056559 - QT plugin doesn't load (claudius)
Fixed: 3042850 - Enable Java by default

Cleaned up WebPlugin and WebPluginDatabase.

• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin openResourceFile]): (-[WebNetscapePlugin closeResourceFile:]): (-[WebNetscapePlugin stringForStringListID:andIndex:]): (-[WebNetscapePlugin getPluginInfo]): (-[WebNetscapePlugin initWithPath:]): (-[WebNetscapePlugin load]): (-[WebNetscapePlugin unload]): (-[WebNetscapePlugin MIMEToExtensionsDictionary]): (-[WebNetscapePlugin extensionToMIMEDictionary]): (-[WebNetscapePlugin MIMEToDescriptionDictionary]): (-[WebNetscapePlugin description]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase pluginForMIMEType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginForFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Enable Java by default

1:50 PM Changeset in webkit [2189] by rjw

• 21 edits in trunk

WebBrowser no longer responsible for setting page title in history.

• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]):

Fixed 3060158: REGRESSION: iframes added to session history
Also moved setting title in history to WebKit.

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (+[WebHistory sharedHistory]): (+[WebHistory webHistoryWithFile:]): (-[WebHistory addEntryForURL:]): (-[WebHistory addEntries:]):
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Fixed 3059237: Visited links do not appear in a different color on yahoo.com
Fixed 3051288: visited links are not colored in local files
Fixed 3060158: REGRESSION: iframes added to session history
Always use the canonical originally requested URL as the URL entered in history.

• khtml/khtml_part.cpp: (KHTMLPart::begin):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestedURLString):
• kwq/KWQKHistoryProvider.mm:
• kwq/WebCoreBridge.h:
• kwq/WebCoreHistory.h:

12:40 PM Changeset in webkit [2188] by hyatt

• 4 edits in trunk/WebCore

Fix for 3058119, doctype of HTML docs should be null.

• khtml/dom/dom_doc.cpp:

12:27 PM Changeset in webkit [2187] by hyatt

• 4 edits in trunk/WebCore

DOM compliance. Fix for 3058100, hasFeature of HTML returns
false. Oops.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature):

11:35 AM Changeset in webkit [2186] by darin

• 4 edits in trunk/WebCore

• fixed 3060487 -- error connecting member slot to signal (KWQObject)

• kwq/KWQObject.mm: (QObject::connect): Add slotShowDocument to the list of slots that we don't care about hooking up.

10:32 AM Changeset in webkit [2185] by cblu

• 5 edits in trunk/WebKit

WebKit:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• Misc.subproj/WebNSPasteboardExtras.h:
• Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): set WebURLPboardType and WebURLNamePboardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use WebURLPboardType and WebURLNamePboardType
• WebKit.exp: export WebURLPboardType and WebURLNamePboardType

WebBrowser:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): use WebURLPboardType and WebURLNamePboardType

10:27 AM Changeset in webkit [2184] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3033969 -- repro crash (infinite recursion in JavaScript) clicking on "screens" option at fsv.sf.net

• kjs/object.h: Change recursion limit to 100 levels rather than 1000.

8:25 AM Changeset in webkit [2183] by cblu

• 1 edit in trunk/WebKit/Misc.subproj/WebNSPasteboardExtras.m

* empty log message *

4:30 AM Changeset in webkit [2182] by mjs

• 5 edits in trunk/WebKit

WebFoundation:

Put in place all the API changes needed for the "remember
password" feature and examining stored passwords. The actual
storing of passwords in Keychain is not implemented yet - that's
the next step.

• AuthenticationManager.subproj/WebAuthenticatingResource.h: Added.
• AuthenticationManager.subproj/WebAuthenticatingResource.m: Added. New class that's the data holder part of WebAuthenticationRequest, the part that describes the resource needing authentication. (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource initWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (+[WebAuthenticatingResource resourceWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (-[WebAuthenticatingResource init]): (-[WebAuthenticatingResource dealloc]): (-[WebAuthenticatingResource URL]): (-[WebAuthenticatingResource realm]): (-[WebAuthenticatingResource username]): (-[WebAuthenticatingResource receivesCredentialSecurely]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource proxyHost]): (-[WebAuthenticatingResource proxyType]): (-[WebAuthenticatingResource copyWithZone:]):
• AuthenticationManager.subproj/WebAuthenticationHandler.h:
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher WebAuthenticationRequest:useCredential:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
• AuthenticationManager.subproj/WebAuthenticationManager.h:
• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager removeCredentialForResource:]): (-[WebAuthenticationManager resourceCredentials]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:withCallback:context:]): (-[WebAuthenticationManager _tryRequest:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
• AuthenticationManager.subproj/WebAuthenticationRequest.h:
• AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:previousFailureCount:delegate:]): Change to init with a WebAuthenticatingResource rather than passing all the data. (-[WebAuthenticationRequest _authenticationHandlerBusy]): (-[WebAuthenticationRequest resource]): New method (-[WebAuthenticationRequest previousFailureCount]): Renamed from previousFailures (-[WebAuthenticationRequest useCredential:]): Renamed from authenticationDone: (-[WebAuthenticationRequest cancel]): Removed to fix in-band signalling
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/WebAuthenticationResult.m: Removed.
• AuthenticationManager.subproj/WebCredential.h: Added.
• AuthenticationManager.subproj/WebCredential.m: Added. Renamed from WebAuthenticationResult. (-[WebCredentialPrivate dealloc]): (-[WebCredential initWithUsername:password:remembered:]): Add remembered: parameter (+[WebCredential credentialWithUsername:password:remembered:]): Likewise (-[WebCredential dealloc]): (-[WebCredential username]): (-[WebCredential password]): (-[WebCredential remembered]): New method (-[WebCredential copyWithZone:]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp: Fix exports.
• WebFoundation.pbproj/project.pbxproj: Add new files, remove removed ones.

Mechanical fixes to get C glue to compile:

• AuthenticationManager.subproj/IFAuthenticationHandlerC.m: (-[IFCallBackAuthenticationHandler isReadyToStartAuthentication:]):
• AuthenticationManager.subproj/IFAuthenticationRequestC.m: (IFAuthenticationRequestCopyURL): (IFAuthenticationRequestCopyRealm): (IFAuthenticationRequestCopyUsername): (IFAuthenticationRequestWillPasswordBeSentInClear): (IFAuthenticationRequestGetPreviousFailures): (IFAuthenticationRequestIsForProxy): (IFAuthenticationRequestCopyProxyHost): (IFAuthenticationRequestCopyProxyType): (IFAuthenticationRequestDone):
• AuthenticationManager.subproj/IFAuthenticationResultC.m: (IFAuthenticationResultCreate): (IFAuthenticationResultCopyUsername): (IFAuthenticationResultCopyPassword):

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
• Panels.subproj/WebPanelAuthenticationHandler.h:
• Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithRequest:result:]):

Sep 26, 2002:

8:25 PM Changeset in webkit [2181] by darin

• 4 edits in trunk/WebCore

• fixed 2953256 -- JavaScript window.moveTo() and window.moveBy() methods do not work

• kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Fix calculation. It was returning the bottom left coordinate instead of the top left.

8:06 PM Changeset in webkit [2180] by darin

• 12 edits in trunk/WebCore

• fixed 3060459 -- REGRESSION: crash leaving page that sets cookie in JavaScript unload handler

• khtml/khtml_part.cpp: (KHTMLPart::begin): Call updatePolicyBaseURL to set the "policy base URL" on the documents so the cookie can be based on the URL of the main document.

• khtml/dom/html_document.h: Add setPolicyBaseURL.
• khtml/dom/html_document.cpp: (HTMLDocument::setPolicyBaseURL): Call the impl.

• khtml/html/html_documentimpl.h: Add policyBaseURL, setPolicyBaseURL.
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie): Pass the base URL that's stored here instead of getting at the part through the view, since the view will be 0 during the unload event.

• kwq/KWQKHTMLPartImpl.h: Add updatePolicyBaseURL and setPolicyBaseURL.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::updatePolicyBaseURL): Set the base URL based on the URL if this is the topmost part, based on the parent's policy base URL if this is not the topmost part. (KWQKHTMLPartImpl::setPolicyBaseURL): Change the policy base URL for this part and all the subparts.

5:45 PM Changeset in webkit [2179] by darin

• 18 edits in trunk

Tools:

• HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: File encodings.

WebCore:

• kwq/WebCoreBridge.h: Use NSString for encoding name, not CFStringEncoding.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withOverrideEncoding:]): Ditto.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Use NSString for encoding.
• WebView.subproj/WebController.h: Update names to use separate boolean for user agent and strings for text encodings instead of CFStringEncoding.
• WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Name change. (-[WebController resetUserAgent]): Added. (-[WebController hasCustomUserAgent]): Added. (-[WebController customUserAgent]): Name change. (-[WebController setCustomTextEncodingName:]): Take NSString. (-[WebController resetTextEncoding]): Update for NSString. (-[WebController _mainFrameOverrideEncoding]): Ditto. (-[WebController hasCustomTextEncoding]): Ditto. (-[WebController customTextEncodingName]): Return NSString.

• WebView.subproj/WebDataSourcePrivate.h: Use NSString instead of CFStringEncoding.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): No need to init. (-[WebDataSource _setContentType:]): Copy, don't retain. (-[WebDataSource _setEncoding:]): Copy, don't retain. (-[WebDataSource _setOverrideEncoding:]): Use NSString. (-[WebDataSource _overrideEncoding]): Use NSString.

• WebView.subproj/WebFramePrivate.h: Use NSString.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Use NSString.

• WebView.subproj/WebPreferences.h: Use NSString instead of CFStringEncoding.
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Use NSString. (-[WebPreferences defaultTextEncodingName]): Use NSString. (-[WebPreferences setDefaultTextEncodingName:]): Use NSString.

WebBrowser:

• AppController.m: (-[AppController updateTextEncodingMenu]): Convert to CFStringEncoding.
• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Convert to CFStringEncoding. (-[BrowserWindowController changeTextEncoding:]): Convert to NSString.
• Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Update for API change. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Ditto. (-[BrowserDocument validate_resetUserAgent:]): Ditto.
• Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Convert to CFStringEncoding. (-[TextPreferences takeDefaultCharacterSetFrom:]): Convert to NSString.

3:37 PM Changeset in webkit [2178] by cblu

• 3 edits in trunk/WebKit

WebKit:

Made WebTextView super-private.

• WebKit.pbproj/project.pbxproj:

WebBrowser:

• Made the view source window
  • larger
  • use Monaco, 10 font
  • respond to makeTextLarger and makeTextSmaller
  • use saveDocumentAs

Fixed: 3053366 - source window should have file proxy after save

• BrowserDocument.h:
• BrowserDocument.m:
• English.lproj/HTMLSource.nib: made window larger, use WebSearchableTextView
• HTMLSourceController.h:
• HTMLSourceController.m: (-[HTMLSourceController windowDidLoad]): set the text multiplier (-[HTMLSourceController setTextSizeMultiplier:]): new (-[HTMLSourceController textSizeMultiplier]): new
• HTMLSourceDocument.h:
• HTMLSourceDocument.m: (-[HTMLSourceDocument dataRepresentationOfType:]): new saved flag (-[HTMLSourceDocument saveDocumentTo:]): call saveDocumentAs (-[HTMLSourceDocument displayName]): perform hacks to get window title and saved filename correct (-[HTMLSourceDocument controller]): new (-[HTMLSourceDocument browserDocumentLoadingFinished:]): don't update after save (-[HTMLSourceDocument canMakeTextLarger]): new (-[HTMLSourceDocument canMakeTextSmaller]): new (-[HTMLSourceDocument makeTextLarger:]): new (-[HTMLSourceDocument makeTextSmaller:]): new (-[HTMLSourceDocument validateUserInterfaceItem:]): new

3:11 PM Changeset in webkit [2177] by rjw

• 3 edits in trunk/WebKit

i Use a rectangle with rounded corners for dragged label.

Put a subtle shadow behind text in label.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

12:07 PM Changeset in webkit [2176] by cblu

• 15 edits
  2 adds in trunk

WebCore:

Added WebCoreElementImageLocationKey to the element dictionary.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

• When dragging an image, use the image itself for the drag image
• Support promised file and image data drag types for dragged images.

• Misc.subproj/WebNSImageExtras.h: Added.
• Misc.subproj/WebNSImageExtras.m: Added. (-[NSImage _web_scaleToMaxSize:]): new, scales an image is greater than max (-[NSImage _web_dissolveToFraction:]): new, dissolves image in place
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h: Added WebElementImageLocationKey to the element dictionary
• WebView.subproj/WebController.m: ditto
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): subclassed for only for image drags (-[WebHTMLView mouseDragged:]): use the promised file api again. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): use the retained element dictionary instead of the dragged URL which I deleted.
• WebView.subproj/WebHTMLViewPrivate.h:

10:20 AM Changeset in webkit [2175]

• 3 copies in tags/Alexander-25

This commit was manufactured by cvs2svn to create tag 'Alexander-25'.

10:20 AM Changeset in webkit [2174] by sheridan

• 8 edits in trunk

Alex-25 versions + markers

8:20 AM Changeset in webkit [2173] by darin

• 5 edits in trunk/JavaScriptCore

Fix the infinity problem Dave worked around. We didn't have the
configuration flags set right to make infinity work. Setting those
properly made everything work without changes to min and max.

• kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and also WORDS_BIGENDIAN (if on ppc).

• kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max changes from yesterday.

Sep 25, 2002:

7:15 PM Changeset in webkit [2172] by rjw

• 9 edits in trunk/WebKit

API tweaks.

• Misc.subproj/WebKit.h: Added headers.

• Misc.subproj/WebKitErrors.h: Removed #defines.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _loadIcon]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): Removed isMainDocument.

Moved errors string #defines here.

• WebView.subproj/WebView.m:

Updated to reflect API tweaks.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

5:57 PM Changeset in webkit [2171] by sullivan

• 3 edits in trunk/WebKit

• fixed 3060773 -- Wrong title proposed when image link dropped on favorites bar

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Claim the pasteboard (via declareTypes:) before putting data on it.

5:51 PM Changeset in webkit [2170] by rjw

• 24 edits in trunk/WebKit

API and documentation tweaks.

WebDocumentDragSettings: canDrag -> acceptsDrag
WebDataSource: removed originalURL
WebStandardPanels: use -> uses

• History.subproj/WebBackForwardList.h:
• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]):
• Panels.subproj/WebStandardPanels.h:
• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]): (-[WebStandardPanels usesStandardAuthenticationPanel]):
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView frameStateChanged:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient cancel]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
• WebView.subproj/WebDocument.h:
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame startLoading]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setState:]): (-[WebFrame _goToItem:withFrameLoadType:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView setAcceptsDrags:]): (-[WebHTMLView acceptsDrags]): (-[WebHTMLView setAcceptsDrops:]): (-[WebHTMLView acceptsDrops]):
• WebView.subproj/WebImageView.m: (-[WebImageView setAcceptsDrags:]): (-[WebImageView acceptsDrags]): (-[WebImageView setAcceptsDrops:]): (-[WebImageView acceptsDrops]):
• WebView.subproj/WebLoadProgress.h:
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):
• WebView.subproj/WebView.h:

Updated to reflect API tweaks.

• AppController.m: (-[AppController awakeFromNib]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]):

3:47 PM Changeset in webkit [2169] by hyatt

• 5 edits in trunk/WebCore

Implement scrollX and scrollY on the window object. This
gets brainjar closer to reality. :)

• khtml/ecma/kjs_window.cpp: (Window::get):
• khtml/ecma/kjs_window.h:

3:46 PM Changeset in webkit [2168] by hyatt

• 4 edits in trunk/JavaScriptCore

Fix the impls of min/max to not use +inf/-inf when you have
arguments. Technically there's still a bug here for the no
argument case, probably caused by a screwup when +inf/-inf are
converted to doubles.

• kjs/math_object.cpp: (MathFuncImp::call):

1:25 PM Changeset in webkit [2167] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page

• kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers in the range 0x10000000 to 0x1FFFFFFF.

11:23 AM Changeset in webkit [2166] by kocienda

• 9 edits in trunk/WebKit

WebFoundation:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

• Removed loadInBackground method from the public interface.
• Start asynchronous loading in WebResourceHandle init method.
• Remove loadInForeground: from WebResourceHandle interface.
• Add nice comments to WebResourceHandle header file.
• Move WebResourceHandle callback deferral methods to SPI header file.
• Some cleanups in synchronous loading.
• Change name of WebResourceHandle cancelLoadInBackground method to cancel.
• Some changes to the C glue (why do I even pretend that I am keeping this glue code working?)

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleCancelLoadInBackground) (IFURLHandleDidRedirectToURL)
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:]) (-[WebResourceHandle initWithRequest:delegate:]) (-[WebResourceHandle cancel]) (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle loadInForeground])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _postCallback:]) (-[WebResourceHandle _sendCallbacks])
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _setDefersCallbacks:]) (-[WebResourceHandle _defersCallbacks])
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel])
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate finished])
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

• Removed loadInBackground method from the public interface.
• Start asynchronous loading in WebResourceHandle init method. This required some code reorganization in callers.
• Remove loadInForeground: from WebResourceHandle interface.
• Move WebResourceHandle callback deferral methods to SPI header file.
• Change name of WebResourceHandle cancelLoadInBackground method to cancel.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]) (-[WebIconLoader stopLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]) (-[WebNetscapePluginStream cancel])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]) (-[WebSubresourceClient cancel])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]) (-[WebDataSource _addSubresourceClient:]) (-[WebDataSource _stopLoading]) (-[WebDataSource _defersCallbacksChanged])
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])

11:01 AM Changeset in webkit [2165] by cblu

• 4 edits in trunk/WebKit

Fixed: 3050665 - REGRESSION: mp3 audio loads and plays, but no progress or play control is visible

• Plugins.subproj/WebPluginView.h:
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]): (-[WebNetscapePluginView layout]): (-[WebNetscapePluginView drawRect:]):

9:03 AM Changeset in webkit [2164] by darin

• 4 edits in trunk/WebCore

Fix error with the color "indigo".

• kwq/KWQColor.mm: (getNamedColors): There were some spaces in our color table so we wouldn't handle indianred or indigo.

8:50 AM Changeset in webkit [2163] by darin

• 5 edits in trunk/WebKit

Make the "set aside subviews" logic stronger so it can handle a display
while inside drawRect. But note, this recursive display is most likely
the cause of the redrawing problems we have while resizing, like bug 2969367.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Restore views and then set them aside again, but don't leave the "views set aside" boolean set.
• WebView.subproj/WebHTMLViewPrivate.h: Add private _setAsideSubviews and _restoreSubviews methods.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setAsideSubviews]): Added. (-[WebHTMLView _restoreSubviews]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use the new _setAsideSubviews and _restoreSubviews methods. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.

8:32 AM Changeset in webkit [2162] by kocienda

• 4 edits in trunk/WebKit

WebFoundation:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Also added a convenience method to WebResourceRequest that
allocates, inits, and returns an autoreleased instance.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (+[WebResourceRequest requestWithURL:])

WebKit:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Callers have been updated to reflect the change.

• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:])
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:])

7:18 AM Changeset in webkit [2161] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:didReceiveData:])
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDataDidBecomeAvailable])
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])

WebKit:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didReceiveData:])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveData:])
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])

7:02 AM Changeset in webkit [2160] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

• (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;

• CacheLoader.subproj/WebResourceCallbackClient.m:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDidFailLoading])
• CacheLoader.subproj/WebResourceSynchronousClient.m:

WebKit:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

• (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didFailLoadingWithError:])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didFailLoadingWithError:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didFailLoadingWithError:])
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didFailLoadingWithError:])

6:25 AM Changeset in webkit [2159] by kocienda

• 13 edits in trunk/WebKit

WebFoundation:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

As part of this change, WebResourceSynchronousClient becomes
WebResourceHandleSynchronousDelegate. Also, the init interface
for WebResourceHandle assumes the form specified in the new API
specification:

-(id)initWithRequest:(WebResourceRequest *)request delegate:(id <WebResourceHandleDelegate>)delegate;

I also made cosmetic changes to variable names and such.

Note that I am removing the WebResourceClient.h file, but I
copied the ,v file in the repository so that the history for WebResourceClient.h
is preserved in WebResourceHandleDelegate.h.

• CacheLoader.subproj/WebResourceCallbackClient.h:
• CacheLoader.subproj/WebResourceClient.h: Removed.
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle initWithRequest:delegate:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceSynchronousClient.h:
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithMonitor:realDelegate:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate handleWillUseUserAgent:forURL:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handleDidReceiveData:data:]) (-[WebResourceHandleSynchronousDelegate handleDidRedirect:toURL:])
• Misc.subproj/WebFoundation.h:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

I made other cosmetic changes to variable names and such.

• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])
• WebView.subproj/WebMainResourceClient.h:

1:22 AM Changeset in webkit [2158] by mjs

• 17 edits in trunk

Tests:

• CookieManager/wkcookiemanager-test.m: (main): Adjust for API change.

WebFoundation:

• fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"

• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest cookiePolicyBaseURL]): (-[WebResourceRequest setCookiePolicyBaseURL:]): (-[WebResourceRequest copyWithZone:]):
• CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerSetCookiesFromResponseHeaders):
• CookieManager.subproj/WebCookieConstants.h:
• CookieManager.subproj/WebCookieManager.h:
• CookieManager.subproj/WebCookieManager.m: (-[WebCookieManager _readAcceptCookiesPreference]): (-[WebCookieManager _setCookies:forURL:policyBaseURL:]): (-[WebCookieManager setCookie:]): (-[WebCookieManager setCookiesFromResponseHeaders:forURL:policyBaseURL:]): (-[WebCookieManager setAcceptPolicy:]):
• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_domainFromHost]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _parseHeadersFromData:]):

WebCore:

• fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie):
• kwq/KWQKCookieJar.h:
• kwq/KWQKCookieJar.mm: (KWQKCookieJar::setCookie):
• kwq/WebCoreCookieAdapter.h:
• kwq/WebCoreCookieAdapter.m: (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]):

WebKit:

• fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"

• WebCoreSupport.subproj/WebCookieAdapter.h:
• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient handleDidRedirect:toURL:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidRedirect:toURL:]):

WebBrowser:

• fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"

• Preferences.subproj/English.lproj/SecurityPreferences.nib:
• Preferences.subproj/SecurityPreferences.h:
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

Sep 24, 2002:

6:42 PM Changeset in webkit [2157] by rjw

• 11 edits in trunk/WebKit

More documentation tweaks.

• History.subproj/WebHistory.h:
• History.subproj/WebHistoryItem.h:
• WebView.subproj/WebContextMenuDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebResourceProgressDelegate.h:

6:20 PM Changeset in webkit [2156] by darin

• 8 edits
  2 adds in trunk/WebKit

• fixed 3059513 -- REGRESSION: Scrolling to fragment doesn't work

Turns out it was better to just put the extra smarts into the clip view
that we are already creating. Making WebHTMLView be a second clip view
was silly and broke things.

• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Create a WebClipView and use it as the content view rather than the NSClipView created by default.

• WebKit.pbproj/project.pbxproj: Added WebClipView.
• WebView.subproj/WebClipView.h: Added.
• WebView.subproj/WebClipView.m: Added.

• WebView.subproj/WebHTMLView.h: Don't be a subclass of NSClipView any more.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Call setAdditionalClip and resetAdditionalClip on the clip view.

• WebView.subproj/WebHTMLViewPrivate.h: Remove inDrawRect and drawRect.
• WebView.subproj/WebHTMLViewPrivate.m: Remove visibleRect override. This is now in WebClipView.

5:31 PM Changeset in webkit [2155] by darin

• 7 edits in trunk/WebCore

Tests:

• harness.c: (runtest): Turn off leak checking. It's broken.

• qt/qdate-test.chk: Update test for changes to QDate.
• qt/qdate-test.cpp: (main): Ditto.

• qt/qtime-test.chk: Update test for changes to QTime.
• qt/qtime-test.cpp: (main): Ditto.

WebCore:

• fixed 3057928 -- lstat private/etc/localtime repeatedly reported by fs_usage when mouse is moved

• WebCore-tests.exp: Remove now-unneeded external entry points for QTime, QDate, QDateTime.

• kwq/qt/qdatetime.h:
• kwq/KWQDateTime.mm: Redid QDateTime using CoreFoundation instead of time/localtime. This avoids constantly hitting the disk when getting the current time to stuff into an event.

5:30 PM Changeset in webkit [2154] by cblu

• 6 edits in trunk/WebKit

More documentation changes.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.h:
• WebView.subproj/WebDocument.h:

4:25 PM Changeset in webkit [2153] by hyatt

• 4 edits in trunk/WebCore

Make sure we dispatch both a capturing and a bubbling event
to target nodes. DOM lvl 2 event compliance.

• ChangeLog:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):

4:22 PM Changeset in webkit [2152] by rjw

• 4 edits in trunk/WebKit

Added FIXME not about unresolved issue with CFStringEncoding/NSStringEncoding.

• WebView.subproj/WebController.h:

4:20 PM Changeset in webkit [2151] by rjw

• 11 edits in trunk

i Fixed 3055078. Ensure file: URLs have before path.

• kwq/KWQKURL.mm: (KURL::parse):

Documentation for WebDataSource and WebFrame.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource frameExists:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource addFrame:]):
• WebView.subproj/WebFrame.h:

3:34 PM Changeset in webkit [2150] by hyatt

• 4 edits in trunk/WebCore

Better fix. Clears the boolean when CLASS has no value.
This will keep the style system from thinking you have
a class when you don't.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):

3:21 PM Changeset in webkit [2149] by hyatt

• 4 edits in trunk/WebCore

Fix updating of the document's notion of the focused node
to happen on mouse down rather than click. This matches
the behavior of all other browsers (IE, Gecko, etc.).

This fixes the drawing of the outline on the brainjar.com
DHTML menus.

• khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):

3:20 PM Changeset in webkit [2148] by darin

• 3 edits in trunk/WebKit

• fixed 3059266 -- REGRESSION: clicking in web view when location field is focused does not focus web view

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView needsPanelToBecomeKey]): Must override this to return YES, because NSClipView makes it return NO even though we accept the first responder.

2:45 PM Changeset in webkit [2147] by hyatt

• 4 edits in trunk/WebCore

Make sure that changes to the CLASS attribute mark the
element as changed (as if a CSS property were added or
removed).

This makes the brainjar.com rollovers work much better.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):

2:26 PM Changeset in webkit [2146] by sullivan

• 3 edits in trunk/WebKit

• fixed 3056158 -- REGRESSION: Page up/down should scroll one whole contentView minus at least one readable line of text

This was broken a while back when the keyboard scrolling code
migrated into WebKit.

• WebView.subproj/WebViewPrivate.m: (-[WebView _verticalKeyboardScrollAmount]), (-[WebView _horizontalKeyboardScrollAmount]): New private methods, return one arrow key's worth of scrolling. (-[WebView _scrollLineVertically:]), (-[WebView _scrollLineHorizontally:]): Now use the broken-out methods. (-[WebView _pageVertically:]), (-[WebView _pageHorizontally:]): overlap by one arrow key's worth of scrolling instead of the teensy-weensy one click's worth.

2:02 PM Changeset in webkit [2145] by cblu

• 3 edits in trunk/WebKit

Documentation for WebHTMLView

• WebView.subproj/WebHTMLView.h:

1:05 PM Changeset in webkit [2144] by rjw

• 16 edits in trunk/WebKit

Documentation changes. Removal of imports from
some headers required modification of .m.

• Plugins.subproj/WebNullPluginView.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m:
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:]): (-[WebDefaultPolicyDelegate URLPolicyForURL:inFrame:]):
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLViewPrivate.m:

Documentation changes. Removal of imports from
some headers required modification of .m.

• BrowserDocument.m:
• BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]):
• DownloadMonitor.m:
• DownloadProgressEntry.m:

11:37 AM Changeset in webkit [2143] by cblu

• 21 edits in trunk

WebCore:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

Renamed element info keys to WebElement* instead of WebContextMenuElement*
Added WebKit API documentation

• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]): clean-up
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebContextMenuDelegate.h:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]): (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadLinkToDisk:]): (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadImageToDisk:]): (-[WebDefaultContextMenuDelegate copyImageToClipboard:]): (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

• BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]): (-[ContextMenuHandler openWithiTunes:]):

11:29 AM Changeset in webkit [2142] by darin

• 8 edits in trunk/WebKit

Cleaned up some loose ends from adding setNeedsLayout to the WebDocumentView
protocol. Was causing exceptions.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]):
• WebView.subproj/WebTextView.m: (-[WebTextView setNeedsLayout:]): Added missing stubs.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Removed unneeded cast.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Remove an unneeded cast and call to isDocumentHTML.
• WebView.subproj/WebHTMLView.h: No need to re-declare setNeedsLayout.
• WebView.subproj/WebView.m: (-[WebView setFrame:]): Get rid of unneeded check of isDocumentHTML.

10:48 AM Changeset in webkit [2141] by darin

• 4 edits in trunk/WebCore

• fixed 3056579 -- various crashes at ​http://www.auspost.com.au/

Apparently the strings at this site were just the right length to expose a bug
in our QString implementation, one that I probably introduced when fixing 3032072.
One nice thing about this is that getting this correct could also result in a
little bit of a speedup, as the internal buffer is used more.

• kwq/KWQString.mm: (QStringData::makeAscii): Set _maxAscii to QS_INTERNAL_BUFFER_CHARS when using the internal buffer instead of leaving it uninitialized. (QStringData::makeUnicode): Same for _maxUnicode.

10:24 AM Changeset in webkit [2140] by darin

• 10 edits in trunk/WebCore

Remove the focus border hack, which was no longer doing us any good.

• kwq/KWQNSTextField.h: Don't define FOCUS_BORDER_SIZE.
• kwq/KWQNSTextField.mm: Remove KWQTextFieldCell. (-[KWQNSTextField updateSecureFieldFrame]): Don't inset by FOCUS_BORDER_SIZE.
• kwq/qt/qlineedit.h: Don't override frameGeometry and setFrameGeometry any more.
• kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Don't subtract the focus border size.

10:17 AM Changeset in webkit [2139] by darin

• 6 edits in trunk/WebKit

• fixed 3057383 -- focus rectangles are being drawn multiple times
• fixed 3051025 -- focus ring on password field gets darker and darker

To make focus rings clip too, we have to do more than just set the clip.
We also have to set the visible rectangle to make clipping happen, and we
need to be a subclass of NSClipView so that the focus ring drawing code will
consult us rather than one of our superviews.

• WebView.subproj/WebHTMLView.h: Be a subclass of NSClipView.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Set a inDrawRect flag, and a drawRect rectangle. This tells us to clip to this rectangle. what we need to clip to.
• WebView.subproj/WebHTMLViewPrivate.h: Added inDrawRect and drawRect.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView visibleRect]): Clip the visible rect based on the drawRect while inDrawRect is set.

10:13 AM Changeset in webkit [2138] by darin

• 4 edits in trunk/WebCore

• kwq/mac-encodings.txt: Remove constant for Japanese auto-detect.

9:53 AM Changeset in webkit [2137] by darin

• 4 edits in trunk/WebCore

• kwq/KWQFileButton.mm: (KWQFileButton::paint): Fix typo.

9:22 AM Changeset in webkit [2136] by darin

• 5 edits in trunk/WebCore

Some improvements to the file button, including displaying the file without the
extension if it's set that way by the user, and using the system font rather
than hard-coding "Lucida Grande".

• kwq/KWQFileButton.h: Add _label field.
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Set up label. (KWQFileButton::~KWQFileButton): Release label. (KWQFileButton::setFilename): Use NSFileManager componentsToDisplayForPath to figure out the appropriate label. (KWQFileButton::paint): Clip to passed-in rect, get font using systemFontOfSize, and use NSString drawing rather than our own.

Sep 23, 2002:

9:28 PM Changeset in webkit [2135] by cblu

• 7 edits in trunk/WebKit

WebKit:

Factored URL pasteboard initialization to 1 place.
Fixed: 3048924 - regression: drag & drop broken for initial empty page
Fixed: 3045997 - Dragging a link from one Alex window to another one doesn't work

• Misc.subproj/WebNSPasteboardExtras.h:
• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): new
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
• WebView.subproj/WebView.m: (-[WebView draggingEntered:]): handle nil cases

WebBrowser:

• main.m: (main): Fixed comment

6:56 PM Changeset in webkit [2134] by mjs

• 6 edits in trunk/WebKit

Added documentation for these two delegate protocols.

• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebResourceProgressDelegate.h:

5:16 PM Changeset in webkit [2133] by rjw

• 3 edits in trunk/WebKit

Made WebIconLoader and WebIconDatabase SPI.

• WebKit.pbproj/project.pbxproj:

5:13 PM Changeset in webkit [2132] by rjw

• 2 edits in trunk/WebKit/WebView.subproj

Put back changes I blew away.

5:02 PM Changeset in webkit [2131] by rjw

• 42 edits
  2 adds
  12 deletes in trunk/WebKit

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

• Misc.subproj/WebDownloadHandler.m:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebNetscapePluginView status:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge reportClientRedirectTo:delay:fireDate:]): (-[WebBridge reportClientRedirectCancelled]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebContextMenuDelegate.h:
• WebView.subproj/WebContextMenuHandler.h: Removed.
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]):
• WebView.subproj/WebControllerPolicyDelegate.m: Added. (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy URL]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
• WebView.subproj/WebControllerPolicyDelegatePrivate.h:
• WebView.subproj/WebControllerPolicyHandler.h: Removed.
• WebView.subproj/WebControllerPolicyHandler.m: Removed.
• WebView.subproj/WebControllerPolicyHandlerPrivate.h: Removed.
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _defaultContextMenuDelegate]): (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setURL:]): (-[WebDataSource _loadIcon]):
• WebView.subproj/WebDefaultContextMenuDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
• WebView.subproj/WebDefaultContextMenuHandler.h: Removed.
• WebView.subproj/WebDefaultContextMenuHandler.m: Removed.
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebDefaultPolicyHandler.h: Removed.
• WebView.subproj/WebDefaultPolicyHandler.m: Removed.
• WebView.subproj/WebDocument.h:
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame frameNamed:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _shouldShowURL:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]):
• WebView.subproj/WebImageView.m: (-[WebImageView setNeedsLayout:]):
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebLocationChangeDelegate.m:
• WebView.subproj/WebLocationChangeHandler.h: Removed.
• WebView.subproj/WebLocationChangeHandler.m: Removed.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidReceiveData:data:]):
• WebView.subproj/WebResourceProgressDelegate.h:
• WebView.subproj/WebResourceProgressHandler.h: Removed.
• WebView.subproj/WebView.m: (-[WebView window]):
• WebView.subproj/WebWindowContext.h: Removed.
• WebView.subproj/WebWindowOperationsDelegate.h:

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument close]):
• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController setFrame:]):
• ContextMenuHandler.h:
• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
• DownloadMonitor.h:
• LocationChangeHandler.h:

4:02 PM Changeset in webkit [2130] by hyatt

• 4 edits in trunk/WebCore

Found the problem with the CSS W3C page.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):

3:43 PM Changeset in webkit [2129] by darin

• 15 edits in trunk

WebCore:

WebCore part of fixes for proper layering when drawing subframes.

• kwq/KWQWidget.mm: (QWidget::paint): Use the parent view in the "WebCoreFrameView" case so we update the scroll view too, not just the HTML part. Also use the passed in rectangle instead of always using the view bounds.

• kwq/KWQScrollView.mm: (QScrollView::updateContents): Call setNeedsDisplayInRect instead of displayRect.

• kwq/KWQPainter.mm: (QPainter::drawRect): Use NSRectFill and NSFrameRect instead of NSBezierPath. (QPainter::fillRect): Ditto.

WebKit:

• fixed 3052543 -- iframes don't work with z-index
• fixed 3057382 -- code to prevent subviews from drawing not working perfectly for subframes

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Change this back to always return YES. We handle this issue at another level now. (-[WebHTMLView drawRect:]): Clip to the passed-in rect. This was the big change that fixed most of the trouble.

• WebView.subproj/WebHTMLViewPrivate.h: Remove _isMainFrame.
• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Add an imposter for NSView too, so we can make opaqueAncestor do what we need it to do. This will only work if the application doesn't also poseAsClass NSView, but it does work. (-[WebNSView opaqueAncestor]): Always return the topmost WebHTMLView if the object is inside one, even if there is an intervening opaque object.

• WebView.subproj/WebView.m: (-[WebView setFrame:]): Do the display call at the window level so the topmost WebHTMLView always gets involved.
• WebView.subproj/WebViewPrivate.h: Remove _controller, since we already have a public controller method. Add _isMainFrame.
• WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]): Added.

3:17 PM Changeset in webkit [2128] by mjs

• 3 edits in trunk/WebKit

• Panels.subproj/WebStandardPanels.h: Added inline header docs.

2:44 PM Changeset in webkit [2127] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Changes to the WebCache interface to bring it closer into line
with the current API proposal. Changes in other classes have been made to
keep up with the WebCache changes.

Added removeCacheObjectForKey method.
Renamed cacheVars pointer in WebCache header to more "standard" _private.
Changed names of private methods so that they begin with underscores.

• CacheLoader.subproj/WebCache.h:
• CacheLoader.subproj/WebCache.m: (-[WebCache initWithSizeLimit:]) (-[WebCache removeCacheObjectForKey:]) (-[WebCache sizeLimit]) (-[WebCache setSizeLimit:]) (-[WebCache objectSizeLimit]) (-[WebCache setObjectSizeLimit:]) (-[WebCache currentUsage]) (-[WebCache clearCache]) (-[WebCache dealloc]) (-[WebCache _syncCache]) (-[WebCache _setCurrentUsage:]) (-[WebCache _truncateToSizeLimit:])
• CacheLoader.subproj/WebCachePrivate.h:
• CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache removeCacheObjectForKey:]) (-[WebDiskCache _syncCache]) (-[WebDiskCache _truncateToSizeLimit:])
• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]) (-[WebMemoryCache storeCacheObject:forKey:]) (-[WebMemoryCache removeCacheObjectForKey:]) (-[WebMemoryCache clearCache])
• CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager syncAllCaches])
• Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]) (-[WebFileDatabase performSetObject:forKey:]) (-[WebFileDatabase setSizeLimit:])

2:36 PM Changeset in webkit [2126] by mjs

• 5 edits in trunk/WebKit

• WebView.subproj/WebWindowContext.h: Added inline header docs.

12:30 PM Changeset in webkit [2125] by hyatt

• 5 edits in trunk/WebCore

Don't let alternate stylesheets delay render tree construction.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):
• khtml/html/html_headimpl.h:

10:56 AM Changeset in webkit [2124] by hyatt

• 5 edits in trunk/WebCore

Make overflow:auto and scroll map to hidden until we figure
out something better.

• khtml/css/cssstyleselector.cpp:

10:25 AM Changeset in webkit [2123] by kocienda

• 8 edits in trunk/WebKit

Fixes for some build problems I missed earlier due to the fact that PB can't handle header dependencies,
and I did not do a clean build of WebKit.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:withDataSource:]): WebFoundation error constant name change. (-[WebNetscapePluginStream cancel]): Ditto.
• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): Modified to use [[WebCookieManager sharedCookieManager] acceptPolicy] rather than reaching down into CFPreferences directly.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): WebFoundation error constant name change. (-[WebSubresourceClient cancel]): Ditto.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Ditto.

10:22 AM Changeset in webkit [2122] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't special case the top level frame's view so much. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Use public method here instead of private.

10:21 AM Changeset in webkit [2121] by darin

• 12 edits in trunk/WebCore

More refinement of the AppKit hackery.

• khtml/rendering/render_replaced.cpp: (RenderWidget::printObject): Pass in the painter and rect.

• kwq/qt/qwidget.h: Take a painter and rect parameter.
• kwq/KWQWidget.mm: (QWidget::paint): Use painter; not working yet to use rect.

• kwq/KWQFileButton.h: Change paint to take painter and rect.
• kwq/KWQFileButton.mm: (KWQFileButton::paint): Use painter.

• kwq/qt/qpainter.h: Added paintingDisabled() function.
• kwq/KWQPainter.mm: (QPainter::paintingDisabled): Added.

7:58 AM Changeset in webkit [2120] by kocienda

• 4 edits in trunk/WebKit

WebFoundation:

Modified code to work with new WebError API. Many changes in that API, including removing terminal errors,
taking a pass at the error constants, and cleaning up the init methods.

• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:result:]): WebFoundation error code constant name changes
• AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h: Removed WebResult enumerated type; replace with int
• CacheLoader.subproj/IFURLHandleC.h: WebError API change
• CacheLoader.subproj/IFURLHandleC.m: Ditto (IFURLHandleBackgroundLoadFailedWithResultCode):
• CacheLoader.subproj/WebCacheLoaderConstants.h: Removed error constants; moved to WebError.h
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): WebFoundation error code constant name changes
• CacheLoader.subproj/WebResourceLoad.h: WebError API change
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): WebError API change (-[WebResourceLoad didRedirectToURL:permanent:]): Ditto. (-[WebResourceLoad _scheduleOriginLoad]): Ditto. (-[WebResourceLoad _beginOriginLoad]): Ditto. (_loadSweeper): Ditto.
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): WebFoundation error code constant name changes
• English.lproj/WebError.strings: Updated strings file. This file was way out of date.
• Misc.subproj/WebError.h: Updated API. Terminal error concept removed. API simplified. Error constants moved into this file.
• Misc.subproj/WebError.m: (classInitialize): Changes to adapt to new API. (-[WebError initWithErrorCode:inDomain:failingURL:]): Ditto (-[WebError errorDescription]): Ditto (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Ditto
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): WebFoundation error code constant na

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): WebFoundation error code constant name change
• WebView.subproj/WebView.m: (+[WebView initialize]): WebError addErrorsFromDictionary changed to addErrorsWithCodesAndDescriptions

WebBrowser:

Modified code to work with new WebError API.

• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Modified for new "no terminal error" WebError API (-[DownloadProgressEntry stop]): WebFoundation error code constant name change
• FrameProgressEntry.m: (-[FrameProgressEntry stage]): Ditto
• LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Ditto (-[LocationChangeHandler specializedMessageForError:]): Ditto (-[LocationChangeHandler displayLocationChangeError:]): Ditto
• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Modified for new "no terminal error" WebError API
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences updateCookiesViews]): Fixed unitialized variable build breaker I encountered when doing a Deployment build.
• ResourceProgressEntry.m: (-[ResourceProgressEntry stage]): WebFoundation error code constant name change

Sep 22, 2002:

9:31 PM Changeset in webkit [2119] by darin

• 3 edits in trunk/WebKit

• fixed 3057380 -- insertion point shows through elements in front of text fields

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Make WebNSTextView pose as NSTextView. (-[WebNSTextView _web_inHTMLView]): Helper method. (-[WebNSTextView isOpaque]): Override to return NO for all text views that are inside an WebHTMLView, so they don't try to do insertion point caching. (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use setNeedsDisplayInRect to trigger insertion point drawing outside drawRect instead of drawing right away. (-[WebNSTextView _drawRect:clip:]): Set flag so the above can know when it's inside drawRect and when it's not.

9:27 PM Changeset in webkit [2118] by darin

• 8 edits in trunk/WebCore

Change code that moves NSViews out of the way to run inside drawRect
after a layout change rather than running at layout time. This makes
sure that views are in the right place when propagating dirty rects.

• kwq/KWQKHTMLPartImpl.h: Add paint method and _needsToSetWidgetsAside flag.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set _needsToSetWidgetsAside to false. (KWQKHTMLPartImpl::layout): Set _needsToSetWidgetsAside to true. Don't call moveWidgetsAside any more. (KWQKHTMLPartImpl::paint): Moved the code here from the bridge, but also call moveWidgetsAside if _needsToSetWidgetsAside flag is set.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Call KWQKHTMLPartImpl::paint, which is where I moved this code.

Sep 21, 2002:

11:01 PM Changeset in webkit [2117] by darin

• 3 edits in trunk/WebCore

• fixed 3057265 -- REGRESSION: Crash loading ​http://www.undetectables.co.uk/

• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.

10:52 PM Changeset in webkit [2116] by darin

• 4 edits in trunk/WebCore

Fix crashing part of 3057265 -- REGRESSION: Crash loading ​http://www.undetectables.co.uk/

• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.

4:54 PM Changeset in webkit [2115] by darin

• 26 edits in trunk

WebCore:

WebCore part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a minor problems with subframes this should work perfectly.

• kwq/qt/qwidget.h: The paint() method isn't virtual any more. Also remove flushDrawing().
• kwq/KWQWidget.mm: (QWidget::enableFlushDrawing): Do a flushWindowIfNeeded instead of requiring a separate flushDrawing() call to do a flushWindow. (QWidget::paint): Added. Calls displayRectIgnoringOpacity.

• kwq/qt/qbutton.h: Remove paint() override.
• kwq/KWQButton.mm: (QButton::QButton): No need for a subclass any more, so drop KWQNSButton. Also remove paint().

• kwq/qt/qcombobox.h: Remove paint() override.
• kwq/KWQComboBox.mm: (QComboBox::QComboBox): No need for a subclass any more, so drop KWQNSPopUpButton. Also remove paint() method.

• kwq/qt/qlineedit.h: Remove paint() override.
• kwq/KWQLineEdit.mm: Remove paint().

• kwq/KWQFileButton.mm: (KWQFileButton::clicked): Fix typo. Was calling paint instead of clicked on the base class.

• kwq/KWQNSTextField.h: Remove paint method.
• kwq/KWQNSTextField.mm: (-[KWQNSTextField display]): Add a display method that does nothing to work around bug 2753974. (-[KWQSecureTextField display]): Ditto.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Remove call to flushDrawing.

WebKit:

WebKit part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a some remaining problems with subframes this should work perfectly.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Return NO for frames other than the main frame. (-[WebHTMLView drawRect:]): Restore the subviews that were set aside.
• WebView.subproj/WebHTMLViewPrivate.h: Add _isMainFrame. Add savedSubviews and subviewsSetAside.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _isMainFrame]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Added. If this is the main frame, get all the dirty rects from the subviews and then set them aside so the AppKit machinery won't draw them. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Added. Propagates dirty rects the same way that AppKit does, but always does it, ignoring the value of isOpaque.

Sep 20, 2002:

6:58 PM Changeset in webkit [2114] by rjw

• 4 edits in trunk/WebCore

Don't modify selection if no appropriate DOM::Node under
mouse.

• khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent):

6:44 PM Changeset in webkit [2113] by rjw

• 4 edits in trunk/WebCore

Assume triple click for selection if click count >= 3,
not == 3, as in OS X.

• khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent):

6:33 PM Changeset in webkit [2112] by rjw

• 5 edits in trunk/WebCore

Fixed crasher in findTextSlave.

• khtml/rendering/render_text.cpp: (RenderText::findTextSlave):

Added error checks.

• khtml/khtml_part.cpp: (startAndEndLineNodesIncludingNode):

6:00 PM Changeset in webkit [2111] by rjw

• 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Removed debugging.

5:58 PM Changeset in webkit [2110] by rjw

• 12 edits in trunk/WebCore

Made double and triple click selection behave like
like other selection in OS X. That is, selection happens
on mouse down, not mouse up, and can be extended by
further dragging. Triple click followed by dragging extends
the selection a line at a time.

• khtml/khtml_events.cpp:
• khtml/khtml_events.h:
• khtml/khtml_part.cpp: (KHTMLPart::customEvent): (firstSlaveAt): (lastSlaveAt): (startAndEndLineNodesIncludingNode): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (KHTMLPart::khtmlMouseMoveEvent):
• khtml/khtml_part.h:
• khtml/khtmlpart_p.h:
• khtml/khtmlview.cpp:
• khtml/khtmlview.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):

5:42 PM Changeset in webkit [2109] by darin

• 8 edits in trunk/WebCore

• kwq/KWQFileButton.h: Add an icon.
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Nil out icon. (KWQFileButton::~KWQFileButton): Release icon. (KWQFileButton::setFilename): Get icon with [NSWorkspace iconForFile:]. (KWQFileButton::clicked): Set prompt string to "Choose", and start directory to "~". (KWQFileButton::sizeHint): Pad more for icon width. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::paint): Draw icon. Draw "no file selected" if no filename.

• kwq/KWQKFileItem.mm: Our "nonimplementation" is good enough. Stop complaining.
• kwq/KWQKnetaccess.mm: Ditto. Also just extract path when asked to download.

4:45 PM Changeset in webkit [2108] by darin

• 6 edits
  2 adds
  1 delete in trunk/WebCore

Some first steps toward implementing input=file.

• khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Create a KWQFileButton as the widget. (RenderFileButton::calcMinMaxWidth): Use sizeHint(). (RenderFileButton::updateFromElement): Call setFilename(). (RenderFileButton::select): Don't try to selectAll() on m_edit.

• kwq/KWQFileButton.h: Added.
• kwq/KWQFileButton.mm: Added.
• kwq/qt/qhbox.h: Emptied.
• kwq/KWQHBox.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQHBox.mm. Added KWQFileButton.

2:26 PM Changeset in webkit [2107] by darin

• 4 edits in trunk/WebCore

• fixed 3056605 -- REGRESSION: blank page at ​http://www.2ch.net/2ch.html

• kwq/mac-encodings.txt: When people say ShiftJIS, they really mean DOSJapanese. So do what they mean, not what they say.

12:23 PM Changeset in webkit [2106] by darin

• 5 edits in trunk/WebKit

• History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): Use _web_URLWithString so we can handle unusual characters.

• WebView.subproj/WebDefaultPolicyHandler.m: Remove stray semicolon.

10:13 AM Changeset in webkit [2105] by darin

• 5 edits in trunk/WebCore

• fixed 3055339 -- repro crash in RenderPartObject::updateWidget()

• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Only create a new part if we have no old part.

• kwq/KWQtextstream.mm: Remove some of the "not implemented" logging. Once we have logged that the stream is not created correctly, there's no need to continue logging each time something is written out to the non-stream.

9:58 AM Changeset in webkit [2104] by cblu

• 6 edits in trunk/WebKit

Fixed wasteful memory usage in the WebIconDatabase:

• Rather than have multiple NSImages with multiple representations at multiple sizes, have 1 NSImage per size
• Added API to allow client to control memory caching

• Misc.subproj/WebIconDatabase.h:
• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call iconForSiteURL:withSize:cache:YES (-[WebIconDatabase iconForSiteURL:withSize:cache:]): new, was iconForSiteURL:withSize: (-[WebIconDatabase defaultIconWithSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _updateFileDatabase]): write the largest icon to disk (-[WebIconDatabase _hasIconForSiteURL:]): cleaned-up (-[WebIconDatabase _iconsForIconURL:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _builtInIconsForHost:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _setIcon:forIconURL:]): _iconsBySplittingRepresentationsOfIcon: (-[WebIconDatabase _releaseIconForIconURL:]): icons at different sizes are now stored in dictionaries (-[WebIconDatabase _largestIconFromDictionary:]): new, scans the icon dictionary (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): creates the icon dictionary (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): returns icon from dict, resizes if necessary (-[WebIconDatabase _iconByScalingIcon:toSize:]): tweak
• Misc.subproj/WebIconDatabasePrivate.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): don't call _iconsForIconURL: because it doesn't exist.

Sep 19, 2002:

11:25 PM Changeset in webkit [2103] by mjs

• 8 edits in trunk/WebKit

WebFoundation:

• Makefile.am: Make doc' target depend on all'.

WebKit:

• Makefile.am: Make doc' target depend on all'.
• WebView.subproj/WebContextMenuHandler.h: Fix typo found by `make doc'.
• WebView.subproj/WebLocationChangeHandler.h: Likewise.

10:42 PM Changeset in webkit [2102] by mjs

• 3 edits in trunk/WebKit

Tools:

• Scripts/make-docs: Added. New script to generate html docs.

WebFoundation:

• Makefile.am: Changed `make doc' target to use make-docs script (and actually work).
• CacheLoader.subproj/WebProtocolHandler.h: Remove some docs that made headerdoc2html barf.
• CacheLoader.subproj/WebCacheObject.h: Added some docs.
• CacheLoader.subproj/WebResourceHandle.h: Added some docs.
• CacheLoader.subproj/WebResourceResponse.h: Added some docs.

WebKit:

• Makefile.am: Added `make doc' target.

9:09 PM Changeset in webkit [2101] by rjw

• 8 edits in trunk/WebCore

Implemented double and triple click selection.

• khtml/khtml_events.h:
• khtml/khtml_part.cpp: (KHTMLPart::customEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (firstSlaveAt): (lastSlaveAt): (KHTMLPart::khtmlMouseTripleClickEvent):
• khtml/khtml_part.h:
• khtml/rendering/render_text.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):

6:03 PM Changeset in webkit [2100] by darin

• 5 edits in trunk/WebCore

• fixed 3045651 -- null-dereference in DOM::CharacterDataImpl constructor setting up text area element

• khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): Set str to an empty DOMStringImpl instead of to 0. This was easier than going around finding all the places that don't like a str of 0.

• WebCore.pbproj/project.pbxproj: Let PB sort things as it likes.

11:59 AM Changeset in webkit [2099] by sullivan

• 6 edits
  2 adds in trunk/WebKit

WebKit:

• cleaned up some SPI for handling URLs on pasteboard

• Misc.subproj/WebNSPasteboardExtras.h: Added.
• Misc.subproj/WebNSPasteboardExtras.m: Added. (+[NSPasteboard _web_dragTypesForURL]): Moved this here; was -[NSView _web_acceptableDragTypes] (-[NSPasteboard _web_bestURL]): Moved this here; was +[NSView _web_bestURLFromPasteboard:]

• WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change; also removed methods now in NSPasteboard.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.

• WebKit.pbproj/project.pbxproj: Updated for new files.

WebBrowser:

• updated to match SPI changes in WebKit

• BrowserWebBookmarkExtras.m: (+[WebBookmark bookmarkPasteboardTypes]): Use +[NSPasteboard _web_dragTypesForURL] instead of secret inside knowledge about which types are used by [NSPasteboard _web_bestURL] (+[WebBookmark anyBookmarksOnPasteboard:]), (+[WebBookmark bookmarksFromPasteboard:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL]

• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): (-[LocationFieldEditor concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]

• LocationTextField.m: (-[LocationTextField awakeFromNib]): (-[LocationTextField concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]

11:17 AM Changeset in webkit [2098]

• 3 copies in tags/Alexander-24

This commit was manufactured by cvs2svn to create tag 'Alexander-24'.

11:17 AM Changeset in webkit [2097] by sheridan

• 8 edits in trunk

Alex-24 version stamp

Sep 18, 2002:

10:50 PM Changeset in webkit [2096] by darin

• 3 edits in trunk/WebKit

Fix two problems that led to an assertion now that a bogus
load progress doesn't pass the "bytesReceived == total" test.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handleDidFinishLoading:]): Nil out the resource at the start of the function so that a cancel doesn't do anything if called in the middle when we stop. (-[WebNetscapePluginStream cancel]): Send a cancel error instead of a _receivedProgress. And make a partial progress rather than sending an empty progress. (-[WebNetscapePluginStream handleDidFailLoading:withError:]): Same as handleDidFinishLoading.

7:23 PM Changeset in webkit [2095] by rjw

• 10 edits in trunk/WebKit

More documentation stuff.
Added attributed text API as requested (yuck!).
Add reconstructedDocumentSource API as requested.
Removed cruft (stale API, bogus comments).

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation reconstructedDocumentSource]): (-[WebHTMLRepresentation attributedText]):
• WebView.subproj/WebHTMLRepresentationPrivate.h:
• WebView.subproj/WebHTMLView.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectedAttributedText]): (-[WebHTMLView selectedText]):
• WebView.subproj/WebView.h:

6:43 PM Changeset in webkit [2094] by rjw

• 21 edits in trunk/WebKit

Header file reorg.

• BrowserWebController.m:
• ContextMenuHandler.m:

Get HTML source from rep.

• WebBrowser/HTMLSourceDocument.m

Fix compile errors from John's last checkin.
*WebBrowser/LocationFieldEditor.m
*WebBrowser/LocationTextField.m

Added document keywords to headers.
Made bookmark related APIs private.

• Misc.subproj/WebIconDatabase.h:
• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebKitErrors.h:
• Panels.subproj/WebStandardPanels.h:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebLoadProgress.h:
• WebView.subproj/WebLocationChangeHandler.h:
• WebView.subproj/WebPreferences.h:

Made public

• WebHTMLRepresentation.h
• WebHTMLRepresentation.m

5:46 PM Changeset in webkit [2093] by sullivan

• 5 edits in trunk/WebKit

WebKit:

WebKit part of fix for

• 3000823 -- special-case drag of webloc file to bookmarks
• 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files

• Misc.subproj/WebNSViewExtras.h:
• make _web_bestURLForDraggingInfo: a class method and have it take an NSPasteboard * instead of an NSDraggingInfo *; change name to _web_bestURLFromPasteboard:
• Misc.subproj/WebNSViewExtras.m: (+[NSView _web_bestURLFromPasteboard:]):
• make this a class method and have it take an NSPasteboard * instead of an NSDraggingInfo * (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.

• WebView.subproj/WebView.m: (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change.

WebBrowser:

WebBrowser part of fix for

• 3000823 -- special-case drag of webloc file to bookmarks
• 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files

• BrowserWebBookmarkExtras.h:
• BrowserWebBookmarkExtras.m: (+[WebBookmark defaultTitleFromURL:]): New method, broken out of bookmarkFromURL, now handles remote as well as file URLs, and URLs ending with /. (+[WebBookmark bookmarkFromURL:]): call defaultTitleFromURL: (+[WebBookmark bookmarkPasteboardTypes]): include the types that _web_bestURLFromPasteboard: (+[WebBookmark anyBookmarksOnPasteboard:]): New method, faster than getting bookmarksFromPasteboard and checking for non-empty array; more accurate than just checking bookmarkPasteboardTypes. (+[WebBookmark bookmarksFromPasteboard:]): Use _web_bestURLFromPasteboard: if all else fails.

• BookmarksViewController.m: (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]), (-[BookmarksViewController canPaste]): Use +[WebBookmark anyBookmarksOnPasteboard] instead of just checking types, since NSStringPboardType (e.g.) may or may not be convertible to a bookmark

4:58 PM Changeset in webkit [2092] by rjw

• 21 edits
  8 adds in trunk/WebKit

Added documentation keywords to header.
Create seperate files for the protocols
that were defined in WebController.h.
Made -[WebController createFrameNamed:for:inParent:allowsScrolling:]):
private.

• Plugins.subproj/WebPluginView.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebContextMenuHandler.h: Added.
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m:
• WebView.subproj/WebDefaultContextMenuHandler.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebResourceProgressHandler.h: Added.
• WebView.subproj/WebView.m:
• WebView.subproj/WebWindowContext.h: Added.

3:50 PM Changeset in webkit [2091] by rjw

• 6 edits in trunk/WebKit

Added documentation keywords to header.

• WebView.subproj/WebControllerPolicyHandler.h:

Made WebDynamicScrollBarsView private

• WebKit.pbproj/project.pbxproj:

3:33 PM Changeset in webkit [2090] by darin

• 3 edits in trunk/WebKit

• fixed 3053155 -- REGRESSION: Activity Window thinks 0-byte images are "complete"

I thought I had fixed it before, but this is needed too.

• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress init]): Set "bytes so far" to 0, not -1. (-[WebLoadProgress initWithResourceHandle:]): Make sure we set total to -1, not 0, when the response is nil.

3:19 PM Changeset in webkit [2089] by rjw

• 3 edits in trunk/WebKit

Added documentation keywords to header.

• WebView.subproj/WebDocument.h:

3:06 PM Changeset in webkit [2088] by rjw

• 7 edits in trunk/WebKit

Added documentation keywords to headers.
Made reset a private method.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame reset]):

2:47 PM Changeset in webkit [2087] by rjw

• 3 edits in trunk/WebKit

Added documentation keywords to headers.

• WebView.subproj/WebView.h:

2:41 PM Changeset in webkit [2086] by rjw

• 3 edits in trunk/WebKit

Added documentation keywords to headers.

• WebView.subproj/WebDataSource.h:

12:46 PM Changeset in webkit [2085] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebController.h: Fix typo.

12:27 PM Changeset in webkit [2084] by darin

• 6 edits in trunk/WebKit

• WebView.subproj/WebController.h: Add getters.
• WebView.subproj/WebController.m: (-[WebController applicationNameForUserAgent]): Added. (-[WebController userAgent]): Added.

11:39 AM Changeset in webkit [2083] by vicki

• 5 edits in trunk

Matt Watson's approved changes to fix the fat build on gcc-1203

11:28 AM Changeset in webkit [2082] by darin

• 17 edits
  2 deletes in trunk/WebCore

• fixed 3037974 -- successful Find does not deselect text field

• khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Turn off the code that restores the cursor position because we don't use the KHTML saveState/restoreState. But we should.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection): Call setFocusNode(0), because on the Macintosh, selection and focus are mutually exclusive. (DocumentImpl::close): Remove no-longer-needed APPLE_CHANGES. (DocumentImpl::setFocusNode): Set focus to the KHTMLView when focus is being removed from a particular node. Clear the selection when focus is set on a particular node because on the Macintosh, selection and focus are mutually exclusive.

• kwq/KWQKHTMLPartImpl.h: Add set/clearDocumentFocus functions that we can use to keep document's idea of focused node in sync. with AppKit's.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::setDocumentFocus): Added. (KWQKHTMLPartImpl::clearDocumentFocus): Added.

• kwq/KWQNSTextField.mm: (-[KWQNSTextField becomeFirstResponder]): Call setDocumentFocus. (-[KWQSecureTextField becomeFirstResponder]): Call setDocumentFocus.

• kwq/qt/qwidget.h: Removed endEditing().
• kwq/KWQWidget.mm: (QWidget::clearFocus): Call clearDocumentFocus. (QWidget::endEditing): Removed.

• khtml/rendering/render_form.h:
• khtml/rendering/render_form.cpp: (RenderImageButton::RenderImageButton): Remove the KWQInvisibleButton hack, which is no longer needed.
• kwq/KWQInvisibleButton.h: Removed.
• kwq/KWQInvisibleButton.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQInvisibleButton.

9:15 AM Changeset in webkit [2081] by darin

• 5 edits in trunk/WebCore

• fixed 3027470 -- hitting tab when the google.com text field is selected (all bars hidden) makes border flash

• kwq/KWQNSTextField.mm: (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next valid key view is nil. (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code here. Maybe I'll figure out a way later.

Sep 17, 2002:

10:12 PM Changeset in webkit [2080] by darin

• 7 edits in trunk/WebCore

• fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()

• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Set the bridge on the part to nil just in case someone else is holding a reference, so we won't try to dispatch methods to an already-deallocated bridge.

• fixed 3028476 -- illegal instruction crash in KWQTimerCallback timerFired

• khtml/ecma/kjs_window.cpp: (WindowQObject::parentDestroyed): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.
• khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove APPLE_CHANGES that kills timers. All timers are killed by ~QObject now, just as in Qt. (KHTMLView::clear): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.

• kwq/KWQObject.mm: (QObject::~QObject): Call killTimers(). (QObject::startTimer): Keep a dictionary keyed by QObject, with a dictionary of timers for each, rather than one global dictionary. This makes it efficient to kill all the timers for an object. (QObject::killTimer): Update for new level of dictionary. (QObject::killTimers): Kill all the timers in this object's timer dictionary rather than all timers in the world. (QObject::inherits): Add an ERROR for the case where the class name is unknown.

4:56 PM Changeset in webkit [2079] by darin

• 4 edits in trunk/WebCore

• fixed 3050818 -- Crash in relative-KURL constructor at site with _ in host name

• kwq/KWQKURL.mm: Change _ so that it's allowed in host names. (KURL::KURL): If base URL is invalid, make result invalid too.

4:38 PM Changeset in webkit [2078] by rjw

• 6 edits in trunk/WebCore

• khtml/khtmlview.cpp: (KHTMLView::viewportMouseTripleClickEvent): Added implementation. Same as viewportMouseReleaseEvent except dispatches additional MouseTripleClickEvent event.

(KHTMLView::viewportMouseDoubleClickEvent):
Send extra release event. This emulates Qt
behavior.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Don't send extra release event here, instead send it in viewportMouseDoubleClickEvent and also in viewportMouseTripleClickEvent so DOM doesn't get confused.

• kwq/KWQColor.mm: (QColor::hsv): Fixed marklar divide by 0 problemn.

3:50 PM Changeset in webkit [2077] by darin

• 4 edits in trunk/WebKit

Fix bug where image documents were broken.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): loadStatus of 0 means the whole image is ready, not 0 scan lines; so check > 0, not >= 0.

• WebKit.pbproj/project.pbxproj: Let Project Builder be the boss of me.

3:18 PM Changeset in webkit [2076] by darin

• 16 edits in trunk/WebCore

WebCore:

• fixed 2936933 -- Pages that claim to be UTF-8 but contain invalid sequences do not render at all

Misc. speed improvements. Total 2.6% speedup for cvs-base.

Improvements for signals.

• kwq/KWQChar.mm: (QChar::isSpace): Add fast case for ASCII. (QChar::lower): Add fast case for ASCII. (QChar::upper): Add fast case for ASCII.

• kwq/qt/qcolor.h: Just store RGB values, not NSColor objects.
• kwq/KWQColor.mm: (QColor::QColor): No need to set color to nil. (QColor::name): Use QString::sprintf instead of NSString. (QColor::setNamedColor): Use KWQInvalidColor instead of nil. (QColor::getNSColor): Make an autoreleased NSColor.

• kwq/KWQKHTMLPartImpl.mm: (moveWidgetsAside): Use isWidget() instead of dynamic_cast.

• kwq/KWQSignal.h: use a QValueList instead of a fixed-size array.
• kwq/KWQSignal.mm: (KWQSignal::connect): Append to list. (KWQSignal::disconnect): Remove from list. (KWQSignal::call): Use the QValueList.

• kwq/KWQSlot.mm: (KWQSlot::call): Use static_cast instead of dynamic_cast where possible.

• kwq/qt/qstring.h: Add return value to forceUnicode.
• kwq/KWQString.mm: (QString::fromStringWithEncoding): Implemented using the Text Encoding Converter instead of CFString. (compareIgnoringCaseForASCIIOnly): New function. Faster find. (QString::find): Separate case-sensitive from case-insensitive and speed up both of them. (QString::stripWhiteSpace): Use the new forceUnicode for simplicity. (QString::simplifyWhiteSpace): Ditto. (QString::insert): Ditto. (QString::remove): Ditto. (QString::forceUnicode): Return the unicode pointer. (QString::fill): Use the new forceUnicode for simplicity.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Fix two bugs. First, don't treat a slow click as a double click. Second, deliver a mouse release event even for a double click, as Qt does.

WebBrowser:

Don't update the tool tip rectangles every time we update the
background image. This makes things a little faster.

• TextFieldWithControls.h: Boolean for whether tool tip rectangles are up to date.
• TextFieldWithControls.m: (-[TextFieldWithControls updateToolTips]): Do work only if flag is NO. Set flag to YES when done. (-[TextFieldWithControls backgroundImage]): Don't update the tool tip rectangles here. (-[TextFieldWithControls setFrameOrigin:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setFrameSize:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls drawRect:]): Update the tool tips if needed. (-[TextFieldWithControls showRightButton:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): Ditto. (-[TextFieldWithControls setRightButtonImage:withOrigin:]): Ditto.

3:10 PM Changeset in webkit [2075] by rjw

• 18 edits in trunk

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): (-[WebHistory containsEntryForURLString:]): Added URL string API. We should remove use of NSURL from this API.

• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _entryForURLString:]): (-[WebHistoryPrivate containsEntryForURLString:]): Implementation of above.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): Use ((int)(x + (1.0 - FLT_EPSILON))) instead of ceil().

• khtml/css/cssstyleselector.cpp: Fixed bug in KHTML that incorrectly modified '' in fragment part of URL.

• kwq/KWQKHistoryProvider.mm: Use string based API to add entry. May eventually remove NSURL from history entirely.

• kwq/KWQKURL.mm: (KURL::canonicalURL): Simply return the urlString.

(KURL::parse):
Added "/" to http and https empty path URLs.

• kwq/KWQString.mm: (QString::mid): Optimize ascii case.

• kwq/WebCoreHistory.h:
• kwq/WebCoreHistory.m: (-[WebCoreHistory addEntryForURLString:]): Use string based API to add entry.

• kwq/kdecore/kurl.h: Defined methods to access canonical components, currently conditionally excluded.

No longer commit history in the browser, now done in WebKit.

• BrowserDocument.m:
• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeCommittedForDataSource:]):

Sep 16, 2002:

6:24 PM Changeset in webkit [2074] by darin

• 3 edits in trunk/WebKit

• History.subproj/WebHistoryPrivate.m: Do that for real.

4:23 PM Changeset in webkit [2073] by rjw

• 5 edits in trunk/WebKit

Remove fix (according to John, partial fix) for 3051288.
Canonicalizing the URL strings used in the history db
is very slow! ~8% slower.

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addEntry:]): (-[WebHistoryPrivate removeEntry:]): (-[WebHistoryPrivate containsURL:]): (-[WebHistoryPrivate entryForURL:]):

• WebView.subproj/WebHTMLView.h: Removed cruft from header.

12:17 PM Changeset in webkit [2072] by hyatt

• 5 edits in trunk/WebCore

Fix the stylesheet loading regression on rubyfruit.

• khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::HTMLStyleElementImpl): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::isLoading):
• khtml/html/html_headimpl.h:

8:09 AM Changeset in webkit [2071] by darin

• 3 edits in trunk/WebKit

• fixed 3050810 -- while an image is loading progressively, it draws white rather then page background

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): Added. Used instead of a direct call to drawInRect:fromRect:operation:fraction:, this only draws the part of the image that is valid according to loadStatus. (-[WebImageRenderer nextFrame:]): Use drawClippedToValidInRect:fromRect:. (-[WebImageRenderer beginAnimationInRect:fromRect:]): Ditto. (-[WebImageRenderer tileInRect:fromPoint:]): Ditto.

Sep 13, 2002:

9:01 PM Changeset in webkit [2070] by rjw

• 3 edits in trunk/WebKit

Fixed 3051288. URLs were not being canonicalized, so matching failed.

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addEntry:]): (-[WebHistoryPrivate removeEntry:]): (-[WebHistoryPrivate containsURL:]): (-[WebHistoryPrivate entryForURL:]):

8:30 PM Changeset in webkit [2069] by rjw

• 3 edits in trunk/WebKit

Fixed 3050636. 90% solution. The "Display Images Automatically"
preference will be used to disallow image draggging. So if this
is set after pages have loaded, their images will not be draggable,
and vice-versa. Not disastrous as dragging in either case has little
or no negative consequences.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:05 PM Changeset in webkit [2068] by hyatt

• 20 edits in trunk/WebCore

Landing code that makes textfields, buttons, checkboxes, radio
buttons, and dropdown lists all draw correctly with respect to
z-index. They all employ the same simple hack (just never paint
unless KHTML tells them to).

Unpatched widgets include the password field, the listbox, and the
textarea.

The only issue with regards to painting with the widgets I've
patched is the textfield... its editor floats to the top when the
field is being edited.

Event handling will also be incorrect and will need to be patched
separately.

• khtml/rendering/render_body.cpp: (RenderBody::printBoxDecorations):
• khtml/rendering/render_replaced.cpp: (RenderWidget::printObject):
• kwq/KWQButton.mm: (QButton::QButton): (QButton::paint): (-[KWQNSButton drawRect:]): (-[KWQNSButton paint]):
• kwq/KWQComboBox.mm: (-[KWQNSPopUpButton drawRect:]): (-[KWQNSPopUpButton paint]): (QComboBox::QComboBox): (QComboBox::insertItem): (QComboBox::paint):
• kwq/KWQLineEdit.mm: (QLineEdit::paint):
• kwq/KWQNSTextField.h:
• kwq/KWQNSTextField.mm: (-[KWQNSTextField paint]):
• kwq/qt/qbutton.h:
• kwq/qt/qcombobox.h:
• kwq/qt/qlineedit.h:
• kwq/qt/qwidget.h:

6:07 PM Changeset in webkit [2067] by rjw

• 5 edits in trunk/WebCore

Fixed navigation to link on mouse up after drag.

• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): Change khtml's definition of double click to be based on mouse up of second click, not mouse down.

(KHTMLView::viewportMouseReleaseEvent):

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseDown:]): Changed double click to be on mouse up with click count of two.

5:53 PM Changeset in webkit [2066] by mjs

• 6 edits in trunk/WebKit

WebFoundation:

WebFoundation changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

I also unwound some now-needless async code paths.

• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.h:
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler endLoadInBackground]): (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]): (-[WebCFNetworkHTTPProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]): (-[WebCFNetworkHTTPProtocolHandler performStreamRead:]):
• CookieManager.subproj/IFCookieAcceptHandlerC.h: Removed.
• CookieManager.subproj/IFCookieAcceptHandlerC.m: Removed.
• CookieManager.subproj/IFCookieAcceptRequestC.h: Removed.
• CookieManager.subproj/IFCookieAcceptRequestC.m: Removed.
• CookieManager.subproj/IFCookieManagerC.h:
• CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerSetCookiesFromResponseHeaders):
• CookieManager.subproj/WebCookieAcceptHandler.h: Removed.
• CookieManager.subproj/WebCookieAcceptHandlerDispatcher.h: Removed.
• CookieManager.subproj/WebCookieAcceptHandlerDispatcher.m: Removed.
• CookieManager.subproj/WebCookieAcceptRequest.h: Removed.
• CookieManager.subproj/WebCookieAcceptRequest.m: Removed.
• CookieManager.subproj/WebCookieAcceptRequestPrivate.h: Removed.
• CookieManager.subproj/WebCookieConstants.h:
• CookieManager.subproj/WebCookieManager.h:
• CookieManager.subproj/WebCookieManager.m: (-[WebCookieManagerPrivate init]): (-[WebCookieManagerPrivate dealloc]): (-[WebCookieManager _readAcceptCookiesPreference]): (-[WebCookieManager _setCookies:forURL:]): (-[WebCookieManager setCookie:]): (-[WebCookieManager setCookiesFromResponseHeaders:forURL:]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

WebKit changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

• Panels.subproj/WebStandardPanels.h:
• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels useStandardAuthenticationPanel]):
• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

WebBrowser changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

• AppController.m: (-[AppController awakeFromNib]):
• Preferences.subproj/English.lproj/SecurityPreferences.nib:
• Preferences.subproj/SecurityPreferences.h:
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

5:35 PM Changeset in webkit [2065] by darin

• 4 edits in trunk/WebCore

Fix crash in slot code.

• kwq/KWQSignal.mm: (KWQSignal::call): Copy the slots before calling through in case we are destroyed by the called function.

5:02 PM Changeset in webkit [2064] by darin

• 11 edits in trunk

WebCore:

Here's the *real* mistake that killed plugins. I accidentally
stopped creating objects at all! Duh. Fixed now.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): Make a part for a plugin if we need one. Not a KHTMLPart, but a KWQPluginPart.

WebKit:

Added assertions, and dealt with some breakage I created while
trying to fix, here, what I broke in WebCore.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Do get the dataSource from our parent when we are being used as an object in a view rather than a document view.

• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebFrame.m: Leave in the assertions I used to debug.

3:57 PM Changeset in webkit [2063] by darin

• 10 edits in trunk/WebKit

WebKit:

• fixed 3031685 -- The text encoding setting is not propagated to subframes

• WebView.subproj/WebDocument.h: Remove old WebDocumentTextEncoding methods, add supportsTextEncoding.
• WebView.subproj/WebController.m: (-[WebController supportsTextEncoding]): Check the document view to see if it supports WebDocumentTextEncoding and returns YES. (-[WebController setCustomTextEncoding:]): Call _reloadAllowingStaleDataWithOverrideEncoding. (-[WebController resetTextEncoding]): Ditto. (-[WebController _mainFrameOverrideEncoding]): Added. Gets encoding from the data source of the main frame; provisional if there, main if not. (-[WebController hasCustomTextEncoding]): Call _mainFrameOverrideEncoding. (-[WebController customTextEncoding]): Ditto.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setParent:]): Set the override encoding to the parent's.

• WebView.subproj/WebFrame.m: (-[WebFrame reload]): Release request to fix storage leak. Set the override encoding on the new data source to match the old.

• WebView.subproj/WebFramePrivate.h: New name for stale data reload method.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Do pretty much the same thing reload does with a few differences. Get the encoding from the parameter rather than the old data source, and set the policy to the one that uses data from the cache, even stale data, if present

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView supportsTextEncoding]): Return YES.

WebBrowser:

WebCore part of text encoding fix.

• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Call the new WebKit methods. (-[BrowserWindowController changeTextEncoding:]): Ditto.

3:38 PM Changeset in webkit [2062] by rjw

• 16 edits in trunk

Made justified text work correctly in khtml for rendering
and selection. Optimized selection point calculation by
only doing characters measurements once.

• khtml/rendering/font.cpp: (Font::floatCharacterWidths):
• khtml/rendering/font.h:
• khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint): (RenderText::position):
• kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
• kwq/KWQPainter.mm: (QPainter::drawText):
• kwq/WebCoreTextRenderer.h:
• kwq/qt/qfontmetrics.h:

Adding padding and widths buffer to our canonical measurement
method. The padding argument is used to 'pad' measurements in
that same way that drawing is padded. The widths parameter
allows a caller to pass a buffer to get all the individual
character widths for the run of characters in the string.

• Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):

3:26 PM Changeset in webkit [2061] by darin

• 7 edits in trunk/WebCore

Quiet error messages related to the slot/signal changes.

• khtml/khtml_part.cpp: (KHTMLPart::startAutoScroll): Ifdef this out. (KHTMLPart::stopAutoScroll): Ditto.

• kwq/KWQObject.mm: (QObject::connect): Add two more expected members to the list for setStatusBarText and slotViewCleared.

• kwq/KWQSignal.h: Allow 4 slots per signal. I don't want to make it a variable number, but we can if we have to.
• kwq/KWQSignal.mm: (KWQSignal::connect): Support multiple slots. (KWQSignal::disconnect): Support multiple slots. (KWQSignal::call): Support multiple slots.

2:35 PM Changeset in webkit [2060] by darin

• 5 edits in trunk/WebKit

Fix dataSource-related plugin crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't grab dataSource here. It's too early. (-[WebNetscapePluginView setDataSource:]): Grab it here.

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: Simplified includes and added asserts while debugging.

2:32 PM Changeset in webkit [2059] by darin

• 12 edits in trunk/WebCore

Fix assertion that happens on any page that has a non-HTML frame.

We were sending signals for objects in m_objects that are only supposed
to be sent for frames in m_frames. The fix is to use actual slot/signal
connections instead of our hard-coded logic.

• kwq/KWQKHTMLPartImpl.h: Add signals for started and completed.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::completed): Emit completed signal. (KHTMLPart::started): Emit started signal. (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Create signals.

• kwq/KWQObject.mm: (QObject::connect): Write out an error message if we see any signal connections to signals that aren't implemented, with a hardwired exception list for ones we either aren't ever going to do or just haven't gotten around to yet.

• kwq/KWQSignal.h: Add support for signals that take bool and KIO::Job *.
• kwq/KWQSignal.mm: (KWQSignal::connect): Put in an actual ERROR call for the case where this fails. (KWQSignal::disconnect): Put in an actual ERROR call for the case where it fails. (KWQSignal::call): Add overloads for bool and KIO::Job *.

• kwq/KWQSlot.h: Add support for slots that take bool and KIO::Job *.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Add four new members. (KWQSlot::call): Add overloads for bool and KIO::Job * and support for the new members.

1:06 PM Changeset in webkit [2058] by rjw

• 3 edits in trunk/WebKit

Changed drag hysteresis to 5 and disallow selection initiation within
a link.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:50 AM Changeset in webkit [2057] by darin

• 48 edits in trunk

top level:

• Tests/WebFoundation-Misc/ifnsurlextensions-test.m: Remove uneeded include of NSURLPathUtilities.h.

WebCore:

• kwq/KWQAssertions.h: Update assertions from from the copy in WebFoundation.
• WebCorePrefix.h: Remove NSURLPathUtilities.h include.

Use even more of the KHTML code so we get referrers in one more place.

• kwq/WebCoreBridge.h: Add referrer to createChildFrameNamed.

• khtml/khtml_part.h: Less APPLE_CHANGES, no substantive change.
• khtml/khtml_part.cpp: (KHTMLPart::requestFrame): Use more of this, less APPLE_CHANGES. (KHTMLPart::requestObject): Ditto. (KHTMLPart::processObjectRequest): Ditto.

• khtml/rendering/render_frames.h: Less APPLE_CHANGES.
• khtml/rendering/render_frames.cpp: Less APPLE_CHANGES.

• kwq/kparts/browserextension.h: Add lockHistory/setLockHistory and openURLNotify.

• kwq/khtml/khtml_ext.h: Add openURLNotify.
• kwq/KWQKHTMLPartImpl.h: Add openURLNotify.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLNotify): Implement.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): Changed name from requestFrame. Do less work.

• kwq/qt/qtimer.h: Add singleShot.
• kwq/KWQTimer.mm: (+[KWQSingleShotTimerTarget targetWithQObject:member:]): Added. Used to implement singleShot. (-[KWQSingleShotTimerTarget dealloc]): Ditto. (-[KWQSingleShotTimerTarget timerFired:]): Ditto. (QTimer::singleShot): Added.

• kwq/qt/qmap.h: Add contains.

• kwq/qt/qvaluelist.h: Add iterator return value for append and prepend.
• kwq/KWQValueListImpl.h: Add iterator return value for appendNode and prependNode.
• kwq/KWQValueListImpl.mm: (KWQValueListImpl::appendNode): Add iterator. (KWQValueListImpl::prependNode): Add iterator.

• kwq/kparts/part.h: Add openURL.

WebKit:

Prep work for fixes to the text encoding for subframes.

• WebCoreSupport.subproj/WebBridge.h: Remove [loadURL:withParent:].
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Added referrer parameter.

• WebView.subproj/WebController.h: Add new methods, not implemented yet.
• WebView.subproj/WebController.m: (-[WebController supportsTextEncoding]): Here is one. (-[WebController setCustomTextEncoding:]): Another. (-[WebController resetTextEncoding]): Etc. (-[WebController hasCustomTextEncoding]): Etc. (-[WebController customTextEncoding]): Etc.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource startLoading]): Remove the forceRefresh flag. This is now controlled by the WebResourceRequest.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Same for this private version.
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Remove the forceRefresh flag. (-[WebFrame reload]): Remove the forceRefresh flag. A reload without a forceRefresh is only used internally, not requested by the caller.

• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Add handling for the case where we reload, but allow stale data. (-[WebFrame _isLoadComplete]): Ditto. (-[WebFrame _reloadAllowingStaleData]): Placeholder, not implemented yet.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView setTextEncoding:]): Update for new API, but this is going away. (-[WebHTMLView setDefaultTextEncoding]): Ditto.

WebBrowser:

• BrowserDocument.m: (-[BrowserDocument refresh:]): Call the new [reload] instead of the old [reload:].

Sep 12, 2002:

11:48 PM Changeset in webkit [2056] by rjw

• 3 edits in trunk/WebKit

Don't initiate a drag if an autoscroll happened.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

8:21 PM Changeset in webkit [2055] by rjw

• 11 edits in trunk

Added "Absolute" position to the render tree view. Useful
to see how kthml LIES!

• Debug/RenderTree.m: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
• Debug/RenderTree.nib:

Added absolute position column to render node for
render tree view.

• WebView.subproj/WebRenderNode.h:
• WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): (-[WebRenderNode absolutePositionString]): (-[WebKitRenderTreeCopier nodeWithName:position:rect:view:children:]):

Rewrite of khtml selection drawing code. Now does
a delta between old and new selection and only
draw those objects that have changed. Selection
drawing is now MUCH faster.

• khtml/rendering/render_root.cpp: (enclosingPositionedRect): (RenderRoot::setSelection): (RenderRoot::clearSelection):
• khtml/rendering/render_root.h:

Added additional absolute position property to render node
stuff for debug render tree view.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge copyRenderNode:copier:]):

6:35 PM Changeset in webkit [2054] by hyatt

• 4 edits in trunk/WebKit

Add text/xml to our list of MIME types that should use the
Web view. With this fix we now render XML and XHTML
correctly!

• WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]):
• WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]):

6:04 PM Changeset in webkit [2053] by hyatt

• 5 edits in trunk/WebCore

KHTML was butchering the laws of background propagation from
the <body> to the <html>. This fixes the logical flaws and
makes some of the geekiest CSS on the planet render correctly. ;)

• khtml/rendering/render_body.cpp: (RenderBody::printBoxDecorations):
• khtml/rendering/render_html.cpp: (RenderHtml::printBoxDecorations):

5:19 PM Changeset in webkit [2052] by hyatt

• 4 edits in trunk/WebCore

Make fixed positioned elements work when you scroll. We were
just missing the implementation of a QScrollView method.

• kwq/KWQScrollView.mm: (QScrollView::setStaticBackground):

3:23 PM Changeset in webkit [2051] by hyatt

• 4 edits in trunk/WebCore

Fix a bug in KHTML that leads it to claim cached @imported stylesheets
are not loaded (when in fact they are).

This fixes the W3C CSS page.

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):

2:51 PM Changeset in webkit [2050] by kocienda

• 12 edits in trunk/WebKit

WebFoundation:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

• CacheLoader.subproj/IFURLHandleC.h: Removed obsolete IFURLHandleGetFlags function
• CacheLoader.subproj/IFURLHandleC.m: Ditto.
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]): Temporary hack until new redirect API is available.
• CacheLoader.subproj/WebCacheLoaderConstants.h: Removed all load flags.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Removed calls to load flags and replaced with calls to new request policies. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
• CacheLoader.subproj/WebResourceHandle.m: Removed flags accessor, and removed calls to load flags and replaced with calls to new request policies. (-[WebResourceHandle description]): Removed calls to load flags and replaced with calls to new request policies.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _beginLoad]): Ditto. (-[WebResourceLoad description]): Ditto.
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Ditto. (+[WebResourceLoadKey keyWithLoad:]): Ditto. (-[WebResourceLoadKey isEqual:]): Ditto. (-[WebResourceLoadKey hash]): Ditto. (-[WebResourceLoadManager requestWithURLHandle:]): Ditto. (-[WebResourceLoadManager loadDidFinish:]): Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Added new WebRequestCachePolicy and WebResponseCachePolicy enums, and accessor methods to set these values on a request.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): Ditto. (-[WebResourceRequest requestCachePolicy]): Added. (-[WebResourceRequest setRequestCachePolicy:]): Added. (-[WebResourceRequest responseCachePolicy]): Added. (-[WebResourceRequest setResponseCachePolicy:]): Added (-[WebResourceRequest copyWithZone:]): Removed calls to load flags and replaced with calls to new request policies.
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Added some initial support for the notion of "specially-handled" headers. This work is not done yet. (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Fixed case where we appended nil if there was no user-agent set. (-[WebSimpleHTTPProtocolHandler _examineHeaders]): Removed calls to load flags and replaced with calls to new request policies.
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp: Removed obsolete _IFURLHandleGetFlags symbol.

WebKit:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

• WebCoreSupport.subproj/WebBridge.h: Removed flags from loadURL method.
• WebCoreSupport.subproj/WebBridge.m: Removed calls to load flags and replaced with calls to new request policies. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge isReloading]): Ditto. (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:withParent:]): Removed flags from loadURL method. (-[WebBridge postWithURL:referrer:data:]): Removed calls to load flags and replaced with calls to new request policies.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Ditto.
• WebView.subproj/WebDataSource.h: Removed flags from init method.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Ditto. (-[WebDataSource initWithRequest:]): Ditto.
• WebView.subproj/WebDataSourcePrivate.h: Removed flags ivar, and dangling attributes ivar.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Ditto.
• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed calls to load flags and replaced with calls to new request policies.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Ditto.

1:25 PM Changeset in webkit [2049] by cblu

• 4 edits in trunk/WebCore

Fixed livepage crash on Marklar. It is naughty to divide by 0 on marklar so we now check before doing that.

• khtml/rendering/render_box.cpp: (RenderBox::printBackground):

12:15 PM Changeset in webkit [2048] by hyatt

• 4 edits in trunk/WebCore

Fix crash on trekweb.com. My simplified FOUC code was a little
bit too simple. ;)

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):

12:05 PM Changeset in webkit [2047] by hyatt

• 8 edits in trunk/WebCore

Fix the Warcraft 3 page on blizzard.com so that the relative
positioned blocks inside centered tables inside enclosing tables
with percentage widths work correctly.

This fix also causes the textfields on mrskin.com to show up
again.

• khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::setPos):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild):
• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/rendering/render_object.h:

8:53 AM Changeset in webkit [2046]

• 3 copies in tags/Alexander-23

This commit was manufactured by cvs2svn to create tag 'Alexander-23'.

8:53 AM Changeset in webkit [2045] by cblu

• 5 edits in trunk/WebKit

WebKit:

Make WebTextView private and exported.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebTextView.h:

WebBrowser:

Show HTML source in Alex.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument viewSource:]): create new HTMLSourceDocument
• BrowserDocumentController.h:
• BrowserDocumentController.m: (-[BrowserDocumentController openHTMLSourceDocumentWithDataSource:]): added
• ContextMenuHandler.m: (-[ContextMenuHandler viewSource:]): create new HTMLSourceDocument
• English.lproj/HTMLSource.nib: Added.
• HTMLSourceController.h: Added.
• HTMLSourceController.m: Added. (-[HTMLSourceController windowDidLoad]): (-[HTMLSourceController setString:]): (-[HTMLSourceController targetForSearch]):
• HTMLSourceDocument.h: Added.
• HTMLSourceDocument.m: Added. (-[HTMLSourceDocument initWithDataSource:]): (-[HTMLSourceDocument dealloc]): (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument dataRepresentationOfType:]): (-[HTMLSourceDocument saveDocumentTo:]): (-[HTMLSourceDocument fileName]): (-[HTMLSourceDocument fileType]): (-[HTMLSourceDocument displayName]):
• WebBrowser.pbproj/project.pbxproj:

Sep 11, 2002:

11:53 PM Changeset in webkit [2044] by mjs

• 4 edits in trunk/WebCore

WebCore:

Don't show the window here any more, now that WebBrowser will set
it up to be shown properly itself.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

WebBrowser:

Changed new window opening to happen right away instead of waiting
until the content policy is known. This avoids the horrible lack
of feedback and feeling of slowness on new window opening, but
re-introduces the problem that command-clicking on a link that
downloads leaves around an empty window (Radar 3049296).

While I was at it, I made goToInitialURL get called right away
instead of deferring it, since the problems that arose from
calling it right away before no longer apply.

• fixed Radar 3017596 - Cmd click on link doesn't display new window fast enough
• fixed Radar 3049291 - Deferring goToInitialURL can cause problems

• BrowserDocument.h:
• BrowserDocument.m: Remove methods and code related to awaiting the content policy, since we no longer wait for it.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Show the window next time through the event loop. (-[BrowserDocumentController _createEmptyBrowserDocumentAndDisplay:]): Show the window next time through the event loop.
• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): No more need to show or close window when content policy is determined.
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Go to initial URL immediately, not after delay.

6:59 PM Changeset in webkit [2043] by hyatt

• 4 edits in trunk/WebCore

Fix horizontal scrolling. The HTML render object lies. It lies,
I tell you.

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

6:01 PM Changeset in webkit [2042] by hyatt

• 11 edits in trunk/WebCore

Fix clipping to work with layers. This fixes the marquee
(once again) on livepage.apple.com.

• khtml/rendering/render_box.cpp: (RenderBox::getClipRect):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject):
• khtml/rendering/render_layer.cpp: (RenderLayer::enclosingPositionedAncestor): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print):

4:23 PM Changeset in webkit [2041] by darin

• 4 edits in trunk/WebCore

WebFoundation:

• Misc.subproj/WebAssertions.h: Changed assertions to use a different technique for varargs, which seems to work better on Claudius. Sorry about the nearly-full build.

• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest setMethod:]): Store a copy so we don't end up retaining a mutable string that the caller then modifies. (-[WebResourceRequest setHeaders:]): Allow nil for theHeaders, and make an empty dictionary in that case. (-[WebResourceRequest setHeader:forKey:]): Store a copy so we don't end up putting a reference to a mutable string in our dictionary. (-[WebResourceRequest addHeader:forKey:]): Ditto. (-[WebResourceRequest setExtraCookies:]): Ditto, same applies for NSArray. (-[WebResourceRequest setData:]): Ditto, same for NSData.

WebCore:

• kwq/KWQAssertions.h: Updated copy of the assertions macros (made by script).

4:10 PM Changeset in webkit [2040] by mjs

• 8 edits in trunk/WebKit

Combined provisionalDataSourceChanged: and
provisionalDataSourceCommitted: methods into a single
setDataSource:, since they are always called one immediately after
the other.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]): (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebView.subproj/WebDocument.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]):
• WebView.subproj/WebImageView.m: (-[WebImageView setDataSource:]):
• WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

3:43 PM Changeset in webkit [2039] by rjw

• 3 edits in trunk/WebKit

i Better fix for previous problem.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

2:05 PM Changeset in webkit [2038] by darin

• 4 edits in trunk/WebCore

• fixed 3047552 -- crash using CFNotification calls on an NSNotification

• kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Create a KWQWindowWidgetDeleter, and hook it up to the notification. (KWQWindowWidget::~KWQWindowWidget): Disconnect the KWQWindowWidgetDeleter and release it. (-[KWQWindowWidgetDeleter initWithWindowWidget:]): Store a pointer. (-[KWQWindowWidgetDeleter deleteWindowWidget]): Do a delete.

1:33 PM Changeset in webkit [2037] by rjw

• 3 edits in trunk/WebKit

Remove ceiling of text width at end of fragment. This was screwing up
intra fragment text measurements.

Selection of justified text is still screwed up. This is a fundamental problem
in khtml and will require a rewrite of their justification code. Konq has the
same problems selecting justified text. The drawing of code applies the justification
factor, but checking the selection doesn't add the justification factor, so selection
will be incorrect by the justification amount.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

12:26 PM Changeset in webkit [2036] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Use the current URL, not the original URL, when doing a reload. This prevents the URL from changing back and forth when you reload on a page that involved a redirect.

11:56 AM Changeset in webkit [2035] by darin

• 10 edits
  1 add
  1 delete in trunk/WebCore

• fixed 3021137 -- changing font prefs doesn't redraw frames other than the main frame

• kwq/WebCoreSettings.m: Renamed to WebCoreSettings.mm.
• kwq/WebCoreSettings.mm: Renamed from WebCoreSettings.m so I could use C++. (-[WebCoreSettings _updateAllViews]): Iterate over all KWQKHTMLPartImpl instances, calling setNeedsReapplyStyles on each one.
• WebCore.pbproj/project.pbxproj: Updated for name change.

• kwq/KWQKHTMLPartImpl.h: Add instances() and mutableInstances(). Get rid of frameExists(), findFrame(), and frames().
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Add to instance list. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove from instance list. (KWQKHTMLPartImpl::requestFrame): Update to not use frameExists(). (KWQKHTMLPartImpl::overURL): Update to not use frameExists, and improve handling of various cases. (KWQKHTMLPartImpl::mutableInstances): Create and return instance list.

• kwq/WebCoreBridge.h: Add setNeedsReapplyStyles; already implemented in WebKit.

• khtml/khtml_part.cpp: (KHTMLPart::findFrame): Remove APPLE_CHANGES. (KHTMLPart::frameExists): Remove APPLE_CHANGES. (KHTMLPart::frames): Remove APPLE_CHANGES.

11:52 AM Changeset in webkit [2034] by darin

• 4 edits in trunk/WebKit

Add machinery needed for fix to 3021137, changing font prefs
doesn't redraw frames other than the main frame.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Added. Lets the web views know that they need to reapply styles. If we did this over on the WebCore side, we'd have to do it right away. Maybe that would be OK; we can move that that later.

• WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use the fixed-width size, rather than using the other size with the fixed-width family.

11:14 AM Changeset in webkit [2033] by kocienda

• 17 edits in trunk/WebKit

WebFoundation:

Major change to the API and design of WebFoundation.

Attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

• CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod): Removed attribute usage. Replace with calls to new API. (IFHTTPURLHandleGetRequestHeaders): Ditto.
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addUnconditionalUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addAcceptHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addCookieHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler hasConditionalCustomHeaders]): Ditto.
• CacheLoader.subproj/WebCacheLoaderConstants.h: Removed newly obsoleted attributes.
• CacheLoader.subproj/WebCacheLoaderConstants.m: Ditto.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldAttemptOriginLoad]): Removed attribute usage. Replace with calls to new API. (-[WebHTTPProtocolHandler shouldCacheResourceData]): Ditto. (-[WebHTTPProtocolHandler requestMethod]): Ditto. (-[WebHTTPProtocolHandler requestData]): Ditto. (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:]): Ditto. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
• CacheLoader.subproj/WebResourceHandle.h: Removed attributeForKey method.
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Removed attribute usage. Replace with calls to new API. (-[WebResourceHandle initWithRequest:client:]): WebResourceRequest no longer requires explicit validation.
• CacheLoader.subproj/WebResourceHandleInternal.h: Removed processedAttributes.
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]): Ditto.
• CacheLoader.subproj/WebResourceHandlePrivate.h: Removed _setAttribute method.
• CacheLoader.subproj/WebResourceHandlePrivate.m: Ditto.
• CacheLoader.subproj/WebResourceLoad.h: Removed processedAttributes ivar. Removed attributeForKey and setAttribute:forKey: methods.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Ditto. (-[WebResourceLoad description]): Ditto. (-[WebResourceLoad dealloc]): Ditto.
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Removed attributes from cache key. Need to put back some request info soon. (+[WebResourceLoadKey keyWithLoad:]): Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Removed attributes ivar. Added method, headers, extraCookies and data ivars. Added getter and setter methods for each of the new ivars.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): API and implementation rejiggering to deal with removing attributes from the init methods. (-[WebResourceRequest initWithURL:flags:]): Ditto. (-[WebResourceRequest initWithURL:userAgent:flags:]): Ditto. (-[WebResourceRequest method]): Added. (-[WebResourceRequest setMethod:]): Added. (-[WebResourceRequest headers]): Added. (-[WebResourceRequest setHeaders:]): Added. (-[WebResourceRequest referrer]): Added. (-[WebResourceRequest setReferrer:]): Added. (-[WebResourceRequest extraCookies]): Added. (-[WebResourceRequest setExtraCookies:]): Added. (-[WebResourceRequest data]): Added. (-[WebResourceRequest setData:]): Added. (-[WebResourceRequest flags]): Just moved method in the file. No changes. (-[WebResourceRequest protocolHandlerClass]): Ditto. (-[WebResourceRequest copyWithZone:]): Made sure new ivars get copied. (-[WebResourceRequest dealloc]): Added new ivars.
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Removed attribute usage. Replace with calls to new API.
• WebFoundation.exp: Removed attribute key exports.

WebKit:

Major change to the API and design of WebFoundation. WebKit has been modified
to use the new API.

WebFoundation attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

• Plugins.subproj/WebPluginStream.h: Removed attribute usage in init API. No need for replacement.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:]): Removed attribute usage in init API. (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Ditto. (-[WebNetscapePluginStream dealloc]): Remove attribute release. (-[WebNetscapePluginStream startLoad]): Removed attribute usage. Replace with calls to new API. (-[WebNetscapePluginStream receivedData:withHandle:]): Ditto.
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView pluginURLFromCString:]): Added this helper method. (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): Added. (-[WebNetscapePluginView getURLNotify:target:notifyData:]): Modified to call new loadRequest:inTarget:withNotifyData: method. (-[WebNetscapePluginView getURL:target:]): Ditto. (-[WebNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): Ditto.
• WebCoreSupport.subproj/WebBridge.h: Removed attribute usage in loadURL API. No need for replacement.
• WebCoreSupport.subproj/WebBridge.m: Added loadRequest:withParent: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge startLoadingResource:withURL:referrer:]): Removed attribute usage. Replace with calls to new API. (-[WebBridge isReloading]): Ditto. (-[WebBridge loadRequest:withParent:]): Added. (-[WebBridge loadURL:]): Modified to use new loadRequest:withParent: API (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:flags:withParent:]): Ditto. (-[WebBridge postWithURL:data:]): Ditto.
• WebCoreSupport.subproj/WebSubresourceClient.h: Changed API to use an NSString referrer instead of an attributes dictionary.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebDataSource.h: Added initWithRequest: method.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Removed attribute usage in init API. (-[WebDataSource initWithURL:flags:]): Ditto. (-[WebDataSource initWithRequest:]): Added. (-[WebDataSource request]): Added.
• WebView.subproj/WebDataSourcePrivate.h: Added WebResourceRequest ivar.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Added WebResourceRequest ivar. (-[WebDataSource _startLoading:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Use new WebDataSource init API.

WebBrowser:

Updated to use new referrer ivar and accessor methods on WebResourceRequest, instead
of using attributes.

• BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:])

9:37 AM Changeset in webkit [2032] by darin

• 36 edits in trunk

WebCore:

WebCore part of support for the "Referer" header.

• khtml/khtml_part.cpp: (KHTMLPart::urlSelected): Use much more of this function. (KHTMLPart::submitForm): Use much more of this function.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Parse the referrer out of the URLArgs and pass it along.

• kwq/KWQKHTMLPartImpl.h: Change parameters to urlSelected and submitForm to allow KHTML to do more of the work. Add referrer helper function.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Pass referrer of nil when opening a blank window. (KWQKHTMLPartImpl::referrer): Extract referrer from metadata. (KWQKHTMLPartImpl::openURLRequest): Pass referrer from args through the bridge. (KWQKHTMLPartImpl::urlSelected): Remove code that duplicates what's in KHTMLPart. Also pass referrer from args through the bridge as above. (KWQKHTMLPartImpl::submitForm): Ditto.

• kwq/kdeui/kmessagebox.h: Add information member function.
• kwq/KWQKMessageBox.mm: (KMessageBox::information): Implement.

• kwq/kdecore/kurl.h: Add encode_string member function.
• kwq/KWQKURL.mm: (KURL::KURL): Fix buffer overflow bug, and add an assert so we will notice these overflows even when using the static buffer. (KURL::parse): Added a similar assert, even though I didn't fix any overflow bug here. (KURL::encode_string): Implemented this, but didn't test it.

• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Pass referrer through the bridge.

• kwq/WebCoreBridge.h: Add referrer parameters to loadURL, postWithURL, openNewWindowWithURL, and startLoadingResource.

• kwq/kparts/browserextension.h: Implement setDoPost, setContentType, const version of metaData().

• kwq/qt/qstring.h: Implement fromLatin1(const char *, int).

• WebCore-tests.exp: Not sure why, but I needed to remove isMalformed, and the tests seem to still work with it removed.

WebKit:

WebKit part of support for the "Referer" header.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Add referrer parameter, and pass it on to the window context method. (-[WebBridge addAttributeForReferrer:toDictionary:]): Added. (-[WebBridge attributesForReferrer:]): Added. (-[WebBridge startLoadingResource:withURL:referrer:]): Put the referrer into an attributes dictionary and pass it to the WebSubresourceClient method. (-[WebBridge loadURL:referrer:]): Put the referrer into an attributes dictionary and pass it along. (-[WebBridge postWithURL:referrer:data:]): Put the referrer into an attributes dictionary and pass it along.

• WebCoreSupport.subproj/WebSubresourceClient.h: Add an attributes parameter to the method that starts loading.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:attributes:forDataSource:]): Put the attributes into the WebResourceRequest.

• WebView.subproj/WebController.h: Add a referrer parameter to the WebWindowContext openNewWindowWithURL method.
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openNewWindowWithURL:referrer:]): Pass the referrer on to the window context. (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): Pass nil for the referrer for now. Not sure if this is best. (-[WebDefaultContextMenuHandler openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Ditto.

• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass nil for the referrer here where we are creating a new empty window.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass nil for the referrer here in the WebClickPolicyOpenNewWindow. The policy API doesn't provide a way for the policy handler to specify the referrer; we might want to change that later.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Pass nil for the referrer here. But it seems wrong that this function discards the handle attributes that are passed in for the case where it opens a new window.

WebBrowser:

WebBrowser part of support for the "Referer" header.

• BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:]): Add referrer parameter, and pass it through to the document controller. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Pass nil for referrer.

• BrowserDocumentController.h: Add referrer parameter to the long version of goToURL.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Change to not all makeDocumentWithContentsOfURL and instead create the document here, because we need to pass the referrer through. (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): Just call the version above that has a referrer, passing a referrer of nil. (-[BrowserDocumentController _goToEachURL:referrer:forceNewWindow:orderFront:]): Pas referrer to goToURL and to openDocumentWithContentsOfURL. (-[BrowserDocumentController goToEachURL:]): Pass nil for referrer. (-[BrowserDocumentController goToURL:referrer:forceNewWindow:orderFront:]): Add referrer parameter, and pass through to _goToEachURL.

• BrowserDocument.h: Add _openWithReferrer field, initWithContentsOfURL method that takes a referrer, and goToURL method that takes a referrer.
• BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:referrer:]): Set _openWithReferrer. (-[BrowserDocument dealloc]): Release _openWithReferrer. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Add referrer parameter. Set up attributes dictionary with referrer in it. (-[BrowserDocument goToURL:]): Call through to goToURL:referrer:. (-[BrowserDocument goToURL:referrer:]): Added. Passes referrer on. (-[BrowserDocument goToInitialURL:]): Pass _openWithReferrer. (-[BrowserDocument tryMultipleURLs:]): Pass nil for referrer.

• ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]): Pass nil for referrer.
• AppController.m: (-[AppController application:openFile:]): Ditto. (-[AppController handleGURLEvent:withReplyEvent:]): Ditto.
• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]): Ditto.
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Ditto.

8:41 AM Changeset in webkit [2031] by cblu

• 4 edits in trunk/WebKit

Fixed: 3048158 - Crash at google in _destroyInitializingClassList

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):

3:36 AM Changeset in webkit [2030] by hyatt

• 8 edits in trunk/WebCore

This patch fixes a slew of bugs. It is an implementation
of the IE extensions offsetLeft, offsetTop, and offsetParent.
Konqueror actually had implementations for these properties
that were totally wrong, leading any DHTML that would use
these properties (like the DHTML on brainjar.com or livepage.apple.com)
to misposition child elements.

With these properties now implemented, the menus on brainjar.com
position correctly, and the marquee on livepage.apple.com once
again shows up (and now you can see how I've regressed clipping
by not shoving it into the layer system as well).

Next up will be fixing the clipping bug on livepage.apple.com.

• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
• khtml/rendering/render_flow.cpp: (RenderFlow::offsetHeight): (RenderFlow::offsetLeft): (RenderFlow::offsetTop):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_object.cpp: (RenderObject::offsetLeft): (RenderObject::offsetTop): (RenderObject::offsetParent):
• khtml/rendering/render_object.h:

Sep 10, 2002:

9:28 PM Changeset in webkit [2029] by hyatt

• 7 edits in trunk/WebCore

Get more elements on mrskin painting as well as the menus
on brainjar.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
• khtml/rendering/render_object.h:

8:02 PM Changeset in webkit [2028] by hyatt

• 11 edits in trunk/WebCore

Fix the CSS clip property.

• khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
• khtml/css/cssstyleselector.cpp:
• khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::tryPut):
• khtml/rendering/render_box.cpp: (RenderBox::calcClip):
• khtml/rendering/render_flow.cpp: (RenderFlow::printObject):
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print):
• khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (RenderStyle::diff):
• khtml/rendering/render_style.h:

6:45 PM Changeset in webkit [2027] by rjw

• 2 edits in trunk/WebKit

Forgot to commit ChangeLog

6:43 PM Changeset in webkit [2026] by rjw

• 17 edits in trunk

• Tests/html/mousetest.html: Added.

Fixed broken DOM handling of click count. DOM click
events can be tested with Labyrinth/Test/html/mousetest.html.
Preparation work for double and triple click selection.

• khtml/khtml_events.cpp:
• khtml/khtml_events.h:
• khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseTripleClickEvent):
• khtml/khtml_part.h:
• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseTripleClickEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent):
• khtml/khtmlview.h:
• kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseDown:]):
• kwq/qt/qevent.h:

Renamed method.

• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):

Renamed method.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): (-[WebPreferences setWillLoadImagesAutomatically:]): (-[WebPreferences willLoadImagesAutomatically]):

5:24 PM Changeset in webkit [2025] by cblu

• 11 edits in trunk/WebKit

WebFoundation:

initialize WebError class in all class methods

• Misc.subproj/WebError.m: (+[WebError classInitialize]): added, calls classInitialize() (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): call +classInitialize (+[WebError addErrorsFromDictionary:]): call +classInitialize

WebKit:

Report download handler errors
Renamed error constants
Added new errors

• Misc.subproj/WebDownloadHandler.h:
• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler errorWithCode:]): added (-[WebDownloadHandler receivedData:]): return an error (-[WebDownloadHandler finishedLoading]): return an error (-[WebDownloadHandler cancel]): return an error
• Misc.subproj/WebKitErrors.h: added new errors
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:]): use renamed error constants
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): don't send an error when errors are suppressed (-[WebMainResourceClient didCancelWithHandle:]): report download handler errors (-[WebMainResourceClient handleDidFinishLoading:]): report download handler errors (-[WebMainResourceClient handleDidReceiveData:data:]): report download handler errors (-[WebMainResourceClient handleDidFailLoading:withError:]): report download handler errors
• WebView.subproj/WebView.m: (+[WebView initialize]): add new errors to WebError

WebBrowser:

Renamed error constants

• BrowserWebController.m: (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): use renamed error constants
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]): clean-up
• DownloadProgressEntry.m: (-[DownloadProgressEntry setError:]): handle errors in succession (-[DownloadProgressEntry setProgress:]): handle errors in succession

5:07 PM Changeset in webkit [2024] by hyatt

• 4 edits in trunk/WebCore

Fix FOUC to behave correctly. I was smoking crack when I
implemented this the first time (mainly because KHTML had
a badly named API that didn't mean even remotely what
I thought it should).

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):

4:36 PM Changeset in webkit [2023] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): removed the ERROR message in the case where the history file was not found, as this is normal initial-state behavior.

WebBrowser:

• fixed 3047715 -- "Favorites" should no longer be a special folder
• fixed 3030996 -- Why can't I delete an empty Favorites?
• some other miscellaneous cleanup

I haven't yet cleaned out all the old favorites-related code; wrote up
3047885 to represent that work.

• BookmarksController.m: (-[BookmarksController imageForBookmark:]): don't special-case _favoritesRoot; use "tiny_menu" as the "standard size" image instead of "heart_small". (-[BookmarksController awakeFromNib]): remove call to (and method) _blessOrCreateFavoritesRoot; this makes _favoritesRoot always nil, so the other code that special-cases it will never do anything interesting. (-[BookmarksController _newBookmarkSheetDidEnd:returnCode:contextInfo:]): find toolbar item in pop-up menu a different way. (-[BookmarksController _addToolbarToMenu:]): new method, adds item to pop-up menu that represents toolbar (needs an image though -- see 3047876) (-[BookmarksController _setUpPopUpMenuForNewBookmarksController:]): add toolbar item to pop-up menu instead of coopting "Favorites" item.

• BrowserWindowController.h,
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]), (-[BrowserWindowController dealloc]): removed all references to favorites bar. (-[BrowserWindowController toggleLocationBarWithAnimation:]): fixed comment.

• Defaults.plist: changed default "Add Bookmarks" location to "Toolbar"
• English.lproj/Browser.nib: not sure what I changed, perhaps nothing.

• PreferenceKeys.h: realphabetized.

• Resources/Images/heart_small.tiff: Removed.
• WebBrowser.pbproj/project.pbxproj: Updated for removed file.

4:07 PM Changeset in webkit [2022] by mjs

• 19 edits
  2 adds in trunk

WebCore:

WebCore part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Reuse existing frame if possible. Pass frame name when opening a new window.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't warn when opening a new window. Check non-descendant frames too. (KWQKHTMLPartImpl::urlSelected): Pass frame name when opening window.
• kwq/WebCoreBridge.h: Add frameName argument to openNewWindowWithURL:.

WebKit:

WebKit part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

This is done by adding a concept of named controller sets, so that
less browser-like uses of WebKit won't be affected.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:frameName:]): Pass frameName parameter to controller initializer.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController init]): Pass nil for controllerSetName.

(-[WebController dealloc]):
(-[WebController frameNamed:]): Check other windows in the same set too.

• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): (-[WebController _setDefersCallbacks:]): (-[WebController _setTopLevelFrameName:]): (-[WebController _frameInThisWindowNamed:]):
• WebView.subproj/WebControllerSets.h: Added.
• WebView.subproj/WebControllerSets.m: Added. (+[WebControllerSets addController:toSetNamed:]): Method to maintain controller sets. (+[WebControllerSets removeController:fromSetNamed:]): Likewise.
• WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

WebBrowser part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

• BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Pass controller set name when creating WebController.

2:29 PM Changeset in webkit [2021] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle client]) (-[WebResourceHandle initWithRequest:client:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest initWithURL:attributes:flags:]) (-[WebResourceRequest initWithURL:userAgent:attributes:flags:]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest dealloc])
• CacheLoader.subproj/WebResourceResponse.h:

WebKit:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:])

11:47 AM Changeset in webkit [2020] by cblu

• 9 edits in trunk/WebKit

WebKit:

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (-[WebHistory entryForURL:]): added
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate entryForURL:]): added
• Misc.subproj/WebIconDatabase.h: added WebIconLargeSize
• Misc.subproj/WebIconDatabase.m: added WebIconLargeSize
• WebKit.exp: export link label key and WebIconLargeSize

WebBrowser:

Check history and the link's label when suggesting a bookmark title.

• ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):

9:01 AM Changeset in webkit [2019] by darin

• 4 edits in trunk/WebCore

Add back the APPLE_CHANGES for a few frame cases. We need to do some real testing
before we remove our alternate versions of these (but I still hope we do remove them).

• khtml/khtml_part.cpp: (KHTMLPart::findFrame): Back to the old way. (KHTMLPart::frameExists): Ditto. (KHTMLPart::frames): Ditto.

8:52 AM Changeset in webkit [2018] by darin

• 46 edits in trunk

WebCore:

• fixed 2942809 -- remove all direct access to "WebKit" defaults from WebCore

• kwq/WebCoreSettings.h: Add willLoadImagesAutomatically and userStyleSheetLocation.
• kwq/WebCoreSettings.m: (-[WebCoreSettings _updateAllViews]): Added. Placeholder for a function that will cause all views to update styles and layout. (-[WebCoreSettings setStandardFontFamily:]): Call _updateAllViews if a change happened. (-[WebCoreSettings setFixedFontFamily:]): Ditto. (-[WebCoreSettings setSerifFontFamily:]): Ditto. (-[WebCoreSettings setSansSerifFontFamily:]): Ditto. (-[WebCoreSettings setCursiveFontFamily:]): Ditto. (-[WebCoreSettings setFantasyFontFamily:]): Ditto. (-[WebCoreSettings setMinimumFontSize:]): Ditto. (-[WebCoreSettings setDefaultFontSize:]): Ditto. (-[WebCoreSettings setDefaultFixedFontSize:]): Ditto. (-[WebCoreSettings setWillLoadImagesAutomatically:]): Added. (-[WebCoreSettings willLoadImagesAutomatically]): Added. (-[WebCoreSettings setUserStyleSheetLocation:]): Added. Call _updateAllViews if a change happened. (-[WebCoreSettings userStyleSheetLocation]): Added.

• WebCore.exp: Add WebCoreSettings to the exported class list.

• kwq/KWQKHTMLSettings.mm: Get settings from WebCoreSettings rather than going directly at WebKit user defaults.
• kwq/KWQKConfigBase.mm: (KConfig::readNumEntry): Check key. (KConfig::readUnsignedNumEntry): Use WebCoreSettings to get the value of the "JavaScript can open windows automatically" setting, rather than going directly at a WebKit user default. (KConfig::readColorEntry): Remove log message. This is implemented well enough.

• fixed 3015877 -- either wean WebCore from _web_URLFromString, or make it public API in WebFoundation

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::redirectionTimerStartedOrStopped): Use KURL to make an NSURL rather than using [NSURL _web_URLWithString:].
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setBaseURL): Ditto.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): Ditto.

After fixing the above bugs, I noticed that I could remove the WebFoundation dependency.

• WebCore.pbproj/project.pbxproj: Remove WebFoundation framework.

• kwq/WebCoreBridge.h: Replace reportError with reportBadURL.
• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Use reportBadURL instead of reportError. This was the last bit of direct dependency on WebFoundation.

Do some preparation work for implementing "referrer".

• khtml/khtml_part.cpp: Remove lots of APPLE_CHANGES and compile more original code. This in preparation for using the "referrer" code from KHTML.
• khtml/khtmlview.h: Ditto.
• khtml/misc/loader.cpp: Ditto.

• kwq/kdecore/kurl.h: Add things needed by code formerly inside APPLE_CHANGES.
• kwq/KWQKURL.mm: (KURL::hasRef): Ditto. (urlcmp): Implement in a simple-minded way. Needed by some code formerly inside APPLE_CHANGES. We can make a more full-featured version when and if we need it.
• kwq/kio/global.h: Ditto.
• kwq/kio/job.h: Ditto.
• kwq/kio/jobclasses.h: Ditto.
• kwq/KWQKjobclasses.mm: Ditto.
• kwq/kparts/browserextension.h:
• kwq/kparts/part.h: Ditto.
• kwq/qt/qstringlist.h: Ditto.
• kwq/KWQStringList.mm: (QStringList::pop_front): Ditto.
• kwq/qt/qvaluelist.h: Ditto.
• kwq/KWQValueListImpl.h: Ditto.
• kwq/KWQValueListImpl.mm: (KWQValueListImpl::isEqual): Ditto.

Other changes.

• kwq/KWQApplication.mm: (QApplication::setOverrideCursor): Don't report an error for this, it's OK to do nothing. (QApplication::restoreOverrideCursor): Ditto.

WebKit:

WebKit part of weaning WebCore from getting directly at WebKit defaults.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): Added. Propagates all preferences to WebCore. This way WebCore doesn't have to actively ask for the values of preferences using defaults keys that are WebKit secrets. (+[WebPreferences load]): Set up an observer that calls _updateWebCoreSettings whenever NSUserDefaultsDidChangeNotification is posted. (-[WebPreferences setStandardFontFamily:]): Call _updateWebCoreSettings right away, don't wait for NSUserDefaultsDidChangeNotification. (-[WebPreferences setFixedFontFamily:]): Ditto. (-[WebPreferences setSerifFontFamily:]): Ditto. (-[WebPreferences setSansSerifFontFamily:]): Ditto. (-[WebPreferences setCursiveFontFamily:]): Ditto. (-[WebPreferences setFantasyFontFamily:]): Ditto. (-[WebPreferences setDefaultFontSize:]): Ditto. (-[WebPreferences setDefaultFixedFontSize:]): Ditto. (-[WebPreferences setMinimumFontSize:]): Ditto. (-[WebPreferences setUserStyleSheetEnabled:]): Ditto. (-[WebPreferences setUserStyleSheetLocation:]): Ditto. (-[WebPreferences setJavaEnabled:]): Ditto. (-[WebPreferences setJavaScriptEnabled:]): Ditto. (-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:]): Ditto. (-[WebPreferences setPluginsEnabled:]): Ditto. (-[WebPreferences setDisplayImages:]): Ditto.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): Add this method, which replaces reportError. Now WebCore doesn't use WebFoundation directly at all! Pretty neat.

WebBrowser:

• Preferences.subproj/ActiveContentPreferences.m: WebKit now calls it "Java", not "java".

Sep 9, 2002:

5:59 PM Changeset in webkit [2017] by rjw

• 8 edits in trunk

Implemented disable images automatically (2896319).

• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):

Implemented disable images automatically (2896319).

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences setDisplayImages:]): (-[WebPreferences displayImages]):

Implemented disable images automatically (2896319).

• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::autoLoadImages):

5:33 PM Changeset in webkit [2016] by darin

• 6 edits in trunk/WebKit

• fixed 3003605 -- Leaking 1 WebView after second run of static PLT

Fixing this should also help with footprint.

• WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Remove old workaround for problem where we always deallocated the frames from timer cleanup. I found a better fix for this. (-[WebFrame stopLoading]): Explicitly fire the scheduled layout timer if any when we stop loading, rather than leaving it hanging.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Explicitly fire the scheduled layout timer if any.

• WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Use an autorelease pool here so we don't end up putting all the frames in the main event loop's autorelease pool.

• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark init]): Use copy instead of retain. (-[WebBookmark identifier]): Use copy instead of retain.

5:19 PM Changeset in webkit [2015] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyView): Remove stray printf.

4:56 PM Changeset in webkit [2014] by hyatt

• 12 edits in trunk/WebCore

Switching over to the layer system for the handling of mouse
events.

• khtml/rendering/render_flow.cpp: (RenderFlow::nodeAtPoint):
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
• khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): (-[WebCoreBridge elementAtPoint:]):
• kwq/qt/qrect.h:

2:52 PM Changeset in webkit [2013] by kocienda

• 3 edits in trunk/WebKit

Missed one call through asking WebResourceHandle for contentLength
instead of WebResourceResponse.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]):

2:24 PM Changeset in webkit [2012] by kocienda

• 5 edits in trunk/WebKit

Content length information now accessible via WebResourceResponse object,
rather than from WebResourceHandle.

• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

2:20 PM Changeset in webkit [2011] by rjw

• 3 edits in trunk/WebKit

Make both calls to adjust CG font cache dynamic.
The new CGFontCacheSetMaxSize() adds a font cache
parameter. Ugh! This is needed so we can compile
w/o warnings on stock Jag.

• WebCoreSupport.subproj/WebTextRendererFactory.m:

2:03 PM Changeset in webkit [2010] by kocienda

• 4 edits in trunk/WebKit

Character set information now accessible via WebResourceResponse object,
rather than from WebResourceHandle.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

11:47 AM Changeset in webkit [2009] by cblu

• 3 edits in trunk/WebKit

WebKit:

Re-enable wizzy scaling.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]):

WebBrowser:

• LoadProgressMonitor.m: (-[LoadProgressMonitor _incrementProgressBarWithProgress:previousProgress:isMainResource:]): renamed (-[LoadProgressMonitor monitorResource:withProgress:error:dataSource:]): _incrementProgressBarWithProgress:previousProgress:isMainResource: (-[LoadProgressMonitor finishedLoadingFrame:]): stop progress bar only if data was received

11:32 AM Changeset in webkit [2008] by darin

• 4 edits in trunk/WebCore

• khtml/rendering/render_layer.h: Add a call to delete to fix a storage leak.

10:47 AM Changeset in webkit [2007] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

I removed WebCacheLoaderConstantsPrivate.h, but did not check for who
was importing that file. Duh!

Includes now fixed.

• CacheLoader.subproj/WebCacheObject.m:
• CacheLoader.subproj/WebDiskCache.m:
• CacheLoader.subproj/WebMemoryCache.m:
• CacheLoader.subproj/WebResourceHandle.m:
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceLoad.h:
• Database.subproj/WebFileDatabase.m:

10:22 AM Changeset in webkit [2006] by darin

• 33 edits in trunk/WebCore

• khtml/misc/helper.cpp: (khtml::setNamedColor): Add a missing return I spotted.

• kwq/KWQApplication.mm:
• kwq/KWQChar.mm:
• kwq/KWQCompletion.mm:
• kwq/KWQCursor.mm:
• kwq/KWQEvent.mm:
• kwq/KWQFontInfo.mm:
• kwq/KWQFontMetrics.mm:
• kwq/KWQInputDialog.mm:
• kwq/KWQKConfigBase.mm:
• kwq/KWQKFileDialog.mm:
• kwq/KWQKFileItem.mm:
• kwq/KWQKGlobalSettings.mm:
• kwq/KWQKHTMLSettings.mm:
• kwq/KWQKIconLoader.mm:
• kwq/KWQKMimeType.mm:
• kwq/KWQKSimpleConfig.mm:
• kwq/KWQKjobclasses.mm:
• kwq/KWQKnetaccess.mm:
• kwq/KWQLineEdit.mm:
• kwq/KWQScrollView.mm:
• kwq/KWQString.mm:
• kwq/KWQWidget.mm:
• kwq/KWQbrowserinterface.mm:
• kwq/KWQtextstream.mm:
• kwq/KWQxml.mm: Change various LOG(NotYetImplemented) to ERROR, FATAL, or removed them entirely. This will help us with the task of getting every last one either "not implemented on purpose" or implemented. I'm not sure the NotYetImplemented log channel is useful, because it's chock full of continuous "direction not implemented" messages.

• kwq/KWQLogging.h:
• kwq/KWQLogging.m: Removed the NeverImplemented logging channel. The distinction is no longer worth keeping around. We use NotYetImplemented instead.

9:38 AM Changeset in webkit [2005] by kocienda

• 5 edits in trunk/WebKit

WebResourcehandle no longer has a contentType method.
Call through to WebResourceResponse object to get content type.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

9:03 AM Changeset in webkit [2004] by darin

• 8 edits in trunk/WebKit

Fixed lifetime problems happening due to new cancel mechanism.

• WebCoreSupport.subproj/WebSubresourceClient.m: Add comments explaining why retain/release is needed.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): Add a retain/release so that we don't run into problems if _stopLoading causes the data source to go away.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Add retain/release for similar reasons, with comment explaining why. (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handleDidFailLoading:withError:]): Ditto.

Fixed the problem that was leading to the NSImage exception, but didn't turn on
the whizzy scaling -- leaving that to Chris.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): Eliminate the "size 0x0" feature. It was only implemented in one place, and tons of other places would actually make a size 0x0 icon. But also, we don't need it any more.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource iconLoader: receivedPageIcon:), (-[WebDataSource _loadIcon]): Don't bother actually passing the icon to [WebLocationChangeHandler receivedPageIcon:forDataSource:]. We should probably eventually either just get rid of this method, or remove the icon parameter.

8:35 AM Changeset in webkit [2003] by cblu

• 4 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]): Commented out wizzy scaling as it was causing an NSImage exception to be raised.
• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin _getPluginInfo]): Check Resource Manager errors

WebBrowser:

• BrowserWindowController.m: (-[BrowserWindowController textFieldWithProgressBar]): renamed, simplified (-[BrowserWindowController setProgressBarValue:]): call textFieldWithProgressBar (-[BrowserWindowController incrementProgressBarBy:]): call textFieldWithProgressBar
• TextFieldWithControls.m: (-[TextFieldWithControls selectText:]): remove progress bar here

Sep 8, 2002:

11:25 PM Changeset in webkit [2002] by darin

• 4 edits in trunk/WebKit

WebFoundation:

• Misc.subproj/WebAssertions.h: Use 0 instead of undefined for the XXX_DISABLED macros to be more consistent with the case where they are explicitly defined on purpose.

• CacheLoader.subproj/WebHTTPProtocolHandler.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

• CacheLoader.subproj/WebResourceLoad.m: Same, but for ERROR, rather than LOG.

WebKit:

• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/WebPluginView.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

WebBrowser:

• BookmarksController.m:
• GlobalHistory.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

11:11 PM Changeset in webkit [2001] by darin

• 65 edits
  4 adds
  2 deletes in trunk/WebCore

Tools:

• Scripts/update-kwq-assert: Added. Script to keep the KWQ version of the assert macros in sync. with the WebFoundation version. Just update the WebFoundation one and run this script.

• wftool/WFTool.m: Remove obsolete include.

WebCore:

Switch over to new assertion/logging scheme.

• kwq/KWQAssertions.h: Added.
• kwq/KWQAssertions.m: Added.
• kwq/KWQLogging.h: Added.
• kwq/KWQLogging.m: Added.
• kwq/kwqdebug.h: Removed.
• kwq/kwqdebug.mm: Removed.
• WebCore.pbproj/project.pbxproj: Update to reflect above changes.

• kwq/KWQApplication.mm:
• kwq/KWQChar.mm:
• kwq/KWQColor.mm:
• kwq/KWQComboBox.mm:
• kwq/KWQCompletion.mm:
• kwq/KWQCursor.mm:
• kwq/KWQDrawUtil.mm:
• kwq/KWQEvent.mm:
• kwq/KWQFontInfo.mm:
• kwq/KWQFontMetrics.mm:
• kwq/KWQFrame.mm:
• kwq/KWQHBox.mm:
• kwq/KWQInputDialog.mm:
• kwq/KWQInvisibleButton.mm:
• kwq/KWQKConfigBase.mm:
• kwq/KWQKFileDialog.mm:
• kwq/KWQKFileItem.mm:
• kwq/KWQKGlobalSettings.mm:
• kwq/KWQKHTMLPartImpl.mm:
• kwq/KWQKHTMLSettings.mm:
• kwq/KWQKIconLoader.mm:
• kwq/KWQKJob.mm:
• kwq/KWQKLocale.mm:
• kwq/KWQKMimeType.mm:
• kwq/KWQKPartsEvent.mm:
• kwq/KWQKSimpleConfig.mm:
• kwq/KWQKURL.mm:
• kwq/KWQKWin.mm:
• kwq/KWQKWinModule.mm:
• kwq/KWQKjobclasses.mm:
• kwq/KWQKnetaccess.mm:
• kwq/KWQLabel.mm:
• kwq/KWQLineEdit.mm:
• kwq/KWQListBox.mm:
• kwq/KWQListImpl.mm:
• kwq/KWQLoaderImpl.mm:
• kwq/KWQObject.mm:
• kwq/KWQPaintDeviceMetrics.mm:
• kwq/KWQPainter.mm:
• kwq/KWQPixmap.mm:
• kwq/KWQRegion.mm:
• kwq/KWQScrollView.mm:
• kwq/KWQSlot.mm:
• kwq/KWQString.mm:
• kwq/KWQTimer.mm:
• kwq/KWQWidget.mm:
• kwq/KWQbrowserinterface.mm:
• kwq/KWQtextcodec.mm:
• kwq/KWQtextstream.mm:
• kwq/KWQxml.mm:
• kwq/WebCoreBridge.mm:
• kwq/WebCoreCookieAdapter.m:
• kwq/WebCoreHistory.m:
• kwq/WebCoreImageRendererFactory.m:
• kwq/WebCoreTextRendererFactory.m:
• kwq/WebCoreViewFactory.m: Update to use new assertions and logging macros. In some cases, just removed unneeded includes.

11:06 PM Changeset in webkit [2000] by darin

• 19 edits in trunk/WebKit

• Bookmarks.subproj/WebBookmarkGroup.m:
• History.subproj/WebHistoryPrivate.m:
• History.subproj/WebURLsWithTitles.m:
• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconDatabase.m:
• Misc.subproj/WebIconLoader.m:
• WebView.subproj/WebController.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebPreferences.m:
• WebView.subproj/WebViewPrivate.m: Remove unnecessary includes.

11:04 PM Changeset in webkit [1999] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m:
• CacheLoader.subproj/WebCacheObject.m:
• CacheLoader.subproj/WebDiskCache.m:
• CacheLoader.subproj/WebHTTPProtocolHandler.m:
• CacheLoader.subproj/WebMemoryCache.m:
• CacheLoader.subproj/WebResourceHandle.m:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceHandlePrivate.m:
• CacheLoader.subproj/WebResourceLoad.m:
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m:
• CookieManager.subproj/WebCookie.m:
• CookieManager.subproj/WebCookieManager.m:
• CookieManager.subproj/WebCookieStorage.m:
• Database.subproj/WebFileDatabase.m:
• Misc.subproj/WebBinaryHeap.m:
• Misc.subproj/WebReadWriteLock.m:
• Misc.subproj/WebRecursiveReadWriteLock.m: Remove some unnecessary includes.

• CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.h: Removed.
• CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m: Removed.
• CacheLoader.subproj/WebHTTPResourceLoader.h: Removed.
• CacheLoader.subproj/WebHTTPResourceLoader.m: Removed. Removed these files. The ChangeLog says they were removed a long time ago, but cvs doesn't agree.

5:22 PM Changeset in webkit [1998] by darin

• 22 edits
  2 adds
  3 deletes in trunk/WebKit

Update logging to use new implementation. Remove old.

• Misc.subproj/WebKitDebug.h: Removed.
• Misc.subproj/WebKitDebug.m: Removed.
• Misc.subproj/WebKitLogging.h: Added.
• Misc.subproj/WebKitLogging.m: Added.
• Misc.subproj/WebKitReallyPrivate.h: Removed.
• WebKit.pbproj/project.pbxproj: Update for above changes.

• WebKit-tests.exp: Now empty.

• History.subproj/WebHistoryItem.m: Remove unneeded include.

• Bookmarks.subproj/WebBookmarkGroup.m:
• History.subproj/WebHistoryPrivate.m:
• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconDatabase.m:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/WebPluginView.m:
• Plugins.subproj/npapi.m:
• WebCoreSupport.subproj/WebTextRenderer.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebMainResourceClient.m: Change to use new log channels.

4:18 PM Changeset in webkit [1997] by darin

• 8 edits in trunk/WebKit

top level:

• Tests/WebFoundationC/ifurlhandlec-test.c: (run): Remove begin and cancel testing.

WebKit:

Remove empty handleDidBeginLoading and handleDidCancelLoading
methods, now that they will never be called.

• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebMainResourceClient.m:

4:07 PM Changeset in webkit [1996] by darin

• 5 edits in trunk/WebKit

Forgot to save out files from the editor in my last change.

• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: Oops.

3:53 PM Changeset in webkit [1995] by darin

• 11 edits in trunk/WebKit

Finished weaning us from handleDidCancelLoading. Now I will remove both
handleDidBeginLoading and handleDidCancelLoading.

• WebCoreSupport.subproj/WebSubresourceClient.h: Add a handle method.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidCancelLoading:]): Remove guts, move to cancel. (-[WebSubresourceClient handleDidFinishLoading:]): Remove the client from the data source now, not the handle. (-[WebSubresourceClient handleDidFailLoading:withError:]): Ditto. (-[WebSubresourceClient cancel]): Move guts here, also make the above change. (-[WebSubresourceClient handle]): Added.

• WebView.subproj/WebDataSource.m: Use clients list, not handles list.
• WebView.subproj/WebDataSourcePrivate.h: Keep a list of subresource clients rather than a list of handles for the subresources.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Update to match new field names. (-[WebDataSource _updateLoading]): Use clients, not handles. (-[WebDataSource _startLoading:]): Move line about starting loading out of the if statement. I suspect the if statement is always true, though. (-[WebDataSource _addSubresourceClient:]): New name. Keep client pointer instead of handle now. (-[WebDataSource _removeSubresourceClient:]): Ditto. (-[WebDataSource _stopLoading]): Move download handler line into WebMainResourceClient since the "not sent when application is quitting" issue is gone now. Stop the subresource clients using the cancel call, not by cancelling the handle directly. (-[WebDataSource _defersCallbacksChanged]): Update for clients list, not handles list.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Cancel the download handler here. (-[WebMainResourceClient handleDidReceiveData:data:]): Call didCancelWithHandle here. A loose end from the previous change.

2:48 AM Changeset in webkit [1994] by hyatt

• 20 edits in trunk/WebCore

Landing the new layer system and turning it on for painting of
all types of positioned blocks (and for painting the root
and HTML layers as well).

Event handling is not yet using the new layer system, so you
may see oddities like DHTML menus now displaying correctly but
events not working (since the event code may still be stacking
incorrectly and think the DHTML is behind other content).

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcHeight): (RenderBox::calcAbsoluteHorizontal):
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject): (RenderFlow::printSpecialObjects): (RenderFlow::layout): (RenderFlow::layoutSpecialObjects): (RenderFlow::layoutBlockChildren): (RenderFlow::insertSpecialObject):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_html.cpp: (RenderHtml::layout):
• khtml/rendering/render_image.cpp: (RenderImage::printObject):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::enclosingAncestor): (RenderLayer::addChild): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree): (RenderLayer::RenderZTreeNode::constructLayerList):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print): (RenderWidget::printObject):
• khtml/rendering/render_root.cpp: (RenderRoot::calcHeight): (RenderRoot::layout): (RenderRoot::printObject):
• khtml/rendering/render_root.h:
• khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==):
• khtml/rendering/render_style.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
• kwq/qt/qrect.h: