Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 8, 2002:

11:46 PM Changeset in webkit [2613] by darin

• 3 edits in trunk/WebKit

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem setTitle:]): Use display title if it matches, so we don't end up with two identical strings, as when reading from the property list. (-[WebHistoryItem setDisplayTitle:]): The same thing, the other way round.

11:46 PM Changeset in webkit [2612] by darin

• 4 edits in trunk/JavaScriptCore

• kjs/date_object.cpp: (ctimeUsingCF): Added. (timeUsingCF): Added.

11:09 PM Changeset in webkit [2611] by darin

• 3 edits in trunk/WebKit

• fixed 3095078 -- image loop counts still not handled right

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Look for the tag "NETSCAPE2.0", not "NETSCAPE1.0". (-[WebImageRenderer nextFrame:]): Remove special handling for last frames with a duration of 0. That was just a misunderstanding.

8:12 PM Changeset in webkit [2610] by mjs

• 4 edits in trunk/WebCore

• fixed 3096451 - REGRESSION: clicking on link to open window only works when pop-up suppression is off

• khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::ScriptInterpreter): Initialize m_timerCallback to false.

5:42 PM Changeset in webkit [2609] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Slightly better fix. Essentially just take out the assert.

5:39 PM Changeset in webkit [2608] by darin

• 4 edits in trunk/WebCore

• kwq/KWQComboBox.mm: Bump fudge factor up one pixel. You could see it was wrong with strings like "0".

5:37 PM Changeset in webkit [2607] by darin

• 3 edits in trunk/WebKit

• fixed an assert I am seeing a lot

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Oops.

5:33 PM Changeset in webkit [2606] by darin

• 5 edits in trunk/WebCore

• fixed 3090452 -- REGRESSION: orbitz Box extends way over margins

• kwq/KWQComboBox.h: Added _width and _widthGood.
• kwq/KWQComboBox.mm: (QComboBox::QComboBox): Set _widthGood to false. (QComboBox::insertItem): Set _widthGood to false. (QComboBox::sizeHint): Compute the width by measuring the text ourselves. Turns out the cell isn't helpful for that. (QComboBox::clear): Set _widthGood to false.

4:23 PM Changeset in webkit [2605] by rjw

• 3 edits in trunk/WebKit

Solved missing glyph problem, but it's very slow, so
it's disabled for now. I'll turn back on after extending
the character to glyph map in each renderer to include
substituted font.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Coalesce items, and add a count to title when appropriate. Useful for
condensing multiple item, like spacer.gif.

• LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]):
• ResourceProgressEntry.h:
• ResourceProgressEntry.m: (-[ResourceProgressEntry count]): (-[ResourceProgressEntry setCount:]): (-[ResourceProgressEntry title]):

2:35 PM Changeset in webkit [2604] by darin

• 15 edits in trunk/WebKit

• separate WebBaseNetscapePluginStream more cleanly from its subclasses by making most fields private

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate _cancelWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate cancelQuietly]): (-[WebBaseResourceHandleDelegate cancelledError]): (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]):

1:06 PM Changeset in webkit [2603] by darin

• 4 edits in trunk/WebKit

Tools:

• Scripts/blame-malloc-history: Added.
• Scripts/count-malloc-history: Added.
• Scripts/diff-malloc-history: Added.

WebFoundation:

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Used a description in a more-standard format.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _cleanup]): Changed so it no longer uses autorelease. (-[WebResourceLoad description]): Use a description in a more-standard format.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest description]): Used a description that includes the URL.
• Misc.subproj/WebError.m: (-[WebError description]): Used a description in a more-standard format.
• Misc.subproj/WebKeyValuePair.m: (-[WebKeyValuePair description]): Used a description in a more-standard format.
• Misc.subproj/WebMonitor.m: Removed a description method that did the same as what NSObject already does.

• English.lproj/Localizable.strings: Regenerated.
• English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.

WebKit:

• changed persistent dictionaries to use NSString instead of NSURL because of impact on memory footprint

Also changed WebIconDatabase code to verify what it reads from disk,
and ignore it if it can't verify the format.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:cache:]): (-[WebIconDatabase retainIconForSiteURL:]): (-[WebIconDatabase releaseIconForSiteURL:]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _hasIconForSiteURL:]): (-[WebIconDatabase _iconsForIconURLString:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forSiteURL:]): (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForSiteURL:]): (-[WebIconDatabase _releaseFutureIconForSiteURL:]): (-[WebIconDatabase _retainOriginalIconsOnDisk]): (-[WebIconDatabase _releaseOriginalIconsOnDisk]): (-[NSEnumerator _web_isAllStrings]):
• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels didStartLoadingURL:inWindow:]): (-[WebStandardPanels didStopLoadingURL:inWindow:]): (-[WebStandardPanels _didStartLoadingURL:inController:]): (-[WebStandardPanels _didStopLoadingURL:inController:]): (-[WebStandardPanels frontmostWindowLoadingURL:]):

11:08 AM Changeset in webkit [2602] by rjw

• 4 edits in trunk/WebCore

Cleanup of fix to 3083281. Never call stopAnimating from
QPixmap's destructor. With the fix it wouldn't have been
called anyway.

• kwq/KWQPixmap.mm: (QPixmap::~QPixmap):

9:58 AM Changeset in webkit [2601] by darin

• 4 edits in trunk/WebCore

• kwq/WebCoreBridge.mm: (attributedString): Remove some dead code.

9:57 AM Changeset in webkit [2600] by darin

• 7 edits in trunk/WebKit

• fixed crash on boot that Don was seeing

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem URL]): Make this work when _URLString is nil. (-[WebHistoryItem initFromDictionaryRepresentation:]): Make this work for nil URL.

• my own private war on the cString method

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): Use %@ in LOG to avoid cString. (-[WebDownloadHandler finishedLoading]): Ditto.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Ditto.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): Ditto. (-[WebFrame _setState:]): More of the same. (-[WebFrame _isLoadComplete]): Ditto.

6:56 AM Changeset in webkit [2599] by kocienda

• 4 edits in trunk/WebKit

Fix deployment build breaker: a variable was used only in a
LOG statement, causing the variable to become usused when
building with the Deployment build style.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading])

Nov 7, 2002:

11:53 PM Changeset in webkit [2598] by darin

• 4 edits in trunk/WebKit

• History.subproj/WebHistoryItem.h: Replace _URL with _URLString.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL]. (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString. (-[WebHistoryItem dealloc]): Release _URLString. (-[WebHistoryItem URL]): Make a URL from _URLString. (-[WebHistoryItem icon]): Use [self URL] instead of _URL. (-[WebHistoryItem setURL:]): Store a URL string. (-[WebHistoryItem hash]): Use the URL string's hash. (-[WebHistoryItem isEqual:]): Compare the URL strings. (-[WebHistoryItem description]): Use _URLString. (-[WebHistoryItem dictionaryRepresentation]): Use _URLString. (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to the other init functions so we have only one designated initializer. Leave the date as nil if there's no date in the dictionary instead of setting the date to 0.

11:47 PM Changeset in webkit [2597] by darin

• 4 edits in trunk/WebCore

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Add an assert in the hopes of catching bug 3084704 a little earlier.

11:43 PM Changeset in webkit [2596] by darin

• 4 edits in trunk/JavaScriptCore

• kjs/date_object.cpp: (mktimeUsingCF): Fix storage leak.

9:29 PM Changeset in webkit [2595] by mjs

• 9 edits in trunk/WebKit

WebKit:

Removed SaveAndOpenExternally policy.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading]):
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Removed all uses of SaveAndOpenExternally policy.

• BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]):
• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):

9:15 PM Changeset in webkit [2594] by cblu

• 3 edits in trunk/WebKit

WebKit:

• WebKit.pbproj/project.pbxproj:

WebBrowser:

Made Alexander responsible for opening downloads.

• BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): call +[WBPreferences shouldOpenFileWithMIMEType:] (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): no open policy
• Defaults.plist:
• DownloadProgressEntry.m: (-[DownloadProgressEntry isDiskCopyFile]): (-[DownloadProgressEntry startDiskCopyInteraction]): (-[DownloadProgressEntry openFile]): (-[DownloadProgressEntry setCompleted]):
• Preferences.subproj/WBPreferences.h:
• Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileWithMIMEType:]): moved this method here from BrowserWebController as this is now called in 2 different places

7:10 PM Changeset in webkit [2593] by mjs

• 4 edits in trunk/JavaScriptCore

• partial fix to 3073230 - JavaScript time calls do I/O by lastat()ing /etc/localtime

• kjs/date_object.cpp: (mktimeUsingCF): Implementation of mktime using CF.

6:49 PM Changeset in webkit [2592] by rjw

• 2 edits in trunk/WebKit

Commit changelog.

5:29 PM Changeset in webkit [2591] by mjs

• 3 edits in trunk/WebKit

• fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): Get the element info from the HTML view where the click originally happened, not the current document view. Add some asserts to make sure this is working.

5:14 PM Changeset in webkit [2590] by rjw

• 4 edits in trunk/WebCore

Don't stop animating unless we're the last referee. (3083281)

• kwq/KWQPixmap.mm: (QPixmap::~QPixmap):

3:50 PM Changeset in webkit [2589] by rjw

• 3 edits in trunk/WebKit

Fixed updating of status bar and activity window when
loading plugin content as main document. (3084311)

• LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):

11:29 AM Changeset in webkit [2588]

• 3 copies in tags/Alexander-31

This commit was manufactured by cvs2svn to create tag 'Alexander-31'.

11:29 AM Changeset in webkit [2587] by sheridan

• 8 edits in trunk

Alex-31 stamp

7:47 AM Changeset in webkit [2586] by mjs

• 3 edits in trunk/WebKit

• fixed 3094778 - REGRESSION: Assert on logout from schwab.com

(probably fixed it anyway - I'm flying blind on this one)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Use a nil request if the URL was nil, instead of making a request that contains a nil URL.

6:33 AM Changeset in webkit [2585] by mjs

• 14 edits in trunk/WebKit

WebKit:

Changed things so that creating a window takes a request rather
than a URL and referrer.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringEvent:]): (-[WebDataSource _triggeringEvent]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame findOrCreateFramedNamed:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Changed things so that creating a window takes a request rather
than a URL and referrer.

• BrowserWebController.m: (-[BrowserWebController createWindowWithRequest:]):

Nov 6, 2002:

10:43 PM Changeset in webkit [2584] by darin

• 4 edits in trunk/WebKit

• fixed problem where files small enough to fit entirely in the buffer (8K or less) would not be decoded

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from receivedData into here. (-[WebDownloadHandler receivedData:]): Changed to call decodeData. (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining bytes rather than writing them straight out to the data fork.

5:21 PM Changeset in webkit [2583] by rjw

• 8 edits in trunk

More work on rendering scripts. Now most complex scripts render correctly.
Working new features include:
bidi, diacriticals, cursive forms, and arabic ligatures.
Selection of text rendered in these scripts, is however, not working.
Also, line height is incorrect when renderering combined below glyphs.
ajami is, sadly, horrendously broken.

• Misc.subproj/WebUnicode.m: (glyphVariantLogical): (shapedString):
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Use our notion of unicode whitespace from lookup tables
and isspace for latin1. This is more correct than CF.
Fixed issues Dave ran into with whitespace calculations.

• kwq/KWQChar.mm: (QChar::isSpace):

5:10 PM Changeset in webkit [2582] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): made this handle WebBookmarkTypeProxy

WebBrowser:

• fixed 3092708 -- allow option for Bookmarks Toolbar as submenu of Bookmarks menu

The wording and possibly layout in Preferences will change soon, but the
behavior is now implemented as SJ specified.

• Defaults.plist:
• PreferenceKeys.h: New preference keys for the new options

• Preferences.subproj/English.lproj/BookmarkPreferences.nib: rejigger everything in the bookmarks preferences panel

• Preferences.subproj/BookmarkPreferences.h:
• Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences updateBookmarksViews]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesAddressBook:]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesRendezvous:]): (-[BookmarkPreferences toggleBookmarksMenuAndToolbarAreSame:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesBookmarksToolbar:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesRendezvous:]): (-[BookmarkPreferences initializeFromDefaults]): reworked all the code to handle the new options, including the way some options change when others are checked

• BookmarksController.h: made addressBookProxyTitle and rendezvousProxyTitle public
• BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): new method, generalized from code elsewhere (handles keyboard equivalents for toolbar items) (-[BookmarksController addMenuItemForBookmark:toMenu:]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController addFavoritesSubmenu]): new method, calls addChildrenOfBookmark:toMenu: (-[BookmarksController addSpecialBookmarkSourcesToMenu]): now handles toolbar as submenu, plus fancier logic to match new preferences (-[BookmarksController _addBookmarksToMenu]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController receivedBrowserPreferenceValueChangedNotification:]): now checks for new preferences also

• FavoriteButton.m: (-[FavoriteButton setBookmark:]): now handles WebBookmarkTypeProxy -- like folder in appearance, but not a drag target (-[FavoriteButton menu]): now handles WebBookmarkTypeProxy (by returning nil for the context menu) (-[FavoriteButton hasContentsMenu]): new method, just checks bookmark type (-[FavoriteButton _contentsMenu]): now handles WebBookmarkTypeProxy by using BookmarkSource protocol to extract contents (-[FavoriteButton mouseDown:]): check hasContentMenu instead of assuming which types have menus

• FavoritesBar.m: (-[FavoritesBar addButtonForBookmark:withLeftEdge:]): new method, extracted from _refreshButtons (-[FavoritesBar includeRendezvous]), (-[FavoritesBar includeAddressBook]): new methods, check with NSUserDefaults (-[FavoritesBar _refreshButtons]): take includeRendezvous and includeAddressBook into account; now calls addButtonForBookmark:withLeftEdge: (-[FavoritesBar refreshButtonsSoon]): new method, extracted from _favoritesChanged (-[FavoritesBar preferenceValueChanged:]): new method, call refreshButtons if the right prefs have changed (-[FavoritesBar _favoritesChanged:]): now calls refreshButtonsSoon (-[FavoritesBar initWithView:]): register for preferences value changed notifications (-[FavoritesBar dropIndexFromDraggingInfo:]): take includeRendezvous and includeAddressBook into account (-[FavoritesBar performDragOperation:]): take includeRendezvous and includeAddressBook into account

4:16 PM Changeset in webkit [2581] by darin

• 5 edits in trunk/WebKit

• fixed bug that affected BinHex-encoded files with no resource fork

• Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]): Don't decode the resource fork unless done with the data fork.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): Set the forks to nil before calling through.

3:47 PM Changeset in webkit [2580] by darin

• 4 edits in trunk/WebKit

• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Fix == 129 check that was supposed to be <= 129.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:44 PM Changeset in webkit [2579] by cblu

• 2 edits in trunk/WebKit/Downloads.subproj

WebFoundation:

Added _web_infoDictionaryForBundleAtPath. Gets info dictionary without using NSBundle.

• Misc.subproj/WebNSDictionaryExtras.h:
• Misc.subproj/WebNSDictionaryExtras.m: (+[NSDictionary _web_infoDictionaryForBundleAtPath:]):

WebBrowser:

Preliminary work for disk copy interaction.

• AppController.m: (-[AppController awakeFromNib]): tweak to GURL event call, no actual change
• Defaults.plist: don't have WebKit open disk images for us anymore, since Alex will do this.
• DiskCopyPuppetStrings.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): set handlers for disk copy events (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]): added, does nothing right now
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry diskCopyStage]): new (-[DownloadProgressEntry setDiskCopyStage:]): new (-[DownloadProgressEntry startDiskCopyInteraction]): new, check version of disk copy, open disk image (-[DownloadProgressEntry setCompleted]): call startDiskCopyInteraction

3:31 PM Changeset in webkit [2578] by darin

• 4 edits in trunk/WebKit

• Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]): Fix an off-by-one error handling repeat counts.

• WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.

3:11 PM Changeset in webkit [2577] by darin

• 8 edits
  2 adds in trunk/WebKit

• added a BinHex decoder and did a little work on the MacBinary decoder

I'm not supposed to be working on this, but I didn't feel like doing "real" work.

• Downloads.subproj/WebBinHexDecoder.h: Added.
• Downloads.subproj/WebBinHexDecoder.m: Added.
• WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.

• Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.

• Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III part that gets the script code. (-[WebMacBinaryDecoder filename]): Use the script code.

2:37 PM Changeset in webkit [2576] by mjs

• 8 edits in trunk/WebKit

WebKit:

Took URL field out of click policy - open in new window policy
will always open the request URL.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Updated for WebKit changes.

• BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):

11:26 AM Changeset in webkit [2575] by cblu

• 3 edits in trunk/WebKit

Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):

9:25 AM Changeset in webkit [2574] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Fix for this bug:

Radar 3004422 (Loader should cache misses)

I added a code to support caching HTTP 404 responses. These objects
will now get cached just like other responses, and they are subject
to the same revalidation rules as other cache objects.

To support caching the 404 for a specified period of time, I have
added an extra method to WebHTTPResourceRequest.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]):
• ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest pageNotFoundCacheLifetime]): (-[WebResourceRequest setPageNotFoundCacheLifetime:]): (-[WebHTTPResourceRequestParameters copyWithZone:]): (-[WebHTTPResourceRequestParameters isEqual:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):

WebKit:

Call new WebHTTPResourceRequest method to set the amount of time
to cache a 404 response when trying to fetch a favicon.

This change helps to fix this bug:

Radar 3004422 (Loader should cache misses)

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])

Nov 5, 2002:

8:00 PM Changeset in webkit [2573] by mjs

• 10 edits in trunk/WebKit

WebKit:

Reworked clickPolicy arguments to be closer to proposed version.

• WebKit.exp:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Adjusted for WebKit API changes.

• BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):

5:59 PM Changeset in webkit [2572] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster version of the new "lose precision" CEIL_TO_INT macro.

5:56 PM Changeset in webkit [2571] by darin

• 4 edits in trunk/WebCore

• fixed 3092722 -- assertion failed

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Removed the assertion. It wasn't needed.

5:47 PM Changeset in webkit [2570] by rjw

• 3 edits in trunk/WebKit

Fixed a couple of issues that Dave highlighted w/ his whitespace
fixes. CG sometimes introduces very small 'error' in metrics, specifically
we saw character widths of 20.0000019 that should have been 20. As a
work-around we loose precision beyond the 1000th place. Also, always
ceil spaces.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

5:25 PM Changeset in webkit [2569] by darin

• 3 edits in trunk/WebKit

• fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): We need to stop loading here. Otherwise we might do loading after closeURL, which could lead to a problem like the one above.

5:21 PM Changeset in webkit [2568] by darin

• 4 edits in trunk/WebKit

• changed our MacBinary decoding to not pay any attention to the comment

Before we would "fail to decode" if the comment was truncated, now we just
don't worry about it.

• Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code to get _commentLength and code to compute _commentEnd. (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork end rather than the comment end to see if we got enough data.

5:19 PM Changeset in webkit [2567] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: reverted generic URL icon back to the one that looks like a document until we get something from HI that SJ likes

WebBrowser:

• Resources/Images/FavoritesBar.tif:
• Resources/Images/tiny_menu.tiff: reverted Bookmarks menu and Bookmarks toolbar icons back to the previous versions until we get something from HI that SJ likes

4:27 PM Changeset in webkit [2566] by cblu

• 12 edits in trunk/WebKit

WebKit:

Fixed: 3074108 - Decode macbinary files during download

• Downloads.subproj/WebDownloadDecoder.h:
• Downloads.subproj/WebDownloadHandler.h:
• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]): (-[WebDownloadHandler closeFile]): (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler writeData:toFork:]): (-[WebDownloadHandler writeDataForkData:resourceForkData:]): (-[WebDownloadHandler dataIfDoneBufferingData:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishDecoding]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• Downloads.subproj/WebMacBinaryDecoder.h:
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder fileAttributes]): (-[WebMacBinaryDecoder filename]):
• Misc.subproj/WebKitErrors.h: added new errors
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

WebBrowser:

Fixed: 3074108 - Decode macbinary files during download

• DownloadMonitor.m: (-[DownloadMonitor identifierForInitialRequest:fromDataSource:]): (-[DownloadMonitor resource:willSendRequest:fromDataSource:]): (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): new, convenience (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry filename]): (-[DownloadProgressEntry path]): (-[DownloadProgressEntry setCompleted]):
• DownloadRow.m: (-[DownloadRow _updateStatusFields]):

11:35 AM Changeset in webkit [2565] by kocienda

• 3 edits in trunk/WebKit

Fix for this bug:

Radar 3092747 (javascript cookieEnabled property returns incorrect value)

Now, we return "true" for navigator.cookieEnabled when
"Only accept cookies from the same domain as the current page" option
is selected is user preferences.

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled])

10:51 AM Changeset in webkit [2564] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3091271 -- missing plug-in icon is on white background, not transparent.

• Resources/nullplugin.tiff: Photoshopped the white away. It's still ugly, but that's a separate bug (3091274)

WebBrowser:

Removed the text from the lock icon. Also cleaned up the
code that positions the lock icon in the window.

• BrowserWindow.m: (-[BrowserWindow adjustRightSideImageViewFrame]): new method, sets the image view's frame based on the image size and specified margins (-[BrowserWindow setUpRightSideImageView]): now calls adjustRightSideImageViewFrame (-[BrowserWindow setTitleBarRightSideImage:]): now calls adjustRightSideImageViewFrame if image has changed

• Resources/Images/Lock.tif: textless version

9:27 AM Changeset in webkit [2563] by darin

• 9 edits in trunk/WebCore

• re-fixed 3070484 -- icon rollovers are very slow on Mac OS X website

Had to roll back some of the files I changed yesterday. I had missed the
one line of useful code among much stuff we don't need.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::slotLoaderRequestStarted): (KHTMLPart::slotLoaderRequestDone):
• kwq/KWQSignal.h:
• kwq/KWQSignal.mm: (KWQSignal::call):
• kwq/KWQSignalStubs.mm: (Loader::requestDone): (Loader::requestFailed): (Loader::requestStarted):
• kwq/KWQSlot.h:
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call): Just roll back all the changes from my 3091714 check-in below, except for the bug fix itself in loader.cpp and KWQResourceLoader.mm.

9:08 AM Changeset in webkit [2562] by kocienda

• 3 edits in trunk/WebKit/Misc.subproj

The -(NSEnumeration *)keys method has never been implemented, and is unneeded.
Removing from API. This has no external impact as this class
is entirely private to WebFoundation.

• Database.subproj/WebDatabase.h:
• Database.subproj/WebDatabase.m:
• Database.subproj/WebFileDatabase.m:

3:20 AM Changeset in webkit [2561] by mjs

• 3 edits in trunk/WebKit

• fixed 3083732 - SJ: window comes out blank on samsung site

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't start loading if the URL is exactly the same as the parent URL. We may need a more stringent check, but this seems to match the tolerance of other browsers OK.

2:26 AM Changeset in webkit [2560] by mjs

• 6 edits in trunk/WebCore

• fixed 3027404 - pop-up ads not always suppressed

• khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isWindowOpenAllowed): Don't allow opening if we are in a timer callback - for reasons unexplained this will always show up as an inline script.
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Note that we're in a timer callback.

1:31 AM Changeset in webkit [2559] by mjs

• 7 edits in trunk/WebKit

WebKit:

Added request and frame to click policy callback.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

WebBrowser:

• fixed 3044620 - incorrect URL sent to the click policy handler, other problems, because it's processed early

• BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierFlags:request:inFrame:]): Look at request URL, not element URL.

Nov 4, 2002:

6:00 PM Changeset in webkit [2558] by rjw

• 12 edits in trunk

i Changes to support cursive letter forms. It works, but I've

disabled it for now. It's buggy and needs cleanup.
Arabic now renders correctly except for ligature substitution.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeIsMark): (getShape): (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (shapedString):
• Misc.subproj/WebUnicodeTables.m:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
• WebKitPrefix.h:

Changes to support cursive letter forms.

• kwq/KWQChar.mm:
• kwq/WebCoreUnicode.h:

Updated to lastest API.

• SimpleViewer/DocumentController.m: (-[ResourceLoadDelegate initWithDocumentController:]): (-[ResourceLoadDelegate updateStatus]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

5:25 PM Changeset in webkit [2557] by darin

• 11 edits in trunk/WebCore

• fixed 3091714 -- reproducible assert cachedObject->response in KWQCheckCacheObjectStatus

• khtml/misc/loader.cpp: (Loader::slotFinished): For APPLE_CHANGES, don't finish the load if it's an error.

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): Shared code for the three following methods. (-[KWQResourceLoader cancel]): Use setError(1) again instead of just keeping the load around forever. (-[KWQResourceLoader reportError]): Ditto. (-[KWQResourceLoader finish]): Use finishJobAndHandle to share code with the two above.

• khtml/khtml_part.cpp: (KHTMLPart::init): Put the slotLoaderRequestStarted and slotLoaderRequestDone connect lines inside ifdefs. (KHTMLPart::~KHTMLPart): Same for disconnect.

• kwq/KWQSignal.h: Remove code for the DocLoader signals.
• kwq/KWQSignal.mm: (KWQSignal::call): Ditto.
• kwq/KWQSignalStubs.mm: (Loader::requestDone): Ditto. (Loader::requestFailed): Ditto. (Loader::requestStarted): Ditto.
• kwq/KWQSlot.h: Ditto.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Ditto. (KWQSlot::call): Ditto.

5:10 PM Changeset in webkit [2556] by mjs

• 7 edits in trunk/WebCore

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::createDummyDocument): (KWQKHTMLPart::setCurrentEvent):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):

5:02 PM Changeset in webkit [2555] by mjs

• 8 edits in trunk/WebKit

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseUp:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m:

4:04 PM Changeset in webkit [2554] by cblu

• 3 edits in trunk/WebKit

Fixed - 3091658: REGRESSION: cmd-left for back doesn't work in plain-text viewer

We now pass text field key events to the next responder which would be WebView in this case.

• WebView.subproj/WebTextView.m: (-[WebTextView keyDown:]): (-[WebTextView keyUp:]):

3:08 PM Changeset in webkit [2553] by darin

• 15 edits in trunk/WebKit

• fixed 3090257 -- "leak the world" using the Wallace and Gromit "console"

• Plugins.subproj/WebNetscapePluginStream.m: Update for changes to the base delegate. (-[WebNetscapePluginStream start]): Use loadWithRequest:. (-[WebNetscapePluginStream stop]): Call cancel instead of just canceling the handle directly. This fixes the world leak. (-[WebNetscapePluginStream cancel]): Do some of the work that was formerly in "stop".

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Call the "stop loading URL" whenever we cancel I/O, so we don't leak the world. (-[WebMainResourceClient handle:didReceiveResponse:]): Ditto.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _finishedLoadingResourceFromDataSource:]): Fix a typo in the word "finished".

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Tweak. (-[WebBaseResourceHandleDelegate cancel]): Tweak.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels didStartLoadingURL:inWindow:]): Add assertions. (-[WebStandardPanels didStopLoadingURL:inWindow:]): Ditto. (-[WebStandardPanels _didStartLoadingURL:inController:]): Ditto. (-[WebStandardPanels _didStopLoadingURL:inController:]): Ditto.

2:52 PM Changeset in webkit [2552] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginDatabase.m

Modified pluginForKey:withEnumeratorSelector: such that we now
enumerate all plugins that match the given key before we return
a plugin. This fixes a bug in which we would sometimes return
the wrong plugin (according to our preferences) because we did
not examine all of the available plugins before making our choice.

With this change, Alexander now behaves correctly when we have
multiple Java plugins in the plugins folder (as we will on user
systems in the field).

10:58 AM Changeset in webkit [2551] by darin

• 6 edits in trunk/WebKit

• Downloads.subproj/WebMacBinaryDecoder.h: Removed many unneeded fields.
• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added comments. Changed maximum filename length to 63 as the format supports, rather than the 31 that's based on historical HFS limitations. Fix endian dependency in CRC check. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Simplified this, and removed the state machine and the accumulator. Also added some asserts. Fixed endian dependency in the code to extract the header. (-[WebMacBinaryDecoder finishDecoding]): New simpler check now that we don't have a _streamComplete boolean. (-[WebMacBinaryDecoder fileAttributes]): Rewrote to take advantage of the above changes, and also to use kCFAbsoluteTimeIntervalSince1904 rather than parsing a date string.

• Downloads.subproj/crc16.h: Tweaks.
• Downloads.subproj/crc16.m: Tweaks.

10:27 AM Changeset in webkit [2550] by darin

• 3 edits in trunk/WebKit

WebKit:

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): Replaced a useless call to stopAnimation with a couple of asserts.

WebBrowser:

• DownloadRow.m: (-[DownloadRow dealloc]): Replaced a useless timer invalidate with an assert.

8:30 AM Changeset in webkit [2549] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: new "generic URL" icon from HI -- this one looks like a red ribbon (!)

WebBrowser:

new images from Steve Lemay

• Resources/Images/MultipleBookmarks.tif: Added. This one will be used when dragging multiple bookmarks, but isn't yet.

• Resources/Images/AddLink.tif:
• Resources/Images/AddLinkDisabled.tif:
• Resources/Images/AddLinkPressed.tif:
• Resources/Images/Back.tif:
• Resources/Images/BackDisabled.tif:
• Resources/Images/BackPressed.tif:
• Resources/Images/FavoritesBar.tif:
• Resources/Images/FavoritesFolderArrow.tif:
• Resources/Images/FontBigger.tif:
• Resources/Images/FontBiggerDisabled.tif:
• Resources/Images/FontBiggerPressed.tif:
• Resources/Images/FontSmaller.tif:
• Resources/Images/FontSmallerDisabled.tif:
• Resources/Images/FontSmallerPressed.tif:
• Resources/Images/Forward.tif:
• Resources/Images/ForwardDisabled.tif:
• Resources/Images/ForwardPressed.tif:
• Resources/Images/NewFolder.tif:
• Resources/Images/NewFolder_Pressed.tif:
• Resources/Images/Reload.tif:
• Resources/Images/ReloadDisabled.tif:
• Resources/Images/ReloadPressed.tif:
• Resources/Images/Stop.tif:
• Resources/Images/StopDisabled.tif:
• Resources/Images/StopPressed.tif:
• Resources/Images/tiny_menu.tiff: new versions of these existing images

• English.lproj/Browser.nib: resized New Folder buttons

• WebBrowser.pbproj/project.pbxproj: updated for new file

8:24 AM Changeset in webkit [2548] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginController.m

(1) Modified destroyAllPlugins to remove the plugin's view from the browser's view hierarchy prior to calling the plugins' pluginDestroy methods.
(2) Modified showURL:inFrame: such that arg 'target' may be 'nil'.

Nov 3, 2002:

11:49 PM Changeset in webkit [2547] by darin

• 4 edits in trunk/WebKit

WebKit:

• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: Not MyCompanyName, but rather Apple Computer.

WebBrowser:

• DownloadProgressEntry.m:
• DownloadRow.h:
• DownloadRow.m:
• DownloadViewController.h:
• DownloadViewController.m:
• DownloadWindowController.h:
• DownloadWindowController.m:
• ServicesProvider.h:
• ServicesProvider.m: Not MyCompanyName, but rather Apple Computer.

11:05 PM Changeset in webkit [2546] by darin

• 5 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredentialPrivate dealloc]): Check for NULL before calling CFRelease, since our dealloc function can be called even before our init function runs if a base class decides to do the "[self release]; return nil;" thing in its init function.

• CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServerPrivate dealloc]): Remove call to invalidate, since, as Trey reminded us, it's pointless to invalidate a timer that retains us in our dealloc function.

WebKit:

• Plugins.subproj/WebPlugin.h: Fix comment.

• Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]): Fix leak by calling [super dealloc].

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the timer invalidate since, as Trey pointed out, it's pointless to invalidate a timer in dealloc if it's retaining this object while valid.

WebBrowser:

• DiskCopyPuppetStrings.h: Remove bogus Log section. Fix header guard that was broken.

• DownloadRow.m: (-[DownloadRow dealloc]): Fix leak by calling [super dealloc].
• DownloadViewController.m: (-[DownloadViewController dealloc]): Ditto.

1:18 PM Changeset in webkit [2545] by cblu

• 4 edits
  4 adds in trunk/WebKit

WebKit:

• Added MacBinary decoding code. Not yet used.

• Downloads.subproj/WebMacBinaryDecoder.h: Added.
• Downloads.subproj/WebMacBinaryDecoder.m: Added. (+[WebMacBinaryDecoder canDecodeHeaderData:]): (-[WebMacBinaryDecoder init]): (-[WebMacBinaryDecoder dealloc]): (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder finishDecoding]): (-[WebMacBinaryDecoder fileAttributes]):
• Downloads.subproj/crc16.h: Added.
• Downloads.subproj/crc16.m: Added. (CRC16):
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage isLoaded]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

• Added DiskCopy interaction code. Not yet used.
• Added Chuck's table view hacks to get NSViews in a TableView. Not yet used.

• DiskCopyPuppetStrings.h: Added.
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): (-[DownloadMonitor removeEntry:]): (-[DownloadMonitor _removeExpiredEntries]): (-[DownloadMonitor resource:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resource:didFailLoadingWithError:fromDataSource:]):
• ViewCell.h: Added.
• ViewCell.m: Added. (RectCenteredInRect): (+[ViewCell needsToRemainInViewHierarchy]): (-[ViewCell init]): (-[ViewCell copyWithZone:]): (-[ViewCell dealloc]): (-[ViewCell instantiateView]): (-[ViewCell setObjectValue:]): (-[ViewCell objectValue]): (-[ViewCell removeViewFromSuperview]): (-[ViewCell setView:]): (-[ViewCell view]): (-[ViewCell setViewFrame:inCellFrame:inView:]): (-[ViewCell drawWithFrame:inView:]): (-[ViewCell trackMouse:inRect:ofView:]): (-[ViewCell editWithFrame:inView:editor:delegate:event:]):
• ViewCellTableView.h: Added.
• ViewCellTableView.m: Added. (+[ViewCellTableColumn newViewCell]): (-[ViewCellTableColumn initWithIdentifier:]): (-[ViewCellTableColumn initWithCoder:]): (-[ViewCellTableColumn dealloc]): (-[ViewCellTableColumn cells]): (-[ViewCellTableColumn dataCellForRow:]): (-[ViewCellTableColumn removeRows:]): (-[ViewCellTableColumn appendRows:]): (-[ViewCellTableColumn noteNumberOfTableRowsChanged:]): (-[ViewCellTableColumn willRemoveFromTableView:]): (-[NSTableColumn noteNumberOfTableRowsChanged:]): (-[NSTableColumn willRemoveFromTableView:]): (-[ViewCellTableView replaceHeaderView]): (-[ViewCellTableView workaroundReorderResizeProblem]): (-[ViewCellTableView didReorderOrResizeNotification:]): (-[ViewCellTableView initWithFrame:]): (-[ViewCellTableView initWithCoder:]): (-[ViewCellTableView dealloc]): (-[ViewCellTableView noteNumberOfRowsChanged]): (-[ViewCellTableView reloadData]): (-[ViewCellTableView removeTableColumn:]): (-[ViewCellTableView acceptsFirstResponder]): (-[ViewCellTableView needsPanelToBecomeKey]):
• WebBrowser.pbproj/project.pbxproj:

12:50 PM Changeset in webkit [2544] by darin

• 3 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add printf to the list of functions to ignore when finding localizable strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes both to the code here and to the extract script.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Remove some now-unneeded exceptions for strings that don't appear in our code any more.

• English.lproj/Localizable.strings: Re-generated. It appears that John removed two more localizable strings after he generated it. (I had to check because last time I did this I clobbered John's change, and I didn't want to do that again.)

12:41 PM Changeset in webkit [2543] by darin

• 9 edits in trunk

WebCore:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• kwq/WebCoreResourceLoader.h: Add reportError, distinct from cancel and finish.
• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Set the error boolean on the job and then call through to [finish].

WebKit:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Call the new reportError instead of cancel. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

12:20 PM Changeset in webkit [2542] by darin

• 4 edits in trunk/WebCore

• fixed 3091275 -- can't type into Answer field in RealOne Player order form

• khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Treat 0 as max (1024) as other browsers do. (RenderFileButton::updateFromElement): Ditto, although this is in !APPLE_CHANGES code that we don't use in WebCore.

Nov 2, 2002:

2:00 PM Changeset in webkit [2541] by darin

• 3 edits in trunk/WebKit

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Do the previous fix one better by using _web_hostWithPort.

1:55 PM Changeset in webkit [2540] by darin

• 3 edits in trunk/WebKit

• fixed bug where the address of an NSNumber object would be used for the port number

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Call intValue on the object returned from [NSURL port].

Nov 1, 2002:

10:46 PM Changeset in webkit [2539] by darin

• 3 edits in trunk/WebKit

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Fixed uninitialized variable problem.

6:16 PM Changeset in webkit [2538] by darin

• 5 edits in trunk/WebCore

• applied the same "subclass responsibility" pattern here as in some of the other WebCore classes

• kwq/WebCoreImageRendererFactory.h: Move the subclass responsibility into a protocol.
• kwq/WebCoreImageRendererFactory.m: Remove now-unneeded stubs.

6:12 PM Changeset in webkit [2537] by darin

• 9 edits in trunk/WebKit

• fixed 3090239 -- crash on window close

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Nil out the bridge and release it so we don't close the URL twice.

• fixed 3058598 -- animated gif animates repeatedly in Alex, but only once in other browsers

• WebCoreSupport.subproj/WebImageRenderer.h: Added fields used by bug workaround.
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Helper method for bug workaround. (-[WebImageRenderer checkDataForGIFExtensionSignature:]): Checks incoming data for the GIF extension signatures. (-[WebImageRenderer initWithData:]): Override to call checkDataForGIFExtensionSignature. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Call checkDataForGIFExtensionSignature. (-[WebImageRenderer repetitionCount]): Return 1 if we were going to return 0, but we didn't see a GIF extension signature. This workaround can be removed once we require a system new enough to have the bug fix for bug 3090341. (-[WebImageRenderer nextFrame:]): Stop on last frame, don't wrap around to first.

• WebCoreSupport.subproj/WebImageRendererFactory.h: Update for changes to WebCore.
• WebCoreSupport.subproj/WebImageRendererFactory.m: Tweaks.

• WebView.subproj/WebImageRepresentation.m: Update imports.
• WebView.subproj/WebImageView.m: Update imports.

5:16 PM Changeset in webkit [2536] by rjw

• 10 edits in trunk

i Implemented rendering of diacriticals.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeDigitValue): (_unicodeCategory): (_unicodeDirection): (_unicodeJoining): (_unicodeDecompositionTag): (_unicodeMirrored): (_unicodeCombiningClass): (_unicodeLower): (_unicodeUpper):
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

Removed old implementation.

• kwq/KWQChar.mm: (QChar::direction):

Renamed JoiningCenter -> JoiningCausing.

• kwq/WebCoreUnicode.h:

5:10 PM Changeset in webkit [2535] by darin

• 7 edits in trunk

JavaScriptCore:

• kjs/object.cpp: Make the same change Maciej just did, but to the other constructor right next to the one he changed.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

4:28 PM Changeset in webkit [2534] by darin

• 8 edits in trunk/WebCore

• fixed 3062598 -- meta refresh of 0.1s fails

KHTML was using an integer for the delay.

• khtml/khtml_part.h: Make scheduleRedirection take a double.
• khtml/khtmlpart_p.h: Make m_delayRedirect be a double.
• khtml/khtml_part.cpp: (KHTMLPart::slotData): Use a double when parsing meta refresh. (KHTMLPart::checkCompleted): Cast to int when passing to timer start. (KHTMLPart::scheduleRedirection): Cast to int when passing to timer start; also check for absurd values and do nothing. (KHTMLPart::slotParentCompleted): Cast to int when passing to timer start.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Use a double when parsing meta refresh.

• kwq/KWQKDebug.h: Add overloads for unsigned int and double to keep us compiling now that we use a double in one place.

4:13 PM Changeset in webkit [2533] by cblu

• 9 edits in trunk/WebKit

WebKit:

Check that the plug-in is loaded before calling it.

• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setPluginPointer:]): (-[WebBaseNetscapePluginStream setResponse:]): (-[WebBaseNetscapePluginStream receivedData:]): (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isLoaded]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage isLoaded]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

WebBrowser:

Use the display name of the dataSource not the document when reporting plug-in errors.

• LoadProgressMonitor.m: (-[LoadProgressMonitor pluginFailedWithError:dataSource:]):

3:17 PM Changeset in webkit [2532] by cblu

• 16 edits
  2 adds in trunk/WebKit

WebFoundation:

• Misc.subproj/WebError.m:

WebKit:

• Moved plug-in error handling to WebResourceLoadDelegate
• Report plug-in load failure, java load failure, and plug-in not found errors.
• Added WebPluginError, subclass of WebError.
• Attempted fix: 3090675 - Standalone WMP (Window Media Player) content crashes Alexander

• English.lproj/Localizable.strings:
• Misc.subproj/WebKitErrors.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): don't send event to null function
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): report plug-in load failure
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: take a WebPluginError (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]):
• Plugins.subproj/WebPluginError.h: Added.
• Plugins.subproj/WebPluginError.m: Added. (-[WebPluginErrorPrivate dealloc]): (-[WebPluginError dealloc]): (-[WebPluginError pluginPageURL]): (-[WebPluginError pluginName]): (-[WebPluginError MIMEType]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): report plug-in load failure (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): report plug-in load failure
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate pluginFailedWithError:dataSource:]): added, does nothing
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebView.m: (+[WebView initialize]): added new error strings

WebBrowser:

• Moved plug-in error handling to WebResourceLoadDelegate

• BrowserWebController.m:
• English.lproj/Localizable.strings:
• LoadProgressMonitor.m: (-[LoadProgressMonitor pluginNotFoundSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): display special sheets for new errors.

3:00 PM Changeset in webkit [2531] by darin

• 4 edits in trunk/WebCore

• fixed 3090249 -- random crash on page load
• fixed 3090286 -- assert _job in KWQResourceLoader cancel

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader cancel]): This function needs to handle the case where the load is already cancelled. I think this also caused Avie's crash.

2:09 PM Changeset in webkit [2530] by sullivan

• 5 edits in trunk/WebKit

WebKit:

• some weaning of WebBookmark API from WebBookmarkGroup

• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): set group to nil instead of asserting that it's non-nil

• Bookmarks.subproj/WebBookmarkGroup.h: removed obsolete ivar _bookmarksByID
• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup initWithFile:]): removed obsolete ivar _bookmarksByID (-[WebBookmarkGroup dealloc]): removed obsolete ivar _bookmarksByID (-[WebBookmarkGroup removeBookmark:]): removed this unnecessary method; callers need to use [[bookmark parent] removeChild:bookmark] instead

WebBrowser:

• fixed bug Darin found in my recent checkin that caused rearranging bookmarks in toolbar to fail an assertion in [WebBookmarkGroup removeBookmark:]
• fixed a leak I found in the process (bookmark rearranged in toolbar would leak)

• BookmarksController.m: (-[BookmarksController updateBookmarkSources]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• BookmarksViewController.m: (-[BookmarksViewController removeBookmarks:]), (-[BookmarksViewController redoRemoveBookmarks:]), (-[BookmarksViewController undoNewBookmark:]), (-[BookmarksViewController moveBookmarks:toNewFolder:]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• BrowserWebBookmarkExtras.m: (-[WebBookmark deleteWithUndo]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• FavoriteButton.m: (-[FavoriteButton draggedImage:endedAt:operation:]): don't use undoable delete in the drag-to-rearrange case; added FIXME explaining why

• FavoritesBar.m: (-[FavoritesBar deleteFavoritesWithURLsMatchingBookmarks:]), (-[FavoritesBar titleChangeSheetDidEnd:returnCode:contextInfo:]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark] (-[FavoritesBar performDragOperation:]): autorelease the copy of the bookmark in the dragged FavoriteButton

12:45 PM Changeset in webkit [2529] by trey

• 7 edits in trunk/WebKit

Moved involved code for loading URLs from WebBridge up to WebFrame, with a little
consolidation along the way. I need to get all this stuff in one place in prep
for doing back-forward properly with frames. There should be no change in
functionality as a result of these changes.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:]): (-[WebBridge postWithURL:data:contentType:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Much of the guts of these is moved to WebFramePrivate.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setIsClientRedirect:]): (-[WebDataSource _isClientRedirect]): Keep state of whether we're processing a redirect in DataSource. I had previously to do this with a loadType, but that failed because cliRedir is orthogonal.
• WebView.subproj/WebFramePrivate.h: WebFrameLoadTypeClientRedirect is gone.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Initialize loadType explicitly. (-[WebFrame _transitionToCommitted]): Test [dataSource _isClientRedirect] instead of looking at loadType. (-[WebFrame _isLoadComplete]): Nuke WebFrameLoadTypeClientRedirect (-[WebFrame _goToItem:withFrameLoadType:]): Nuke WebFrameLoadTypeClientRedirect. (-[WebFrame _loadRequest:]): Helper method moved from WebBridge. (-[WebFrame _loadURL:loadType:clientRedirect:]): Core impl moved up from WebBridge. (-[WebFrame _postWithURL:data:contentType:]): Core impl moved up from WebBridge.

11:51 AM Changeset in webkit [2528] by darin

• 4 edits in trunk/WebKit

• implemented loop counts

• WebCoreSupport.subproj/WebImageRenderer.h: Added repetitionsComplete field.
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer repetitionCount]): Get NSImageLoopCount. (-[WebImageRenderer nextFrame:]): Check repetitionCount and stop once we hit it.

Oct 31, 2002:

5:15 PM Changeset in webkit [2527] by darin

• 9 edits in trunk/WebCore

• fixed huge leak when doing page load test

• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_binding.cpp: Remove ScriptInterpreter::mark(). We don't want to mark the elements of m_domObjects, because we don't want to keep them around the entire lifetime of the interpreter. This is fine because we already have forgetDOMObject(), which takes care of when they are deallocated.

• khtml/ecma/kjs_dom.cpp:
• khtml/ecma/kjs_dom.h:
• khtml/ecma/kjs_html.cpp:
• khtml/ecma/kjs_html.h: Changed lots of parameters to pass by const reference for a bit of a code size and performance gain.

5:10 PM Changeset in webkit [2526] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebFrame.m: (-[WebFrame setController:]): Add an assert, hoping to catch a reported bug earlier or disprove one theory.

2:59 PM Changeset in webkit [2525] by trey

• 10 edits in trunk/WebKit

Added API to support 3072505 - SnapBack for user-entered page address
Refixed 3041616 - Extra page added in back button history
Previous fix was stepped on by a later checkin. Re-established that fix, then
went on to make sure we have the final URL and title in the BF item in the
case of a client redirect. Also handles redirects that happen within frames.
Fixed 3078560 - div added to "back" list

• History.subproj/WebBackForwardList.h:
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList containsEntry:]): Added new API for 3072505.
• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): (-[WebBridge reportClientRedirectCancelled]): (-[WebBridge loadURL:reload:]): Added logging. Renamed flag. Establish the right loadtype and set BF items from the old dataSource onto the new dataSource in the case of a client redirect.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Add logging. (-[WebDataSource _addBackForwardItem:]): (-[WebDataSource _addBackForwardItems:]): (-[WebDataSource _backForwardItems]): New setters/getters to support setting up the new dataSource of a client redirect.
• WebView.subproj/WebFramePrivate.h: New loadType WebFrameLoadTypeClientRedirect.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Update the URL in the BF list in the client redirect case. (-[WebFrame _isLoadComplete]): NOP case for WebFrameLoadTypeClientRedirect (-[WebFrame _goToItem:withFrameLoadType:]): ASSERT_NOT_REACHED case for WebFrameLoadTypeClientRedirect

2:15 PM Changeset in webkit [2524] by rjw

• 9 edits in trunk

Corrected extern definitions of lookup tables.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeDirection):
• WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer initialize]):

Turned on use of lookup tables.

• kwq/KWQChar.mm: (QChar::direction): (QChar::mirrored): (QChar::mirroredChar):

12:27 PM Changeset in webkit [2523] by mjs

• 4 edits in trunk/JavaScriptCore

• fixed 3082660 - REGRESSION: one ListImp leaks opening/closing nearly empty web page

• kjs/object.cpp: Set gc allowed on freshly created ListImp, since there is no List wrapper for it.

11:12 AM Changeset in webkit [2522] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/grammar.y: Fix the APPLE_CHANGES thing here too.
• kjs/grammar.cpp: Regenerated this file.

10:43 AM Changeset in webkit [2521] by mjs

• 5 edits in trunk/WebCore

• fixed 3075803 - yahoo customize layout - delete, ordering of items doesn't work

• khtml/html/html_formimpl.h:
• khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::recalcStyle): New method to insure the select element updates if the contents of the option subelements are changed.

10:05 AM Changeset in webkit [2520]

• 3 copies in tags/Alexander-30

This commit was manufactured by cvs2svn to create tag 'Alexander-30'.

10:05 AM Changeset in webkit [2519] by sheridan

• 9 edits in trunk

Alex-30 version markers

Oct 30, 2002:

9:26 PM Changeset in webkit [2518] by mjs

• 1 edit in trunk/WebCore/khtml/rendering/render_form.cpp

Revert accidentally committed change.

9:20 PM Changeset in webkit [2517] by mjs

• 5 edits in trunk/WebCore

• fixed 3049853 - Javascript: setInterval incorrectly acts as single shot

• kwq/KWQObject.mm: (QObject::startTimer): Set a recurring timer instead of single-shot, to match QObject semantics.

6:42 PM Changeset in webkit [2516] by rjw

• 1 edit in trunk/WebKit/Misc.subproj/WebUnicode.m

Fixed stupid compile problem.

6:23 PM Changeset in webkit [2515] by rjw

• 12 edits
  5 adds in trunk

More work on bidi and contextual forms.
Table lookup code for unicode characters attributes.

• Misc.subproj/WebUnicode.h: Added.
• Misc.subproj/WebUnicode.m: Added. (_unicodeDigitValue): (_unicodeCategory): (_unicodeDirection): (_unicodeJoining): (_unicodeDecompositionTag): (_unicodeMirrored): (_unicodeMirroredChar): (_unicodeCombiningClass): (_unicodeLower): (_unicodeUpper): (WebKitInitializeUnicode):
• Misc.subproj/WebUnicodeTables.m: Added.
• WebKit.pbproj/project.pbxproj:

Additional logging parameter.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:

More work on bidi and contextual forms.
Table lookup code is up in WebKit. Function
pointers are used to isolate WebCore from private
implementation in WebKit. Needs to be fast, so
the usual ObjC abstraction won't work.

• WebCore.exp:
• WebCore.pbproj/project.pbxproj:
• kwq/KWQChar.mm: (QChar::direction):
• kwq/KWQString.h:
• kwq/WebCoreUnicode.cpp: Added.
• kwq/WebCoreUnicode.h: Added.

6:15 PM Changeset in webkit [2514] by mjs

• 7 edits in trunk/WebKit

WebKit:

Pass WebResourceRequest rather than just NSURL to URL policy
delegate method.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]): (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]):

WebBrowser:

Adjust for WebKit API change.

• BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]):
• BrowserWebController.m: (-[BrowserWebController URLPolicyForRequest:inFrame:]):

2:50 PM Changeset in webkit [2513] by darin

• 4 edits in trunk/WebCore

• fixed crash when you open an empty window and just hit tab, tab, tab

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Check for nil.

2:19 PM Changeset in webkit [2512] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

• English.lproj/Localizable.strings: Regenerated this file.

12:15 PM Changeset in webkit [2511] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3073230 -- Alex is doing file I/O when executing JavaScript by asking for localtime

I fixed this by using Core Foundation time functions instead.

• kjs/date_object.cpp: (tmUsingCF): Function that uses Core Foundation to get the time and then puts it into a tm struct. (gmtimeUsingCF): Function used instead of gmtime (used a macro to make the substitution). (localtimeUsingCF): Function used instead of localtime (used a macro to make the substitution).

11:34 AM Changeset in webkit [2510] by cblu

• 3 edits in trunk/WebKit

Fixed: 3088122 - Assertion failure/crash closing window with QuickTime streaming in

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setMainDocumentError:]): call receivedError on the representation.

11:17 AM Changeset in webkit [2509] by darin

• 4 edits in trunk/WebKit

• fixed memory leaks in plugin package creation code

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): Rearrange this code, and make sure that it does a [self release] if it's going to return nil instead of self. (-[WebNetscapePluginPackage unload]): Set bundle to 0 when we release it. (-[WebNetscapePluginPackage dealloc]): Release the bundle if it's not 0.

• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Rearrange this code, and make sure that it does a [self release] if it's going to return nil instead of self.

9:51 AM Changeset in webkit [2508] by darin

• 7 edits
  2 adds in trunk/WebCore

• fixed 3083982 -- Logging into AOL gives null view, crash

I fixed the crash part. Not the "gives null view" part.
The key was to disentangle the references and lifetimes of the transfer job class,
and the resource loader object that KWQ uses to connect it with WebKit.

• kwq/KWQKJobClasses.h: Change the job to keep a loader reference, not a handle reference. The job needs to inform the loader when it's being deallocated.
• kwq/KWQKJobClasses.mm: Use jobWillBeDeallocated instead of cancel when the job is deallocated.

• kwq/KWQLoader.mm: (KWQServeRequest): Use KWQResourceLoader, now with a home in a separate file.

• kwq/KWQResourceLoader.h: Added.
• kwq/KWQResourceLoader.mm: Added.
• WebCore.pbproj/project.pbxproj: Added KWQResourceLoader files.

8:19 AM Changeset in webkit [2507] by darin

• 15 edits in trunk

WebCore:

• fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

The key is to get args.reload passed through to the bridge.

• kwq/WebCoreBridge.h: Add reload parameter to loadURL:.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Pass NO for reload. (KWQKHTMLPart::openURLRequest): Pass args.reload for reload. (KWQKHTMLPart::urlSelected): Pass args.reload for reload. (KWQKHTMLPart::submitForm): Pass args.reload for reload.

• fixed a memory problem with the use of NSBrowser in KWQListBox
• fixed 2863040 -- multiple default items in select list not selected

Switched to use NSTableView instead of NSBrowser. This should also create
a measurable speedup due to other changes to this class.

• kwq/KWQListBox.h: Remove firstItem(), the insertItem() that takes a QListBoxItem parameter, and deleteItems(). Add _items, _width, and _widthGood. Removed _head. Removed the QListBoxItem and QListBoxText classes.
• kwq/KWQListBox.mm: (QListBox::QListBox): Create a KWQListBoxScrollView and put an NSTableView inside it. Also create an NSMutableArray to hold the items. (QListBox::~QListBox): Disconnect the table view from the delegate before releasing it. Also release the items array. (QListBox::count): Return the array count. (QListBox::clear): Do a reloadData here instead of loadColumnZero. (QListBox::setSelectionMode): Update for table view. (QListBox::insertItem): Update for table view. (QListBox::insertGroupLabel): Just calls insertItem for now. (QListBox::endBatchInsert): Update for table view. (QListBox::setSelected): Update for table view, including support for multiple selection. (QListBox::isSelected): Update for table view. (QListBox::sizeForNumberOfLines): Use the table view cell for width, and cache it so we don't have to measure all the strings over and over again. (-[KWQListBoxScrollView setFrameSize:]): Resize the table view column whenever the entire scroll view is resized. (-[KWQListBoxTableViewDelegate initWithListBox:]): Store box pointer and pointer to items array. (-[KWQListBoxTableViewDelegate numberOfRowsInTableView:]): Return count. (-[KWQListBoxTableViewDelegate tableView:objectValueForTableColumn:row:]): Get the data from the items array. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Call both the selection-changed signal and the clicked signal.

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Get rid of the one place here that gets at a list box item by calling a KWQ function insertGroupLabel instead of making a QListBoxText. Also call beginBatchInsert() before clear() for a slight additional speed boost.

• fixed 3067572 -- javascript: URLs typed into page address field or bookmarks don't work in empty window

We needed a document for DOM, so we make a dummy one. This works for an empty
window, and also for a window with non-HTML content.

• kwq/KWQKHTMLPart.h: Added createDummyDocument().
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createDummyDocument): Create an empty DOM document if there isn't one already.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Call the new createDummyDocument() instead of checking and doing nothing if there is no document present when this is called.

• other stuff

• kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]): Removed a stray printf.

• kwq/KWQTextArea.mm: Tweaked code a little.

WebKit:

• fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

The key is to respect the new reload: parameter from the bridge.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:]): Don't ever treat a reload as a redirect. Set the cache policy to WebRequestCachePolicyLoadFromOrigin if it's a reload.

• fixed 3087214 -- REGRESSION: <WebKit/WebKit.h> contains #import of non-existent header

• Misc.subproj/WebKit.h: Removed import of WebControllerSets.h, which is private.

1:43 AM Changeset in webkit [2506] by mjs

• 10 edits in trunk/WebKit

WebKit:

Another step towards the policy API change - add request argument
to file URL policy and remove isDirectory argument.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

WebBrowser:

Adjust for API change.

• BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]):

Oct 29, 2002:

11:58 PM Changeset in webkit [2505] by mjs

• 7 edits in trunk/WebKit

WebKit:

First step towards policy API change. Pass request instead of URL
to content policy delegate method.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

First step towards policy API change. Pass request instead of URL
to content policy delegate method.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):

11:55 PM Changeset in webkit [2504] by mjs

• 6 edits in trunk/WebKit

• fixed 3087548 - REGRESSION: two windows open for netflix confirmation

• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _findFrameInThisWindowNamed:]): Added this function back, and added check for top-level frame name. (-[WebController _findFrameNamed:]): Use _findFrameInThisWindowNamed: to make sure top-level frame names get checked.

8:50 PM Changeset in webkit [2503] by cblu

• 3 edits
  6 adds
  2 deletes in trunk/WebKit

Created Downloads.subproj to hold the to-be-implemented download decoders.

• Downloads.subproj/WebDownloadDecoder.h: Added.
• Downloads.subproj/WebDownloadHandler.h: Added.
• Downloads.subproj/WebDownloadHandler.m: Added. (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler errorWithCode:]): (-[WebDownloadHandler receivedResponse:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• Misc.subproj/WebDownloadHandler.h: Removed.
• Misc.subproj/WebDownloadHandler.m: Removed.
• WebKit.pbproj/project.pbxproj:

Oct 28, 2002:

11:05 PM Changeset in webkit [2502] by darin

• 4 edits in trunk/WebCore

• khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Update so it handles nil for the view.

10:51 PM Changeset in webkit [2501] by darin

• 15 edits in trunk/WebCore

• fixed 3070484 -- icon rollovers are very slow on Mac OS X website

The problem was simply that the part didn't know it was complete.
To let it know, I hooked up some loader signals, and now it works.

• khtml/khtml_part.cpp: (KHTMLPart::init): Create the KWQKHTMLPart a little earlier so we have a chance to initialize the cache before it's used. (KHTMLPart::slotLoaderRequestStarted): Take this out of ifdefs. (KHTMLPart::slotLoaderRequestDone): Ditto.

• khtml/misc/loader.h: Add a KWQLoader pointer to the loader.
• khtml/misc/loader.cpp: (Loader::Loader): Create a KWQLoader; (Loader::~Loader): Destroy the KWQLoader. (Loader::load): Take out ifdefs around code that emits requestStarted.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Call Cache::init().

• kwq/KWQLoader.h: Add a class KWQLoader, with three signals in it.
• kwq/KWQLoader.mm: (KWQLoader::KWQLoader): Initialize the three signals.

• kwq/KWQSignalStubs.mm: (Loader::requestDone): Emit the signal using KWQLoader. (Loader::requestFailed): Ditto. (Loader::requestStarted): Ditto.

• kwq/KWQSlot.h: Add an overload for slots with loader and cached object parameters so we can handle the new slots.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Added slotLoaderRequestDone and slotLoaderRequestStarted. (KWQSlot::call): Added the new overload to handle those two signals.

• kwq/KWQSignal.h: Add an overload for signals with loader and cached object parameters so we can handle the new signals.
• kwq/KWQSignal.mm: (KWQSignal::call): Ditto.

• kwq/KWQObject.mm: (QObject::connect): Remove the special casing that prevents complaints about slotLoaderRequestDone and slotLoaderRequestStarted, since we support those now.

9:29 PM Changeset in webkit [2500] by darin

• 3 edits in trunk/WebKit

• fixed crash I just introduced

• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]): Remove the release call here. When I added the autorelease, I didn't realize that the caller was doing a release.

5:49 PM Changeset in webkit [2499] by trey

• 4 edits in trunk/WebKit

Fixed 3041616 - Extra page added in back button history

Client-side redirects would always put an extra item in the backforward list.
According to Darin this is a regression all the way back from functionality moving
from WebBrowser to WebKit.

• WebCoreSupport.subproj/WebBridge.h: Added state to know if we're doing an "internal" type of load
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Set internalLoad bit if delay==0 (-[WebBridge reportClientRedirectCancelled]): Clear internalLoad (-[WebBridge loadURL:]): Set frame's loadType if doing an internal load (similar to what we do when loading child frames)

5:18 PM Changeset in webkit [2498] by darin

• 14 edits in trunk

WebFoundation:

• fixed storage leak of WebFileDatabaseOp objects

• Database.subproj/WebFileDatabase.m: (-[WebFileDatabase setObject:forKey:]): Release op so it doesn't leak. (-[WebFileDatabase removeObjectForKey:]): Release op so it doesn't leak. (-[WebFileDatabase lazySync:]): Retain op before removing it from the list, since we want to work with it a bit before releasing it.

WebCore:

• fixed storage leak of items in QListBox

• kwq/KWQListBox.h: Added private deleteItems method.
• kwq/KWQListBox.mm: (QListBox::~QListBox): Call deleteItems(). (QListBox::deleteItems): Move the code to delete all the items here from clear(), since clear() is not called on destruction. (QListBox::clear): Call deleteItems().

WebKit:

• fixed storage leak of WebNetscapePluginPackage objects

• Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m:
• Plugins.subproj/WebPluginPackage.h:
• Plugins.subproj/WebPluginPackage.m: Not MyCompanyName, but rather Apple Computer.

4:48 PM Changeset in webkit [2497] by cblu

• 4 edits in trunk/WebCore

Lowercase the text encoding name.

• kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName):

3:16 PM Changeset in webkit [2496] by darin

• 14 edits in trunk/WebKit

WebFoundation:

• fixed bug that caused us to leak one block sometimes when we called WebCallFromCFRunLoop

• Misc.subproj/WebCFRunLoopExtras.m: (WebCallFromCFRunLoop): Initialize refCount to 0.

WebKit:

• fixed bug that caused us to leak all WebResourceHandles used for subresources

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Remove bogus "currentURL == nil" assert. (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Use the new loadWithRequest: call instead of making handle and doing loadWithDelegate:. This is where the leak was, because no one ever released the handle, but releasing it right away would be too soon.

• WebView.subproj/WebBaseResourceHandleDelegate.h: Added defersCallbacks field, loadWithRequest: method, and setDefersCallbacks: method. Removed handle method.
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): New method. Sets up the handle, set the defersCallbacks state on it, and calls loadWithDelegate:. (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): Stores defersCallbacks state, and also sets it on the handle, if any. (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Remove code to set up the handle, since we now do that at loadWithRequest: time.

• WebView.subproj/WebDataSourcePrivate.h: Remove mainHandle field.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Don't release mainHandle. (-[WebDataSource _setPrimaryLoadComplete:]): Ditto. (-[WebDataSource _startLoading]): Use loadWithRequest: on the client, no need to deal with the handle directly at all. (-[WebDataSource _addSubresourceClient:]): Call setDefersCallbacks: on the client. (-[WebDataSource _defersCallbacksChanged]): Ditto.

• WebView.subproj/WebControllerPrivate.m: Remove unneeded include.
• WebView.subproj/WebMainResourceClient.m: Ditto.

2:22 PM Changeset in webkit [2495] by rjw

• 4 edits in trunk/WebCore

Fixed 3086188 - REGRESSION: Justified text is broken

Bogus special case for DirW(hite)S(pace). This
should be correctly detected by CF, but is not.
Revert to explicit checking for ' ' character. This'll
work most of the time. All the more reason to do
our own unicode attribute database.

• kwq/KWQChar.mm: (QChar::direction):

1:59 PM Changeset in webkit [2494] by cblu

• 12 edits in trunk

WebCore:

Fixed: 3056726 - View Source window always displays the source in current system encoding
Fixed: 3019352 - Text encoding is not handled when viewing plain text

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (+[WebCoreBridge stringWithData:textEncoding:]): added, creates a string with data using the WebCore's decoding logic. (+[WebCoreBridge stringWithData:textEncodingName:]): added, calls stringWithData:textEncoding: after getting the encoding for a text encoding name

WebKit:

Fixed: 3056726 - View Source window always displays the source in current system encoding
Fixed: 3019352 - Text encoding is not handled when viewing plain text

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource stringWithData:]): added, creates a string using the specified encoding.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation documentSource]): uses the bridge specified encoding when creating the string
• WebView.subproj/WebTextView.h:
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]): use stringWithData: (-[WebTextView supportsTextEncoding]): Yup

1:28 PM Changeset in webkit [2493] by gramps

• 5 edits in trunk/WebCore

• khtml/html/htmlparser.cpp:

(KHTMLParser::insertNode):

• khtml/html/htmltokenizer.cpp:

(HTMLTokenizer::write):

Backed our Dave's whitespace hack because it was adding newlines, i.e.
vertical margins, to web pages all over.

12:51 PM Changeset in webkit [2492] by rjw

• 3 edits in trunk/WebKit

Fixed crasher.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

12:40 PM Changeset in webkit [2491] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark contentMatches:]): new method, returns YES if two bookmarks are the same, ignoring group and parent.

WebBrowser:

• fixed 3083274 -- Add preference for separating/consolidating contents of Bookmarks Toolbar and Menu
• fixed 3083277 -- Add preferences for showing Address Book and Rendezvous items in Bookmarks menu

Also made Bookmarks menu update only when it is about to be pulled
down (like History menu), rather than every time bookmarks change.

• Defaults.plist,
• PreferenceKeys.h: Add new preference keys with default values: BookmarksMenuAndToolbarAreSame, BookmarksMenuIncludesAddressBook, and BookmarksMenuIncludesRendezvous. Also #defined BrowserPreferenceValueChangedNotification, which is sent when certain preference values change.

• Preferences.subproj/GeneralPreferences.h:
• Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences sendChangeNotificationForPreferenceKey:]): new method, sends BrowserPreferenceValueChangedNotification with a particular preference key's name in the userInfo (-[GeneralPreferences toggleBookmarksMenuAndToolbarAreSame:]), (-[GeneralPreferences toggleBookmarksMenuIncludesRendezvous:]), (-[GeneralPreferences toggleBookmarksMenuIncludesAddressBook:]): Set the appropriate preference, and call sendChangeNotificationForPreferenceKey (-[GeneralPreferences initializeFromDefaults]): Set the initial state for the new checkboxes.

• Preferences.subproj/English.lproj/GeneralPreferences.nib: Added checkboxes for the three new preferences. With Ron Brannan's help, the text is decent, but the General Preferences panel is now much taller than the others; we'll probably need a reorganization soon.

• BookmarkSource.h: added bookmarkSourceImage, setBookmarkSourceMenu:, and bookmarkSourceMenuTitle to the BookmarkSource protocol.

• GlobalHistory.h: removed setHistoryMenu: and historyMenu
• GlobalHistory.m: (-[GlobalHistory dealloc]): change setHistoryMenu to setBookmarkSourceMenu (-[GlobalHistory bookmarkSourceImage]): new method, returns little clock image (-[GlobalHistory setBookmarkSourceMenu:]): new name for setHistoryMenu (-[GlobalHistory bookmarkSourceMenuTitle]): new method, returns nil here since history uses an existing top-level menu

• AppController.m: (-[AppController applicationDidFinishLaunching:]): use -[GlobalHistory setBookmarkSourceMenu:] instead of obsolete -[GlobalHistory setHistoryMenu:]

• ABHomePagesController.h:
• ABHomePagesController.m: (-[ABHomePagesController dealloc]): call setBookmarkSourceMenu:nil (-[ABHomePagesController refreshContents]): set _menuGood to NO (-[ABHomePagesController updateMenu]): new method, make menu contents match address book contents (if !_menuGood) (-[ABHomePagesController setBookmarkSourceMenu:]): new method, set up menuUpdater (-[ABHomePagesController bookmarkSourceMenuTitle]): new method, return "Address Book" (-[ABHomePagesController bookmarkSourceImage]): new method, return little address book image

• RendezvousController.h:
• RendezvousController.m: (-[RendezvousController dealloc]): call setBookmarkSourceMenu:nil (-[RendezvousController sendContentsChangedNotification]): set _menuGood to NO (-[RendezvousController updateMenu]): new method, make menu contents match Rendezvous list (if !_menuGood) (-[RendezvousController setBookmarkSourceMenu:]): new method, set up menuUpdater (-[RendezvousController bookmarkSourceMenuTitle]): new method, return "Rendezvous" (-[RendezvousController bookmarkSourceImage]): new method, return little Rendezvous logo image

• BookmarksController.h: now implements MenuUpdaterDelegate protocol and updates the Bookmarks menu only when it's about to be shown rather than when any bookmarks change.
• BookmarksController.m: (-[BookmarksController imageForBookmark:]): get bookmark source images using BookmarkSource protocol rather than hardwiring here (-[BookmarksController _removeAllBookmarksFromMenu]): renamed from _removeBookmarksFromMenu for some nitpicky reason (-[BookmarksController bookmarkSource:setShouldIncludeSubmenu:]): new method, creates submenu for bookmark source if appropriate (-[BookmarksController addSpecialBookmarkSourcesToMenu]): new method, checks preferences and calls bookmarkSource:setShouldIncludeSubmenu: for Rendezvous and AddressBook (-[BookmarksController updateMenu]): renamed from _updateBookmarksInMenu (now it's the MenuUpdaterDelegate method); do nothing if _menuGood, otherwise remove all bookmarks, then add them back in. (-[BookmarksController _receivedBookmarksChangedNotification:]): set _menuGood to NO rather than updating bookmarks immediately (-[BookmarksController receivedBrowserPreferenceValueChangedNotification:]): new method, do the appropriate updating based on which preference changed (-[BookmarksController addBookmarksMenuUpdater]): new method, broken out only so it could be called after a delay, since awakeFromNib is slightly too early (-[BookmarksController awakeFromNib]): set up menu updater (after delay); observe BrowserPreferenceValueChangedNotification (-[BookmarksController dealloc]): remove menu updater (-[BookmarksController bookmarkSourceForProxyIdentifier:]): new method, moved here from BookmarksViewController; converts a string identifier into an object implementing <BookmarkSource> (-[BookmarksController addUniqueBookmarksFrom:to:]): new method, used to consolidate toolbar and menu contents when the pref is set that way. (-[BookmarksController updateBookmarkSources]): renamed from _blessOrCreateSpecialFolders, now it is also called in response to a change to BookmarksMenuAndToolbarAreSamePreferenceKey; handle making menu initially be a copy of toolbar, or consolidating the two, depending on pref value.

• BookmarksViewController.m: (-[BookmarksViewController bookmarkSourceContentsChanged:]), (-[BookmarksViewController refreshContents]), (-[BookmarksViewController bookmarksFromContentItems:]), (-[BookmarksViewController bookmarkFromContentItem:]), (-[BookmarksViewController canDeleteFromSelectedBookmarkSource]), (-[BookmarksViewController child:ofContentItem:]), (-[BookmarksViewController isContentItemExpandable:]), (-[BookmarksViewController numberOfChildrenOfContentItem:]), (-[BookmarksViewController titleStringForContentItem:]), (-[BookmarksViewController addressStringForContentItem:]), (-[BookmarksViewController imageForContentItem:]), (-[BookmarksViewController deleteContentItems:]): Updated to call bookmarkSourceForProxyIdentifier on [BookmarksController sharedController] rather than self.

• FavoriteButton.m: (-[FavoriteButton determineDragOperation:]): use -[WebBookmark contentMatches:] instead of (deleted) [FavoriteButton bookmarkMatches:]

• English.lproj/Localizable.strings,
• English.lproj/StringsNotToBeLocalized.txt: kept localizations up to date

10:49 AM Changeset in webkit [2490] by trey

• 7 edits in trunk/WebKit

WebKit:

Finished 2998200 - access to most-recent in submenu of back & forward buttons

• WebView.subproj/WebDataSourcePrivate.h: The BF items we are going to and from were moved here from WebFrame because of timing problems among multiple data sources when using the BF buttons during a load. In addition, the datasource has a list of relevant BF items for which it keeps their titles up to date.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Free new state. (-[WebDataSource _setTitle:]): Update titles of BF items. (-[WebDataSource _provisionalBackForwardItem]): (-[WebDataSource _setProvisionalBackForwardItem:]): (-[WebDataSource _previousBackForwardItem]): (-[WebDataSource _setPreviousBackForwardItem:]): (-[WebDataSource _addBackForwardItem:]): Maintain new state. (-[WebDataSource _commitIfReady]): Free up previous and provisional BF items after commit.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:]): Add the new BF item to the datasource. (-[WebBridge saveDocumentState:]): Use the right BF item to save the doc state.
• WebView.subproj/WebFramePrivate.h: Previous and provisional BF are moved to datasource.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Use provisional BF from datasource to set position in BF list. Add new BF item to datasource. (-[WebFrame _isLoadComplete]): (-[WebFrame _checkLoadComplete]): Comments, whitespace. (-[WebFrame _goToItem:withFrameLoadType:]): Set item we will use to saveDocState at commit time.

WebBrowser:

Finished 2998200 - access to most-recent in submenu of back & forward buttons

• BrowserDocument.m: (-[BrowserDocument _addItem:toMenu:]): Center-truncate menu items to reasonable width
• Defaults.plist: Set Back-forward max size to 200.

10:48 AM Changeset in webkit [2489] by darin

• 4 edits in trunk/WebCore

Tests:

• WebFoundation-Misc/ifnsurlextensions-test.chk: Update WebNSURLExtras tests for recently-implemented ftp URL canonicalization.

WebFoundation:

• fixed 3015800 -- bad URL error - unescaped # in URL

Actually this has to be fixed both here and in KURL.

• Misc.subproj/WebNSURLExtras.m: (StringByAddingPercentEscapes): Escape "#" characters too. (URLStringByAddingPercentEscapes): Change the code so that it specifically makes an exception for the first "#" character in the string. I guess that it should really be the first "#" in the path, but that would be a lot harder. (+[NSURL _web_URLWithString:relativeToURL:]): Cite the new CFURL bug I filed.

WebCore:

• fixed 3015800 -- bad URL error - unescaped # in URL

Actually this has to be fixed both here and in NSURLExtras.

• kwq/KWQKURL.mm: Set the "BadChar" flag for "#" so we escape any "#" characters we see after the first one.

Oct 27, 2002:

11:54 PM Changeset in webkit [2488] by darin

• 11 edits in trunk

WebCore:

• fixed 3058845 -- <input type=file> uses hard-coded width of 200 pixels for filename

• khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): Use a default of 20 "x-widths" wide, to match Mozilla, rather than the 17 that is in KHTML by default. (RenderFileButton::calcMinMaxWidth): Pass in a character width here, using the same 20-character rule as above.
• kwq/KWQFileButton.h: Replace sizeHint() with sizeForCharacterWidth(int).
• kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth): Pass character count to the WebCoreFileButton. (KWQFileButton::baselinePosition): Fix baseline computation. It was computing some huge negative number before and was obviously broken.
• kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Add an assertion.
• kwq/WebCoreViewFactory.h: Replace bestVisualFrameSize with bestVisualFrameSizeForCharacterCount:.

WebKit:

• WebKit part of filename width fix

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton drawRect:]): Compute left position by starting at the right side of the button frame rather than by starting at the right side of the overall bounds. Removes dependency on fixed-width filename area. (-[WebFileButton updateLabel]): Added. Computes ellipsized filename. (-[WebFileButton setFilename:]): Use updateLabel instead of code in line here. (-[WebFileButton setFrameSize:]): Call updateLabel. (-[WebFileButton bestVisualFrameSizeForCharacterCount:]): Compute a width based on the count passed in rather than a hardcoded 200-pixel constant.

10:52 PM Changeset in webkit [2487] by darin

• 5 edits in trunk/WebKit

• fixed 3037369 -- Status text not cleared after start of drag from page

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Find the highest-level enclosing WebHTMLView, and call _updateMouseoverWithEvent: with the mouseUp event after the drag is done. (-[WebHTMLView mouseMovedNotification:]): Just call _updateMouseoverWithEvent:, the code from here was moved into there.

• WebView.subproj/WebHTMLViewPrivate.h: Declare _updateMouseoverWithEvent.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Moved all the code from mouseMovedNotification: in here so it could be used twice.

6:27 PM Changeset in webkit [2486] by gramps

• 8 edits in trunk

WebCore:

• khtml/ecma/kjs_navigator.cpp:

(Navigator::getValueProperty):

Tweaked AppName, Product, and Vendor logic.

WebKit:

• WebView.subproj/WebController.m:

(-[WebController userAgentForURL:]):

Changed default user agent to Mozilla 1.1.

WebBrowser:

• Debug/DebugUtilities.m:

(-[DebugUtilities userAgentSubmenuItem]):

Updated all user agents and added new experimental items.

9:08 AM Changeset in webkit [2485] by darin

• 9 edits in trunk

WebCore:

• kwq/KWQLoader.mm: (KWQServeRequest): Add a missing "delete job" for one particular failure case.

WebKit:

• Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy dealloc]): Added, so we don't leak the title.

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup removeBookmark:]):
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList removeChild:]): Added retain/release pairs so we don't use an object after it's deallocated. In practice this doesn't happen the way these are used by Alex since they are in an array, but they have windows of vulnerability depending on exactly how they are used.

WebBrowser:

• BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): Fix indenting.

Oct 26, 2002:

11:45 PM Changeset in webkit [2484] by darin

• 8 edits in trunk/WebCore

• fixed a bug in the WebCore cache that caused it to not cache very much after a while, and also caused a crash I saw twice on my machine

Adjust total size of items in the LRU list, when the size of one of the
items that's in the list is changed.

• khtml/misc/loader.h: Added a size parameter (default 0) to the CachedObject constructor. Added a protected CachedObject::setSize() and made m_size private. Added Cache::adjustSize() and Cache::checkLRUAndUncacheableListIntegrity().
• khtml/misc/loader.cpp: (CachedObject::setSize): Added. This is now the only legal way to change the size of a cached object, and it calls Cache::adjustSize. (CachedCSSStyleSheet::CachedCSSStyleSheet): Pass the length into the base class's constructor instead of setting m_size. (CachedCSSStyleSheet::data): Call setSize() instead of setting m_size. Also get the size back with size() rather than m_size. (CachedScript::CachedScript): Pass the length into the base class's constructor instead of setting m_size. (CachedScript::data): Call setSize() instead of setting m_size. Also get the size back with size() rather than m_size. (CachedImage::CachedImage): Don't set m_size to 0, since the base class's constructor does that already. (CachedImage::clear): Use setSize() to set the size to 0 instead of setting m_size directly. (CachedImage::data): Use setSize() instead of setting m_size directly. (Cache::checkLRUAndUncacheableListIntegrity): Useful debugging function. Left in but ifdef'd out. (Cache::adjustSize): Added. Changes the "total LRU list size" by the passed-in delta, but only if the passed-in object is in the LRU list.

• kwq/KWQLineEdit.mm:
• kwq/KWQTextField.h:
• kwq/KWQTextField.mm: Renamed the Objective C class KWQNSTextField to KWQTextField.

4:55 PM Changeset in webkit [2483] by darin

• 8 edits in trunk/JavaScriptCore

• changed to use #if APPLE_CHANGES and #if !APPLE_CHANGES consistently

We no longer do #ifdef APPLE_CHANGES or #ifndef APPLE_CHANGES.

• kjs/collector.cpp:
• kjs/collector.h:
• kjs/grammar.cpp:
• kjs/internal.cpp:
• kjs/ustring.h:

4:49 PM Changeset in webkit [2482] by darin

• 3 edits
  22 deletes in trunk/WebCore

Tools:

• Scripts/check-forwarding-headers: Added. Finds unused forwarding headers in WebCore.

WebCore:

• removed forwarding headers that are not actually needed

• ForwardingHeaders/kcmdlineargs.h: Removed.
• ForwardingHeaders/kinstance.h: Removed.
• ForwardingHeaders/kio/kprinter.h: Removed.
• ForwardingHeaders/kio/ktrader.h: Removed.
• ForwardingHeaders/kio/scheduler.h: Removed.
• ForwardingHeaders/kparts/factory.h: Removed.
• ForwardingHeaders/kparts/historyprovider.h: Removed.
• ForwardingHeaders/kstddirs.h: Removed.
• ForwardingHeaders/qarray.h: Removed.
• ForwardingHeaders/qbrush.h: Removed.
• ForwardingHeaders/qbutton.h: Removed.
• ForwardingHeaders/qcollection.h: Removed.
• ForwardingHeaders/qcombobox.h: Removed.
• ForwardingHeaders/qframe.h: Removed.
• ForwardingHeaders/qglobal.h: Removed.
• ForwardingHeaders/qiodevice.h: Removed.
• ForwardingHeaders/qlineedit.h: Removed.
• ForwardingHeaders/qnamespace.h: Removed.
• ForwardingHeaders/qpen.h: Removed.
• ForwardingHeaders/qprinter.h: Removed.
• ForwardingHeaders/qsize.h: Removed.
• ForwardingHeaders/qstack.h: Removed.

4:41 PM Changeset in webkit [2481] by darin

• 7 edits in trunk/WebCore

• fixed a couple of files accidentally checked in with KWQQ names

• ForwardingHeaders/qasyncio.h: Change names.
• ForwardingHeaders/qstylesheet.h: Ditto.
• WebCore.pbproj/project.pbxproj: Ditto.
• kwq/KWQMovie.h: Ditto.

4:21 PM Changeset in webkit [2480]

• 1 copy
  89 deletes in branches/unlabeled-1.6.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.56'.

4:21 PM Changeset in webkit [2479] by darin

• 49 edits in trunk/WebCore

• changed to use #if APPLE_CHANGES and #if !APPLE_CHANGES consistently

We no longer do #ifdef APPLE_CHANGES or #ifndef APPLE_CHANGES.

• lots of files

4:08 PM Changeset in webkit [2478] by darin

• 246 edits
  107 adds
  19 deletes in trunk/WebCore

• changed naming scheme in KWQ for files like qstring.h Now use names like KWQString.h and make a forwarding header called qstring.h.

• tons of files

12:27 AM Changeset in webkit [2477] by darin

• 24 edits
  1 add
  2 deletes in trunk

WebCore:

• fixed 3068404 -- eliminate all user-visible messages from WebCore

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Use runJavaScriptPrompt function instead of the more generic QInputDialog.

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::altText): Get submit alt text for input element from the view factory, rather than using i18n, since we don't support that.
• khtml/html/htmlparser.cpp: (KHTMLParser::handleIsindex): Ditto, for the intro that says "This is a searchable index".
• khtml/rendering/render_form.cpp: (RenderSubmitButton::defaultLabel): Ditto, for "Submit". (RenderResetButton::defaultLabel): Ditto, for "Reset". (RenderFileButton::slotClicked): Ifdef'd out this unused code that had i18n text in it.

• khtml/xml/xml_tokenizer.cpp: (XMLHandler::errorString): Put in an ifdef and a FIXME to avoid i18n. (XMLHandler::fatalError): Ditto. (XMLTokenizer::finish): Ditto.

• khtml/misc/decoder.cpp: (Decoder::decode): Ifdef'd the check for the first language being "ja", since that's not how we're going to trigger Japanese auto-detect.

• khtml/rendering/render_applet.cpp: (RenderEmptyApplet::RenderEmptyApplet): Turned off the code that does the empty applet label. I don't think it worked, and it used i18n. We'll have to tackle this eventually.

• kwq/KWQKHTMLPartImpl.h: Added runJavaScriptPrompt.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptPrompt): Moved the code here that used to be in KWQInputDialog.

• kwq/kdecore/klocale.h: Remove i18n() and KLocale::languageList(), added the functions that are listed below.
• kwq/KWQKLocale.mm: (inputElementAltText): Added specific function for getting one of the very few translated strings that we need in WebCore. (resetButtonDefaultLabel): Ditto. (searchableIndexIntroduction): Ditto. (submitButtonDefaultLabel): Ditto. (KLocale::language): Use the view factory to ask for the language code, since there's no public API to get it that WebCore can use.

• kwq/WebCoreViewFactory.h: Add new API for above.

• ForwardingHeaders/qinputdialog.h: Added empty file.

• kwq/qt/qinputdialog.h: Removed.
• kwq/KWQInputDialog.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed QInputDialog files.

WebKit:

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory inputElementAltText]): Added. (-[WebViewFactory resetButtonDefaultLabel]): Added. (-[WebViewFactory searchableIndexIntroduction]): Added. (-[WebViewFactory submitButtonDefaultLabel]): Added. (-[WebViewFactory defaultLanguageCode]): Added.

• English.lproj/Localizable.strings: Update.
• English.lproj/StringsNotToBeLocalized.txt: Update.

Oct 25, 2002:

11:43 PM Changeset in webkit [2476] by darin

• 18 edits
  1 add
  2 deletes in trunk

WebCore:

Remove some user-visible strings. We can't have any strings that need
localization in WebCore, given our translation strategy.

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding): Put APPLE_CHANGES around some i18n dialog code.
• khtml/khtml_part.cpp: (KHTMLPart::submitForm): Ditto.
• khtml/rendering/render_frames.cpp: (RenderPartObject::slotPartLoadingErrorNotify): Ditto.
• khtml/ecma/kjs_window.cpp: (Window::get): Ditto. (Window::scheduleClose): Ditto. (WindowFunc::tryCall): Put APPLE_CHANGES in to use JavaScript-specific methods in the part of calling the generic ones from KMessageBox.

• ForwardingHeaders/kmessagebox.h: Added (empty file).

• kwq/KWQKHTMLPartImpl.h: Added new runJavaScript functions.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptAlert): Added. (KWQKHTMLPartImpl::runJavaScriptConfirm): Added.

• kwq/WebCoreViewFactory.h: Added runJavaScriptAlertPanelWithMessage and runJavaScriptConfirmPanelWithMessage.

• kwq/kdeui/kmessagebox.h: Removed.
• kwq/KWQKMessageBox.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed the KMessageBox files.

WebKit:

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptAlertPanelWithMessage:]): Added. (-[WebViewFactory runJavaScriptConfirmPanelWithMessage:]): Added.

• English.lproj/Localizable.strings: Update.
• English.lproj/StringsNotToBeLocalized.txt: Update.

10:49 PM Changeset in webkit [2475] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3038011 -- drop-down menu hierarchy broken at yahoo new acct page

• kjs/array_object.cpp: (ArrayProtoFuncImp::call): Fix bug calling concat on an empty array. The old code tried to optimize in a way that would prevent appending any arrays until at least one element was in the destination array. So if you were concatenating a non-empty array into an empty array, you got an empty array.

7:14 PM Changeset in webkit [2474] by rjw

• 4 edits in trunk/WebCore

Removed debug logging.

• khtml/rendering/font.cpp: (Font::drawText):

7:11 PM Changeset in webkit [2473] by rjw

• 12 edits in trunk

Implemented support for bidi text layout.

• WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):

Implemented support for bidi text layout. WebCore
temporarily depends on SPI to get unicode character
attribute from CF. This will change shortly.

• khtml/rendering/font.cpp: (Font::drawText):
• kwq/KWQChar.mm: (QChar::direction):
• kwq/KWQPainter.mm: (QPainter::drawText):
• kwq/WebCoreTextRenderer.h:
• kwq/qt/qpainter.h:

Updated to reflect change in WebKit SPI.

• EtchedStringView.m: (-[EtchedStringView drawRect:]):

5:55 PM Changeset in webkit [2472] by cblu

• 11 edits in trunk/WebKit

Made frameNamed private in WebController and renamed it to _findFrameNamed. Got rid of _frameInThisWindowNamed in WebController because it isn't needed anymore.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]): call _findFrameNamed
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _findFrameNamed:]): renamed, made private, got rid of call to _frameInThisWindowNamed as it is not needed
• WebView.subproj/WebFrame.m: (-[WebFrame findFrameNamed:]): call [WebController _findFrameNamed:]

5:27 PM Changeset in webkit [2471] by cblu

• 8 edits in trunk/WebKit

• Fix case where we would name a new window _blank
• If a data source can't be created for a plug-in request, don't create the frame or open a window.
• cleaned up plug-in stream notifications

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView initWithFrame:]): create streamNotifications dict (-[WebBaseNetscapePluginView dealloc]): release streamNotifications dict (-[WebBaseNetscapePluginView frameStateChanged:]): cleaned up (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): create data source before frame
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): create data source before frame
• WebView.subproj/WebControllerPrivate.m: (-[WebController _setTopLevelFrameName:]): don't allow _blank frames
• WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFramedNamed:]): no need to check for _blank

5:06 PM Changeset in webkit [2470] by darin

• 3 edits in trunk/WebKit

WebKit:

Tighten up the code that observes mouse moved events.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't set up observers here. (-[WebHTMLView addMouseMovedObserver]): Added some assertions. (-[WebHTMLView viewWillMoveToWindow:]): Stop observing the "become main" and "resign main" notifications here. (-[WebHTMLView viewDidMoveToWindow]): Start observing them here. (-[WebHTMLView windowDidBecomeMain:]): Assert that the notification is for this window, instead of checking with if. (-[WebHTMLView windowDidResignMain:]): Assert that the notification is for this window.

WebBrowser:

• fixed 3078924 -- Rollovers fail on wired.com after selecting a menu

• BrowserApplication.m: (-[BrowserApplication sendEvent:]): Put in a workaround that sets the mouse focus to the key window.

• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Remove unneeded pageTitleChanged. (-[BrowserWindowController frameLoadWithinPage:]): Call updateBackAndForwardButtons instead of doing the "two calls to setActivity:" dance.

4:41 PM Changeset in webkit [2469] by cblu

• 20 edits in trunk

WebCore:

Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): call findFrameNamed
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): call findOrCreateFramedNamed
• kwq/WebCoreBridge.h:

WebKit:

Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFramedNamed
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFramedNamed
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): moved (-[WebBridge mainFrame]): moved (-[WebBridge findOrCreateFramedNamed:]): call findOrCreateFramedNamed on the frame (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): call _pluginController
• WebView.subproj/WebControllerPrivate.m: (-[WebController _frameInThisWindowNamed:]): call _descendantFrameNamed
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame findFrameNamed:]): was frameNamed. First checks special-case frame names, descendant frames, then the whole controller, then other controllers. (-[WebFrame findOrCreateFramedNamed:]): calls findFrameNamed, opens new window if necessary
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _descendantFrameNamed:]): searches children, children's children etc. (-[WebFrame _pluginController]): this method needed an "_"
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): call _pluginController
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): no need to special case for "_blank" since findFrameNamed will return nil for that name

3:51 PM Changeset in webkit [2468] by trey

• 14 edits
  2 deletes in trunk/WebKit

WebKit:

2919039 - Implement limit on back/forward history list
2998200 - access to most-recent in submenu of back & forward buttons
3022566 - need WebKit API for accessing and visiting back/forward list items
3084051 - forward button incorrectly enabled after going forward all the way

Remaining issues at this point are getting the title of the pages
into the menu items (instead of the URL), and saving document
state properly when you jump around in the list. Solutions are
known and coming soon.

• History.subproj/WebBackForwardList.h: Added doc comments to API. Made ivars private. Replaced index- based API with item-based API. Added a sizelimit to the overall list. Tweaked API to get back and forward lists.
• History.subproj/WebBackForwardList.m: Straightforward impl of the above, with the note that I dumped WebHistoryList from the API and impl in favor of an NSArray, which is efficient for this sort of use (queue, stack). (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToEntry:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList maximumSize]): (-[WebBackForwardList setMaximumSize:]): (-[WebBackForwardList description]):
• History.subproj/WebHistoryList.h: Removed. Nuked from API, per above.
• History.subproj/WebHistoryList.m: Removed.
• Misc.subproj/WebKit.h: WebHistoryList gone from API.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:]): Use if/else instead of buried "return;", so next person doesn;t make the same mis-read I did. (-[WebBridge saveDocumentState:]): Site of future work.
• WebKit.pbproj/project.pbxproj: Nuked WebHistoryList.
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController goBackOrForwardToItem:]): New method to support random access nav in backforward list.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): Site of future work (fixing title in items)
• WebView.subproj/WebFramePrivate.h: WebFrameLoadTypeIndexedBack/WebFrameLoadTypeIndexedForward are collapsed into WebFrameLoadTypeIndexedBackForward. Vestigial WebFrameLoadTypeIntermediateBack is nuked.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setBackForwardItem:]): (-[WebFrame _setBackForwardItem:]): (-[WebFrame _backForwardItem]): Must remember the BF item we're going to so we can update the BF list on commit. (-[WebFrame _transitionToCommitted]): Update the BF list on commit. (-[WebFrame _isLoadComplete]): (-[WebFrame _goToItem:withFrameLoadType:]): Update BF list on within-page nav. Remember BF item we are going to for later update on commit.

WebBrowser:

2919039 - Implement limit on back/forward history list
2998200 - access to most-recent in submenu of back & forward buttons
3084051 - forward button incorrectly enabled after going forward all the way

Remaining issues at this point are getting the title of the pages
into the menu items (instead of the URL), and saving document
state properly when you jump around in the list. Solutions are
known and coming soon.

• BrowserDocument.h: Add BrowserDocumentClientNavigatedWithinPageNotification.
• BrowserDocument.m: (-[BrowserDocument init]): Set up BackForwardListSizeLimit preference. (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]): Nits adopting new API. (-[BrowserDocument goToItem:]): (-[BrowserDocument _addItem:toMenu:]): (-[BrowserDocument backListMenuForButton:]): (-[BrowserDocument forwardListMenuForButton:]): Code to build BF menus, and respond to clicks.
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadWithinPage:]): Register for and handle BrowserDocumentClientNavigatedWithinPageNotification. Must update title bar widgets at this point.
• Defaults.plist: New defaults: BackForwardListSizeLimit, BackForwardMenuSizeLimit
• LocationChangeHandler.m: (-[LocationChangeHandler locationChangedWithinPageForDataSource:]): Post BrowserDocumentClientNavigatedWithinPageNotification.
• PreferenceKeys.h: New default keys.

12:51 PM Changeset in webkit [2467] by cblu

• 3 edits in trunk/WebKit

Minor non-mentionable clean-up.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):

10:11 AM Changeset in webkit [2466] by cblu

• 5 edits in trunk/WebKit

Cleaned up the plug-in API headers so they can be sent to other groups.

• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPluginContainer.h:
• Plugins.subproj/WebPluginViewFactory.h:

3:09 AM Changeset in webkit [2465] by mjs

• 4 edits in trunk/WebCore

• fixed 3065638 - "undefined" output to screen on empty document.write()

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): Don;t assume there is at least one argument.

2:31 AM Changeset in webkit [2464] by rjw

• 2 edits in trunk/WebKit

* empty log message *

2:15 AM Changeset in webkit [2463] by mjs

• 4 edits in trunk/WebCore

• fixed 3048031 - innerHTML is incorrectly null

• kwq/KWQString.mm: (QString::isNull): Check for NULL by comparing to shared_null_handle instead of checking for 0 length, so garden-variety empty strings don't show as NULL. (QString::QString): Make sure that string created with a NULL char
• uses the shared null handle, so it's properly NULL.

Oct 24, 2002:

9:54 PM Changeset in webkit [2462] by rjw

• 9 edits in trunk

Fixed many font substitution related bugs, at least including:
3006966, 3026675, 3071106, and more... (each of these bugs
has a list of related bugs).

Needs little more cleanup to correctly deal with non base characters.

• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Against Darin's better judgement prevent extra layout when not in live resize. If
this introduces any regressions I owe darin a good bottle of wine.

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):

Updated to reflect new calling parameter semantic of floatCharacterWidths(),
which now returns the entire array of widths up the last character requested.

• khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):

4:35 PM Changeset in webkit [2461] by cblu

• 4 edits in trunk/WebKit

New Java plug-in works! Much faster to load and no spinny cursor! Unfortunately, it very unstable.

• Plugins.subproj/WebPluginController.m: cleaned-up the logging messages. (-[WebPluginController addPluginView:]): (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): make height and width an attribute.

4:12 PM Changeset in webkit [2460] by hyatt

• 4 edits in trunk/WebCore

<pre>, <xmp> and <plaintext> should all have a top margin of 1em.
Fixes a bunch of sites that use <pre>.

• khtml/css/html4.css:

3:34 PM Changeset in webkit [2459] by cblu

• 18 edits in trunk

WebCore:

Removed didAddSubview calls because that can easily be done in WebKit. Duh!

• khtml/rendering/render_frames.cpp: (RenderPart::setWidget):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm:
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/WebCoreBridge.h:

WebKit:

Some clean-up and bug fixes for new plug-in support.

• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): need a colon after windowWillClose (-[WebPluginController addPluginView:]): added logging (-[WebPluginController didAddPluginView:]): added logging (-[WebPluginController startAllPlugins]): added logging (-[WebPluginController stopAllPlugins]): added logging (-[WebPluginController destroyAllPlugins]): added logging
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): use correct dict key for getting MIME descriptions
• WebCoreSupport.subproj/WebBridge.m: no more didAddSubview
• WebView.subproj/WebFramePrivate.h: no more didAddSubview
• WebView.subproj/WebFramePrivate.m: no more didAddSubview
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): call didAddPluginView on WebPluginController

3:08 PM Changeset in webkit [2458] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]): added ASSERT(response != nil), leftover from debugging session on Tuesday, seems worth leaving in.

WebBrowser:

• fixed 3083271 -- Change Show/Hide menu items in View menu to use check marks

• English.lproj/MainMenu.nib: changed menu items to not include "Show" or "Hide" and to be indented by two spaces so they look like they belong to the dimmed "Show" item at the top of the menu. This is a yucky UI hack but is (A) probably better than the old huge list of items starting with "Show" or "Hide", and (B) what SJ wants.

• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): validate by updating check mark rather than changing title

1:28 PM Changeset in webkit [2457] by darin

• 5 edits
  29 adds
  26 deletes in trunk/WebCore

A step in the direction of making KWQ headers much nicer.
Move all empty headers out of kwq, and into ForwardingHeaders.

• ForwardingHeaders/kcmdlineargs.h: Added.
• ForwardingHeaders/kdatastream.h: Added.
• ForwardingHeaders/khtml_iface.h: Added.
• ForwardingHeaders/khtml_printsettings.h: Added.
• ForwardingHeaders/khtml_run.h: Added.
• ForwardingHeaders/kio/kprinter.h: Added.
• ForwardingHeaders/kio/kprotocolmanager.h:
• ForwardingHeaders/kio/ktrader.h: Added.
• ForwardingHeaders/kio/scheduler.h: Added.
• ForwardingHeaders/kmultipledrag.h: Added.
• ForwardingHeaders/kprinter.h: Added.
• ForwardingHeaders/kprotocolmanager.h: Added.
• ForwardingHeaders/ksslcertchain.h: Added.
• ForwardingHeaders/ksslinfodlg.h: Added.
• ForwardingHeaders/kstdaction.h: Added.
• ForwardingHeaders/ktempfile.h: Added.
• ForwardingHeaders/ktrader.h: Added.
• ForwardingHeaders/kurldrag.h: Added.
• ForwardingHeaders/kxmlguifactory.h: Added.
• ForwardingHeaders/qasyncimageio.h: Added.
• ForwardingHeaders/qbitmap.h: Added.
• ForwardingHeaders/qclipboard.h: Added.
• ForwardingHeaders/qfontdatabase.h: Added.
• ForwardingHeaders/qglobal.h: Added.
• ForwardingHeaders/qhbox.h: Added.
• ForwardingHeaders/qintcache.h: Added.
• ForwardingHeaders/qintdict.h: Added.
• ForwardingHeaders/qmetaobject.h: Added.
• ForwardingHeaders/qobjectlist.h: Added.
• ForwardingHeaders/scheduler.h: Added.

• kwq/dcop/kdatastream.h: Removed.
• kwq/kdecore/kcmdlineargs.h: Removed.
• kwq/kdecore/kmultipledrag.h: Removed.
• kwq/kdecore/ktempfile.h: Removed.
• kwq/kdecore/kurldrag.h: Removed.
• kwq/kdeui/kstdaction.h: Removed.
• kwq/kdeui/kxmlguifactory.h: Removed.
• kwq/khtml/khtml_iface.h: Removed.
• kwq/khtml/khtml_printsettings.h: Removed.
• kwq/khtml/khtml_run.h: Removed.
• kwq/kio/kprinter.h: Removed.
• kwq/kio/kprotocolmanager.h: Removed.
• kwq/kio/kssl/ksslcertchain.h: Removed.
• kwq/kio/kssl/ksslinfodlg.h: Removed.
• kwq/kio/ktrader.h: Removed.
• kwq/kio/scheduler.h: Removed.
• kwq/qt/qasyncimageio.h: Removed.
• kwq/qt/qbitmap.h: Removed.
• kwq/qt/qclipboard.h: Removed.
• kwq/qt/qfontdatabase.h: Removed.
• kwq/qt/qglobal.h: Removed.
• kwq/qt/qhbox.h: Removed.
• kwq/qt/qintcache.h: Removed.
• kwq/qt/qintdict.h: Removed.
• kwq/qt/qmetaobject.h: Removed.
• kwq/qt/qobjectlist.h: Removed.

• WebCore.pbproj/project.pbxproj: Removed all the above headers from the project.

12:47 PM Changeset in webkit [2456] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Move the new pltsuite into the Test group.

12:23 PM Changeset in webkit [2455] by darin

• 4 edits
  1 delete in trunk/WebCore

• ForwardingHeaders/private/qucomextra_p.h: Emptied this out.
• kwq/qt/private/qucomextra_p.h: Removed.

12:15 PM Changeset in webkit [2454] by hyatt

• 4 edits in trunk/WebCore

Make sure that KHTML's initial layout happens after KHTML
fires the onload. This means that in the case where we
beat the timer, we will now fire the onload before both
the initial layout and the initial paint.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):

11:35 AM Changeset in webkit [2453] by cblu

• 5 edits in trunk/WebKit

WebKit:

Changed some method names in WebPluginController.

• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController windowWillClose:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _didAddSubview:]):

WebBrowser:

Fixed: 2961256 - vend an open URL service

• AppController.m: (-[AppController applicationDidFinishLaunching:]): register the services
• ServicesProvider.h: Added.
• ServicesProvider.m: Added. (-[ServicesProvider openURL:userData:error:]): the service
• WebBrowser.pbproj/project.pbxproj:

10:04 AM Changeset in webkit [2452]

• 3 copies in tags/Alexander-29

This commit was manufactured by cvs2svn to create tag 'Alexander-29'.

10:04 AM Changeset in webkit [2451] by sheridan

• 8 edits in trunk

Alex-29 version stamp

9:28 AM Changeset in webkit [2450] by rjw

• 4 edits in trunk/WebKit

Don't leak request.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

9:18 AM Changeset in webkit [2449] by rjw

• 5 edits in trunk/WebKit

Always copy request, we can't count on it being immutable.
This was the cause of the ASSERT from last night's checkin.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

Only send serverRedirectedForDataSource: if URL changed.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

8:38 AM Changeset in webkit [2448] by cblu

• 17 edits in trunk

WebCore:

Use "MIMEType" instead of "serviceType".

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
• kwq/WebCoreBridge.h:

WebKit:

• Use "MIMEType" instead of "serviceType".

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage setPath:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributes:]):
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getMIMEInformation]): changed name. (-[WebNetscapePluginPackage initWithPath:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:MIMEType:attributes:]): (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]): send missing plug-ins notification here
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): new, gets MIME info from plist (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage unload]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

2:02 AM Changeset in webkit [2447] by rjw

• 3 edits in trunk/WebKit

Flag error instead of ASSERTing as a result of fix to 3083013.
Not clear why this condition occurs, but better than ASSERTing
for Alex 29.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

12:35 AM Changeset in webkit [2446] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKLocale.mm: (i18n): Make it obvious when non-localized strings from WebCore show up in the UI, but putting the string "not localized: " in front.

• kwq/KWQKMessageBox.mm: (KMessageBox::error): Fix use of NSRunAlertPanel so that we won't accidentally try to interpret % sequences in the messages we are displaying. (KMessageBox::warningYesNo): Ditto. (KMessageBox::questionYesNo): Ditto. (KMessageBox::sorry): Ditto. (KMessageBox::information): Ditto.

12:20 AM Changeset in webkit [2445] by darin

• 7 edits in trunk/WebKit

• fixed a crash I ran into in the new delegate code

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): Retain self across this deallocation to avoid reentering and being deallocated midstream. This happens because the handle holds the only reference to us, and we may be releasing the last reference to it. (-[WebBaseResourceHandleDelegate dealloc]): Add call to [super dealloc].

• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Add call to [super dealloc].

• WebView.subproj/WebMainResourceClient.m: Tweak.

Oct 23, 2002:

11:50 PM Changeset in webkit [2444] by darin

• 4 edits in trunk/WebKit

• fixed 3083013 -- REGRESSION: Cookie refused at ​http://directory/ even on reload

Restore a bit of the cruft.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): We need to change the request on the data source when a redirect happens, because the data source goes on to ultimately communicate this to WebCore. Restored the code that did that, with some changes to fit into the new regime.

10:16 PM Changeset in webkit [2443] by rjw

• 30 edits in trunk/WebKit

Cleaned up months of accumulated cruft.
Added base class to the three WebResourceHandleDelegate implementors.
Removed superfluous handle references to controller callbacks.
More can still be done.
All in the name of fixing 3076050.

• Misc.subproj/WebKitErrors.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate init]): (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]): (-[WebBaseResourceHandleDelegate setDataSource:]): (-[WebBaseResourceHandleDelegate dataSource]): (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate setIsDownload:]): (-[WebBaseResourceHandleDelegate isDownload]): (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate handle:didReceiveData:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate handle]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedBytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:fromDataSource:]): (-[WebController _mainReceivedError:fromDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _clearErrors]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient _notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceLoadDelegate.h:

6:30 PM Changeset in webkit [2442] by cblu

• 13 edits in trunk

WebCore:

WebKit now gets called when render_frame subviews are added.

• khtml/rendering/render_frames.cpp: (RenderPart::setWidget): call didAddWidget on the part
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::didAddWidget): added, calls didAddSubview on the bridge

WebKit:

Support for new plug-in API. This is about as much as I can do without the new java plug-in and java root.

• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): observe window close changes (-[WebPluginController dealloc]): remove observer, assert if we're still tracking plug-ins (-[WebPluginController didAddSubview:]): start the plug-in (-[WebPluginController stopAllPlugins]): stop and destroy all plug-ins. (-[WebPluginController windowWillClose:]): call stopAllPlugins if the window in question is closing
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): call stopAllPlugins on WebPluginController

5:44 PM Changeset in webkit [2441] by cblu

• 19 edits in trunk

WebCore:

Change for plug-in package API changes.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreBridge.h: added didAddSubview, called when a render_frame's view is added as a subview of the main view.
• kwq/WebCoreViewFactory.h: added didAddSubview

WebKit:

Changed the plug-in package API to return key enumerators instead dictionaries.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage extensionEnumerator]): (-[WebBasePluginPackage MIMETypeEnumerator]): (-[WebBasePluginPackage descriptionForMIMEType:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage extensionsForMIMEType:]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setFilename:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage setMIMEToDescriptionDictionary:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage executableType]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddSubview:]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): (-[WebBridge didAddSubview:]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _didAddSubview:]): new

4:17 PM Changeset in webkit [2440] by darin

• 16 edits in trunk

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt:

WebCore:

• finished up the job of moving the file button to WebKit

I did this mainly for localization reasons.

• kwq/KWQFileButton.h: Remove filename(), add filenameChanged(), make KWQFileButton be a QWidget subclass, not a QPushButton one. Remove clicked() and paint() virtual functions, _filename, _icon, and _label data members.
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Just make a WebCoreFileButton. (KWQFileButton::~KWQFileButton): Less to do here now. (KWQFileButton::setFilename): Call the button to do the work. (KWQFileButton::sizeHint): Ditto. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::baselinePosition): Ditto. (KWQFileButton::filenameChanged): Added. Sends message. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe the "filename changed notification". (-[KWQFileButtonAdapter dealloc]): Stop observing. (-[KWQFileButtonAdapter filenameChanged:]): Send a signal when the notification comes in, so KHTML finds out.

• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Remove handling for RenderFileButton slotReturnPressed. (KWQSlot::call): Ditto.

• kwq/WebCoreViewFactory.h: Remove bestSize. Add setVisualFrame, visualFrame, and bestVisualFrameSize.

• kwq/KWQInputDialog.mm: Tweaked includes. Long-term we want to use "", not <>.
• kwq/KWQKConfigBase.mm: Ditto.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

WebKit:

• finished up the job of moving the file button here from WebCore.

I did this mainly for localization reasons.

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style, target, and action. Also add it as a subview. (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view, not the entire bounds. (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty. (-[WebFileButton bestVisualFrameSize]): Implemented this. (-[WebFileButton visualFrame]): Ditto. (-[WebFileButton setVisualFrame:]): Ditto. (-[WebFileButton baseline]): Ditto. (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks. (-[WebFileButton chooseButtonPressed:]): Call beginSheet. (-[WebFileButton mouseDown:]): Ditto. (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification, WebCoreFileButtonFilenameChanged, when the filename is changed.

• WebView.subproj/WebController.m: (-[WebController policyDelegate]): Add a FIXME about the leak I found here.

1:49 PM Changeset in webkit [2439] by cblu

• 20 edits in trunk

WebCore:

Call the arguments for plug-ins "attributes" everywhere.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/WebCoreBridge.h:

WebKit:

Call the arguments for plug-ins "attributes" everywhere.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setAttributes:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:attributes:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:mimeType:attributes:]): (-[WebNullPluginView drawRect:]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): (-[WebPluginController dealloc]): (-[WebPluginController addPluginView:]):
• Plugins.subproj/WebPluginPackage.h:
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage viewFactory]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

11:52 AM Changeset in webkit [2438] by cblu

• 17 edits in trunk

WebCore:

For the new plug-in API, we need to pass a WebPluginContainer to the plug-in view upon creation. The is owned by the WebFrame. To make this all work, I had to move the WebCore plug-in and java view constructors to WebBridge from WebViewFactory since WebBridge has the frame.

• khtml/khtml_part.cpp: (KHTMLPart::createJavaContext): New APPLE_CHANGES around the java context constructor so we pass the part.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): call the bridge to create the view
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): save the context (KJavaAppletWidget::showApplet): call the bridge to create the view
• kwq/WebCoreBridge.h:
• kwq/WebCoreViewFactory.h:
• kwq/khtml/java/kjavaappletcontext.h: made constructor take the part
• kwq/khtml/java/kjavaappletwidget.h: ivar for the context

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]): (-[WebBridge viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebBridge viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): (-[WebViewFactory pluginsInfo]):

10:49 AM Changeset in webkit [2437] by darin

• 6 edits in trunk/WebKit

• fix bug where plugins crashed closing a stream that was never opened

• Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of receivedError: to NPReason. It's not NPError.
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by checking stream.ndata. (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the stream is not successfully created by NPP_NewStream. (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix. (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.

• English.lproj/Localizable.strings: Update.
• English.lproj/StringsNotToBeLocalized.txt: Update.

10:38 AM Changeset in webkit [2436] by cblu

• 3 edits in trunk/WebKit

Forgot to add WebPluginController back to the project after I had a project conflict.

• WebKit.pbproj/project.pbxproj:

10:27 AM Changeset in webkit [2435] by cblu

• 4 edits
  2 adds in trunk/WebKit

Added WebPluginController which controls and reacts to plug-in requests. Its owned by the WebFrame.

• Plugins.subproj/WebPluginController.h: Added.
• Plugins.subproj/WebPluginController.m: Added. (-[WebPluginController initWithWebFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController showStatus:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): (-[WebFrame pluginController]):

9:57 AM Changeset in webkit [2434] by darin

• 19 edits
  2 adds in trunk

WebCore:

• fixed 3080478 -- reproducible incomplete load on apple.com

• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): Add an assert. (-[WebCoreResourceLoader cancel]): Don't finish here, just disconnect the handle from the job, and disconnect the job from the WebCoreResourceLoader, and let the KHTML code finish the cleanup later. This is the bug fix. (KWQCheckCacheObjectStatus): Add an assertion.

• kwq/KWQKjobclasses.mm: (TransferJob::~TransferJob): Don't call kill(); do the work here instead. (TransferJob::kill): Self-destruct. Need this to avoid a storage leak.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): Put some Apple-specific code inside APPLE_CHANGES. (CachedObject::setResponse): Streamlined this function. (Loader::receivedResponse): Added assertions.

• kwq/qt/qxml.h: Add more stubs.
• kwq/KWQxml.mm: Ditto.

• kwq/WebCoreViewFactory.h: Add [WebCoreViewFactory fileButton], the WebCoreFileButton protocol, and WebCoreFileButtonFilenameChanged.
• kwq/WebCoreViewFactory.m: Add WebCoreFileButtonFilenameChanged.
• WebCore.exp: Export _WebCoreFileButtonFilenameChanged.

WebKit:

Add WebFileButton, to be used by WebCore soon. It's about 1/2
done right now. Compiles but not used yet.

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.

• WebCoreSupport.subproj/WebFileButton.h: Added.
• WebCoreSupport.subproj/WebFileButton.m: Added.
• WebKit.pbproj/project.pbxproj: Added WebFileButton files.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.

5:40 AM Changeset in webkit [2433] by mjs

• 5 edits in trunk/WebKit

• fixed 2876448 - The authentication panel should give a note when the user tried to log in and failed

Also, made the message different (and more helpful) when the
authentication is for a proxy server.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use different messages depending on proxy and previous failure count.

Updated localized strings:

• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:

2:29 AM Changeset in webkit [2432] by mjs

• 7 edits in trunk/WebKit

• fixed 2876446 - The label in the authentication panel needs to adjust its height depending on content

Also improved [NSControl sizeToFitAndAdjustWindowHeight] method.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Adjusted springs.
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use sizeToFitAndAdjustWindowHeight on main label.

• Misc.subproj/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): Improved the logic so the best height is picked while leaving the width alone. Before, the label would always come out to be a very wide single line.

Oct 22, 2002:

11:31 PM Changeset in webkit [2431] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Made WebControllerSets.h private. Also alphabetized headers in target pane and subproject folders.

11:25 PM Changeset in webkit [2430] by mjs

• 6 edits in trunk/WebCore

Forgot to check this in earlier:

• fixed 3077084 - debugging output when suppressing or allowing pop-ups

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
• kwq/KWQLogging.h:
• kwq/KWQLogging.m:

10:48 PM Changeset in webkit [2429] by cblu

• 5 edits in trunk/WebKit

load and unload is only a WebNetscapePluginPackage thing since you can't unload an NSBundle.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m:
• Plugins.subproj/WebNetscapePluginPackage.h:

10:35 PM Changeset in webkit [2428] by cblu

• 9 edits
  4 adds in trunk/WebKit

More moving stuff around for the new plug-in API. Added WebBasePluginPackage and added subclass WebPluginPackage. Also made WebNetscapePluginPackage a subclass of WebBasePluginPackage.

• Plugins.subproj/WebBasePluginPackage.h: Added.
• Plugins.subproj/WebBasePluginPackage.m: Added. (+[WebBasePluginPackage pluginWithPath:]): creates a WebPluginPackage or WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage extensionToMIMEDictionary]): (-[WebBasePluginPackage MIMEToExtensionsDictionary]): (-[WebBasePluginPackage MIMEToDescriptionDictionary]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage isLoaded]): (-[WebBasePluginPackage description]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase pluginForFilename:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• Plugins.subproj/WebPluginPackage.h: Added.
• Plugins.subproj/WebPluginPackage.m: Added. (-[WebPluginPackage initWithPath:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): check the class of the plug-in when deciding which view to create. (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): same here.
• WebKit.pbproj/project.pbxproj:

5:41 PM Changeset in webkit [2427] by hyatt

• 3 edits in trunk/WebKit

Getting XML docs at least made for XML files...

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]):

5:40 PM Changeset in webkit [2426] by hyatt

• 7 edits in trunk/WebCore

Get XML files closer. An XML doc is at least made. No
parsing works yet though.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::setPolicyBaseURL):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setContentType:]):

5:24 PM Changeset in webkit [2425] by cblu

• 11 edits in trunk

WebCore:

Fixed: 3023814 - contexual menus and dragging doesn't work for some images

Added a innerNonSharedNode to NodeInfo that points to the node which is not shared by another node. In this case, the innerNonSharedNode is the image node not the area node.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_object.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): use the innerNonSharedNode

WebKit:

Made new plug-in API headers private.

• WebKit.pbproj/project.pbxproj:

4:25 PM Changeset in webkit [2424] by hyatt

• 5 edits in trunk/WebCore

Fix slashdot. Make sure the KONQBLOCK hack just throws away
margins at the tops and bottoms of kids.

• khtml/css/html4.css:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

3:44 PM Changeset in webkit [2423] by darin

• 5 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebKitErrors.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): Rename WebErrorLocationChangeInterruptedByURLPolicyChange to WebErrorLocationChangeInterruptedByPolicyChange.

WebBrowser:

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Rename WebErrorLocationChangeInterruptedByURLPolicyChange to WebErrorLocationChangeInterruptedByPolicyChange.

3:37 PM Changeset in webkit [2422] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Send the new error whenever a policy change happens. The old code was sending a successful completion in the download and ignore cases.

3:27 PM Changeset in webkit [2421] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3080873 -- Error in console when no bookmark file found -[WebBookmarkGroup _loadBookmarkGroupGuts]

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _loadBookmarkGroupGuts]): removed ERROR that was useful only long ago.

WebBrowser:

• fixed buggy case with my previous checkin

• ActivityViewer.h: new ivar _pendingExpansionItems
• ActivityViewer.m: (-[ActivityViewer init]): create empty _pendingExpansionItems (-[ActivityViewer dealloc]): release _pendingExpansionItems (-[ActivityViewer expandPendingItems]): expand _pendingExpansionItems and empty the set (-[ActivityViewer showActivity:]): call expandPendingItems when window becomes visible (-[ActivityViewer addTopLevelActivity:]): if window is not visible, save item in _pendingExpansionItems to expand later.

3:18 PM Changeset in webkit [2420] by rjw

• 9 edits
  4 adds in trunk/WebKit

Added stubs from common WebResourceHandleDelegate base
class.

• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.h:
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.h: Added.
• WebView.subproj/WebBaseResourceHandleDelegate.m: Added.
• WebView.subproj/WebMainResourceClient.h:

3:13 PM Changeset in webkit [2419] by darin

• 5 edits
  4 adds in trunk/WebKit

Make the panel position itself above the main window.
Too bad we can't use a sheet, but this is better than a random position.

• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: (-[WebJavaScriptTextInputPanel initWithPrompt:text:]): Use the new [NSWindow sizeToFitAndAdjustWindowHeight] and [NSControl sizeToFitAndAdjustWindowHeight].

• Misc.subproj/WebNSControlExtras.h: Added.
• Misc.subproj/WebNSControlExtras.m: Added.
• Misc.subproj/WebNSWindowExtras.h: Added.
• Misc.subproj/WebNSWindowExtras.m: Added.
• WebKit.pbproj/project.pbxproj: Added above files.

• English.lproj/StringsNotToBeLocalized.txt: Update.

3:11 PM Changeset in webkit [2418] by hyatt

• 4 edits in trunk/WebCore

Fix for left-hand-side of wired.com. A disturbingly basic
bug. I was applying a parent's margins to its children
when collapsing, even if the parent had a border/padding set
that should have separated it from its kids.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

3:01 PM Changeset in webkit [2417] by kocienda

• 5 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebKitErrors.h: Add new error code to signify that a location change has been interrupted by a change in the URLPolicy governing the load.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Add code to check the URLPolicy for the URL in the request that is submitted to us in this delegate method. Send a locationChangeDone:forDataSource: message with an error using the newly-defined code in cases where the location change should be cancelled.

WebBrowser:

Update LocationChangeHandler to handle the case where the
URLPolicy changes during a page load. This happens in the
case where we attempt to load an FTP URL that looks like
a URL to a file, but turns out to be a URL to a directory.

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:])

2:56 PM Changeset in webkit [2416] by cblu

• 3 edits
  3 adds in trunk/WebKit

Added protocol headers for new plug-in API.

• Plugins.subproj/WebPlugin.h: Added.
• Plugins.subproj/WebPluginContainer.h: Added.
• Plugins.subproj/WebPluginViewFactory.h: Added.
• WebKit.pbproj/project.pbxproj:

2:45 PM Changeset in webkit [2415] by hyatt

• 4 edits in trunk/WebCore

Optimize my inline margin discarding to be smart about the
case when the inline has a block and its beginning or
end. Fixes aintitcool.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

2:40 PM Changeset in webkit [2414] by cblu

• 14 edits
  4 adds
  4 deletes in trunk/WebKit

• Moved things around to make room for new plug-in API.
• Renamed WebNetscapePlugin to WebNetscapePluginPackage.
• Renamed WebNetscapePluginDatabase to WebPluginDatabase.

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPluginPointer:]):
• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView plugin]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]):
• Plugins.subproj/WebNetscapePluginNullEventSender.h: Added.
• Plugins.subproj/WebNetscapePluginNullEventSender.m: Added. (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender dealloc]): (-[WebNetscapePluginNullEventSender sendNullEvents]): (-[WebNetscapePluginNullEventSender stop]):
• Plugins.subproj/WebNetscapePluginPackage.h: Added.
• Plugins.subproj/WebNetscapePluginPackage.m: Added. (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage stringByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]): (-[WebNetscapePluginPackage NPP_SetWindow]): (-[WebNetscapePluginPackage NPP_New]): (-[WebNetscapePluginPackage NPP_Destroy]): (-[WebNetscapePluginPackage NPP_NewStream]): (-[WebNetscapePluginPackage NPP_StreamAsFile]): (-[WebNetscapePluginPackage NPP_DestroyStream]): (-[WebNetscapePluginPackage NPP_WriteReady]): (-[WebNetscapePluginPackage NPP_Write]): (-[WebNetscapePluginPackage NPP_HandleEvent]): (-[WebNetscapePluginPackage NPP_URLNotify]): (-[WebNetscapePluginPackage NPP_GetValue]): (-[WebNetscapePluginPackage NPP_SetValue]): (-[WebNetscapePluginPackage NPP_Print]): (-[WebNetscapePluginPackage MIMEToExtensionsDictionary]): (-[WebNetscapePluginPackage extensionToMIMEDictionary]): (-[WebNetscapePluginPackage MIMEToDescriptionDictionary]): (-[WebNetscapePluginPackage name]): (-[WebNetscapePluginPackage filename]): (-[WebNetscapePluginPackage path]): (-[WebNetscapePluginPackage isLoaded]): (-[WebNetscapePluginPackage pluginDescription]): (-[WebNetscapePluginPackage description]): (functionPointerForTVector): (tVectorForFunctionPointer):
• Plugins.subproj/WebPlugin.h: Removed.
• Plugins.subproj/WebPlugin.m: Removed.
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase pluginForFilename:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h: Removed.
• Plugins.subproj/WebPluginNullEventSender.m: Removed.
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory pluginsInfo]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m: (+[WebController canShowMIMEType:]):

2:36 PM Changeset in webkit [2413] by darin

• 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m

* empty log message *

2:36 PM Changeset in webkit [2412] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added missing import.

1:57 PM Changeset in webkit [2411] by darin

• 4 edits
  6 adds in trunk/WebKit

• fixed 3077305 -- js dialog not yet implemented - crash (fatal error)

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Create a WebJavaScriptTextInputPanel and run it.

• English.lproj/WebJavaScriptTextInputPanel.nib: Added.
• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.h: Added.
• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added.
• WebKit.pbproj/project.pbxproj: Added

1:52 PM Changeset in webkit [2410] by cblu

• 5 edits in trunk/WebKit

Use the mouseDown point instead of the mouseDragged point to determine the mouseOffset when dragging images. When you drag an image now, the point where you clicked is the point where the cursor is in relation to the drag image.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): retain the mouse down event (-[WebHTMLView mouseDragged:]): use the mouse down event
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): release the mouse down event

1:06 PM Changeset in webkit [2409] by hyatt

• 5 edits in trunk/WebCore

Removing konq's flow-around-floats hack for <blockquote> and
<dl>. These objects are allowed to flow under floats. Fixes
www.webreference.com's front page.

Also fixing a bug in my <td> margin collapsing quirk that
prevented lists (ol,ul,dl,menu,dir) from collapsing their
top margins into the td.

• khtml/css/html4.css:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addChild):

1:20 AM Changeset in webkit [2408] by hyatt

• 3 edits in trunk/WebCore

Fix a typo in my change to the h1 rule.

• khtml/css/html4.css:

1:20 AM Changeset in webkit [2407] by hyatt

• 1 edit in trunk/WebCore/khtml/css/html4.css

* empty log message *

12:51 AM Changeset in webkit [2406] by hyatt

• 12 edits in trunk/WebCore

Ok, this patch does a lot of stuff. It contains a complete
rewrite of the WinIE quirk for handling collapsing margins
at the tops and bottoms of table cells. We match WinIE's
behavior for all HTML4 block-level elements.

This patch also applies a bottom margin to <form> elements,
which is what was causing the missing space on livepage.apple.com
underneath the textfield on the right. WinIE and Gecko both
put a bottom margin on all forms.

This patch also updates the collapsing margin code to detect
inlines that have been morphed into blocks by KHTML (this is
so wrong, don't even get me started, you can't treat an inline
as a block, this code is lame, etc. etc.) and to properly ignore
their margins completely. Fixing the code to not morph inlines
is another architectural problem that will have to be dealt
with (sigh).

• khtml/css/css_valueimpl.h:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue): (StyleBaseImpl::parseUnit):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp:
• khtml/css/html4.css:
• khtml/misc/khtmllayout.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren): (RenderFlow::addChild):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_object.h:

Oct 21, 2002:

5:45 PM Changeset in webkit [2405] by darin

• 13 edits
  1 delete in trunk

WebCore:

• kwq/KWQInputDialog.mm: (QInputDialog::getText): Call the view factory to do the heavy lifting.

• kwq/WebCoreViewFactory.h: Add runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:. Use a protocol for the subclass responsibility.
• kwq/WebCoreViewFactory.m: Remove stub methods not needed because of the subclass responsibility technique we are using.

• kwq/qt/qstylesheet.h: Made this inline, since it does nothing.
• kwq/KWQStyleSheet.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQStyleSheet.mm.

WebKit:

• WebCoreSupport.subproj/WebViewFactory.h: Changed to use new protocol scheme so we get an error if we forget to implement something.
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Stub.

5:28 PM Changeset in webkit [2404] by rjw

• 10 edits in trunk/WebKit

Real checkin this time!

5:00 PM Changeset in webkit [2403] by trey

• 4 edits in trunk/WebKit

WebFoundation:

Fixed typos and other doc comment errors found during API review.

• CacheLoader.subproj/WebCacheManager.m:
• CacheLoader.subproj/WebProtocolHandler.h:
• Misc.subproj/WebError.h:

WebKit:

Fixed typos and other doc comment errors found during API review.

• WebView.subproj/WebController.h:

4:09 PM Changeset in webkit [2402] by rjw

• 14 edits in trunk/WebKit

Modernized the activity window a little bit. Fixed
a slew of activity related bugs.

• BrowserWebController.m: (-[BrowserWebController identifierForInitialRequest:fromDataSource:]): (-[BrowserWebController resource:willSendRequest:fromDataSource:]): (-[BrowserWebController resource:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resource:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resource:didFinishLoadingFromDataSource:]):
• FrameProgressEntry.h:
• FrameProgressEntry.m: (-[FrameProgressEntry _initWithFrame:]): (-[FrameProgressEntry provisionalDataSourceWasCommitted]): (-[FrameProgressEntry activeSubresourcesForDataSource:]): (-[FrameProgressEntry trackSubresource:forDataSource:]): (-[FrameProgressEntry completedEntry:fromDataSource:]): (-[FrameProgressEntry trackSubframe:fromDataSource:]): (-[FrameProgressEntry resetProvisionalLoad]):
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor _incrementProgressBarWithOldBytes:newBytes:oldTotal:newTotal:isMainResource:]): (-[LoadProgressMonitor createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor completedEntry:fromDataSource:]): (-[LoadProgressMonitor receivedError:forEntry:fromDataSource:]): (-[LoadProgressMonitor receivedUpdateForEntry:URLString:bytesLoaded:bytesExpected:error:dataSource:]):
• ResourceProgressEntry.h:
• ResourceProgressEntry.m:

Changed WebResourceLoadDelegate methods to include an identifier
as first parameter. This will help clients track callbacks relating
to a particular resource. Added identifierForInitialRequest:fromDataSource:
so clients can create their own identifier.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceLoadDelegate.h:

3:41 PM Changeset in webkit [2401] by hyatt

• 10 edits in trunk/WebCore

Implement support for a new @-rule called @konq-quirks. This
will allow us to put style rules into html4.css that only
apply for pages in quirks mode.

• khtml/css/css_ruleimpl.cpp: (CSSQuirksRuleImpl::CSSQuirksRuleImpl): (CSSQuirksRuleImpl::~CSSQuirksRuleImpl): (CSSQuirksRuleImpl::cssRules): (CSSQuirksRuleImpl::appendRule): (CSSQuirksRuleImpl::insertRule): (CSSQuirksRuleImpl::deleteRule):
• khtml/css/css_ruleimpl.h:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseAtRule):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/dom/css_rule.h:

2:19 PM Changeset in webkit [2400] by cblu

• 7 edits in trunk/WebKit

WebFoundation:

Partial fix for 2968124 - file misnamed on download

• added the "filename" method to response so that the logic for getting the correct filename for a resource is in one easy place.
• obey the "Content-Disposition" header. Not totally fixed because the parsing doesn't totally work.

• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse filename]): new, filename by using "Content-Disposition" and MIME type. (-[WebResourceResponse _setContentType:]): no changes, but I added _setFilename
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• Misc.subproj/WebFileTypeMappings.h: remove unused method
• Misc.subproj/WebFileTypeMappings.m: remove unused method
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]): call _setFilename for the "Content-Disposition"

WebKit:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andURL:inFrame:withContentPolicy:]):

12:45 PM Changeset in webkit [2399] by darin

• 4 edits in trunk/WebKit

• fixed 3080512 -- REGRESSION: moving from old page to new one, we get blank white before the new one is ready

Roll out a bunch of my changes, because they weren't complete. Added FIXMEs for the
problems I was unsuccessfully trying to fix.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView isOpaque]), (-[WebView drawRect:]): Roll back.

12:09 PM Changeset in webkit [2398] by darin

• 5 edits in trunk/WebCore

Remove closeEntireTree now that deferred close takes care of that case.

• khtml/html/htmlparser.cpp: (KHTMLParser::startBody):
• khtml/rendering/render_object.h:

11:23 AM Changeset in webkit [2397] by darin

• 4 edits in trunk/WebCore

• fixed 3075041 -- text larger/smaller increment too large when font-size specified as %

• khtml/css/cssstyleselector.cpp: Don't apply the zoom factor to a font size that already has the zoom factor applied.

11:12 AM Changeset in webkit [2396] by darin

• 5 edits in trunk/WebKit

• fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

Once more, with feeling.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutIfSizeChanged:]): Added setNeedsDisplay:YES here. The lack of this is what caused the bug. But also don't do any work when the size doesn't change. This prevents this from being called at all in the scrolling case, which is what we want. (-[WebHTMLView viewWillMoveToSuperview:]): Just the name change. (-[WebHTMLView layout]): Store the layout size for the above methods.
• WebView.subproj/WebHTMLViewPrivate.h: Add a place to store the size.

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): Roll this change back in.

11:04 AM Changeset in webkit [2395] by darin

• 4 edits in trunk/WebCore

• khtml/khtmlview.cpp: (KHTMLView::clear): Default to fast scrolling. I'm pretty sure this was just backwards here.

8:53 AM Changeset in webkit [2394] by darin

• 3 edits in trunk/WebKit

• fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): My change to this caused the regression. Not sure why, but I'll just back out because the change wasn't important.

3:06 AM Changeset in webkit [2393] by hyatt

• 4 edits in trunk/WebCore

DLs are supposed to have margins.

• khtml/css/html4.css:

1:16 AM Changeset in webkit [2392] by hyatt

• 4 edits in trunk/WebCore

Fix for margin problems on aintitcool.com. There was a subtlety
to WinIE's quirk. For <h1>-<h6> only, they don't collapse the
bottom margin for table cells (they still collapse the top
margin). I just love emulating the odd behavior of WinIE.
Wheee.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Oct 20, 2002:

11:11 PM Changeset in webkit [2391] by cblu

• 3 edits in trunk/WebKit

Fixed: 3025847 - Can't use any menu command keys after clicking on a plugin

Don't give plug-ins command-modified keys anymore because the ability wasn't worth the annoyance. If only plug-ins truthfully responded t events! Anyway, filed 3080103 so that I can look into a way to make this work for everybody.

• Plugins.subproj/WebBaseNetscapePluginView.m:

11:03 PM Changeset in webkit [2390] by darin

• 4 edits in trunk/WebCore

Redid my fix. It was just an ordering thing. The image had to already be
installed as the current image before calling ref(), because in the cached
case, you get the loading complete callback right then.

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Call deref on the old image later. Basically, instead of moving the ref of the new image up, I moved the deref of the old image down.

10:39 PM Changeset in webkit [2389] by darin

• 4 edits in trunk/WebCore

Roll out my render_image.cpp change. It was causing a big problem
getting images from the cache. I need to study further to figure out why.

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Roll back the change.

10:03 PM Changeset in webkit [2388] by cblu

• 4 edits in trunk/WebKit

Fixed: 3025868 - Plugin context menu disappears then reappears if you click off of it

Also fixed some rare dragging weirdness in WebHTMLView. If you attempted to drag a plug-in after dragging an image, the image would drag again.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView mouseDragged:]): subclass and do nothing to prevent calling mouseDragged in WebHTMLView (-[WebBaseNetscapePluginView performKeyEquivalent:]): no changes to this method, removed menuForEvent, wasn't needed after all
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream stop]): minor clean-up

9:02 PM Changeset in webkit [2387] by hyatt

• 4 edits in trunk/WebCore

Rewrite the clearing code for floats. Rewrote the
collapsing margin code to really work with floating and
clearing. This fixes the right hand side of wired.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::checkClear): (RenderFlow::addChild):

5:41 PM Changeset in webkit [2386] by darin

• 4 edits in trunk/WebCore

• fixed 3007961 -- Crash in DOM::HTMLImageElementImpl::parseAttribute

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Be sure to call ref on the new image before calling deref on the old image. That's because deref on the old image causes a cache flush, which might cause the image to go away in certain cases.

5:08 PM Changeset in webkit [2385] by cblu

• 4 edits in trunk/WebCore

Fixed possible build failure.

• kwq/KWQDOMNode.cpp: (isImage): remove unused variable.

4:54 PM Changeset in webkit [2384] by darin

• 3 edits in trunk/WebKit

• fixed a minor problem with autorelease I just ran into

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Create an autorelease pool for the benefit of the class initialize functions that will be called.

4:18 PM Changeset in webkit [2383] by cblu

• 4 edits in trunk/WebCore

Partial fix for:
3023814 - contexual menus and dragging doesn't work for some images

The image map case is still broken because I need to find a way to get the RenderImage for an AREA node. Anyone know how?

• kwq/KWQDOMNode.cpp: (isImage): Also return true if the node is an INPUT tag with TYPE set to "image"

3:10 PM Changeset in webkit [2382] by cblu

• 13 edits in trunk/WebKit

Fixed 3050010: Should show contextual menu for WebImageView
Also made drags from WebImageView work.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: added _web_setPromisedImageDragImage which does the hackery to extend the promised file drag for images
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _menuForElement:]): added, gets menu items from delegate and creates menu
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): simplified, gets element and calls -[WebController _menuForElement:] (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: when dragging image
• WebView.subproj/WebImageRepresentation.h:
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release the URL (-[WebImageRepresentation URL]): added so WebImageView can get the URL (-[WebImageRepresentation setDataSource:]): retain the URL
• WebView.subproj/WebImageView.h: use new drag bools
• WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): ditto (-[WebImageView setAcceptsDrags:]): ditto (-[WebImageView acceptsDrags]): ditto (-[WebImageView setAcceptsDrops:]): ditto (-[WebImageView acceptsDrops]): ditto (-[WebImageView controller]): new (-[WebImageView menuForEvent:]): new, creates element and calls -[WebController _menuForElement:] (-[WebImageView mouseDragged:]): drag promised file (-[WebImageView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): new

12:59 PM Changeset in webkit [2381] by darin

• 7 edits in trunk/WebKit

• fixed a problem where you would get garbage bits when resizing while loading a standalone image

Cleaned up some of the complexity of how we were handling resizing.

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Do the update twice to properly handle the case where a disappearing scroller makes a second scroller appear or vice versa.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Remove the code that was trying to set the setDrawsBackground flag on the scroll view. It was doing it wrong, causing bugs with drawing non-HTML views while loading. Also, it wasn't working as an optimization, since the window was still drawing the metallic background behind. We can revisit adding an optimization at the WebHTMLView level if it creates a measurable speed increase, but we must be careful to test loading with non-HTML views along with the HTML cases.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutToYes:]): Added. Calls setNeedsLayout:YES. (-[WebHTMLView viewWillMoveToSuperview:]): Added. Registers so we get _setNeedsLayoutToYes: calls when the superview's size changes. This allows us to do a layout at all the right times. (-[WebHTMLView layout]): Call setNeedsDisplay:YES, because if we do a layout without a complete display the screen will look bad. Also do a reapplyStyles, because if there are pending style changes we want to apply them before doing a layout since they could affect the layout. (-[WebHTMLView drawRect:]): Remove the special case that says to always relayout during live resize, because it works without a special case now. For the other live resize case, turn it from a special case into a general one. Any time layout is done, make sure to draw the entire view, not just the passed-in rectangle, and call setNeedsDisplay:NO so we don't do it all over again.

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): Explicitly set frame size to 0,0 when there is no image.

• WebView.subproj/WebView.m: Remove now-unnecessary viewWillStartLiveResize, setFrame:, viewDidEndLiveResize, isOpaque, and drawRect overrides. (-[WebView initWithFrame:]): Don't call setDrawsBackground:NO for the reasons above. Don't set scroll bar visibility because the dynamic scroll bars view handles that already.

9:09 AM Changeset in webkit [2380] by darin

• 4 edits in trunk/WebCore

• fixed 3076390 -- crash in DOM::DocumentImpl::setParsing loading thread detail page at groups.apple.com

• khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't do any redirect special case if the document is nil. Just do a normal load in that case.

8:40 AM Changeset in webkit [2379] by darin

• 5 edits in trunk/WebCore

• fixed 3079864 -- REGRESSION: assertion failure on any page with a form element

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Roll back the parent call to use NodeBaseImpl::attach. Not sure why I changed that at the last minute before my last checkin, but it was *bad*.

• fixed a crash I observed when clicking on an about:blank page

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Check for nil renderer.

Oct 19, 2002:

10:10 PM Changeset in webkit [2378] by darin

• 3 edits in trunk/WebKit

• fixed 3073693 -- flash drawn to screen even when window minimized

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Set up additional notifications. Don't start the null event sender if the window is miniaturized. (-[WebBaseNetscapePluginView windowDidMiniaturize:]): Stop the null event sender. (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Start the null event sender.

4:41 PM Changeset in webkit [2377] by darin

• 8 edits in trunk/WebCore

• fixed 3075032 -- textarea contents sometimes aren't shown

The root of the problem is that we weren't delivering close calls to
the render objects in the case where we created them late due to our FOUC
fix. I taught the DOM implementation to remember that a close call is
due, and deliver it when the render object is created. We can probably
replace the closeEntireTree hack with this too. I'll talk to Dave about
that on Monday.

• khtml/xml/dom_nodeimpl.h: Add m_rendererNeedsClose and closeRenderer.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): Initialize m_rendererNeedsClose to false. (NodeImpl::closeRenderer): Call close on the renderer if it's created, otherwise set m_rendererNeedsClose. (NodeImpl::attach): If the renderer is created and m_rendererNeedsClose is true call close on the renderer and set it to false.

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Rearrange this so that the base class attach is called before updateFromElement is called. This allows the base attach to do a close for us before we update.

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Call closeRenderer on the DOM node rather than calling close on the render node. (KHTMLParser::popOneBlock): Ditto.
• khtml/xml/xml_tokenizer.cpp: (XMLHandler::endElement): Ditto. (XMLTokenizer::finish): Ditto.

10:19 AM Changeset in webkit [2376] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Removed stray printf.

1:11 AM Changeset in webkit [2375] by hyatt

• 5 edits in trunk/WebCore

A couple of whitespace fixes. What's really odd about these
fixes is that they *work* but only if you load the page by
hitting "Back". I suspect that I've now fixed the bugs on
KHTML's end, and we have some sort of whitepsace dropping
problem on our end.

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write):

Oct 18, 2002:

5:27 PM Changeset in webkit [2374] by rjw

• 15 edits in trunk

Fixed khtml to ignore <title> tags after the first tag.

Fixed setting document.title from JavaScript.

• khtml/dom/html_document.cpp: (HTMLDocument::setTitle):
• khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged):

Changed name to setUsesBackForwardList: from
setUseBackForwardList. ditto for useBackForwardList

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setUsesBackForwardList:]): (-[WebController usesBackForwardList]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]):

Fixed history items that have "untitled" title after
redirect. (3078577).

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):

Made title of snippet window change to match document title, if
present.

• Debug/SnippetController.h:
• Debug/SnippetController.m: (-[SnippetController setTitle:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]):

3:08 PM Changeset in webkit [2373] by darin

• 4 edits in trunk/WebCore

• fixed 3078293 -- Implement evaluateJavaScript on WebController

• kwq/KWQVariant.mm: (QVariant::asString): Made this return reasonable values for types other than string. Still may be loose ends left, but this takes care of most of it.

3:00 PM Changeset in webkit [2372] by darin

• 11 edits in trunk

WebCore:

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebKit:

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebBrowser:

• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
• BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Update to call stringByEvaluatingJavaScriptFromString.

1:49 PM Changeset in webkit [2371] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
• English.lproj/Localizable.strings: Regenerate after recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

• LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): Say "Contacting <host>" instead of "Looking for <host>" to help reduce confusion about whether this shows up just during DNS or not.

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
• English.lproj/Localizable.strings: Regnerate.

1:26 PM Changeset in webkit [2370] by kocienda

• 3 edits in trunk/WebKit

Removed unneeded import of WebFoundation/WebResourceLoadManager.h

• Misc.subproj/WebIconLoader.m

1:20 PM Changeset in webkit [2369] by hyatt

• 7 edits in trunk/WebCore

The collapsing margin rewrite. Also fixes a bug where
we stay in quirks mode for strict HTML4 dtds when we
shouldn't.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode):
• khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_object.h:

11:10 AM Changeset in webkit [2368] by darin

• 7 edits in trunk

WebCore:

• Makefile.am: Move dependency so clean happens before build.

WebKit:

• Makefile.am: Move dependency so clean happens before build.

11:01 AM Changeset in webkit [2367] by darin

• 3 edits in trunk/WebKit

• force-clean-timestamp: Dependencies don't work well enough, so we need a clean build here after the WebFoundation domain change.

10:13 AM Changeset in webkit [2366] by darin

• 7 edits
  1 delete in trunk/WebKit

WebFoundation:

WebError cleanup. Change domains to be strings, remove unused codes.

• AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:]): Don't return an error code. The error code was always vague, and never looked at by our one client or exposed outside WebFoundation. If we later want to report a precise error, we can easily re-add it.

• CacheLoader.subproj/WebResourceLoad.h: Change domain parameter to an NSString *.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): Ditto.

• Misc.subproj/WebError.h: Moved WebErrorDomainWebKit to WebKit. Removed WebErrorDomainFTP. Removed WebErrorCodeNoError, WebErrorCodeHTTPUnknownAuthenticationSchemeError, and WebErrorCodeHTTPBadAuthenticationHeaderError, which were never used. Changed methods to take NSString * for the error domain. Added errorIsInDomain method.
• Misc.subproj/WebError.m: (-[WebErrorPrivate dealloc]): Release the error domain string. (classInitialize): Remove descriptions for now-unused error codes. (-[WebError initWithErrorCode:inDomain:failingURL:]): Take a domain string. (-[WebError errorDomain]): Return the domain string. (-[WebError errorIsInDomain:]): Added. (-[WebError errorDescription]): Update to look up by string. (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Use domain string as key.

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]): Get rid of the code that stored the authenticationFailureResult, which was never passed to the user.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove authenticationFailureResult.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Rearrange the code so we don't use WebErrorCodeNoError. Also change the domain so that we don't report the WebErrorCodeCannotConnectToHostError error in the SSL domain any more.

• WebFoundation.exp: Export the new domain string globals.

WebKit:

Update for WebFoundation error domain changes.

• Misc.subproj/WebKitErrors.h: Put WebErrorDomainWebKit in here. Also remove WebErrorNoError and the WebErrorCode name for the enum.
• WebKit.exp: Export the WebErrorDomainWebKit constant.
• WebView.subproj/WebView.m: Define the WebErrorDomainWebKit.

• WebKit.pbproj/project.pbxproj: Always use WebKit.exp.
• Makefile.am: Don't generate WebKit-combined.exp any more.
• WebKit-tests.exp: Removed.

WebBrowser:

Update for WebFoundation error domain changes.

• LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Use the new errorIsInDomain method instead of doing a switch statement, since that works with NSString. (-[LocationChangeHandler specializedMessageForError:]): Ditto.

Oct 17, 2002:

11:41 PM Changeset in webkit [2365] by darin

• 2 edits in trunk/WebKit

• fixed 3078644 -- Odd clipping in frame

• WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
• WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.

11:40 PM Changeset in webkit [2364] by darin

• 5 edits in trunk/WebKit

A small change that eliminates a variety of strange clipping problems, including ones that
make large swathes of the page disappear.

• WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
• WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.

5:30 PM Changeset in webkit [2363] by rjw

• 11 edits in trunk

Support for drawing frame borders and frame resizing. (fixes 2982466).

• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]):
• kwq/qt/qframe.h:

Support for drawing frame borders (fixes 2982466).

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _drawBorder:]): (-[WebHTMLView drawRect:]):

5:18 PM Changeset in webkit [2362] by darin

• 8 edits in trunk/WebCore

• fixed 2807340 -- Alex is case sensitive for anchors, but should not be in quirks mode (other browsers aren't)

• khtml/dom/html_misc.cpp: Touched this file to prevent us from requiring a full build. Damned header dependencies still don't work right.

• khtml/html/html_miscimpl.h: Add caseSensitive parameters.
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): Add caseSensitive parameter, and compare by converting both to lower case if it's false and pass it on when recursing. (HTMLCollectionImpl::namedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedFormItem): Pass along, and handle, it. (HTMLFormCollectionImpl::getNamedImgItem): Ditto. (HTMLFormCollectionImpl::nextNamedItemInternal): Pass true for caseSensitive.

• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Pass false for the new caseSensitive parameter to namedItem when the document mode is not strict.

• kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): Removed a stray NSLog that I left in by accident.

4:04 PM Changeset in webkit [2361] by darin

• 6 edits in trunk/WebCore

• fixed 3052547 -- <select> doesn't size properly (size > 1)

• khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed): #if !APPLE_CHANGES around some unused code in here. (RenderSelect::updateFromElement): Fix bug where it was using Multi here, but Extended elsewhere for the selection mode. (RenderSelect::layout): Change code so that QListBox handles the sizing.

• kwq/KWQListBox.h: Removed a lot of unused stuff, made other things use inlines.
• kwq/KWQListBox.mm: Rewrote most of the file contents. Made a new QListBox::sizeForNumberOfLines method. We will have to port this to NSTableView rather than NSBrowser.

2:05 PM Changeset in webkit [2360] by darin

• 4 edits in trunk/WebCore

• fixed 3078245 -- REGRESSION: lightgrey displays as black, used to display as white, should display light gray

• kwq/KWQColor.mm: (getNamedColors): For every color with the name "gray" in it, also include the version spelled "grey" as other browsers seem to.

1:14 PM Changeset in webkit [2359] by sullivan

• 8 edits in trunk/WebKit

WebKit:

• added support for bookmark identifiers, to be used for marking bookmark proxies uniquely (independent of localized title). This is not the old unique-identifier scheme; now identifiers are optional, and initially nil, but the client can use them for its own purposes.

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): release identifier (-[WebBookmark identifier]): return identifier (-[WebBookmark setIdentifier:]): set identifier
• Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkLeaf dictionaryRepresentation]): save identifier (-[WebBookmarkLeaf copyWithZone:]): copy identifier
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkList dictionaryRepresentation]): save identifier (-[WebBookmarkList copyWithZone:]): copy identifier
• Bookmarks.subproj/WebBookmarkPrivate.h:
• Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkProxy dictionaryRepresentation]): save identifier (-[WebBookmarkProxy copyWithZone:]): copy identifier

WebBrowser:

• a bunch of work in the direction of getting the special "bookmark sources" to work in the bookmarks view. The Address Book contents now appear in the Bookmarks view, but Rendezvous and History don't yet.

• BookmarkSource.h: Added. Defines protocol to be used by special bookmark sources.

• BookmarksController.h: define identifier constants used for special bookmark sources.
• BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): set identifiers on bookmark proxies representing special bookmark sources

• BookmarksViewController.m: (-[BookmarksViewController undoRemoveBookmarks:]): (-[BookmarksViewController selectedContentItems]): (-[BookmarksViewController deleteContentItems:]): (-[BookmarksViewController deleteSelectedContentItems]): (-[BookmarksViewController doubleClick:]): (-[BookmarksViewController newBookmarkFolder:]): (-[BookmarksViewController bookmarkSourceForProxyIdentifier:]): (-[BookmarksViewController refreshContents]): (-[BookmarksViewController bookmarksFromContentItems:]): (-[BookmarksViewController bookmarkFromContentItem:]): (-[BookmarksViewController canAddToBookmarkSource:]): (-[BookmarksViewController canAddToSelectedBookmarkSource]): (-[BookmarksViewController canDeleteFromSelectedBookmarkSource]): (-[BookmarksViewController child:ofContentItem:]): (-[BookmarksViewController isContentItemExpandable:]): (-[BookmarksViewController numberOfChildrenOfContentItem:]): (-[BookmarksViewController titleStringForContentItem:]): (-[BookmarksViewController addressStringForContentItem:]): (-[BookmarksViewController imageForContentItem:]): (-[BookmarksViewController shouldEditTableColumn:forContentItem:]): (-[BookmarksViewController tableView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController cleanUpAfterDraggingBookmarksWithOperation:]): (-[BookmarksViewController prepareForDraggingBookmarks:fromSourceColumn:]): (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): (-[BookmarksViewController handleKeyDown:inSourceColumn:]): (-[BookmarksViewController tableViewSelectionDidChange:]): (-[BookmarksViewController outlineView:child:ofItem:]): (-[BookmarksViewController outlineView:isItemExpandable:]): (-[BookmarksViewController outlineView:numberOfChildrenOfItem:]): (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksViewController outlineView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController outlineView:writeItems:toPasteboard:]): (-[BookmarksViewController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): (-[BookmarksViewController copy:]): (-[BookmarksViewController delete:]): My brain gets sore thinking about writing individual comments here. Basically I generalized methods that were dealing explicitly with bookmarks to deal with opaque "content items" instead, then delegate to the appropriate BookmarkSource in the bottleneck methods. Only Address Book is hooked up so far. This also fixed lots of trouble you could get into if you played with the "not implemented yet" items too much.

• ABHomePagesController.h:
• ABHomePagesController.m: (-[ABHomePagesController refreshContents]): (-[ABHomePagesController canDeleteContents]): (-[ABHomePagesController deleteContentItems:]): (-[ABHomePagesController isContentItemExpandable:]): (-[ABHomePagesController child:ofContentItem:]): (-[ABHomePagesController numberOfChildrenOfContentItem:]): (-[ABHomePagesController bookmarkFromContentItem:]): (-[ABHomePagesController bookmarksFromContentItems:]): (-[ABHomePagesController addressStringForContentItem:]): (-[ABHomePagesController titleStringForContentItem:]): (-[ABHomePagesController imageForContentItem:]): Implement BookmarkSource protocol; I haven't deleted all the similar code that drives the Address Book window yet.

• English.lproj/MainMenu.nib: changed "Last Search Results" to "SnapBack to Search" under protest.

• WebBrowser.pbproj/project.pbxproj: updated for new file

12:06 PM Changeset in webkit [2358] by hyatt

• 4 edits in trunk/WebCore

Make navigator.product dynamic based off user agent (i.e.,
make it participate in spoofing too).

• khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):

11:10 AM Changeset in webkit [2357]

• 3 copies in tags/Alexander-28

This commit was manufactured by cvs2svn to create tag 'Alexander-28'.

11:10 AM Changeset in webkit [2356] by sheridan

• 8 edits in trunk

Alex-28

10:12 AM Changeset in webkit [2355] by darin

• 5 edits in trunk/WebCore

• fixed 3077856 -- REGRESSION: scroll to fragment doesn't work (except when Alex started from command line)

• kwq/kparts/browserextension.h: Initialize reload to false. It was uninitialized, and when true was preventing anchor navigation from working.

9:48 AM Changeset in webkit [2354] by darin

• 4 edits in trunk/WebKit

• fixed 3062613 -- too many redirects at nytimes.com and apple

Our cookie policy was rejecting the cookies from nytimes.com -- the policy base
URL was still the news.com URL from before the redirect.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update the cookie policy URL when a redirect changes the data source's URL.

9:17 AM Changeset in webkit [2353] by darin

• 3 edits in trunk/WebKit

• fixed 3077910 -- REGRESSION: download window open at startup time -> no scrollbars

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Check for WebDocumentView protocol before making the layout method call. Prevents exception when WebDynamicScrollBarsView is used with a document that is not a WebDocumentView.

1:05 AM Changeset in webkit [2352] by darin

• 4 edits in trunk/WebCore

• fixed 3075992 -- Hang in khtml::RenderFlow::lowestPosition() trying to render ​http://avoyagetoarcturus.blogspot.com/

• khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't recurse on the same child twice. (RenderFlow::rightmostPosition): Ditto.

1:03 AM Changeset in webkit [2351] by hyatt

• 4 edits in trunk/WebCore

Fix bayarea.com. My implementation of offsetParent was
flawed. And to think I was blaming Gecko... ;)

• khtml/rendering/render_object.cpp: (RenderObject::offsetParent):

Oct 16, 2002:

10:43 PM Changeset in webkit [2350] by darin

• 5 edits in trunk/WebCore

• fixed 3061103 -- Line-breaks lost when submitting after pasting text from MSIE into Alexander textarea

• kwq/KWQLineEdit.mm: (QLineEdit::text):
• kwq/KWQTextEdit.mm: (QTextEdit::text): Turn \r\n sequences and standalone \r characters into \n characters on the way out of AppKit land and into KHTML land. I didn't try to make this efficient for the common case because these are not time-critical functions.

6:08 PM Changeset in webkit [2349] by rjw

• 13 edits in trunk

i Fixed a few regressions in drawing of frame resize handle

in preparation for drawing frame borders and completing
2982466.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
• kwq/KWQPainter.mm: (QPainter::drawRect):
• kwq/qt/qscrollview.h:
• kwq/KWQScrollView.mm: (QScrollView::updateContents):
• kwq/KWQWidget.mm: (QWidget::enableFlushDrawing):

Use static_cast everywhere DOM::NodeImpl is cast to
subclass.

• kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode DOM::]): (-[WebCoreDOMNodeList DOM::]): (-[WebCoreDOMNamedNodeMap DOM::]): (-[WebCoreDOMAttr DOM::]):

Added some drawing debug code (ifdef excluded).

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):

5:37 PM Changeset in webkit [2348] by hyatt

• 7 edits in trunk/WebCore

Fix crash on pages with bulleted lists. Making sure the list
item marker doesn't get a layer (which means it has to be
painted by hand now by the list item object).

• khtml/rendering/render_box.cpp: (RenderBox::setStyle):
• khtml/rendering/render_list.cpp: (RenderListItem::printObject):
• khtml/rendering/render_list.h:
• khtml/rendering/render_object.h:

5:01 PM Changeset in webkit [2347] by darin

• 4 edits in trunk/WebCore

• fixed 3072542 -- double "&" in submit button

• khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Don't double the "&" character, not needed for KWQ.

4:49 PM Changeset in webkit [2346] by darin

• 3 edits in trunk/WebKit

Fixed anomalies with plugin positioning caused by my switch to
NSViewFocusDidChangeNotification. Turns out that is not sent during
live resize, but we need things to work during live resize.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Register for changes in the bounds and frame of all superviews again, instead of using NSViewFocusDidChangeNotification.

4:28 PM Changeset in webkit [2345] by hyatt

• 5 edits in trunk/WebCore

When render objects were being dynamically wrapped in anonymous
blocks, the layer parenting connection was being broken without
being reconnected when the wrapping finished. This patch
shifts the layer connection into the functions that are also
called in the dynamic case.

With this fix, all objects on mrskin finally show up. Yeehah.
brainjar.com's brain is back too.

This patch also stops treating images as inline if they are
using abs/fixed positioning, since according to the CSS spec,
abs/fixed positioned elements should be treated as block-level
content.

• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_image.cpp: (RenderImage::setStyle):

4:24 PM Changeset in webkit [2344] by darin

• 9 edits in trunk/WebCore

• fixed 3045570 -- can't select a printer at inkfinder.com

• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Call the new openURL for the case where we are reusing a part. We do this backwards from how KHTML does, so it's twisted.

• kwq/KWQKHTMLPartImpl.h: Add openURL.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Tell the bridge to load the URL.

• kwq/mac-encodings.txt: Tweak Korean encoding names.

3:41 PM Changeset in webkit [2343] by rjw

• 3 edits in trunk/WebKit

Fixed 2969367. Ensure layout happens before doing check
to determine if scrollbars are needed. Ahhh, dynamic
scrollbars work so much better now.

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):

3:01 PM Changeset in webkit [2342] by darin

• 3 edits in trunk/WebKit

Fixed the problem where we would leave white bits when making the window larger.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): During live resize, use the visible rectangle after doing layout, not before.

2:55 PM Changeset in webkit [2341] by hyatt

• 9 edits in trunk/WebCore

A very substantial change. Absolute/fixed positioned elements that
are NOT renderflows were not getting layers constructed for them.
They do now.

Also, floats now have layers constructed for them. This allows
printSpecialObjects to be completely eliminated, enables smarter
damge rect intersection testing for faster painting, and fixes
regressions on sites like www.demian5.com.

• khtml/rendering/render_box.cpp: (RenderBox::setStyle):
• khtml/rendering/render_flow.cpp: (RenderFlow::printObject): (RenderFlow::addOverHangingFloats): (RenderFlow::printTree):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/rendering/render_root.cpp: (RenderRoot::printObject):
• khtml/rendering/render_table.cpp: (RenderTable::print):

1:40 PM Changeset in webkit [2340] by rjw

• 10 edits in trunk

Fixed 3059237, which was fixed, but regressed.

Fixed regression in visited links due to change is semantics of
[dataSource request], added [dataSource _originalRequest]. Items
always need to be added to history with the original request.

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _originalRequest]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):

Removed bogus code.

• kwq/KWQKHistoryProvider.mm:

10:03 AM Changeset in webkit [2339] by darin

• 11 edits in trunk/WebKit

WebKit:

• fixed 3017152 -- intra-page anchors not updating page address field

• WebView.subproj/WebLocationChangeDelegate.h: Rearrange methods so they are in the order they are delivered. Add locationChangedWithinPageForDataSource method. Renamed the redirect methods to match the verb tenses used in the others. Removed the URL parameter from the server redirect method.
• WebView.subproj/WebLocationChangeDelegate.m: Update the class to match the changes to the protocol.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Update for change to clientWillRedirectTo method name. (-[WebBridge loadURL:]): Call locationChangedWithinPageForDataSource:.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Update for change to serverRedirectedForDataSource method name.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseMovedNotification:]): Remove overzealous assert that was firing for me.

• WebCoreSupport.subproj/WebSubresourceClient.m: Update comment.
• WebView.subproj/WebDataSource.h: Fix comment.

WebBrowser:

WebBrowser changes to handle location changes within a page (clicks on anchors).

• BrowserWindowController.h: Added mainFrameLocationChangedWithinPage.
• BrowserWindowController.m: (-[BrowserWindowController mainFrameLocationChangedWithinPage]): Calls setLocationFieldTextToCurrentURL.
• LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectedForDataSource:]): Updated name to track change in WebKit. Also removed unnecessary calls to titleChangedForFrame and to _currentURLHasChanged, since both are only needed if the data source is committed, and server redirects always come before it is committed. (-[LocationChangeHandler locationChangedWithinPageForDataSource:]): Added. Has much of what used to be in serverRedirectedForDataSource, and also calls the new mainFrameLocationChangedWithinPage. (-[LocationChangeHandler clientWillRedirectTo:delay:fireDate:forFrame:]): Updated name to track change in WebKit.

Oct 15, 2002:

6:42 PM Changeset in webkit [2338] by rjw

• 6 edits in trunk/WebCore

• kwq/WebCoreBridge.mm: (attributedString): Don't convert element unless it has a renderer.

• kwq/WebCoreDOMNode.mm: (-[WebCoreDOMAttr DOM::]): (-[WebCoreDOMAttr name]): (-[WebCoreDOMAttr specified]): (-[WebCoreDOMAttr value]): (-[WebCoreDOMAttr ownerElement]): (-[WebCoreDOMElement tagName]): (-[WebCoreDOMElement setAttribute::]): (-[WebCoreDOMElement removeAttribute:]): (-[WebCoreDOMElement getAttributeNode:]): (-[WebCoreDOMElement removeAttributeNode:]): (-[WebCoreDOMElement getElementsByTagName:]): (-[WebCoreDOMElement getAttributeNS::]): (-[WebCoreDOMElement setAttributeNS:::]): (-[WebCoreDOMCharacterData data]): (-[WebCoreDOMCharacterData setData:]): (-[WebCoreDOMCharacterData length]): (-[WebCoreDOMCharacterData substringData::]): (-[WebCoreDOMCharacterData appendData:]): (-[WebCoreDOMCharacterData insertData::]): (-[WebCoreDOMCharacterData deleteData::]): (-[WebCoreDOMText splitText:]): (-[WebCoreDOMProcessingInstruction data]): (-[WebCoreDOMProcessingInstruction setData:]):
• kwq/WebCoreDOMPrivate.h: API cleanup.

5:39 PM Changeset in webkit [2337] by hyatt

• 4 edits in trunk/WebCore

More work on making blocks correctly compute their maximal
positive and negative margins. Adding code to ensure
that floats and absolute/fixed positioned elements know
not to collapse with children or with themselves. Also adding
code to teach empty blocks that they can collapse their own
margins together.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):

5:15 PM Changeset in webkit [2336] by darin

• 18 edits in trunk

WebCore:

WebCore support for using referrer even in loads that are not initiated
by WebCore itself.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Don't pass a referrer. We get the referrer from the part.

• kwq/KWQKHTMLPartImpl.h: Add a new referrer method that works on the part, and remove the old one that got it from the URL arguments.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't pass a referrer when creating a new window. (KWQKHTMLPartImpl::openURLRequest): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::urlSelected): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::createPart): Don't pass a referrer when creating a child frame for this window. (KWQKHTMLPartImpl::submitForm): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::referrer): Added.

• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Don't pass a referrer when starting a load.
• kwq/WebCoreBridge.h: Add referrer method. Remove referrer parameter from many other methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Added.

WebKit:

• fixed 3062393 -- need to send proper referrer for "open in new window" menu items and keyboard shortcuts

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Don't take a referrer parameter any more. Get the referrer by calling to the other side of the bridge, instead. (-[WebBridge startLoadingResource:withURL:]): Ditto. (-[WebBridge loadURL:]): Ditto. (-[WebBridge postWithURL:data:contentType:]): Ditto. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.

• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): Don't take a referrer parameter, which was always nil anyway. Instead, get the referrer from the bridge. (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): Don't pass nil for referrer. (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]): Ditto.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass a referrer from the bridge, rather than nil, for both WebClickPolicyOpenNewWindow and WebClickPolicyOpenNewWindowBehind.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Add a FIXME.

4:48 PM Changeset in webkit [2335] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.h: Remove unused stuff.
• WebView.subproj/WebDataSourcePrivate.m: Ditto.

4:35 PM Changeset in webkit [2334] by darin

• 4 edits in trunk/WebCore

• fixed 3021713 -- text selection background obliterates descenders (in www.theregister.co.uk articles)
• fixed 3038207 -- Selected link text doesn't draw its link underline

• khtml/rendering/render_text.cpp: (TextSlave::printSelection): Don't draw text at all, just draw a selection background. (RenderText::printObject): Draw in two passes. Draw the selection background in the first pass, and the text in the second pass. That way pieces of the background won't cover any other text or adornments, like underlines.

3:44 PM Changeset in webkit [2333] by darin

• 16 edits in trunk

WebCore:

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Move the special case of a different anchor within the same page into WebKit from here.

• kwq/kdecore/kurl.h: Mark urlcmp as a friend.
• kwq/KWQKURL.mm: (urlcmp): Implement the ignoreRef feature, which is needed to make the KHTMLPart::openURL function work right.

• kwq/WebCoreBridge.h: Removed addBackForwardItemWithURL:anchor: and added URL method.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge URL]): Added.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:]): Add a special case for when the URL is the same as the previous URL for the same frame. This relies on some logic in KHTML's openURL method that handles this case too.

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Don't bother keeping an inputURL. (-[WebDataSource URL]): Just return [[self request] URL]. Maybe we can remove this altogether.
• WebView.subproj/WebDataSourcePrivate.h: Remove inputURL, finalURL.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release inputURL, finalURL. (-[WebDataSource _setURL:]): Used only by the new code above. Makes a copy of the request, changes the URL, and then drops the old request. (-[WebDataSource _setRequest:]): Changed to no longer call _setURL. Now does much of the work that _setURL used to do.

1:49 PM Changeset in webkit [2332] by darin

• 13 edits in trunk

WebCore:

• fixed 3074558 -- frames multiply at: ​http://www.iarsn.com/

The key was to make the name attribute work properly.

• khtml/ecma/kjs_window.cpp: (Window::get): Enable the "name" attribute. (Window::put): Enable the "name" attribute, but don't do the conversion to an 8-bit string -- leave it as a QString.
• kwq/WebCoreBridge.h: Add setName/name methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Added. Calls part->setName(). (-[WebCoreBridge name]): Added. Calls part->name().
• kwq/kparts/part.h: Added setName/name to ReadOnlyPart.

• kwq/KWQKHTMLPartImpl.mm: Remove old bogusish comment.

WebKit:

WebKit part of improved frame name support.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Call setName on the newly created part.

1:01 PM Changeset in webkit [2331] by sullivan

• 3 edits in trunk/WebKit

• fixed 3075777 -- hysteresis for dragging links on web pages is still too large

• WebView.subproj/WebHTMLView.m: changed hysteresis constants; added comment.

12:52 PM Changeset in webkit [2330] by darin

• 3 edits in trunk/WebKit

Fix problem where timer was lasting after window was closed.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Add a call to [_private->bridge closeURL].

12:51 PM Changeset in webkit [2329] by rjw

• 4 edits in trunk/WebCore

Added text color to attributed string conversion.

• kwq/WebCoreBridge.mm: (attributedString):

12:47 PM Changeset in webkit [2328] by rjw

• 8 edits in trunk

Added attributed string to pasteboard. Fixes 3006760.
We may want to scale back the content that is included in the
attributed string. Currently all text nodes in the selection
are converted. This include text nodes for non-visible content,
i.e. scripts.
[Note we may also want to put HTML snippet on the pboard. The appkit
does support reading text using htmldisplay today. Of course this should
eventually migrate to use WebView.]

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView copy:]):

Added API to get attributed string from bridge.
Added API to get selection in terms of the DOM API
from the bridge.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (attributedString): (-[WebCoreBridge selectionStart]): (-[WebCoreBridge selectionStartOffset]): (-[WebCoreBridge selectionEnd]): (-[WebCoreBridge selectionEndOffset]):

11:20 AM Changeset in webkit [2327] by darin

• 5 edits in trunk/WebCore

• fixed 3054791 -- crash in WebCoreSettings _updateAllViews changing font

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Pass in the "this" pointer so that the right instance is removed from the instances list. Before, we would always remove the first instance from the list, leaving the list broken.

11:19 AM Changeset in webkit [2326] by darin

• 3 edits in trunk/WebKit

Fixed bug where URLs dragged to the content area were not made canonical
the way URLs dragged to the page address field are.

• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Make URLs canonical before returning them.

10:34 AM Changeset in webkit [2325] by cblu

• 6 edits in trunk/WebKit

If a file is renamed during download because a file of the same name already exists, show this in the UI.

• Misc.subproj/WebDownloadHandler.h:
• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedResponse:]): added, create file here (-[WebDownloadHandler receivedData:]): don't create file here
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): call [dataSource _setPrimaryLoadComplete:YES] for downloads (-[WebMainResourceClient handle:didReceiveResponse:]): call [WebDownloadHandler receivedResponse:] (-[WebMainResourceClient handle:didReceiveData:]): no download error to handle

7:28 AM Changeset in webkit [2324] by kocienda

• 4 edits in trunk/WebCore

Fixed an "unused variable" build breaker. Note that I just
commented out the code and put a FIXME, as I know this is code
that David has been banging on a lot. This should be either
used for real or removed eventually, but I'll leave that for
Hyatt.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Oct 14, 2002:

11:20 PM Changeset in webkit [2323] by hyatt

• 5 edits in trunk/WebCore

More collapsing margin surgery. Working on setting up blocks
to properly compute their collapsed margins (without actually changing
the obsolete collapsing behavior yet).

• khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
• khtml/rendering/render_flow.h:

10:34 PM Changeset in webkit [2322] by cblu

• 14 edits in trunk/WebKit

WebFoundation:

Renamed filenameByCorrectingExtensionOfFilename:withMIMEType: to filenameWithURL:andMIMEType:
It comes up with the best filename for a URL and MIME type.

• Misc.subproj/WebFileTypeMappings.h:
• Misc.subproj/WebFileTypeMappings.m:

WebKit:

• Made all downloads no matter how prompted, pass through the content policy API so the client can properly choose the file name and correct the extension if necessary. We now ask for the content policy even if one has been predetermined.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]): Renamed, set the predetermined content policy.
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]): call [WebController _downloadURL:withContentPolicy:]
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebController _downloadURL:withContentPolicy:]
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): call [WebController _downloadURL:withContentPolicy:]
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): ask for content policy even if one is predetermined

WebBrowser:

• Support for content policy API change. Properly handle the predetermined content policy.
• Minor clean-up in DownloadProgressEntry.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andURL:inFrame:withContentPolicy:]): Properly handle the predetermined content policy.
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Use bytesLoaded and bytesExpected var names (-[DownloadProgressEntry setCompleted]): set bytesExpected to bytesLoaded (-[DownloadProgressEntry updateProgressUI]): slight rearrange.

7:04 PM Changeset in webkit [2321] by hyatt

• 4 edits in trunk/WebCore

Adding helper functions for handling of collapsing margins.
Not used yet.

• khtml/rendering/render_object.h:

4:27 PM Changeset in webkit [2320] by darin

• 4 edits in trunk/WebCore

Fixed problems with named colors.

• kwq/KWQColor.mm: (QColor::setNamedColor): Check named colors before hex codes for colors because our hex code parsing is now lenient enough that many names qualify.

4:27 PM Changeset in webkit [2319] by cblu

• 6 edits in trunk/WebKit

WebFoundation:

• Added new method that corrects a filename's extension based on its MIME type.

• Misc.subproj/WebFileTypeMappings.h:
• Misc.subproj/WebFileTypeMappings.m: (-[WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]): if the extension does not correspond with the MIME type, correct it using the preferred MIME type.

WebKit:

• Cleaned up download handler and download progress delegate interactions.
• Got rid of error suppression junk.
• Only send 1 final message to the download progress delegate

• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): no error suppression (-[WebMainResourceClient didCancelWithHandle:]): ignore cancel errors because 1 download error is enough (-[WebMainResourceClient handleDidFinishLoading:]): don't send the special and odd final message to the download progress delegate (-[WebMainResourceClient handle:didReceiveData:]): no error suppression (-[WebMainResourceClient handle:didFailLoadingWithError:]): ignore cancel errors because 1 download error is enough

WebBrowser:

• Correct extensions of filenames of downloaded files based on MIME type. This fixes issues with files that have random extensions and thus not claimed by any application.
• Cleaned up DownloadMonitor. Got rid of bottle-neck progress method that caused much confusion and bugs.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): call [WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]
• DownloadMonitor.m: (-[DownloadMonitor _entryForDataSource:]): renamed (-[DownloadMonitor _entryForView:]): renamed (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): create new download entry (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): increment progress of download entry (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): setCompleted on the download entry (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]): set error and setCompleted on the download entry
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry awakeFromNib]): progress bar should be determinate by default (-[DownloadProgressEntry setCompleted]): replaces _cleanUpIfComplete, have the DownloadMonitor tell us when we're done.

4:23 PM Changeset in webkit [2318] by hyatt

• 4 edits in trunk/WebCore

Really fixing zeldman.com this time. This disabling stuff
is complicated! :)

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):

1:33 PM Changeset in webkit [2317] by darin

• 12 edits in trunk/WebKit

• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): Add checking since we don't "trust" the dictionary passed in.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): Add FIXME about adding the checking.

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup initWithFile:]): Use copy, not retain.

• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Fix storage leak by releasing the default context menu delegate.

• WebView.subproj/WebControllerPrivate.h: Tweak.

12:46 PM Changeset in webkit [2316] by hyatt

• 4 edits in trunk/WebCore

Stop the insanity. Make sure that a sheet that is disabled
while it is still loading is removed from the doc's list
of pending sheets (for FOUC checks).

Fixes zeldman.com.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute):

10:20 AM Changeset in webkit [2315] by cblu

• 4 edits in trunk/WebKit

Made WebNetscapePluginStream retain a WebNetscapePluginEmbeddedView not a WebBaseNetscapePluginView.

• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):

12:19 AM Changeset in webkit [2314] by hyatt

• 6 edits in trunk/WebCore

Implementing the ability to individually enable/disable
both preferred and alternate stylesheets. Enabling/disabling
sheets via the disabled property of the <link> element overrides
whether or not a sheet happens to be alternate or preferred.

This new implementation of sheet disabling/enabling was a missing
piece of our HTML4 compliance, and was used by the Wired
site to implement its text sizing mechanism.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::process):
• khtml/html/html_headimpl.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):

Oct 13, 2002:

11:44 PM Changeset in webkit [2313] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Added strings from WebBookmarkProxy.m.

11:16 PM Changeset in webkit [2312] by cblu

• 7 edits
  6 adds
  2 deletes in trunk/WebKit

• Eliminated the dual-role behavior of WebPluginStream. Renamed WebPluginStream to WebBaseNetscapePluginStream.

WebNetscapePluginRepresentation, a subclass of WebNetscapePluginRepresentation, is the document representation for standalone plug-ins. WebNetscapePluginStream, also a subclass of WebNetscapePluginRepresentation, is the general plug-in stream loader for embedded plug-ins or plug-in requested streams.

23 plug-in source files with more likely to come!

• Plugins.subproj/WebBaseNetscapePluginStream.h: Added.
• Plugins.subproj/WebBaseNetscapePluginStream.m: Added. (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setPluginPointer:]): (-[WebBaseNetscapePluginStream setResponse:]): (-[WebBaseNetscapePluginStream receivedData:]): (-[WebBaseNetscapePluginStream receivedError:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView pluginPointer]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginRepresentation.h: Added.
• Plugins.subproj/WebNetscapePluginRepresentation.m: Added. (-[WebNetscapePluginRepresentation setDataSource:]): (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.h: Added.
• Plugins.subproj/WebNetscapePluginStream.m: Added. (-[WebNetscapePluginStream setCurrentURL:]): (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream loadEnded]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginStream.h: Removed.
• Plugins.subproj/WebPluginStream.m: Removed.
• WebKit.pbproj/project.pbxproj:

Oct 11, 2002:

11:10 PM Changeset in webkit [2311] by rjw

• 5 edits in trunk/WebCore

Avoid one-click crasher.

• Debug/SnippetController.m: (-[SnippetController load]):

Remove debugging.

• kwq/WebCoreDOMDocument.mm: (+[WebCoreDOMDocument documentWithImpl:DOM::]):
• kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode lastChild]):

10:49 PM Changeset in webkit [2310] by rjw

• 18 edits in trunk

More implementation of snippet viewer to show converted
attributed string.

• Debug/Snippet.nib:
• Debug/SnippetController.h:
• Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController awakeFromNib]): (-[SnippetController load]): (lastNode): (-[SnippetController loadComplete]): (-[SnippetController convert:]): (-[SnippetController show:]): (-[SnippetController mainDataSource]): (-[SnippetLocationChangeDelegate initWithController:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]): (-[AttributedStringView dealloc]): (-[AttributedStringView setAttributedString:]): (-[AttributedStringView drawRect:]):

More DOM/attributed string work.

• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
• WebView.subproj/WebHTMLRepresentationPrivate.h:

More DOM/attributed string work. Still need to fix more
inappropriate casting problems.

• khtml/dom/dom_node.cpp: (Node::lastChild):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::lastChild): (NodeBaseImpl::lastChild):
• khtml/xml/dom_nodeimpl.h:
• kwq/KWQKHTMLPartImpl.cpp: (KWQKHTMLPartImpl::selectionStartOffset): (KWQKHTMLPartImpl::selectionEndOffset): (KWQKHTMLPartImpl::selectionStart): (KWQKHTMLPartImpl::selectionEnd):
• kwq/KWQKHTMLPartImpl.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]): (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): (attributedString): (-[WebCoreBridge selectedAttributedString]): (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]):
• kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocumentType DOM::]): (-[WebCoreDOMDocumentType name]): (-[WebCoreDOMDocumentType entities]): (-[WebCoreDOMDocumentType notations]): (-[WebCoreDOMDocumentType publicId]): (-[WebCoreDOMDocumentType systemId]): (-[WebCoreDOMDocumentType internalSubset]): (-[WebCoreDOMImplementation DOM::]): (-[WebCoreDOMImplementation hasFeature::]): (-[WebCoreDOMImplementation createDocument:::]): (+[WebCoreDOMDocument documentWithImpl:DOM::]): (-[WebCoreDOMDocument DOM::]): (-[WebCoreDOMDocument doctype]): (-[WebCoreDOMDocument implementation]): (-[WebCoreDOMDocument documentElement]): (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]): (-[WebCoreDOMDocument createDocumentFragment]): (-[WebCoreDOMDocument createTextNode:]): (-[WebCoreDOMDocument createComment:]): (-[WebCoreDOMDocument createCDATASection:]): (-[WebCoreDOMDocument createProcessingInstruction::]): (-[WebCoreDOMDocument createAttribute:]): (-[WebCoreDOMDocument createAttributeNS::]): (-[WebCoreDOMDocument createEntityReference:]): (-[WebCoreDOMDocument getElementById:]): (-[WebCoreDOMDocument getElementsByTagName:]): (-[WebCoreDOMDocument getElementsByTagNameNS::]): (-[WebCoreDOMDocument importNode::]):
• kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode initWithImpl:DOM::]): (-[WebCoreDOMNode firstChild]): (-[WebCoreDOMNode lastChild]):
• kwq/WebCoreDOMPrivate.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): (recursive_toHTML): (attributedString):

4:22 PM Changeset in webkit [2309] by kocienda

• 3 edits in trunk/WebKit

Fixed uninitialized variable build breaker I got when
doing a Deployment build.

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]):

2:56 PM Changeset in webkit [2308] by sullivan

• 8 edits
  2 adds in trunk/WebKit

WebKit:

Added the concept of bookmark proxies; items that can be
stored and displayed with other bookmarks but represent
a source of bookmark-like items (e.g. Rendezvous, History)

• Bookmarks.subproj/WebBookmarkProxy.h: Added.
• Bookmarks.subproj/WebBookmarkProxy.m: Added. (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): (-[WebBookmarkProxy dictionaryRepresentation]): (-[WebBookmarkProxy bookmarkType]): (-[WebBookmarkProxy copyWithZone:]): (-[WebBookmarkProxy title]): (-[WebBookmarkProxy setTitle:]): (-[WebBookmarkProxy icon]): New class, has a title and that's about it

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]): Handle proxy case

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]): Handle proxy case

• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]), (-[WebBookmarkList dictionaryRepresentation]): Handle proxy case

• Bookmarks.subproj/WebBookmarkPrivate.h: Add #define for proxy

• WebKit.pbproj/project.pbxproj: updated for new files

WebBrowser:

• started work on moving Address Book, Rendezvous, and History out of their own windows and into the Library view.

The titles Rendezvous/Address Book/History now appear in the
Library view, but they don't do anything. They have no content,
you can't drag them, and if you try to drop something on one
you get a mysterious console message but nothing else happens.

• BookmarksController.m: (+[BookmarksController _favoritesTitle]), (+[BookmarksController _menuRootTitle]): just moved in file (+[BookmarksController historyProxyTitle]), (+[BookmarksController addressBookProxyTitle]), (+[BookmarksController rendezvousProxyTitle]): new methods to retrieve localizable titles for these bookmark proxies. (-[BookmarksController imageForBookmark:]): supply the right images for the proxies we know about (-[BookmarksController addMenuItemForBookmark:toMenu:]): handle proxy case (but there isn't yet a way to get one in a menu) (-[BookmarksController _blessOrCreateSpecialFolders]): make sure the right set of proxies are in there where they belong.

• BookmarksViewController.m: (-[BookmarksViewController bookmarkForSourceRow:]): (-[BookmarksViewController sourceRowForBookmark:]): (-[BookmarksViewController numberOfRowsInTableView:]): (-[BookmarksViewController canRemoveBookmarkSource:]): (-[BookmarksViewController tableView:shouldEditTableColumn:row:]):
• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:

2:02 PM Changeset in webkit [2307] by cblu

• 3 edits in trunk/WebKit

Thought I has checking for nil enough, but not enough as I raised an exception on Avie's machine.

• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for the nil extension case

1:33 PM Changeset in webkit [2306] by darin

• 3 edits in trunk/WebKit

Apply a simplified technique I learned while working on the Favorites button
class in the browser code.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Use the NSViewFocusDidChangeNotification to track the plugin rectangles instead of the NSViewFrameDidChangeNotification and NSViewBoundsDidChangeNotification on all the superviews.

9:34 AM Changeset in webkit [2305] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: new generic URL icon -- no more @!

WebBrowser:

• some new and improved images from Steve Lemay (more to come)

• Resources/Images/FavoritesBar.tif: new little heart
• Resources/Images/folder16.tiff: new little folder
• Resources/Images/rendezvous.tiff: new rendezvous symbol
• Resources/Images/tiny_menu.tiff: new little menu

Oct 10, 2002:

9:07 PM Changeset in webkit [2304] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3072643 -- infinite loop in JavaScript code at walgreens.com

The problem is that "xxx".indexOf("", 1) needs to return 1, but we
were returning 0.

• kjs/ustring.cpp: (UString::find): Return pos, not 0, when the search string is empty. (UString::rfind): Make sure that pos is not past the end of the string, taking into account the search string; fixes a potential read off the end of the buffer. Also return pos, not 0, when the search string is empty.

3:29 PM Changeset in webkit [2303] by darin

• 4 edits in trunk/WebKit

• fixed 3069366 -- REGRESSION: no pop-up window at inkfinder.com

The window now pops up, but it doesn't seem to work right. But I
think the window working right is a separate issue.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Make sure we use the copy of the request that we're keeping around when we call _setRequest on the data source, rather than the copy we're returning which can be modified by WebFoundation. Also rearrange things so we're more likely to get things right when the delegate changes the URL on the request.

3:07 PM Changeset in webkit [2302] by hyatt

• 4 edits in trunk/WebCore

Fix for 3058829, assertion caused by table cell with
incorrect display type. Implemented a quirk that forces
<td>s of display: block to construct table cells as
rendering objects.

• khtml/rendering/render_object.cpp: (RenderObject::createObject):

2:13 PM Changeset in webkit [2301] by cblu

• 3 edits in trunk/WebKit

top level:

Fix typos.

• Site/Internal/How-To/pc-os-installation.html:
• Site/Internal/index.html:

WebKit:

No need to send update event when activating/deactivating. This was as old workaround for the plug-in drawing problems.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]):

11:39 AM Changeset in webkit [2300]

• 3 copies in tags/Alexander-27

This commit was manufactured by cvs2svn to create tag 'Alexander-27'.

11:39 AM Changeset in webkit [2299] by sheridan

• 8 edits in trunk

Alex-27 stamp

Oct 9, 2002:

11:30 PM Changeset in webkit [2298] by darin

• 5 edits in trunk/WebCore

• fixed 3047782 -- Alexander rejects some color strings that other browsers accept

• khtml/misc/helper.cpp: (khtml::setNamedColor): Put some of the code from this level that tries to accomodate bad colors in #if !APPLE_CHANGES, since we do most of the smarts in KWQ.

• kwq/KWQColor.mm: (hex2int): Tolerate non-hex digits, treating them as 0. (decodeColorFromHexColorString): Trim any number of leading # characters, and trailing " and ' characters. Handle strings of 4, 5, 7, 8, 10, and 11 hex digits, along with the existing 3, 6, 9, and 12.

10:43 PM Changeset in webkit [2297] by darin

• 6 edits in trunk/WebKit

• fixed 3071799 -- REGRESSION: hang and strange download loading about:blank

Chris fixed the strange download earlier. This fixes the "hang' by making sure
we commit even if we receive 0 bytes of data.

• WebView.subproj/WebDataSourcePrivate.h: Added a _finishedLoading method.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]): Added. Sets the "first byte of data received" flag, and calls _commitIfReady.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Call _finishedLoading.

10:33 PM Changeset in webkit [2296] by darin

• 4 edits in trunk/WebKit

• fixed 3072015 -- REGRESSION: frames multiply endlessly

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setFrame:]): Remove code that sets the parent from here, because it's too early, always nil.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _addChild:]): Do it here instead.

4:35 PM Changeset in webkit [2295] by hyatt

• 4 edits in trunk/WebCore

Fix a subtle bug with layers. When a parent is sorted with its
children the parent's zindex must be treated as 0, so that
negative children draw behind the layer's content and positive
children (or auto children) draw in front of the layer's content.

This fix makes chrysler.com work again (and doubtless many other
messed up DHTML sites).

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree): (RenderLayer::RenderZTreeNode::constructLayerList):

2:43 PM Changeset in webkit [2294] by rjw

• 4 edits in trunk/WebCore

Implemented string conversion functions.

• kwq/WebCoreDOMDocument.mm: (domStringToNSString): (NSStringToDOMString):

2:11 PM Changeset in webkit [2293] by rjw

• 10 edits in trunk/WebKit

Cleaned up and made a little more useful as an example for
WebKit root.

• SimpleViewer/ApplicationController.h:
• SimpleViewer/ApplicationController.m: (-[ApplicationController validateUserInterfaceItem:]):
• SimpleViewer/DocumentController.h:
• SimpleViewer/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController loadURL:]): (-[DocumentController windowWillClose:]): (-[LocationChangeDelegate dealloc]): (-[LocationChangeDelegate locationChangeStartedForDataSource:]): (-[LocationChangeDelegate locationChangeDone:forDataSource:]): (-[ResourceLoadDelegate resourceRequest:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resourceRequest:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resourceRequest:didFailLoadingWithError:fromDataSource:]):
• SimpleViewer/English.lproj/Document.nib:
• SimpleViewer/English.lproj/MainMenu.nib:
• SimpleViewer/English.lproj/Thumbnail.nib: Removed.
• SimpleViewer/SimpleViewer.pbproj/project.pbxproj:
• SimpleViewer/ThumbnailController.h: Removed.
• SimpleViewer/ThumbnailController.m: Removed.
• SimpleViewer/ThumbnailView.h: Removed.
• SimpleViewer/ThumbnailView.m: Removed.

Guarantee that resource progress messages arrive
before final locationChangeDone message.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
• WebKit.exp:
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate resourceRequest:willSendRequest:fromDataSource:]): (-[WebResourceLoadDelegate resourceRequest:didReceiveResponse:fromDataSource:]): (-[WebResourceLoadDelegate resourceRequest:didReceiveContentLength:fromDataSource:]): (-[WebResourceLoadDelegate resourceRequest:didFinishLoadingFromDataSource:]): (-[WebResourceLoadDelegate resourceRequest:didFailLoadingWithError:fromDataSource:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]):
• WebView.subproj/WebResourceLoadDelegate.h:

1:41 PM Changeset in webkit [2292] by sullivan

• 7 edits in trunk/WebKit

WebKit:

• removed unnecessary concept of unique identifiers for bookmarks

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): (-[WebBookmark _setGroup:]):
• Bookmarks.subproj/WebBookmarkGroup.h:
• Bookmarks.subproj/WebBookmarkGroup.m:
• Bookmarks.subproj/WebBookmarkGroupPrivate.h: removed all references to unique identifiers

WebBrowser:

• greatly simplified drag-and-drop bookmark code, which will help me make further refinements more easily
• removed uses of unique bookmark identifiers
• tweaked Library column behaviors with IB

• BookmarksViewController.h: removed _draggedBookmarks ivar; this is now a static variable
• BookmarksViewController.m: (-[BookmarksViewController dealloc]): don't release _draggedBookmarks, which is now static (-[BookmarksViewController bookmarkOrAnyAncestor:inArray:]): new method, slight addition to already-existing anyAncestorOfBookmark:inArray:; replaces code that was checking bookmark identifiers against a list of identifiers (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]), (-[BookmarksViewController tableView:acceptDrop:row:dropOperation:]), (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]), (-[BookmarksViewController outlineView:acceptDrop:item:childIndex:]): Always use draggedImage:endedAt: for deleting original bookmarks; compare against draggedBookmarks instead of using bookmark identifiers; other simplifications.

• BrowserWebBookmarkExtras.h:
• BrowserWebBookmarkExtras.m: (+[WebBookmark bookmarkPasteboardTypes]): (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): (+[WebBookmark bookmarksFromPasteboard:]): Removed bookmarkIdentifiersFromPasteboard and supporting code

• English.lproj/Browser.nib: made single-column not reorderable so it doesn't highlight

• FavoriteButton.m: (-[FavoriteButton bookmarkMatches:]): new method, compares a bookmark against self's (-[FavoriteButton determineDragOperation:]): use bookmarkMatches instead of unique identifiers to test for dropping an item onto itself.

11:45 AM Changeset in webkit [2291] by darin

• 33 edits in trunk

WebCore:

• fixed 3069264 -- REGRESSION: windows created for links with target=blank start out hidden (window menu only)

• kwq/WebCoreBridge.h: Removed openNewWindowWithURL:referrer:frameName: and added createWindowWithURL:referrer:frameName: and showWindow.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createWindowWithURL, and then showWindow after the window is set up. Also change the code that flips coordinates to always use the height of the first screen instead of using the height of the screen the window is on, which sounds right, but is wrong.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Call createWindowWithURL and then showWindow in the case where we create a window. (KWQKHTMLPartImpl::urlSelected): Remove unused command-click code. The real command-click code is in the browser now.

WebKit:

WebKit support for creating windows and then showing them later
after setting them up.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:referrer:frameName:]): Replaced the old openNewWindowWithURL with this. It calls the new window operations delegate method. (-[WebBridge showWindow]): Added. Calls the window operations delegate showWindow method. (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Call _createFrameNamed instead of createFrameNamed.

• WebView.subproj/WebWindowOperationsDelegate.h: Replaced the openNewWindowWithURL method with a new method named createWindowWithURL. Added showWindow and showWindowBehindFrontmost.

• WebView.subproj/WebControllerPrivate.h: Renamed createFrameNamed to _createFrameNamed and removed the data source parameter. Added _openNewWindowWithURL:referrer:behind: for the convenience of those who used to call the window operations delegate directly to open the window.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _createFrameNamed:inParent:allowsScrolling:]): Renamed, and removed the data source parameter. (-[WebController _openNewWindowWithURL:referrer:behind:]): Added.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]):
• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Use a private WebController method instead of calling the delegate directly, because it now takes two method calls to create and display a new window.

• Misc.subproj/WebNSViewExtras.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebController.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebPreferences.m:
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.m: Tweaked comments.

WebBrowser:

WebBrowser support for creating windows and then showing them later
after setting them up.

• BrowserDocumentController.h: Add a new policy, CreateHiddenWindow.
• BrowserDocumentController.m: (-[BrowserDocumentController _goToEachURL:referrer:windowPolicy:]): Pass NO for display if policy is CreateHiddenWindow. (-[BrowserDocumentController tryMultipleURLs:windowPolicy:]): Ditto.

• BrowserWebController.m: (-[BrowserWebController createWindowWithURL:referrer:]): Added. Like the old openNewWindowWithURL method, but uses CreateHiddenWindow. (-[BrowserWebController showWindow]): Added. Tells the window controller to show the window. (-[BrowserWebController showWindowBehindFrontmost]): Added. Tells the window controllers to show the window after telling the document that the window should open behind the frontmost.

9:48 AM Changeset in webkit [2290] by darin

• 4 edits in trunk/WebCore

• fixed 3069749 -- crash in QString during third run of cvs-base

• kwq/KWQString.mm: (checkNodeAllocationPages): Added function to use for debugging. (_allocateNode): Clear the next pointer after removing a page from the free node list so that the free node list doesn't point at part of the used node list. (freeHandle): Change the code around so that the code to add the node to the free list works even in the case where this was the top from the used list. The old code would half-remove the node from the used list and not add it to the free list at all.

8:09 AM Changeset in webkit [2289] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): Fix positioning of progressively loading images that are flipped.