Timeline
Feb 9, 2003:
- 10:01 AM Changeset in webkit [3615]
-
- 4 copies2 deletes in tags/JavaScriptCore-60
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-60'.
- 10:01 AM Changeset in webkit [3614] by
-
- 1 edit in branches/JavaScriptCore-60-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj
Update project for tarball.
- 9:56 AM Changeset in webkit [3613]
-
- 23 copies3 deletes in tags/WebCore-60
This commit was manufactured by cvs2svn to create tag 'WebCore-60'.
- 9:56 AM Changeset in webkit [3612] by
-
- 1 edit in branches/WebCore-60-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj
Tweak project for tarball.
Feb 7, 2003:
- 11:14 PM Changeset in webkit [3611] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3145899 -- tf1.fr page marked UTF-8 is being decoded as Latin-1 (due to <noscript> before <meta>)
- khtml/misc/decoder.cpp: (Decoder::decode): Add NOSCRIPT to the list of tags that are allowed before META tags that specify character sets.
- fixed 3144214 -- treat Big5 as Windows CP 950 the same way TEC does
- kwq/mac-encodings.txt: Move Big5 names to kCFStringEncodingDOSChineseTrad instead of kCFStringEncodingBig5.
- kwq/KWQCharsetData.c: Regenerated.
- 2:08 PM Changeset in webkit [3610] by
-
- 26 edits in trunk
WebKit:
Changes to support per WebController preferences.
Reviewed by Maciej and Ken.
- WebView.subproj/WebController.m: (-[WebController setPreferences:]):
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _setFormDelegate:]): (-[WebController _formDelegate]): (-[WebController _settings]): (-[WebController _updateWebCoreSettingsFromPreferences:]): (-[WebController _releaseUserAgentStrings]): (-[WebController _preferencesChangedNotification:]):
- WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]):
- WebView.subproj/WebPreferences.h:
- WebView.subproj/WebPreferences.m: (-[WebPreferences _postPreferencesChangesNotification]): (+[WebPreferences load]): (-[WebPreferences _stringValueForKey:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences standardFontFamily]): (-[WebPreferences setStandardFontFamily:]): (-[WebPreferences fixedFontFamily]): (-[WebPreferences setFixedFontFamily:]): (-[WebPreferences serifFontFamily]): (-[WebPreferences setSerifFontFamily:]): (-[WebPreferences sansSerifFontFamily]): (-[WebPreferences setSansSerifFontFamily:]): (-[WebPreferences cursiveFontFamily]): (-[WebPreferences setCursiveFontFamily:]): (-[WebPreferences fantasyFontFamily]): (-[WebPreferences setFantasyFontFamily:]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): (-[WebPreferences defaultFixedFontSize]): (-[WebPreferences setDefaultFixedFontSize:]): (-[WebPreferences minimumFontSize]): (-[WebPreferences setMinimumFontSize:]): (-[WebPreferences defaultTextEncodingName]): (-[WebPreferences setDefaultTextEncodingName:]): (-[WebPreferences userStyleSheetEnabled]): (-[WebPreferences setUserStyleSheetEnabled:]): (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]): (-[WebPreferences JavaEnabled]): (-[WebPreferences setJavaEnabled:]): (-[WebPreferences JavaScriptEnabled]): (-[WebPreferences setJavaScriptEnabled:]): (-[WebPreferences JavaScriptCanOpenWindowsAutomatically]): (-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:]): (-[WebPreferences pluginsEnabled]): (-[WebPreferences setPluginsEnabled:]): (-[WebPreferences allowAnimatedImages]): (-[WebPreferences allowAnimatedImageLooping]): (-[WebPreferences setAllowAnimatedImageLooping:]): (-[WebPreferences setWillLoadImagesAutomatically:]): (-[WebPreferences willLoadImagesAutomatically]): (-[WebPreferences _initialTimedLayoutDelay]): (-[WebPreferences _initialTimedLayoutSize]): (-[WebPreferences _pageCacheSize]): (-[WebPreferences _objectCacheSize]): (-[WebPreferences _initialTimedLayoutEnabled]): (-[WebPreferences _resourceTimedLayoutDelay]): (-[WebPreferences _resourceTimedLayoutEnabled]):
- WebView.subproj/WebPreferencesPrivate.h:
WebCore:
Changes to support per WebController preferences.
KHTMLPart now always accesses preferences from it's m_setting.
Changes made to WebPreferences pass to WebCoreSetting to KTMLSettings.
Added JavaScriptCanOpenWindowsAutomatically to KHTMLSettings.
Reviewed by Maciej and Ken.
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
- khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::restoreURL): (KHTMLPart::openURL): (KHTMLPart::begin): (KHTMLPart::reparseConfiguration):
- khtml/khtmlpart_p.h:
- kwq/KWQKConfigBase.h:
- kwq/KWQKConfigBase.mm: (KConfig::readUnsignedNumEntry):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setSettings):
- kwq/KWQKHTMLSettings.h:
- kwq/KWQKHTMLSettings.mm: (KHTMLSettings::stdFontName): (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName): (KHTMLSettings::sansSerifFontName): (KHTMLSettings::cursiveFontName): (KHTMLSettings::fantasyFontName): (KHTMLSettings::minFontSize): (KHTMLSettings::mediumFontSize): (KHTMLSettings::mediumFixedFontSize): (KHTMLSettings::isJavaEnabled): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::JavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::userStyleSheet): (KHTMLSettings::setStdFontName): (KHTMLSettings::setFixedFontName): (KHTMLSettings::setSerifFontName): (KHTMLSettings::setSansSerifFontName): (KHTMLSettings::setCursiveFontName): (KHTMLSettings::setFantasyFontName): (KHTMLSettings::setMinFontSize): (KHTMLSettings::setMediumFontSize): (KHTMLSettings::setMediumFixedFontSize): (KHTMLSettings::setAutoLoadImages): (KHTMLSettings::setIsJavaScriptEnabled): (KHTMLSettings::setIsJavaEnabled): (KHTMLSettings::setArePluginsEnabled): (KHTMLSettings::setJavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::setUserStyleSheet):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge init]): (-[WebCoreBridge initializeSettings:]):
- kwq/WebCoreSettings.h:
- kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]): (-[WebCoreSettings init]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setFixedFontFamily:]): (-[WebCoreSettings setSerifFontFamily:]): (-[WebCoreSettings setSansSerifFontFamily:]): (-[WebCoreSettings setCursiveFontFamily:]): (-[WebCoreSettings setFantasyFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setJavaEnabled:]): (-[WebCoreSettings setPluginsEnabled:]): (-[WebCoreSettings setJavaScriptEnabled:]): (-[WebCoreSettings setJavaScriptCanOpenWindowsAutomatically:]): (-[WebCoreSettings setWillLoadImagesAutomatically:]): (-[WebCoreSettings setUserStyleSheetLocation:]): (-[WebCoreSettings userStyleSheetLocation]): (-[WebCoreSettings settings]):
- 12:49 PM Changeset in webkit [3609]
-
- 23 copies3 deletes in branches/WebCore-60-tarball-branch
This commit was manufactured by cvs2svn to create branch
'WebCore-60-tarball-branch'.
- 12:49 PM Changeset in webkit [3608]
-
- 23 copies3 deletes in tags/WEBCORE_60_TARBALL_BRANCH_ANCHOR
This commit was manufactured by cvs2svn to create tag
'WEBCORE_60_TARBALL_BRANCH_ANCHOR'.
- 12:49 PM Changeset in webkit [3607]
-
- 31 copies1 delete in tags/Safari-60
This commit was manufactured by cvs2svn to create tag 'Safari-60'.
- 12:49 PM Changeset in webkit [3606]
-
- 4 copies2 deletes in branches/JavaScriptCore-60-branch
This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-60-branch'.
- 12:49 PM Changeset in webkit [3605]
-
- 4 copies2 deletes in tags/JAVASCRIPTCORE_60_BRANCH_ANCHOR
This commit was manufactured by cvs2svn to create tag
'JAVASCRIPTCORE_60_BRANCH_ANCHOR'.
- 12:49 PM Changeset in webkit [3604] by
-
- 8 edits in branches/Safari-0-8-2-branch
Safari-60
- 10:59 AM Changeset in webkit [3603] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebCore
Rolled change from trunk to branch.
2003-02-07 Darin Adler <Darin Adler>
Reviewed by Dave.
- fixed 3165171 -- REGRESSION: images overlap text
- khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Change to distribute space to the fixed columns first so the code to distribute to non-fixed columns does not assume it can distribute more to the fixed columns than it really can.
- 10:53 AM Changeset in webkit [3602] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebCore
Rolled changes from trunk onto branch to fix this bug:
Radar 3165860 (REGRESSION: most of the page disappears when you mouse over DHTML at rollingstone.com)
Original comment for checkin:
2003-02-06 David Hyatt <hyatt@apple.com>
Fix rollingstone regression.
Reviewed by mjs
- khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
- 10:49 AM Changeset in webkit [3601] by
-
- 4 edits in branches/Safari-0-8-2-branch/WebCore
Moved Darin's copyright changes onto this branch.
- khtml/rendering/render_table.cpp:
- khtml/rendering/render_table.h:
- 10:46 AM Changeset in webkit [3600] by
-
- 4 edits in branches/Safari-0-8-2-branch/WebCore
Rolled changes from trunk onto branch to fix this bug:
Radar 3167025 (REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value)
Original comment for checkin:
003-02-07 Darin Adler <Darin Adler>
Reviewed by Ken.
- fixed 3167025 -- REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value
- khtml/rendering/table_layout.h: Make the fields in the Layout structure used in table width computations use int instead of short.
- khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): Make sure we don't overflow m_minWidth or m_maxWidth in case the specified fixed width value is huge. (FixedTableLayout::layout): Use ints for the calcWidth array instead of shorts. (AutoTableLayout::calcMinMaxWidth): Clamp both maxWidth and minWidth to 0x7fff to match the other code in this file, rather than using 10000.
- 10:42 AM Changeset in webkit [3599] by
-
- 5 edits in branches/Safari-0-8-2-branch/WebCore
Rolled changes from trunk onto branch to fix this bug:
Radar 3166693 (REGRESSION: infinite recursion in makeFirstResponder while tabbing as page loaded)
Original comment for checkin:
2003-02-06 Darin Adler <Darin Adler>
Reviewed by Ken.
- fixed 3166693 -- REGRESSION: infinite recursion in makeFirstResponder while tabbing as page loaded
Because we now deliver blur events, we are triggering a handler on this page that changes focus.
It triggered an infinite loop because setFocus kept setting the focus back to a text field, which
then changed the focus to its editor. The fix was to make QWidget::setFocus smarter about editors.
- kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Don't do any changes in responder until after calling KWQKHTMLPart::setDocumentFocus, since that can change focus away. If it does, return NO.
- kwq/KWQWidget.h: Add hasFocus, remove virtual from setFocus and clearFocus.
- kwq/KWQWidget.mm: (QWidget::hasFocus): Added. Moved code to check if a particular view is first responder here. Here's the bug fix too, check if the first responder is this widget's view's editor, and if so return true. (QWidget::setFocus): Do nothing if this widget already has focus. (QWidget::clearFocus): Do nothing if this widget does not have focus.
- 10:36 AM Changeset in webkit [3598] by
-
- 7 edits in branches/Safari-0-8-2-branch/WebCore
Rolled changes from trunk onto branch to fix this bug:
Radar 3165295 (Hang while triple clicking on page)
Original comment for checkin:
2003-02-06 Darin Adler <Darin Adler>
Reviewed by Dave.
- fixed 3165295 -- Hang while triple clicking on page
Flaws in the continuation logic we added to checkSelectionPoint made it take
exponential time on pages with a lot of continuations.
- khtml/rendering/render_object.h: Make checkSelectionPoint non-virtual, and added virtual checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint): Added. Does the inline continuation part of the render object walking process, which we only want to do at the top level, since otherwise we will see the same nodes multiple times. Also optimizes by only looking at the inline continuations of inlines, not any continuations of a block. (RenderObject::checkSelectionPointIgnoringContinuations): This is now the virtual function that is overriden by RenderText. It is identical to the old version of checkSelectionPoint, minus the continuation logic.
- khtml/rendering/render_text.h: Changed the name of checkSelectionPoint to checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_text.cpp: (RenderText::checkSelectionPointIgnoringContinuations): Changed the name, and nothing else.
- fixed my build which was crashing on load
- WebCore.pbproj/project.pbxproj: Change seg1addr from 2200000 to 9000000.
- 10:28 AM Changeset in webkit [3597] by
-
- 4 edits in branches/Safari-0-8-2-branch/WebCore
Rolled changes from trunk onto branch to fix this bug:
Radar 3161953 (crash due to trashed memory on XML page)
Original comment for checkin:
Reviewed by Dave.
- fixed 3161953 -- crash in KWQListImpl, DOM::CSSStyleSheetImpl::isLoading on XML page
The problem is that this page has some non-HTML elements, but the code was checking
only the element ID, not whether it is HTML or not. Also fixed the page's layout.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Check that the node is an HTML element before checking the ID in two places. Without this, we cast the pointer to the wrong type and trash memory.
- khtml/rendering/render_root.cpp: (RenderRoot::layout): Set all the children false here, not just firstChild. (RenderRoot::docHeight): Take all the children's heights into account, not just firstChild. (RenderRoot::docWidth): Take all the children's widths into account, not just firstChild.
- 10:16 AM Changeset in webkit [3596] by
-
- 1 edit in trunk/WebCore/khtml/rendering/render_object.cpp
* empty log message *
- 10:07 AM Changeset in webkit [3595] by
-
- 4 edits in trunk/WebCore
- khtml/rendering/render_table.h: Added copyright date.
- khtml/rendering/render_table.cpp: Added copyright date.
- 9:53 AM Changeset in webkit [3594] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3165171 -- REGRESSION: images overlap text
- khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Change to distribute space to the fixed columns first so the code to distribute to non-fixed columns does not assume it can distribute more to the fixed columns than it really can.
- 8:58 AM Changeset in webkit [3593] by
-
- 4 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3167025 -- REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value
- khtml/rendering/table_layout.h: Make the fields in the Layout structure used in table width computations use int instead of short.
- khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): Make sure we don't overflow m_minWidth or m_maxWidth in case the specified fixed width value is huge. (FixedTableLayout::layout): Use ints for the calcWidth array instead of shorts. (AutoTableLayout::calcMinMaxWidth): Clamp both maxWidth and minWidth to 0x7fff to match the other code in this file, rather than using 10000.
Feb 6, 2003:
- 10:50 PM Changeset in webkit [3592] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3140738 -- textarea contents are LF delimited instead of CRLF
- khtml/html/html_formimpl.cpp: (encodeCString): Turn CR followed by something other than LF into CRLF. (fixLineBreaks): Added. Turns stray CRs and LFs into CRLF. (HTMLFormElementImpl::formData): Call fixLineBreaks on form data.
- fixed 3167235 -- REGRESSION: assert after clicking on a link on radioslack.com
- kwq/KWQTextCodec.mm: (KWQTextDecoder::toUnicode): Return the null string if the passed in string pointer is NULL, rather than asserting.
- 7:27 PM Changeset in webkit [3591] by
-
- 3 edits in trunk/WebCore
Fix rollingstone regression.
Reviewed by mjs
- khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
- 4:52 PM Changeset in webkit [3590] by
-
- 7 edits in trunk/WebKit
- Made WebDownload.h a public header.
- Added stubs for the new methods.
- Moved all private methods to the WebPrivate category.
- Added FIXMEs for things that needed to be removed or implemented.
Reviewed by rjw.
- Downloads.subproj/WebDownload.h:
- Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:delegate:]): (-[WebDownload dealloc]): (-[WebDownload cancel]): (-[WebDownload _initWithLoadingHandle:request:response:delegate:]): (-[WebDownload initWithDataSource:]): (-[WebDownload receivedData:]): (-[WebDownload finishedLoading]): (-[WebDownload decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownload decodeData:dataForkData:resourceForkData:]): (-[WebDownload createFileIfNecessary]): (-[WebDownload writeDataForkData:resourceForkData:]): (-[WebDownload dataIfDoneBufferingData:]): (-[WebDownload decodeData:]): (-[WebDownload finishDecoding]):
- Downloads.subproj/WebDownloadPrivate.h:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebMainResourceClient.m:
- 4:28 PM Changeset in webkit [3589] by
-
- 5 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3166693 -- REGRESSION: infinite recursion in makeFirstResponder while tabbing as page loaded
Because we now deliver blur events, we are triggering a handler on this page that changes focus.
It triggered an infinite loop because setFocus kept setting the focus back to a text field, which
then changed the focus to its editor. The fix was to make QWidget::setFocus smarter about editors.
- kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Don't do any changes in responder until after calling KWQKHTMLPart::setDocumentFocus, since that can change focus away. If it does, return NO.
- kwq/KWQWidget.h: Add hasFocus, remove virtual from setFocus and clearFocus.
- kwq/KWQWidget.mm: (QWidget::hasFocus): Added. Moved code to check if a particular view is first responder here. Here's the bug fix too, check if the first responder is this widget's view's editor, and if so return true. (QWidget::setFocus): Do nothing if this widget already has focus. (QWidget::clearFocus): Do nothing if this widget does not have focus.
- 4:24 PM Changeset in webkit [3588] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3161953 -- crash in KWQListImpl, DOM::CSSStyleSheetImpl::isLoading on XML page
The problem is that this page has some non-HTML elements, but the code was checking
only the element ID, not whether it is HTML or not. Also fixed the page's layout.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Check that the node is an HTML element before checking the ID in two places. Without this, we cast the pointer to the wrong type and trash memory.
- khtml/rendering/render_root.cpp: (RenderRoot::layout): Set all the children false here, not just firstChild. (RenderRoot::docHeight): Take all the children's heights into account, not just firstChild. (RenderRoot::docWidth): Take all the children's widths into account, not just firstChild.
- 4:08 PM Changeset in webkit [3587] by
-
- 12 edits1 add2 deletes in trunk/WebKit
Renamed WebDownloadHandler to WebDownload.
Made ivars of WebDownload private.
Reviewed by kocienda.
- Downloads.subproj/WebDownload.h: Added.
- Downloads.subproj/WebDownload.m: Added. (-[WebDownloadPrivate init]): (-[WebDownloadPrivate dealloc]): (-[WebDownload initWithDataSource:]): (-[WebDownload dealloc]): (-[WebDownload decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownload decodeData:dataForkData:resourceForkData:]): (-[WebDownload closeFork:deleteFile:]): (-[WebDownload closeFileAndDelete:]): (-[WebDownload closeFile]): (-[WebDownload cleanUpAfterFailure]): (-[WebDownload createFileIfNecessary]): (-[WebDownload writeDataForkData:resourceForkData:]): (-[WebDownload dataIfDoneBufferingData:]): (-[WebDownload decodeData:]): (-[WebDownload receivedData:]): (-[WebDownload finishDecoding]): (-[WebDownload finishedLoading]): (-[WebDownload cancel]): (-[WebDownload path]): (-[WebDownload writeForkData:isDataFork:]): (-[WebDownload errorWithCode:]): (-[WebDownload cancelWithError:]): (-[WebDownload dataForkReferenceNumber]): (-[WebDownload setDataForkReferenceNumber:]): (-[WebDownload resourceForkReferenceNumber]): (-[WebDownload setResourceForkReferenceNumber:]): (-[WebDownload areWritesCancelled]): (-[WebDownload setWritesCancelled:]): (WriteCompletionCallback): (CloseCompletionCallback): (DeleteCompletionCallback):
- Downloads.subproj/WebDownloadHandler.h: Removed.
- Downloads.subproj/WebDownloadHandler.m: Removed.
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebController.h:
- WebView.subproj/WebDataSource.m:
- WebView.subproj/WebDataSourcePrivate.m:
- WebView.subproj/WebMainResourceClient.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient download]): (-[WebMainResourceClient isDownload]): (-[WebMainResourceClient receivedError:complete:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]):
- 3:08 PM Changeset in webkit [3586] by
-
- 7 edits in trunk/WebKit
Fixed: 3125067 - Investigate performance implications of writing download file data
Reviewed by trey, rjw, darin.
- Downloads.subproj/WebDownloadHandler.h:
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler closeFileAndDelete:]): close the file asynchronously (-[WebDownloadHandler closeFile]): call closeFileAndDelete:NO (-[WebDownloadHandler cleanUpAfterFailure]): call closeFileAndDelete:YES (-[WebDownloadHandler writeDataForkData:resourceForkData:]): call writeForkData:isDataFork: (-[WebDownloadHandler path]): new (-[WebDownloadHandler writeForkData:isDataFork:]): writes file asynchronously (-[WebDownloadHandler errorWithCode:]): moved (-[WebDownloadHandler cancelWithError:]): new, stops load with error (-[WebDownloadHandler dataForkReferenceNumber]): new (-[WebDownloadHandler setDataForkReferenceNumber:]): new (-[WebDownloadHandler resourceForkReferenceNumber]): new (-[WebDownloadHandler setResourceForkReferenceNumber:]): new (WriteCompletionCallback): new (CloseCompletionCallback): new, removes file if necessary (DeleteCompletionCallback): new,
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingWithError:]): new
- 2:11 PM Changeset in webkit [3585] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3165295 -- Hang while triple clicking on page
Flaws in the continuation logic we added to checkSelectionPoint made it take
exponential time on pages with a lot of continuations.
- khtml/rendering/render_object.h: Make checkSelectionPoint non-virtual, and added virtual checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint): Added. Does the inline continuation part of the render object walking process, which we only want to do at the top level, since otherwise we will see the same nodes multiple times. Also optimizes by only looking at the inline continuations of inlines, not any continuations of a block. (RenderObject::checkSelectionPointIgnoringContinuations): This is now the virtual function that is overriden by RenderText. It is identical to the old version of checkSelectionPoint, minus the continuation logic.
- khtml/rendering/render_text.h: Changed the name of checkSelectionPoint to checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_text.cpp: (RenderText::checkSelectionPointIgnoringContinuations): Changed the name, and nothing else.
- fixed my build which was crashing on load
- WebCore.pbproj/project.pbxproj: Change seg1addr from 2200000 to 9000000.
- 1:57 PM Changeset in webkit [3584] by
-
- 7 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- fixed 3165295 -- Hang while triple clicking on page
Flaws in the continuation logic we added to checkSelectionPoint made it take
exponential time on pages with a lot of continuations.
- khtml/rendering/render_object.h: Make checkSelectionPoint non-virtual, and added virtual checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint): Added. Does the inline continuation part of the render object walking process, which we only want to do at the top level, since otherwise we will see the same nodes multiple times. Also optimizes by only looking at the inline continuations of inlines, not any continuations of a block. (RenderObject::checkSelectionPointIgnoringContinuations): This is now the virtual function that is overriden by RenderText. It is identical to the old version of checkSelectionPoint, minus the continuation logic.
- khtml/rendering/render_text.h: Changed the name of checkSelectionPoint to checkSelectionPointIgnoringContinuations.
- khtml/rendering/render_text.cpp: (RenderText::checkSelectionPointIgnoringContinuations): Changed the name, and nothing else.
- fixed my build which was crashing on load
- WebCore.pbproj/project.pbxproj: Change seg1addr from 2200000 to 9000000.
- 12:24 PM Changeset in webkit [3583] by
-
- 12 edits in trunk
WebCore:
3137647 - ad frames get their own history entries at channels.netscape.com
3133844 - 2 items in back list at http://www.kiup-bank.com/personal/main01.html
The logic for deciding whether new entries are added to history is moved here
from WebKit. The advantage is that we can take specific action in each of the
relevant cases instead of WK the half-informed guessing WK was doing.
Here is what we now use for the lockHistory param to scheduleRedirect():
document.location = XXX - !userGesture
window.location = XXX - !userGesture
window.open - false
window.replace - true
window.reload - true
meta equiv http-refresh - delay <= 1
http-refresh - delay <= 1
Reviewed by Maciej, Darin.
- khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Rename of previous isWindowOpenAllowed(), since we know use it for multiple purposes.
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Assignment to document.location locks history if not a result of a user gesture.
- khtml/ecma/kjs_window.cpp: (Window::put): Assignment to window.location locks history if not a result of a user gesture. (WindowFunc::tryCall): Adopt rename to wasRunByUserGesture(). (Location::put): Assignment to window.location locks history if not a result of a user gesture.
- khtml/khtml_part.cpp: (KHTMLPart::receivedFirstData): http-refreshes lock history if the timeout<1
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): http-refreshes lock history if the timeout<1
WebKit:
3137647 - ad frames get their own history entries at channels.netscape.com
3133844 - 2 items in back list at http://www.kiup-bank.com/personal/main01.html
Move logic for deciding on "quick redirect" down to WebCore, where we really know
what case we're in instead of having to guess from the params we were receiving.
Reviewed by Maciej, Darin.
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): Fix build error (URL vs String)
- WebView.subproj/WebFramePrivate.h: Nuke Completing state.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Nuke Completing state. (-[WebFrame _transitionToCommitted:]): Nuke Completing state. (-[WebFrame _isLoadComplete]): Nuke Completing state. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]): Just obey lockHistory param when deciding whether we are doing a "client redirect" instead of previous guesswork.
- 11:32 AM Changeset in webkit [3582] by
-
- 14 edits in trunk/WebKit
WebKit:
Rename WebError to WebKitError.
Reviewed by maciej.
- API-Issues.rtf:
- Bookmarks.subproj/WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler writeDataForkData:resourceForkData:]): (-[WebDownloadHandler decodeData:]): (-[WebDownloadHandler finishedLoading]):
- Misc.subproj/WebKitErrors.h:
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]):
- WebView.subproj/WebView.m: (+[WebView initialize]):
WebBrowser:
Rename WebError to WebKitError.
Reviewed by maciej.
- BrowserWebController.m: (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
- LoadProgressMonitor.m: (-[LoadProgressMonitor pluginFailedWithError:dataSource:]):
- LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]):
Feb 5, 2003:
- 11:39 PM Changeset in webkit [3581] by
-
- 1 edit in trunk/WebKit/ChangeLog
WebKit:
Comment should have been "Made WebPluginError constructors private."
- ChangeLog:
WebBrowser:
Comment should have been "Made WebPluginError constructors private."
- ChangeLog:
- 10:34 PM Changeset in webkit [3580] by
-
- 9 edits1 add in trunk/WebKit
WebKit:
WebKit API clean-up:
- Added enum to WebContextMenuDelegate that is the menu item tag of the menu items passed in the default menu item array.
- WebPluginError should return URL strings.
- Made WebContextMenuDelegate constructors private.
Reviewed by rjw.
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
- Plugins.subproj/WebPluginError.h:
- Plugins.subproj/WebPluginError.m: (-[WebPluginError pluginPageURL]):
- Plugins.subproj/WebPluginErrorPrivate.h: Added.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebContextMenuDelegate.h:
- WebView.subproj/WebDefaultContextMenuDelegate.h:
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate menuItemWithTag:]): (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]):
WebBrowser:
WebKit API clean-up:
- Added enum to WebContextMenuDelegate that is the menu item tag of the menu items passed in the default menu item array.
- WebPluginError should return URL strings.
- Made WebContextMenuDelegate constructors private.
Reviewed by rjw.
- ContextMenuHandler.m: (-[ContextMenuHandler addMenuItemWithTag:fromArray:toArray:]): (-[ContextMenuHandler addMenuItemWithTitle:action:toArray:]): (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
- LoadProgressMonitor.m: (-[LoadProgressMonitor launchApplicationSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginErrorSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginFailedWithError:dataSource:]):
- 8:56 PM Changeset in webkit [3579] by
-
- 19 edits in trunk
WebCore:
Pass formValues up through the bridge at submit time.
Reviewed by Maciej
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Tell KWQPart about the form values, instead of talking to the khtmlview.
- kwq/KWQKHTMLPart.h: New ivar to store formValues.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Init ivar (KWQKHTMLPart::~KWQKHTMLPart): Free ivar (KWQKHTMLPart::openURL): Pass nil formValues (KWQKHTMLPart::openURLRequest): Pass nil formValues (KWQKHTMLPart::clearRecordedFormValues): Clear saved formValues (KWQKHTMLPart::recordFormValue): Record a name/value (KWQKHTMLPart::submitForm): Pass along recorded formValues (KWQKHTMLPart::urlSelected): Pass nil formValues
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Pass nil formValues
- kwq/WebCoreBridge.h: New params for formValues
WebKit:
WC now tells us the form values being submitted with a get/post.
We forward this info to a new WebFormDelegate method. Most of this
change is just glue passing the formValues through all our layers.
Reviewed by Maciej
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:formValues:]) Pass along formValues. (-[WebBridge postWithURL:data:contentType:triggeringEvent:formValues:]): Pass along formValues.
- WebKit.pbproj/project.pbxproj: Reorder previously added files.
- WebView.subproj/WebControllerPolicyDelegate.m: Fix latent copy/paste error where two keys had the same underlying string value!
- WebView.subproj/WebFormDelegate.h: Declare new delegate method.
- WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:willSubmitFormWithValues:]): NOP impl of new method.
- WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Pass nil formValues. (-[WebFrame reload]): Pass nil formValues.
- WebView.subproj/WebFramePrivate.h: New ivar to hold form values while waiting for the policy delegate response.
- WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): ASSERT new ivar is nil. (-[WebFrame _loadItem:fromItem:withLoadType:]): Pass nil formValues. (-[WebFrame _loadRequest:triggeringAction:loadType:formValues:]): Pass along formValues. (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): Pass nil formValues to continuation method. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formValues:andCall:withSelector:]): Stash formValues before calling policy delegate. (-[WebFrame _continueAfterNavigationPolicy:]): Resurrect formValues after calling policy delegate, pass to continuation method. (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formValues:]): Bail on nil request instead of shouldContinue=NO (-[WebFrame _loadURL:loadType:triggeringEvent:formValues:]): Pass formValues along. (-[WebFrame _loadURL:intoChild:]): Pass nil formValues. (-[WebFrame _postWithURL:data:contentType:triggeringEvent:formValues:]): Pass formValues along. (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Pass nil formValues. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formValues:]): Bail on nil request instead of shouldContinue=NO. Call new FormDelegate method. (-[WebFrame _loadDataSource:withLoadType:formValues:]): Pass formValues along. (-[WebFrame _downloadRequest:toDirectory:]): Pass nil formValues.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formValues:]): Bail on nil request instead of shouldContinue=NO (-[WebMainResourceClient handle:willSendRequest:]): Pass nil formValues.
WebBrowser:
Add new FormCompletionController class, mostly unimplemented.
Add implementation of new WebFormDelegate method, which tells us
when a form is submitted.
Reviewed by Maciej
- BrowserWindowController.m: (-[FormDelegate dealloc]): Free completion controller. (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Alloc completion controller. (-[FormDelegate frame:willSubmitFormWithValues:]): New FormDelegate method, pass on to completion controller.
- FormCompletionController.h: Added.
- FormCompletionController.m: Added. New class, NOP impls. (-[FormCompletionController initWithSourceField:frame:]): (+[FormCompletionController _loadCompletionDB]): (+[FormCompletionController frame:willSubmitFormWithValues:]): (-[FormCompletionController executeQuery]): (-[FormCompletionController reflectSelectedRow]): (-[FormCompletionController reflectFinalSelectedRow]):
- LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): Made some code a little clearer.
- WebBrowser.pbproj/project.pbxproj: New classes.
- 5:41 PM Changeset in webkit [3578] by
-
- 20 edits in trunk/WebKit
WebKit:
WebHistory* API clenaup.
Reviewed by Chris.
- Bookmarks.subproj/WebBookmarkLeaf.m:
- History.subproj/WebHistory.h:
- History.subproj/WebHistory.m:
- History.subproj/WebHistoryItem.h:
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem title]): (-[WebHistoryItem setDisplayTitle:]): (-[WebHistoryItem hash]): (-[WebHistoryItem anchor]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem _retainIconInDatabase:]): (+[WebHistoryItem entryWithURL:]): (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem parent]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]):
- History.subproj/WebHistoryItemPrivate.h:
- History.subproj/WebHistoryPrivate.h:
- History.subproj/WebHistoryPrivate.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebController.h:
- WebView.subproj/WebController.m: (-[WebController setPreferences:]): (-[WebController preferences]):
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]):
- WebView.subproj/WebDataSourcePrivate.m:
- WebView.subproj/WebFramePrivate.m:
WebBrowser:
WebHistory* API clenaup.
Reviewed by Chris.
- BrowserDocument.m:
- Debug/DebugUtilities.m:
- GlobalHistory.m: (-[GlobalHistory updateDisplayTitleForHistoryItem:]):
- URLCompletionController.m: (-[URLCompletionController tableView:objectValueForTableColumn:row:]):
Tests:
Added (-[DataResourceRequest initWithString:]).
Reviewed by me.
- SnippetEditor/DataResourceRequest.h:
- SnippetEditor/DataResourceRequest.m: (-[DataResourceRequest initWithString:]):
- SnippetEditor/SnippetController.m: (-[SnippetController updateFromText:]):
- 3:54 PM Changeset in webkit [3577] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3165682 -- REGRESSION: assertion failure in appendChildNode loading cnn.com
- khtml/rendering/render_table.cpp: (RenderTable::addChild): Get rid of double-addChild introduced when I carelessly rolled in a change from the KHTML guys.
- 2:03 PM Changeset in webkit [3576]
-
- 19 copies1 delete in tags/Safari-59
This commit was manufactured by cvs2svn to create tag 'Safari-59'.
- 2:03 PM Changeset in webkit [3575] by
-
- 8 edits in branches/Safari-0-8-2-branch
Safari-59 versionstamp
- 1:54 PM Changeset in webkit [3574] by
-
- 3 edits in trunk/WebCore
Fix for 3164949. My fix to make form controls actually obey
display settings in CSS exposed a bug in the html4.css
stylesheet. SELECT had been set to be display: block, which
is of course just plain wrong.
Reviewed by darin
- khtml/css/html4.css:
- 12:28 AM Changeset in webkit [3573] by
-
- 10 edits in trunk
WebKit:
Cleanup public WebHistory API, stage 1.
Reviewed by trey.
- History.subproj/WebHistory.h:
- History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider initWithHistory:]): (-[_WebCoreHistoryProvider containsEntryForURLString:]): (-[_WebCoreHistoryProvider dealloc]): (+[WebHistory sharedHistory]): (+[WebHistory createSharedHistoryWithFile:]):
- History.subproj/WebHistoryPrivate.h:
- History.subproj/WebHistoryPrivate.m:
WebBrowser:
Cleanup public WebHistory API, stage 1.
Reviewed by trey.
- GlobalHistory.m: (-[GlobalHistory init]):
WebCore:
Cleanup public WebHistory API, stage 1.
Reviewed by trey.
- kwq/KWQKHistoryProvider.mm:
- kwq/WebCoreHistory.h:
- kwq/WebCoreHistory.m: (+[WebCoreHistory setHistoryProvider:]): (+[WebCoreHistory historyProvider]):
Feb 4, 2003:
- 11:42 PM Changeset in webkit [3572] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3164850 -- REGRESSION: query URLs are broken
Mea culpa. The KURL test in the Tests directory failed last time, but for
some reason I didn't notice that when I ran it, perhaps due to the other
failing tests.
- kwq/KWQKURL.mm: (appendEscapingBadChars): Don't escape '?' even though it is in the "bad character" set, since this is a more-lenient definition of bad character. Also fixed a buffer overrun bug in the '%'-sequence-preserving code, which is a second way this function is lenient. We still get the speed because most characters this routine processes are not bad characters. (KURL::encode_string): Instead of calling appendEscapingBadChars, put in a strict version of the escaping loop that does not tolerate pre-existing '%' sequences or '?' characters.
- 7:52 PM Changeset in webkit [3571] by
-
- 1 add in trunk/WebKit/API-Issues.rtf
WebKit API Notes.
Reviewed by me.
- 6:38 PM Changeset in webkit [3570] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- rolled in table code fix from Dirk on the khtml-dev list
- khtml/rendering/render_table.cpp: (RenderTable::addChild): Change return back to break.
- 5:11 PM Changeset in webkit [3569] by
-
- 8 edits in branches/Safari-0-8-2-branch
Merged changes from the trunk:
2003-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebFoundation:
Merged changes from the trunk:
2003-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebCore:
Merged changes from the trunk:
2003-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebKit:
Merged changes from the trunk:
2003-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebBrowser:
Merged changes from the trunk:
2003-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebBrowser.pbproj/project.pbxproj: Updated to link against standalone frameworks instead of embeddeding them when doing a B&I build for Panther.
- 4:51 PM Changeset in webkit [3568] by
-
- 12 edits in trunk/WebCore
Reviewed by Maciej.
- we say goodbye to "MIB numbers"
- khtml/misc/decoder.cpp: (Decoder::Decoder): Get the Latin-1 codec using a name. (Decoder::setEncoding): Detect the Hebrew encoding using isISOLatin1Hebrew() instead of MIB number. (Decoder::decode): Get the UCS-2 codec using a name. Redo APPLE_CHANGES so we don't get the MIB-number-based workaround for a bug in QTextCodec that KWQ doesn't have. Get the Latin-1 codec using a name.
- khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): Get the Latin-1 codec using a name. (CachedScript::CachedScript): Get the Latin-1 codec using a name.
- kwq/KWQCharsets.h: Remove the two MIB-related functions.
- kwq/KWQCharsets.mm: Remove the MIB number from the character set table struct. Remove the MIB-related dictionary globals and functions. (buildDictionaries): Remove code to set up the MIB-related dictionaries.
- kwq/KWQTextCodec.h: Remove codecForMib, mibEnum, and encoding member functions. Add isISOLatin1Hebrew member function.
- kwq/KWQTextCodec.mm: (QTextCodec::makeDecoder): Pass in the encoding when making KWQTextDecoder rather than passing in the QTextCodec object. (QTextCodec::toUnicode): Ditto. (QTextCodec::isISOLatin1Hebrew): Return true for kCFStringEncodingISOLatinHebrew only. (KWQTextDecoder::convertUsingTEC): Get encoding directly instead of from a QTextCodec. (KWQTextDecoder::toUnicode): Ditto.
- kwq/make-charset-table.pl: Don't write out MIB numbers.
- kwq/KWQCharsetData.c: Regenerated.
- khtml/khtml_part.cpp: (KHTMLPart::completeURL): Don't bother passing the MIB number to KURL. Soon, we'll have to do something smart here, but we won't use MIB numbers.
- kwq/mac-encodings.txt: Added more 16-bit Unicode character set names. Updated some comments.
- 4:47 PM Changeset in webkit [3567] by
-
- 3 edits in trunk/WebCore
Patch calcInlineMaxWidth to add in left/right margins/borders/padding
separately (since the inline could break across multiple lines).
Reviewed by darin
- khtml/rendering/render_block.cpp: (RenderBlock::calcInlineMinMaxWidth):
- 3:58 PM Changeset in webkit [3566] by
-
- 8 edits in trunk
Reviewed by Darin.
- JavaScriptCore.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebFoundation:
Reviewed by Darin.
- WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebCore:
Reviewed by Darin.
- WebCore.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebKit:
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
WebBrowser:
Reviewed by Darin.
- WebBrowser.pbproj/project.pbxproj: Updated to link against standalone frameworks instead of embeddeding them when doing a B&I build for Panther.
- 2:51 PM Changeset in webkit [3565] by
-
- 5 edits in trunk/WebCore
Patch #1: Compacts are supposed to use their maximum intrinsic width
when determining if they will fit. I was wrongly using the
minwidth (i.e., being too aggressive about trying to squeeze
the compact in there).
Also yanking the setMaxWidth/MinWidth setters, since I'm not
using them any more.
Reviewed by kocienda
Patch #2: Implement an iterator for min/max width calculations
of blocks with inline children. This iterator will include
inline flows twice (with a bool flag indicating whether you're at the
start or end of the flow).
Reviewed by darin
- khtml/rendering/render_block.cpp: (RenderBlock::layoutBlockChildren):
- khtml/rendering/render_box.h:
- khtml/rendering/render_object.h:
- 1:34 PM Changeset in webkit [3564] by
-
- 8 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3142813 -- Safari displays a blank page when trying to open html file encoded in little-endian UTF-16
- kwq/KWQString.h: Remove fromStringWithEncoding and convertToQCString, add append that takes a QChar * and length.
- kwq/KWQString.mm: (QString::fromUtf8): Use QTextCodec instead of fromStringWithEncoding. (QString::append): Implement by calling insert.
- kwq/KWQTextCodec.h: Added an encoding() member function to QTextCodec and made QTextDecoder an abstract base class to pave the way for putting more state in it to handle multibyte encodings.
- kwq/KWQTextCodec.mm: Add KWQTextDecoder, a concrete subclass of QTextDecoder. (codecForCFStringEncoding): Moved the static inside this function for clarity. (QTextCodec::makeDecoder): Make a KWQTextDecoder. (QTextCodec::toUnicode): Make a KWQTextDecoder and use it do the decoding instead of calling fromStringWithEncoding. (KWQTextDecoder::convertUTF16): Added. Decodes Unicode, using the BOM to decide whether it's little-endian or big-endian. (KWQTextDecoder::convertUsingTEC): Added. Here's where the code from QString::fromStringWithEncoding was moved. This needs to be changed to handle state between multiple buffers passed in eventually, but not to fix this bug. (KWQTextDecoder::toUnicode): Added. Calls convertUTF16 or convertUsingTEC.
- kwq/WebCoreBridge.mm: (+[WebCoreBridge stringWithData:textEncoding:]): Use QTextCodec instead of fromStringWithEncoding.
- khtml/misc/decoder.cpp: (Decoder::decode): Rearranged the #if to make things easier to read.
- 12:41 PM Changeset in webkit [3563] by
-
- 2 edits in trunk/WebKit
Fixed: 3163879 - receivedPageIcon:forDataSource: always sends nil image
Reviewed by rjw.
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]):
- 11:08 AM Changeset in webkit [3562] by
-
- 4 edits in trunk/WebCore
Reviewed by Trey.
- fixed 3150252 -- files with question marks in their names fail to upload as attachments
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Don't include a Content-Type header at all if we don't have a MIME type to send. Matches other web browsers' behavior. (HTMLInputElementImpl::encoding): Construct the URL using setPath rather than just passing a filename to the KURL constructor. (HTMLSelectElementImpl::state): Tweak #if formatting a bit. (HTMLSelectElementImpl::restoreState): Improve comment a bit.
- kwq/KWQKURL.mm: Make ? be a "bad character". I checked carefully to be sure this does not adversely affect any calls, including running our KURL tests. (KURL::setPath): Encode the passed-in path. I determined this was correct both by looking at all the call sites in KHTML code to see that they would want this behavior, and by noticing that the path() getter decodes the path.
- 9:15 AM Changeset in webkit [3561] by
-
- 3 edits in trunk/WebCore
WebFoundation:
Reviewed by Darin
Fix for this bug:
Radar 3142922 (file URLs should never be sent as referrers)
Note that this code is added to this framework to close this security
hole for WebFoundation-only clients. Safari does not depend on this change
to fix the bug.
- ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest setReferrer:]): Return if argument passed in returns YES when sent _web_isFileURL message.
WebCore:
Reviewed by Darin
Radar 3142922 (file URLs should never be sent as referrers)
- kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Check that the referrer does not start with the prefix "file:". If it does, return nil.
- 8:53 AM Changeset in webkit [3560] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed 3135388 -- encoding changes do not affect text in form elements
The problem was that form data was being saved and restored, and in the case of buttons,
the form data was the incorrectly decoded button label.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Remove the default: case so we get a warning if we omit one of the enum values from this switch statement. (-[WebFrame _transitionToCommitted:]): Move the WebFrameLoadTypeReloadAllowingStaleData case up so it's right next to the case it should be merged with. (-[WebFrame _isLoadComplete]): Remove the default: case so we get a warning if we omit one of enum values from this switch statement. (-[WebFrame _itemForRestoringDocState]): Replace the if statement with a switch statement. Include WebFrameLoadTypeReloadAllowingStaleData, which fixes the bug.
Feb 3, 2003:
- 5:33 PM Changeset in webkit [3559]
-
- 19 copies1 delete in branches/Safari-58-1-branch
This commit was manufactured by cvs2svn to create branch
'Safari-58-1-branch'.
- 5:33 PM Changeset in webkit [3558]
-
- 19 copies1 delete in tags/Safari-58
This commit was manufactured by cvs2svn to create tag 'Safari-58'.
- 5:33 PM Changeset in webkit [3557]
-
- 19 copies1 delete in tags/SAFARI_58_1_ANCHOR
This commit was manufactured by cvs2svn to create tag
'SAFARI_58_1_ANCHOR'.
- 5:33 PM Changeset in webkit [3556] by
-
- 8 edits in branches/Safari-0-8-2-branch
Safari-58 versionstamp
- 4:51 PM Changeset in webkit [3555] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebKit
Rolled over changes from the trunk.
2003-02-03 Chris Blumenberg <cblu@apple.com>
Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe
Reviewed by kocienda, darin, mjs.
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the enco
- 4:47 PM Changeset in webkit [3554] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebCore
Rolled over changes from the main trunk.
2003-02-03 David Hyatt <hyatt@apple.com>
Fix for 3163603, livepage.apple.com repaints entire page.
Reviewed by darin.
- khtml/rendering/render_object.cpp: (RenderObject::setStyle):
- 4:43 PM Changeset in webkit [3553] by
-
- 3 edits in trunk/WebCore
Fix for 3163603, livepage.apple.com repaints entire page.
Reviewed by darin.
- khtml/rendering/render_object.cpp: (RenderObject::setStyle):
- 4:32 PM Changeset in webkit [3552] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3133902 -- leaked render objects from makeChildrenNonInline (4 after running cvs-base)
- khtml/rendering/render_block.cpp: (RenderBlock::removeChild): Deatch the anonymous block after emptying it out.
- 4:08 PM Changeset in webkit [3551] by
-
- 3 edits in trunk/WebCore
Fix for livepage.apple.com crash. The bug # is
3163508.
Reviewed by darin
- khtml/rendering/render_box.cpp: (RenderBox::setPos):
- 3:41 PM Changeset in webkit [3550] by
-
- 7 edits in trunk/WebCore
Rename TextSlave to TextRun.
Reviewed by darin
- khtml/khtml_part.cpp: (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
- khtml/rendering/bidi.cpp: (RenderBlock::layoutInlineChildren):
- khtml/rendering/render_text.cpp: (TextRun::detach): (throw): (TextRun::operator delete): (TextRun::paintSelection): (TextRun::paintDecoration): (TextRun::paintBoxDecorations): (TextRun::checkSelectionPoint): (TextRunArray::TextRunArray): (TextRunArray::compareItems): (TextRunArray::findFirstMatching): (RenderText::detach): (RenderText::deleteRuns): (RenderText::findTextRun): (RenderText::nodeAtPoint): (RenderText::checkSelectionPoint): (RenderText::cursorPos): (RenderText::posOfChar): (RenderText::paintObject): (RenderText::position): (RenderText::width):
- khtml/rendering/render_text.h:
- kwq/KWQRenderTreeDebug.cpp: (writeTextRun): (write):
- 3:19 PM Changeset in webkit [3549] by
-
- 3 edits in trunk/WebCore
Fix for assertion on nasdaq.com. Patch containingBlock
to return 0 when it can't find a containingBlock at all (e.g.,
when the object is orphaned).
Patch setOverhangingContents to deal with a null containingBlock
caused by it being called from RenderImage::setStyle().
The bug # is 3162989.
Reviewed by NOBODY (OOPS!).
- khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):
- 2:48 PM Changeset in webkit [3548] by
-
- 15 edits in trunk/WebCore
Enable support for the "run-in" and "compact" display types.
Also implementing support for :before and :after (they were not even
remotely working before these fixes).
Made sure :first-letter drills into inline children to find the
first letter in a block, e.g., so :before content can be used in
conjunction with :first-letter.
Fixed a regression in addOverhangingFloats that broke meyerweb.com's
front page.
Patched findNextLineBreak to correctly handle words that cross
inline boundaries and white-space mixtures. We now pass Hixie's
insanely evil mixed white-space test (we are the only browser
to do so).
Reviewed by kocienda
- ChangeLog:
- khtml/css/cssstyleselector.cpp:
- khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):
- khtml/rendering/render_block.cpp: (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::layoutBlockChildren): (RenderBlock::paintObject): (RenderBlock::clearFloats):
- khtml/rendering/render_box.cpp: (RenderBox::calcWidthUsing):
- khtml/rendering/render_box.h:
- khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
- khtml/rendering/render_container.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
- khtml/rendering/render_image.cpp: (RenderImage::setStyle):
- khtml/rendering/render_inline.cpp: (RenderInline::setStyle): (RenderInline::addChildToFlow):
- khtml/rendering/render_object.cpp: (RenderObject::createObject):
- khtml/rendering/render_object.h:
- khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):
- 12:09 PM Changeset in webkit [3547] by
-
- 2 edits in trunk/WebKit
Fixed headerdoc type.
Reviewed by me.
- WebView.subproj/WebDocument.h:
- 11:57 AM Changeset in webkit [3546] by
-
- 18 edits in trunk/WebKit
WebKit:
Support for new canProvideDocumentSource and documentSource API.
Updated all the representations. Added support to show for RTF source.
Moved WebKitInitializeUnicode to to early class. This was necessary
because WebCore may use the unicode property functions before WebTextRenderer
gets initialized.
Ensured guarantee that identifierForInitialRequest:fromDataSource: is called with
the first initial request.
Reviewed by maciej.
- Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation canProvideDocumentSource]): (-[WebNetscapePluginRepresentation documentSource]):
- WebCoreSupport.subproj/WebTextRenderer.m:
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setIdentifier:]):
- WebView.subproj/WebDataSource.h:
- WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource controller]): (-[WebDataSource initialRequest]):
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading:]): (-[WebDataSource _originalRequest]):
- WebView.subproj/WebDocument.h:
- WebView.subproj/WebHTMLRepresentation.h:
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): (-[WebHTMLRepresentation canProvideDocumentSource]):
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]):
- WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation canProvideDocumentSource]): (-[WebImageRepresentation documentSource]):
- WebView.subproj/WebTextRepresentation.h:
- WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation dealloc]): (-[WebTextRepresentation setDataSource:]): (-[WebTextRepresentation finishedLoadingWithDataSource:]): (-[WebTextRepresentation canProvideDocumentSource]): (-[WebTextRepresentation documentSource]):
WebBrowser:
Make us of new canProvideDocumentSource API, replacing somewhat
klunky usage of isDocumentHTML.
Reviewed by maciej.
- BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument source]):
- ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
- HTMLSourceDocument.m: (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument setDataSource:]):
- 11:28 AM Changeset in webkit [3545] by
-
- 3 edits in trunk/WebKit
Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe
Reviewed by kocienda, darin, mjs.
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the encoded filename
- 10:41 AM Changeset in webkit [3544]
-
- 16 copies1 delete in tags/Safari-57
This commit was manufactured by cvs2svn to create tag 'Safari-57'.
- 10:41 AM Changeset in webkit [3543] by
-
- 8 edits in branches/Safari-0-8-2-branch
Safari-57 versionstamp
- 9:38 AM Changeset in webkit [3542] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebCore
Rolled over changes from the main trunk.
2003-01-30 Trey Matteson <trey@apple.com>
3161486 - REGRESSION: double click on a widget causes crash
Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.
The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.
Reviewed by Darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.
- 9:02 AM Changeset in webkit [3541] by
-
- 9 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3146862 -- meta http-equiv refresh with a space before the delay does not work
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Fix code that was trying to use positions within the whitespace-stripped string, but extracting substrings from the non-stripped original.
- tweaks to render tree dumping format
- khtml/rendering/render_block.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
- khtml/rendering/render_block.cpp: (RenderBlock::renderName): Use the string RenderBlock instead of the string Block for consistency with all the other renderName results.
- khtml/rendering/render_inline.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
- khtml/rendering/render_inline.cpp: (RenderInline::renderName): Use the string RenderInline instead of the string Inline for consistency with all the other renderName results.
- khtml/rendering/render_text.h: Make textSlaves() a const member function.
- kwq/KWQRenderTreeDebug.cpp: (operator<<): Format rectangles as "x at (1,2) size 3x4" rather than "(1,2,3,4)". (quoteAndEscapeNonPrintables): Added. Makes it easy to turn an arbitrary Unicode string into something that's all ASCII. (writeTextSlave): Change this so it also writes out the text. (write): Call the new writeTextSlave, and also use "layer" instead of "RenderLayer".
Feb 1, 2003:
- 5:29 PM Changeset in webkit [3540] by
-
- 3 edits in trunk/WebCore
- fix mistake that broke build
- khtml/rendering/render_block.h: Add include of <qsortedlist.h>.
- 5:02 PM Changeset in webkit [3539] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin and Ken.
- fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): No need to assert that the controller is not deferred if this is a handle being used for a download. (-[WebMainResourceClient handle:didReceiveData:]): Likewise. (-[WebMainResourceClient handleDidFinishLoading:]): Likewise. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Likewise.
- 4:51 PM Changeset in webkit [3538] by
-
- 12 edits in trunk/WebCore
Reviewed by Dave.
- reduced the amount of RenderFlow in the world by about 1/2
- khtml/rendering/bidi.h: Take RenderBlock * instead of RenderFlow *.
- khtml/rendering/bidi.cpp: (BidiIterator::BidiIterator): Take RenderBlock * instead of RenderFlow *. (RenderBlock::layoutInlineChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::findNextLineBreak): Fix debug message to say RenderBlock instead of RenderFlow.
- khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Make RenderBlock * instead of RenderFlow *. (RenderBlock::layout): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::layoutBlockChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::clearFloats): Fix debug message to say RenderBlock instead of RenderFlow.
- khtml/rendering/render_flow.h: Return a RenderFlow * instead of a RenderObject * from createFlow.
- khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): Use an if statement instead of ? : to get rid of typecasting.
- khtml/rendering/render_html.cpp: (RenderHtml::containingBlockWidth): Fix parent call to call RenderBlock. Calling RenderFlow was a mistake, but one that didn't matter since the actual method isn't implemented until up in RenderBox anyway.
- khtml/rendering/render_inline.h: Change some parameters to RenderBlock *.
- khtml/rendering/render_inline.cpp: (cloneInline): Make this return a RenderInline * instead of a RenderFlow *. (RenderInline::splitInlines): Change some parameters to RenderBlock * and locals to RenderInline *. (RenderInline::splitFlow): Change some parameters and locals to RenderBlock *.
- khtml/rendering/render_layer.h: Remove forward declaration of class RenderFlow.
- khtml/rendering/render_object.h: Remove forward declaration and friend declaration of class RenderFlow.
- 1:39 PM Changeset in webkit [3537] by
-
- 12 edits2 adds in trunk
WebCore:
New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.
New SPI is exposed over the bridge and KWQTextField passes the text delegate msgs to it.
Reviewed by Richard
- kwq/KWQTextField.mm: Pass text delegate msgs through new SPI. (-[KWQTextField controlTextDidBeginEditing:]): (-[KWQTextField controlTextDidEndEditing:]): (-[KWQTextField controlTextDidChange:]): (-[KWQTextField control:textShouldBeginEditing:]): (-[KWQTextField control:textShouldEndEditing:]): (-[KWQTextField control:didFailToFormatString:errorDescription:]): (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextField control:isValidObject:]): (-[KWQTextField control:textView:doCommandBySelector:]):
- kwq/WebCoreBridge.h: New SPI for passing text delegate msgs.
WebKit:
New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.
New private API is exposed for the app to set a WebFormDelegate.
Reviewed by Richard
- WebCoreSupport.subproj/WebBridge.m: Pass msgs from WC on to the controller's FormDelegate. (formDelegate): Little utility function. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
- WebKit.exp: New class exported.
- WebKit.pbproj/project.pbxproj: New WebFormDelegate files.
- WebView.subproj/WebControllerPrivate.h: API to set/get FormDelegate.
- WebView.subproj/WebControllerPrivate.m: (-[WebController _setFormDelegate:]): simple setter (-[WebController _formDelegate]): simple getter
- WebView.subproj/WebFormDelegate.h: Added.
- WebView.subproj/WebFormDelegate.m: Added. NOP impls for all these delegate methods. (-[WebFormDelegate controlTextDidBeginEditing:inFrame:]): (-[WebFormDelegate controlTextDidEndEditing:inFrame:]): (-[WebFormDelegate controlTextDidChange:inFrame:]): (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]): (-[WebFormDelegate control:textShouldEndEditing:inFrame:]): (-[WebFormDelegate control:didFailToFormatString:errorDescription:inFrame:]): (-[WebFormDelegate control:didFailToValidatePartialString:errorDescription:inFrame:]): (-[WebFormDelegate control:isValidObject:inFrame:]): (-[WebFormDelegate control:textView:doCommandBySelector:inFrame:]):
WebBrowser:
New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.
This is mostly using new API, with a couple autocomplete fixes for newly exposed issues.
Reviewed by Richard
- BrowserWindowController.h: New formDelegate ivar.
- BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Create FormDelegate, an internal helper object to field WebFormDelegate messages. (-[BrowserWindowController dealloc]): Release FormDelegate. (-[BrowserWindowController controlTextDidEndEditing:]): Pass msg on to completion controller. (-[FormDelegate initWithController:]): Create CompletionController to do autocomplete (commented out for now). (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidChange:inFrame:]): Pass msg on to completion controller. (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Pass msg on to completion controller.
- CompletionController.h: Added controlTextDidBeginEditing: Should have been receiving this all along.
- CompletionController.m: (-[CompletionController _buildUI]): Set TableView font to match the textfield. (-[CompletionController _positionWindow]): Position window relative to TextField, not enclosing ScrollView (bogus code that's a NOP for the locationField). (-[CompletionController controlTextDidEndEditing:]): Hide the completion window when we leave the field.
Jan 31, 2003:
- 6:30 PM Changeset in webkit [3536] by
-
- 3 edits in trunk/WebCore
Fix regression that broke John's site. RenderInline needs
to implement childrenInline() so that it can return true.
I pulled this method out of RenderFlow and into RenderBlock,
which caused RenderInline to use RenderObject's method (and
that one returns false).
Reviewed by rjw
- khtml/rendering/render_inline.h:
- 5:44 PM Changeset in webkit [3535] by
-
- 3 edits in trunk/WebCore
Fix for crash on espn.com. Revert my change to make
containingBlock() return 0 for the root. Put it back to the
old behavior, where the root returns itself when you ask for
the root's containing block.
Reviewed by rjw
- khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):
- 5:13 PM Changeset in webkit [3534] by
-
- 3 edits in trunk/WebCore
Two whitespace handling fixes that improve <pre> handling,
especially of inline pres.
Reviewed by rjw.
- khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):
- 4:31 PM Changeset in webkit [3533]
-
- 15 copies1 delete in tags/Safari-56
This commit was manufactured by cvs2svn to create tag 'Safari-56'.
- 4:31 PM Changeset in webkit [3532] by
-
- 8 edits in branches/Safari-0-8-2-branch
Safari-56 version stamp
- 3:14 PM Changeset in webkit [3531] by
-
- 3 edits in branches/Safari-0-8-2-branch/WebCore
Rolled over changes from the main trunk.
2003-01-31 Darin Adler <Darin Adler>
Reviewed by Richard.
- khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.
- 3:13 PM Changeset in webkit [3530] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.
- 2:06 PM Changeset in webkit [3529] by
-
- 4 edits1 delete in branches/Safari-0-8-2-branch/WebCore
Rolled over changes from the main trunk.
2003-01-31 Darin Adler <Darin Adler>
- Resources/Info.plist: Removed unused file.
2003-01-31 Darin Adler <Darin Adler>
Reviewed by me, Dave wrote the code.
- fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)
- khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.
2003-01-31 Darin Adler <Darin Adler>
Reviewed by Dave.
- fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.
- 1:47 PM Changeset in webkit [3528] by
-
- 2 edits1 delete in trunk/WebCore
- Resources/Info.plist: Removed unused file.
- 1:44 PM Changeset in webkit [3527] by
-
- 26 edits4 adds in trunk/WebCore
Split RenderFlow into subclasses: RenderInline and RenderBlock.
This change should make inlines a lot smaller (since nearly all
of the member variables in RenderFlow moved into RenderBlock).
It also simplifies methods like containingBlock(), which can
now return a RenderBlock.
Reviewed by darin
- WebCore.pbproj/project.pbxproj:
- khtml/css/cssstyleselector.cpp:
- khtml/rendering/bidi.cpp: (RenderBlock::bidiReorderLine): (RenderBlock::layoutInlineChildren): (RenderBlock::findNextLineBreak):
- khtml/rendering/render_block.cpp: Added. (:RenderFlow): (RenderBlock::~RenderBlock): (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::makeChildrenNonInline): (RenderBlock::removeChild): (RenderBlock::layout): (RenderBlock::layoutBlockChildren): (RenderBlock::layoutSpecialObjects): (RenderBlock::paint): (RenderBlock::paintObject): (RenderBlock::paintFloats): (RenderBlock::insertSpecialObject): (RenderBlock::removeSpecialObject): (RenderBlock::positionNewFloats): (RenderBlock::newLine): (RenderBlock::leftOffset): (RenderBlock::leftRelOffset): (RenderBlock::rightOffset): (RenderBlock::rightRelOffset): (RenderBlock::lineWidth): (RenderBlock::nearestFloatBottom): (RenderBlock::floatBottom): (RenderBlock::lowestPosition): (RenderBlock::rightmostPosition): (RenderBlock::leftBottom): (RenderBlock::rightBottom): (RenderBlock::clearFloats): (RenderBlock::addOverHangingFloats): (RenderBlock::checkClear): (RenderBlock::nodeAtPoint): (RenderBlock::calcMinMaxWidth): (next): (RenderBlock::calcInlineMinMaxWidth): (RenderBlock::calcBlockMinMaxWidth): (RenderBlock::close): (RenderBlock::printTree): (RenderBlock::dump):
- khtml/rendering/render_block.h: Added.
- khtml/rendering/render_body.cpp: (RenderBody::RenderBody): (RenderBody::setStyle): (RenderBody::layout): (RenderBody::availableHeight):
- khtml/rendering/render_body.h:
- khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth): (RenderBox::calcHeight):
- khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
- khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): (RenderFlow::addChildWithContinuation):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_form.h:
- khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml): (RenderHtml::setStyle): (RenderHtml::layout):
- khtml/rendering/render_html.h:
- khtml/rendering/render_image.h:
- khtml/rendering/render_inline.cpp: Added. (:RenderFlow): (RenderInline::~RenderInline): (RenderInline::setStyle): (RenderInline::addChildToFlow): (cloneInline): (RenderInline::splitInlines): (RenderInline::splitFlow): (RenderInline::paint): (RenderInline::paintObject): (RenderInline::calcMinMaxWidth): (RenderInline::offsetWidth): (RenderInline::offsetHeight): (RenderInline::offsetLeft): (RenderInline::offsetTop):
- khtml/rendering/render_inline.h: Added.
- khtml/rendering/render_list.cpp: (RenderListItem::RenderListItem): (RenderListItem::setStyle): (getParentOfFirstLineBox): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout): (RenderListItem::paint): (RenderListItem::paintObject):
- khtml/rendering/render_list.h:
- khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::containingBlock): (RenderObject::setOverhangingContents): (RenderObject::removeFromSpecialObjects):
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.h:
- khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::calcMinMaxWidth): (RenderRoot::layout): (RenderRoot::paintObject):
- khtml/rendering/render_root.h:
- khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::lineHeight): (RenderTable::baselinePosition): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::recalcSections): (RenderTable::dump): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::close): (RenderTableCell::repaintRectangle): (RenderTableCell::absolutePosition): (RenderTableCell::setStyle): (RenderTableCell::dump):
- khtml/rendering/render_table.h:
- khtml/rendering/render_text.h:
- khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
- 1:13 PM Changeset in webkit [3526] by
-
- 3 edits in trunk/WebCore
Reviewed by me, Dave wrote the code.
- fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)
- khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.
- 1:09 PM Changeset in webkit [3525] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.
- 12:55 PM Changeset in webkit [3524] by
-
- 7 edits in trunk
WebCore:
- kwq/WebCoreBridge.mm: fixed key value
WebKit:
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- WebView.subproj/WebController.m: fixed key value
WebBrowser:
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 9:38 AM Changeset in webkit [3523] by
-
- 14 edits in trunk
WebCore:
Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page
Reviewed by darin.
- kwq/WebCoreBridge.h: added WebCoreElementImageRectKey
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): get the rect of the image
WebKit:
Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page
Reviewed by darin.
- Misc.subproj/WebNSViewExtras.h:
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): take a rect so we know the original size and origin
- WebKit.exp: added WebElementImageRectKey
- WebView.subproj/WebController.h: WebElementImageRectKey
- WebView.subproj/WebController.m: WebElementImageRectKey
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): call _web_dragPromisedImage with WebElementImageRect
- WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): provide the WebElementImageRect since we do this for other image elements (-[WebImageView mouseDragged:]): call _web_dragPromisedImage with [self bounds]
- 8:54 AM Changeset in webkit [3522] by
-
- 4 edits in trunk/WebCore
3161088 - disabled select elements are not disabled when scrolling list used
We use a tableview delegate method to prevent the user from changing the
selection when disabled. Too bad tableviews don't know how to disable themselves.
We also condition the cell used for drawing to match our enabled state.
Reviewed by Maciej.
- kwq/KWQListBox.h: Keep track of whether we are enabled.
- kwq/KWQListBox.mm: (QListBox::QListBox): Init new flag. (QListBox::setEnabled): Set new flag. (QListBox::isEnabled): Getter for new flag. (-[KWQListBoxTableViewDelegate selectionShouldChangeInTableView:]): Disallow selection changes if disabled. (-[KWQListBoxTableViewDelegate tableView:willDisplayCell:forTableColumn:row:]): Enable cell based on our enabled state to get visual feedback of being disabled.
Jan 30, 2003:
- 8:59 PM Changeset in webkit [3521] by
-
- 3 edits in trunk/WebCore
3161486 - REGRESSION: double click on a widget causes crash
Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.
The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.
Reviewed by Darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.
- 8:09 PM Changeset in webkit [3520]
-
- 6 copies in tags/Safari-55
This commit was manufactured by cvs2svn to create tag 'Safari-55'.
- 8:09 PM Changeset in webkit [3519]
-
- 6 copies in branches/Safari-0-8-2-branch
This commit was manufactured by cvs2svn to create branch
'Safari-0-8-2-branch'.
- 8:09 PM Changeset in webkit [3518]
-
- 6 copies in tags/SAFARI_0_8_2_BRANCH_ANCHOR
This commit was manufactured by cvs2svn to create tag
'SAFARI_0_8_2_BRANCH_ANCHOR'.
- 8:09 PM Changeset in webkit [3517] by
-
- 6 edits in trunk/WebCore
Reviewed by Ken, Maciej, and Trey.
- fixed 3161486 -- REGRESSION: double click on a widget causes crash
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Only pass the mouseUp event if it's not the same as the current event. Through a strange set of circumstances, sometimes the "mouse down" event is a mouse up event (due to KHTML vs. AppKit differences for double-click handling).
- fixed build with newer compiler
- khtml/html/Makefile.am: Use ANSI-C style, not C++ style, gperf.
- khtml/html/doctypes.cpp: Regenerated.
- khtml/html/html_documentimpl.cpp: Do inline workaround to make newer compiler happy. (HTMLDocumentImpl::determineParseMode): Change to use ANSI-C style.
- 4:42 PM Changeset in webkit [3516] by
-
- 4 edits in trunk
tree is open, 56u is build version, now on the path to beta 2 officially
- 4:34 PM Changeset in webkit [3515] by
-
- 8 edits in trunk
Safari-55 version stamp
- 4:13 PM Changeset in webkit [3514] by
-
- 3 edits in trunk/WebKit
Backed out my fix for 3161102. Richard and I found problems the fix. 3161102 turns out to not be an issue.
Reviewed by rjw.
- History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]):
- 2:17 PM Changeset in webkit [3513] by
-
- 3 edits in trunk/WebCore
Fix for 3156831 (and dupe 3160816). Don't access userInfo on an invalid NSTimer.
Reviewed by trey.
- kwq/KWQObject.mm: (QObject::pauseTimer): (QObject::resumeTimers):
- 2:11 PM Changeset in webkit [3512] by
-
- 3 edits in trunk/WebKit
Fixed: 3161102 - Avoid retain cycles by destroying plug-ins in the page cache before dealloc
Reviewed by rjw.
- History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]): iterate over all of the plug-ins and call destroy
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]): clear page cache
- 1:41 PM Changeset in webkit [3511] by
-
- 3 edits in trunk/WebCore
3160565 - REGRESSION: Can't log in to etrade
Fix regression caused by fixed to 3058229. We auto-select an item of a select element
if it is size=1 or size is unset (m_size==0 in the code).
This gives us conformance with WinIE. The test at dbaron.org fails us for the
case of a disabled list with no size and no initial selection.
Reviewed by Darin.
- khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::recalcListItems): Auto-select an item if size==1 or is unset.
- 1:22 PM Changeset in webkit [3510] by
-
- 3 edits in trunk/WebCore
Make quirk bits part of the bitfield to shrink RenderFlows.
Reviewed by trey
- khtml/rendering/render_flow.h:
- 12:24 PM Changeset in webkit [3509] by
-
- 5 edits in trunk/WebCore
Fix for 3155954. Make sure no layers get made for :before,
:after or :first-letter. The only debatable case is whether
overflow can apply to generated content. Included a FIXME
to think about that case.
Reviewed by darin
- khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
- khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):
- khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
- 12:03 PM Changeset in webkit [3508] by
-
- 3 edits in trunk/WebKit
Fixed: 3160464 - Slideback sometimes happens twice
Because we start drags in mouseDragged (which AppKit says we shouldn't), we get mouseDragged events after a drag (image, link, text etc) has ended. We also get mouseDragged events after we've sent the fake mouseUp to WebCore. That is probably bad for unknown reasons.
Reviewed by darin.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebHTMLView mouseDragged:]): check ignoringMouseDraggedEvents (-[WebHTMLView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to NO
- WebView.subproj/WebHTMLViewPrivate.h: added ignoringMouseDraggedEvents
- 11:25 AM Changeset in webkit [3507] by
-
- 3 edits in trunk/WebCore
- khtml/html/html_documentimpl.cpp: Updated license.
- 9:12 AM Changeset in webkit [3506] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed 3160710 -- REGRESSION: bizrate.com front page ad in wrong position
The new code to compute port coordinates was screwing up somehow.
I had to roll it out and we'll have to try again to fix the problem Ed was fixing.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Roll back changes between 1.45 and 1.47.
- 8:08 AM Changeset in webkit [3505] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3158958 -- nil-dereference in KJS::DOMNode::getValueProperty at www.babyage.com
- khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Move the code that gets the render object down after the point where the render tree is updated, so we don't end up using a stale pointer.
Jan 29, 2003:
- 10:32 PM Changeset in webkit [3504] by
-
- 3 edits in trunk/WebCore
- add new assertion that Dave can use to debug bug 3155954 tomorrow
- khtml/rendering/render_arena.cpp: (RenderArena::allocate): Assert that the arena is not 0. (RenderArena::free): Change signature so we will detect double-frees even more simply.
- 8:48 PM Changeset in webkit [3503] by
-
- 5 edits in trunk/WebCore
Margins were being lost on documents inside iframes
and objects. This turned out to be 3 different bugs, one
of which involved the bad cast of an object element to an
iframe element.
Reviewed by darin
- khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::HTMLIFrameElementImpl):
- khtml/rendering/render_frames.cpp: (RenderPartObject::slotViewCleared):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
- 5:11 PM Changeset in webkit [3502] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed 3158624 -- crash reentering WebBaseNetscapePluginView removeTrackingRect closing window
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView removeTrackingRect]): Set tracking tag to 0 before releasing the window to prevent reentering.
- 4:29 PM Changeset in webkit [3501] by
-
- 2 edits in trunk/WebCore
Fix for auto width tables. Prevent overflow when assigning from
the computed integer max width back into a short value.
Fixes cnn.com and spies.com. Bug # is 3158469.
Reviewed by darin
- khtml/rendering/table_layout.cpp: (AutoTableLayout::calcMinMaxWidth):
- 4:28 PM Changeset in webkit [3500] by
-
- 3 edits in trunk/WebCore
Fix for auto width tables. Prevent overflow when assigning from
the computed integer max width back into a short value.
Fixes cnn.com and spies.com. Bug # is 3158469.
Reviewed by darin
- khtml/rendering/table_layout.cpp: (AutoTableLayout::calcMinMaxWidth):
- 4:28 PM Changeset in webkit [3499] by
-
- 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m
Reviewed by Ken
- Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): fixed an NSString leak found with the leaks tool.
- 4:23 PM Changeset in webkit [3498] by
-
- 5 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3150439 -- navigating to a .xml, then away, then back causes display problems
- khtml/rendering/render_root.h: Add paintBoxDecorations
- khtml/rendering/render_root.cpp: (RenderRoot::paintObject): Call paintBoxDecorations all the time. Don't consult shouldPaintBackgroundOrBorder(), and don't waste cycles on !isInline(). (RenderRoot::paintBoxDecorations): If we don't have a RenderHtml as our first child, then fill with the background color.
- khtml/html/htmlparser.cpp: (KHTMLParser::finished): Remove code that makes an HTML element for an empty document. We don't need it any more.
- 3:40 PM Changeset in webkit [3497] by
-
- 9 edits in trunk/WebKit
Reviewed by Darin.
Fix for this bug:
Radar 3142818 (Downloading many items quickly can cause future page loads to fail)
The issue was with a mismatch between different object's idea about
whether callbacks were being deferred. I have simplified the code in this
area somewhat, and I have added some asserts to make sure that callbacks
are not sent when deferalls are on.
More work will need to be done in callback deferral-land, however. This change
fixes the bug, but it may not be a good long-term fix. I will file a bug on
the need for this additonal work.
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate defersCallbacks]): Added method.
- WebView.subproj/WebMainResourceClient.h: Removed unneeded defersBeforeCheckingPolicy flag.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:request:]): Unconditionally set callback deferrals to NO. (-[WebMainResourceClient handle:willSendRequest:]): Remove all callback deferral code here. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Unconditionally set callback deferrals to NO. (-[WebMainResourceClient handle:didReceiveResponse:]): Assert that the handle argument to this method, the client (self), and the data source's controller all are not deferring callbacks. Unconditionally set callback deferrals to YES. (-[WebMainResourceClient handle:didReceiveData:]): Ditto (-[WebMainResourceClient handleDidFinishLoading:]): Ditto (-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto
- 3:33 PM Changeset in webkit [3496] by
-
- 2 edits in trunk/WebKit
- fixed 3160116 -- REGRESSION:leak in WebBookmarkLeaf at startup
Reviewed by Darin
- Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): don't leak the _entry that was created in initWithURLString:title:group:
- 3:21 PM Changeset in webkit [3495] by
-
- 5 edits in trunk/WebCore
Fix for tables. They weren't initializing their max top/bottom
values for margin collapsing, so their margins were being
ignored!
Reviewed by darin
- khtml/rendering/render_flow.cpp: (RenderFlow::layout):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_table.cpp: (RenderTable::layout):
- 2:00 PM Changeset in webkit [3494] by
-
- 3 edits in trunk/WebCore
Back out my removal of the layer optimization. The rest of
the code is not prepared to deal with child elements overriding
visibility, or with invisible layers sitting on top of
visible ones.
- khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
- 1:53 PM Changeset in webkit [3493] by
-
- 5 edits in trunk/WebKit
3159750 - REGRESSION: cursor is I-beam when over a standalone image
We now reset the cursor to arrow before switching doc views.
Also, made various replacements of "id <WebDocumentView>" with "NSView < WebDocumentView> *"
to get better compile time checking.
Reviewed by Darin.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Use NSView* (-[WebFrame _transitionToCommitted:]): Use NSView*
- WebView.subproj/WebViewPrivate.h: Use NSView*
- WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): Use NSView*. Reset cursor. (-[WebView _makeDocumentViewForDataSource:]): Use NSView*
- 12:55 PM Changeset in webkit [3492] by
-
- 3 edits in trunk/WebKit
3159529 - REGRESSION: URLs with no path are saved as "-.html"
Reviewed by darin, trey, kocienda.
- Misc.subproj/WebResourceResponseExtras.m: (-[NSURL _web_suggestedFilenameForSavingWithMIMEType:]): Don't use the lastPathComponent if it is "/".
- 12:46 PM Changeset in webkit [3491] by
-
- 4 edits in trunk/WebCore
Fix yet another bug with makeChildrenNonInline that caused the
assertion on 3158194. Rather than trying to work with the
function as it was written by the KHTML guys, I've just thrown
everything out and re-written it using a helper function to make
it more clear what's going on (and less error-prone).
Reviewed by darin
- khtml/rendering/render_flow.cpp: (getInlineRun): (RenderFlow::makeChildrenNonInline):
- 10:45 AM Changeset in webkit [3490] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- kjs/scope_chain.cpp: Rolled out the fix to bug 3137084. It caused a massive storage leak, and probably didn't even fix the bug.
- 10:01 AM Changeset in webkit [3489] by
-
- 3 edits in trunk/WebCore
- khtml/rendering/break_lines.cpp: (isBreakable): Fix error that prevented this from compiling. I had failed to build, and then tested the version without my change! I retested with the change.
- 8:38 AM Changeset in webkit [3488] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- 3158477 -- text break locator leak leads to giant (2.04 GB) VSIZE idling at livepage
- khtml/rendering/break_lines.cpp: (isBreakable): Dispose the text locator.
Jan 28, 2003:
- 7:19 PM Changeset in webkit [3487] by
-
- 3 edits in trunk/WebKit
Removing ERROR() that isn't an error, left over from the Safari-48 download firedrill.
Reviewed by Chris.
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Don't ERROR if we are asked to cleanup a file and there is nothing to cleanup. This can happen in the rare case of the download being canceled before the first byte arrives, and we deal properly, no ERROR.
- 7:13 PM Changeset in webkit [3486] by
-
- 1 edit in trunk/WebCore/khtml/html/html_documentimpl.cpp
* empty log message *
- 5:28 PM Changeset in webkit [3485] by
-
- 3 edits in trunk/WebCore
Fix quirks/strict regression caused by improper use of findRev (should
be find), and latin1() (can't be invoked on temporaries).
Reviewed by darin
- khtml/html/html_documentimpl.cpp: (parseDocTypePart): (HTMLDocumentImpl::determineParseMode):
- 4:26 PM Changeset in webkit [3484] by
-
- 4 edits in trunk/WebCore
Fix for 3155209, dashed-line schmutz left behind when dragging
links.
Also porting a fix from the old table code to the new table code
that I missed.
Reviewed by darin
- khtml/rendering/render_object.cpp: (RenderObject::setStyle):
- khtml/rendering/render_table.cpp: (RenderTable::layout):
- 3:08 PM Changeset in webkit [3483] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Ken.
- fixed 3157318 -- hang at time zone page after clicking on map at www.time.gov
- kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a comma after the day. Given how this code is structured, it allows commas in unwanted contexts too, but that's almost certainly harmless.
- 2:34 PM Changeset in webkit [3482] by
-
- 5 edits in trunk/WebKit
Fixed: 3150856 - crash with full-size plugins in frame or iframe
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): added assert
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): added assert
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Don't call setDataSource here because the view is not in the view hierarchy at this point.
- WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Call setDataSource on the document view after it has been placed in the view hierarchy. This what we for the top-level view, so should do this for views in subframes as well.
- 2:20 PM Changeset in webkit [3481] by
-
- 16 edits2 adds in trunk/WebCore
New implementation of determineParseMode that is much better
about getting the quirks vs. strict decision right (as compared
to Mozilla and WinIE).
Also made a new inQuirksMode function and converted callers of
parseMode to use it, so that AlmostStrict and Strict modes will
both be treated as non-quirks mode by those who check for this
sort of thing.
Reviewed by darin, mjs
- khtml/html/html_documentimpl.cpp: (parsePS): (containsString): (parseDocTypeDeclaration): (HTMLDocumentImpl::determineParseMode):
- khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
- khtml/html/htmlparser.cpp: (KHTMLParser::parseToken):
- khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
- khtml/rendering/render_list.cpp: (getParentOfFirstLineBox):
- khtml/rendering/render_object.cpp: (RenderObject::createObject):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::determineParseMode):
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::createDecl):
- kwq/KWQString.mm: (QString::compare):
- 2:08 PM Changeset in webkit [3480] by
-
- 13 edits in trunk/WebKit
Fixed: 3156172 - No filename correction when downloading images via drag & drop
Reviewed by mjs, john, trey.
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]): call _downloadURL:toDirectory: (-[WebController _downloadURL:toDirectory:]): call -[WebFrame _downloadRequest:toDirectory:]
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): release the download directory (-[WebDataSource _setDownloadDirectory:]): new (-[WebDataSource _downloadDirectory]): new
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _downloadRequest:toDirectory:]): renamed
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call -[WebController _downloadURL:toDirectory:]
- WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): call -[WebController _downloadURL:toDirectory:]
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the data source has a download directory, use it plus the filename from the response as download path
- 1:55 PM Changeset in webkit [3479] by
-
- 4 edits in trunk/WebCore
Reviewed by Ken and Maciej.
- fixed remaining bit of 3142646 -- JavaScript Error reported at www.hotmail.com after first time
The problem was that forms that were attached, but had no render object yet, were
not in the form names dictionary. This causes trouble for JavaScript that runs before
style sheets load, since the FOUC code makes us not create render objects at that stage.
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::attach): Don't check m_render before adding to dictionary. (HTMLFormElementImpl::parseAttribute): Use attached(), not m_render, to tell whether to track the name of the form in the dictionary.
- khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): Use attached(), not m_render, to tell whether to track the name of the image in the dictionary. (HTMLImageElementImpl::attach): Don't check m_render before adding to dictionary.
- 12:50 PM Changeset in webkit [3478] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed 3144918 -- Can't drill down multiple levels of categories when selling on ebay if first item in list is chosen
The bug was caused by having array values in the property map past the storageLength cutoff
in an array object; those values would not be seen when you do a get.
- kjs/array_object.cpp: (ArrayInstanceImp::put): Implement a new rule for resizing the storage that is independent of the length. The old rule would sometimes make the storage very big if you added two elements in a row that both had large, but consecutive indexes. This eliminates any cases where we make sparse entries in the property map below the sparse array cutoff. (ArrayInstanceImp::resizeStorage): Don't ever make storage size bigger than the cutoff unless the caller specifically requests it. (ArrayInstanceImp::setLength): Change this so it only makes the storage smaller, never larger. We will actually enlarge the storage when putting elements in.
- 12:32 PM Changeset in webkit [3477] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- fixed 3157014 - Crash on disabling JavaScript and reloading livepage.apple.com
- khtml/khtml_part.cpp: (KHTMLPart::openURL): Move check of JavaScript setting and possible disabling from here... (KHTMLPart::begin): ... to here, to make sure it happens after clearing the interpreter.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::resumeActions): Don't bother to restore timers if JavaScript is off.
- 12:11 PM Changeset in webkit [3476] by
-
- 3 edits in trunk/WebCore
3158465 - REGRESSION: cursor turns into I-beam after clicking on most KWQ widgets
When we return from handing a mousedown to an AK widget, we check to see if currentEvent
is now a MouseUp, in which case we hand it to khtml. This allows khtml to keep in
synch as to the state of the mouse. This covers the case of AK widgets that
run their own event loop and consume events until a mouseup (but not ones that use
Carbon, such as PopUpList, since Carbon does not update currentEvent).
Reviewed by Darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Pass mouseup to khtml.
- 10:39 AM Changeset in webkit [3475] by
-
- 7 edits in trunk
WebCore:
2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window
3158238 - cursor shape does not track after double-click to activate a window
Reviewed by Darin.
- khtml/khtmlview.cpp: (KHTMLView::viewportMouseDoubleClickEvent): We get this when the mouse goes up the second time, so clear d->mousePressed.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mouseMoved): Pitch any mousemoved that comes through while we think the mouse is down. Those screw up our tracking, like 3137661. This is part of the 2940179 fix.
WebKit:
2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window
3158240 - cursor does not track when switching from panels to safari windows
Two changes here: First, we post fake mousemoved events to get the cursor fixed up
without checking if the mouse is down (WC deals with that now). That fixes 2940179,
because the button is down when we get notified of becoming key.
Second, we observe key window instead of main window notifications everywhere, so we
update the cursor when clicking between a panel and our doc windows.
Reviewed by Darin.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): s/main/key/g (-[WebHTMLView addWindowObservers]): s/main/key/g (-[WebHTMLView removeWindowObservers]): s/main/key/g (-[WebHTMLView windowDidBecomeKey:]): s/main/key/g (-[WebHTMLView windowDidResignKey:]): s/main/key/g
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Always post mousemoved event.
- 9:26 AM Changeset in webkit [3474] by
-
- 4 edits in trunk/WebKit
- fixed 3158304 -- Assertion failure cancelling "Add Bookmark" or deleting newly-created bookmarks
Reviewed by Darin
- Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _bookmark:changedUUIDFrom:to:]): new method that notifies group when a bookmark that's already in a group changes its UUID -- the UUID to bookmark dictionary updates for this change.
- Bookmarks.subproj/WebBookmarkGroupPrivate.h: private declaration for this method
- Bookmarks.subproj/WebBookmark.m: (-[WebBookmark _setUUID:]): notify group when UUID changes (-[WebBookmark UUID]): ditto
- 8:23 AM Changeset in webkit [3473] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed 3156197 -- leak in -[WebBookmarkList initFromDictionaryRepresentation:withGroup:]
- Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): Fixed storage leak by not allocating the list here, because [self init] will be called and that will allocate the list.
Jan 27, 2003:
- 8:55 PM Changeset in webkit [3472] by
-
- 5 edits in trunk/WebCore
3157146 REGRESSION: using a pop-up menu turns the cursor into an I-beam
A hack for the benefit of AK's PopUpButton, which uses the Carbon menu
manager, which thus eats all subsequent events after it is starts its
modal tracking loop. After the interaction is done, we call a new routine
to fix things up in the khtml event world. We post a fake mouse up to balance
the mouse down we started with. In addition, we post a fake mouseMoved to get
the cursor in sync with whatever we happen to be over after the tracking is done.
Reviewed by Darin.
- kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Call part after NSPopUp's modal tracking consumes events.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::doFakeMouseUpAfterWidgetTracking): New routine to allow widgets to get out event state fixed up after a modal tracking loop.
- 5:15 PM Changeset in webkit [3471] by
-
- 1 edit in trunk/WebKit/ChangeLog
WebFoundation:
Reviewed by Darin and Ken.
- fixed 3153098 - Implement "simple retry" when Safari fails to validate a certifcate
- Misc.subproj/WebError.h:
- Misc.subproj/WebError.m: (classInitialize): Added new "unknown root cert" error.
- English.lproj/Localizable.strings: Updated.
- ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler setCertificatePolicyOnStream]): If the request says to allow unknown roots, do so.
- ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Report unknown root error properly.
- ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
- ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest setAllowSSLCertificatesWithUnknownRoots:]): New method to allow unknown root certs on a per-request basis. (-[WebResourceRequest allowSSLCertificatesWithUnknownRoots]): Corresponding getter. (-[WebHTTPResourceRequestParameters copyWithZone:]): Account for new field. (-[WebHTTPResourceRequestParameters isEqual:]): Likewise.
WebKit:
Reviewed by Darin and Ken.
- English.lproj/StringsNotToBeLocalized.txt: Removed unused exception.
WebBrowser:
Reviewed by Darin and Ken.
- fixed 3153098 - Implement "simple retry" when Safari fails to validate a certifcate
- LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): If the error was unknown root certificate, put up a sheet asking whether the user wants to continue (actually retry for now).
- English.lproj/Localizable.strings: Updated.
- 4:12 PM Changeset in webkit [3470] by
-
- 10 edits in trunk
WebCore:
Fixed: 3152053 - Safari: Java 141: Only visible applets are instantiated on web page
Reviewed by dave.
- khtml/rendering/render_applet.cpp: (RenderApplet::layout): move the widget before calling showApplet
- kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): add the java view to the main view immediately instead of waiting for first paint
- kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionImage]): tweak
WebKit:
Fixed: 3156230 - REGRESSION: Java 141: Safari Does Not Stop Applets When Browser Window Closes
Reviewed by dave.
- Plugins.subproj/WebPluginController.h:
- Plugins.subproj/WebPluginController.m: (-[WebPluginController destroyAllPlugins]): renamed from HTMLViewWillBeDeallocated because it may get called before the dealloc
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView addWindowObservers]): observe NSWindowWillCloseNotification (-[WebHTMLView removeWindowObservers]): remove observer for NSWindowWillCloseNotification (-[WebHTMLView windowWillClose:]): call destroyAllPlugins
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): call destroyAllPlugins
- 3:50 PM Changeset in webkit [3469] by
-
- 6 edits in trunk/WebKit
Fixed 3139909. Fake the resource load delegate messages (minus willSendRequest)
when a page is loaded from a the page cache.
Reviewed by john.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]):
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addResponse:]): (-[WebDataSource _responses]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]):
- 3:33 PM Changeset in webkit [3468] by
-
- 2 edits in trunk/WebKit
3157104 - reproducible assert in _continueFragmentScrollAfterNavigationPolicy
Remove assertion, and it turns out the existing code will handle the case.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
- 2:59 PM Changeset in webkit [3467] by
-
- 7 edits in trunk/WebCore
Reviewed by Darin.
- fixed 3156461 - SECURITY: contentDocument of iframe from other domain can be accessed
- fixed 3156462 - SECURITY: can invoke setTimeout on other window
- fixed 3156469 - SECURITY: can add an event listener on another protected window
- fixed 3156527 - SECURITY: Can access HTML document from different domain in another frame
- fixed 3156535 - SECURITY: Can access XML document from different domain in another frame
These fixes are merged from or inspired by security fixes in upstream khtml.
- khtml/ecma/kjs_dom.h:
- khtml/ecma/kjs_dom.cpp: (KJS::checkNodeSecurity): Prototype new method used to check whether a document is allowed to access the contents of a node.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Apply security check to getting the contentDocument of an iframe or object.
- khtml/ecma/kjs_window.cpp: (Window::get): Make sure addEventListener/removeEventListener, and all timer related functions are protocted from cross-domain calls. (WindowFunc::tryCall): Make sure this is true even if they are detached from one window and called on another.
- khtml/khtml_part.cpp: (KHTMLPart::checkEmitLoadEvent): When setting frames to the domain of the parent document, don't force it, so the usual suffix check rule will apply.
- 2:13 PM Changeset in webkit [3466] by
-
- 6 edits in trunk
WebKit:
Make emptying the page cache synchronous when "Empty Cache"
is selected from menu. More bulletproofing to ensure that
3155781 doesn't happen.
Reviewed by trey.
- History.subproj/WebBackForwardList.m: (-[WebBackForwardList clearPageCache]):
WebCore:
Reviewed by trey.
Added ASSERT trap to help track down non-repro crash reported
by 3144546.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
Remove assert that caused 3155781. We believe this was happening
because of a delayed release of the page cache after emptying cache
from "Empty Cache" menu item.
- kwq/KWQPageState.mm: (-[KWQPageState dealloc]):
*.lut.h changes are spurious.
*.c changes are spurious.
- 1:00 PM Changeset in webkit [3465] by
-
- 7 edits in trunk/WebCore
Fix text dragging so that text inside floats paints when you
drag the selection.
Reviewed by cblu
- ChangeLog:
- khtml/rendering/render_flow.cpp: (RenderFlow::paintObject): (RenderFlow::paintFloats):
- khtml/rendering/render_flow.h:
- 11:55 AM Changeset in webkit [3464] by
-
- 2 edits in trunk/WebKit
Fixed: 3156235 - change throttle for plug-in null events to 50 frames per second (when frontmost)
Reviewed by dave.
- Plugins.subproj/WebBaseNetscapePluginView.m:
- 11:37 AM Changeset in webkit [3463] by
-
- 5 edits in trunk/WebKit
WebKit:
Fixed 3151241. Cleanly handle nil return from resource:willSendRequest:fromDataSource:.
Reviewed by trey.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
- WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]):
Tests:
Removed unneeded local variable that shadowed ivar.
Reviewed by me.
- SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):
- 11:31 AM Changeset in webkit [3462] by
-
- 2 edits in trunk/WebKit
- fixed 3156744 -- REGRESSION: Renaming bookmarks dragged into bookmark bar does not work at first
Reviewed by Darin
- Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList insertChild:atIndex:]): was adding self to its own group (a no-op), instead of adding the new child to self's group. This was a typo from the refactoring to fix 3152427.
- 10:43 AM Changeset in webkit [3461] by
-
- 2 edits in trunk/WebKit
- English.lproj/StringsNotToBeLocalized.txt: Updated for changes I previously made.
Jan 26, 2003:
- 11:41 PM Changeset in webkit [3460] by
-
- 7 edits in trunk
WebCore:
Fixed: 3156725 - Partially selected links show extra underlining when dragged
Fixed: 3156962 - Text drag image sometimes doesn't include last selected text node
Reviewed by darin.
- khtml/rendering/render_root.cpp: (RenderRoot::selectionRect): include all nodes that are selected
- khtml/rendering/render_text.cpp: (TextSlave::paintDecoration): removed stray ";" (RenderText::paintObject): call paintDecoration with default parameters for "from" and "to" when not painting the selection only
- khtml/rendering/render_text.h:
WebKit:
Fixed: 3156725 - Partially selected links show extra underlining when dragged
Reviewed by darin.
- WebCoreSupport.subproj/WebTextRenderer.m: (drawLineForCharacters...): don't ignore "from" "to" parameters
- 11:33 PM Changeset in webkit [3459] by
-
- 8 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3126431 -- failed assertion `!attached()' at silkair.net
- khtml/rendering/render_image.h: Fix isImage which for some strange reason was returning false. Not important because no one calls it. Added dispatchLoadEvent and detach member functions.
- khtml/rendering/render_image.cpp: (RenderImage::notifyFinished): Instead of dispatching the load or error event immediately, call dispatchImageLoadEventSoon on the document. (RenderImage::dispatchLoadEvent): Added. Moved the code to do the actual event dispatch in here. (RenderImage::detach): Remove the image from the document in case it has a pending event that was not delivered yet before calling the base class detach.
- khtml/xml/dom_docimpl.h: Add dispatchImageLoadEventSoon, dispatchImageLoadEventsNow, removeImage, and an override of timerEvent. Moved APPLE_CHANGES code to a better place.
- khtml/xml/dom_docimpl.cpp: Moved APPLE_CHANGES code to a better place and made these changes: (DocumentImpl::DocumentImpl): Initialize m_imageLoadEventTimer to 0. (DocumentImpl::detach): Redo the APPLE_CHANGES to make them easier to read. Empty out the m_imageLoadEventDispatchSoonList and the m_imageLoadEventDispatchingList to avoid an O(n2) operation as we detach each image and remove it from the list. (DocumentImpl::dispatchImageLoadEventSoon): Added. Adds image to list and sets up timer. (DocumentImpl::removeImage): Added. Removes image from lists, and cancels timer if needed. (DocumentImpl::dispatchImageLoadEventsNow): Added. Copies list, and call images to dispatch load events. (DocumentImpl::timerEvent): Added. Calls dispatchImageLoadEventsNow.
- khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Dispatch all pending image load events before dispatching the document load.
- force-clean-timestamp: Force rebuild because Project Builder doesn't do header dependencies well enough to deal with changes to the document class.
- 3:53 PM Changeset in webkit [3458] by
-
- 3 edits in trunk/WebCore
Fix :active to behave just like :hover. It was being
restricted and only allowed to match <a> tags, when :active
should be applicable to any element (e.g., like images).
Fixes the :active feedback on numerous blog sites (e.g.,
the photo image buttons on joehewitt.com).
Reviewed by gramps
- khtml/css/cssstyleselector.cpp:
Jan 25, 2003:
- 9:04 PM Changeset in webkit [3457] by
-
- 15 edits in trunk
WebCore:
Reviewed by Maciej.
- fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)
- fixed 2950618 -- JavaScript window.history object name prints blank
- khtml/ecma/kjs_window.cpp: (FrameArray::toString): Added. Returns "[object FrameArray]". (History::getValueProperty): Removed #if APPLE_CHANGES to turn more code on. (History::toString): Added. Returns "[object History]".
- kwq/KWQKPartsBrowserExtension.h: Make browserInterface a pure virtual function instead of always returning 0.
- kwq/KWQKHTMLPartBrowserExtension.h: Added browserInterface() function. Also replaced m_part with a _part that is a KWQKHTMLPart to simplify code.
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): Create the browser interface object when the browser extension object is created. (KHTMLPartBrowserExtension::openURLRequest): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::createNewWindow): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::setIconURL): Use _part instead of KWQ(m_part). (KHTMLPartBrowserExtension::setTypedIconURL): Use _part instead of KWQ(m_part).
- kwq/KWQKPartsBrowserInterface.h: Add a constructor, property() function, and _part data member.
- kwq/KWQKPartsBrowserInterface.mm: (BrowserInterface::property): Added. Handles historyLength property by calling the historyLength method on the bridge. (BrowserInterface::callMethod): Handles goHistory(int) by calling the goBackOrForward: method on the bridge.
- kwq/WebCoreBridge.h: Added historyLength and goBackOrForward: methods.
- kwq/KWQVariant.h: Added Int to the variant enum, added int and uint contructors, and added toInt() member function.
- kwq/KWQVariant.mm: (QVariant::QVariant): Implemented int and uint constructors. (QVariant::toBool): Added Int case, sorted alphabetically. (QVariant::toInt): Added. (QVariant::toUInt): Added Int case, sorted alphabetically. (QVariant::asString): Added Int case, sorted alphabetically.
WebKit:
Reviewed by Maciej.
- fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)
Implemented new bridge functions for use by the history object.
- History.subproj/WebBackForwardList.h: Added backListCount and entryAtIndex:.
- History.subproj/WebBackForwardList.m: (-[WebBackForwardList backListCount]): Added. (-[WebBackForwardList entryAtIndex:]): Added.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge historyLength]): Added. Calls backListCount. (-[WebBridge goBackOrForward:]): Added. Calls entryAtIndex: and then goBackOrForwardToItem:.
- 8:38 PM Changeset in webkit [3456] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- kjs/Makefile.am: Add dependencies so the .lut.h files get rebuilt if the script changes.
- 2:37 PM Changeset in webkit [3455] by
-
- 23 edits1 delete in trunk
WebCore:
Fixed: 3153605 - Drag image when dragging text should be the actual text
Reviewed by darin.
- khtml/rendering/font.cpp: (Font::drawLineForText): take a "from" and "to" so only selected portions of text draw lines
- khtml/rendering/font.h:
- khtml/rendering/render_layer.cpp: (RenderLayer::paint): handle the selection-only case
- khtml/rendering/render_layer.h:
- khtml/rendering/render_root.cpp: (RenderRoot::selectionRect): new, computes bounding box of the selection
- khtml/rendering/render_root.h:
- khtml/rendering/render_text.cpp: (TextSlave::paintDecoration): take a "from" and "to" so only selected portions of text draw lines (RenderText::paintObject): when only drawing the selection, only draw selected text and no selection background (RenderText::paint): handle the selection-only case
- khtml/rendering/render_text.h:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): handle the selection-only case (KWQKHTMLPart::selectionRect): new, returns the bounding box of the selection
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (QPainter::drawLineForText): take a "from" and "to" so only selected portions of text draw lines
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): handle the selection-only case (-[WebCoreBridge selectionRect]): new, returns the bounding box of the selection clipped to visible (-[WebCoreBridge selectionImage]): new, returns the image of the selection
WebKit:
Fixed: 3153605 - Drag image when dragging text should be the actual text
Reviewed by darin.
- Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_dissolveToFraction:]): handle non-flipped images
- Misc.subproj/WebNSViewExtras.h: moved some constants around
- Misc.subproj/WebNSViewExtras.m:
- Resources/text_clipping.tiff: Removed.
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): cleaned-up, get text drag image from WebCore
- 1:57 PM Changeset in webkit [3454] by
-
- 2 edits in trunk/WebKit
- Plugins.subproj/WebBaseNetscapePluginView.m: Replace some tabs with spaces.
Jan 24, 2003:
- 3:46 PM Changeset in webkit [3453] by
-
- 2 edits in trunk/WebKit
Cleaned up some stray comments.
Reviewed by kocienda.
- Misc.subproj/WebUnicode.m: (getShape): (nextChar): (glyphVariantLogical): (shapedString):
- 3:36 PM Changeset in webkit [3452] by
-
- 3 edits in trunk/WebCore
Fix for 3153260, tables used as height spacers don't get the
specified height.
Reviewed by rjw
- khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
- 3:20 PM Changeset in webkit [3451] by
-
- 9 edits in trunk
WebCore:
Chris pointed out a FIXME that led to a more contained way to make sure the cursor
is correct during and after image/text/URL dragging.
Reviewed by Chris.
- kwq/KWQKHTMLPart.h: Back out just-added resetCursor method.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Reset cursor to arrow when image drag starts.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: Back out just-added resetCursor method, which is no longer needed by WebKit.
WebKit:
Chris pointed out a FIXME that led to a more contained way to make sure the cursor
is correct during and after image/text/URL dragging.
Reviewed by Chris.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): No need to reset the cursor at the end of dragging. WC deals with it.
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): No need to set the cursor to arrow, WC deals with it.
- 2:23 PM Changeset in webkit [3450] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3058229 -- two failures in DOM test page for HTMLSelectElement
- fixed 3138938 -- choose another member name on .Mac signup not working as expected
- fixed 3155763 -- Safari autoselects first item in a WOBrowser/<select>
- khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::value): Return "" rather than null when nothing is selected. (HTMLSelectElementImpl::recalcListItems): Don't automatically select a first item in the single selection case.
- 12:48 PM Changeset in webkit [3449] by
-
- 2 edits in trunk/WebCore
Fix for 3146066, messed up lists on dictionary.com. Make
sure that a marker in an anonymous box with no other line box
parent available just stays where it is, rather than removing
itself from the anonymous box (causing that box to be deleted
and recreated ad infinitum).
Reviewed by darin
- khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):
- 12:45 PM Changeset in webkit [3448] by
-
- 3 edits in trunk/WebCore
Fix for 3146066, messed up lists on dictionary.com. Make
sure that a marker in an anonymous box with no other line box
parent available just stays where it is, rather than removing
itself from the anonymous box (causing that box to be deleted
and recreated ad infinitum).
Reviewed by darin
- khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation):
- 12:36 PM Changeset in webkit [3447] by
-
- 8 edits in trunk
WebCore:
Reviewed by Dave.
- fixed 3142852 -- frame content repeatedly requested
The bug was that JavaScript document.referrer was totally wrong.
- khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): Use the new incomingReferrer() rather than referrer(), because referrer() is the referrer to use for new loads in the part, not the one that was used to load the document.
- kwq/KWQKHTMLPart.h: Added incomingReferrer(). Also removed referrer() which has been totally redundant since we made KWQKHTMLPart a subclass of KHTMLPart.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::incomingReferrer): Added. Uses the bridge.
- kwq/WebCoreBridge.h: Added incomingReferrer.
WebKit:
Reviewed by Dave.
- fixed 3142852 -- frame content repeatedly requested
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge incomingReferrer]): Added a way to get the referrer across the bridge, needed for bug fix.
- 11:55 AM Changeset in webkit [3446] by
-
- 2 edits in trunk/WebKit
Netscape plugins were being improperly positioned. I noticed this when I
put the web view into a window with borders around it (Carbon metal window,
but I would imagine Cocoa metal would do it too).
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
- 11:14 AM Changeset in webkit [3445] by
-
- 8 edits in trunk
WebCore:
3155162 - cursor changes to I-beam after dragging image
3154468 - no mouseup event comes through after text snippet drag
Export a means to reset the cursor to WebKit, which is used to fix these bugs.
Reviewed by Darin.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::resetCursor): New method that just calls through to khtmlview's private resetCursor method.
- kwq/WebCoreBridge.h: Add new method.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge resetCursor]): Call view's reset cursor.
WebKit:
3155162 - cursor changes to I-beam after dragging image
3154468 - no mouseup event comes through after text snippet drag
During AK dragging the system takes over the event stream and we never get any mouse
move or up events. It also changes the cursor behind out back. When done
cached state that thinks it knows the current cursor is wrong.
The fix is that after the drag we reset the cursor and synthesize a mouseup event,
which then sets the cursor based on what we're really over.
Reviewed by Darin.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): After the drag, reset the cursor, fake up a mouseup event.
- 10:40 AM Changeset in webkit [3444] by
-
- 3 edits in trunk/WebCore
I ran our KURL tests and found that my previous fix for "localhost" urls, fixed too much.
This now passes all the tests.
Reviewed by Darin.
- kwq/KWQKURL.mm: (KURL::parse): Use different logic for deciding to add authority to the URL and stripping localhost off of file URLs.
- 10:38 AM Changeset in webkit [3443] by
-
- 2 edits in trunk/WebKit
Reviewed by Trey
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView takeFindStringFromSelection:]): Now uses new _web_setFindPasteboardString:withOwner: to share code.
- 9:53 AM Changeset in webkit [3442] by
-
- 4 edits in trunk
WebKit:
Reviewed by Trey
- Misc.subproj/WebNSPasteboardExtras.h:
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_setFindPasteboardString:withOwner:]): New method to put text on the Find pasteboard.
WebBrowser:
- fixed 3147083 -- Text in the "Google" field should be placed in the find pasteboard
- fixed 3148130 -- Safari's Find submenu should use ellipses instead of three dots
- fixed 3149466 -- There's no tooltip for the Home icon
- fixed 3153618 -- Text drags appears to be accepted by the bookmarks bar
Reviewed by Trey
- BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): Use _web_setFindPasteboardString:withOwner: to put search string on find pasteboard
- English.lproj/Browser.nib: added tooltip "Go to the home page."
- English.lproj/MainMenu.nib: replaced all dot dot dots with ellipses
- FavoritesBar.m: (-[FavoritesBar updateDropTarget:]): Bail out right away if there are no bookmarks on the pasteboard. This was being checked only at drop time.
- FindPanelController.m: (-[FindPanelController controlTextDidEndEditing:]): Now uses _web_setFindPasteboardString:withOwner: (which was extracted from the code here).
- 9:46 AM Changeset in webkit [3441] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed null view and hang part of 3153612 -- REGRESSION: null view and hang loading cycleworld.com
- khtml/xml/xml_tokenizer.cpp: (XMLHandler::XMLHandler): Initialize the line number to 0 so we can detect the case where we didn't get a fatal error callback. (XMLTokenizer::finish): Construct an error page without an XML excerpt if the line number if 0.
- 9:23 AM Changeset in webkit [3440] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- fixed 3140945 -- crash viewing www.nextthing.org
- khtml/rendering/render_container.cpp: (RenderContainer::removeLeftoverAnonymousBoxes): Change this function so it will never remove a table cell. Although a table cell that is created automatically is anonymous, it is not an anonymous box in the sense that this function is trying to deal with. Maybe there will be a better way to fix this some day, but this is the best Dave and I could come up with.
- fixed 3155700 -- nil-dereference in khtml::RenderTableRow::detach shortly after visiting www.alltheweb.com
- khtml/rendering/render_table.cpp: (RenderTableRow::detach): Check for nil before calling setNeedCellRecalc in case we are being detached after our parent is already nil.
Jan 23, 2003:
- 8:04 PM Changeset in webkit [3439] by
-
- 3 edits in trunk/WebCore
Fix for 3152494. Set the default iframe width to 300 and
height to 150. This copies the behavior of mozilla and IE.
Reviewed by hyatt.
- khtml/css/html4.css:
- 7:46 PM Changeset in webkit [3438] by
-
- 5 edits in trunk/WebCore
WebCore:
Fixed whitespace exclusion code. Fixes many sites
that have problems that were exposed after
fixing 3119777.
Reviewed by hyatt.
- khtml/rendering/bidi.cpp: (RenderFlow::bidiReorderLine): (RenderFlow::findNextLineBreak):
- khtml/rendering/break_lines.cpp:
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
Test:
Tests for the fix above.
- 7:18 PM Changeset in webkit [3437] by
-
- 4 edits in trunk/WebCore
Dump textslaves in the regression tests.
Reviewed by rjw.
- kwq/KWQRenderTreeDebug.cpp: (operator<<): (write):
- 7:05 PM Changeset in webkit [3436] by
-
- 3 edits in trunk/WebKit
Reviewed by Trey.
- WebView.subproj/WebController.h: Remove unneeded declaration in sample code.
- 4:52 PM Changeset in webkit [3435] by
-
- 7 edits in trunk/WebKit
WebKit:
Made WebTextView use the same format for context menus as the rest of WebKit.
Implemented "Copy" context menu.
Reviewed by john.
- English.lproj/Localizable.strings:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _menuForElement:]): tweak.
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): added "Copy" context menu.
- WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): added asserts
- WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): implemented
WebBrowser:
Implemented context menus "Copy", "Google Search" and "Go To Address" context menus for selected text.
Reviewed by john.
- BrowserWindowController.h:
- BrowserWindowController.m: (-[BrowserWindowController searchForString:]): new, does what chooseSearchString but takes a string (-[BrowserWindowController chooseSearchString:]): call searchForString
- ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): added "Copy", "Google Search" and "Go To Address" (-[ContextMenuHandler search:]): calls searchForString (-[ContextMenuHandler goToAddress:]): does what it says
- English.lproj/Localizable.strings:
- 3:33 PM Changeset in webkit [3434] by
-
- 5 edits in trunk/WebCore
Fix for 3144763, inlines clear too many floats, and jump all the
way to the end of the lowest float instead of only moving as far
down as they have to in order to fit.
Reviewed by darin
- khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
- khtml/rendering/render_flow.cpp: (RenderFlow::nearestFloatBottom):
- khtml/rendering/render_flow.h:
- 2:51 PM Changeset in webkit [3433] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3144560 -- non-reproducible nil-dereference in HTMLFrameElementImpl::updateForNewURL at macfixit
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Add check for nil view.
- 2:38 PM Changeset in webkit [3432] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3154647 -- Triple clicked on a line of text (to select entire line), crashola
- khtml/khtml_part.cpp: (firstSlaveAt): Loop instead of using recursion for siblings. (lastSlaveAt): Ditto, only backwards.
- 1:54 PM Changeset in webkit [3431] by
-
- 2 edits in trunk/WebCore
Fix for 3142124.
When pseudo-elements have display:none, they should not generate
rendering objects.
Reviewed by rjw, kocienda.
- khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
- 1:54 PM Changeset in webkit [3430] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
- WebView.subproj/WebController.m: Add missing static.
- 1:52 PM Changeset in webkit [3429] by
-
- 3 edits in trunk/WebCore
Fix for 3142124.
When pseudo-elements have display:none, they should not generate
rendering objects.
Reviewed by darin.
- khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
- 1:29 PM Changeset in webkit [3428] by
-
- 9 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3129556 -- can't search on japanese string at yahoo.co.jp
The key to fixing this was to look up character sets in a way that does not
pay attention to punctuation. Only alphanumeric characters count. Also did
a little belt tightening and speeding up while I was at it.
- kwq/KWQCharsets.h: Use const char * instead of CFStringRef.
- kwq/KWQCharsets.mm: (buildDictionaries): Store const char * in the dictionaries instead of CFStringRef, and use the key compare and hash functions that obey only alphanumeric characters. (KWQCFStringEncodingFromIANACharsetName): Use const char * directly. (KWQCFStringEncodingFromMIB): Tweak code a bit. (KWQCFStringEncodingToIANACharsetName): Use const char * directly. (KWQCFStringEncodingToMIB): Tweak code a bit. (encodingNamesEqual): Added. Compares two names, ignoring non-alphanumeric characters. (encodingNameHash): Added.
- kwq/KWQKCharsets.h: Take a const char * instead of a QString. Also overload for QCString. This fixes conversion back and forth from QString that was happening before.
- kwq/KWQKCharsets.mm: (KCharsets::codecForName): Update for above parameter change.
- kwq/KWQTextCodec.mm: (codecForCFStringEncoding): Add check for kCFStringEncodingInvalidId. (QTextCodec::codecForMib): Simplify because of above check. (QTextCodec::codecForName): Simplify because we don't need to make a CFStringRef, and because of above check. (QTextCodec::name): No need to convert the CFStringRef back to a const char * now.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge textEncoding]): Convert character set name to a const char * to pass in. (+[WebCoreBridge stringWithData:textEncodingName:]): Ditto.
- kwq/WebCoreEncodings.mm: (+[WebCoreEncodings charsetNameForEncoding:]): Convert character set name to an NSString to use as a return value. (+[WebCoreEncodings encodingForCharsetName:]): Convert character set name to a const char * to pass in.
- 1:25 PM Changeset in webkit [3427] by
-
- 3 edits in trunk/WebCore
Fixed a divide by zero problem.
Reviewed by darin.
- WebCore.pbproj/project.pbxproj:
- khtml/rendering/render_image.cpp: (RenderImage::calcReplacedWidth): (RenderImage::calcReplacedHeight):
- 1:20 PM Changeset in webkit [3426] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
- fixed last minute screwup in my last patch fixing onchange
- kwq/KWQTextField.mm: (-[KWQTextField fieldEditorWillBecomeFirstResponder]): Renamed from fieldWillBecomeFirstResponder. (-[KWQTextField fieldEditorWillResignFirstResponder]): Renamed from fieldWillResignFirstResponder.
- 1:13 PM Changeset in webkit [3425] by
-
- 3 edits in trunk/WebCore
Reviewed by Trey.
- fixed 3151442 - mac.com homepage editing - selection and clicking with mouse don't work
- khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Only allow a false return value to prevent default if this is an html event handler, rather than one set with addEventListener or the like.
- 12:23 PM Changeset in webkit [3424] by
-
- 23 edits in trunk/WebCore
Replaced the paint phase constants with the PaintAction enum. Added PaintActionSelection as a paint action. This will eventually allow us to only paint selected objects. This is needed for the text dragging image.
Reviewed by dave.
- khtml/rendering/render_box.cpp: (RenderBox::paint):
- khtml/rendering/render_box.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::paint): (RenderFlow::paintObject): (RenderFlow::paintFloats):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_html.cpp: (RenderHtml::paint):
- khtml/rendering/render_html.h:
- khtml/rendering/render_image.cpp: (RenderImage::paintObject):
- khtml/rendering/render_image.h:
- khtml/rendering/render_layer.cpp: (RenderLayer::paint):
- khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListItem::paintObject): (RenderListMarker::paint): (RenderListMarker::paintObject):
- khtml/rendering/render_list.h:
- khtml/rendering/render_object.cpp: (RenderObject::paint):
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::paintObject):
- khtml/rendering/render_replaced.h:
- khtml/rendering/render_root.cpp: (RenderRoot::paint): (RenderRoot::paintObject):
- khtml/rendering/render_root.h:
- khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTableSection::paint): (RenderTableCell::paint):
- khtml/rendering/render_table.h:
- khtml/rendering/render_text.cpp: (RenderText::paintObject): (RenderText::paint):
- khtml/rendering/render_text.h:
- 12:03 PM Changeset in webkit [3423] by
-
- 9 edits in trunk/WebKit
WebFoundation:
Reviewed by John.
- Misc.subproj/WebNSFileManagerExtras.h: Change the too broad "FinderInfo" to the accurate "FinderFlags". The property does not contain all the FinderInfo, rather just the flags.
- Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_createFileAtPath:contents:attributes:]): Update for the FinderFlags name change. (-[NSFileManager _web_carbonPathForPath:]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.
- English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
WebKit:
Reviewed by John.
- Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder fileAttributes]):
- Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder fileAttributes]): Use "FinderFlags" instead of "FinderInfo" as appropriate, since these are just the Finder flags, not all the Finder info.
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]):
- Misc.subproj/WebNSWorkspaceExtras.m: (-[NSWorkspace _web_noteFileChangedAtPath:]):
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage load]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.
- WebView.subproj/WebUserAgentSpoofTable.gperf: Improved one of the motivating comments.
- English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
WebBrowser:
Reviewed by John.
- BrowserNSWorkspaceExtras.m: (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): Use fileSystemRepresentation instead of fileSystemRepresentationWithPath: because it's simpler and there's no good reason to use the other one.
- 11:54 AM Changeset in webkit [3422] by
-
- 4 edits in trunk/WebCore
Fix for 3147995, empty <li> tags don't render bullets.
Reviewed by john.
- khtml/rendering/render_list.cpp: (RenderListItem::layout):
- khtml/rendering/render_list.h:
- 11:42 AM Changeset in webkit [3421] by
-
- 4 edits in trunk/WebCore
Fix for 3134613, bullets overlapping text on weather.com. Make
sure min/max widths get updated when the marker moves around.
Reviewed by john
- khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout):
- khtml/rendering/render_list.h:
- 11:38 AM Changeset in webkit [3420] by
-
- 3 edits in trunk
55u versions
- 11:25 AM Changeset in webkit [3419]
-
- 3 copies in tags/Safari-54
This commit was manufactured by cvs2svn to create tag 'Safari-54'.
- 11:25 AM Changeset in webkit [3418] by
-
- 8 edits in trunk
Safari-54 stamp
- 9:33 AM Changeset in webkit [3417] by
-
- 5 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3154575 -- REGRESSION: Right sidebar on Yahoo! page in base PLT renders incorrectly
- khtml/rendering/break_lines.cpp: (isBreakable): Pass kUCTextBreakLineMask to the UC calls, which looks for places where line breaks are allowed, instead of kUCTextBreakWordMask, which finds all word breaks instead. We still pass all the layout tests, so I think this means Japanese word breaking is still OK.
- fixed 3154416 -- images that specify width but not height should keep aspect ratio (example at thegods.org.uk)
- khtml/rendering/render_image.h: Declared new member functions.
- khtml/rendering/render_image.cpp: (RenderImage::widthSpecified): Added helper function. (RenderImage::heightSpecified): Added helper function. (RenderImage::calcReplacedWidth): Added. Derives width from height keeping aspect ratio if we have a specified height and no width. (RenderImage::calcReplacedHeight): Added. Same thing in the opposite direction.
- 1:03 AM Changeset in webkit [3416] by
-
- 3 edits in trunk/WebCore
3153313 cursor changes during text selection when we cross links
Reviewed by Dave.
- khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Remember mouse is down. (KHTMLView::viewportMouseMoveEvent): Use ibeam while mouse down. (KHTMLView::viewportMouseReleaseEvent): Remember that it's up.
Jan 22, 2003:
- 10:55 PM Changeset in webkit [3415] by
-
- 9 edits in trunk/WebKit
Fixed problem where we weren't stopping the Java plug-in. This problem was introduced on Jan. 1 when the ownership of the WebPluginController was moved from WebFrame to WebDataSource. This change moves the WebPluginController to the WebHTMLView. Why this change?
- The state of the plug-ins (currently only the Java plug-in) completely relies on the state of the WebHTMLView, not on the state of the WebDataSource.
- WebHTMLView and WebDataSource are usually coupled via WebView and WebFrame, but not always. In a transitional state, the WebHTMLView may not be up to date with the WebDataSource.
- WebPluginController controls an array of views. It makes more sense for this object to be owned by a view (WebHTMLView) not a model.
Reviewed by darin.
- Plugins.subproj/WebPluginController.h:
- Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithHTMLView:]): renamed, take the HTML view (-[WebPluginController addPlugin:]): use the HTML view (-[WebPluginController HTMLViewWillBeDeallocated]): renamed (-[WebPluginController showURL:inFrame:]): use the HTML view (-[WebPluginController showStatus:]): use the HTML view
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): get the plug-in controller from the HTML view
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): removed calls to plug-in controller
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): create plug-in controller (-[WebHTMLView viewWillMoveToWindow:]): get plug-in controller from self, data source won't be accessible here since we don't have a superview (-[WebHTMLView viewDidMoveToWindow]): get plug-in controller from self (-[WebHTMLView addSubview:]): get plug-in controller from self
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): release plug-in controller (-[WebHTMLView _pluginController]): added
- 7:16 PM Changeset in webkit [3414] by
-
- 10 edits in trunk/WebKit
- fixed 3152427 -- Need unique IDs for bookmarks, for synching's sake
Bookmarks now have a UUID string so that each can maintain its identity
even in the face of multi-machine synching. One known loose end is written
up in 3153832 (unique IDs in bookmarks aren't preserved correctly after copy/paste).
This should be good enough now for the iSynch folks to start implementing
the bookmarks-synching conduit.
I also did some cleanup in this area to share more code and handle
init methods more cleanly, inspired by earlier feedback from Trey and Darin.
Reviewed by Trey and Darin
- Bookmarks.subproj/WebBookmark.h: new _UUID ivar, UUID declaration
- Bookmarks.subproj/WebBookmarkPrivate.h: new _setUUID and _hasUUID declarations
- Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): assert that group is nil here; release _UUID (-[WebBookmark copyWithZone:]): implement the code shared by each subclass; formerly had no implementation. (-[WebBookmark _setUUID:]): private method to set the UUID (-[WebBookmark UUID]): public method to get the UUID; this lazily creates the UUID. (-[WebBookmark _hasUUID]): private method to check whether there's a UUID without creating one by side effect (as calling -[WebBookmark UUID] would) (-[WebBookmark initFromDictionaryRepresentation:withGroup:]): implement the code shared by each subclass; formerly had no implementation. (-[WebBookmark dictionaryRepresentation]): implement the code shared by each subclass; formerly had no implementation.
- Bookmarks.subproj/WebBookmarkGroup.h: new _bookmarksByUUID ivar
- Bookmarks.subproj/WebBookmarkGroupPrivate.h: declarations for new methods _addBookmark: and _removeBookmark:
- Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup init]): new method, just complains that you should have called initWithFile: instead. (-[WebBookmarkGroup initWithFile:]): create _bookmarksByUUID (-[WebBookmarkGroup dealloc]): release _bookmarksByUUID (-[WebBookmarkGroup _addBookmark:]): new method, if bookmark has UUID, adds it to table, and recursively processes children the same way (-[WebBookmarkGroup _removeBookmark:]): new method, if bookmark has UUID, removes it from table, and recursively processes children the same way (-[WebBookmarkGroup _setTopBookmark:]): replace [bookmark setGroup:group] with [group _addBookmark:bookmark] so it runs through the UUID code (-[WebBookmarkGroup _bookmarkChildren:wereRemovedFromParent:]): retitled this from "wereRemovedToParent"
- Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): now calls initWithURLString:title:group with nil parameters so that there's a designated initializer (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): rewritten to do only the subclasses' part now (-[WebBookmarkLeaf dictionaryRepresentation]): rewritten to do only the subclasses' part now (-[WebBookmarkLeaf copyWithZone:]): rewritten to do only the subclasses' part now
- Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList init]): now calls initWithTitle:group with nil parameters so that there's a designated initializer (-[WebBookmarkList initWithTitle:group:]): replace [bookmark setGroup:group] with [group _addBookmark:bookmark] so it runs through the UUID code (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): rewritten to do only the subclasses' part now (-[WebBookmarkList dictionaryRepresentation]): rewritten to do only the subclasses' part now (-[WebBookmarkList copyWithZone:]): rewritten to do only the subclasses' part now (-[WebBookmarkList _setGroup:]): removed this override, which used to do the recursion to set the group of children; this recursion is now done by -[WebBookmarkGroup _addBookmark:] and _removeBookmark: (-[WebBookmarkList removeChild:]): wereRemovedToParent -> wereRemovedFromParent (-[WebBookmarkList insertChild:atIndex:]): replace [bookmark setGroup:group] with [group _addBookmark:bookmark] so it runs through the UUID code
- Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy init]): now calls initWithTitle:group with nil parameters so that there's a designated initializer (-[WebBookmarkProxy initWithTitle:group:]): replace [bookmark setGroup:group] with [group _addBookmark:bookmark] so it runs through the UUID code (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): rewritten to do only the subclasses' part now (-[WebBookmarkProxy dictionaryRepresentation]): rewritten to do only the subclasses' part now (-[WebBookmarkProxy copyWithZone:]): rewritten to do only the subclasses' part now
- 7:00 PM Changeset in webkit [3413] by
-
- 3 edits in trunk/WebCore
Fix first-line regression caused by my removal of a local variable.
Reviewed by mjs
- khtml/css/cssstyleselector.cpp:
- 6:08 PM Changeset in webkit [3412] by
-
- 3 edits in trunk/WebCore
Fix the fix to 3119777 to scan for break over entire string
instead of trying to optimize.
Reviewed by hyatt.
- khtml/rendering/break_lines.cpp: Pass offset into entire string, rather than try to optimize by passing a shorter string.
- 5:46 PM Changeset in webkit [3411] by
-
- 3 edits in trunk/WebCore
Fix the CSS parser so that it disallows class names beginning
with a digit even in quirks mode.
Reviewed by rjw
- khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector2):
- 5:28 PM Changeset in webkit [3410] by
-
- 4 edits in trunk
WebCore
Fix 3119777 (and a host of other international bugs). Word break
was broken. Use unicode services to detect work breaks
for non basic latin1. We may want to go further and
always use unicode services so we get correct hyphenation
breaking.
Reviewed by hyatt.
- khtml/rendering/break_lines.cpp:
WebFoundation
Fix crash in logging code.
Reviewed by hyatt.
- Database.subproj/WebFileDatabase.m: (-[WebFileDatabase lazySync:]):
- 5:15 PM Changeset in webkit [3409] by
-
- 5 edits in trunk/WebCore
Fix word-spacing bugs in text measurement calculations. This
fixes our issues on the CSS1 test suite. Regression tests have
been added for both positive and negative word-spacing.
Reviewed by rjw
- khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):
- khtml/rendering/render_text.h:
- 4:25 PM Changeset in webkit [3408] by
-
- 4 edits in trunk/WebCore
Fixed: 3153969 - Should not be able drag text while double or triple-click selecting it
Fixed: 3154153 - Can drag an empty selection
Reviewed by rjw.
- khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): consider an empty selection like no selection
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): don't allow dragging after selection has started using double or triple click
- 2:34 PM Changeset in webkit [3407] by
-
- 3 edits in trunk/WebCore
Fix absolute positioning problem for bottom-positioned elements.
This is a fix from the KHTML trunk.
Reviewed by john
- khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
- 1:56 PM Changeset in webkit [3406] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3141566 -- non-reproducible nil-dereference in HTMLGenericFormElementImpl at firstdirect.com
- khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Check for the case where the view is 0.
- 1:51 PM Changeset in webkit [3405] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed two-day-old regression where we get nil-dereferences with text areas
- kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Don't do the setWidget: here because widget is always nil at this point. (-[KWQTextArea initWithQTextEdit:]): Do it here instead.
- 1:50 PM Changeset in webkit [3404] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
- fixed 3153673 -- spoof as MacIE to get into http://www.mazdausa.com
- fixed 3153678 -- spoof as MacIE for http://wap.sonyericsson.com/
- WebView.subproj/WebUserAgentSpoofTable.gperf: Add the two new entries. Also reorganize existing entries a bit.
- 1:28 PM Changeset in webkit [3403] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed 3137084 -- Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
- kjs/scope_chain.cpp: (ScopeChain::push): Add assertion. (ScopeChain::release): Fix while loop so that it decrements refCount of the first node in the chain too.
- 12:46 PM Changeset in webkit [3402] by
-
- 5 edits in trunk/WebCore
Fix for 3126927, don't let absolute positioned blocks grow
to accommodate content. They overflow instead.
Reviewed by mjs
- khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_object.h:
- 11:57 AM Changeset in webkit [3401] by
-
- 2 edits in trunk/WebKit
Removed comment that I added by mistake.
Reviewed by me.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
- 11:57 AM Changeset in webkit [3400] by
-
- 2 edits in trunk/WebKit
Fixed: 3153651 - text dragging does not work to Terminal
Reviewed by trey.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Terminal only accepts the drag if one of the operations is generic. Made the operation both generic and copy.
- 11:23 AM Changeset in webkit [3399] by
-
- 3 edits in trunk/WebCore
Fix for 3153316, selection busted on google.com. For now keep
mouse events grabbing the absolutePosition of elements, and don't
ever let them grab the absolutePosition of text nodes.
Reviewed by john.
- khtml/khtml_events.cpp: (khtml::MouseEvent::MouseEvent):
- 10:53 AM Changeset in webkit [3398] by
-
- 5 edits in trunk/WebCore
Renamed isPointSelected to isPointInsideSelection because it's a better name.
Reviewed by darin.
- khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): (KHTMLPart::khtmlMousePressEvent):
- khtml/khtml_part.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
- 10:36 AM Changeset in webkit [3397] by
-
- 1 edit in trunk/WebKit/English.lproj/StringsNotToBeLocalized.txt
* empty log message *
- 10:25 AM Changeset in webkit [3396] by
-
- 23 edits1 add in trunk
WebCore:
Added support for text dragging.
Reviewed by dave.
- khtml/khtml_events.cpp: (khtml::MouseEvent::offset): made checkSelectionPoint take x,y coords, passing the whole event is unnecessary
- khtml/khtml_part.cpp: (KHTMLPart::isPointSelected): new (KHTMLPart::khtmlMousePressEvent): don't restart the selection when click was on the selection (KHTMLPart::khtmlMouseMoveEvent): restart the selection since we may not do it in khtmlMousePressEvent (KHTMLPart::khtmlMouseReleaseEvent): clear the selection if no selection took place
- khtml/khtml_part.h:
- khtml/khtmlpart_p.h:
- khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint): made checkSelectionPoint take x,y coords, passing the whole event is unnecessary
- khtml/rendering/render_object.h:
- khtml/rendering/render_text.cpp: (RenderText::checkSelectionPoint): made checkSelectionPoint take x,y coords, passing the whole event is unnecessary
- khtml/rendering/render_text.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): set booleans indicating that it is OK to drag or select (KWQKHTMLPart::khtmlMouseMoveEvent): ask WebKit if we can drag. Make this decision here instead of in khtmlMousePressEvent because WebKit needs the drag hysteresis to make the decision.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): set the selection bit
WebKit:
Added support for text dragging.
Reviewed by dave.
- Resources/text_clipping.tiff: Added. Temp drag image until we can create an image of the selected text.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge mayStartDragWithMouseDraggedEvent:]): renamed, we now ask if OK to drag during the drag
- WebKit.exp: renamed element key for selected text
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebController.h: renamed element key for selected text
- WebView.subproj/WebController.m: renamed element key for selected text
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): added support for text dragging (-[WebHTMLView _mayStartDragWithMouseDragged:]): renamed, we now ask if OK to drag during the drag
Jan 21, 2003:
- 9:29 PM Changeset in webkit [3395] by
-
- 4 edits in trunk/WebCore
3032718 - I-beam cursor behavior different between web view and text view
Now that the innerNode is the real text element instead of an enclosing
tag element, it's a piece of cake to test for a text node and set the ibeam cursor.
Reviewed by Chris
- khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Set iBeam if over text.
- kwq/KWQKCursor.mm: (KCursor::ibeamCursor): Make this cursor have the Cocoa ibeam instead of arrow.
- 9:04 PM Changeset in webkit [3394] by
-
- 4 edits in trunk/WebCore
Fix selection so that it will go up to the parent node
if the innerNode is text, preserving the old behavior for
now until we can rewrite selection to not require this.
Reviewed by cblu.
- khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
- khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent):
- 9:02 PM Changeset in webkit [3393] by
-
- 3 edits in trunk/WebCore
3121681 - "localhost" part of link is lost with relative links
Was broken for abs links with localhost too. Solution is to tighten up the test
for "localhost" removal to only apply to file urls.
canonical result.
Reviewed by Maciej.
- kwq/KWQKURL.mm: (KURL::parse): Allow the authority processing even for links with localhost. Only cut out the addition of host for locahost file links.
- 7:06 PM Changeset in webkit [3392] by
-
- 2 edits in trunk/WebCore
Fix nodeAtPoint to return text nodes if the mouse is over them.
Make :active fully hierarchical so that e.g., <a><b>Foo</b></a>
gets an outline when clicked.
Reviewed by trey
- khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
- khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
- 6:51 PM Changeset in webkit [3391] by
-
- 4 edits in trunk/WebCore
Fix nodeAtPoint to return text nodes if the mouse is over them.
Make :active fully hierarchical so that e.g., <a><b>Foo</b></a>
gets an outline when clicked.
Reviewed by ???
- khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
- khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
- 5:45 PM Changeset in webkit [3390] by
-
- 4 edits in trunk/WebCore
Fix for regressions on layout-tests caused by new table code.
Make sure cell's padding is used and not just the table's cellpadding.
Also make sure cell padding can be changed dynamically.
Reviewed by darin.
- khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):
- 5:33 PM Changeset in webkit [3389] by
-
- 2 edits in trunk/WebCore
Fix for regressions on layout-tests caused by new table code.
Make sure cell's padding is used and not just the table's cellpadding.
Reviewed by darin.
- khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):
- 5:09 PM Changeset in webkit [3388] by
-
- 5 edits in trunk
Bump versions to 0.8.2/54u. Fix some copyrights to say 2003, not 2001-2003.
- 4:54 PM Changeset in webkit [3387]
-
- 5 copies2 deletes in tags/WebCore-53
This commit was manufactured by cvs2svn to create tag 'WebCore-53'.
- 4:54 PM Changeset in webkit [3386]
-
- 3 copies2 deletes in tags/JavaScriptCore-53
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-53'.
- 4:54 PM Changeset in webkit [3385] by
-
- 3 edits in branches
More README and project fixes.
- 4:51 PM Changeset in webkit [3384] by
-
- 2 edits in branches/JavaScriptCore-53-branch/JavaScriptCore
Updated project and README to prepare for tarballs.
- 4:49 PM Changeset in webkit [3383] by
-
- 1 edit in trunk/JavaScriptCore/README
New README for tarballs.
- 4:48 PM Changeset in webkit [3382] by
-
- 1 edit in trunk/WebCore/README
New README.
- 4:12 PM Changeset in webkit [3381]
-
- 1 copy317 deletes in branches/unlabeled-1.3.50
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.50'.
- 4:12 PM Changeset in webkit [3380]
-
- 1 copy317 deletes in branches/unlabeled-1.2.50
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2.50'.
- 4:12 PM Changeset in webkit [3379]
-
- 1 copy317 deletes in branches/unlabeled-1.16.50
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.16.50'.
- 4:12 PM Changeset in webkit [3378]
-
- 3 copies2 deletes in branches/WebCore-53-branch
This commit was manufactured by cvs2svn to create branch
'WebCore-53-branch'.
- 4:12 PM Changeset in webkit [3377]
-
- 3 copies2 deletes in tags/WEBCORE_53_BRANCH_ANCHOR
This commit was manufactured by cvs2svn to create tag
'WEBCORE_53_BRANCH_ANCHOR'.
- 4:12 PM Changeset in webkit [3376] by
-
- 390 edits in trunk/WebCore
- correct our copyrights to 2003; copyright is based on year of publication, not year worked on
- 4:11 PM Changeset in webkit [3375]
-
- 1 copy2 deletes in branches/JavaScriptCore-53-branch
This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-53-branch'.
- 4:11 PM Changeset in webkit [3374]
-
- 1 copy2 deletes in tags/JAVASCRIPTCORE_53_BRANCH_ANCHOR
This commit was manufactured by cvs2svn to create tag
'JAVASCRIPTCORE_53_BRANCH_ANCHOR'.
- 4:11 PM Changeset in webkit [3373] by
-
- 44 edits in trunk/JavaScriptCore
More copyright fixes.
- 3:54 PM Changeset in webkit [3372] by
-
- 6 edits in trunk/WebCore
Fix for the 2.5% perf regression from the descendant rules
changes. This patch does 3 things:
(1) Fix the descendant rule check in the CSS parser. It
was incorrect.
(2) Fix DOM insertion/removal from setting the parent as needing
a style re-resolve.
(3) Fix whitespace inside <html> so that it doesn't make a premature
<body>.
Reviewed by mjs
- khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector):
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
- khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::removeChild): (NodeBaseImpl::appendChild):
- 3:46 PM Changeset in webkit [3371] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- clean room rewrite of QCString
- kwq/KWQCString.mm: Replaced functions that needed rewrite.
- 2:35 PM Changeset in webkit [3370] by
-
- 11 edits in trunk/WebCore
Added support to pause and resume javascript timers. This allows pages
that have javascript timers to be added to the page cache.
Fixes 3126138.
Reviewed by trey and maciej.
- khtml/ecma/kjs_window.cpp: (Window::pauseTimeouts): (Window::resumeTimeouts): (WindowQObject::pauseTimeouts): (WindowQObject::resumeTimeouts): (WindowQObject::timerEvent):
- khtml/ecma/kjs_window.h:
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::pauseActions): (KWQKHTMLPart::resumeActions): (KWQKHTMLPart::canCachePage): (KWQKHTMLPart::openURLFromPageCache):
- kwq/KWQObject.h:
- kwq/KWQObject.mm: (QObject::pauseTimer): (QObject::_addTimer): (QObject::clearPausedTimers): (QObject::resumeTimers): (QObject::startTimer):
- kwq/KWQPageState.h:
- kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): (-[KWQPageState setPausedActions:int::]): (-[KWQPageState int::]): (-[KWQPageState _cleanupPausedActions]): (-[KWQPageState invalidate]): (-[KWQPageState dealloc]):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge saveDocumentToPageCache]):
- 12:32 PM Changeset in webkit [3369] by
-
- 3 edits in trunk/WebCore
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::createRenderer): Add return statements to fix compile on deployment build.
- 12:19 PM Changeset in webkit [3368] by
-
- 3 edits in trunk/WebCore
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::rendererIsNeeded): (HTMLInputElementImpl::attach): Add return statements to fix compile on deployment build.
- 12:18 PM Changeset in webkit [3367] by
-
- 45 edits in trunk/JavaScriptCore
- correct our copyrights to 2003; copyright is based on year of publication, not year worked on
- 11:54 AM Changeset in webkit [3366] by
-
- 5 edits in trunk/WebCore
Reviewed by Nobody, fixing an accidental commit.
- khtml/khtml_part.cpp:
- khtml/html/html_documentimpl.cpp:
- khtml/xml/dom_docimpl.h:
- 11:43 AM Changeset in webkit [3365] by
-
- 31 edits in trunk/WebCore
Everything else reviewed by Maciej, dtd.cpp and htmlparser.cpp changes reviewed by Dave.
- fixed 3151098 -- REGRESSION: Frequent assert about renderer in DOM code
- khtml/html/dtd.cpp: (DOM::checkChild): Disallow text inside colgroup so it can be handled as a special case inside the parser.
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Discard text inside colgroup and don't pop the colgroup.
- fixed 3149792 -- memory trasher at robinlionheart.com
- fixed 3150664 -- failed assertion in HTMLFrameSetElementImpl::attach on page with frameset inside frameset
The key to fixing the 3149792 memory trasher was to avoid constructing trees where there
is a render object nested inside an object that is not a suitable container. In particular,
the code assumed that RenderFlow objects would only be inside other RenderFlow objects, and
this does not happen if you have an <object> that is an image, with objects inside it that
are intended to be used if the image fails to load.
The key to fixing the 3150664 assertion was to handle the case where a frame set's parent
didn't have a renderer, rather than just asserting about it.
- khtml/rendering/render_flow.cpp: (RenderFlow::layout): Added an assertion and a FIXME from Dave's and my review of this code. (RenderFlow::splitInlines): Add assertions that we have actual RenderFlow objects. Casting non-RenderFlow objects was the cause of the memory trashing. The other parts of this change assure we never hit these assertions by not creating any render objects for DOM objects that are inside non-RenderFlow. (RenderFlow::addChildWithContinuation): Add a similar assertion here.
- khtml/rendering/render_object.h: Declare new member function.
- khtml/rendering/render_object.cpp: (RenderObject::canHaveChildren): Return false.
- khtml/rendering/render_container.h: Declare new member function.
- khtml/rendering/render_container.cpp: (RenderContainer::canHaveChildren): Return true.
- khtml/rendering/render_replaced.h: Declare new member function.
- khtml/rendering/render_replaced.cpp: (RenderReplaced::canHaveChildren): Return false.
- khtml/xml/dom_nodeimpl.h: Declare new member functions.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::createRendererIfNeeded): Added. Checks to see if a renderer should be created, and creates it if so. The bug fix is checking canHaveChildren() here. This also reduces the amount of repeated code in various attach() methods. (NodeImpl::styleForRenderer): Added. Default is parent style. (NodeImpl::rendererIsNeeded): Added. Default is to create only if display is not none. (NodeImpl::createRenderer): Added. Must never reach this function, but I didn't make it a pure virtual because of subclasses like AttrImpl that don't ever call createRendererIfNeeded. Could rethink this and improve it even more.
- khtml/xml/dom_elementimpl.h: Declare new member functions.
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::styleForRenderer): Override to get the style from the style selector rather than from the parent renderer. (ElementImpl::createRenderer): Call RenderObject::createObject to create the right type of renderer. (ElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/html/html_baseimpl.h: Declare new member functions.
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::createRenderer): Create a RenderBody. (HTMLBodyElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLFrameElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLFrameElementImpl::createRenderer): Create a RenderFrame. (HTMLFrameElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLFrameSetElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLFrameSetElementImpl::createRenderer): Create a RenderFrameSet. (HTMLFrameSetElementImpl::attach): Call createRendererIfNeeded to do most of the work. This fixes a bug where the parent doesn't have a renderer; we were asserting in that case rather than just not creating a renderer ourselves, which was wrong. (HTMLHtmlElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLHtmlElementImpl::createRenderer): Create a RenderHtml. (HTMLHtmlElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLIFrameElementImpl::createRenderer): Create a RenderPartObject. (HTMLIFrameElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/html/html_formimpl.h: Declare new member functions.
- khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Remove now-unneeded code that is handled by createRendererIfNeeded now. (HTMLInputElementImpl::rendererIsNeeded): Return false for HIDDEN, otherwise call base. (HTMLInputElementImpl::createRenderer): Create the appropriate type of RenderObject. (HTMLInputElementImpl::attach): Call createRendererIfNeeded to do most of the work. Determined that we don't need the special case for image buttons any more. (HTMLSelectElementImpl::createRenderer): Create a RenderSelect. (HTMLSelectElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLTextAreaElementImpl::createRenderer): Create a RenderTextArea. (HTMLTextAreaElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/html/html_imageimpl.h: Declare new member function.
- khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::createRenderer): Create a RenderImage. (HTMLImageElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/html/html_inlineimpl.h: Declare new member function.
- khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::createRenderer): Create a RenderBR. (HTMLBRElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/html/html_objectimpl.h: Declare new member functions.
- khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLAppletElementImpl::createRenderer): Create either a RenderApplet or RenderEmptyApplet. (HTMLAppletElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLEmbedElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLEmbedElementImpl::createRenderer): Create a RenderPartObject. (HTMLEmbedElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLObjectElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLObjectElementImpl::createRenderer): Create either a RenderImage or a RenderPartObject. (HTMLObjectElementImpl::attach): Call createRendererIfNeeded to do most of the work.
- khtml/xml/dom_textimpl.h: Declare new member functions.
- khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded): Moved logic about not making renderers for only-whitespace elements here. Left out the special case for textarea, since the fact that RenderReplaced returns false from the canHaveChildren function now takes care of that of that case. (TextImpl::createRenderer): Create a RenderText. (TextImpl::attach): Call createRendererIfNeeded to do most of the work.
- fixed a buffer overrun that libgmalloc detected
- khtml/misc/decoder.cpp: (KanjiCode::judge): Pass in a size parameter instead of using strlen. (Decoder::decode): Pass in a size parameter.
- a little housekeeping
- WebCore.pbproj/project.pbxproj: Remove a bunch of the .moc files from the project. I'm not sure why I put them in originally, but they do no good in there.
- khtml/khtmlview.moc: Empty out this file.
- 11:18 AM Changeset in webkit [3364] by
-
- 3 edits in trunk/WebCore
Reviewed by Trey.
- fixed 3145317 - Unable to add or remove menu items on Site Menu page using Safari Beta
This turned out to be a problem with event.layerX / event.layerY.
- khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::computeLayerPos): Since layer position is relative to parent layer, go up the layer tree adjusting for layer offset to compute true layer position.
- 10:28 AM Changeset in webkit [3363] by
-
- 6 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3151982 - missing content at debka.com after iframe is written using document.write
- fixed 3000234 - javascript problem writing iframe at cycleworld.com
- khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): If we come out of the script with the parser in skip mode, don't throw away the whole rest of the document - instead, parse it as usual. The parser's skip mode will take care of skipping stuff as needed and will detect close tags for special tags like <iframe>.
Jan 20, 2003:
- 6:35 PM Changeset in webkit [3362] by
-
- 4 edits in trunk/WebCore
Fix :hover performance regression on wsj.com. Moving my
<a name="foo"> quirk down into the :hover rule matching code,
so that we'll know never to apply :hover to anchorless <a>s.
Reviewed by gramps
- khtml/css/cssstyleselector.cpp:
- khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
- 6:33 PM Changeset in webkit [3361] by
-
- 13 edits1 add in trunk
WebCore:
Reviewed by Trey.
- fixed 3132120 - onchange handler not firing on mac.com webmail
- khtml/rendering/render_form.h:
- khtml/rendering/render_replaced.cpp: (RenderWidget::handleFocusOut): Moved empty virtual method here from render_form. (RenderWidget::eventFilter): Uncomment call to handleFocusOut - we need it to send onChange properly.
- khtml/rendering/render_replaced.h:
- kwq/KWQObject.h: Add empty eventFilter virtual method.
- kwq/KWQComboBox.h: Remove no longer needed empty eventFilter.
- kwq/KWQEvent.h: Implement a bit more of QFocusEvent.
- kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Tell the text view its widget. (-[KWQTextAreaTextView setWidget:]): New method to set widget. (-[KWQTextAreaTextView becomeFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus in event. (-[KWQTextAreaTextView resignFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus out event.
- kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Cleaned up a bit. (-[KWQTextField fieldWillBecomeFirstResponder]): Call the widget's event filter with a focus in event. (-[KWQTextField fieldWillResignFirstResponder]): Call the widget's event filter with a focus out event.
- kwq/KWQView.mm:
WebKit:
Reviewed by Trey.
- fixed 3132120 - onchange handler not firing on mac.com webmail
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView resignFirstResponder]): If we really resign first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method. (-[WebNSTextView becomeFirstResponder]): If we really become first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method.
- 5:35 PM Changeset in webkit [3360] by
-
- 3 edits in trunk/WebCore
Fix for 3147213. <nobr> is treated like other inlines now,
so it can contain blocks. <wbr> is also fixed. This fixes
tvguide.com.
Reviewed by john
- khtml/html/dtd.cpp: (DOM::checkChild):
- 4:29 PM Changeset in webkit [3359] by
-
- 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m
Reviewed by Hyatt
Moved up to HTTP/1.1 in the simple loader, including chunked transer encoding and
persistent connections. While I was in the neighborhood, I cleaned up a lot of
code and improved some names.
- Database.subproj/WebFileDatabase.m: Changed sync idle timeout from 3 seconds to 10 seconds. In the "real world" I think that this is a better choice since with even DSL speeds, pages often take longer than 3 seconds to load.
- Misc.subproj/WebNSStringExtras.h:
- Misc.subproj/WebNSStringExtras.m: (-[NSString _web_timeoutFromKeepAliveHeader]): Added this helper.
- ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Added WebHTTPTransferEncoding enum and transferEncodingFlags ivar to the class.
- ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler populateResponseWithProtocolMetadata:]): Do a "sanity" check on the value of transferEncodingFlags. If the encoding is not "identity" discard content length header value. (-[WebHTTPProtocolHandler determineTransferEncoding]): Added.
- ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.h: Quite a bit of rearranging and additions in order to handle new functionality. Moved the whole method interface into the .m file. None of that was public in any way.
- ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebHTTPPersistentConnection initWithFD:expiry:]): Added. (-[WebHTTPPersistentConnection isExpired]): Added. (WebSimpleHTTPProtocolHandlerInit): Some name changes and additions in order to handle new functionality. (_persistentConnectionSweeper): Added. (_signalledHandlersCallback): Name change. (_socketWriteCallback): Name change. (_socketReadCallback): Name change. (-[WebSimpleHTTPProtocolHandler initWithResourceLoad:]): Create the HTTP request string here. (-[WebSimpleHTTPProtocolHandler beginLoadInBackgroundWithConditions:]): Now checks to see if a persistent connection is available for the destination host/port. (-[WebSimpleHTTPProtocolHandler endLoad]): Name change to call _finishedWithFileDescriptor. (-[WebSimpleHTTPProtocolHandler cleanUpForRetry]): Rearranged in order to be more legible. Some additions to handle new functionality. (-[WebSimpleHTTPProtocolHandler dealloc]): Adjusted for name changes. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Now uses HTTP/1.1 and Connection: keep-alive. This is what the change is all about. :-) (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): (-[WebSimpleHTTPProtocolHandler _processHTTPResultCode]): Name change. (-[WebSimpleHTTPProtocolHandler _performSocketRead]): Name change. (-[WebSimpleHTTPProtocolHandler _finishedWithFileDescriptor]): Name change. Now handles keeping connections alive if they are eligible. (isToken): Added to deal with chunked transfer encoding. (skipLWS): Ditto. (skipToken): Ditto. (skipQuotedString): Ditto. (parseChunkedHeader): Ditto. (-[WebSimpleHTTPProtocolHandler _processResponseData]): Now handles chunked transfer encoding. (-[WebSimpleHTTPProtocolHandler _handleLoadCallback]): Now does more checks to see if a load has finished. Additional logic needed here since we do not get a "hard close" when a load is done since we are trying to keep the socket open.
- 4:09 PM Changeset in webkit [3358] by
-
- 3 edits in trunk/WebKit
Nit fix to remove a dead "cursor" ivar found while grepping.
Reviewed by Richard.
- WebView.subproj/WebDynamicScrollBarsView.h:
- WebView.subproj/WebDynamicScrollBarsView.m:
- 4:00 PM Changeset in webkit [3357] by
-
- 4 edits in trunk/WebCore
Gah. Fix positioned objects and floating objects so that they
don't append themselves to the list of runs in normal flow.
An astoundingly basic bug. :(
Reviewed by john
- khtml/rendering/bidi.cpp: (appendRunsForObject):
- khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):
- 1:59 PM Changeset in webkit [3356] by
-
- 23 edits in trunk/WebCore
Fixes for 3150561 (blog articles vanish on stylesheet switch) and
and 3150560 (crash changing fixed positioned element to normal
positioning dynamically).
This change makes layers able to deal with dynamic changes in
position that cause you to have to either remove a layer from
the hierarchy while preserving the children or to insert a
layer into the hierarchy in between a parent and its descendants.
This patch also rewrites :hover/:active so that they can actually
be used in selectors other than the rightmost selector (e.g., so you
can write a rule like "li:hover > a").
Also, layers will now properly clear out their hover/active state
when the mouse is no longer inside them.
With these fixes, Eric Meyer's "Pure CSS Menus" work (perfectly)
and the repainting problems on sites like brainjar.com and
diveintomark.org and wired.com are fixed.
Reviewed by mjs and john.
- khtml/css/css_stylesheetimpl.h:
- khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector):
- khtml/css/cssparser.h:
- khtml/css/cssstyleselector.cpp:
- khtml/css/cssstyleselector.h:
- khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- khtml/rendering/render_box.h:
- khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
- khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_layer.cpp: (RenderLayer::addChild): (RenderLayer::removeOnlyThisLayer): (RenderLayer::insertOnlyThisLayer): (RenderLayer::clearOtherLayersHoverActiveState): (RenderLayer::clearHoverAndActiveState): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
- khtml/rendering/render_layer.h:
- khtml/rendering/render_object.cpp: (RenderObject::addLayers): (RenderObject::moveLayers): (RenderObject::findNextLayer): (RenderObject::setStyle): (RenderObject::setHoverAndActive):
- khtml/rendering/render_object.h:
- khtml/rendering/render_style.cpp: (RenderStyle::diff):
- khtml/rendering/render_style.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
- khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::setActive):
Jan 18, 2003:
- 7:08 PM Changeset in webkit [3355] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3149511 - Blogger.com window closes after update is posted
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For now, don't allow closing the window at all if it wasn't opened by JavaScript, since we don't support the history object and so can't tell if the window has only one history item.
- 3:11 PM Changeset in webkit [3354] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed 3123041 - VIP: Spewage at bottom of oregonlive.com and other similar pages
- WebView.subproj/WebUserAgentSpoofTable.gperf: Added nj.com to spoof list below oregonlive.com (which was already in there). Added comment explaining the need to spoof a bit more.
- WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry): Regenerated.
Jan 17, 2003:
- 3:08 PM Changeset in webkit [3353] by
-
- 7 edits in trunk/WebCore
Reviewed by Dave.
- fixed the crashing so the layout tests work
- khtml/rendering/render_layer.h: Add a node pointer result.
- khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Return the node pointer so we can destroy it when done with it.
- khtml/rendering/render_object.h: Make renderArena() const.
- khtml/rendering/render_object.cpp: (RenderObject::renderArena): Make it const.
- kwq/KWQRenderTreeDebug.cpp: (writeLayers): Free the Z layer list when done. Without this things just crashed.
- 2:46 PM Changeset in webkit [3352] by
-
- 3 edits in trunk/WebCore
Fixed 3126141. Allow pages with plugins to be cached. This is safe
because plugins are cleanly started/stopped when their containing views are
added/removed from the view hierarchy.
Reviewed by trey.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):
- 2:42 PM Changeset in webkit [3351] by
-
- 35 edits3 adds in trunk/WebCore
The new table code from Lars. Also includes bug fixes for
percentage height children in table cells, for positioning
of tables, and for width distribution of percentage width
cells.
Reviewed by darin
- ForwardingHeaders/rendering/table_layout.h: Added.
- WebCore.pbproj/project.pbxproj:
- khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
- khtml/css/cssstyleselector.cpp:
- khtml/css/cssvalues.c: (findValue):
- khtml/css/cssvalues.h:
- khtml/css/cssvalues.in:
- khtml/css/html4.css:
- khtml/dom/html_table.cpp: (HTMLTableElement::insertRow): (HTMLTableElement::deleteRow): (HTMLTableRowElement::insertCell): (HTMLTableRowElement::deleteCell): (HTMLTableSectionElement::insertRow): (HTMLTableSectionElement::deleteRow):
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::setTFoot): (HTMLTableElementImpl::setTBody): (HTMLTableElementImpl::createTHead): (HTMLTableElementImpl::createTFoot): (HTMLTableElementImpl::insertRow): (HTMLTableElementImpl::deleteRow): (HTMLTableElementImpl::addChild): (HTMLTableElementImpl::parseAttribute): (HTMLTableElementImpl::attach): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableSectionElementImpl::HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::~HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::insertRow): (HTMLTableSectionElementImpl::deleteRow): (HTMLTableSectionElementImpl::numRows): (HTMLTableRowElementImpl::rowIndex): (HTMLTableRowElementImpl::insertCell): (HTMLTableRowElementImpl::deleteCell): (HTMLTableCellElementImpl::HTMLTableCellElementImpl): (HTMLTableCellElementImpl::parseAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableColElementImpl::HTMLTableColElementImpl): (HTMLTableColElementImpl::parseAttribute):
- khtml/html/html_tableimpl.h:
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): (KHTMLParser::getElement):
- khtml/rendering/bidi.cpp: (RenderFlow::layoutInlineChildren):
- khtml/rendering/render_body.cpp: (RenderBody::availableHeight):
- khtml/rendering/render_body.h:
- khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight): (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedHeight): (RenderBox::availableHeight): (RenderBox::calcAbsoluteVertical):
- khtml/rendering/render_box.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::leftOffset): (RenderFlow::rightOffset): (RenderFlow::addOverHangingFloats): (RenderFlow::calcBlockMinMaxWidth): (RenderFlow::calcMinMaxWidth):
- khtml/rendering/render_form.cpp:
- khtml/rendering/render_form.h:
- khtml/rendering/render_frames.cpp:
- khtml/rendering/render_frames.h:
- khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight):
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
- khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::layout): (RenderRoot::paintObject):
- khtml/rendering/render_root.h:
- khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
- khtml/rendering/render_style.h:
- khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::~RenderTable): (RenderTable::setStyle): (RenderTable::position): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::layout): (RenderTable::setCellWidths): (RenderTable::paint): (RenderTable::calcMinMaxWidth): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::colElement): (RenderTable::recalcSections): (RenderTable::removeChildNode): (RenderTable::dump): (RenderTableSection::RenderTableSection): (RenderTableSection::~RenderTableSection): (RenderTableSection::detach): (RenderTableSection::setStyle): (RenderTableSection::addChild): (RenderTableSection::ensureRows): (RenderTableSection::addCell): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableSection::recalcCells): (RenderTableSection::clearGrid): (RenderTableSection::removeChildNode): (RenderTableSection::dump): (RenderTableRow::RenderTableRow): (RenderTableRow::detach): (RenderTableRow::setStyle): (RenderTableRow::addChild): (RenderTableRow::removeChildNode): (RenderTableRow::dump): (RenderTableRow::layout): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::updateFromElement): (RenderTableCell::getCellPercentageHeight): (RenderTableCell::setCellPercentageHeight): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::baselinePosition): (RenderTableCell::setStyle): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations): (RenderTableCell::dump): (RenderTableCol::RenderTableCol): (RenderTableCol::updateFromElement): (RenderTableCol::addChild): (RenderTableCol::dump):
- khtml/rendering/render_table.h:
- khtml/rendering/table_layout.cpp: Added. (FixedTableLayout::FixedTableLayout): (FixedTableLayout::~FixedTableLayout): (FixedTableLayout::calcWidthArray): (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::AutoTableLayout): (AutoTableLayout::~AutoTableLayout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::insertSpanCell): (AutoTableLayout::layout): (AutoTableLayout::calcPercentages):
- khtml/rendering/table_layout.h: Added.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::dump):
- khtml/xml/dom_nodeimpl.h:
- 2:38 PM Changeset in webkit [3350] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave.
- clean room rewrite of QCString::operator<<.
- kwq/KWQCString.mm: (operator<<): Rewrote it.
- update format of render tree dumping for real use
- khtml/rendering/render_layer.h: Added elementList().
- khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Added.
- kwq/KWQRenderTreeDebug.cpp: (operator<<): Added an overload for writing out QRect. (writeIndent): Added. (write): Use the overload for QRect, also reorganize to dump layers. (writeLayers): Use this to dump the layers. (externalRepresentation): Call writeLayers instead of write.
- 11:24 AM Changeset in webkit [3349] by
-
- 3 edits in trunk/WebKit
WebFoundation:
Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window
Removed all unnecessary content sniffing as that work is already done in WebResourceLoad.
Reviewed by darin.
- CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _sendResponseMetadataCallbackCheckingPreconditions:]): only sniff here, call _web_guessedMIMEType
- Misc.subproj/WebMultipartForm.m: include WebNSDataExtras
- Misc.subproj/WebNSDataExtras.h: Added.
- Misc.subproj/WebNSDataExtras.m: Added. (-[NSMutableData _web_appendFormat:]): (-[NSMutableData _web_appendEncodedString:format:arguments:]): (-[NSMutableData _web_appendEncodedString:format:]): (-[NSData _web_guessedMIMEType]): was _guessMIMEType in WebResourceLoad
- Misc.subproj/WebNSMutableDataExtras.h: Removed.
- Misc.subproj/WebNSMutableDataExtras.m: Removed.
- Misc.subproj/WebNSStringExtras.h: removed 2 unneeded methods
- Misc.subproj/WebNSStringExtras.m:
- ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler didLoadData:]): get the MIME type from the extension, don't sniff
- ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): don't sniff
- WebFoundation.pbproj/project.pbxproj:
WebKit:
Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window
Reviewed by darin.
- WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): rewrote, now calls _web_guessedMIMEType
- 9:04 AM Changeset in webkit [3348] by
-
- 4 edits2 deletes in trunk/WebCore
Reviewed by Ken.
- removed unused KWQDrawUtil code
- ForwardingHeaders/qdrawutil.h: Emptied this file out.
- kwq/KWQDrawUtil.h: Removed.
- kwq/KWQDrawUtil.mm: Removed.
- WebCore.pbproj/project.pbxproj: Removed KWQDrawUtil.
- 8:53 AM Changeset in webkit [3347] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by John.
- updated copyright to include expat copyrights
- WebCore.pbproj/project.pbxproj: Added expat copyrights on the end. Got text of copyrights from Acknowledgments.rtf in WebBrowser.
WebBrowser:
Reviewed by John.
- updated acknowledgments to latest text from legal that mentions expat
- Help/English.lproj/Acknowledgments.rtf: New drop from legal.
- 8:07 AM Changeset in webkit [3346] by
-
- 3 edits in trunk/WebKit
WebKit:
- compressed all our non-compressed TIFF files
- Resources/nullplugin.tiff:
- Resources/url_icon.tiff:
WebBrowser:
- compressed all our non-compressed TIFF files
- Preferences.subproj/AppearancePreferences.tiff:
- Preferences.subproj/BookmarkPreferences.tiff:
- Preferences.subproj/GeneralPreferences.tiff:
- Preferences.subproj/SecurityPreferences.tiff:
- Resources/Images/Activity_Stop.tif:
- Resources/Images/AddLink.tif:
- Resources/Images/AddLinkDisabled.tif:
- Resources/Images/AddLinkPressed.tif:
- Resources/Images/AddressBook.tiff:
- Resources/Images/Back.tif:
- Resources/Images/BackDisabled.tif:
- Resources/Images/BackPressed.tif:
- Resources/Images/BookmarksButton.tif:
- Resources/Images/BookmarksButton_Pressed.tif:
- Resources/Images/BookmarksButton_Rollover.tif:
- Resources/Images/BookmarksButton_Selected.tif:
- Resources/Images/BookmarksButton_Selected_Pressed.tif:
- Resources/Images/BookmarksDragBadge1-2.tif:
- Resources/Images/BookmarksDragBadge3.tif:
- Resources/Images/BookmarksDragBadge4.tif:
- Resources/Images/BookmarksDragBadge5.tif:
- Resources/Images/BookmarksDragImage.tif:
- Resources/Images/Bug_Report.tif:
- Resources/Images/Bug_Report_Pressed.tif:
- Resources/Images/DarkMetalSwatch.tif:
- Resources/Images/Download_Clear.tif:
- Resources/Images/Download_ClearDisabled.tif:
- Resources/Images/Download_ClearPressed.tif:
- Resources/Images/Download_Reload.tif:
- Resources/Images/Download_ReloadPressed.tif:
- Resources/Images/Download_Reveal.tif:
- Resources/Images/Download_RevealPressed.tif:
- Resources/Images/Download_Stop.tif:
- Resources/Images/Download_StopPressed.tif:
- Resources/Images/FavoriteDrag_Caps.tif:
- Resources/Images/FavoriteDrag_Middle.tif:
- Resources/Images/FavoritePressed_Caps.tif:
- Resources/Images/FavoritePressed_Middle.tif:
- Resources/Images/FavoriteRollover_Caps.tif:
- Resources/Images/FavoriteRollover_Middle.tif:
- Resources/Images/FavoritesBar.tif:
- Resources/Images/FavoritesBarClipIndicator.tiff:
- Resources/Images/FavoritesBarClipIndicatorPressed.tiff:
- Resources/Images/FavoritesFolderArrow.tif:
- Resources/Images/FavoritesFolderArrowWhite.tif:
- Resources/Images/FontBigger.tif:
- Resources/Images/FontBiggerDisabled.tif:
- Resources/Images/FontBiggerPressed.tif:
- Resources/Images/FontSmaller.tif:
- Resources/Images/FontSmallerDisabled.tif:
- Resources/Images/FontSmallerPressed.tif:
- Resources/Images/Forward.tif:
- Resources/Images/ForwardDisabled.tif:
- Resources/Images/ForwardPressed.tif:
- Resources/Images/History.tif:
- Resources/Images/Home.tif:
- Resources/Images/HomeDisabled.tif:
- Resources/Images/HomePressed.tif:
- Resources/Images/LibrarySelection.tif:
- Resources/Images/LibrarySelectionGray.tif:
- Resources/Images/Location_Left.tif:
- Resources/Images/Location_Left_Progress.tif:
- Resources/Images/Location_Middle.tif:
- Resources/Images/Location_Middle_Progress.tif:
- Resources/Images/Location_Right_Progress.tif:
- Resources/Images/Lock.tif:
- Resources/Images/NewFolder.tif:
- Resources/Images/NewFolder_Disabled.tif:
- Resources/Images/NewFolder_Pressed.tif:
- Resources/Images/Reload.tif:
- Resources/Images/ReloadDisabled.tif:
- Resources/Images/ReloadPressed.tif:
- Resources/Images/Search_Left.tif:
- Resources/Images/Search_Left_Progress.tif:
- Resources/Images/Search_Middle.tif:
- Resources/Images/Search_Middle_Progress.tif:
- Resources/Images/Search_Right.tif:
- Resources/Images/Search_Right_Progress.tif:
- Resources/Images/Search_SnapBack.tif:
- Resources/Images/Search_SnapBackPressed.tif:
- Resources/Images/Stop.tif:
- Resources/Images/StopDisabled.tif:
- Resources/Images/StopPressed.tif:
- Resources/Images/folder16.tiff:
- Resources/Images/rendezvous.tiff:
- Resources/Images/tiny_menu.tiff:
- 12:47 AM Changeset in webkit [3345] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3148141 - crash in KJS::WindowFunc::tryCall leaving certain site
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setView): If setting the view to nil and we have a document, detach the document. This means that we are removing a frame from the tree, so we want to run it's onUnload handler now, rather than later when things are no longer fully hooked up.
Jan 16, 2003:
- 6:25 PM Changeset in webkit [3344] by
-
- 4 edits in trunk/WebCore
Fixed 3148932. Account for zero width characters
in <pre> fixed-width optimization.
Reviewed by hyatt.
- khtml/rendering/render_text.cpp: (RenderText::widthFromCache):
Reviewed by Richard (written by Mike S.) 'Clean' implementations of these
functions that were too similar to the Qt implementations.
- kwq/KWQString.mm: (QString::left): (QString::right): (QString::mid):
- 5:43 PM Changeset in webkit [3343] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
- fixed 3144771 - Crash in KJS::WindowFunc::tryCall leaving www.smogcheck.org
I fixed this by making sure we couldn't send the unload event twice, which was
happening before in certain circumstances.
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): When emitting load event, note that unload event has not yet been sent. (KHTMLPart::checkEmitLoadEvent): Note when unload event has been sent to avoid sending it twice.
- khtml/khtmlpart_p.h:
- 5:18 PM Changeset in webkit [3342] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
- made minor tweaks to work better with Mozilla's JavaScript tests.
- kjs/testkjs.cpp: (VersionFunctionImp::call): Implemented (main): Ignore files named -f (hack to match -f <filename syntax that moz JavaScript tests expect). Also use return code 3 instead of 1 for uncaught exception.
- 5:17 PM Changeset in webkit [3341] by
-
- 3 edits in branches/Alexander-48-branch/JavaScriptCore
Reviewed by no one - just backing out an accidental commit to the wrong branch.
- kjs/testkjs.cpp: (main):
- 5:02 PM Changeset in webkit [3340] by
-
- 4 edits in branches/Alexander-48-branch/WebCore
Reviewed by no one, I'm just rolling out an accidentally committed change.
- removed the change below which I accidentally committed on the branch.
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): (KHTMLPart::checkEmitLoadEvent):
- khtml/khtmlpart_p.h:
- 4:24 PM Changeset in webkit [3339] by
-
- 3 edits in trunk/JavaScriptCore
- kjs/number_object.cpp: (NumberObjectImp::construct): Fix build, remove stray space.
- 4:17 PM Changeset in webkit [3338] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- rolled in a change from the KJS folks
- kjs/number_object.h: Use ObjectImp *, not Object, for the proto.
- kjs/number_object.cpp: (NumberInstanceImp::NumberInstanceImp): Use ObjectImp *, not Object, for the proto. (NumberPrototypeImp::NumberPrototypeImp): Pass ObjectImp. (NumberObjectImp::construct): Use ObjectImp.
- 3:36 PM Changeset in webkit [3337] by
-
- 5 edits in trunk
Removed the Safari-49 markers to reduce confusion since
49 was never used and includes changes that were not in 51.
- 3:08 PM Changeset in webkit [3336] by
-
- 3 edits in trunk/WebKit
- WebView.subproj/WebController.h: Fixed a comment that was out of date.
- 1:11 PM Changeset in webkit [3335] by
-
- 2 edits in trunk/WebKit
Fixed comment.
Reviewed by NOBODY (OOPS!).
- Plugins.subproj/WebBaseNetscapePluginView.m:
- 1:10 PM Changeset in webkit [3334] by
-
- 2 edits in trunk/WebKit
Fixed: 3125743 - right-click doesn't count as ctrl-click in Flash
AppKit doesn't call mouseDown or mouseUp on right-click. Simulate control-click mouseDown and mouseUp so plug-ins get the right-click event as they do in Carbon
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
- 12:45 PM Changeset in webkit [3333] by
-
- 15 edits2 adds4 deletes in trunk
WebCore:
Reviewed by John.
- added an API for dumping the external representation of the render tree for testing
- kwq/KWQRenderTreeDebug.h: Added.
- kwq/KWQRenderTreeDebug.cpp: Added.
- kwq/KWQTextStream.h: Added more overloads for operator<<.
- kwq/KWQTextStream.mm: (QTextStream::operator<<): Implemented them.
- kwq/WebCoreBridge.h: Added renderTreeAsExternalRepresentation.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge renderTreeAsExternalRepresentation]): Added.
- removed remnants of an earlier more-naive cut at this same sort of thing
- removed ForwardingHeaders from the project since that doesn't really help Project Builder
- kwq/WebCoreTestController.h: Removed.
- kwq/WebCoreTestController.m: Removed.
- WebCore.exp: Removed WebCoreTestController.
- WebCore-combined.exp: Re-generated.
- WebCore.pbproj/project.pbxproj: Removed WebCoreTestController and ForwardingHeaders.
WebKit:
Reviewed by John.
- added an API for dumping the external representation of the render tree for testing
- Misc.subproj/WebCoreStatistics.h: Added renderTreeAsExternalRepresentation.
- Misc.subproj/WebCoreStatistics.m: (-[WebFrame renderTreeAsExternalRepresentation]): Added.
- removed remnants of an earlier more-naive cut at this same sort of thing
- Misc.subproj/WebTestController.h: Removed.
- Misc.subproj/WebTestController.m: Removed.
- WebKit.exp: Removed WebTestController.
- WebKit.pbproj/project.pbxproj: Removed WebTestController.
- other changes
- WebCoreSupport.subproj/WebBridge.m: Had added new copyright date to touch a file. That's not needed any more, but the date should be updated anyway.
- 10:51 AM Changeset in webkit [3332] by
-
- 3 edits in trunk
Safari-53u; tree is open
- 10:47 AM Changeset in webkit [3331]
-
- 3 copies in tags/Safari-52
This commit was manufactured by cvs2svn to create tag 'Safari-52'.
- 10:47 AM Changeset in webkit [3330] by
-
- 8 edits in trunk
Safari-52 stamp
Jan 15, 2003:
- 3:33 PM Changeset in webkit [3329] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- fixed 3143418 - controller assert in WebStandardPanels _didStartLoadingURL
- fixed 3141212 - crash in kjs garbage collection (contextimp mark)
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]): If the data source doesn't have a controller, then block the load.
- 10:59 AM Changeset in webkit [3328] by
-
- 8 edits in trunk/WebCore
3144458 - user's credentials are present in a form that is revisited via b/f or history
We now never save/restore password fields. Also if the page has a form with a password
field that would be submitted securely, we do not save anything on that page.
Reviewed by Darin.
- force-clean-timestamp: PB isn't smart enough to know what to rebuild.
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formWouldHaveSecureSubmission): Utility function. (HTMLFormElementImpl::attach): Tell doc if we've added a secure form. (HTMLFormElementImpl::parseAttribute): Tell doc if form became secure. (HTMLInputElementImpl::state): Assert that we never save password fields. (HTMLInputElementImpl::restoreState): Assert that we never restore password fields. (HTMLInputElementImpl::attach): Tell doc if we've added a password field.
- khtml/html/html_formimpl.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Init count of secure forms, password fields. (DocumentImpl::passwordFieldAdded): (DocumentImpl::passwordFieldRemoved): (DocumentImpl::hasPasswordField): New methods to count password fields. (DocumentImpl::secureFormAdded): (DocumentImpl::secureFormRemoved): (DocumentImpl::hasSecureForm): New methods to count secure forms.
- khtml/xml/dom_docimpl.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Never let pages with password fields in the page cache. (KWQKHTMLPart::saveDocumentState): Do not save form state if page has a form with a password field that would be submitted securely
- 8:42 AM Changeset in webkit [3327] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Ken.
- rolled in a change from the KJS folks
Fixes a bug where the date functions would not accept non-strings.
And provides a bit of a speedup.
- kjs/date_object.h: Change parameter type for parseDate.
- kjs/date_object.cpp: (DateObjectFuncImp::call): Always call toString, don't check the type. (KJS::parseDate): Take a UString parameter, not a String parameter.
- 8:40 AM Changeset in webkit [3326] by
-
- 7 edits in trunk
WebCore:
Reviewed by Ken.
- fixed problem where Content-Type was coming in with suffixes like "charset"
- kwq/WebCoreBridge.h: Add contentType and refresh parameters, and remove "headers" parameter, from openURL method.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Get the content type from a parameter, and the refresh header from a separate parameter rather than extracting both from a headers dictionary.
WebKit:
Reviewed by Ken.
- fixed problem where Content-Type was going into WebCore with suffixes like "charset"
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Pass in contentType from the response, rather than the "Content-Type" header. Also pass in the refresh header separately.
- English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
Jan 14, 2003:
- 10:42 PM Changeset in webkit [3325] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3147036 -- words separated only by newlines are getting rammed together on XML page
- fixed 3147032 -- preformatted text is missing much whitespace on XML page
- khtml/xml/xml_tokenizer.cpp: (XMLHandler::characters): Don't try to strip whitespace at all, because it needs to be in the DOM.
- add support for more MIME types
- khtml/khtml_part.cpp: (KHTMLPart::begin): Add "application/xml" and "application/xhtml+xml".
- 7:28 PM Changeset in webkit [3324] by
-
- 4 edits in trunk/WebKit
WebFoundation:
Reviewed by Darin, Dave and Trey, and given the seal of approval by Don.
Added a new NSFileManager extension method which can be used to
remove a file but will refuse to remove a directory. Used it
wherever we remove files but not directories.
- Misc.subproj/WebNSFileManagerExtras.h:
- Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_removeFileOnlyAtPath:]): New method that removes a file using unlink(2), which means we can't possibly remove a directory. Also unlink ._ file if we are on a filesystem that doesn't support a resource fork.
- Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): Use the new method. (-[WebFileDatabase performRemoveObjectForKey:]): Use the new method.
WebKit:
Reviewed by Darin, Dave and Trey, and given the seal of approval by Don.
Use new safer file removal call that does not handle directories.
- Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Use _web_removeFileOnlyAtPath:
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Use _web_removeFileOnlyAtPath: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Use _web_removeFileOnlyAtPath:
- 6:47 PM Changeset in webkit [3323] by
-
- 6 edits in trunk/WebKit
Reviewed by Dave.
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Fixed uninitialized variable warning so builds work again.
- WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): Added "application/xml".
- WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): Added "application/xml".
- English.lproj/Localizable.strings: Regenerated.
- English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
- 4:56 PM Changeset in webkit [3322] by
-
- 5 edits in trunk/WebCore
Make FOUC work with XML.
Reviewed by darin.
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::attach):
- khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::ProcessingInstructionImpl): (ProcessingInstructionImpl::checkStyleSheet): (ProcessingInstructionImpl::isLoading): (ProcessingInstructionImpl::sheetLoaded): (ProcessingInstructionImpl::setStyleSheet):
- khtml/xml/dom_xmlimpl.h:
- 1:51 PM Changeset in webkit [3321] by
-
- 9 edits6 adds2 deletes in trunk/WebCore
Reviewed by Maciej.
- first cut at XML parsing with expat
- khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML code for text/xml documents.
- WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project. Added new QXml files, removed old ones.
- kwq/KWQXml.h: Removed.
- kwq/KWQXml.mm: Removed.
- kwq/KWQXmlAttributes.h: Added.
- kwq/KWQXmlAttributes.mm: Added.
- kwq/KWQXmlDefaultHandler.h: Added.
- kwq/KWQXmlDefaultHandler.mm: Added.
- kwq/KWQXmlSimpleReader.h: Added.
- kwq/KWQXmlSimpleReader.mm: Added.
- kwq/KWQString.h: Add fromUtf8 functions.
- kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just calls fromStringWithEncoding. We may need something more efficient later, at least for all-ASCII text.
- other changes
- khtml/khtml_part.h: Fix spelling of occurrence.
- khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect. It doesn't seem to work yet, but this does no harm.
- 1:23 PM Changeset in webkit [3320] by
-
- 4 edits in branches/Alexander-48-branch/WebCore
Reviewed by Darin.
- fixed 3144771 - Crash in KJS::WindowFunc::tryCall leaving www.smogcheck.org
I fixed this by making sure we couldn't send the unload event twice, which was
happening before in certain circumstances.
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): When emitting load event, note that unload event has not yet been sent. (KHTMLPart::checkEmitLoadEvent): Note when unload event has been sent to avoid sending it twice.
- khtml/khtmlpart_p.h:
- 1:14 PM Changeset in webkit [3319] by
-
- 6 edits in trunk/WebCore
Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly
handles the visually ordered encodings. The patch also picks up changes
from kde that accounts for european numbers correctly in bidiReorderLine().
Reviewed by Dave.
- 8:55 AM Changeset in webkit [3318] by
-
- 6 edits in trunk/WebKit
Reviewed by Trey, John, and Maciej, and given the seal of approval by Don.
- fixed 3143317 -- plug-in supplied URLs cause correspondingly named files in /tmp to be deleted
- fixed 3143330 -- plug-in supplied URLs can overwrite files used in other windows by same plug-in
- Plugins.subproj/WebBaseNetscapePluginStream.h: Make path be a char * rather than an NSString.
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Use unlink() to delete the temporary file we made. Since we created the file, we know it doesn't have any fancy stuff like a resource fork. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Create the file with mkstemp instead of trying to come up with our own filename. This eliminates the need to delete an old file (because we are guaranteed the file is new) and also mkstemp opens the file for us, so we just need to write the contents.
- English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.
- unrelated change to help with other bug analysis
- WebView.subproj/WebBaseResourceHandleDelegate.m: Added assertions.
Jan 13, 2003:
- 7:33 PM Changeset in webkit [3317] by
-
- 3 edits in branches/Alexander-48-branch/JavaScriptCore
Reviewed by Darin.
- made minor tweaks to work better with Mozilla's JavaScript tests.
- kjs/testkjs.cpp: (VersionFunctionImp::call): Implemented (main): Ignore files named -f (hack to match -f <filename syntax that moz JavaScript tests expect). Also use return code 3 instead of 1 for uncaught exception.
- 6:02 PM Changeset in webkit [3316] by
-
- 7 edits4 adds in trunk/WebKit
WebFoundation:
Fix for checking and creating proper download filenames.
Reviewed by mjs, kocienda, trey.
- CacheLoader.subproj/WebResourceResponse.h:
- CacheLoader.subproj/WebResourceResponse.m: removed the filename method. That is now a category in WebKit
- CacheLoader.subproj/WebResourceResponsePrivate.h:
- Misc.subproj/WebNSStringExtras.h:
- Misc.subproj/WebNSStringExtras.m: (-[NSString _web_filenameByFixingIllegalCharacters]): new, turns "/" into "-", strips leading dots
- ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]): don't parse out the content disposition. This is done in WebKit.
WebKit:
Fix for checking and creating proper download filenames.
Reviewed by mjs, kocienda, trey.
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebControllerPolicyDelegate.h: changes for renamed savePathForResponse:andRequest: method
- WebView.subproj/WebDefaultPolicyDelegate.m: changes for renamed savePathForResponse:andRequest: method (-[WebDefaultPolicyDelegate savePathForResponse:andRequest:]): renamed
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): changes for renamed savePathForResponse:andRequest: method
WebBrowser:
Fix for checking and creating proper download filenames.
Reviewed by mjs, kocienda, trey.
- BrowserDocument.m: (-[BrowserDocument pageName]): call _web_filenameByFixingIllegalCharacters on the web page title when saving the document
- BrowserWebController.m: (-[BrowserWebController savePathForResponse:andRequest:]): renamed, removed temporary that checks for invalid filename. That work is done in WebKit.
- HTMLSourceDocument.m: (-[HTMLSourceDocument displayName]): call suggestedFilenameForSaving
- 10:27 AM Changeset in webkit [3315] by
-
- 3 edits in trunk/JavaScriptCore
- kjs/ustring.h: Fix spelling of occurrence.
- 9:38 AM Changeset in webkit [3314] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3143781 -- submitting the same form twice doesn't work properly (example at directory.apple.com)
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same form twice" logic when the form is one that affects the frame that the form is in.
- 7:49 AM Changeset in webkit [3313] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- turned more recursion into iteration, and fixed some backwards stuff
- kjs/grammar.y: Use the normal idiom for CaseClauses and FormalParameterList rather than using append().
- kjs/grammar.cpp: Regenerated.
- kjs/nodes.h: Change ClauseListNode and ParameterNode to use the normal idiom, and got rid of append methods. Also added friend declarations and calls to reverseList().
- kjs/nodes.cpp: (StatListNode::ref): Iteration, not recursion. (StatListNode::deref): Iteration, not recursion. (StatListNode::execute): Iteration, not recursion. (StatListNode::processVarDecls): Iteration, not recursion. (CaseClauseNode::reverseList): Added. (ClauseListNode::ref): Iteration, not recursion. (ClauseListNode::deref): Iteration, not recursion. (ClauseListNode::processVarDecls): Iteration, not recursion. (CaseBlockNode::reverseLists): Added. (ParameterNode::ref): Iteration, not recursion. (ParameterNode::deref): Iteration, not recursion. (FuncDeclNode::reverseParameterList): Added. (FuncExprNode::reverseParameterList): Added. (SourceElementsNode::ref): Iteration, not recursion. (SourceElementsNode::deref): Iteration, not recursion. (SourceElementsNode::execute): Use variable name of n to match other functions. (SourceElementsNode::processFuncDecl): Ditto. (SourceElementsNode::processVarDecls): Ditto.
- kjs/nodes2string.cpp: (SourceStream::operator<<): Used a switch statement for a bit of added clarity. (ElementNode::streamTo): Iteration, not recursion. (PropertyValueNode::streamTo): Iteration, not recursion. (ArgumentListNode::streamTo): Iteration, not recursion. (StatListNode::streamTo): Iteration, not recursion, and fixed order. (VarDeclListNode::streamTo): Iteration, not recursion. (ClauseListNode::streamTo): Used for statement to match other functions. (CaseBlockNode::streamTo): Used for statement to match other functions. (ParameterNode::streamTo): Iteration, not recursion. (SourceElementsNode::streamTo): Iteration, not recursion, and fixed order that has been backwards since I changed how this works in nodes.cpp.
Jan 12, 2003:
- 9:53 PM Changeset in webkit [3312] by
-
- 4 edits in trunk/WebCore
- WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat).
- kwq/KWQKHTMLPart.cpp: Reformatted a bit.
- 9:30 PM Changeset in webkit [3311]
-
- 4 copies24 deletes in tags/EXPAT_1_95_5
This commit was manufactured by cvs2svn to create tag 'EXPAT_1_95_5'.
- 9:30 PM Changeset in webkit [3310] by
-
- 3 edits in branches/expat/WebCore/expat/lib
Check in files that I had modified from expat 1.95.5.
- 9:28 PM Changeset in webkit [3309]
-
- 1 copy24 deletes in branches/expat
This commit was manufactured by cvs2svn to create branch 'expat'.
- 9:28 PM Changeset in webkit [3308] by
-
- 4 edits23 adds in trunk/WebCore
Reviewed by Maciej.
- first step towards integrating expat for XML support: make it compile and link
- kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat. Mainly just used to make sure we link.
- WebCore.pbproj/project.pbxproj: Added expat files.
- expat/COPYING: Added.
- expat/Changes: Added.
- expat/MANIFEST: Added.
- expat/README: Added.
- expat/expat_config.h: Added.
- expat/lib/ascii.h: Added.
- expat/lib/asciitab.h: Added.
- expat/lib/expat.h: Added.
- expat/lib/iasciitab.h: Added.
- expat/lib/internal.h: Added.
- expat/lib/latin1tab.h: Added.
- expat/lib/nametab.h: Added.
- expat/lib/utf8tab.h: Added.
- expat/lib/xmlparse.c: Added.
- expat/lib/xmlrole.c: Added.
- expat/lib/xmlrole.h: Added.
- expat/lib/xmltok.c: Added.
- expat/lib/xmltok.h: Added.
- expat/lib/xmltok_impl.c: Added.
- expat/lib/xmltok_impl.h: Added.
- expat/lib/xmltok_ns.c: Added.
- 7:49 PM Changeset in webkit [3307] by
-
- 12 edits in trunk/WebKit
Reviewed by John.
- fixed 3144882 -- pretend to be WinIE for abcnews.com
- WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
- WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather than once against the spoof table, allowing two dots in the "domain name", which is needed for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean "pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE. Add a case for WinIE to the user agent computations.
- English.lproj/StringsNotToBeLocalized.txt: Update for change above.
- WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController _defaultsDidChange]): Ditto.
- WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct. Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
- Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries in the hash table.
- WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.
- other changes
- WebView.subproj/WebHTMLView.m: Removed some old, dead, #if 0'd code.
- 10:43 AM Changeset in webkit [3306] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by John.
- changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball
- kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is not available. Do #ifndef NDEBUG, not #if !NDEBUG.
- kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
- kjs/internal.cpp: (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG. (KJS::printInfo): Remove case for ListType and remove default case that just ends up suppressing the "missing case" warning and does no good.
- kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
- kjs/nodes.cpp: (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile. (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in, and together we determined it's not needed. (TypeOfNode::evaluate): Ditto.
- kjs/object.cpp: Remove assert that refers to ListType.
- kjs/value.h: Remove ListType.
- 10:41 AM Changeset in webkit [3305] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave.
- minor cleanup of plug-in-related classes in ECMA directory
- khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions ref() and deref(). Instead just make Plugin and MimeType both derive from PluginBase and remove APPLE_CHANGES. (Navigator::getValueProperty): Don't use "Konqueror" for the fallback. Just return Undefined() for that case since we will never reach it anyway.
- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two identical if statements, the logic of this function becomes much clearer.
- 9:05 AM Changeset in webkit [3304] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave.
- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
- khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
- khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
- khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): Changed !x == y to x != y. In each case, there's a reason that this does not create any problem in practice, which is why we didn't rush to get this in for beta 1.
- 9:01 AM Changeset in webkit [3303] by
-
- 7 edits in trunk/WebCore
Reviewed by John.
- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
- khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than waiting until the parser is destroyed. This fixes the bug because when the parser is destroyed, the document is already destroyed, so we have a dangling current pointer to an already-destroyed node.
- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
The bug was caused by an erroneous clicked signal that was being emitted by
QListBox at just the wrong time.
- kwq/KWQListBox.h: Added _changingSelection boolean.
- kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false. (QListBox::setSelected): Set _changingSelection to true. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked" signal if _changingSelection is false.
- khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
- khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false. (HTMLTokenizer::write): Set inWrite to true. (HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
Jan 11, 2003:
- 9:13 PM Changeset in webkit [3302] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed 3144479 -- put TITLE from links in status bar
- WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
- WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above to have any effect, so update the copyright date here.
- 5:17 PM Changeset in webkit [3301] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims link to current page
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct from an empty ATTR_HREF). Did a similar cleanup on the image code.
Jan 10, 2003:
- 12:20 AM Changeset in webkit [3300] by
-
- 11 edits in trunk
- JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.
- English.lproj/InfoPlist.strings: Updated to match above changes.
WebFoundation:
- WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass.
- English.lproj/InfoPlist.strings: Update to match above.
WebCore:
- WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL that was in the Info plist instead of project settings.
- English.lproj/InfoPlist.strings: Update to match above.
WebKit:
- WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.
- English.lproj/InfoPlist.strings: Updated to match above changes.
WebBrowser:
- WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions to 0.8.1 and 52u to keep up with the branch.
- English.lproj/InfoPlist.strings: Update to match above.
Note:
See TracTimeline
for information about the timeline view.
