Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Mar 12, 2003:

9:19 PM Changeset in webkit [3813] by mhay

• 2 edits in trunk/WebKit/Bookmarks.subproj

First cut at importing Netscape and Mozilla bookmarks.

Reviewed by Darin Adler, John Sullivan

• BookmarksController.h: Removed -(IBAction)importInternetExplorerFavorites:(id)sender; and replaced it with -(IBAction)importFavorites:(id)sender;

• BookmarksController.m: (-[BookmarksController importFavoritesFrom:intoBookmarksFolder:settingPrefKey:]): (-[BookmarksController importIEFavorites]): (-[BookmarksController _computeNetscapeAndMozillaBookmarksPath]): (-[BookmarksController importNetscapeAndMozillaFavorites]): (-[BookmarksController importFavorites:]): (-[BookmarksController importFavoritesIfNecessary]): (-[BookmarksController awakeFromNib]): Rearranged/rewrote bookmark importing code to support multiple browser types.

• PreferenceKeys.h: Added preference key to indicate that we had imported Netscape and Mozilla bookmarks.

• Localizable.strings: Added localizable string used to name imported Netscape and Mozilla bookmarks folder.

• DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Changed menu item "Import IE Favorites" to "Import Favorites". Changed action associated with that menu item from importInternetExplorerFavorites: to importFavorites:

• WebBookmarkImporter.h: Defined constant strings used to import Netscape and Mozilla bookmarks.

• WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): Added return statement to avoid executing when we had no data.

4:14 PM Changeset in webkit [3812] by cblu

• 4 edits in trunk/WebKit

3196673 - REGRESSION: Assertion failure when download fails to create file

• Retain the download delegate because it will live longer than the WebController which it is an instance of.

Reviewed by rjw.

• Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): call _downloadStarted (-[WebDownload loadWithDelegate:]): call _downloadStarted (-[WebDownload _downloadStarted]): renamed from _loadStarted (-[WebDownload _downloadEnded]): release delegate (-[WebDownload resource:willSendRequest:]): reordered so if we are released in this method, we never call self (-[WebDownload resourceDidFinishLoading:]): don't call _loadEnded because _downloadEnded gets called in _didCloseFile and _cancelWithError (-[WebDownload resource:didFailLoadingWithError:]): don't call _loadEnded because _downloadEnded gets called in _didCloseFile and _cancelWithError (-[WebDownload _didCloseFile:]): call _downloadEnded (-[WebDownload _cancelWithError:]): call _downloadEnded
• WebView.subproj/WebController.h: mention that the download delegate gets retained.

4:10 PM Changeset in webkit [3811] by rjw

• 3 edits in trunk/WebCore

Fixed leak of RenderRoot.

Reviewed by darin.

• kwq/KWQPageState.mm: (-[KWQPageState invalidate]): Added comment. (-[KWQPageState dealloc]): Ensure that the renderer is "re"set on the document so it will be correctly cleaned up in detach.

4:07 PM Changeset in webkit [3810] by hyatt

• 4 edits in trunk/WebCore

Two fixes. The first is more help with macromedia. Floats could
get lost and not painted by the correct layer still. The new
code is more robust about checking if a layer crossing occurred
in the case where you want to addOverhangingFloats to a parent.

The second fix changes the priority of space allocation when
growing cells from their minwidths to their preferred widths.
The old code did fixed and then percent. The new code does
percent and then fixed.

Also when tables are overconstrained after growing cells to their
effective widths, instead of shrinking cells without regard for
their type, I implemented a shrink system that follows the same
priority (reversed) that was used when growing the cells originally.

Reviewed by darin

• khtml/rendering/render_block.cpp:
• khtml/rendering/table_layout.cpp: (AutoTableLayout::layout):

2:09 PM Changeset in webkit [3809] by trey

• 3 edits in trunk/WebCore

WebCore:

3190784 REGRESSION: crash in KWQListIteratorImpl in form completion code at sonyericsson.com page

Don't crash on an input element with no enclosing form.

• kwq/WebCoreBrid

(-[WebCoreBridge formForElement:]): Gracefully bail on !form.

WebBrowser:

3190784 REGRESSION: crash in KWQListIteratorImpl in form completion code at sonyericsson.com page

Don't crash on an input element with no enclosing form.

Reviewed by Chris.

• FormCompletionController.m: (-[FormCompletionController initWithSourceField:frame:]): Bail out if form==nil.

11:40 AM Changeset in webkit [3808] by darin

• 7 edits in trunk/WebKit

Reviewed by John.

• fixed 3193552 -- REGRESSION: crash loading ftp directory URL
• fixed minor problems with setDefersCallbacks handling and object lifetime

• WebView.subproj/WebBaseResourceHandleDelegate.h: Removed now-unused cancelQuietly.
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancel]): Changed cancel to tolerate being called when we have already cancelled. It's an error to call cancelWithError once we have cancelled.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Added. New function to create the WebError object for policy change. (-[WebMainResourceClient stopLoadingForPolicyChange]): Changed to just be a call to cancelWithError:. (-[WebMainResourceClient resource:willSendRequest:]): Call setDefersCallbacks:YES here; continueAfterNavigationPolicy already takes care of setDefersCallbacks:NO, but we lost this one somewhere along the way. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Changed to call receivedError: on interruptForPolicyChangeError directly. It wasn't clearer to call a method named interruptForPolicyChange. (-[WebMainResourceClient resource:didReceiveResponse:]): Don't bother calling setDefersCallbacks:YES here any more; checkContentPolicyForResponse: takes care of that so there's no need to do it here. Initialize _contentLength before calling checkContentPolicyForResponse:, since that method can result in deallocating self.

9:50 AM Changeset in webkit [3807] by sullivan

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Trey

• English.lproj/StringsNotToBeLocalized.txt: updated for recent changes

WebBrowser:

• changed "Auto-fill" to "AutoFill" everywhere for consistency (Ron got to choose between "Auto Fill", "AutoFill", and "Auto-fill", and "AutoFill" won).

Reviewed by Trey

• BrowserWindowController.m: (-[BrowserWindowController explainWhyAutoFillDidNothing]): Auto-fill -> AutoFill in sheet title & message
• English.lproj/Browser.nib: Auto-fill -> "Automatically fill in" in tooltip for button
• English.lproj/MainMenu.nib: Auto-fill -> AutoFill in menu

• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt: updated for these and earlier changes

Mar 11, 2003:

8:34 PM Changeset in webkit [3806] by cblu

• 2 edits in trunk/WebKit

Fixed deployment build failure.

Reviewed by me.

• WebView.subproj/WebFramePrivate.m:

7:15 PM Changeset in webkit [3805] by rjw

• 31 edits in trunk/WebKit

WebKit:

Added controller: parameter to all WebControllers delegates.

Reviewed by chris.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
• WebView.subproj/WebContextMenuDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:]): (-[WebController _menuForElement:]): (-[WebController _mouseDidMoveOverElement:modifierFlags:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate controller:contextMenuItemsForElement:defaultMenuItems:]):
• WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate controller:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate controller:clientRedirectCancelledForFrame:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate controller:unableToImplementPolicy:error:forURL:inFrame:]): (-[WebDefaultPolicyDelegate controller:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate controller:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate controller:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:pluginFailedWithError:dataSource:]):
• WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate controller:runOpenPanelForFileButtonWithResultListener:]):
• WebView.subproj/WebFramePrivate.m: (if): (switch):
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Added controller: parameter to all WebControllers delegates.

Reviewed by chris.

• LoadProgressMonitor.m: (-[LoadProgressMonitor controller:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor controller:resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didReceiveContentLength:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didFinishLoadingFromDataSource:]): (-[LoadProgressMonitor controller:pluginFailedWithError:dataSource:]):
• LocationChangeHandler.m: (-[LocationChangeHandler controller:locationChangeStartedForDataSource:]): (-[LocationChangeHandler controller:locationChangeCommittedForDataSource:]): (-[LocationChangeHandler controller:locationChangeDone:forDataSource:]): (-[LocationChangeHandler controller:willCloseLocationForDataSource:]): (-[LocationChangeHandler controller:receivedPageTitle:forDataSource:]): (-[LocationChangeHandler controller:receivedPageIcon:forDataSource:]): (-[LocationChangeHandler controller:serverRedirectedForDataSource:]): (-[LocationChangeHandler controller:locationChangedWithinPageForDataSource:]): (-[LocationChangeHandler controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler controller:clientRedirectCancelledForFrame:]):

Tests:

Added controller: parameter to all WebControllers delegates.

Reviewed by chris.

• SimpleViewer/DocumentController.m: (-[DocumentController controller:locationChangeStartedForDataSource:]): (-[DocumentController controller:receivedPageTitle:forDataSource:]): (-[DocumentController controller:locationChangeDone:forDataSource:]): (-[DocumentController controller:identifierForInitialRequest:fromDataSource:]): (-[DocumentController controller:resource:willSendRequest:fromDataSource:]): (-[DocumentController controller:resource:didFinishLoadingFromDataSource:]): (-[DocumentController controller:resource:didFailLoadingWithError:fromDataSource:]):

6:52 PM Changeset in webkit [3804] by mjs

• 15 edits in trunk/WebKit

WebKit:

Reviewed by Richard.

Final policy API changes:

• changed WebPolicyDecisionListener to protocol in public API
• replaced policy enum with separate methods
• made content policy handling async

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]):
• WebView.subproj/WebControllerPolicyDelegatePrivate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (switch):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelContentPolicy]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient cancelQuietly]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]):

WebBrowser:

Reviewed by Richard.

• adjusted for WebKit API changes.

• BrowserWebController.m: (-[BrowserWebController decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController tellListenerToUseContentPolicyAndRelease:]): (-[BrowserWebController confirmSendSheetDidEnd:returnCode:contextInfo:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):

4:52 PM Changeset in webkit [3803] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed mistake in that last check-in that made Safari assert on startup with Chris's bookmarks bar

• Misc.subproj/WebStringTruncator.m: (centerTruncateToBuffer): Fix logic here to not use an uninitialized variable.

3:49 PM Changeset in webkit [3802] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3193213 -- assert truncatedLength+1 < STRING_BUFFER_SIZE creating tab label for firstyearibs.com
• fixed 3194935 -- WebStringTruncator rightTruncateString: will break between composed characters
• fixed right truncator to use interpolation algorithm rather than linear search

• Misc.subproj/WebStringTruncator.m: (centerTruncateToBuffer): Changed from a class method to a plain function, and tweaked the code a bit. (rightTruncateToBuffer): Added. Like centerTruncateToBuffer, but does it on the right end instead. (stringWidth): Added. Helper function that calls the TextRenderer method with the right parameters. (truncateString): Moved all the code from centerTruncateString here, adding one new parameter, the truncate to buffer function. (+[WebStringTruncator centerTruncateString:toWidth:]): Call truncateString with the appropriate parameters. (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): Ditto. (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): Ditto.

3:39 PM Changeset in webkit [3801] by hyatt

• 4 edits in trunk/WebCore

Fix for tantek's slides, this is an issue on diveintomark's
list as well. <style> was not honoring any media attributes
set on it, so print stylesheets were being applied to the screen,
etc.!

Reviewed by rjw

• khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::childrenChanged):
• khtml/html/html_headimpl.h:

3:00 PM Changeset in webkit [3800]

• 3 copies in tags/Safari-66~1_ANCHOR

This commit was manufactured by cvs2svn to create tag
'Safari-66~1_ANCHOR'.

3:00 PM Changeset in webkit [3799]

• 3 copies in branches/Safari-66~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-66~1-branch'.

3:00 PM Changeset in webkit [3798]

• 3 copies in tags/Safari-66

This commit was manufactured by cvs2svn to create tag 'Safari-66'.

3:00 PM Changeset in webkit [3797] by sheridan

• 8 edits in trunk

Safari-66 (panther submission hopeful)

10:15 AM Changeset in webkit [3796] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur

• kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.

1:19 AM Changeset in webkit [3795] by hyatt

• 3 edits in trunk/WebCore

Fix the 16000 pixel tall scrollbar on macromedia.com/software.
vertical-align position hints were being set to bad values.

Reviewed by mjs

• khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):

1:18 AM Changeset in webkit [3794] by mjs

• 2 edits in trunk/WebKit

Reviewed by Dave.

• fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com

• WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.

Mar 10, 2003:

6:58 PM Changeset in webkit [3793] by hyatt

• 3 edits in trunk/WebCore

Fix for <pre> regression, bug #3193590, directory listings
busted.

Reviewed by gramps

• khtml/rendering/bidi.cpp:

5:53 PM Changeset in webkit [3792] by darin

• 12 edits
  2 adds in trunk

WebCore:

Reviewed by Maciej.

• fixed 3010915 -- mouse wheel won't scroll the main document when you are over [i]frame

• kwq/WebCoreScrollView.h: Added.
• kwq/WebCoreScrollView.m: Added. Overrides scrollWheel to "do the right thing".
• WebCore.pbproj/project.pbxproj: Added WebCoreScrollView, and made it SPI so WebKit can use it.
• WebCore.exp: Exported WebCoreScrollView so WebKit can use it.
• WebCore-combined.exp: Regenerated.

• kwq/KWQListBox.mm: Made KWQListBoxScrollView a subclass of WebCoreScrollView instead of NSScrollView.
• kwq/KWQTextArea.h: Made KWQTextArea a subclass of WebCoreScrollView instead of NSScrollView.

• other changes

• kwq/KWQComboBox.mm: Make the workaround for the position of text in the pop-up compile only when we build on Jaguar. That way a Jaguar-built Safari looks perfect on Jaguar and a Panther built one looks perfect on Panther.

• kwq/KWQKHTMLPart.mm: Reformatted some method calls.

WebKit:

Reviewed by Maciej.

• fixed 3010915 -- mouse wheel won't scroll the main document when you are over [i]frame

• WebView.subproj/WebDynamicScrollBarsView.h: Made WebDynamicScrollBarsView a subclass of WebCoreScrollView instead of NSScrollView.

• other changes

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:): Fix problem where you would not get any information if the click was on a subview of the WebHTMLView, like a form control.

1:11 PM Changeset in webkit [3791] by hyatt

• 10 edits in trunk/WebCore

Fix compacts and run-ins to work a lot better than they did
before. I had some huge misunderstandings with how compact
worked that have now been clarified.

Reviewed by kocienda

• khtml/rendering/bidi.cpp:
• khtml/rendering/bidi.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
• khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally):
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h:

10:37 AM Changeset in webkit [3790] by cblu

• 11 edits in trunk/WebKit

Fixed some download-related leaks. Primarily, we were leaking the data source that started the download. The data source is now immediately released when it becomes a download.

Reviewed by darin.

• Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release the WebResourceDelegateProxy (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): renamed, don't pass a datasource so WebDownload is completely disconnected from the that. Pass the proxy so it transfers ownership from WebMainResourceClient and it doesn't leak when we cancel a download. (-[WebDownload _setRequest:]): added (-[WebDownload _setResponse:]): added (-[WebDownload resource:willSendRequest:]): call _setRequest (-[WebDownload resource:didReceiveResponse:]): call _setResponse
• Downloads.subproj/WebDownloadPrivate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: removed notifyDelegatesOfInterruptionByPolicyChange, no longer called
• WebView.subproj/WebMainResourceClient.h: made WebResourceDelegateProxy available to other classes
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): moved most error handling code here (-[WebMainResourceClient cancel]): stop load, call receivedError (-[WebMainResourceClient interruptForPolicyChange]): renamed, call receivedError with the policy interrupt error (-[WebMainResourceClient stopLoadingForPolicyChange]): call interruptForPolicyChange (-[WebMainResourceClient continueAfterContentPolicy:response:]): for WebPolicySave, create the download, call interruptForPolicyChange and return so the response isn't set on the superclass. (-[WebMainResourceClient resource:didFailLoadingWithError:]): call receivedError (-[WebResourceDelegateProxy setDelegate:]): don't retain the delegate (-[WebResourceDelegateProxy resourceDidFinishLoading:]): don't release the delegate (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]): don't release the delegate

8:32 AM Changeset in webkit [3789] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.

Mar 8, 2003:

2:58 AM Changeset in webkit [3788] by hyatt

• 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

* empty log message *

2:55 AM Changeset in webkit [3787] by hyatt

• 3 edits in trunk/WebCore

Check in the patch I actually meant to land. Somehow what I landed
had removed a line that was supposed to be there.

• khtml/css/cssstyleselector.cpp:

Mar 7, 2003:

8:02 PM Changeset in webkit [3786] by mjs

• 3 edits in trunk/WebCore

Reviewed by Trey.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Fix form submission (was completely broken).

6:19 PM Changeset in webkit [3785] by mjs

• 24 edits in trunk

WebCore:

Reviewed by Richard.

• fixed 3127705 - don't open new window on opt-click even if the link requests it
• fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Don't use findOrCreateFrameNamed, instead pass target along. (KWQKHTMLPart::openURLRequest): Likewise. (KWQKHTMLPart::submitForm): Likewise. (KWQKHTMLPart::urlSelected): Likewise.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Likewise.
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Richard.

• fixed 3127705 - don't open new window on opt-click even if the link requests it
• fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)

• removed open new window and open new window behind policies
• removed [WebFrame findOrCreateFrameNamed:] from API
• remved showWindowBehind from window operations delegate
• added decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener: delegate method

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest dealloc]): (-[WebPluginRequest frameName]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[NSObject performSelector:withObject:withObject:withObject:]):
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by Richard.

• fixed 3127705 - don't open new window on opt-click even if the link requests it
• fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
• updated for various WebKit API changes.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument init]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument createWebController]):
• BrowserDocumentController.h:
• BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):

6:16 PM Changeset in webkit [3784] by hyatt

• 4 edits in trunk/WebCore

better fix for text-decoration issue on time.com.

Reviewed by mjs

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_style.h:

6:02 PM Changeset in webkit [3783] by cblu

• 2 edits in trunk/WebKit

Updated header doc comments.

• Downloads.subproj/WebDownload.h:

4:04 PM Changeset in webkit [3782] by hyatt

• 3 edits in trunk/WebCore

Fix for time.com regression. Don't allow text-decoration to
apply to anchor elements with no href.

Reviewed by darin

• khtml/css/cssstyleselector.cpp:

3:14 PM Changeset in webkit [3781] by hyatt

• 3 edits in trunk/WebCore

Whoops. Fix regression causedb y previous checkin.

Reviewed by darin

• khtml/css/cssstyleselector.cpp:

3:10 PM Changeset in webkit [3780] by rjw

• 11 edits in trunk/WebKit

WebKit:

Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.

Reviewed by trey.

• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainDocumentError]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
• WebView.subproj/WebFramePrivate.m: (switch):
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m:

Tests:

Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.

Reviewed by trey.

• PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):

2:58 PM Changeset in webkit [3779] by hyatt

• 3 edits in trunk/WebCore

Make the :hover:active behavior much more sophisticated
(and make it match WinIE, since that buggy browser is what
necessitates this hack).

Reviewed by darin

• khtml/css/cssstyleselector.cpp:

2:58 PM Changeset in webkit [3778] by sullivan

• 6 edits in trunk/WebKit

WebKit:

WebKit part of fixes to these two synching-related bugs:

3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file

3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one

Reviewed by Trey

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark setUUID:]): Removed the leading underscore, made this method public. Removed unnecessary constraint that new or old UUID had to be nil; now short-circuits the no-change case. (-[WebBookmark copyWithZone:]): updated for name change (-[WebBookmark initFromDictionaryRepresentation:withGroup:]): ditto

• Bookmarks.subproj/WebBookmarkGroup.h:
• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup bookmarkForUUID:]): new public method to find a bookmark from a UUID. (-[WebBookmarkGroup _addBookmark:]): updated for name change

• Bookmarks.subproj/WebBookmarkPrivate.h: removed declaration for old _setUUID

WebBrowser:

WebBrowser part of fixes to these two synching-related bugs:

3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file

3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one

Reviewed by Trey

• BookmarksController.m: (-[BookmarksController bookmark:isFolderTitled:]): new convenience method (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): new method, replaces old code to bless the Bookmarks Bar and Bookmarks Menu folders. Now sets the new well-known UUID for these folders, and ensures that the bookmarks file will be saved if the UUIDs were not there previously. I also removed some of the old backward-compatibility-to-ancient- prelease-version hacks. (-[BookmarksController updateBookmarkSources]): reworked to call new methods

• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt: Kept these up to date

11:48 AM Changeset in webkit [3777] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed regression caused when we made the stopLoading method on WebDataSource private

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): The children are frames, so we need to do stopLoading, not _stopLoading.

11:20 AM Changeset in webkit [3776] by cblu

• 14 edits in trunk/WebKit

WebKit:

Fixed: 3191052 - Predetermined downloads should not be started from the browser window

• Stripped the rest of WebKit of download related code.

Reviewed by trey.

• Downloads.subproj/WebDownload.h: Changed the download delegate method from download:didStartFromDataSource: download:didStartFromRequest:. Passing the data source wasn't that helpful. It was also quirky that the data source would sometimes be nil.
• Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release directory path (-[WebDownload _initWithLoadingResource:dataSource:]): call _loadStarted and _loadEnded (-[WebDownload loadWithDelegate:]): call _loadStarted (-[WebDownload _loadStarted]): set flag, retain self (-[WebDownload _loadEnded]): set flag, release self (-[WebDownload resource:willSendRequest:]): call _loadEnded if the returned request is nil (-[WebDownload resourceDidFinishLoading:]): call _loadEnded (-[WebDownload resource:didFailLoadingWithError:]): call _loadEnded (-[WebDownload _createFileIfNecessary]): handle a predetermined download directory, not path (-[WebDownload _cancelWithError:]): call _loadEnded (-[WebDownload _setDirectoryPath:]): new private method
• Downloads.subproj/WebDownloadPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]): don't call [dataSource isDownloading] (-[WebController _downloadURL:toDirectory:]): create and start a self retained WebDownload
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: removed download related methods
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: removed download related methods (-[WebDataSource _commitIfReady:]): don't call isDownloading
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): when handing off the load to the download, don't deal with the download path (-[WebMainResourceClient resource:didReceiveResponse:]): no more predetermined downloads come through here

WebBrowser:

Fixed: 3142376 - would be better if queued downloads showed up in downloads window

• Handle WebKit started downloads that don't have associated data sources.
• Don't use removed WebKit download API's.
• Handle HTTP errors in responses instead of downloading html error files.
• Don't update progress bar using a timer so it doesn't jerk.

Reviewed by john.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): call downloadMayBeOpenedForRequest (-[BrowserWebController stopLoading]): removed stopNonDownloadingDataSource, don't call it
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): create _openableDownloadRequests (-[DownloadMonitor download:didStartFromRequest:]): fixed leak, create entry with request (-[DownloadMonitor download:didReceiveResponse:]): handle HTTP errors (-[DownloadMonitor downloadMayBeOpenedForRequest:]): renamed
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry setBytesLoaded:]): call progress notification (-[DownloadProgressEntry setBytesExpected:]): call progress notification (-[DownloadProgressEntry bytesExpected]): overridden to avoid superclass quirks
• DownloadRow.m: (-[DownloadRow initWithDownloadProgressEntry:]): observe DownloadEntryProgressDidChangeNotification (-[DownloadRow _updateProgressAnimation]): handle changes in bytesExpected (-[DownloadRow _startProgressAnimation]): call _updateProgressAnimation, have timer call _updateStatusField (-[DownloadRow _updateStatusField]): handle no bytes received case (-[DownloadRow entryStageDidChange]): tweak (-[DownloadRow entryPathDidChange]): tweak (-[DownloadRow entryProgressDidChange]): call _updateProgressAnimation
• English.lproj/Localizable.strings: updated

Mar 6, 2003:

11:26 PM Changeset in webkit [3775] by mjs

• 7 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

Step towards policy API changes. Remove WebPolicyNone,
WebPolicyRevealInFinder, WebPolicyOpenURL and WebPolicyShow.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
• WebView.subproj/WebFramePrivate.m: (switch):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

Reviewed by Trey.

Updated for WebKit API changes. Handle removed convenience
policies internally.

• BrowserWebController.m: (-[BrowserWebController unableToImplementPolicyWithError:inFrame:]): (-[BrowserWebController openFileExternallyWithRequest:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController revealInFinderWithRequest:inFrame:]): (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):

7:45 PM Changeset in webkit [3774] by rjw

• 3 edits in trunk/WebKit

Remove setWebView: from WebFrame.

Reviewed by chris.

• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): (-[WebFrame name]):

7:30 PM Changeset in webkit [3773] by rjw

• 14 edits in trunk/WebKit

WebKit:

API changes. WebCapabilities -> WebContentTypes.
Move fileExtension from WebDataSource to WebContentTypes

Reviewed by chris.

• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
• WebKit.exp:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (+[WebContentTypes suggestedFileExtensionForMIMEType:]): (-[WebController supportsTextEncoding]): (-[WebController setCustomTextEncodingName:]): (-[WebController _mainFrameOverrideEncoding]): (-[WebController customTextEncodingName]): (-[WebController stringByEvaluatingJavaScriptFromString:]): (-[WebController userAgentForURL:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

API changes. WebCapabilities -> WebContentTypes.
Move fileExtension from WebDataSource to WebContentTypes

Reviewed by chris.

• BrowserDocument.m: (-[BrowserDocument fileType]):
• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):

6:37 PM Changeset in webkit [3772] by cblu

• 21 edits in trunk/WebKit

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

• Misc.subproj/WebNSFileManagerExtras.h:
• Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebKit:

Implemented WebDownload API.

Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off

Reviewed by trey, rjw, mjs.

• Downloads.subproj/WebDownload.h: Tweaked comments, added new methods.
• Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release new objects (-[WebDownload initWithRequest:]): was initWithRequest:delegate:, but found that starting the load from the init method made it tricky to do other set up work before the load started. (-[WebDownload _initWithLoadingResource:dataSource:]): private init method, "catches up" to load by sending delegate method immediately, doesn't retain the dataSource, uses it for info (-[WebDownload loadWithDelegate:]): new, starts load (-[WebDownload cancel]): cancel load with no error (-[WebDownload path]): simple getter (-[WebDownload setPath:]): implement this because WebDownload is the WebDownloadDecisionListener, call _setPath (-[WebDownload resource:willSendRequest:]): resource delegate method (-[WebDownload resource:didReceiveResponse:]): resource delegate method (-[WebDownload resource:didReceiveData:]): resource delegate method, decode and write data, cancel load if error (-[WebDownload resourceDidFinishLoading:]): resource delegate method, decode and write data if necessary, end in error if error (-[WebDownload resource:didFailLoadingWithError:]): resource delegate method, end in error (-[WebDownload _pathWithUniqueFilenameForPath:]): this work was done in _createFileIfNecessary, does what it says (-[WebDownload _createFSRefForPath:]): this work was done in _createFileIfNecessary as well, makes fileRefPtr point to a file (-[WebDownload _createFileIfNecessary]): creates file, creates temp file if path hasn't been set yet (-[WebDownload _decodeHeaderData:dataForkData:resourceForkData:]): call private method (-[WebDownload _decodeData:dataForkData:resourceForkData:]): made private, if the download is encoded, ask client if OK to decode (-[WebDownload _decodeData:]): hardly changed, don't cancel, just return error (-[WebDownload _dataIfDoneBufferingData:]): moved, not changed (-[WebDownload _finishDecoding]): hardly changed, don't cancel, just return error (-[WebDownload _writeForkData:isDataFork:]): moved, not changed (-[WebDownload _writeDataForkData:resourceForkData:]): moved, not changed (-[WebDownload _isFileClosed]): new (-[WebDownload _fileDidClose:]): new, called by the callback thread, delete file if deleteFile flag is set, report error or end successfully (-[WebDownload _closeForkAsync:]): new (-[WebDownload _closeForkSync:]): new (-[WebDownload _closeFileAsync]): new (-[WebDownload _closeFileSync]): new (-[WebDownload _deleteFileAsnyc]): new (-[WebDownload _closeAndDeleteFileAsync]): new (-[WebDownload _cancelWithError:]): kill load if there is one, report error if there is one, close and delete file is not already closed or deleted (-[WebDownload _cancelWithErrorCode:]): internal convenienve, calls _cancelWithError (-[WebDownload _setPath:]): set path, if we are already saving data to a temp path, move the file and continue downloading (-[WebDownload _currentPath]): new (-[WebDownload _errorWithCode:]): new (-[WebDownload _dataForkReferenceNumber]): added underscore (-[WebDownload _setDataForkReferenceNumber:]): added underscore (-[WebDownload _resourceForkReferenceNumber]): added underscore (-[WebDownload _setResourceForkReferenceNumber:]): added underscore (-[WebDownload _areWritesCancelled]): added underscore (-[WebDownload _setWritesCancelled:]): added underscore (-[WebDownload _encounteredCloseError]): new (-[WebDownload _setEncounteredCloseError:]): new (WriteCompletionCallback): call underscored methods (CloseCompletionCallback): call underscored methods, handle close error, don't delete file (DeleteCompletionCallback): call _currentPath
• Downloads.subproj/WebDownloadPrivate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.h: renamed handle to resource
• WebView.subproj/WebBaseResourceHandleDelegate.m: renamed handle to resource (-[WebBaseResourceHandleDelegate _releaseResources]): renamed handle to resource (-[WebBaseResourceHandleDelegate startLoading:]): renamed handle to resource (-[WebBaseResourceHandleDelegate loadWithRequest:]): renamed handle to resource (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): renamed handle to resource (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): renamed handle to resource (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate cancelWithError:]): renamed handle to resource, don't handle downloads
• WebView.subproj/WebController.h: updated comments
• WebView.subproj/WebController.m: (-[WebController setDownloadDelegate:]): call the ivar downloadDelegate, not downloadProgressDelegate (-[WebController downloadDelegate]): call the ivar downloadDelegate, not downloadProgressDelegate
• WebView.subproj/WebControllerPolicyDelegate.h: removed saveFilenameForResponse:andRequest:, handle by WebDownload
• WebView.subproj/WebControllerPrivate.h: call the ivar downloadDelegate, not downloadProgressDelegate
• WebView.subproj/WebDefaultPolicyDelegate.m: removed saveFilenameForResponse:andRequest:, handle by WebDownload
• WebView.subproj/WebMainResourceClient.h: added WebResourceDelegateProxy icar
• WebView.subproj/WebMainResourceClient.m: remove most download related stuff (-[WebMainResourceClient initWithDataSource:]): create a WebResourceDelegateProxy which allows us to change the resource delegate (-[WebMainResourceClient dealloc]): release the proxy (-[WebMainResourceClient receivedError:complete:]): don't handle downloads (-[WebMainResourceClient continueAfterContentPolicy:response:]): pass the load off to the download (-[WebMainResourceClient resource:didReceiveResponse:]): don't handle downloads (-[WebMainResourceClient resource:didReceiveData:]): don't handle downloads (-[WebMainResourceClient resourceDidFinishLoading:]): don't handle downloads (-[WebMainResourceClient resource:didFailLoadingWithError:]): don't handle downloads (-[WebMainResourceClient startLoading:]): make the proxy the delegate (-[WebResourceDelegateProxy setDelegate:]): switches the resource delegate (-[WebResourceDelegateProxy resource:willSendRequest:]): forwards message (-[WebResourceDelegateProxy resource:didReceiveResponse:]): forwards message (-[WebResourceDelegateProxy resource:didReceiveData:]): forwards message (-[WebResourceDelegateProxy resourceDidFinishLoading:]): forwards message (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]): forwards message

WebBrowser:

Made WebBrowser use the WebDownload API. Most of the changes involved switching from a WebDataSource to a WebDownload to represent a download.

Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off

Reviewed by trey.

• BrowserWebController.m: Removed savePathForResponse:: because it is handled by the WebDownload API
• BrowserWebErrorExtras.m: Define WebErrorDomainBrowser in here not in DownloadMonitor.
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor _loadDownloadHistory]): call DownloadProgressEntry init method, not class constructor (-[DownloadMonitor init]): (-[DownloadMonitor download:didStartFromDataSource:]): new WebDownload API, reuse a DownloadProgressEntry if reloading, else create a new one (-[DownloadMonitor download:willSendRequest:]): new WebDownload API (-[DownloadMonitor download:didReceiveResponse:]): new WebDownload API (-[DownloadMonitor download:decidePathWithListener:suggestedFilename:]): new WebDownload API, set path immediately (-[DownloadMonitor download:didReceiveDataOfLength:]): new WebDownload API (-[DownloadMonitor downloadShouldDecodeEncodedFile:]): new WebDownload API, return YES if "Open Safe Downloads" is enabled (-[DownloadMonitor download:didCreateFileAtPath:]): new WebDownload API (-[DownloadMonitor downloadDidFinishDownloading:]): new WebDownload API (-[DownloadMonitor download:didFailDownloadingWithError:]): new WebDownload API (-[DownloadMonitor downloadMayBeOpenedForDataSource:]): use renamed dictionary (-[DownloadMonitor setEntry:forReloadingDownload:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry _setDownload:]): new, replaces setDataSource (-[DownloadProgressEntry dealloc]): release the response (-[DownloadProgressEntry setResponse:]): new (-[DownloadProgressEntry response]): new (-[DownloadProgressEntry filename]): handle the nil path case (a DownloadProgressEntry now will be created before the file exists) (-[DownloadProgressEntry setPath:]): added comments (-[DownloadProgressEntry fileExists]): handle the nil path (-[DownloadProgressEntry open]): assert for nil path (-[DownloadProgressEntry stop]): cancel the download (-[DownloadProgressEntry reload]): No need to involve all the WebKit machinery to do a download. Phew! (-[DownloadProgressEntry reveal]): handle the nil path (-[DownloadProgressEntry setDownloadStage:]): don't do anything if the set stage is the same as the current (-[DownloadProgressEntry _openDiskCopyFile]): assert for nil path (-[DownloadProgressEntry _openInstallerPackage]): assert for nil path (-[DownloadProgressEntry autoOpen]): assert for nil path (-[DownloadProgressEntry setDone:]): release and set download to nil (-[NSFileManager _pathForSingleItemAtPath:]): assert for nil path

5:14 PM Changeset in webkit [3771] by hyatt

• 3 edits in trunk/WebCore

Fix for 3156125, regression on hiptop.com. Caused by better
nowrap handling perversely enough. Need another quirk from
Moz/WinIE to make this site behave.

Reviewed by darin

• khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth): (RenderTableCell::setStyle):

4:25 PM Changeset in webkit [3770] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3191027 -- REGRESSION: KWQColor assert at aol.com front page

• kwq/KWQColor.mm: (qRgb): Clamp to [0,0xFF] instead of asserting.

3:25 PM Changeset in webkit [3769] by rjw

• 12 edits in trunk/WebKit

Move tweaks to WebKit API.

Removed [WebFrame setController:] from public API.
Removed [WebDataSource stringWithData:] from public API.

Reviewed by hyatt.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource mainDocumentError]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stringWithData:]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLRepresentation.m:
• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]):
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):

2:33 PM Changeset in webkit [3768] by rjw

• 33 edits in trunk/WebKit

WebKit:

Tweaks to WebKit API.
Dropped URL on WebDataSource.
Dropped start/stop loading on WebDataSource.
Drop frameForView and frameForDataSource from WebController.
Moved canShowXX to WebCapabilities.

Reviewed by hyatt.

• Downloads.subproj/WebDownload.m: (-[WebDownload errorWithCode:]):
• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_printViewHierarchy:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
• WebKit.exp:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (+[WebCapabilities canShowMIMEType:]): (+[WebCapabilities canShowFile:]): (-[WebController mainFrame]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _frameForDataSource:fromFrame:]): (-[WebController _frameForDataSource:]): (-[WebController _frameForView:fromFrame:]): (-[WebController _frameForView:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _recursiveStopLoading]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _URL]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):
• WebView.subproj/WebFramePrivate.m: (if):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation setDataSource:]):
• WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancel]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]):
• WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
• WebView.subproj/WebView.m: (-[WebView webFrame]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]):

WebBrowser:

Tweaks to WebKit API.
Dropped URL on WebDataSource.
Dropped start/stop loading on WebDataSource.
Drop frameForView and frameForDataSource from WebController.
Moved canShowXX to WebCapabilities.

Reviewed by hyatt.

• BrowserDocument.m: (-[BrowserDocument provisionalURL]):
• BrowserDocumentController.m: (-[BrowserDocumentController openHTMLSourceDocumentWithDataSource:]):
• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController currentURL]): (-[BrowserWebController stopNonDownloadingDataSource:]):
• BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
• FormCompletionController.m: (domainFromFrame): (+[AutoFillController autoFillInController:]):
• FrameProgressEntry.m: (-[FrameProgressEntry URL]):
• HTMLSourceDocument.m: (-[HTMLSourceDocument fileName]): (-[HTMLSourceDocument displayName]): (-[HTMLSourceDocument browserDocumentLoadingFinished:]):
• LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]):

2:14 PM Changeset in webkit [3767] by voas

• 2 edits in trunk/WebKit

2003-03-06 Ed Voas ​voas@apple.com

Reviewed by Richard.

Don't use _HIViewSetNeedsDisplayInRect for now. Fixes
Jaguar builds.

• Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]):

1:52 PM Changeset in webkit [3766] by trey

• 3 edits in trunk/WebCore

Refinement of routine that scans the DOM for field labels.
We skip nodes that have no renderer, or are invisible.

Reviewed by hyatt.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsBeforeElement): Added check.

1:48 PM Changeset in webkit [3765] by mjs

• 7 edits in trunk/WebKit

WebKit:

Reviewed by John.

Step towards policy API chantes - removed unneeded policy and URL
arguments from unableToImplementPolicy:

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

Reviewed by John.

Updated for WebKit API change.

• BrowserWebController.m: (-[BrowserWebController unableToImplementPolicyWithError:inFrame:]): Removed URL and policy arguments.

1:40 PM Changeset in webkit [3764] by voas

• 3 edits
  14 adds in trunk/WebKit

2003-03-06 Ed Voas ​voas@apple.com

Reviewed by Richard.

First cut of Carbon view support. It will need tweaking as we go,
but I think I finally have all the assertions taken care of, and
I also believe that I have the drawing glitches all sorted out now.

• Carbon.subproj/CarbonUtils.h: Added.
• Carbon.subproj/CarbonUtils.m: Added. (InitWebKitForCarbon): (PoolCleaner): (ConvertNSImageToCGImageRef):
• Carbon.subproj/CarbonWindowAdapter.h: Added.
• Carbon.subproj/CarbonWindowAdapter.m: Added. (+[CarbonWindowAdapter frameViewClassForStyleMask:]): (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter setViewsNeedDisplay:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]): (-[CarbonWindowAdapter dealloc]): (-[CarbonWindowAdapter windowRef]): (-[CarbonWindowAdapter _hasWindowRef]): (-[CarbonWindowAdapter _managesWindowRef]): (-[CarbonWindowAdapter _removeWindowRef]): (-[CarbonWindowAdapter _carbonWindowClass]): (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): (-[CarbonWindowAdapter sendSuperEvent:]): (-[CarbonWindowAdapter _cancelKey:]): (-[CarbonWindowAdapter _commonAwake]): (-[CarbonWindowAdapter _destroyRealWindow:]): (-[CarbonWindowAdapter _oldPlaceWindow:]): (-[CarbonWindowAdapter _termWindowIfOwner]): (-[CarbonWindowAdapter _windowMovedToRect:]): (-[CarbonWindowAdapter constrainFrameRect:toScreen:]): (-[CarbonWindowAdapter selectKeyViewFollowingView:]): (-[CarbonWindowAdapter selectKeyViewPrecedingView:]): (-[CarbonWindowAdapter makeKeyWindow]): (-[CarbonWindowAdapter canBecomeKeyWindow]): (-[CarbonWindowAdapter canBecomeMainWindow]): (-[CarbonWindowAdapter encodeWithCoder:]): (-[CarbonWindowAdapter initWithCoder:]): (-[CarbonWindowAdapter setContentView:]): (-[CarbonWindowAdapter worksWhenModal]): (-[CarbonWindowAdapter _setModalWindowLevel]): (-[CarbonWindowAdapter _clearModalWindowLevel]): (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]): (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]): (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]): (-[CarbonWindowAdapter _handleRootBoundsChanged]): (-[CarbonWindowAdapter _handleContentBoundsChanged]): (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]): (NSCarbonWindowHandleEvent):
• Carbon.subproj/CarbonWindowContentView.h: Added.
• Carbon.subproj/CarbonWindowContentView.m: Added.
• Carbon.subproj/CarbonWindowFrame.h: Added.
• Carbon.subproj/CarbonWindowFrame.m: Added. (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame initWithFrame:styleMask:owner:]): (-[CarbonWindowFrame dealloc]): (-[CarbonWindowFrame _setFrameNeedsDisplay:]): (-[CarbonWindowFrame _setSheet:]): (-[CarbonWindowFrame _updateButtonState]): (-[CarbonWindowFrame _windowChangedKeyState]): (-[CarbonWindowFrame _showToolbarWithAnimation:]): (-[CarbonWindowFrame _hideToolbarWithAnimation:]): (-[CarbonWindowFrame closeButton]): (-[CarbonWindowFrame styleMask]): (-[CarbonWindowFrame dragRectForFrameRect:]): (-[CarbonWindowFrame isOpaque]): (-[CarbonWindowFrame minimizeButton]): (-[CarbonWindowFrame setTitle:]): (-[CarbonWindowFrame title]): (-[CarbonWindowFrame _sheetHeightAdjustment]): (-[CarbonWindowFrame _maxTitlebarTitleRect]): (-[CarbonWindowFrame _clearDragMargins]): (-[CarbonWindowFrame _resetDragMargins]):
• Carbon.subproj/HIViewAdapter.h: Added.
• Carbon.subproj/HIViewAdapter.m: Added. (+[HIViewAdapter bindHIViewToNSView:nsView:]): (+[HIViewAdapter getHIViewForNSView:]): (+[HIViewAdapter unbindNSView:]): (-[HIViewAdapter initWithFrame:view:]): (-[HIViewAdapter hiView]): (-[HIViewAdapter nextValidKeyView]): (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]): (-[CarbonSheetInterceptor _orderFrontRelativeToWindow:]): (-[CarbonSheetInterceptor _orderOutRelativeToWindow:]):
• Carbon.subproj/HIWebView.h: Added.
• Carbon.subproj/HIWebView.m: Added. (if): (switch):
• Carbon.subproj/HIWebViewPriv.h: Added.
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:

1:22 PM Changeset in webkit [3763] by hyatt

• 3 edits in trunk/WebCore

Fix for 3190580, tables should reset line-height and white-space
in quirks mode.

Reviewed by trey and john

• khtml/css/quirks.css:

11:26 AM Changeset in webkit [3762] by sheridan

• 3 edits in trunk

starting Safari-66; tree is open

11:23 AM Changeset in webkit [3761]

• 3 copies in tags/Safari-65

This commit was manufactured by cvs2svn to create tag 'Safari-65'.

11:23 AM Changeset in webkit [3760] by sheridan

• 8 edits in trunk

Safari-65 stamp

8:46 AM Changeset in webkit [3759] by darin

• 2 edits in trunk/WebCore

Reviewed by Don.

• fixed 3177862 -- REGRESSION: can't upload widget at www.konfabulator.com

• khtml/html/html_formimpl.cpp: (fixUpfromUnicode): Add a call to fixLineBreaks here (and move this down below that function). (HTMLFormElementImpl::formData): Remove the call to fixLineBreaks here, which was being used on non-text form data, like files being uploaded.

8:35 AM Changeset in webkit [3758] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3177862 -- REGRESSION: can't upload widget at www.konfabulator.com

• khtml/html/html_formimpl.cpp: (fixUpfromUnicode): Add a call to fixLineBreaks here (and move this down below that function). (HTMLFormElementImpl::formData): Remove the call to fixLineBreaks here, which was being used on non-text form data, like files being uploaded.

Mar 5, 2003:

11:29 PM Changeset in webkit [3757] by trey

• 4 edits in trunk/WebCore

Autofill tweak. In field names, replace all digits with spaces before matching
labels against them. This turns the digits to word boundaries, so field names like
"address2" are matched by "address".

As part of this, I abandoned an earlier attempt to map Qt regexp syntax to Darwin's.
Now clients just have to use Darwin's.

Reviewed by Maciej.

• kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::matchLabelsAgainstElement): Replace digits with space.
• kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::compile): Don't try to support Qt syntax.

7:26 PM Changeset in webkit [3756] by rjw

• 30 edits in trunk/WebKit

WebKit:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient resourceDidFinishLoading:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController backForwardList]): (-[WebController setUsesBackForwardList:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _receivedError:complete:]): (-[WebDataSource _loadIcon]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFramePrivate.m: (switch):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]): (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
• WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]):
• WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView webFrame]): (-[WebView concludeDragOperation:]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _controller]):

WebBrowser:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

• BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
• BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]):
• BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]):
• DownloadProgressEntry.m:
• LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):

5:17 PM Changeset in webkit [3755] by mjs

• 2 edits in trunk/WebKit

Reviewed by Ken.

• WebView.subproj/WebFramePrivate.m: (_recursiveGoToItem:fromItem:withLoadType:): Account for possibility of nil target.

3:19 PM Changeset in webkit [3754] by mjs

• 3 edits in trunk/WebKit

Reviewed by Darin.

• fixed crash when going back due to frame name of nil since we don't force the name "_top" any more.

• WebView.subproj/WebController.m: (-[WebController _goToItem:withLoadType:]): Handle nil target properly.

8:23 AM Changeset in webkit [3753] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3189441 -- REGRESSION: layout tests crash building generated frame name

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _addFramePathToString:]): Handle a frame name of nil here, since we don't force the name "_top" any more.

8:19 AM Changeset in webkit [3752] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3189442 -- REGRESSION: utf-16-little-endian.html crashes making decoder

• kwq/KWQCharsets.mm: (encodingNameHash): Re-add tolower call to hash function to match the equality function.

Mar 4, 2003:

11:18 PM Changeset in webkit [3751] by trey

• 11 edits in trunk

WebCore:

New support for autofill. We provide a routine that scans backwards in the text
before a given element, looking for a match with a set of labels. In addition,
we provide for a similar match against the element's name.

To implement a few more methods in QRegExp API were implemented.

Reviewed by Maciej.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (scanForForm): Remove redundant call to a helper function. (regExpForLabels): Return a regexp used to search for the set of labels. (KWQKHTMLPart::searchForLabelsBeforeElement): Walk the DOM to scan backwards in the text before the element, apply regexp to the text we find. (KWQKHTMLPart::matchLabelsAgainstElement): Get the element name, use regexp to check it for any of the labels.
• kwq/KWQRegExp.h:
• kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): Init two new ivars. (RegExpFromPattern): Massage a non-glob expression before handing to Darwin. (QRegExp::KWQRegExpPrivate::compile): Call RegExpFromPattern. (QRegExp::match): Set new ivars based on match result. (QRegExp::search): New API, just call match. (QRegExp::searchRev): New API, call match repeatedly to (weakly) simulate a reverse search. (QRegExp::pos): Return info from last result. (QRegExp::matchedLength): Return info from last result.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge searchForLabels:beforeElement:]): Call straight through to part. (-[WebCoreBridge matchLabels:againstElement:]): Call straight through to part.

WebKit:

Support for autofill. These are just two new glue routines
that call down through the bridge. They allow regexp driven
binding of AB data to form elements.

Reviewed by Maciej.

• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Call straight to bridge. (-[WebHTMLRepresentation matchLabels:againstElement:]): Call straight to bridge.

11:14 PM Changeset in webkit [3750] by mjs

• 2 edits in trunk/WebKit

Reinstate missing part of last checking.

• WebView.subproj/WebFramePrivate.m:

11:05 PM Changeset in webkit [3749] by mjs

• 12 edits in trunk/WebKit

Tests:

Reviewed by Trey.

Updated for WebKit API change.

• DumpBackForward/main.m: (main): (-[CheapWindowOpsDelegate createWindowWithRequest:]):
• DumpRenderTree/main.m: (main):
• PDFViewer/DocumentController.m: (-[DocumentController loadURL:]):
• SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):
• SnippetEditor/SnippetController.m: (-[SnippetController _resetViews]):

WebKit:

Reviewed by Trey.

Added the ability to set the top-level frame name via the
WebController initializer. Also made [[controller mainFrame]
frameName] return the true top-level frame name instead of "_top",
since that is already special-cased anywhere it needs to be.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController init]): Update for change to designated initializer. (-[WebController initWithView:]): New convenience initializer. (-[WebController initWithView:frameName:setName:]): Added ability to set top-level frame name.
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Remove topLevelFrameNAme field. (-[WebController _setTopLevelFrameName:]): Actually set it on the top level frame, no point to keeping it here. (-[WebController _findFrameInThisWindowNamed:]): No more need to special-case top-level frame name.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): call [self _setName:] instead of [_private setName:]
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setName:]): Don't let the name get set to _blank.

WebBrowser:

Reviewed by Trey.

Updated for WebKit API change.

• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:]):
• BrowserWindowController.m: (-[BrowserWindowController setUpFavoritesBar]):
• Debug/SnippetController.m: (-[SnippetController load]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):

5:11 PM Changeset in webkit [3748] by sullivan

• 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin

• Misc.subproj/WebKitNSStringExtras.h:
• Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): (-[NSString _web_drawAtPoint:font:textColor:): removed the unnecessary string parameter from these two NSString methods.

WebBrowser:

• updated all callers to WebKitNSStringExtras methods that I renamed.

Reviewed by Darin

• BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): replace _web_drawString:atPoint:... with _web_drawAtPoint:...
• DownloadRow.m: (-[DownloadRow bestWidth]): replace _web_widthOfString:font:... with _web_widthWithFont:...
• TabBarView.m: (-[TabBarView _leftTruncateWordsFrom:withFont:width:maxWordsToRemove:]): ditto
• TabButton.m: (-[TabButton _updateCellAttributes]): ditto

4:56 PM Changeset in webkit [3747] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• got rid of some framework initialization (working on bug 3185161)

• WebView.subproj/WebPreferences.m: (-[WebPreferences _postPreferencesChangesNotification]): Moved this function up. (+[WebPreferences standardPreferences]): Call _postPreferencesChangesNotification when this is made, for consistency with the old behavior. (+[WebPreferences initialize]): Changed to initialize from load, and got rid of stuff we don't want to do from inside an initialize function.

4:42 PM Changeset in webkit [3746] by darin

• 8 edits in trunk/WebCore

Reviewed by Maciej.

• got rid of some framework initialization (working on bug 3188781)

• khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): Put some waitCursor use inside #if !APPLE_CHANGES. (KHTMLPart::reparseConfiguration): Put some waitCursor use inside #if !APPLE_CHANGES.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Use KCursor cursors instead of Qt cursors.

• kwq/KWQNamespace.h: Remove Qt cursors.
• kwq/KWQCursor.mm: Remove Qt cursors.
• kwq/KWQKCursor.h: Remove waitCursor.
• kwq/KWQKCursor.mm: Remove waitCursor.

4:41 PM Changeset in webkit [3745] by darin

• 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• got rid of some framework initialization (working on bug 2959353)

• kjs/identifier.h: Turn Identifier:null into Identifier:null().
• kjs/identifier.cpp: Removed Identifier:null and added Identifier:null().

• kjs/internal.cpp: Made NaN_Bytes and Inf_Bytes const.

• kjs/completion.h: Use Identifier:null() instead of Identifier:null.
• kjs/function.h: Ditto.
• kjs/function_object.cpp: (FunctionObjectImp::construct): Ditto.
• kjs/nodes.cpp: (FuncExprNode::evaluate): Use Identifier:null() instead of Identifier:null.

4:37 PM Changeset in webkit [3744] by sheridan

• 3 edits in trunk

forgot to update to version 65u after the build of Safari-64

3:45 PM Changeset in webkit [3743] by darin

• 8 edits in trunk/WebCore

Reviewed by John.

• fixed build rules for parser.cpp so we don't rebuild it every time

• khtml/css/Makefile.am: Changed target to parser.cpp, not parser.

• some QColor cleanup

• kwq/KWQColor.h: Removed the qRgba function, the unused KWQColor constructor that takes a QString parameter, and made the KWQColor constructor that takes a const char * parameter explicit.
• kwq/KWQColor.mm: (QColor::QColor): Use findColor directly so we don't create and then destroy a QString. (QColor::setNamedColor): Eliminated the unnecessary special case for empty string. Get rid of the call to lower(), which is now handled by the caller. Got rid of the "can't decipher this color" ERROR, which makes little sense now that non-named colors (like hex ones) are handled at the KHTML level. Don't use setRgb to set the color, since the RGB value in the gperf table is already in the correct format to just be stored in QColor::color.

• khtml/misc/helper.h: Removed now-unused setNamedColor function. I'm sure this same change exists on the KHTML trunk (since the CSS parser rewrite).
• khtml/misc/helper.cpp: More of the same.

• khtml/misc/loader.cpp: #if !APPLE_CHANGES the places that use qRgba to set bgColor, which we don't use anyway.

12:38 PM Changeset in webkit [3742] by rjw

• 3 edits in trunk/WebKit

Remove initWithURL: and frameName from WebDataSource public API.

Reviewed by trey.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource webFrame]):

9:40 AM Changeset in webkit [3741] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
• English.lproj/Localizable.strings: Regenerated.

12:40 AM Changeset in webkit [3740] by rjw

• 41 edits
  10 adds
  2 deletes in trunk/WebKit

WebKit:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView status:]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]): (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
• WebView.subproj/WebContextMenuDelegate.h:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]): (-[WebController stringByEvaluatingJavaScriptFromString:]):
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]): (-[WebController _menuForElement:]): (-[WebController _mouseDidMoveOverElement:modifierFlags:]): (-[WebController _locationChangeDelegateForwarder]): (-[WebController _resourceLoadDelegateForwarder]): (-[WebController _policyDelegateForwarder]): (-[WebController _contextMenuDelegateForwarder]): (-[WebController _windowOperationsDelegateForwarder]): (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): (-[_WebSafeForwarder forwardInvocation:]): (-[_WebSafeForwarder methodSignatureForSelector:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
• WebView.subproj/WebDefaultContextMenuDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.m: (+[WebDefaultContextMenuDelegate sharedContextMenuDelegate]):
• WebView.subproj/WebDefaultLocationChangeDelegate.h: Added.
• WebView.subproj/WebDefaultLocationChangeDelegate.m: Added. (+[WebDefaultLocationChangeDelegate sharedLocationChangeDelegate]): (-[WebDefaultLocationChangeDelegate locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate clientRedirectCancelledForFrame:]):
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate sharedPolicyDelegate]):
• WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Removed.
• WebView.subproj/WebDefaultResourceLoadDelegate.h: Added.
• WebView.subproj/WebDefaultResourceLoadDelegate.m: Added. (+[WebDefaultResourceLoadDelegate sharedResourceLoadDelegate]): (-[WebDefaultResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate pluginFailedWithError:dataSource:]):
• WebView.subproj/WebDefaultWindowOperationsDelegate.h: Added.
• WebView.subproj/WebDefaultWindowOperationsDelegate.m: Added. (+[WebDefaultWindowOperationsDelegate sharedWindowOperationsDelegate]): (-[WebDefaultWindowOperationsDelegate runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate runOpenPanelForFileButtonWithResultListener:]):
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): (-[WebFrame findOrCreateFrameNamed:]):
• WebView.subproj/WebFramePrivate.m: (if): (switch):
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebLocationChangeDelegate.m: Removed.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

• BrowserWebController.h:
• Debug/SnippetController.h:
• Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController locationChangeDone:forDataSource:]):
• LoadProgressMonitor.h:
• LocationChangeHandler.h:

Tests:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

• DumpBackForward/main.m:
• DumpRenderTree/main.m:
• Makefile.am:
• SimpleViewer/DocumentController.h:
• SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController updateStatus]): (-[DocumentController locationChangeStartedForDataSource:]): (-[DocumentController receivedPageTitle:forDataSource:]): (-[DocumentController locationChangeDone:forDataSource:]): (-[DocumentController identifierForInitialRequest:fromDataSource:]): (-[DocumentController resource:willSendRequest:fromDataSource:]):
• SnippetEditor/DataResourceRequest.m: (+[DataProtocolHandler canHandleURL:]): (-[DataProtocolHandler startLoadingWithCacheObject:]):
• SnippetEditor/SnippetController.h:
• SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController _resetViews]): (-[SnippetController locationChangeDone:forDataSource:]):

Mar 3, 2003:

10:50 PM Changeset in webkit [3739] by darin

• 5 edits in trunk/WebKit

WebKit:

Reviewed by Richard.

• simplified the custom user agent and text encoding methods as per request from documentation group

• WebView.subproj/WebController.h: Removed hasCustomUserAgent, resetUserAgent, hasCustomTextEncoding, and resetTextEncoding. Updated comments to indicate what nil means.

• WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Remove assertion, allow nil. (-[WebController customUserAgent]): Remove nil check. (-[WebController setCustomTextEncodingName:]): Remove assertion, allow nil, and do an == check along with the isEqualToString: check to handle the nil case. (-[WebController customTextEncodingName]): Remove nil check.

WebBrowser:

Reviewed by Richard.

• updated for WebKit API changes

• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Use customTextEncodingName of nil to detect lack of custom text encoding, rather than hasCustomTextEncoding. (-[BrowserWindowController changeTextEncoding:]): Use setCustomTextEncodingName:nil to reset custom text encoding rather than resetTextEncoding.

• Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Just use isEqualToString: with the user agent as the responder because it now returns nil when there is none. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Use customUserAgent instead of hasCustomUserAgent, and use setCustomUserAgent:nil instead of resetUserAgent. (-[BrowserDocument validate_resetUserAgent:]): More of the same.

6:09 PM Changeset in webkit [3738] by mjs

• 3 edits in trunk/WebCore

Reviewed by Richard.

• upgrade to new hash function in one spot that I missed:

• kwq/KWQString.mm: (QString::hash): Use spiffy new hash algorithm.

5:29 PM Changeset in webkit [3737] by mjs

• 19 edits in trunk

WebCore:

Reviewed by Darin.

• fixed 3163855 - Need control over certain potential dialogs/sheets

• khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Pass the part to KWQFileButton.
• kwq/KWQFileButton.h:
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Go through the bridge for the view, not the view factory.
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::runJavaScriptAlert): Go through the bridge for the panel, not the view factory. (KWQKHTMLPart::runJavaScriptConfirm): Likewise. (KWQKHTMLPart::runJavaScriptPrompt): Likewise.
• kwq/WebCoreViewFactory.h: Move methods from here...
• kwq/WebCoreBridge.h: ...to here.

WebKit:

Reviewed by Darin.

• fixed 3163855 - Need control over certain potential dialogs/sheets

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Moved here from view factory. Call the bridge instead of popping up the dialog. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): Likewise. (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Likewise. (-[WebBridge fileButton]): Moved here from view factory, so we can pass the bridge to the button. (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): Call the delegate.
• WebCoreSupport.subproj/WebFileButton.h:
• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithBridge:]): New method so this object knows about the bridge. (-[WebFileButton beginSheet]): Instead of popping up the sheet directly, call the bridge (which will call the delegate). (-[WebFileButton chooseFilename:]): Update for the new filename. (-[WebFileButton cancel]): Do nothing.
• WebCoreSupport.subproj/WebViewFactory.m: Removed some methods.
• WebKit.exp: Export .objc_class_WebJavaScriptTextInputPanel (for now).
• WebKit.pbproj/project.pbxproj: Export WebJavaScriptTextInputPanel.h (for now).
• WebView.subproj/WebWindowOperationsDelegate.h: Added new methods.

WebBrowser:

Reviewed by Darin.

Implemented new window delegate methods. Moving the code here is
temporary until we make the window operations delegate an informal
protocol or else provide a default implementation to subclass.

• BrowserWebController.m: (-[BrowserWebController setResizable:]): (-[BrowserWebController runJavaScriptAlertPanelWithMessage:]): (-[BrowserWebController runJavaScriptConfirmPanelWithMessage:]): (-[BrowserWebController runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[BrowserWebController runOpenPanelForFileButtonWithResultListener:]): (-[BrowserWebController openPanelDidEnd:returnCode:contextInfo:]):

5:13 PM Changeset in webkit [3736] by mjs

• 7 edits in trunk

JavaScriptCore:

Reviewed by Trey.

• fixed 3158833 - ebay prefs page is so slow, it seems like a hang.

92% speed improvement on ebay prefs page.
1% speed improvement on js-ibench and js-performance plt suites.

There were a couple of problems with the identifier hash table that
I fixed:

• kjs/identifier.cpp: (void Identifier::remove): Adjust the shrink threshold to avoid constantly growing and shrinking.
• kjs/ustring.cpp: (UString::Rep::computeHash): Use a better hash function that avoids collisions for obvious data sets.

WebFoundation:

Reviewed by Trey.

Updated string hash function to match the new, improved one in
JavaScriptCore.

• Database.subproj/WebLRUFileList.m: (cStringHash):

WebCore:

Reviewed by Trey.

Updated string hash function to match the new, improved one in
JavaScriptCore.

• kwq/KWQCharsets.mm: (encodingNameHash):

4:46 PM Changeset in webkit [3735] by darin

• 6 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3187518 -- REGRESSION: w3c css sample page crashes in cssyyparse

• khtml/css/parser.y: (selector): Added code to handle the case where simple_selector is 0.
• khtml/css/parser.cpp: Regenerated.

• fixed regression I introduced earlier today where ID anchors wouldn't work

• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Check by ID first explicitly before using DOC_ANCHORS.

• WebCore.pbproj/project.pbxproj: Add parser.y to the project to make it easier to open it.

4:39 PM Changeset in webkit [3734] by hyatt

• 6 edits in trunk/WebCore

Fix for 3185852, crash when dynamically inserting rules because
of an unitialized parser variable.

Reviewed by darin

• khtml/css/css_ruleimpl.cpp: (CSSMediaRuleImpl::insertRule):
• khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::insertRule):
• khtml/css/cssparser.cpp: (CSSParser::parseRule):
• khtml/css/cssparser.h:

4:13 PM Changeset in webkit [3733] by hyatt

• 3 edits in trunk/WebCore

Clean up dynamic ID/CLASS setting/removal. Make ID actually
work when set dynamically. Fixes bug 3173050.

Reviewed by john

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):

4:09 PM Changeset in webkit [3732] by darin

• 5 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3154394 -- non-repro nil-dereference in DOM::HTMLFormElementImpl::submit

• khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Add checks for nil like the other methods in this file have.

• fixed some types to remove a bit of unnecessary overhead

• khtml/ecma/kjs_window.h: Change types.
• khtml/ecma/kjs_window.cpp: (Window::installTimeout): Change parameter to UString, not Identifier. (WindowFunc::tryCall): Pass the UString, not Identifier. (ScheduledAction::ScheduledAction): Change parameter to use const QString & to avoid a bit of overhead. (WindowQObject::installTimeout): Change parameter to UString, not Identifier.

3:15 PM Changeset in webkit [3731] by hyatt

• 3 edits in trunk/WebCore

I messed up when i merged Lars' quirks color patch for CSS with
my original patch. I'm now exactly matching Lars' patch, and this
now fixes bug 3181185.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseColor):

2:47 PM Changeset in webkit [3730] by hyatt

• 3 edits in trunk/WebCore

Fix for 3179084. Fix is to just dump our code so that the new
addHTMLColor code kicks in. This code is very close to WinIE
on more-colortests.html.

Reviewed by darin

• ChangeLog:
• kwq/KWQColor.mm: (QColor::setNamedColor):

12:24 PM Changeset in webkit [3729] by hyatt

• 3 edits in trunk/WebCore

Fix for 3178361, <th> don't draw borders. Boneheaded mistake
on my part. Just forgot to include it along with <td> in the
CSS hack for sharing cell rules.

Reviewed by rjw

• khtml/css/cssstyleselector.cpp:

11:56 AM Changeset in webkit [3728] by rjw

• 4 edits in trunk/WebKit

Reviewed by Chris & Darin.

Fixed frameRequiredForMIMEType: to correctly check for BOTH
netscape plugins and cocoa plugins.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]):

Made WebPluginViewFactory.h private (SPI) to provide access to
plugin package keys.

• WebKit.pbproj/project.pbxproj:

11:54 AM Changeset in webkit [3727] by rjw

• 3 edits in trunk/WebCore

Fix build oops from last checkin to khtml/html/html_formimpl.cpp.

Reviewed by trey

• khtml/html/html_formimpl.cpp: (encodeCString):

11:31 AM Changeset in webkit [3726] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3183445 -- hang in QCString::length reloading page with lots of text in textarea

• khtml/html/html_formimpl.cpp: (encodeCString): Compute string length only once outside the loop to avoid being O(n^{2) in the size of the string.}

10:28 AM Changeset in webkit [3725] by darin

• 3 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3180364 -- infinite loop in JavaScript at www.vw.dk (due to document.anchors problem) leads to hang

The underlying problem was that our document.anchors had all the anchors in it.
But here's what the Gecko DOM reference documentation says about document.anchors:
"For reasons of backwards compatibility, the returned set of anchors only contains
those anchors created with the name attribute, not those created with the id attribute."

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): Include only A elements with NAME attributes in the DOC_ANCHORS case. (HTMLCollectionImpl::getItem): Ditto. (HTMLCollectionImpl::getNamedItem): Ditto.

Mar 2, 2003:

10:48 PM Changeset in webkit [3724] by trey

• 3 edits in trunk/WebCore

Use a KWQPopUpButton in place of NSPopUpButton. The only addition is that
it implements the KWQWidgetHolder protocol. This is needed in order to
auto set PopUps during autofill.

Reviewed by Maciej.

• kwq/KWQComboBox.mm: (QComboBox::QComboBox): Make a KWQPopUpButton instead of NSPopUpButton. (QComboBox::~QComboBox): trivial s/KWQPopUpButton/NSPopUpButton/ (QComboBox::insertItem): ditto (QComboBox::sizeHint): ditto (QComboBox::baselinePosition): ditto (QComboBox::clear): ditto (QComboBox::setCurrentItem): ditto (QComboBox::currentItem): ditto (-[KWQPopUpButtonCell widget]): Also implement KWQWidgetHolder (-[KWQPopUpButton widget]): Implement KWQWidgetHolder by calling our cell.

Feb 28, 2003:

11:44 PM Changeset in webkit [3723] by rjw

• 2 edits in trunk/WebKit

Make WebDOM* classes private instead of public. This change
was made before but the project file must have been accidentally
overwritten. Make the WebPlugin* classes private.

Reviewed by me.

• WebKit.pbproj/project.pbxproj:

8:07 PM Changeset in webkit [3722] by darin

• 4 edits in trunk/WebCore

• khtml/css/parser.y: Fixed bad check-in that broke the build in a subtle way.
• khtml/css/parser.cpp: Regenerated.

7:15 PM Changeset in webkit [3721] by trey

• 26 edits in trunk

WebBrowser:

Large wad of autocomplete-autofill implementation.

AutoFill makes its first appearance. Only triggered by debug menu item now,
with cmd-A equivalent.

A new class AutoFillController, maintains per-form state while the user is
working with the form, and holds a bunch of autofill behavior (and probably
more later when I do some code movement after these changes). State we save
includes what fields have been autofilled, and which fields have matches that
came from AB.

Uses of AB data are saved in the FormsCompletion DB for proper LRU wrt ad-hoc
data entries. To do this we save an "ABMarker" array of info instead of the
raw string used for an ad-hoc entry.

A ProxyABProperty is specified in the ABMappings file in the case where multiple
"real" props are specified so that are contatenated. I needed a single prop
name as a reliable key. (example of this: "Name" fields get FirstName+LastName)

FormCompletionController uses a new class AddressBookMatch for elements in the
_matches array that come from AB. The class is basically an open struct around
a handful of fields.

Reviewed by Chris.

• BrowserWebController.m: (-[BrowserWebController _closeDataSources:]): Make call to free up autocomplete state when the controller is going away. (-[BrowserWebController close]): Call _closeDataSources.
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController updateKeyboardLoop]): Coding nit - removed internal return in favor of an else clause. (-[BrowserWindowController validateUserInterfaceItem:]): Validate autofill: selector. (-[BrowserWindowController autoFill:]): Just call FormCompletionController. (-[FormDelegate willSubmitForm:withValues:]): Pass along new form param.
• CompletionController.h: We keep our own _selectedMatchIndex instead of always looking to the tableView's selected row, since the TableView might not exist.
• CompletionController.m: (-[CompletionController initWithSourceField:]): Init _selectedMatchIndex. (-[CompletionController dealloc]): Make sure stuff is freed, since abortCompletion is no longer freeing these things. (-[CompletionController _selectMatchAtIndex:]): Newly factored code. (-[CompletionController _showMatchesWindow:]): Call factored code. (-[CompletionController abortCompletion]): No longer has distinct behavior from _hideMatchesWindow. I was getting screwed by this method freeing state that I would now later need (like the underlying matching object instead of just the string in the TextField), so we just free the stuff in dealloc. (-[CompletionController selectedMatch]): Factor some code here. Use our _selectedMatchIndex instead of the TableView's selected row. (-[CompletionController reflectSelectedRow]): Call factored code. Exposed for subclassing (removed leading _). (-[CompletionController reflectFinalSelectedRow]): Call factored code. Exposed for subclassing (removed leading _). (-[CompletionController completeString:]): Set _selectedMatchIndex after a query. (-[CompletionController leavingFieldReflectsFinalString]): New hook for diff behavior in forms case. (-[CompletionController controlTextDidEndEditing:]): Conditionally put the final string into the field when we leave the field. Off for URLs, on for forms. (-[CompletionController control:textView:doCommandBySelector:]): Get rid of wrap-around when arrow selecting in dropdown. Call factored code. On CR, only reflect the final string whenever are going to send the action. (-[CompletionController goToItemAtRow:]): Don't perform the TextField's action on double click if we don't perform it when you hit return when the dropdown is showing. (-[CompletionController tableViewSelectionDidChange:]): Name change of reflectSelectedRow.
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add menu item.
• FormCompletionController.h:
• FormCompletionController.m: (-[FormCompletionController _cryptData:encode:]): Better error msg. (+[FormCompletionController frame:willSubmitForm:withValues:]): Accept new form arg, and use it to look up info about how we edited the form. For any values being submitted that came from AB, store a marker array in the CompletionDB instead of the raw string. Make sure timestamp is always updated, even if the LRU was in the right order. (+[FormCompletionController autoFillInController:]): Handoff to AutofillController. (+[FormCompletionController clearAutoFillStateForFrame:]): Handoff to AutofillController. (-[FormCompletionController initWithSourceField:frame:]): Use formIsLoginForm: instead of elementIsInLoginForm. Remember field's form. (-[FormCompletionController dealloc:): Free field's form. (-[FormCompletionController controlTextDidChange:]): Clear any record we might have had that we autofilled this field, since it has now been edited since. (-[FormCompletionController _indexOfMarkerInMatches:]): Utility method. Find an ABMarker we previously saved that matches the current match from AB we are about to submit. (+[FormCompletionController _abSingleValue:]): Now a class method for use during autofill. Some tighter ASSERT checking. (+[FormCompletionController _abValuesForProperty:key:label:]): Now a class method for use during autofill. Build an AddressBookMatch object for each match instead of just returning the literal string. (+[FormCompletionController _addABMatchesToArray:forString:fieldName:]): Now a class method for use during autofill, field name is param for same reason. For multi-prop ABMappings, make sure AddressBookMatch ends up with the proxy property. When combining ABMatches with previousData matches, replace any markers of a previous ABMatch with the current one, so as to preserve LRU ordering. Also replace any previous literal string matches that happen to match current AB match. (+[FormCompletionController _addPreviousDataMatchesToArray:forString:frame:fieldName:]): Now a class method for use during autofill, new params for same reason. Allow ABMarkers (which are stored as arrays) to pass from the stored data to our matches array that we build. (+[FormCompletionController _matchesForString:frame:fieldName:]): New a class method for use during autofill. Mostly code factored from queryResultsForString. At the very end of the query, filter out any remaining ABMarkers from the results, since those make no sense to show to a user. (stringFromMatch): Utility to make a string from one of out matches, which can now be a literal string or an AddressBookMatch. (matchComparator): New sort comparator that handles strings and AddressBookMatches. (-[FormCompletionController queryResultsForString:startingMatch:]): Much code factored out. Sort using new comparator. (-[FormCompletionController reflectFinalSelectedRow]): Override to possibly record that we filled a field with AB data. (-[FormCompletionController intermediateMatchingStringForResult]): Use stringFromMatch to interpret AddressBookMatches. (-[FormCompletionController finalMatchingStringForResult]): Use stringFromMatch to interpret AddressBookMatches. (-[FormCompletionController leavingFieldReflectsFinalString]): Return YES for different behavior than URL case. (+[AutoFillController _markAutoFilledColor]): Return shares color. (+[AutoFillController autoFillInController]): Do an autofill. Figure out the form to work on, make an autofiller, cut it loose. (+[AutoFillController autoFillerForFrame:form:create:]): Lookup autofiller. (+[AutoFillController abMatchInFrame:form:fieldName:]): Return any AB match we've stuck into for a particular field during the current editing session with that form. (+[AutoFillController recordABMatch:inFrame:form:fieldName:]): Record any AB match we've stuck into for a particular field during the current editing session with that form. (+[AutoFillController clearAutoFillStateForFrame:]): Release any autofillers used for the given frame. (+[AutoFillController clearAutoFilledView:inFrame:form:]): Clear state for a field when it is manually edited. (-[AutoFillController dealloc]): Free our state. (-[AutoFillController _autoFillWidget:rep:]): Do autofill of one widget. (-[AutoFillController autoFill]): Do autofill of our form. (-[AutoFillController recordABMatch:fieldName:]): Record a field that we've set with an ABMatch. (-[AutoFillController clearView:]): Remove a view from the list we've autofilled. (-[AddressBookMatch initWithValue:property:key:label:]): Trivial class' init. (-[AddressBookMatch dealloc:]): Trivial class' dealloc.
• LocationChangeHandler.m: (-[LocationChangeHandler willCloseLocationForDataSource:]): Implement new callout to free the completion state for that frame.

WebKit:

Various support for autofill/autocomplete.

We receive a form along with the formValues from WC on submit, which we
just pass along to the FormDelegate. As part of this we store the values
and the form together in a new private WebFormState class. Lots of glue
for passing this around instead of just the values dict.

Send willCloseLocationForDataSource when we are finally through with a page.

Reviewed by Darin.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:form:formValues:]): Pass along form along with values (-[WebBridge postWithURL:data:contentType:triggeringEvent:form:formValues:]): Pass along form along with values
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Call frame to send willCloseLocationForDataSource.
• WebView.subproj/WebFormDelegate.h:
• WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:willSubmitForm:withValues:]): Pass form along with values
• WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Pass FormState instead of just values. (-[WebFrame reload]): Pass FormState instead of just values.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: <<prepare-ChangeLog flailed on this file>> Lots of routines were we pass FormState instead of the form values dict -([WebFrame _closeOldDataSources]): New, sends willCloseLocation for whole frame tree. New, trivial, WebFormState class.
• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation formIsLoginForm:]): Changed to take form instead of form field. (-[WebHTMLRepresentation formForElement:]): New, just pass through bridge. (-[WebHTMLRepresentation controlsInForm:]): New, just pass through bridge.
• WebView.subproj/WebLocationChangeDelegate.h: Add willCloseLocationForDataSource.
• WebView.subproj/WebLocationChangeDelegate.m: (-[WebLocationChangeDelegate willCloseLocationForDataSource:]): Default impl.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): Pass FormState instead of just values. (-[WebMainResourceClient resource:willSendRequest:]): Pass FormState instead of just values.

WebCore:

More support for autofill, autocomplete.

Pass the form element along with the values to WK when submitting.

isLoginForm looks for a single plain text field along with password fields, so as not to match registration forms.

Added means to find the "current" form on a page.

Added means to return the whole set of controls on a form.

Reviewed by Darin.

• khtml/html/html_elementimpl.h: Added isGenericFormElement().
• khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isLoginForm): See above. (HTMLFormElementImpl::submit): Also register form when registering values, so it will be sent over bridge.
• kwq/KWQKHTMLPart.h: New ivar to save form along with form values to be submitted.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Init _formAboutToBeSubmitted ivar. (KWQKHTMLPart::~KWQKHTMLPart): Free _formAboutToBeSubmitted ivar. (KWQKHTMLPart::openURL): Pass form to bridge along with values. (KWQKHTMLPart::openURLRequest): Pass form to bridge along with values. (scanForForm): Helper function to scan forward in the DOM for a form. (KWQKHTMLPart::currentForm): Returns current form. (KWQKHTMLPart::clearRecordedFormValues): Clear _formAboutToBeSubmitted. (KWQKHTMLPart::recordFormValue): Record _formAboutToBeSubmitted too. (KWQKHTMLPart::submitForm): Pass form to bridge along with values. (KWQKHTMLPart::urlSelected): Pass form to bridge along with values.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Pass form to bridge along with values.
• kwq/KWQTextField.mm: (-[KWQTextField setStringValue:]): Call textChanged so the changes actually make it to khtml.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (viewForElement): New helper. (formElementFromDOMElement): New helper. (-[WebCoreBridge formIsLoginForm:]): Changed API to operate on a form instead of a field. (-[WebCoreBridge currentForm]): New method, described above. (-[WebCoreBridge controlsInForm:]): New method, described above.
• kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode isEqual:]): Implement this to == compare the element we contain. (-[WebCoreDOMNode hash]): Implement to hash element ptr we contain.

6:45 PM Changeset in webkit [3720] by mjs

• 10 edits in trunk

WebCore:

Reviewed by Trey.

• fixed 3180170 - filepile.com does not work correctly

I fixed this by making referrer work correctly for targetted
cross-frame and cross-window links. It is still not working right
for JavaScript window.open though.

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Add some FIXMEs about not handling referrer right.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Pass referrer. (KWQKHTMLPart::openURLRequest): Pass referrer. (KWQKHTMLPart::submitForm): Pass referrer. (KWQKHTMLPart::urlSelected): Pass referrer.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Pass referrer.
• kwq/WebCoreBridge.h: Ad referrer argument to loadURL:

WebKit:

Reviewed by Trey.

• fixed 3180170 - filepile.com does not work correctly

I fixed this by making referrer work correctly for targetted
cross-frame and cross-window links. It is still not working right
for JavaScript window.open though.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Set referrer. (-[WebBridge loadURL:referrer:reload:triggeringEvent:formValues:]): Pass referrer along to frame. (-[WebBridge postWithURL:referrer:data:contentType:triggeringEvent:formValues:]): Likewise.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): Pass referrer. (-[WebFrame _loadURL:referrer:loadType:triggeringEvent:formValues:]): Use passed-in referrer (link could have been clicked in another frame). (-[WebFrame _loadURL:intoChild:]): Pass referrer. (-[WebFrame _postWithURL:referrer:data:contentType:triggeringEvent:formValues:]): Use passed-in referrer.

3:19 PM Changeset in webkit [3719] by hyatt

• 3 edits in trunk/WebCore

Exclude <BR>s from the text-dec check. Really fixes 3185121.

Reviewed by john

• khtml/rendering/render_line.cpp: (shouldDrawDecoration):

3:10 PM Changeset in webkit [3718] by darin

• 5 edits in trunk/WebCore

Reviewed by Dave.

• fixed some storage leaks; this code is still leaking when we run cvs-base

• khtml/css/parser.y: (import): Use the new maybe_media_list (ported from KDE), and delete the media list if the current item we are parsing is not a style sheet. (maybe_media_list): Added. (ported from KDE). (media_list): Added error case so we don't leak in that case (ported from KDE). (media): Use media_list instead of media_list2 (ported from KDE). (selector_list): Added error case so we don't leak in that case (ported from KDE). (selector): Added error case so we don't leak in that case (ported from KDE). (simple_selector): Added nil-checking (ported from KDE). (element_name): Use 0xFFFF instead of -1 (ported from KDE). (specifier_list): Added error case so we don't leak in that case (ported from KDE). (declaration): Delete the expr if we don't use it because property is 0. (expr): Added error case so we don't leak in that case (ported from KDE).

• khtml/css/cssparser.cpp: (CSSParser::parseSheet): Delete the rule in case one was created. (CSSParser::parseRule): Zero out the rule after extracting it to return. (CSSParser::parseValue): Delete the rule in case one was created. (CSSParser::parseDeclaration): Delete the rule in case one was created.

• khtml/css/parser.cpp: Regenerated.

2:07 PM Changeset in webkit [3717] by darin

• 4 edits in trunk/WebKit

Reviewed by Trey.

• fixed 3183575 -- <​https://sbcreg.sbcglobal.net> casuses infinite refresh & crash

The page had history.forward(1) which was causing us to reload.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]): Handle edge cases by checking backListCount and forwardListCount at this level. Be sure to do nothing when we are already on the right page.

• History.subproj/WebBackForwardList.h: Added forwardListCount, updated comment for entryAtIndex.
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList forwardListCount]): Added. (-[WebBackForwardList entryAtIndex:]): Return nil for out of range indices.

2:06 PM Changeset in webkit [3716] by hyatt

• 3 edits in trunk/WebCore

Fix for text-dec regression, 3185121.

Reviewed by john

• khtml/rendering/render_line.cpp: (shouldDrawDecoration):

3:15 AM Changeset in webkit [3715] by mjs

• 5 edits in trunk/WebKit

WebKit:

Reviewed by Richard.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge window]): Avoid calling removed call.
• WebView.subproj/WebView.m: Remove override of window method.
• WebView.subproj/WebWindowOperationsDelegate.h: Adjust for new API.

WebBrowser:

Reviewed by Richard.

Minimal implementation of new window operations delegate API.

• BrowserWebController.m: (-[BrowserWebController closeWindow]): (-[BrowserWebController focusWindow]): (-[BrowserWebController unfocusWindow]): (-[BrowserWebController firstResponderInWindow]): (-[BrowserWebController makeFirstResponderInWindow:]): (-[BrowserWebController isResizable]): (-[BrowserWebController setResizbale:]): (-[BrowserWebController setFrame:]): (-[BrowserWebController frame]):

Feb 27, 2003:

12:08 PM Changeset in webkit [3714]

• 3 copies in tags/Safari-64

This commit was manufactured by cvs2svn to create tag 'Safari-64'.

12:08 PM Changeset in webkit [3713] by sheridan

• 8 edits in trunk

needed to bump build # to 64

11:10 AM Changeset in webkit [3712] by sheridan

• 3 edits in trunk

starting 64 train

10:58 AM Changeset in webkit [3711]

• 3 copies in tags/Safari-63

This commit was manufactured by cvs2svn to create tag 'Safari-63'.

10:58 AM Changeset in webkit [3710] by sheridan

• 8 edits in trunk

63 stamp

Feb 26, 2003:

5:15 PM Changeset in webkit [3709] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

• fixed 3156705 - REGRESSION: javascript menus improperly placed at umich.edu store

• kjs/nodes.cpp: (StatListNode::execute): If the first statement's completion is not normal, return immediately.

3:38 PM Changeset in webkit [3708] by hyatt

• 4 edits in trunk/WebCore

Additional cleanup. Don't need the arg to be a reference param
any more.

Reviewed by mjs

• khtml/rendering/render_object.cpp: (RenderObject::getTextDecorationColors):
• khtml/rendering/render_object.h:

3:22 PM Changeset in webkit [3707] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Dave.

• fixed reproducible hang at ​http://asp.eltonsoft.dk/cast/get.asp?cat=Quicktime

This was a set of mutually recursive frameset pages. This allows
the number of frames to grow huge, which kills both WebCore and
WebKit, so I added a hard limit of 200 total frames per page.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLIFrameElementImpl::attach):
• khtml/html/html_baseimpl.h:
• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::incrementFrameCount): (KHTMLPart::decrementFrameCount): (KHTMLPart::topLevelFrameCount):
• khtml/khtml_part.h:

WebKit:

Reviewed by Dave.

• fixed reproducible hang at ​http://asp.eltonsoft.dk/cast/get.asp?cat=Quicktime

WebKit's processing time was O(N^{3) in the number of
frames. Improved it to O(N}2) by storing frame pointer directly in
WebDataSource instead of linear scan. Could still be improved more.

• WebView.subproj/WebDataSource.m: (-[WebDataSource webFrame]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setWebFrame:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): (-[WebFrame _setDataSource:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _clearProvisionalDataSource]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formValues:]): (-[WebFrame _loadDataSource:withLoadType:formValues:]): (-[WebFrame _setProvisionalDataSource:]):

3:10 PM Changeset in webkit [3706] by hyatt

• 6 edits in trunk/WebCore

Fix numerous regressions with text-decoration in quirks mode and
also fixed a bug where text-decoration:none is not being honored
on links.

Reviewed by mjs

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_object.cpp: (RenderObject::getTextDecorationColors):
• khtml/rendering/render_object.h:
• khtml/rendering/render_text.cpp: (TextRun::paintDecoration):

1:39 PM Changeset in webkit [3705] by hyatt

• 4 edits in trunk/WebCore

Fix for 3179109. containingBlock() had a big old bug in it.
For ABSOLUTE positioned elements, it would return inline relative
positioned parents (when it should only be returning blocks).

Reviewed by john

• khtml/rendering/render_object.cpp: (RenderObject::containingBlock):

12:59 PM Changeset in webkit [3704] by rjw

• 8 edits in trunk/WebKit

Fixed 3102760. Removed WebDocumentDragSettings from API.

Reviewed by Chris.

• WebView.subproj/WebDocument.h:
• WebView.subproj/WebHTMLView.h:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebImageView.h:
• WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): (-[WebImageView mouseDragged:]):
• WebView.subproj/WebTextView.h:
• WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): (-[WebTextView layout]):

12:25 AM Changeset in webkit [3703] by hyatt

• 5 edits in trunk/WebCore

Fix for findNextLayer problems. There was nothing wrong with
findNextLayer per se... it was just getting called *way* more
often than it needed to be.

Fixes two bugs, 3159866 and 3168815.

Reviewed by darin

• khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_object.cpp: (addLayers): (RenderObject::addLayers):
• khtml/rendering/render_object.h:

Feb 25, 2003:

10:18 PM Changeset in webkit [3702] by darin

• 4 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3177139 -- REGRESSION: tiny buttons with no text on dbaron test page

This is actually a shortcoming in XML support. The reason it seemed like a regression
is that this page was parsed as HTML before we had the XML support.

• khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): As the HTML tokenizer/parser does, call init() on all DOM tree elements before calling attach(). The KHTML guys want to get rid of init(), but until they do, we need the same thing here as in the HTML version. (XMLHandler::startCDATA): Ditto. (XMLHandler::enterText): Ditto.

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Fix an obvious editing error that would lead to a second attach.

7:52 PM Changeset in webkit [3701] by hyatt

• 3 edits in trunk/WebCore

Revert one of my optimizations. It was bogus. You can't use
the parsed value of "inherit."

Fixes versiontracker. Bug #3178204

Reviewed by mjs

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls):

6:38 PM Changeset in webkit [3700] by hyatt

• 3 edits in trunk/WebCore

reverseRuns was buggy and crashing. 3182658.

Reviewed by mjs

• khtml/rendering/bidi.cpp:

5:46 PM Changeset in webkit [3699] by hyatt

• 3 edits in trunk/WebCore

Regression caused by my inclusion of inline flows in the bidi
iteration. These flows are always empty and should be skipped
if found at the start of a line.

The bug # is 3175670.

Reviewed by NOBODY (OOPS!).

• khtml/rendering/bidi.cpp:

4:56 PM Changeset in webkit [3698] by hyatt

• 2 edits in trunk/WebKit

Fix for bug #3181249. Ensure the padding argument gets passed
through properly (instead of just passing 0).

Reviewed by darin

• WebCoreSupport.subproj/WebTextRenderer.m:

4:34 PM Changeset in webkit [3697] by hyatt

• 3 edits in trunk/WebCore

Fix for bug 3166276. <tt> uses wrong font size inside a table.
Make sure logical font values like "medium" don't set the "size
specified" bit on the font, so that the generic family change
code will get activated.

Reviewed by darin

• khtml/css/cssstyleselector.cpp:

2:28 PM Changeset in webkit [3696] by darin

• 7 edits in trunk/WebCore

Reviewed by me, changes by Dave.

• fixed 3181790 -- REGRESSION: TextRun objects of length 0 or with just the character '\n' leak

• khtml/rendering/render_text.cpp: (RenderText::position): Destroy the passed-in TextRun if it's the kind that's not needed, rather than just returning.

• fixed 3181794 -- REGRESSION: objects created by RenderObject::createInlineBox leak

• khtml/rendering/render_box.cpp: (RenderBox::position): Only do work for replaced elements, and for those elements, destroy the passed-in InlineBox. Dave says this is not the real solution, but it does plug the leak.

• khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): Call through to the inherited createInlineBox for all replaced elements. This code was making the wrong kind of InlineBox for replaced elements.

• removed Id cvs magic string which causes big headaches in generated files

• khtml/css/parser.cpp: Removed Id cvs magic string.
• khtml/css/parser.y: Removed Id cvs magic string.

12:00 PM Changeset in webkit [3695] by hyatt

• 43 edits
  9 adds in trunk/WebCore

The new CSS1 parser, implementation of attr(), improvement of
the content property, impl of the :target selector, and new
dotted/dashed line drawing code for borders.

Reviewed by darin/gramps

• ForwardingHeaders/css/css_base.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/Makefile.am:
• khtml/css/css_base.cpp: Added. (StyleBaseImpl::checkLoaded): (StyleBaseImpl::stylesheet): (StyleBaseImpl::baseURL): (StyleBaseImpl::setParsedValue): (StyleListImpl::~StyleListImpl): (CSSSelector::print): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::operator == ): (CSSSelector::selectorText):
• khtml/css/css_base.h: Added.
• khtml/css/css_ruleimpl.cpp: (CSSRuleImpl::parentRule): (CSSImportRuleImpl::CSSImportRuleImpl): (CSSImportRuleImpl::~CSSImportRuleImpl): (CSSImportRuleImpl::setStyleSheet): (CSSImportRuleImpl::init): (CSSMediaRuleImpl::CSSMediaRuleImpl): (CSSMediaRuleImpl::append): (CSSMediaRuleImpl::insertRule): (CSSStyleRuleImpl::setDeclaration): (CSSStyleRuleImpl::setNonCSSHints):
• khtml/css/css_ruleimpl.h:
• khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl): (CSSStyleSheetImpl::insertRule): (CSSStyleSheetImpl::cssRules): (CSSStyleSheetImpl::parseString): (MediaListImpl::deleteMedium):
• khtml/css/css_stylesheetimpl.h:
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::getPropertyValue): (CSSStyleDeclarationImpl::get4Values): (CSSStyleDeclarationImpl::getShortHandValue): (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::getPropertyPriority): (CSSStyleDeclarationImpl::setProperty): (CSSStyleDeclarationImpl::setLengthProperty): (CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (CSSPrimitiveValueImpl::cleanup): (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat): (CSSPrimitiveValueImpl::setFloatValue): (CSSPrimitiveValueImpl::cssText): (FontFamilyValueImpl::FontFamilyValueImpl): (FontValueImpl::FontValueImpl): (FontValueImpl::~FontValueImpl):
• khtml/css/css_valueimpl.h:
• khtml/css/cssparser.cpp: (qFatal): (ValueList::ValueList): (ValueList::~ValueList): (ValueList::addValue): (CSSParser::CSSParser): (CSSParser::~CSSParser): (CSSParser::parseSheet): (CSSParser::parseRule): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::addProperty): (CSSParser::createStyleDeclaration): (CSSParser::clearProperties): (CSSParser::document): (validUnit): (CSSParser::parseShortHand): (CSSParser::parse4Values): (CSSParser::parseContent): (CSSParser::parseShape): (CSSParser::parseFont): (CSSParser::parseFontFamily): (parseColor): (CSSParser::parseColor): (yyerror): (DOM::CSSParser::lex): (toHex): (DOM::CSSParser::text):
• khtml/css/cssparser.h:
• khtml/css/cssproperties.c: (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/css/html4.css:
• khtml/css/parser.cpp: Added. (DOM::getPropertyID): (getValueID): (cssyyerror): (cssyylex): (yy_memcpy):
• khtml/css/parser.h: Added.
• khtml/css/parser.y: Added.
• khtml/css/quirks.css: Added.
• khtml/css/tokenizer.cpp: Added.
• khtml/css/tokenizer.flex: Added.
• khtml/dom/css_value.h:
• khtml/dom/html_element.cpp:
• khtml/ecma/kjs_css.cpp:
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
• khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLHRElementImpl::attach): (HTMLParagraphElementImpl::parseAttribute):
• khtml/html/html_elementimpl.cpp: (isHexDigit): (toHex): (HTMLElementImpl::addHTMLColor):
• khtml/html/html_elementimpl.h:
• khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): (HTMLTableElementImpl::attach): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute):
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
• khtml/misc/helper.h:
• khtml/rendering/render_body.cpp: (RenderBody::setStyle):
• khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
• khtml/rendering/render_style.cpp: (RenderStyle::setContent):
• khtml/rendering/render_style.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setFocusNode): (DocumentImpl::setCSSTarget): (DocumentImpl::getCSSTarget):
• khtml/xml/dom_docimpl.h:
• kwq/KWQChar.mm: (QChar::upper):
• kwq/KWQColor.h:
• kwq/KWQKStandardDirs.mm: (locate):
• kwq/KWQPainter.mm: (QPainter::drawLine):
• kwq/KWQString.h:

11:47 AM Changeset in webkit [3694] by sullivan

• 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3181290 -- need call to reload all bookmarks from disk,
for synching's sake.

I ended up not adding a new call, but making the existing loadBookmarkGroup
work better when called after the initial load. It wasn't doing anything wrong
before; it just wasn't passing along enough information to clients to enable
them to do the right thing.

Reviewed by Trey

• Bookmarks.subproj/WebBookmarkGroup.h: new extern NSStrings WebBookmarksWillBeReloadedNotification and WebBookmarksWereReloadedNotification

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _sendNotification:forBookmark:children:]): soften assert so it doesn't fire on the new cases.

(-[WebBookmarkGroup _bookmarksWillBeReloaded]):
send WebBookmarksWillBeReloadedNotification
(-[WebBookmarkGroup _bookmarksWereReloaded]):
send WebBookmarksWereReloadedNotification

(-[WebBookmarkGroup _loadBookmarkGroupGuts]):
bracket the load with the new notification-sending calls

• WebKit.exp: add the two new extern NSStrings

WebBrowser:

WebBrowser part of fix for 3181290 -- need call to reload all
bookmarks from disk, for synching's sake

Reviewed by Trey

• BookmarksController.m: (-[BookmarksController _receivedBookmarksWereReloadedNotification:]): new method; parallel to _receivedBookmarksChangedNotification. Unlike that method, this one does not trigger a save-bookmars-to-disk. (Also this one updates the top-level data structures.) (-[BookmarksController awakeFromNib]): register for WebBookmarksWereReloadedNotifications from our group.
• BookmarksViewController.m: (-[BookmarksViewController updateUIForChangeToBookmark:includingChildren:]): Changed title from ...andChildren:. Used to take array of children, now just takes a boolean. The array was being converted into a boolean immediately, and rather than add yet another caller that created an array for the sole purpose of passing it to this method, I changed the method to take the boolean and updated all callers. (-[BookmarksViewController bookmarksChanged:]): handle reload case by getting top changed bookmark from bookmark group that is the notification object (-[BookmarksViewController awakeFromNib]): register for WebBookmarksWereReloadedNotification from our bookmark group (-[BookmarksViewController newSourceFolder]): update for parameter change in updateUIForChangeToBookmark:includingChildren: (-[BookmarksViewController undoNewBookmark:]): ditto (-[BookmarksViewController redoNewBookmark:]): ditto (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]): ditto (-[BookmarksViewController changeTitleForBookmark:to:]): ditto (-[BookmarksViewController changeAddressForBookmark:to:]): ditto

• URLCompletionController.m: (+[URLCompletionController _loadDB]): removed false part of comment (+[URLCompletionController _registerForNotifications]): register for WebBookmarksWereReloadedNotification, call _reloadDB

10:18 AM Changeset in webkit [3693] by darin

• 4 edits in trunk/WebKit

WebKit:

Reviewed by John.

• fixed 3176962 -- add KHTML somewhere in the user agent string

• English.lproj/StringsNotToBeLocalized.txt: Change "(like Gecko)" to "(KHTML, like Gecko)".
• WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Ditto.

WebBrowser:

Reviewed by John.

• fixed 3176962 -- add KHTML somewhere in the user agent string

• Debug/DebugUtilities.m: (-[DebugUtilities userAgentSubmenuItem]): Change "(like Gecko)" to "(KHTML, like Gecko)".

Feb 24, 2003:

3:09 PM Changeset in webkit [3692] by mjs

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed 3167642 - crash in renderArena.

• khtml/html/html_documentimpl.h:
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl): Added new processingLoadEvent bool. (HTMLDocumentImpl::close): Guard against re-entering the load event handler.

10:33 AM Changeset in webkit [3691] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3179059 -- CSS1: capitalized letters should remain capitalized when text-transform: capitalize is applied

• khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::capitalize): Capitalize the first letters of words, but don't make any letters lowercase.

Feb 23, 2003:

3:24 PM Changeset in webkit [3690] by darin

• 3 edits in trunk/WebCore

Tests:

Reviewed by Maciej.

• added tests for URLs affected by bug 3179181, ones with a "?" or "#" character right after the host name, with no intervening "/"
• turned off tests that aren't passing right now, so make check can be used pass/fail easy to turn tests back on by editing test.list

• TestURLs.h: Added URLs "​http://www.apple.com?email=darin@apple.com" and "​http://my.site.com#fragment".
• kde/kurl-test.chk: Added test results for the two new URLs.

• WebFoundation-Misc/ifnsstringextensions-test.chk: Updated results for _web_splitAtNonDateCommas, which now splits only at commas followed by spaces.

• test.list: Disabled ifnsthreadextensions-test, ifnsurlextensions-test, and ifurlparsing-test, since they aren't passing right now. We can turn them back on when we get them back in shape.

WebCore:

Reviewed by Maciej.

• fixed 3179181 -- KURL won't accept URLs with a query part and no / separating host name from path

• kwq/KWQKURL.mm: (KURL::parse): Allow any path segment end character to end the host part of a URL, rather than allowing only a "/".

Feb 21, 2003:

7:10 PM Changeset in webkit [3689] by mjs

• 3 edits in trunk/WebCore

Back out last change, mondo layout regressions.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):

6:30 PM Changeset in webkit [3688] by mjs

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3167642 - crash in renderArena.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Clear the tokenizer early to avoid re-entering the onload handler - this was causing a massive overload of frames which finally caused a crash.

4:04 PM Changeset in webkit [3687] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed a problem that was causing layout tests to give inconsistent results

• kwq/KWQPixmap.mm: (QPixmap::size): Handle case of nil image so we don't use the uninitialized result of dispatching a method to a structure-returning function. (QPixmap::rect): Ditto. (QPixmap::width): Ditto. (QPixmap::height): Ditto.

3:14 PM Changeset in webkit [3686] by darin

• 5 edits in trunk/WebCore

Reviewed by Maciej.

• Made it possible to run the layout tests in a Deployment version

• kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove #ifndef NDEBUG.
• kwq/KWQRenderTreeDebug.h: Remove #ifndef NDEBUG.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge renderTreeAsExternalRepresentation]): Remove #ifndef NDEBUG.

3:14 PM Changeset in webkit [3685] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• fixed 3142355 -- nil-deref in CFTimeZoneCopyAbbreviation

The real problem wasn't with the current time zone, but with the UTC time zone.
The poor sod had a broken /usr/share/zoneinfo directory, with a 0-byte-long UTC file.

• kjs/date_object.cpp: (UTCTimeZone): Use CFTimeZoneCreateWithTimeIntervalFromGMT(NULL, 0.0) to get the universal time zone instead of getting it by name.

8:35 AM Changeset in webkit [3684] by darin

• 3 edits in trunk/WebCore

• kwq/KWQRenderTreeDebug.cpp: (write): Add missing spaces in render tree dump format.

Feb 20, 2003:

4:28 PM Changeset in webkit [3683] by mjs

• 4 edits in trunk/WebCore

Revert Dave's patch to these files, since it turned out to cause
layout regressions.

• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
• khtml/rendering/render_object.cpp: (RenderObject::setLayouted): (RenderObject::container):

2:33 PM Changeset in webkit [3682] by mjs

• 3 edits in trunk/WebCore

Reviewed by Darin Adler.

• fixed 3173276 - hang in kjs string at iteslj.org page

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::addPending): Leave whitespace unmolested inside <script>, so that literal tabs in strings come through as tabs, not spaces.

2:19 PM Changeset in webkit [3681] by cblu

• 3 edits in trunk/WebKit

WebKit:

Added _web_superviewOfClass:stoppingAtClass:. Climbs up hierarchy and returns nil when stoppingAtClass is hit.

Reviewed by darin.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:stoppingAtClass:]): (-[NSView _web_superviewOfClass:]):

WebBrowser:

Fixed: 3177369 - titles of inactive tabs should appear in the title bar when you roll over the tab

Reviewed by darin.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument dealloc]): release _mouseOverWebController (-[BrowserDocument displayName]): use _mouseOverWebController if presnt (-[BrowserDocument setMouseOverWebController:]): new, sets _mouseOverWebController
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController tabBarView:mouseMovedOverButtonForTabViewItem:]): new, called when mouse is moved over/off a tab (-[BrowserWindowController synchronizeWindowTitleWithDocumentNameNow]): new, calls synchronizeWindowTitleWithDocumentName (-[BrowserWindowController synchronizeWindowTitleWithDocumentNameSoon]): new, calls synchronizeWindowTitleWithDocumentNameNow later
• FavoriteButton.m: (-[FavoriteButton _setAttributes]): new, sets attributes (-[FavoriteButton initWithFrame:]): call _setAttributes (-[FavoriteButton awakeFromNib]): call _setAttributes
• RolloverImageButton.m: (-[RolloverImageButton _setAttributes]): new, sets attributes (-[RolloverImageButton initWithFrame:]): call _setAttributes (-[RolloverImageButton awakeFromNib]): call _setAttributes
• RolloverTrackingButton.h:
• RolloverTrackingButton.m: (-[RolloverTrackingButton mouseEnteredOrExited:]): new, does nothing, overridden be subclasses (-[RolloverTrackingButton setRedrawOnMouseEnteredAndExited:]): new (-[RolloverTrackingButton redrawOnMouseEnteredAndExited]): new (-[RolloverTrackingButton updateMouseIsOver]): check the window and tracking rect (-[RolloverTrackingButton removeTrackingRect]): always call updateMouseIsOver (-[RolloverTrackingButton updateTrackingRect]): always call updateMouseIsOver
• TabBarView.h:
• TabBarView.m: (-[TabBarView _layOutButtons]): call updateMouseOverTabButton (-[TabBarView dealloc]): release _mouseOverTabButton (-[TabBarView _setMouseOverTabButton:]): set _mouseOverTabButton, call delegate (-[TabBarView updateMouseOverTabButton]): call updateMouseOverTabButton
• TabButton.h:
• TabButton.m: call updateMouseOverTabButton

2:05 PM Changeset in webkit [3680] by trey

• 1 edit in trunk/WebKit/WebView.subproj/WebHTMLViewPrivate.m

Just a comment marking a bug I found. 3178518

2:04 PM Changeset in webkit [3679] by trey

• 1 edit in trunk/WebCore/kwq/KWQTextField.mm

Just a comment marking a bug I found. 3178518.

9:11 AM Changeset in webkit [3678] by darin

• 4 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3177310 -- REGRESSION: "serif" mapped to "fixed"

Fixed a typo where the serif method was returning the fixed font name.
Also made this class use inlining for almost everything -- yields a miniscule
improvement in code size and speed, and increases brevity.

• kwq/KWQKHTMLSettings.h: Moved almost everything here.
• kwq/KWQKHTMLSettings.mm: Moved almost everything out of here.

8:40 AM Changeset in webkit [3677]

• 1 copy
  64 deletes in branches/WebFoundation-SDK-branch

This commit was manufactured by cvs2svn to create branch
'WebFoundation-SDK-branch'.

8:40 AM Changeset in webkit [3676]

• 1 copy
  64 deletes in tags/WEBFOUNDATION_SDK_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'WEBFOUNDATION_SDK_BRANCH_ANCHOR'.

8:40 AM Changeset in webkit [3675] by kocienda

• 66 edits in trunk/WebKit

Tools:

Reviewed by David

Modified to use new WebFoundation API.

• WebDiskCacheInspector/Controller.m: (-[Controller setCachePath:]): (-[Controller loadFileList:]): (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):
• WebDiskCacheInspector/WebDiskCacheInspector.pbproj/project.pbxproj:

Tests:

Reviewed by David

Modified to use new WebFoundation API. Most of the changes were in
class names and method names only.

An exception is SnippetEditor/DataResourceRequest.m. This class
has been updated to use the new API for WebProtocol implementors.

• CookieManager/wkcookiemanager-test.m: (main):
• DumpBackForward/main.m: (dumpBackForward): (-[CheapWindowOpsDelegate createWindowWithRequest:]):
• DumpRenderTree/main.m: (dumpRenderTree):
• SnippetEditor/DataResourceRequest.h:
• SnippetEditor/DataResourceRequest.m: (+[DataProtocolHandler load]): (+[DataProtocolHandler canonicalURLForURL:]): (-[DataProtocolHandler startLoadingWithCacheObject:]): (-[DataProtocolHandler stopLoading]):
• SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]):
• WebFoundation-CacheLoader/NeverExpiresTest.m: (-[NeverExpiresTest testNeverExpires]):

WebFoundation:

Reviewed by David.

The big WebFoundation API change.

This check in delivers a nice new interface for WebProtocol developers,
simplifies the interaction between protocols and WebResource objects,
cleans up reponse creation and response callback delivery, and includes
numerous other small changes and improvements that helped to fix on the
final API.

There were also many name changes to files, the big changes can be
described as follows:

• "ProtocolHandler" changes to "Protocol"
• Usages of "Resource" removed from request and reponse classes.
• "WebResourceHandle" and its variants now use just "WebResource".

These bugs gets fixed as aresult of this check in.

Radar 3081798 (MASTER: WebFoundation API/SPI complete)
Radar 3078996 (error codes should be named in a way that makes them unlikely to

be used in the wrong domain)

Radar 3151249 (<WebFoundation/WebResourceLoad.h> is missing)
Radar 3163688 (API on WebResourceLoad needs to be sanitized for public consumption)
Radar 3164090 (Fix on final SPI for WebFoundation protocol handler developers)
Radar 3164091 (Consider merging WebResourceLoad and WebResourceHandle classes)

Note that since I touched just about every file in the framework, I did not call
things out individually.

WebKit:

Reviewed by David

Modified to use new WebFoundation API. Though there seem to be
many changes, they are all "uninteresting" in that the changes
only moved code to use new method and class names.

• Downloads.subproj/WebDownload.h:
• Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:delegate:]): (-[WebDownload _initWithLoadingHandle:request:response:delegate:]): (-[WebDownload createFileIfNecessary]):
• Downloads.subproj/WebDownloadPrivate.h:
• Misc.subproj/WebIconLoader.h:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resourceDidFinishLoading:]): (-[WebIconLoader resource:willSendRequest:]): (-[WebIconLoader resource:didReceiveResponse:]): (-[WebIconLoader resource:didReceiveData:]): (-[WebIconLoader resource:didFailLoadingWithError:]):
• Misc.subproj/WebResourceResponseExtras.h:
• Misc.subproj/WebResourceResponseExtras.m: (-[WebHTTPResponse suggestedFilenameForSaving]):
• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebPluginRequest initWithRequest:frame:notifyData:]): (-[WebPluginRequest request]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream resource:didReceiveResponse:]): (-[WebNetscapePluginStream resource:didReceiveData:]): (-[WebNetscapePluginStream resourceDidFinishLoading:]): (-[WebNetscapePluginStream resource:didFailLoadingWithError:]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge defersLoading]): (-[WebBridge setDefersLoading:]): (-[WebBridge loadEmptyDocumentSynchronously]):
• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient resource:willSendRequest:]): (-[WebSubresourceClient resource:didReceiveResponse:]): (-[WebSubresourceClient resource:didReceiveData:]): (-[WebSubresourceClient resourceDidFinishLoading:]): (-[WebSubresourceClient resource:didFailLoadingWithError:]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelledError]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]):
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:toDirectory:]): (-[WebController defersCallbacks]): (-[WebController setDefersCallbacks:]): (-[WebController _openNewWindowWithRequest:behind:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _addSubresourceClient:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setURL:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _setResponse:]): (-[WebDataSource _commitIfReady:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _originalRequest]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]): (-[WebDataSource _addResponse:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate savePathForResponse:andRequest:]): (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _opened]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:loadType:formValues:]): (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formValues:andCall:withSelector:]): (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formValues:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:loadType:triggeringEvent:formValues:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formValues:]): (-[WebFrame _downloadRequest:toDirectory:]):
• WebView.subproj/WebHTMLRepresentation.m:
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formValues:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]): (-[WebMainResourceClient startLoading:]):
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebTextRepresentation.m:
• WebView.subproj/WebTextView.m:
• WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]):
• WebView.subproj/WebViewPrivate.m:
• WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by David

Modified to use new WebFoundation API. Though there seem to be
many changes, they are all "uninteresting" in that the changes
only moved code to use new method and class names.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToRequest:]):
• BrowserDocumentController.h:
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:]): (-[BrowserWebController createWindowWithRequest:]): (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController savePathForResponse:andRequest:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController goToRequest:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
• BugReportController.h:
• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]): (-[BugReportController resource:didReceiveResponse:]): (-[BugReportController resource:didReceiveData:]): (-[BugReportController resourceDidFinishLoading:]): (-[BugReportController resource:didFailLoadingWithError:]):
• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
• Debug/DebugUtilities.m: (initProtocolHandlers): (-[BrowserDocument unregisterAllProtocolHandlers]): (-[BrowserDocument reregisterAllProtocolHandlers]): (-[BrowserDocument toggleAboutProtocolHandler:]): (-[BrowserDocument toggleFileProtocolHandler:]): (-[BrowserDocument toggleCFNetworkHTTPProtocolHandler:]): (-[BrowserDocument toggleSimpleHTTPProtocolHandler:]):
• Debug/SnippetController.m: (-[SnippetController load]):
• DownloadMonitor.m: (-[DownloadMonitor identifierForInitialRequest:fromDataSource:]): (-[DownloadMonitor resource:willSendRequest:fromDataSource:]): (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry _setRequest:]): (+[DownloadProgressEntry entryWithDictionary:]): (-[DownloadProgressEntry stop]):
• FrameProgressEntry.m: (-[FrameProgressEntry stage]):
• HTMLSourceDocument.m:
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor resource:didReceiveResponse:fromDataSource:]):
• LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:]): (-[LocationChangeHandler displayLocationChangeError:]):
• LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]):
• ResourceProgressEntry.m: (-[ResourceProgressEntry stage]): (-[ResourceProgressEntry statusString]):
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):

Feb 19, 2003:

7:41 PM Changeset in webkit [3674] by hyatt

• 4 edits in trunk/WebCore

Update layers to not fix their positions during setLayouted.
Inline container() within render_object.cpp so setLayouted can
use it inline.

Reviewed by mjs

• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
• khtml/rendering/render_object.cpp: (RenderObject::setLayouted): (RenderObject::container):

5:27 PM Changeset in webkit [3673] by hyatt

• 5 edits in trunk/WebCore

Just chain BidiRuns using an internal next ptr and dump the
use of QPtrList (which has to malloc internal nodes to wrap
each run).

Reviewed by darin (reverseRuns reviewed by mjs)

• khtml/rendering/bidi.cpp:
• khtml/rendering/bidi.h:
• khtml/rendering/render_block.h:

3:22 PM Changeset in webkit [3672] by hyatt

• 5 edits in trunk/WebCore

Make the BidiIterator midpoints use an array instead of a list.

Reviewed by kocienda

• khtml/rendering/bidi.h
• khtml/rendering/bidi.cpp:
• khtml/rendering/render_block.h:

Feb 18, 2003:

7:02 PM Changeset in webkit [3671] by mjs

• 8 edits in trunk

WebCore:

Reviewed by Chris.

Merged changes from Safari-58-1-branch.

2003-02-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Trey.

• WebCore.pbproj/project.pbxproj: Include /System/Library/PrivateFrameworks.

WebKit:

Reviewed by Chris.

Merged changes from Safari-58-1-branch.

2003-02-11 Richard Williamson <​rjw@apple.com>

Add import of CGFontCache.h, which is no longer
included by CoreGraphicsPrivate.h.

Reviewed by Vicki.

• WebCoreSupport.subproj/WebTextRendererFactory.m:

2003-02-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• WebCoreSupport.subproj/WebTextRenderer.m: Change (void ) cast to (void *) for compatibility with the latest Panther.

2003-02-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Trey.

• WebKit.pbproj/project.pbxproj: Add /System/Library/PrivateFrameworks

4:34 PM Changeset in webkit [3670] by trey

• 5 edits in trunk/WebCore

3171982 - REGRESSION: onClick handlers run twice when button pressed (DSLReports.com forums)

My earlier changes added the codepath by which we let khtmlview fully process
a mouse up after a widget has done it's tracking, which leads to the second
onClick call. Presumably that path does not exist in the native KDE case.
The change below reduces the impact of my hack, whereby instead of fully posting
a fake mouseup, we just note that the mouse has done up at the end of mousedown
handling, and clear the mousePressed state (state I also added).

Reviewed by Darin.

• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Look for a current mouseUp at the end of dispatching the mouse down.
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Don't post a phony mouse up from here. (KWQKHTMLPart::lastEventIsMouseUp): Utility routine to test for mouseUp.

3:25 PM Changeset in webkit [3669] by sheridan

• 3 edits in trunk

opening tree for Safari-63

3:23 PM Changeset in webkit [3668]

• 3 copies in tags/Safari-62

This commit was manufactured by cvs2svn to create tag 'Safari-62'.

3:23 PM Changeset in webkit [3667] by sheridan

• 3 edits in trunk

fixing typo

3:18 PM Changeset in webkit [3666] by sheridan

• 8 edits in trunk

Safari-62 for the trunk

2:18 PM Changeset in webkit [3665]

• 31 copies
  1 delete in tags/Safari-61

This commit was manufactured by cvs2svn to create tag 'Safari-61'.

2:18 PM Changeset in webkit [3664] by sheridan

• 9 edits in branches/Safari-0-8-2-branch

Safari-61 on the branch

2:06 PM Changeset in webkit [3663] by hyatt

• 2 edits in trunk/WebCore

Fix for 3176102, bad table cell regression. I was adding in
random properties for cells. Eep.

Also patched table element to add in the inherit property using
CSS_VAL_INHERIT instead of the string "inherit" (faster).

Reviewed by gramps

• khtml/css/cssstyleselector.cpp:
• khtml/html/html_tableimpl.cpp

2:03 PM Changeset in webkit [3662] by hyatt

• 4 edits in trunk/WebCore

Fix for 3176102, bad table cell regression. I was adding in
random properties for cells. Eep.

Reviewed by gramps

• khtml/css/cssstyleselector.cpp:

12:13 PM Changeset in webkit [3661] by hyatt

• 3 edits in trunk/WebCore

Fix for 3171795, dotted borders drawn incorrectly. Picked this
gem up from the KHTML trunk.

Reviewed by darin

• khtml/rendering/render_object.cpp: (RenderObject::drawBorder):

11:18 AM Changeset in webkit [3660] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Trey and Ken.

• fixed 3142355 -- nil-deref in CFTimeZoneCopyAbbreviation

Although I can't reproduce this bug, it seems that it's caused by CFTimeZoneCopyDefault returning NULL.
I'm almost certain that the UTC time zone will be created successfully in this case, so I'll just use that.

• kjs/date_object.cpp: (UTCTimeZone): Added. Gets the UTC time zone (once in a global). (CopyLocalTimeZone): Added. Gets the local time zone, but falls back to UTC. (gmtimeUsingCF): Use UTCTimeZone. (localtimeUsingCF): Use CopyLocalTimeZone. (mktimeUsingCF): Use CopyLocalTimeZone. (timegmUsingCF): Use UTCTimeZone.

Feb 17, 2003:

4:13 PM Changeset in webkit [3659] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3174332 -- REGRESSION: bad initial layout due to empty QFontMetrics

• khtml/rendering/render_html.cpp: (RenderHtml::setStyle): Don't set the style's to display:BLOCK if it's display:NONE. This prevents us from modifying the special FOUC style among other things.

• unrelated code cleanup

• khtml/html/html_baseimpl.cpp: Moved code around that was grouped badly.

2:19 PM Changeset in webkit [3658] by hyatt

• 3 edits in trunk/WebCore

Missed another "Almost Strict" spot.

Reviewed by kocienda

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):

12:25 PM Changeset in webkit [3657] by hyatt

• 7 edits in trunk/WebCore

Fix for 3% improvement on cached cvs-base. Make cells share the
declarations set up by the table (add these decls to the table
once instead of to every cell).

Reviewed by darin

• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::~HTMLTableElementImpl): (HTMLTableElementImpl::createSharedCellDecls): (HTMLTableCellElementImpl::getAdditionalStyleDecls): (HTMLTableCellElementImpl::attach):
• khtml/html/html_tableimpl.h:
• khtml/xml/dom_elementimpl.h:

11:22 AM Changeset in webkit [3656] by trey

• 1 edit in trunk/WebCore/khtml/khtmlview.cpp

Cleanup comment turd left in by mistake

11:00 AM Changeset in webkit [3655] by kocienda

• 22 edits in trunk/WebKit

Reviewed by Trey

Rolled in documentation changes from Peter Kelly, our tech writer.

• History.subproj/WebBackForwardList.h
• History.subproj/WebHistory.h
• Misc.subproj/WebKitErrors.h
• Misc.subproj/WebResourceResponseExtras.h
• Panels.subproj/WebStandardPanels.h
• Plugins.subproj/WebPluginError.h
• WebView.subproj/WebContextMenuDelegate.h
• WebView.subproj/WebController.h
• WebView.subproj/WebControllerPolicyDelegate.h
• WebView.subproj/WebDataSource.h
• WebView.subproj/WebDefaultPolicyDelegate.h
• WebView.subproj/WebDocument.h
• WebView.subproj/WebFrame.h
• WebView.subproj/WebPreferences.h
• WebView.subproj/WebResourceLoadDelegate.h
• WebView.subproj/WebView.h
• WebView.subproj/WebWindowOperationsDelegate.h

10:54 AM Changeset in webkit [3654] by trey

• 2 edits in trunk/WebKit

2943514 hide the cursor when using the arrow keys to scroll

Reviewed by Darin

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Hide that cursor.

10:53 AM Changeset in webkit [3653] by trey

• 4 edits in trunk/WebCore

2938062 Mouse cursor does not change to link cursor over non-button form submission controls

Reviewed by Darin

• khtml/khtmlview.cpp: (isSubmitImage): Helper function to ID submit buttons with images. (KHTMLView::viewportMouseMoveEvent): Set cursor for submit buttons with images.
• kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Simplify previously written casting goop.

9:21 AM Changeset in webkit [3652] by cblu

• 4 edits in trunk/WebKit

WebKit:

Added debug method that can be used inside of gdb to examine an image. Needed this many times.

Reviewed by darin.

• Misc.subproj/WebNSImageExtras.h:
• Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):

WebBrowser:

Implemented the tab bar with tabs and all.

Reviewed by darin.

• BarBackground.m: moved private appkit declarations to BrowserNSViewExtras and BrowserNSWindowExtras so they can be used by other classes
• BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): obey the x origin when centering text
• BrowserNSViewExtras.h:
• BrowserNSViewExtras.m: (-[NSView shouldDrawBackgroundTheSneakyPrivateNSWindowWay]): moved method from BarBackground so it can be used by other classes
• BrowserNSWindowExtras.h: put private appkit declarations here
• English.lproj/Browser.nib:
• EtchedStringButtonCell.h: Added.
• EtchedStringButtonCell.m: Added. Factored out from FavoriteButtonCell so TabButtonCell can use the same functionality (+[EtchedStringButtonCell font]): (+[EtchedStringButtonCell bottomColorForDarkText]): (+[EtchedStringButtonCell topColorForDarkText]): (+[EtchedStringButtonCell bottomColorForLightText]): (+[EtchedStringButtonCell topColorForLightText]): (-[EtchedStringButtonCell textRectForFrame:]): (-[EtchedStringButtonCell drawInteriorWithFrame:inView:]): (-[EtchedStringButtonCell setTextCenterTruncated:]): (-[EtchedStringButtonCell isTextCenterTruncated]): (-[EtchedStringButtonCell setTextCentered:]): (-[EtchedStringButtonCell isTextCentered]): (-[EtchedStringButtonCell setDrawsLightText:]): (-[EtchedStringButtonCell drawsLightText]):
• FavoriteButton.m: (-[FavoriteButton setBookmark:]):
• FavoriteButtonCell.h:
• FavoriteButtonCell.m: made subclass of EtchedStringButtonCell (+[FavoriteButtonCell updateCellForButton:]): (-[FavoriteButtonCell textRectForFrame:]): (-[FavoriteButtonCell imageRectForFrame:]): (-[FavoriteButtonCell drawInteriorWithFrame:inView:]):
• Resources/Images/TabBevel_Caps.tif: Added.
• Resources/Images/TabBevel_Middle.tif: Added.
• Resources/Images/TabClose_Back.tif: Added.
• Resources/Images/TabClose_Back_Pressed.tif: Added.
• Resources/Images/TabClose_Back_Rollover.tif: Added.
• Resources/Images/TabClose_Front.tif: Added.
• Resources/Images/TabClose_Front_Pressed.tif: Added.
• Resources/Images/TabClose_Front_Rollover.tif: Added.
• Resources/Images/TabMask_Caps.tif: Added.
• Resources/Images/TabMask_Middle.tif: Added.
• TabBarView.h:
• TabBarView.m: (-[TabBarView scaledAndTexturedWindowBackgroundImage]): image of textured background used by tab buttons (-[TabBarView windowBackgroundImage]): ditto (-[TabBarView _addTabButtonWithTabViewItem:]): links tab button to tab item (-[TabBarView _removeTabButton:]): removes tab button (-[TabBarView _layOutButtons]): lays out tab buttons (-[TabBarView _bringSelectedTabToFront:]): brings tab button of tab item to front (-[TabBarView awakeFromNib]): set things up (-[TabBarView dealloc]): release things (-[TabBarView _drawSeparatorAtXOrigin:]): draws separator (-[TabBarView drawRect:]): draw separators (-[TabBarView setFrameSize:]): call _layOutButtons (-[TabBarView bringTabToFront:]): brings tab item of tab button to front (-[TabBarView closeTab:]): closes the clicked tab (-[TabBarView tabView:shouldSelectTabViewItem:]): forward to delegate, return YES otherwise (-[TabBarView tabView:willSelectTabViewItem:]): deselect current tab, forward to delegate (-[TabBarView tabView:didSelectTabViewItem:]): select current tab, forward to delegate (-[TabBarView tabViewDidChangeNumberOfTabViewItems:]): call _layOutButtons, forward to delegate
• TabButton.h: Added.
• TabButton.m: Added. (+[TabButton initialize]): set the cell (+[TabButton _loadImages]): load images (-[TabButton _setCloseButtonImages:]): set close images (-[TabButton initWithFrame:tabViewItem:]): set attributes (-[TabButton dealloc]): release things (-[TabButton drawRect:]): drag textured background obeying mask (-[TabButton mouseDownCanMoveWindow]): return NO (-[TabButton setState:]): set the close button images appropriately (-[TabButton setCloseAction:]): set the action of the close button (-[TabButton tabViewItem]): getter (-[TabButton height]): returns the height given the height of the mask image (-[TabButton closeTab:]): call the close action on the target of the button
• TabButtonCell.h: Added.
• TabButtonCell.m: Added. (+[TabButtonCell bottomColorForLightText]): override (+[TabButtonCell topColorForLightText]): override (-[TabButtonCell textRectForFrame:]): override (-[TabButtonCell setTextInsetX:]): sets the X inset
• TabViewItemWithButton.h: Added.
• TabViewItemWithButton.m: Added. (-[TabViewItemWithButton dealloc]): (-[TabViewItemWithButton setLabel:]): set the title on the button (-[TabViewItemWithButton setButton:]): set the button (-[TabViewItemWithButton button]): returns the button
• WebBrowser.pbproj/project.pbxproj:

Feb 16, 2003:

11:39 PM Changeset in webkit [3651] by hyatt

• 3 edits in trunk/WebCore

Fix "Almost Strict" mode to not match @konq-quirks.

Reviewed by kocienda

• ChangeLog:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyleSelector):

Feb 15, 2003:

11:00 PM Changeset in webkit [3650] by darin

• 2 edits in trunk/WebKit

• English.lproj/Localizable.strings: Regenerated.

Feb 14, 2003:

11:44 AM Changeset in webkit [3649] by hyatt

• 2 edits in trunk/WebKit

Patch to the drawLine function for the inline box model landing.

Reviewed by kocienda

• WebCoreSupport.subproj/WebTextRenderer.m:

11:43 AM Changeset in webkit [3648] by hyatt

• 28 edits in trunk/WebCore

Make the inline box model live. Borders/backgrounds and text
decorations have been rewritten.

Also fixed a bug with clip rects. They didn't include borders.

Reviewed by kocienda

• khtml/css/cssstyleselector.cpp:
• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
• khtml/rendering/bidi.cpp:
• khtml/rendering/font.cpp:
• khtml/rendering/font.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended): (RenderBox::getClipRect): (RenderBox::position):
• khtml/rendering/render_box.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_inline.cpp: (RenderInline::paintObject): (RenderInline::width): (RenderInline::height): (RenderInline::offsetLeft): (RenderInline::offsetTop): (RenderInline::nodeAtPoint):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren): (InlineFlowBox::paintBackgroundAndBorder): (shouldDrawDecoration): (InlineFlowBox::paintDecorations):
• khtml/rendering/render_line.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::lineHeight): (RenderObject::getTextDecorationColors):
• khtml/rendering/render_object.h:
• khtml/rendering/render_root.cpp: (enclosingPositionedRect):
• khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
• khtml/rendering/render_style.h:
• khtml/rendering/render_table.cpp: (RenderTableCell::repaintRectangle):
• khtml/rendering/render_text.cpp: (TextRun::paintDecoration): (TextRun::checkSelectionPoint): (RenderText::nodeAtPoint): (RenderText::cursorPos): (RenderText::absolutePosition): (RenderText::paintObject): (RenderText::paint): (RenderText::position):
• khtml/rendering/render_text.h:
• kwq/KWQPainter.h:
• kwq/KWQPainter.mm: (QPainter::drawLineForText):
• kwq/WebCoreTextRenderer.h:

Feb 13, 2003:

5:15 PM Changeset in webkit [3647] by trey

• 19 edits in trunk

WebBrowser:

First checkin for working forms autocomplete.

The feature is disabled by default, but can be turned on (persistently) via
the debug menu. Note that your data is not encrypted on disk yet.

Aside from the plain old implementation work, there is some refactoring done
with CompletionController to allow URLCompletionController and FormCompletionController
to share more code.

There is also the addition of the libCdsaCrypt, which is not yet used, but will be
soon for encyption. It's a thin layer over some Security API's to make them usable
for simple applications, from developer.apple.com.

Reviewed by Chris

• CompletionController.h: Added _ignoreTextDidChange. Added new methods to be implemented by subclasses to facilitate factoring.
• CompletionController.m: (-[CompletionController _sendMessageIgnoringTextChanges:]): New wrapper to send a message with _ignoreTextDidChange temporarily set. This prevents recursion into our completion code. (-[CompletionController reflectSelectedRow]): Impl factored up from URLCompCtrl, calls new methods to get into from subclasses. (-[CompletionController reflectFinalSelectedRow]): Ditto. (-[CompletionController executeQuery]): Comment fix. (-[CompletionController completeString:]): Use _sendMessageIgnoringTextChanges (-[CompletionController queryString]): New method to be overridden. (-[CompletionController intermediateMatchingStringAtIndex:]): Ditto. (-[CompletionController finalMatchingStringAtIndex:]): Ditto. (-[CompletionController controlTextDidChange:]): Obey _ignoreTextDidChange flag. (-[CompletionController control:textView:doCommandBySelector:]): Use _sendMessageIgnoringTextChanges. (-[CompletionController goToItemAtRow:]): Ditto (-[CompletionController tableViewSelectionDidChange:]): Ditto (-[CompletionController tableView:objectValueForTableColumn:row:]): use new overridable method.
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add item for disabling feature. (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleFormsAutoComplete:]):
• Defaults.plist: New key.
• FormCompletionController.h:
• FormCompletionController.m: All new code. (completionDBPath): Get db path. (domainFromFrame): Utility routine. (+[FormCompletionController formCompletionEnabled]): Return pref value. (+[FormCompletionController setFormCompletionEnabled:]): Set pref value. (-[FormCompletionController initWithSourceField:frame:]): Setup state for doing completion. (-[FormCompletionController dealloc]): (+[FormCompletionController _loadCompletionDB]): Load db. (+[FormCompletionController _saveCompletionDB:]): Save db. (+[FormCompletionController _saveCompletionDBSoon]): Queue up a db save. (+[FormCompletionController _appWillTerminate:]): Save db. (+[FormCompletionController clearFormAutoCompleteDatabase]): Nuke db. (+[FormCompletionController frame:willSubmitFormWithValues:]): Save new form values in db. (-[FormCompletionController executeQuery]): Match string to db.
• PreferenceKeys.h: New key.
• URLCompletionController.m: (-[URLCompletionController executeQuery]): Comment. (-[URLCompletionController intermediateMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class. (-[URLCompletionController finalMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class.
• WebBrowser.pbproj/project.pbxproj: Add new security sample code.
• libCdsaCrypt.h: Added.
• libCdsaCrypt.m: Added.

WebKit:

First checkin for working forms autocomplete.

This level mostly just has glue to go from app to WC through the bridge.
WebHTMLReo exports some new SPI to get the element of a view, and then to get
some HTML-level properties of that element.

Reviewed by Chris

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _saveBookmarkGroupGuts]): Don't dump entire bookmark dict in the log.
• WebKit.exp: New class used by app, objc_class_name_WebHTMLRepresentation.
• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementForView:]): New SPI. (-[WebHTMLRepresentation elementDoesAutoComplete:]): New SPI. (-[WebHTMLRepresentation elementIsInLoginForm:]): New SPI.

WebCore:

First checkin for working forms autocomplete.

This level has some new support routines.

Reviewed by Chris

• khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isLoginForm): New, returns if a form is for login.
• khtml/html/html_formimpl.h:
• kwq/KWQDOMNode.cpp: (idFromNode): New, helper routine to allow us to use the id() function from ObjC.
• kwq/KWQDOMNode.h:
• kwq/KWQTextArea.h: Adopt KWQWidgetHolder protocol.
• kwq/KWQTextArea.mm: (-[KWQTextArea widget]): Adopt KWQWidgetHolder protocol. (-[KWQTextAreaTextView widget]): Adopt KWQWidgetHolder protocol.
• kwq/KWQTextField.h: Adopt KWQWidgetHolder protocol.
• kwq/KWQTextField.mm: (-[KWQTextField widget]): Adopt KWQWidgetHolder protocol. (-[KWQSecureTextField widget]): Adopt KWQWidgetHolder protocol.
• kwq/KWQView.h: Define KWQWidgetHolder protocol
• kwq/KWQView.mm: (-[KWQView widget]): Adopt KWQWidgetHolder protocol.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): New method. (inputElementFromDOMElement): Common code for next two methods. (-[WebCoreBridge elementIsInLoginForm:]): New method. (-[WebCoreBridge elementDoesAutoComplete:]): New method.

2:40 PM Changeset in webkit [3646] by darin

• 8 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3162806 -- REGRESSION: handle == h assertion when clicking headphone link at cnn.com

• khtml/ecma/kjs_window.cpp: (HistoryFunc::tryCall): Instead of trying to actually do the history navigation here, call the new KHTMLPart::scheduleHistoryNavigation.

• khtml/khtml_part.cpp: (KHTMLPart::init): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::openURL): Ditto. (KHTMLPart::createJavaContext): Ditto. (KHTMLPart::clear): Also initialize m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::checkCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::scheduleRedirection): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress, and set m_scheduledRedirection to redirectionScheduled. (KHTMLPart::scheduleHistoryNavigation): Added. Does the same thing as scheduleRedirection, but always uses a delay of 0, sets m_scheduledRedirection to historyNavigationScheduled, and sets m_scheduledHistoryNavigationSteps. (KHTMLPart::slotRedirect): Add an if statement that does the history navigation. The code is moved here from HistoryFunc::tryCall. Also set m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::urlSelected): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::requestObject): Ditto. (KHTMLPart::submitForm): Ditto. (KHTMLPart::slotParentCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::setZoomFactor): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields.

• khtml/khtml_part.h: Added scheduleHistoryNavigation.
• khtml/khtmlpart_p.h: Added RedirectionScheduled enum. Added more #if !APPLE_CHANGES to leave out a bunch more fields we don't use. Added m_scheduledRedirection and m_scheduledHistoryNavigationSteps.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Check and don't do anything if the timer was being used for history redirection.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check m_scheduledRedirection instead of m_redirectURL to figure out if there is a redirection in progress. Not strictly necessary since we really don't care about the history case here, but consistent with the rest.

12:02 PM Changeset in webkit [3645] by sheridan

• 3 edits in trunk

updating versions to 61u ... trunk had gotten out of sync because of the branch

10:54 AM Changeset in webkit [3644] by cblu

• 18 edits in trunk

WebCore:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForFrameName): call findOrCreateFrameNamed
• kwq/WebCoreBridge.h: fixed method name for findOrCreateFrameNamed

WebKit:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (categoryInitialize): Error should be WebErrorDescriptionCannotFindApplicationForURL not WebErrorDescriptionCannotNotFindApplicationForURL
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFrameNamed
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFrameNamed
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge findOrCreateFrameNamed:]): call findOrCreateFrameNamed
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFrameNamed:]): fixed name
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): use WebErrorDescriptionCannotFindApplicationForURL
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): use WebErrorDescriptionCannotFindApplicationForURL
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView setAllowsScrolling:]): cast to WebDynamicScrollBarsView (-[WebView allowsScrolling]): cast to WebDynamicScrollBarsView (-[WebView frameScrollView]): return NSScrollView
• WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): cast to WebDynamicScrollBarsView

Feb 12, 2003:

5:29 PM Changeset in webkit [3643] by cblu

• 6 edits
  1 add in trunk/WebKit

• Moved the WebKit error registration out of WebView because apps that use WebKit but not WebView might need to use WebKit errors (like my test app for WebDownload).
• Added file close and file move errors (needed for WebDownload).

Reviewed by kocienda.

• English.lproj/Localizable.strings: Localize file close and file move errors.
• Misc.subproj/WebKitErrors.h: Added file close and file move errors.
• Misc.subproj/WebKitErrors.m: Added. (+[WebError initialize]): register the errors here
• WebKit.exp: Export the WebDownload class (forgot to do this earlier).
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebView.m: don't register the errors here

3:44 PM Changeset in webkit [3642] by darin

• 11 edits in trunk

WebCore:

Reviewed by Ken.

• fixed 3158484 -- after submission failure, submitting a second time doesn't work

• kwq/KWQKHTMLPart.h: Added didNotOpenURL method. Changed _formSubmittedFlag bool into _submittedFormURL string.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): No need to initialize string. (KWQKHTMLPart::didNotOpenURL): If the form we submitted failed, then forget about it. (KWQKHTMLPart::submitForm): Only do the protection against multiple submissions if the URL is the same. (KWQKHTMLPart::setView): Nuke the submitted URL here where we used to nuke the flag.

• kwq/WebCoreBridge.h: Added didNotOpenURL: method to be called by WebKit.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge didNotOpenURL:]): Forward the call to the part.

WebKit:

Reviewed by Ken.

• fixed 3158484 -- after submission failure, submitting a second time doesn't work

• WebView.subproj/WebDataSourcePrivate.h: Added _receivedError:complete: method.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]): Added, parallel to _receivedData and _finishedLoading. Calls the new bridge method didNotOpenURL: for cases where we fail before committing (which calls openURL). Note that we can't use our own _bridge method because it asserts that we have committed to prevent accidental misuse. Also make the call on the controller that used to be done directly by the client.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:complete:]): Call the new -[WebDataSource _receivedError:complete:] rather than calling the controller directly.

2:18 PM Changeset in webkit [3641] by darin

• 3 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3162786 -- hang with large amounts of text in textarea

• kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Rewrite to not use RangeOfParagraph to avoid n^{2 algorithm. Also made small changes to similar functions so they look similar, and got rid of an int/unsigned mismatch in a case where the value is guaranteed to be positive.}

12:11 PM Changeset in webkit [3640] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3145442 -- toString(16) is not working, causing non-ASCII characters in mac.com homepage to be munged

• kjs/number_object.cpp: (NumberProtoFuncImp::call): Add handling for toString with a radix other than 10 passed as an argument.

Feb 11, 2003:

7:08 PM Changeset in webkit [3639]

• 8 copies
  6 deletes in tags/WebKit-58~5

This commit was manufactured by cvs2svn to create tag 'WebKit-58~5'.

7:08 PM Changeset in webkit [3638] by rjw

• 2 edits in branches/Safari-58-1-branch/WebKit

* empty log message *

7:01 PM Changeset in webkit [3637] by rjw

• 2 edits in branches/Safari-58-1-branch/WebKit

Add import of CGFontCache.h, which is no longer
included by CoreGraphicsPrivate.h.

Reviewed by Vicki.

• WebCoreSupport.subproj/WebTextRendererFactory.m:

5:13 PM Changeset in webkit [3636]

• 7 copies
  6 deletes in tags/Safari-58~4

This commit was manufactured by cvs2svn to create tag 'Safari-58~4'.

5:13 PM Changeset in webkit [3635] by mjs

• 3 edits in branches/Safari-58-1-branch/WebKit

Reviewed by Darin.

• WebCoreSupport.subproj/WebTextRenderer.m: Change (void ) cast to (void *) for compatibility with the latest Panther.

5:07 PM Changeset in webkit [3634] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

4:55 PM Changeset in webkit [3633] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3170403 -- nil-dereference in addEventListener

• khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Check getJSEventListener result for nil.
• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check getJSEventListener result for nil.

3:10 PM Changeset in webkit [3632] by darin

• 2 edits in trunk/WebKit

Reviewed by Ed.

• applied a fixed version of Ed Voas's change to make plug-ins position correctly inside Carbon metal windows; should have no effect on Safari

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Don't assume that the Cocoa concept of the content view matches up with the Carbon concept of where the port is positioned. Instead, convert coordinates to border view coordinates, then back to Carbon content coordinates by using the delta between the port bounds and the port's pixmap bounds. Bug 3160710 was caused by an older version of this patch implicitly assuming the port bounds always had (0,0) for top left.

11:24 AM Changeset in webkit [3631]

• 17 copies
  2 deletes in tags/Safari-58~3

This commit was manufactured by cvs2svn to create tag 'Safari-58~3'.

11:24 AM Changeset in webkit [3630] by mjs

• 2 edits in branches/Safari-58-1-branch/WebKit

Reviewed by Trey.

• WebKit.pbproj/project.pbxproj: Add /System/Library/PrivateFrameworks

11:23 AM Changeset in webkit [3629] by mjs

• 3 edits in branches/Safari-58-1-branch/WebCore

Reviewed by Trey.

• WebCore.pbproj/project.pbxproj: Include /System/Library/PrivateFrameworks.

10:53 AM Changeset in webkit [3628] by trey

• 8 edits in trunk

JavaScriptCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

• JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

• WebFoundation.pbproj/project.pbxproj:

WebCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

• WebCore.pbproj/project.pbxproj:

WebKit:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

• WebKit.pbproj/project.pbxproj:

Feb 10, 2003:

5:59 PM Changeset in webkit [3627] by hyatt

• 23 edits
  2 adds in trunk/WebCore

Inline box model landing, stage 1. Doesn't really change
much of anything visually yet. Just builds a bunch of boxes
and positions them, but those boxes aren't used yet.

Also fixing repaint() to understand not to dirty outside
overflow:hidden clipped ancestors.

Fixed two table bugs in table painting as well.

Reviewed by kocienda

• WebCore.pbproj/project.pbxproj:
• khtml/rendering/bidi.cpp:
• khtml/rendering/bidi.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::position): (RenderBox::repaintRectangle):
• khtml/rendering/render_box.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::addChild): (RenderFlow::deleteLineBoxes): (RenderFlow::detach): (RenderFlow::createInlineBox):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_image.cpp: (RenderImage::paintObject):
• khtml/rendering/render_inline.cpp:
• khtml/rendering/render_inline.h:
• khtml/rendering/render_line.cpp: Added. (InlineBox::detach): (throw): (InlineBox::operator delete): (InlineFlowBox::marginLeft): (InlineFlowBox::marginRight): (InlineFlowBox::marginBorderPaddingLeft): (InlineFlowBox::marginBorderPaddingRight): (InlineFlowBox::getFlowSpacingWidth): (InlineFlowBox::nextOnLineExists): (InlineFlowBox::prevOnLineExists): (InlineFlowBox::onEndChain): (InlineFlowBox::determineSpacingForFlowBoxes): (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically):
• khtml/rendering/render_line.h: Added.
• khtml/rendering/render_object.cpp: (RenderObject::createInlineBox):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp:
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_table.cpp: (RenderTableSection::paint): (RenderTableCell::repaintRectangle): (RenderTableCell::paint):
• khtml/rendering/render_table.h:
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint): (RenderText::paintObject): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::metrics):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.h:

5:21 PM Changeset in webkit [3626]

• 21 copies
  1 delete in tags/Safari-58~2

This commit was manufactured by cvs2svn to create tag 'Safari-58~2'.

5:21 PM Changeset in webkit [3625] by mjs

• 2 edits in branches/Safari-58-1-branch/WebKit

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

5:17 PM Changeset in webkit [3624] by mjs

• 6 edits in branches/Safari-58-1-branch

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

4:09 PM Changeset in webkit [3623] by cblu

• 3 edits in trunk/WebKit

Added HeaderDoc comments for WebDownload and WebPluginError.

Reviewed by rjw.

• Downloads.subproj/WebDownload.h:
• Plugins.subproj/WebPluginError.h:

3:03 PM Changeset in webkit [3622] by trey

• 7 edits
  1 add in trunk/WebKit

Following the recent fix for ensuring that we always have a FormDelegate,
when we need a default policy delegate we use a shared one instead of allocing
a new one each time, which then would leak.

This included getting rid of the initWithWebController: method in the
WebDefaultPolicyDelegate API. The arg was not used.

Reviewed by Richard

• WebKit.pbproj/project.pbxproj: new private header
• WebView.subproj/WebController.m: (-[WebController policyDelegate]): use shared delegate if none set
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate _sharedWebPolicyDelegate]): return shared instance
• WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Added.
• WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): Trivial renaming of static.

2:26 PM Changeset in webkit [3621] by darin

• 13 edits in trunk/WebCore

Reviewed by Richard.

• fixed 3124596 -- failures handling URLs with non-ASCII characters in them

• khtml/xml/dom_docimpl.h: Add an m_decoder field.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_decoder to 0. (DocumentImpl::completeURL): Pass the QTextCodec from m_decoder to KURL if present.

• khtml/khtml_part.cpp: (KHTMLPart::begin): Set the decoder on the document when we make the document if we have a decoder. (KHTMLPart::write): Set the decoder on the document when we make the decoder if we have a document. (KHTMLPart::completeURL): Remove APPLE_CHANGES; we handle the encoding in the document.

• kwq/KWQKURL.h: Removed "encoding hint" parameters. Add a QTextCodec parameter to the relative URL constructor, which is the one used when we deal with links on a page.
• kwq/KWQKURL.mm: (KURL::KURL): Decode the relative string based on the QTextCodec parameter.

• kwq/KWQString.h: Added isAllASCII, good for detecting when it's safe to use latin1() or ascii() without worrying about character sets.
• kwq/KWQString.mm: (QString::isAllASCII): Added.

• WebCore-tests.exp: Updated for changes in KURL API.
• WebCore-combined.exp: Regenerated.

• other changes

• khtml/rendering/render_table.cpp: (RenderTableCell::setWidth): Add an assertion that will help us notice future overflow issues.

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Rolled out the APPLE_CHANGES here that were intended to cope with the lack of window.history, which we now have. While KHTML's rule may not be the correct rule, this will now work as well in Safari as in Konqueror.

1:47 PM Changeset in webkit [3620] by rjw

• 2 edits in trunk/WebKit

Update API issues document.

Reviewed by me.

• API-Issues.rtf:

1:13 PM Changeset in webkit [3619]

• 21 copies
  1 delete in tags/Safari-58~1

This commit was manufactured by cvs2svn to create tag 'Safari-58~1'.

1:13 PM Changeset in webkit [3618] by mjs

• 11 edits in branches/Safari-58-1-branch

top level:

Reviewed by Maciej.

• remove leftover bits of NO_LICENSE

• acconfig.h: Remove NO_LICENSE.
• configure.in: Remove all the NO_LICENSE-related bits.

Tools:

• Ahem.ttf: Added.
• Makefile.am: Install Ahem.ttf into the user's home directory if it's not already in there.

JavaScriptCore:

Reviewed by John.

• kjs/scope_chain.cpp: Rolled out the fix to bug 3137084. It caused a massive storage leak, and probably didn't even fix the bug.

Tests:

Another example application. Illustrates how to get document source,
and how to convert HTML to an NSAttributedString, among other things.
Need to add comments and cleanly format code.

NOTE: The two example apps won't compile until I checkin some post 0.8.2 WebKit API tweaks
tomorrow.

Reviewed by me.

• ChangeLog:
• SnippetEditor/ApplicationController.h: Added.
• SnippetEditor/ApplicationController.m: Added. (-[ApplicationController mainWebView]): (-[ApplicationController validateUserInterfaceItem:]): (-[ApplicationController new:]):
• SnippetEditor/English.lproj/MainMenu.nib: Added.
• SnippetEditor/English.lproj/Snippet.nib: Added.
• SnippetEditor/SnippetController.h: Added.
• SnippetEditor/SnippetController.m: Added. (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController windowNibName]): (-[SnippetController awakeFromNib]): (-[SnippetController loadURL:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController setTitle:]): (-[SnippetController updateFromText:]): (-[SnippetController updateFromURL:]): (-[SnippetController mainDataSource]): (-[SnippetLocationChangeDelegate initWithController:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]): (-[AttributedStringView dealloc]): (-[AttributedStringView setAttributedString:]): (-[AttributedStringView drawRect:]):
• SnippetEditor/SnippetEditor.pbproj/project.pbxproj: Added.
• SnippetEditor/SnippetEditor_Prefix.h: Added.
• SnippetEditor/main.m: Added. (main):

Tweaked to reflect updated API.

• SimpleViewer/DocumentController.h:
• SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[ResourceLoadDelegate dealloc]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

WebFoundation:

Merged changes from trunk.

2003-02-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• fixed 3167156 - WebFoundation-58.1: Partial downloads do not work
• fixed 3048004 - "simple" loader should send headers passed in as part of request (CFNetwork one already does)

• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Add the rest of the headers that are specially handled. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Add custom headers that do not conflict with standard ones (and add FIXME to note that they should actually win).

WebCore:

Rolled over changes from the main trunk.

2003-02-03 David Hyatt <​hyatt@apple.com>

Fix for 3163603, livepage.apple.com repaints entire page.

Reviewed by darin.

• khtml/rendering/render_object.cpp: (RenderObject::setStyle):

WebKit:

Rolled over changes from the trunk.

2003-02-03 Chris Blumenberg <​cblu@apple.com>

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the enco

WebBrowser:

Rolled over changes from the main trunk.

2003-01-31 Chris Blumenberg <​cblu@apple.com>

Beta expiration warnings should not say "Beta 1"

Reviewed by john.

• English.lproj/Localizable.strings:
• main.m: (main): (shouldShowFinalBetaExpirationWarning): fixed variable name

12:40 PM Changeset in webkit [3617] by cblu

• 2 edits in trunk/WebKit

Fixed: 3168888 - REGRESSION: many downloads fail (due to -36 error from write)

Reviewed by darin.

• Downloads.subproj/WebDownload.m: (-[WebDownload writeForkData:isDataFork:]):

10:02 AM Changeset in webkit [3616] by trey

• 6 edits
  1 add in trunk/WebKit

Make sure we have a FormsDelegate installed with NOP behavior if our client
does not set one. Editing forms was broken for Ed by the introduction
of the new FormDelegate.

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Added new header file.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _formDelegate]): Use shared delegate if none set yet.
• WebView.subproj/WebFormDelegatePrivate.h: New header.
• WebView.subproj/WebFormDelegate.h: Nit cleanup.
• WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): New method to return a shared NOP implementation.