Context Navigation

← Previous Period
Next Period →

Timeline

Apr 12, 2003:

3:18 PM Changeset in webkit [4086] by cblu

3 edits in trunk/WebCore

Fixed: 3188070 - 6I32 EMBED tag with no SRC attribute doesn't load the plugin

Reviewed by dave.

khtml/khtml_part.cpp: (KHTMLPart::requestObject): allow URL-less parts

Apr 11, 2003:

6:17 PM Changeset in webkit [4085] by cblu

3 edits in trunk/WebKit

WebKit:

Removed WebKitErrorResourceLoadInterruptedByPolicyChange error because it isn't used.

Reviewed by john.

Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (registerErrors):
WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: 3109110 - clean up status bar after deciding to download
Fixed: 3090317 - Download progress feedback very bad after drag & drop .dmg URL to Alex

Reviewed by trey, john.

BrowserWebErrorExtras.h:
BrowserWebErrorExtras.m: (-[WebError isCancelledError]): new (-[WebError isPolicyChangeError]): new
FrameProgressEntry.m: (-[FrameProgressEntry stage]): use new error categories
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor reset]): new, set main entry to nil if we haven't previously committed (-[LoadProgressMonitor committedFrame:]): set committed bool
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call [LoadProgressMonitor reset] for downloads

5:34 PM Changeset in webkit [4084] by trey

11 edits in trunk

WebCore:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

khtml/rendering/render_root.cpp: (RenderRoot::layout): Always resize our view, even when doing a layout when in printing mode. It's necessary to change the view size because we rely on the AppKit built-in pagination, which operates using the view geometry.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth): New method to do a layout given a specific width.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge _setPrintingMode:]): Helper routine to take the RenderRoot in and out of printing mode. (-[WebCoreBridge forceLayout]): Turn printing mode on/off. (-[WebCoreBridge forceLayoutForPageWidth:]): Turn printing mode on/off. New glue routine to call part. (-[WebCoreBridge drawRect:withPainter:]): Turn printing mode on/off. (-[WebCoreBridge drawRect:]): Test paintDevice type instead of graphics context to determine printing mode. The latter is still on when we are wrapping up the job and want to be setting things back to normal. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Turn printing mode on/off.

WebKit:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

WebKit.pbproj/project.pbxproj: Someone is using an old version...
WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't do the dynamic scrollbar update magic when printing.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): New routine, basically the old layout method with a new parameter. If we're given an width, we call a different bridge method. (-[WebHTMLView layout]): Just call above method with width==0 (-[WebHTMLView drawRect:]): Protect setting/resetting of graphics context and additional clip with a DURING/HANDLER. I saw an assertion failure that could be explained by this, so this is mostly a beartrap for that problem. (-[WebHTMLView _setPrinting:pageWidth:]): Pass page width through to others. (-[WebHTMLView beginDocument]): If we are not in a frame set, do a layout using the page width. (-[WebHTMLView endDocument]): Pass 0 to new pageWidth: arg.

4:30 PM Changeset in webkit [4083] by darin

5 edits in trunk/WebCore

Reviewed by Richard.

fixed 3225472 -- www.sina.com.cn uses A3A0 for full-width space; used to work in Simplified Chinese (Mac OS)

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Work around the problem in the Text Encoding Converter by changing all U+E5E5 to U+3000.

kwq/KWQString.h: Added replace(QChar, QChar), since Qt has it and I need it.
kwq/KWQString.mm: (QString::find): Fixed a bug where we'd yield a FATAL and return -1 on deployment if you searched for a non-ASCII character in a string that had ASCII valid and not Unicode valid. (QString::replace): Added replace(QChar, QChar).

2:38 PM Changeset in webkit [4082] by trey

2 edits in trunk/WebKit

3220349 - assertion failure in [WebFrame _recursiveGoToItem:...] hitting Back while loading movie

The problem was that when we go back we call stopLoading on the top frame, but
that has a bogus optimization to not do any work if state=Completed. That is a
bogus test if a subframe is doing a load. The fix is to just always tell the
dataSources to stopLoading. They already bail quickly when they are not loading,
so there is no significant additional cost.

Reviewed by Richard.

WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):

1:23 PM Changeset in webkit [4081] by sheridan

6 edits in trunk

Safari-74u.
also "1.0" instead of 0.9 AND instead of "1.0 Beta[ 2]"
cheers

10:07 AM Changeset in webkit [4080]

3 copies
2 deletes in branches/WebCore-73-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-73-tarball-branch'.

10:07 AM Changeset in webkit [4079]

3 copies
2 deletes in tags/WebCore-73-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-73-tarball-anchor'.

10:07 AM Changeset in webkit [4078]

3 copies in branches/Safari-74-branch

This commit was manufactured by cvs2svn to create branch
'Safari-74-branch'.

10:07 AM Changeset in webkit [4077]

3 copies in tags/Safari-74-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-74-anchor'.

10:07 AM Changeset in webkit [4076]

3 copies in tags/Safari-73

This commit was manufactured by cvs2svn to create tag 'Safari-73'.

10:07 AM Changeset in webkit [4075]

1 copy
2 deletes in branches/JavaScriptCore-73-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-73-tarball-branch'.

10:07 AM Changeset in webkit [4074]

1 copy
2 deletes in tags/JavaScriptCore-73-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-73-tarball-anchor'.

10:07 AM Changeset in webkit [4073] by sheridan

8 edits in trunk

73 stamp

Apr 10, 2003:

7:49 PM Changeset in webkit [4072] by rjw

2 edits in trunk/WebKit

Fixed 3219525

Our work-around for the CG pattern cache bogosity was always bypassed,
consequently we'd unnecessarily burn lots of memory filling that cache.

Reviewed by mjs & gramps.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer tileInRect:fromPoint:]):

7:22 PM Changeset in webkit [4071] by mjs

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3225042 - MallocDebug shows "access after deallocated" problem in WebFrameView

WebView.subproj/WebFrameView.m: (-[WebFrameView dealloc]): Nil out _private. (-[WebFrameView nextKeyView]): Check _private for nil. (-[WebFrameView previousKeyView]): Check _private for nil.

7:16 PM Changeset in webkit [4070] by rjw

3 edits in trunk/WebKit

Fix performance regression with iBench (post 71). The iBench cheat was being defeated.

Ensure that the layout timer is always invalidated when a frame completes
or is cancelled.

Reviewed by mjs & gramps.

WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):

7:01 PM Changeset in webkit [4069] by trey

7 edits in trunk

WebCore:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

New WC support function.

Reviewed by Darin.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementWithName:inForm:]): Run through the form's elements looking for a matching name.

WebKit:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

Just glue for calling a new WC function.

Reviewed by Darin.

WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementWithName:inForm:]):

WebBrowser:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

User new WC SPI to lookup the element for each field at submit time,
and test them for AUTOCOMPLETE=OFF or if they are password fields.

This is in the "saving data for previous forms case". Saving creds in
the keychain is done elsewhere.

Reviewed by Darin.

FormCompletionController.m: (+[FormCompletionController _frame:willSubmitRegularForm:withValues:]):

3:45 PM Changeset in webkit [4068]

3 copies in tags/Safari-72

This commit was manufactured by cvs2svn to create tag 'Safari-72'.

3:45 PM Changeset in webkit [4067] by sheridan

8 edits in trunk

Safari-72 versionstamp

2:41 PM Changeset in webkit [4066] by mjs

2 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches

WebKit.pbproj/project.pbxproj: Install WebKitErrorsPrivate.h as SPI.

WebBrowser:

Reviewed by Chris.

fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches

BrowserWebController.m: (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): Use _webKitErrorWithCode:forURL: SPI.
DownloadProgressEntry.m: -([DownloadProgressEntry initWithDictionary:]): Use _webKitErrorWithCode:forURL: SPI when appropriate. Also, avoid treating error code of 0 as "no error" if we have a non-empty non-nil domain.

1:57 PM Changeset in webkit [4065] by darin

4 edits in trunk/WebKit

Reviewed by Trey.

fixed 3224622 -- REGRESSION: in an empty window, repeated tabs don't cycle back to location field

Added logic to WebFrameView's next/previous that matches the logic in WebHTMLView.
Looking for a better solution some day to the whole nextKeyView thing.

WebView.subproj/WebFrameView.m: (-[WebFrameView nextKeyView]): If being called from nextValidKeyView, return the nextKeyView of the WebView rather than of self. (-[WebFrameView previousKeyView]): Ditto. (-[WebFrameView nextValidKeyView]): Set the inNextValidKeyView flag. (-[WebFrameView previousValidKeyView]): Ditto.

WebView.subproj/WebFrameViewPrivate.h: Add the inNextValidKeyView flag.

12:23 PM Changeset in webkit [4064] by mjs

8 edits in trunk/WebKit

Reviewed by Darin.

Another launch time speedup - don't load the WebKit WebError
strings until we actually make a WebKit error. This prevents the
WebKit localized strings file from being loaded during normal startup.

Downloads.subproj/WebDownload.m: (+[WebDownloadPrivate initialize]): Don't register WebKit errors. (-[WebDownload _errorWithCode:]): Use _webKitErrorWithCode:failingURL:
Misc.subproj/WebKitErrors.m: (+[WebError _webKitErrorWithCode:failingURL:]): Wrapper that registers the WebKit error codes first.
Misc.subproj/WebKitErrorsPrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use _webKitErrorWithCode:failingURL: (-[WebFrame _loadItem:withLoadType:]): Use _webKitErrorWithCode:failingURL:
WebView.subproj/WebFrameView.m:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Use _webKitErrorWithCode:failingURL:

11:48 AM Changeset in webkit [4063] by mjs

3 edits in trunk/WebCore

Reviewed by Darin and Ken.

fixed 3223127 - REGRESSION: windows for PopCap games show scroll bars now, did not in Safari-60

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Re-add scrollbars property, but change it to default to on even when other properties are specified (unlike other window properties). This seems to match what Mac IE, Win IE and Windows Mozilla do.

11:06 AM Changeset in webkit [4062] by cblu

2 edits in trunk/WebKit

Fixed: 3222896 - REGRESSION: sound plays after closing a window with a RealPlayer plug-in in it

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): We were starting plug-in on window close because that's when the host window is set to nil. Just check if we now have a host window before we start.

9:56 AM Changeset in webkit [4061] by darin

4 edits in trunk/WebCore

Reviewed by Trey.

speed up startup by not loading the hand cursor until it's used

khtml/khtml_part.cpp: (KHTMLPart::urlCursor): Use the hand cursor.
khtml/khtmlpart_p.h: Don't store the hand cursor in a per-part global.

9:54 AM Changeset in webkit [4060] by darin

4 edits in trunk/WebKit

Reviewed by Trey.

speed up startup by not calling [NSImage imageFileTypes] until we need to

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): Call _viewClassForMIMEType instead of _viewTypes, since _viewClassForMIMEType is now optimized by not loading the image types unless needed.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Call _representationClassForMIMEType instead of _repTypes, since _representationClassForMIMEType is now optimized by not loading the image types unless needed. (+[WebDataSource _repTypesAllowImageTypeOmission:]): Added. Moved the guts of _repTypes in here. If you pass YES, doesn't bother adding the image types yet. (+[WebDataSource _repTypes]): Now calls _repTypesAllowImageTypeOmission:NO. (+[WebDataSource _representationClassForMIMEType:]): First try the dictionary without requiring the image types, then only in the case where we get nil, try with the image types.

WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Call _viewClassForMIMEType instead of _viewTypes, since _viewClassForMIMEType is now optimized by not loading the image types unless needed. (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Added. Moved the guts of _viewTypes in here. If you pass YES, doesn't bother adding the image types yet. (+[WebFrameView _viewTypes]): Now calls _viewTypesAllowImageTypeOmission:NO. (+[WebFrameView _viewClassForMIMEType:]): First try the dictionary without requiring the image types, then only in the case where we get nil, try with the image types.

9:52 AM Changeset in webkit [4059] by darin

5 edits
1 add in trunk/WebCore

Reviewed by Maciej.

fixed 3224077 -- REGRESSION: tables on MacNN forums messed up because we reject %% due to style parser

khtml/css/tokenizer.flex: Add a + sign after the % in the percentage rule so we allow any number of extra percent signs. This is a temporary hack.

khtml/css/Makefile.am: Add make rules to build tokenizer.cpp so we don't have to do it by hand.
khtml/css/maketokenizer: Added. Script used by the make rules.
khtml/css/tokenizer.cpp: Regenerated. The only substantive change is in the state tables.

12:14 AM Changeset in webkit [4058] by trey

5 edits in trunk/WebKit

3223413 - crash in [CompletionController controlTextDidChange] at travelocity.com

This was a great one to get steps for repro - it has shown up at least twice before.

The problem is that when there is a focused TextField within a frame, the proper
FormDelegate messages were not being sent on refresh or b/f. The cause was that
the FirstResponder would be reset in the middle of detaching the frame, at which point
our object graph was already half taken apart. Fix is to detect that case before
doing the detach work, and endEditing explicitly.

Reviewed by Darin.

ChangeLog:
Misc.subproj/WebKitLogging.h:
Misc.subproj/WebKitLogging.m: New FormDelegate logging category.
WebCoreSupport.subproj/WebBridge.m: All changes in here are just calling LOG for the new category. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]): The fix, as described above.

Apr 9, 2003:

7:12 PM Changeset in webkit [4057] by rjw

4 edits in trunk/WebKit

Fix for 3222904. This change fixes the immediate symptoms of the bug,
but we need to come back to this issue after beta 2. Bug 3223929 captures
the other problems.

Reviewed by gramps.

WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource __setRequest:]): (-[WebDataSource _setRequest:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldReloadForCurrent:andDestination:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

6:48 PM Changeset in webkit [4056] by hyatt

4 edits in trunk/WebCore

This first fix is a refinement of the patch I produced to fix <nobr>
on cnn.com recently. It wasn't quite good enough to plug the
regression on other sites. This fix just checks the object
we're currently breaking on (which is what I meant to do) and
not the last object examined (which will always just be the
previous object you looked at).

The code currently in the tree would work if you had two objects
like this:

[Normal Whitespace] [Nowrap Whitespace]

but not if you had three:

[Normal][Nowrap][Nowrap]

Since when you looked at the third object, |last| would be the
previous nowrap object and not the normal object. The line break
properly stays at the normal object as long as nowrap objects are
encountered, so this patch basically does what the original was
intended to do.

This fixes the line break problems on 1800flowers.com, a line break
problem on the bugzilla.mozilla.org layout test, a problem
on the zdnet layout test, and 3207196 a regression on livejournal.

The second fix in this patch is a simple reversal of
containsOnlyWhitespace. The method on RenderText was
backwards! No logical changes have been made... I just inverted
all the callers, and then I patched the method.

The third fix is to make images check for == normal instead of != nowrap
in a few places, thus preventing incorrect line break points from being
set up.

Reviewed by gramps

khtml/rendering/bidi.cpp:
khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):

5:46 PM Changeset in webkit [4055] by mjs

3 edits in trunk/WebKit

Reviewed by Chris, Trey, Darin and Don.

fixed 3223568 - site icons lost when moving from older Safari to 71

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): Rename old database containing directory to new, so we carry over old databases. The format is forward but not backward compatible. (-[WebIconDatabase _loadIconDictionaries]): Treat no version at all as version 1, so we can load old-style databases.

Reviewed by Trey.

English.lproj/StringsNotToBeLocalized.txt: Updated.

4:19 PM Changeset in webkit [4054] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3223414 -- update text encoding menu and encoding names table

Made changes as suggested by Deborah Goldsmith and Peter Edberg from the International group.

kwq/mac-encodings.txt: Moved all Korean character sets that are not explicitly Macintosh from MacKorean to EUC_KR. Moved Shift JIS character sets that are not explicitly Microsoft from DOSJapanese to ShiftJIS_X0213_00. Moved cp949 from DOSKorean to EUC_KR (DOSKorean is not implemented in Jaguar). Moved big5 character sets that are not explicitly Microsoft from DOSChineseTrad to Big5_HKSCS_1999. Moved all gb2312-80 character sets from GB_2312_80 to GB_18030_2000. Moved all gbk character sets from GBK_95 to GB_18030_2000. Moved all euc-cn character sets from EUC_CN to GB_18030_2000.

kwq/KWQCharsetData.c: Regenerated.

1:05 PM Changeset in webkit [4053] by darin

4 edits in trunk/WebCore

Reviewed by Richard.

fixed 3223126 -- REGRESSION: exception BrowserWindow isDescendantOf:]: selector not recognized

kwq/KWQWidget.mm: (QWidget::hasFocus): Add missing check of the class of the first responder before calling an NSView method on it.

12:02 PM Changeset in webkit [4052] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3222708 -- REGRESSION: repro crash trying to read news at nttdocomo

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Make window.open do its location change with scheduleRedirection like all the other JavaScript calls that change location.

11:01 AM Changeset in webkit [4051] by cblu

2 edits in trunk/WebKit

Fixed: 3223022 - Plug-in content bleeds onto frontmost tab

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewDidMoveToWindow]): Explicitly call setWindow when the plug-in view is moved out of the window so it is clipped out of sight.

Apr 8, 2003:

4:39 PM Changeset in webkit [4050] by trey

2 edits in trunk/WebKit

3221355 document is numb to clicks after going back

The layoutTimer now does a layout if the doc is in state Completed,
in addition to LayoutAcceptable.

Reviewed by Richard.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]):

4:29 PM Changeset in webkit [4049] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3221400 -- REGRESSION: password field with onfocus handler that does select causes focus/typing trouble

kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Rearrange slightly. (-[KWQTextField becomeFirstResponder]): Add code to make the secure field first responder when in password mode. The old code did this indirectly through the call to setDocumentFocus, which caused minor trouble. (-[KWQSecureTextField selectText:]): Correct the current editor check to use a technique that works even for the secure text field's editor (which does not get returned by currentEditor).

kwq/KWQWidget.mm: (QWidget::hasFocus): Update the logic here so it works for the secure text field and the secure text field's editor.

3:59 PM Changeset in webkit [4048] by hyatt

3 edits in trunk/WebCore

Fix for 3166374. Making the nudie blog work. My loop for
removing floating objects when they got deleted wasn't catching
all the cases.

Reviewed by darin

khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists):

2:39 PM Changeset in webkit [4047] by cblu

6 edits in trunk/WebKit

Fixed: 3221128 - Double grey lines on macromedia.com home page

Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.

Reviewed by trey.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m:
Plugins.subproj/WebNetscapePluginEmbeddedView.h:
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:]): take attributeKeys and attributeValues instead of a dictionary
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): create attributeKeys and attributeValues to pass to the above method (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): create attributeKeys and attributeValues to pass to the above method

2:10 PM Changeset in webkit [4046] by sheridan

3 edits in trunk

72u versionstamp

12:15 PM Changeset in webkit [4045] by cblu

4 edits in trunk/WebKit

Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)

Reviewed by darin.

Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView didStart]): always call redeliverStream. Have WebNetscapePluginRepresentation determine if it actually needs to do that.
Plugins.subproj/WebNetscapePluginRepresentation.h:
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): keep track of _dataLengthReceived which is independent of the data received by the data source (-[WebNetscapePluginRepresentation redeliverStream]): only redeliver the stream if _dataLengthReceived is greater than 0

12:04 PM Changeset in webkit [4044] by hyatt

4 edits in trunk/WebCore

Fix for 3220979. Regression caused by changes to the CSS
parser's error handling. Fix is to narrow my original patch
to handle a specific subtype of error for properties.

Reviewed by darin

khtml/css/parser.cpp:
khtml/css/parser.y:

10:23 AM Changeset in webkit [4043] by rjw

3 edits in trunk/WebCore

Fixed 3221353. Added check for nil part.

Reviewed by Darin.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):

Apr 7, 2003:

10:41 PM Changeset in webkit [4042] by cblu

2 edits in trunk/WebKit

Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window

MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.

Reviewed by gramps.

Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): treat nil as _top.

8:49 PM Changeset in webkit [4041] by rjw

3 edits in trunk/WebKit

API conveniences for IB.

Reviewed by Maciej.

WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView reload:]): (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): (-[WebView makeTextSmaller:]): (-[WebView makeTextLarger:]):

8:36 PM Changeset in webkit [4040] by rjw

11 edits in trunk

WebCore:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
khtml/khtml_part.h:
kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):
kwq/WebCoreBridge.h:

WebKit:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]):

6:59 PM Changeset in webkit [4039] by hyatt

3 edits in trunk/WebCore

Fix for 3220395. nearestFloatBottom() mistakenly returned 0
when it ran out of floats to return.

Reviewed by gramps

khtml/rendering/render_block.cpp:

6:36 PM Changeset in webkit [4038] by mjs

2 edits in trunk/WebKit

Reviewed by Richard.

fixed 3219584 - REGRESSION: launch times appear slower in v71

WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): Avoid loading plugin database if we can find a view without doing so.

5:36 PM Changeset in webkit [4037] by hyatt

5 edits in trunk/WebCore

Fix for the scrollbar problem in 3220395. Does not yet fix
the overlap problem. lowest/rightmostPosition got broken by
the RenderFlow split. This patch makes sure that we still crawl
into inlines with overhangingContents.

Reviewed by darin

khtml/rendering/render_block.cpp:
khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
khtml/rendering/render_flow.h:

5:24 PM Changeset in webkit [4036] by sheridan

3 edits in branches/Safari-69~1-branch

actually I meant something slightly different ...

5:13 PM Changeset in webkit [4035] by sheridan

5 edits in branches/Safari-69~1-branch

fixing versions for panther vs alexander build train submission

3:31 PM Changeset in webkit [4034] by hyatt

3 edits in trunk/WebCore

khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):

This is a patch to the parser to prevent residual
style from creating illegal constructs according to the DTD.
For now, it will just bail on performing the fixup if an
illegal construct would be created.

This fixes the regression #3219944.

Reviewed by darin

2:43 PM Changeset in webkit [4033] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3220490 -- REGRESSION: MALLORY horiz scrollbar incorrectly appears with abs positioned content

khtml/rendering/render_block.cpp: (RenderBlock::rightmostPosition): Fix a place where I had xPos instead of yPos.

9:55 AM Changeset in webkit [4032] by darin

2 edits in trunk/WebKit

WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. When I landed my last change to the .gperf file I forgot to land this.

Apr 4, 2003:

2:28 PM Changeset in webkit [4031]

3 copies in tags/Safari-71

This commit was manufactured by cvs2svn to create tag 'Safari-71'.

2:28 PM Changeset in webkit [4030] by sheridan

8 edits in trunk

Safari-71 versions

1:31 PM Changeset in webkit [4029] by darin

3 edits in trunk/WebCore

Reviewed by John and Richard.

fixed 3218725 -- REGRESSION: reproducible crash in recalcStyle on reload

khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_paintDevice to 0.

11:13 AM Changeset in webkit [4028] by darin

1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Roll out accidentally-committed change.

10:34 AM Changeset in webkit [4027] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed 3125850 -- VIP: "search by goo" instead of "search by google" at livepage.apple.com

We decided not to fix the general problem right now, but just hack the site.

khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::parseAttribute): Just ignore the style set by livepage.apple.com, so we get a too-big "Search by Google" rather than a cut off "Search by Goo".

10:26 AM Changeset in webkit [4026] by hyatt

3 edits in trunk/WebCore

Fix for the Search button cutoff on livepage.apple.com We
weren't honoring hspace/vspace on input elements.

Reviewed by darin

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute):

9:39 AM Changeset in webkit [4025] by hyatt

3 edits in trunk/WebCore

Fix for 3218085. Remove the bogus 2cm print rule for body in the
html4.css sheet.

Reviewed by darin/trey

khtml/css/html4.css:

8:56 AM Changeset in webkit [4024] by darin

22 edits
1 delete in trunk

WebCore:

Reviewed by Ken.

fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

To get the style machinery working for me instead of against me, I had to introduce both
FontDef and QFont to the screen/printer font dichotomy. Just following that through took
care of the bugs we were seeing.

khtml/rendering/font.h: Add a usePrinterFont field to FontDef (in APPLE_CHANGES).
khtml/rendering/font.cpp: (Font::update): Set the new "printer font" field on the QFont (in APPLE_CHANGES).

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Set usePrinterFont field on the document's fontDef (in APPLE_CHANGES).

kwq/KWQFont.h: Add isPrinterFont, setter, getter.
kwq/KWQFont.mm: (QFont::QFont): Default isPrinterFont to false, copy when copying. (QFont::operator=): Copy isPrinterFont. (QFont::setPrinterFont): Added. (QFont::operator==): Compare isPrinterFont.

kwq/KWQFontMetrics.mm: Remove the _rendererUsesPrinterFont field and associated code. This was only needed when the same QFont could be both printer and screen font, but now the QFont itself is different.
kwq/KWQPainter.mm: (QPainter::_updateRenderer): Remove textRendererUsesPrinterFont field and associated code, for same reason as above.

kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStylesForDeviceType:]): Set the document's paint device.

kwq/WebCoreTextRendererFactory.h: Remove global setUsingPrinterFonts: and usingPrinterFonts methods. We now handle this at the document level. Add a usingPrinterFont: parameter to rendererWithFont:, which is now how KHTML tells the text rendering code which kind to use.
kwq/WebCoreTextRendererFactory.m: Removed KWQTextRendererFactoryUsingPrinterFonts. (-[WebCoreTextRendererFactory rendererWithFont:usingPrinterFont:]): Added parameter.

other changes

kwq/KWQPaintDevice.h: Store the device type instead of using a virtual function.
kwq/KWQPrinter.h: Set device type in constructor instead of overriding devType function.
kwq/KWQPixmap.h: Changed destructor back to non-virtual (and entire class back to non-polymorphic), now that QPaintDevice doesn't use virtual functions any more.

kwq/KWQPaintDeviceMetrics.h: Remove unused width() and height().
kwq/KWQPaintDeviceMetrics.mm: Ditto.

WebCore.pbproj/project.pbxproj: Removed KWQTextRendererFactory.h.
kwq/KWQTextRendererFactory.h: Removed.

WebKit:

Reviewed by Ken.

fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

WebCoreSupport.subproj/WebTextRendererFactory.m: Removed now-unused rendererWithFont: which called, the now-removed usingPrinterFonts method. WebCore now calls the one with the usingPrinterFont parameter.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Remove setUsingPrinterFonts: calls. This is now handled by the document on the WebCore side. (-[WebHTMLView _setPrinting:]): Ditto.

1:44 AM Changeset in webkit [4023] by mjs

1 edit in trunk/WebKit/ChangeLog

Added the following missing bug number to an earlier checkin.

fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab

1:32 AM Changeset in webkit [4022] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

Made a return value mutable so callers can conveniently change it w/o allocating.g

Misc.subproj/WebNSDataExtras.h:
Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]): Declare return type as NSMutableDictionary instead of NSDictionary. We were returning a mutable one anyway.

WebKit:

Reviewed by Trey.

fixed 3188914 - loop checking for Flash at http://www.scottsmind.com/celebrity_defacer/index.php

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Take a mutable request, and make sure to set referrer to the frame URL (as other browsers do). (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass an NSMutableURLRequest. (-[WebBaseNetscapePluginView getURL:target:]): Likewise. (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): If the plug-in passes a Content-Length header, take it out of the headers and truncate the content appropriately to make WebFoundation happy.

Apr 3, 2003:

11:25 PM Changeset in webkit [4021] by rjw

3 edits in trunk/WebKit

Fix checks for about: to avoid using our 'fake' request when
using WebDataProtocol. This fixes the assertion in the Snippet
Editor.

Reviewed by mjs.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

10:20 PM Changeset in webkit [4020] by trey

2 edits in trunk/WebKit

3218212 REGRESSION: page on screen draws ugly while printing is happening

Turn autodisplay of the window off while we print.

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Turn it off. (-[WebHTMLView endDocument]): and back on.

9:52 PM Changeset in webkit [4019] by mjs

6 edits in trunk

WebCore:

Reviewed by Trey.

fixed 3031544 - can't login on secure paytrust page due to lack of onchange handler

kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]): Send FocusIn event to event filter here. (-[KWQTextField control:textShouldEndEditing:]): Send FocusOut event to event filter here. (-[KWQTextField fieldEditorDidBecomeFirstResponder]): Removed. (-[KWQTextField fieldEditorDidResignFirstResponder]): Removed.
kwq/WebCoreFirstResponderChanges.h: Removed first responder methods.

WebKit:

Reviewed by Trey.

removed no-longer forwarding of become/resignFirstResponder

WebView.subproj/WebHTMLViewPrivate.m: Removed become/resignFirstResponder poses for WebNSTextView.

9:43 PM Changeset in webkit [4018] by mjs

2 edits in trunk/WebKit

Reviewed by Richard and Don.

WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForWriting]): Renamed from _webDataRequestParameters. (-[NSURLRequest _webDataRequestParametersForReading]): Like the above, but make sure nto to create the part if it does not exist. (-[NSURLRequest _webDataRequestData]): Use _webDataRequestParametersForReading. (-[NSURLRequest _webDataRequestEncoding]): Likewise. (-[NSURLRequest _webDataRequestBaseURL]): Likewise. (-[NSURLRequest _webDataRequestSetData:]):Use _webDataRequestParametersForWriting. (-[NSURLRequest _webDataRequestSetEncoding:]): Likewise. (-[NSURLRequest _webDataRequestSetBaseURL:]): Likewise. (-[NSURLRequest _webDataRequestExternalRequest]): Use _webDataRequestParametersForReading.

7:24 PM Changeset in webkit [4017] by rjw

7 edits in trunk/WebKit

WebFoundation:

Changed NSURLRequest to use an ivar to hold the primary
part data, instead of a dictionary. This avoids a dictionary
lookup when accessing part data. The dictionary lookup turns
out to be very expensive.

Reviewed by ken.

CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequestInternal dealloc]): (-[NSURLRequest _partWithClass:createIfDoesNotExist:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSMutableURLRequest copyWithZone:]):

WebKit:

Tweaks to minimize access to the parts of a WebDataRequest
that turn out to be slow. Although we've changed NSURLRequest
to be faster, it's still good to keep these tweaks.

Reviewed by ken.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestExternalRequest]): (+[WebDataProtocol canHandleURL:]):
WebView.subproj/WebDataSource.m: (-[WebDataSource request]):

Tests:

Removed dead code.

Reviewed by ken.

SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
SnippetEditor/DataResourceRequest.h: Removed.
SnippetEditor/DataResourceRequest.m: Removed.

4:12 PM Changeset in webkit [4016] by trey

17 edits
1 add in trunk

WebCore:

3067928 - printing should not break lines in half
3217607 - when printing we should not draw the selection

We leverage the existing knowledge that a couple render object classes had
for adjusting pagination. Wrote 3217705 saying we should add similar
smarts to a few more places.

Reviewed by Darin.

ForwardingHeaders/qprinter.h: Added.
khtml/rendering/render_list.cpp: (RenderListMarker::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
khtml/rendering/render_root.cpp: (RenderRoot::setBestTruncatedAt): Accumulate the best pagination boundary.
khtml/rendering/render_root.h:
khtml/rendering/render_text.cpp: (RenderText::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Don't draw the debugging red background when printing. (KWQKHTMLPart::adjustPageHeight): The meat of the change. Make another painting pass (with actual painting disabled) to get the pagination boundary set as a side effect. Return result up to AppKit.
kwq/KWQPaintDevice.h: devType() made virtual
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::QPainter): New constructor for making a printing painter. (QPainter::device): Return either the Screen or Printer device.
kwq/KWQPixmap.h: Destructor needed to become virtual.
kwq/KWQPrinter.h: Implement devType().
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Setup printer device in our painter if we're not drawing to the screen. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Forward to part.

WebKit:

3067928 - printing should not break lines in half

This is just glue to call the right piece in WebCore.

Reviewed by Darin.

(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
Defer to WebCore to set pagination boundary.

3:39 PM Changeset in webkit [4015] by rjw

3 edits in trunk/WebKit

WebKit:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences setJavaEnabled:]): (-[WebPreferences setJavaScriptEnabled:]): (-[WebPreferences setPlugInsEnabled:]):

WebBrowser:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences togglePluginsEnabled:]):

2:48 PM Changeset in webkit [4014] by darin

5 edits in trunk/WebKit

Reviewed by Ken.

remove spoof entries as decided in meeting with Don, Dave, Mark Malone

WebView.subproj/WebUserAgentSpoofTable.gperf: Remove battle.net because it's only there to make Darin happy, and the site works fine without it. Remove pier1.com and disney.go.com because we want to try evangelism first in both those cases, and having a released version where the site works weakens our evangelism efforts.

WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

disable workaround for Panther bug in Panther builds

Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_dissolveToFraction:]): Add ifdefs.

11:07 AM Changeset in webkit [4013] by darin

6 edits in trunk/WebCore

Reviewed by John.

fixed 3194468 -- ARCH: text zoom should scale line-height as well as font-size

khtml/css/css_valueimpl.h:
khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLength): Add a new version that does a multiply before rounding. Also simplify the rounding code.

khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule): For line height, multiply by the text zoom factor in cases where the height isn't already relative to the font size.

other changes

khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject): Disable code to work around X11 widget size limit. It can only do harm for us.

8:29 AM Changeset in webkit [4012] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed bug 3216832 -- REGRESSION: scroll bar doesn't appear soon enough when shrinking excite.com horizontally

khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Fixed mistake where using the wrong variable led to the colspan distribution loop terminating early, and not giving any additional width to the second column.

fixed some navigator properties as discussed in the meeting yesterday (with Don, Dave, Mike Malone)

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Use the date 20030107 instead of 20021225 because people think it's less arbitrary. Use "Apple Computer, Inc." as the vendor string.

Apr 2, 2003:

10:41 PM Changeset in webkit [4011] by mjs

2 edits in trunk/WebKit

Reviewed by Trey.

fixed 3213556 - VIP: parent.mainFrameWidth=undefined on page refresh results in missing content

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): When reload or going back/forward, make sure to load the original URL of the item, not it's most recent URL. (-[WebFrame _loadURL:intoChild:]): Likewise.

7:24 PM Changeset in webkit [4010] by hyatt

3 edits in trunk/WebCore

Fix for 3216650. Needed an additional check when the disabled
attribute is changed on <link> elements for stylesheets to keep
the pending sheet count in sync.

Reviewed by gramps

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute):

5:31 PM Changeset in webkit [4009] by rjw

2 edits in trunk/WebKit

Raise exceptions when these methods are called inappropriately.

Reviewed by Trey.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]):

5:22 PM Changeset in webkit [4008] by hyatt

3 edits in trunk/WebCore

Fix for 3212011. Avoid applying a fixup to the minwidth
of overflow:hidden table cells, since we don't really have
an accurate width to compare against.

I filed followup bug 3216709 to deal with the fact that this
fixup has been disabled.

Reviewed by john

khtml/rendering/render_block.cpp:

4:48 PM Changeset in webkit [4007] by hyatt

4 edits in trunk/WebCore

Do not assume all columns have a minwidth/maxwidth of 1px.
Instead give them a min/maxwidth of 0px, and only inflate to
1px if a cell originates in the column.

This fixes the error on travelocity.com, where a large colspan
leads to the implicit creation of a new column that contains no
originating cells. That new column should be 0px wide, not
1px.

The bug # is 3170592.

Reviewed by kocienda

khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):
khtml/rendering/table_layout.h:

4:47 PM Changeset in webkit [4006] by rjw

16 edits
2 adds in trunk/WebKit

WebKit:

Added new API on WebFrame, loadData: and loadString:

Reviewed by Maciej.

Fixed loading of cocoa plugins.

Reviewed by Chris.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList _entries]):
Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage bundle]):
Plugins.subproj/WebPluginDatabase.h:
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]): (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): (-[WebPluginDatabase dealloc]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.h: Added.
WebView.subproj/WebDataProtocol.m: Added. (-[WebDataRequestParameters copyWithZone:]): (-[WebDataRequestParameters mutableCopyWithZone:]): (-[WebDataRequestParameters dealloc]): (+[NSURLRequest _webDataRequestURLForData:]): (-[NSURLRequest _webDataRequestParameters]): (-[NSURLRequest _webDataRequestData]): (-[NSURLRequest _webDataRequestSetData:]): (-[NSURLRequest _webDataRequestEncoding]): (-[NSURLRequest _webDataRequestSetEncoding:]): (-[NSURLRequest _webDataRequestBaseURL]): (-[NSURLRequest _webDataRequestSetBaseURL:]): (-[NSURLRequest _webDataRequestExternalRequest]): (+[WebDataProtocol load]): (+[WebDataProtocol doesURLHaveInternalDataScheme:]): (+[WebDataProtocol canHandleURL:]): (+[WebDataProtocol canonicalURLForURL:]): (-[WebDataProtocol startLoadingWithCacheObject:]): (-[WebDataProtocol stopLoading]):
WebView.subproj/WebDataSource.m: (-[WebDataSource initialRequest]): (-[WebDataSource request]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame loadString:baseURL:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]):
WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]):
WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]):

WebBrowser:

Change SnippetEditor to use new loadString: API.

Reviewed by Maciej.

ChangeLog:
Debug/SnippetController.m: (-[SnippetController load]):

4:42 PM Changeset in webkit [4005] by mjs

3 edits in trunk/WebKit

Reviewed by Ken.

fixed 3177183 - disneyland.com says "500 Internal Server Error"

WebView.subproj/WebUserAgentSpoofTable.gperf: Spoof as Mac IE for disney.go.com
WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

4:39 PM Changeset in webkit [4004] by rjw

2 edits in trunk/WebKit

Reviewed by john.

WebView.subproj/WebPreferences.h: (-[WebPreferences setUserStyleSheetLocation:]): Cleaned up arg and comment.

4:37 PM Changeset in webkit [4003] by rjw

2 edits in trunk/WebKit

Fix for 3200447. Use class_pose to pose so as to avoid
indirect invocation of appkit class initializers.

Reviewed by darin.

WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

4:33 PM Changeset in webkit [4002] by rjw

2 edits in trunk/WebKit

Removed private headers.

Reviewed by john.

Misc.subproj/WebKit.h:

3:30 PM Changeset in webkit [4001] by hyatt

2 edits in trunk/WebCore

Fix for excite.com. There are many bugs being fixed that all
contributed to the wideness of the table.

The bug # is 3200534

Reviewed by darin

khtml/rendering/table_layout.cpp: (shouldScaleColumns):

3:19 PM Changeset in webkit [4000] by hyatt

3 edits in trunk/WebCore

Fix for excite.com. There are many bugs being fixed that all
contributed to the wideness of the table.

Reviewed by darin

khtml/rendering/table_layout.cpp: (shouldScaleColumns):

1:54 PM Changeset in webkit [3999] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed 3213854 -- REGRESSION: can't click on a text field to select it
fixed 3201477 -- friends links don't work on hyatt's blog

khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint): Skip floating objects when hit testing children.
khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint): Ditto.

10:54 AM Changeset in webkit [3998] by trey

5 edits in trunk/WebKit

3174227 - aggressive caching of generated pages causes problems with WIKI

We decided to fix half the observed behavior, as all the bad behavior is
arguably due to a mis-configured server (that sets a max-age=60 on
all its pages).

The fix is that when a redirect comes in response to a POST we force a
load from origin, since this is a common technique sites do to prevent
a post from ending up in the b/f list, and it is very likely you are
on your way back to look at data that you believe you just edited.

Reviewed by Ken.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): Nit cleanup. Remove unused arg. (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): Same nit cleanup.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Force loadFromOrigin if we have a redirect in response to a POST.
WebView.subproj/WebResourceLoadDelegate.h: Add headerdoc comment for redirectResponse param.

10:44 AM Changeset in webkit [3997] by trey

3 edits in trunk/WebCore

WebCore:

3119711 - redirects to anchors leave window half-loaded (was SCClib.org is half loaded, half rendered)

The problem happened when an anchor nav was the last half of a client redirect.
We would never stop the redirect timer, and thus never post a clientRedirectCanceled
message up through the stack. This left the app thinking that it was in redirect
mode even when the whole navigation had finished, which makes it not clear the
progress bar.

Reviewed by Darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Stop the redirect timer.

WebBrowser:

3119711 - redirects to anchors leave window half-loaded (was SCClib.org is half loaded, half rendered)

The problem happened when an anchor nav was the last half of a client redirect.
This case implies that an anchor nav must do the end-of-load cleanup, and not assume
that only a scroll was done to accomplish the nav. Note additional fix was
also needed in WebCore.

Reviewed by Darin.

LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): Update our page loading status. Finish up the progress bar, if it was showing non-zero progress.

Apr 1, 2003:

7:25 PM Changeset in webkit [3996] by mjs

2 edits in trunk/WebKit

Reviewed by Richard.

fixed 3214748 - REGRESSION: After using latest Safari for awhile, can't launch older Safaris (icon db problem)

Misc.subproj/WebIconDatabase.m: Changed icon cache path, since we are breaking compatibility and the old version does not support versioning. (-[WebIconDatabase _loadIconDictionaries]): Check version. (-[WebIconDatabase _updateFileDatabase]): Save version.

7:01 PM Changeset in webkit [3995] by sheridan

3 edits in trunk

version 71u; building 71 on Friday.

6:59 PM Changeset in webkit [3994] by mjs

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3182103 - REGRESSION: one developer.apple.com page is so slow, it almost seems like a hang

khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak): Avoid returning bad iterators that point past the end of an object instead of to the start ot the next one.

4:46 PM Changeset in webkit [3993] by darin

8 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3123709 -- redirect isn't followed at Apple's Dental Benefits provider

khtml/dom/dom2_events.h: Added boolean "isWindowEvent" parameter.
khtml/dom/dom2_events.cpp: (EventListener::handleEvent): Ignore boolean "isWindowEvent" parameter.

khtml/ecma/kjs_events.h: Added boolean "isWindowEvent" parameter.
khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Look at new "isWindowEvent" parameter, and send the event to the window if it's true, rather than the current node, document, and form.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Pass true for "isWindowEvent".
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Pass false for "isWindowEvent".

4:21 PM Changeset in webkit [3992] by kocienda

12 edits in trunk/WebKit

Tests:

Reviewed by Darin

NSURLConnectionDelegate is no longer a formal protocol.

PDFBundle/PDFView.m:

WebFoundation:

Reviewed by Darin

NSURLConnectionDelegate is no longer a formal protocol. Added support
to do dynamic checking of delegate object to see if that object
implements the NSURLConnectionDelegate category methods.

NSURLConnection no longer has a loadWithDelegate: method. Loads
start implicitly at init time. Changed code since we no longer
send willSendRequest:redirectResponse: callbacks for initial loads.

Updated comments in NSURLConnection.h so they match API approved versions.

Tweaked callback flag names so that they match the callback names themselves.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection connectionWithRequest:delegate:]): (-[NSURLConnection initWithRequest:delegate:]): (-[NSURLConnection _sendCallbacks]): (-[NSURLConnection _postWillSendRequestCallback]): (-[NSURLConnection _postDidReceiveResponseCallback]): (-[NSURLConnection _postDidReceiveDataCallback]): (-[NSURLConnection _postDidFinishLoadingCallback]): (-[NSURLConnection _postDidFailLoadingCallback]): (-[NSURLConnection _sendWillSendRequestCallback]): (-[NSURLConnection schedule]): (-[NSURLConnection _beginLoad]): (-[NSURLConnectionInternal prepareCallbacks]):
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]):

WebKit:

Reviewed by Darin

NSURLConnectionDelegate is no longer a formal protocol.

NSURLConnection no longer has a loadWithDelegate: method. Loads
start implicitly at init time. Some clients have been updated
to call the willSendRequest:redirectResponse: callback manually
since this callback is no longer sent for initial loads.

Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]):
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]):
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient loadWithRequest:]): (-[WebResourceDelegateProxy setDelegate:]):

WebBrowser:

Reviewed by Darin

NSURLConnectionDelegate is no longer a formal protocol.

NSURLConnection no longer has a loadWithDelegate: method. Loads
start implicitly at init time.

BugReportController.h:
BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):

2:05 PM Changeset in webkit [3991] by darin

10 edits in trunk

WebCore:

Reviewed by John.

fixed 3144287 -- CSS with media=print not used when printing

kwq/KWQKHTMLPart.h: Added a setMediaType function, so the bridge can access the KHTMLView::setMediaType function, which is private (KWQKHTMLPart is a friend).
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setMediaType): Call setMediaType on the KHTMLView.

kwq/WebCoreBridge.h: Added a device type parameter to reapplyStyles.
kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStylesForDeviceType:]): Call setMediaType with the appropriate media type for the passed in device type.

WebKit:

Reviewed by John.

fixed 3213918 -- REGRESSION: printing Mapquest directions, screen font is used, causing exception, crashes
fixed 3144287 -- CSS with media=print not used when printing

WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): Don't call the reapplyStyles method directly here, use setNeedsToApplyStyles instead.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView reapplyStyles]): Pass the appropriate device type here. (-[WebHTMLView drawRect:]): Don't call setUsingPrinterFonts:NO at the end of this method if we were already using printer fonts at the start. This was the bug fix. (-[WebHTMLView _setPrinting:]): Renamed from _setUsingPrinterFonts since this now controls the styles used too, not just the fonts. (-[WebHTMLView beginDocument]): Updated for _setPrinting name change. (-[WebHTMLView endDocument]): Ditto.
WebView.subproj/WebHTMLViewPrivate.h: Renamed "usingPrinterFonts" field to "printing".

12:17 PM Changeset in webkit [3990] by hyatt

3 edits in trunk/WebCore

Table code fixes. Working to try to fix excite.com.

Reviewed by darin

khtml/rendering/table_layout.cpp: (shouldScaleColumns): (AutoTableLayout::calcMinMaxWidth):

12:05 PM Changeset in webkit [3989] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3213900 -- REGRESSION: crash in CSS parser at http://radioalice.com/

khtml/css/cssparser.cpp: (CSSParser::parseColor): Add a missing check for nil.

11:34 AM Changeset in webkit [3988] by rjw

10 edits in trunk/WebKit

Fixed ~2% performance regression problem. The regression
was caused by the allocation of a forwarder on every
delegate callback. Modified code to only create forwarders once,
and reset when delegates change.

Reviewed by Ken.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]): (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]):
WebView.subproj/WebView.m: (-[WebView setWindowOperationsDelegate:]): (-[WebView setResourceLoadDelegate:]): (-[WebView setContextMenuDelegate:]): (-[WebView setPolicyDelegate:]): (-[WebView setLocationChangeDelegate:]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): (-[WebView _locationChangeDelegateForwarder]): (-[WebView _resourceLoadDelegateForwarder]): (-[WebView _cacheResourceLoadDelegateImplementations]): (-[WebView _resourceLoadDelegateImplementations]): (-[WebView _policyDelegateForwarder]): (-[WebView _contextMenuDelegateForwarder]): (-[WebView _windowOperationsDelegateForwarder]): (-[_WebSafeForwarder forwardInvocation:]):

API-Issues.rtf: Notes to self.

10:24 AM Changeset in webkit [3987]

15 copies in tags/Safari-70

This commit was manufactured by cvs2svn to create tag 'Safari-70'.

10:24 AM Changeset in webkit [3986] by sheridan

5 edits in branches/Safari-70-branch

changelog markers for safari-70

9:10 AM Changeset in webkit [3985] by darin

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3202542 -- REGRESSION: preinitialized password inputs do not show dots (affects mac.com)

kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): Remove code that sets the string value to "". This is not needed, and because a text changed signal is sent out it makes the caller think the text was deleted intentionally. Added code to move the string from the current field in use to the other field, so changing the password mode does not make the string go away. The old code was fragile and depended on the order of operations.

7:35 AM Changeset in webkit [3984] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Allowed update-alex-localizable-strings to sort this file.

Mar 31, 2003:

6:49 PM Changeset in webkit [3983] by trey

9 edits in trunk/WebKit

WebKit:

3212724 - bookmarks and history items have screwed up designated inits

and support code for:
3116315 - autocomplete needs some prioritization magic

The main changes are adding and maintaining a visitCount to the HistoryItem,
cleaning up the init methods of HistoryItem. Also lastVisitedDate is now
set explicitly instead of automatically getting the current date.

Reviewed by John.

History.subproj/WebHistory.m: (-[WebHistory addItemForURL:]): Set lastVisitedDate of new item. (-[WebHistory _itemForURLString:]): New helper routine.
History.subproj/WebHistoryItem.h: Conform to NSCopying.
History.subproj/WebHistoryItem.m: (-[WebHistoryItem init]): Behave like a designated initializer. (-[WebHistoryItem copyWithZone:]): New. (-[WebHistoryItem initWithURL:title:]): Call the designated initializer. (-[WebHistoryItem initWithURL:target:parent:title:]): Call the designated initializer. Don't blindly init lastVisitedDate. (-[WebHistoryItem setLastVisitedDate:]): Update visitCount too. (-[WebHistoryItem visitCount]): New getter. (-[WebHistoryItem setVisitCount:]): New setter. (-[WebHistoryItem _mergeAutoCompleteHints:]): Combine autocomplete info of two items. Used when one item replaces another in the history. (-[WebHistoryItem dictionaryRepresentation]): Write visitCount. (-[WebHistoryItem initFromDictionaryRepresentation:]): Read visitCount.
History.subproj/WebHistoryItemPrivate.h:
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Merge autocomplete date from old item to new. (-[WebHistoryPrivate itemForURLString:]): s/entry/item/ (-[WebHistoryPrivate containsItemForURLString:]): s/entry/item/ (-[WebHistoryPrivate containsURL:]): s/entry/item/ (-[WebHistoryPrivate itemForURL:]): s/entry/item/ (-[WebHistoryPrivate _loadHistoryGuts:]): Skip history items without visitDate.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): Update last visitTime when we revisit the same URL (since no new history item is created).

WebBrowser:

3116315 - autocomplete needs some prioritization magic
3181925 - editing redundant bookmarks could lead to screwed up autocomplete, likely crash
3212724 - bookmarks and history items have screwed up designated inits
3213092 - REGRESSION: infinite loop on launch if no bookmarks file exists

Reviewed by John.

BookmarksController.h:
BookmarksController.m: (-[BookmarksController bookmarksFileHasChanged]): Don't return YES if the file doesn't exist - fixes 3213092. (-[BookmarksController savePendingChangesWhenever]): New method to dirty bookmarks file without causing save.
BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Set lastVisited date of bookmark. Rearranged code to get rid of embedded return statements.

General idea here is that the _instantRedirectPending is replaced by the
delay of the redirect. I ended up tossing the client code that used this,
but it seems like a useful thing to keep for no cost.

BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): Init _redirectDelay. (-[BrowserWebController displayName]): Test _redirectDelay. (-[BrowserWebController setPendingRedirectDelay:]): Set the _redirectDelay instead of just the BOOL. (-[BrowserWebController cancelPendingRedirect]): Clear _redirectDelay. (-[BrowserWebController pendingRedirectDelay]): Return _redirectDelay. (-[BrowserWebController pageLoadingStatusHasChanged]): Test _redirectDelay.
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeStartedForDataSource:]): Don't clear redirectDelay yet. Wait for clientRedirectCancelled. (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): Adopt coding standards. clear redirectDelay (-[LocationChangeHandler webView:willCloseLocationForDataSource:]): Add LOG (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): Add LOG (-[LocationChangeHandler webView:clientWillRedirectTo:delay:fireDate:forFrame:]): Add LOG, set redirectDelay. (-[LocationChangeHandler webView:clientRedirectCancelledForFrame:]): Add LOG, clear redirectDelay.

BrowserWindowController.m: (-[BrowserWindowController frameLoadFinished:]): Renamed a variable, noted an existing bug.
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
GlobalHistory.m: (-[GlobalHistory parentOfContentItem:]): Added ASSERT.
LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): Comment out overly verbose, misfit LOG.

Two things going on here: 1) We changed the Patricia Trie data structure to
hold an array of bookmarks instead of just one with a refcount, to fix problems
when bookmarks were added/deleted. In addition, this also means that when we
have both a HistoryItem and Bookmark added, we prefer the Bookmark instead of
the History item. 2) Added code to pick the selected autocomplete element
based on various heuristics.

URLCompletionController.m: (isDeleted): Use deleted flag instead of refCount. (+[URLCompletionController _tree_create]): Set deleted instead of refCount. (_keyStringFromNode): Test deleted flag instead of isKindOf:NSString. This is functionally the same thing, but would make it easier to separate out the data structure into a reusable class someday. (_findPotentialNode): Added ASSERT. (setKeyForNode): New utility routine for setting the key of a node. (deleteKeyForNode): New utility routine for deleting the key of a node. (+[URLCompletionController _tree_addItem:]): Deal with all the cases of adding items and bookmarks in different order. (+[URLCompletionController _tree_deleteItem:]): Deal with all the cases of removing items and bookmarks in different order. (_rawStringFromItem): Handle the array-of-bookmarks case. (+[URLCompletionController _loadDB]): Use GlobalHistory instead of WebHistory so we know the thing will be created if needed. (-[URLCompletionController _queryStringForAbsoluteURL:fullScan:]): This is just code factored from the next method. (-[URLCompletionController _queryStringForString:fullScan:]): Cut out code of above method for factoring. (visitCountForResult): Calc the visit count for a given result. (-[URLCompletionController _indexOfBestMatch:]): Pick the best result. (-[URLCompletionController queryResultsForString:startingMatch:]): Call _indexOfBestMatch instead of just using 0. All other changes here are diff being dumb. (+[URLCompletionController _registerForNotifications]): Use GlobalHistory instead of WebHistory so we know the thing will be created if needed. (-[URLCompletionController _addStatsForURL:]): NOP'ed code.

This is all mostly sorting out the designated inits.

WebBookmark.h:
WebBookmark.m: (-[WebBookmark initFromDictionaryRepresentation:withGroup:]): Call super like a designated init should.
WebBookmarkGroup.h:
WebBookmark.h:
WebBookmark.m: (-[WebBookmarkLeaf setLastVisitedDate:]): New abstract method. (-[WebBookmarkLeaf lastVisitedDate]): New abstract method.
WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): Call super like a designated init should. (-[WebBookmarkLeaf initWithURLString: title:group:]): Call [self init] like a non-designated init should. (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): No need to free wasted entry now that this is a designated init. (-[WebBookmarkLeaf dictionaryRepresentation]): Nil out visitCount, since we don't want this to end up in the bookmarks file. (-[WebBookmarkLeaf copyWithZone:]): Do a real copy of the HistoryItem. (-[WebBookmarkLeaf setLastVisitedDate:]): New setter. (-[WebBookmarkLeaf lastVisitedDate]): New getter.
WebBookmarkList.m: (-[WebBookmarkList init]): Call super like a designated init should. (-[WebBookmarkList initWithTitle:group:]): Call [self init] like a non-designated init should. (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): Alloc _list, since we are a designated init.
WebBookmarkProxy.m: Nuke init method. Now that it is a designated init, it can use the inherited one. (-[WebBookmarkList initWithTitle:group:]): Call [self init] like a non-designated init should.

5:14 PM Changeset in webkit [3982] by darin

7 edits in branches/Safari-70-branch

Bumped versions to 70 and 1.0 Beta 2, regenerated strings files.

5:06 PM Changeset in webkit [3981] by rjw

2 edits in trunk/WebKit

Fixed 3213637. We weren't calling the correct delegate method,
setStatus: instead of webView:setStatus:

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView status:]):

4:51 PM Changeset in webkit [3980] by mjs

6 edits in trunk/WebKit

Reviewed by Chris.

fixed 3210813 - REGRESSION: full size stock chart on etrade shows up empty after viewing mini stock chart

I fixed this by adding a "negative cache" of icon URLs that loaded
something but failed to yield an icon. This prevents us from
asking for the site icon over and over, which was messing up the
session cookie.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconsForIconURLString:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
Misc.subproj/WebIconDatabasePrivate.h:
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader connectionDidFinishLoading:]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _iconLoaderReceivedPageIcon:]):

4:39 PM Changeset in webkit [3979] by darin

5 edits in trunk/WebKit

English.lproj/InfoPlist.strings: Changed "1.0 Beta" to "1.0 Beta 2".
WebKit.pbproj/project.pbxproj: Changed "1.0 Beta" to "1.0 Beta 2".

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

English.lproj/Localizable.strings: Regenerated (new script, "1.0 Beta 2").

4:38 PM Changeset in webkit [3978] by darin

4 edits in trunk/WebCore

English.lproj/InfoPlist.strings: Changed "1.0 Beta" to "1.0 Beta 2".
WebCore.pbproj/project.pbxproj: Changed "1.0 Beta" to "1.0 Beta 2".

4:37 PM Changeset in webkit [3977] by darin

4 edits in trunk/JavaScriptCore

English.lproj/InfoPlist.strings: Changed "1.0 Beta" to "1.0 Beta 2".
JavaScriptCore.pbproj/project.pbxproj: Changed "1.0 Beta" to "1.0 Beta 2".

2:46 PM Changeset in webkit [3976] by hyatt

4 edits in trunk/WebCore

Fixes for 3211862 and 3212750, add error-handling cases for
property values to the CSS parser so the whole sheet doesn't
get rejected.

Reviewed by darin

khtml/css/parser.cpp:
khtml/css/parser.y:

2:36 PM Changeset in webkit [3975] by rjw

6 edits in trunk/WebKit

WebKit:

Reviewed by darin.

History.subproj/WebHistory.h: Added use of WebHistoryItemsKey instead of @"Entries".

History.subproj/WebHistory.m:(-[WebHistory _sendNotification:entries:]): Use WebHistoryItemsKey as key instead of @"Entries".

History.subproj/WebHistoryItem.m: (-[WebHistoryItem init]): Fix double allocation of WebHistoryPrivate.

WebKit/WebKit.exp Added export for WebHistoryItemsKey

WebKit/API-Issues.rtf Notes.

WebBrowser:

Use WebHistoryItemsKey as key instead of @"Entries".

Reviewed by darin.

URLCompletionController.m: (+[URLCompletionController _historyAdded:]): (+[URLCompletionController _historyRemoved:]):

2:31 PM Changeset in webkit [3974] by darin

3 edits in trunk/WebCore

Reviewed by Chris.

fixed 3213093 -- REGRESSION: crash accessing menu items right after launch with about:blank as homepage

khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Another place needed a check for null.

1:44 PM Changeset in webkit [3973] by hyatt

3 edits in trunk/WebCore

Fix for 3211849. I accidentally removed a BORDER_COLOR case
from the switch when I removed the transparency check for
the shorthand. The case originally fell through to the case
below it, so a straight removal was wrong. I needed to add
it to the following set of case labels.

Reviewed by darin

khtml/css/cssstyleselector.cpp:

1:42 PM Changeset in webkit [3972] by darin

3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

improved default behaviors in window operations delegate

WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webViewShowWindowBehindFrontmost:]): Removed unused method. (-[WebDefaultWindowOperationsDelegate webViewCloseWindow:]): Added default implementation, calls close on window. (-[WebDefaultWindowOperationsDelegate webViewFocusWindow:]): Added default implementation, makeKeyAndOrderFront. (-[WebDefaultWindowOperationsDelegate webViewUnfocusWindow:]): Added default implementation, uses _cycleWindowsReversed as needed. (-[WebDefaultWindowOperationsDelegate webViewFirstResponderInWindow:]): Added default implementation, calls firstResponder. (-[WebDefaultWindowOperationsDelegate webView:makeFirstResponderInWindow:]): Added default implementation, calls makeFirstResponder. (-[WebDefaultWindowOperationsDelegate webViewIsResizable:]): Added default implementation, calls showsResizeIndicator. (-[WebDefaultWindowOperationsDelegate webView:setResizable:]): Added default implementation, calls setShowsResizeIndicator. (-[WebDefaultWindowOperationsDelegate webView:setFrame:]): Use display:YES, not display:NO. (-[WebDefaultWindowOperationsDelegate webViewFrame:]): Return NSZeroRect if window is nil instead of random garbage. (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Use display:YES, not display:NO. (-[WebDefaultWindowOperationsDelegate webViewContentRect:]): Return NSZeroRect if window is nil instead of random garbage. (-[WebDefaultWindowOperationsDelegate webView: runJavaScriptAlertPanelWithMessage:]): Added a FIXME because we should have a default implementation here. (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptConfirmPanelWithMessage:]): Ditto. (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): Put a default implementation here. (-[WebDefaultWindowOperationsDelegate webView:runOpenPanelForFileButtonWithResultListener:]): Added a FIXME because we should have a default implementation here.

WebBrowser:

Reviewed by Chris.

fixed 3213389 -- last tab can be left showing a close button (then you get assertion/badness if you close it)

BrowserWindowController.m: (-[BrowserWindowController closeTab:]): Be sure to turn off the close buttons even if the tab bar is invisible at the moment you close a tab (noticed by inspection, not the bug). (-[BrowserWindowController closeOtherTabs:]): Turn off the close buttons (this was the bug).

fixed 3213569 -- non-frontmost tabs can grab focus, causing crash later on

BrowserWebController.h: Remove "window" method.
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): Use the window controller's window so this works even for the non-frontmost tab. (-[BrowserWebController webViewShowWindowBehindFrontmost:]): Removed. Was eliminated from WebKit API, so unused. (-[BrowserWebController webViewUnfocusWindow:]): Removed. The WebKit default implementation now handles this fine. (-[BrowserWebController webViewIsResizable:]): Removed. The WebKit default implementation now handles this fine. (-[BrowserWebController webView:setResizable:]): Removed. The WebKit default implementation now handles this fine. (-[BrowserWebController window]): Removed. We don't want to override -[NSView window]. This fixed the bug. Had to visit all the various places window was called to make sure it was OK not to return the host window in the case of an inactive tab. (-[BrowserWebController webView:setFrame:]): Don't do anything for the case of the non-frontmost tab. (-[BrowserWebController webViewFrame:]): Use the window controller's window so this works even for the non-frontmost tab. (-[BrowserWebController webView:setContentRect:]): Don't do anything for the case of the non-frontmost tab. (-[BrowserWebController webViewContentRect:]): Use the window controller's window so this works even for the non-frontmost tab. (-[BrowserWebController webView:runJavaScriptAlertPanelWithMessage:]): Select the tab before putting up the panel. (-[BrowserWebController webView:runJavaScriptConfirmPanelWithMessage:]): Ditto. (-[BrowserWebController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): Ditto.

11:56 AM Changeset in webkit [3971] by hyatt

4 edits in trunk/WebCore

First-letter can be floated. Make sure we mutate the display
to BLOCK so that we don't make an inline when we're floating.
Fixes bug 3186004.

Reviewed by darin

khtml/rendering/render_block.cpp:

11:35 AM Changeset in webkit [3970] by cblu

16 edits in trunk/WebKit

Fixed: 3178058 - Plug-ins are stopped/reloaded when switching tabs
Made the "Enable plug-ins" preference toggle in real-time again.

No events including null events are sent when a plug-in is in a non-frontmost tab. This causes Flash movies to pause (which is nice) and QT movies to continue to play.

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): use the current window, clip out the plug-in when not in an actual window (-[WebBaseNetscapePluginView restorePortState:]): use the current window (-[WebBaseNetscapePluginView sendEvent:]): added asserts (-[WebBaseNetscapePluginView sendActivateEvent:]): tweak (-[WebBaseNetscapePluginView sendNullEvent]): tweak (-[WebBaseNetscapePluginView restartNullEvents]): tweak (-[WebBaseNetscapePluginView isInResponderChain]): tweak (-[WebBaseNetscapePluginView performKeyEquivalent:]): tweak (-[WebBaseNetscapePluginView canStart]): new, implemented by subclasses (-[WebBaseNetscapePluginView didStart]): new, implemented by subclasses (-[WebBaseNetscapePluginView addWindowObservers]): new (-[WebBaseNetscapePluginView removeWindowObservers]): new (-[WebBaseNetscapePluginView start]): check pref, call canStart, addWindowObservers and didStart (-[WebBaseNetscapePluginView stop]): call removeWindowObservers (-[WebBaseNetscapePluginView currentWindow]): new, returns the actual window else the host window (-[WebBaseNetscapePluginView initWithFrame:]): observer pref change notifications (-[WebBaseNetscapePluginView dealloc]): call removeObserver (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): stop if there is no host window (-[WebBaseNetscapePluginView viewDidMoveToWindow]): start if we moved to a window (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): stop if there will be no windows (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): start if there is a window (-[WebBaseNetscapePluginView preferencesHaveChanged:]): renamed, start or stop (-[WebBaseNetscapePluginView destroyStream:reason:]): tweak (-[NSData _web_locationAfterFirstBlankLine]): tweak
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]): call setAutoresizingMask here (-[WebNetscapePluginDocumentView canStart]): new, return YES if there is a data source (-[WebNetscapePluginDocumentView didStart]): redeliver the stream if there is any data (-[WebNetscapePluginDocumentView setDataSource:]): start if there is a current window (-[WebNetscapePluginDocumentView layout]): no need to call setWindow, this is done in the superclass (-[WebNetscapePluginDocumentView viewWillMoveToHostWindow:]): forward to super to make compiler happy (-[WebNetscapePluginDocumentView viewDidMoveToHostWindow]): forward to super to make compiler happy
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]): start the load (-[WebNetscapePluginEmbeddedView dataSource]): tweak
WebView.subproj/WebDocument.h: added viewWillMoveToHostWindow: and viewDidMoveToHostWindow
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _viewWillMoveToHostWindow:]): forward to document view and subframes (-[WebFrame _viewDidMoveToHostWindow]): forward to document view and subframes
WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToHostWindow:]): forward to plug-in views (-[WebHTMLView viewDidMoveToHostWindow]): forward to plug-in views (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): new
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _reset]): don't stop plug-ins here. WebBaseNetscapePluginView can handle that
WebView.subproj/WebImageView.m: (-[WebImageView viewWillMoveToHostWindow:]): implement new WebDocumentView methods (-[WebImageView viewDidMoveToHostWindow]): implement new WebDocumentView methods
WebView.subproj/WebTextView.m: (-[WebTextView viewWillMoveToHostWindow:]): implement new WebDocumentView methods (-[WebTextView viewDidMoveToHostWindow]): implement new WebDocumentView methods
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView setHostWindow:]): new (-[WebView hostWindow]): new
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): release the host window

10:44 AM Changeset in webkit [3969] by darin

2 edits in trunk/WebKit

WebKit:

Reviewed by John.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge nextKeyViewOutsideWebFrameViews]): Get next key view from WebView, only using the top level WebFrameView if the WebView doesn't have one set (for compatibility in case some of our current WebKit clients are using this). (-[WebBridge previousKeyViewOutsideWebFrameViews]): Ditto.

WebBrowser:

Reviewed by John.

fixed 3213095 -- REGRESSION: can't clear History; selector removeAllEntries not recognized

GlobalHistory.m: (-[GlobalHistory appendClearHistoryItemToMenuWithEnabledState:]): Use the new name, removeAllItems, instead of the old name removeAllEntries.

use the WebView for the keyboard loop rather than going at the WebFrameView explicitly

BrowserWindowController.m: (-[BrowserWindowController updateKeyboardLoop]): Just use WebView instead of digging in for the WebFrameView.

10:29 AM Changeset in webkit [3968] by darin

4 edits in trunk/WebKit

Reviewed by John.

fixed 3211730 -- REGRESSION: Flash spawns blank page then loads new page inside banner itself

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Load the request in the frame we found or created, not always in our own frame (oops!).

other changes

History.subproj/WebHistory.h: Update comments to all say "Item" instead of "Entry". They didn't match the method names any more.

WebView.subproj/WebView.m: (-[WebView acceptsFirstResponder]): Return YES. (-[WebView becomeFirstResponder]): Pass first responder on to the WebFrameView in the same way the WebFrameView passes it on to the document view.

10:23 AM Changeset in webkit [3967] by darin

5 edits in trunk/WebCore

Reviewed by John.

fixed 3213093 -- accessing menu items immediately after launch causes crash when about:blank is homepage

khtml/khtmlview.cpp: (isSubmitImage): Add check for node of 0.

fixed 3211461 -- crash in KWQListIteratorImpl tabbing through w3c test page

kwq/KWQKHTMLPart.h: Added childFrameForPart function, better than KHTMLPart::frame because it works for HTML frames inside objects as well as plain old HTML frames.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::childFrameForPart): Like KHTMLPart::frame, but looks through m_objects too. (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrameForPart instead of frame function.

Mar 30, 2003:

7:36 PM Changeset in webkit [3966] by mjs

4 edits in trunk/WebKit

Reviewed by Darin.

fixed 3204257 - CNN's 'war on iraq' ticker stops on mouseover

WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]): When leaving an HTML view, tell it that the mouse moved outside everything in the view, even accounting for scrolled off portions (otherwise khtml gets confused). This makes cross-frame mouse enter/leave work properly. (-[WebHTMLView _clearLastHitViewIfSelf]): Method to clear last hit view, so we don't need to retain it.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView dealloc]): Call _clearLastHitViewIfSelf.

6:53 PM Changeset in webkit [3965] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3206524 - incyte.com "load properties" function does not work

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Make sure to clear the tokenizer before firing the onLoad handler, otherwise document.write from inside an onLoad handler will fail.
khtml/xml/dom_docimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Call closeInternal. (DocumentImpl::closeInternal): New version of close that allows bypassing the tokenizer null check, in case we already deleted the tokenizer/

12:10 AM Changeset in webkit [3964] by mjs

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3169064 - can't search at lonelyplanet.com; onSubmit handler fails due to problem addressing radio button

khtml/ecma/kjs_dom.cpp: (DOMNamedNodesCollection::tryGet): Allow lookup by id as well as by integer index.

Mar 29, 2003:

11:22 PM Changeset in webkit [3963] by mjs

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3138427 - new window opened by javascript is too small for popcap.com game

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Be a bit more tolerant of misformatted attribute strings.

11:20 PM Changeset in webkit [3962] by mjs

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3180786 - Can't log in to the LL Bean Web site

The problem on this site was misnested tags, leading to two FORM
elements that were nested. Both their onSubmit handlers fired, and
the outer one returned false. The fix was to avoid bubbling submit
events, since this can never be useful in a valid document and
because that is what other browsers seem to do, and what Win IE
documents.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::prepareSubmit): Don't allow the submit event to bubble.

4:46 PM Changeset in webkit [3961] by mjs

2 edits in trunk/WebCore

Corrected reviewer in ChangeLog.

4:46 PM Changeset in webkit [3960] by mjs

3 edits in trunk/WebCore

Reviewed by Ken.

improved on Darin's fix for 3211289 - REGRESSION: nil-deref in bridgeForWidget

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForWidget): Special-case KHTMLView - this is the only kind of widget in the program that's not a form control (so nodeForWidget would return nil for it).

Mar 28, 2003:

3:14 PM Changeset in webkit [3959] by rjw

3 edits in trunk/WebKit

WebKit:

Fix typo in comments that broke headerdoc.

Reviewed by me.

WebView.subproj/WebWindowOperationsDelegate.h:

Tests:

Fixed Carbon compile problems in example app.

Reviewed by me.

Carbon/CarbonWeb/CarbonWeb.h:
Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:pluginFailedWithError:dataSource:]):
Carbon/CarbonWeb/THistoryMenu.cp:
Carbon/CarbonWeb/TWebWindow.cp:
Carbon/CarbonWeb/main.c: (main):

2:05 PM Changeset in webkit [3958] by hyatt

3 edits in trunk/WebCore

Fix a regression caused by my addition of nearestFloatBottom
to the code. I needed to make that a loop rather than just call
it once, since the nearestFloatBottom could be a bad position
for the next line.

This fixes the overlapping text problem at CNN: 3186593.

Reviewed by john

khtml/rendering/bidi.cpp:

12:09 PM Changeset in webkit [3957] by darin

6 edits in trunk/WebCore

Reviewed by Ken.

fixed 3191163 -- hang in QPtrListIterator at www.phiffer.com
fixed 3183520 -- XML page has no vertical scrollbar

The hang was due to an exponential algorithm in lowest/rightmostPosition.
Fixed by making some simplifications to these functions, used only to determine the size
of the entire web page. While doing that I cleared some things up that made the XML
scroll bar problem go away too.

Note that www.phiffer.com still does not render right.

khtml/rendering/render_block.cpp: (RenderBlock::lowestPosition): Since this is always called on the whole tree, don't worry about which parent deals with which child. Just make sure that every object is visited exactly once. (RenderBlock::rightmostPosition): Ditto.
khtml/rendering/render_html.cpp: (RenderHtml::layout): Use the result from calling lowestPosition on the root, since some floating/positioned objects hang off there, rather than here. This seems consistent with the long term approach of doing more work in the root and less in RenderHtml, since XML documents don't have a RenderHtml.
khtml/rendering/render_root.cpp: (RenderRoot::docHeight): Call lowestPosition() on self rather than on children. Now that I understand the method, it's clear this is the correct way to do things. (RenderRoot::docWidth): Ditto, but rightmostPosition().

fixed 3211289 -- REGRESSION: nil-deref in bridgeForWidget

Maciej may have some ideas about how to fix this even better, but this
is better than just rolling his change out.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewForWidget): Added an assertion. (KWQKHTMLPart::bridgeForWidget): Handle case where node is 0 by returning 0. (KWQKHTMLPart::partForNode): Added an assertion. (KWQKHTMLPart::nodeForWidget): Handle case where eventFilterObject is 0 by returning 0. (KWQKHTMLPart::setDocumentFocus): Quietly do nothing if the node is 0. (KWQKHTMLPart::clearDocumentFocus): Quietly do nothing if the node is 0.

11:47 AM Changeset in webkit [3956] by kocienda

5 edits in trunk/WebKit

WebFoundation:

Reviewed by John

Made SPI out of NSURLConnection code that did not make the API cut.

Removed timeout interval code from NSURLConnection. This is now
a per-request value.

SPI added to NSURLRequest to modify the default per-request
timeout interval.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection resourceLoaderRunLoop]): (-[NSURLConnection setDefersCallbacks:]): (-[NSURLConnection defersCallbacks]): (-[NSURLConnection _checkIfTimedOut]):
CacheLoader.subproj/NSURLConnectionPrivate.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithURL:]): (-[NSURLRequest timeoutInterval]): (+[NSURLRequest setDefaultTimeoutInterval:]): (+[NSURLRequest defaultTimeoutInterval]):
CacheLoader.subproj/NSURLRequestPrivate.h:
CookieManager.subproj/WebCookieManager.m:
ProtocolHandlers.subproj/WebFTPProtocol.m:
ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:

WebKit:

Reviewed by John

Imports NSURLConnection private header to access NSURLConnection code
that did not make the API cut.

WebView.subproj/WebBaseResourceHandleDelegate.m:
WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Reviewed by John

There is now a per-request timeout for NSURLRequest instead
of one default on the NSURLConnection class. Error string
code updated to account for this.

PageLoadTestRunner now uses SPI added to NSURLRequest to
modify the default timeout interval.

LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]):
Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):

10:42 AM Changeset in webkit [3955] by kocienda

5 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

Moved to API-approved model for synchronous loads.
Removed some files made obsolete by this change.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]):
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate resourceData]):
CacheLoader.subproj/WebSynchronousResult.h: Removed.
CacheLoader.subproj/WebSynchronousResult.m: Removed.
CacheLoader.subproj/WebSynchronousResultPrivate.h: Removed.
ChangeLog:
Misc.subproj/WebFoundation.h:
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

Moved to API-approved model for synchronous loads.
Removed fixme I put in yesterday having to do with
reposting form data. The feature is fully functional
again.

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _continueAfterNavigationPolicy:]):

WebBrowser:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):

9:28 AM Changeset in webkit [3954] by kocienda

12 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Cosmetic change. Instances of 'resource' as a local variable
name have been changed to 'connection'. Some other changes
related to this cosmetic cleanup were done as well.

Also updated some comments.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection initWithRequest:]): (+[NSURLConnection sendSynchronousRequest:]): (+[NSURLConnection _forceSingleLoad]): (-[NSURLConnection _postCallback:]): (-[NSURLConnectionInternal redirectedToRequest:permanent:]): (-[NSURLConnectionInternal responseAvailable:]): (-[NSURLConnectionInternal didLoadBytes:length:]): (-[NSURLConnectionInternal invalidateCacheObject]): (-[NSURLConnectionInternal finishedLoading]): (-[NSURLConnectionInternal failedWithError:]):
CacheLoader.subproj/NSURLConnectionQueue.h:
CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate dealloc]): (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate connection]):

WebKit:

Reviewed by Darin

Cosmetic change. Instances of 'resource' as a local variable
name have been changed to 'connection'. Some other changes
related to this cosmetic cleanup were done as well.

As part of this change, I needed to change some 'connection'
method arguments to 'con' to avoid the name conflict now
that instance variables are named .connection'.

Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]): (-[WebDownload _downloadEnded]): (-[WebDownload _cancelWithError:]):
Downloads.subproj/WebDownloadPrivate.h:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didReceiveResponse:]): (-[WebNetscapePluginStream connection:didReceiveData:]): (-[WebNetscapePluginStream connectionDidFinishLoading:]): (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): (-[WebSubresourceClient connection:didReceiveResponse:]): (-[WebSubresourceClient connection:didReceiveData:]): (-[WebSubresourceClient connectionDidFinishLoading:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connection:didReceiveData:]): (-[WebMainResourceClient connectionDidFinishLoading:]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebMainResourceClient startLoading:]):

8:28 AM Changeset in webkit [3953] by kocienda

14 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

PDFBundle/PDFView.m: (-[PDFResourceDelegate connection:willSendRequest:redirectResponse:]): (-[PDFResourceDelegate connection:didReceiveResponse:]): (-[PDFResourceDelegate connection:didReceiveData:]): (-[PDFResourceDelegate connectionDidFinishLoading:]): (-[PDFResourceDelegate connection:didFailLoadingWithError:]):

WebFoundation:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _sendWillSendRequestCallback]): (-[NSURLConnection _sendDidReceiveResponseCallback]): (-[NSURLConnection _sendDidReceiveDataCallback]): (-[NSURLConnection _sendDidFailLoadingCallback]): (-[NSURLConnection _sendDidFinishLoadingCallback]):
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate connection:willSendRequest:redirectResponse:]): (-[WebSynchronousDelegate connectionDidFinishLoading:]): (-[WebSynchronousDelegate connection:didReceiveResponse:]): (-[WebSynchronousDelegate connection:didReceiveData:]):

WebKit:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

Downloads.subproj/WebDownload.h:
Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload connection:willSendRequest:redirectResponse:]): (-[WebDownload connection:didReceiveResponse:]): (-[WebDownload connection:didReceiveData:]): (-[WebDownload connectionDidFinishLoading:]): (-[WebDownload connection:didFailLoadingWithError:]):
Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): (-[WebIconLoader connection:willSendRequest:redirectResponse:]): (-[WebIconLoader connection:didReceiveResponse:]): (-[WebIconLoader connection:didReceiveData:]): (-[WebIconLoader connection:didFailLoadingWithError:]):
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didReceiveResponse:]): (-[WebNetscapePluginStream connection:didReceiveData:]): (-[WebNetscapePluginStream connectionDidFinishLoading:]): (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): (-[WebSubresourceClient connection:didReceiveResponse:]): (-[WebSubresourceClient connection:didReceiveData:]): (-[WebSubresourceClient connectionDidFinishLoading:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connection:didReceiveData:]): (-[WebMainResourceClient connectionDidFinishLoading:]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy connection:willSendRequest:redirectResponse:]): (-[WebResourceDelegateProxy connection:didReceiveResponse:]): (-[WebResourceDelegateProxy connection:didReceiveData:]): (-[WebResourceDelegateProxy connectionDidFinishLoading:]): (-[WebResourceDelegateProxy connection:didFailLoadingWithError:]):
WebView.subproj/WebResourceLoadDelegate.h:

WebBrowser:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

BugReportController.m: (-[BugReportController connection:willSendRequest:redirectResponse:]): (-[BugReportController connection:didReceiveResponse:]): (-[BugReportController connection:didReceiveData:]): (-[BugReportController connectionDidFinishLoading:]): (-[BugReportController connection:didFailLoadingWithError:]):

Mar 27, 2003:

6:17 PM Changeset in webkit [3952] by hyatt

5 edits in trunk/WebCore

A collection of fixes for tables.

(1) Fixed table layout should only be used if an explicit width
is specified on a table.
(2) width="0" and height="0" should be ignored on table cells!
(3) Fixed table layout wasn't spreading extra space over
columns.

Reviewed by mjs

khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseAttribute):
khtml/rendering/render_table.cpp: (RenderTable::setStyle):
khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):

3:43 PM Changeset in webkit [3951] by hyatt

3 edits in trunk/WebCore

Fix for the top of directory.apple.com. Only use the fixed
width on the cell (with nowrap set) if it is *larger* than
our current minwidth.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):

3:38 PM Changeset in webkit [3950] by cblu

2 edits in trunk/WebKit

Left out a "!" in my last check-in.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

3:05 PM Changeset in webkit [3949] by hyatt

6 edits in trunk/WebCore

Fix for 3166374. When a float is removed, crawl up and down the
tree looking for blocks that contain the float and dirty them all.

Reviewed by darin

ChangeLog:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_object.cpp: (RenderObject::markAllDescendantsWithFloatsForLayout): (RenderObject::removeFromObjectLists):
khtml/rendering/render_object.h:

2:57 PM Changeset in webkit [3948] by cblu

2 edits in trunk/WebKit

Allow Netscape plug-ins that don't have resource files to load in Safari.
Added more error handling when loading plug-ins.

Reviewed by darin.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

2:49 PM Changeset in webkit [3947] by mjs

11 edits in trunk

WebCore:

Reviewed by Darin.

fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
fixed 3098365 - Default window size changes as a result of popup windows
fixed 3189291 - javascript window.close() closes window, not just originating tab

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Close via the bridge, not the window directly. (KWQKHTMLPart::bridgeForWidget): Take const QWidget * instead of QWidget *. (KWQKHTMLPart::nodeForWidget): Likewise. (KWQKHTMLPart::khtmlMousePressEvent): Deal with responder issues via bridge, not window directly. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Likewise. (KWQKHTMLPart::mouseDown): Likewise.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set resizability via bridge, not window directly.
kwq/KWQTextArea.mm: (-[KWQTextArea becomeFirstResponder]): Deal with bridge for first responder issues, not window directly. (-[KWQTextArea drawRect:]): Likewise. (-[KWQTextAreaTextView insertTab:]): Likewise. (-[KWQTextAreaTextView insertBacktab:]): Likewise. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Likewise. (-[KWQTextAreaTextView selectedTextAttributes]): Likewise.
kwq/KWQWidget.mm: (QWidget::setActiveWindow): Focus window via bridge. (QWidget::hasFocus): Handle first responder issues via bridge. (QWidget::setFocus): Likewise. (QWidget::isVisible): Get window from bridge. (QWidget::mapFromGlobal): Get window from bridge. (QWidget::disableFlushDrawing): Add comment noting why it's OK to get the window from the view instead of from the bridge here. (QWidget::enableFlushDrawing): Likewise.
kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Work through bridge, not window directly. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::setFrameGeometry): Likewise.
kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
fixed 3098365 - Default window size changes as a result of popup windows
fixed 3189291 - javascript window.close() closes window, not just originating tab

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowIsResizable:]): New bridge method, implemented by calling window operations delegate. (-[WebBridge windowIsResizable]): Likewise. (-[WebBridge firstResponder]): Likewise. (-[WebBridge makeFirstResponder:]): Likewise. (-[WebBridge closeWindow]): Likewise.

WebBrowser:

Reviewed by Darin.

fixed 3189291 - javascript window.close() closes window, not just originating tab

BrowserWebController.m: (-[BrowserWebController windowController]): Moved this method higher. (-[BrowserWebController webViewCloseWindow:]): Close the tab, not the window.
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController closeTabForWebController:]): New method, closes tab or window if there is only one tab.

2:24 PM Changeset in webkit [3946] by kocienda

29 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

HeaderView/DocumentController.m:
IBViewer/DocumentController.m:
PDFBundle/PDFView.h:
PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFResourceDelegate resource:didReceiveResponse:]): (-[PDFResourceDelegate resource:didReceiveData:]): (-[PDFResourceDelegate resourceDidFinishLoading:]): (-[PDFResourceDelegate resource:didFailLoadingWithError:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
SimpleViewer/DocumentController.m:

WebFoundation:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/WebCacheManager.m:
CacheLoader.subproj/WebProtocol.m: (-[WebProtocol initWithProtocolClient:request:]):
CacheLoader.subproj/WebResourceDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate resource]): (-[WebSynchronousDelegate resource:willSendRequest:]): (-[WebSynchronousDelegate resourceDidFinishLoading:]): (-[WebSynchronousDelegate resource:didReceiveResponse:]): (-[WebSynchronousDelegate resource:didReceiveData:]):
CacheLoader.subproj/WebSynchronousResult.h:
CookieManager.subproj/WebCookieManager.m: (runningOnLoadThread): (-[WebCookieManager _scheduleSetupOnLoadThread]):
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebFoundation.h:
Misc.subproj/WebFoundationLogging.h:
Misc.subproj/WebFoundationLogging.m:
Misc.subproj/WebFoundationPrivate.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol deallocateCFNetworkResources]): (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): (-[WebCFNetworkHTTPProtocol handleReadStreamEvent:event:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoadingWithCacheObject:]): (-[WebFTPProtocol stopLoading]):
ProtocolHandlers.subproj/WebFileProtocol.m:
ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m: (-[WebSSLProxyWrapperStream cancel]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (WebSimpleHTTPProtocolInit):
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]): (-[WebDownload resource:willSendRequest:]): (-[WebDownload resource:didReceiveResponse:]): (-[WebDownload resource:didReceiveData:]): (-[WebDownload resourceDidFinishLoading:]): (-[WebDownload resource:didFailLoadingWithError:]):
Downloads.subproj/WebDownloadPrivate.h:
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resourceDidFinishLoading:]): (-[WebIconLoader resource:willSendRequest:]): (-[WebIconLoader resource:didReceiveResponse:]): (-[WebIconLoader resource:didReceiveData:]): (-[WebIconLoader resource:didFailLoadingWithError:]):
Plugins.subproj/WebNetscapePluginStream.h:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream resource:didReceiveResponse:]): (-[WebNetscapePluginStream resource:didReceiveData:]): (-[WebNetscapePluginStream resourceDidFinishLoading:]): (-[WebNetscapePluginStream resource:didFailLoadingWithError:]):
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:willSendRequest:]): (-[WebSubresourceClient resource:didReceiveResponse:]): (-[WebSubresourceClient resource:didReceiveData:]): (-[WebSubresourceClient resourceDidFinishLoading:]): (-[WebSubresourceClient resource:didFailLoadingWithError:]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]): (-[WebResourceDelegateProxy setDelegate:]): (-[WebResourceDelegateProxy resource:willSendRequest:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]): (-[WebResourceDelegateProxy resource:didReceiveData:]): (-[WebResourceDelegateProxy resourceDidFinishLoading:]): (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]):
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
BugReportController.h:
BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]): (-[BugReportController resource:didReceiveResponse:]): (-[BugReportController resource:didReceiveData:]): (-[BugReportController resourceDidFinishLoading:]): (-[BugReportController resource:didFailLoadingWithError:]):
ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
DownloadMonitor.m:
LoadProgressMonitor.h:
LoadProgressMonitor.m:
LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]):
Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):

1:45 PM Changeset in webkit [3945] by rjw

5 edits in trunk/WebKit

WebKit:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (-[WebHistory initWithContentsOfURL:]): (-[WebHistory URL]):
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate initWithContentsOfURL:]): (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate _loadHistoryGuts:]): (-[WebHistoryPrivate loadHistory]): (-[WebHistoryPrivate _saveHistoryGuts:]): (-[WebHistoryPrivate URL]): (-[WebHistoryPrivate saveHistory]):

WebBrowser:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
GlobalHistory.m: (-[GlobalHistory init]):

12:24 PM Changeset in webkit [3944] by darin

3 edits in trunk/WebKit

Reviewed by Shelley.

fixed 3157067 -- Pier1.com doesn't load; Microsoft VBScript runtime error in user-agent checking code

Besides this fix, I also filed an evangelism bug, bug 3210612.

WebView.subproj/WebUserAgentSpoofTable.gperf: Added pier1.com.
WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

11:59 AM Changeset in webkit [3943] by kocienda

12 edits in trunk/WebKit

Tools:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

WebDiskCacheInspector/Controller.m: (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):

Tests:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.
Includes these method name changes:

replacemethod "resultCode" with "statusCode"
replacemethod "setResultCode:" with "setStatusCode:"
replacemethod "localizedStringForResultCode:" with "localizedStringForStatusCode:"
replacemethod "isErrorResultCode:" with "isErrorStatusCode:"
replacemethod "contentType" with "MIMEType" /* for NSURLResponse */
replacemethod "contentLength" with "expectedContentLength"
replacemethod "setContentType:" with "setMIMEType:"
replacemethod "setContentLength:" with "setExpectedContentLength:"

Other changes:

Bumped NSURLResponseVersion.
Removed WebError from NSURLResponse. Error object now tracked in WebResource.
Moved NSHTTPURLResponse into NSURLResponse header.
Bumped WebCacheObjectVersion.

CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponseInternal init]): (-[NSURLResponseInternal dealloc]): (-[NSURLResponse initWithCoder:]): (-[NSURLResponse encodeWithCoder:]): (-[NSURLResponse MIMEType]): (-[NSURLResponse expectedContentLength]): (-[NSURLResponse setExpectedContentLength:]): (-[NSURLResponse setMIMEType:]): (-[NSURLResponse createdDate]): (-[NSURLResponse lastModifiedDate]): (-[NSHTTPURLResponseInternal initWithCoder:]): (-[NSHTTPURLResponseInternal encodeWithCoder:]): (-[NSHTTPURLResponseInternal dealloc]): (-[NSHTTPURLResponse init]): (-[NSHTTPURLResponse initWithCoder:]): (-[NSHTTPURLResponse encodeWithCoder:]): (-[NSHTTPURLResponse allHeaderFields]): (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (-[NSHTTPURLResponse setHeader:]): (-[NSHTTPURLResponse dealloc]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
CacheLoader.subproj/NSURLResponsePrivate.h:
CacheLoader.subproj/WebCacheObject.m:
CacheLoader.subproj/WebMutableResponse.h:
CacheLoader.subproj/WebResource.m: (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _sendDidFailLoadingCallback]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource _responseAvailable:]): (-[WebResource _didLoadBytes:length:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource _setError:]): (-[WebResourceInternal dealloc]): (-[WebResourceInternal failedWithError:]):
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate result]):
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/NSHTTPURLResponse.h:
ProtocolHandlers.subproj/NSHTTPURLResponse.m: (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
ProtocolHandlers.subproj/NSHTTPURLResponsePrivate.h:
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol sendResponseAvailableCallback]): (-[WebHTTPProtocol canStoreCacheObject:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _processHTTPResultCode]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

Downloads.subproj/WebDownload.m:
Misc.subproj/WebNSURLResponseExtras.m: (-[NSURLResponse suggestedFilenameForSaving]): (-[NSHTTPURLResponse suggestedFilenameForSaving]):
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): (-[WebDataSource _commitIfReady:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): (-[WebFrame _loadItem:fromItem:withLoadType:]):
WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]):
WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]):
WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):

WebBrowser:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

BrowserDocument.m: (-[BrowserDocument fileType]):
DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]):
LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
ResourceProgressEntry.h:
ResourceProgressEntry.m: (-[ResourceProgressEntry statusCode]): (-[ResourceProgressEntry setStatusCode:]): (-[ResourceProgressEntry statusString]):

11:26 AM Changeset in webkit [3942] by hyatt

3 edits in trunk/WebCore

This is just a long-standing screwup where I didn't port an old
table fix I made to Lars' new table code properly. The original
fix had this check in it.

The bug is 3171963 (cvs.com).

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

10:52 AM Changeset in webkit [3941] by darin

4 edits in trunk/WebCore

Reviewed by Trey.

fixed 3156509 -- Safari fills src="" frame with current contents of frameset instead of leaving it empty

The trick here is to always use "about:blank" when the frame URL is empty string.
If we pass the empty string elsewhere, it's going to get passed to completeURL and
turned into a reference to the current document, and we have to avoid doing that
ourselves explicitly too.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::HTMLFrameElementImpl): Let the URL default to null rather than "about:blank". We do want to treat the frame as "about:blank", but that's not something people should see when inspecting the frame via the DOM. (HTMLFrameElementImpl::isURLAllowed): Allow empty URLs explicitly, so we don't call completeURL on them. (HTMLFrameElementImpl::updateForNewURL): Map empty URLs to "about:blank" at this level. (HTMLFrameElementImpl::attach): Do the same thing here. At some point we can share more code between these two. (HTMLFrameElementImpl::setLocation): Change this to call updateForNewURL. Not only does this make us handle the empty URL case properly, it also gets the benefit of other things we do in updateForNewURL, like handling the "isURLAllowed" rule, and properly handling the case where we already have a suitable frame.

other changes

kwq/KWQKHTMLView.mm: Improved a comment.

10:39 AM Changeset in webkit [3940] by sheridan

3 edits in trunk

Safari-70u ... tree's open again

10:24 AM Changeset in webkit [3939]

3 copies in branches/Safari-70-branch

This commit was manufactured by cvs2svn to create branch
'Safari-70-branch'.

10:24 AM Changeset in webkit [3938]

3 copies in tags/Safari-70-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-70-anchor'.

10:24 AM Changeset in webkit [3937]

3 copies in branches/Safari-69~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-69~1-branch'.

10:24 AM Changeset in webkit [3936]

3 copies in tags/Safari-69~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-69~1-anchor'.

10:24 AM Changeset in webkit [3935]

3 copies in tags/Safari-69

This commit was manufactured by cvs2svn to create tag 'Safari-69'.

10:24 AM Changeset in webkit [3934] by sheridan

8 edits in trunk

Safari-69 stamp

Mar 26, 2003:

8:05 PM Changeset in webkit [3933] by rjw

6 edits in trunk/WebKit

File name change WebPluginError.[hm] -> WebPlugInError.[hm]

Misc.subproj/WebKit.h:
Plugins.subproj/WebNullPluginView.m:
Plugins.subproj/WebPlugInError.h:
Plugins.subproj/WebPluginError.h: Removed.
Plugins.subproj/WebPluginError.m: Removed.
Plugins.subproj/WebPluginErrorPrivate.h:
WebKit.pbproj/project.pbxproj:

7:05 PM Changeset in webkit [3932] by rjw

10 edits in trunk/WebKit

WebKit:

WebPreferences API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled
allowAnimatedImageLooping -> allowsAnimatedImageLooping
setAllowAnimatedImageLooping -> setAllowsAnimatedImageLooping
allowAnimatedImages -> allowsAnimatedImages
setAllowAnimatedImages -> setAllowsAnimatedImages

Made WebHistoryItem's ivars private.

WebPluginError API changes:

pluginPageURL -> plugInPageURLString
contentURL -> contentURLString

Reviewed by cblu.

API-Issues.rtf:
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem init]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setDisplayTitle:]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedDate]): (-[WebHistoryItem hash]): (-[WebHistoryItem anchor]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem parent]): (-[WebHistoryItem setURL:]): (-[WebHistoryItem setOriginalURLString:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setParent:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem documentState]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]): (-[WebHistoryItem setAnchor:]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem setIsTargetItem:]): (-[WebHistoryItem _recurseToFindTargetItem]): (-[WebHistoryItem targetItem]): (-[WebHistoryItem formData]): (-[WebHistoryItem setFormData:]): (-[WebHistoryItem formContentType]): (-[WebHistoryItem setFormContentType:]): (-[WebHistoryItem formReferrer]): (-[WebHistoryItem setFormReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem addChildItem:]): (-[WebHistoryItem childItemWithName:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem alwaysAttemptToUsePageCache]): (-[WebHistoryItem _scheduleRelease]): (-[WebHistoryItem setHasPageCache:]): (-[WebHistoryItem pageCache]):
Plugins.subproj/WebPluginError.h:
Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURLString]):
WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences isJavaEnabled]): (-[WebPreferences setIsJavaEnabled:]): (-[WebPreferences isJavaScriptEnabled]): (-[WebPreferences setIsJavaScriptEnabled:]): (-[WebPreferences javaScriptCanOpenWindowsAutomatically]): (-[WebPreferences arePlugInsEnabled]): (-[WebPreferences setArePlugInsEnabled:]): (-[WebPreferences allowsAnimatedImages]): (-[WebPreferences allowsAnimatedImageLooping]): (-[WebPreferences setAllowsAnimatedImageLooping:]): (-[WebPreferences setLoadsImagesAutomatically:]): (-[WebPreferences loadsImagesAutomatically]):
WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebBrowser:

WebPrefernces API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
pluginPageURL -> plugInPageURLString
contentURL -> contentURLString
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled

Reviewed by cblu.

AppController.m: (-[AppController validateUserInterfaceItem:]): (-[AppController toggleJavaScriptCanNotOpenWindows:]):
LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences toggleJavaScriptCanOpenWindows:]): (-[SecurityPreferences updateJavaScriptViews]): (-[SecurityPreferences togglePluginsEnabled:]): (-[SecurityPreferences initializeFromDefaults]):

6:56 PM Changeset in webkit [3931] by mjs

3 edits in trunk/WebCore

Reviewed by Chris.

fix unitialized access.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart):

5:57 PM Changeset in webkit [3930] by mjs

12 edits in trunk/WebCore

Reviewed by Trey.

Made progress towards better handling of window operations.

khtml/ecma/kjs_window.cpp: (Window::get): Replace a few part->widget() calls with part->view() -- just as good for the real khtml, but easier to adapt to with KWQ. (WindowFunc::tryCall): Likewise.
khtml/khtmlview.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): Delete the window widget. (KWQKHTMLPart::topLevelWidget): Return the window widget. (KWQKHTMLPart::setBridge): Make a new window widget passing it the bridge.
kwq/KWQKHTMLView.mm: (KHTMLView::topLevelWidget): Moved here from KHTMLView; get the top level widget from the part. (KHTMLView::mapToGlobal): Moved here from KHTMLView; add a needed cast.
kwq/KWQWidget.h:
kwq/KWQWidget.mm: Remove all top level widget considerations.
kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Changed to work based on bridge, not window. (KWQWindowWidget::~KWQWindowWidget): Ditto. (KWQWindowWidget::frameGeometry): Ditto. (KWQWindowWidget::mapToGlobal): Ditto. (KWQWindowWidget::mapFromGlobal): Ditto. (KWQWindowWidget::setFrameGeometry): Ditto.

Also:

kwq/KWQKHTMLPart.cpp: Removed stuff that did not belong here.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::selectionStartOffset): Moved here from KWQKHTMLPart.cpp (KWQKHTMLPart::selectionEndOffset): Likewise. (KWQKHTMLPart::selectionStart): Likewise. (KWQKHTMLPart::selectionEnd): Likewise. (KWQKHTMLPart::selectionRect): Likesie.

4:13 PM Changeset in webkit [3929] by darin

4 edits in trunk/WebCore

Reviewed by Trey.

fixed a storage leak when running cvs-base

khtml/rendering/render_list.h: Added _markerInstalledInParent.
khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Set _markerInstalledInParent to false when creating a new marker. (RenderListItem::detach): Detach the marker if it's not not installed in the parent yet. (RenderListItem::updateMarkerLocation): Set _markerInstalledInParent to true when installing the marker in a parent.

3:41 PM Changeset in webkit [3928] by hyatt

3 edits in trunk/WebCore

Make <label> use tag list 1. Fixes 3206063. Residual style
changes called this out.

Reviewed by darin

khtml/html/dtd.cpp: (DOM::checkChild):

3:12 PM Changeset in webkit [3927] by kocienda

39 edits
2 deletes in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

Carbon/CarbonWeb/MyWebEventTypes.h:
Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]):
Carbon/CarbonWeb/TWebWindow.cp:
Downloader/MyDocument.h:
Downloader/MyDocument.m: (-[MyDocument download:didReceiveResponse:]):
PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:didReceiveResponse:]):
SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

CacheLoader.subproj/WebCacheObject.h:
CacheLoader.subproj/WebCacheObject.m: (+[WebCacheObject cacheObjectWithResponse:]): (-[WebCacheObject initWithCoder:]): (-[WebCacheObject response]): (-[WebCacheObject setResponse:]):
CacheLoader.subproj/WebProtocol.h:
CacheLoader.subproj/WebProtocol.m:
CacheLoader.subproj/WebProtocolClient.h:
CacheLoader.subproj/WebResource.h:
CacheLoader.subproj/WebResource.m: (-[WebResource _responseAvailable:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource response]): (-[WebResourceInternal response]): (-[WebResourceInternal responseAvailable:]):
CacheLoader.subproj/WebResourceDelegate.h:
CacheLoader.subproj/WebResourceQueue.m:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate response]): (-[WebSynchronousDelegate resource:didReceiveResponse:]):
CacheLoader.subproj/WebSynchronousResult.h:
CacheLoader.subproj/WebSynchronousResult.m: (-[WebSynchronousResult response]): (-[WebSynchronousResult _setResponse:]):
CacheLoader.subproj/WebSynchronousResultPrivate.h:
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol canStoreCacheObject:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

Downloads.subproj/WebDownload.h:
Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setResponse:]): (-[WebDownload resource:didReceiveResponse:]):
Downloads.subproj/WebDownloadPrivate.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader resource:didReceiveResponse:]):
Misc.subproj/WebKit.h:
Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
Plugins.subproj/WebNetscapePluginDocumentView.m:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream resource:didReceiveResponse:]):
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebSubresourceClient.h:
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:didReceiveResponse:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource response]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setResponse:]): (-[WebDataSource _commitIfReady:]): (-[WebDataSource _addResponse:]):
WebView.subproj/WebDefaultPolicyDelegate.m:
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]):
WebView.subproj/WebFrameViewPrivate.m:
WebView.subproj/WebHTMLRepresentation.m:
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]):
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebTextRepresentation.m:
WebView.subproj/WebTextView.m:

WebBrowser:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

BrowserDocument.m:
BrowserWebController.m:
BugReportController.m: (-[BugReportController resource:didReceiveResponse:]):
DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]): (-[DownloadProgressEntry response]):
HTMLSourceDocument.m:
LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]):

11:38 AM Changeset in webkit [3926] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

11:29 AM Changeset in webkit [3925] by darin

3 edits in trunk/WebKit

Reviewed by Trey.

fixed 3209091 -- REGRESSION: WebFrameView leak (world leak)

WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): Use copy, not retain, on an incoming NSString parameter. (-[WebView initWithFrame:frameName:groupName:]): Release the WebFrameView after setting it up.

other changes

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Put the bug workaround here inside an ifdef so we don't compile it in on Panther.

11:04 AM Changeset in webkit [3924] by cblu

6 edits in trunk/WebKit

Use the private _cfBundle method on NSBundle so we only create 1 bundle per plug-in package class.

Reviewed by trey.

Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): (-[WebBasePluginPackage dealloc]):
Plugins.subproj/WebNetscapePluginPackage.h:
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromPLists]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]):
Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage isLoaded]):

8:46 AM Changeset in webkit [3923] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3208468 -- REGRESSION: checkbox immediately unchecks the first time you check it

The stateChanged signal must be delivered before the mouse up event is handled.

kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Use [self init] instead of [super init]; no real difference, just makes more logical sense. (-[KWQButton action:]): Don't send the mouse up event here. (-[KWQButton sendConsumedMouseUpIfNeeded]): Added. New method that sends the consumed mouse up event. (-[KWQButton mouseDown:]): Use a simplified scheme that uses only a single boolean to control sending the consumed mouse up event. Call sendConsumedMouseUpIfNeeded to do the deed. (QButton::clicked): Added comment to explain why it's important to send the consumed mouse up event here. Added a call to the new sendConsumedMouseUpIfNeeded method, replacing the code that was formerly in -[KWQButton action:].

8:28 AM Changeset in webkit [3922] by kocienda

10 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

CacheLoader.subproj/NSURLRequest.m: (-[NSMutableURLRequest _parametersForWriting]):
CacheLoader.subproj/NSURLRequestPrivate.h:

WebKit:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 25, 2003:

7:37 PM Changeset in webkit [3921] by rjw

14 edits in trunk/WebKit

WebKit:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

Changed userStyleSheetLocation to take/pass an NSURL.

Reviewed by Chris

Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
Plugins.subproj/WebNullPluginView.h:
Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins.subproj/WebPluginError.h:
Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURL]): (-[WebPlugInError plugInName]):
Plugins.subproj/WebPluginErrorPrivate.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]):
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

API-Issues.rtf: notes to self

WebBrowser:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]):

6:40 PM Changeset in webkit [3920] by cblu

8 edits in trunk/WebKit

Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari

Reviewed by trey.

Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): tweak (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): moved up from WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): retain path, create bundle so subclasses don't have to do this work (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): was getMIMEInformation from WebPluginPackage (-[WebBasePluginPackage dealloc]): release the bundle (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): tweak
Plugins.subproj/WebNetscapePluginPackage.h:
Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): new (-[WebNetscapePluginPackage openResourceFile]): tweak (-[WebNetscapePluginPackage closeResourceFile:]): tweak (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): tweak (-[WebNetscapePluginPackage getPluginInfoFromResources]): was getMIMEInformation (-[WebNetscapePluginPackage pListForPath:createFile:]): new, calls BP_CreatePluginMIMETypesPreferences if createFile==YES (-[WebNetscapePluginPackage getPluginInfoFromPLists]): calls getPluginInfoFromBundleAndMIMEDictionary with the MIME dictionary from the user's home dir. (-[WebNetscapePluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromPLists and/or getPluginInfoFromResources (-[WebNetscapePluginPackage executableType]): tweak (-[WebNetscapePluginPackage load]): get the BP_CreatePluginMIMETypesPreferences symbol (-[WebNetscapePluginPackage unload]): tweak (-[WebNetscapePluginPackage dealloc]): tweak
Plugins.subproj/WebPluginPackage.h:
Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromBundleAndMIMEDictionary (-[WebPluginPackage viewFactory]): tweak (-[WebPluginPackage load]): call principalClass (-[WebPluginPackage isLoaded]): tweak
Plugins.subproj/npapi.h: added declaration for the BP_CreatePluginMIMETypesPreferences function pointer.

5:11 PM Changeset in webkit [3919] by hyatt

5 edits in trunk/WebCore

Fix font-family parsing to match the spec (and other browsers).

This fixes bugs 3197584 and 3207760.

Also fix pseudos to be lower-cased. Fixes 3208303.

Reviewed by darin

khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):

2:43 PM Changeset in webkit [3918] by sullivan

4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

WebView.subproj/WebDynamicScrollBarsView.h: replaced disallowsScrolling boolean ivar with separate booleans for disallowHorizontalScrolling and disallowVerticalScrolling

WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): take the two disallow booleans into account separately (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]), (-[WebDynamicScrollBarsView allowsHorizontalScrolling]), (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]), (-[WebDynamicScrollBarsView allowsVerticalScrolling]): new methods, do the obvious (-[WebDynamicScrollBarsView setAllowsScrolling:]): changed to set both ivars (-[WebDynamicScrollBarsView allowsScrolling]): changed to return YES if scrolling is allowed in either direction

WebKit.exp: exported symbol for WebDynamicScrollBarsView class name

WebBrowser:

WebBrowser part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

English.lproj/Browser.nib: changed class of scroll view around collections column to be WebDynamicScrollBarsView

BookmarksViewController.m: (-[BookmarksViewController setUpBookmarkSourcesScrollView:]): new method, finds the dynamic scroll view enclosing the collections column, and turns off horizontal scrolling for it. (-[BookmarksViewController awakeFromNib:]): call setUpBookmarkSourcesScrollView

2:08 PM Changeset in webkit [3917] by kocienda

3 edits in trunk/WebKit

Reviewed by Richard

Fixed a bug that could occur in the new immutable/mutable
request scheme. When opening a javascript window, it was
possible for a request passed as a method argument to be
released during the course of a method, particularly
after that request was passed to willSendRequest:.
The solution is to ask the data source for its current
request rather than using the one stored in the method
argument.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient startLoading:]):

10:42 AM Changeset in webkit [3916] by trey

8 edits in trunk

JavaScriptCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be

additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

WebFoundation.pbproj/project.pbxproj:

WebCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

WebCore.pbproj/project.pbxproj:

WebKit:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

WebKit.pbproj/project.pbxproj:

10:36 AM Changeset in webkit [3915] by kocienda

10 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Spilt NSURLRequest into the immutable and mutable variants
as specified by the approved API.

Updated other code to use NSMutableURLRequest where appropriate.

Also updated some comments in NSURLRequest.h and removed
obsolete WebRequestCachePolicyRevalidate NSURLRequestCachePolicy
constant.

CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest setURL:]): (-[NSMutableURLRequest setURL:]): (-[NSMutableURLRequest setCachePolicy:]): (-[NSMutableURLRequest setTimeoutInterval:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest mutableCopyWithZone:]):
CacheLoader.subproj/WebResource.m: (-[WebResource loadWithDelegate:]): (-[WebResource _redirectedToRequest:permanent:]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol stateForCacheObject:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _addRequestMessageBody]):
WebFoundation.exp:

WebKit:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource request]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]):
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):

WebBrowser:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]):
BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):

9:23 AM Changeset in webkit [3914] by darin

4 edits in trunk/WebKit

Reviewed by John.

fixed 3205745 -- WebKit.framework's Localizable.strings file contains high ASCII in the Key definition.

English.lproj/Localizable.strings: Regenerated with the new version of the extract-localizable-strings tool that uses \U syntax instead of "high ASCII".

changed cursive font back to "Apple Chancery" for now

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change to "Apple Chancery".
English.lproj/StringsNotToBeLocalized.txt: Update for above change.

Mar 24, 2003:

6:36 PM Changeset in webkit [3913] by hyatt

7 edits in trunk/WebCore

Clean up isInlineFlow. Add a couple of new methods that I'll
be converting code over to use (carefully) piece by piece in
future patches.

Reviewed by gramps

khtml/rendering/render_block.h:
khtml/rendering/render_flow.h:
khtml/rendering/render_inline.h:
khtml/rendering/render_object.cpp: (RenderObject::setStyle):
khtml/rendering/render_object.h:

5:40 PM Changeset in webkit [3912] by darin

4 edits in trunk/WebKit

Reviewed by Dave.

fixed 3206803 -- REGRESSION: Lucida Handwriting font doesn't work

WebCoreSupport.subproj/WebTextRendererFactory.m: (acceptableChoice): Added. Returns NO if the weight/traits are no good. (betterChoice): Added. Returns YES if the new weight/traits are better than the old. (-[WebTextRendererFactory fontWithFamily:traits:size:]): Use the new functions to judge which font is good enough. Now it will accept an italic font if that's all we have.

fixed 3206904 -- use "Lucida Handwriting" for "cursive" so it works on systems without Classic

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change default from "Apple Chancery" to "Lucida Handwriting".

English.lproj/StringsNotToBeLocalized.txt: Updated for this change.

5:23 PM Changeset in webkit [3911] by mjs

6 edits in trunk/WebKit

Reviewed by Richard.

made API (actually doc-only) changes needed for 3087535 - bugzilla queries come back as downloaded files

Downloads.subproj/WebDownload.h: Documented that download:didReceiveResponse: may be sent more than once.
WebView.subproj/WebLocationChangeDelegate.h: Documented that locationChangeCommittedForDataSource: may be sent more than once.
WebView.subproj/WebPolicyDelegate.h: Documented that decideContentPolicyForMIMEType:andRequest:inFrame: may be sent more than once.
WebView.subproj/WebResourceLoadDelegate.h: Documented that resource:didReceiveResponse:fromDataSource: may be sent more than once.

5:13 PM Changeset in webkit [3910] by mjs

11 edits in trunk

WebCore:

Reviewed by Richard.

fixed 3083339 - significant top and side margin appended to new windows

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Account for distinction between frame and content rect.
kwq/KWQStyle.h: Return 0 for the appropriate style to avoid adding extra padding when making a new window from JavaScript.
kwq/WebCoreBridge.h: Prototype new methods.

WebKit:

Reviewed by Richard.

fixed 3083339 - significant top and side margin appended to new windows

Part of the fix involves adding new window operation delegate methods.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowFrame:]): Tweaked code a bit. (-[WebBridge windowFrame]): Added. (-[WebBridge setWindowContentRect:]): Added. (-[WebBridge windowContentRect]): Added.
WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented. (-[WebDefaultWindowOperationsDelegate webViewContentRect:]): Likewise.
WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by Richard.

fixed 3083339 - significant top and side margin appended to new windows

BrowserWebController.m: (-[BrowserWebController webView:setFrame:]): Tweaked a bit. (-[BrowserWebController webViewFrame:]): Likewise. (-[BrowserWebController webView:setContentRect:]): Implemented. (-[BrowserWebController webViewContentRect:]): Likewise.

3:39 PM Changeset in webkit [3909] by hyatt

4 edits in trunk/WebCore

Fix for crash on www.lnt.com. 3199929 is the bug number.

Blocks must have all their kids as inlines or all theirs kids
as blocks. Floats and positioned elements are special and
disregarded when this check occurs.

If a float or positioned element suddenly becomes a normal flow
element again, then the parent block might have to make its kids
all be non-inline or it might have to wrap a normal flow inline
with an anonymous block.

This patch fixed RenderObject's setStyle method to check for
this situation and to make the parent block fix itself up
appropriately.

Reviewed by darin

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

2:56 PM Changeset in webkit [3908] by cblu

10 edits in trunk/WebKit

WebFoundation:

Reviewed by trey.

types.plist: added text/qif (Quicken)

WebKit:

Fixed: 3155489 - Seed: PostScript files display instead of downloading, often as a blank page
Fixed: 3106251 - quicken file not downloaded, can't save manually

Reviewed by trey.

WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): call [WebImageView supportedImageMIMETypes]
WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewTypes]): call [WebImageView supportedImageMIMETypes]
WebView.subproj/WebImageView.h:
WebView.subproj/WebImageView.m: (+[WebImageView initialize]): was -initialize (oops) (+[WebImageView unsupportedImageMIMETypes]): new, AppKit images that we shouldn't display inline, includes ps and pdf (+[WebImageView supportedImageMIMETypes]): new, was in WebViewPrivate
WebView.subproj/WebTextView.h:
WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): renamed, added text/qif (quicken)
WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call [WebTextView unsupportedTextMIMETypes]
WebView.subproj/WebViewPrivate.h: removed _supportedImageMIMETypes
WebView.subproj/WebViewPrivate.m: removed _supportedImageMIMETypes

2:37 PM Changeset in webkit [3907] by kocienda

14 edits in trunk/WebKit

WebFoundation:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

This involved some non-complicated changes in the
internals of NSURLRequest.

Note that NSURLRequestPrivate.h has taken on some methods
that used to be API, but were removed from the public
proposal. These methods are now available as SPI.

CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest initWithURL:cachePolicy:timeoutInterval:]): (-[NSURLRequest initWithURL:]): (-[NSURLRequest init]): (-[NSURLRequest URL]): (-[NSURLRequest timeoutInterval]): (-[NSURLRequest setURL:]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest setTimeoutInterval:]): (NSHTTPURLRequestInit): (-[NSURLRequest _parametersForReading]): (-[NSURLRequest _parametersForWriting]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest HTTPAllHeaderFields]): (-[NSURLRequest HTTPValueForHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest HTTPAllowSSLCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSURLRequest HTTPSetMethod:]): (-[NSURLRequest HTTPSetAllHeaderFields:]): (-[NSURLRequest HTTPSetValue:forHeaderField:]): (-[NSURLRequest HTTPAddValue:forHeaderField:]): (-[NSURLRequest HTTPSetBody:]): (-[NSURLRequest HTTPSetAllowSSLCertificatesWithUnknownRoots:]): (-[NSURLRequest HTTPSetContentType:]): (-[NSURLRequest HTTPSetCookiePolicyBaseURL:]): (-[NSURLRequest HTTPSetExtraCookies:]): (-[NSURLRequest HTTPSetPageNotFoundCacheLifetime:]): (-[NSURLRequest HTTPSetReferrer:]): (-[NSURLRequest HTTPSetUserAgent:]): (-[NSHTTPURLRequestRequestParameters copyWithZone:]): (-[NSHTTPURLRequestRequestParameters dealloc]): (-[NSHTTPURLRequestRequestParameters hash]): (-[NSHTTPURLRequestRequestParameters isEqual:]): (-[NSHTTPURLRequestRequestParameters description]):
CacheLoader.subproj/NSURLRequestPrivate.h:
CacheLoader.subproj/WebCacheManager.m:
CacheLoader.subproj/WebResource.m: (-[WebResource _cacheKey]):
CacheLoader.subproj/WebResponse.h:
CacheLoader.subproj/WebResponse.m: (-[WebResponse contentType]): (-[WebResponse setContentType:]):
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol addReferrerFieldToHeader]): (-[WebCFNetworkHTTPProtocol addUserAgentFieldToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addMessageBodyToRequest]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol shouldAttemptOriginLoad]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol stateForCacheObject:]):
ProtocolHandlers.subproj/WebHTTPRequest.h: Removed.
ProtocolHandlers.subproj/WebHTTPRequest.m: Removed.
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.h:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _canUsePersistentConnectionForRequest]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebKit, this amounts to name changes only.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge incomingReferrer]):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
WebView.subproj/WebFrame.m: (-[WebFrame reload]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebBrowser, this amounts to name changes only.

BrowserDocument.m:
BrowserDocumentController.m:
BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
English.lproj/Localizable.strings:
LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):

11:47 AM Changeset in webkit [3906] by hyatt

4 edits in trunk/WebCore

ignore the float property on first-letter styles.
The bug # is 3186044.

Reviewed by darin

khtml/css/parser.cpp:
khtml/rendering/render_block.cpp:

10:58 AM Changeset in webkit [3905] by hyatt

4 edits in trunk/WebCore

Add error-handling case to deal with a common CSS malformation:

clip: rect( )

The bug is 3206171.

Reviewed by darin

khtml/css/parser.cpp:
khtml/css/parser.y:

10:50 AM Changeset in webkit [3904] by darin

18 edits
1 add in trunk

WebCore:

Reviewed by John.

fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)

kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::getRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.
kwq/KWQPainter.mm: (QPainter::_updateRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.

kwq/KWQTextRendererFactory.h: Added. Exposes a global variable that tells whether we are in global "using printer font" mode.
kwq/WebCoreTextRendererFactory.h: Added setUsingPrinterFonts: and usingPrinterFonts methods.
kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory setUsingPrinterFonts:]): Added. Sets global. (-[WebCoreTextRendererFactory usingPrinterFonts]): Added. Returns value of global.

WebCore.pbproj/project.pbxproj: Added KWQTextRendererFactory.h.

WebKit:

Reviewed by John.

fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)

Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): Pass usingPrinterFont:NO, since this is used exclusively for on-screen text, not printing.
Misc.subproj/WebStringTruncator.m: (truncateString): Ditto.

WebCoreSupport.subproj/WebTextRenderer.h: Add usingPrinterFont boolean field and parameter to init.
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:forScreen:]): Add usingPrinterFont parameter, and get the screen font if it's NO, also store the boolean for later use. (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding: attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]): Pass the usingPrinterFont parameter through when getting a substitute font.

WebCoreSupport.subproj/WebTextRendererFactory.h: Add separate caches for screen and printing text renderers. Add usingPrinterFont parameter to our rendererWithFont: method (the one inherited from WebCore still has no parameter).
WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory init]): Create both caches. (-[WebTextRendererFactory dealloc]): Release both caches. (-[WebTextRendererFactory rendererWithFont:]): Call the new rendererWithFont:usingPrinterFont: method, passing usingPrinterFonts from the WebCore side. Thus any fonts fetched by WebCore during printing are printing fonts, and otherwise they are screen fonts. (-[WebTextRendererFactory rendererWithFont:usingPrinterFont:]): Added. Has the code from the old rendererWithFont: method, but passes the usingPrinterFont parameter through to the WebTextRenderer init method.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't set unused canDragTo and canDragFrom fields. (-[WebHTMLView drawRect:]): Call -[WebTextRendererFactory setUsingPrinterFonts:] here if we are printing, as indicated by the usingPrinterFonts field. The reason we do this only inside drawRect is so we don't affect redraws of other HTML views that are not being printed that might be in "needs display" state when printing began. (-[WebHTMLView _setUsingPrinterFonts:]): Added. Calls _setUsingPrinterFonts on all WebHTMLViews inside this one, then does the work for this one. Uses the frame hierarchy rather than the view hierarchy, but either would work. If printer font state is changing, then sets the WebTextRendererFactory mode, then forces a layout and application of styles, but without triggering display. (-[WebHTMLView beginDocument]): Do an explicit display so this view does not have to be displayed while it is in "use printer fonts" mode. Then call _setUsingPrinterFonts:YES so that drawRect will use printer fonts, and also that the WebCore data structures and layout will be updated to reflect printer fonts as opposed to screen fonts. (-[WebHTMLView endDocument]): Call _setUsingPrinterFonts:NO to restore things to normal after printing.
WebView.subproj/WebHTMLViewPrivate.h: Removed unused canDragTo, canDragFrom, and liveAllowsScrolling fields. Added usingPrinterFonts field.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

10:40 AM Changeset in webkit [3903] by kocienda

3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithURL:]): (-[NSURLRequest cachePolicy]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest hash]): (-[NSURLRequest isEqual:]):
CacheLoader.subproj/WebResource.m: (-[WebResource _finishedLoading]):

WebKit:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):

10:12 AM Changeset in webkit [3902] by kocienda

2 edits in trunk/WebKit

Tests:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

Carbon/CarbonWeb/MyWebEventTypes.h:
Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
Carbon/CarbonWeb/TWebWindow.cp:

WebKit:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

WebView.subproj/WebFramePrivate.m

9:29 AM Changeset in webkit [3901] by kocienda

42 edits in trunk/WebKit

Tests:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
Carbon/CarbonWeb/TWebWindow.h:
Downloader/MyDocument.m: (-[MyDocument downloadCancel:]): (-[MyDocument download:didStartFromRequest:]): (-[MyDocument download:willSendRequest:]):
DumpBackForward/main.m: (dumpBackForward): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
DumpRenderTree/main.m: (dumpRenderTree):
HeaderView/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
IBViewer/DocumentController.m: (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
PDFBundle/PDFView.h:
PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
SnippetEditor/DataResourceRequest.h:
SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]):

WebFoundation:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

In the repository:
Moved WebRequest.h to NSURLRequest.h
Moved WebRequest.m to NSURLRequest.m
Moved WebRequestPrivate.h to NSURLRequestPrivate.h

CacheLoader.subproj/WebCacheManager.m:
CacheLoader.subproj/WebProtocol.h:
CacheLoader.subproj/WebProtocol.m: (+[WebProtocol partOfRequest:withClass:createIfDoesNotExist:]): (-[WebProtocol initWithProtocolClient:request:]): (-[WebProtocol request]):
CacheLoader.subproj/WebProtocolClient.h:
CacheLoader.subproj/WebResource.h:
CacheLoader.subproj/WebResource.m: (-[WebResource initWithRequest:]): (+[WebResource sendSynchronousRequest:]): (+[WebResource canInitWithRequest:]): (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _beginLoad]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource request]): (-[WebResourceInternal request]): (-[WebResourceInternal redirectedToRequest:permanent:]):
CacheLoader.subproj/WebResourceDelegate.h:
CacheLoader.subproj/WebResourceQueue.m:
CacheLoader.subproj/WebResponse.h:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate initWithRequest:monitor:]): (-[WebSynchronousDelegate resource:willSendRequest:]):
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/WebAboutProtocol.m:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol initWithProtocolClient:request:]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol initWithProtocolClient:request:]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
ProtocolHandlers.subproj/WebFileProtocol.m:
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]): (-[WebHTTPProtocol stateForCacheObject:]):
ProtocolHandlers.subproj/WebHTTPRequest.h:
ProtocolHandlers.subproj/WebHTTPRequest.m:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol initWithProtocolClient:request:]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]):
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

Downloads.subproj/WebDownload.h:
Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setRequest:]): (-[WebDownload resource:willSendRequest:]):
Downloads.subproj/WebDownloadPrivate.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resource:willSendRequest:]):
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest request]):
Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]):
Plugins.subproj/WebNetscapePluginStream.h:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge isReloading]): (-[WebBridge loadEmptyDocumentSynchronously]):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient resource:willSendRequest:]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _originalRequest]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]):
WebView.subproj/WebDefaultWindowOperationsDelegate.m:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNewWindowPolicy:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _loadRequest:inFrameNamed:]):
WebView.subproj/WebFrameView.m: (-[WebFrameView concludeDragOperation:]):
WebView.subproj/WebImageRepresentation.m:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:willSendRequest:]):
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebView.m: (-[WebView takeStringURLFrom:]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): (-[WebView _openNewWindowWithRequest:]):
WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToRequest:]):
BrowserDocumentController.h:
BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController reuseWebController:forRequest:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController openFileExternallyWithRequest:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController revealInFinderWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController expectedOrCurrentURL]): (-[BrowserWebController queueRequest:]): (-[BrowserWebController removeRequestFromQueue]): (-[BrowserWebController goNowIfInQueue]): (-[BrowserWebController goToRequest:allowJavaScript:waitInQueue:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
BrowserWindowController.m: (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]):
BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]):
ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
Debug/SnippetController.m: (-[SnippetController load]):
DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor download:didStartFromRequest:]): (-[DownloadMonitor downloadMayBeOpenedForRequest:]):
DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry _setRequest:]):
FrameProgressEntry.m:
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]):
LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 23, 2003:

12:02 AM Changeset in webkit [3900] by hyatt

3 edits in trunk/WebCore

Fix the top of the gamespot.com page on the PLT. The
clear status for <br> should be ignored if/when we decide
to ignore the <br> because the previous line didn't break
cleanly.

Reviewed by gramps

khtml/rendering/bidi.cpp:

Mar 22, 2003:

6:07 PM Changeset in webkit [3899] by hyatt

3 edits in trunk/WebCore

Loosen up the DTD for <dl>, <dt>, and <dd> so that they can
occur anywhere in a document and be independent of one
another.

Reviewed by darin/gramps

khtml/html/dtd.cpp: (DOM::checkChild):

3:27 PM Changeset in webkit [3898] by hyatt

7 edits in trunk/WebCore

Bottom border/padding was incorrectly being used in float
computations. The fix is trivial... positioning of floats
occurs before you add in the bottom border/padding rather
than after.

Also implementing support for transparent borders and adding
code that understands how to draw more complex polys when
individual sides are transparent. This code existed for left
and right borders, but not for top and bottom borders.

These two fixes make the tantek demo found at:

http://www.tantek.com/map.html

work properly for the first time in Safari.

Reviewed by darin

ChangeLog:
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp:
khtml/rendering/bidi.cpp:
khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
khtml/rendering/render_style.h:

Mar 21, 2003:

5:37 PM Changeset in webkit [3897] by hyatt

12 edits in trunk/WebCore

Fixes for all 4 macromedia rendering problems. They were all
related to buggy float handling.

The bugs are 3194998, 3195014, 3915155, 3204114.

This patch splits floats and positioned elements into two lists
instead of 1, and it also adds better logic for clearing out
floats when blocks move vertically.

Reviewed by darin

khtml/rendering/bidi.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_container.cpp: (RenderContainer::detach):
khtml/rendering/render_flow.cpp: (RenderFlow::addChildWithContinuation):
khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::nodeAtPoint):
khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::removeFromObjectLists): (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_root.cpp: (RenderRoot::layout):
khtml/rendering/render_table.cpp: (RenderTable::layout):

3:25 PM Changeset in webkit [3896] by cblu

9 edits in trunk/WebKit

WebFoundation:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMEType]): sniff for vcards and ical files
types.plist: added text/calendar and text/vcard

WebKit:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _representationClassForMIMEType:]): was _canShowMIMEType
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewClassForMIMEType:]): was _canShowMIMEType
WebView.subproj/WebTextView.h:
WebView.subproj/WebTextView.m: (+[WebTextView unshowableMIMETypes]): new, returns text types that shouldn't be shown
WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call unshowableMIMETypes

WebBrowser:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): auto-open vcf and ics

2:09 PM Changeset in webkit [3895] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3203212 -- nil-deref in khtml::CachedImage::isErrorImage at turbotax.com

khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeImage): Remove all occurrences of the image from the list. We don't try to prevent multiple occurrences from getting in there. Also use removeRef instead of remove, for speed.

9:42 AM Changeset in webkit [3894]

2 copies
2 deletes in tags/JavaScriptCore-68-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball'.

9:42 AM Changeset in webkit [3893] by darin

1 edit in branches/JavaScriptCore-68-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

9:39 AM Changeset in webkit [3892]

4 copies
2 deletes in tags/WebCore-68

This commit was manufactured by cvs2svn to create tag 'WebCore-68'.

9:39 AM Changeset in webkit [3891] by darin

1 edit in branches/WebCore-68-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Updated project file for tarball.

9:31 AM Changeset in webkit [3890] by darin

4 edits in branches/Safari-68~1-branch/WebKit

Rolled in change from trunk.

2003-03-20 Vicki Murley <vicki@apple.com>

don't include WebFoundation.h

Reviewed by cblu.

Plugins.subproj/WebBaseNetscapePluginStream.m:
Plugins.subproj/WebNetscapePluginRepresentation.m:
Plugins.subproj/WebNetscapePluginStream.m:

9:26 AM Changeset in webkit [3889] by darin

6 edits in trunk/WebCore

WebFoundation:

Reviewed by John.

fixed 3204660 -- EUC decoding not used for japanese yahoo page

Misc.subproj/WebNSStringExtras.m: (-[NSString _web_characterSetFromContentTypeHeader]): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.

other changes

Database.subproj/WebLRUFileList.m: (cStringHash): Get rid of unnecessary code to avoid hashes of 0. This is helpful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).

WebCore:

Reviewed by John.

fixed 3204660 -- EUC decoding not used for japanese yahoo page

khtml/misc/decoder.cpp: (Decoder::decode): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.

other changes

kwq/KWQString.mm: (QString::hash): Get rid of unnecessary code to avoid hashes of 0. This is useful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).

kwq/WebCoreTextRendererFactory.m: Remove unused method.

12:46 AM Changeset in webkit [3888] by hyatt

3 edits in trunk/WebCore

Fix the color handling of link= attributes on <body> elements
to pass in the quirks mode so that lax parsing can take place.

Reviewed by rjw and john

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):

Mar 20, 2003:

7:39 PM Changeset in webkit [3887] by rjw

22 edits in trunk

WebKit:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

History.subproj/WebBackForwardList.h:
History.subproj/WebBackForwardList.m: (-[WebBackForwardListPrivate dealloc]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList maximumSize]): (-[WebBackForwardList setMaximumSize:]): (-[WebBackForwardList description]): (-[WebBackForwardList clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList setUsesPageCache:]): (-[WebBackForwardList usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLString:]): (+[WebHistory setSharedHistory:]): (-[WebHistory addItemForURL:]): (-[WebHistory addItem:]): (-[WebHistory removeItem:]): (-[WebHistory removeItems:]): (-[WebHistory removeAllItems]): (-[WebHistory addItems:]): (-[WebHistory orderedItemsLastVisitedOnDay:]): (-[WebHistory containsItemForURLString:]): (-[WebHistory itemForURL:]):
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate removeItem:]): (-[WebHistoryPrivate removeItems:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate addItems:]): (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate containsItemForURLString:]): (-[WebHistoryPrivate itemForURL:]): (-[WebHistoryPrivate _loadHistoryGuts:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _resetBackForwardListToCurrent]):
WebView.subproj/WebLocationChangeDelegate.h:
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView setMaintainsBackForwardList:]): (-[WebView goBack]): (-[WebView goForward]):

WebCore:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

kwq/KWQKHistoryProvider.mm:
kwq/WebCoreHistory.h:

WebBrowser:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

AppController.m: (-[AppController confirmResetSafari:]):
BrowserDocument.m: (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]): (-[BrowserDocument goToItem:]): (-[BrowserDocument backListMenuForButton:]):
BrowserWebController.m: (-[BrowserWebController snapBackTo:]): (-[BrowserWebController setPageForSnapBackToCurrentPage:]): (-[BrowserWebController canSnapBackToPage]): (-[BrowserWebController setSearchResultsForSnapBackToCurrentPage]): (-[BrowserWebController canSnapBackToSearchResults]):
ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument validate_toggleBackForwardEnabled:]):
GlobalHistory.m: (-[GlobalHistory _registerForHistoryNotifications]): (-[GlobalHistory init]): (-[GlobalHistory _entriesFromMixedItems:]): (-[GlobalHistory _addItemsForDate:toMenu:skip:limit:]): (-[GlobalHistory _removeEntries:]): (-[GlobalHistory _undoRemoveEntries:]): (-[GlobalHistory deleteContentItems:withUndoManager:]): (-[GlobalHistory child:ofContentItem:]): (-[GlobalHistory numberOfChildrenOfContentItem:]):
URLCompletionController.m: (+[URLCompletionController _loadDB]): (+[URLCompletionController _registerForNotifications]):

7:04 PM Changeset in webkit [3886] by rjw

1 edit in trunk/WebKit/API-Issues.rtf

Notes to self.

4:15 PM Changeset in webkit [3885] by cblu

4 edits in trunk/WebKit

WebKit:

Properly handle file URL directory errors.

Reviewed by trey.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): when file URL has no path, return generic file icon
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): set the URL, don't set it to nil!

WebBrowser:

Fixed: 3204064 - REGRESSION: PDF URL is left in location for after download
Properly handle file URL directory errors.

Reviewed by darin.

BrowserWebController.m: (-[BrowserWebController expectedOrCurrentURL]): don't use the URL of the provisional data source if it is not loading.
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): tweak, use [NSWorkspace isFilePackageAtPath:] instead of LaunchServices because it is easier.

2:21 PM Changeset in webkit [3884] by hyatt

3 edits in trunk/WebCore

Always do residual style fixups in all three Safari rendering
modes.

Reviewed by darin

khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):

2:18 PM Changeset in webkit [3883] by vicki

4 edits in trunk/WebKit

don't include WebFoundation.h

Reviewed by cblu.

Plugins.subproj/WebBaseNetscapePluginStream.m:
Plugins.subproj/WebNetscapePluginRepresentation.m:
Plugins.subproj/WebNetscapePluginStream.m:

11:44 AM Changeset in webkit [3882] by sheridan

3 edits in trunk

Safari-69 begins

10:50 AM Changeset in webkit [3881]

3 copies
2 deletes in branches/WebCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3880]

3 copies
2 deletes in tags/WebCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3879]

3 copies in branches/Safari-68~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-68~1-branch'.

10:50 AM Changeset in webkit [3878]

3 copies in tags/Safari-68~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-68~1-anchor'.

10:50 AM Changeset in webkit [3877]

3 copies in tags/Safari-68

This commit was manufactured by cvs2svn to create tag 'Safari-68'.

10:50 AM Changeset in webkit [3876]

1 copy
2 deletes in branches/JavaScriptCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3875]

1 copy
2 deletes in tags/JavaScriptCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3874] by sheridan

8 edits in trunk

Safari-68

8:52 AM Changeset in webkit [3873] by darin

2 edits in trunk/WebKit

WebFoundation:

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Mar 19, 2003:

7:20 PM Changeset in webkit [3872] by voas

5 edits
1 delete in trunk/WebKit

2003-03-19 Ed Voas voas@apple.com

Reviewed by Richard.

React to WebView API changes. Redo HIWebView API.

Carbon.subproj/HIWebView.h:
Carbon.subproj/HIWebView.m: (if): (switch):
Carbon.subproj/HIWebViewPriv.h: Removed.
WebKit.exp:
WebKit.pbproj/project.pbxproj:

7:02 PM Changeset in webkit [3871] by hyatt

3 edits in trunk/WebCore

Adding a few more tags to the list of ones to check for
residual style.

Reviewed by gramps

khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle):

6:55 PM Changeset in webkit [3870] by rjw

4 edits in trunk/WebKit

WebKit:

Removed initWithView:* constructors from WebView.
New designated initializer for WebView is initWithFrame:frameName:groupName:

Reviewed by cblu & ed.

Carbon.subproj/HIWebView.m:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView init]): (-[WebView initWithFrame:]):

WebBrowser:

Updated Safari to use the new designated initializer for WebView. Simplified
many places that used to reference the WebFrameView.

Reviewed by cblu.

BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]):
BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]):

6:13 PM Changeset in webkit [3869] by hyatt

8 edits in trunk/WebCore

Fix continuations so that they are smarter about reusing
anonymous blocks. Avoids deep nesting when it isn't
necessary.

A complete implementation of the residual style fixes. It
seems to fix all current outstanding bugs.

One of the bugs in the residual style list was caused by
font-weight not being reset to tables and is actually its
own problem. I fixed that by moving the quirks resets for
table elements into the quirks stylesheet (which should be
a speed boost).

<b><p>Foo</b> Goo</p>

Also fixed the huge XML failure issue that made us fail hundreds
of test cases. Attachment of text nodes was being done way too
early, before the text of the node had been determined. By moving
the attachment from enterText to exitText, the problem is solved.

Reviewed by darin (res. style fix 1) and gramps (rest of res. style fix and XML fix)

ChangeLog:
khtml/css/quirks.css:
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle): (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
khtml/html/htmlparser.h:
khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
khtml/xml/xml_tokenizer.cpp: (XMLHandler::enterText): (XMLHandler::exitText):

5:14 PM Changeset in webkit [3868] by rjw

17 edits
3 deletes in trunk/WebKit

WebKit:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

API-Issues.rtf:
Misc.subproj/WebKit.h:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebControllerPolicyDelegate.h: Removed.
WebView.subproj/WebControllerPolicyDelegate.m: Removed.
WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebFrameView.h:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebPolicyDelegate.m:
WebView.subproj/WebPolicyDelegatePrivate.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:

WebBrowser:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

BrowserWebController.m:

4:45 PM Changeset in webkit [3867] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed 3202780 -- REGRESSION: progress bar, stop button, both get stuck in "loading" state (bartsoft.com)

WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Add back the "is this page complete" check, so that subresource loads don't make us think we're loading again, once the page is complete. On the other hand, frames must still be checked independent of the "is this page complete" flag to avoid reintroducing bug 3200611.

3:11 PM Changeset in webkit [3866] by voas

5 edits in trunk/WebKit

2003-03-19 Ed Voas voas@apple.com

Reviewed by Richard.

Got it working in non-compositing mode as well, so in theory it
can work inside a PowerPlant application as well. It's a bit of what
I'd consider a hack, but it's pretty straightforward.

Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter setViewsNeedDisplay:]):
Carbon.subproj/HIViewAdapter.h:
Carbon.subproj/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]): (SetViewNeedsDisplay):
Carbon.subproj/HIWebView.m: (if):

9:04 AM Changeset in webkit [3865] by darin

7 edits in trunk/WebCore

Reviewed by Ken.

fixed 3197684 -- <textarea wrap="hard"> behaves incorrectly (bugzilla)

By doing the line breaking inside the KWQ class for textarea we can both remove
the broken lineOfCharAtIndex: method and avoid the n-squared algorithm KHTML uses to
insert hard line breaks.

khtml/rendering/render_form.cpp: (RenderTextArea::text): Call textWithHardLineBreaks on widget instead of trying to break lines here.

kwq/KWQTextEdit.h: Added textWithHardLineBreaks member function. Made text member function const. Got rid of text(int), paragraphs, paragraphLength, and lineOfChar member functions.
kwq/KWQTextEdit.mm: (QTextEdit::text): Made this const, and move code that transforms CRLF and CR into LF inside KWQTextArea. (QTextEdit::textWithHardLineBreaks): Added. Calls new textWithHardLineBreaks method.

kwq/KWQTextArea.h: Added textWithHardLineBreaks method. Removed numLines, textForLine:, paragrahs, paragraphLength:, textForParagraph:, and lineOfCharAtIndex: methods.
kwq/KWQTextArea.mm: (-[KWQTextArea initWithQTextEdit:]): Call [self init] for clarity instead of [super init]. In both cases, we end up calling [self initWithFrame:]. (-[KWQTextArea text]): Added logic for transforming CRLF and CR into LF here instead of at the KWQTextEdit level. (-[KWQTextArea textWithHardLineBreaks]): Added. This method uses the layout manager to extract the characters for one line at a time, and put line breaks in between.

1:06 AM Changeset in webkit [3864] by mjs

6 edits in trunk

WebCore:

Reviewed by Trey.

fixed 3146407 - bring the window with the targeted frame to the front

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): If we use an existing frame, focus it.
kwq/WebCoreBridge.h: Prototype focusWindow method.

WebKit:

Reviewed by Trey.

fixed 3127431 - bring the window with the named frame to the front

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge focusWindow]): Tell the window operations delegate to focus. (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): If this navigation is meant for a different frame, focus its window. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Likewise.

WebBrowser:

Reviewed by Trey.

fixed 3127431 - bring the window with the named frame to the front
set main frame name properly for targeted links opened in tabs

BrowserDocument.h:
BrowserDocument.m:

(-[BrowserDocument createWebControllerWithFrameName:]): New method.
(-[BrowserDocument createWebController]): Reimplement in terms of above.

BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): Pass main frame name for tabs too.
BrowserWebController.m: (-[BrowserWebController windowController]): Move to higher in the file. (-[BrowserWebController webViewFocusWindow:]): Switch tabs too.
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController createTabWithFrameName:andShow:]): Added frameName parameter. (-[BrowserWindowController createTabWithFrameName:]): New method. (-[BrowserWindowController createInactiveTabWithFrameName:]): New method. (-[BrowserWindowController createTab]): Pass nil frame name. (-[BrowserWindowController createInactiveTab]): Likewise.

Mar 18, 2003:

11:23 PM Changeset in webkit [3863] by trey

4 edits in trunk/WebKit

3077223 full keyboard UI navigation fails in authentication sheet

Hook up the views in this panel into a useful nextKeyView cycle.

Reviewed by Maciej.

Panels.subproj/English.lproj/WebAuthenticationPanel.nib:

11:05 PM Changeset in webkit [3862] by trey

16 edits in trunk

WebCore:

Support for password saving in forms. Added elementIsPassword:,
nuked deadwood formIsLoginForm:.

Reviewed by Maciej.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Pass forms data for login forms and password fields to bridge. This case was skipped for security in khtml's autocomplete, but we need this data to save passwords, and we enforce policy at a higher level.
khtml/html/html_formimpl.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: Nuked formIsLoginForm:. (-[WebCoreBridge elementIsPassword:]): New utility.

WebKit:

Support for saving passwords on forms-based logins. Biggest change is that
the willSubmitForm: message is async to allow a sheet to be presented.

Also fixed @interface.*{ so prepare-change-log can swallow WebFramePrivate.m.

Reviewed by Maciej.

WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListener continue]): The decision listener also implements WebFormSubmissionListener, to share some other impl.
WebView.subproj/WebControllerPolicyDelegatePrivate.h:
WebView.subproj/WebFormDelegate.h:
WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:willSubmitForm:withValues:submissionListener:]): Take listener param for async API.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _continueAfterWillSubmitForm:]): Continuation code for after FormDelegate is done with willSubmitForm. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass new listener arg to willSubmitForm.
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: Nuke deadwood formIsLoginForm. (-[WebHTMLRepresentation elementIsPassword:]): Just pass through glue over the bridge.

WebBrowser:

Password saving is implemented, with data saved in the keychain.
Lots of FIXMEs were either fixed or moved to Radar.

Reviewed by Chris.

BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Observe BrowserDocumentLoadingFinishedNotification. (-[BrowserWindowController frameLoadStarted:]): Cancel timer that would try to autofill the last page with a password. (-[BrowserWindowController frameLoadFinished:]): Start a timer that will try to autofill this page with a password. We use a short timer to avoid affecting the PLT. (-[BrowserWindowController tryToAutofillPasswords:]): Force keychain check of password protecting the ad-hoc data. Try to autocomplete any login form on the page. (-[FormDelegate frame:willSubmitForm:withValues:submissionListener:]): Pass new async listener param along to FormCompletionController.
CompletionController.m: (-[CompletionController _showMatchesWindow:]): Don't try to set an initial match if there wasn't one. (-[CompletionController completeString:]): Handle the case of a subclass specifying no initial match after a query.
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Nuke items for which we now have real prefs.
English.lproj/ABAutoCompleteMappings.plist: A tweak for better matching. No longer need to have both USA and U.S.A.
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
FormCompletionController.h:
FormCompletionController.m: (urlFromFrame): New utility, just factored from other routines. (domainFromFrame): Call new utility. (authResourceFromFrame): New utility. (HTMLRepFromFrame): New utility, just factored from other routines. (dontSaveMarker): Return a magic username that indicates passwords are never saved for a particular AuthResource. (+[FormCompletionController setPasswordCompletionEnabled:]): Nuke NOP code. (viewContainsTextField): Utility to search view hierarchy for a text field. (+[FormCompletionController verifyKeychainAccessWithController:]): Read the AutoComplete encryption password, just to get the keychain nag out of the way. (+[FormCompletionController _cryptData:encode:]): Terminology - s/AutoComplete/AutoFill/ (+[FormCompletionController _reapABMarker:forFrame:fieldName:]): Deletes a stale AB marker that was detected. (+[FormCompletionController loginInfoForForm:inFrame:]): Return some info about the form if it is a login form. (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Handle a login form being submitted. Runs a sheet for the user, or at least makes sure the one we are sending becomes the default item for the site. (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): After the sheet, possibly save the new item, or save a refusal marker so we never ask the user again for this site. Make sure to continue the submission. (+[FormCompletionController _frame:willSubmitRegularForm:withValues:]): Same code as what used to be in willSubmitForm, just factored here for the non-login case. (+[FormCompletionController frame:willSubmitForm:withValues:submissionListener:]): Branch to either the regular or login method. (+[FormCompletionController _addABMatchesToArray:forString:atABPointer:]): Subtle bug in how we inserted AB matches into the matches from completion data. We would sometimes errantly leave ABMarkers in this list, which became problematic now that we reap stale ones. Now we are willing to match an ABMatch against a literal string from the CompletionDB -AND- an ABMarker. (+[FormCompletionController _credentialMatchesForString:frame:]): Match the partialString against previous logins for this site. For these matches we insert WebCredentials into the matches array. (+[FormCompletionController _matchesForString:frame:fieldName:view:]): Call new utility routine. Reap any stale ABMarkers left over in the matches list. (stringFromMatch): Handle a Credential match. (matchComparator): Oops, should be case insensitive. (-[FormCompletionController queryResultsForString:startingMatch:]): Do a credential-based match if this is a login form. (+[FormCompletionController currentFrameAndForm:inController:]): Just factored code from autoFillInController. (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): Stick the default login and password into a form. (+[FormCompletionController autoFillInController:]): AutoFill a non-login form the same was as before (code was moved from elsewhere). AutoFill a login form too. (+[FormCompletionController autoFillPasswordInController:]): AutoFill, but only for login forms. (-[FormCompletionController initWithSourceField:frame:]): Use new utility to decide if this is a login form instead of WC routine. (-[FormCompletionController reflectSelectedRow]): If we are stuffing a username into a login form, stuff the password field too. (-[FormCompletionController finalMatchingStringForResult:]): FIXME -> Radar. (cookedPopupString): strip periods out of strings before we match popup values. (indexOfBestStringInArray): Use cookedPopupString for all matching. (-[AutoFillController _reflectAutoFillMatch:inView:fieldName:]): When stuffing a popup, be sure the action message is sent to get the right side-effects. (-[AutoFillController autoFill]): Use new utility routines. Return a more accurate result of whether we actually autofilled anything. (-[AutoFillController autoFillAddressStartingAtView:match:]): Use new utility routines. (+[FormToABBinder loadGlobalBinder]): FIXME -> Radar (-[FormToABBinder initWithPath:]): Cleanup SearchPass handling, so a non-specified SearchPass really behaves the same as a SearchPass==1.

10:18 PM Changeset in webkit [3861] by rjw

38 edits
4 deletes in trunk/WebKit

WebKit:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

Carbon.subproj/HIWebView.h:
Misc.subproj/WebKit.h:
Misc.subproj/WebNSPasteboardExtras.m:
Panels.subproj/WebStandardPanelsPrivate.h:
Plugins.subproj/WebBaseNetscapePluginView.m:
Plugins.subproj/WebNetscapePluginDocumentView.m:
Plugins.subproj/WebNetscapePluginEmbeddedView.m:
Plugins.subproj/WebNetscapePluginStream.m:
Plugins.subproj/WebNullPluginView.m:
Plugins.subproj/WebPluginController.m:
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebSubresourceClient.m:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.m:
WebView.subproj/WebController.h: Removed.
WebView.subproj/WebController.m: Removed.
WebView.subproj/WebControllerPrivate.h: Removed.
WebView.subproj/WebControllerPrivate.m: Removed.
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebDefaultPolicyDelegate.m:
WebView.subproj/WebDefaultResourceLoadDelegate.m:
WebView.subproj/WebDefaultWindowOperationsDelegate.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebFrameView.m:
WebView.subproj/WebFrameViewPrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebImageView.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebTextView.m:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m:

WebBrowser:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

BrowserDocument.h:
BrowserDocument.m:
BrowserDocumentController.h:
BrowserWebController.h:
BrowserWebFrameExtras.m:
BrowserWebViewExtras.m:
BrowserWindowController.m:
ContextMenuHandler.m:
Debug/DebugUtilities.m:
Debug/SnippetController.m:
LoadProgressMonitor.m:
LocationChangeHandler.m:

Tests:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

DumpBackForward/main.m:
DumpRenderTree/main.m:
IBViewer/DocumentController.m:

9:13 PM Changeset in webkit [3860] by rjw

33 edits in trunk/WebKit

WebKit:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

Misc.subproj/WebKit.h:
Misc.subproj/WebNSViewExtras.m:
Panels.subproj/WebStandardPanels.m:
Plugins.subproj/WebBaseNetscapePluginView.m:
Plugins.subproj/WebNetscapePluginDocumentView.m:
Plugins.subproj/WebNetscapePluginEmbeddedView.m:
Plugins.subproj/WebNetscapePluginRepresentation.m:
Plugins.subproj/WebNullPluginView.m:
Plugins.subproj/WebPluginController.m:
Plugins.subproj/WebPluginDatabase.m:
WebCoreSupport.subproj/WebBridge.m:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebController.m:
WebView.subproj/WebControllerPrivate.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDebugDOMNode.m:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebFrameView.m:
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebImageView.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebRenderNode.m:
WebView.subproj/WebTextView.m:
WebView.subproj/WebView.h: Removed.
WebView.subproj/WebView.m: Removed.
WebView.subproj/WebViewPrivate.h: Removed.
WebView.subproj/WebViewPrivate.m: Removed.

WebBrowser:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

BrowserDocument.m:
BrowserTabViewItem.m:
BrowserWebController.m:
BrowserWebViewExtras.h:
BrowserWindowController.m:
ContextMenuHandler.m:
Debug/ViewTree.m:
FormCompletionController.m:
LocationChangeHandler.m:

Tests:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

DumpBackForward/main.m:
DumpRenderTree/main.m:
HeaderView/ApplicationController.m:
HeaderView/DocumentController.m:
IBViewer/ApplicationController.m:
PDFBundle/PDFView.m:
PDFViewer/ApplicationController.m:
PDFViewer/DocumentController.m:
PDFViewer/PDFRepresentation.m:
SimpleViewer/ApplicationController.m:
SimpleViewer/DocumentController.m:
SnippetEditor/ApplicationController.m:
SnippetEditor/SnippetController.m:

8:29 PM Changeset in webkit [3859] by rjw

65 edits in trunk/WebKit

WebKit:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

API-Issues.rtf:
Carbon.subproj/HIWebView.h:
Carbon.subproj/HIWebView.m:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStartLoadingURL:inController:]): (-[WebStandardPanels _didStopLoadingURL:inController:]): (-[WebStandardPanels frontmostWindowLoadingURL:]):
Panels.subproj/WebStandardPanelsPrivate.h:
Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView loadPluginRequest:]):
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation isPluginViewStarted]): (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge mainFrame]): (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge userAgentForURL:]): (-[WebBridge nextKeyViewOutsideWebFrameViews]): (-[WebBridge previousKeyViewOutsideWebFrameViews]): (-[WebBridge defersLoading]): (-[WebBridge setDefersLoading:]): (-[WebBridge setNeedsReapplyStyles]): (-[WebBridge setNeedsLayout]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]): (-[WebBridge historyLength]): (-[WebBridge goBackOrForward:]): (formDelegate):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
WebKit.exp:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
WebView.subproj/WebContextMenuDelegate.h:
WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView initWithFrame:]): (-[WebView supportsTextEncoding]): (-[WebView userAgentForURL:]):
WebView.subproj/WebControllerPolicyDelegate.h:
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebViewPrivate _clearControllerReferences:]): (+[WebView canShowFile:]): (+[WebView suggestedFileExtensionForMIMEType:]): (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _findFrameNamed:]): (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _frameForView:fromFrame:]):
WebView.subproj/WebControllerSets.h:
WebView.subproj/WebControllerSets.m: (+[WebControllerSets addController:toSetNamed:]): (+[WebControllerSets removeController:fromSetNamed:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _setController:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _layoutChildren]): (+[WebDataSource _repTypes]): (-[WebDataSource _receivedData:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate webView:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate webView:clientRedirectCancelledForFrame:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:pluginFailedWithError:dataSource:]):
WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate webView:runOpenPanelForFileButtonWithResultListener:]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame frameView]): (-[WebFrame webView]): (-[WebFrame findFrameNamed:]): (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (if): (switch):
WebView.subproj/WebHTMLView.h:
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]):
WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
WebView.subproj/WebLocationChangeDelegate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]):
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]): (-[WebFrameView scrollView]): (-[WebFrameView documentView]): (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebFrameView _controller]): (-[WebFrameView _setDocumentView:]): (-[WebFrameView _setController:]): (-[WebFrameView _contentView]): (-[WebFrameView _verticalKeyboardScrollAmount]): (-[WebFrameView _horizontalKeyboardScrollAmount]): (-[WebFrameView _scrollToBottomLeft]): (+[WebFrameView _viewTypes]):
WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

BrowserDocument.m: (-[BrowserDocument fileType]): (-[BrowserDocument mainWebFrameView]): (-[BrowserDocument text]):
BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebController webView:setStatusText:]): (-[BrowserWebController webViewStatusText:]): (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): (-[BrowserWebController webView:mouseDidMoveOverElement:modifierFlags:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController webViewCloseWindow:]): (-[BrowserWebController webViewShowWindow:]): (-[BrowserWebController webViewShowWindowBehindFrontmost:]): (-[BrowserWebController webViewFocusWindow:]): (-[BrowserWebController webViewUnfocusWindow:]): (-[BrowserWebController webViewFirstResponderInWindow:]): (-[BrowserWebController webView:makeFirstResponderInWindow:]): (-[BrowserWebController webViewIsResizable:]): (-[BrowserWebController webView:setResizable:]): (-[BrowserWebController webViewAreToolbarsVisible:]): (-[BrowserWebController webView:setToolbarsVisible:]): (-[BrowserWebController webViewIsStatusBarVisible:]): (-[BrowserWebController webView:setStatusBarVisible:]): (-[BrowserWebController mainWebFrameView]): (-[BrowserWebController webView:setFrame:]): (-[BrowserWebController webViewFrame:]): (-[BrowserWebController webView:runJavaScriptAlertPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptConfirmPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[BrowserWebController webView:runOpenPanelForFileButtonWithResultListener:]): (-[BrowserWebController webView:unableToImplementPolicyWithError:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
BrowserWebFrameExtras.m: (-[WebFrame isMainFrame]):
BrowserWebViewExtras.m: (-[WebFrameView isScrollable]): (-[WebFrameView largestScrollableWebView]):
BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController bestWindowSizeForCurrentPageWithDefaultSize:]): (-[BrowserWindowController frameLoadStarted:]): (-[BrowserWindowController frameLoadCommitted:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController closeOtherTabs:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController replaceTabSwitcher:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]): (-[BrowserWindowController validateMenuItem:]):
ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler search:]): (-[ContextMenuHandler goToAddress:]):
Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): (-[BrowserDocument validate_setUserAgent:]):
Debug/Snippet.nib:
Debug/SnippetController.h:
Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):
FormCompletionController.h:
FormCompletionController.m: (+[FormCompletionController autoFillInController:]): (+[AutoFillController autoFillInController:]):
LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor monitorFrame:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveContentLength:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didFinishLoadingFromDataSource:]): (-[LoadProgressMonitor webView:pluginFailedWithError:dataSource:]):
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeStartedForDataSource:]): (-[LocationChangeHandler webView:locationChangeCommittedForDataSource:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): (-[LocationChangeHandler webView:willCloseLocationForDataSource:]): (-[LocationChangeHandler webView:receivedPageTitle:forDataSource:]): (-[LocationChangeHandler webView:receivedPageIcon:forDataSource:]): (-[LocationChangeHandler webView:serverRedirectedForDataSource:]): (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): (-[LocationChangeHandler webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler webView:clientRedirectCancelledForFrame:]):

Tests:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveContentLength:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFinishLoadingFromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFailLoadingWithError:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:pluginFailedWithError:dataSource:]):
DumpBackForward/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
DumpRenderTree/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
HeaderView/ApplicationController.m:
HeaderView/DocumentController.h:
HeaderView/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController awakeFromNib]): (-[DocumentController loadURL:]): (-[DocumentController updateLayout]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
IBViewer/DocumentController.m: (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
PDFBundle/PDFView.m: (-[PDFView layout]):
PDFViewer/DocumentController.h:
PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
PDFViewer/PDFRepresentation.m: (-[PDFView layout]):
SimpleViewer/DocumentController.h:
SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
SnippetEditor/SnippetController.h:
SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController awakeFromNib]): (-[SnippetController _resetViews]): (-[SnippetController _updateTitleWithURL]): (-[SnippetController updateFromURL:]): (-[SnippetController updateFromText:]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):

5:29 PM Changeset in webkit [3858] by mjs

3 edits in trunk/WebCore

Reviewed by John.

fixed 3119663 - document.lastModified returns the wrong date format

kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Instead of using NSDate's default date format, use the format that IE and Gecko use.

4:35 PM Changeset in webkit [3857] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Fix build, use size instead of length.

4:25 PM Changeset in webkit [3856] by darin

2 edits in trunk/WebKit

Reviewed by Richard.

fixed 3187143 -- when a font-family has many variants, Safari chooses the wrong one

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Changed the algorithm here in two ways. 1) Pick the family member with matching traits that has a weight closest to 5, the standard weight; the old code picked the first family member with matching traits. 2) Match traits based on a mask of which traits are the important ones. The old code matched traits based on a rule of "if the trait bit is 1 it matters, otherwise don't care".

3:31 PM Changeset in webkit [3855] by mjs

3 edits in trunk/WebCore

Reviewed by John.

fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Treat empty string the same as missing for third argument - leave all chrome on. Also remove support for scrollbars= property

2:23 PM Changeset in webkit [3854] by darin

2 edits in trunk/WebKit

Reviewed by Richard.

fixed 3194756 -- REGRESSION: Geneva bold yields Geneva plain, used to yield Helvetica bold (apple.com)

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Remove the first call to NSFontManager before we do our searching algorithm. We always need to do the searching, because NSFontManager uses a different set of rules.

2:13 PM Changeset in webkit [3853] by darin

12 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3164522 -- text encoding conversion is done a chunk at a time with no state; won't work in some cases
fixed 3164557 -- pages served with encoding UTF-16LE but no BOM character won't be decoded correctly
fixed 3164569 -- pages without BOM that have a server-specified encoding of utf-16 will fail to decode
fixed 3165002 -- can't open link with tilde (~) in page with Japanese encoding
fixed 3181297 -- can't open link with backslash (\) in page with Japanese encoding (download at netscape.com)
fixed 3182977 -- "unicode" encoding handled as UTF-16 rather than UTF-8 at www.delcom-eng.com

khtml/misc/decoder.h: Add an optional "8-bit-only" parameter to the setEncoding method.
khtml/misc/decoder.cpp: (Decoder::setEncoding): Add an "8-bit-only" parameter. Use the new codeForNameEightBitOnly method when that parameter is true. Use the new usesVisualOrdering constant rather than all the hardcoded logic here to tell logical from visual Hebrew encodings. (Decoder::decode): Pass true for "8-bit-only" when the encoding came out of an HTML header, since we are already parsing the file by this point so it makes no sense to use a non-8-bit encoding. (Decoder::flush): Pass true for the "flush" parameter when calling the decoder.

kwq/KWQCharsets.h: Add a new KWQEncodingFlags enum, and return a parameter of that type (optionally) from KWQCFStringEncodingFromIANACharsetName.
kwq/KWQCharsets.mm: (buildDictionaries): Make the dictionaries lead to table entries so we can get both the flags and the encoding. (KWQCFStringEncodingFromIANACharsetName): Get the flags as well as the encoding. (KWQCFStringEncodingToIANACharsetName): Use the new dictionary format. (encodingNameHash): Removed special case for hash for 0. This was useful in JavaScriptCore where this hash function came from, but it's not relevant for a CF hash function.

kwq/KWQTextCodec.h: Added codecForNameEightBitOnly function to QTextCodec. Added optional KWQEncodingFlags parameter to QTextCodec constructor. Replaced isISOLatin1Hebrew with usesVisualOrdering. Added == and hash functions to QTextCodec. Added virtual destructor to QTextDecoder. Added optional "flush" boolean parameter to QTextDecoder's toUnicode function.
kwq/KWQTextCodec.mm: (codecForCFStringEncoding): Use both the encoding and the flags as a key for the dictionary that holds QTextCodec objects. (QTextCodec::codecForName): Pass flags through. (QTextCodec::codecForNameEightBitOnly): Added. Maps kCFStringEncodingUnicode to kCFStringEncodingUTF8. (QTextCodec::codecForLocale): Pass noEncodingFlags. (QTextCodec::makeDecoder): Pass flags to KWQTextDecoder constructor. (QTextCodec::toUnicode): Pass true for the "flush" boolean parameter to KWQTextDecoder. (operator==): Added. Compares both encoding and flags. (QTextCodec::hash): Added. Computes a hash of encoding and flags. (QTextCodecsEqual): Added. Calls operator==. (QTextCodecHash): Added. Calls hash member function. (QTextDecoder::~QTextDecoder): Added. Empty. (KWQTextDecoder::KWQTextDecoder): Made this no longer inline. (KWQTextDecoder::~KWQTextDecoder): Added. Cache the TEC object for use next time. (KWQTextDecoder::convertUTF16): Use the flags to decide on big vs. little endian when the page does not have a BOM marker that makes it unambiguous. (KWQTextDecoder::convertUsingTEC): Added flush parameter. Changed code to reuse the same converter for successive convert calls, and only flush when the flush parameter is passed. Added code to set the kUnicodeForceASCIIRangeMask. Do it directly since we can't use TECSetBasicOptions due to bug 3201405. (KWQTextDecoder::toUnicode): Pass flush parameter through.

kwq/mac-encodings.txt: Added new sections for "Unicode, bigEndian", "Unicode, littleEndian", and "ISOLatinHebrew, visualOrdering". Also moved UTF-16 to "Unicode" from "UTF8" since we now handle this with the "8-bit-only" mechanism.

kwq/make-charset-table.pl: Updated script to support flags (after a comma), and made it a bit more strict about what to do with ill-formed lines.

kwq/KWQCharsetData.c: Regenerated.

other changes

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsBeforeElement): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::matchLabelsAgainstElement): Ditto. (KWQKHTMLPart::pauseActions): Ditto. (KWQKHTMLPart::resumeActions): Add check for nil to match pauseActions. Also take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::saveWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::saveLocationProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreLocationProperties): Use ERROR instead of printf for the nil case. (KWQKHTMLPart::openURLFromPageCache): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Ditto. (KWQKHTMLPart::passSubframeEventToSubframe): Ditto.

Mar 17, 2003:

4:44 PM Changeset in webkit [3852] by cblu

7 edits
1 add in trunk/WebKit

WebKit:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

Downloads.subproj/WebDownload.m: (+[WebDownloadPrivate initialize]): call _registerWebKitErrors
English.lproj/Localizable.strings:
Misc.subproj/WebKitErrors.h: cleaned-up, removed unused errors
Misc.subproj/WebKitErrors.m: (+[WebError _registerWebKitErrors]): (registerErrors):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebView.m: (+[WebFrameView initialize]): call _registerWebKitErrors

WebBrowser:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry dictionaryRepresentation]): store the error domain

3:28 PM Changeset in webkit [3851] by darin

3 edits in trunk/WebKit

Reviewed by Chris and Richard.

fixed 3200611 -- Progress indicator in tabs not shown for subframe loads

WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Remove the early out for when we're in the WebFrameStateComplete state. The top frame being complete does not really tell us anything about whether subframes are complete, especially since they can have their locations changed without affecting the top level frame at all.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

11:33 AM Changeset in webkit [3850] by cblu

2 edits in trunk/WebKit

Made data categories use the "_web_" prefix.

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[NSData _web_startsWithBlankLine]): (-[NSData _web_locationAfterFirstBlankLine]):

11:18 AM Changeset in webkit [3849] by cblu

2 edits in trunk/WebKit

WebFoundation:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

Misc.subproj/WebNSDataExtras.h:
Misc.subproj/WebNSDataExtras.m: (_findEOL): new (-[NSData _web_parseRFC822HeaderFields]): new
Misc.subproj/WebNSStringExtras.h:
Misc.subproj/WebNSStringExtras.m: (-[NSString _web_fixedCarbonPOSIXPath]): moved from WB (-[NSString _web_capitalizeRFC822HeaderFieldName]): new

WebKit:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): parse headers, handle carbon POSIX paths (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): call _postURLNotify (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): call _postURLNotify (-[NSData startsWithBlankLine]): new (-[NSData locationAfterFirstBlankLine]): new

WebBrowser:

Renamed canonicalizedCarbonPOSIXPath to _web_fixedCarbonPOSIXPath and moved it down to WF.

Reviewed by ken.

AppController.m: (-[AppController handleURLEvent:withReplyEvent:]):
BrowserNSStringExtras.h:
BrowserNSStringExtras.m:

10:57 AM Changeset in webkit [3848] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed 3200259 - REGRESSION: Clicking on Flash links at homestarrunner.com creates blank windows

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Don't always make the window, only do it if the frame doesn't already exist. Duh.

10:20 AM Changeset in webkit [3847] by darin

3 edits in trunk/WebKit

Reviewed by Trey and Maciej.

fixed 3199154 -- REGRESSION: world leaks on any page load test

WebView.subproj/WebController.m: (-[WebController initWithView:frameName:groupName:]): Call through to initWithFrame, the designated initializer, not init. Calling [super init] results in calling our initWithFrame method, resulting in two calls to the _commonInitialization method.

9:53 AM Changeset in webkit [3846] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

fixed 3199763 - Need to revise authentication API for form passwords
fixed a bunch of crashing and wrongful Keychain saving bugs found while testing

AuthenticationManager.subproj/WebAuthenticatingResource.h:
AuthenticationManager.subproj/WebAuthenticatingResource.m: (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource _internalInit]): (-[WebAuthenticatingResource initWithURL:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithProxyHost:port:type:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithHTMLFormURL:]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource isHTMLForm]): (-[WebAuthenticatingResource host]): (-[WebAuthenticatingResource port]): (-[WebAuthenticatingResource type]): (-[WebAuthenticatingResource hash]): (-[WebAuthenticatingResource isEqual:]):
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _usernameForRealm:URL:]): (-[WebAuthenticationManager _removePasswordForRealm:URL:]): (-[WebAuthenticationManager _removeProxyPasswordForURL:]): (-[WebAuthenticationManager _proxyResourceForURL:]): (-[WebAuthenticationManager _setDefaultUserInfoFromURL:]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
AuthenticationManager.subproj/WebAuthenticationRequest.h:
AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequest resource]): (-[WebAuthenticationRequest defaultUsername]):
AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _rootResourceForResource:]): (-[WebCredentialStorage _resourceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _saveCredential:forResource:isDefault:]): (-[WebCredentialStorage removeCredential:forResource:]): (-[WebCredentialStorage setDefaultCredential:forResource:]):
Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingUserAndPath]):

WebKit:

Reviewed by Trey.

Adjusted for WebFoundation API changes.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):

9:41 AM Changeset in webkit [3845] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

8:59 AM Changeset in webkit [3844] by cblu

9 edits in trunk/WebKit

Fixed: 3199951 - Standalone plug-in content that is cancelled doesn't restart when switching tabs

Instead of creating and managing resourceData in WebMainResourceClient then passing the ownership to WebDataSource, just manage it in WebDataSource. We had the prior behavior because we didn't buffer downloads. Now, we always buffer. The fix for the bug is to retain the incomplete data even though the load ends in error.

Reviewed by darin.

WebView.subproj/WebDataSource.h: updated headerdoc for the data method
WebView.subproj/WebDataSource.m: (-[WebDataSource data]): just return resourceData
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): create resourceData if necessary, append data to it.
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): don't work with resourceData (-[WebMainResourceClient dealloc]): don't work with resourceData (-[WebMainResourceClient resource:didReceiveData:]): don't work with resourceData (-[WebMainResourceClient resourceDidFinishLoading:]): don't work with resourceData

Mar 16, 2003:

8:49 PM Changeset in webkit [3843] by mjs

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3196050 - Hang in www.janegoodall.org dynamic menus

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Copy handlers before processing them, so we don't go into an infinite loop if a handler adds or removes handlers.

12:48 AM Changeset in webkit [3842] by trey

8 edits in trunk

JavaScriptCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

WebFoundation.pbproj/project.pbxproj:

WebCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

WebCore.pbproj/project.pbxproj:

WebKit:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

WebKit.pbproj/project.pbxproj:

WebBrowser:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.

Reviewed by Maciej.

WebBrowser.pbproj/project.pbxproj:

Mar 14, 2003:

6:37 PM Changeset in webkit [3841] by cblu

2 edits in trunk/WebKit

Backed out changes to WebBaseNetscapePluginView. Unintentional commit.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]):

6:29 PM Changeset in webkit [3840] by cblu

4 edits in trunk/WebKit

Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI

Reviewed by mjs.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): call receivedError so [dataSource _receivedError:error complete:YES] is called

6:06 PM Changeset in webkit [3839] by rjw

3 edits in trunk/WebCore

Fixed 3197162. The regression was introduced with the change
to preferences. The old settings API was used to 'reset' the jscript
other properties of the part. This effectively always disabled
javascript and prevented properties from being restored to the js
property maps.

Reviewed by trey.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache):

3:28 PM Changeset in webkit [3838]

13 copies in tags/Safari-66~1

This commit was manufactured by cvs2svn to create tag 'Safari-66~1'.

3:28 PM Changeset in webkit [3837] by mjs

10 edits in branches/Safari-66~1-branch

top level:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

acconfig.h: Remove NO_LICENSE.
configure.in: Remove all the NO_LICENSE-related bits.

Tools:

Scripts/byteswap: Fixed a bug in the tool that Trey spotted. It wouldn't swap newline characters correctly.

JavaScriptCore:

Reviewed by Ken.

fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces

kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.

Tests:

TestURLs.h: Added more test URLs.
kde/kurl-test.chk: Added test results for the new URLs.

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebCore:

Reviewed by John.

fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur

kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.

WebKit:

Reviewed by Dave.

fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com

WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.

WebBrowser:

First step of preferences reorganization. I added new empty
panes for AutoFill and Tabs. I added an Advanced pane and
moved the existing Style Sheet and Proxies controls and code
there. I made no other code changes yet.

Reviewed by Maciej

BookmarksController.m: (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): Unrelated change -- once you've found the Bookmarks Menu or Bookmarks Bar folder, stop iterating. This code will be changed soon anyway due to 3192834.

Preferences.subproj/AdvancedPreferences.tiff: Added.
Preferences.subproj/AutoFillPreferences.tiff: Added.
Preferences.subproj/TabsPreferences.tiff: Added. new images for new preference panes

Preferences.subproj/AdvancedPreferences.h: Added.
Preferences.subproj/AdvancedPreferences.m: Added. (-[AdvancedPreferences sendProxyTabEventToPSN:]): (-[AdvancedPreferences openProxyPreferences:]): (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]): (-[AdvancedPreferences updateStyleSheetMenu]): (-[AdvancedPreferences takeStyleSheetFromMenuItem:]): (-[AdvancedPreferences disableUserStyleSheet:]): (-[AdvancedPreferences choseStyleSheetFromPanel:returnCode:contextInfo:]): (-[AdvancedPreferences chooseStyleSheetFromFileBrowser:]): (-[AdvancedPreferences initializeFromDefaults]): (-[AdvancedPreferences isResizable]): Just cut/pasted code to here from AppearancePreferences (style sheet) and GeneralPreferences (proxies)

Preferences.subproj/AppearancePreferences.h:
Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences initializeFromDefaults]): Cut out the style sheet code.

Preferences.subproj/GeneralPreferences.h:
Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences toggleAutoOpenDownloads:]): Cut out the proxies code.

Preferences.subproj/AutoFillPreferences.h: Added.
Preferences.subproj/AutoFillPreferences.m: Added. New empty husk of a class.

Preferences.subproj/TabsPreferences.h: Added.
Preferences.subproj/TabsPreferences.m: Added. New empty husk of a class.

Preferences.subproj/English.lproj/AutoFillPreferences.nib: Added. New empty husk of a preference pane.

Preferences.subproj/English.lproj/TabsPreferences.nib: Added. New empty husk of a preference pane.

Preferences.subproj/English.lproj/AdvancedPreferences.nib: Added. New preference pane, contains style sheet and proxies controls that formerly lived elsewhere. (Also a silly dividing line.)

Preferences.subproj/English.lproj/AppearancePreferences.nib: Removed style sheet control, shrunk window.

Preferences.subproj/English.lproj/GeneralPreferences.nib: Removed proxies control, shrunk window.

Preferences.subproj/WBPreferences.m: (-[WBPreferences init]): Create the three new panes.

WebBrowser.pbproj/project.pbxproj: updated for new files.

English.lproj/Localizable.strings: updated for names of new panes.

3:27 PM Changeset in webkit [3836] by hyatt

3 edits in trunk/WebCore

Make :target match the root element if no #fragment is specified in
the URL.

Reviewed by john

khtml/css/cssstyleselector.cpp:

3:08 PM Changeset in webkit [3835] by mjs

4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

fixed 3190846 - REGRESSION: can't use Fidelity NetBenefits account

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Treat javascript: URLs as about:blank for now. (HTMLFrameElementImpl::attach): Likewise.
khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Make sure to send completed() signal after signals are connectd in synchronous load case.

1:53 PM Changeset in webkit [3834] by mjs

3 edits in trunk/WebKit

WebKit:

Reviewed by Don.

revert premature controller --> webView renaming, it's causing problems with window opening and such.

WebView.subproj/WebDefaultWindowOperationsDelegate.m:

WebBrowser:

Reviewed by Don.

add controller: argument to a method that now needs it.

(informal protocols suck!)

BrowserWebController.m: (-[BrowserWebController controller:runOpenPanelForFileButtonWithResultListener:]):

12:13 PM Changeset in webkit [3833] by hyatt

4 edits in trunk/WebCore

Fix for ew.com, hrweb and arstechnica forums. A <br> should
not create a nonempty line in the case where the previous line
didn't break cleanly. The fix is to have a new boolean that
tracks how the previous line broke and to have <br> check that
to figure out if it should set the line to be non-empty.

Reviewed by gramps

khtml/rendering/bidi.cpp:

11:28 AM Changeset in webkit [3832] by cblu

7 edits in trunk/WebKit

Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab

We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by the machinery in WebKit. The stream is only delivered once. This fix addresses that.

Reviewed by trey.

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): reset the offset ivar (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): If we create a file for the plug-in, handle the case where the file is already created.
Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView isStarted]): added so the stream knows the state of the view
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]): tweak (-[WebNetscapePluginDocumentView viewDidMoveToWindow]): call redeliverStream if we are added back to the window (-[WebNetscapePluginDocumentView setDataSource:]): only start the plug-in if we are in a window, don't assert
Plugins.subproj/WebNetscapePluginRepresentation.h:
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): release the retained data source and error (-[WebNetscapePluginRepresentation setDataSource:]): retain the data source (-[WebNetscapePluginRepresentation isPluginViewStarted]): new (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): retain the error, only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]): only do work if isPluginViewStarted

(-[WebNetscapePluginRepresentation redeliverStream]): call receivedData: with all the received data up to this point. Call receivedError:: or finishedLoadingWithDataSource: if the load is already complete.

Mar 13, 2003:

11:17 PM Changeset in webkit [3831]

1 copy
319 deletes in branches/unlabeled-1.10.38

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.10.38'.

11:17 PM Changeset in webkit [3830] by mjs

26 edits in trunk

WebCore:

Reviewed by Trey.

fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements

khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): Connect to clicked signal. (RenderFileButton::RenderFileButton): Likewise. (RenderFileButton::slotClicked): Send clicked through DOM. (RenderTextArea::RenderTextArea): Connect to clicked signal.
khtml/rendering/render_replaced.cpp: (RenderWidget::sendConsumedMouseUp): New method to send a mouseUp event for this DOM element. Meant for up events consumed by AppKit mouseDown: methods that use modal event loops.
khtml/rendering/render_replaced.h:
kwq/KWQButton.h:
kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Moved here from former adaptor class. (-[KWQButton action:]): Make sure to send up before click. (-[KWQButton mouseDown:]): Record that we are processing a mouse event. If no click happened, send the missing up event. (QButton::QButton): Use NSButton subclass instead of separate adaptor. (QButton::~QButton): Likewise.
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Initialize clicked signal. (KWQFileButton::clicked): Emit clicked signal. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe Clicked notification too. (-[KWQFileButtonAdapter clicked]): Send mouse up and click through DOM.
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Initialize clicked signal. (QLineEdit::clicked): Emit clicked signal.
kwq/KWQListBox.mm: (QListBox::QListBox): No longer use separate object as delegate and data source. (QListBox::~QListBox): No more need to retrieve and release delegate. (-[KWQTableView initWithListBox:items:]): (-[KWQTableView mouseDown:]): Record that we are processing a mouse event; if no click happens while processing, send the mouse up event through the DOM. (-[KWQTableView tableViewSelectionDidChange:]): If sending clicked and processing a mouse event, send up first.
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView mouseDown:]): Send up and click through DOM after calling super.
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Initialize clicked signal. (QTextEdit::clicked): Emit clicked signal.
kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): initWithQLineEdit: instead of initWithQWidget: (-[KWQTextField fieldEditorDidMouseDown:]): Send up and click through DOM. (-[KWQSecureTextField initWithQLineEdit:]): Store QLineEdit*, not just QWidget*. (-[KWQSecureTextField fieldEditorDidMouseDown:]): Send up and click through DOM.
kwq/KWQWidget.h:
kwq/KWQWidget.mm: (QWidget::sendConsumedMouseUp): Common method for widgets to send a mouseUp that has been consumed by mouseDown processing through the DOM.
kwq/WebCoreBridge.h:
kwq/WebCoreFirstResponderChanges.h:
kwq/WebCoreViewFactory.m:
WebCore.exp: Export new string constant.
WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Trey.

fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements

WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton chooseButtonPressed:]): Send appropriate NSNotification.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView mouseDown:]): Call fieldEditorDidMouseDown: on delegate, if implemented, after calling super.

7:09 PM Changeset in webkit [3829] by rjw

67 edits in trunk

WebKit:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView. Also
added some simple action methods to WebController (soon to be WebView)
to facilitate IB hookup.

Reviewed by Maciej.

Carbon.subproj/CarbonWindowAdapter.m:
Carbon.subproj/HIWebView.h:
Carbon.subproj/HIWebView.m: (if): (switch):
Carbon.subproj/HIWebViewPriv.h:
Misc.subproj/WebKitStatistics.m: (+[WebKitStatistics viewCount]):
Misc.subproj/WebKitStatisticsPrivate.h:
Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebFrameView]):
Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels frontmostWindowLoadingURL:]):
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge window]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge nextKeyViewOutsideWebFrameViews]): (-[WebBridge previousKeyViewOutsideWebFrameViews]): (-[WebBridge setNeedsReapplyStyles]): (-[WebBridge setNeedsLayout]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge frameRequiredForMIMEType:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (+[WebContentTypes canShowMIMEType:]): (-[WebController _commonInitialization:frameName:groupName:]): (-[WebController init]): (-[WebController initWithFrame:]): (-[WebController initWithView:]): (-[WebController supportsTextEncoding]): (-[WebController takeStringURLFrom:]): (-[WebController goBack:]): (-[WebController goForward:]): (-[WebController stopLoading:]):
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate _clearControllerReferences:]): (-[WebController _createFrameNamed:inParent:allowsScrolling:]): (-[WebController _frameForView:fromFrame:]): (-[WebController _frameForView:]):
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _layoutChildren]): (-[WebDataSource _receivedData:]):
WebView.subproj/WebDebugDOMNode.h:
WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithWebFrameView:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate controller:contextMenuItemsForElement:defaultMenuItems:]):
WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate controller:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate controller:clientRedirectCancelledForFrame:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate controller:unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate controller:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate controller:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate controller:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:pluginFailedWithError:dataSource:]):
WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate controller:runOpenPanelForFileButtonWithResultListener:]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebDynamicScrollBarsView.m:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:controller:]): (-[WebFrame view]): (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (if): (switch):
WebView.subproj/WebHTMLView.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView becomeFirstResponder]):
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]): (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]): (-[WebImageView mouseDragged:]): (-[WebImageView draggedImage:endedAt:operation:]):
WebView.subproj/WebLocationChangeDelegate.h:
WebView.subproj/WebRenderNode.h:
WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): (-[WebRenderNode initWithWebFrameView:]):
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebFrameView initWithFrame:]): (-[WebFrameView dealloc]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m:
WebView.subproj/WebWindowOperationsDelegate.h:

WebCore:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyView):
kwq/KWQScrollView.mm:
kwq/KWQWidget.mm: (QWidget::getOuterView):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreBridge previousKeyViewInsideWebFrameViews]):

WebBrowser:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument mainWebFrameView]): (-[BrowserDocument bugReportSheetDidEnd:returnCode:contextInfo:]): (-[BrowserDocument printShowingPrintPanel:]): (-[BrowserDocument setURLString:]): (-[BrowserDocument text]):
BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController mainWebFrameView]): (-[BrowserWebController goToRequest:allowJavaScript:waitInQueue:]): (-[BrowserWebController goToURL:withFallbackURLs:]): (-[BrowserWebController setShouldStartEmpty]):
BrowserWebViewExtras.h:
BrowserWebViewExtras.m: (-[WebFrameView largestScrollableWebView]):
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateKeyboardLoop]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController windowWillHandleKeyEvent:]): (-[BrowserWindowController bestWindowSizeForCurrentPageWithDefaultSize:]): (-[BrowserWindowController frameLoadStarted:]): (-[BrowserWindowController frameLoadCommitted:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController targetForSearch]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]):
ContextMenuHandler.m: (-[ContextMenuHandler controller:contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler search:]): (-[ContextMenuHandler goToAddress:]):
Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebFrameView:]): (-[DOMTree createTreeFromController:]):
Debug/RenderTree.m: (-[RenderTreeDataSource initWithWebFrameView:]): (-[RenderTree createTreeFromController:]):
Debug/SnippetController.m: (-[SnippetController load]):
Debug/ViewTree.m: (-[ViewTreeDataSource initWithWebFrameView:]): (-[ViewTree createTreeFromController:]):
FormCompletionController.m: (+[AutoFillController autoFillInController:]):

Tests:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

DumpBackForward/main.m: (main): (-[CheapWindowOpsDelegate controller:createWindowWithRequest:]):
DumpRenderTree/main.m: (main):
IBViewer/DocumentController.h:
IBViewer/DocumentController.m: (-[DocumentController controller:locationChangeStartedForDataSource:]): (-[DocumentController controller:locationChangeDone:forDataSource:]):
IBViewer/English.lproj/Document.nib:
PDFBundle/PDFView.m: (-[PDFView dataSource]): (-[PDFView layout]): (+[PDFPluginViewFactory pluginViewWithArguments:]):
PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):
PDFViewer/DocumentController.m: (-[DocumentController loadURL:]):
PDFViewer/PDFRepresentation.m: (-[PDFView layout]):
SimpleViewer/ApplicationController.m:
SimpleViewer/DocumentController.h:
SimpleViewer/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController loadURL:]):
SnippetEditor/ApplicationController.m:
SnippetEditor/SnippetController.m: (-[SnippetController _resetViews]): (-[SnippetController loadComplete]):

5:41 PM Changeset in webkit [3828] by darin

3 edits in trunk/WebCore

remove mistaken inlining to fix build with newer versions of gcc

khtml/rendering/render_object.cpp: (RenderObject::container): Don't mark this inline.

5:25 PM Changeset in webkit [3827] by hyatt

3 edits in trunk/WebCore

This is a fix to stop creating textruns for the whitespace at the
end of a block. This is a major line layout bug that leads to the
height of the last line in a paragraph being wrong, especially when
<font> tags are used.

Example of the problem:

<div><nobr>foo</nobr> </div>

The whitespace between the </nobr> and the end of the </div> was
being counted when it should have been stripped. The problem was
an off-by-one error with the endpoint I set up. I used a position
of 0, which is inclusive, so I needed a new value that meant
"Stop on this object and don't include any of it." I'm using
UINT_MAX as this special value for the position.

Reviewed by john

khtml/rendering/bidi.cpp:
khtml/rendering/bidi.h:

4:57 PM Changeset in webkit [3826] by sullivan

2 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

English.lproj/StringsNotToBeLocalized.txt: Removed all the bookmarks-related strings that I forgot to remove in my previous checkin.

WebBrowser:

fixed 3192834 Bookmarks Bar and Menu titles should not be localized in bookmarks.plist, for synching

Reviewed by Trey.

WebBookmarkGroup.h: changed _loading to _notificationsSuppressed
WebBookmarkGroup.m: (-[WebBookmarkGroup suppressNotifications]): new method, sets _notificationsSuppressed (and asserts about reentrancy) (-[WebBookmarkGroup resumeNotifications]): new method, clears _notificationsSuppressed (and asserts about reentrancy) (-[WebBookmarkGroup _sendNotification:forBookmark:children:]): check _notificationsSuppressed instead of _loading (-[WebBookmarkGroup _loadBookmarkGroupGuts]): call suppress/resumeNotifications instead of using _loading

BookmarksController.m: (+[BookmarksController _favoritesTitle]): just tweaked localization comment (+[BookmarksController _menuRootTitle]): ditto (+[BookmarksController historyProxyTitle]): ditto (+[BookmarksController addressBookProxyTitle]): ditto (+[BookmarksController rendezvousProxyTitle]): ditto (-[BookmarksController savePendingChanges]): temporarily change titles of bookmarks for bar and menu so that the special well-known stored value is saved; guard with -[WebBookmarkGroup suppress/resumeNotifications]. (-[BookmarksController findOrCreateBookmarkSourceWithStoredTitle:displayedTitle:atIndex:]): modified to look first for well-known stored title and 2nd for displayed title; don't look for special UUIDs anymore. Death to special UUIDs. (-[BookmarksController updateBookmarkSources]): call findOrCreateBookmarkSourceWithStoredTitle:displayedTitle:atIndex: appropriately

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: updated for these changes and also for the big bookmark code-moving change earlier.

WebBrowser.pbproj/project.pbxproj: change encoding of AutoFillPreferences.m to Unicode so I can use a curly quote in an error message

Preferences.subproj/AutoFillPreferences.m: (-[AutoFillPreferences editMyCard:]): return of the curly quote now that I changed the file encoding properly

3:12 PM Changeset in webkit [3825]

8 copies in tags/Safari-67~1

This commit was manufactured by cvs2svn to create tag 'Safari-67~1'.

3:12 PM Changeset in webkit [3824] by darin

5 edits in branches/Safari-67~1-branch/WebCore

fixes for building with newer gcc

khtml/css/Makefile.am: Rolled in Makefile fix from main trunk.
khtml/css/parser.y: Rolled in inline build fix from main trunk.
khtml/css/parser.cpp: Regenerated.

3:03 PM Changeset in webkit [3823] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed 3197728 -- REGRESSION: crash at http://transitive.com/company.htm

khtml/rendering/bidi.cpp: (appendRun): Added an if statement to handle the case where obj is 0; the while loop already handled that case.

did the "no inlining workaround" needed for newer versions of gcc

khtml/css/parser.y: Added #define inline as we have elsewhere.
khtml/css/parser.cpp: Regenerated.

12:45 PM Changeset in webkit [3822] by hyatt

3 edits in trunk/WebCore

Add color dumping and bgcolor dumping to the render dump tool.

Reviewed by darin

kwq/KWQRenderTreeDebug.cpp: (operator<<):

12:25 PM Changeset in webkit [3821] by hyatt

10 edits in trunk/WebCore

Fix for 3193407, crash in CSS parser on www.hixie.ch. Improved the grammar to
understand the CSS3 :not selector so that it wouldn't think of that case as an
error. Also patched the error handling case that crashed on :not anyway. Then
I went ahead and implemented :not (since it was trivial to add once the parser
was reading it in).

Also fixed the regression that the * selector didn't work. The new KHTML trunk moved
away from a tag value of -1 in order to do @namespace support. Since we aren't really ready
to take that code yet, I patched our parser.y to treat * like -1 instead of 0xffff.

Implemented support for a couple of new CSS3 selectors, :root and ::selection. Also :last-child and :only-child.

Fixed a trivial bug (demonstrated in the CSS3 test suite) with the matching of the ~= selector.

Reviewed by darin

khtml/css/Makefile.am:
khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
khtml/css/css_base.h:
khtml/css/cssstyleselector.cpp:
khtml/css/parser.cpp:
khtml/css/parser.y:
khtml/rendering/render_style.h:
khtml/rendering/render_text.cpp: (TextRun::paintSelection): (RenderText::paintObject):

12:11 PM Changeset in webkit [3820] by sullivan

3 edits
1 delete in trunk/WebKit

WebKit:

Removed all the bookmarks code from WebKit; put it
in WebBrowser instead.

Reviewed by Darin

Bookmarks.subproj/WebBookmark.h: Removed.
Bookmarks.subproj/WebBookmark.m: Removed.
Bookmarks.subproj/WebBookmarkGroup.h: Removed.
Bookmarks.subproj/WebBookmarkGroup.m: Removed.
Bookmarks.subproj/WebBookmarkGroupPrivate.h: Removed.
Bookmarks.subproj/WebBookmarkImporter.h: Removed.
Bookmarks.subproj/WebBookmarkImporter.m: Removed.
Bookmarks.subproj/WebBookmarkLeaf.h: Removed.
Bookmarks.subproj/WebBookmarkLeaf.m: Removed.
Bookmarks.subproj/WebBookmarkList.h: Removed.
Bookmarks.subproj/WebBookmarkList.m: Removed.
Bookmarks.subproj/WebBookmarkPrivate.h: Removed.
Bookmarks.subproj/WebBookmarkProxy.h: Removed.
Bookmarks.subproj/WebBookmarkProxy.m: Removed.
WebKit.exp: removed all bookmark-related symbols
WebKit.pbproj/project.pbxproj: updated for removed files

WebBrowser:

Moved all the bookmarks code that was in WebKit
into WebBrowser. No code changes other than fixing
up #imports to make everything compile.

Reviewed by Darin

ABHomePagesController.m:
BookmarkSource.m:
BookmarksController.m:
BookmarksViewController.m:
BrowserDocument.m:
BrowserNSViewExtras.m:
BrowserWebBookmarkExtras.h:
BrowserWebBookmarkExtras.m:
BrowserWindowController.m:
ContextMenuHandler.m:
FavoritesBar.m:
FavoritesBarView.m:
GlobalHistory.m:
LocationTextField.m:
NewBookmarksController.m:
RendezvousController.m:
TitleBarButton.m:
URLCompletionController.m: Just fixed up #imports for moved bookmarks files.

WebBookmark.m:
WebBookmarkGroup.h:
WebBookmarkGroup.m:
WebBookmarkGroupPrivate.h:
WebBookmarkImporter.m:
WebBookmarkLeaf.h:
WebBookmarkLeaf.m:
WebBookmarkList.h:
WebBookmarkList.m:
WebBookmarkPrivate.h:
WebBookmarkProxy.h: These are the files that were moved (and had their #imports changed also). They don't say "New" because I moved the cvs history on the server first.

WebBrowser.pbproj/project.pbxproj: updated for files added to project

12:05 PM Changeset in webkit [3819] by sheridan

3 edits in trunk

tree for Safari-68u is open

11:53 AM Changeset in webkit [3818]

3 copies in branches/Safari-67~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-67~1-branch'.

11:53 AM Changeset in webkit [3817]

3 copies in tags/Safari-67~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-67~1-anchor'.

11:53 AM Changeset in webkit [3816]

3 copies in tags/Safari-67

This commit was manufactured by cvs2svn to create tag 'Safari-67'.

11:53 AM Changeset in webkit [3815] by sheridan

8 edits in trunk

Safari-67 stamp

7:18 AM Changeset in webkit [3814] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3194451 -- Textarea COLS='40.0' displays with width of 0

khtml/xml/dom_stringimpl.h: Changed toInt to not be inline any more. It was already really too big for inline to be a good optimization.
khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::toInt): Rewrote this to find the valid characters at the start of the string, rather than strip invalid characters from the end. The old code would strip non-digits from the end, which doesn't help with a string like "40.0" or even "40 garbage3".

fixed a bit of int/long sloppiness

kwq/KWQString.mm: (QString::toLong): Use LONG_MAX, not INT_MAX. (QString::toULong): Use ULONG_MAX, not UINT_MAX.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed