Context Navigation

← Previous Period
Next Period →

Timeline

May 13, 2003:

7:06 PM Changeset in webkit [4368] by hyatt

3 edits in trunk/WebCore

Fix for 3222607. divs that specify a fixed width should have
their minwidths increased to that width. This is an issue
on diveintomark's list as well as a blocker for Benoit.

Reviewed by gramps

khtml/rendering/render_block.cpp:

6:39 PM Changeset in webkit [4367] by hyatt

18 edits in trunk/WebCore

Fix for 3256376, absolute positioned content that had to be
scrolled into view would not respond to events. This is a
regression caused by fixing the size of the HTML element.

I stopped all of the updating of layer widths/heights in
setLayouted and in setWidth/Height of RenderBox and special-cased
the sizing of the RenderCanvas layer so that it always encloses
all content.

This patch also contains a fix for 3211915, left/top positions
not computed properly when auto or static. The patch adds
staticX/Y member variables to RenderBox that holds the cached
values that can then be used by positioned elements to determine
their correct positions in the flow. RenderStyles also now
remember both the original display of an element as well as
the mutated display (e.g., when an inline becomes a block
because of absolute positioning).

Reviewed by darin (canvas fix) and kocienda (left/top fix)

khtml/css/cssstyleselector.cpp:
khtml/rendering/bidi.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::position): (RenderBox::setStaticX): (RenderBox::setStaticY): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical):
khtml/rendering/render_box.h:
khtml/rendering/render_canvas.cpp:
khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox):
khtml/rendering/render_flow.h:
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::adjustMaxAscentAndDescent): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren):
khtml/rendering/render_object.cpp: (RenderObject::hasStaticX): (RenderObject::hasStaticY): (RenderObject::setNeedsLayout): (RenderObject::createInlineBox):
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (RenderStyle::diff):
khtml/rendering/render_style.h:
khtml/rendering/render_text.cpp: (RenderText::createInlineBox):
khtml/rendering/render_text.h:

6:30 PM Changeset in webkit [4366] by rjw

13 edits
1 add in trunk

WebKit:

Fixed 3014661. We now display (a lame Lemay) image
when an image fails to load. We also display the
alt text if it fits within the image container
above the missing image icon. Alt text is also
now shown if image loading is disabled.

Reviewed by John.

Resources/missing_image.tiff: Added.
WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer isNull]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithName:]):
WebKit.pbproj/project.pbxproj:

WebCore:

Fixed 3014661. We now display (a lame Lemay) image
when an image fails to load. We also display the
alt text if it fits within the image container
above the missing image icon. Alt text is also
now shown if image loading is disabled.

Reviewed by John.

khtml/misc/loader.cpp: (CachedImage::data): (Cache::init):
khtml/rendering/render_image.cpp: (RenderImage::paintObject): (RenderImage::reload):
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (KWQLoadPixmap): (QPixmap::QPixmap): (QPixmap::isNull):
kwq/WebCoreImageRenderer.h:
kwq/WebCoreImageRendererFactory.h:

3:36 PM Changeset in webkit [4365] by cblu

2 edits in trunk/WebKit

Reviewed by Chris and Richard.

fixed 3257296 -- REGRESSION: crash in WebImageRendererFactory (movietickets.com)

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): Check for nil. (-[WebImageRenderer initWithData:MIMEType:]): Check for nil, also don't check for GIF signature until after the object is allocated.

2:19 PM Changeset in webkit [4364]

1 copy
318 deletes in branches/unlabeled-1.6.20

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.20'.

2:19 PM Changeset in webkit [4363] by mjs

18 edits in trunk

JavaScriptCore:

Reviewed by Darin.

fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
improved JavaScript error message format

kjs/error_object.cpp: (ErrorProtoFuncImp::call): Include line number in toString output.
kjs/internal.cpp: (Parser::parse): Remove redundant fprintf.
kjs/interpreter.cpp: (Interpreter::evaluate): Log if the flag is on. Include filename in log output. (Interpreter::shouldPrintExceptions): Check the global flag. (Interpreter::setShouldPrintExceptions): Set the global flag.
kjs/interpreter.h:
kjs/nodes.cpp: (Node::throwError): Add variants that include value and expression or label in format. (NewExprNode::evaluate): Improve error message. (FunctionCallNode::evaluate): Improve error message. (RelationalNode::evaluate): Improve error message. (ContinueNode::execute): Improve error message. (BreakNode::execute): Improve error message. (LabelNode::execute): Improve error message.
kjs/nodes.h:

WebCore:

Reviewed by Darin.

fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Pass the filename.
kwq/WebCoreJavaScript.h:
kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript shouldPrintExceptions]): Call through to JavaScriptCore. (+[WebCoreJavaScript setShouldPrintExceptions:]): Call through to JavaScriptCore.
khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Print exception if there is one.
khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Print exception in the function case.

WebKit:

Reviewed by Darin.

fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

Misc.subproj/WebCoreStatistics.h:
Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics shouldPrintExceptions]): Call through to WebCore. (+[WebCoreStatistics setShouldPrintExceptions:]): Call through to WebCore.

WebBrowser:

Reviewed by Darin.

fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Include "Log JavaScript Exceptions" item. (-[BrowserDocument toggleLogJavaScriptExceptions:]): Call WebKit to do the toggle. (-[BrowserDocument validate_toggleLogJavaScriptExceptions:]): Set state properly.

1:40 PM Changeset in webkit [4362] by darin

3 edits in trunk/WebCore

Tests:

Reviewed by Ken.

kde/kurl-test.chk: Update test results affected by the query changes.

kde/kurl-relative-test.chk: Update test results for recent changes (this test has been off for some time, so some changes were not that recent).
test.list: Turned kurl-relative-test back on.

WebCore:

Reviewed by Ken.

fixed 3140822 -- relative URLs starting with query strings clobber path as the RFC says, but web says no

kwq/KWQKURL.mm: (KURL::KURL): Add a case for queries (as with anchors) to match the behavior of the web (albeit not the RFC).

1:15 PM Changeset in webkit [4361] by darin

7 edits in trunk

WebCore:

Reviewed by Ken.

fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)

kwq/WebCoreEncodings.h: Added decodeData:, removed all other (unused) methods.
kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): Added. Calls the same decoder used to decode web pages.

WebKit:

Reviewed by Ken.

fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)

WebView.subproj/WebViewPrivate.h: Added _decodeData:.
WebView.subproj/WebViewPrivate.m: (+[WebView _decodeData:]): Added. Calls through to WebCore.

WebBrowser:

Reviewed by Ken.

fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)

WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): Use new SPI call that decodes taking encoding into account, since the bookmarks file uses the same kinds of encoding techniques as web pages.

1:04 PM Changeset in webkit [4360] by mjs

2 edits in trunk/WebKit

WebFoundation:

API CHANGE

Reviewed by Darin.

renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
removed NSURLCFStreamErrorDomain

Misc.subproj/NSURLError.h:
Misc.subproj/WebNSErrorExtras.m: (-[NSError _web_initWithDomain:code:failingURL:]): (-[NSError _web_failingURL]):
WebFoundation-base.exp:

WebKit:

Reviewed by Darin.

renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey

Misc.subproj/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):

WebBrowser:

Reviewed by Darin.

renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey

LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):

9:42 AM Changeset in webkit [4359] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed 3228186 -- REGRESSION: crash walking parent tree at housingscc.org in DOM::StyleBaseImpl::stylesheet()

khtml/xml/dom_elementimpl.cpp: (ElementImpl::~ElementImpl): Unref the stylesheet with the style declaration in it when destroying the element. (ElementImpl::createDecl): Ref the stylesheet with the style declaration in it when making a style element for this. If we don't we could end up with a style declaration without a stylesheet, which can't be manipulated by the CSS parser.

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::removeCSSProperty): Since this function has a side effect of changing the stylesheet for the style declaration, ref the new stylesheet and unref the old one.

9:40 AM Changeset in webkit [4358] by sullivan

2 edits in trunk/WebKit

fixed build break

Reviewed by Darin

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): move #ifdefs; two required methods were being #ifdeffed out on Panther

May 12, 2003:

6:19 PM Changeset in webkit [4357] by rjw

3 edits in trunk/WebKit

Fixed 3251316. * Public API Change *

Added -(void)setGroupName:(NSString *) and -(NSString *)groupName;

Reviewed by mjs.

WebView.subproj/WebView.h:
WebView.subproj/WebView.m:

5:07 PM Changeset in webkit [4356] by rjw

21 edits in trunk

WebCore:

Fixed 3194614 and 3194751. We avoid creating and render objects
and loading any images if the document is in 'renderless' mode.

Also, we now unique instances of the ObjC DOM wrappers.

Reviewed by hyatt/darin.

khtml/misc/loader.cpp:
khtml/xml/dom_docimpl.cpp:
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp:
kwq/KWQLoader.h:
kwq/KWQLoader.mm:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:
kwq/WebCoreDOMNode.mm:
kwq/WebDOMNode.h:

Pass the reported MIME type of an image up to WebKit when
creating an WebImageRenderer. This is useful to help speed up
the selection of an appropriate decoder.

Reviewed by darin.

kwq/WebCoreImageRendererFactory.h:
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm:

WebKit:

Fixed 3194614 and 3194751. Add SPI to set 'renderless' mode
for a frame.

Reviewed by darin.

WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m:

WebImageRenderers now get a MIME type that can be used to faciliate
selection of an appropriate decoder.

Reviewed by darin.

WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m:
WebCoreSupport.subproj/WebImageRendererFactory.m:
WebKit.pbproj/project.pbxproj:

4:32 PM Changeset in webkit [4355] by sullivan

7 edits in trunk/WebKit

WebKit:

addition to Darin's previous patch; when checking whether a request can be handled, take into account the schemes that were registered without an NSURLProtocol getting involved.

Reviewed by Darin

WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (+[WebView _canHandleRequest:]): like NSURLConnection canHandleRequest, but also takes into account the schemes that were registered without an NSURLProtocol
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest]
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): ditto
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): ditto
WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): ditto

WebBrowser:

more code cleanup from bookmarks view change; eliminated BookmarksProtocol entirely.

Reviewed by Darin

BookmarksProtocol.h: Removed. Two #defines were moved to BookmarksView.h
BookmarksProtocol.m: Removed.

BookmarksView.h: Moved to #defines here from BookmarksProtocol.h

AppController.m: #import BookmarksView.h instead of BookmarksProtocol.h (+[AppController initialize]): remove call that registered BookmarkProtocol with NSURLProtocol

BrowserWebController.m: #import BookmarksView.h instead of BookmarksProtocol.h (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest] so it works for bookmarks (and any future registered schemes)

BrowserWindowController.m: #import BookmarksView.h instead of BookmarksProtocol.h
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest] so it works for bookmarks (and any future registered schemes)

English.lproj/StringsNotToBeLocalized.txt: updated for moving the two #defines

WebBrowser.pbproj/project.pbxproj: updated for removed files

4:19 PM Changeset in webkit [4354] by darin

4 edits in trunk/WebCore

Reviewed by Richard.

fixed 3240925 -- can't select or copy text from readonly INPUT elements

An AppKit peculiarity. Calling setEditable:NO will have a side effect of
doing setSelectable:NO unless you explicitly did setSelectable:YES.

kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Call setSelectable:YES.

kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): When creating the password field, keep the setSelectable state synchronized. (-[KWQTextField setSelectable:]): If we already have a password field, be sure to keep its selectable state the same as the main field.

1:29 PM Changeset in webkit [4353] by darin

6 edits in trunk/WebKit

WebKit:

Reviewed by John.

fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first

WebView.subproj/WebViewPrivate.h: Added new SPI for registering view and represenation classes by scheme rather than MIME type.
WebView.subproj/WebViewPrivate.m: (+[WebView _registerViewClass:representationClass:forURLScheme:]]): Added. (+[WebView _generatedMIMETypeForURLScheme:]): Added. Makes a special MIME type for us only by the special "register scheme" mechanism. (+[WebView _representationExistsForURLScheme:]): Added.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Check for schemes that have their own representation, and handle them just like empty documents, loading no data, and doing it synchronously. (-[WebMainResourceClient loadWithRequest:]): Same thing here, only also arrange to get the appropriate MIME type. (-[WebMainResourceClient setDefersCallbacks:]): Same check here.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by John.

fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first

AppController.m: (+[AppController initialize]): Register the bookmarks view and representation class using the scheme, not the MIME type.

BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): Fix off by one error that would cause an NSException when you typed bookmarks:. Also fix so that bookmarks: is not treated as a host name.

9:11 AM Changeset in webkit [4352] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3255281 -- REGRESSION: objc_error in key loop code, closing tab containing aintitcool.com page

kwq/KWQTextField.mm: (-[KWQSecureTextField nextKeyView]): Change back to using our own nextKeyView implementation. By returning the nextKeyView from KWQTextField, we ended up making AppKit very upset about the key view loop. This undoes a change I made last Thursday, so the regression is very new and was never in a release. (-[KWQSecureTextField previousKeyView]): More of the same. (-[KWQSecureTextField nextValidKeyView]): Ditto. (-[KWQSecureTextField previousValidKeyView]): Ditto.

May 11, 2003:

12:15 PM Changeset in webkit [4351] by hyatt

2 edits in trunk/WebCore

The root element (HTML) tries to set itself to the lowest position
of the canvas, before the canvas has necessarily even determined
the correct lowest position. This creates a timing problem.

This code is legacy code anyyway, left over from before KHTML
understood about overflow. The HTML should not be resizing itself
to enclose positioned content or floats. They should just spill
out of the HTML object, so the fix is easy: kill the legacy code.

There's a second fix required as well, which is to make the canvas
avoid scanning its positioned objects list when computing its
lowest and rightmost position. Fixed positioned objects can't
be scrolled, so it's incorrect to show scrollbars because of
fixed positioned objects (since they are locked to the viewport).

Reviewed by darin/gramps

khtml/rendering/render_block.cpp:

12:15 PM Changeset in webkit [4350] by hyatt

3 edits in trunk/WebCore

The root element (HTML) tries to set itself to the lowest position
of the canvas, before the canvas has necessarily even determined
the correct lowest position. This creates a timing problem.

This code is legacy code anyyway, left over from before KHTML
understood about overflow. The HTML should not be resizing itself
to enclose positioned content or floats. They should just spill
out of the HTML object, so the fix is easy: kill the legacy code.

There's a second fix required as well, which is to make the canvas
avoid scanning its positioned objects list when computing its
lowest and rightmost position. Fixed positioned objects can't
be scrolled, so it's incorrect to show scrollbars because of
fixed positioned objects (since they are locked to the viewport).

Reviewed by darin/gramps

khtml/rendering/render_block.cpp:

11:53 AM Changeset in webkit [4349] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3242493 -- loop in khtml::RenderLayer::RenderZTreeNode at google cached copy of epower2go.biz page

khtml/rendering/render_layer.cpp: (RenderLayer::RenderZTreeNode::detach): Use an iterative algorithm rather than a recursive one to destroy the child nodes at each level of the tree, so our recursion is O(depth of tree) rather than O(size of tree).

8:27 AM Changeset in webkit [4348] by darin

2 edits in trunk/WebKit

WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): Added a check for nil that I forgot.

8:04 AM Changeset in webkit [4347] by darin

3 edits in trunk/WebKit

Reviewed by John.

fixed 3254473 - REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)

WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): Don't send out a resize event any time during the first event that results in a layout. The old check was merely for the first layout, but we need to ignore any number of layouts that are all part of handling a first event. Some day we may need to refine this rule even further, but this fixes the present bug.

WebView.subproj/WebHTMLViewPrivate.h: Goodbye laidOutAtLeastOnce, hello firstLayoutEventTime.

May 10, 2003:

11:20 PM Changeset in webkit [4346] by hyatt

3 edits in trunk/WebCore

Fix the misrendering at the top of cnn.com (the extra tearing
by the Google logo on the front page of cnn).

I am reducing the intrinsic margins of text fields down to 2px
to match buttons and selects.

This is easily sufficient distance to avoid focus ring overlap and
still looks nice, e.g., on www.google.com and amazon.com.

Reviewed by mjs

khtml/rendering/render_form.h:

6:05 PM Changeset in webkit [4345] by hyatt

6 edits in trunk/WebCore

A refinement of our intrinsic margin rules for form controls.
Rather than always applying the intrinsic margin to form controls,
this patch makes the application conditional.

If the Web page explicitly specifies a width on a form control,
the form control will honor that precise pixel-width and will not
apply left/right intrinsic margins. If a Web page specifies margins
that the control should use, then the control will honor those
margins. The same rules apply for height and top/bottom margins.

Reviewed by mjs

khtml/css/html4.css:
khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedHeight):
khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfNeeded): (RenderFormElement::setStyle):
khtml/rendering/render_form.h:

5:32 PM Changeset in webkit [4344] by darin

6 edits in trunk/WebCore

Tests:

Reviewed by Maciej.

update tests for removal of prettyURL parameter, added a new test for mailto URLs with subjects

TestURLs.h: Added "mailto:mduerst@ifi.unizh.ch?Subject=nothing".
kde/kurl-test.chk: Removed prettyURL(1) and prettyURL(-1) tests. Added test results for new URL.
kde/kurl-test.cpp: (testURL): Removed prettyURL(1) and prettyURL(-1) tests.
test.list: Removed ifnsthreadextensions-test.

WebCore:

Reviewed by Maciej.

fixed 3206695 -- Safari puts all of the mailto form content in email subject line, should put content in body

The bug was caused by our KURL class not parsing the query out of the mailto URL properly.

kwq/KWQKURL.h: Removed parameter from prettyURL, unused in KHTML.
kwq/KWQKURL.mm: (KURL::prettyURL): Removed parameter, unused in KHTML. (KURL::parse): Parse queries even from non-hierarchical URLs. This fixes the bug.

WebCore-tests.exp: Updated for parameter removed from prettyURL.
WebCore-combined.exp: Regenerated.

12:59 AM Changeset in webkit [4343] by darin

6 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

fixed 3250119 -- REGRESSION: WebFrame leaked after showing pop-up menu

The leak was caused by various code storing the "element" dictionary that describes where
a click took place.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Don't store the element in a retained global. Instead attach it as the represented object to each menu item. (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): Pass in an element. (-[WebDefaultUIDelegate downloadURL:element:]): Ditto. (-[WebDefaultUIDelegate openLinkInNewWindow:]): Get element from represented object. (-[WebDefaultUIDelegate downloadLinkToDisk:]): Ditto. (-[WebDefaultUIDelegate copyLinkToClipboard:]): Ditto. (-[WebDefaultUIDelegate openImageInNewWindow:]): Ditto. (-[WebDefaultUIDelegate downloadImageToDisk:]): Ditto. (-[WebDefaultUIDelegate copyImageToClipboard:]): Ditto. (-[WebDefaultUIDelegate openFrameInNewWindow:]): Ditto.

WebView.subproj/WebDefaultUIDelegate.h: Remove element field.
WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate dealloc]): No need to release element any more.

WebView.subproj/WebHTMLViewPrivate.h: Remove dragElement instance variable.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): No need to release dragElement any more. (-[WebHTMLView _handleMouseDragged:]): Get element again here. The old code used to get it from an instance variable, but that is unnecessary. (-[WebHTMLView _mayStartDragWithMouseDragged:]): Don't store the element.

WebBrowser:

Reviewed by Maciej.

fixed 3250119 -- REGRESSION: WebFrame leaked after showing pop-up menu

The leak was caused by various code storing the "element" dictionary that describes where
a click took place.

BrowserWebController.h: Added windowController and browserWindow methods for convenience. Removed element instance variable. Keeping this dictionary around caused a leak of a WebFrame.
BrowserWebController.m: (-[BrowserWebView browserWindow]): Added. (-[BrowserWebView initWithDocument:request:frameName:]): Use browserWindow. (-[BrowserWebView dealloc]): Don't release element. (-[BrowserWebView webViewIsResizable:]): Use browserWindow. (-[BrowserWebView webViewFrame:]): Use browserWindow. (-[BrowserWebView webViewContentRect:]): Use browserWindow. (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): Use browserWindow. (-[BrowserWebView openFileExternallyWithRequest:inFrame:]): Use browserWindow. (-[BrowserWebView revealInFinderWithRequest:inFrame:]): Use browserWindow. (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): Use browserWindow. (-[BrowserWebView setShouldStartEmpty]): Use browserWindow.

ContextMenuHandler.m: (-[NSMutableArray addMenuItemWithTag:fromArray:]): Moved method from BrowserWebView to NSMutableArray to simplify parameters. (-[NSMutableArray addMenuItemWithTitle:action:]): Ditto. Don't set target any more since we do that in a postprocessing pass. (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): Don't store the element in a retained global. Instead attach it as the represented object to each menu item. Update for changed interface for adding menu items. Set targets and represented objects on all the menu items at the end. (-[BrowserWebView addLinkToBookmarks:]): Get element from represented object. Get window from browserWindow method instead of going the long way through the element. (-[BrowserWebView viewFrameSource:]): Get element from represented object. (-[BrowserWebView savePageAs:]): Get element from represented object. Use the _document instance variable instead of going the long way through the element. (-[BrowserWebView openWithITunes:]): Get element from represented object. (-[BrowserWebView openWithQuickTime:]): Get element from represented object. (-[BrowserWebView googleSearch:]): Get element from represented object. Get the window controller from the windowController method instead of going the long way through the element. (-[BrowserWebView goToAddress:]): Get element from represented object. Do the goToURL: on ourselves rather than going through the document (which will just forward the call to us anyway). (-[BrowserWebView openInNewTab:]): Get element from represented object.

12:56 AM Changeset in webkit [4342] by mjs

6 edits in trunk/WebKit

Tests:

Reviewed by Darin.

Updated for API changes.

PictureBrowser/PictureBrowserProtocol.m: (-[PictureBrowserProtocol startLoading]):

WebFoundation:

API CHANGE

Reviewed by Darin.

removed secred NSURLResponse mutators from NSURLProtocol.
added four-argument init method for NSURLResponse.
added NSURLResponseUnknownLength constant.
fixed a tiny bug in the HTTP protocol where unknown content length would sometimes get reported as 0.

CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didFailWithError:]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m:
CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponseInternal initWithURL:MIMEType:expectedContentLength:textEncodingName:]): (-[NSURLResponse initWithURL:MIMEType:expectedContentLength:textEncodingName:]): (-[NSURLResponse init]): (-[NSURLResponse initWithCoder:]): (-[NSURLResponse _setExpectedContentLength:]): (-[NSURLResponse _setMIMEType:]):
CacheLoader.subproj/NSURLResponsePrivate.h:
ChangeLog:
ProtocolHandlers.subproj/NSAboutURLProtocol.m: (-[NSAboutURLProtocol startLoading]):
ProtocolHandlers.subproj/NSFTPURLProtocol.m: (-[NSFTPURLProtocol sendResponseAvailableCallback]):
ProtocolHandlers.subproj/NSFileURLProtocol.m: (-[NSFileURLProtocol didLoadData:]):
ProtocolHandlers.subproj/NSHTTPURLProtocol.m: (-[NSHTTPURLProtocol HTTPResponse]):

WebKit:

Reviewed by Darin.

Updated for NSURLResponse API changes.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient loadWithRequest:]):

WebBrowser:

Reviewed by Darin.

Updated for NSURLResponse API changes.

BookmarksProtocol.m: (-[BookmarksProtocol startLoading]):

May 9, 2003:

11:25 PM Changeset in webkit [4341] by mjs

12 edits
3 deletes in trunk/WebKit

WebFoundation:

Reviewed by Darin.

removed subclasses of NSURLAuthenticationChallenge, and added a `sender' field to allow challenged to be handled generically.

AuthenticationManager.subproj/NSHTTPAuthenticator.h:
AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _tryChallenge:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator useCredential:forAuthenticationChallenge:]): (-[NSHTTPAuthenticator continueWithoutCredentialForAuthenticationChallenge:]):
AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengeInternal initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:sender:]): (-[NSURLAuthenticationChallenge initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:sender:]): (-[NSURLAuthenticationChallenge initWithAuthenticationChallenge:sender:]): (-[NSURLAuthenticationChallenge failureResponse]): (-[NSURLAuthenticationChallenge sender]):
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.h: Removed.
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: Removed.
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h: Removed.
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h: Removed.
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.m: Removed.
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallengeInternal.h: Removed.
AuthenticationManager.subproj/NSURLProtocolAuthenticationChallenge.h: Removed.
AuthenticationManager.subproj/NSURLProtocolAuthenticationChallenge.m: Removed.
CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLConnection cancelAuthenticationChallenge:]): (-[NSURLConnection _sendDidReceiveAuthenticationCallback]): (-[NSURLConnection _sendDidCancelAuthenticationCallback]): (-[NSURLConnection _performUseCredential]): (-[NSURLConnection _performContinueWithoutCredential]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didCancelAuthenticationChallenge:]): (-[NSURLConnectionInternal URLProtocol:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionInternal URLProtocol:didCancelAuthenticationChallenge:]):
CacheLoader.subproj/NSURLProtocol.h:
FileTransfer.subproj/NSURLDownload.h:
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload cancelAuthenticationChallenge:]): (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload connection:didReceiveResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]):
FileTransfer.subproj/NSURLUpload.h:
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.h:
ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m: (-[NSCFNetworkHTTPURLProtocol useCredential:forAuthenticationChallenge:]): (-[NSCFNetworkHTTPURLProtocol continueWithoutCredentialForAuthenticationChallenge:]): (-[NSCFNetworkHTTPURLProtocol cancelAuthenticationChallenge:]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

removed WebAuthenticationChallenge
adjusted everything for removal of NSURLAuthenticationChallenge subclasses.

Misc.subproj/WebDownload.m: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]):
Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
WebView.subproj/WebAuthenticationChallenge.h: Removed.
WebView.subproj/WebAuthenticationChallenge.m: Removed.
WebView.subproj/WebAuthenticationChallengeInternal.h: Removed.
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate useCredential:forAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate cancelAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate setIdentifier:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
WebView.subproj/WebResourceLoadDelegate.h:
Misc.subproj/WebKit.h: Remove headers that are gone.
WebKit.exp: Remove classes that are gone.
WebKit.pbproj/project.pbxproj: Remove files that are gone.

10:46 PM Changeset in webkit [4340] by darin

7 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3131026 -- half-width yen character (x5C) shows up as a backslash

To fix this, I had to reverse our previous decoding approach for the characters
that are different in Shift-JIS and ASCII. Before, we would decode them as
ASCII, and so they would be wrong in web pages, but right in URLs. Now, I decode
them as Shift-JIS, so they are right for web pages. This does not break URLs,
though, because back in February we added code to re-encode characters for URLs
to fix bug 3124596. But there is a TEC bug we have to work around to make this
work right for the tilde character.

kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Work around the TEC bug that prevents the tilde character from surviving the round trip through the decoding process by explicitly changing decoded tildes back to ASCII tildes. (KWQTextDecoder::convertUsingTEC): Do not set kUnicodeForceASCIIRangeMask.

kwq/KWQCString.h: Added replace call for use by new code. Some other small improvements.
kwq/KWQCString.mm: (QCString::contains): Make this faster by not doing the case-insensitive and case-sensitive cases both in the same loop. (QCString::append): Changed the += calls to this name, and made the += operator override call these. (QCString::replace): Added.

WebCore-tests.exp: Changed to export append calls.
WebCore-combined.exp: Regenerated.

9:45 PM Changeset in webkit [4339] by hyatt

3 edits in trunk/WebCore

Finally get tables cutting the right properties off and letting
the right ones through in quirks mode. Font-family *is* inherited
through into tables in all other browsers. We have been doing this
wrong the whole time. Also ensure that font-style and font-variant
are reset.

Reviewed by darin

khtml/css/quirks.css:

5:14 PM Changeset in webkit [4338] by hyatt

3 edits in trunk/WebCore

Always allow KONQ_TEXT as a valid value, and don't restrict its
use to lax CSS parsing. (We want our UA sheets to be parsed
strictly.)

Fixes bug 3224791, color inheritance not being properly cut off
in tables in quirks mode.

Reviewed by mjs and darin

khtml/css/cssparser.cpp: (CSSParser::parseValue):

5:13 PM Changeset in webkit [4337] by hyatt

2 edits in trunk/WebKit

Change the minfontsize to 1, i.e., to have no minimum. This
matches other browsers while still retaining the pref control
in WebKit.

Fixes www.gamespot.com. The bug is 3254489.

Reviewed by darin

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

4:04 PM Changeset in webkit [4336]

11 copies in tags/Safari-74~1

This commit was manufactured by cvs2svn to create tag 'Safari-74~1'.

4:04 PM Changeset in webkit [4335] by darin

8 edits in branches/Safari-74-branch

JavaScriptCore:

JavaScriptCore.pbproj/project.pbxproj: Bumped version to 74.

WebFoundation:

WebFoundation.pbproj/project.pbxproj: Bumped version to 74.

WebCore:

WebCore.pbproj/project.pbxproj: Bumped version to 74.

WebKit:

WebKit.pbproj/project.pbxproj: Bumped version to 74.

WebBrowser:

WebBrowser.pbproj/project.pbxproj: Bumped version to 74.

3:14 PM Changeset in webkit [4334] by mjs

9 edits in trunk/WebKit

WebFoundation:

Reviewed by John.

Rename connection:didFailLoadingWithError: to
connection:didFailWithError: to match NSURLDownload and
NSURLProtocol.

CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m:
CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _sendCallbacks]): (-[NSURLConnection _postDidFailCallback]): (-[NSURLConnection _sendDidFailCallback]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didFailWithError:]): (-[NSURLConnectionInternal prepareCallbacks]):
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload connection:didFailWithError:]): (-[NSURLConnectionDelegateProxy connection:didFailWithError:]):

WebKit:

Reviewed by John.

Rename connection:didFailLoadingWithError: to
connection:didFailWithError: to match NSURLDownload and
NSURLProtocol.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader connection:didFailWithError:]):
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didFailWithError:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didFailWithError:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didFailWithError:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient connection:didFailWithError:]):

1:56 PM Changeset in webkit [4333] by rjw

2 edits in trunk/WebKit

Apply the same check used to by-pass fast rendering
in the fix to 3146161 to measurement.

Reviewed by Ken.

Misc.subproj/WebKitNSStringExtras.m:

1:44 PM Changeset in webkit [4332] by hyatt

3 edits in trunk/WebCore

Fix for 3253695, XML pages with <style>@import...</style> don't
render. The XML tokenizer is getting text in small chunks, and
so it tries to load the sheet multiple times. This fix patches
the stylesheet code to properly decrement the loading sheet
count when you abort a still-loading @import.

Reviewed by darin

khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::childrenChanged):

10:17 AM Changeset in webkit [4331] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed 3191943 -- XML parsing error occurs when loading shift-JIS Japanese XML file

khtml/misc/decoder.h: Add a new type of encoding, EncodingFromXMLHeader.
khtml/misc/decoder.cpp: (findXMLEncoding): Added. (Decoder::decode): Call findXMLEncoding to extract the encoding from the XML header.

10:03 AM Changeset in webkit [4330] by kocienda

2 edits in trunk/WebKit

Reviewed by John

Removed unneeded import of WebFoundation/WebQueue.h.

WebCoreSupport.subproj/WebTextRendererFactory.h

8:46 AM Changeset in webkit [4329] by darin

5 edits in trunk/WebCore

Reviewed by John and Ken.

fixed 3253461 -- stylesheet-reading code does not support BOM
fixed 3253359 -- XML parser does not allow UTF-8 BOM

kwq/KWQTextCodec.mm: (KWQTextDecoder::KWQTextDecoder): Initialize the new _littleEndian, _atStart, and _numBufferedBytes fields, not the old _flags, _state, and _haveBufferedByte fields. (KWQTextDecoder::convertUTF16): Moved the BOM-based endianness detection out of here; now done in toUnicode. Switched to use the new multibyte buffer, even though we only need one byte of it. Remove any BOM characters encountered within the text. (KWQTextDecoder::convertUsingTEC): Remove any BOM characters encountered within the text. (KWQTextDecoder::toUnicode): Do all the BOM detection at this level, including the UTF-8 BOM as well as the UTF-16 BOM.

khtml/misc/decoder.cpp: (Decoder::decode): Don't bother stripping the UTF-8 BOM. The QTextCodec object handles that now.

kwq/KWQXmlSimpleReader.mm: (QXmlSimpleReader::parse): Pass in the data in 16-bit character form, and specify the encoding when creating the parser. Both expat and KHTML want to do the decoding, so this is really just a way to get expat to back off.

May 8, 2003:

10:41 PM Changeset in webkit [4328] by rjw

2 edits in trunk/WebKit

Fixed 3146161. Use the AppKit to render complex
text in the simple string drawing method.

Reviewed by John.

Misc.subproj/WebKitNSStringExtras.m:

10:32 PM Changeset in webkit [4327] by rjw

6 edits in trunk/WebKit

Make representations without intrinsic titles return nil for

(NSString *)title

Reviewed by John.

Plugins.subproj/WebNetscapePluginRepresentation.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebImageRepresentation.m:
WebView.subproj/WebTextRepresentation.m:

6:54 PM Changeset in webkit [4326] by rjw

7 edits in trunk/WebKit

Fixed 3252460. * Public API Change *
Added title method to WebDocumentRepresentation.

Fixed 3250352. Check that delegate implements method.

Reviewed by hyatt.

WebView.subproj/WebDataSource.m: (-[WebDataSource pageTitle]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _title]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]):
WebView.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation title]):
WebView.subproj/WebTextRepresentation.h:
WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation dealloc]): (-[WebTextRepresentation setDataSource:]): (-[WebTextRepresentation title]):

6:16 PM Changeset in webkit [4325] by hyatt

9 edits in trunk/WebCore

Fix the definition of isRoot() so that it doesn't depend on
the object being in the render tree yet (and to avoid any
virtual function calls as well).

Make sure that requiresLayer() returns true if the object is
the root. This way the layer isn't destroyed when you e.g.,
hit Cmd+ to increase font size.

This fixes bug 3252496.

Reviewed by rjw

khtml/rendering/render_block.cpp:
khtml/rendering/render_box.cpp: (RenderBox::setStyle):
khtml/rendering/render_object.cpp: (RenderObject::isRoot):
khtml/rendering/render_object.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::createRenderer):

6:13 PM Changeset in webkit [4324] by kocienda

2 edits in trunk/WebKit/Misc.subproj

2003-05-08 Ken Kocienda <kocienda@apple.com>

WebBrowser:

Reviewed by Maciej

A number of file and class name changes in WebFoundation, as done
by running this tops script.

replace "WebAboutProtocol" with "NSAboutURLProtocol"
replace "WebCFNetworkHTTPProtocol" with "NSCFNetworkHTTPURLProtocol"
replace "WebFileProtocol" with "NSFileURLProtocol"
replace "WebHTTPProtocol" with "NSHTTPURLProtocol"
replace "WebSimpleHTTPProtocol" with "NSSimpleHTTPURLProtocol"
replace "WebSSLProxyWrapperStream" with "NSSSLProxyWrapperStream"

There were also some changes I did by hand in DebugUtilities.m, to
bring up to date some flag names used to figure out what protocols are
registered.

Debug/DebugUtilities.m: (-[DebugUtilities supportedProtocolHandlersSubmenuItem]): (-[BrowserDocument setCertificatePolicy:]): (-[BrowserDocument validate_setCertificatePolicy:]): (initProtocolHandlers): (-[BrowserDocument unregisterAllProtocolHandlers]): (-[BrowserDocument reregisterAllProtocolHandlers]): (-[BrowserDocument toggleAboutURLProtocolHandler:]): (-[BrowserDocument validate_toggleAboutURLProtocolHandler:]): (-[BrowserDocument toggleFileURLProtocolHandler:]): (-[BrowserDocument validate_toggleFileURLProtocolHandler:]): (-[BrowserDocument toggleCFNetworkHTTPURLProtocolHandler:]): (-[BrowserDocument validate_toggleCFNetworkHTTPURLProtocolHandler:]): (-[BrowserDocument toggleSimpleHTTPURLProtocolHandler:]): (-[BrowserDocument validate_toggleSimpleHTTPURLProtocolHandler:]):

WebFoundation:

A number of file and class name changes in WebFoundation, as done
by running this tops script.

/* Cookies */
replace "WebCookieStorage" with "NSHTTPCookieDOStorage"
replace "WebCookieStorageServer" with "NSHTTPCookieServer"

/* CacheLoader */
replace "WebNetworkSettings" with "NSNetworkSettings"
replace "WebNetworkSettingsPrivate" "NSNetworkSettingsPrivate"
replace "_settingsPrivate" "_internal"
replace "WebSynchronousDelegate" with "NSSynchronousURLConnectionDelegate"

/* Database */
replace "WebLRUFileList" with "NSLRUFileList"

/* Protocols */
replace "WebAboutProtocol" with "NSAboutURLProtocol"
replace "WebCFNetworkHTTPProtocol" with "NSCFNetworkHTTPURLProtocol"
replace "WebFileProtocol" with "NSFileURLProtocol"
replace "WebHTTPProtocol" with "NSHTTPURLProtocol"
replace "WebSimpleHTTPProtocol" with "NSSimpleHTTPURLProtocol"
replace "WebSSLProxyWrapperStream" with "NSSSLProxyWrapperStream"

Also, the NSLRUFileList files have many C functions whose names
changed from Web to NS prefixes.

AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _proxyProtectionSpaceForURL:]):
AuthenticationManager.subproj/NSURLCredentialStorage.m:
CacheLoader.subproj/NSNetworkSettings.h:
CacheLoader.subproj/NSNetworkSettings.m: (-[NSNetworkSettings _updateProxySettings]): (proxySettingsChanged): (-[NSNetworkSettings _listenForProxySettingChanges]): (-[NSNetworkSettings _URLMatchesProxyExceptions:]): (-[NSNetworkSettings _init]): (-[NSNetworkSettings init]): (-[NSNetworkSettings dealloc]): (initSharedNetworkSettings): (+[NSNetworkSettings sharedNetworkSettings]): (-[NSNetworkSettings proxyPropertiesForURL:]): (-[NSNetworkSettings connectedToInternet:]):
CacheLoader.subproj/NSSynchronousURLConnectionDelegate.h:
CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m:
CacheLoader.subproj/NSURLCache.m: (-[NSURLCacheInternal dealloc]): (-[NSURLCache _diskCacheSync:]): (-[NSURLCache _diskCacheCreateLRUList:]): (-[NSURLCache _diskCacheGet:]): (-[NSURLCache _diskCacheTruncate:]): (-[NSURLCache _diskCacheExecuteWrite:]): (-[NSURLCache _diskCacheExecuteRemoval:]):
CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection _forceSingleLoad]): (_loadThrottler):
CacheLoader.subproj/NSURLProtocol.m: (NSURLProtocolInit):
CacheLoader.subproj/WebNetworkSettings.h: Removed.
CacheLoader.subproj/WebNetworkSettings.m: Removed.
CacheLoader.subproj/WebSynchronousDelegate.h: Removed.
CacheLoader.subproj/WebSynchronousDelegate.m: Removed.
CookieManager.subproj/NSHTTPCookieDOStorage.h:
CookieManager.subproj/NSHTTPCookieDOStorage.m: (-[NSHTTPCookieDOStorage _updateCookiesFromServer]): (-[NSHTTPCookieDOStorage _establishConnection]): (-[NSHTTPCookieDOStorage init]):
CookieManager.subproj/NSHTTPCookieServer.h:
CookieManager.subproj/NSHTTPCookieServer.m: (checkForCookieExpiration): (-[NSHTTPCookieServer init]):
CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _connectToCookieStorage]):
CookieManager.subproj/WebCookieStorage.h: Removed.
CookieManager.subproj/WebCookieStorage.m: Removed.
CookieManager.subproj/WebCookieStorageServer.h: Removed.
CookieManager.subproj/WebCookieStorageServer.m: Removed.
Database.subproj/NSLRUFileList.h:
Database.subproj/NSLRUFileList.m: (NSLRUFileListCreate): (NSLRUFileListRelease): (NSLRUFileListRebuildFileDataUsingRootDirectory): (NSLRUFileListRemoveFileWithPath): (NSLRUFileListTouchFileWithPath): (NSLRUFileListSetFileData): (NSLRUFileListGetPathOfOldestFile): (NSLRUFileListRemoveOldestFileFromList): (NSLRUFileListContainsItem): (NSLRUFileListGetFileSize): (NSLRUFileListCountItems): (NSLRUFileListGetTotalSize): (NSLRUFileListRemoveAllFilesFromList): (compareTimes): (NSLRUFileDataEqual): (NSLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease): (NSLRUFileDataBinaryHeapDumpApplierFunction): (NSLRUFileDataDictDumpApplierFunction): (NSLRUFileListDescription):
Database.subproj/WebFileDatabase.h:
Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]):
Database.subproj/WebLRUFileList.h: Removed.
Database.subproj/WebLRUFileList.m: Removed.
English.lproj/StringsNotToBeLocalized.txt:
ProtocolHandlers.subproj/NSAboutURLProtocol.h:
ProtocolHandlers.subproj/NSAboutURLProtocol.m:
ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.h:
ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m: (NSCFNetworkHTTPURLProtocolInit): (readStreamCallback): (+[NSCFNetworkHTTPURLProtocol _certificatePolicy]): (+[NSCFNetworkHTTPURLProtocol _setCertificatePolicy:]): (+[NSCFNetworkHTTPURLProtocol _supportsCertificatePolicy:]): (-[NSCFNetworkHTTPURLProtocol initWithRequest:cachedResponse:client:]): (-[NSCFNetworkHTTPURLProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
ProtocolHandlers.subproj/NSFTPURLProtocol.h:
ProtocolHandlers.subproj/NSFTPURLProtocol.m: (NSFTPURLProtocolInit): (readStreamCallback): (-[NSFTPURLProtocol initWithRequest:cachedResponse:client:]): (-[NSFTPURLProtocol startLoading]): (-[NSFTPURLProtocol determineErrorAndFail]):
ProtocolHandlers.subproj/NSFileURLProtocol.h:
ProtocolHandlers.subproj/NSFileURLProtocol.m:
ProtocolHandlers.subproj/NSHTTPURLProtocol.h:
ProtocolHandlers.subproj/NSHTTPURLProtocol.m: (-[NSHTTPURLProtocol startOriginLoad]): (-[NSHTTPURLProtocol stopLoading]): (-[NSHTTPURLProtocol buildHTTPRequest]): (-[NSHTTPURLProtocol determineErrorAndFail]): (-[NSHTTPURLProtocol didAddCredentials:toRequest:context:]): (-[NSHTTPURLProtocol cleanUpForRetry]):
ProtocolHandlers.subproj/NSSSLProxyWrapperStream.h:
ProtocolHandlers.subproj/NSSSLProxyWrapperStream.m: (wSocketStreamCallBack): (WebCFReadStreamOpenThroughSSLProxy): (WebCFReadStreamCancelOpenThroughSSLProxy):
ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.h:
ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m: (ensureRequestStringCapacity): (appendBytesToRequestString): (appendIntegerToRequestString): (appendNSStringToRequestString): (NSSimpleHTTPURLProtocolInit): (_socketWriteCallback): (_socketReadCallback): (_addCookieHeader): (_hostNameResolved): (+[NSSimpleHTTPURLProtocol canInitWithRequest:]): (-[NSSimpleHTTPURLProtocol initWithRequest:cachedResponse:client:]):
ProtocolHandlers.subproj/WebAboutProtocol.h: Removed.
ProtocolHandlers.subproj/WebAboutProtocol.m: Removed.
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h: Removed.
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: Removed.
ProtocolHandlers.subproj/WebFTPProtocol.h: Removed.
ProtocolHandlers.subproj/WebFTPProtocol.m: Removed.
ProtocolHandlers.subproj/WebFileProtocol.h: Removed.
ProtocolHandlers.subproj/WebFileProtocol.m: Removed.
ProtocolHandlers.subproj/WebHTTPProtocol.h: Removed.
ProtocolHandlers.subproj/WebHTTPProtocol.m: Removed.
ProtocolHandlers.subproj/WebSSLProxyWrapperStream.h: Removed.
ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m: Removed.
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.h: Removed.
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: Removed.
WebFoundation-base.exp:
WebFoundation.pbproj/project.pbxproj:

5:15 PM Changeset in webkit [4323] by hyatt

3 edits in trunk/WebCore

Background-position-x and y should be length|percentage. Number
is not a valid option. Need to remove this so that the quirk will
kick in that translates numbers to pixels. Fixes an issue on
diveintomark's list.

Reviewed by darin

khtml/css/cssparser.cpp: (CSSParser::parseValue):

5:04 PM Changeset in webkit [4322] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed part of the cause of 3251979 -- switching tabs hoses page layout

kwq/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): Only update views that are using this settings object. The old way would result in re-laying out all views every time you created a new one.

4:43 PM Changeset in webkit [4321]

3 copies
6 deletes in tags/WebKit-78~1

This commit was manufactured by cvs2svn to create tag 'WebKit-78~1'.

4:43 PM Changeset in webkit [4320] by darin

2 edits in branches/Safari-78~1-branch/WebKit

Rolled in change from main trunk.

2003-05-08 Darin Adler <Darin Adler>

WebKit.pbproj/project.pbxproj: Fixed paths for non-Panther builds.

4:33 PM Changeset in webkit [4319] by darin

2 edits in trunk/WebKit

WebKit.pbproj/project.pbxproj: Fixed paths for non-Panther builds.

3:51 PM Changeset in webkit [4318] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed regression caused by my last check-in; need to use the KHTMLView layout function

kwq/KWQWidget.mm: (QWidget::setFocus): Use KHTMLView's layout instead of RenderCanvas's.

fixed 3251913 -- when form field has focus, dragging across text elsewhere does not select it

khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection): Remove setFocusNode(0) call. Apparently not needed these days. I tested and everything works fine without it, and its side effect was the bug above. (DocumentImpl::setFocusNode): Remove clearSelection() call for similar reasons.

3:23 PM Changeset in webkit [4317] by darin

6 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3251985 -- REGRESSION: tabbing doesn't scroll text fields into view any more

kwq/KWQTextField.h: Add a _hasFocus field, which prevents us from focusing multiple times.
kwq/KWQTextField.mm: (+[KWQTextField initialize]): Set KWQTextFieldCell as the cell class. We need a cell subclass to detect when editing begins. (-[KWQTextField setPasswordMode:]): Don't pass a QLineEdit to the secure text field when creating it. It's no longer needed. (-[KWQTextField controlTextDidEndEditing:]): Call setHasFocus:NO, and do the actual work in there. (-[KWQTextField control:textShouldBeginEditing:]): Remove the work that was done in here. This is only called when you actually start typing, so it's too late. (-[KWQTextField becomeFirstResponder]): Keep the code to forward first responder to the password field, but get rid of the rest, because this code path does not cover all the ways to start editing. (-[KWQTextField currentEditorForEitherField]): Moved this method inside the KWQInternal category. (-[KWQTextField selectedRange]): Ditto. (-[KWQTextField setSelectedRange:]): Ditto. (-[KWQTextField setHasFocus:]): Added. This method does all the work we want to do when we get focus and when we relinquish focus, including scrolling to make the field visible. (-[KWQTextFieldCell editWithFrame:inView:editor:delegate:event:]): Call setHasFocus:YES on the KWQTextField. (-[KWQTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): Ditto. (+[KWQSecureTextField cellClass]): Use KWQSecureTextFieldCell as the cell class. We need a cell subclass to detect when editing begins and we can't use the normal technique because NSSecureTextField will raise an exception. (-[KWQSecureTextField nextKeyView]): Simplified to just call through to KWQTextField. (-[KWQSecureTextField previousKeyView]): Ditto. (-[KWQSecureTextField nextValidKeyView]): Ditto. (-[KWQSecureTextField previousValidKeyView]): Ditto. (-[KWQSecureTextField widget]): Ditto. (-[KWQSecureTextField fieldEditorDidMouseDown:]): Ditto. (-[KWQSecureTextFieldCell editWithFrame:inView:editor:delegate:event:]): Call setHasFocus:YES on the KWQTextField. (-[KWQSecureTextFieldCell selectWithFrame:inView:editor:delegate:start:length:]): Ditto.

kwq/KWQWidget.mm: (QWidget::setFocus): Do a layout before positioning the widget. The code dealt with calls after a layout and before a draw, before, but not calls before a layout.

2:59 PM Changeset in webkit [4316] by hyatt

3 edits in trunk/WebCore

Fix for a problem where positioned/floating children with
percentage width tables inside them don't expand to fill
the width of their containing block.

The way to solve this is to detect this
case and treat the block as though it has an infinite maxwidth.

Note that this is a quirk only, since doing this for real would
be crazy. We're basically just matching broken WinIE behavior.

Reviewed by kocienda

khtml/rendering/render_block.cpp:

2:03 PM Changeset in webkit [4315]

3 copies in tags/Safari-78-dev-release

This commit was manufactured by cvs2svn to create tag
'Safari-78-dev-release'.

2:03 PM Changeset in webkit [4314] by sullivan

7 edits in trunk/WebKit

Closed up all gaps in WebKit between "ASSERT" and "(" to
make Darin's day a little brighter.

Reviewed by Darin

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]):
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):
WebView.subproj/WebViewPrivate.m: (-[WebView _preferencesChangedNotification:]):

1:52 PM Changeset in webkit [4313] by sullivan

8 edits in trunk/WebKit

fixed 3252632 -- Registering a WebDocumentView too early breaks built-in image viewing

A startup-performance optimization was breaking the case
where clients registered WebDocumentView types before the
first WebFrameView had been created. The fix is to allow
registering WebDocumentView types without retrieving the
built-in image types.

Reviewed by Darin

WebView.subproj/WebFrameViewPrivate.h: remove _viewTypes; expose _viewTypesAllowImageTypeOmission. All callers have to specify the boolean now.

WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): assert that the list of image types isn't nil before inserting them; insert each image type only if not already present. (+[WebFrameView _viewClassForMIMEType:]): replace _viewTypes with _viewTypesAllowImageTypeOmission

Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]): replace _viewTypes with _viewTypesAllowImageTypeOmission

WebView.subproj/WebDataSourcePrivate.h: remove _repTypes; expose _repTypesAllowImageTypeOmission. All callers have to specify the boolean now.
WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _representationClassForMIMEType:]): replace _repTypes with _repTypesAllowImageTypeOmission

WebView.subproj/WebView.m: (+[WebView registerViewClass:representationClass:forMIMEType:]): replace _viewTypes with _viewTypesAllowImageTypeOmission, and replace _repTypes with _repTypesAllowImageTypeOmission

1:44 PM Changeset in webkit [4312] by sheridan

3 edits in trunk

Safari-79u stamp

12:22 PM Changeset in webkit [4311] by darin

3 edits in trunk/WebKit

Reviewed by Richard.

fixed 3242414 -- REGRESSION: PLT times reported 10% slower after emptying cache with B/F cache enabled
made it only compute the page cache size once

History.subproj/WebBackForwardList.m: (-[WebBackForwardList init]): Set initial page cache size to special value, COMPUTE_DEFAULT_PAGE_CACHE_SIZE. (-[WebBackForwardList setPageCacheSize:]): Remove code to set pageCacheSizeModified and call to _setUsesPageCache:, not needed any more. (-[WebBackForwardList pageCacheSize]): If cache size is COMPUTE_DEFAULT_PAGE_CACHE_SIZE, then compute it. The old code would compute the cache size each time this method was called until pageCacheSizeModified was set. (-[WebBackForwardList _usesPageCache]): Just check pageCacheSize for 0 to see if we use a page cache. No need for a separate boolean any more.

History.subproj/WebHistoryItemPrivate.h: Remove _setUsesPageCache (gone altogether) and _clearPageCache (now only used internally).

11:54 AM Changeset in webkit [4310]

3 copies in branches/Safari-78~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-78~1-branch'.

11:54 AM Changeset in webkit [4309]

3 copies in tags/Safari-78~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-78~1-anchor'.

11:54 AM Changeset in webkit [4308]

3 copies in tags/Safari-78

This commit was manufactured by cvs2svn to create tag 'Safari-78'.

11:54 AM Changeset in webkit [4307] by sheridan

8 edits in trunk

Safari-78 version stamp

7:57 AM Changeset in webkit [4306] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3174769 -- Safari doesn't ignore byte order mark at start of UTF-8 HTML document

khtml/misc/decoder.cpp: (Decoder::decode): Added handling of the UTF-8 BOM to the code that already handled the UTF-16 BOM.

May 7, 2003:

7:19 PM Changeset in webkit [4305] by hyatt

34 edits
3 adds
6 deletes in trunk/WebCore

The purpose of this patch is to unify XML and HTML documents' root
element handling. Instead of having a special RenderHTML object
for dealing with <html>, root element handling is now done in
base classes so that it works with XML documents as well.

The changes include:

Rename RenderRoot to RenderCanvas to more accurately reflect what this RenderObject represents in CSS2.
Rename root() to canvas()
Rename isHtml() to isRoot()
Rename isRoot() to isCanvas().
Eliminate RenderHTML and fold its functionality into base classes (RenderBlock and RenderBox).
isRoot() now means "are you the RenderObject for the root element". All isHtml() callers now say isRoot() instead.

Reviewed by gramps

ForwardingHeaders/rendering/render_canvas.h: Added.
ForwardingHeaders/rendering/render_html.h: Removed.
ForwardingHeaders/rendering/render_root.h: Removed.
WebCore.pbproj/project.pbxproj:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_window.cpp:
khtml/html/html_baseimpl.cpp: (HTMLHtmlElementImpl::id):
khtml/html/html_baseimpl.h:
khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::print): (KHTMLView::slotPaletteChanged): (KHTMLView::paint): (KHTMLView::timerEvent):
khtml/khtmlview.h:
khtml/rendering/render_applet.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_body.cpp:
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgroundExtended): (RenderBox::containingBlockWidth): (RenderBox::repaint): (RenderBox::calcHeight): (RenderBox::availableHeight): (RenderBox::calcAbsoluteVertical):
khtml/rendering/render_box.h:
khtml/rendering/render_canvas.cpp: Added. (RenderCanvas::RenderCanvas): (RenderCanvas::~RenderCanvas): (RenderCanvas::calcHeight): (RenderCanvas::calcWidth): (RenderCanvas::calcMinMaxWidth):
khtml/rendering/render_canvas.h: Added.
khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
khtml/rendering/render_flow.cpp:
khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): (RenderFrameSet::userResize):
khtml/rendering/render_html.cpp: Removed.
khtml/rendering/render_html.h: Removed.
khtml/rendering/render_image.cpp: (RenderImage::paintObject):
khtml/rendering/render_layer.cpp: (RenderLayer::enclosingPositionedAncestor): (RenderLayer::convertToLayerCoords): (RenderLayer::constructZTree):
khtml/rendering/render_layer.h:
khtml/rendering/render_line.cpp:
khtml/rendering/render_list.cpp: (RenderListMarker::paintObject):
khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::canvas): (RenderObject::container): (RenderObject::removeFromObjectLists): (RenderObject::detach): (RenderObject::nodeAtPoint): (RenderObject::scheduleRelayout):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp:
khtml/rendering/render_root.cpp: Removed.
khtml/rendering/render_root.h: Removed.
khtml/rendering/render_table.cpp: (RenderTable::layout):
khtml/rendering/render_text.cpp: (RenderText::paintObject):
khtml/rendering/table_layout.cpp: (shouldScaleColumns):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::attach): (DocumentImpl::setSelection): (DocumentImpl::clearSelection): (DocumentImpl::prepareMouseEvent):
khtml/xml/dom_elementimpl.cpp: (ElementImpl::createRenderer):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::rendererIsNeeded):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::adjustPageHeight): (KWQKHTMLPart::forceLayoutForPageWidth): (KWQKHTMLPart::selectionRect):
kwq/WebCoreBridge.mm: (-[WebCoreBridge _setupRootForPrinting:]):

6:01 PM Changeset in webkit [4304] by darin

14 edits in trunk

WebCore:

Reviewed by John.

fixed 3127927 -- web view should not use primary selection color when it's not first responder

kwq/WebCoreBridge.h: Added usesInactiveTextBackgroundColor getter and setter.
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Set the QPainter's usesInactiveTextBackgroundColor to match the value from the part. (-[WebCoreBridge selectionRect]): Fix nil-deref that happened in the no-KHTMLView case. (-[WebCoreBridge setUsesInactiveTextBackgroundColor:]): Added. (-[WebCoreBridge usesInactiveTextBackgroundColor]): Added.

kwq/KWQKHTMLPart.h: Added usesInactiveTextBackgroundColor, including getter and setter.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Initialize usesInactiveTextBackgroundColor.

kwq/KWQPainter.h: Added setUsesInactiveTextBackgroundColor and made selectedTextBackgroundColor a const member function, not a static one.
kwq/KWQPainter.mm: (QPainter::QPainter): Initialize _usesInactiveTextBackgroundColor to false. (QPainter::selectedTextBackgroundColor): Return secondarySelectedControlColor instead of selectedTextBackgroundColor if _usesInactiveTextBackgroundColor is true.

khtml/rendering/render_text.cpp: (TextRun::paintSelection): Call selectedTextBackgroundColor on the painter object; it's no longer a static member function.

khtml/rendering/render_root.cpp: (RenderRoot::selectionRect): Fix nil-deref that happened in the no-selection case.

WebKit:

Reviewed by John.

fixed 3127927 -- web view should not use primary selection color when it's not first responder

WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateTextBackgroundColor]): Added. Sets the usesInactiveTextBackgroundColor flag on the bridge, and does setNeedsDisplayInRect: of the selectionRect if the state changes. (-[WebHTMLView viewDidMoveToWindow]): Call updateTextBackgroundColor. (-[WebHTMLView windowDidBecomeKey:]): Call updateTextBackgroundColor. (-[WebHTMLView windowDidResignKey:]): Call updateTextBackgroundColor. (-[WebHTMLView becomeFirstResponder]): Call updateTextBackgroundColor. (-[WebHTMLView resignFirstResponder]): Call updateTextBackgroundColor.

fixed up WebHistoryItem initializers so there is a designated initializer

History.subproj/WebHistoryItem.m: (-[WebHistoryItem init]): Call initWithURLString:title:lastVisitedTimeInterval:, which is the designated initializer. (-[WebHistoryItem initWithURL:title:]): Ditto. (-[WebHistoryItem initWithURL:target:parent:title:]): Ditto.

other changes

History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Fixed assertion to not use _lastVisitedDate; we're trying to get rid of calls to that method.

5:13 PM Changeset in webkit [4303] by vicki

8 edits in trunk

JavaScriptCore:

Reviewed by darin.

modify the Mixed build style to build optimized with symbols

JavaScriptCore.pbproj/project.pbxproj: removed OPTIMIZATION_CFLAGS

WebFoundation:

Reviewed by darin.

modify the Mixed build style to build optimized with symbols

WebFoundation.pbproj/project.pbxproj: removed OPTIMIZATION_CFLAGS

WebCore:

Reviewed by darin.

modify the Mixed build style to build optimized with symbols

WebCore.pbproj/project.pbxproj: removed OPTIMIZATION_CFLAGS, use WebCore.exp

WebKit:

Reviewed by darin.

modify the Mixed build style to build optimized with symbols

WebKit.pbproj/project.pbxproj: removed OPTIMIZATION_CGLAGS

WebBrowser:

Reviewed by darin.

modify the Mixed build style to build optimized with symbols

WebBrowser.pbproj/project.pbxproj: removed OPTIMIZATION_CFLAGS

9:01 AM Changeset in webkit [4302] by darin

5 edits in trunk/WebCore

Reviewed by Ken.

fixed 3109258 -- Unicode above U+FFFF not handled correctly when expressed as numeric entities

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseEntity): Keep track of the entity in an unsigned integer that can hold 32 bits rather than a QChar. Convert to a pair of Unicode surrogate code points if necessary.

khtml/misc/stringit.h: Add a second pushed character, used for the case where we have a pair of surrogate characters for a single numeric entity.

khtml/html/htmltokenizer.h: Add missing DOM:: that was compiling only due to "using namespace DOM" in stringit.h. Replace EntityChar with EntityUnicodeValue.

May 6, 2003:

6:56 PM Changeset in webkit [4301]

21 copies
1 delete in tags/Safari-77~1

This commit was manufactured by cvs2svn to create tag 'Safari-77~1'.

6:56 PM Changeset in webkit [4300] by rjw

2 edits in branches/Safari-77~1-branch

Revert framework references in project.pbxproj.

6:11 PM Changeset in webkit [4299] by darin

12 edits in trunk/WebCore

Reviewed by Chris.

fixed 3211756 -- form field contents on the left instead of right on page in RtL language

khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Call setAlignment based on the style's direction. (RenderTextArea::updateFromElement): Ditto.
kwq/KWQLineEdit.h: Added setAlignment.
kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Added. Calls setAlignment on KWQTextField.
kwq/KWQTextArea.h: Added setAlignment.
kwq/KWQTextArea.mm: (-[KWQTextArea setAlignment:]): Added. Calls setAlignment on NSTextView.
kwq/KWQTextEdit.h: Added setAlignment.
kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Added. Calls setAlignment on KWQTextField.
kwq/KWQTextField.mm: (-[KWQTextField setAlignment:]): Added. Call setAlignment on secure text field too.

fixed 3250538 -- on pages labeled "US-ASCII", non-ASCII chars are not decoded as Latin-1 as in other browsers

kwq/KWQTextCodec.mm: (effectiveEncoding): Added. Maps ISO Latin-1 and US-ASCII to Windows Latin-1. (QTextCodec::fromUnicode): Use effectiveEncoding. (KWQTextDecoder::convertUsingTEC): Use effectiveEncoding.

other changes

kwq/KWQCharsets.mm: (buildDictionaries): Make the first encoding in the file win for purposes of deciding which name is used. I thought this was happening before, but actually the last one was winning. Do this by using CFDictionaryAddValue, which does nothing if there's already a dictionary entry, instead of CFDictionarySetValue, which replaces.

6:06 PM Changeset in webkit [4298] by rjw

8 edits in branches/Safari-77~1-branch/WebKit

Fixed build problems caused by mistaken additional merge.

5:43 PM Changeset in webkit [4297] by rjw

8 edits in branches/Safari-77~1-branch

Backed out install name and release directory change.
Frameworks will be private for one more release.

WebKit.pbproj/project.pbxproj:

5:31 PM Changeset in webkit [4296] by rjw

7 edits in branches/Safari-77~1-branch/WebKit

Merged changes from HEAD:

Fixed problem for HelpViewer. HV calls stopLoading in
a webView:resource:didReceiveResponse. This causes
the premature release of the connection delegate.

Reviewed by Ken.

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connectionDidFinishLoading:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingForPolicyChange]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connectionDidFinishLoading:]):

5:15 PM Changeset in webkit [4295] by rjw

8 edits in trunk/WebKit

Fixed problem for HelpViewer. HV calls stopLoading in
a webView:resource:didReceiveResponse. This causes
the premature release of the connection delegate.

Reviewed by Ken.

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connectionDidFinishLoading:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingForPolicyChange]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connectionDidFinishLoading:]):

3:26 PM Changeset in webkit [4294] by hyatt

11 edits in trunk/WebCore

Make negative z-index content paint above the background of
the stacking context element that encloses it. This fixes
gettyimages.com and hotwired.com.

Reviewed by kocienda

khtml/css/html4.css:
khtml/rendering/render_block.cpp:
khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::RenderZTreeNode::constructLayerList):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.h:
khtml/rendering/render_root.cpp:
khtml/rendering/render_table.cpp: (RenderTable::paint):
kwq/KWQRenderTreeDebug.cpp: (write):

2:31 PM Changeset in webkit [4293] by darin

1 edit
1 delete in trunk/WebKit

removed obsolete file that's still around for some reason

Downloads.subproj/WebDownload.m: Removed.

1:28 PM Changeset in webkit [4292] by darin

2 edits in trunk/WebKit

fixed crash on startup

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): Allocate WebHistoryItemPrivate.

11:26 AM Changeset in webkit [4291] by rjw

8 edits in branches/Safari-77~1-branch

Changed install names and release directory to
/System/Library/Frameworks.

11:11 AM Changeset in webkit [4290] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Richard

Refactored memory and disk cache. All the implementation
for the memory and disk caches are now concentrated in one
file, NSURLCache.m. This spells the end for the WebCache,
WebMemoryCache and WebDiskCache files. It also enabled
me to implement the API-approved design which calls upon
NSURLProtocol to make a determination about the cache
equivalence of cached objects.

NSURLRequest and friends are now codable.

WebLRUFileList gets a new function: WebLRUFileListContainsItem.

In WebNSFileManagerExtras, I fixed a gibberish method name:

_web_deleteBackgroundRemoveLeftoverFiles:

is now

_web_backgroundRemoveLeftoverFiles:

CacheLoader.subproj/NSURLCache.m: (-[NSURLCacheInternal dealloc]): (-[NSURLCacheNode initWithCachedResponse:request:key:]): (-[NSURLCacheNode isEqual:]): (-[NSURLCacheNode description]): (-[NSURLCacheNode dealloc]): (MemoryCacheRemoveNodeFromLRUList): (MemoryCacheAppendNodeToLRUList): (MemoryCacheTouchNode): (MemoryCacheTruncate): (MemoryCacheGet): (MemoryCacheSet): (MemoryCacheRemove): (MemoryCacheClear): (DiskCacheDefaultPath): (DiskCacheUniqueFilePathForKey): (DiskCacheCreateDirectory): (DiskCacheGet): (DiskCacheClear): (DiskCacheTruncate): (DiskCacheScheduleWrite): (DiskCacheExecuteWrite): (DiskCacheScheduleRemoval): (DiskCacheExecuteRemoval): (+[NSURLCache _diskCacheSyncLoop:]): (-[NSURLCache _setDiskCacheSyncTimer]): (-[NSURLCache _diskCacheSync:]): (-[NSURLCache _createDiskCacheLRUList:]): (NSURLCacheInit): (NSURLCacheCreateSharedInstance): (+[NSURLCache sharedURLCache]): (-[NSURLCache initWithMemoryCapacity:diskCapacity:diskPath:]): (-[NSURLCache cachedResponseForRequest:]): (-[NSURLCache storeCachedResponse:forRequest:]): (-[NSURLCache removeCachedResponseForRequest:]): (-[NSURLCache removeAllCachedResponses]): (-[NSURLCache memoryCapacity]): (-[NSURLCache diskCapacity]): (-[NSURLCache setMemoryCapacity:]): (-[NSURLCache setDiskCapacity:]): (-[NSURLCache currentMemoryUsage]): (-[NSURLCache currentDiskUsage]): (-[NSURLCache _cacheStatistics]):
CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithCoder:]): (-[NSURLRequest encodeWithCoder:]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest allHTTPHeaderFields]): (-[NSURLRequest valueForHTTPHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest allowsHTTPSCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSURLRequest HTTPShouldHandleCookies]): (-[NSMutableURLRequest _parametersForWriting]): (-[NSMutableURLRequest setHTTPMethod:]): (-[NSMutableURLRequest setAllHTTPHeaderFields:]): (-[NSMutableURLRequest setValue:forHTTPHeaderField:]): (-[NSMutableURLRequest addValue:forHTTPHeaderField:]): (-[NSMutableURLRequest setHTTPBody:]): (-[NSMutableURLRequest setAllowsHTTPSCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest setHTTPCookiePolicyBaseURL:]): (-[NSMutableURLRequest setHTTPExtraCookies:]): (-[NSMutableURLRequest setHTTPPageNotFoundCacheLifetime:]): (-[NSMutableURLRequest setHTTPShouldHandleCookies:]): (-[NSHTTPURLRequestParameters initWithCoder:]): (-[NSHTTPURLRequestParameters encodeWithCoder:]): (-[NSHTTPURLRequestParameters copyWithZone:]): (-[NSHTTPURLRequestParameters mutableCopyWithZone:]): (-[NSHTTPURLRequestParameters isEqual:]):
CacheLoader.subproj/WebCache.h: Removed.
CacheLoader.subproj/WebCache.m: Removed.
CacheLoader.subproj/WebCachePrivate.h: Removed.
CacheLoader.subproj/WebDiskCache.h: Removed.
CacheLoader.subproj/WebDiskCache.m: Removed.
CacheLoader.subproj/WebMemoryCache.h: Removed.
CacheLoader.subproj/WebMemoryCache.m: Removed.
Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]):
Database.subproj/WebLRUFileList.h:
Database.subproj/WebLRUFileList.m: (WebLRUFileListContainsItem):
Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_backgroundRemoveLeftoverFiles:]):
WebFoundation.pbproj/project.pbxproj:

10:50 AM Changeset in webkit [4289] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3245048 - "Block Pop-Up Windows" can easily be bypassed using javascript: URLs

Closed the loophole by tracking what client redirects were
triggered by user actions, and making sure the script interpreter
knows.

khtml/ecma/kjs_window.cpp: (Window::put): (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::clear): (KHTMLPart::scheduleRedirection): (KHTMLPart::slotRedirect): (KHTMLPart::urlSelected):
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]):

10:47 AM Changeset in webkit [4288]

21 copies in tags/Safari-73~5

This commit was manufactured by cvs2svn to create tag 'Safari-73~5'.

10:47 AM Changeset in webkit [4287] by darin

2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-05-06 Darin Adler <Darin Adler>

fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup

WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.

10:43 AM Changeset in webkit [4286] by darin

2 edits in branches/Safari-77~1-branch/WebKit

Rolled in change from main trunk.

2003-05-06 Darin Adler <Darin Adler>

fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup

WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.

10:42 AM Changeset in webkit [4285] by darin

2 edits in trunk/WebKit

fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup

WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.

9:20 AM Changeset in webkit [4284] by darin

4 edits in trunk/WebKit

Reviewed by Ken.

used ObjectAlloc to find large numbers of allocations on startup and get rid of some

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the init method that takes a URL string so we don't have to create and then destroy a URL for each item we decode.
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Use URLString instead of making and destroying a URL each time this is called. (-[WebHistoryPrivate removeItem:]): Ditto. (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): Check URLString for nil; no reason to construct and then destroy a URL just to check validity.

WebCoreSupport.subproj/WebTextRendererFactory.m: (FontCacheKeyCopy): Added. (FontCacheKeyFree): Added. (FontCacheKeyEqual): Added. (FontCacheKeyHash): Added. (FontCacheValueRetain): Added. (FontCacheValueRelease): Added. (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]): Use a C struct for the font cache key instead of using an Objective-C object. This saves us an object allocation and deallocation when doing a lookup. Also took advantage of the CFDictionary ability to store NULL and distinguish it from "not found" so we don't need a separate set for cache misses.

8:59 AM Changeset in webkit [4283] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

used ObjectAlloc to find large numbers of allocations on startup and get rid of some

kwq/KWQColor.mm: (QColor::getNSColor): Keep a cache of 32 colors instead of returning a new one each time. Also use special cases for black and white.

May 5, 2003:

10:28 PM Changeset in webkit [4282] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Don.

fixed 3239961 - www.phiffer.com doesn't work; uses "var top; top = n;"

kjs/nodes.cpp: (VarDeclNode::evaluate): Check if the property exists with getDirect() instead of hasProperty().

9:09 PM Changeset in webkit [4281] by mjs

4 edits in trunk/WebCore

Reviewed by Dave.

fixed 3241065 - popcap.com doesn't work in Safari, window.scrollBy fails to work in onLoad

Make sure to do a layout before accessing any window properties or
calling any window functions that require a layout to work
properly.

khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall): (Window::updateLayout):
khtml/ecma/kjs_window.h:

7:47 PM Changeset in webkit [4280] by mjs

4 edits in trunk/WebKit

Reviewed by Richard.

Fix build by separating mutating data protocol methods into
category on NSMutableURLRequest. Also, formatting fixes.

WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): (-[NSURLRequest _webDataRequestData]): (-[NSURLRequest _webDataRequestEncoding]): (-[NSURLRequest _webDataRequestMIMEType]): (-[NSURLRequest _webDataRequestBaseURL]): (-[NSURLRequest _webDataRequestExternalRequest]): (-[NSMutableURLRequest _webDataRequestSetData:]):
WebView.subproj/WebFrame.m:

4:26 PM Changeset in webkit [4279] by hyatt

4 edits in trunk/WebCore

Fix for 3247722. Make sure the grammar accepts properties with
no values as declarations (albeit bad ones).

Reviewed by darin

khtml/css/parser.cpp:
khtml/css/parser.y:

10:51 AM Changeset in webkit [4278] by hyatt

3 edits in trunk/WebCore

Fix for 3248587. Refine the crash fix for generated image
content so that we still set the image's intrinsic width
and height properly.

Reviewed by john

khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

10:31 AM Changeset in webkit [4277] by hyatt

8 edits in trunk/WebCore

When using the content property in CSS, you can string together
an intermixed list of strings and image URLs. The old code
only supported a single image URL, and if you tried to mix
text in with images, you ended up crashing.

The crash bug is 3248172. The fix is to maintain a list of
ContentData objects instead of just a single object and to
ensure that a whole list of generated content gets made (and
not just a single RenderObject).

Reviewed by john

khtml/css/cssstyleselector.cpp: (applyRule)
khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
khtml/rendering/render_image.cpp: (RenderImage::setStyle): (RenderImage::setContentObject): (RenderImage::updateFromElement):
khtml/rendering/render_image.h:
khtml/rendering/render_style.cpp: (RenderStyle::setContent): (ContentData::clearContent):
khtml/rendering/render_style.h:

10:22 AM Changeset in webkit [4276] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed replaceOccurrencesOfString crash reported in bug 3247249 (not what the bug is about)

kwq/KWQTextArea.mm: (-[KWQTextArea text]): Use the length of the replaced text.

May 4, 2003:

9:28 PM Changeset in webkit [4275] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed a storage leak

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Release the timer before setting to nil.

7:57 PM Changeset in webkit [4274] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed 3131534 -- "javascript:window.open()" leads to page not found error

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For open() calls, if the first parameter is not present, use "" instead of "undefined" as the URL.

fixed 3244766 -- window.open() doesn't position window correctly along the y axis

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fixed the code that flips the y coordinate to take the window height into account.

3:21 PM Changeset in webkit [4273] by hyatt

5 edits in trunk/WebKit

Add smallCaps boolean to the string measuring and drawing
methods. Not actually supported yet.

Reviewed by darin

Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
Misc.subproj/WebStringTruncator.m: (stringWidth):
WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:smallCaps:fontFamilies:]):

3:17 PM Changeset in webkit [4272] by hyatt

8 edits in trunk/WebCore

Add smallCaps boolean to the string drawing and measuring
routines. WebCore should be done after this patch, with
the rest of the work being done entirely in WebKit.

Reviewed by darin

khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::width):
kwq/KWQFontMetrics.h:
kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText):
kwq/WebCoreTextRenderer.h:

3:08 PM Changeset in webkit [4271] by darin

3 edits in trunk/WebKit

Reviewed by John.

added validation to "Interface Builder" methods on WebView

WebView.subproj/WebView.h: Add NSUserInterfaceValidations protocol so that subclassers know that they can call [super validateUserInterfaceItem:].
WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): Simplify. (-[WebView canMakeTextLarger]): Simplify. (-[WebView _isLoading]): Added. (-[WebView validateUserInterfaceItem:]): Added. Checks for the six actions we implement, and returns NO if they are not valid.

May 3, 2003:

11:33 AM Changeset in webkit [4270] by hyatt

30 edits in trunk/WebCore

Rename layouted to needsLayout. Add a layoutIfNeeded method
and start using it in places that do if (needsLayout()) layout();

Reviewed by kocienda

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::recalcStyle):
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): (HTMLImageElementImpl::height):
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::print): (KHTMLView::timerEvent):
khtml/rendering/bidi.cpp:
khtml/rendering/render_applet.cpp: (RenderApplet::layout): (RenderEmptyApplet::layout):
khtml/rendering/render_block.cpp:
khtml/rendering/render_box.cpp: (RenderBox::close):
khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): (RenderContainer::layout):
khtml/rendering/render_flow.h:
khtml/rendering/render_form.cpp: (RenderFormElement::layout): (RenderSubmitButton::updateFromElement): (RenderSelect::updateFromElement): (RenderSelect::calcMinMaxWidth): (RenderSelect::layout):
khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): (RenderFrameSet::positionFrames): (RenderFrameSet::userResize): (RenderFrameSet::canResize): (RenderPart::setWidget): (RenderPartObject::updateWidget): (RenderPartObject::layout):
khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitInlines): (RenderInline::splitFlow):
khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
khtml/rendering/render_list.cpp: (RenderListItem::layout): (RenderListMarker::setStyle): (RenderListMarker::layout): (RenderListMarker::setPixmap):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::information): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::invalidateLayout): (RenderObject::detach):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::setQWidget): (RenderWidget::layout):
khtml/rendering/render_root.cpp:
khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTable::layout): (RenderTable::paint): (RenderTable::close): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::recalcSections): (RenderTableSection::addChild): (RenderTableSection::setCellWidths): (RenderTableSection::layoutRows): (RenderTableSection::recalcCells): (RenderTableRow::addChild): (RenderTableRow::layout): (RenderTableCell::paint):
khtml/rendering/render_text.cpp: (RenderText::setText):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::updateStyleSelector):
khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth):
kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]):

May 2, 2003:

5:42 PM Changeset in webkit [4269] by mjs

56 edits in trunk

WebFoundation:

Reviewed by Richard.

reformatted method prototypes to match AppKit style

AuthenticationManager.subproj/NSHTTPAuthenticator.h:
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLProtectionSpace.h:
AuthenticationManager.subproj/WebCredentialStorage.h:
AuthenticationManager.subproj/WebKeychainCredential.h:
CacheLoader.subproj/NSURLCache.h:
CacheLoader.subproj/NSURLCachePrivate.h:
CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnectionPrivate.h:
CacheLoader.subproj/NSURLConnectionQueue.h:
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocolClient.h:
CacheLoader.subproj/NSURLProtocolPrivate.h:
CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequestPrivate.h:
CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/NSURLResponsePrivate.h:
CacheLoader.subproj/WebCache.h:
CacheLoader.subproj/WebCachePrivate.h:
CacheLoader.subproj/WebDiskCache.h:
CacheLoader.subproj/WebNetworkSettings.h:
CacheLoader.subproj/WebSynchronousDelegate.h:
CookieManager.subproj/NSHTTPCookiePrivate.h:
CookieManager.subproj/NSHTTPCookieStorage.h:
CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
CookieManager.subproj/WebCookieStorage.h:
CookieManager.subproj/WebCookieStorageServer.h:
Database.subproj/WebDatabase.h:
Database.subproj/WebFileDatabase.h:
Misc.subproj/WebBinaryHeap.h:
Misc.subproj/WebFileTypeMappings.h:
Misc.subproj/WebHostNameAddressInfo.h:
Misc.subproj/WebKeyValuePair.h:
Misc.subproj/WebMonitor.h:
Misc.subproj/WebMultipartForm.h:
Misc.subproj/WebNSArrayExtras.h:
Misc.subproj/WebNSCalendarDateExtras.h:
Misc.subproj/WebNSDataExtras.h:
Misc.subproj/WebNSDictionaryExtras.h:
Misc.subproj/WebNSErrorExtras.h:
Misc.subproj/WebNSObjectExtras.h:
Misc.subproj/WebNSStringExtras.h:
Misc.subproj/WebNSThreadExtras.h:
Misc.subproj/WebNSValueExtensions.h:
Misc.subproj/WebOrderable.h:
Misc.subproj/WebQueue.h:
Misc.subproj/WebReadWriteLock.h:
Misc.subproj/WebRecursiveReadWriteLock.h:
Misc.subproj/WebSpinLock.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
ProtocolHandlers.subproj/WebFTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.h:

WebCore:

Reviewed by Richard.

reformatted method prototypes to match AppKit style

kwq/WebCoreBridge.h:
kwq/WebCoreDOMPrivate.h:
kwq/WebCoreHistory.h:
kwq/WebCoreResourceLoader.h:
kwq/WebCoreTextRenderer.h:
kwq/WebDOMDocument.h:
kwq/WebDOMElement.h:
kwq/WebDOMNode.h:

WebKit:

Reviewed by Richard.

reformatted method prototypes to match AppKit style
remove "Public header file" from headers that are not public
fix header doc @method names to match actual method names

Carbon.subproj/CarbonWindowAdapter.h:
Carbon.subproj/HIViewAdapter.h:
DOM.subproj/WebDOMDocument.h:
DOM.subproj/WebDOMNode.h:
History.subproj/WebBackForwardList.h:
History.subproj/WebHistoryItemPrivate.h:
History.subproj/WebHistoryPrivate.h:
History.subproj/WebURLsWithTitles.h:
Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconLoader.h:
Misc.subproj/WebKitNSStringExtras.h:
Misc.subproj/WebUnicode.h:
Panels.subproj/WebPanelAuthenticationHandler.h:
Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebNetscapePluginStream.h:
Plugins.subproj/WebNullPluginView.h:
Plugins.subproj/WebPluginViewFactory.h:
WebCoreSupport.subproj/WebGlyphBuffer.h:
WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRendererFactory.h:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebControllerSets.h:
WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDebugDOMNode.h:
WebView.subproj/WebDocument.h:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFrameView.h:
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLView.h:
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebPolicyDelegatePrivate.h:
WebView.subproj/WebPreferencesPrivate.h:
WebView.subproj/WebRenderNode.h:
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebUIDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebViewPrivate.h:

4:10 PM Changeset in webkit [4268]

8 copies
1 delete in tags/WebKit-SDK-Beta-1

This commit was manufactured by cvs2svn to create tag
'WebKit-SDK-Beta-1'.

4:10 PM Changeset in webkit [4267] by rjw

3 edits in branches/Safari-77~1-branch

Build hackery for WebKit beta SDK. Installs framework in /System/Library/Frameworks.

1:09 PM Changeset in webkit [4266] by mjs

11 edits in trunk

WebCore:

Reviewed by Darin.

fixed 2936175 - MALLORY: please implement onResize

khtml/khtmlview.cpp: (KHTMLView::resizeEvent): Put most of this in #if !APPLE_CHANGES, since we already do the relayout and such on resize elswhere.
kwq/KWQEvent.h: Add a minimal QResizeEvent.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Send it to the view.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge sendResizeEvent]): Send it to the part.

WebKit:

Reviewed by Darin.

fixed 2936175 - MALLORY: please implement onResize

WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): If we just resized and we're not printing, make sure to send a resize event after the layout.

12:21 PM Changeset in webkit [4265] by hyatt

3 edits in trunk/WebCore

Fix for 3184113, bottom margins didn't collapse with their children
like they were supposed to. The problem is fixed by separately
caching whether or not the top and bottom margins can collapse
with their kids instead of having one global canCollapse variable.

Reviewed by kocienda

khtml/rendering/render_block.cpp:

11:13 AM Changeset in webkit [4264] by darin

10 edits in trunk

WebCore:

Reviewed by John.

fixed 3236383 -- http://www.xy.com/ exception, crash loading main page

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Change to use closeWindowSoon, so that the delay is on the WebKit side so it can be tied to the WebView as a whole, not a particular bridge.

kwq/WebCoreBridge.h: Replaced closeWindow with closeWindowSoon.

rolled in a couple of harmless and eventually-possibly-useful changes inspired by changes OmniGroup made in their copy of WebCore

kwq/KWQListBox.mm: Make KWQTableView a KWQWidgetHolder. (-[KWQTableView widget]): Return the widget.
kwq/KWQScrollView.mm: (QScrollView::ensureVisible): First cut at implementing these.

WebKit:

Reviewed by John.

fixed 3236383 -- http://www.xy.com/ exception, crash loading main page

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Replaces closeWindow. Schedule a closeWindow operation in the WebView. Important to not have the call's execution depend on whether this WebBridge or WebFrame is still around after the delay.

WebView.subproj/WebViewPrivate.h: Added _closeWindow.
WebView.subproj/WebViewPrivate.m: (-[WebView _closeWindow]): Make a webViewClose: call on the UI delegate.

10:39 AM Changeset in webkit [4263] by darin

38 edits in trunk/WebKit

WebKit:

Reviewed by John.

first step in fixing 3236383 -- http://www.xy.com/ exception, crash loading main page

Changed WebFrame to explicitly detach from the bridge so we don't have a stale pointer;
also cleaned up WebBridge initialization.

WebCoreSupport.subproj/WebBridge.h: Added initWithWebFrame: and close methods, removed setWebFrame: method.
WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webFrameView:webView:]): Use the new initWithWebFrame:.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Call close on the bridge.

fixed many places that call a WebView a "controller"

Misc.subproj/WebKitStatistics.h:
Misc.subproj/WebKitStatistics.m:
Misc.subproj/WebKitStatisticsPrivate.h:
Misc.subproj/WebNSViewExtras.m:
Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m:
Plugins.subproj/WebNetscapePluginStream.m:
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebSubresourceClient.m:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m:
WebView.subproj/WebControllerSets.h:
WebView.subproj/WebControllerSets.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFrameView.m:
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m:
WebView.subproj/WebImageView.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebTextView.m:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John.

fixed many places that call a WebView a "controller", including changing the name BrowserWebController to BrowserWebView

BrowserDocument.h:
BrowserDocument.m:
BrowserDocumentController.h:
BrowserDocumentController.m:
BrowserTabViewItem.m:
BrowserWebBookmarkExtras.m:
BrowserWebController.h:
BrowserWebController.m:
BrowserWebFrameExtras.h:
BrowserWindowController.h:
BrowserWindowController.m:
ContextMenuHandler.m:
Debug/DOMTree.h:
Debug/DOMTree.m:
Debug/DebugUtilities.m:
Debug/RenderTree.h:
Debug/RenderTree.m:
Debug/ViewTree.h:
Debug/ViewTree.m:
English.lproj/StringsNotToBeLocalized.txt:
FindPanelController.m:
FormCompletionController.h:
FormCompletionController.m:
LoadProgressMonitor.h:
LoadProgressMonitor.m:
LocationChangeError.m:
LocationChangeHandler.h:
LocationChangeHandler.m:
Test/PageLoadTestRunner.m:

10:22 AM Changeset in webkit [4262] by hyatt

3 edits in trunk/WebCore

Make sure that recalcSections always clears out the needSectionRecalc
boolean, even in the case where it finds column elements.

Fixes the assert outlined in bug 3237651.

Reviewed by john

khtml/rendering/render_table.cpp: (RenderTable::recalcSections):

8:52 AM Changeset in webkit [4261] by hyatt

3 edits in trunk/WebCore

Fix for 3226030, percentage height tables inside table cells
don't grow to fill the space inside the cell. There was
a missing edge case here for the case where the table was
nested inside a table cell.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTable::layout):

May 1, 2003:

5:53 PM Changeset in webkit [4260] by hyatt

3 edits in trunk/WebCore

Add a cycle check when importing stylesheets to prevent
infinite loops.

Reviewed by john

khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):

5:12 PM Changeset in webkit [4259] by hyatt

4 edits in trunk/WebCore

Table rows don't know their precise dimensions, so repainting
them fails. For now, just make an invalidation of a table
row due to CSS changes invalidate the whole table.

This is what the old Safari table code used to do prior to the
new table code landing.

Fixes bug #3205092.

Reviewed by darin/john

khtml/rendering/render_table.cpp: (RenderTableRow::repaint):
khtml/rendering/render_table.h:

4:30 PM Changeset in webkit [4258] by hyatt

3 edits in trunk/WebCore

Fix for 3232637, don't let generated parentless image content
try to do width/height/layout calculations. It will do this
all anyway, when it finally gets inserted into the rendering
tree.

Reviewed by john

khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

4:01 PM Changeset in webkit [4257] by hyatt

3 edits in trunk/WebCore

Fix for 3239404, a crash caused because a block-level :after
element was being inserted as generated content inside an
inline element.

The fix is to mutate the display of the generated content to
be inline when the parent of the generated content is also
inline.

Section 12.1 of the CSS2 spec (at the very end of the spec)
covers this special case. Once we do the mutation it becomes
impossible for generated content to cause a splitFlow, and so
the crash is plugged.

Reviewed by john

khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):

3:31 PM Changeset in webkit [4256] by sullivan

3 edits in trunk/WebKit

fixed 3246045 -- History items without a valid date in History.plist show up with unexpected dates in UI

Reviewed by Darin.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): don't set lastVisitedTimeInterval to [nil doubleValue], since this is random

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:13 PM Changeset in webkit [4255] by rjw

2 edits in branches/Safari-77~1-branch/WebKit

Merged from HEAD:

Added missing header and alphabetized.

Reviewed by Ken.

Misc.subproj/WebKit.h:

3:11 PM Changeset in webkit [4254] by rjw

2 edits in trunk/WebKit

Added missing header and alphabetized.

Reviewed by Ken.

Misc.subproj/WebKit.h:

3:10 PM Changeset in webkit [4253] by hyatt

9 edits in trunk/WebCore

Replace effectiveWidth and effectiveHeight with a
parameterized overflowWidth/Height, since this is much better
terminology.

Also fix event handling so that it no longer assumes (incorrectly)
that being inside the overflow rect of an object means you are
inside the object. Now there are two separate checks, with the
overflow check being used only to figure out if you should check
inside your kids.

Reviewed by darin

khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::repaint):
khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_table.h:

2:44 PM Changeset in webkit [4252] by cblu

6 edits in trunk/WebKit

WebKit:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame setController:]): fixed comment
WebView.subproj/WebView.m: (-[WebView dealloc]): call [self _close]
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): let the WebView class clear the frames (-[WebView _close]): remove self from controller set and detach and release frame

WebBrowser:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

BrowserWebController.m: (-[BrowserWebController close]): call [self _close]

2:31 PM Changeset in webkit [4251] by sheridan

3 edits in trunk

Safari-78u versionstamp

1:39 PM Changeset in webkit [4250]

3 copies
1 delete in branches/Safari-77~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-77~1-branch'.

1:39 PM Changeset in webkit [4249]

3 copies
1 delete in tags/Safari-77~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-77~1-anchor'.

1:39 PM Changeset in webkit [4248]

3 copies
1 delete in tags/Safari-77

This commit was manufactured by cvs2svn to create tag 'Safari-77'.

1:39 PM Changeset in webkit [4247] by sheridan

8 edits in trunk

Safari-77 stamp

12:19 PM Changeset in webkit [4246] by sullivan

2 edits in trunk/WebKit

fixed 3245793 -- Launching Safari-75 after tip of tree erases all history

Reviewed by Chris, Don

History.subproj/WebHistoryItem.m: keep using "lastVisitedDate" as the dictionary key, since old Safaris otherwise can't read the History file. (-[WebHistoryItem dictionaryRepresentation]): keep storing the time interval as a string, since old Safaris otherwise can't read the History file (-[WebHistoryItem initFromDictionaryRepresentation:]): read the stored date as a string and convert to a double, as we did before.

11:24 AM Changeset in webkit [4245] by hyatt

3 edits in trunk/WebCore

Fix for 3244157, giantrobot.com misrenders with a lot of
vertical space. Overflow heights were being miscomputed for
overflow:auto blocks.

Reviewed by gramps

khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:

9:44 AM Changeset in webkit [4244] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed 3169117 -- dragging while using a scroll wheel affects scroll movement

WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): Just return nil when called with NSScrollWheelMask to work around the bug where any kind of event can be returned when this mask is passed. This will prevent scroll wheel events from being coalesced, but it's better than extracting events of all different types. Mouse moved events are particularly bad because they have deltaX/Y/Z and the scroll wheel code in NSScrollView treats them as if they were scroll wheel events.

9:35 AM Changeset in webkit [4243]

1 copy
61 deletes in tags/WebFoundation-77~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-77~1'.

9:35 AM Changeset in webkit [4242] by kocienda

4 edits in trunk/WebKit/Misc.subproj

Reviewed by Gramps

Updated copyright notices on every header and
implementation file in the framework.

9:33 AM Changeset in webkit [4241] by kocienda

2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.
Note that there are some discrepancies in the
test results, but they seem to be the result
of changes in the way we handle cookie paths,
an aspect of cookies I did not change at all
with this patch. The difference must have
crept in some time ago.

CookieManager/wkcookie-test.chk:
CookieManager/wkcookiemanager-test.chk:
CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Updated to provide and use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

Added back compare: method in NSHTTPCookie. Our tests use it.

CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie compare:]):
CookieManager.subproj/NSHTTPCookieStorage.h:
CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage _cookiesForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (+[NSHTTPCookieStorage sharedHTTPCookieStorage]): (-[NSHTTPCookieStorage cookiesForURL:]): (-[NSHTTPCookieStorage setCookies:forURL:mainDocumentURL:]): (-[NSHTTPCookieStorage cookieAcceptPolicy]): (-[NSHTTPCookieStorage setCookieAcceptPolicy:]):
CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):

WebKit:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy

AppController.m: (-[AppController deleteAllCookies]):
Preferences.subproj/AcceptedCookies.m: (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

12:06 AM Changeset in webkit [4240] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Apr 30, 2003:

8:52 PM Changeset in webkit [4239] by kocienda

8 edits in trunk/WebKit

Tests:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

PictureBrowser/PictureBrowserProtocol.m: (-[PictureBrowserProtocol startLoading]):

WebFoundation:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _beginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]):
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]):
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _writeDataForkData:resourceForkData:]): (-[NSURLDownload _errorWithCode:]): (WriteCompletionCallback): (CloseCompletionCallback):
Misc.subproj/WebFoundation.h:
Misc.subproj/WebNSErrorExtras.h:
Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoading]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol cachedResponseRevalidated]): (-[WebHTTPProtocol determineTransferEncoding]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _continueLoadingWithAddressInfo]): (-[WebSimpleHTTPProtocol hostNameResolved:]): (-[WebSimpleHTTPProtocol _processRawData]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
WebFoundation-base.exp:
WebFoundation.pbproj/project.pbxproj:
Misc.subproj/WebNSErrorConstants.h: Removed

WebKit:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]):
WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]):

WebBrowser:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

BrowserNSErrorExtras.m: (-[NSError isCancelledError]):
DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler displayLocationChangeError:forDataSource:]):
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
ResourceProgressEntry.m: (-[ResourceProgressEntry stage]):
WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):

8:16 PM Changeset in webkit [4238] by kocienda

6 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard

Add API to NSURLProtocol so that protocol implementors
can set the instance variables defined on the base NSURLRequest
class. Also modified the existing setters on NSURLRequest
by giving them leading underscores, thus marking them
more clearly as SPI.

CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didLoadData:]): (-[NSURLConnection _didFinishReturnCachedResponse:]): (-[NSURLConnection _didFinishLoading]): (-[NSURLConnection _didFailWithError:]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol setURL:inResponse:]): (-[NSURLProtocol setExpectedContentLength:inResponse:]): (-[NSURLProtocol setMIMEType:inResponse:]): (-[NSURLProtocol setTextEncodingName:inResponse:]):
CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse _setURL:]): (-[NSURLResponse _setExpectedContentLength:]): (-[NSURLResponse _setMIMEType:]): (-[NSURLResponse _setTextEncodingName:]):
CacheLoader.subproj/NSURLResponsePrivate.h:
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoading]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol HTTPResponse]):

WebKit:

Reviewed by Richard

Use NSURLResponse new SPI methods to set instance variables.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient loadWithRequest:]):

8:04 PM Changeset in webkit [4237] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _protectionSpaceForURL:realm:]): (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _proxyProtectionSpaceForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]):
AuthenticationManager.subproj/NSURLProtectionSpace.h:
AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpaceInternal dealloc]): (-[NSURLProtectionSpace _internalInit]): (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]): (-[NSURLProtectionSpace initWithProxyHost:port:type:realm:authenticationMethod:]): (-[NSURLProtectionSpace dealloc]): (-[NSURLProtectionSpace realm]): (-[NSURLProtectionSpace receivesCredentialSecurely]): (-[NSURLProtectionSpace isProxy]): (-[NSURLProtectionSpace host]): (-[NSURLProtectionSpace port]): (-[NSURLProtectionSpace proxyType]): (-[NSURLProtectionSpace hash]): (-[NSURLProtectionSpace isEqual:]): (-[NSURLProtectionSpace authenticationMethod]): (-[NSURLProtectionSpace protocol]):
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _secProtocolForProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage credentialsForProtectionSpace:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage defaultCredentialForProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):

WebKit:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):

WebBrowser:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

FormCompletionController.m: (protectionSpaceFromFrame):
Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor addressStringForCredential:]): (-[PasswordsEditor resetCredentials]):

6:56 PM Changeset in webkit [4236] by rjw

2 edits in trunk/WebKit

Copy MIME type when copying WebDataProtocol's parameters.

Reviewed by Ken.

WebView.subproj/WebDataProtocol.m: (-[WebDataRequestParameters copyWithZone:]):

6:30 PM Changeset in webkit [4235] by rjw

3 edits in trunk/WebKit

Documentation fixes.
Added "ADVISORY NOTE" about possible API change after beta SDK.

History.subproj/WebHistory.h:
WebView.subproj/WebUIDelegate.h:

5:59 PM Changeset in webkit [4234] by kocienda

11 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

CacheLoader.subproj/NSURLRequest.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest allHTTPHeaderFields]): (-[NSURLRequest valueForHTTPHeaderField:]): (-[NSURLRequest allowsHTTPSCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSMutableURLRequest setHTTPMethod:]): (-[NSMutableURLRequest setAllHTTPHeaderFields:]): (-[NSMutableURLRequest setValue:forHTTPHeaderField:]): (-[NSMutableURLRequest addValue:forHTTPHeaderField:]): (-[NSMutableURLRequest setHTTPBody:]): (-[NSMutableURLRequest setAllowsHTTPSCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest setHTTPContentType:]): (-[NSMutableURLRequest setHTTPCookiePolicyBaseURL:]): (-[NSMutableURLRequest setHTTPExtraCookies:]): (-[NSMutableURLRequest setHTTPPageNotFoundCacheLifetime:]): (-[NSMutableURLRequest setHTTPReferrer:]): (-[NSMutableURLRequest setHTTPUserAgent:]):
CacheLoader.subproj/NSURLRequestPrivate.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol _cachedResponsePassesValidityChecks]): (-[WebHTTPProtocol _shouldAttemptOriginLoad]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]):

WebKit:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]):
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):

WebBrowser:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):

5:44 PM Changeset in webkit [4233] by hyatt

4 edits in trunk/WebCore

Fix for 3210725, invalid n/a selector treated as valid. This
fix also makes the CSS1 test on the test suite for forward-compatible
parsing completely pass (yay!), which was an issue on
diveintomark's list.

Reviewed by gramps

khtml/css/parser.cpp:
khtml/css/parser.y:

5:40 PM Changeset in webkit [4232] by mjs

5 edits in trunk/WebKit

Reviewed by Ken.

Minor header tweaks.

Misc.subproj/WebDownload.h: Fix copyright notice.
Panels.subproj/WebAuthenticationPanel.h: Added 2003 to copyright.
WebView.subproj/WebAuthenticationChallenge.h: Fix copyright notice, add docs.
WebView.subproj/WebAuthenticationChallengeInternal.h: Fix copyright notice.

5:27 PM Changeset in webkit [4231] by mjs

3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Cut over to using the approved API mechanism for sending
challenges between the protocol and protocol
client. NSURLConnection now does the corss-thread dispatch and
NSURLAuthenticationDispatcher is obsoleted.

AuthenticationManager.subproj/NSHTTPAuthenticator.h:
AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithProtocol:httpRequest:challenge:callback:context:]): (-[NSURLAuthenticationChallengeState dealloc]): (-[NSHTTPAuthenticator _tryChallenge:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:protocol:withCallback:context:]): (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): (-[NSHTTPAuthenticator addCredentialsToInitialHTTPRequest:protocol:]): (-[NSHTTPAuthenticator checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[NSHTTPAuthenticator useCredential:forAuthenticationChallenge:]): (-[NSHTTPAuthenticator continueWithoutCredentialForAuthenticationChallenge:]):
AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengeInternal initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallengeInternal dealloc]): (-[NSURLAuthenticationChallenge initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallenge initWithAuthenticationChallenge:]): (-[NSURLAuthenticationChallenge dealloc]): (-[NSURLAuthenticationChallenge protectionSpace]): (-[NSURLAuthenticationChallenge proposedCredential]): (-[NSURLAuthenticationChallenge previousFailureCount]): (-[NSURLAuthenticationChallenge error]): (-[NSURLAuthenticationChallenge failureResponse]):
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:]):
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
AuthenticationManager.subproj/NSURLCredentialStorage.h:
AuthenticationManager.subproj/NSURLCredentialStorage.m:
AuthenticationManager.subproj/WebAuthenticationHandler.h: Removed.
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h: Removed.
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Removed.
AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h: Removed.
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLConnection _sendCallbacks]): (-[NSURLConnection _sendDidReceiveAuthenticationCallback]): (-[NSURLConnection _sendDidCancelAuthenticationCallback]): (-[NSURLConnection _performCancel]): (-[NSURLConnection _performUseCredential]): (-[NSURLConnection _performContinueWithoutCredential]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didCancelAuthenticationChallenge:]): (+[NSURLConnection _resourceLoadLoop:]): (NSURLConnectionInit): (_authenticationDone): (-[NSURLConnectionInternal prepareCallbacks]): (-[NSURLConnectionInternal URLProtocol:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionInternal URLProtocol:didCancelAuthenticationChallenge:]):
CacheLoader.subproj/NSURLProtocol.h:
ChangeLog:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol didAddCredentials:toRequest:context:]): (-[WebCFNetworkHTTPProtocol useCredential:forAuthenticationChallenge:]): (-[WebCFNetworkHTTPProtocol continueWithoutCredentialForAuthenticationChallenge:]):
WebFoundation-base.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Fixed imports and @class directives for WebFoundation changes.

Panels.subproj/WebAuthenticationPanel.h:
Panels.subproj/WebAuthenticationPanel.m:

WebBrowser:

Reviewed by John.

FileLocker.m: (-[FileLocker dealloc]): Add call to [super dealloc].

AppController.m: (-[AppController applicationShouldOpenUntitledFile:]): Since page load test is now really part of the real application, don't FIXME it in some half-assed way. (-[AppController applicationDidFinishLaunching:]): Remove a FIXME here too.

Test/PageLoadTestRunner.m: (+[PageLoadTestRunner shouldPerformAutomatedPageLoadTest]): Replace the load method with this method.

TitleBarButton.m: (-[TitleBarButton startDragIfNecessaryForEvent:URL:): Removed.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
English.lproj/Localizable.strings: Rolled out Ken's accidental check-in. Regenerating the file just changed it back to how it was before.

5:12 PM Changeset in webkit [4230] by hyatt

4 edits in trunk/WebCore

Fixes for 3227983 and 3224521, both bugs involving bad letter-spacing
property values. This fixes all Movable Type blogs that had this
error in their stylesheets.

Reviewed by gramps

khtml/css/parser.cpp:
khtml/css/parser.y:

4:50 PM Changeset in webkit [4229] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3233819 -- MALLORY: onChange handler being called on SELECT even if selected item does not change

kwq/KWQComboBox.h: Added _currentItem variable, updateCurrentItem function, and replaced activated function with itemSelected function.

kwq/KWQComboBox.mm: (QComboBox::QComboBox): Call updateCurrentItem so _currentItem is up to date. (QComboBox::insertItem): Ditto. (QComboBox::clear): Ditto. (QComboBox::setCurrentItem): Ditto. (QComboBox::updateCurrentItem): Added. Returns true if current item has changed since the last time the function was called. (QComboBox::itemSelected): Only send the activate method if updateCurrentItem returns true. (-[KWQComboBoxAdapter action:]): Call itemSelected instead of calling activated directly.

4:47 PM Changeset in webkit [4228] by rjw

2 edits in trunk/WebKit

Fixed doc errors.

History.subproj/WebHistory.h:

4:46 PM Changeset in webkit [4227] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _applyHTTPProxyCredentials:]): (-[NSHTTPAuthenticator _applyHTTPCredentials:]): (-[NSHTTPAuthenticator _proxyUsernameForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]): (-[NSHTTPAuthenticator _removeProxyPasswordForURL:]): (-[NSHTTPAuthenticator init]):
AuthenticationManager.subproj/NSURLCredential.h:
AuthenticationManager.subproj/NSURLCredential.m: (+[NSURLCredential credentialWithUser:password:persistence:]):
AuthenticationManager.subproj/NSURLCredentialStorage.h:
AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]): (initSharedCredentialStorage): (initCredentialStorage): (+[NSURLCredentialStorage sharedCredentialStorage]):

WebKit:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

WebBrowser:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

AppController.m: (-[AppController removeAllCredentials]):
FormCompletionController.m: (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]):
Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]):

4:15 PM Changeset in webkit [4226] by mjs

10 edits
3 adds in trunk/WebKit

Reviewed by Darin.

Changed things to use WebAuthenticationChallenge for
WebResoureceLoadDelegate auth callbacks.

Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebAuthenticationChallenge.h: Added.
WebView.subproj/WebAuthenticationChallenge.m: Added. (-[WebAuthenticationChallengeInternal initWithDelegate:]): (-[WebAuthenticationChallengeInternal dealloc]): (-[WebAuthenticationChallenge _initWithAuthenticationChallenge:delegate:]): (-[WebAuthenticationChallenge dealloc]): (-[WebAuthenticationChallenge useCredential:]): (-[WebAuthenticationChallenge cancel]): (-[WebAuthenticationChallenge continueWithoutCredential]):
WebView.subproj/WebAuthenticationChallengeInternal.h: Added.
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate useCredential:forAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
WebView.subproj/WebResourceLoadDelegate.h:

3:48 PM Changeset in webkit [4225] by mjs

4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

AuthenticationManager.subproj/NSURLCredential.h:
AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredential initWithUser:password:persistence:]): (-[NSURLCredential dealloc]): (-[NSURLCredential user]): (-[NSURLCredential password]): (-[NSURLCredential hasPassword]): (-[NSURLCredential persistence]): (-[NSURLCredential description]):
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.m: Added. (-[NSURLDownloadAuthenticationChallengeInternal initWithDownload:]): (-[NSURLDownloadAuthenticationChallengeInternal dealloc]): (-[NSURLDownloadAuthenticationChallenge _initWithAuthenticationChallenge:download:]): (-[NSURLDownloadAuthenticationChallenge dealloc]): (-[NSURLDownloadAuthenticationChallenge download]):
AuthenticationManager.subproj/NSURLDownloadAuthenticationChallengeInternal.h: Added.
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload _cancelWithError:]):
WebFoundation-base.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

Misc.subproj/WebDownload.m: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]):
Panels.subproj/WebPanelAuthenticationHandler.h:
Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):

3:41 PM Changeset in webkit [4224] by kocienda

2 edits in trunk/WebKit

Tests:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

CookieManager/wkcookie-test.m: (main):
CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

CookieManager.subproj/NSHTTPCookie.h:
CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie initWithDictionary:]): (-[NSHTTPCookie init]): (-[NSHTTPCookie dictionaryRepresentation]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (-[NSHTTPCookie description]):
CookieManager.subproj/NSHTTPCookiePrivate.h:
CookieManager.subproj/NSHTTPCookieStorage.h:
CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _readAcceptCookiesPreference]): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage init]): (-[NSHTTPCookieStorage acceptPolicy]): (-[NSHTTPCookieStorage setAcceptPolicy:]): (-[NSHTTPCookieStorage description]):
English.lproj/StringsNotToBeLocalized.txt:
WebFoundation-base.exp:

WebKit:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]):

WebBrowser:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

English.lproj/Localizable.strings:
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

3:20 PM Changeset in webkit [4223] by cblu

5 edits in trunk/WebKit

WebKit:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): If the icon db hasn't been set using the defaults, create o directory using the bundle id.
WebKit.exp:

WebBrowser:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

AppController.m: (+[AppController initialize]): Moved the icon DB rename code here from WebKit. Set the icon DB path.
Defaults.plist: Removed unused "safe MIME types" defaults
English.lproj/StringsNotToBeLocalized.txt:

3:03 PM Changeset in webkit [4222] by rjw

14 edits in trunk/WebKit

WebFoundation:

Added utility _web_URLFragment.

Reviewed by Darin.

Misc.subproj/WebNSStringExtras.h:
Misc.subproj/WebNSStringExtras.m: (-[NSString _web_URLFragment]):

WebKit:

API changes from final review meeting.

Moved view registry to WebView.
Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.
Added WebHistorySavedNotification.

Reviewed by Darin.

History.subproj/WebHistory.m: (-[WebHistory addItemForURL:]):
History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem anchor]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]):
History.subproj/WebHistoryItemPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (+[WebView registerViewClass:representationClass:forMIMEType:]):

WebBrowser:

API changes from final review meeting.

Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.

Reviewed by Darin.

Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
GlobalHistory.m: (-[GlobalHistory parentOfContentItem:]):
WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): (-[WebBookmarkLeaf setLastVisitedDate:]): (-[WebBookmarkLeaf lastVisitedDate]):

Tests:

API changes from final review meeting.
Moved view registry to WebView.

Reviewed by Darin.

PDFBundle/PDFView.m: (+[PDFPluginViewFactory load]):
PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):

2:49 PM Changeset in webkit [4221] by mjs

18 edits
2 adds
3 deletes in trunk/WebKit

WebFoundation:

Reviewed by Darin.

More authentication API changes. With this change, we actually
send the authentication request through the connection delegate,
which is the major structural change. Even so, some work remains
to be done.

AuthenticationManager.subproj/NSHTTPAuthenticator.h:
AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithConnection:httpRequest:challenge:callback:context:]): Use a connection and dispatcher, not the usual handler array. (-[NSURLAuthenticationChallengeState dealloc]): Likewise. (-[NSHTTPAuthenticator _tryChallenge:]): Likewise. (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Renamed from _invokeHandlersWithURL... and updated. (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Likewise. (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): Fix cleanup - no more handlers. (-[NSHTTPAuthenticator _internalInit]): Got rid of handler stuff. (-[NSHTTPAuthenticator dealloc]): Likewise. (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:connection:withCallback:context:]): Ask the delegate, not the handlers. (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): Likewise.

AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallenge _useCredential:]): Semi-privatized this method, it will go for real soon but is used as a back channel by NSURLConnection for now. (-[NSURLAuthenticationChallenge _cancel]): Likewise.

AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:delegate:]): Temporary private init since we still need the challenge delegate for now.

AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h: Added.
AuthenticationManager.subproj/NSURLProtocolAuthenticationChallenge.h: Updated.

AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h:
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Renamed class to WebAuthenticationDispatcher. (-[WebAuthenticationDispatcher _dispatchStartAuthentication:]): Redone to use connection delegate based auth instead of using an authentication handler. (-[WebAuthenticationDispatcher _dispatchCancelAuthentication:]): Likewise. (-[WebAuthenticationDispatcher _dispatchAuthenticationDone:]): Likewise. (-[WebAuthenticationDispatcher dealloc]): Likewise. (-[WebAuthenticationDispatcher startAuthentication:]): Likewise. (-[WebAuthenticationDispatcher initWithConnection:]): New init.

CacheLoader.subproj/NSURLConnectionPrivate.h:
CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection _delegate]): Temporary private method so that NSHTTPAuthenticator can bypass the Protocol <--> ProtocolClient interface and call the delegate directly.

FileTransfer.subproj/NSURLDownloadPrivate.h: Declared _init methods.
FileTransfer.subproj/NSURLDownload.h:
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): Added. (+[NSURLDownload _downloadWithLoadingConnection:request:response:delegate:proxy:]): Use corresponding _init. (-[NSURLDownload _initWithSource:delegate:directory:]): Added. (+[NSURLDownload _downloadWithSource:delegate:directory:]): Use correspoding _init. (-[NSURLDownload _sendDidBeginMessage]): Note that we sent it even if we tried but the delegate does not respond to the begin selector, to avoid failing asserts later otherwise. (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): Forward to delegate or do the default action. (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): Likewise. (-[NSURLConnectionDelegateProxy respondsToSelector:]): Act like we respond only if the underlying delegate does. (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): Pass it along. (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]): Pass it along.
AuthenticationManager.subproj/NSURLCredentialStorage.h: Removed authentication handler stuff.
AuthenticationManager.subproj/NSURLCredentialStorage.m: Likewise.

WebKit:

Reviewed by Darin.

Adjusted for authentication API change - now we expect authentication via the connection delegate, not a separate global authentication handler

Misc.subproj/WebKit.h: Include WebDownload.h
Misc.subproj/WebDownload.h: Added.
Misc.subproj/WebDownload.m: Added - this new class is just like NSURLDownload but if the standard auth delegate methods are not implemented, it prompts using the standard AppKit sheet.
Panels.subproj/WebPanelAuthenticationHandler.h:
Panels.subproj/WebPanelAuthenticationHandler.m: (+[WebPanelAuthenticationHandler sharedHandler]): New method to get a shared handler, since we no logner register an instance with WebFoundation. (-[WebPanelAuthenticationHandler startAuthentication:window:]): Do things using the new API. (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): Likewise.
WebKit.exp: Export WebDownload.
WebKit.pbproj/project.pbxproj: Add new files to build.

Removed WebStandardPanels - this is removed from the API.

Panels.subproj/WebStandardPanels.h: Removed.
Panels.subproj/WebStandardPanels.m: Removed.
Panels.subproj/WebStandardPanelsPrivate.h: Removed.
Panels.subproj/WebAuthenticationPanel.m: Remove WebStandardPanels.h import.

Added new resource load delegate auth methods:

WebView.subproj/WebResourceLoadDelegate.h:

Use WebDownload where appropriate, and remove use of WebStandardPanels:

WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Pass to resource load delegate. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Likewise. (-[WebBaseResourceHandleDelegate dealloc]): Don't track currentURL any more. (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Likewise. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Likewise. (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): Likewise. (-[WebBaseResourceHandleDelegate cancelWithError:]): Likewise.
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): Prompt using the standard panel.

(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
Cancel prompting using the standard panel.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Use WebDownload instead of NSURLDownload.
WebView.subproj/WebView.h: Remove unneeded @class directives, and mention WebDownload instead of NSURLDownload.
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): Use WebDownload instead of NSURLDownload. (-[WebView _cacheResourceLoadDelegateImplementations]): Track auth methods too.

WebBrowser:

Reviewed by Darin.

Updated for new WebKit auth API.

AppController.m: (-[AppController awakeFromNib]): No need to register interest in standard panels.
DownloadMonitor.m: (-[DownloadMonitor downloadWindowForAuthenticationSheet:]): Implemented this method so we can pop a sheet off the download window when reloading (yay, finally)!
DownloadProgressEntry.m: (-[DownloadProgressEntry reload]): Use WebDownload not NSURLDownload.

2:44 PM Changeset in webkit [4220] by hyatt

3 edits in trunk/WebCore

Fix for the Adam Rice float/padding test on diveintomark's list
of bugs. We weren't adding in the parent's border/padding in
one case in the clearFloats function, which resulted in the
float being incorrectly positioned.

Reviewed by darin

khtml/rendering/render_block.cpp:

11:20 AM Changeset in webkit [4219] by kocienda

2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

CookieManager/wkcookie-test.m: (DumpIFCookie): (main):
CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

CookieManager.subproj/NSHTTPCookie.h:
CookieManager.subproj/NSHTTPCookie.m: (+[NSHTTPCookie cookieWithDictionary:]): (setVersion): (setName): (setValue): (setDefaultsFromOriginURL): (setDomain): (setPath): (setSecure): (setExpires): (-[NSHTTPCookie initWithDictionary:]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (+[NSHTTPCookie _cookieArrayFromResponseHeaders:forURL:]): (-[NSHTTPCookie compare:]): (-[NSHTTPCookie _compareForHeaderOrder:]):
CookieManager.subproj/NSHTTPCookiePrivate.h:
CookieManager.subproj/NSHTTPCookieStorage.h:
CookieManager.subproj/NSHTTPCookieStorage.m: (acceptCookiesChanged): (setUpOnLoadThread): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage _internalInit]): (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (initSharedCookieManager): (+[NSHTTPCookieStorage sharedCookieManager]): (-[NSHTTPCookieStorage setCookie:]): (-[NSHTTPCookieStorage deleteCookie:]): (-[NSHTTPCookieStorage setCookiesFromResponseHeader:forURL:policyBaseURL:]):
CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
CookieManager.subproj/WebCookieStorage.m: (-[WebCookieStorage cookiesMatchingDomain:path:secure:]):
CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServer _checkForCookieExpiration:]): (-[WebCookieStorageServer _saveCookies]): (-[WebCookieStorageServer _setCookiesWithoutSaving:]): (-[WebCookieStorageServer deleteCookies:]): (makeCookie):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
WebFoundation-base.exp:

WebKit:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

AppController.m: (-[AppController deleteAllCookies]):
Preferences.subproj/AcceptedCookies.m: (compareByDomain): (compareByName): (compareByPath): (compareBySecure): (compareByExpires): (compareByContents): (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies tableView:objectValueForTableColumn:row:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

9:17 AM Changeset in webkit [4218] by kocienda

4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Changed file names for cookie-related classes.
With the exception of moving some constants
around, the contents of the files themselves
remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

CookieManager.subproj/NSHTTPCookie.h:
CookieManager.subproj/NSHTTPCookie.m:
CookieManager.subproj/NSHTTPCookiePrivate.h:
CookieManager.subproj/NSHTTPCookieStorage.h:
CookieManager.subproj/NSHTTPCookieStorage.m:
CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
CookieManager.subproj/WebCookie.h: Removed.
CookieManager.subproj/WebCookie.m: Removed.
CookieManager.subproj/WebCookieManager.h: Removed.
CookieManager.subproj/WebCookieManager.m: Removed.
CookieManager.subproj/WebCookieManagerPrivate.h: Removed.
CookieManager.subproj/WebCookiePrivate.h: Removed.
CookieManager.subproj/WebCookieStorage.m:
CookieManager.subproj/WebCookieStorageServer.m:
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

WebCoreSupport.subproj/WebCookieAdapter.m:
WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

AppController.m:
Preferences.subproj/AcceptedCookies.m:
Preferences.subproj/SecurityPreferences.m:

8:22 AM Changeset in webkit [4217] by darin

3 edits in trunk/WebKit

Reviewed by Ken.

make change to avoid misunderstanding that led to bug report 3179394 "Safari: Request that temp files use actual file extensions"

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Don't put a dot between "SafariPlugInStream" and the the 6-digit unique number, so the number does not look like an extension. Also make it "WebKitPlugInStream" since this is used for other WebKit clients, and not just Safari.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Apr 29, 2003:

7:33 PM Changeset in webkit [4216] by hyatt

8 edits in trunk/WebCore

This patch fixes the following bugs:

(1) 3186174 - padding-left improperly applied to list items.
The fix is in render_list.cpp and involves adding in the
list item's border and padding so that outside markers end up
outside the border box instead of just inside the padding box.

(2) 3239571 - a stray !important after a ; causes the CSS parser
to choke. This patch adds a rule to parser.y to deal with
!importants found in between property values and to just ignore
them.

(3) 3170647 - positioned boxes with auto widths ended up adding
in their border/padding twice! Make sure that when
calcAbsoluteHorizontal in render_box.cpp examines m_maxWidth that
it subtracts out the border and padding and looks at content width.

(4) 3186165 - Negative padding values were being incorrectly
honored by Safari. A patch to css_styleselector.cpp checks to
see if the value specified by the rule is negative, and if so
the rule is not applied.

(5) 3132172 - The clip property could not be accessed via script
because the cssText routine for CSS_RECT primitive values had
not been implemented. In css_valueimpl.cpp this code has now been
filled in.

Reviewed by mjs

khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText):
khtml/css/cssstyleselector.cpp:
khtml/css/parser.cpp:
khtml/css/parser.y:
khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
khtml/rendering/render_list.cpp: (RenderListMarker::paintObject):

6:13 PM Changeset in webkit [4215] by rjw

3 edits in trunk/WebKit

API changes from final review meeting.
Added textEncodingName method to WebDataSource.

Reviewed by Chris.

WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource textEncodingName]):

5:12 PM Changeset in webkit [4214] by hyatt

4 edits in trunk/WebCore

Fix for 3226138, crash on canada.gc.ca. Make sure a failed
@media parse doesn't crash by adding a null check.

Reviewed by mjs

khtml/css/parser.cpp:
khtml/css/parser.y:

4:46 PM Changeset in webkit [4213] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_object.cpp

Tweaking a comment.

4:32 PM Changeset in webkit [4212] by hyatt

9 edits in trunk/WebCore

The remainder of the overflow:auto patch.

A minor table cell optimization has also been included.

Also fixing one of rjw's inline table bugs. Inline tables
didn't clear their minmaxwidth bool when contents inside them
changed size.

r=mjs/gramps on overflow:auto stuff
r=rjw on the table stuff

khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
khtml/rendering/render_table.cpp: (RenderTableCell::layout):
khtml/rendering/render_table.h:

2:54 PM Changeset in webkit [4211] by cblu

6 edits in trunk/WebKit

Tests:

Updated to use the new NSURLDownload API.

Downloader/MyDocument.h:
Downloader/MyDocument.m: (-[MyDocument downloadCancel:]): (-[MyDocument savePanelDidEnd:returnCode:contextInfo:]): (-[MyDocument downloadDidBegin:]): (-[MyDocument download:didReceiveResponse:]): (-[MyDocument download:decideDestinationWithSuggestedFilename:]): (-[MyDocument download:didReceiveDataOfLength:]): (-[MyDocument download:didCreateDestination:]): (-[MyDocument downloadDidFinish:]): (-[MyDocument download:didFailWithError:]):

WebFoundation:

Updated to new NSURLDownload API.

Reviewed by rjw.

FileTransfer.subproj/NSBinHexDecoder.m: (+[NSBinHexDecoder MIMEType]):
FileTransfer.subproj/NSGZipDecoder.m: (+[NSGZipDecoder MIMEType]):
FileTransfer.subproj/NSMacBinaryDecoder.m: (+[NSMacBinaryDecoder MIMEType]):
FileTransfer.subproj/NSURLDownload.h:
FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload initWithSource:delegate:]): (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithLoadingConnection:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithSource:delegate:directory:]): (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload source]): (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload _sendDidBeginMessage]): (-[NSURLDownload connection:willSendRequest:redirectResponse:]): (-[NSURLDownload connection:didReceiveResponse:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload connection:didFailLoadingWithError:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _didCloseFile:]): (-[NSURLDownload _cancelWithError:]): (-[NSURLDownload _setPath:]): (-[NSURLConnectionDelegateProxy connection:didFailLoadingWithError:]):
FileTransfer.subproj/NSURLDownloadDecoder.h:
FileTransfer.subproj/NSURLDownloadPrivate.h:
FileTransfer.subproj/NSURLUpload.h: Added.
FileTransfer.subproj/NSURLUpload.m: Added. (-[NSURLUpload initWithSource:destination:delegate:]): (-[NSURLUpload useCredential:forAuthenticationChallenge:]): (-[NSURLUpload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLUploadAuthenticationChallenge upload]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Updated to use the new NSURLDownload API.

Reviewed by rjw.

WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):
WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):

WebBrowser:

Updated to use the new NSURLDownload API.

Reviewed by rjw.

DownloadMonitor.m: (-[DownloadMonitor downloadDidBegin:]): (-[DownloadMonitor download:decideDestinationWithSuggestedFilename:]): (-[DownloadMonitor download:shouldDecodeSourceDataOfMIMEType:]): (-[DownloadMonitor download:didCreateDestination:]): (-[DownloadMonitor downloadDidFinish:]): (-[DownloadMonitor download:didFailWithError:]): (-[DownloadMonitor cancelDownload:withError:]):
DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):

2:38 PM Changeset in webkit [4210] by rjw

18 edits in trunk/WebKit

Added "Copyright (C) 2003 Apple Computer, Inc. All rights reserved."
to all public headers. Also made formatting consistent.

Reviewed by darin.

12:44 PM Changeset in webkit [4209] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3234633 -- page with moderately deep tag nesting causes crash when closed (www.4strokenationals.com)

khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::~NodeBaseImpl): Avoid recursion by using a global list of child nodes to destroy and only doing the actual destruction at the top level.

11:30 AM Changeset in webkit [4208] by darin

22 edits
2 deletes in trunk/WebCore

Mostly reviewed by Ken, some bits reviewed by John.

fixed 3188781 -- eliminate globally initialized objects from WebCore

kwq/KWQString.h: Change QChar::null to be a char constant, and QString::null to be a const char *. In the cases where the code still compiles after these changes, everything works fine. A few cases that didn't compile are fixed below.
kwq/KWQString.mm: Remove QString::null. (QString::mid): Return QString() instead of null.
kwq/KWQChar.mm: Remove the definition of QChar::null.

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): Use DOMString explicitly in one place where the code said QString::null. The trick where QString::null is really a const char * does not work in this case.
khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration): Use QString() instead of QString::null in one place. The trick where QString::null is really a const char * does not work in this case.
kwq/KWQKHTMLSettings.h: Use QString() for settingsToCSS, the trick where QString::null is really a const char * does not work in this case.
khtml/rendering/render_list.cpp: (RenderListMarker::paintObject): Use an isEmpty check here instead of comparing with QString::null. Not sure this change was strictly required, but it is simpler and may also make the code slightly faster.

kwq/KWQKFileDialog.h: Removed. This used QString::null in a way that is incompatible with the new "0" hack, but was not used any more.
kwq/KWQKFileDialog.mm: Removed.
ForwardingHeaders/kfiledialog.h: Empty this out, since there is no KWQKFileDialog.h any more.
WebCore.pbproj/project.pbxproj: Removed KWQKFileDialog.h and .mm.

khtml/html/htmltokenizer.cpp: Change the commentStart global array to be an array of char instead of QChar to avoid the static constructor; the code works fine with char anyway.
khtml/html/html_formimpl.cpp: Change the global constants in this file to be char instead of QChar. It works this way (and faster for KWQ), and avoids the static constructor.

khtml/rendering/bidi.h: Change BidiIterator from a class with constructors into a plain struct. The copy construct and assignment operator weren't needed anyway since they simply duplicated default assignment, and if we have a constructor then we can't use it as a global object, since we want to avoid static constructors. Do the same with BidiStatus, and also stop using bit fields. It's silly to use bit fields for something when we have only one global instance of it; just makes extra code size and saves a few bytes.
khtml/rendering/bidi.cpp: (BidiIterator::current): Move the non-breaking space global inside this function. (appendRunsForObject): Initialize BidiIterator object using brace notation. (buildCompactRuns): Initialize BidiIterator objects using brace notation and assignment. (RenderBlock::layoutInlineChildren): Initialize BidiStatus fields separately. Initialize BidiIterator objects using brace notation and assignment. (RenderBlock::findNextLineBreak): Initialize BidiIterator objects using brace notation and assignment.

khtml/rendering/render_frames.cpp: Removed an include of <iostream.h>. This pulled the entire C++ I/O library in, with lots of static constructors. Elsewhere, we are careful not to use the C++ I/O library in WebCore except in Development versions. And this file didn't actually use the library, just included the header.

kwq/KWQNamespace.h: Remove all the color globals except for the ones used in KHTML: black, white, darkGray, gray, and lightGray. And for those, make the globals RGB constants instead of QColor objects. This gets rid of the global objects with constructors and works without any KHTML code changes.
kwq/KWQColor.mm: Remove the definition of the QColor constants from the Qt class.

kwq/KWQPainter.h: Add overloads for setPen and setBrush so they work with the "color" constants from Qt that are now RGB constants rather than QColor objects.
kwq/KWQPainter.mm: (QPainter::setPen): Set style to solid line and width to 0 when the parameter is an RGB constant. This is just like what you'd get if you constructed a QPen. (QPainter::setBrush): Set style to solid pattern when the parameter is an RGB constant. This is just like what you'd get if you constructed a QBrush.

khtml/misc/loader.h: Change m_LRULists to be a global pointer instead of a global array, so we don't have to statically construct LRUList objects.
khtml/misc/loader.cpp: (Cache::getLRUListFor): Allocate the global array the first time we pass through here.

11:27 AM Changeset in webkit [4207] by darin

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 2959353 -- eliminate globally initialized objects from JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Added fpconst.cpp.
kjs/fpconst.cpp: Added. Defines KJS::NaN and KJS::Inf in a way that does not require a framework init routine.

kjs/identifier.h: Use a new KJS_IDENTIFIER_EACH_GLOBAL macro so we can do things to the entire set of identifiers easily. Also added an init function that sets up these globals in a way that does not require a framework init routine.
kjs/identifier.cpp: (Identifier::init): Initialize the property ane globals in a way that does not require a framework init routine.

kjs/internal.cpp: (InterpreterImp::initGlobalObject): Call Identifier::init.

kjs/ustring.h: Remove UChar::null and UString::null, and add UString::null(). We can't have a global object of a class that has a constructor if we want to avoid framework init routines, and luckily very little code relies on these.
kjs/ustring.cpp: (UCharReference::ref): Use our own global specific to this function rather than returning UChar::null when past the end of the string. This is dangerous because if the caller modifies it, that affects what all subsequent callers will see. (UString::Rep::create): Added assertions. (UString::UString): Got rid of code here that used to set up UString::null. (UString::null): Added. Returns a global null string, and can be used in some of the places where we used to use the UString::null global. (UString::operator[]): Fixed case where this used to return UChar::null to return '\0' instead.

kjs/regexp.cpp: (RegExp::match): Change uses of UString::null to UString::null().

11:26 AM Changeset in webkit [4206] by darin

9 edits
1 add in trunk/JavaScriptCore

Reviewed by John.

fixed 2959353 -- eliminate globally initialized objects from JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Added fpconst.cpp.
kjs/fpconst.cpp: Added. Defines KJS::NaN and KJS::Inf in a way that does not require a framework init routine.

kjs/identifier.h: Use a new KJS_IDENTIFIER_EACH_GLOBAL macro so we can do things to the entire set of identifiers easily. Also added an init function that sets up these globals in a way that does not require a framework init routine.
kjs/identifier.cpp: (Identifier::init): Initialize the property ane globals in a way that does not require a framework init routine.

kjs/internal.cpp: (InterpreterImp::initGlobalObject): Call Identifier::init.

kjs/ustring.h: Remove UChar::null and UString::null, and add UString::null(). We can't have a global object of a class that has a constructor if we want to avoid framework init routines, and luckily very little code relies on these.
kjs/ustring.cpp: (UCharReference::ref): Use our own global specific to this function rather than returning UChar::null when past the end of the string. This is dangerous because if the caller modifies it, that affects what all subsequent callers will see. (UString::Rep::create): Added assertions. (UString::UString): Got rid of code here that used to set up UString::null. (UString::null): Added. Returns a global null string, and can be used in some of the places where we used to use the UString::null global. (UString::operator[]): Fixed case where this used to return UChar::null to return '\0' instead.

kjs/regexp.cpp: (RegExp::match): Change uses of UString::null to UString::null().

10:02 AM Changeset in webkit [4205] by darin

6 edits in trunk/WebCore

Reviewed by Ken.

fixed 3242460 -- crash in NSPopUpButtonCell at acheter-moins-cher.com

kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Defer QObject timers too as well as loading while tracking a pop-up.

kwq/KWQObject.h: Add defersTimers and setDefersTimers functions.
kwq/KWQObject.mm: (QObject::setDefersTimers): Added. When called with true starts deferring timers. When called with false schedules a "delay 0" task to deliver all the timers and stop deferring them. (-[KWQObjectTimerTarget sendTimerEvent]): Added. Contains guts of the old timerFired method. (-[KWQObjectTimerTarget timerFired]): Puts timer on the deferred timers list or calls sendTimerEvent. (+[KWQObjectTimerTarget stopDeferringTimers]): Remove timers items from the deferred timers list, and makes them fire, then stops deferring timers.

WebCore.pbproj/project.pbxproj: Reorder things a bit.

8:19 AM Changeset in webkit [4204] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3230885 -- crash loading hixie test page in -[WebSubresourceClient connection:didReceiveData:]

khtml/rendering/render_style.cpp: (RenderStyle::setContent): Change code around so we don't deref the text object without checking the contentType. Also fix the leak of a DOMStringImpl in the case where we are asked to add a string, but the string pointer is 0.

Apr 28, 2003:

7:09 PM Changeset in webkit [4203] by gramps

6 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

WebKit:

Fixed 3225050 -- Default font size should be 16px
Fixed 3241813 -- No longer spoof as WinIE for abcnews.go.com when
default font size becomes 16px

Reviewed by Darin and Maciej.

English.lproj/StringsNotToBeLocalized.txt:

Updated.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

We need to adjust Times, Helvetica, and Courier to closely match the
vertical metrics of their Microsoft counterparts that are the de facto
web standard. The AppKit adjustment of 20% is too big and is
incorrectly added to line spacing, so we use a 15% adjustment instead
and add it to the ascent.

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

Changed default font size from 14 to 16 pixels and default fixed font
size from 14 to 13 pixels. Changed standard font from Lucida Grande to
Times, serif font from Times New Roman to Times, and sans serif font
from Lucida Grande to Helvetica. Also replaced some stray tabs with
spaces and made a few other anal-retentive formatting changes.

WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry):
WebView.subproj/WebUserAgentSpoofTable.gperf:

No longer spoof as Windows MSIE for abcnews.go.com since we've also
changed the default font size.

WebBrowser:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

6:59 PM Changeset in webkit [4202] by rjw

22 edits in trunk

WebCore:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

WebKit:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

Plugins.subproj/WebBaseNetscapePluginView.m:
WebCoreSupport.subproj/WebBridge.m:
WebKit.exp:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebDefaultUIDelegate.m:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebImageView.m:
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebTextView.m:
WebView.subproj/WebUIDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m:

WebBrowser:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

BrowserDocument.m:
BrowserWebController.m:
ContextMenuHandler.m:
FindPanelController.m:

Tests:

Updated examples to match API changes
Added zooming as an example of stringByEvaluatingJavaScriptFromString:
and custom context menus. Currently problematic because of 3242716.

IBViewer/English.lproj/Document.nib:
IBViewer/IBViewer.pbproj/project.pbxproj:
PictureBrowser/Document.m:
PictureBrowser/English.lproj/Document.nib:
PictureBrowser/image_template.html:
PictureBrowser/thumbnail_template.html:

5:12 PM Changeset in webkit [4201] by darin

3 edits in trunk/WebCore

Reviewed by John.

re-fixed 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::attach): Only set the type if JavaScript hasn't set it explicitly already.

4:01 PM Changeset in webkit [4200] by kocienda

3 edits
2 adds in trunk/WebKit

WebFoundation:

Reviewed by Chris

Large reworking of NSURLResponse internals and
NSCachedURLResponse internals to move this code to
the API-approved design. Quite a bit of SPI has
shifted around as well.

CacheLoader.subproj/NSCachedURLResponse.h: Name change: WebCacheObjectInternal -> NSCachedURLResponseInternal.

Added new init methods that conform to approved API. Removed old
initWithResponse: init method.

Also removed a host of other cache-related accessors and methods:
createdDate, setCreatedDate:, expiresDate, setExpiresDate:,
lastModifiedDate, setLastModifiedDate:, maxAgeValue, setMaxAgeValue:,
mustRevalidate, setMustRevalidate:, isExpired, age, and
freshnessLifetime. The getters have moved to SPI on NSURLResponse. The
setters have been obsoleted as there are now default values in the
case of non-HTTP responses, and the information can be derived from
the HTTP header in all cases for HTTP responses.

Removed: objectSize and setObjectSize: methods. This figure can be
derived from the length of the NSCachedURLResponse's data field.

Removed: canStoreInMemory, setCanStoreInMemory:, canStoreOnDisk, and
setCanStoreOnDisk: methods. These are obsoleted by the new
NSURLCacheStoragePolicy API construct.

CacheLoader.subproj/NSCachedURLResponse.m:

Name change: WebCacheObjectVersion -> NSCachedURLResponseVersion.
Bumped the version number as well.

Removed instance variables used for now-obsoleted getter and setter
methods.

Added NSData, user-info NSDictionary and NSURLCacheStoragePolicy
instance variables, and added the API-approved getters for them.

Added implementation for new init methods; removed old init method
implementation.

Modified copy and coding methods accordingly.

Removed all method implementations mentioned in the
NSCachedURLResponse.h comment.

CacheLoader.subproj/NSURLCache.m: (-[NSURLCache storeCacheObject:forKey:]): Rewrote implementation to use new NSURLCacheStoragePolicy construct in place of older canCache accessors.

CacheLoader.subproj/NSURLCachePrivate.h: Added _cacheStatistics SPI method that used to be API but did not make the cut.

CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didFinishReturnCachedResponse:]): Use new API to access cache object data. (-[NSURLConnection _didFinishLoading]): Use new API to create an NSCachedURLResponse.

CacheLoader.subproj/NSURLResponse.h: Now implements NSCopying.

CacheLoader.subproj/NSURLResponse.m:

Bumped NSURLResponseVersion.

Removed createdTime and lastModifiedTime instance variables from
NSURLResponseInternal. Added createdDate instance variable. This is
part of the new way to track this information in responses.

Removed resourceData instance variable from NSURLResponseInternal.
This is no longer stored in the response object; it has moved to
NSCachedURLResponse.

Fixed silly retain of a static string in NSURLResponseInternal.

Updated NSURLResponseInternal dealloc and coding methods for new
instance variable set.

Added copyWithZone: method.

Removed accessors for obsoleted instance variables.

Added SPI accessor methods to NSURLResponseInternal: _createdDate,
_expiresDate, _lastModifiedDate, _maxAge, _mustRevalidate, and
_freshnessLifetime. Most of these return default values that give
objects very permissive cache constraints.

Name change: WebHTTPResponseVersion -> NSHTTPURLResponseVersion.
Bumped the value.

Added a collection of transient instance variables to
NSHTTPURLResponseInternal to track the values the HTTP response
subclass returns for _createdDate, _expiresDate, _lastModifiedDate,
_maxAge, _mustRevalidate, and _freshnessLifetime methods.

Updated NSHTTPURLResponseInternal dealloc method for new instance
variable set.

Name change in NSHTTPURLResponseInternal: setHeader: ->
setAllHeaderFields:.

Added SPI accessor methods: _createdDate, _expiresDate,
_lastModifiedDate, _maxAge, _mustRevalidate, and _freshnessLifetime
that use HTTP header information to return protocol-correct values.
Added _parseCacheControl helper method.

CacheLoader.subproj/NSURLResponsePrivate.h:

Removed a collection of accessors having to do with cache processing
and replaced with a modified set of SPI methods which work
together with API-approved NSURLResponse and NSCachedURLResponse
designs.

CacheLoader.subproj/WebCacheObjectPrivate.h: Removed.

CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache storeCacheObject:forKey:]): Access NSCachedURLResponse data instance variable to determine the size of a cache object. (-[WebDiskCache removeCacheObjectForKey:]): Ditto.

CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]): Ditto. (-[WebMemoryCache storeCacheObject:forKey:]): Ditto.

Downloads.subproj/NSURLDownload.m: (-[NSURLDownload _createFileIfNecessary]): _createdDate is now NSURLResponse SPI, not API.

Misc.subproj/WebNSCalendarDateExtras.h: Modified convenience method:

+(NSTimeInterval)_web_timeIntervalFromHTTPDateString:(NSString *)string

is now

+(NSDate *)_web_dateFromHTTPDateString:(NSString *)string

Misc.subproj/WebNSCalendarDateExtras.m: (+[NSCalendarDate _web_dateFromHTTPDateString:]): Ditto.

Misc.subproj/WebNSStringExtras.h: Added a new method: -(BOOL)_web_hasCaseInsensitiveSubstring:(NSString *)substring;

Misc.subproj/WebNSStringExtras.m: Ditto. (-[NSString _web_hasCaseInsensitiveSubstring:]):

ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): Use new _web_dateFromHTTPDateString: method.

ProtocolHandlers.subproj/WebHTTPProtocol.h: Remove unused timeIntervalFromHTTPResponseHeader: method.

ProtocolHandlers.subproj/WebHTTPProtocol.m: Ditto.

Modify a wide range of cache-related methods to use new API and
SPI made available by NSURLResponse and NSCachedURLResponse. In
many cases, this involved deleting code that now lives in one
of these two classes, which allows the protocol to rely more
on helpers.
(-[WebHTTPProtocol cachedResponseMustBeRevalidated]):
(-[WebHTTPProtocol _cachedResponseHasExpired]):
(-[WebHTTPProtocol HTTPResponse]):
(-[WebHTTPProtocol _cachePolicyForResponse]):
(-[WebHTTPProtocol setResponseHeader:]):

ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): Tweaks to call new-style NSURLResponse and NSCachedURLResponse accessors.

WebFoundation.pbproj/project.pbxproj: PB knows best.

WebKit:

Reviewed by Chris

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): _lastModifiedDate on NSURLResponse is now SPI.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Ditto.

Apr 27, 2003:

6:10 PM Changeset in webkit [4199] by cblu

3 edits in trunk/WebKit

Improved headerdoc comments.

Misc.subproj/WebKitErrors.h:
WebView.subproj/WebFrameLoadDelegate.h:

Apr 25, 2003:

11:05 PM Changeset in webkit [4198] by darin

3 edits in trunk/JavaScriptCore

fixed 3241344 -- REGRESSION: top of page missing on wired.com and cnn.com

Caused by the ResolveNode speedup. Roll it out until I can figure out why.

kjs/nodes.cpp: (ResolveNode::evaluate): Go back to using evaluateReference.

9:13 PM Changeset in webkit [4197] by gramps

2 edits in trunk/WebKit

Backed out Richard's (hopefully) accidental checkin of our experiments
from earlier today. Otherwise many layout tests are hosed. But this
change, or something like it, will arrive soon.

Reviewed by me.

WebCoreSupport.subproj/WebTextRenderer.m:

(-[WebTextRenderer initWithFont:usingPrinterFont:]):

6:42 PM Changeset in webkit [4196] by rjw

16 edits in trunk/WebKit

WebBrowser:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

BrowserDocument.m: (-[BrowserDocument _isDocumentHTML]):
BrowserWebViewExtras.h:
BrowserWebViewExtras.m: (-[WebFrameView scrollView]):
FrameProgressEntry.m: (+[FrameProgressEntry _isDocumentHTMLForDataSource:]): (-[FrameProgressEntry useSingletonChildForDisplay]):

WebKit:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _layoutChildren]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _isDocumentHTML]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): (-[WebFrame _setState:]): (-[WebFrame _isLoadComplete]):
WebView.subproj/WebFrameView.h:
WebView.subproj/WebFrameView.m: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]): (-[WebFrameView documentView]): (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _setDocumentView:]): (-[WebFrameView _scrollView]): (-[WebFrameView _contentView]): (-[WebFrameView _verticalKeyboardScrollAmount]): (-[WebFrameView _horizontalKeyboardScrollAmount]): (-[WebFrameView _scrollToBottomLeft]): (+[WebFrameView _viewTypesAllowImageTypeOmission:]): (+[WebFrameView _canShowMIMETypeAsHTML:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:]):
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (+[WebView canShowMIMETypeAsHTML:]):

Tests:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

SimpleViewer/DocumentController.m: (-[DocumentController webView:didReceiveTitle:forFrame:]):

6:24 PM Changeset in webkit [4195] by cblu

16 edits
3 deletes in trunk/WebKit

WebFoundation:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

Downloads.subproj/NSBinHexDecoder.h: Added.
Downloads.subproj/NSBinHexDecoder.m: Added. (-[NSBinHexDecoder decodeIntoBuffer:size:]): (-[NSBinHexDecoder pumpCRCTwice]): (-[NSBinHexDecoder decodeAllIntoBuffer:size:]): (-[NSBinHexDecoder decodeHeader]): (-[NSBinHexDecoder setUpSourceForData:]): (-[NSBinHexDecoder decodeForkWithData:count:CRCCheckFlag:]): (+[NSBinHexDecoder canDecodeHeaderData:]): (-[NSBinHexDecoder decodeData:dataForkData:resourceForkData:]): (-[NSBinHexDecoder finishDecoding]): (-[NSBinHexDecoder fileAttributes]): (-[NSBinHexDecoder filename]):
Downloads.subproj/NSGZipDecoder.h: Added.
Downloads.subproj/NSGZipDecoder.m: Added. (+[NSGZipDecoder decodeHeader:headerLength:modificationTime:filename:]): (+[NSGZipDecoder canDecodeHeaderData:]): (-[NSGZipDecoder init]): (-[NSGZipDecoder dealloc]): (-[NSGZipDecoder decodeData:dataForkData:resourceForkData:]): (-[NSGZipDecoder finishDecoding]): (-[NSGZipDecoder fileAttributes]): (-[NSGZipDecoder filename]):
Downloads.subproj/NSMacBinaryDecoder.h: Added.
Downloads.subproj/NSMacBinaryDecoder.m: Added. (+[NSMacBinaryDecoder canDecodeHeaderData:]): (-[NSMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[NSMacBinaryDecoder finishDecoding]): (-[NSMacBinaryDecoder fileAttributes]): (-[NSMacBinaryDecoder filename]): (CRC16):
Downloads.subproj/NSURLDownload.h: Added.
Downloads.subproj/NSURLDownload.m: Added. (+[NSURLDownloadPrivate initialize]): (-[NSURLDownloadPrivate dealloc]): (-[NSURLDownload initWithRequest:]): (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[NSURLDownload dealloc]): (-[NSURLDownload loadWithDelegate:]): (-[NSURLDownload cancel]): (-[NSURLDownload path]): (-[NSURLDownload setPath:]): (-[NSURLDownload _downloadStarted]): (-[NSURLDownload _downloadEnded]): (-[NSURLDownload _setRequest:]): (-[NSURLDownload _setResponse:]): (-[NSURLDownload connection:willSendRequest:redirectResponse:]): (-[NSURLDownload connection:didReceiveResponse:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload connection:didFailLoadingWithError:]): (-[NSURLDownload _pathWithUniqueFilenameForPath:]): (-[NSURLDownload _createFSRefForPath:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _dataIfDoneBufferingData:]): (-[NSURLDownload _finishDecoding]): (-[NSURLDownload _writeForkData:isDataFork:]): (-[NSURLDownload _writeDataForkData:resourceForkData:]): (-[NSURLDownload _isFileClosed]): (-[NSURLDownload _didCloseFile:]): (-[NSURLDownload _closeForkAsync:]): (-[NSURLDownload _closeForkSync:]): (-[NSURLDownload _closeFileAsync]): (-[NSURLDownload _closeFileSync]): (-[NSURLDownload _didDeleteFile]): (-[NSURLDownload _deleteFileAsnyc]): (-[NSURLDownload _closeAndDeleteFileAsync]): (-[NSURLDownload _cancelWithError:]): (-[NSURLDownload _cancelWithErrorCode:]): (-[NSURLDownload _setPath:]): (-[NSURLDownload _setDirectoryPath:]): (-[NSURLDownload _currentPath]): (-[NSURLDownload _errorWithCode:]): (-[NSURLDownload _dataForkReferenceNumber]): (-[NSURLDownload _setDataForkReferenceNumber:]): (-[NSURLDownload _resourceForkReferenceNumber]): (-[NSURLDownload _setResourceForkReferenceNumber:]): (-[NSURLDownload _areWritesCancelled]): (-[NSURLDownload _setWritesCancelled:]): (-[NSURLDownload _encounteredCloseError]): (-[NSURLDownload _setEncounteredCloseError:]): (-[NSURLConnectionDelegateProxy setDelegate:]): (-[NSURLConnectionDelegateProxy connection:willSendRequest:redirectResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveData:]): (-[NSURLConnectionDelegateProxy connectionDidFinishLoading:]): (-[NSURLConnectionDelegateProxy connection:didFailLoadingWithError:]): (WriteCompletionCallback): (CloseCompletionCallback): (DeleteCompletionCallback):
Downloads.subproj/NSURLDownloadDecoder.h: Added.
Downloads.subproj/NSURLDownloadPrivate.h: Added.
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebFoundation.h:
Misc.subproj/WebNSErrorConstants.h:
Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_noteFileChangedAtPath:]):
WebFoundation-base.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

Downloads.subproj/WebBinHexDecoder.h: Removed.
Downloads.subproj/WebBinHexDecoder.m: Removed.
Downloads.subproj/WebDownload.h: Removed.
Downloads.subproj/WebDownload.m: Removed.
Downloads.subproj/WebDownloadDecoder.h: Removed.
Downloads.subproj/WebDownloadPrivate.h: Removed.
Downloads.subproj/WebGZipDecoder.h: Removed.
Downloads.subproj/WebGZipDecoder.m: Removed.
Downloads.subproj/WebMacBinaryDecoder.h: Removed.
Downloads.subproj/WebMacBinaryDecoder.m: Removed.
Downloads.subproj/crc16.h: Removed.
Downloads.subproj/crc16.m: Removed.
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebKit.h:
Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]): (registerErrors):
Misc.subproj/WebNSWorkspaceExtras.h: Removed.
Misc.subproj/WebNSWorkspaceExtras.m: Removed.
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]):
WebView.subproj/WebView.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):

WebBrowser:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor download:didStartFromRequest:]): (-[DownloadMonitor download:didReceiveResponse:]): (-[DownloadMonitor download:decidePathWithListener:suggestedFilename:]): (-[DownloadMonitor download:didReceiveDataOfLength:]): (-[DownloadMonitor downloadShouldDecodeEncodedFile:]): (-[DownloadMonitor download:didCreateFileAtPath:]): (-[DownloadMonitor downloadDidFinishDownloading:]): (-[DownloadMonitor download:didFailDownloadingWithError:]): (-[DownloadMonitor cancelDownload:withError:]): (-[DownloadMonitor setEntry:forReloadingDownload:]):
DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry _setDownload:]): (-[DownloadProgressEntry reload]):
WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):

4:21 PM Changeset in webkit [4194] by rjw

2 edits in trunk/WebKit

Final API review changes.

parent -> parentFrame
children -> childFrames

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:]):

4:17 PM Changeset in webkit [4193] by rjw

2 edits in trunk/WebKit

Final API review changes.

parent -> parentFrame
children -> childFrames

Reviewed by Chris.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): (-[WebBridge frameDetached]):

3:55 PM Changeset in webkit [4192] by rjw

9 edits in trunk/WebKit

WebKit:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (-[WebDataRequestParameters dealloc]): (-[NSURLRequest _webDataRequestMIMEType]): (-[NSURLRequest _webDataRequestSetMIMEType:]): (-[WebDataProtocol startLoading]):
WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): (-[WebDataSource _layoutChildren]): (-[WebDataSource _defersCallbacksChanged]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadHTMLString:baseURL:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _descendantFrameNamed:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (+[WebFrame _recursiveCheckCompleteFromFrame:]): (-[WebFrame _textSizeMultiplierChanged]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate _clearControllerReferences:]): (-[WebView _frameForDataSource:fromFrame:]): (-[WebView _frameForView:fromFrame:]):

WebBrowser:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

BrowserWebController.m: (-[BrowserWebController _closeDataSources:]):
BrowserWebFrameExtras.m: (-[WebFrame _topFrame]):
BrowserWebViewExtras.m: (-[WebFrameView largestScrollableWebView]):
Debug/SnippetController.m: (-[SnippetController load]):
LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor titleChangedForFrame:]):

Tests:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

PictureBrowser/Document.m: (-[Document readFromFile:ofType:]):
SnippetEditor/SnippetController.m: (-[SnippetController updateFromText:]):

3:47 PM Changeset in webkit [4191] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

a couple improvements that give a 6.6% speedup on iBench JavaScript

kjs/nodes.cpp: (ResolveNode::evaluate): Don't use evaluateReference.

kjs/object.cpp: (ObjectImp::get): Do the prototype work with the ValueImp, not a wrapper. Contributes a tiny bit to the speedup, but cleaner anyway. (ObjectImp::hasProperty): Same thing here.

3:07 PM Changeset in webkit [4190] by cblu

2 edits in trunk/WebKit

WebKit:

Don't do "@class WebDataSource" as that class isn't mentioned in this file.

WebView.subproj/WebFrameLoadDelegate.h:

WebBrowser:

Do "@class WebDataSource" as that class is mentioned in this file.

LocationChangeError.h:

2:55 PM Changeset in webkit [4189] by cblu

20 edits
3 deletes in trunk/WebKit

Tests:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

DumpBackForward/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
DumpRenderTree/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
IBViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
PDFViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
PictureBrowser/Document.m: (-[Document webView:didStartProvisionalLoadForFrame:]): (-[Document webView:locationChangeDone:forDataSource:]): (-[Document webView:didFailProvisionalLoadWithError:forFrame:]): (-[Document webView:didFinishLoadForFrame:]): (-[Document webView:didFailLoadWithError:forFrame:]):
SimpleViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]): (-[SnippetController webView:didReceiveTitle:forFrame:]): (-[SnippetController webView:didFailProvisionalLoadWithError:forFrame:]): (-[SnippetController webView:didFinishLoadForFrame:]): (-[SnippetController webView:didFailLoadWithError:forFrame:]):

WebKit:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

English.lproj/Localizable.strings:
Misc.subproj/WebKit.h:
Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (registerErrors):
WebCoreSupport.subproj/WebBridge.m:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
WebView.subproj/WebDefaultFrameLoadDelegate.h: Added.
WebView.subproj/WebDefaultFrameLoadDelegate.m: Added. (+[WebDefaultFrameLoadDelegate sharedFrameLoadDelegate]): (-[WebDefaultFrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didCommitLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFinishLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[WebDefaultFrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[WebDefaultFrameLoadDelegate webView:willCloseFrame:]):
WebView.subproj/WebDefaultLocationChangeDelegate.h: Removed.
WebView.subproj/WebDefaultLocationChangeDelegate.m: Removed.
WebView.subproj/WebFrame.m:
WebView.subproj/WebFrameLoadDelegate.h: Added.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _closeOldDataSources]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]): (-[WebFrame _clientRedirectCancelled]):
WebView.subproj/WebLocationChangeDelegate.h: Removed.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]):
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView setFrameLoadDelegate:]): (-[WebView frameLoadDelegate]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): (-[WebView _frameLoadDelegateForwarder]):

WebBrowser:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

BrowserNSErrorExtras.m: (-[NSError isPolicyChangeError]):
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController close]):
Debug/SnippetController.m: (-[SnippetController load]): (-[SnippetController webView:didFinishLoadForFrame:]): (-[SnippetController webView:didReceiveTitle:forFrame:]):
LocationChangeHandler.h:
LocationChangeHandler.m: (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didCommitLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveTitle:forFrame:]): (-[LocationChangeHandler webView:didReceiveIcon:forFrame:]): (-[LocationChangeHandler webView:didFailProvisionalLoadWithError:forFrame:]): (-[LocationChangeHandler webView:didFinishLoadForFrame:]): (-[LocationChangeHandler webView:didFailLoadWithError:forFrame:]): (-[LocationChangeHandler webView:didChangeLocationWithinPageForFrame:]): (-[LocationChangeHandler webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[LocationChangeHandler webView:didCancelClientRedirectForFrame:]): (-[LocationChangeHandler webView:willCloseFrame:]):

2:51 PM Changeset in webkit [4188] by darin

5 edits in trunk/JavaScriptCore

Reviewed by Maciej.

move from linear probing to double hashing, gives an 0.7% speedup in iBench JavaScript

kjs/property_map.h: Remove the hash function.
kjs/property_map.cpp: Added statistics for rehashes and removes. Moved from linear probing to double hashing, using the hash modulo (table size minus one) plus one for the probing distance.

kjs/ustring.h: Use unsigned instead of int for hash function result.

2:14 PM Changeset in webkit [4187] by hyatt

16 edits
3 adds in trunk/WebCore

Part two of the overflow patch. This adds the scrollbars and
patches the layers code, but it doesn't yet turn on the
overflow:auto capability.

Reviewed by mjs/gramps

ForwardingHeaders/qscrollbar.h: Added.
WebCore.pbproj/project.pbxproj:
khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_dom.lut.h:
khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::repaintRectangle): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical): (RenderBox::lowestPosition):
khtml/rendering/render_layer.cpp: (RenderScrollMediator::slotValueChanged): (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::scrollOffset): (RenderLayer::subtractScrollOffset): (RenderLayer::scrollToOffset): (RenderLayer::updateScrollPositionFromScrollbars): (RenderLayer::setHasHorizontalScrollbar): (RenderLayer::setHasVerticalScrollbar): (RenderLayer::verticalScrollbarWidth): (RenderLayer::horizontalScrollbarHeight): (RenderLayer::moveScrollbarsAside): (RenderLayer::positionScrollbars): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintScrollbars): (RenderLayer::paint): (RenderLayer::nodeAtPoint):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::clientWidth): (RenderObject::clientHeight): (RenderObject::scrollWidth): (RenderObject::scrollHeight): (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget):
kwq/KWQNamespace.h:
kwq/KWQScrollBar.h: Added.
kwq/KWQScrollBar.mm: Added. (-[KWQScrollBar initWithQScrollBar:]): (-[KWQScrollBar scroll:]): (:m_valueChanged): (QScrollBar::~QScrollBar): (QScrollBar::setValue): (QScrollBar::setSteps): (QScrollBar::setKnobProportion): (QScrollBar::scrollbarHit): (QScrollBar::valueChanged):
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):

1:23 PM Changeset in webkit [4186] by sullivan

2 edits in trunk/WebKit

fixed 3240676 -- REGRESSION: Using old Safari then new one erases history

Reviewed by Darin.

History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): The new code to use a synchronous NSURLConnection to read the property list file did not take into account the two possible formats of the file (NSArray or NSDictionary), so reading old-style history files was completely broken. While in here, I distributed the variable declarations to first use.

Apr 24, 2003:

10:10 PM Changeset in webkit [4185] by mjs

2 edits in trunk/WebKit

Fixed build.

Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):

9:22 PM Changeset in webkit [4184] by mjs

1 edit in trunk/WebKit/ChangeLog

WebFoundation:

Reviewed by Ken.

Updated NSURLCredentialStorage to match proposed API (except
authentication handlers, that remains to be fixed).

AuthenticationManager.subproj/NSURLCredentialStorage.h:
AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]): (initSharedURLCredentialStorage): (initCredentialStorage): (+[NSURLCredentialStorage sharedURLCredentialStorage]): (-[NSURLCredentialStorage setCredential:forProtectionSpace:]):
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _sendChangeNotification]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol stopLoading]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):

WebKit:

Reviewed by Ken.

Updated for auth API changes.

Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):

WebBrowser:

Reviewed by Ken.

Updated for auth API changes.

AppController.m: (-[AppController removeAllCredentials]):
FormCompletionController.m: (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]):
Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]):

8:26 PM Changeset in webkit [4183] by rjw

23 edits
4 deletes in trunk/WebKit

WebKit:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.
Fixed crasher if history file doesn't exist.

Reviewed by Ken.

History.subproj/WebHistory.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
Misc.subproj/WebKit.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView status:]):
Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
WebCoreSupport.subproj/WebBridge.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge windowFrame]): (-[WebBridge setWindowContentRect:]): (-[WebBridge windowContentRect]): (-[WebBridge setWindowIsResizable:]): (-[WebBridge windowIsResizable]): (-[WebBridge firstResponder]): (-[WebBridge makeFirstResponder:]): (-[WebBridge closeWindow]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge focusWindow]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebContextMenuDelegate.h: Removed.
WebView.subproj/WebDefaultContextMenuDelegate.h:
WebView.subproj/WebDefaultContextMenuDelegate.m:
WebView.subproj/WebDefaultUIDelegate.h:
WebView.subproj/WebDefaultUIDelegate.m: (+[WebDefaultUIDelegate sharedUIDelegate]): (-[WebDefaultUIDelegate dealloc]):
WebView.subproj/WebDefaultWindowOperationsDelegate.h: Removed.
WebView.subproj/WebDefaultWindowOperationsDelegate.m: Removed.
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
WebView.subproj/WebFrameView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebUIDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView setUIDelegate:]): (-[WebView UIDelegate]): (-[WebView downloadDelegate]):
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _UIDelegateForwarder]):
WebView.subproj/WebWindowOperationsDelegate.h: Removed.

WebBrowser:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.

Reviewed by Ken.

BrowserDocument.h:
BrowserDocument.m:
BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController dealloc]): (-[BrowserWebController close]):
ContextMenuHandler.h: Removed.
ContextMenuHandler.m:
WebBrowser.pbproj/project.pbxproj:

Tests:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.

Reviewed by Ken.

ChangeLog:
DumpBackForward/main.m: (main):
SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):

6:32 PM Changeset in webkit [4182] by hyatt

21 edits in trunk/WebCore

Rename inQuirksMode to inCompatMode. Drop uses of it in
the render tree code in favor of style()->htmlHacks().

Remove dead code in the parser dealing with discarded attributes.

Optimize bidi run justification by adding a guard.

Fix :target to not match :root when no fragment ID is specified.

Reviewed by mjs/gramps

khtml/css/cssstyleselector.cpp:
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):
khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls):
khtml/html/htmlparser.cpp: (KHTMLParser::~KHTMLParser): (KHTMLParser::reset): (KHTMLParser::parseToken): (KHTMLParser::insertNode):
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
khtml/rendering/bidi.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
khtml/rendering/render_inline.cpp:
khtml/rendering/render_inline.h:
khtml/rendering/render_list.cpp: (getParentOfFirstLineBox):
khtml/rendering/render_object.cpp: (RenderObject::createObject):
khtml/rendering/render_text.cpp: (RenderText::paintObject):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::recalcStyleSelector):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::createDecl):

6:24 PM Changeset in webkit [4181] by rjw

3 edits in trunk/WebKit

WebKit:

Final API review changes.

Reviewed by Chris.

BrowserWindowController.m: (-[BrowserWindowController updateSnapBackButtons]):
GlobalHistory.m: (-[GlobalHistory updateDisplayTitleForHistoryItem:]): (-[GlobalHistory _addHistoryEntry:toMenu:]):

WebBrowser:

Final API review changes.

History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem initFromDictionaryRepresentation:]):

6:03 PM Changeset in webkit [4180] by rjw

10 edits in trunk/WebKit

WebKit:

Final API review changes.

Reviewed by Chris.

History.subproj/WebBackForwardList.h:
History.subproj/WebBackForwardList.m: (-[WebBackForwardList containsItem:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList _setUsesPageCache:]): (-[WebBackForwardList _usesPageCache]):
History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (+[WebHistory optionalSharedHistory]): (+[WebHistory setOptionalSharedHistory:]): (-[WebHistory init]): (-[WebHistory loadFromURL:error:]): (-[WebHistory saveToURL:error:]):
History.subproj/WebHistoryItemPrivate.h:
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate init]): (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): (-[WebHistoryPrivate loadFromURL:error:]): (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): (-[WebHistoryPrivate saveToURL:error:]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]):

WebBrowser:

Final API review changes.

Reviewed by Chris.

BrowserDocument.m: (-[BrowserDocument backListMenuForButton:]): (-[BrowserDocument forwardListMenuForButton:]):
BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController clearPageCache]):
Debug/DebugUtilities.m: (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument validate_toggleBackForwardEnabled:]): (-[WebHistory populateHistoryWithTestData:]):
GlobalHistory.h:
GlobalHistory.m: (+[GlobalHistory historyURL]): (-[GlobalHistory init]): (-[GlobalHistory savePendingChanges]):

5:24 PM Changeset in webkit [4179] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Chris.

Update Challenge API to mostly match proposal, except for the
parts that can't be done until auth handling is moved from the
authentication handler to the connection delegate.

AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengePrivate initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:delegate:]): (-[NSURLAuthenticationChallengePrivate dealloc]): (-[NSURLAuthenticationChallenge _initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:delegate:]): (-[NSURLAuthenticationChallenge proposedCredential]): (-[NSURLAuthenticationChallenge cancel]): (-[NSURLAuthenticationChallenge error]): (-[NSURLAuthenticationChallenge failureResponse]):
AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage _invokeHandlersWithURL:realm:forRequest:failureCount:failureResponse:withCallback:context:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:proxy:forRequest:failureCount:failureResponse:withCallback:context:]): (-[NSURLCredentialStorage _addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:withCallback:context:]):
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]):

WebKit:

Reviewed by Chris.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Update for new Challenge API.

5:03 PM Changeset in webkit [4178] by cblu

10 edits
2 deletes in trunk/WebKit

WebFoundation:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse suggestedFilename]): (-[NSHTTPURLResponse suggestedFilename]):
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):

WebKit:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

Downloads.subproj/WebDownload.m: (-[WebDownload _createFileIfNecessary]):
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebNSURLResponseExtras.h: Removed.
Misc.subproj/WebNSURLResponseExtras.m: Removed.
Plugins.subproj/WebNullPluginView.m: include NSError to unbreak build.
WebKit.pbproj/project.pbxproj:

WebBrowser:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

BrowserDocument.m: (-[BrowserDocument displayName]):
BrowserWebController.m:
DownloadProgressEntry.m: (-[DownloadProgressEntry filename]):
English.lproj/StringsNotToBeLocalized.txt:
HTMLSourceDocument.m: (-[HTMLSourceDocument displayName]):

4:18 PM Changeset in webkit [4177] by cblu

12 edits
3 deletes in trunk/WebKit

WebKit:

Removed WebPluginError and instead added fields to the userInfo of NSError for plug-in specific errors.

Reviewed by rjw.

Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):
Misc.subproj/WebKitErrorsPrivate.h:
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
Plugins.subproj/WebNullPluginView.h:
Plugins.subproj/WebNullPluginView.m:
Plugins.subproj/WebPlugInError.h: Removed.
Plugins.subproj/WebPlugInError.m: Removed.
Plugins.subproj/WebPluginErrorPrivate.h: Removed.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURLString:]):
WebKit.exp:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
WebView.subproj/WebResourceLoadDelegate.h:

WebBrowser:

Updated WebBrowser to not use WebPlugInError.

Reviewed by rjw.

LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):

1:27 PM Changeset in webkit [4176] by darin

11 edits in trunk

WebCore:

Reviewed by Chris.

fixed 3210096 -- server identifies page as UTF-8, page identifies itself as windows-1252, server must win
fixed 3105796 -- www.thai.com does not display with correct encoding (<body> tag in comment before <meta>)

khtml/khtml_part.cpp: (KHTMLPart::write): Pass in an EncodingType rather than just a boolean. This lets us tell the difference between EncodingFromHTTPHeader (which wins out over an encoding in a meta tag) and DefaultEncoding (which loses). (KHTMLPart::setEncoding): Put ifdef around the whole function. We use our own version in KWQKHTMLPart instead.

khtml/misc/decoder.h: Defined an EncodingType and changed the parameter to setEncoding to take it instead of force and 8-bit-only parameters. Store it in m_type and get rid of haveEncoding.
khtml/misc/decoder.cpp: (Decoder::Decoder): Set m_type to DefaultEncoding. (Decoder::setEncoding): Take a type parameter, instead of force and 8-bit-only parameters. Use "eight-bit-only" mode for EncodingFromMetaTag only. Fix code so we don't clobber an existing codec if we can't find a new one in a simpler way. Store the type in m_type, rather than using the confusing "haveEncoding" flag. (skipComment): Added. Used to skip comments found in the <head> section. (Decoder::decode): Moved the check for the UTF-16 BOM out and do that check even when we have an encoding (although not if we have one the user chose). Update check so that we look for a meta tag when we have nothing except a default encoding. This fixes the bug where we have an encoding from an HTTP header; in that case we do not want to look at the meta tag. Improve performance a bit by not constructing a string just so we can append the data. Merged the APPLE_CHANGES case a bit with the original case better. Added code to skip comments; this fixes the thai.com issue. Improved the code to handle data after the first buffer full. We now avoid putting data into a QString once we are past the header. Extended an APPLE_CHANGES ifdef to exclude more code we don't need.

kwq/KWQKHTMLPart.h: Added setEncoding and addData to replace slotData.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setEncoding): Added. Needs to be called only once and does the first-time work as well as setting up the encoding for the page. In practice it is called before each time addData is. (KWQKHTMLPart::addData): Added. Needs to be called for each run of data. Now just calls write(), but does some assertions, which is why I have not removed it and changed the bridge to call write().

kwq/WebCoreBridge.h: Replaced the old addData:withEncoding: and addData:withOverrideEncoding: with setEncoding:userChosen: and addData:.
kwq/WebCoreBridge.mm: (-[WebCoreBridge setEncoding:userChosen:]): Call setEncoding on the part. (-[WebCoreBridge addData:]): Call addData on the part.

WebKit:

Reviewed by Chris.

fixed 3210096 -- server identifies page as UTF-8, page identifies itself as windows-1252, server must win

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Change for new WebCore API. Pass the encoding in a separate setEncoding call rather than as a parameter in addData. Also don't handle default encoding here any more. Default encoding is now handled the same way all the other preferences are, in a way that works better on the WebCore side anyway; nil or empty string means use the default encoding.

11:21 AM Changeset in webkit [4175] by kocienda

45 edits in trunk/WebKit

top level:

Reviewed by Darin

Added a configure test for checking OS version. Used
to figure out what exports to use for WebFoundation.

configure.in

Tests:

Reviewed by Darin

Changed WebError to NSError.

Changed call to errorDescription to localizedDescription to match
new NSError API.

Unrelated change to fix build breakage in PDFRepresentation. It seems
that WebDocumentRepresentation changed but this test was not updated.

DumpBackForward/main.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
DumpRenderTree/main.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
PDFViewer/DocumentController.m: (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
PDFViewer/PDFRepresentation.m: (-[PDFRepresentation receivedError:withDataSource:]): (-[PDFView menuForEvent:]): (-[PDFView viewWillMoveToHostWindow:]): (-[PDFView viewDidMoveToHostWindow]):
SimpleViewer/DocumentController.m: (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
SnippetEditor/SnippetController.h:
SnippetEditor/SnippetController.m: (-[SnippetController receivedError:]): (-[SnippetController webView:locationChangeDone:forDataSource:]):

WebFoundation:

Reviewed by Darin

Changed WebError to NSError.

Removed WebFoundation.exp. File with this name is now generated and
is listed in .cvsignore.

Added build mojo to handle making the correct exports for the
framework based on whether we are running on Jaguar or Panther
(or later). If we are on Jaguar, we need to export the NSError
class we build and include in the framework. Also note that
there is build mojo that works both for our local builds and
for B&I builds.

.cvsignore:
AuthenticationManager.subproj/NSURLCredentialStorage.m:
CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _sendDidFailLoadingCallback]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didFailWithError:]): (-[NSURLConnection _setError:]): (-[NSURLConnectionInternal URLProtocol:didFailWithError:]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLResponse.h:
CacheLoader.subproj/NSURLResponse.m:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate error]):
ChangeLog:
English.lproj/StringsNotToBeLocalized.txt:
Makefile.am:
Misc.subproj/NSError.h: Added.
Misc.subproj/NSError.m: Added. (-[NSError initWithDomain:code:userInfo:]): (+[NSError errorWithDomain:code:userInfo:]): (-[NSError code]): (-[NSError domain]): (-[NSError userInfo]): (-[NSError localizedDescription]): (-[NSError description]): (-[NSError copyWithZone:]): (-[NSError encodeWithCoder:]): (-[NSError initWithCoder:]):
Misc.subproj/WebError.h:
Misc.subproj/WebError.m: (-[WebError errorDescription]):
Misc.subproj/WebFoundation.h:
Misc.subproj/WebNSErrorConstants.h: Added.
Misc.subproj/WebNSErrorExtras.h: Added.
Misc.subproj/WebNSErrorExtras.m: Added. (WebNSErrorExtrasInit): (+[NSError _web_addErrorsWithCodesAndDescriptions:inDomain:]): (+[NSError _web_errorWithDomain:code:failingURL:]): (-[NSError _web_initWithDomain:code:failingURL:]): (-[NSError _web_errorIsInDomain:]): (-[NSError _web_localizedDescription]): (-[NSError _web_failingURL]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoading]):
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol cachedResponseRevalidated]): (-[WebHTTPProtocol failWithError:]): (-[WebHTTPProtocol determineTransferEncoding]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _continueLoadingWithAddressInfo]): (-[WebSimpleHTTPProtocol hostNameResolved:]): (-[WebSimpleHTTPProtocol _processRawData]): (-[WebSimpleHTTPProtocol _handleLoadCallback]): (-[WebSimpleHTTPProtocol failWithError:]):
WebFoundation-base.exp: Added.
WebFoundation-jaguar.exp: Added.
WebFoundation.exp: Removed.
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebError to NSError

Downloads.subproj/WebDownload.h:
Downloads.subproj/WebDownload.m: (-[WebDownload connection:didReceiveData:]): (-[WebDownload connectionDidFinishLoading:]): (-[WebDownload connection:didFailLoadingWithError:]): (-[WebDownload _decodeData:]): (-[WebDownload _writeDataForkData:resourceForkData:]): (-[WebDownload _didCloseFile:]): (-[WebDownload _cancelWithError:]): (-[WebDownload _errorWithCode:]): (CloseCompletionCallback):
English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader connection:didFailLoadingWithError:]):
Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): (registerErrors):
Misc.subproj/WebKitErrorsPrivate.h:
Plugins.subproj/WebNetscapePluginRepresentation.h:
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
Plugins.subproj/WebPlugInError.h:
Plugins.subproj/WebPlugInError.m:
WebCoreSupport.subproj/WebBridge.m:
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
WebKit.exp:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]): (-[WebBaseResourceHandleDelegate cancelledError]):
WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _setMainDocumentError:]): (-[WebDataSource _receivedError:complete:]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _mainDocumentError]):
WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate webView:locationChangeDone:forDataSource:]):
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebFrame.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]):
WebView.subproj/WebFrameView.m:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedError:withDataSource:]):
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation receivedError:withDataSource:]):
WebView.subproj/WebLocationChangeDelegate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient interruptForPolicyChangeError]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebResourceDelegateProxy connection:didFailLoadingWithError:]):
WebView.subproj/WebPolicyDelegate.h:
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation receivedError:withDataSource:]):
WebView.subproj/WebView.h:
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _receivedError:fromDataSource:]): (-[WebView _mainReceivedError:fromDataSource:complete:]):

WebBrowser:

Reviewed by Darin

Changed WebError to NSError.

BrowserDocument.m:
BrowserWebController.m: (-[BrowserWebController webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]):
BugReportController.m: (-[BugReportController connection:didFailLoadingWithError:]):
Debug/SnippetController.m: (-[SnippetController webView:locationChangeDone:forDataSource:]):
DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]): (-[DownloadMonitor download:didFailDownloadingWithError:]): (-[DownloadMonitor cancelDownload:withError:]): (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]):
DownloadProgressEntry.m: (-[DownloadProgressEntry dictionaryRepresentation]): (-[DownloadProgressEntry stop]):
DownloadRow.m:
FrameProgressEntry.h:
FrameProgressEntry.m: (-[FrameProgressEntry _setCommittedError:]): (-[FrameProgressEntry _setProvisionalError:]): (-[FrameProgressEntry setError:forDataSource:]): (-[FrameProgressEntry error]): (-[FrameProgressEntry URL]): (-[FrameProgressEntry _urlStringForTitle]):
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor setError:forDataSource:]): (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
LocationChangeError.h:
LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler genericTitleForError:]): (-[LocationChangeHandler genericMessageForError:]): (-[LocationChangeHandler displayLocationChangeError:forDataSource:]):
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
ResourceProgressEntry.h:
ResourceProgressEntry.m: (+[ResourceProgressEntry entryWithURLString:bytesLoaded:bytesExpected:error:parent:]): (-[ResourceProgressEntry initWithURLString:bytesLoaded:bytesExpected:error:parent:]): (-[ResourceProgressEntry error]): (-[ResourceProgressEntry setError:]): (-[ResourceProgressEntry stage]):
WebBookmarkImporter.h:
WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): (-[WebBookmarkImporter error]):
WebBrowser.pbproj/project.pbxproj:

11:13 AM Changeset in webkit [4174] by darin

19 edits
1 delete in trunk

WebCore:

Reviewed by John.

improved the text encoding database

kwq/mac-encodings.txt: Changed to a new format. Now the first encoding name in every list is the "canonical" one and is in canonical case and punctuation (no longer requiring lowercase). Since the first is the one that will be used outgoing to send to servers, it's good to have that one in canonical form. All subsequent aliases in the list are now required to be all lowercase and not use any punctuation. Since the comparison is done ignoring non-alphanumeric characters, and ignoring case, this will have no effect on which encodings are recognized.

kwq/make-charset-table.pl: Updated to enforce the new format rules.

kwq/KWQCharsetData.c: Regenerated.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Simplify the "change commas to spaces" code in a way that lets us get rid of APPLE_CHANGES. Use the official "ISO-8859-1" here instead of something almost, but not quite, like it.
kwq/KWQKCharsets.mm: (KCharsets::codecForName): Use the official "ISO-8859-1" here instead of the unofficial "latin1". Unimportant, but cleaner this way.

preparation for some text encoding changes to fix some bugs

kwq/KWQKHTMLSettings.h: Added an encoding value rather than always returning a hardcoded value. Other minor cleanup.
kwq/KWQKHTMLSettings.mm: Removed.
WebCore.pbproj/project.pbxproj: Removed KWQKHTMLSettings.mm.

other changes

kwq/KWQKHTMLPart.h: Removed "using" statement. Headers must not pollute the namespace by doing "using".
khtml/khtml_part.cpp: Added a "using" here.
kwq/KWQPageState.mm: Added a "using" here.

kwq/KWQString.h: Added an append that takes a const char * and length for use by the decoder.
kwq/KWQString.mm: (QString::append): Implemented it.

kwq/WebCoreSettings.h: Added default text encoding field and methods.
kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]): Release defaultTextEncoding. (-[WebCoreSettings setDefaultTextEncoding:]): Added. (-[WebCoreSettings defaultTextEncoding]): Added.

WebKit:

Reviewed by John.

WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Added a call to the new setDefaultTextEncoding: method in WebCore. A preparation step for some encoding bug fixes.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSuperviewObservers]): Improved a comment.

10:38 AM Changeset in webkit [4173]

3 copies in tags/Safari-75-1

This commit was manufactured by cvs2svn to create tag 'Safari-75-1'.

10:38 AM Changeset in webkit [4172]

3 copies in tags/Safari-75

This commit was manufactured by cvs2svn to create tag 'Safari-75'.

10:38 AM Changeset in webkit [4171] by sheridan

3 edits in trunk

Safari-76u; tree's open

10:37 AM Changeset in webkit [4170] by sheridan

8 edits in trunk

Safari-75 version stamp

10:19 AM Changeset in webkit [4169] by sheridan

3 edits in trunk

Safari-75u; tree's open

9:47 AM Changeset in webkit [4168]

3 copies in tags/Safari-74

This commit was manufactured by cvs2svn to create tag 'Safari-74'.

9:47 AM Changeset in webkit [4167] by sheridan

8 edits in trunk

Safari-74 version stamps

9:17 AM Changeset in webkit [4166] by sullivan

3 edits in trunk/WebCore

fixed 3151501 -- Toggling "Check Spelling As You Type" in a textarea should affect future textareas

Reviewed by Darin

kwq/KWQTextArea.mm: (+[KWQTextAreaTextView _setContinuousSpellCheckingEnabledForNewTextAreas:]): new method, sets a static variable and an NSUserDefault (+[KWQTextAreaTextView _isContinuousSpellCheckingEnabledForNewTextAreas]): new method, checks a static variable, reading it from an NSUserDefault the first time (-[KWQTextAreaTextView initWithFrame:textContainer:]): override designated initializer to set continuous spell checking if appropriate (-[KWQTextAreaTextView setContinuousSpellCheckingEnabled:]): call _setContinuousSpellCheckingEnabledForNewTextAreas in addition to setting the value for this object

8:00 AM Changeset in webkit [4165] by darin

2 edits in trunk/WebKit

Reviewed by Ken and Darin.

Fixed an authentication crashing bug that crept into the last few
changes, plus a typo.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Remove extra space. (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Store the challenge properly.

Apr 23, 2003:

10:36 PM Changeset in webkit [4164] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Revised NSURLCredential to fully comply with proposal.

AuthenticationManager.subproj/NSURLCredential.h:
AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredentialPrivate dealloc]): (-[NSURLCredential initWithUser:password:persistence:]): (+[NSURLCredential URLCredentialWithUser:password:persistence:]): (-[NSURLCredential dealloc]): (-[NSURLCredential user]): (-[NSURLCredential password]): (-[NSURLCredential hasPassword]): (-[NSURLCredential persistence]): (-[NSURLCredential copyWithZone:]): (-[NSURLCredential description]):
AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage _usernameForRealm:URL:]): (-[NSURLCredentialStorage _removePasswordForRealm:URL:]): (-[NSURLCredentialStorage _proxyUsernameForURL:]): (-[NSURLCredentialStorage _removeProxyPasswordForURL:]): (-[NSURLCredentialStorage _setDefaultUserInfoFromURL:]): (-[NSURLCredentialStorage NSURLAuthenticationChallenge:useCredential:]): (-[NSURLCredentialStorage _applyHTTPProxyCredentials:]): (-[NSURLCredentialStorage _applyHTTPCredentials:]):
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _addCredential:forProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredential initWithKeychainItem:]): (+[WebKeychainCredential credentialWithKeychainItem:]): (-[WebKeychainCredential hasPassword]):

WebKit:

Reviewed by Darin.

Adjusted for NSURLCredential changes.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

WebBrowser:

Reviewed by Darin.

Adjusted for NSURLCredential changes.

FormCompletionController.m: (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]): (stringFromMatch): (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): (+[FormCompletionController credentialIsNeverSaveMarker:]):
Preferences.subproj/PasswordsEditor.m: (compareCredentials): (-[PasswordsEditor tableView:objectValueForTableColumn:row:]):

2:41 PM Changeset in webkit [4163] by cblu

2 edits in trunk/WebKit

WebKit:

Reviewed by darin.

English.lproj/StringsNotToBeLocalized.txt: updated

WebBrowser:

Fixed: 3190961 - Adobe's "Download Manager Instructions" file deemed unsafe by Safari, so not opened

Reviewed by darin.

English.lproj/StringsNotToBeLocalized.txt:
Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): open the file if its application's id is "com.adobe.ESD.helperapp"

1:36 PM Changeset in webkit [4162] by cblu

2 edits in trunk/WebKit

Fixed: 3161374 - safari windows don't allow text/URL dragging on the first click

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionEvent:]): new, determines if the event occurred over the selection (-[WebHTMLView acceptsFirstMouse:]): newly implemented, return result of _isSelectionEvent: (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): newly implemented, return result of _isSelectionEvent:

11:03 AM Changeset in webkit [4161] by cblu

6 edits in trunk/WebKit

WebKit:

Renamed the policy delegate methods.

Reviewed by john.

WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]): (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient checkContentPolicyForResponse:]):
WebView.subproj/WebPolicyDelegate.h:

WebBrowser:

Updated WebBrowser to the renamed WebPolicyDelegate methods.

Reviewed by john.

BrowserWebController.m: (-[BrowserWebController webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController decidePolicyForAction:request:frame:newFrameName:decisionListener:]): (-[BrowserWebController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): (-[BrowserWebController webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):

10:24 AM Changeset in webkit [4160] by darin

11 edits in trunk/WebCore

Reviewed by Ken.

fixed 3237301 -- REGRESSION: text fields with size greater than maxlength are sized according to maxlength

kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Override the maximum length for this operation.

fixed 3236961 -- setting innerHTML with input elements doesn't set up value properly

To fix this, I rolled in the changes from the trunk of KHTML development that get rid of
the init() function and do the work in either attach() or insertedIntoDocument() instead.

khtml/html/html_baseimpl.h: Removed init overrides, added insertedIntoDocument override.
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Moved HTMLBodyElementImpl::init code here. (HTMLFrameElementImpl::attach): Moved HTMLFrameElementImpl::init code here. (HTMLFrameSetElementImpl::attach): Moved HTMLFrameSetElementImpl::init code here.

khtml/html/html_formimpl.h: Added m_inited flag, removed init overrides, removed unused m_encCharset field.
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Removed code that set m_encCharset. (HTMLFormElementImpl::setEnctype): Removed code that set m_encCharset. (HTMLInputElementImpl::HTMLInputElementImpl): Initialize m_inited to false. (HTMLInputElementImpl::attach): Moved HTMLInputElementImpl::init code here, guarded by m_inited. (HTMLSelectElementImpl::attach): Moved HTMLSelectElementImpl::init code here. (HTMLTextAreaElementImpl::attach): Moved HTMLTextAreaElementImpl::init code here.

khtml/xml/dom_nodeimpl.h: Removed init.
khtml/xml/dom_nodeimpl.cpp: Removed init.

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Removed calls to init.
khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): Removed call to init. (XMLHandler::startCDATA): Removed call to init. (XMLHandler::exitText): Removed call to init.

Apr 22, 2003:

6:10 PM Changeset in webkit [4159]

20 copies in tags/Safari-73~4

This commit was manufactured by cvs2svn to create tag 'Safari-73~4'.

6:10 PM Changeset in webkit [4158] by mjs

5 edits in branches/Safari-73~1-branch

Bump versions to 1.0.

5:30 PM Changeset in webkit [4157] by mjs

8 edits in branches/Safari-73~1-branch

Safari-73.4

5:09 PM Changeset in webkit [4156] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Ken.

Improved List pool for 3% speed improvement on cvs-js-ibench

kjs/list.cpp: Replaced the roving cursor with a free list and raised the high water mark to 384.

5:03 PM Changeset in webkit [4155] by darin

6 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3158411 -- radio button groups are per-form in WebCore, per-page in other browsers (flyglobespan.com)

khtml/html/html_formimpl.h: Removed radioClicked. Made setName virtual and make HTMLInputElementImpl override it. Added isCheckedRadioButtonForDocument, addCheckedRadioButtonToDocument, and removeCheckedRadioButtonFromDocument.
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::~HTMLInputElementImpl): Call removeCheckedRadioButtonFromDocument. (HTMLInputElementImpl::setType): Call removeCheckedRadioButtonFromDocument before changing the type and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::parseAttribute): Call removeCheckedRadioButtonFromDocument before changing ATTR_NAME and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::setChecked): Call removeCheckedRadioButtonFromDocument before changing the checked state and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::setName): Call removeCheckedRadioButtonFromDocument before changing the name and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::isCheckedRadioButtonForDocument): Added. Checks if this element should be the one known to the document. (HTMLInputElementImpl::addCheckedRadioButtonToDocument): Call addCheckedRadioButton on the document if isCheckedRadioButtonForDocument returns true. (HTMLInputElementImpl::removeCheckedRadioButtonFromDocument): Call removeCheckedRadioButtonFromDocument on the document if isCheckedRadioButtonForDocument returns true.

khtml/xml/dom_docimpl.h: Add addCheckedRadioButton, removeCheckedRadioButton, and m_checkedRadioButtons.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::addCheckedRadioButton): Uncheck the old radio button with this name, if any. Store the new radio button in the "checked radio buttons" map. (DocumentImpl::removeCheckedRadioButton): Remove the radio button from the map.

4:48 PM Changeset in webkit [4154] by kocienda

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Updated to use API-approved methods for accessing
protocol-specific URL request data.

Changed use of NSURLProtocol registeredClasses method to
_registeredClasses to reflect that that this method
is no longer API, but is available as SPI.

CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol propertyForKey:inRequest:]): (+[NSURLProtocol setProperty:forKey:inRequest:]): (+[NSURLProtocol _registeredClasses]):
CacheLoader.subproj/NSURLProtocolPrivate.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequestInternal dealloc]): (-[NSURLRequest hash]): (-[NSURLRequest isEqual:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _propertyForKey:]): (-[NSURLRequest _setProperty:forKey:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _parametersForReading]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest HTTPAllHeaderFields]): (-[NSURLRequest HTTPValueForHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest HTTPAllowSSLCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSMutableURLRequest _parametersForWriting]): (-[NSMutableURLRequest HTTPSetMethod:]): (-[NSMutableURLRequest HTTPSetAllHeaderFields:]): (-[NSMutableURLRequest HTTPSetValue:forHeaderField:]): (-[NSMutableURLRequest HTTPAddValue:forHeaderField:]): (-[NSMutableURLRequest HTTPSetBody:]): (-[NSMutableURLRequest HTTPSetAllowSSLCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest HTTPSetCookiePolicyBaseURL:]): (-[NSMutableURLRequest HTTPSetExtraCookies:]): (-[NSMutableURLRequest HTTPSetPageNotFoundCacheLifetime:]): (-[NSHTTPURLRequestRequestParameters copyWithZone:]): (-[NSHTTPURLRequestRequestParameters mutableCopyWithZone:]):
CacheLoader.subproj/NSURLRequestPrivate.h:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Updated to use API-approved methods for accessing
protocol-specific URL request data.

WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForReading]): (-[NSURLRequest _webDataRequestParametersForWriting]):

WebBrowser:

Reviewed by Darin

Changed use of NSURLProtocol registeredClasses method to
_registeredClasses to reflect that that this method
is no longer API, but is available as SPI.

Debug/DebugUtilities.m: (initProtocolHandlers):

11:54 AM Changeset in webkit [4153] by mjs

6 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Adjusted for class renames.

AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengePrivate initWithProtectionSpace:defaultUsername:previousFailureCount:delegate:]): (-[NSURLAuthenticationChallengePrivate dealloc]): (-[NSURLAuthenticationChallenge _initWithProtectionSpace:defaultUsername:previousFailureCount:delegate:]): (-[NSURLAuthenticationChallenge _authenticationHandlerBusy]): (-[NSURLAuthenticationChallenge init]): (-[NSURLAuthenticationChallenge dealloc]): (-[NSURLAuthenticationChallenge protectionSpace]): (-[NSURLAuthenticationChallenge defaultUsername]): (-[NSURLAuthenticationChallenge previousFailureCount]): (-[NSURLAuthenticationChallenge useCredential:]): (-[NSURLAuthenticationChallenge cancel]):
AuthenticationManager.subproj/NSURLCredential.h:
AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredential initWithUsername:password:remembered:]): (+[NSURLCredential credentialWithUsername:password:remembered:]): (-[NSURLCredential copyWithZone:]):
AuthenticationManager.subproj/NSURLCredentialStorage.h:
AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLAuthenticationChallengeState initWithHandlersCopy:index:httpRequest:challenge:callback:context:]): (-[NSURLAuthenticationChallengeState dealloc]): (-[NSURLCredentialStoragePrivate init]): (-[NSURLCredentialStoragePrivate dealloc]): (-[NSURLCredentialStorage dealloc]): (-[NSURLCredentialStorage init]): (initSharedCredentialStorage): (initCredentialStorage): (_credentialStorage): (+[NSURLCredentialStorage sharedCredentialStorage]): (-[NSURLCredentialStorage addAuthenticationHandler:]): (-[NSURLCredentialStorage removeAuthenticationHandler:]): (-[NSURLCredentialStorage credentialsForProtectionSpace:]): (-[NSURLCredentialStorage addCredential:forProtectionSpace:]): (-[NSURLCredentialStorage removeCredential:forProtectionSpace:]): (-[NSURLCredentialStorage defaultCredentialForProtectionSpace:]): (-[NSURLCredentialStorage setDefaultCredential:forProtectionSpace:]): (-[NSURLCredentialStorage _internalInit]): (-[NSURLCredentialStorage _usernameForRealm:URL:]): (-[NSURLCredentialStorage _removePasswordForRealm:URL:]): (-[NSURLCredentialStorage _proxyUsernameForURL:]): (-[NSURLCredentialStorage _removeProxyPasswordForURL:]): (-[NSURLCredentialStorage _realmForURL:]): (-[NSURLCredentialStorage _setRealm:forURL:]): (-[NSURLCredentialStorage _proxyProtectionSpaceForURL:]): (-[NSURLCredentialStorage _setDefaultUserInfoFromURL:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:realm:forRequest:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:proxy:forRequest:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _tryChallenge:]): (-[NSURLCredentialStorage _retryWaitingChallenges]): (-[NSURLCredentialStorage NSURLAuthenticationChallenge:useCredential:]): (-[NSURLCredentialStorage NSURLAuthenticationChallengeCancel:]): (-[NSURLCredentialStorage NSURLAuthenticationChallengeAuthenticationHandlerBusy:]): (-[NSURLCredentialStorage _applyHTTPProxyCredentials:]): (-[NSURLCredentialStorage _applyHTTPCredentials:]): (-[NSURLCredentialStorage _addCredentialsToInitialHTTPRequest:]): (-[NSURLCredentialStorage _checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[NSURLCredentialStorage _addCredentialsToRetryHTTPRequest:afterFailureResponse:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _cancelAddCredentialsToRetryHTTPRequest:]): (-[NSURLCredentialStorage _haveCredentialForURL:]):
AuthenticationManager.subproj/NSURLProtectionSpace.h:
AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpace _internalInit]): (-[NSURLProtectionSpace copyWithZone:]): (-[NSURLProtectionSpace isEqual:]):
AuthenticationManager.subproj/WebAuthenticationHandler.h:
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h:
AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher NSURLAuthenticationChallenge:useCredential:]): (-[WebAuthenticationHandlerDispatcher NSURLAuthenticationChallengeAuthenticationHandlerBusy:]): (-[WebAuthenticationHandlerDispatcher _dispatchCancelAuthentication:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationHandlerBusy:]): (-[WebAuthenticationHandlerDispatcher initWithAuthenticationHandler:]): (-[WebAuthenticationHandlerDispatcher dealloc]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]): (-[WebAuthenticationHandlerDispatcher cancelAuthentication:]):
AuthenticationManager.subproj/WebAuthenticationManagerCallback.h:
AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
AuthenticationManager.subproj/WebCredentialStorage.h:
AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _addCredential:forProtectionSpace:]): (-[WebCredentialStorage _rootSpaceForProtectionSpace:]): (-[WebCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _secProtocolForProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage credentialsForProtectionSpace:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage defaultCredentialForProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
AuthenticationManager.subproj/WebKeychainCredential.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol stopLoading]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):
WebFoundation.exp:

WebKit:

Reviewed by Darin.

Renamed classes to match API document.

Panels.subproj/WebAuthenticationPanel.h:
Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
Panels.subproj/WebPanelAuthenticationHandler.h:
Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler init]): (-[WebPanelAuthenticationHandler dealloc]): (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler cancelAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):

WebBrowser:

Reviewed by Darin.

Adjusted for class renames.

AppController.m: (-[AppController removeAllCredentials]):
BookmarksViewController.m: (+[BookmarksViewController autoTabColumnTitle]):
FormCompletionController.h:
FormCompletionController.m: (protectionSpaceFromFrame): (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]): (stringFromMatch): (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): (+[FormCompletionController credentialIsNeverSaveMarker:]): (-[FormCompletionController reflectSelectedRow]):
Preferences.subproj/PasswordsEditor.h:
Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor protectionSpaceForCredential:]): (-[PasswordsEditor addressStringForCredential:]): (compareCredentials): (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]): (-[PasswordsEditor tableView:objectValueForTableColumn:row:]):

11:30 AM Changeset in webkit [4152] by darin

9 edits in trunk/WebCore

Reviewed by John.

fixed 3144966 -- problems typing in form at http://www.mobile.att.net/messagecenter

The bug was that doing a focus would always select the entire contents of the field.
While this behavior does match Mozilla's behavior for text fields, it doesn't match
WinIE; we're going to imitate WinIE and not do it. Also fix the same issue for text areas.

kwq/KWQTextField.h: Add lastSelectedRange field.
kwq/KWQTextField.mm: (-[KWQTextField initWithFrame:]): Initialize lastSelectedRange (to nothing). (-[KWQTextField initWithQLineEdit:]): Use [self init] instead of [super init]. The same thing, but you should never call [super xxx] where xxx is a non-designated initializer of the superclass. (-[KWQTextField currentEditorForEitherField]): Added. Returns the current editor of either the text field or the secure text field. (-[KWQTextField selectedRange]): Added. (-[KWQTextField setSelectedRange:]): Added. (-[KWQTextField controlTextDidEndEditing:]): Store the selected text range in the lastSelectedRange variable, so it can be used later. Also move the code that sends the FocusOut event here. (-[KWQTextField control:textShouldBeginEditing:]): Do the "scroll frame into view" here isntead of in becomeFirstResponder so it can be shared. (-[KWQTextField control:textShouldEndEditing:]): Moved FocusOut to controlTextDidEndEditing:. (-[KWQTextField didBecomeFirstResponder]): Added. Sets the selected range back to what it was in textShouldEndEditing, but only if we are not tabbing into the field. If we don't set the selected range, then we inherit the behavior from NSTextField, all text selected. We can't do the selected range work in textDidEndEditing because that's called too early. (-[KWQTextField becomeFirstResponder]): Call didBecomeFirstResponder. (-[KWQSecureTextField currentEditorForSecureField]): Added. Factored out of selectText:. (-[KWQSecureTextField selectText:]): Use currentEditorForSecureField for clarity. (-[KWQSecureTextField becomeFirstResponder]): Call didBecomeFirstResponder.

kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Rearrange a bit. (-[KWQTextArea setWordWrap:]): Ditto. (-[KWQTextAreaTextView becomeFirstResponder]): Only do the selectAll: operation here if we are tabbing into the field. Otherwise keep the selection from last time.

khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Don't do the whole "save cursor position, set text, restore cursor position" dance for the case where the field already has the correct contents. Without this change, selections can be collapsed to an insertion point at the start of the selection at seemingly random times.

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't deselect the currently focused node on mouse down. This created a symptom where a text field would lose focus when you clicked on a button.

kwq/KWQLineEdit.h: Remove unused frame() method.
kwq/KWQLineEdit.mm: Remove unused, unimplemented frame() method.

6:56 AM Changeset in webkit [4151] by kocienda

6 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

API changes in NSURLProtocol and its subclasses:

+canHandleURL: becomes +canInitWithRequest:
+canonicalURLForURL: becomes +canonicalRequestForRequest:
_protocolClassForURL: becomes _protocolClassForRequest:

Some other related changes include:

These two methods added to NSURLRequest SPI:
-(id)_copyReplacingURLWithURL:(NSURL *)URL;
-(BOOL)_URLHasScheme:(NSString *)scheme;

_web_canonicalize: method in NSURL extras has been updated
to work with new canonicalization scheme.

The process of canonicalizing URLs no longer unconditionally
makes a new URL. There is now additional smarts that checks
a URL before making a new one based on whether or not the
input URL is already in canonical form.

CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]): (-[NSURLConnection _beginLoad]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol canInitWithRequest:]): (+[NSURLProtocol canonicalRequestForRequest:]): (+[NSURLProtocol registerClass:]): (+[NSURLProtocol _protocolClassForRequest:]): (+[NSURLProtocol _makeRequestCanonicalByMakingRequestURLCanonical:]):
CacheLoader.subproj/NSURLProtocolPrivate.h:
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _URLHasScheme:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest _copyReplacingURLWithURL:]):
CacheLoader.subproj/NSURLRequestPrivate.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_canonicalize]):
ProtocolHandlers.subproj/WebAboutProtocol.m: (+[WebAboutProtocol canInitWithRequest:]): (+[WebAboutProtocol canonicalRequestForRequest:]): (+[WebAboutProtocol _canonicalURLForURL:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (+[WebCFNetworkHTTPProtocol canInitWithRequest:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (+[WebFTPProtocol canInitWithRequest:]): (+[WebFTPProtocol canonicalRequestForRequest:]): (+[WebFTPProtocol _canonicalURLForURL:]):
ProtocolHandlers.subproj/WebFileProtocol.m: (+[WebFileProtocol canInitWithRequest:]): (+[WebFileProtocol canonicalRequestForRequest:]): (+[WebFileProtocol _canonicalURLForURL:]):
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.m: (+[WebHTTPProtocol canonicalRequestForRequest:]): (+[WebHTTPProtocol _canonicalURLForURL:]): (-[WebHTTPProtocol URL]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):

WebKit:

Reviewed by Darin

API changes in NSURLProtocol and its subclasses:

+canHandleURL: becomes +canInitWithRequest:
+canonicalURLForURL: becomes +canonicalRequestForRequest:

Added new _webIsDataProtocolURL: helper method.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (+[WebDataProtocol _webIsDataProtocolURL:]): (+[WebDataProtocol canInitWithRequest:]): (+[WebDataProtocol canonicalRequestForRequest:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]):

Apr 21, 2003:

9:54 PM Changeset in webkit [4150] by darin

2 edits in trunk/WebKit

Plugins.subproj/WebNetscapePluginStream.m: Removed unnecessary #import of <WebFoundation/WebFoundation.h>.

7:12 PM Changeset in webkit [4149] by mjs

4 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard.

Renamed headers and implementation files for new auth API.

AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
AuthenticationManager.subproj/NSURLAuthenticationChallenge.m:
AuthenticationManager.subproj/NSURLCredential.h:
AuthenticationManager.subproj/NSURLCredential.m:
AuthenticationManager.subproj/NSURLCredentialStorage.h:
AuthenticationManager.subproj/NSURLCredentialStorage.m:
AuthenticationManager.subproj/NSURLProtectionSpace.h:
AuthenticationManager.subproj/NSURLProtectionSpace.m:
AuthenticationManager.subproj/WebAuthenticatingResource.h: Removed.
AuthenticationManager.subproj/WebAuthenticatingResource.m: Removed.
AuthenticationManager.subproj/WebAuthenticationHandler.h:
AuthenticationManager.subproj/WebAuthenticationManager.h: Removed.
AuthenticationManager.subproj/WebAuthenticationManager.m: Removed.
AuthenticationManager.subproj/WebAuthenticationManagerCallback.h:
AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
AuthenticationManager.subproj/WebAuthenticationRequest.h: Removed.
AuthenticationManager.subproj/WebAuthenticationRequest.m: Removed.
AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
AuthenticationManager.subproj/WebAuthenticationResult.h: Removed.
AuthenticationManager.subproj/WebCredential.h: Removed.
AuthenticationManager.subproj/WebCredential.m: Removed.
AuthenticationManager.subproj/WebCredentialStorage.h:
AuthenticationManager.subproj/WebCredentialStorage.m:
AuthenticationManager.subproj/WebKeychainCredential.h:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Richard.

Updated for file renames.

Panels.subproj/WebAuthenticationPanel.h:
Panels.subproj/WebPanelAuthenticationHandler.h:
Panels.subproj/WebStandardPanels.m:

WebBrowser:

Reviewed by Richard.

Updated for file renames.

AppController.m:
FormCompletionController.m:
Preferences.subproj/PasswordsEditor.m:

4:45 PM Changeset in webkit [4148] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed bug 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::setType): Implement; loosen rule about what type changes are allowed. (HTMLInputElementImpl::parseAttribute): Call setType for ATTR_TYPE.

unrelated tweak

kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Use a macro here to make it a little easier to add items.

1:45 PM Changeset in webkit [4147] by cblu

3 edits in trunk

WebCore:

Fixed previous "Reviewed by".

ChangeLog:

WebKit:

Fixed previous "Reviewed by".

ChangeLog:

11:49 AM Changeset in webkit [4146] by cblu

8 edits in trunk

WebCore:

Use renamed plug-in view methods.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
kwq/WebCoreBridge.h:

WebKit:

Fixed: 3140990 - Safari: Error attempting to load movie from Rhino records
Renamed plug-in view methods to mention that they take URL strings.

Reviewed by darin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): renamed, try to find the plug-in using the extension of the SRC URL if the plug-in isn't found using the MIME type. (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURLString:]): renamed

Apr 18, 2003:

2:20 PM Changeset in webkit [4145] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fixed 3191892 - Popup blocking prevents window.open with '_self' as target (superbitdvd.com)

khtml/ecma/kjs_html.h:
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Don't apply popup blocking if the call would open something in an existing frame (inlcuding the special _self, _top and _parent frames.

2:20 PM Changeset in webkit [4144] by hyatt

3 edits in trunk/WebCore

Make sure display:table is not accidentally mutated to
display:block.

Reviewed by darin

khtml/css/cssstyleselector.cpp:

2:14 PM Changeset in webkit [4143] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3081926 - bookmarklet to count and display mailto links fails

khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): Implement custom toString JavaScript method which calls the existing toString C++ custom method.
khtml/ecma/kjs_html.h: Added AnchorToString.
khtml/ecma/kjs_html.lut.h: Regenerated.

1:15 PM Changeset in webkit [4142] by cblu

3 edits in trunk/WebCore

Fixed: 3172389 - Safari doesn't parse attributes within the OBJECT tag

Reviewed by dave.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): add attributes from within the OBJECT tag to params, the list of attributes we pass to plug-ins. Don't override attributes that are already in params.

10:44 AM Changeset in webkit [4141] by hyatt

3 edits in trunk/WebCore

Make sure display:none is ignored and not accidentally mutated
to display:block.

Reviewed by darin

khtml/css/cssstyleselector.cpp:

9:20 AM Changeset in webkit [4140] by cblu

10 edits in trunk/WebKit

WebKit:

Fixed: 3139385 - don't accept drags from other frames in the same WebView

Reviewed by john.

WebView.subproj/WebFrameView.m: moved drag destination code from WebFrameView to WebView (-[WebFrameView initWithFrame:]): removed drag registration code
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): unregister drag types on the WebView (-[WebHTMLView draggedImage:endedAt:operation:]): reregister drag types on the WebView
WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): unregister drag types on the WebView (-[WebImageView draggedImage:endedAt:operation:]): reregister drag types on the WebView
WebView.subproj/WebView.m: moved drag destination code from WebFrameView to WebView (-[WebView draggingEntered:]): moved from WebFrameView (-[WebView prepareForDragOperation:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView concludeDragOperation:]): ditto
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _registerDraggedTypes]): ditto

WebBrowser:

Fixed regression. Don't append "txt" to files that already end in "txt". Doh!

Reviewed by john.

BrowserDocument.m: (-[BrowserDocument panel:userEnteredFilename:confirmed:]):

Apr 17, 2003:

7:14 PM Changeset in webkit [4139] by sullivan

2 edits in trunk/WebKit

Reviewed by Maciej.

History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): if we can't load the file as a dictionary, try loading it the old-fashioned array way. This makes the history file format change forward-compatible.

6:30 PM Changeset in webkit [4138] by cblu

3 edits in trunk/WebKit

WebKit:

Fixed: 3160751 - Can't use non-'.txt' file extension for text files?

Reviewed by mjs.

English.lproj/StringsNotToBeLocalized.txt:
Misc.subproj/WebNSURLResponseExtras.m: (-[NSURL _web_suggestedFilenameForSavingWithMIMEType:]): don't correct the file extension for plain text files

WebBrowser:

Fixed: 3160751 - Can't use non-'.txt' file extension for text files?

Reviewed by mjs

BrowserDocument.m: (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument isSavingPlainText]): new (-[BrowserDocument prepareSavePanel:]): newly implemented, make the save panel lenient about plain text (-[BrowserDocument panel:userEnteredFilename:confirmed:]): mimic TextEdit when saving plain text. If the extension ends in something other that ".txt", suggest appending ".txt" (-[BrowserDocument dataRepresentationOfType:]): call dataSourceToSave (-[BrowserDocument displayName]): call dataSourceToSave (-[BrowserDocument fileType]): call dataSourceToSave
English.lproj/Localizable.strings:

5:43 PM Changeset in webkit [4137] by sullivan

2 edits in trunk/WebKit

fixed 3232332 -- History file should be versioned since we might change it in the future
fixed 3220355 -- Console error message at launch when there's no history file

Note: a downside of this change is that the history formats
before and after this change are not compatible. You will
get no history each time you cross that boundary by running
different Safaris.

Reviewed by Maciej.

History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): check for file-doesn't-exist case before complaining about being unable to read existing file; expect to read dictionary rather than array, and check version in dictionary. (-[WebHistoryPrivate _saveHistoryGuts:]): save dictionary that includes version as well as array of items by date.

5:40 PM Changeset in webkit [4136] by rjw

2 edits in trunk/WebKit

Fixed typos in headerdoc comments.

WebView.subproj/WebFrame.h:

4:44 PM Changeset in webkit [4135] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed a bug caught by libgmalloc on Vicki's test machine

khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Make sure we don't have a dangling paint device after detaching from the KTHMLView. (DocumentImpl::setPaintDevice): Allow a 0 parameter.
kwq/WebCoreBridge.mm: (nowPrinting): Handle the case of a 0 paint device.

4:22 PM Changeset in webkit [4134] by mjs

3 edits in branches/Safari-73~1-branch/WebKit/Misc.subproj

merged build fixes from HEAD

2003-04-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

fix build on latest Panther due to conflicts with the latest Foundation.

Database.subproj/WebDatabase.h:
Database.subproj/WebDatabase.m: (-[WebDatabase open]): Removed boolean return. (-[WebDatabase close]): Likewise.
Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]): Likewise. (-[WebFileDatabase close]): Likewise.

4:20 PM Changeset in webkit [4133] by mjs

3 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin.

fix build on latest Panther due to conflicts with the latest Foundation.

Database.subproj/WebDatabase.h:
Database.subproj/WebDatabase.m: (-[WebDatabase open]): Removed boolean return. (-[WebDatabase close]): Likewise.
Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]): Likewise. (-[WebFileDatabase close]): Likewise.

11:54 AM Changeset in webkit [4132]

8 copies in tags/Safari-73~3

This commit was manufactured by cvs2svn to create tag 'Safari-73~3'.

11:54 AM Changeset in webkit [4131] by darin

2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-04-17 Richard Williamson <rjw@apple.com>

Drop down yet one more level to avoid intialization horkage.
Call objc_getClass() instead of NSClassFromString().

Reviewed by darin.

WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

11:51 AM Changeset in webkit [4130] by rjw

2 edits in trunk/WebKit

Drop down yet one more level to avoid intialization horkage.
Call objc_getClass() instead of NSClassFromString().

Reviewed by darin.

WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

11:43 AM Changeset in webkit [4129] by darin

2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-04-17 Darin Adler <Darin Adler>

Reviewed by John.

WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): Register the WebDataProtocol here instead of doing it with a load method, since this is the bottleneck that must be used before that protocol is needed. It's good to have one less load method, and this may fix a problem reported by a Panther WebKit client on intrigue-dev too.

9:10 AM Changeset in webkit [4128] by darin

2 edits in trunk/WebKit

Reviewed by John.

WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): Register the WebDataProtocol here instead of doing it with a load method, since this is the bottleneck that must be used before that protocol is needed. It's good to have one less load method, and this may fix a problem reported by a Panther WebKit client on intrigue-dev too.

Apr 16, 2003:

3:26 PM Changeset in webkit [4127]

6 copies in tags/Safari-73~2

This commit was manufactured by cvs2svn to create tag 'Safari-73~2'.

3:26 PM Changeset in webkit [4126] by darin

2 edits in branches/Safari-73~1-branch/WebKit

WebFoundation:

Rolled in change from trunk.

2003-04-16 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

Fixed synchronous loading API. When deciding on the new API,
we made a bonehead play which removed the ability to access
the error object associated with the load. Fixed.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate error]):

WebKit:

Rolled in change from trunk.

2003-04-16 Ken Kocienda <kocienda@apple.com>

Reviewed by Darin

Fixed call to load synchronous URL. Now conforms to new API
which allows callers to access error object associated with
the load.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]):

3:08 PM Changeset in webkit [4125] by kocienda

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Fixed synchronous loading API. When deciding on the new API,
we made a bonehead play which removed the ability to access
the error object associated with the load. Fixed.

CacheLoader.subproj/NSURLConnection.h:
CacheLoader.subproj/NSURLConnection.m:
CacheLoader.subproj/WebSynchronousDelegate.h:
CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate error]):

WebKit:

Reviewed by Darin

Fixed call to load synchronous URL. Now conforms to new API
which allows callers to access error object associated with
the load.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]):

1:38 PM Changeset in webkit [4124] by cblu

3 edits in trunk/WebKit

Progressively load plain text in our text view.
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]): added FIXME about document source of RTF not working (-[WebTextRepresentation receivedData:withDataSource:]): feed data to the text view, progressively for plain text
WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): include text/directory, another vcard MIME type (-[WebTextView setDataSource:]): do 1-time attribute settings (-[WebTextView dataSourceUpdated:]): do nothing

1:34 PM Changeset in webkit [4123] by kocienda

2 edits in trunk/WebKit

WebFoundation:

Reviewed by David

Added API-approved NSURLCacheStoragePolicy enum.

Removed NSURLProtocolClient.h file. Rolled protocol
declaration in NSURLProtocol.h

Moved all NSURLProtocolClient implementors to API-approved
interface.

Did some code reorganization with regard to cached response
management in NSURLConnection implementation and its interaction
with NSURLProtocol. This is a partial step towards implementing
the final API.

Moved some more cacheObject usages in the program text to
use cachedResponse instead.

Added a number of API FIXME markers to indicate places where
more work needs to be done to complete the API transition.

CacheLoader.subproj/NSURLCache.h:
CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection cachedResponse]): (-[NSURLConnection setCacheObject:]): (-[NSURLConnection _chooseCachedResponse]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _scheduleOriginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _beginOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnection _didLoadData:]): (-[NSURLConnection _invalidateCacheObject]): (-[NSURLConnection _didFinishLoading]): (-[NSURLConnection _didFailWithError:]): (-[NSURLConnectionInternal dealloc]): (-[NSURLConnectionInternal cachedResponse]): (-[NSURLConnectionInternal URLProtocol:wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnectionInternal URLProtocol:cachedResponseIsValid:]): (-[NSURLConnectionInternal URLProtocol:didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnectionInternal URLProtocol:didLoadData:]): (-[NSURLConnectionInternal URLProtocolDidFinishLoading:]): (-[NSURLConnectionInternal URLProtocol:didFailWithError:]): (-[NSURLConnectionInternal _invalidateCacheObject]): (-[NSURLConnectionInternal _setWaitingForCallback:]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol initWithRequest:cachedResponse:client:]): (-[NSURLProtocol client]): (-[NSURLProtocol startLoading]): (-[NSURLProtocol _invalidateCacheObject]):
CacheLoader.subproj/NSURLProtocolPrivate.h:
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoading]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol startLoading]): (-[WebCFNetworkHTTPProtocol retryAfterAuthenticationFailure:]): (-[WebCFNetworkHTTPProtocol retryAfterConnectingToInternet]): (-[WebCFNetworkHTTPProtocol continueAfterEndEncountered]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]): (-[WebCFNetworkHTTPProtocol performStreamRead:]): (-[WebCFNetworkHTTPProtocol didAddCredentials:toRequest:context:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]): (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol didLoadData:]): (-[WebFTPProtocol handleHasBytesAvailable]): (-[WebFTPProtocol _checkDirectoryListing]): (-[WebFTPProtocol handleEndEncountered]): (-[WebFTPProtocol handleReadStreamEvent:event:]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]): (-[WebFileProtocol startLoading]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol sendResponseAvailableCallback]): (-[WebHTTPProtocol failWithError:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol startLoading]): (-[WebSimpleHTTPProtocol _extractResponseStatusLineFromBytes:length:]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by David

Moved this NSURLProtocolClient implementor to API-approved
interface.

WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):

11:20 AM Changeset in webkit [4122] by kocienda

2 edits in trunk/WebKit

Reviewed by me

Fix deployment build breaker caused by uninitialized variable.

WebView.subproj/WebViewPrivate.m: (-[WebView _loadBackForwardListFromOtherView:]):

10:21 AM Changeset in webkit [4121] by darin

6 edits in trunk/WebKit

Reviewed by John.

fixed 3226281 -- REGRESSION: crash in WebHTMLView removeMouseMovedObserver closing gist.com

Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]): Use _webView instead of _controller.

WebCoreSupport.subproj/WebTextRendererFactory.m: Remove stray semicolon.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView removeMouseMovedObserver]): Use _webView instead of _controller. (-[WebHTMLView menuForEvent:]): Ditto. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
WebView.subproj/WebHTMLViewPrivate.h: Rename _controller to _webView.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]): Use _web_superviewOfClass to find the WebView. This dodges possible stale unretained pointer issues with getting the WebView through the WebFrame, which is what fixes the bug. (-[WebHTMLView _updateMouseoverWithEvent:]): Use _webView instead of _controller. (+[WebHTMLView _pasteboardTypes]): Put the types in order from most preferred to least. (-[WebHTMLView _writeSelectionToPasteboard:]): Ditto.

Apr 15, 2003:

7:18 PM Changeset in webkit [4120] by rjw

2 edits in trunk/WebKit

Create the dictionary for volatile values. Without this fix
values were never volatile!

Reviewed by mjs.

WebView.subproj/WebPreferences.m: (-[WebPreferences _init]): (-[WebPreferences init]): (+[WebPreferences standardPreferences]): (-[WebPreferences dealloc]):

7:02 PM Changeset in webkit [4119] by rjw

2 edits in trunk/WebKit

Fix for 3226746. Remove some ancient and apparantly invalid cruft.

Reviewed by trey.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]):

5:47 PM Changeset in webkit [4118] by hyatt

3 edits in trunk/WebCore

Missed a piece of the renaming on lowestPosition/rightmostPosition.
This was already reviewed by darin. Just missed landing one file.

Reviewed by darin

khtml/rendering/render_box.cpp: (RenderBox::lowestPosition): (RenderBox::rightmostPosition):

5:38 PM Changeset in webkit [4117] by rjw

2 edits in trunk/WebKit

Fixed clipping of progressive images to correctly clip.

Reviewed by darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):

5:28 PM Changeset in webkit [4116] by trey

3 edits in trunk/WebCore

3210061 - Forms auto-fill ignores maxlength attribute

Reviewed by Maciej.

kwq/KWQTextField.mm: (-[KWQTextField setStringValue:]): We now trim down incoming values to fit the maxlength criteria. Matches the way we enforce this constraint when maxlength is set.

5:09 PM Changeset in webkit [4115] by hyatt

1 edit in trunk/WebCore/khtml/css/parser.y

* empty log message *

5:04 PM Changeset in webkit [4114] by hyatt

3 edits in trunk/WebCore

Fix 3227983 and 3229592, both the same bug involving a movable type
template:

letter-spacing: .none;

Fix is to make error-handling of exprs more generic.

Reviewed by darin

khtml/css/parser.y:

4:45 PM Changeset in webkit [4113] by darin

8 edits in trunk/WebCore

Reviewed by Ken.

fixed 3056913 -- please add Japanese auto-detect

khtml/misc/decoder.cpp: (Decoder::decode): Turn on the auto-detect code if the default encoding is one of the Japanese encodings. Also change things around so the auto-detection process doesn't clobber the old chosen encoding if it does not yield a result.

kwq/KWQCharsets.h: Add a new IsJapanese encoding flag.
kwq/KWQTextCodec.h: Add a new isJapanese() member function, used by the above.
kwq/mac-encodings.txt: Add the IsJapanese flag to all Japanese encodings, and add "jis7" as a synonym for ISO-2022-JP.
kwq/make-charset-table.pl: Changed to allow flags even for unused encodings.

kwq/KWQCharsetData.c: Regenerated.

4:29 PM Changeset in webkit [4112] by hyatt

14 edits in trunk/WebCore

Fix for 3220809, overflow values other than visible should not
affect the document's height (or document scrollbars). This
fixes squidfingers.com and briefcase.yahoo.com

Also laying a bunch of groundwork for overflow:auto and scroll
by adding them as supported values now.

Fixed overflow so that overflow objects now dodge floats and
don't let them intrude into their space.

Reviewed by darin

khtml/css/cssstyleselector.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::repaint): (RenderBox::repaintRectangle): (RenderBox::calcWidth): (RenderBox::calcAbsoluteVertical): (RenderBox::lowestPosition): (RenderBox::rightmostPosition):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::repaint): (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
khtml/rendering/render_flow.h:
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::convertToLayerCoords): (RenderLayer::scrollOffset):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setLayouted): (RenderObject::detach):
khtml/rendering/render_object.h:
khtml/rendering/render_style.h:

3:54 PM Changeset in webkit [4111] by trey

3 edits in trunk/WebCore

3229318 - no back entry created when searching at lonelyplanet.com

Reviewed by Darin.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Treat blur/focus events as being user gestures, since they probably were caused by something the user did. This cues us to not lock history for navigations that are spawned by these events.

2:25 PM Changeset in webkit [4110] by kocienda

2 edits in trunk/WebKit

Tools:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

DiskCachePeek/main.m:
WebDiskCacheInspector/Controller.h:
WebDiskCacheInspector/Controller.m: (-[Controller cacheObjectForPath:]): (-[Controller setFilesArrayUsingSearchString:]): (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):

WebFoundation:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection cacheObject]): (-[NSURLConnection setCacheObject:]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _finishedLoading]): (-[NSURLConnectionInternal cacheObject]):
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol cacheObject]): (-[NSURLProtocol setCacheObject:]): (-[NSURLProtocol startLoadingWithCacheObject:]): (-[NSURLProtocol stateForCacheObject:]): (-[NSURLProtocol canStoreCacheObject:]):
CacheLoader.subproj/WebCache.h:
CacheLoader.subproj/WebCache.m: (-[WebCache cacheObjectForKey:]): (-[WebCache storeCacheObject:forKey:]):
CacheLoader.subproj/WebCacheManager.h:
CacheLoader.subproj/WebCacheManager.m: (-[WebCacheManager cacheObjectForKey:]): (-[WebCacheManager storeCacheObject:forKey:]):
CacheLoader.subproj/WebCacheObjectPrivate.h:
CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache cacheObjectForKey:]): (-[WebDiskCache storeCacheObject:forKey:]): (-[WebDiskCache removeCacheObjectForKey:]):
CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCacheLRUListNode initWithCacheObject:forKey:]): (-[WebMemoryCache cacheObjectForKey:]): (-[WebMemoryCache storeCacheObject:forKey:]):
Misc.subproj/WebFoundation.h:
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): (-[WebCFNetworkHTTPProtocol startLoadingWithCacheObject:]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoadingWithCacheObject:]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol stateForCacheObject:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol startLoadingWithCacheObject:]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]):
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoadingWithCacheObject:]):

1:44 PM Changeset in webkit [4109] by trey

3 edits in trunk/WebKit

WebKit:

3227514 Open window in "Same Page" should copy entire back/forward list

New support to load a new view by copying the whole backforward
list and driving the new view to the current item.

Reviewed by John.

WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _loadItem:]): Old routine, which only loaded an item. (-[WebView _loadItemsFromOtherView:]): New routine that does the works.

WebBrowser:

3227514 Open window in "Same Page" should copy entire back/forward list

Just call new method in WebKit.

Reviewed by John.

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument loadCloneOfView:]): Renamed goToHistoryItem:inView:.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Call above method instead of old one.

11:25 AM Changeset in webkit [4108] by hyatt

5 edits in trunk/WebCore

A collection of fixes.

(1) Don't lay out positioned elements so early in
layoutInlineChildren. They need to get a layout only after
all the normal flow kids have gotten a layout (and this happens
already in layoutPositionedObjects).

(2) Fix a mistake with overflow:hidden. I was applying the
overflow-clip for positioned elements only if you had defined
clip using the clip property. This makes iht.com look better
(although it still misrenders pretty badly due to some JS error
we hit in the source).

(3) Patch RenderText's height method to give more accurate
information. This affects all the layout tests. :)

Reviewed by darin

khtml/rendering/bidi.cpp:
khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
khtml/rendering/render_text.cpp: (RenderText::height):

11:13 AM Changeset in webkit [4107] by kocienda

2 edits in trunk/WebKit

WebFoundation:

Reviewed by John

Name change from WebProtocolClient to NSURLProtocolClient.
No functional changes.

CacheLoader.subproj/NSURLConnection.m:
CacheLoader.subproj/NSURLProtocol.h:
CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol initWithProtocolClient:request:]): (-[NSURLProtocol client]):
ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol initWithProtocolClient:request:]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]): (-[WebCFNetworkHTTPProtocol performStreamRead:]):
ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol initWithProtocolClient:request:]): (-[WebFTPProtocol startLoadingWithCacheObject:]): (-[WebFTPProtocol _checkDirectoryListing]): (-[WebFTPProtocol handleEndEncountered]): (-[WebFTPProtocol handleReadStreamEvent:event:]):
ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]): (-[WebFileProtocol startLoadingWithCacheObject:]):
ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol initWithProtocolClient:request:]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Name change from WebProtocolClient to NSURLProtocolClient.
No functional changes.

WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoadingWithCacheObject:]):

10:39 AM Changeset in webkit [4106] by kocienda

4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection protocol]):
CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _parametersForReading]): (-[NSMutableURLRequest _parametersForWriting]):
CacheLoader.subproj/NSURLResponse.m:
CacheLoader.subproj/WebCacheManager.m:
CacheLoader.subproj/WebProtocolClient.h:
Misc.subproj/WebFoundation.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_canonicalize]):
ProtocolHandlers.subproj/WebAboutProtocol.h:
ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
ProtocolHandlers.subproj/WebFTPProtocol.h:
ProtocolHandlers.subproj/WebFTPProtocol.m:
ProtocolHandlers.subproj/WebFileProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.h:
ProtocolHandlers.subproj/WebHTTPProtocol.m:
ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForReading]): (-[NSURLRequest _webDataRequestParametersForWriting]): (+[WebDataProtocol load]):
WebView.subproj/WebFrame.m:

WebBrowser:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

Debug/DebugUtilities.m: (initProtocolHandlers): (-[BrowserDocument unregisterAllProtocolHandlers]): (-[BrowserDocument reregisterAllProtocolHandlers]): (-[BrowserDocument toggleAboutProtocolHandler:]): (-[BrowserDocument toggleFileProtocolHandler:]): (-[BrowserDocument toggleCFNetworkHTTPProtocolHandler:]): (-[BrowserDocument toggleSimpleHTTPProtocolHandler:]):

10:25 AM Changeset in webkit [4105] by trey

19 edits in trunk

WebCore:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection

And a commented out fix for:

3121828 - scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Various missing pieces are implemented to support better finding. The fix for
3121828 is left out until 3228511 is dealt with.

Reviewed by Maciej.

WebCore.pbproj/project.pbxproj:
khtml/khtml_part.cpp: (KHTMLPart::findTextBegin): Added args to allow starting a find at an arbitrary places, such as the current selection. (KHTMLPart::findTextNext): Implement reverse search - only the param was there. Don't do lame scrolling selection to visible here, do better ourselves later.
khtml/khtml_part.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Make whole selection rect visible, and only scroll anything if needed. *Commented out in lieu of 3228511. (KWQKHTMLPart::findString): Implement find starting at the right place relative to the selection, forwards and backwards, and wraparound. This is just setup around calling findTextNext. Also scroll the result to be visible.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge deselectAll]): Call part instead of doc so its state isn't out of sync. (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): Pass extra wrap arg.
kwq/WebCoreDOMNode.mm: (+[WebCoreDOMNode nodeWithImpl:DOM::]): Return a nil for a null element instead of croaking. (-[WebCoreDOMNode initWithImpl:DOM::]): Ditto.

WebKit:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection
Primary changes here: I added a wrap flag to the searchFor method, which is needed to
control how we search as we traverse the frame tree. A new method is added to WebView
that knows about traversing the frame tree as we search. HTMLView and TextView both
clear their selections when they lose first responder (see 3228554 for possible
improvements to that change).

Reviewed by Maciej.

Misc.subproj/WebSearchableTextView.m: Added wrap flag, pass on to TextView. Ensure we do some searching when we would previous get a zero range to search in.
WebView.subproj/WebDocument.h:
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: These are all basic methods to support forwards and backwards traversal of the frame tree. Modeled after same methods we have for traversing the DOM. (-[WebFrame _nextSibling]): (-[WebFrame _previousSibling]): (-[WebFrame _lastChild]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): Added wrap flag, pass it to bridge. (-[WebHTMLView resignFirstResponder]): Clear selection when we lose firstResp.
WebView.subproj/WebTextView.m: (-[WebTextView resignFirstResponder]): Clear selection when we lose firstResp.
WebView.subproj/WebView.m: (-[WebView _currentFrame]): Return the frame holding the first responder. (-[WebView _searchFor:direction:caseSensitive:wrap:]): Main work: traverse the frame tree and drive the overall find.
WebView.subproj/WebViewPrivate.h:

WebBrowser:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection

Primary change here is that we use a new WK method that is hip to searching across
frames. There is an open issue in 3228520 for getting that into the API.

Reviewed by Maciej.

BrowserWindowController.h:
BookmarksViewController.m: Added wrap: argument to searchFor:direction:caseSensitive: method.
FindPanelController.m: (-[FindPanelController _searchTarget]): Hacked to return a WebView if possible instead of always a WebDocumentSearching. (-[FindPanelController _doSearchForString:direction:caseSensitive:inTarget:]): New method that knows to call new WK method for searching across frames in the special case of us about to search within a WebView. (-[FindPanelController _findWithDirection:caseSensitive:]): Call above new method instead of going straight to the search target using the WebDocumentSearching method.

Apr 14, 2003:

10:31 PM Changeset in webkit [4104] by mjs

5 edits in trunk/WebCore

Reviewed by Trey.

fixed 3214900 - iBench JavaScript test times get progressively slower with each test run

The fix is to make sure to always cast NodeImpl * to DocumentImpl
*. Multiple inheritance means the pointer values need not be the
same.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::getDOMObjectForDocument): (ScriptInterpreter::putDOMObjectForDocument): (ScriptInterpreter::deleteDOMObjectsForDocument): (ScriptInterpreter::forgetDOMObjectsForDocument):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode):

3:43 PM Changeset in webkit [4103] by hyatt

5 edits in trunk/WebCore

Reviewed by darin

ChangeLog:
khtml/css/cssstyleselector.cpp:
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseComment):

2:43 PM Changeset in webkit [4102] by cblu

6 edits in trunk/WebKit

Log time spent loading each plug-in.

Reviewed by mjs.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): fixed logging code (-[WebIconDatabase _scaleIcon:toSize:]): fixed logging code
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): log time spent loading a plug-in
Plugins.subproj/WebPluginController.m: (-[WebPluginController startAllPlugins]): only log if there are plug-ins to start (-[WebPluginController stopAllPlugins]): only log if there are plug-ins to stop (-[WebPluginController destroyAllPlugins]): only log if there are plug-ins to destroy

1:46 PM Changeset in webkit [4101] by trey

7 edits in trunk/WebKit

WebKit:

3150693 - open new window on "same page" doesn't give me the same frame content

The core is a new support method that loads a WebView given a HistoryItem, which
thus restores all frames of that item, and optionally the form and scroll state.

Reviewed by NOBODY (OOPS!).

History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]): Copy the docState, scrollPosition, isTargetItem. No good reason to have left these out when I wrote this method.
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _saveDocumentAndScrollState]): New method to run the frame tree and save all form/scroll state to the current item.
WebView.subproj/WebView.m: _goToItem:withLoadType: moved to WebViewPrivate.m
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _goToItem:withLoadType:]): Moved from WebView.m, no change. (-[WebView _loadItem:showingInView:]): New method to load the view with the item.

WebBrowser:

3150693 - open new window on "same page" doesn't give me the same frame content

The basic idea is that we try to call the new _loadItem:showingInView:
method with a history item instead of just loading a URL.

Reviewed by NOBODY (OOPS!).

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument goToHistoryItem:inView:]): Just pass through args to our current controller.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): If we can get a history item use that to do the load. Else use a URL like before.

11:48 AM Changeset in webkit [4100] by cblu

3 edits in trunk/WebCore

Fixed build failure.

Reviewed by darin.

khtml/rendering/render_table.cpp: (RenderTable::cellAbove):

11:03 AM Changeset in webkit [4099] by cblu

3 edits in trunk/WebKit

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Reviewed by dave.

WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): code moved from +[WebImageView supportedImageMIMETypes]
WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): return -[WebImageRendererFactory supportedMIMETypes]

11:01 AM Changeset in webkit [4098] by cblu

6 edits in trunk/WebCore

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Whenever we encounter an OBJECT tag with a type that starts with "image/" we create a render image object instead of a render part object. The behavior is nice because this allows the render object to resize to the size of the image if no WIDTH and HEIGHT are supplied. For example, the image at the bottom of this page:

http://tantek.com/CSS/Examples/boxmodelhack.html

The problem is that we do this for image types that we can't handle and when there are plug-ins that *can* handle the types.

Reviewed by dave.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::rendererIsNeeded): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::createRenderer): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::attach): call canRenderImageType instead of serviceType.startsWith
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (canRenderImageType): new, checks if the MIME type is supported by the image factory
kwq/WebCoreImageRendererFactory.h: added supportedMIMETypes to the WebCoreImageRendererFactory protocol

7:14 AM Changeset in webkit [4097]

2 copies
2 deletes in tags/JavaScriptCore-73

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-73'.

7:14 AM Changeset in webkit [4096] by darin

1 edit in branches/JavaScriptCore-73-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

7:11 AM Changeset in webkit [4095]

4 copies
2 deletes in tags/WebCore-73

This commit was manufactured by cvs2svn to create tag 'WebCore-73'.

7:11 AM Changeset in webkit [4094] by darin

1 edit in branches/WebCore-73-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Update project for tarball release.

12:10 AM Changeset in webkit [4093] by mjs

5 edits in trunk/WebCore

Reviewed by Trey.

fixed 3165326 - javascript getSelection not implemented

khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall):
khtml/ecma/kjs_window.h:
khtml/ecma/kjs_window.lut.h:

Apr 13, 2003:

11:24 PM Changeset in webkit [4092] by mjs

3 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented in terms of webView:setFrame: to save clients work.

WebBrowser:

Reviewed by Trey.

fixed 3210715 - Window cannot resize smaller than 392px wide - mac.com Bookmarks

WindowController.m: (-[WindowController setFrameWithoutAutosaving:]): When setting size smaller than the current minimum, make it the new minimum. (-[WindowController webView:setContentRect:]): Removed.

10:18 PM Changeset in webkit [4091] by trey

6 edits in trunk/WebCore

3219720 - autofill mapping confused by tables, worse than MacIE (at store.apple.com)

If in scanning backwards we get to the end of a table row, we take a diversion
and scan the cell that is above the cell we started at.
Big improvement for store.apple.com.

Reviewed by Maciej

khtml/rendering/render_table.cpp: (RenderTable::cellAbove): New support routine to find the cell above another
khtml/rendering/render_table.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): Get the cell above, scan its tree for matching text. (KWQKHTMLPart::searchForLabelsBeforeElement): Call above routine if we are working within a table

12:31 AM Changeset in webkit [4090]

4 copies in branches/Safari-73~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-73~1-branch'.

12:31 AM Changeset in webkit [4089]

4 copies in tags/Safari-73~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-73~1-anchor'.

12:31 AM Changeset in webkit [4088]

4 copies in tags/Safari-73~1

This commit was manufactured by cvs2svn to create tag 'Safari-73~1'.

12:31 AM Changeset in webkit [4087] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by Don.

JavaScriptCore part of fix for 3158769 - JavaScript triggers not as async as they used to be

Added a way to get the current interpreter lock count, so Sherlock
can unlock the interpreter inside JS method implementations that
spend a long time waiting for I/O, allowing more efficient
multi-threaded operation.

kjs/internal.cpp: (lockInterpreter): (unlockInterpreter): (InterpreterImp::lock): (InterpreterImp::lockCount):
kjs/internal.h:
kjs/interpreter.cpp: (Interpreter::lockCount):
kjs/interpreter.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed