⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 13, 2003:

9:44 PM Changeset in webkit [4550] by darin
  • 3 edits in trunk/WebCore

Reviewed by Don.

  • fixed 3293031 -- REGRESSION (83-84): extra entry in history when going to page that redirects (live365.com)
  • khtml/khtmlpart_p.h: Initialize m_executingJavaScriptFormAction to false. We had left it uninitialized when we fixed 3289047.
9:32 PM Changeset in webkit [4549] by darin
  • 2 edits in trunk/WebKit

Reviewed by Darin (Richard wrote the first cut), then Don and Dave.

  • fixed 3291467 -- CARBON: context menus are broken when using WebKit from Carbon
  • Carbon.subproj/HIWebView.m: (ContextMenuClick): Rewrite method to create a fake right mouse up event, and pass that to menuForEvent: and _popUpMenuWithEvent.
8:10 PM Changeset in webkit [4548] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3292630, misrendered page because of bad doctype. Add
this bad doctype to our list of quirky doctypes to fix the
problem, since the screwed up strict mode rendering is actually
correct.

Reviewed by john

  • khtml/html/doctypes.cpp: (findDoctypeEntry):
  • khtml/html/doctypes.gperf:
7:12 PM Changeset in webkit [4547] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3178438 -- return elements in order of addition in for..in loop (other browsers seem to)
  • fixed 3292067 -- REGRESSION (64-65): albertsons.com "Shop A to Z" menus are not sorted alphabetically
  • kjs/property_map.h: Add index field to hash table entry and index parameter to insert function.
  • kjs/property_map.cpp: (PropertyMap::put): Set an index for new map entries to an ever-increasing number based on a global. (PropertyMap::insert): Take an index parameter. (PropertyMap::expand): Preserve the indices as we rehash the table. (comparePropertyMapEntryIndices): Added. Compares two property map entries by index. (PropertyMap::addEnumerablesToReferenceList): Sort the proprty map entries by index before adding them to the reference list.
5:46 PM Changeset in webkit [4546] by darin
  • 3 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3291778 -- REGRESSION (51-52): QT controller never shows up for mp3 in frame
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Handle the "invisible" plug-in cases in a more complete way. Detect the various ways of being invisible (big negative X value, 0 size, not really in a window) and in all those cases, use a clip rect to guarantee we won't be seen, and make sure the size passed to the plug-in is *not* 0.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
2:13 PM Changeset in webkit [4545] by rjw
  • 4 edits in trunk/WebCore

Fixed 3282087. Don't use our <pre> optimizations
if text contains non-ascii, and consequently may
result in font substitution.

2:11 PM Changeset in webkit [4544] by hyatt
  • 3 edits in trunk/WebKit

Fix for 3291319, scrolling is much worse since 79. The problem
was a fix for resize events that needed to use the scrollview size
and not the document view size inside the scrollview.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
12:03 PM Changeset in webkit [4543] by cblu
  • 1 edit in trunk/WebKit/ChangeLog

Fixed previous " Reviewed by" string.

  • ChangeLog:
12:01 PM Changeset in webkit [4542] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3291502>: REGRESSION (80-81): freebsd.org is giving us gzipped content (because we stopped spoofing)

Reviewed by darin.

  • WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry):
  • WebView.subproj/WebUserAgentSpoofTable.gperf:
11:51 AM Changeset in webkit [4541] by rjw
  • 3 edits in trunk/WebCore

Fixed 3291537.
Reviewed by John.

  • kwq/KWQObject.mm: (QObject::killTimer): Only remove the timer is it hasn't fired (and is therefore valid). It is NOT permissible to reference a timer's userInfo if it is invalid.

Jun 12, 2003:

10:58 PM Changeset in webkit [4540] by rjw
  • 3 edits in trunk/WebKit

Restoring fix for 3221078 that I earlier backed out in a
panic about performance. In careful performance testing
I now see no performance regression, and maybe a tiny improvement.
The earlier performance regression Vicki saw was entirely
due to the incorrect checkin for the fix to 3288532.

Reviewed by Chris & Gramps.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m:
10:22 PM Changeset in webkit [4539] by rjw
  • 2 edits in trunk/WebKit

Correct fix for 3288532 again. This time will feeling!

Reviewed by Gramps.

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):
9:29 PM Changeset in webkit [4538] by gramps
  • 2 edits in trunk/WebKit

Since Richard didn't actually correct the fix for 3288532 in
WebBackForwardList.m, I've backed out out his original fix entirely.

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):
7:24 PM Changeset in webkit [4537] by rjw
  • 1 edit in trunk/WebKit/ChangeLog

Correct fix for 3288532.

  • History.subproj/WebBackForwardList.m:
7:09 PM Changeset in webkit [4536] by rjw
  • 2 edits in trunk/WebKit/WebCoreSupport.subproj

Back out change for 3221078 pending further testing.

6:25 PM Changeset in webkit [4535] by rjw
  • 2 edits in trunk/WebKit

Fixed 3288532. When setCapacity: shrinks capacity, trim
the back/forward list. Setting to zero will effectively
flush the list.

Reviewed by John.

  • History.subproj/WebBackForwardList.m:
6:22 PM Changeset in webkit [4534] by rjw
  • 3 edits in trunk/WebKit

Fixed 3221078. Maintain a separate width map
for substitute fonts to avoid collision of glyph
codes.

Reviewed by Chris & Gramps.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m:
2:01 PM Changeset in webkit [4533] by sheridan
  • 3 edits in trunk

Safari-85u version, but the tree's not really open.

1:11 PM Changeset in webkit [4532]
  • 3 copies in tags/Safari-84

This commit was manufactured by cvs2svn to create tag 'Safari-84'.

1:11 PM Changeset in webkit [4531] by sheridan
  • 8 edits in trunk

Safari-84 stamp

11:00 AM Changeset in webkit [4530] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3289113, body.scrollTop doesn't return the right
value. Fix scrollLeft and scrollTop for body tags to just
use the view's offset. This matches WinIE behavior.

Reviewed by john

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::putValue):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.lut.h:
10:19 AM Changeset in webkit [4529] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3289405 -- repro crash in KWQPopUpButtonCell at umax.de
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Use the bridge that we got earlier in the function to find the right part. This is simpler, and more reliable. The old way would run into trouble if the widget or any of the other objects in the chain got destroyed during the event handling.
9:43 AM Changeset in webkit [4528] by darin
  • 10 edits in trunk

WebCore:

Fixed by Richard, reviewed by me.

  • fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
  • khtml/khtmlpart_p.h: Add an "executing JavaScript form action" flag.
  • kwq/WebCoreBridge.h: Add an "executing JavaScript form action" flag parameter to the reportClientRedirectToURL method.
  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): In the JavaScript case, set a flag to say we are executing a JavaScript form action.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Pass the isJavaScriptFormAction state over the bridge.

WebKit:

Fixed by Richard, reviewed by me.

  • fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Added isJavaScriptFormAction parameter, passed on to frame.
  • WebView.subproj/WebFramePrivate.h: Added isJavaScriptFormAction parameter.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): If isJavaScriptFormAction is YES, then don't treat this is a "quick redirect" which is merged with the previous page for purposes of back/forward.

Jun 11, 2003:

6:13 PM Changeset in webkit [4527] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3289577>: Reenable Carbon Java plug-ins when in Carbon app

Reviewed by gramps.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): only call canUsePlugin: for web plug-ins
5:22 PM Changeset in webkit [4526] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3289380>: REGRESSION: policyDataSource == nil assertion failure after closing particular window

Reviewed by john.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): don't clear policyDataSource here because this method may not be called during navigation (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): clear policyDataSource here
3:57 PM Changeset in webkit [4525] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3288875, :after/:before content not getting destroyed
after printing on alistapart.com. Make the update method for
pseudos smart enough to destroy generated content when it is
no longer needed.

Reviewed by darin

  • khtml/rendering/render_block.cpp: (RenderBlock::setStyle);
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::setStyle):
3:48 PM Changeset in webkit [4524] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3288097>: REGRESSION: assertion failure after hitting back while loading page after fragment scroll

Fixed by darin, reviewed by me.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _URLsMatchItem:]): ignore the URL fragment so we scroll back at the current page instead of attempt to load the current page
1:51 PM Changeset in webkit [4523] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3288035, the wrong value was being filled in for
textfields. Fixed a bug in QString's assignment operator
that made empty strings become null strings upon assignment.
Also ensured that the form control never sets the value to
null but always uses empty instead.

Reviewed by john

  • khtml/rendering/render_form.cpp: (RenderLineEdit::slotTextChanged):
  • kwq/KWQString.mm: (QString::setLatin1):
10:37 AM Changeset in webkit [4522] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3285808 -- repro world leak when replacing div that contains iframe (at www.kbs.co.kr)
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]): Add a call to _detachFromParent.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]): Nil out the parent pointer in the removed child.
9:18 AM Changeset in webkit [4521] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3288076>: REGRESSION: Fragment scroll stops page load

We do policy navigation checks for the regular load case, fragment scroll and redirects.
We only want to stop the load, change the provisional data source etc in the regular load case.

Reviewed by darin.

  • WebView.subproj/WebFramePrivate.m: got rid of _prepareForProvisionalLoadWithDataSource:: since the work done in this method only needs to be done in _continueLoadRequestAfterNavigationPolicy:: (which covers the regular load case).
(-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): …
(-[WebFrame _setPolicyDataSource:]): new (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): don't call _prepareForProvisionalLoadWithDataSource::, don't muck with policyDataSource because it is only needed in the regular load case (-[WebFrame _continueAfterNavigationPolicy:]): don't call _prepareForProvisionalLoadWithDataSource::, call _setPolicyDataSource:nil after _continueLoadRequestAfterNavigationPolicy:: has used policyDataSource
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): …
(-[WebFrame _loadDataSource:withLoadType:formState:]): set the policyLoadType and policyDataSource (the beginning of the regular load case)

Jun 10, 2003:

6:51 PM Changeset in webkit [4520] by rjw
  • 2 edits in trunk/WebKit

2003-06-10 Richard Williams <​rjw@apple.com>

Back out incorrect fix to 3287862.

6:20 PM Changeset in webkit [4519] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win

Reviewed by rjw.

  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): set the provisional data source to nil to avoid a newly added assert in [WebFramePrivate setProvisionalDataSource:] and since it is wasteful to retain it in this case
  • WebView.subproj/WebFramePrivate.h: added policyDataSource and policyLoadType ivars
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): added an assert (-[WebFramePrivate setProvisionalDataSource:]): added an assert (-[WebFrame _isLoadComplete]): formatting tweak (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): reset policyDataSource (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): formatting tweak (-[WebFrame _prepareForProvisionalLoadWithDataSource:loadType:]): new, calls stopLoading, _setLoadType and _setProvisionalDataSource (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): call _prepareForProvisionalLoadWithDataSource:loadType: only in the "use" policy case (-[WebFrame _continueAfterNavigationPolicy:]): call _setProvisionalDataSource:andLoadType: (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): formatting tweak (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): formatting tweak (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): if there is no request to continue with, don't reset things like the provisional data source since it was never unset in this case (-[WebFrame _loadDataSource:withLoadType:formState:]): don't call stopLoading, _setLoadType and _setProvisionalDataSource, since that stops the frame even for command-click and option-click. Do this work in _prepareForProvisionalLoadWithDataSource:loadType: instead.
6:17 PM Changeset in webkit [4518] by rjw
  • 2 edits in trunk/WebKit

Fixed 3287862. Don't override resize flags
when decoding WebView.

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView _commonInitializationFrameName:groupName:]):
6:09 PM Changeset in webkit [4517] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3287870, the <embed hidden=true> feature didn't work.
hidden should turn the embed into a plugin with a width and
height of 0.

Reviewed by gramps

  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::attach):
5:12 PM Changeset in webkit [4516] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3286006>: Carbon Java plug-in problems may require workaround in WebKit

Reviewed by john.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase canUsePlugin:]): if in a carbon app, only use the mach-o java plug-in when its version is anything but 1.0.0 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): call canUsePlugin on all the plug-ins
2:00 PM Changeset in webkit [4515] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3285820 -- REGRESSION: iframe set up with innerHTML shows up empty (discovered at www.kbs.co.kr)
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Remove the frame from the parent's m_frames list so it's not accidentally reused, since our naming scheme gives frames in the same place in the scheme of things the same name.
11:36 AM Changeset in webkit [4514] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3270813, crash in the code for the CSS content property.
When copying a DOMString, I missed a required ref.

Reviewed by darin

  • khtml/rendering/render_style.cpp: (RenderStyle::setContent):
10:39 AM Changeset in webkit [4513] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3285120 -- crash in CSSParser::parseColor (originally seen with Panther Mail while indexing)
  • khtml/css/parser.y: Moved DIMEN rule out of unary_term, needed because a term production assumes that the values that come out of unary_term are all fValue, not string.
  • khtml/css/parser.cpp: Regenerated.
9:49 AM Changeset in webkit [4512] by vicki
  • 8 edits in trunk

JavaScriptCore:

Reviewed by john.

WebCore:

Reviewed by john.

  • WebCore.order: new order file for 1.0

WebKit:

Reviewed by john.

  • WebKit.order: new order file for 1.0

WebBrowser:

Reviewed by john.

  • Safari.order: new order file for 1.0
8:37 AM Changeset in webkit [4511] by darin
  • 4 edits in trunk/WebCore

Reviewed by Don.

  • fixed 3286343 -- REGRESSION: crashing on pages with text area elements
  • khtml/rendering/render_form.cpp: (RenderTextArea::detach): Do cleanup in detach rather than in destructor.
  • khtml/rendering/render_form.h: Remove destructor, add detach.

Jun 9, 2003:

6:54 PM Changeset in webkit [4510] by rjw
  • 6 edits in trunk/WebCore

Fixed 3281761.
This was a real doozie. It boiled down to a frame
attempting to access a siblings window object when that
frame wasn't loaded and didn't have a document.

Reviewed by Dave.

  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (FrameArray::get): Made the isSafeScript more tolerant. Always allow JS to execute if the active domain is nil (local). Also allow JS to execute if the target part has no document yet.
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::openURL): (KHTMLPart::jScript): (KHTMLPart::scheduleRedirection): (KHTMLPart::findFrame): Flag redirects during load so we can later avoid cancelling the redirect when the document would otherwise normally load.
  • khtml/khtmlpart_p.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:]): Document may now be nil. Replace assert with conditional check.
4:42 PM Changeset in webkit [4509] by sullivan
  • 3 edits in trunk/WebCore
  • finished fixing crash in 3275675 -- REGRESSION: crash when replacing <div> which contains iframe (at www.kbs.co.kr)

Reviewed by Darin

  • khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): check for nil element() before ref/deref'ing
4:32 PM Changeset in webkit [4508] by cblu
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebDataSource.h: Removed FIXME related to pageTitle.
3:40 PM Changeset in webkit [4507] by cblu
  • 3 edits in trunk/WebKit

<rdar://problem/3283359>: don't load Cocoa Java plug-in if in Carbon app

Reviewed by darin.

  • Plugins.subproj/WebPluginDatabase.h: removed pluginForFilename, wasn't being used
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): don't use the plug-in if ![self isCocoa] && [[[webPlugin bundle] bundleIdentifier] isEqualToString:JavaCocoaPluginIdentifier]
3:39 PM Changeset in webkit [4506] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • first step in fixing 3275675 -- REGRESSION: crash when replacing <div> which contains iframe (at www.kbs.co.kr)
  • khtml/rendering/render_object.h: Made m_node protected, so RenderWidget can zero it out.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach): Set m_node to 0 here. RenderWidget does this strange thing of staying around after the DOM node is gone, but we need to get rid of the dangling pointer to the DOM node.
  • khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): Do nothing if element() is 0, since we are on our way out anyway. (RenderPartObject::slotViewCleared): Ditto.
2:29 PM Changeset in webkit [4505] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3284312 -- repro nil-deref in khtml::RenderTable::cellAbove at pi.nersc.gov

Reviewed by Darin

  • khtml/rendering/render_table.cpp: (RenderTable::cellAbove): When the section had 0 rows, we were trying to index the -1st row. Fixed by falling into the "didn't find anything" case when the row we're going to look in is < 0.
2:16 PM Changeset in webkit [4504] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3284848>: REGRESSION: repro crash in Flash handling null event, going back to Japanese Disney page

When restarting plug-ins from the BF cache, we were not calling NPP_SetWindow.

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView stop]): set the window type to 0 to force the calling of NPP_SetWindow
12:40 PM Changeset in webkit [4503] by darin
  • 3 edits in trunk

Removed misleading Safari-74 markers.

12:36 PM Changeset in webkit [4502] by darin
  • 20 edits in trunk/WebCore

Reviewed by John.

  • fixed 3277733 -- REGRESSION: \ in JavaScript mishandled when encoding is Japanese (istweb.apple.com)

This is the third time I've fixed handling of backslash and yen sign. Each time I fixed part
of the problem but either didn't fix the whole thing or caused a regression. This time I did
more experiments with other browsers, and I came to the conclusion that all other browsers keep
the backslash character internally unchanged, and only change to the yen sign when displaying
rather than decoding to the Unicode "yen sign" character. This makes the backslash character
different from any other, and requires special code, but it's the only way to match the other
browsers' behavior. This seems to work great; I retested all the backslash/yen bugs from the
past to make sure I didn't cause new regressions. The only loose end is the DOM API. It's not
clear whether the DOM API should return the strings with backslashes or with yen signs, but
we can probably ship 1.0 without getting that 100% right.

  • kwq/KWQTextCodec.h: Added backslashAsCurrencySymbol() member function.
  • kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Removed the old workaround for tilde problems, which is not needed now that we are back to using "force ASCII" mode, so tildes are always tildes. Updated the comment about the backslash hack to better reflect the new situation and change it to use the new backslashAsCurrencySymbol() member function. (QTextCodec::backslashAsCurrencySymbol): Added. Returns the yen sign for the encodings where it's appropriate. Later might do the same thing with the won sign for Korean, depending on what we discover as we research bug 3221037 (Korean currency symbol should replace backslash). (KWQTextDecoder::convertUsingTEC): Add back the call to TECSetBasicOptions since we once-again want to use force-ASCII mode; we turn backslashes into yen signs at a higher level now; internally they are kept as backslashes.
  • khtml/xml/dom_docimpl.h: Made setDecoder no longer be inline, and added a decoder member function so callers could get the decoder (they need it to figure out what to do with backslashes).
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setDecoder): Made this no longer be an inline. Also made sure it derefs the existing decoder. This probably does not happen in practice, but the old version would leak if it was ever called twice on the same document.
  • kwq/KWQString.mm: (QString::replace): Made sure that the case of replacing a character with the same character has an early out, since that's now the common case with this "map backslash to currency character if needed" feature.
  • khtml/xml/dom_stringimpl.h: Made capitalize() const and added a new replace() member function.
  • khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::replace): Implemented this new function that replaces one character with another. Returns the existing string if there is no replacing to do, otherwise makes a new one.
  • khtml/rendering/render_object.h: Added backslashAsCurrencySymbol() member function.
  • khtml/rendering/render_object.cpp: (RenderObject::backslashAsCurrencySymbol): Added. Helper function so render objects have an easier time digging for the "do I need to turn the backslashes into currency symbols" flag.
  • kwq/KWQKHTMLPart.h: Added backslashAsCurrencySymbol() member function.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setTitle): Convert title to use yen sign. (KWQKHTMLPart::setStatusBarText): Convert status bar text to use yen sign. (KWQKHTMLPart::runJavaScriptAlert): Convert message text to use yen sign. (KWQKHTMLPart::runJavaScriptConfirm): Convert message text to use yen sign. (KWQKHTMLPart::runJavaScriptPrompt): Convert message text and default value to use yen sign, convert result back from yen sign to backslash. (KWQKHTMLPart::attributedString): Convert pieces of text to use yen sign when building up the attributed text. (KWQKHTMLPart::backslashAsCurrencySymbol): Added. Helper function so render objects have an easier time digging for the "do I need to turn the backslashes into currency symbols" flag.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedString]): Convert text to use yen sign before returning to WebKit. (-[WebCoreBridge elementAtPoint:]): Convert title and alt strings to use yen sign before returning them to WebKit.
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Convert button label to use yen sign. (RenderLineEdit::updateFromElement): Convert text for line edit to use yen sign. (RenderLineEdit::slotTextChanged): Convert yen sign to backslash on the way in from line edit. (RenderSelect::updateFromElement): Convert text for select items to use yen sign. (RenderTextArea::updateFromElement): Convert text for text areas to use yen sign. (RenderTextArea::text): Convert yen sign to backslash on the way in from text area.
  • khtml/rendering/render_image.cpp: (RenderImage::paintObject): Convert alt text to use yen sign before drawing it.
  • khtml/rendering/render_text.cpp: (RenderText::RenderText): Convert text to use yen sign before drawing it. (RenderText::setText): Ditto.
  • fix a problem that was bugging the shit out of me where we kept rebuilding config.h
  • Makefile.am: Use the config-timestamp file to decide when to remake config.h so we don't end up making it over and over again. Also don't bother to grep out NO_LICENSE any more since that's long gone.
  • .cvsignore: Ignore the config-timestamp file.
9:40 AM Changeset in webkit [4501] by sheridan
  • 3 edits in trunk

Safari-84u

9:34 AM Changeset in webkit [4500]
  • 3 copies in tags/Safari-83

This commit was manufactured by cvs2svn to create tag 'Safari-83'.

9:34 AM Changeset in webkit [4499] by sheridan
  • 8 edits in trunk

Safari-83

8:42 AM Changeset in webkit [4498] by darin
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3280538 -- JavaScript infinite loop loading frame b/c scrollHeight is always zero (easons.ie)
  • khtml/xml/dom_docimpl.h: Added updateLayout method.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateLayout): Added. Code moved here from KJS::Window::updateLayout so it can be shared. Named this updateLayout() to match the name from KJS::Window.
  • khtml/ecma/kjs_window.cpp: (Window::updateLayout): Call updateLayout() instead of updateRendering(); the extra logic here was moved into updateLayout().
  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Call updateLayout() on the document before computing the BodyScrollHeight or BodyScrollWidth, much as we already do in kjs_dom.cpp for ScrollHeight and ScrollWidth and other properties.

Jun 7, 2003:

5:59 PM Changeset in webkit [4497] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
5:51 PM Changeset in webkit [4496] by darin
  • 3 edits in trunk/WebKit

Rolled out Chris's fix for 3156169 because it was causing a lot of crashes
and problems with basic behavior. We can try again later.

One of the problems was that Back wasn't working. Another was that you could
not follow the link at the top of the page at kbb.com. More testing seemed to
reveal still more problems.

  • WebView.subproj/WebFramePrivate.h: Rolled back to previous version.
  • WebView.subproj/WebFramePrivate.m: Ditto.

Jun 6, 2003:

4:48 PM Changeset in webkit [4495] by rjw
  • 2 edits in trunk/WebKit

Fixed 3283236. Remove use of forward declarations in public header because
CodeWarrior pukes on 'em.

Reviewed by Chris.

  • WebView.subproj/WebDataSource.h:
4:22 PM Changeset in webkit [4494] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win

Reviewed by darin.

  • WebView.subproj/WebFramePrivate.h: added policyDataSource and policyLoadType as ivars
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): added ASSERT (-[WebFramePrivate setProvisionalDataSource:]): added ASSERT (-[WebFrame _isLoadComplete]): formatting tweak (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): clear policyDataSource (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): formatting tweak (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): retain policyDataSource (-[WebFrame _continueAfterNavigationPolicy:]): stop the load, set the load type, set the provisional data source in the "use" case (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): formatting tweak (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): don't reset things if something other than "use" has been chosen (-[WebFrame _loadDataSource:withLoadType:formState:]): DON'T stop the load, set the load type, set the provisional data source
3:53 PM Changeset in webkit [4493] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3282881>: Java plugin fails in carbon WebKit apps

Fixed by Mike Hay, reviewed by me.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase initIsCocoa]): (-[WebPluginDatabase isCocoa]): (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): don't load cocoa plug-ins if isCocoa.
10:47 AM Changeset in webkit [4492] by sheridan
  • 3 edits in trunk

v83u, forgot to do this after the build on Tuesday

3:31 AM Changeset in webkit [4491] by hyatt
  • 3 edits in trunk/WebCore

Fix for crash on an XHTML frameset page. It was assuming
that all docs were HTML. The bug # is 3277973.

Reviewed by john

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::updatePolicyBaseURL): (KWQKHTMLPart::setPolicyBaseURL):

Jun 5, 2003:

12:24 PM Changeset in webkit [4490] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/html_headimpl.h

* empty log message *

12:05 PM Changeset in webkit [4489]
  • 1 copy
    79 deletes in branches/unlabeled-1.35.18

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.18'.

12:05 PM Changeset in webkit [4488] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3281030, stylesheets can't be enabled properly via
script. Test case from Dirk. The fix is to make the setting
of the state happen independently of the attribute setting.

Reviewed by john

  • khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setDisabledState): (HTMLLinkElementImpl::parseAttribute):
  • khtml/html/html_headimpl.h:
11:36 AM Changeset in webkit [4487] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/3268751>: REGRESSION: crash in KWQValueListImpl selecting connection speed at news.com

Reviewed by darin.

  • kwq/KWQButton.mm: (QButton::clicked): Don't call clicked if the button was destroyed inside of sendConsumedMouseUpIfNeeded.
11:23 AM Changeset in webkit [4486] by sullivan
  • 8 edits in trunk/WebKit
  • fixed 3266216 -- repro crash in -[WebBaseResourceHandleDelegate connection:didReceiveData:] in GIA Application

The problem was that an NSURLConnection delegate object (in this
case a WebMainResourceClient) was being dealloc'ed during one of
its connection delegate methods. To prevent this kind of problem,
I added [self retain]/[self release] guards around the meat of
all of the connection delegate methods in which arbitrary code
could be run. Another approach would be to do this retain/release
pair in NSURLConnection, but Darin deemed it wiser not to muck with
Foundation at this point for this issue.

Reviewed by Darin

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): guard with [self retain]/[self release] (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveResponse:]): ditto (-[WebSubresourceClient connection:didReceiveData:]): ditto
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): ditto. Also, commented out two assertions that fire illegitimately in the steps in this bug report. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): ditto (-[WebMainResourceClient connection:didReceiveResponse:]): ditto (-[WebMainResourceClient connection:didReceiveData:]): ditto
9:47 AM Changeset in webkit [4485] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3279206 -- REGRESSION: new page does not load after selecting item from list and hitting 'Go' button
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding): Use value() in a couple of places that were still directly using m_value.
8:41 AM Changeset in webkit [4484] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3278079 -- REGRESSION: UTF-8 page claiming to be UTF-16 in XML header gives garbage characters
  • khtml/misc/decoder.cpp: (Decoder::setEncoding): Add EncodingFromXMLHeader as one of the types where we know the encoding is an 8-bit one. The reason this is a regression is that we used to ignore the encoding in the XML header altogether.

Jun 4, 2003:

5:26 PM Changeset in webkit [4483] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3279957 -- REGRESSION: assertion failure at launch in Decoder::~Decoder() importing bookmarks

Richard actually wrote this fix.
Reviewed by me, Darin

  • kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): don't use stack-based decoder; use new instead.
5:11 PM Changeset in webkit [4482] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3224031 -- can't search at rakuten.co.jp b/c of extra characters inserted by regexp replace (8-bit char)

Use PCRE UTF-8 regular expressions instead of just chopping off high bytes.

  • kjs/regexp.h: Redo field names, remove some unused stuff.
  • kjs/regexp.cpp: (convertToUTF8): Added. (compareStringOffsets): Added. (createSortedOffsetsArray): Added. (convertCharacterOffsetsToUTF8ByteOffsets): Added. (convertUTF8ByteOffsetsToCharacterOffsets): Added. (RegExp::RegExp): Set the PCRE_UTF8 flag, and convert the UString to UTF-8 instead of using ascii() on it. (RegExp::~RegExp): Remove unneeded if statement (pcre_free is 0-tolerant as free is). (RegExp::match): Convert the UString to UTF-8 and convert the character offsets to and from UTF-8 byte offsets. Also do fixes for the "no offset vector" case so we get the correct position and matched string.
  • JavaScriptCore.pbproj/project.pbxproj: Add a PCRE header that was missing before.
3:59 PM Changeset in webkit [4481] by rjw
  • 3 edits in trunk/WebKit

Fixed 3277775. Send less notifications. Notifcations suck!

Reviewed by David.

  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate init]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]):
3:12 PM Changeset in webkit [4480] by darin
  • 4 edits in trunk/WebKit

Reviewed by John.

  • fixed 3277675 -- REGRESSION: mouse wheel events not coalesced
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): When the mask is scroll wheel mask, instead of getting no events, do some tricks to get the next event if it is a scroll wheel event, and nothing otherwise. Also ifdef the fix so we don't compile it on Panther, since the underlying bug was fixed on Panther.
  • other changes
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): Remove unneeded line of code. The super function copies all simple fields for us.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setMIMEType:]): Use copy instead of retain, do it in the right order to avoid "same object release/retain" disease. (-[WebBaseNetscapePluginView setBaseURL:]): Do retain before release (same reason as above).
1:35 PM Changeset in webkit [4479] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3273300, leaks in cssyyparse. Function forgot to delete
its args value list when destroyed.

Reviewed by gramps

  • khtml/css/cssparser.h:

Jun 3, 2003:

7:45 PM Changeset in webkit [4478] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request

Reviewed by rjw.

  • Misc.subproj/WebDownload.m: (-[WebDownload initWithRequest:delegate:]): (-[WebDownload _initWithRequest:delegate:directory:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setNeedsDisplay:]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):

WebBrowser:

Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request

Reviewed by rjw.

  • DownloadMonitor.m: (-[DownloadMonitor downloadDidBegin:]): (-[DownloadMonitor startDownloadForRequest:mayOpenWhenDone:]):
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):

WebKitExamples:

Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request

Reviewed by rjw.

  • CarbonDownloader/CarbonURLDownload.mm: (CarbonURLDownload::CarbonURLDownload):
  • Downloader/MyDocument.m: (-[MyDocument downloadOrCancel:]): (-[MyDocument savePanelDidEnd:returnCode:contextInfo:]): (-[MyDocument download:didFailWithError:]):
3:58 PM Changeset in webkit [4477] by rjw
  • 3 edits in trunk/WebKit

Fixed 3263188, 3274636.

Written by Ed Voas. Reviewed by Richard.

  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): Ensure the process info is correctly initialized so the correct "flavour" (carbon) is detected.
  • Carbon.subproj/HIWebView.m: (Draw): Always draw the growbox after drawing the web view, assuming overlap.
3:03 PM Changeset in webkit [4476] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3259647, crash when printing a table page. This is fixed
on the KDE KHTML trunk. The loop shouldn't be broken out of
when you have column elements so that all sections can recalc
their cell grids as needed.

Reviewed by kocienda

  • khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
2:46 PM Changeset in webkit [4475]
  • 3 copies in tags/Safari-82

This commit was manufactured by cvs2svn to create tag 'Safari-82'.

2:46 PM Changeset in webkit [4474] by sheridan
  • 8 edits in trunk

v82 stamp

2:36 PM Changeset in webkit [4473] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3167792>: hang in _web_dragPromisedImage dragging 4 MB image

Reviewed by john.

  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): if the original image is greater than 1500x1500, use a file icon for the drag image to avoid hanging
12:47 PM Changeset in webkit [4472] by rjw
  • 8 edits in trunk/WebCore

Fixed 3275565. Ref count the decoder.

Reviewed by Ken.

  • khtml/khtml_part.cpp: (KHTMLPart::clear):
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
  • khtml/misc/decoder.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl):
  • khtml/xml/dom_docimpl.h:

Jun 2, 2003:

3:59 PM Changeset in webkit [4471] by rjw
  • 4 edits in trunk/WebKit

Fix for 3250352.

Reviewed by Chris.

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Check respondsToSelector: before calling.
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebUIDelegate.h: Headerdoc tweaks.
3:41 PM Changeset in webkit [4470] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3276099. value() was wrong for radio buttons. Needed
to get it from the attribute since I was no longer caching
anything in m_value.

Reviewed by kocienda

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value):
2:29 PM Changeset in webkit [4469] by kocienda
  • 3 edits in trunk/WebCore

Code written by darin
Reviewed by me

Fix for this bug:

<rdar://problem/3272162>: repro crash in khtml::CachedImage::checkNotify() on particular page

  • khtml/ecma/kjs_html.cpp: (Image::putValue): ref onLoadListener when setting a value to onLoad (Image::~Image): deref onLoadListener when destructing the image.
2:12 PM Changeset in webkit [4468] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3263679, color: # doesn't parse. Fix is to add an
error-handling case for # by itself to parser.y.

Reviewed by gramps/ken

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
1:18 PM Changeset in webkit [4467] by sheridan
  • 3 edits in trunk

v82u

12:47 PM Changeset in webkit [4466]
  • 3 copies in tags/Safari-81

This commit was manufactured by cvs2svn to create tag 'Safari-81'.

12:47 PM Changeset in webkit [4465] by sheridan
  • 8 edits in trunk

v81 stamp

11:42 AM Changeset in webkit [4464] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3256787 -- HOMEPAGE:\000 characters being added by Safarin in Form submission, causing an exception in property list parsing
  • kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Encode \ as 5C instead of 815F when encoding Shift-JIS. This should make the Apple Store work again. The only thing we lose is the ability to send an actual Shift-JIS backslash (815F), but I think that is almost never needed. In other browsers you can't even type a backslash in Shift-JIS.
10:56 AM Changeset in webkit [4463] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3154910>: No video when viewing QT plug-in content at some pages but audio works

This fix works around QT plug-in bug 3275755, but I think the fix is logical and worth keeping even after 3275755 is fixed.

Eric Carlson:
The problem happens when you call NPP_SetWindow with a 0 width or height more than once. The first call to NPP_SetWindow always seems to have width and height set to 0, but the next call sometimes has it set to the correct values (those in the EMBED tag). This is when it draws successfully. It seems to me that the fix is to always pass the correct width and height to NPP_SetWindow. You always position the plug-in far offscreen (1000000, -52) and set the clip region to an empty rect (48576, 52, 48576, 52) so there isn't really any danger of the plug-in drawing anyway. Additionally, you pass the correct width and height in the call to NPP_New before the first call to NPP_SetWindow.

Reviewed by john, darin.

  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): use the NSView width and height if greater than 0, else use the tag specified width and height (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): new (-[WebBaseNetscapePluginView setWindow]): NPP_SetWindow may be expensive, only call it if it has changed
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): tweak, no need to store error code since it is ignored
9:25 AM Changeset in webkit [4462] by kocienda
  • 3 edits in trunk/WebCore

top level:

Reviewed by John

  • configure.in: Removed unneeded configure-time checks for Foundation. Added check to see if there is a Foundation tree checked out. Added HAVE_FOUNDATION_SOURCES macro to config.h.

Tests:

Reviewed by John

Tweaked path in Makefile.am so that tests can find private
Foundation headers using new configure-time checks.

Modified tests to be "skippable" based on whether there is
a Foundation tree checked out and HAVE_FOUNDATION_SOURCES
is set in config.h.

Modified test harness so that it knows how to skip tests.

  • CookieManager/Makefile.am:
  • CookieManager/wkcookiemanager-test.m: (main):
  • WebFoundation-Misc/Makefile.am:
  • WebFoundation-Misc/ifnsarrayextensions-test.m: (main):
  • WebFoundation-Misc/ifnscalendardateextensions-test.m: (main):
  • WebFoundation-Misc/ifnsobjectextensions-test.m: (main):
  • WebFoundation-Misc/ifnsstringextensions-test.m: (main):
  • WebFoundation-Misc/ifnsurlextensions-test.m: (main):
  • WebFoundation-Misc/ifreadwritelock-test.m: (main):
  • WebFoundation-Misc/ifrecursivereadwritelock-test.m: (main):
  • WebFoundation-Misc/ifurlparsing-test.m: (main):
  • harness.c: (runtest):

WebCore:

Reviewed by NOBODY (OOPS!).

  • config.h:
3:07 AM Changeset in webkit [4461] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3275136. Make sure that when the checked attribute
is set dynamically (something we were ignoring before my previous
patch) that we also properly update the radio button array in
the document.

Reviewed by gramps

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset):

May 30, 2003:

7:04 PM Changeset in webkit [4460] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Chris.

  • fixed 3169067 - PEOPLESOFT: left frame missing; frame RenderRoot height and width are both zero
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
6:54 PM Changeset in webkit [4459] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): Return null when the ID is the empty string. Otherwise we'll return the first element in the document, usually the top-level HTML element, which is wrong and does not match other browsers.
5:37 PM Changeset in webkit [4458] by rjw
  • 11 edits in trunk

WebKit:

Fixed 3272516. Items are now expired from the
b/f cache if they are older than 30 minutes. This
number was pulled out of our #!$es. Also did
some cleanup of the b/f cache code.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentToPageCache:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _resourceTimedLayoutEnabled]): (-[WebPreferences _backForwardCacheExpirationInterval]):
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebPreferences.h: Cleaned up some headerdoc comments.

WebCore:

As part of some cleanup when fixing 3272516 changed use of
@"" for cache keys to NSString declarations.

Reviewed by Ken.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
4:21 PM Changeset in webkit [4457] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3269129 and 3269220. setAttribute('value') didn't work
for inputs. Basically defaultValue and defaultChecked have never
worked. This patch fixes the problem by making sure that for both
value and checked you have a two-tier system where you look first
for the value as altered by the control (or by setting the DOM
property) and if that isn't set then you look at the default value.

This allows setAttribute (which changes the *default*) to work in
the cases where the control has not overridden the default
with a different value.

Reviewed by NOBODY (OOPS!).

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): (HTMLInputElementImpl::state): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::value): (HTMLInputElementImpl::setValue): (HTMLInputElementImpl::isCheckedRadioButtonForDocument):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::calcMinMaxWidth): (RenderLineEdit::updateFromElement): (RenderLineEdit::slotTextChanged):
  • khtml/rendering/render_form.h:
4:08 PM Changeset in webkit [4456] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • added "sjis" as a synonym for "Shift_JIS"; this might fix 3235161, HOMEPAGE: Publishing page with Japanese characters w/ Safari generates an error, but I am currently unable to test the fix.
  • kwq/mac-encodings.txt: Added sjis to the Shift_JIS line.
  • kwq/KWQCharsetData.c: Regenerated.
10:41 AM Changeset in webkit [4455] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3263156, stack overflow at www.liceo.edu.mx. This
site nests about 500 bold tags, only closes some of them,
and then opens 500 more, etc.

The fix for this problem is to stop honoring tags in the parser
after you see 20 identical tags. We do this only for fontstyle HTML
tags.

Reviewed by john/darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement): (KHTMLParser::allowNestedRedundantTag):
  • khtml/html/htmlparser.h:
10:23 AM Changeset in webkit [4454] by sullivan
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by Chris

  • khtml/rendering/break_lines.cpp: Removed #ifdef/#else for which the two sides were identical that I noticed in passing.

WebBrowser:

  • fixed 3273444 -- Window title leaks when window is closed

Reviewed by Chris

  • BrowserWindow.m: (-[BrowserWindow dealloc]): release _title here, because there's a leftover retain from the last setTitle to enable our delay-title-change-for-performance hack.

May 29, 2003:

7:55 PM Changeset in webkit [4453] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3270373 - MALLORY: repro crash in +[KWQObjectTimerTarget stopDeferringTimers] while changing folder
  • kwq/KWQObject.mm: (QObject::killTimer): Remove the timer from the deferred list too - clients expect that a timer will never be delivered after the object was killed. (QObject::killTimers): Use killTimer on each timer for this object instead of trying to be tricky. (-[KWQObjectTimerTarget timerFired]): Don't add a timer to the deferred list more than once, because there's no benefit in ganging up multiple firings while deferred, and it makes other things simpler. (+[KWQObjectTimerTarget stopDeferringTimers]): Make sure to remove the timer before firing it, since it may also cancel itself, and we don't want to remove an extra timer in that case.
6:55 PM Changeset in webkit [4452] by rjw
  • 18 edits in trunk

WebKit:

* Public API change *
This API addition will be used (in some fashion) for Scott's WWDC
demo.

Implemented 'estimatedProgress' method on WebView. This should
eventually replace the broken algorithm on WebBrowser. Maybe
for panther.

Reviewed by Chris.

  • WebKit.exp:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): (-[WebFrame _numPendingOrLoadingRequests:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView estimatedProgress]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): (-[WebView _isPerformingProgrammaticFocus]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (-[WebView _completeProgressForConnection:]):

Code cleanup. Moved variable initialization into block that
check for non-nil self.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):

WebCore:

Support for the 'estimatedProgress' method on
WebView. Added bridge access to the number of pending or still
loading requests (from KHTML's perspective). This is used to
more accurately guess at the total remaining bytes to load.

Reviewed by Chris.

  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQNumberOfPendingOrLoadingRequests):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge numPendingOrLoadingRequests]):
5:59 PM Changeset in webkit [4451] by rjw
  • 2 edits in trunk/WebKit

Fixed 3272226. The shared image factory was being released
when any renderer had 0 reps!

Reviewed by John.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]):
3:54 PM Changeset in webkit [4450] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open

Reviewed by rjw.

  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): return NSDragOperationNone is the app has a modal window so the current page can't be changed with a drag
  • WebView.subproj/WebView.m: (-[WebView draggingEntered:]): return _web_dragOperationForDraggingInfo

WebBrowser:

Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open

Reviewed by rjw.

  • BrowserApplication.m: (-[BrowserApplication beginModalSessionForWindow:]): disable dragging app-wide (-[BrowserApplication endModalSession:]): renable dragging app-wide
3:44 PM Changeset in webkit [4449] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3271697>: Search fails at travel site

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::parseAttribute): Allow form method to be set to GET from javascript.
3:42 PM Changeset in webkit [4448] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3273109 - leak from functionPointerForTVector in -[WebNetscapePluginPackage load]

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): free the main function after using it
3:37 PM Changeset in webkit [4447] by rjw
  • 2 edits in trunk/WebKit

Fixed 3273115. Always use pixel dimensions,
not absolute dimensions.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
1:00 PM Changeset in webkit [4446] by rjw
  • 2 edits in trunk/WebKit

Fix 3272292. Ensure that loadStatus is always
initialized to NSImageRepLoadStatusUnknownType.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):
12:09 PM Changeset in webkit [4445] by sullivan
  • 3 edits in trunk/WebCore
  • fixed MIME type leaks that were most of 3272566 (several leaks after visiting amazon.com and emptying cache)

Reviewed by Darin

  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::operator=): fixed two leaks of MIME string
8:59 AM Changeset in webkit [4444] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3269564 -- dynamically-created forms look right, but don't post values when submitted
  • khtml/html/html_formimpl.h: Remove useless virtual setParent function. Since the inherited setParent is not virtual, it does no good to make the subclass override it with a virtual function.
  • khtml/html/html_formimpl.cpp: Remove useless virtual setParent. (HTMLGenericFormElementImpl::attach): Add code here, cribbed from setParent, to add a new form element to the form it's in. (HTMLButtonElementImpl::attach): A copy of the code is also needed here.
  • WebCore.pbproj/project.pbxproj: Let Project Builder be Project Builder.
8:57 AM Changeset in webkit [4443] by kocienda
  • 5 edits in trunk/WebKit

Reviewed by Richard

Fix for this bug:

Radar 3260323 (Some links at nike.com cause assertion failure
(connectionDidFinishLoading sent after cancel))

Added a flag which is set when a load is cancelled. This flag prevents
bad behvior when loads that finish cause the load itself to be
cancelled (which could happen with a javascript that changes the
window location). This is used to prevent both the body of
cancelWithError: and the body of connectionDidFinishLoading: running
for a single delegate. Cancelling wins.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):

May 28, 2003:

4:53 PM Changeset in webkit [4442] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3263157 - REGRESSION: tabbing into a secure password field shows contents
  • kwq/KWQTextField.mm: (-[KWQSecureTextField textDidEndEditing:]): Make sure to restore bullet mode if we accidentally lose it.
1:52 PM Changeset in webkit [4441] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3270576 - RealPlayer plug-in fails to load

Reviewed by darin.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): new (-[WebNetscapePluginPackage load]): call launchRealPlayer to regenerate its broken plist file
1:47 PM Changeset in webkit [4440] by rjw
  • 4 edits in trunk/WebKit

Fixed 3165631 (and other similar).
Fixed 3262592.

We now set NSImage's cache mode to NSImageCacheNever during
progressive loads. It gets reset to NSImageCacheDefault when
loads complete.

If an image is scaled, NSImage appears to create a NSCacheImageRep
with the wrong size during progessive image loading. Specifically
it appears to create a cached rep with the original size.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]):
  • WebView.subproj/WebPreferences.h: Updated headerdoc comments.
10:38 AM Changeset in webkit [4439] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: 3233442 - Crash in -[WebNetscapePluginPackage load] at ​http://www.adultswim.com/

Reviewed by mjs.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): don't call NPP_Shutdown if the plug-in fails to load

WebBrowser:

Fixed: 3271123 - "Plug-in not supported" error when Real fails to load

Reviewed by john.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]): only show the "plug-in not supported" dialog for WMP

May 27, 2003:

5:20 PM Changeset in webkit [4438] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Don't load and save icons if the icon DB directory default is not set.

Reviewed by darin.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): don't create the DB if the default is not set (-[WebIconDatabase _loadIconDictionaries]): don't load the dictionaries if the DB doesn't exist (-[WebIconDatabase _updateFileDatabase]): don't update the DB if it doesn't exist
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): don't load icons if the icon DB directory default is not set

WebBrowser:

Moved the icon DB to ~/Library/Safari/Icons

Reviewed by darin.

  • AppController.m: (+[AppController initialize]): move the icon DB (+[AppController _settingsDirectoryPath]): made this a class method (-[AppController settingsDirectoryPath]): call the class method
4:22 PM Changeset in webkit [4437] by mjs
  • 3 edits in trunk/WebCore

Rolled in fix from Safari-80~1-branch

2003-05-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
4:22 PM Changeset in webkit [4436] by mjs
  • 2 edits in trunk/WebKit

Rolled in fix from Safari-80~1-branch

2003-05-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
4:12 PM Changeset in webkit [4435]
  • 3 copies
    2 deletes in tags/WebKit-80~1

This commit was manufactured by cvs2svn to create tag 'WebKit-80~1'.

4:12 PM Changeset in webkit [4434] by mjs
  • 2 edits in branches/Safari-80~1-branch/WebKit

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Updated version to 80.1.
4:12 PM Changeset in webkit [4433]
  • 6 copies
    2 deletes in tags/WebCore-80~1

This commit was manufactured by cvs2svn to create tag 'WebCore-80~1'.

4:12 PM Changeset in webkit [4432] by mjs
  • 3 edits in branches/Safari-80~1-branch/WebCore

Reviewed by Darin.

  • WebCore.pbproj/project.pbxproj: Updated version to 80.1.
4:11 PM Changeset in webkit [4431] by mjs
  • 3 edits in branches/Safari-80~1-branch/WebCore

Reviewed by Darin.

  • WebCore.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
4:09 PM Changeset in webkit [4430] by mjs
  • 2 edits in branches/Safari-80~1-branch/WebKit

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
3:03 PM Changeset in webkit [4429] by rjw
  • 2 edits in trunk/WebKit

Fix for IB.

Reviewed by Eric Seymour.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Added retain to uniqued instance. (As we did recently for initWithCoder:).
2:50 PM Changeset in webkit [4428] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3270013 - Exception raised when visiting ​http://www.shutterfly.com/favicon.ico

Reviewed by john.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]): return nil if the image has no representations
1:50 PM Changeset in webkit [4427] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3242864 - repro assertion failure in WebIconDatabase.m for www.shutterfly.com

Reviewed by john.

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): don't set the icon on the DB if it has no representations
1:04 PM Changeset in webkit [4426] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3268589, static position miscomputed when the positioned object is the last item in its enclosing block and when its previous sibling is a text run that ends in a space. In this case we need to clear our trailingSpaceObject so that we don't mistakenly ignore the positioned object when building up bidi runs.

Fix for 3260053, table-layout of inherit not supported. This
caused a crash. The fix is to just add in the support for the inherit
value to the style selector.

Reviewed by john

  • khtml/rendering/bidi.cpp:
  • khtml/css/cssstyleselector.cpp
11:34 AM Changeset in webkit [4425] by rjw
  • 3 edits in trunk/WebKit

Fixes for IB.

Reviewed by Eric Seymour.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added retain to uniqued instance
  • WebView.subproj/WebView.m: (-[WebView initWithCoder:]): (-[WebView setPreferences:]): Added release check to global uniquing dictionary.

May 26, 2003:

1:49 PM Changeset in webkit [4424] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3262849 -- jump to nil in KWQKHTMLPart::searchForLabelsAboveCell at techbargains.com

Reviewed by Dave

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): check for nil result of cellAboveRenderer->element()

May 23, 2003:

5:29 PM Changeset in webkit [4423] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3229799, images missing on geocities page. Residual style
needs to understand when you reopen tags at a malformed table
content boundary and make sure the newly-reopened tags also know
they are malformed table content so that they get cleaned up
properly.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock):
  • khtml/html/htmlparser.h:
4:56 PM Changeset in webkit [4422] by rjw
  • 4 edits in trunk/WebKit

Tweaks for IB.
Updated WebView and WebPreferences to use
keyed archiving.
Added private method to export settable user
defaults keys.

Reviewed by Ken.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]): (+[WebPreferences _userDefaultsKeysForIB]):
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView initWithCoder:]):
3:22 PM Changeset in webkit [4421] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3248176, failed assertion on blizzard's world of warcraft
page. They dynamically changed the position of an element from
absolute to relative, and this element was inside an inline.
The setStyle() code has to be smart enough to split the inline
flow when the element is no longer absolute positioned.

This patch makes a splitFlow occur like it should and it also
cleans up anonymous block creation with a new helper function
on RenderObject, createAnonymousBlock.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
  • khtml/rendering/render_object.cpp: (RenderObject::createAnonymousBlock): (RenderObject::handleDynamicFloatPositionChange): (RenderObject::setStyle):
  • khtml/rendering/render_object.h:
2:30 PM Changeset in webkit [4420] by rjw
  • 2 edits in trunk/WebKit

Added export of _WebHistoryItemChangedNotification.

  • WebKit.exp:
12:36 PM Changeset in webkit [4419] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: 3259426 - Can't copy mailto links to clipboard

Reviewed by john.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): offer "Copy Link to Clipboard" for all links

WebBrowser:

Fixed: 3259426 - Can't copy mailto links to clipboard

Reviewed by john.

  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): don't offer "Add Link to Bookmarks" for links we can't handle inline

May 22, 2003:

6:14 PM Changeset in webkit [4418] by rjw
  • 3 edits in trunk/WebKit

* Public API change *
100% compatible. Added notification when history items
change values.

Fixed 3265672
Reviewed by John.

  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem setURL:]): (-[WebHistoryItem setOriginalURLString:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem _setLastVisitedTimeInterval:]):
5:04 PM Changeset in webkit [4417] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3259947. Can't add clippings on iht.com. The fix is
to make sure all DOM properties that relate to attributes return ""
and not "null" when the attribute isn't present or when the
DOMString is null.

Also patching the code for text-indent to make sure that floats
don't improperly consume text-indent. This fixes two of the issues
on diveintomark.

Reviewed by mjs

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::getValueProperty):
1:39 PM Changeset in webkit [4416] by rjw
  • 3 edits in trunk/WebKit

Fixed 3266464. Build problem on panther caused by overly
pedantic gcc.

Reviewed by John.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]):
  • WebView.subproj/WebView.m: (-[WebView initWithCoder:]):
1:21 PM Changeset in webkit [4415] by rjw
  • 2 edits in trunk/WebKit

Add _web to method in category name.

Fixed 3266102. @selector missing ":".

Reviewed by Darin.

  • WebView.subproj/WebPreferences.m: (+[WebPreferences _removeReferenceForIdentifier:]): (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]):
11:21 AM Changeset in webkit [4414] by hyatt
  • 4 edits in trunk/WebCore

Make sure the overflow clip rect clips out the scrollbars
so that child layers aren't able to draw on top of the
scrollbars.

Also fix scrollbars so that they are painted before the
overflow clip rect is applied (just as backgrounds and borders
are).

These two fixes make the divtest example from Yahoo (sent by Mark
Malone) work.

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_layer.cpp: (RenderLayer::paint):
9:55 AM Changeset in webkit [4413] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • removed all entries except for jaguar.com because:

a) most of these sites now work fine without the spoofing or have gone away
b) nj.com and oregonlive.com do not work, but the spoofing committee (Mark,

Don, Dave, and me) decided we should stop spoofing and get them to fix
the sites instead

If we can resolve jaguar.com in a similar way, we can remove the spoofing
feature altogether.

  • WebView.subproj/WebUserAgentSpoofTable.gperf: Removed all but jaguar.com.
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
9:46 AM Changeset in webkit [4412] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3216039 -- calls to m_redirectionTimer.stop() do not always clear m_scheduledRedirection
  • khtml/khtml_part.h: Added cancelRedirection().
  • khtml/khtml_part.cpp: (KHTMLPart::~KHTMLPart): Call cancelRedirection() instead of m_redirectionTimer.stop(). (KHTMLPart::restoreURL): Ditto. (KHTMLPart::openURL): Ditto. (KHTMLPart::closeURL): Ditto. (KHTMLPart::cancelRedirection): Added. Sets m_scheduledRedirection to noRedirectionScheduled and calls m_redirectionTimer.stop(), but is also safe to call after d is set to 0. (KHTMLPart::restoreState): Call cancelRedirection() instead of m_redirectionTimer.stop().
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Call cancelRedirection() instead of m_redirectionTimer.stop(). (KWQKHTMLPart::scrollToAnchor): Call cancelRedirection() instead of m_redirectionTimer.stop() (and setting m_scheduledRedirection).

May 21, 2003:

10:58 PM Changeset in webkit [4411] by hyatt
  • 7 edits in trunk/WebCore

This patch deals with the main cause of regressions from
the minimum font size removal. Because we stored font sizes
as integers, we ended up flooring font sizes, and when percentages
were nested, the magnitude of error increased dramatically.

This patch changes FontDef to store a float size instead of an
integer size. The style system thus always computes a precise
floating point value for a font, with no error introduced and
only once it has that final computed value does it round to the
nearest pixel for the QFont.

This fixes 3265628, www.anandtech.com.

Reviewed by rjw

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat):
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/font.cpp: (Font::update):
  • khtml/rendering/font.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):
8:52 PM Changeset in webkit [4410] by rjw
  • 6 edits in trunk/WebKit

* Public API Change *
The fix for 3265442 requires new API. This API is an addition
that is 100% compatible with the existing API.

Provide support for IB to palettize WebView.

Fixed 3265442.
Fixed 3263106.

Reviewed by Chris.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferencesPrivate dealloc]): (-[WebPreferences init]): (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (-[WebPreferences encodeWithCoder:]): (+[WebPreferences standardPreferences]): (-[WebPreferences dealloc]): (-[WebPreferences identifier]): (-[WebPreferences _stringValueForKey:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences autosaves]): (+[WebPreferences _getInstanceForIdentifier:]): (+[WebPreferences _setInstance:forIdentifier:]): (+[WebPreferences _removeReferenceForIdentifier:]): (-[WebPreferences _postPreferencesChangesNotification]): (-[NSMutableDictionary _checkLastReferenceForIdentifier:]):
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView dealloc]): (-[WebView setPreferencesIdentifier:]): (-[WebView preferencesIdentifier]):
5:57 PM Changeset in webkit [4409] by cblu
  • 10 edits in trunk/WebKit

Fixed data source leak when viewing standalone plug-in content.

Reviewed by rjw.

  • Plugins.subproj/WebBaseNetscapePluginStream.h: don't inherit from WebBaseResourceHandleDelegate
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream transferMode]): new
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): don't release the data source (-[WebNetscapePluginRepresentation setDataSource:]): don't retain the data source
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): create a WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream dealloc]): release the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream start]): start the load on the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream stop]): start the load on the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginConnectionDelegate initWithStream:view:]): new class, inherits from WebBaseResourceHandleDelegate (-[WebNetscapePluginConnectionDelegate _releaseResources]): (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]): (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): (-[WebNetscapePluginConnectionDelegate cancel]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate response]): new
5:20 PM Changeset in webkit [4408] by mjs
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3254473 - REGRESSION: nike help page reloads on mouseovers, triggered by onresize function

REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): Go back to checking for at least one layout instead of last layout event time. Measure size in a way that ignores whether the scrollbares are there or not.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove last layout event time and add back laid out at least once boolean.
4:37 PM Changeset in webkit [4407] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3257990, attributes in HTML should always be case-insensitive
when matching CSS attribute selectors. Instead of relying on
the strict mode check, I patched the code to use an isXMLDoc
bool instead.

Also fixing a problem where <pre>s are mistakenly justifying their
text when text-align: justify is set.

Reviewed by kocienda

  • ChangeLog:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/bidi.cpp:
1:10 PM Changeset in webkit [4406] by cblu
  • 2 edits in trunk/WebKit

These problems:
3184359 - icon exception closing window while typing
3245476 - Safari-78 crashes or hangs after IMDB Find and using the history menu to go back ...
are not or are no longer reproducible. They were caused by an exception raised in WebKit.
Since we don't use exceptions in WebKit, I've replaced the exception with an assert.

Reviewed by john.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _releaseFutureIconForURL:]): assert instead of exception if failure
12:03 PM Changeset in webkit [4405] by voas
  • 6 edits in trunk/WebKit

2003-05-21 Ed Voas <​voas@apple.com>

  • fixed 3262868: Update Carbon WebKit API prefixes
  • fixed 3264980: Carbon support in WebKit needs to route mouse events properly

Reviewed by Richard.

  • Carbon.subproj/CarbonUtils.h:
  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (WebConvertNSImageToCGImageRef):
  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (HIWebViewGetWebView): (OwningWindowChanged): (WindowHandler): (HIWebViewEventHandler):
  • WebKit.exp:
11:14 AM Changeset in webkit [4404] by vicki
  • 8 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files

WebCore:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • WebCore.order: Added.
  • WebCore.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text WebCore.order

WebKit:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • WebKit.order: Added.
  • WebKit.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text WebKit.order;

WebBrowser:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • Safari.order: Added.
  • WebBrowser.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text Safari.order -e start;
12:00 AM Changeset in webkit [4403] by hyatt
  • 15 edits
    1 add in trunk/WebCore

An implementation of fieldset and legend. This is based off
some KHTML trunk code, but only loosely. I had to rewrite
most of it in order to make fieldsets work properly with
padding and in order to match the fieldset style of other
browsers more closely.

This code also fixes HTML4 buttons so that they don't fill the
width of containing blocks. This has been a long-standing
bug. Since legends behave the same way as buttons and floats,
I made a new helper function, sizesToMaxWidth(), to denote an
element that just uses its max intrinsic width when sizing
instead of filling a containing block.

This patch also fixes z-index so it properly only applies to the
root and to positioned/relpositioned elements.

Reviewed by darin

  • ChangeLog:
  • ForwardingHeaders/rendering/render_block.h: Added.
  • khtml/css/html4.css:
  • khtml/html/html_formimpl.cpp: (HTMLFieldSetElementImpl::HTMLFieldSetElementImpl): (HTMLFieldSetElementImpl::attach): (HTMLFieldSetElementImpl::createRenderer): (HTMLLegendElementImpl::HTMLLegendElementImpl): (HTMLLegendElementImpl::id): (HTMLLegendElementImpl::attach): (HTMLLegendElementImpl::createRenderer):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcWidthUsing):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_form.cpp: (RenderFieldset::RenderFieldset): (RenderFieldset::layoutLegend): (RenderFieldset::findLegend): (RenderFieldset::paintBoxDecorations): (RenderFieldset::paintBorderMinusLegend): (RenderLegend::RenderLegend):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth):
  • khtml/rendering/render_object.h:

May 20, 2003:

5:19 PM Changeset in webkit [4402] by rjw
  • 6 edits in trunk/WebKit

Fixed 3262825.
Fixed 3245625.
Fixed 3262547.

Recursively check items when going back/forward to ensure all
frame URLs are correct.

Added some logging to help diagnose back/forward problems.

Reviewed by John.

  • History.subproj/WebHistory.m: (-[WebHistory addItem:]):
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]):
3:43 PM Changeset in webkit [4401] by sheridan
  • 3 edits in trunk

Safari-81u

3:09 PM Changeset in webkit [4400]
  • 3 copies
    1 delete in branches/Safari-80~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-80~1-branch'.

3:09 PM Changeset in webkit [4399]
  • 3 copies
    1 delete in tags/Safari-80~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-80~1-anchor'.

3:09 PM Changeset in webkit [4398]
  • 3 copies in tags/Safari-80

This commit was manufactured by cvs2svn to create tag 'Safari-80'.

3:09 PM Changeset in webkit [4397] by sheridan
  • 8 edits in trunk

Safari-80 version stamp

10:48 AM Changeset in webkit [4396] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by Darin

Due to some header file changes in Foundation on Panther,
Tweaked some includes so that WebKit builds on Jaguar
and Panther.

  • Carbon.subproj/CarbonWindowFrame.m:
  • Plugins.subproj/WebNetscapePluginPackage.m:
  • Plugins.subproj/WebPluginPackage.m:

May 19, 2003:

8:47 PM Changeset in webkit [4395] by mjs
  • 10 edits in trunk

JavaScriptCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • JavaScriptCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebKit:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebKit.pbproj/project.pbxproj: Build WebKit as a public umbrella framework when doing a B&I build.

WebBrowser:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebBrowser.pbproj/project.pbxproj: Build with umbrella public WebKit when doing a B&I build.
2:29 PM Changeset in webkit [4394] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Darin

  • Panels.subproj/WebAuthenticationPanel.m: Now imports Foundation/NSURLCredential.h
  • WebCoreSupport.subproj/WebCookieAdapter.m: Now imports Foundation/NSHTTPCookie.h
1:10 PM Changeset in webkit [4393] by kocienda
  • 58 edits in trunk/WebKit

top level:

Reviewed by Darin

Changes to move from WebFoundation to Foundation

  • Makefile.am: Add some targets to check out and build Foundation.
  • configure.in: Add some more command line options to support building Foundation.
  • make-Foundation.sh.in: Added. Helper script to build Foundation.

Tests:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project files.

Updated some test files to use Foundation-related names
instead of WebFoundation-related names.

No longer build WebFoundation-CacheLoader subdirectory.
This test has not worked in a very long time. No need
to keep up the ruse as long as the test does not work.

  • PDFViewer/DocumentController.m:
  • PDFViewer/PDFViewer.pbproj/project.pbxproj:
  • SimpleViewer/DocumentController.m:
  • SimpleViewer/SimpleViewer.pbproj/project.pbxproj:
  • SnippetEditor/SnippetController.m:
  • SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
  • WebFoundation-CacheLoader/NeverExpiresTest.m: (-[NeverExpiresTest setUp]):
  • WebFoundation-Misc/Makefile.am:

WebKit:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m:
  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebDownload.m:
  • Misc.subproj/WebFileDatabase.m:
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebKitErrorsPrivate.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.h:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebDefaultFrameLoadDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebDefaultUIDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLRepresentation.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageRepresentation.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPreferences.m:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • AppController.m:
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSBundleExtras.m:
  • BrowserNSErrorExtras.h:
  • BrowserNSErrorExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSURLExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ContextMenuHandler.m:
  • Debug/CacheController.m:
  • Debug/DebugUtilities.m:
  • Debug/SnippetController.m:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • GoogleSearchChannel.m:
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • LocationFieldEditor.m:
  • NewBookmarksController.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/SecurityPreferences.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • Test/PageLoadTestController.m:
  • Test/PageLoadTestRunner.m:
  • TitleBarButton.m:
  • URLCompletionController.m:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • main.m:
11:55 AM Changeset in webkit [4392] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fixed build problem with declaring MIMEType as a category
on NSObject. This method needs to be typed to return NSString.

  • kwq/KWQLoader.mm

May 16, 2003:

9:55 PM Changeset in webkit [4391] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed 3254063 - REGRESSION: hang in KJS PropertyMap with many items in iDisk pictures folder
  • kjs/property_map.cpp: (PropertyMap::expand): Fixed to maintain key count properly - otherwise the hashtable could get completely full, resulting in disaster. (PropertyMap::checkConsistency): Fixed compilation. Fixed to know about deleted sentinel. Fixed to search with double-hashing instead of linear probing.
6:40 PM Changeset in webkit [4390] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3260940 - REGRESSION: reproducible crash freeing page cache item
  • fixed 3241041 - REGRESSION: repro world leak of 1 JavaScript interpreter

The fix for these problems and probably other page cache wackiness
was to use a refcounting scheme for KHTMLView instead of counting
on the previous tricky ownership rules.

  • khtml/khtmlview.cpp: (KHTMLView::KHTMLView): Initialize _refCount to 1. (KHTMLView::~KHTMLView): Assert that _refCount is 0, to make sure no one is deleting views explicitly.
  • khtml/khtmlview.h:
  • khtml/rendering/render_frames.cpp: (RenderPart::~RenderPart): If our view is a KHTMLView, deref it. (RenderPart::setWidget): If the view is a KHTMLView, tell the superclass not to delete it and ref it.
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initizlize m_deleteWidget to false. (RenderWidget::~RenderWidget): Only delete widget if we're supposed to. (RenderWidget::setQWidget): Add extra delegeWidget argument that says whether to delete this widget when done - defaults to true.
  • khtml/rendering/render_replaced.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Removed _ownsView boolean -- we'll always hang on to a ref to it now. (KWQKHTMLPart::~KWQKHTMLPart): Deref the view always instead of deleting it sometimes. (KWQKHTMLPart::setView): deref the old view if not null. ref the new view if not null. Drop tricky ownership rules. (KWQKHTMLPart::openURLFromPageCache): Remove no longer applicable comment about the importance of when setView is called.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): ref the document's view. (-[KWQPageState invalidate]): deref the document's view. (-[KWQPageState dealloc]): deref the document's view instead of deleting it.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): No more need to pass weOwnIt argument to setView. Also, deref the view after passing it to the KWQKHTMLView -- we own the initial ref since we allocated it. (-[WebCoreBridge removeFromFrame]): No more need to pass weOwnIt argument to setView. (-[WebCoreBridge installInFrame:]): Ditto.
11:36 AM Changeset in webkit [4389] by mjs
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _secProtocolForProtectionSpace:]): Don't assert if the protocol is unknown, just return 0 and let the higher levels fail gracefully. (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): Don't save if the protocol is unknown. Tolerate nil host.
  • AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]):
  • unrelated cookie code cleanup
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): Avoid warning about "0 previous cookies rejected"

WebKit:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame argument.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Include source frame in form state. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Include source frame in form state. Post directly to the target frame if it exists, since we want the form state to contain the right source frame. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass source frame to form delegate. (-[WebFormState initWithForm:values:sourceFrame:]): New sourceFrame argument. (-[WebFormState dealloc]): release sourceFrame. (-[WebFormState sourceFrame]): New method.

WebBrowser:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Pop up sheet based on source frame's window, and raise the sheet-bearing window if different than the target window. (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): Expect and use sourceFrame. (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
10:28 AM Changeset in webkit [4388] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3256997 - reproducible world leak (of 1 JavaScript interpreter) using google images

This turned out to be a page cache bug, and nothing to do with
JavaScript. The part and view were also leaked.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Make sure to reset the view before resetting the document, so that when we check if the document is in the page cache to determine if we can delete the old view, we'll be checking the old document instead of the new one.
9:07 AM Changeset in webkit [4387] by kocienda
  • 10 edits
    2 adds in trunk/WebKit

WebFoundation:

Reviewed by Gramps

Moved WebDatabase and WebFileDatabase files to WebKit

Twiddled some logging constants now that the WebFileDatabase
has been removed from the framework.

Updated StringsNotToBeLocalized.txt.

  • Database.subproj/NSLRUFileList.m: (NSLRUFileListRemoveOldestFileFromList):
  • Database.subproj/WebDatabase.h: Removed.
  • Database.subproj/WebDatabase.m: Removed.
  • Database.subproj/WebFileDatabase.h: Removed.
  • Database.subproj/WebFileDatabase.m: Removed.
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSURLLogging.h:
  • Misc.subproj/NSURLLogging.m:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Gramps

Moved in WebDatabase and WebFileDatabase files from WebFoundation.

Copied NSLRUFileList from WebFoundation and renamed to WebLRUFileList.

Updated StringsNotToBeLocalized.txt.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebDatabase.h:
  • Misc.subproj/WebDatabase.m:
  • Misc.subproj/WebFileDatabase.h:
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp perform:]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]):
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • Misc.subproj/WebLRUFileList.h: Added.
  • Misc.subproj/WebLRUFileList.m: Added. (WebLRUFileListCreate): (WebLRUFileListRelease): (WebLRUFileListRebuildFileDataUsingRootDirectory): (WebLRUFileListRemoveFileWithPath): (WebLRUFileListTouchFileWithPath): (WebLRUFileListSetFileData): (WebLRUFileListGetPathOfOldestFile): (WebLRUFileListRemoveOldestFileFromList): (WebLRUFileListContainsItem): (WebLRUFileListGetFileSize): (WebLRUFileListCountItems): (WebLRUFileListGetTotalSize): (WebLRUFileListRemoveAllFilesFromList): (compareTimes): (cStringEqual): (cStringHash): (NSLRUFileDataEqual): (WebLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease): (NSLRUFileDataBinaryHeapDumpApplierFunction): (NSLRUFileDataDictDumpApplierFunction): (WebLRUFileListDescription):
  • WebKit.pbproj/project.pbxproj:

May 15, 2003:

6:09 PM Changeset in webkit [4386] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3168588 - Can't click on links at Nike site (Image onload handler problem)

The fix was to implement the onload property for Image objects
(which are entirely different from <img> HTML elements).

  • khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Implement access to onload attribte. (Image::tryPut): Use putValue cause we're gonna use the hashtable now. (Image::putValue): Moved guts of tryPut here. Implement setting of onload attribute. (Image::notifyFinished): Fire onload event if there is a listener. (Image::Image): initialize onload listener to null.
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.lut.h: Regenerated.
2:59 PM Changeset in webkit [4385] by cblu
  • 4 edits in trunk/WebKit

WebFoundation:

Fixed: ASSERT if delegate doesn't implement didReceiveResponse

Reviewed by kocienda.

  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _postDidReceiveResponseCallback]): set didReceiveResponseCallbackSent to YES here (-[NSURLConnection _sendDidReceiveResponseCallback]): don't set didReceiveResponseCallbackSent to YES here because this method may not be called

WebKit:

Fixed: 3199310 - No user agent included in favicon.ico requests

Reviewed by kocienda.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoaderPrivate dealloc]): use the request ivar (-[WebIconLoader URL]): ditto (-[WebIconLoader startLoading]): ditto (-[WebIconLoader connection:didReceiveData:]): ditto (-[WebIconLoader connectionDidFinishLoading:]): ditto
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): create a icon loader with a request with the extra fields set
2:46 PM Changeset in webkit [4384] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3155760 - Plug-in MIME and extension mapping should be case-insensitive

Reviewed by john.

  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): store the extensions and MIMEs as lowercase strings (-[NSArray _web_lowercaseStrings]): new, returns array of lowercase strings
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfoFromResources]): store the extensions and MIMEs as lowercase strings
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForMIMEType:]): lowercase the passed MIME type (-[WebPluginDatabase pluginForExtension:]): lowercase the passed extension
2:39 PM Changeset in webkit [4383] by sheridan
  • 3 edits in trunk

build number 80u

2:11 PM Changeset in webkit [4382]
  • 3 copies in tags/Safari-79

This commit was manufactured by cvs2svn to create tag 'Safari-79'.

2:11 PM Changeset in webkit [4381] by sheridan
  • 8 edits in trunk

Safari-79 stamp

1:47 PM Changeset in webkit [4380] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Chris.

  • fixed 3259673 - REGRESSION: marvel.com thinks I don't have the flash plugin any more
  • kjs/nodes.cpp: (ContinueNode::execute): Return a Continue completion, not a Break completion, in the normal non-exception case.
12:55 PM Changeset in webkit [4379] by kocienda
  • 2 edits in trunk/WebKit

Tools:

Reviewed by John

Tweaked script so that it works with the changed names
of some dependent files and macors in WebFoundation.

  • Scripts/extract-localizable-strings:

WebFoundation:

Reviewed by John

Updated StringsNotToBeLocalized.txt for recent changes.

Changed localization macros back to UI_STRING and UI_STRING_KEY so
that we keep working with the tools we have to keep
localization information up to date.

  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]):
  • CacheLoader.subproj/NSURLResponse.m: (+[NSHTTPURLResponse localizedStringForStatusCode:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSError_NSURLExtras.m: (WebNSErrorExtrasInit):
  • Misc.subproj/NSString_NSURLExtras.m:
  • Misc.subproj/NSURLAssertions.h:
  • Misc.subproj/NSURLAssertions.m: (NSURLReportFatalError):
  • Misc.subproj/NSURLLocalizableStrings.h:
  • Misc.subproj/NSURL_NSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):

WebKit:

Reviewed by John

Updated for recent changes.

  • English.lproj/StringsNotToBeLocalized.txt:

WebBrowser:

Reviewed by John

Updated for recent changes.

  • English.lproj/StringsNotToBeLocalized.txt:
11:19 AM Changeset in webkit [4378] by kocienda
  • 37 edits in trunk/WebKit

Tests:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in the tests.

WebNSArrayExtras -> NSArray_NSURLExtras
WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras

  • WebFoundation-Misc/ifnsarrayextensions-test.m:
  • WebFoundation-Misc/ifnscalendardateextensions-test.m:
  • WebFoundation-Misc/ifnsobjectextensions-test.m:
  • WebFoundation-Misc/ifnsstringextensions-test.m:
  • WebFoundation-Misc/ifnsurlextensions-test.m:
  • WebFoundation-Misc/ifurlparsing-test.m:

WebFoundation:

Reviewed by John

Changed the names of some extras files:
Updated imports and usages in this project.

WebNSArrayExtras -> NSArray_NSURLExtras
WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDataExtras -> NSData_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras
WebNSValueExtensions -> NSValue_NSURLExtras

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m:
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • AuthenticationManager.subproj/NSURLKeychainCredential.m:
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m:
  • CacheLoader.subproj/NSNetworkSettings.m:
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m:
  • CacheLoader.subproj/NSURLCache.m:
  • CacheLoader.subproj/NSURLConnection.m:
  • CacheLoader.subproj/NSURLConnectionQueue.m:
  • CacheLoader.subproj/NSURLProtocol.m:
  • CacheLoader.subproj/NSURLRequest.m:
  • CacheLoader.subproj/NSURLResponse.m:
  • ChangeLog:
  • CookieManager.subproj/NSHTTPCookie.m:
  • CookieManager.subproj/NSHTTPCookieDOStorage.m:
  • CookieManager.subproj/NSHTTPCookieServer.m:
  • CookieManager.subproj/NSHTTPCookieStorage.m:
  • Database.subproj/WebFileDatabase.m:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FileTransfer.subproj/NSBinHexDecoder.m:
  • FileTransfer.subproj/NSMacBinaryDecoder.m:
  • FileTransfer.subproj/NSURLDownload.m:
  • Misc.subproj/NSArray_NSURLExtras.m:
  • Misc.subproj/NSCalendarDate_NSURLExtras.h:
  • Misc.subproj/NSCalendarDate_NSURLExtras.m:
  • Misc.subproj/NSData_NSURLExtras.h:
  • Misc.subproj/NSData_NSURLExtras.m:
  • Misc.subproj/NSDictionary_NSURLExtras.h:
  • Misc.subproj/NSDictionary_NSURLExtras.m:
  • Misc.subproj/NSError_NSURLExtras.h:
  • Misc.subproj/NSError_NSURLExtras.m:
  • Misc.subproj/NSFileManager_NSURLExtras.h:
  • Misc.subproj/NSFileManager_NSURLExtras.m:
  • Misc.subproj/NSObject_NSURLExtras.h:
  • Misc.subproj/NSObject_NSURLExtras.m:
  • Misc.subproj/NSString_NSURLExtras.h:
  • Misc.subproj/NSString_NSURLExtras.m:
  • Misc.subproj/NSURL_NSURLExtras.h:
  • Misc.subproj/NSURL_NSURLExtras.m:
  • Misc.subproj/NSUserDefaults_NSURLExtras.h:
  • Misc.subproj/NSUserDefaults_NSURLExtras.m:
  • Misc.subproj/NSValue_NSURLExtras.h:
  • Misc.subproj/NSValue_NSURLExtras.m:
  • Misc.subproj/WebNSArrayExtras.h: Removed.
  • Misc.subproj/WebNSArrayExtras.m: Removed.
  • Misc.subproj/WebNSCalendarDateExtras.h: Removed.
  • Misc.subproj/WebNSCalendarDateExtras.m: Removed.
  • Misc.subproj/WebNSDataExtras.h: Removed.
  • Misc.subproj/WebNSDataExtras.m: Removed.
  • Misc.subproj/WebNSDictionaryExtras.h: Removed.
  • Misc.subproj/WebNSDictionaryExtras.m: Removed.
  • Misc.subproj/WebNSErrorExtras.h: Removed.
  • Misc.subproj/WebNSErrorExtras.m: Removed.
  • Misc.subproj/WebNSFileManagerExtras.h: Removed.
  • Misc.subproj/WebNSFileManagerExtras.m: Removed.
  • Misc.subproj/WebNSObjectExtras.h: Removed.
  • Misc.subproj/WebNSObjectExtras.m: Removed.
  • Misc.subproj/WebNSStringExtras.h: Removed.
  • Misc.subproj/WebNSStringExtras.m: Removed.
  • Misc.subproj/WebNSURLExtras.h: Removed.
  • Misc.subproj/WebNSURLExtras.m: Removed.
  • Misc.subproj/WebNSUserDefaultsExtras.h: Removed.
  • Misc.subproj/WebNSUserDefaultsExtras.m: Removed.
  • Misc.subproj/WebNSValueExtensions.h: Removed.
  • Misc.subproj/WebNSValueExtensions.m: Removed.
  • ProtocolHandlers.subproj/NSAboutURLProtocol.m:
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFileURLProtocol.m:
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m:
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in this project.

WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDataExtras -> NSData_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m:
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPreferences.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in this project.

WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras

  • AppController.m: (-[AppController settingsDirectoryPath]):
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSBundleExtras.m:
  • BrowserNSErrorExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSURLExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ChangeLog:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • GoogleSearchChannel.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • LocationFieldEditor.m:
  • NewBookmarksController.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • Test/PageLoadTestController.m:
  • Test/PageLoadTestRunner.m:
  • TitleBarButton.m:
  • URLCompletionController.m: (visitCountForResult):
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • main.m:

May 14, 2003:

4:48 PM Changeset in webkit [4377] by kocienda
  • 5 edits
    2 adds in trunk/WebKit

Tests:

Reviewed by Chris

Fixed one straggling test I missed earlier when
changing name from WebMonitor to NSURLMonitor

  • WebFoundation-CacheLoader/NeverExpiresTest.m:

WebFoundation:

Reviewed by Chris

Cut way down on WebSystemBits. Kept only two thread-priority
functions. The WebSystemBits header is no longer privately exported.

  • Misc.subproj/WebSystemBits.h:
  • Misc.subproj/WebSystemBits.m: (WebGetThreadPriority):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Chris

WebKitSystemBits files that contain a system memory size
getter. This function is used in a few of places in WebKit.

  • History.subproj/WebBackForwardList.m:
  • Misc.subproj/WebKitSystemBits.h: Added.
  • Misc.subproj/WebKitSystemBits.m: Added. (initCapabilities): (WebSystemMainMemory):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Reviewed by Chris

Removed dependency on WebFoundation/WebSystemBits.h.
Moved one function that was used into this file. This
function, JaguarSUJagGreenOrLater(), has been tweaked
to be more specialized for the one question it needs
to answer.

  • FormCompletionController.m: (GetRandomBytes): (generatePassword):
  • LocationChangeError.m: (JaguarSUJagGreenOrLater): (-[LocationChangeHandler specializedMessageForError:dataSource:]):
3:00 PM Changeset in webkit [4376] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3248193. Floats with layers paint twice. The fix
is to make sure floats are not painted during the float phase
if they also have a layer.

Reviewed by john

  • khtml/rendering/render_block.cpp:
2:03 PM Changeset in webkit [4375] by kocienda
  • 7 edits in trunk/WebKit

Tests:

Reviewed by David

File and class renamings in WebFoundation:

WebKeyValuePair -> NSURLKeyValuePair
WebReadWriteLock -> NSURLReadWriteLock
WebRecursiveReadWriteLock -> NSURLRecursiveReadWriteLock

  • WebFoundation-Misc/ifnsstringextensions-test.m: (formatPair): (main):
  • WebFoundation-Misc/ifreadwritelock-test.m: (main):
  • WebFoundation-Misc/ifrecursivereadwritelock-test.m: (main):

WebFoundation:

Reviewed by David

File and class renamings:

WebFileTypeMappings -> NSURLFileTypeMappings
WebHostNameAddressInfo.h -> NSURLHostNameAddressInfo.h
WebKeyValuePair -> NSURLKeyValuePair
WebMonitor -> NSURLMonitor
WebQueue -> NSURLQueue
WebReadWriteLock -> NSURLReadWriteLock
WebRecursiveReadWriteLock -> NSURLRecursiveReadWriteLock
WebSpinLock -> NSURLSpinLock

  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _internalInit]):
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • CacheLoader.subproj/NSNetworkSettings.m: (-[NSNetworkSettingsInternal init]):
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.h:
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m: (-[NSSynchronousURLConnectionDelegate initWithRequest:monitor:]):
  • CacheLoader.subproj/NSURLCache.m: (-[NSURLCache initWithMemoryCapacity:diskCapacity:diskPath:]):
  • CacheLoader.subproj/NSURLConnection.m: (NSURLConnectionInit):
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
  • CacheLoader.subproj/NSURLResponse.m: (-[NSHTTPURLResponse _parseCacheControl]):
  • ChangeLog:
  • CookieManager.subproj/NSHTTPCookie.m: (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]):
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorageInternal init]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSURLFileTypeMappings.h:
  • Misc.subproj/NSURLFileTypeMappings.m: (-[NSURLFileTypeMappings _init]): (initFileTypeMappings): (+[NSURLFileTypeMappings sharedMappings]):
  • Misc.subproj/NSURLHostNameAddressInfo.h:
  • Misc.subproj/NSURLHostNameAddressInfo.m: (NSURLHostNameAddressInfoInit): (+[NSURLHostNameAddressInfo addressInfoForHost:]): (+[NSURLHostNameAddressInfo asyncResolveWithCallbackClient:]): (doResolveHostName): (resolveHostName):
  • Misc.subproj/NSURLKeyValuePair.h:
  • Misc.subproj/NSURLKeyValuePair.m: (+[NSURLKeyValuePair pair]): (+[NSURLKeyValuePair pairWithKey:value:]): (-[NSURLKeyValuePair description]):
  • Misc.subproj/NSURLMonitor.h:
  • Misc.subproj/NSURLMonitor.m:
  • Misc.subproj/NSURLQueue.h:
  • Misc.subproj/NSURLQueue.m: (+[NSURLQueue newNode]): (-[NSURLQueue init]): (-[NSURLQueue put:]): (-[NSURLQueue take]): (-[NSURLQueue peekAt:]): (-[NSURLQueue remove:]): (-[NSURLQueue clear]): (-[NSURLQueue indexOf:]):
  • Misc.subproj/NSURLReadWriteLock.h:
  • Misc.subproj/NSURLReadWriteLock.m: (-[NSURLReadWriteLock init]):
  • Misc.subproj/NSURLRecursiveReadWriteLock.h:
  • Misc.subproj/NSURLRecursiveReadWriteLock.m:
  • Misc.subproj/NSURLSpinLock.h:
  • Misc.subproj/NSURLSpinLock.m:
  • Misc.subproj/WebFileTypeMappings.h: Removed.
  • Misc.subproj/WebFileTypeMappings.m: Removed.
  • Misc.subproj/WebHostNameAddressInfo.h: Removed.
  • Misc.subproj/WebHostNameAddressInfo.m: Removed.
  • Misc.subproj/WebKeyValuePair.h: Removed.
  • Misc.subproj/WebKeyValuePair.m: Removed.
  • Misc.subproj/WebMonitor.h: Removed.
  • Misc.subproj/WebMonitor.m: Removed.
  • Misc.subproj/WebNSArrayExtras.m: (-[NSArray _web_encodeWWWFormURLData]):
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMETypeForExtension:]):
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_parseAsKeyValuePair]): (-[NSString _web_parseAsKeyValuePairHandleQuotes:]): (-[NSString _web_fileNameFromContentDispositionHeader]): (-[NSString _web_timeoutFromKeepAliveHeader]):
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):
  • Misc.subproj/WebQueue.h: Removed.
  • Misc.subproj/WebQueue.m: Removed.
  • Misc.subproj/WebReadWriteLock.h: Removed.
  • Misc.subproj/WebReadWriteLock.m: Removed.
  • Misc.subproj/WebRecursiveReadWriteLock.h: Removed.
  • Misc.subproj/WebRecursiveReadWriteLock.m: Removed.
  • Misc.subproj/WebSpinLock.h: Removed.
  • Misc.subproj/WebSpinLock.m: Removed.
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m: (-[NSFTPURLProtocol sendResponseAvailableCallback]):
  • ProtocolHandlers.subproj/NSFileURLProtocol.m: (-[NSFileURLProtocol didLoadData:]):
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.h:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m: (NSSimpleHTTPURLProtocolInit): (-[NSSimpleHTTPURLProtocol initWithRequest:cachedResponse:client:]): (-[NSSimpleHTTPURLProtocol startOriginLoad]): (-[NSSimpleHTTPURLProtocol hostNameResolved:]): (-[NSSimpleHTTPURLProtocol _handleLoadCallback]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by David

File and class renaming in WebFoundation:

WebFileTypeMappings -> NSURLFileTypeMappings

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]):
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebViewPrivate.m: (+[WebView suggestedFileExtensionForMIMEType:]): (+[WebView _MIMETypeForFile:]):

WebBrowser:

Reviewed by David

File and class renaming done in WebFoundation:

WebFileTypeMappings -> NSURLFileTypeMappings

  • BrowserWebController.m:
1:27 PM Changeset in webkit [4374] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3258389, min-width should take precedence over max-width.
I just had an "else" that shouldn't have been there, so that
min-width would get checked even if max-width was also checked.

Reviewed by kocienda

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
1:27 PM Changeset in webkit [4373] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3258389, min-width should take precedence over max-width.
I just had an "else" that shouldn't have been there, so that
min-width would get checked even if max-width was also checked.

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
11:48 AM Changeset in webkit [4372] by kocienda
  • 9 edits
    2 adds in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit.
Renamed copy of WebLocalizableStrings.[hm] that stayed to NSURLLocalizableStrings.[hm]

Search and replace through all the code in this framework to
twiddle localizable string function names and macros
used and defined in the headers and implementation
files so that they use an "NSURL" prefix instead of no prefix,
a "Web" prefix, or a "WebFoundation" prefix.

Removed localizable strings exported symbols from exports file.

  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]):
  • CacheLoader.subproj/NSURLResponse.m: (+[NSHTTPURLResponse localizedStringForStatusCode:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
  • Misc.subproj/WebNSStringExtras.m:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit

Updated all imports.

Added logging exported symbols to exports file.

  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebLocalizableStrings.h: Added.
  • Misc.subproj/WebLocalizableStrings.m: Added.
  • Panels.subproj/WebAuthenticationPanel.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebFileButton.m:
  • WebCoreSupport.subproj/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:

WebBrowser:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit.
Updated all imports.

  • ABHomePagesController.m:
  • AppController.m:
  • BookmarksController.m:
  • BookmarksRepresentation.m:
  • BookmarksViewController.m:
  • BrowserAddressBookExtras.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSErrorExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ContextMenuHandler.m:
  • DateCell.m:
  • DownloadMonitor.m:
  • DownloadRow.m:
  • DownloadViewController.m:
  • DownloadWindowController.m:
  • FavoriteButton.m:
  • FindPanelController.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/AppearancePreferences.m:
  • Preferences.subproj/AutoFillPreferences.m:
  • Preferences.subproj/BookmarkPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/GeneralPreferences.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/SecurityPreferences.m:
  • Preferences.subproj/TabsPreferences.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SearchTextField.m:
  • ServicesProvider.m:
  • WebSearchManager.m:
  • main.m:
11:13 AM Changeset in webkit [4371] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Don.

  • fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
  • kwq/KWQTextField.mm:

(-[KWQTextField setHasFocus:]): Don't call
KWQKHTMLPart::setDocumentFocus(widget) to start with, it might
invoke a handler which could call blur(), and we don't want to do
the selection handling after that; futhermore, it will get called
anyway when we deliver the FocusIn event to the event
filter. Also, sometimes unfocusing in the middle of a focus can
leave us and AppKit in an inconsistent state; correct this. A
comment explains the details.

WebKit:

Reviewed by Don.

  • fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge makeFirstResponder:]): Let the WebView know that this is a programmatic focus.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Check if this is a programmatic focus from WebCore - if so, treat it like a direct focus, even if there is a selection direction set.
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _pushPerformingProgrammaticFocus]): New method to indicate upcoming programmatic focus. (-[WebView _popPerformingProgrammaticFocus]): New method to indicate end of programmatic focus. Needs to nest with the previous. (-[WebView _isPerformingProgrammaticFocus]): Check if we are handling a programmatic focus from WebCore.
11:03 AM Changeset in webkit [4370] by mjs
  • 8 edits in trunk/WebCore

Reviewed by John.

  • fixed 3240129 - REGRESSION: www.ezprints.com navigation buttons don't show up (window.addEventListener)

The problem here was that event handlers set using
window.addEventListener were set as regular event handlers on the
document object instead of as window event handlers - and the load
event does not fire properly that way.

The fix was to add support for both HTML and non-HTML window event
handlers. The old window event methods supported only "HTML"
handlers, but were not named as such.

  • khtml/ecma/kjs_window.cpp: (Window::setListener): Use setHTMLWindowEventListener. (Window::getListener): Use getHTMLWindowEventListener. (WindowFunc::tryCall): use addWindowEventListener and removeWindowEventListener on the DocumentImpl instead of addEventListener and removeEventListener on the Document.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use setHTMLWindowEventListener instead of the old setWindowEventListener.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Don't stop after the first window event handler - keep going, since there might now be more than one for the same event. (DocumentImpl::setHTMLWindowEventListener): Renamed from setWindowEventListener. (DocumentImpl::getHTMLWindowEventListener): Renamed from getWindowEventListener. (DocumentImpl::removeHTMLWindowEventListener): Renamed from removeWindowEventListener. (DocumentImpl::addWindowEventListener): Implemented - support adding non-HTML window event listeners, which, unlike html listeners, are nto exclusive - there may be more than one. (DocumentImpl::removeWindowEventListener): Implemented. (DocumentImpl::hasWindowEventListener): Check if a window has any handler at all for a prticular event.
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::addEventListener): Add ref/deref pair to protect against last ref of listener going away on remove. Correct comment about the removal.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Check for an UNLOAD event handler using hasWindowEventListener instead of getHTMLWindowEventListener, to check for even addListener-style unload handlers.
9:56 AM Changeset in webkit [4369] by kocienda
  • 38 edits
    2 adds in trunk/WebKit

Tests:

Reviewed by John

Moved WebAssertions header to WebKit

  • PDFViewer/PDFRepresentation.m:

WebFoundation:

Reviewed by John

Copied WebAssertions.[hm] to WebKit
Renamed copy of WebAssertions.[hm] that stayed to NSURLAssertions.[hm]
Renamed WebFoundationLogging.[hm] to NSURLLogging.[hm]

Search and replace through all the code in this framework to
twiddle names used and defined in the logging and assertions
files so that they use an "NSURL" prefix instead of no prefix, i
a "Web" prefix, or a "WebFoundation" prefix.

Removed logging exported symbols to exports file.

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator init]):
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallenge init]):
  • AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]):
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[NSURLKeychainCredentialStorage _secProtocolForProtectionSpace:]): (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[NSURLKeychainCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[NSURLKeychainCredentialStorage _initializeFromKeychain]): (-[NSURLKeychainCredentialStorage removeCredential:forProtectionSpace:]):
  • CacheLoader.subproj/NSNetworkSettings.m: (-[NSNetworkSettings _listenForProxySettingChanges]): (-[NSNetworkSettings init]):
  • CacheLoader.subproj/NSURLCache.m: (-[NSURLCache cachedResponseForRequest:]): (-[NSURLCache storeCachedResponse:forRequest:]): (-[NSURLCache removeCachedResponseForRequest:]): (-[NSURLCache removeAllCachedResponses]): (-[NSURLCache _memoryCacheRemoveNodeFromLRUList:]): (-[NSURLCache _memoryCacheAppendNodeToLRUList:]): (-[NSURLCache _memoryCacheTouchNode:]): (-[NSURLCache _memoryCacheTruncate:]): (-[NSURLCache _memoryCacheGet:]): (-[NSURLCache _memoryCachePut:]): (-[NSURLCache _memoryCacheRemove:]): (-[NSURLCache _diskCacheSetSyncTimer]): (-[NSURLCache _diskCacheSync:]): (-[NSURLCache _diskCacheCreateLRUList:]): (-[NSURLCache _diskCacheCreateDirectory]): (-[NSURLCache _diskCacheGet:]): (-[NSURLCache _diskCacheTruncate:]): (-[NSURLCache _diskCacheScheduleWrite:]): (-[NSURLCache _diskCacheExecuteWrite:]): (-[NSURLCache _diskCacheScheduleRemoval:]): (-[NSURLCache _diskCacheExecuteRemoval:]):
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection initWithRequest:delegate:]): (+[NSURLConnection _forceSingleLoad]): (-[NSURLConnection _postDidReceiveResponseCallback]): (-[NSURLConnection _sendWillSendRequestCallback]): (-[NSURLConnection _sendDidReceiveResponseCallback]): (-[NSURLConnection _sendDidReceiveDataCallback]): (-[NSURLConnection _sendDidFailCallback]): (-[NSURLConnection _sendDidFinishLoadingCallback]): (-[NSURLConnection _chooseCachedResponse]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _checkIfTimedOut]): (-[NSURLConnection _cleanup]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnection _didFinishReturnCachedResponse:]): (-[NSURLConnection _didFinishLoading]): (+[NSURLConnection incrementOriginLoadCount]): (_loadThrottler): (_loadSweeper): (-[NSURLConnectionInternal dealloc]): (-[NSURLConnectionInternal URLProtocol:wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnectionInternal URLProtocol:cachedResponseIsValid:]):
  • CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
  • CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol canonicalRequestForRequest:]): (+[NSURLProtocol requestIsCacheEquivalent:toRequest:]): (+[NSURLProtocol propertyForKey:inRequest:]): (+[NSURLProtocol setProperty:forKey:inRequest:]): (+[NSURLProtocol _makeRequestCanonicalByMakingRequestURLCanonical:]):
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _URLHasScheme:]): (+[NSURLRequest allowsAnyHTTPSCertificateForHost:]): (+[NSURLRequest setAllowsAnyHTTPSCertificate:forHost:]): (-[NSMutableURLRequest setHTTPMethod:]):
  • CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse suggestedFilename]):
  • CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie initWithProperties:]): (-[NSHTTPCookie init]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]):
  • CookieManager.subproj/NSHTTPCookieDOStorage.m: (-[NSHTTPCookieDOStorage _establishConnection]):
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (-[NSHTTPCookieStorage setCookiesFromResponseHeader:forURL:policyBaseURL:]):
  • Database.subproj/NSLRUFileList.m: (NSLRUFileListRelease): (NSLRUFileListRebuildFileDataUsingRootDirectory): (NSLRUFileListRemoveFileWithPath): (NSLRUFileListTouchFileWithPath): (NSLRUFileListSetFileData): (NSLRUFileListGetPathOfOldestFile): (NSLRUFileListRemoveOldestFileFromList): (NSLRUFileListContainsItem): (NSLRUFileListGetFileSize): (NSLRUFileListCountItems): (NSLRUFileListGetTotalSize): (NSLRUFileListRemoveAllFilesFromList): (compareTimes): (cStringEqual): (cStringHash): (NSLRUFileDataEqual): (NSLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease):
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp perform:]): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • FileTransfer.subproj/NSBinHexDecoder.m: (-[NSBinHexDecoder decodeIntoBuffer:size:]): (-[NSBinHexDecoder decodeHeader]): (-[NSBinHexDecoder decodeForkWithData:count:CRCCheckFlag:]): (-[NSBinHexDecoder decodeData:dataForkData:resourceForkData:]): (-[NSBinHexDecoder finishDecoding]):
  • FileTransfer.subproj/NSGZipDecoder.m: (-[NSGZipDecoder init]): (-[NSGZipDecoder decodeData:dataForkData:resourceForkData:]): (-[NSGZipDecoder finishDecoding]): (-[NSGZipDecoder fileAttributes]): (-[NSGZipDecoder filename]):
  • FileTransfer.subproj/NSMacBinaryDecoder.m: (-[NSMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[NSMacBinaryDecoder fileAttributes]):
  • FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownloadInternal dealloc]): (-[NSURLDownload initWithSource:delegate:]): (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload _createFSRefForPath:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _dataIfDoneBufferingData:]): (-[NSURLDownload _writeForkData:isDataFork:]): (-[NSURLDownload _closeForkSync:]): (-[NSURLConnectionDelegateProxy connection:willSendRequest:redirectResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]): (-[NSURLConnectionDelegateProxy connection:didReceiveResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveData:]): (-[NSURLConnectionDelegateProxy connectionDidFinishLoading:]): (-[NSURLConnectionDelegateProxy connection:didFailWithError:]): (WriteCompletionCallback): (CloseCompletionCallback): (DeleteCompletionCallback):
  • Misc.subproj/NSURLAssertions.h:
  • Misc.subproj/NSURLAssertions.m: (NSURLReportAssertionFailure): (NSURLReportAssertionFailureWithMessage): (NSURLReportArgumentAssertionFailure): (NSURLReportFatalError): (NSURLReportError): (NSURLLog):
  • Misc.subproj/NSURLLogging.h:
  • Misc.subproj/NSURLLogging.m:
  • Misc.subproj/WebAssertions.h: Removed.
  • Misc.subproj/WebAssertions.m: Removed.
  • Misc.subproj/WebFoundationLogging.h: Removed.
  • Misc.subproj/WebFoundationLogging.m: Removed.
  • Misc.subproj/WebLocalizableStrings.m: (WebLocalizedString):
  • Misc.subproj/WebNSCalendarDateExtras.m: (+[NSCalendarDate _web_dateFromHTTPDateString:]):
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]):
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): (-[NSFileManager _web_noteFileChangedAtPath:]):
  • Misc.subproj/WebNSStringExtras.m:
  • Misc.subproj/WebNSURLExtras.m: (URLStringByAddingPercentEscapes): (hexDigitValue):
  • Misc.subproj/WebQueue.m: (-[WebQueue put:]): (-[WebQueue peekAt:]): (-[WebQueue remove:]):
  • Misc.subproj/WebSystemBits.m: (WebGetRandomBytes): (WebSetThreadPriority): (initCapabilities):
  • ProtocolHandlers.subproj/NSAboutURLProtocol.m: (+[NSAboutURLProtocol canInitWithRequest:]): (+[NSAboutURLProtocol canonicalRequestForRequest:]):
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m: (+[NSCFNetworkHTTPURLProtocol canInitWithRequest:]): (-[NSCFNetworkHTTPURLProtocol dealloc]): (-[NSCFNetworkHTTPURLProtocol setCertificatePolicyOnStream]): (-[NSCFNetworkHTTPURLProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): (-[NSCFNetworkHTTPURLProtocol addConditionalFieldsToHeader]): (-[NSCFNetworkHTTPURLProtocol addMessageBodyToRequest]): (-[NSCFNetworkHTTPURLProtocol retryAfterConnectingToInternet]): (-[NSCFNetworkHTTPURLProtocol handleReadStreamEvent:event:]): (-[NSCFNetworkHTTPURLProtocol performHTTPHeaderRead:andCall:]): (-[NSCFNetworkHTTPURLProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m: (+[NSFTPURLProtocol canInitWithRequest:]): (+[NSFTPURLProtocol _canonicalURLForURL:]): (-[NSFTPURLProtocol startLoading]): (-[NSFTPURLProtocol determineErrorAndFail]): (-[NSFTPURLProtocol handleReadStreamEvent:event:]):
  • ProtocolHandlers.subproj/NSFileURLProtocol.m: (+[NSFileURLProtocol canInitWithRequest:]): (+[NSFileURLProtocol _canonicalURLForURL:]):
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m: (+[NSHTTPURLProtocol _canonicalURLForURL:]): (+[NSHTTPURLProtocol requestIsCacheEquivalent:toRequest:]): (-[NSHTTPURLProtocol startLoading]): (-[NSHTTPURLProtocol cachedResponseRevalidated]): (-[NSHTTPURLProtocol _cachedResponsePassesValidityChecks]): (-[NSHTTPURLProtocol HTTPResponse]): (-[NSHTTPURLProtocol buildHTTPResponse]): (-[NSHTTPURLProtocol determineErrorAndFail]): (-[NSHTTPURLProtocol _cachePolicyForResponse]): (-[NSHTTPURLProtocol setResponseHeader:]): (-[NSHTTPURLProtocol _URLStringFromLocationHeader]):
  • ProtocolHandlers.subproj/NSSSLProxyWrapperStream.m: (createConnectBytes): (wSocketStreamCallBack):
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m: (ensureRequestStringCapacity): (appendBytesToRequestString): (appendIntegerToRequestString): (appendNSStringToRequestString): (_loadRunLoop): (_socketWriteCallback): (_socketReadCallback): (_addCookieHeader): (+[NSSimpleHTTPURLProtocol canInitWithRequest:]): (-[NSSimpleHTTPURLProtocol _canUsePersistentConnectionForRequest]): (-[NSSimpleHTTPURLProtocol _continueLoadingWithFileDescriptor:]): (-[NSSimpleHTTPURLProtocol _continueLoadingWithAddressInfo]): (-[NSSimpleHTTPURLProtocol _addRequestMessageBody]): (-[NSSimpleHTTPURLProtocol buildHTTPRequest]): (-[NSSimpleHTTPURLProtocol _parseHeaderFromData:]): (-[NSSimpleHTTPURLProtocol _finishedWithFileDescriptor]): (-[NSSimpleHTTPURLProtocol _processRawData]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Copied WebAssertions.[hm] from WebFoundation to WebKit

Updated all imports.

Added logging exported symbols to exports file.

  • History.subproj/WebBackForwardList.m:
  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • Misc.subproj/WebAssertions.h: Added.
  • Misc.subproj/WebAssertions.m: Added. (vprintf_stderr_objc): (WebReportAssertionFailure): (WebReportAssertionFailureWithMessage): (WebReportArgumentAssertionFailure): (WebReportFatalError): (WebReportError): (WebLog):
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebStringTruncator.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebFileButton.m:
  • WebCoreSupport.subproj/WebImageRenderer.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebCoreSupport.subproj/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebClipView.m:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John

Copied WebAssertions.[hm] from WebFoundation.[hm] to WebKit.
Updated all imports.

  • ABHomePagesController.m:
  • ActivityViewer.m:
  • AppController.m:
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserApplication.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSAppleEventDescriptorExtras.m:
  • BrowserNSMenuExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSOutlineViewExtras.m:
  • BrowserNSSplitViewExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSTableViewExtras.m:
  • BrowserNSWindowExtras.m:
  • BrowserNSWorkspaceExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWebFrameExtras.m:
  • BrowserWebViewExtras.m:
  • BrowserWindow.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ClippedItemsIndicator.m:
  • ColoredRect.m:
  • CompletionController.m:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • Debug/Logging.h:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • DownloadViewController.m:
  • DownloadWindowController.m:
  • FavoriteButton.m:
  • FavoritesBar.m:
  • FavoritesBarView.m:
  • FindPanelController.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GoogleSearchChannel.m:
  • HTMLSourceDocument.m:
  • ImageAndTextCell.m:
  • InternetConfigUtilities.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • NewBookmarksController.m:
  • OutlineViewPlus.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/BookmarkPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/GeneralPreferences.m:
  • Preferences.subproj/ISyncController.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SearchChannel.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • TabButton.m:
  • TableViewPlus.m:
  • Test/PageLoadTestRunner.m:
  • TextEncodingMenu.m:
  • TextFieldWithControls.m:
  • TitleBarButton.m:
  • URLCompletionController.m:
  • WebBookmark.m:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • WebBookmarkList.m:
  • WebBookmarkProxy.m:
  • WebSearchManager.m:
Note: See TracTimeline for information about the timeline view.