⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 14, 2003:

5:49 PM Changeset in webkit [4828] by mjs
  • 3 edits in trunk/WebCore

Back out the last change, because the tree is closed. I am an idiot.

5:40 PM Changeset in webkit [4827] by mjs
  • 3 edits in trunk/WebCore

Fixed by Darin, reviewed by me (and originally figured out by John).

  • fixed 3375592 - New Yahoo Maps doesn't work right
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.
2:46 PM Changeset in webkit [4826] by vicki
  • 8 edits in trunk

JavaScriptCore:

Reviewed by John.

WebCore:

Reviewed by John.

  • WebCore.pbproj/project.pbxproj: deleted WebCore.order from the project.

WebKit:

Reviewed by John.

  • WebKit.pbproj/project.pbxproj: deleted WebKit.order from the project.
2:16 PM Changeset in webkit [4825] by vicki
  • 8 edits
    3 deletes in trunk

JavaScriptCore:

Reviewed by John.

  • JavaScriptCore.order: Removed. We now link to the order file at /AppleInternal/OrderFiles.
  • JavaScriptCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/JavaScriptCore.order

WebCore:

Reviewed by John.

  • WebCore.order: Removed. We now point to the WebCore order file in /AppleInternal/OrderFiles.
  • WebCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/WebCore.order

WebKit:

Reviewed by John.

  • WebKit.order: Removed. We now point to the WebKit order file in /AppleInternal/OrderFiles.
  • WebKit.pbproj/project.pbxproj: set sectorder flag to point to /AppleInternal/OrderFiles/WebKit.order

WebBrowser:

Reviewed by John.

  • Safari.order: updated this order file
  • WebBrowser.pbproj/project.pbxproj: set sectorder flag to point to Safari.order
11:13 AM Changeset in webkit [4824] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3344259 -- flipped image when copying from Safari in 1000s of colors mode

The workaround is to turn off the NSImage cache. Andrew says this won't have any
practical repercussions other than making the bug go away.

Seems to have a side effect of speeding up the cvs-base page load test!

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): Set mode to NSImageCacheNever. (-[WebImageRenderer initWithData:MIMEType:]): Ditto. (-[WebImageRenderer initWithContentsOfFile:]): Ditto. (-[WebImageRenderer _adjustSizeToPixelDimensions]): Don't set mode to NSImageCacheDefault.
10:56 AM Changeset in webkit [4823] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3095893>: Image Capture: "Build web page" doesn't work with Japanese folder name.

  • kwq/KWQKURL.mm: (KURL::getNSURL): Try UTF-8 first and fallback to ISO Latin-1 when creating an NSURL. This will handle the two-byte character in file name case mentioned in the bug.
9:48 AM Changeset in webkit [4822] by kocienda
  • 27 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
to use improved variants

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): Use data-as-string. (-[WebHistoryItem initWithURL:target:parent:title:]): Use data-as-string. (-[WebHistoryItem setURL:]): Use data-as-string.
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Remove FIX_VISITED ifdef (-[WebHistoryPrivate removeItem:]): Ditto (-[WebHistoryPrivate containsURL:]): Ditto. Use data-as-string. (-[WebHistoryPrivate itemForURL:]): Ditto. Ditto. (-[WebHistoryPrivate loadFromURL:error:]): Fix log message to URL. (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): Ditto. (-[WebHistoryPrivate saveToURL:error:]): Ditto.
  • History.subproj/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use visible-string.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Use data-as-string.
  • Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithDomain:code:URL:]): Added new convenience that takes a URL instead of a URL string. (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Added new convenience that takes URLs instead of a URL stringis.
  • Misc.subproj/WebKitErrorsPrivate.h: Declared new conveniences.
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:types:]): Use visible-string.
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_originalDataAsString]): Added. (-[NSURL _webkit_isJavaScriptURL]): Use data-as-string. (-[NSURL _webkit_scriptIfJavaScriptURL]): Ditto (-[NSURL _webkit_isFTPDirectoryURL]): Ditto (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Ditto. Also use _web_isEmpty.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use data-as-string.
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): Use new error convenience.
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Ditto.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Use data-as-string.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Use new error convenience.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]): Ditto.
  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]): Ditto.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]): Ditto. (-[WebDataSource _updateIconDatabaseWithURL:]): Use data-as-string. (-[WebDataSource _loadIcon]): Ditto.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Use data-as-string. (-[WebFrame _transitionToCommitted:]): Fix log message to use URL. (-[WebFrame _purgePageCache]): Use _web_isEmpty (-[WebFrame _setState:]): Fix log message to use URL. (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use new error convenience. (-[WebFrame _loadItem:withLoadType:]): Fix log message to use URL. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Fix log messages to use URL. (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): Use data-as-string.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]): Use visible-string.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Use new error convenience.
  • WebView.subproj/WebPreferences.m: (-[WebPreferences setUserStyleSheetLocation:]): Use data-as-string.
  • WebView.subproj/WebView.m: (-[WebView mainFrameURL]): Use data-as-string. (-[WebView mainFrameIcon]): Use data-as-string.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Use data-as-string.
8:56 AM Changeset in webkit [4821] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3375270 -- writing to frame parent from a button press crashes in viewportMousePressEvent

The fix turned out to be to ref the view around handling events in the view, since processing
the event could cause the view and part to go away. Since the view refs the part, ref'ing just
the view seems to work perfectly.

  • kwq/KWQKHTMLPart.mm: Fixed namespace access to use "using" instead of explicit namespaces. (KWQKHTMLPart::setView): Not-entirely-related cleanup. Use the "ref before deref" idiom here. (KWQKHTMLPart::sendResizeEvent): Ref the KHTMLView while sending the resize event. (KWQKHTMLPart::mouseDown): Ref the KHTMLView while sending the viewport mouse down event. (KWQKHTMLPart::mouseDragged): Ref the KHTMLView while sending the viewport mouse dragged event. (KWQKHTMLPart::mouseUp): Ref the KHTMLView while sending the viewport mouse up or double click event. (KWQKHTMLPart::mouseMoved): Ref the KHTMLView while sending the viewport mouse moved event.

Aug 13, 2003:

11:44 PM Changeset in webkit [4820] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3372896, spaces left at ends of lines. Patch the selection code
to be smarter about detecting ends of lines and adding in spaces.

Reviewed by gramps

  • khtml/khtml_part.cpp: (KHTMLPart::selectedText):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
5:26 PM Changeset in webkit [4819] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): ref the data source around processing the data and afterwards, to avoid crashing if a script in this chunk of data made the frame go away.
4:25 PM Changeset in webkit [4818] by rjw
  • 6 edits in trunk/WebKit

Fixed 3376077. Override automaticallyNotifiesObserversForKey: to
prevent unnecessary additional notifications from being sent. Also
added development-only logging (bulk of the change).

Reviewed by Chris.

  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _didChangeValueForKey:]): (-[WebView _willChangeValueForKey:]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _willChangeBackForwardKeys]): (-[WebView _didChangeBackForwardKeys]): (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
2:57 PM Changeset in webkit [4817] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3347134>: After first successful POST in Flash, Safari does not repeat POST and gives cached reply

Reviewed by kocienda.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): call [request setCachePolicy:NSURLRequestReloadIgnoringCacheData]
1:55 PM Changeset in webkit [4816] by kocienda
  • 5 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3366441>: URL strings with UTF-8 characters
processed improperly for display by WebKit

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (isHexDigit): Added (hexDigitValue): Added (-[NSURL _web_userVisibleString]): Added. Produces a string that is suitable for display to a user in the UI. (-[NSURL _web_isEmpty]): Convenience to check for an empty URL
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Now calls _web_userVisibleString
1:48 PM Changeset in webkit [4815] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374458>: Choose UTF-8 for encoding when calling
CFURLCreateAbsoluteURLWithBytes in WebKit

Calling CFURLCreateAbsoluteURLWithBytes with ISO Latin 1 string
encoding results in some issues when trying to decode a URL path in
preparation for doing file I/O. Instead of doing a redecoding step
whenever a path is needed to perform I/O, use UTF-8 as the encoding
right from the start. This will mean that illegal UTF-8 sequences will
be rejected by CFURLCreateAbsoluteURLWithBytes. However, we can work
around this by falling back on ISO Latin1 in this case. The end result
is that existing code throughout the URL loading system can remain
unchanged and simply call the path method on NSURL as it does now and
get the right result for its I/O requirements.

  • Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:])
1:23 PM Changeset in webkit [4814] by kocienda
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Call _web_URLWithUserTypedString: to make a URL from this type of string.
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (hexDigit): Added. (+[NSURL _web_URLWithUserTypedString:]): Added. Creates a URL from a string that is typed in a user, for example, in the Safari location bar.

WebBrowser:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar

  • BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): Use _web_URLWithUserTypedString: to make URL from this type of string.
9:51 AM Changeset in webkit [4813] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken Kocienda.

  • fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
  • khtml/khtml_part.cpp: (KHTMLPart::write): ref the part around actually processing the data, since a script could cause the part to go away.

Aug 12, 2003:

6:25 PM Changeset in webkit [4812] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3369505 -- leaks of NSCFTimer after running through the cvs-base test suite

Reviewed by Richard

  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): release timer before nil'ing it out
4:03 PM Changeset in webkit [4811] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3262190, <li> bullets in mail were overly massive. The bezier path the
painter stroked was not setting the line width from QPen's width, so it ended up
just using the current line width instead (which happened to be much larger in
Mail).

Reviewed by darin

  • kwq/KWQPainter.mm: (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::_drawPoints):
3:13 PM Changeset in webkit [4810] by voas
  • 2 edits in trunk/WebKit

2003-08-12 Ed Voas <​voas@apple.com>

Reviewed by Richard.

Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2:50 PM Changeset in webkit [4809] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3370614 -- REGRESSION (81-85): partial inline input from Japanese input method can disappear

Reviewed by Hyatt

  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): call w->text() before element()->value(), because w->text() has a side effect of updating element()->value() in the inline input case (RenderTextArea::updateFromElement): same for text areas
11:30 AM Changeset in webkit [4808] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3374566, list bullets don't display if list-style-type is none but a list-style-image
is specified. The spec says list-style-type: none does not apply to list-style-image,
and this fixes Microsoft's list bullet on their security pages.

Reviewed by john

  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
11:26 AM Changeset in webkit [4807] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
  • kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view that we make for the list box. This prevents the incorrect graphics state caching that causes the problem, although it's not entirely clear why this is necessary. This may ultimately turn out to be an AppKit bug, and if so we can roll out this change when the AppKit itself is fixed.
9:42 AM Changeset in webkit [4806] by hyatt
  • 2 edits in trunk/LayoutTests/fast

Updating layout tests.

9:34 AM Changeset in webkit [4805] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3373462, XML shows up as blank because the root is inline. The fix is
to just disallow inline roots.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp:

Aug 11, 2003:

4:41 PM Changeset in webkit [4804] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3349142, blocks inside inlines with generated content cause the generated
content to get all screwed up, especially if you try to print. This patch fixes
generated content to be continuation-aware (and vice versa), so that the content
behaves correctly when inlines get split.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
  • khtml/rendering/render_inline.cpp: (RenderInline::isInlineContinuation): (RenderInline::addChildToFlow): (RenderInline::cloneInline): (RenderInline::splitInlines):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::continuation): (RenderObject::isInlineContinuation):
  • khtml/rendering/render_object.h:
2:13 PM Changeset in webkit [4803] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari

Revidewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView installKeyEventHandler]): new (-[WebBaseNetscapePluginView removeKeyEventHandler]): new (-[WebBaseNetscapePluginView becomeFirstResponder]): call installKeyEventHandler (-[WebBaseNetscapePluginView resignFirstResponder]): call removeKeyEventHandler (-[WebBaseNetscapePluginView keyUp:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (-[WebBaseNetscapePluginView keyDown:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (TSMEventHandler): turn the TSM event into a series of EventRecords and pass them to the plug-in (-[WebBaseNetscapePluginView stop]): call removeKeyEventHandler because resignFirstResponder may not get called
10:22 AM Changeset in webkit [4802] by darin
  • 3 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.h: Fixed some small typo-ish strangenesses.

Aug 8, 2003:

6:00 PM Changeset in webkit [4801] by rjw
  • 6 edits in trunk/WebKit

Lots of healthy cleanup. Introduced width and shaping iterators
to simplify code and remove allocations for large text runs. Should
go further and make more use of these in the future (post panther).

Fixed 3369608. Crash in -[WebTextRenderer _CG_drawRun:style:atPoint:] at lovepucca.net
Fixed 3118050. Crash selecting text at ​http://www.faqs.org/rfcs/rfc2849.html (SELECTION)
Fixed 3371115. Can't correctly select text that contains surrogate pairs

Reviewed by darin.

  • Misc.subproj/WebUnicode.h:
  • Misc.subproj/WebUnicode.m: (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (hasShapeForNextCharacter): (shapeForNextCharacter): (initializeCharacterShapeIterator): (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (widthForNextCharacter): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):

Just formatting changed here

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
4:34 PM Changeset in webkit [4800] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Put "about:blank" in the back/forward item if there is no URL (which happens because there is no data source because the frame has never successfully loaded anything). Perhaps we can do better some day, but this avoids all the major bad effects in a safe way.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:26 PM Changeset in webkit [4799] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3368672, don't allow frames and framesets to be positioned or relpositioned.

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h:
11:34 AM Changeset in webkit [4798] by sullivan
  • 6 edits in trunk/WebCore

WebCore:

  • fixed 3362481 -- REGRESSION (89-90): clicking in a field causes page to move; esp. bad if the field moves out from under the mouse

Reviewed by Darin

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentEventIsMouseDownInWidget): new method
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): only scroll to reveal if currentEventIsMouseDownInWidget is false
  • kwq/KWQTextField.mm: (-[KWQTextField setHasFocus:]): ditto

WebBrowser:

  • fixed 3369587 -- REGRESSION (85-88): window position isn't being saved if moved from default position

Reviewed by Chris

The bug was that when the default window size is set
programmatically to be full screen height, we're setting the
_lastResizeWasProgrammatic bit in WindowController, which
prevents the window frame from being saved on subsequent window
moves (to avoid saving a window frame whose size was set by
JavaScript). The fix is to rejigger the code so that this bit
is not left set in this default-window-frame case.

  • WindowController.h:
  • WindowController.m: (-[WindowController defaultFrame]): New method for subclasses to override. Default implementation is to return the current frame. (-[WindowController setFrameToDefault]): new method, uses defaultFrame but leaves the _lastResizeWasProgrammatic bit clear
  • BrowserWindowController.m: (-[BrowserWindowController defaultFrame]): replace setDefaultWindowFrame with this override of new method; we don't know about the _lastResizeWasProgrammatic bit at this level. (-[BrowserWindowController windowDidLoad]): call new setFrameToDefault instead of old setDefaultWindowFrame
11:27 AM Changeset in webkit [4797] by sheridan
  • 3 edits in trunk

* empty log message *

10:42 AM Changeset in webkit [4796]
  • 3 copies
    2 deletes in tags/WebCore-92~1

This commit was manufactured by cvs2svn to create tag 'WebCore-92~1'.

10:42 AM Changeset in webkit [4795]
  • 1 copy
    3 deletes in tags/JavaScriptCore-92~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-92~1'.

10:42 AM Changeset in webkit [4794] by sheridan
  • 6 edits in trunk

JSC and WC 92.1, picking up missed fixes for Safari-92

8:21 AM Changeset in webkit [4793] by darin
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fixed 3366234 -- repro crash in CSS parser: function that can't be parsed (www.bi-flugplatz-magdeburg.de)
  • khtml/css/parser.y: Allocate a Function object for the "can't parse function" case, since the other code involved cannot handle 0 for the function.
  • khtml/css/parser.cpp: Regenerated.
8:21 AM Changeset in webkit [4792] by darin
  • 8 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • fixed 3365527 -- subscripting JavaScript strings does not work (leads to hang at www.newmagna.com.au)

The JavaScript specification says nothing about this, but other browsers seem to give
read-only access to the characters in a string as if the string was an array of characters.

  • kjs/array_object.cpp: (ArrayInstanceImp::get): Update to use a public toArrayIndex function instead of our own getArrayIndex function, so we can share with string. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.
  • kjs/ustring.h: Add toArrayIndex.
  • kjs/ustring.cpp: (UString::toArrayIndex): Added. Implements the rule from array.
  • kjs/identifier.h: Add a forwarding function so we can use toArrayIndex.
  • kjs/string_object.cpp: (StringInstanceImp::get): Return a single character string if the property name is an array index. (StringInstanceImp::hasProperty): Return true for property names that are suitable array indices.

Aug 7, 2003:

4:11 PM Changeset in webkit [4791]
  • 3 copies in tags/Safari-92

This commit was manufactured by cvs2svn to create tag 'Safari-92'.

4:11 PM Changeset in webkit [4790] by sheridan
  • 8 edits in trunk

Safari-92 version stamp

4:02 PM Changeset in webkit [4789] by rjw
  • 2 edits in trunk/WebKit

Fixed 3362939. Checked flippyness of view and adjust y coord accordingly.

Reviewed by John.

  • Misc.subproj/WebKitNSStringExtras.m:
2:32 PM Changeset in webkit [4788] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3330742>: 1.0 Safari fails to send NPP_URLNotify with the error of NPRES_NETWORK_ERR to Flash

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): call NPP_URLNotify so we cover both the failure and successful cases (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): have destroyStreamWithReason call NPP_URLNotify
2:07 PM Changeset in webkit [4787] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3367434>: newly-added KURL assertion failing reproducibly for JavaScript URL (www.thai.com)

The assertion is correct. The issue was in calling the function
with bad input. Non-hierarchical URLs should not have their "path"
elements submitted to a function that will replace dots.

The fix is to avoid calling this function with such non-hierarchical
URLs.

  • kwq/KWQKURL.mm: (KURL::parse)
1:53 PM Changeset in webkit [4786] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3368552>: Fix inappropriate use of NSURL creation methods in WebKit

Change calls to URLWithString: or URLWithString:relativeToURL to
_web_URLWithDataAsString: and _web_URLWithDataAsString:relativeToURL,
respectively.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:intoChild:]):
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]):
  • WebView.subproj/WebView.m: (-[WebView takeStringURLFrom:]): (-[WebView setMainFrameURL:]):
1:36 PM Changeset in webkit [4785] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Maciej

There was a bug in this code that caused a relative URL that was
being resolved against an empty base URL to process incorrectly.
The bug is that the resolution was being done twice. The first
time was correct handling of this case, but then the code did
not return at this point, and instead proceeded on through the
code path that is used to handle resolution of a relative URL
against a non-empty base. This double processing is clearly
wrong, and we found this bug as the result of the recent addition
of an assertion in some related code.

  • kwq/KWQKURL.mm: (KURL::KURL)
1:27 PM Changeset in webkit [4784] by darin
  • 7 edits
    1 delete in trunk

WebCore:

Reviewed by Richard.

  • fixed 3347114 -- remove vestiges of posing, including init routine, from WebKit
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Remove check for old versions of AppKit that let the WebKit posing handle key down events.
  • kwq/KWQTextField.mm: Removed fieldEditorDidMouseDown: methods.
  • WebCore.pbproj/project.pbxproj: Removed WebCoreFirstResponderChanges.h.
  • kwq/WebCoreFirstResponderChanges.h: Removed.

WebKit:

Reviewed by Richard.

  • fixed 3347114 -- remove vestiges of posing, including init routine, from WebKit
  • WebView.subproj/WebHTMLViewPrivate.m: Removed WebNSTextView, WebNSView, and WebNSWindow, removed the code to have them pose as NSTextView, NSView, and NSWindow, and removed excess imports that are no longer needed.
12:10 PM Changeset in webkit [4783] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed 3366975 - repro hang in KJS::Value::Value entering text at eil.com
  • kjs/string_object.cpp: (StringProtoFuncImp::call): When doing a match against a regexp with the global flag set, make sure to return null rather than an empty array when there is no match. This is what other browsers do.

Aug 6, 2003:

7:19 PM Changeset in webkit [4782] by rjw
  • 6 edits in trunk

WebKit:

Fixed 3365378. Edge case text run > 1024 hit by JS generated string. We weren't correctly checking size of string length. Used /2 instead of *2.

Reviewed by Vicki (and Dan!).

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]):

WebCore:

Fixed development build problem. WebCore.exp needed a newline at EOF.

  • WebCore-combined.exp:
6:35 PM Changeset in webkit [4781] by rjw
  • 1 edit in trunk/WebCore/WebCore.exp

Added newline to WebCore.exp. W/O newline development builds break.

5:11 PM Changeset in webkit [4780] by rjw
  • 12 edits in trunk

WebKit:

Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.

Reviewed by Ken.

  • Misc.subproj/WebUnicode.h:
  • Misc.subproj/WebUnicode.m: (_unicodeDirection): (_unicodeJoining): (_unicodeMirrored): (WebKitInitializeUnicode):
  • Misc.subproj/WebUnicodeTables.m:

WebCore:

Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.

Reviewed by Ken.

  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQString.h:
  • kwq/WebCoreUnicode.cpp:
  • kwq/WebCoreUnicode.h:
4:52 PM Changeset in webkit [4779] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc

Reviewed by rjw.

  • History.subproj/WebHistoryItemPrivate.h: added declaration for [WebBackForwardList _clearPageCache]
  • WebView.subproj/WebViewPrivate.m: (-[WebView _close]): clear the page cache when we are closing the web view so we call destroy on all the plug-ins on the page cache to break any retain cycles.
3:25 PM Changeset in webkit [4778] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3366587 -- Mail quits instantly (no crashlog) trying to reply to a particular message

Reviewed by Richard

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Return nil immediately if startNode is nil.
3:15 PM Changeset in webkit [4777] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Chris Blumenberg.

  • fixed 3366173 - crash in DOM::DomShared::ref loading www.berkheiser.net
  • khtml/ecma/kjs_html.cpp: (Image::putValue): Check for NULL before refing, because we set onLoadListener with a function that returns NULL if passed a value that's not a function.
1:36 PM Changeset in webkit [4776] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin and Dave.

  • fixed 3364433 - repro crash in khtml::RenderBlock::nodeAtPoint
  • khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists): When finding the right parent block to remove a float from, don't stop at floating or positioned elements. They could well have floats in their m_floatingObjects list due to overhang, and failing to remove them leads to crashes.
10:38 AM Changeset in webkit [4775] by cblu
  • 6 edits in trunk/WebKit

Fixed: <rdar://problem/3106525>: Results of JavaScript requests are not returned to plug-ins

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginStream.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setNotifyData:]): new (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): renamed from setResponse (-[WebBaseNetscapePluginStream startStreamWithResponse:]): new (-[WebBaseNetscapePluginStream receivedData:]): tweak (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): tweak (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:targetFrame:]): new
(-[WebBaseNetscapePluginView loadPluginRequest:]): call …
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call loadPluginRequest for JS requests
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): call renamed startStreamWithResponse
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): call setNotifyData (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed startStreamWithResponse
7:45 AM Changeset in webkit [4774] by kocienda
  • 5 edits in trunk/WebKit

Reviewed by Richard

Plugins in WebKit need to store URLs in the form of "C-style" strings.
Create and use a new, improved method to make these strings, and do
not traverse through the NSURL absoluteString method, since that can i
introduce errors.

  • Misc.subproj/WebNSURLExtras.h: Added _web_URLCString method.
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLCString]): Added.
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): Call new _web_URLCString method. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Ditto.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView frameStateChanged:]): Ditto. (-[WebBaseNetscapePluginView loadPluginRequest:]): Ditto.

Aug 5, 2003:

4:06 PM Changeset in webkit [4773] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • kwq/KWQPainter.mm: (QPainter::drawLine): Print a warning in debug builds when drawing a dashed line. Also, revert accidental commenting of lines that set the dash style.
3:18 PM Changeset in webkit [4772] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3365035>: Modify WebNSURLExtras to call improved NSURL creation API

  • Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithDataAsString:]): Call through to _web_URLWithDataAsString:relativeToURL:. (+[NSURL _web_URLWithDataAsString:relativeToURL:]): Call through to _web_URLWithData:relativeToURL:. (+[NSURL _web_URLWithData:]): Ditto. (+[NSURL _web_URLWithData:relativeToURL:]): Call CFURLCreateAbsoluteURLWithBytes API in CoreFoundation. (-[NSURL _web_originalData]): Use CFURLGetBytes API in CoreFoundation. Also make sure that a relative URL is resolved against its base. (-[NSURL _web_displayableString]): Call _web_originalData to get bytes to use to create the string. (-[NSURL _web_URLStringLength]): Use CFURLGetBytes API in CoreFoundation.
2:21 PM Changeset in webkit [4771] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

  • kjs/list.cpp: (List::copyTail): Test for loop termination with < instead of !=, since i starts at 1 but size could be 0. Do the same for the other loop for consistency's sake.
2:16 PM Changeset in webkit [4770] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3127909, copied text matched the document source instead of the
rendered HTML. This patch makes sure that the TextRuns are walked instead
of just blindly pulling the text out of the DOM node.

Reviewed by rjw

  • khtml/khtml_part.cpp: (KHTMLPart::selectedText):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
1:16 PM Changeset in webkit [4769] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin and Dave.

  • fixed 3363557 - REGRESSION (90-91): float:left element inside position:absolute element positioned wrong
  • khtml/rendering/render_block.cpp: (RenderBlock::calcInlineMinMaxWidth): Remove attempt to break line after flaot that follows a non-float. Removing this code fixes the regression and leaves pepboys and the meyerweb matrix theme working properly. Also, I could not find any evidence in the CSS2 spec that what this code is trying to do is right.
10:38 AM Changeset in webkit [4768] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3364251>: Modify KURL to call improved NSURL creation API

  • kwq/KWQKURL.mm: (KURL::getNSURL): Modify to use CFURLCreateAbsoluteURLWithBytes to create the NSURL.
10:33 AM Changeset in webkit [4767] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Maciej

In KWQKURL.mm, we copy the contents of a URL path from a source buffer
to a destination buffer. In the loop, we often access dst[-1]. It was
not entirely clear that this did not underrun the buffer. Upon further
inspection, it seems clear that it does not, but this small change
makes this more clear, and adds an assertion that all is well with
regard to indexing into the dst buffer.

  • kwq/KWQKURL.mm: (copyPathRemovingDots)

Aug 4, 2003:

6:38 PM Changeset in webkit [4766] by rjw
  • 3 edits in trunk/WebKit

Fixed 3363011. Pass b/f related key down events to super if b/f is disabled.

Reviewed by Chris.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):

Fixed 3363345. Retain static array used by IB to present WebView's bindable keys.

Review by Maciej

  • WebView.subproj/WebViewPrivate.m: (-[WebView _declaredKeys]):
4:44 PM Changeset in webkit [4765] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3363318>: REGRESSION: Plug-in content doesn't show up, animate etc

WebNetscapePluginConnectionDelegate must implement this method:

  • (void)connection:(NSURLConnection *)con didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:])
2:41 PM Changeset in webkit [4764] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3298153 -- get "screen font while printing" error, bad stuff happens after that (Sherlock, Safari)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): If we find ourselves in drawRect with the wrong printing mode, that usually means we're being printed as part of some larger print process, so do the layout in printing mode.
1:50 PM Changeset in webkit [4763] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3360977>: REGRESSION (7B28-7B29): main webview rejects drop of doc icon from BBEdit

Reviewed by darin.

  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_dragTypesForURL]): we handle NSFilenamesPboardType
  • WebKit.pbproj/project.pbxproj:
1:20 PM Changeset in webkit [4762] by rjw
  • 2 edits in trunk/WebKit

Fixed 3223989. Pass key down events to super if scrolling is disabled.

Reviewed by Chris (Welcome back!).

  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):

Aug 1, 2003:

5:54 PM Changeset in webkit [4761]
  • 1 copy
    95 deletes in branches/unlabeled-1.35.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.14'.

5:54 PM Changeset in webkit [4760] by rjw
  • 12 edits in trunk

WebKit:

Fixed 3095376. Implemented correct selection behavior for rtl scripts.
We still use our Arabic and Hebrew layout scheme.

Fixed 3360487. Implemented selection of ATSU rendered code.

Fixed 3360242. Return nil from _bodyBackgroundColor when no
background color specified. This was requested by Doug D.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer pointToOffset:style:position:reversed:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):

WebCore:

Fixed 3095376. Implemented correct selection behavior for rtl scripts.
We still use our Arabic and Hebrew layout scheme.

Fixed 3360487. Implemented selection of ATSU rendered code.

Fixed 3360242. Return nil from _bodyBackgroundColor when no
background color specified. This was requested by Doug D.

Reviewed by Maciej.

  • khtml/rendering/font.cpp: (Font::drawHighlightForText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextRun::paintSelection):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bodyBackgroundColor):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
5:47 PM Changeset in webkit [4759] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3265419 - homepage preview doesn't show Images with names longer than 17 chars
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTML):
4:33 PM Changeset in webkit [4758] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com

I fixed this by making sure to cancel any pending redirects before
telling the bridge to load a URL. We don't want a race between
getting back a response and the redirect timer.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge provisionalLoadStarted]): New method - call equivalent part method. We count on the other side of the bridge to call this once it knows a load will really happen (not cancelled by policy, etc).
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::provisionalLoadStarted): cancel pending redirects.

WebKit:

Reviewed by Darin.

  • fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): When going to provisional state, tell the bridge that a provisional load started, so it can cancel any pending redirects.
4:04 PM Changeset in webkit [4757] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

  • fixed 3222621 - Cryptic "anonymous function hack" messages in console (10.2.4)
  • kjs/lexer.cpp: (Lexer::lex): Remove useless debug spew.
3:58 PM Changeset in webkit [4756] by sheridan
  • 3 edits in trunk

Safari-91u versions ... tree is open

11:10 AM Changeset in webkit [4755]
  • 3 copies in tags/Safari-91

This commit was manufactured by cvs2svn to create tag 'Safari-91'.

11:10 AM Changeset in webkit [4754] by sheridan
  • 8 edits in trunk

Safari-91 version stamp

10:40 AM Changeset in webkit [4753] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3347286, hang on pepboys.com. Text-indent had numerous bugs that
resulted in an infinite loop because some incorrect values were being compared.
This patch changes floats to ignore text-indent when positioning themselves
(as they should).

The maxwidth computation also didn't deal properly with text-indent, applying it
multiple times instead of once, and also only applying it for text and not for
inline replaced elements (images, form controls, etc.).

With these changes pepboys.com renders correctly. This patch also conveniently fixes
the last rendering error on meyerweb's Matrix stylesheet.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:

Jul 31, 2003:

5:16 PM Changeset in webkit [4752] by rjw
  • 2 edits in trunk/WebKit

Make sure width is initialized for monospace optimizations.
Reviewed by Vicki.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer checkSelectionPoint:style:position:reversed:]):
4:06 PM Changeset in webkit [4751] by rjw
  • 9 edits in trunk

WebKit:

Fixed 3359152. SPI to get the background color for a frame.

Reviewed by hyatt.

  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _bodyBackgroundColor]):

WebCore:

Fixed 3359152. SPI to get the background color for a frame.

Reviewed by hyatt.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bodyBackgroundColor):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge bodyBackgroundColor]):
3:32 PM Changeset in webkit [4750] by hyatt
  • 31 edits in trunk/LayoutTests

Update layout tests.

3:25 PM Changeset in webkit [4749] by hyatt
  • 3 edits in trunk/WebCore

Fix for "The Matrix" stylesheet on meyerweb.com and for 26(!) of the
layout tests. Basically when laying out a line, you have a beginning, and end,
and midpoints in between that tell you what whitespace to skip over. It was
possible to end up with the last midpoint being a start point that was past the
end of the line, and in that case, we would sometimes not strip off the trailing
space at the end of the line like we should.

This patch adds a simple function to check for this condition. It strips off the
out-of-bounds midpoint, and then shaves off the trailing space from the previous
midpoint if it's necessary to do so.

Also fix the way spaces are counted so that we don't add in spaces for text that
is not part of any bidi runs.

Reviewed by john

  • khtml/rendering/bidi.cpp:
1:39 PM Changeset in webkit [4748] by rjw
  • 2 edits in trunk/WebKit

Fixed 3358870. Fall back on 'user defaults' values when a value
in a custom instance of WebPreferences hasn't been overriden.

Reviewed by Eric Seymour.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences _stringValueForKey:]): (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _boolValueForKey:]):

Jul 30, 2003:

7:29 PM Changeset in webkit [4747]
  • 1 copy
    319 deletes in branches/unlabeled-1.15.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.15.14'.

7:29 PM Changeset in webkit [4746] by rjw
  • 17 edits in trunk

WebKit:

Preparation for 3095376.

Reviewed by Maciej.

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForRun:style:widths:]): (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer checkSelectionPoint:style:position:reversed:]):

WebCore:

Preparation for 3095376.

Reviewed by Maciej.

  • WebCore-combined.exp:
  • WebCore.exp:
  • khtml/rendering/font.cpp: (Font::checkSelectionPoint):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextRun::checkSelectionPoint):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeTextRun): (WebCoreInitializeEmptyTextStyle):
5:46 PM Changeset in webkit [4745] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3274144, floats in Help Viewer overlapped when they shouldn't have.
lineWidth was overflowing (and positionNewFloats was also sometimes not called
when it should have been).

Reviewed by darin

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
5:38 PM Changeset in webkit [4744] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Ignore layout test results.

5:37 PM Changeset in webkit [4743] by darin
  • 18 deletes in trunk/LayoutTests

Remove actual and diffs checked in by accident.

5:21 PM Changeset in webkit [4742] by darin
  • 245 adds in trunk/LayoutTests/css1

More layout tests here.

5:18 PM Changeset in webkit [4741]
  • 1 copy
    104 deletes in branches/unlabeled-1.1.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.14'.

5:18 PM Changeset in webkit [4740] by darin
  • 842 adds in trunk/LayoutTests

Moving layout tests in here.

4:54 PM Changeset in webkit [4739] by darin
  • 6 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed problem where some JavaScriptCore symbols had no namespace or prefix
  • kjs/grammar.y: Added a define for yylloc to make it use the kjs prefix. This is the same thing done for the rest of the symbols automatically by yacc, but for some reason it's not done for yyloc. Also make automatic() function static.
  • kjs/grammar.cpp: Regenerated.
  • kjs/lexer.cpp: Use kjsyylloc instead of yyloc.
  • pcre/pcre.h: Add defines to prepend kjs prefixes for all the PCRE functions.
3:34 PM Changeset in webkit [4738] by darin
  • 3 edits in trunk/JavaScriptCore
  • Makefile.am: Include the subdirectory with the PCRE code in it.
3:19 PM Changeset in webkit [4737] by hyatt
  • 4 edits in trunk/WebCore

Add support for setting the text-shadow's color. This uses a new CG API,
so updating to a fairly recent Panther is required.

Reviewed by rjw

  • khtml/css/cssparser.cpp: (CSSParser::parseShadow):
  • kwq/KWQPainter.mm: (QPainter::setShadow):
3:09 PM Changeset in webkit [4736] by sullivan
  • 1 edit in trunk/WebCore/WebCore-tests.exp

Tweaked for signature change to KWQRegExp::match, to fix build

2:03 PM Changeset in webkit [4735] by sullivan
  • 3 edits in trunk/WebCore

Tests:

  • qt/qregexp-test.cpp: (main): fixed broken build by removing final parameter to match()

WebCore:

  • fixed 3346460 -- images > area (2048x2048) are compressed vertically when displayed as src of img tag

Reviewed by Darin

  • khtml/rendering/render_image.cpp: (RenderImage::layout): Just comment out the code that imposes a maximum image size (incorrectly); maybe KDE folks want to make this work, but we don't need to try to prevent large images.
2:02 PM Changeset in webkit [4734] by rjw
  • 1 edit in trunk/WebKit/WebView.subproj/WebViewPrivate.m

Backout hack for IB. IB will deal with the issue internally.

1:49 PM Changeset in webkit [4733] by sullivan
  • 1 edit in trunk/WebCore/WebCore-combined.exp

Fixed signature for QRegExp::match in .exp file to fix build

1:48 PM Changeset in webkit [4732] by rjw
  • 2 edits in trunk/WebKit

Fixed 3356518. Added private method called by IB to ensure
that autoresizeSubviews flag is turned on correctly.

Reviewed by mjs.

  • WebView.subproj/WebViewPrivate.m: (-[WebView _finishedMakingConnections]):
12:04 PM Changeset in webkit [4731] by sullivan
  • 9 edits in trunk

JavaScriptCore:

  • JavaScriptCore part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan

Reviewed by Darin

  • JavaScriptCore.pbproj/project.pbxproj: Mark pcre.h as a Private header

WebCore:

  • WebCore part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan

There were two problems: the regex library being used by
KWQRegExp.mm didn't handle unicode at all, and the way we
were using word boundaries in our regular expressions didn't
work with Japanese.

Reviewed by Darin

  • kwq/KWQKHTMLPart.mm: (regExpForLabels): Redid the way word boundaries are used; the old way didn't work with PCRE, and also didn't work with Japanese.
  • kwq/KWQRegExp.h: removed treatStartAsStartOfInput parameter to match() that Trey had added; it was being used incorrectly and was not necessary.
  • kwq/KWQRegExp.mm: (compareStringOffsets), (createSortedOffsetsArray), (convertCharacterOffsetsToUTF8ByteOffsets), (convertUTF8ByteOffsetsToCharacterOffsets): Code copied from JavaScriptCore/regexp.cpp to convert between byte and character offsets. Darin preferred that I copy these methods rather than make them public in JavaScriptCore/regexp.h. (QRegExp::KWQRegExpPrivate::compile): converted from regex.h style to pcre.h style (QRegExp::KWQRegExpPrivate::~KWQRegExpPrivate): ditto (QRegExp::match): ditto (QRegExp::search): removed parameter to match() (QRegExp::searchRev): ditto
  • kwq/KWQString.mm: (QString::replace): removed parameter to match()

WebBrowser:

  • WebBrowser part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan

Reviewed by Darin

  • FormCompletionController.m: (-[FormToABBinder _indexMapping:]): Replace ASSERT with ERROR when label tables have duplicates. The Japanese localized file that I was using to test with had such duplicates, and was crashing on me.
11:48 AM Changeset in webkit [4730] by rjw
  • 3 edits in trunk/WebCore

Fixed 3349598. Deal gracefully with <li> items that
are not in a <ol> or <ul>, instead of crashing!

Reviewed by Ken.

  • kwq/KWQKHTMLPart.mm: (listParent): (KWQKHTMLPart::attributedString):

Jul 29, 2003:

6:36 PM Changeset in webkit [4729] by rjw
  • 3 edits in trunk/WebCore

Use the new KURL getNSURL() method to create an NSURL.

Reviewed by darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
5:39 PM Changeset in webkit [4728] by darin
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3311756 -- REGRESSION (76-77): radio buttons in different forms act as the same set by rolling out old fix for 3158411 -- radio button groups are supposed to be per-form The real bug at flyglobespan.com is what's fixed below.
  • khtml/html/html_formimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::radioClicked): (HTMLInputElementImpl::~HTMLInputElementImpl): (HTMLInputElementImpl::setType): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::isEditable):
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • fixed 3158411 -- re-opened form is one form in other browsers, multiple forms in Safari (flyglobespan.com)
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Don't open a form if we encounter a form element inside another form.
11:00 AM Changeset in webkit [4727] by sullivan
  • 4 edits in trunk/WebCore

WebCore:

  • fixed 3346707 -- AutoFill does not fill in email address on Apple Store new account page

Reviewed by Darin

  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::searchRev): This method (that Trey had added) used a placeholder 2nd parameter that was always -1 and should have been ignored. But it was being passed into QRegExp::match as the starting index, which happened to work in many cases, but not if the byte of memory before the string happened to be a null character. Fixed by eliminating the placeholder parameter entirely.

WebBrowser:

  • fixed 3345689 -- Safari-89: timeout alert sheet sometimes shows for the wrong tab

Reviewed by Darin

  • BrowserWindowController.m: (-[BrowserWindowController closeTab:]): We were removing the old tab, then switching to the next tab. But removing the old tab causes NSTabView to switch to the previous tab, so there was an instant where the previous tab was switched in and thus felt compelled to put up its pending sheet. Fixed by switching to new tab before removing old one, which should also be a slight speed improvement, since we bypass going to the wrong tab momentarily.

Jul 28, 2003:

6:23 PM Changeset in webkit [4726] by rjw
  • 3 edits in trunk/WebKit

Fixed 3323866. Provide SPI to IB to enable scoping of preferences
values on a document-by-document basis.

Reviewed by Maciej.

  • WebView.subproj/WebPreferences.m: (-[WebPreferencesPrivate dealloc]): (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (+[WebPreferences _userDefaultsKeysForIB]): (+[WebPreferences _setIBCreatorID:]): (+[WebPreferences _IBCreatorID]): (-[WebPreferences _concatenateKeyWithIBCreatorID:]):
  • WebView.subproj/WebPreferencesPrivate.h:
5:55 PM Changeset in webkit [4725] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed 3344647 -- reachedTerminalState assertion in WebBaseResourceHandleDelegate.m
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): Use [super cancelWithError:] rather than [self receivedError:]. I checked carefully to see that this code now does everything the old code did (and a bit more).
5:10 PM Changeset in webkit [4724] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Richard.

  • fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel
  • kjs/internal.cpp: (Parser::parse): ref() and deref() the program node, to make sure to clean up properly, before deleting it. (InterpreterImp::checkSyntax): Likewise.
2:58 PM Changeset in webkit [4723] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3343050 - nil-deref in saveInterpreterBuiltins running Sherlock via MallocDebug in Panther7B20
  • fixed 3343942 - Safari crashes when clicking on link w/ JavaScript turned off
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveInterpreterBuiltins): Don't attempt to save when JavaScript is off. (KWQKHTMLPart::restoreInterpreterBuiltins): Don't attempt to restore when JavaScript is off. (KWQKHTMLPart::saveWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::saveLocationProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreLocationProperties): Remove ERROR, since that case is normal when JS is off.
2:24 PM Changeset in webkit [4722] by rjw
  • 3 edits in trunk/WebKit

Fixed 3341859.

Check that the WebHTMLView is initialized in viewWillMoveToWindow: and

viewDidMoveToWindow. Don't do anything if we aren't initialized. This
happens when decoding a WebView. When WebViews are decoded their subviews

are created by initWithCoder: and so won't be normally initialized. The

stub views are discarded by WebView.

Reviewed by John.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]):
1:58 PM Changeset in webkit [4721] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3279864 -- remove class_poseAs calls from WebKit
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Call _setDrawsOwnDescendants, if we have a new enough AppKit.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Don't pose as NSView, if we have a new enough AppKit.
1:39 PM Changeset in webkit [4720] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage on my buggy panther compiler.

Reviewed by darin

  • kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit):
1:37 PM Changeset in webkit [4719] by kocienda
  • 10 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3336933>: REGRESSION (Panther): Mozilla build downloaded
with wrong extension, bad file size (gzip)

Use new delegate methods that allow for the correct reporting
of progress in cases where Foundation-level content decoding
has been performed on data received

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveData:lengthReceived:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
1:32 PM Changeset in webkit [4718] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3343250, XML didn't know how to make implicit tbodies when starting new elements,
nor did it know to skip implicit elements when popping its element stack.

Reviewed by darin

  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::endElement):
1:16 PM Changeset in webkit [4717] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed leak of WebDataRequestParameters objects
  • WebView.subproj/WebDataProtocol.m: (-[NSMutableURLRequest _webDataRequestParametersForWriting]): Release the WebDataRequestParameters object after putting it in the dictionary.
10:14 AM Changeset in webkit [4716] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly in Safari when viewed standalone (uspto.gov)

Reviewed by Darin

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _adjustSizeToPixelDimensions]): call setScalesWhenResized:YES

Jul 25, 2003:

3:04 PM Changeset in webkit [4715] by rjw
  • 2 edits in trunk/WebKit

Fixed 3344519. Prevent infinite recursion attempting font substitution.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
2:22 PM Changeset in webkit [4714] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect
  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Use chall, the parameter, not challenge, the not-yet-set ivar so we get the right failure count &c.
1:47 PM Changeset in webkit [4713] by hyatt
  • 6 edits in trunk/WebCore

Rename box and inline-box to -khtml-box and -khtml-inline-box.

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
1:22 PM Changeset in webkit [4712] by hyatt
  • 21 edits in trunk/WebCore

Fix for 3343529, inline blocks crashing Safari. There were lots of problems with
inlne-blocks. This code gets basic inline-blocks working properly (with no crashes).

Several functions have been patched to take an isRootLineBox parameter. This is used
to tell whether you're supposed to examine the root line box for a block or the block
itself. In the case of baselinePosition and lineHeight, it indicates whether the caller
wants to measure the outside or inside of the box.

The outside of an inline-block is like a replaced element (e.g., an image), but the
inside is like a block, e.g., you want measurements for
the line height and baseline position of a root line box for that block.

Similarly, createInlineBox has been patched in order to know whether you're making a
root inline box *inside* the inline-block or an inline box that *encompasses* the
inline-block element (like you'd do for an image).

A number of places had isInline() calls and needed to be patched to also check
isInlineBlockOrInlineTable(). How to treat the inline-block again basically depends
on whether the caller is looking at the outside of the block (in which case you're like
an inline replaced element) or the inside of the block (in which case you're just like
a block).

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth): (RenderBox::calcHeight):
  • khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): (RenderButton::baselinePosition): (RenderSubmitButton::baselinePosition): (RenderSelect::baselinePosition):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights):
  • khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth): (RenderObject::getVerticalPosition): (RenderObject::lineHeight): (RenderObject::baselinePosition): (RenderObject::createInlineBox):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::lineHeight): (RenderReplaced::baselinePosition):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::lineHeight): (RenderText::baselinePosition): (RenderText::createInlineBox):
  • khtml/rendering/render_text.h:
12:54 PM Changeset in webkit [4711] by rjw
  • 2 edits in trunk/WebKit

Use 11 point bold, instead of 12 point bold, to draw dragged link
labels. This matches the text drawn in the bookmarks bar.

Reviewed by John.

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
3:27 AM Changeset in webkit [4710] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3343527, crash when attempting to access rules in the CSS OM.
Our KWQListImpl doesn't null check accesses, so anything out
of bounds would cause a crash.

Reviewed by mjs

  • kwq/KWQListImpl.mm: (KWQListImpl::at):
3:10 AM Changeset in webkit [4709] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
  • khtml/rendering/render_form.cpp: (RenderTextArea::handleFocusOut): Check if we still have an element. It could have gone away while handling an event that replaced some or all of the document, and if we're gonna be destroyed soon then there's no point doing this work anyway.
2:11 AM Changeset in webkit [4708] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
  • khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter): We want to ref element() across this call, but it could get unset, so store it in a local variable.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit): invalidate our KWQTextField.
  • kwq/KWQTextField.h:
  • kwq/KWQTextField.mm: (-[KWQTextField invalidate]): Set widget to NULL. (-[KWQTextField action:]): Do nothing if widget is NULL. (-[KWQTextField controlTextDidBeginEditing:]): Likewise. (-[KWQTextField controlTextDidEndEditing:]): Likewise. (-[KWQTextField controlTextDidChange:]): Likewise. (-[KWQTextField control:textShouldBeginEditing:]): Likewise. (-[KWQTextField control:textShouldEndEditing:]): Likewise. (-[KWQTextField control:didFailToFormatString:errorDescription:]): Likewise. (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): Likewise. (-[KWQTextField control:isValidObject:]): Likewise. (-[KWQTextField control:textView:doCommandBySelector:]): Likewise. (-[KWQTextField stringValue]): Likewise. (-[KWQTextField setStringValue:]): Likewise. (-[KWQTextField setFont:]): Likewise. (-[KWQTextField nextKeyView]): Likewise. (-[KWQTextField previousKeyView]): Likewise. (-[KWQTextField nextValidKeyView]): Likewise. (-[KWQTextField previousValidKeyView]): Likewise. (-[KWQTextField fieldEditorDidMouseDown:]): Likewise. (-[KWQTextField textView:shouldHandleEvent:]): Likewise. (-[KWQTextField textView:didHandleEvent:]): Likewise. (-[KWQTextField setHasFocus:]): Likewise.

Jul 24, 2003:

6:21 PM Changeset in webkit [4707] by rjw
  • 5 edits in trunk/WebKit

Fixed 3279910. Change the way we draw dragged link to use
WebKit's measurement and drawing. Also made the look match
the bookmarks bar text.

Reviewed by Maciej.

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _handleMouseDragged:]):
3:43 PM Changeset in webkit [4706] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3332622 -- Safari Abbreviates Attribute Names in EMBED tags

Reviewed by Richard

  • khtml/html/htmltokenizer.h: bumped fixed max length of attributes from 14 to 1024. Theoretically they could be any arbitrary length, but it's more risk than it's worth to rewrite the code that uses the fixed-size buffer that is based on this value.
3:27 PM Changeset in webkit [4705] by rjw
  • 3 edits in trunk/WebKit

Removed unnecessary log.

Reviewed by John.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithData:MIMEType:]):

Add another check to use ATSU for Limbu (Unicode 4.0) script.
Also made shouldUseATSU inline.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU):
3:07 PM Changeset in webkit [4704] by hyatt
  • 27 edits in trunk/WebCore

Change all uses of "konq-" in CSS to "khtml-".

Also rename the CSS3 properties that have either buggy or
incomplete implementations to "-khtml-property" for forward
compatibility (so that people don't have to worry about a buggy
Safari if/when they use the official property names).

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseRule): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::parseFontFamily): (CSSParser::parseShadow):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.h:
  • khtml/css/parser.y:
  • khtml/css/quirks.css:
  • khtml/css/tokenizer.cpp:
  • khtml/css/tokenizer.flex:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::calcHorizontalMargins):
  • khtml/rendering/render_flexbox.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp: (RenderTableCell::setStyle):
12:49 PM Changeset in webkit [4703] by sheridan
  • 3 edits in trunk

Safari-91u

12:39 PM Changeset in webkit [4702]
  • 3 copies in tags/Safari-90

This commit was manufactured by cvs2svn to create tag 'Safari-90'.

12:39 PM Changeset in webkit [4701] by sheridan
  • 8 edits in trunk

Safari-90 stamp

Jul 23, 2003:

8:38 PM Changeset in webkit [4700] by mjs
  • 3 edits in trunk/WebKit

Build breakage fix:

Fix WebKit to build with the latest Foundation.

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_isJavaScriptURL]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFTPDirectoryURL]): (-[NSString _webkit_isFTPDirectoryURL]):
6:51 PM Changeset in webkit [4699] by hyatt
  • 3 edits in trunk/WebCore

Fix opacity to respect clipping.

Reviewed by rjw

  • khtml/rendering/render_layer.cpp: (RenderLayer::paint):
6:38 PM Changeset in webkit [4698] by rjw
  • 7 edits in trunk/WebKit

Fixed 3311725: Added support for key/value binding.
(As a side effect also made icon loading work! In 1.0
it doesn't work unless a secret preference value is set.)

Reviewed by Ken.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebView.m: (-[WebView setMainFrameURL:]): (-[WebView mainFrameURL]): (-[WebView isLoading]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (-[WebView _completeProgressForConnection:]): (-[WebView _declaredKeys]): (-[WebView setObservationInfo:]): (-[WebView observationInfo]): (-[WebView _willChangeBackForwardKeys]): (-[WebView _didChangeBackForwardKeys]): (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
5:32 PM Changeset in webkit [4697] by rjw
  • 2 edits in trunk/WebKit

i Fixed 3341119: Crash when content contains nil (0x0) characters.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:atPoint:]):
5:23 PM Changeset in webkit [4696] by darin
  • 11 edits in trunk

WebCore:

Reviewed by John.

  • fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)
  • kwq/KWQTextArea.h: Add drawing state variable so we can tell the difference between calls to draw the insertion point inside and calls to draw outside the redraw machinery.
  • kwq/KWQTextArea.mm: (-[KWQTextArea displayRectIgnoringOpacity:]): Added. Set drawing flag while in here. This is the method used by KWQWidget to draw. (-[KWQTextArea textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added. Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead of immediately drawing when asked to draw outside the normal redraw machinery. (-[KWQTextAreaTextView keyDown:]): Call interceptKeyEvent before handling each key down event.
  • kwq/KWQTextField.h: Add drawing state variable so we can tell the difference between calls to draw the insertion point inside and calls to draw outside the redraw machinery.
  • kwq/KWQTextField.mm: (-[KWQTextField displayRectIgnoringOpacity:]): Added. Set drawing flag while in here. This is the method used by KWQWidget to draw. (-[KWQTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added. Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead of immediately drawing when asked to draw outside the normal redraw machinery. (-[KWQTextField textView:shouldHandleEvent:]): Call interceptKeyEvent before handling each key down event. (-[KWQTextField textView:didHandleEvent:]): Call fieldEditorDidMouseDown: after handling each mouse down event.
  • kwq/KWQWidget.mm: (QWidget::paint): Add comment about dependency on displayRectIgnoringOpacity: use in KWQTextArea and KWQTextField.
  • kwq/WebCoreFirstResponderChanges.h: Added a comment about obsolescence.
  • Xcode wanted to change this, because it now knows JavaScriptCore is a framework
  • WebCore.pbproj/project.pbxproj: Munged by Xcode.

WebKit:

Reviewed by John.

  • fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Only pose as NSTextView and NSWindow if we have an older AppKit. If we have a new enough AppKit, the code in WebCore now takes care of things.
3:56 PM Changeset in webkit [4695] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3340885, invalid colors were being mapped to transparentColor,
thus causing invisible text!

Reviewed by kocienda

  • khtml/css/cssparser.cpp: (CSSParser::parseColorFromValue):
3:48 PM Changeset in webkit [4694] by rjw
  • 14 edits in trunk

WebCore:

Fixed for 3259840. Use ATSU for scripts we don't handle internally,
i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters. Much cleaner.

Reviewed by Maciej.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreMakeTextRun): (WebCoreMakeEmptyTextStyle):

WebKit:

Fixed for 3259840. Use ATSU for scripts we don't handle internally,
i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters. Much cleaner.

Reviewed by Maciej.

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): (-[WebTextRenderer _setupFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:]): (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _initializeATSUStyle]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
3:36 PM Changeset in webkit [4693] by hyatt
  • 5 edits in trunk/WebCore

Clean up the mess left by a couple of previous checkins. I had
patched computeLength and computeLengthFloat to take a CSSStyleSelector,
but then I came up with a simpler solution that didn't require that
the selector be passed in as an argument. I forgot, however, to revert
the functions back to their original forms. This patch does that.

Reviewed by john

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssstyleselector.cpp:
1:04 PM Changeset in webkit [4692] by kocienda
  • 24 edits in trunk/WebKit

WebKit:

Reviewed by Darin

Removed dependency on Foundation NSURL_NSURLExtras file.
Copied the required methods from that file to WebNSURLExtras,
temporarily renaming the methods that are now in both
places to have a _webkit_ prefix. The names will be changed
back once every one is living on a Foundation version that
no longer contains these methods.

The files below were changed in one of three ways:

  1. Rename _web_URLWithString: to _web_URLWithDataAsString:
  2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
  3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem URL]):
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m: (+[WebURLsWithTitles URLsFromPasteboard:]):
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]):
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): (+[NSURL _web_URLWithDataAsString:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_displayableString]): (-[NSURL _web_URLStringLength]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_isJavaScriptURL]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFTPDirectoryURL]): (-[NSURL _webkit_shouldLoadAsEmptyDocument]): (isHexDigit): (hexDigitValue): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_stringByReplacingValidPercentEscapes]): (-[NSString _webkit_scriptIfJavaScriptURL]):
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]):
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _shouldReloadForCurrent:andDestination:]): (-[WebFrame _URLsMatchItem:]):
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient loadWithRequest:]): (-[WebMainResourceClient setDefersCallbacks:]):

WebBrowser:

Reviewed by Darin

Removed dependency on Foundation NSURL_NSURLExtras file.
Copied the required methods from that file to WebNSURLExtras
in WebKit. WebBrowser code now depends on that file instead.
In order to avoid method name collisions, the WebNSURLExtras
some methods have been temporarily renamed to have a _webkit_
prefix. The names will be changed back once every one is
living on a Foundation version that no longer contains these methods.

The files below were changed in one of three ways:

  1. Rename _web_URLWithString: to _web_URLWithDataAsString:
  2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
  3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
  • AppController.m: (-[AppController handleURLEvent:withReplyEvent:]):
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToScriptSpecifiedURL]): (-[BrowserDocument goHome:]):
  • BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController URLFromShortcutFile:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]):
  • BrowserNSNetServiceExtras.m: (-[NSNetService URL]):
  • BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): (-[NSString bestURLForUserTypedString]):
  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): (-[WebBookmark URLsForGoToAllWithTitles:]):
  • BrowserWebController.m: (-[BrowserWebView mouseoverTextForElement:modifierFlags:]): (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]): (-[BrowserWebView locationFieldURL]): (-[BrowserWebView goToRequest:withTabLabel:allowJavaScript:waitInQueue:]): (-[BrowserWebView goToURL:withFallbackURLs:]):
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocationWithWindowPolicy:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController goToBookmarks]):
  • ContextMenuHandler.m: (-[BrowserWebView goToAddress:]):
  • Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
  • DownloadProgressEntry.m:
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]):
  • GlobalHistory.m: (-[GlobalHistory updateDisplayTitleForHistoryItem:]):
  • GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor launchApplicationSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginErrorSheetEnded:returnCode:contextInfo:]):
  • LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
  • LocationFieldEditor.m: (-[LocationFieldEditor paste:]):
  • Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]):
  • RendezvousController.m: (-[RendezvousController init]):
  • ResourceProgressEntry.m: (-[ResourceProgressEntry open]): (-[ResourceProgressEntry download]):
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]): (-[PageLoadTestRunner loadTestSuiteFile:]): (-[PageLoadTestRunner pageLoadStarted:]):
  • TitleBarButton.m: (-[TitleBarButton showPathRepresentingPopUpMenuForEvent:URL:]):
  • URLCompletionController.m:
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf setURLString:]):
11:07 AM Changeset in webkit [4691] by hyatt
  • 3 edits in trunk/WebCore

Temporary hack to ensure that the layout tests will not all
be failures if/when the layout tests regression gets fixed.
Will remove once we can run the tests.

Reviewed by ken

  • khtml/rendering/render_block.cpp:

Jul 22, 2003:

11:35 PM Changeset in webkit [4690] by hyatt
  • 11 edits
    3 deletes in trunk/WebCore

Allow HTML and BODY to be any display type. This patch primarily eliminates the
RenderBody class and makes the code that deals with background propagation smart
enough to locate the correct renderers for the HTML and BODY elements (by crossing
back into the DOM tree).

Reviewed by darin

  • ForwardingHeaders/rendering/render_body.h: Removed.
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument):
  • khtml/html/html_baseimpl.h:
  • khtml/rendering/render_body.cpp: Removed.
  • khtml/rendering/render_body.h: Removed.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::repaint):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::isBody):
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::createRenderer):
11:02 PM Changeset in webkit [4689] by darin
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu
  • kwq/mac-encodings.txt: Added "Shift_JIS_X0213-2000". Changed all non-HKSCS Big5 encodings to use the DOS variant of Big5 as requested by Peter Edberg, but left Big5-HKSCS alone.
  • kwq/KWQCharsets.mm: Added kCFStringEncodingBig5_DOSVariant constant.
  • kwq/KWQCharsetData.c: Regenerated.
  • fixed 3100151 -- subframes without explicit charset settings should inherit from parent, not use default
  • khtml/khtml_part.cpp: (KHTMLPart::write): Get the default encoding from the parent part, if there is one.

WebBrowser:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu

Since Shift JIS X0213 does not yet have an IANA name, had to change the code
to get the name another way. This led me to change the menu items to work by having
the character set name in the representedObject instead of the CFString character set
code in the tag.

  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Set the state of a changeTextEncoding: menu item based on the represented object, not the tag. (-[BrowserWindowController changeTextEncoding:]): Pass the represented object into setCustomTextEncodingName: rather than calling CFStringConvertEncodingToIANACharSetName.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences updateDefaultCharacterSetPopup]): (-[AppearancePreferences takeDefaultCharacterSetFrom:]):
  • TextEncodingMenu.m: Added both kCFStringEncodingShiftJIS_X0213_00 and kCFStringEncodingBig5_HKSCS_1999 to the menu. (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Get the name using CFStringConvertEncodingToIANACharSetName, with hardcoded fallbacks for kCFStringEncodingGB_2312_80 and kCFStringEncodingShiftJIS_X0213_00, which do not have their IANA names in the table. Put the name in the represented object instead of putting the encoding constant in the tag. No need for the separatorItemWithNonConflictingTag method any more, since a character set name of nil does not ever get used (unlike a tag of 0, which was used for US-ASCII). (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Use the represented object check to detect the end of a group rather than checking the tag. No need for the separatorItemWithNonConflictingTag method (as above).
  • English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.
9:41 PM Changeset in webkit [4688] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
1:48 PM Changeset in webkit [4687]
  • 2 copies
    2 deletes in tags/Safari-89~1

This commit was manufactured by cvs2svn to create tag 'Safari-89~1'.

1:48 PM Changeset in webkit [4686] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

Remove -seg_addr_table_filename to fix build.

11:24 AM Changeset in webkit [4685] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3293898, list bullets in ordered lists with an inside list
position were rendering as though they had a width of 0. This was
a bug in KWQFontMetrics, which needed to handle the case where a
length of -1 was passed in to the width method (in which case
you should use the length of the whole string).

Reviewed by john

  • kwq/KWQFontMetrics.mm: (QFontMetrics::width):
9:40 AM Changeset in webkit [4684] by hyatt
  • 13 edits in trunk/WebCore

Fix for mozilla.org front page. This patch re-architects
align="left" and align="right" (for rtl and ltr directionality
respectively). The attributes are mapped to custom text-align
values, konq-left and konq-right, just as was done with the
center/middle attributes for alignment.

A number of "hack" style rules have been dropped from html4.css
and replaced with this C++ code that now works in the general
case for any children of align="left/right" divs and tds.

In addition, absmiddle support has been added for <td>s.

For RTL blocks, there is also a regression fix (this was probably
the #1 culprit for mangled placement of blocks in Hebrew Web
pages). The old code was doing byzantine math that happened to
work out. When I tried to simplify it before 1.0, I missed a spot
and basically broke margin handling on RTL blocks completely.

Reviewed by mjs

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::calcHorizontalMargins):
  • khtml/rendering/render_style.h:

Jul 21, 2003:

3:53 PM Changeset in webkit [4683] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3333557, crash on www.dremedia.com. markDescendants in RenderBlock
was not passing in its argument in the recursive step, so the float wasn't
getting properly cleared out of everyone's lists.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
2:19 PM Changeset in webkit [4682] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3182596, percentage height tables with cells that specify
tiny percentage heights used that height even if it was smaller
than the cell's minimum required height.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
1:41 PM Changeset in webkit [4681] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3316867 -- tabbing to textarea below visible part of page doesn't scroll down
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added call to _KWQ_scrollFrameToVisible to match the one in KWQTextField.
1:29 PM Changeset in webkit [4680] by hyatt
  • 3 edits in trunk/WebCore

Fix removeAttributeNode. This is David Faure's patch.

Reviewed by me

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeAttribute):
1:21 PM Changeset in webkit [4679] by hyatt
  • 4 edits in trunk/WebCore

Checking in David Faure's patch that fixes getElementsByTagName(*).

Reviewed by me

  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::getElementsByTagNameNS): (TagNodeListImpl::nodeMatches):
7:31 AM Changeset in webkit [4678] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me.

Fixed build breaker.

Removed glyphCountFromFont function. It was used only in an
ERROR function, which does not compile in on deployment
builds, causing a "defined, but not used warning".

As this function is only a one-liner call into ATS, I
replaced the usage in the ERROR call with a call to the
ATS function directly.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:])

Jul 20, 2003:

6:36 PM Changeset in webkit [4677] by hyatt
  • 10 edits in trunk/WebCore

Enable domain() and setDomain() to work for all documents (XML
as well as HTML).

Implement onload for frames.

Reviewed by mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): (WindowFunc::tryCall):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::parseAttribute):
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::checkEmitLoadEvent):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::domain): (DocumentImpl::setDomain):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent):
5:19 PM Changeset in webkit [4676]
  • 7 copies
    2 deletes in tags/WebKit-85~7

This commit was manufactured by cvs2svn to create tag 'WebKit-85~7'.

5:19 PM Changeset in webkit [4675] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • another attempt to fix compiler error
  • WebKit.pbproj/project.pbxproj: Turn off -Werror.

Jul 18, 2003:

7:06 PM Changeset in webkit [4674] by rjw
  • 3 edits in trunk/WebKit

Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
additional bullet proofing to catch corrupt fonts. Also added a special case
hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
glyphs.

Fixed 3319846. The page mentioned in this bug required > 10 substitute fonts for
the same base font. This triggered some buggy code that hasn't been exercise before.
Specifically the code that resizes the substitute fonts array was incorrect.

Reviewed by mjs.

  • Misc.subproj/WebAssertions.h: Added FATAL_ALWAYS macro that logs and CRASHES even in deployment builds.
  • WebCoreSupport.subproj/WebTextRenderer.m: (mapForSubstituteFont): (widthFromMap): (FillStyleWithAttributes): (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont:]): (pathFromFont): (glyphCountFromFont): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):
5:17 PM Changeset in webkit [4673] by sheridan
  • 1 edit in branches/Safari-1-0-branch/WebKit/WebKit.pbproj/project.pbxproj

85.7 version for webkit

4:29 PM Changeset in webkit [4672] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • attempt to fix compiler error
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Did the type casting another way.
12:22 PM Changeset in webkit [4671] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3334082, XML documents can access HTML/XML docs in other
domains. The basic bug is that we made a change right before
1.0 to allow a parent document to access a child frame's document
if the child frame had no document. What we didn't notice was
that the ptr was obtained from the part by asking for an HTML
document. For XML documents that failed the cast, we got back
null as well, which means that for non-HTML XML documents we
always return true from isSafeScript.

This patch makes sure our addition uses the raw xmlDoc pointer,
so that there are no mistakes, and it restores the code that
denies access when you aren't an HTML document.

(It is a separate bug that we just disallow cross-frame
communication in XML documents right now that I'll file as
a follow-up to this one.)

Reviewed by darin, rjw, mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript):

Jul 17, 2003:

5:48 PM Changeset in webkit [4670]
  • 7 copies
    2 deletes in tags/WebKit-85~6

This commit was manufactured by cvs2svn to create tag 'WebKit-85~6'.

5:48 PM Changeset in webkit [4669] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • rolled over change from main trunk

2003-07-17 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed 3250608 -- REGRESSION (74-85): reproducible Safari crash in blinkCaretTimerAction
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use NSView's setNeedsDisplayInRect: instead of the one in NSTextView. This avoids the layout that the NSTextView version of the call might do. By definition, we don't need layout to draw the insertion point, because we did the layout to find where the insertion point should display. If we do the layout we can end up recursing into the insertion point drawing code, which wreaks major havoc. Still no idea why this happened less in version 74.
4:41 PM Changeset in webkit [4668] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3250608 -- REGRESSION (74-85): reproducible Safari crash in blinkCaretTimerAction
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use NSView's setNeedsDisplayInRect: instead of the one in NSTextView. This avoids the layout that the NSTextView version of the call might do. By definition, we don't need layout to draw the insertion point, because we did the layout to find where the insertion point should display. If we do the layout we can end up recursing into the insertion point drawing code, which wreaks major havoc. Still no idea why this happened less in version 74.
12:49 PM Changeset in webkit [4667] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3300362, crash on myuhc.com. The residual style code
was messing up and inserting nodes in the wrong place (and also
updating the current member variable when it wasn't supposed to).

Fix for 3331793, nil deref because (astoundingly) someone was
using text-shadow and exposed a bug with the color handling
of the shadow.

Reviewed by darin

  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock):
11:55 AM Changeset in webkit [4666] by mjs
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3283076 - crash when doing 2nd query on the eBay channel (Sherlock) -- JavaScript locking issue?

I added a bit of minimal extra locking to WebCore to make sure
multithreaded apps that use WebKit on the main thread but do
JavaScript on other threads as well continue to work nicely.

  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::initScript): Lock interpreter around possible allocations or collections.
  • khtml/ecma/kjs_window.cpp: (Window::clear): Lock interpreter around possible allocations or collections.
11:54 AM Changeset in webkit [4665] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

  • fixed 3330344 - Please change allowable client to "JavaScriptGlue" from "JSGlue"
  • JavaScriptCore.pbproj/project.pbxproj: Changed allowable client to "JavaScriptGlue"
10:49 AM Changeset in webkit [4664] by kocienda
  • 12 edits in trunk

WebCore:

Reviewed by John

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): Now uses NSURL instead of NSString (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto (KWQKHTMLPart::userAgent): Ditto
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::setIconURL): Ditto (KHTMLPartBrowserExtension::setTypedIconURL): Ditto
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): Ditto
  • kwq/KWQLoader.mm: (KWQServeRequest): Ditto (KWQCheckCacheObjectStatus): Ditto
  • kwq/WebCoreBridge.h: Changed quite a number of methods to use NSURL instead of NSString
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge didNotOpenURL:]): Now uses NSURL instead of NSString (-[WebCoreBridge scrollToAnchorWithURL:]): Ditto (-[WebCoreBridge URL]): Ditto

WebKit:

Reviewed by John

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]): Now uses NSURL instead of NSString (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Ditto (-[WebBridge setIconURL:]): Ditto (-[WebBridge setIconURL:withType:]): Ditto (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto (-[WebBridge userAgentForURL:]): Ditto (-[WebBridge requestedURL]): Now returns string using _web_absoluteString
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]): Now uses NSURL instead of NSString
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): Ditto (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): Ditto (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Ditto
8:51 AM Changeset in webkit [4663] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLStringLength]): Fix premature use of new CFURL API. New code is ifdef'ed out for now until everyone has revved.
7:56 AM Changeset in webkit [4662] by kocienda
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin

  • kwq/KWQKHTMLPart.h: _submittedFormURL is now a KURL, not a QString
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Now uses NSURL in API instead of NSString (KWQKHTMLPart::openURLRequest): Ditto (KWQKHTMLPart::didNotOpenURL): Ditto (KWQKHTMLPart::submitForm): Ditto. Plus update _submittedFormURL usages. (KWQKHTMLPart::urlSelected): Ditto (KWQKHTMLPart::setView): Ditto
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Now uses NSURL in API instead of NSString
  • kwq/KWQKURL.h: Added constructor that takes an NSURL
  • kwq/KWQKURL.mm: (KURL::KURL): Ditto.
  • kwq/WebCoreBridge.h: Updated bridge APIs to use NSURL instead of NSString in several places.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Ditto

WebKit:

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Now uses NSURL in API instead of NSString (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): Ditto (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto
  • WebKit.pbproj/project.pbxproj: Added WebNSURLExtras file
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Now uses NSURL in API instead of NSString

Jul 16, 2003:

1:30 PM Changeset in webkit [4661] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • cure problem where we keep competing to check in config.h with/without HAVE_FOUNDATION_SOURCSE
  • Makefile.am: Remove the HAVE_FOUNDATION_SOURCES line.
  • config.h: Check in without that line.
11:46 AM Changeset in webkit [4660] by vicki
  • 3 edits in trunk/WebCore

Reviewed by kocienda.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): set linkStartLocation to zero to fix deployment build
9:54 AM Changeset in webkit [4659] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Richard

  • kwq/KWQKURL.h:
  • kwq/KWQKURL.mm: (StringHasCaseInsensitivePrefix): Helper method for the new functions below (StringByAddingPercentEscapes): Ditto (URLStringByAddingPercentEscapes): Ditto (KURL::getNSURL): Added convenience function to get an NSURL from a KURL (KURL::getNSData): Added convenience function to get an NSData from a KURL

Jul 15, 2003:

3:54 PM Changeset in webkit [4658] by rjw
  • 6 edits in trunk

WebKit:

Fixed 3315952: Add support for <IMG> in attributed string conversion.

Added RTFD pasteboard type.

Reviewed by John.

  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _pasteboardTypes]): (-[WebHTMLView _writeSelectionToPasteboard:]):

WebCore:

Fixed 3315951: Add support for <OL>, <UL> in attributed string conversion.
Fixed 3315952: Add support for <IMG> in attributed string conversion.
Fixed 3315953: Added support for <A> in attributed string conversion.

Reviewed by John (and earlier by Darin).

  • khtml/rendering/render_list.h:
  • kwq/KWQKHTMLPart.mm: (fileWrapperForElement): (listParent): (inList): (KWQKHTMLPart::attributedString):
3:32 PM Changeset in webkit [4657]
  • 1 copy
    319 deletes in branches/unlabeled-1.32.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.32.14'.

3:32 PM Changeset in webkit [4656] by hyatt
  • 18 edits in trunk/WebCore

Fix a problem where ems used for non-font values like width
and line-height would not zoom. (r=darin)

The rest is r=rjw.

An implementation of the CSS2 text-shadow property.

It uses a CoreGraphics API for drawing shadows
(via a custom API on QPainter) to paint the shadows.

At the moment there are two limitations in CG's API. The first
is that the shadow color cannot be set. This will be fixed for
Panther, and the code passes the color through in preparation
for this fix.

The second limitation is that CG only supports one shadow effect
and not multiple shadow effects. The parsing code on the CSS
side is set up to go ahead and parse all of the shadow effects,
but the code that makes use of shadows will simply look at the
first one for now. CG will not support multiple shadow effects
in the Panther time frame, so it will be a while before this
is revisited.

This patch also fixes a slew of bugs with colors in KHTML. When
we took the CSS parser and all of its associated code from Lars,
that code was using QRgb values that assumed RGBA (like the current
Qt toolkit uses). The code even made use of an "invalid color"
that wasn't really invalid (kind of like the z-index hack we refused
to take, i.e., unlikely but not invalid).

Our KWQColor implementation has been rewritten in this patch to
work the way the current Qt toolkit expects. That is, the top
eight bits actually do contain an alpha channel, and you can obtain
the alpha component using the qAlpha method and build a quadruple
using the qRgba method.

This patch adds support for rgba quadruples to CSS, so you can now
say, e.g.,color: rgba(255,0,0,0.5); in CSS.

  • khtml/css/css_valueimpl.cpp: (ShadowValueImpl::~ShadowValueImpl):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): (parseColor): (CSSParser::parseColor): (CSSParser::parseColorFromValue): (CSSParser::parseShadow):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/misc/helper.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::paintDecorations):
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (opacity): (flexibleBox): (StyleCSS3NonInheritedData::operator==): (textShadow): (StyleCSS3InheritedData): (StyleCSS3InheritedData::operator==): (StyleCSS3InheritedData::shadowDataEquivalent): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::operator==): (RenderStyle::inheritedNotEqual): (RenderStyle::diff): (ContentData::clearContent): (RenderStyle::setTextShadow): (ShadowData::operator==):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_text.cpp: (RenderText::paintObject):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::diff):
  • kwq/KWQColor.h:
  • kwq/KWQColor.mm: (qRgb): (qRgba): (qAlpha): (QColor::QColor): (QColor::setNamedColor): (QColor::getNSColor):
  • kwq/KWQNamespace.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawRect): (QPainter::drawLine): (QPainter::_fillRect): (QPainter::fillRect): (QPainter::setShadow): (QPainter::clearShadow):
Note: See TracTimeline for information about the timeline view.