Context Navigation

← Previous Period
Next Period →

Timeline

Sep 14, 2003:

9:58 PM Changeset in webkit [4988]

1 copy
3 deletes in tags/WebKit-104

This commit was manufactured by cvs2svn to create tag 'WebKit-104'.

9:58 PM Changeset in webkit [4987] by vicki

1 edit in trunk/WebKit/ChangeLog

marker for WebKit-104

Sep 13, 2003:

12:44 PM Changeset in webkit [4986] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3420547 -- REGRESSION: repro crash in khtml::RenderBlock::findNextLineBreak (wisdomtips.com)

khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Exclude BR elements when looking for an element to process first-letter style.

8:38 AM Changeset in webkit [4985] by darin

3 edits in trunk

layout-tests/fast/frames/empty-frame-src-expected.txt: Updated test results that changed due to the change in our handling of frame borders.

Sep 12, 2003:

7:11 PM Changeset in webkit [4984] by rjw

11 edits in trunk

WebKit:

Fixed 3420097. If redirects are cancelled during a pending load don't reset the quickRedirect flag.

Reviewed by Darin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectCancelled:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrame _clientRedirectCancelled:]):

WebCore:

Fixed 3420097. Pass flag up to WebKit indicating that redirects are being cancelled during a pending load.

Reviewed by Darin.

khtml/khtml_part.cpp: (KHTMLPart::cancelRedirection):
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::provisionalLoadStarted): (KWQKHTMLPart::redirectionTimerStartedOrStopped):
kwq/WebCoreBridge.h:

5:42 PM Changeset in webkit [4983]

1 copy
3 deletes in tags/WebKit-103

This commit was manufactured by cvs2svn to create tag 'WebKit-103'.

5:42 PM Changeset in webkit [4982]

3 copies
2 deletes in tags/WebCore-103

This commit was manufactured by cvs2svn to create tag 'WebCore-103'.

5:42 PM Changeset in webkit [4981] by vicki

3 edits in trunk

release markers for WebKit-103 and WebCore-103; updated release notes to include -103 fixes

4:41 PM Changeset in webkit [4980] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

khtml/css/html4.css: Use the same hardcoded default size for OBJECT and EMBED tags as for IFRAME.

4:17 PM Changeset in webkit [4979] by rjw

2 edits in trunk/WebKit

Fixed 3412062. Don't allow pages with the same URL as the current URL to enter b/f or history.

Reviewed by Maciej.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):

3:55 PM Changeset in webkit [4978] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed 3413463 - QuickTime plug-in content doesn't load in Safari (NPP_Write not called)

Plugins.subproj/npapi.h: Fix erroneous function pointer declarations that led to an int16/int32 mismatch.

3:53 PM Changeset in webkit [4977] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3403223 -- <input type=file> with initial value causes exception, bad results afterwards, when submitted

kwq/KWQFile.mm: (QFile::QFile): Don't pass an empty string to fileSystemRepresentation, because that will cause an exception.

3:48 PM Changeset in webkit [4976] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePluginView sendEvent:]

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): temporarily retain self in case the plug-in view is released while sending an event. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:targetFrame:]): don't deliver the return value of the JS evaluation if stringByEvaluatingJavaScriptFromString caused the plug-in to stop.

Sep 11, 2003:

8:47 PM Changeset in webkit [4975] by mjs

1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

WebKit is open for business.

8:46 PM Changeset in webkit [4974] by mjs

1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

WebCore is open for business.

8:27 PM Changeset in webkit [4973]

1 copy
3 deletes in tags/WebKit-102

This commit was manufactured by cvs2svn to create tag 'WebKit-102'.

8:27 PM Changeset in webkit [4972] by mjs

1 edit in trunk/WebKit/ChangeLog

Er, I meant WebKit-102. Looks like there was no release marker for 101.

8:23 PM Changeset in webkit [4971] by mjs

2 edits in trunk/WebKit

WebKit-101

8:22 PM Changeset in webkit [4970]

3 copies
2 deletes in tags/WebCore-101

This commit was manufactured by cvs2svn to create tag 'WebCore-101'.

8:22 PM Changeset in webkit [4969] by mjs

3 edits in trunk/WebCore

WebCore-101

5:58 PM Changeset in webkit [4968] by mjs

2 edits in trunk/WebKit

Reviewed by Ken.

fixed 3417486 - after logging off from secure Etrade website, going back returns you to secure page

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): Don't request stale data for https pages, as this could be a security risk.

5:19 PM Changeset in webkit [4967] by rjw

11 edits in trunk

WebKit:

Fixed 3406671. Added a private method for Mail to get selection
rect.

Reviewed by Darin Adler.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateTextBackgroundColor]):
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): (-[WebHTMLView _pluginController]): (-[WebHTMLView _selectionRect]):

WebCore:

Fixed 3406671. Added a private method for Mail to get selection
rect.

Fixed 3417688. Don't allow https page into page cache.

Reviewed by Darin.

kwq/KWQFrame.h:
kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameWidth):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionRect]): (-[WebCoreBridge visibleSelectionRect]): (-[WebCoreBridge selectionImage]): (-[WebCoreBridge adjustViewSize]):

Sep 10, 2003:

5:12 PM Changeset in webkit [4966]

1 copy
3 deletes in tags/WebKit-101

This commit was manufactured by cvs2svn to create tag 'WebKit-101'.

5:12 PM Changeset in webkit [4965] by rjw

2 edits in trunk/WebKit

Fixed 3231031. Use the normal methodology for displaying each frame of a GIF. That is,
just call setNeedsDisplayInRect, rather than drawing directly. Drawing directly violates
layering/clipping.

Reviewed by Dave Hyatt.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]):

Sep 9, 2003:

5:10 PM Changeset in webkit [4964] by vicki

3 edits in trunk

* empty log message *

4:55 PM Changeset in webkit [4963]

3 copies in tags/Safari-100

This commit was manufactured by cvs2svn to create tag 'Safari-100'.

4:55 PM Changeset in webkit [4962]

1 copy
3 deletes in tags/JavaScriptCore-96-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-96-tarball'.

4:55 PM Changeset in webkit [4961]

1 copy
3 deletes in branches/JavaScriptCore-100-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-100-tarball-branch'.

4:55 PM Changeset in webkit [4960] by vicki

8 edits in trunk

* empty log message *

3:42 PM Changeset in webkit [4959] by rjw

9 edits in trunk/WebKit

WebKit:

Fixed 3414988. Don't store absolute path to home directory.
Reviewed by Chris Blumenberg.

Fixed 3414319. Send correct WebView back as parameter to webViewShow:
Review by Darin.

Fixed 3095029. Draw a frame's border in WebFrameView, instead of WebHTMLView, and correctly inset the frame's scrollview to account for the border. Mostly written by Darin.
Reviewed by Darin (and Richard).

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): Store @"~/Library/Icon" instead of absolute path, and always try to tilde expand stored path.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setHasBorder:]):
WebView.subproj/WebFrameView.m: (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
WebView.subproj/WebFrameViewPrivate.h:
WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _isMainFrame]): (-[WebFrameView _tile]): (-[WebFrameView _drawBorder]): (-[WebFrameView _shouldDrawBorder]): (-[WebFrameView _setHasBorder:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Changes to correct draw border in WebFrameView instead of WebHTMLView.

WebView.subproj/WebViewPrivate.m: (-[WebView _openNewWindowWithRequest:]): Send correct parameter (returned from webView:createWebViewWithRequest:), rather than self, to webViewShow:.

WebCore:

Fix for 3095029. Written by Darin.
Reviewed by Richard.

kwq/KWQFrame.h:
kwq/KWQFrame.mm: (QFrame::setFrameStyle): Doesn't need to be virtual. (QFrame::frameWidth): Tweaks.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge adjustViewSize]): Remove frameBorderStyle, no longer needed.

2:28 PM Changeset in webkit [4958] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3412380>: REGRESSION (85-98): www.minoltan.com is decoded incorrectly on Japanese system

The default encoding that Safari uses is latin1 regardless of the current system encoding. This is how it's always been. The problem is that the UI is displaying shift JIS for the default text encoding instead of latin1. This is happening because WebKit is using "latin1" instead of "ISO-8859-1" for the default text encoding name. "ISO-8859-1" is the IANA character set name for latin1 and this is what the WebKitDefaultTextEncodingNamePreferenceKey preference expects. This ends up confusing Safari, so Safari just ends up displaying the first item in the pop-up menu which is shift JIS.

Reviewed by rjw.

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): The WebKitDefaultTextEncodingNamePreferenceKey should be "ISO-8859-1" not "latin1" since "ISO-8859-1" is the IANA character set name for latin1.

1:24 PM Changeset in webkit [4957] by darin

5 edits in trunk/WebCore

Reviewed by Chris.

fixed 3373654 -- REGRESSION: Yahoo chat applet reloads over and over due to "baseURL" param name conflict

After some research by the Java team, we discovered that there was no need to
pass in baseURL at all This patch gets rid of that by only passingindividual specified
arguments, rather than passing all the arguments, as applet parameters.

khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Remove the call to KJavaApplet::processArguments, because we only want the individual arguments.
kwq/KWQKJavaAppletWidget.h: Implement setAppletClass, setAppletName, setArchives, and setCodeBase. Remove processArguments.
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setParameter): Lowercase all the parameters as we put them in the dictionary, since this is the semantics required by Java.

Sep 8, 2003:

4:33 PM Changeset in webkit [4956] by vicki

3 edits in trunk

tree is open for Safari-100!

4:14 PM Changeset in webkit [4955]

3 copies in tags/Safari-99

This commit was manufactured by cvs2svn to create tag 'Safari-99'.

4:14 PM Changeset in webkit [4954] by vicki

8 edits in trunk

Safari-99 stamp

11:45 AM Changeset in webkit [4953] by darin

2 edits in trunk/WebKit

Reviewed by Chris.

fixed 3412726 -- some HTML messages in Mail lose a line at page breaks when printed (multipart/alternative)

WebView.subproj/WebHTMLView.m: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Go into printing mode when asked to adjust page height, if not already in it. We already have code in drawRect that does this when actually printing, but it's also important to lay out the same way when deciding where to break pages, otherwise the difference between printer and screen fonts can lead to page breaks that split a line of text across two pages, and that can lead to missing lines of text as well.

Sep 7, 2003:

4:06 PM Changeset in webkit [4952] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3411827 -- REGRESSION: text drawing after text-shadow does not respect smoothing style (asahi.com)

kwq/KWQPainter.mm: (QPainter::clearShadow): Call CGContextSetShadowWithColor with a color of NULL, which actually clears the shadow, rather than CGContextSetShadow, which sets a black shadow (even if it is zero pixels in size).

3:38 PM Changeset in webkit [4951] by darin

3 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3410939 -- disabling Geneva and Helvetica (by removing them, or by using Font Book) makes Safari crash

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): Fall back on Lucida Grande (plain, not bothering with traits) if Helvetica is not present.

English.lproj/StringsNotToBeLocalized.txt: Update for this and other recent changes.

12:16 PM Changeset in webkit [4950] by darin

2 edits in trunk/WebKit

Reviewed by Ken.

fixed 3406660 -- screen fonts are not being used for substitute fonts (Japanese text, Roman font)

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:families:]): Get a printer or screen font, based on the renderer's mode. The old code didn't do anything explicit. (-[WebTextRenderer _setupFont]): Remove ignored parameter for clarity. (-[WebTextRenderer initWithFont:usingPrinterFont:]): Fixed code paths that would not explicitly get a printer or screen font, and code paths that would get data from the original "before mapping to printer or screen font" NSFont object.

Sep 5, 2003:

4:27 PM Changeset in webkit [4949] by vicki

3 edits in trunk

tree is open for Safari-99!

4:12 PM Changeset in webkit [4948]

3 copies in tags/Safari-98

This commit was manufactured by cvs2svn to create tag 'Safari-98'.

4:12 PM Changeset in webkit [4947] by vicki

8 edits in trunk

Safari-98 stamp

1:00 PM Changeset in webkit [4946] by kocienda

6 edits in trunk

WebCore:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3226083>: REGRESSION (Panther): white box
overlaying select lists at nvidia.com drivers page

kwq/KWQListBox.mm: (QListBox::QListBox): Re-add releaseGState fix that Darin added, but then removed. It turns out that we do need this workaround in place to get proper drawing.

Fix for this bug:

<rdar://problem/3310943>: REGRESSION (Panther): textareas
in forms sometimes draw blank (bugreporter)

kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Same fix as above.

WebKit:

Reviewed by Darin

Incorporate releaseGState fix that Darin developed for
textareas and list boxes in WebCore. It turns out that
we this workaround in WebClipView as well to get proper
drawing of subframes.

In addition, removed some tests that which performed
runtime checks for code in AppKit. AppKit will have
the checked-for code in all versions that will be used
with the version of WebKit.

WebView.subproj/WebClipView.m: (-[WebClipView initWithFrame:]) (-[WebClipView resetAdditionalClip]) (-[WebClipView setAdditionalClip:])

10:46 AM Changeset in webkit [4945] by sullivan

1 edit in trunk/WebKit/ChangeLog

Removed stray conflict marker.

10:23 AM Changeset in webkit [4944] by sullivan

2 edits in trunk/WebKit

fixed 3409011 -- the graphics views palette does not open

Reviewed by Maciej

WebView.subproj/WebPreferences.m: (+[WebPreferences _removeReferenceForIdentifier:]): special-case nil, which is a magic initial identifier already special-cased in the other mutator

1:34 AM Changeset in webkit [4943] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed - REGRESSION (85-92): Javascript on page isn't triggered by typed characters (onKeyUp)

(This actually also requires an AppKit fix to be a full fix.)

kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Added. Send event through DOM. (-[KWQTableView keyUp:]): Likewise. (-[KWQTableView becomeFirstResponder]): Added. Report focus change to DOM.
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]): Added. Send event through DOM.
kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Pass NSKeyUp events too (not going to work until we get an AppKit fix).

1:12 AM Changeset in webkit [4942] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed 3406140 - REGRESSION (7B52-7B55): time spent in NSFont makes Safari 50% slower in Five Apps test

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Make font using the font name we found, not the one we were looking for. Since the compare is case-insensitive, it makes a difference. Also, don't make the font twice.

Sep 4, 2003:

11:07 PM Changeset in webkit [4941] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning correctly

Reviewed by mjs.

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): if the content length is unknown, use 0 instead of -1

6:22 PM Changeset in webkit [4940] by sullivan

3 edits in trunk/WebCore

fixed 3399880 -- Repro crash when filling out a form to download Macromedia software. I managed to check in this ChangeLog comment a few days ago without actually checking in the changed file, weird.

Reviewed by Chris

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): check for nil widget before dereferencing

5:29 PM Changeset in webkit [4939] by hyatt

3 edits in trunk/WebCore

Fix for 3408630, leak of child frame parts caused by a missing deref when frames
get detached from their parent frame list.

Reviewed by mjs

kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):

4:51 PM Changeset in webkit [4938] by darin

3 edits in trunk

layout-tests/apple-only/base/www.msn.com/index-expected.txt: Update for residual style fix.
layout-tests/fast/invalid/003-expected.txt: Update for residual style fix.

4:22 PM Changeset in webkit [4937] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3286922>: Shockwave: Using HTTP to stream .mp3 or .swa files fails at ~50%

Reviewed by mjs.

Plugins.subproj/WebBaseNetscapePluginStream.h: new deliveryData and reason ivars
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): release deliveryData ivar (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): set new reason ivar (-[WebBaseNetscapePluginStream destroyStream]): new, calls NPP_StreamAsFile, NPP_DestroyStream and NPP_URLNotify (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): set the reason, call destroyStream (-[WebBaseNetscapePluginStream receivedError:]): set deliveryData length to 0 so no more data is streamed, call destroyStreamWithReason (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): don't call NPP_StreamAsFile because this has to be called right before NPP_DestroyStream in destroyStream (-[WebBaseNetscapePluginStream deliverData]): new, call NPP_WriteReady and NPP_Write and properly obey their returned values (-[WebBaseNetscapePluginStream receivedData:]): call deliverData
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream stop]): call receivedError here (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): don't call receivedError here because after the load is complete, stream is set to nil and receivedError can be called after the completed load

1:31 PM Changeset in webkit [4936] by darin

36 edits in trunk

kwq/KWQRenderTreeDebug.cpp: (write): Fix clip rectangle computation.
layout-tests: Update test results.

11:29 AM Changeset in webkit [4935] by cblu

2 edits in trunk/WebKit

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): Fixed typo in newly added comment.

11:08 AM Changeset in webkit [4934] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3407328>: request headers at the start of the file passed to NPN_PostURL don't work for Acrobat plug-in?

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): As documented, allow headers to be specified via NPP_PostURL when using a file.

Sep 3, 2003:

5:16 PM Changeset in webkit [4933] by vicki

3 edits in trunk

tree is open for Safari-98

4:56 PM Changeset in webkit [4932]

3 copies in tags/Safari-97

This commit was manufactured by cvs2svn to create tag 'Safari-97'.

4:56 PM Changeset in webkit [4931] by vicki

8 edits in trunk

Safari-97 stamp

2:10 PM Changeset in webkit [4930] by mjs

4 edits in trunk/WebCore

Reviewed by Darin.

khtml/khtml_part.cpp: (KHTMLPart::clear): Un-ifdef cleanup of frames, and add similar cleanup for objects. Replace delete with deref.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): Add an extra ref to KHTMLParts since both the bridge and the parent part want to deref.

2:01 PM Changeset in webkit [4929] by sullivan

2 edits in trunk/WebKit

fixed 3406411 -- infoseek.co.jp: many console errors about attempting to set non-screen font (HiraMinPro-W3)

Reviewed by Ken

WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs): use ERROR instead of NSLog for the printing-font-used-on-screen case, so it doesn't flood the world's console logs. We need to investigate why this is happening also, but that can probably be post-Panther.

1:43 PM Changeset in webkit [4928] by hyatt

3 edits in trunk/WebCore

Fix for 3404398, leak in residual style code. The code that built up the
residualStyleStack was messed up and discarded tags.

Reviewed by mjs

khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):

Sep 2, 2003:

3:54 PM Changeset in webkit [4927] by kocienda

3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3399169>: 4 leaks of DOMString objects (Mail)

Remove circular reference between AttributeImpl and AttrImpl objects.
This was causing the leak.

khtml/xml/dom_elementimpl.cpp: (AttributeImpl::allocateImpl):

3:28 PM Changeset in webkit [4926] by hyatt

3 edits in trunk/WebCore

Fix for 3359408, DirWS should not be used when collapsing/stripping spaces,
since only ASCII spaces are supposed to be collapsed/stripped.

Reviewed by mjs

khtml/rendering/bidi.cpp:

2:59 PM Changeset in webkit [4925] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3403388 -- decoder mishandles pages which fill the decoding buffer (mainly ISO-2022-JP)

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Keep decoding, passing in no additional bytes, until we get noErr, don't ever stop after a kTECOutputBufferFullStatus error.

1:52 PM Changeset in webkit [4924] by hyatt

3 edits in trunk/WebCore

Fix for 3404452, paint errors on mezzoblue.com's links list. There was a simple
math error in the invalidation rect computation.

Reviewed by mjs

khtml/rendering/render_flow.cpp: (RenderFlow::repaint):

Sep 1, 2003:

6:52 PM Changeset in webkit [4923] by sullivan

6 edits in trunk

WebCore:

WebCore part of fix for 3402489 -- REGRESSION (7B48-7B55): Some printed web pages are too small (width is half a page)

This was a regression caused by the fix for 3378810.

Reviewed by Maciej

kwq/WebCoreBridge.h: add adjustingViewSize flag to forceLayout and forceLayoutForPageWidth:
kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayoutAdjustingViewSize:]): respect new flag while we are set up for printing. (-[WebCoreBridge forceLayoutForPageWidth:adjustingViewSize:]): ditto (-[WebCoreBridge adjustFrames:]): pass NO for new flag here

WebKit:

WebKit part of fix for 3402489 -- REGRESSION (7B48-7B55): Some printed web pages are too small (width is half a page)

This was a regression caused by the fix for 3378810.

Reviewed by Maciej

WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:adjustingViewSize:]): now takes adjustViewSize flag, and passes it down to one of bridge's forceLayout calls. (-[WebHTMLView layout]): pass NO for adjustViewSize flag in this case (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): pass adjustViewSize flag down to layoutToPageWidth instead of using it directly here; this is the wrong level to use it directly since the bridge is no longer set up for printing after the layoutToPageWidth call completes.

4:46 PM Changeset in webkit [4922] by mjs

2 edits in trunk/WebKit

Reviewed by John.

fixed 3401709 - [WebView searchFor:] with wrap:NO hangs if the search fails

WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Fix for wrap:NO case as suggested by Darin.

10:59 AM Changeset in webkit [4921] by sullivan

3 edits in trunk/WebCore

kwq/KWQPainter.mm: (QPainter::drawLine): Removed the ERROR that warns of the CG memory trashing bug, now that we are enough builds away from it that it is (almost?) never reported anymore.

Aug 29, 2003:

8:45 PM Changeset in webkit [4920] by vicki

3 edits in trunk

tree is open for Safari-97!

4:54 PM Changeset in webkit [4919]

3 copies in tags/Safari-96

This commit was manufactured by cvs2svn to create tag 'Safari-96'.

4:54 PM Changeset in webkit [4918] by vicki

8 edits in trunk

Safari-96 stamp

3:04 PM Changeset in webkit [4917] by mjs

4 edits in trunk/WebCore

Reviewed by Ken.

fixed 3397775 21 leaks from CSS parser running PLT

khtml/css/css_ruleimpl.cpp: (CSSMediaRuleImpl::~CSSMediaRuleImpl): Clear the parent for all contained rules. (CSSMediaRuleImpl::append): Call insertRule. (CSSMediaRuleImpl::insertRule): set parent of the rule to this media rule. (CSSRuleListImpl::append): Call insertRule to cover all the relevant additional handling, instead of adding straight to the list.
khtml/css/css_ruleimpl.h:

3:02 PM Changeset in webkit [4916] by rjw

3 edits in trunk/WebKit

Fixed 3401334. Use IB document key when checking for reference removal on instances of WebPreferences.

Also removed _userDefaultsKeysForIB, no longer needed by IB.

Reviewed by John.

WebView.subproj/WebPreferences.m: (+[WebPreferences _removeReferenceForIdentifier:]): (-[WebPreferences _postPreferencesChangesNotification]):
WebView.subproj/WebPreferencesPrivate.h:

2:52 PM Changeset in webkit [4915] by rjw

2 edits in trunk/WebKit

Fixed 3400807. Don't release state associated with the current b/f item. We shouldn't normally have page cache state associated with the current item (3401376). This fix guarantees that we won't prematurely release the page cache state for the current item.

Reviewed byJohn Sullivan.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList _clearPageCache]):

1:18 PM Changeset in webkit [4914] by sullivan

2 edits in trunk/WebCore

fixed 3399880 -- Repro crash when filling out a form to download Macromedia software

Reviewed by Chris

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): check for nil widget before dereferencing

Aug 28, 2003:

4:17 PM Changeset in webkit [4913] by rjw

6 edits in trunk/WebKit

Fixed 3399736. Fixed several problems with WebView/WebPreferences
interaction.

Reviewed by Eric Seymour.

Misc.subproj/WebKitLogging.h:
Misc.subproj/WebKitLogging.m: Added debug logging.

WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs): Checkin for 3398229 below.

WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (-[WebPreferences encodeWithCoder:]): (+[WebPreferences standardPreferences]): (+[WebPreferences _getInstanceForIdentifier:]): (+[WebPreferences _setInstance:forIdentifier:]): (+[WebPreferences _concatenateKeyWithIBCreatorID:]):
WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]):

2:24 PM Changeset in webkit [4912] by hyatt

4 edits in trunk/WebCore

Fix for 3381377, fix the calcBlockMinMaxWidth function to not use the
renderobject's computed margins except when it has to. This makes
table cells with align=right not mess up and fixes margin problems
in general with floated elements and table cells.

Since XUL boxes also use a similar function and since it had a similar
error, vertical XUL boxes have been patched as well.

Reviewed by gramps

khtml/rendering/render_block.cpp:
khtml/rendering/render_flexbox.cpp:

1:14 AM Changeset in webkit [4911] by hyatt

3 edits in trunk/WebCore

Fix for 3398463, a regression caused by an unintended line movement.
<br/> was no longer being treated just like <br> in HTML.

Reviewed by gramps

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

Aug 27, 2003:

8:45 PM Changeset in webkit [4910] by rjw

2 edits in trunk/WebKit

Fixed 3398229. When we request a font from NSFont by name we should use a case specific name. We do case insensitve comparsion, but once a match is found we should use the actual font name, not the requested name. Two layout tests are still failing, but I don't think the failures are font related.

Reviewed by Hyatt.

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):

7:50 PM Changeset in webkit [4909] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by John

fixed rdar://problem/3397316 - sherlock crash: KJS::Collector::allocate(unsigned long)

kjs/internal.cpp: (InterpreterImp::InterpreterImp): Hold the lock a bit longer, so the call to initGlobalObject is covered.

6:06 PM Changeset in webkit [4908] by vicki

3 edits in trunk

tree is open for Safari-96!

5:35 PM Changeset in webkit [4907]

3 copies in tags/Safari-95

This commit was manufactured by cvs2svn to create tag 'Safari-95'.

5:35 PM Changeset in webkit [4906] by vicki

8 edits in trunk

top level:

Reviewed by Chris.

acconfig.h: Removed. The new autoconf in Panther doesn't need it.
configure.in: Removed HAVE_S_ISSOCK code; none of our code needs this define and it upsets the new autoconf if we leave out acconfig.h.

Tools:

Scripts/create-tarball: Leave out anything with "apple-only" in the path.
Scripts/run-layout-tests: Print out whether each test succeeded or failed after it runs.

JavaScriptCore:

Reviewed by John.

fixed 3098350 -- opt. params to date methods are ignored (can't set end date in Exchange/Outlook web cal.)

kjs/date_object.cpp: (DateProtoFuncImp::call): Added code to handle the optional parameters. Strangely, the table of functions already had the right number of parameters listed, but the code to look at the parameter values was missing.

Tests:

PDFViewer/ApplicationController.m: Added missing include.
PDFViewer/PDFRepresentation.m: (-[PDFView layout]): Change to use the frame of the WebFrameView instead of the frame of the NSScrollView since there's noAPI to get the scroll view any more.

WebCore:

Fixed 3359408. DON'T treat unicode whitespace as whitespace when collapsing spaces.

Reviewed by David Hyatt.

khtml/rendering/bidi.cpp:
khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):
khtml/xml/dom_stringimpl.cpp:

WebKit:

Fixed 3397235. WebView wasn't archiving useBackForwardList.

Reviewed by Eric Seymour.

WebView.subproj/WebView.m: (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]):

WebBrowser:

Reviewed by John.

fixed 3390306 -- REGRESSION (Panther): Safari browser window titles not available via Accessibility APIs

BrowserWindow.m: (-[BrowserWindow accessibilityTitleAttribute]): Return the title.

WebKitExamples:

CarbonDownloader/English.lproj/main.nib: Changed command key equivalent for Close to Cmd-W. Since this is example code and not localized, the localization freeze should not be an issue.
CarbonDownloader/English.lproj/main~.nib: Removed.

3:57 PM Changeset in webkit [4905] by rjw

5 edits in trunk/WebCore

Fixed 3359408. DON'T treat unicode whitespace as whitespace when collapsing spaces.

Reviewed by David Hyatt.

khtml/rendering/bidi.cpp:
khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):
khtml/xml/dom_stringimpl.cpp:

3:07 PM Changeset in webkit [4904] by rjw

2 edits in trunk/WebKit

Fixed 3397235. WebView wasn't archiving useBackForwardList.

Reviewed by Eric Seymour.

WebView.subproj/WebView.m: (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]):

2:00 PM Changeset in webkit [4903] by hyatt

2 adds in trunk/LayoutTests/fast/forms

Add inline fieldset test.

1:53 PM Changeset in webkit [4902] by hyatt

4 edits in trunk/WebCore

Fix for 3396962, hang on quote.com. Fieldsets with display:inline should be treated
like inline-blocks. This matches WinIE's behavior.

Reviewed by mjs

khtml/rendering/render_form.cpp: (RenderFieldset::setStyle):
khtml/rendering/render_form.h:

11:23 AM Changeset in webkit [4901] by rjw

5 edits in trunk/WebKit

Fixed 3385478. Look for an exact match for font names (using PS names) before matching on family names.

Also added logging to help debug now resolved binding problem.

Reviewed by Maciej.

Misc.subproj/WebKitLogging.h:
Misc.subproj/WebKitLogging.m:
WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):
WebView.subproj/WebView.m: (-[WebView addObserver:forKeyPath:options:context:]): (-[WebView removeObserver:forKeyPath:]):

Aug 26, 2003:

11:41 PM Changeset in webkit [4900] by darin

5 edits in trunk

WebCore:

Reviewed by Maciej.

follow-on to fix for 3310943 -- REGRESSION (Panther): textareas in forms sometimes draw blank (bugreporter)

kwq/KWQListBox.mm: (QListBox::QListBox): Remove call to releaseGState. This was here to work around a problem we thought was an AppKit bug, but it turns out it was caused by NSView hackery in WebKit. We now do the WebKit part in a way that does not create the problem.

WebKit:

Reviewed by Maciej.

fixed 3310943 -- REGRESSION (Panther): textareas in forms sometimes draw blank (bugreporter)

There are two fixes here. The more elegant and slightly faster one that requires a new AppKit,
and the less elegant one that works without AppKit support. By including both we don't have to
worry about timing of submission of WebKit vs. AppKit but we get the good, elegant fix. Later,
we can delete the less elegant fix.

WebView.subproj/WebClipView.m: (+[WebClipView initialize]): Set up a boolean global so we only hav to do the "does AppKit support _focusRingVisibleRect" check one time. (-[WebClipView resetAdditionalClip]): Only do the renewGState thing if we don't have the _focusRingVisibleRect method, but if we do the renewGState thing, do it to self and all descendants using _web_renewGStateDeep. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView visibleRect]): Only limit this based on the additional clip if we don't have the _focusRingVisibleRect method. (-[WebClipView _focusRingVisibleRect]): Override the new method. Harmless if it's an old AppKit that doesn't have the method yet. (-[NSView _web_renewGStateDeep]): Implemented this helper method. We can get rid of it once we are entirely on the new AppKit.

10:47 PM Changeset in webkit [4899] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3031562 -- most forms don't work in certain configurations because of a bug in KWQVariant

kwq/KWQVariant.mm: (QVariant::QVariant): Set the b element of the union, not the d element, in the constructor for bool.

6:23 PM Changeset in webkit [4898] by hyatt

2 adds in trunk/LayoutTests/fast/block/float

Add a test for floats/clearing/margin-collapsing under the new system

6:15 PM Changeset in webkit [4897] by hyatt

6 deletes in trunk/LayoutTests/fast/block/margin-collapse

Remove margin collapsing tests that are now buggy/invalid

6:09 PM Changeset in webkit [4896] by hyatt

4 edits in trunk/WebCore

Fix for 3395950, better support for self-collapsing blocks. Make them obey
clear properly and also change the definition of self-collapsing to match
the CSS2.1 specification.

Reviewed by gramps

khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:

5:47 PM Changeset in webkit [4895] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

Add a layout test for <script/>

5:46 PM Changeset in webkit [4894] by hyatt

3 edits in trunk/WebCore

Fix for 3335175, www.calstone.com renders as blank. The fix is to deliberately
introduce an error into our HTML parsing code that causes us to honor self-closing
XML-style <script/> tags. This matches Mozilla and Opera behavior (both of them
have this bug), but it does not match WinIE.

Reviewed by mjs

khtml/html/htmltokenizer.cpp:

4:57 PM Changeset in webkit [4893] by hyatt

2 adds in trunk/LayoutTests/fast/block/basic

Add a display:none test.

4:44 PM Changeset in webkit [4892] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

Commit an h2/form test case.

4:43 PM Changeset in webkit [4891] by hyatt

3 edits in trunk/WebCore

Fix for 3286229, popup menu misplaced. <form> needs to be allowed as a child of
<h1>-<h6> tags. All other browsers allow this.

Reviewed by darin

khtml/html/dtd.cpp:

4:13 PM Changeset in webkit [4890] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

re-fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Added missing # sign.

4:09 PM Changeset in webkit [4889] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3321247 -- window size box disappears from Help window (caused by WebKit NSView hackery)

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]), (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Don't propagate dirty rects at all. This was causing problems because now the AppKit uses dirty regions, not dirty rects. In AppKit-722 and newer, _setDrawsDescendants: takes care of this for us so we don't have to do anything at all.

3:19 PM Changeset in webkit [4888] by hyatt

3 edits in trunk/WebCore

Fix for 3394107, make sure the display mutation code doesn't mutate objects with
display: none set.

Reviewed by darin

khtml/css/cssstyleselector.cpp:

11:57 AM Changeset in webkit [4887] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed 3392650 -- REGRESSION?: assertion fails trying Apple-hosted page load test while not on Apple network

WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Stop loading the provisional data source before blowing it away, in case there are some callbacks that haven't occurred yet. It's a waste of time to try to handle those additional callbacks, and can lead to failed assertions since the data source won't be hooked up to any frame any more.

Aug 25, 2003:

4:26 PM Changeset in webkit [4886] by rjw

2 edits in trunk/WebKit

Fix for 3391609. Our rounding hack wasn't correctly reflected in the selection point
code. Piggy-backed on this fix are fixes for selection of letter-spacing, word-spacing
and justified text.

Reviewed by Hyatt.

WebCoreSupport.subproj/WebTextRenderer.m: (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (widthForNextCharacter): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):

4:08 PM Changeset in webkit [4885] by sullivan

2 edits in trunk/WebKit

fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not updating immediately after page load

The buttons are updated in response to window update notifications.
Jaguar was sending so many extra bogus notifications that it
masked the fact that we weren't ensuring that these notifications
were sent at all in the case of non-event-based interesting
changes that might affect menu items/toolbar items/etc.

Reviewed by Richard

WebView.subproj/WebViewPrivate.m: (-[WebView _didStartProvisionalLoadForFrame:]): call -[NSApp setWindowsNeedUpdate:YES] so window update notices will be sent (-[WebView _didCommitLoadForFrame:]): ditto (-[WebView _didFinishLoadForFrame:]): ditto (-[WebView _didFailLoadWithError:forFrame:]): ditto (-[WebView _didFailProvisionalLoadWithError:forFrame:]): ditto

Aug 24, 2003:

6:57 PM Changeset in webkit [4884] by darin

3 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3098350 -- opt. params to date methods are ignored (can't set end date in Exchange/Outlook web cal.)

kjs/date_object.cpp: (DateProtoFuncImp::call): Added code to handle the optional parameters. Strangely, the table of functions already had the right number of parameters listed, but the code to look at the parameter values was missing.

6:44 PM Changeset in webkit [4883] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed 3382179 -- REGRESSION: many images scroll down while loading (e.g., homepage.mac.com slide show)

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): While loading, always draw one less line than the number NSImage says we have, since that last line is a partial line and draws unwanted white. This is not what the bug report complains about, but is a longstanding and very minor issue. Remove the code that adjust the Y origin. This is what the bug report is about. That adjustment is incorrect and was unknowingly compensating for some kind of NSImage bug that is now fixed. (-[WebImageRenderer tileInRect:fromPoint:]): Added an assertion that the WebImageRenderer is flipped. The code does assume that it's flipped.

Aug 22, 2003:

9:09 PM Changeset in webkit [4882] by sullivan

4 edits in trunk/WebKit

fixed 3385837 -- REGRESSION: can't paste link from Safari into Keynote (paste at top level, not into text)

Reviewed by Darin

The problem was that we were using a single list of pasteboard
types for both "types we can read" and "types we can write", but
NSFilenamesPBoardType wasn't being written to, creating a bad
pasteboard. The fix is to split this list in two. We could do
this a little more elegantly if we weren't paranoid about
last-minute SPI changes breaking compatibility with Sherlock or
some other internal client.

Misc.subproj/WebNSPasteboardExtras.h: add new _web_writableDragTypesForURL, commented various methods better.

Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_writableDragTypesForURL]): implement _web_writableDragTypesForURL; it's just like _web_dragTypesForURL but without the NSFilenamesPBoardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use _web_writableDragTypesForURL

Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:title:event:]): use _web_writableDragTypesForURL

3:02 PM Changeset in webkit [4881] by hyatt

3 edits in trunk/WebCore

Fix for 3388363, copying a word in a list item copied too much. The code that checked
for the bullet would add in too much text sometimes.

Reviewed by john

kwq/KWQKHTMLPart.mm: (isTextFirstInListItem): (KWQKHTMLPart::attributedString):

12:28 PM Changeset in webkit [4880] by darin

2 edits in trunk/WebKit

Reviewed by Dave.

fixed 3386051 -- REGRESSION: text "too dark" after the page is deactivated and reactivated (bugweb)

Cached clips were causing us to draw nothing for the top frames of framesets, resulting in darkened
text because we draw anti-aliased text twice without drawing a background.

WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Invalidate cached graphics state when changing the visible rect. (-[WebClipView setAdditionalClip:]): Ditto.

10:33 AM Changeset in webkit [4879] by sheridan

3 edits in trunk

95u version number

Aug 21, 2003:

9:22 PM Changeset in webkit [4878] by darin

4 edits in trunk/WebCore

Makefile.am: Work around DLCFN issue to prevent constant churn of config.h.
config.h: Regenerated without DLCFN.

9:21 PM Changeset in webkit [4877] by darin

2 edits in trunk/WebKit

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): Tweak to printing fix: Be sure to call adjustViewSize after applying styles and doing layout.

9:18 PM Changeset in webkit [4876] by darin

3 edits in trunk/WebCore

khtml/khtmlview.h: Formatting tweak.

6:31 PM Changeset in webkit [4875] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3386673>: a particular fidelity.com "Log in" link does nothing because of cross-domain JavaScript rules

Reviewed by mjs.

config.h:
khtml/ecma/kjs_window.cpp: (Window::get): allow other frames to get the location object (Window::isSafeScript): added JS logging (Location::get): don't allow other frames to access location attributes (LocationFunc::tryCall): don't allow other frames to call functions on the location object

5:45 PM Changeset in webkit [4874] by rjw

10 edits in trunk

WebKit:

Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.

Reviewed by Hyatt.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): (-[WebHTMLView drawRect:]): (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView endDocument]):

WebCore:

Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.

Reviewed by Hyatt.

khtml/khtmlview.cpp: (KHTMLView::adjustViewSize):
khtml/khtmlview.h:
khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
kwq/KWQScrollView.mm: (QScrollView::resizeContents):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge adjustViewSize]):

4:57 PM Changeset in webkit [4873]

3 copies in tags/Safari-94

This commit was manufactured by cvs2svn to create tag 'Safari-94'.

4:57 PM Changeset in webkit [4872] by sheridan

8 edits in trunk

Safari-94

2:05 PM Changeset in webkit [4871] by sullivan

2 edits in trunk/WebKit

fixed 3387950 -- REGRESSION (85-89): Standalone image in Safari prints much smaller than in Jaguar

Reviewed by Chris.

WebView.subproj/WebImageView.m: (-[WebImageView adjustFrameSize]): renamed from setFrameSizeUsingImage; now sets the frame size to exactly the image size (as it did in Jaguar always) when we're not drawing to the screen. (-[WebImageView setFrameSize:]): updated for name change (-[WebImageView layout]): ditto (-[WebImageView beginDocument]): adjust frame size (before printing) (-[WebImageView endDocument]): adjust frame size (after printing)

12:14 PM Changeset in webkit [4870] by hyatt

2 adds in trunk/LayoutTests/fast/block/float

Add a test for relpositioned floats.

11:52 AM Changeset in webkit [4869] by hyatt

3 edits in trunk/WebCore

Fix for 3387302, floats weren't being allowed to be relatively positioned. The
fix is trivial. Stop making floating/relpositiion setting an if/else and just make
it two ifs.

Reviewed by darin

khtml/rendering/render_box.cpp: (RenderBox::setStyle):

2:27 AM Changeset in webkit [4868] by hyatt

2 adds in trunk/LayoutTests/fast/inline-block

The most evil test I've ever come up with.

2:21 AM Changeset in webkit [4867] by hyatt

2 adds in trunk/LayoutTests/fast/text/basic

Add test case for the unicode bullet bug.

2:17 AM Changeset in webkit [4866] by hyatt

3 edits in trunk/WebCore

Fix for 3384635, breakable unicode characters that were preceded by multiple spaces
accidentally added in those spaces to their widths.

Reviewed by rjw and gramps

khtml/rendering/bidi.cpp:

Aug 20, 2003:

7:19 PM Changeset in webkit [4865] by hyatt

2 edits in trunk/LayoutTests/fast/block/float

Fix this float test.

6:02 PM Changeset in webkit [4864] by hyatt

2 adds in trunk/LayoutTests/fast/overflow

Adding overflow test with percentage widths.

6:00 PM Changeset in webkit [4863] by hyatt

1 edit in trunk/LayoutTests/fast/block/float/003-expected.txt

Repair float test case.

5:52 PM Changeset in webkit [4862] by hyatt

4 edits in trunk/WebCore

Fix for 3384609. Objects that want to dodge floats should fill the line width instead
of the containing block width only if their widths are auto. If widths are specified
explicitly, then ccontaining block width should be honored.

Reviewed by john

khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
khtml/rendering/render_table.cpp: (RenderTable::calcWidth):

5:17 PM Changeset in webkit [4861] by rjw

3 edits in trunk/WebCore

UCFindTextBreak will report false if we have a sequence of 0xa0 0x20 (nbsp, sp), so we explicity check for that case. Filed 3386852 to track this problem, meanwhile added a work-around. This problem was revealed after adding the fix for 3242508.

Reviewed by Dave.

khtml/rendering/break_lines.cpp:

4:02 PM Changeset in webkit [4860] by hyatt

1 edit in trunk/LayoutTests/fast/frames/empty-frame-src-expected.txt

Updating layout tests.

3:48 PM Changeset in webkit [4859] by hyatt

1 edit
2 adds in trunk/LayoutTests/fast/table

Correcting the glitch caused by textareas changing size and add a layout test for the amazon.com colspan table issue.

3:46 PM Changeset in webkit [4858] by hyatt

2 adds in trunk/LayoutTests/fast/block/positioning

Adding a positioning test that makes sure spaces are properly stripped when computing maxwidths.

3:44 PM Changeset in webkit [4857] by hyatt

2 adds in trunk/LayoutTests/fast/block/float

Adding a float test that mixes positioning, inline blocks, and text-indent. The horror, the horror.

3:37 PM Changeset in webkit [4856] by hyatt

2 adds in trunk/LayoutTests/fast/block/float

Adding a float test for overflowing and line breaking.

3:34 PM Changeset in webkit [4855] by hyatt

2 adds in trunk/LayoutTests/fast/block/positioning

Adding a test of line breaking inside positioned elements.

3:31 PM Changeset in webkit [4854] by darin

5 edits in trunk/WebCore

Reviewed by John.

fixed 3248069 -- Safari does not support ISO Latin 10 (ISO-8859-16, romanian) coding.

kwq/mac-encodings.txt: Added ISO-8859-16, which maps to ISO Latin-10.
kwq/KWQCharsetData.c: Regenerated.
kwq/KWQCharsets.mm: Add definition of kCFStringEncodingISOLatin10, since this encoding is currently only in TextCommon.h, not in CFStringEncodingExt.h.

3:20 PM Changeset in webkit [4853] by hyatt

1 edit
2 adds in trunk/LayoutTests/fast/frames

Adding an object/iframe test for padding/borders.

3:15 PM Changeset in webkit [4852] by hyatt

2 adds in trunk/LayoutTests/fast/css-generated-content

Add a <q>/<p> test for split anonymous content.

3:05 PM Changeset in webkit [4851] by mjs

3 edits in trunk/WebCore

Reviewed by Richard.

fixed 3384963 - REGRESSION: assertion in copyPathRemovingDots, crash parsing URL in snippet editor

kwq/KWQKURL.mm: (copyPathRemovingDots): It's OK if the path is entirely empty.

3:03 PM Changeset in webkit [4850] by hyatt

6 edits in trunk/WebCore

Fix for 3385211, <td>s should ignore the float property in quirks mode. This
patch cleans up the adjustments of <td>s and <table>s and moves the code into
the style selector (instead of cluttering up the rendering code).

Fix for 3385476, generated content not built correctly. All generated content
should be placed inside a containing object that actually gets the pseudo-style.

Reviewed by rjw

ChangeLog:
khtml/css/cssstyleselector.cpp:
khtml/css/cssstyleselector.h:
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
khtml/rendering/render_object.cpp: (RenderObject::createObject):

1:48 PM Changeset in webkit [4849] by mjs

3 edits in trunk/WebCore

Reviewed by Richard.

fixed 3292036 - albertsons.com world leak of 2 WebDataSource and 2 WebHTMLRepresentation objects

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Test for parentPart() even if there is no document.

11:24 AM Changeset in webkit [4848] by rjw

5 edits in trunk/WebCore

Fixed 3242508. Japanese (and other non latin1 scripts) line breaking incorrect when mixed with latin1.

Reviewed by Dave.

khtml/rendering/break_lines.cpp:

Checkin fix for earlier bug that was already approved!

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):

Aug 19, 2003:

6:18 PM Changeset in webkit [4847] by rjw

3 edits in trunk/WebKit

Fixed 3383623 (and 3384896). Remove our unbeknownst work-around for an NSImage bug that incorrectly flipped y coordinate when drawing a partial rect within the image. This has been fixed in Panther, making our work-around no longer necessary.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]):
WebKit.pbproj/project.pbxproj:

5:26 PM Changeset in webkit [4846] by hyatt

4 edits in trunk/WebCore

Fixes for 3380766 and 3381867. One is a table bug with amazon.com where colspans
were losing percentage width values. The other is a bug where floats aren't dirtying
objects into which they intrude when doing layout.

Reviewed by darin

khtml/rendering/render_block.cpp:
khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth):

2:49 PM Changeset in webkit [4845] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3379336>: flash on front page of http://www.westportmotorsports.com is broken

Reviewed by darin.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Ignore the PARAM tags and only use attributes inside the OBJECT tag when the EMBED tag is omitted.

1:58 PM Changeset in webkit [4844] by darin

6 edits in trunk/WebCore

Reviewed by Dave.

fixed 3343681 -- clicking on a disabled submit button submits the form!

This turned out to be a problem with code in dispatchGenericEvent that sent
DOMActivate events even when the form element was disabled.

khtml/xml/dom_nodeimpl.h: Add virtual disabled() member function.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Don't send DOM activate events for disabled elements. (NodeImpl::handleLocalEvents): Don't send mouse events for disabled elements. But we do want those events to pass through the bubble and capture phases, just avoid triggering any listeners on this node itself. (NodeImpl::disabled): Added default implementation that returns false.

khtml/html/html_formimpl.h: Removed the disabled() function's inline implementation since it's now virtual and it's not helpful to inline virtual functions.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::disabled): Moved this method into the .cpp file since it's now virtual and it's not helpful to inline virtual functions.

1:07 PM Changeset in webkit [4843] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3380411 -- Unicode supplementary characters cut in half in text control with maxlength set

kwq/KWQTextField.mm: (-[KWQTextField setMaximumLength:]): Enforce maximum length based on number of composed character sequences rather than on number of UTF-16 values. This helps with both surrogate pairs (the supplementary characters mentioned in the bug report) and composed character sequences. (-[KWQTextField setStringValue:]): Ditto. (-[KWQTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]): Ditto. (-[NSString _KWQ_numComposedCharacterSequences]): Added. Computes the length of a string in terms of number of composed character sequences. (-[NSString _KWQ_truncateToNumComposedCharacterSequences:]): Added. Truncates a string in terms of number of composed character sequences.

11:08 AM Changeset in webkit [4842] by sheridan

3 edits in trunk

94u version numbers

Aug 18, 2003:

5:09 PM Changeset in webkit [4841] by rjw

4 edits in trunk/WebKit

Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
problem with bidi neutrals at directional boundaries 3382926.

Reviewed by Maciej.

Misc.subproj/WebUnicode.h:
Misc.subproj/WebUnicode.m: (shapedString):
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):

2:12 PM Changeset in webkit [4840] by darin

17 edits in trunk

WebCore:

Reviewed by Maciej.

fixed 3299893 -- oncontextmenu support

kwq/WebCoreBridge.h: Added sendContextMenuEvent: method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge sendContextMenuEvent:]): Added. Calls sendContextMenuEvent on the part.

kwq/KWQKHTMLPart.h: Added sendContextMenuEvent member function.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): Added. Sets up a suitable mouse event and calls dispatchMouseEvent for CONTEXTMENU_EVENT.

khtml/ecma/kjs_dom.cpp: Added oncontextmenu to DOMNode's list of properties. (DOMNode::getValueProperty): Added case for OnContextMenu. (DOMNode::putValue): Added case for OnContextMenu.
khtml/ecma/kjs_dom.h: Added constant for OnContextMenu.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Added case for ATTR_ONCONTEXTMENU.
khtml/misc/htmlattrs.in: Added oncontextmenu.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added case for CONTEXTMENU_EVENT. (EventImpl::idToType): Added case for CONTEXTMENU_EVENT.
khtml/xml/dom2_eventsimpl.h: Added CONTEXTMENU_EVENT.

khtml/ecma/kjs_dom.lut.h: Regenerated.
khtml/misc/htmlattrs.c: Regenerated.
khtml/misc/htmlattrs.h: Regenerated.

WebKit:

Reviewed by Maciej.

fixed 3299893 -- oncontextmenu support

WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Call sendContextMenuEvent: on the bridge, and don't show a menu if the event is handled over in WebCore. (-[WebHTMLView mouseDown:]): Don't send a mouse down event in the case where we already sent a context menu event and decided not to put up a real context menu.

2:03 PM Changeset in webkit [4839] by rjw

2 edits in trunk/WebKit

Fix build problem from last checkin.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):

12:23 PM Changeset in webkit [4838] by darin

3 edits
4 adds in trunk

Reviewed by Maciej.

fixed 3381295 -- regular expression matches for text with UTF-16 surrogates will give incorrect results

kwq/KWQRegExp.mm: (QRegExp::match): Removed local copy of convertCharacterOffsetsToUTF8ByteOffsets and its reverse. Instead use convertUTF16OffsetsToUTF8Offsets and its reverse, now available from <JavaScriptCore/ustring.h>.

added test for the URI encoding and decoding functions in JavaScriptCore

layout-tests/fast/js/global/encode-URI-test-expected.txt: Added.
layout-tests/fast/js/global/encode-URI-test.html: Added.

11:51 AM Changeset in webkit [4837] by darin

8 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed 3247528 -- encodeURI missing from JavaScriptCore (needed by Crystal Reports)
fixed 3381297 -- escape method does not escape the null character
fixed 3381299 -- escape method produces incorrect escape sequences ala WinIE, rather than correct ala Gecko
fixed 3381303 -- unescape method treats escape sequences as Latin-1 ala WinIE rather than as UTF-8 ala Gecko
fixed 3381304 -- unescape method garbles strings with bad escape sequences in them

kjs/function.h: Added constants for decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent.
kjs/function.cpp: (encode): Added. New helper function for escape, encodeURI, and encodeURIComponent. (decode): Added. New helper function for unescape, decodeURI, and decodeURIComponent. (GlobalFuncImp::call): Added decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent implementations. Changed escape and unescape to use new helper functions, which fixes the four problems above.

kjs/internal.cpp: (InterpreterImp::initGlobalObject): Add decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent to the global object.

kjs/ustring.h: Added a length to the CString class so it can hold strings with null characters in them, not just null-terminated strings. This allows a null character from a UString to survive the process of UTF-16 to UTF-8 decoding. Added overloads to UString::append, UString::UTF8String, UTF8SequenceLength, decodeUTF8Sequence, convertUTF16OffsetsToUTF8Offsets, and convertUTF8OffsetsToUTF16Offsets.

kjs/ustring.cpp: (CString::CString): Set up the length properly in all the constructors. Also add a new constructor that takes a length. (CString::append): Use and set the length properly. (CString::operator=): Use and set the length properly. (operator==): Use and the length and memcmp instead of strcmp. (UString::append): Added new overloads for const char * and for a single string to make it more efficient to build up a UString from pieces. The old way, a UString was created and destroyed each time you appended. (UTF8SequenceLength): New. Helper for decoding UTF-8. (decodeUTF8Sequence): New. Helper for decoding UTF-8. (UString::UTF8String): New. Decodes from UTF-16 to UTF-8. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (compareStringOffsets): Moved from regexp.cpp. (createSortedOffsetsArray): Moved from regexp.cpp. (convertUTF16OffsetsToUTF8Offsets): New. Converts UTF-16 offsets to UTF-8 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (convertUTF8OffsetsToUTF16Offsets): New. Converts UTF-8 offsets to UTF-16 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates.

fixed 3381296 -- regular expression matches with UTF-16 surrogates will treat sequences as two characters

kjs/regexp.cpp: (RegExp::RegExp): Use the new UString::UTF8String function instead a function in this file. (RegExp::match): Use the new convertUTF16OffsetsToUTF8Offsets (and the corresponding reverse) instead of convertCharacterOffsetsToUTF8ByteOffsets in this file.

9:10 AM Changeset in webkit [4836] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3380418>: Ignore specified string encoding when constructing file, mailto and help URLs

Reviewed by mjs, darin.

kwq/KWQKURL.mm: (KURL::KURL): store the URL string as UTF-8 when the URL is file, mailto and help.

7:50 AM Changeset in webkit [4835] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Do the &-encoding thing on the filename. This is what Gecko does.

Aug 17, 2003:

11:02 PM Changeset in webkit [4834] by darin

4 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3376522 -- REGRESSION: uncaught exception from bad .ico causes crash (login window at 34sp.com)

I added exception handling in all the places we load images with NSImage.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): Add exception handler.
Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Add exception handler.
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): Add exception handler. (-[WebImageRenderer initWithContentsOfFile:]): Add exception handler. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Add exception handler.

Aug 15, 2003:

5:10 PM Changeset in webkit [4833] by mjs

3 edits in trunk/WebCore

Fixed by Darin, reviewed by me (and originally figured out by John).

fixed 3375592 - New Yahoo Maps doesn't work right

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.

5:04 PM Changeset in webkit [4832] by rjw