Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 15, 2003:

9:18 AM Changeset in webkit [5186] by darin

• 10 edits in trunk/WebCore

Reviewed by Ken.

• change "volatile X * volatile" to "X * volatile" in cases where the pointer needs to be volatile but the object pointed to do does not

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
• kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
• kwq/KWQLineEdit.mm: (QLineEdit::text):
• kwq/KWQScrollView.mm: (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::getDocumentView):
• kwq/KWQTextEdit.mm: (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
• kwq/KWQWidget.mm: (QWidget::getOuterView): Removed the excess volatiles and excess casts that go with them.

• kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also remove an unnecessary nil check that is the same as QString::fromNSString's default behavior.

12:05 AM Changeset in webkit [5185] by mjs

• 7 edits in trunk/WebCore

Reviewed by Dave.

More objc-exception-blocking excitement.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): (RefreshPlugins):
• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
• kwq/KWQRegion.mm: (QRegion::QRegion):

Oct 14, 2003:

6:32 PM Changeset in webkit [5184] by rjw

• 5 edits in trunk/WebKit

WebBrowser:

Use WebKit estimated progress scheme. I've left the old
scheme in place. You can get the old behavior by turning off the
"Use Alternate Progress" item in the debug menu. The new code is
much simpler than the old code. Once we decide to move ahead with the
new scheme we can do a serious root canal.

Reviewed by Chris.

• BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView dealloc]): (-[BrowserWebView isLoading]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController updateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController clearProgressBar]):
• Debug/DebugUtilities.h:
• Debug/DebugUtilities.m: (-[DebugUtilities init]): (-[DebugUtilities useAlternateProgress]): (-[DebugUtilities setUseAlternateProgress:]): (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleAlternateProgress:]):
• TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKit:

Added logging for estimated progress.

Added a time delta to the throttler, so we now send notifications
if a delta amount has been exceeded OR a delta between notifications
has been exceeded.

Reviewed by Chris.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• WebView.subproj/WebView.m: (-[WebViewPrivate init]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]):
• WebView.subproj/WebViewPrivate.h:

12:47 PM Changeset in webkit [5183] by hyatt

• 3 edits in trunk/WebCore

Fix an obvious little typo with smallCaps inheritance. Richard reviewed.

Also merge in Dirk's patch to fix a crasher caused by an obvious deref mistake.

Reviewed by rjw and nobody

• khtml/css/cssstyleselector.cpp: (khtml::convertToLength): (khtml::CSSStyleSelector::applyRule):

9:01 AM Changeset in webkit [5182] by kocienda

• 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3450449>: assertion failure in WebBridge
_retrieveKeyboardUIModeFromPreferences

Can't assert that the preference always exists and is valid as I
thought you could. This could just mean that the a preference for full
keyboard access has not been specified by the user yet. If this is so,
just return the default keyboard access mode.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:])

8:36 AM Changeset in webkit [5181]

• 1 copy
  74 deletes in branches/unlabeled-1.8.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.8.4'.

8:36 AM Changeset in webkit [5180]

• 1 copy
  41 deletes in branches/unlabeled-1.27.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.27.4'.

8:36 AM Changeset in webkit [5179] by kocienda

• 20 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/dom/dom_misc.h: Declared TristateFlag enum used to implement inheritance behavior for inheritable attributes like designMode.
• khtml/dom/html_document.cpp: (HTMLDocument::designMode): Added getter. (HTMLDocument::setDesignMode): Added setter.
• khtml/dom/html_document.h: Added declarations for designMode getter and setter.
• khtml/dom/html_element.cpp: (HTMLElement::isContentEditable): Added convenience. (HTMLElement::contentEditable): Added getter. (HTMLElement::setContentEditable): Added setter.
• khtml/dom/html_element.h: Added declarations for contentEditable accessors.
• khtml/ecma/kjs_html.cpp: Added js support for contentEditable and designMode. (KJS::HTMLDocument::tryGet) (KJS::HTMLDocument::putValue) (KJS::HTMLElement::getValueProperty) (KJS::HTMLElement::putValue)
• khtml/ecma/kjs_html.h: (KJS::HTMLDocument::): Added DesignMode to attribuute enum. (KJS::HTMLElement::): Added ContentEditable to attribute enum.
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::designMode): Added getter. (HTMLDocumentImpl::setDesignMode): Added setter.
• khtml/html/html_documentimpl.h: Declared designMode accessors.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::parseAttribute): Added support for contentEditable. (HTMLElementImpl::isContentEditable): Added. Implements inheritance feature for this attribute. (HTMLElementImpl::contentEditable): Getter for contentEditable attribute. (HTMLElementImpl::setContentEditable): Setter for contentEditable attribute.
• khtml/html/html_elementimpl.h:
• khtml/khtml_part.cpp: (KHTMLPart::setEditMode): Added. (KHTMLPart::editMode): Added. Implements inheritance behavior for attribute. (KHTMLPart::inEditMode): Helper that calls on editMode function. (KHTMLPart::parentPart): Made const.
• khtml/khtml_part.h: Rolled in a couple of typo fixes. Added declarations for the changes made in the implementation file.
• khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Declared editMode flag. Also added support for editMode flag in initializers and copy function.
• khtml/misc/htmlattrs.in: Added contentEditable as an attribute name.

Oct 13, 2003:

6:56 PM Changeset in webkit [5178] by hyatt

• 3 edits in trunk/WebCore

Fix for a small-caps rendering error when used in conjunction with ::first-line. Always update
the Font variable even when QFonts are the same, since small-caps is not stored in QFonts.

Reviewed by rjw

• khtml/rendering/render_text.cpp: (RenderText::paintObject):

5:52 PM Changeset in webkit [5177] by rjw

• 6 edits in trunk

Updated layout tests actuals to reflect implementation of small-caps style.

• layout-tests/css1/font_properties/font-expected.txt:
• layout-tests/css1/font_properties/font_variant-expected.txt:
• layout-tests/css1/pseudo/firstline-expected.txt:
• layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:

5:44 PM Changeset in webkit [5176] by rjw

• 4 edits in trunk/WebCore

Added support for small-caps.

Reviewed by John.

• khtml/rendering/font.h: (khtml::Font::isSmallCaps):
• khtml/rendering/render_text.cpp: (RenderText::shouldUseMonospaceCache):

5:39 PM Changeset in webkit [5175] by rjw

• 4 edits in trunk/WebKit

Added support for small-caps.

Reworked drawing and measuring to use new iterators. Position checking was already using
the new iterator code, but I was reluctant to switch the mainline drawing and measuring
code over to the new approach until now.

Lots of other code cleanup.

Reviewed by John.

• Misc.subproj/WebUnicode.m: (initializeCharacterShapeIterator):
• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer widthForString:]): (-[WebTextRenderer ascent]): (-[WebTextRenderer descent]): (-[WebTextRenderer lineSpacing]): (-[WebTextRenderer xHeight]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForRun:style:widths:]): (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): (-[WebTextRenderer drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer pointToOffset:style:position:reversed:]): (-[WebTextRenderer _setIsSmallCapsRenderer:]): (-[WebTextRenderer _isSmallCapsRenderer]): (-[WebTextRenderer _smallCapsRenderer]): (-[WebTextRenderer _smallCapsFont]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _substituteFontForCharacters:length:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _updateGlyphEntryForCharacter:glyphID:font:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): (freeWidthMap): (freeGlyphMap): (glyphForCharacter): (glyphForUnicodeCharacter): (mapForSubstituteFont): (widthFromMap): (widthForGlyph): (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (ceilCurrentWidth): (widthForNextCharacter): (fillStyleWithAttributes): (findLengthOfCharacterCluster): (shouldUseATSU): (isControlCharacter): (isAlternateSpace): (isSpace): (fontContainsString): (GetScratchUniCharString): (toUpper): (isUpper):

Oct 12, 2003:

8:32 PM Changeset in webkit [5174] by darin

• 4 edits in trunk

• layout-tests/fast/js/date-parse-test.html: Fixed a couple of silly mistakes.

• kwq/character-sets.txt: New version of file from www.iana.org. No substantive change. Also, now that we don't use MIB numbers any more, I could leave out our one local change, the MIB number we added for ISO-10646-J-1.

7:13 PM Changeset in webkit [5173] by darin

• 5 adds in trunk/JavaScriptCore/tests/mozilla

A few more files from the Mozilla tests. Soon I will make it so we can
run the tests.

7:05 PM Changeset in webkit [5172] by darin

• 1218 adds in trunk/JavaScriptCore/tests

First commit of Mozilla JavaScript tests.

Oct 10, 2003:

4:22 PM Changeset in webkit [5171] by hyatt

• 5 edits in trunk/WebCore

Beginning of work on border collapsing. This patch makes sure that cell spacing between cells is
ignored and that padding on tables is ignored. This ensures that there is no space between cells
or between the edges of cells and the border of the table itself.

Reviewed by john

• khtml/rendering/render_style.h: (khtml::RenderStyle::setBitDefaults):
• khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::layout):
• khtml/rendering/render_table.h: (khtml::RenderTable::collapseBorders): (khtml::RenderTable::bordersPaddingAndSpacing):

4:05 PM Changeset in webkit [5170] by hyatt

• 1 edit in trunk/LayoutTests/fast/block/basic/016.html

Update test to remove the padding from tables.

3:35 PM Changeset in webkit [5169] by mjs

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Fixed for Private change from a while back.

3:04 PM Changeset in webkit [5168] by hyatt

• 6 edits in trunk/WebKit

Patch to move widgets during layout instead of waiting until paint time.

Reviewed by darin

• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.h:

3:03 PM Changeset in webkit [5167] by hyatt

• 28 edits in trunk/WebCore

Fix for table regression 3449444, as well as a patch to support padding on tables and to stop
honoring borders on row groups (both of which are correct for the "separate" border model).

• khtml/rendering/render_table.cpp:

(RenderTable::layout):
(RenderTableSection::calcRowHeight):
(RenderTableSection::layoutRows):

• khtml/rendering/render_table.h: (khtml::RenderTable::bordersPaddingAndSpacing):
• khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::layout):

Reviewed by darin

11:40 AM Changeset in webkit [5166] by kocienda

• 7 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3440703>: Textarea form controls do not respect disabled attribute

• khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Check for disabled attribute.
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextArea setEnabled:]): Added. (-[KWQTextArea isEnabled]): Added. (-[KWQTextArea drawRect:]): Draws a disabled-looking bezel when disabled. (-[KWQTextAreaTextView becomeFirstResponder]): Return NO if disabled. (-[KWQTextAreaTextView mouseDown:]): Block events if disabled. (-[KWQTextAreaTextView keyDown:]): Ditto. (-[KWQTextAreaTextView keyUp:]): Ditto. (-[KWQTextAreaTextView setEnabled:]): Added. Pass value through to editable attribute on text view. (-[KWQTextAreaTextView isEnabled]): Added. (-[KWQTextAreaTextView drawRect:]): Set the text color to a disabled color when disabled.
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::isDisabled): Added. (QTextEdit::setDisabled): Added.

12:45 AM Changeset in webkit [5165] by mjs

• 3 edits in trunk/WebCore

• fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page, e.g. on www.aa.com

More fallout from the exception blocking.

• kwq/KWQButton.mm: (QButton::focusPolicy): Don't return from exception block (caught by Darin).

Oct 9, 2003:

10:49 PM Changeset in webkit [5164] by darin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3449280 -- REGRESSION: crash copying a selection that ends in a <br>

• khtml/rendering/render_br.h: Add checkSelectionPointIgnoringContinuations.
• khtml/rendering/render_br.cpp: (RenderBR::checkSelectionPointIgnoringContinuations): Override to never return an offset of 1. We can't use a character offset because the DOM doesn't know that we're implemented as a text object. So an offset of 1 turns into "after this element".

8:21 PM Changeset in webkit [5163] by mjs

• 3 edits in trunk/WebCore

• fixed crash I just added.

• kwq/KWQWidget.mm: (QWidget::setCursor): Move BLOCK_NS_EXCEPTIONS macros so you don't `break' out of the blocking code.

5:46 PM Changeset in webkit [5162] by rjw

• 3 edits in trunk/WebKit

Ensure that the autoscroll timer is always stopped if a mouse up event is lost.

Reviewed by John.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _startAutoscrollTimer:]): (-[WebHTMLView _stopAutoscrollTimer]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView mouseDown:]):
• WebView.subproj/WebHTMLViewPrivate.h:

3:56 PM Changeset in webkit [5161] by mjs

• 11 edits in trunk/WebCore

Reviewed by Ken.

More Cocoa exception blocking work.

• kwq/KWQFrame.mm: (QFrame::setFrameStyle):
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::~QLineEdit): (QLineEdit::setEchoMode): (QLineEdit::setFont): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition): (QLineEdit::setAlignment):
• kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::~QListBox): (QListBox::count): (QListBox::clear): (QListBox::setSelectionMode): (QListBox::insertItem): (QListBox::insertGroupLabel): (QListBox::endBatchInsert): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::focusPolicy):
• kwq/KWQPushButton.mm: (QPushButton::QPushButton): (QPushButton::sizeHint): (QPushButton::baselinePosition): (QPushButton::dimensions):
• kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): (QRadioButton::setChecked): (QRadioButton::isChecked): (QRadioButton::dimensions):
• kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (:m_valueChanged): (QScrollBar::~QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QScrollBar::scrollbarHit):
• kwq/KWQScrollView.mm: (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars): (QScrollView::addChild): (QScrollView::removeChild): (QScrollView::resizeContents): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::setStaticBackground): (QScrollView::ensureVisible): (QScrollView::getDocumentView):
• kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks): (QTextEdit::getCursorPosition): (QTextEdit::setCursorPosition): (QTextEdit::wordWrap): (QTextEdit::setWordWrap): (QTextEdit::isReadOnly): (QTextEdit::setReadOnly): (QTextEdit::selectAll): (QTextEdit::setFont): (QTextEdit::setAlignment): (QTextEdit::sizeWithColumnsAndRows):
• kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::~QWidget): (QWidget::setActiveWindow): (QWidget::setEnabled): (QWidget::isEnabled): (QWidget::frameGeometry): (QWidget::hasFocus): (QWidget::setFocus): (QWidget::focusPolicy): (QWidget::isVisible): (QWidget::setCursor): (QWidget::cursor): (QWidget::setFrameGeometry): (QWidget::mapFromGlobal): (QWidget::setView): (QWidget::getOuterView): (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::disableFlushDrawing): (QWidget::enableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::paint): (QWidget::sendConsumedMouseUp):

3:20 PM Changeset in webkit [5160] by hyatt

• 3 edits in trunk/WebCore

Stop printing extra spaces before list items. Fixes ordered lists with list-style-position: inside.

Reviewed by mjs

• khtml/rendering/render_list.cpp:

2:59 PM Changeset in webkit [5159] by hyatt

• 3 edits in trunk/WebCore

Make definition of kMin and kMax match the KHTML trunk. Someone still needs to eliminate uses of QMIN
and QMAX from the code.

• kwq/KWQDef.h: (kMin): (kMax):

1:41 PM Changeset in webkit [5158] by cblu

• 20 edits in trunk

WebCore:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

• khtml/ecma/kjs_navigator.cpp: (PluginBase::refresh): new (PluginsFunc::tryCall): call refresh
• kwq/KWQKConfigBase.h:
• kwq/KWQKConfigBase.mm: (RefreshPlugins): new
• kwq/WebCoreViewFactory.h:

WebKit:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): release the plug-in object
• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): store the last mod date (-[WebBasePluginPackage dealloc]): release the last mod date (-[WebBasePluginPackage lastModifiedDate]): new (-[WebBasePluginPackage isEqual:]): new (-[WebBasePluginPackage hash]): new
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): convert the NPP_Shutdown proc pointer so that we can use it later (-[WebNetscapePluginPackage unload]): added log message
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): tweak (-[WebPluginDatabase plugins]): tweak (-[WebPluginDatabase init]): call refresh (-[WebPluginDatabase refresh]): new (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): tweak
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): new
• WebView.subproj/WebControllerSets.h:
• WebView.subproj/WebControllerSets.m: (+[WebViewSets makeWebViewsPerformSelector:]): new
• WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebView.m: (-[WebView _reloadForPluginChanges]): new
• WebView.subproj/WebViewPrivate.h:

1:15 PM Changeset in webkit [5157] by vicki

• 3 edits in trunk

tree is open for Safari-110!

1:12 PM Changeset in webkit [5156]

• 3 copies in tags/Safari-109

This commit was manufactured by cvs2svn to create tag 'Safari-109'.

1:12 PM Changeset in webkit [5155] by vicki

• 8 edits in trunk

Safari-109 stamp

12:45 AM Changeset in webkit [5154]

• 7 copies
  2 deletes in tags/WebCore-106-tarball

This commit was manufactured by cvs2svn to create tag
'WebCore-106-tarball'.

12:45 AM Changeset in webkit [5153] by mjs

• 1 edit in branches/WebCore-106-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

WebCore-106 tarball.

Oct 8, 2003:

6:35 PM Changeset in webkit [5152] by hyatt

• 2 adds in trunk/LayoutTests/fast/block/positioning

Adding layout test for section 10.3.7 of the CSS2.1 spec.

6:34 PM Changeset in webkit [5151] by hyatt

• 3 edits in trunk/WebCore

Fix for 3436723, the shrink-to-fit algorithm for positioned elements did not match
the algorithm specified in section 10.3.7 of the CSS2.1 specification. The min-width
of the element was not being taken into account like it should have been.

Reviewed by mjs

• khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):

5:45 PM Changeset in webkit [5150] by hyatt

• 4 edits in trunk/WebCore

Implement min/max width and min/max height support for replaced elements.

Reviewed by ken

• khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedWidthUsing): (RenderBox::calcReplacedHeight): (RenderBox::calcReplacedHeightUsing): (RenderBox::availableHeight): (RenderBox::availableHeightUsing):
• khtml/rendering/render_box.h:

4:27 PM Changeset in webkit [5149] by mjs

• 3 edits in trunk/WebCore

Fix development build.

• kwq/KWQExceptions.h: Correct assertion args.

2:23 PM Changeset in webkit [5148]

• 1 copy
  322 deletes in branches/unlabeled-1.39.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.39.4'.

2:23 PM Changeset in webkit [5147] by mjs

• 23 edits
  1 add in trunk/WebCore

Reviewed by Ken.

Start on blocking Cocoa exceptions when calling ObjC from C++ to
avoid unreproducible crashes when this happens.

• kwq/KWQExceptions.h: Added. Helper macros for exception blocking.
• WebCore.pbproj/project.pbxproj: Add new header

In all these files, block exceptions when calling ObjC from C++,
or explain why not.

• kwq/KWQAccObjectCache.mm:
• kwq/KWQApplication.mm:
• kwq/KWQButton.mm: (QButton::QButton): (QButton::~QButton): (QButton::setText): (QButton::text): (QButton::clicked): (QButton::simulateClick): (QButton::setFont): (QButton::focusPolicy):
• kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox): (QCheckBox::setChecked): (QCheckBox::isChecked): (QCheckBox::dimensions):
• kwq/KWQColor.mm:
• kwq/KWQComboBox.mm: (QComboBox::QComboBox): (QComboBox::~QComboBox): (QComboBox::insertItem): (QComboBox::sizeHint): (QComboBox::setCurrentItem): (QComboBox::updateCurrentItem): (QComboBox::setFont): (QComboBox::dimensions):
• kwq/KWQCursor.mm:
• kwq/KWQFile.mm:
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):
• kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookieEnabled):
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): (KHTMLPartBrowserExtension::setIconURL): (KHTMLPartBrowserExtension::setTypedIconURL):
• kwq/KWQKHistoryProvider.mm: (KParts::HistoryProvider::contains):
• kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::callMethod):
• kwq/KWQKStandardDirs.mm:
• kwq/KWQKURL.mm:
• kwq/KWQKWinModule.mm: (KWinModule::workArea):
• kwq/KWQObject.mm:
• kwq/KWQString.mm: (QString::getNSString):
• kwq/KWQTimer.mm:
• kwq/KWQWindowWidget.mm:

Oct 7, 2003:

6:49 PM Changeset in webkit [5146] by hyatt

• 5 edits in trunk/WebCore

Fix for link dragging regression in the titles of links. More accessibility
improvements.

Reviewed by darin

• khtml/khtml_part.cpp: (KHTMLPart::text):
• kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject helpText]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeValue:]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

3:23 PM Changeset in webkit [5145] by kocienda

• 19 edits in trunk/WebCore

Reviewed by Darin

Fix for these bugs:

<rdar://problem/3443296>: REGRESSION: pop-up menu gets focus, but once it has
focus doesn't work right
<rdar://problem/3444873>: Select widgets that use list views do not take part in tab order
<rdar://problem/3446306>: Text area form widgets do not accept DOM focus correctly
<rdar://problem/3446323>: Using keyboard to work popup button select form
widget causes a crash

The intention of this patch is to add keyboard navigation support for
HTML form select widgets. This includes the two visual representations
for these widgets: popup buttons and lists. Many keyboard, focus, and
tabbing fixes are included in this work, as indicated below.

• khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::defaultEventHandler): Added. Submit form when return or enter key is pressed when focused on a select widget.
• khtml/html/html_formimpl.h: Make HTMLSelectElementImpl a friend class of HTMLInputElementImpl. This is done so that an HTMLSelectElementImpl can call the private method which simulates a form submit. Also add declaration of defaultEventHandler function.
• kwq/KWQButton.h: Clean up focusPolicy declaration.
• kwq/KWQComboBox.h: Add focusPolicy declaration.
• kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Now calls sendFakeEventsAfterWidgetTracking instead of doFakeMouseUpAfterWidgetTracking now that name has changed. (-[KWQPopUpButton becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQPopUpButton resignFirstResponder]): Ditto. (-[KWQPopUpButton nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQPopUpButton previousKeyView]): Ditto. (-[KWQPopUpButton nextValidKeyView]): Ditto. (-[KWQPopUpButton previousValidKeyView]): Ditto.
• kwq/KWQKHTMLPart.h: Change name of doFakeMouseUpAfterWidgetTracking to sendFakeEventsAfterWidgetTracking now that it handles key events as well.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Name change as noted above. Also handles sending simulated key up events.
• kwq/KWQLineEdit.h: (QLineEdit::checksDescendantsForFocus): Added. This is a big part of the fiz for <rdar://problem/3446306>.
• kwq/KWQListBox.h: (QListBox::checksDescendantsForFocus): Ditto. Yes for this widget.
• kwq/KWQListBox.mm: (QListBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQListBoxScrollView becomeFirstResponder]): Added. Needed for setting focus correctly. This sets the focus to its document view. (-[KWQTableView becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView resignFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQTableView previousKeyView]): Ditto. (-[KWQTableView nextValidKeyView]): Ditto. (-[KWQTableView previousValidKeyView]): Ditto. (-[KWQTableView _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Other part of fix for <rdar://problem/3446306>. The recursion guards were bad and wrong. The checksDescendantsForFocus improvement prevents the erroneous recursion from happening.
• kwq/KWQTextEdit.h: (QTextEdit::checksDescendantsForFocus): Added. Yes for this widget.
• kwq/KWQWidget.h: (QWidget::checksDescendantsForFocus): Added. No by default.
• kwq/KWQWidget.mm: (QWidget::hasFocus): Now uses checksDescendantsForFocus to perform proper checks for views that may have a subview which is first responder.

1:15 PM Changeset in webkit [5144] by hyatt

• 9 edits in trunk/WebCore

Fix for 3363421, event handlers could be triggered for content outside an overflow:hidden
area. The layer checks that test for intersection/point containment need to only include
layers with overhanging floats if the element is overflow:visible.

Fix for 3366801, assignment to scrollLeft/Top of an overflow:hidden layer makes the layer
disappear. overflow:hidden blocks actually were never computing their scroll dimensions,
and so had bogus answers for those values.

Fix for 3366686, no reliable scrollHeight/Width reporting for overflow:hidden or
overflow:visible elements. The former was caused by the same bug as 3366801. The
latter was just me using the wrong method (clientWidth/Height instead of
overflowWidth/Height).

This patch also tightens the assignment to scrollLeft/Top to not do anything if you don't
have an overflow value other than visible.

Reviewed by darin

• khtml/ecma/kjs_dom.cpp: (DOMNode::putValue):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::scrollToOffset): (RenderLayer::scrollWidth): (RenderLayer::scrollHeight): (RenderLayer::computeScrollDimensions): (RenderLayer::updateScrollInfoAfterLayout): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::scrollWidth): (RenderObject::scrollHeight):
• khtml/rendering/render_object.h:

10:43 AM Changeset in webkit [5143] by darin

• 3 edits in trunk/WebCore

Reviewed by Chris.

• fixed some exceptions I was seeing with my recent text change

• khtml/khtml_part.cpp: (KHTMLPart::text): Return an empty string for a null range rather than raising an exception. (KHTMLPart::selection): Return a null range rather than raising an exception if there is no selection.

8:49 AM Changeset in webkit [5142] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• removed code that mutates \n into a space so we can pass more W3C DOM Level 1 Core tests

• khtml/rendering/bidi.cpp: (khtml::addRun): Treat \n as a space. (khtml::RenderBlock::computeHorizontalPositionsForLine): Treat \n as a space. (khtml::RenderBlock::findNextLineBreak): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space.

• khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): Treat \n outside <pre> as a space. (RenderText::calcMinMaxWidth): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space. (RenderText::position): Detect a <br> with isBR instead of assuming a 1-character string with a \n in it is a <br>.

Oct 6, 2003:

9:43 PM Changeset in webkit [5141] by hyatt

• 23 edits in trunk/WebCore

Several fixes preparing for the incremental repainting patch to be enabled.

(1) Make layers update their positions after layout instead of during layout or
during painting.

(2) Fix a regression from the overflow:hidden body quirk landing. Make sure repaint()
understands that quirk exists and avoids clipping when it shouldn't.

(3) Fix a regression from the scrollbar improvements. The vertical scrollbar repainted
on every layout.

(4) Make sure outside list bullets are repainted when a list item needs to repaint.

(5) A whole bunch of INCREMENTAL_REPAINTING code that isn't turned on yet.

Reviewed by kocienda

• khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::resetScrollBars): (KHTMLView::needsFullRepaint):
• khtml/khtmlview.h:
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::repaintFloatingDescendants): (khtml::RenderBlock::repaintObjectsBeforeLayout):
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintDuringLayoutIfMoved):
• khtml/rendering/render_box.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
• khtml/rendering/render_canvas.h: (khtml::RenderCanvas::hasOverhangingFloats):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::layoutHorizontalBox): (khtml::RenderFlexibleBox::layoutVerticalBox): (khtml::RenderFlexibleBox::placeChild):
• khtml/rendering/render_flexbox.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::computeRepaintRects): (RenderLayer::updateLayerPositions): (RenderLayer::updateLayerPosition): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintLayer): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects):
• khtml/rendering/render_layer.h: (khtml::RenderLayer::relativePositionOffset):
• khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
• khtml/rendering/render_list.h: (khtml::RenderListMarker::listImage):
• khtml/rendering/render_object.cpp: (RenderObject::repaint): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintDuringLayoutIfMoved): (RenderObject::repaintFloatingDescendants): (RenderObject::checkForRepaintDuringLayout): (RenderObject::repaintObjectsBeforeLayout): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::container):
• khtml/rendering/render_object.h:
• khtml/rendering/render_table.cpp: (RenderTable::layout):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget):

5:01 PM Changeset in webkit [5140] by darin

• 7 edits in trunk/WebCore

Reviewed by Ken.

• preparation for the upcoming whitespace patch; refactored some of the code that extracts text

• khtml/khtml_part.h: Added text() member function.
• khtml/khtml_part.cpp: (KHTMLPart::text): Added. Refactored from selectedText; takes a DOM::Range as a parameter. Also added code to change newlines to spaces when extracting text from the DOM. (KHTMLPart::selectedText): Now calls text(). (KHTMLPart::selection): Removed stray declaration.

• kwq/KWQAccObject.mm: (-[KWQAccObject value]): Changed to call KHTMLPart::text.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Changed to call KHTMLPart::text instead of doing it ourselves.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Added code to change change '\n' newlines to spaces when extracting text from the DOM.

1:28 PM Changeset in webkit [5139] by mjs

• 5 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3444255 - REGRESSION: www.aa.com crashes (innerHTML)

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Keep the fragment ref'd since the tokenizer will ref and deref it. Then turn TreeShared's evil against itself to get the fragment back in the floating 0-ref state.
• khtml/html/html_elementimpl.h: Remove stray whitespace.
• khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Initialize current to 0 in the other constructor too.

9:01 AM Changeset in webkit [5138] by darin

• 1 edit in trunk/WebKit/ChangeLog

Fixed a newline.

8:50 AM Changeset in webkit [5137] by darin

• 20 edits in trunk

JavaScriptCore:

• kjs/create_hash_table: Remove stray semicolon.

• kjs/array_object.lut.h:
• kjs/date_object.lut.h:
• kjs/lexer.lut.h:
• kjs/math_object.lut.h:
• kjs/number_object.lut.h:
• kjs/string_object.lut.h: Regenerated.

WebCore:

• khtml/ecma/kjs_css.lut.h:
• khtml/ecma/kjs_dom.lut.h:
• khtml/ecma/kjs_events.lut.h:
• khtml/ecma/kjs_html.lut.h:
• khtml/ecma/kjs_navigator.lut.h:
• khtml/ecma/kjs_range.lut.h:
• khtml/ecma/kjs_traversal.lut.h:
• khtml/ecma/kjs_views.lut.h:
• khtml/ecma/kjs_window.lut.h: Regenerated, without stray semicolon.

Oct 3, 2003:

4:24 PM Changeset in webkit [5136] by rjw

• 3 edits in trunk/WebKit

Fix part of 3438071. Creating an instance of WebPreferences using init
will do the expected thing: that is, create a new instance! We used to
always return standardPreferences.

Reviewed by Chris.

• WebView.subproj/WebPreferences.m: (-[WebPreferences init]): (+[WebPreferences standardPreferences]):

3:38 PM Changeset in webkit [5135] by darin

• 3 edits in trunk

• updated layout tests for recent WebTextRenderer changes

• layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
• layout-tests/apple-only/base/www.sun.com/index-expected.txt:
• layout-tests/css1/font_properties/font_weight-expected.txt:

3:32 PM Changeset in webkit [5134] by hyatt

• 2 edits in trunk/WebKit

Fix for numerous regressions caused by an inadvertent renaming of the recursiveDisplay
override method.

Reviewed by darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):

2:57 PM Changeset in webkit [5133] by rjw

• 2 edits in trunk/WebKit

Fixed some edge case issue (control characters after end of word) with our rounding hack.

Reviewed by Darin.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):

2:51 PM Changeset in webkit [5132] by cblu

• 3 edits
  1 delete in trunk/WebCore

Removed eastCursor.tiff because it was added by mistake.

• Resources/eastCursor.tiff: Removed.
• WebCore.pbproj/project.pbxproj:

2:49 PM Changeset in webkit [5131] by mjs

• 7 edits in trunk/WebCore

Reviewed by Richard.

• fixed 3398420 - crash when creating a new document.body object in <body>

Also included David Faure's improvement to throw an exception.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setBody): Don't remove the body when null is passed in, as this means type error at the higher level, so throw an exception.
• khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Initialize current to 0. (KHTMLParser::setCurrent): Ref new current and deref old; we need to keep it ref'd because script execution could drop the current node on the floor. (KHTMLParser::reset): Use setCurrent. (KHTMLParser::insertNode): Likewise. (KHTMLParser::reopenResidualStyleTags): Likewise. (KHTMLParser::popOneBlock): Likewise. (KHTMLParser::finished): Likewise.
• khtml/html/htmlparser.h: Prototype setCurrent.

2:46 PM Changeset in webkit [5130] by cblu

• 14 edits in trunk/WebCore

Ran compress-tiffs on new cursor images.

• Resources/eastCursor.tiff:
• Resources/eastResizeCursor.tiff:
• Resources/helpCursor.tiff:
• Resources/moveCursor.tiff:
• Resources/northEastResizeCursor.tiff:
• Resources/northResizeCursor.tiff:
• Resources/northWestResizeCursor.tiff:
• Resources/southEastResizeCursor.tiff:
• Resources/southResizeCursor.tiff:
• Resources/southWestResizeCursor.tiff:
• Resources/waitCursor.tiff:
• Resources/westResizeCursor.tiff:

11:46 AM Changeset in webkit [5129] by kocienda

• 11 edits in trunk

WebCore:

Reviewed by Darin, with much help from Maciej and Hyatt

Fix for these bugs:

<rdar://problem/3441321>: Form buttons do not respond to key events when focused
<rdar://problem/3441060>: Form buttons do not scroll to view when focused

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::simulateMouseClickForEvent): Added helper to simulate mouse clicks in elements. Used to trigger button actions in response to keyboard events. (HTMLInputElementImpl::defaultEventHandler): Improved handler to process key press events for radio, checkbox, image, reset, and submit buttons.
• khtml/html/html_formimpl.h: Added simulateMouseClickForEvent function.
• khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::isKeyboardEvent): Added type check virtual function. (DOM::KeyEventImpl::isKeyboardEvent): Ditto.
• kwq/KWQButton.h:
• kwq/KWQButton.mm: (-[KWQButton simulateClick]): New method. This makes AppKit do a button click programatically for button types. For <input type=image>, we just simulate a the click in the DOM since there is no real "clickable" AppKit widget. (-[KWQButton becomeFirstResponder]): Fixes the button scroll to visible when focused issue. (-[KWQButton resignFirstResponder]): Correctly give up focus when user clicks into the page body when a button has the focus. (QButton::simulateClick): QWidget bridge to the KWQButton simulateClick method.

WebKit:

Reviewed by Darin, with much help from Maciej and Hyatt

Fix for this bug:

<rdar://problem/3441321>: Form buttons do not respond to key events when focused

• WebView.subproj/WebFrameView.m: (-[WebFrameView _firstResponderIsControl]): Added to tell if the focus is on a form control. (-[WebFrameView keyDown:]): Call new _firstResponderIsControl method to see whether space bar key events should propagate. Adding this check keeps us from blocking the event here and allows AppKit to handle it.
• WebView.subproj/WebFrameViewPrivate.h: Add new _firstResponderIsControl method.

11:40 AM Changeset in webkit [5128] by hyatt

• 6 edits in trunk/WebCore

Removing redundant layouts and adding a few !needsLayout and !normalChildNeedsLayout
checks to prevent extra layouts.

Also, fixing the recalcStyle changed() bottleneck to go through view's layout and to
not do a full repaint. The layout method will then do the right thing (full repaint
without INCREMENTAL_REPAINTING turned on, the precise repainting needed otherwise).

Reviewed by darin

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):

Oct 2, 2003:

5:48 PM Changeset in webkit [5127] by mjs

• 9 edits
  6 deletes in trunk/WebKit

Folded Private implementation files into the regular ones as the
first step towards pulling in our SPI exposure and other code
cleanup.

• History.subproj/WebHistory.m:
• History.subproj/WebHistoryPrivate.m: Removed.
• Misc.subproj/WebIconDatabasePrivate.h:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m: Removed.
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m: Removed.
• WebView.subproj/WebFrameView.m:
• WebView.subproj/WebFrameViewPrivate.m: Removed.
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m: Removed.
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.m: Removed.

4:28 PM Changeset in webkit [5126] by hyatt

• 3 edits in trunk/WebCore

Remove the speed hit from using the UC break locators by not using them when
checking if the current character is &nbsp; and by also using a global text
break locator object.

Reviewed by rjw

• khtml/rendering/break_lines.cpp:

4:16 PM Changeset in webkit [5125] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build

Reviewed by rjw.

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): if not data was received for a stream, create the temp file anyway. Plug-ins expect this.

3:11 PM Changeset in webkit [5124] by vicki

• 3 edits in trunk

tree is open for Safari-109

3:06 PM Changeset in webkit [5123]

• 3 copies in tags/Safari-108

This commit was manufactured by cvs2svn to create tag 'Safari-108'.

3:06 PM Changeset in webkit [5122] by vicki

• 8 edits in trunk

Safari-108 stamp.

12:58 PM Changeset in webkit [5121] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

11:50 AM Changeset in webkit [5120] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed 3441466 - REGRESSION: ​http://www.meyerweb.com/eric/css/edge/complexspiral/glassy.html broken on scroll

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Don't turn on scroll-blitting here when the page is done... (-[WebFrame _transitionToCommitted:]): Instead do it here, when the page is committed.

11:46 AM Changeset in webkit [5119] by mjs

• 5 edits in trunk/WebCore

Reviewed by Darin.

• fixed 3398622 - Crash when JavaScript changes display style

This was a problem with one of the many global variables in
bidi.cpp, last, having a stale value from the last layout that
pointed to a dead node. I fixed this by refactoring the code to
put most of the global variables in a struct allocated on the
stack, and pass around a reference to the struct. Seems much
cleaner (if somewhat wordier) this way. There are still more
global variables to kill here.

• khtml/rendering/bidi.cpp: (khtml::BidiIterator::BidiIterator): (khtml::BidiStatus::BidiStatus): (khtml::BidiInfo::BidiInfo): (khtml::Bidinext): (khtml::first): (khtml::BidiIterator::increment): (khtml::checkMidpoints): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/bidi.h:
• khtml/rendering/render_block.h:

11:35 AM Changeset in webkit [5118] by darin

• 2 edits in trunk/WebKit

Reviewed by Ken.

• in preparation for a WebCore whitespace-handling change, made WebTextRenderer draw and measure newline characters as if they are spaces (just as we already do with non-breaking spaces)
• removed some unused stuff from WebTextRenderer
• other unimportant tweaks (e.g. unsigned int -> unsigned)

• WebCoreSupport.subproj/WebTextRenderer.m: (kFixedOne), (fixed1), (FixToFloat), (FloatToFixed): Removed these. We can use the standard ones from <FixMath.h> instead of defining our own. (isControlCharacter): Added. Inline function that we can use instead of the macro we had before. (isAlternateSpace): Added. Returns YES for newlines and non-breaking spaces. (isSpace): Added. Returns YES for real spaces and the two alternate spaces as well. (initializeCharacterWidthIterator): Use isSpace. (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): Use isAlternateSpace and isControlCharacter. (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): Use isControlCharacter, isAlternateSpace, and isSpace. Also fix a small bug where numGlyphs would not get set up properly when the run length is 0, and used local variables when possible instead of going back at the run structure. (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): Use the standard FixedToFloat instead of our own FixToFloat. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): Ditto.

11:23 AM Changeset in webkit [5117] by hyatt

• 7 edits in trunk/WebCore

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

• kwq/KWQAccObject.h:
• kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityIsAttributeSettable:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityHitTest:]):
• kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):

11:22 AM Changeset in webkit [5116] by hyatt

• 2 edits in trunk/WebKit

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView accessibilityAttributeValue:]): (-[WebHTMLView accessibilityHitTest:]):

11:19 AM Changeset in webkit [5115] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3441656 -- constructor bad for objs created w/ function as prototype (www.moock.org/asdg/codedepot)

• kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Set up the constructor as as specified in the JavaScript spec. We were already doing this right in the other place we make functions.

8:31 AM Changeset in webkit [5114] by darin

• 122 edits in trunk

Reviewed by Ken.

• kwq/KWQRenderTreeDebug.cpp: (quoteAndEscapeNonPrintables): Since our text rendering renders non-breaking spaces the same as spaces, dump them as spaces. Do the same with newlines since I am about to change our text rendering to do the same with newlines.

• layout-tests: Updated test results.

Oct 1, 2003:

6:43 PM Changeset in webkit [5113] by hyatt

• 4 edits in trunk/WebCore

Avoid doing extra work when tearing down the document by checking to see if
we're in the destruction of the document.

Reviewed by darin

• khtml/rendering/render_block.cpp:
• khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):

5:24 PM Changeset in webkit [5112] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewDidMoveToSuperview]): skip some work when when we've been removed. This wasn't causing any trouble before, but was at least conceptually inefficient.

5:07 PM Changeset in webkit [5111] by sullivan

• 2 edits in trunk/WebKit

• fixed 3441372: REGRESSION (107+): Plain text document is initially drawn with proportional font

Reviewed by Hyatt

• WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]): Changed a != to an ==

4:57 PM Changeset in webkit [5110] by rjw

• 13 edits in trunk

WebKit:

Fixed 3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.

Reviewed by Ken.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _itemForRestoringDocState]):

WebCore:

Fixed 3438441. Pass extra info up to WebKit about load type, specifically is a load is triggered by JS running in an onLoad handler.

Reviewed by Ken.

• khtml/ecma/kjs_binding.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::urlSelected):
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Nothing changed. Tweaked spacing.

4:56 PM Changeset in webkit [5109] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]): Fixed problem where we'd get a nil WebView and pass crazy values for subframe text multipliers.

4:27 PM Changeset in webkit [5108] by cblu

• 10 edits
  12 adds in trunk/WebCore

<rdar://problem/2942589>: CSS cursors are not implemented

Reviewed by Dave.

• Resources/eastCursor.tiff: Added.
• Resources/eastResizeCursor.tiff: Added.
• Resources/helpCursor.tiff: Added.
• Resources/moveCursor.tiff: Added.
• Resources/northEastResizeCursor.tiff: Added.
• Resources/northResizeCursor.tiff: Added.
• Resources/northWestResizeCursor.tiff: Added.
• Resources/southEastResizeCursor.tiff: Added.
• Resources/southResizeCursor.tiff: Added.
• Resources/southWestResizeCursor.tiff: Added.
• Resources/waitCursor.tiff: Added.
• Resources/westResizeCursor.tiff: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/cssparser.cpp: special-case the hand cursor to mean pointer (CSSParser::parseValue):
• khtml/css/cssvalues.c: generated changes (hash_val): (findValue):
• khtml/css/cssvalues.h: generated changes
• khtml/css/cssvalues.in: removed the progress cursor from the list because it was messing up the mapping
• khtml/khtmlview.cpp: call new cursor methods
• kwq/KWQKCursor.h:
• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]): new, loads and caches cursors (KCursor::crossCursor): get the AppKit cross hair cursor (KCursor::handCursor): call _WebCore_cursorWithName:hotSpot: (KCursor::sizeAllCursor): ditto (KCursor::waitCursor): ditto (KCursor::whatsThisCursor): ditto (KCursor::eastResizeCursor): new, call _WebCore_cursorWithName:hotSpot: (KCursor::northResizeCursor): ditto (KCursor::northEastResizeCursor): ditto (KCursor::northWestResizeCursor): ditto (KCursor::southResizeCursor): ditto (KCursor::southEastResizeCursor): ditto (KCursor::southWestResizeCursor): ditto (KCursor::westResizeCursor): ditto

1:58 PM Changeset in webkit [5107] by hyatt

• 45 edits
  4 adds in trunk

Clean up our detach model so that you can always get to a document, even for
anonymous content. Also stubbing out and adding the accessibility objects.

Reviewed by darin, mjs, john

• ChangeLog:
• WebCore.pbproj/project.pbxproj:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_box.cpp: (RenderBox::detach):
• khtml/rendering/render_box.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
• khtml/rendering/render_container.cpp: (RenderContainer::detach): (RenderContainer::addChild): (RenderContainer::updatePseudoChild): (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes):
• khtml/rendering/render_container.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::createAnonymousFlow): (RenderFlow::deleteLineBoxes): (RenderFlow::detach):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_form.cpp: (RenderTextArea::detach):
• khtml/rendering/render_form.h:
• khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::detach):
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitFlow): (RenderInline::renderName):
• khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation): (RenderListMarker::RenderListMarker):
• khtml/rendering/render_list.h:
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information): (RenderObject::dump): (RenderObject::createAnonymousBlock): (RenderObject::remove): (RenderObject::detach):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderWidget::detach):
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTableSection::detach): (RenderTableSection::addChild): (RenderTableRow::detach): (RenderTableRow::addChild): (RenderTableCell::detach):
• khtml/rendering/render_table.h:
• khtml/rendering/render_text.cpp: (RenderText::detach): (RenderText::deleteRuns):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::detach): (DocumentImpl::getOrCreateAccObjectCache):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::detach):
• kwq/KWQAccObject.h: Added.
• kwq/KWQAccObject.mm: Added. (-[KWQAccObject x]): (-[KWQAccObject y]): (-[KWQAccObject width]): (-[KWQAccObject height]): (-[KWQAccObject detached]): (-[KWQAccObject detach]): (-[KWQAccObject data]): (-[KWQAccObject setData:]): (-[KWQAccObject firstChild]): (-[KWQAccObject lastChild]): (-[KWQAccObject previousSibling]): (-[KWQAccObject nextSibling]): (-[KWQAccObject parentObject]):
• kwq/KWQAccObjectCache.h: Added.
• kwq/KWQAccObjectCache.mm: Added. (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::detach):
• layout-tests/css1/pseudo/firstletter-expected.txt:
• layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
• layout-tests/fast/css-generated-content/002-expected.txt:
• layout-tests/fast/css-generated-content/004-expected.txt:
• layout-tests/fast/css-generated-content/005-expected.txt:
• layout-tests/fast/css-generated-content/006-expected.txt:
• layout-tests/fast/selectors/039-expected.txt:
• layout-tests/fast/selectors/039b-expected.txt:
• layout-tests/fast/selectors/041-expected.txt:
• layout-tests/fast/selectors/042-expected.txt:
• layout-tests/fast/selectors/166a-expected.txt:
• layout-tests/fast/selectors/168-expected.txt:
• layout-tests/fast/selectors/168a-expected.txt:
• layout-tests/fast/selectors/169-expected.txt:
• layout-tests/fast/selectors/169a-expected.txt:
• layout-tests/fast/text/firstline/002-expected.txt:
• layout-tests/fast/text/firstline/003-expected.txt:

1:36 PM Changeset in webkit [5106] by hyatt

• 2 adds in trunk/LayoutTests/fast/dynamic

Adding layout test for setting of cssFlaot via a with clause.

1:30 PM Changeset in webkit [5105] by hyatt

• 3 edits in trunk/WebCore

Fix for 3163840, the images are mispositioned on the DHTML menus at the top of
www.aa.com (and in many other places). We needed to support returning the right
value from hasProperty and tryGet for 'cssFloat'.

This patch also adds support for getting/setting our custom CSS properties (-khtml-*)
and just factors the code a bit better for all the special values.

Reviewed by darin

• khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::hasProperty): (DOMCSSStyleDeclaration::tryGet): (DOMCSSStyleDeclaration::tryPut):

1:22 PM Changeset in webkit [5104] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3437309 -- REGRESSION (100-107): Javascript menu doesn't work at www.aa.com

• khtml/xml/dom_elementimpl.cpp: (ElementImpl::removeAttribute): Restored the old behavior for removeAttribute and removeAttributeNS; these don't give NOT_FOUND_ERR. But keep the NOT_FOUND_ERR for removeAttributeNode and removedNamedItem.

12:57 PM Changeset in webkit [5103] by kocienda

• 3 edits in trunk/WebCore

Reviewed by me

• kwq/KWQWidget.mm: (QWidget::focusPolicy): Improved comment.

11:48 AM Changeset in webkit [5102] by kocienda

• 8 edits in trunk/WebCore

Reviewed by Maciej

Fix for these bugs:

<rdar://problem/3439736>: WebCore form button widgets do not accept focus
<rdar://problem/3440770>: WebCore form button widgets do not take part in tabbing order

• kwq/KWQButton.h: Add focusPolicy function declaration.
• kwq/KWQButton.mm: (-[KWQButton nextKeyView]): Add tabbing support for buttons. (-[KWQButton previousKeyView]): Ditto (-[KWQButton nextValidKeyView]): Ditto (-[KWQButton previousValidKeyView]): Ditto (QButton::focusPolicy): Add focusPolicy implementation. This calls through to the recently-added accessor for full keyboard access to help in the determination for focus policy. For now, full keyboard access must be turned on for buttons to receive focus.
• kwq/KWQTextEdit.h: Remove focusPolicy specialization from this class. The implementation in QWidget now serves this class well.
• kwq/KWQTextEdit.mm: Ditto
• kwq/KWQWidget.h: Added isEnabled function. Small, unrelated cleanup to move the no-implementation setFocusPolicy() and setFocusProxy() functions fully into the header file.
• kwq/KWQWidget.mm: (QWidget::isEnabled): Added. Calls through to the Cocoa view to retrieve this information. (QWidget::focusPolicy): Much improved focus policy function is now more general in stipulating the conditions for focus policy, and will work for more widgets.

11:36 AM Changeset in webkit [5101]

• 1 copy
  318 deletes in branches/unlabeled-1.35.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.4'.

11:36 AM Changeset in webkit [5100] by hyatt

• 4 edits in trunk/WebCore

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

• kwq/KWQScrollView.h:
• kwq/WebCoreFrameView.h:

11:34 AM Changeset in webkit [5099] by hyatt

• 2 edits in trunk/WebKit

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

• WebView.subproj/WebDynamicScrollBarsView.m:

Sep 30, 2003:

5:47 PM Changeset in webkit [5098] by rjw

• 2 edits in trunk/WebKit

Attempt to find a reasonable font using a simple string matching heuristic if
none of the fonts actually specified are found. In particular we will use
Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
any of the requested font family names. Geeza Pro is a much better fallback
font for Arabic (and variant languages) than Helvetica.

Reviewed by Chris.

• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]):

5:38 PM Changeset in webkit [5097] by sullivan

• 8 edits
  1 add in trunk/WebKit

WebKit:

• fixed 3045617 -- Make Text Bigger/Smaller doesn't affect non-html documents.

I added an internal protocol inside WebKit to make this work, and implemented
it for plain text and RTF. I also slightly shuffled the existing code to
handle this for HTML so that it goes through the new protocol in that case
also.

Reviewed by NOBODY (OOPS!).

• WebView.subproj/WebDocumentInternal.h: Added.

New header file, holds definition of

_web_WebDocumentTextSizing protocol.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): if the document view conforms to the new protocol, tell it that the multiplier has changed. Also, don't tell the bridge here anymore; let WebHTMLView do that.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateTextSizeMultiplier]): tell the bridge here instead of having WebFrame do so (-[WebHTMLView viewDidMoveToSuperview]): call _updateTextSizeMultiplier (in case it changed while we were switched out) (-[WebHTMLView _web_textSizeMultiplierChanged]): call _updateTextSizeMultiplier

• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation receivedData:withDataSource:]):

• WebView.subproj/WebTextView.h: now implements _web_WebDocumentTextSizing protocol; new ivar for holding local copy of text size multiplier; new public method appendReceivedData:fromDataSource:

• WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): set local copy of text size multiplier to 1.0 (-[WebTextView _textSizeMultiplierFromWebView]): new method, asks the webview's opinion of the text size multiplier (-[WebTextView setFixedWidthFont]): use the text size multiplier when setting font size (-[WebTextView _adjustRichTextFontSizeByRatio:]): new method, borrowed from Mail and tweaked, that walks through the rich text and adjusts the font sizes (-[WebTextView _updateTextSizeMultiplier]): new method, updates local copy of text size multiplier to match webview's opinion (-[WebTextView setDataSource:]): set the text size multiplier appropriately before setting the fixed-width font; this is too early for the RTF case though since the fonts are embedded in the data (-[WebTextView appendReceivedData:fromDataSource:]): new method. Most of this logic was in WebTextRepresentation, but it's a little better encapsulated here, plus now it handles the text multiplier for RTF. (-[WebTextView defaultsChanged:]): added comment (-[WebTextView _web_textSizeMultiplierChanged]): call updateTextSizeMultiplier

• WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): return NO if the main frame doesn't support the text sizing protocol. This means that if the main frame doesn't support it but a subframe does, you can't adjust the text size. This seems fine for now since the only case with subframes is HTML, where the main frame does support changing text size.

• WebKit.pbproj/project.pbxproj: updated for new file

WebBrowser:

Reviewed by Darin

• HTMLSourceDocument.h: removed unused _textSizeMultiplier ivar

5:08 PM Changeset in webkit [5096] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3428262>: Plugin loads for static files, but not PHP scripts

Reviewed by rjw.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): load the plug-in DB so this method returns reliable results.

4:17 PM Changeset in webkit [5095] by kocienda

• 3 edits in trunk/WebCore

Reviewed by me

• WebCore.pbproj/project.pbxproj: Made WebCoreKeyboardAccess.h a private header.

4:07 PM Changeset in webkit [5094] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3006869>: show image dimensions in title bar when single image is loaded

Reviewed by rjw.

• English.lproj/Localizable.strings:
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): return "foo.jpg 50x50 pixels"

4:04 PM Changeset in webkit [5093] by rjw

• 2 edits in trunk/WebKit

Fixed 3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is only important because our Help folks oddly depend on the behavior.

Reviewed by Chris.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

3:47 PM Changeset in webkit [5092] by kocienda

• 1 add in trunk/WebCore/kwq/WebCoreKeyboardAccess.h

I added this file earlier, but a cvs-abandon command removed it. Re-adding and committing.

3:47 PM Changeset in webkit [5091] by kocienda

• 9 edits in trunk

WebCore:

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference

• WebCore.pbproj/project.pbxproj:
• kwq/KWQKHTMLPart.h: Declare keyboardUIMode accessor.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyboardUIMode): Implement keyboardUIMode accessor (calls through the bridge).
• kwq/WebCoreBridge.h: Declare the bridge accessor.
• kwq/WebCoreKeyboardAccess.h: Added. Header defines keyboard UI mode constants.

WebKit:

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference

• WebCoreSupport.subproj/WebBridge.h: Add two ivars: one to track the keyboard UI mode, the other a flag we use to register for notifications.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove the notification observer to keyboard UI mode changes. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): New method. Accesses the preferences to get the current keyboard UI mode. (-[WebBridge keyboardUIMode]): Returns the current keyboard UI mode. Registers for notifications of keyboard UI mode changes when called the first time.

2:58 PM Changeset in webkit [5090] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Ken.

• fixed 3375281 - Keyboard event handlers not fired if focus not in form field
• fixed 3242927 - KeyPressed Event in Javascript don't work
• fixed 3375353 - keyboard event.target not updated when blurring from form items
• fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
• kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
• kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto

WebKit:

Reviewed by Ken.

• fixed 3375281 - Keyboard event handlers not fired if focus not in form field
• fixed 3242927 - KeyPressed Event in Javascript don't work
• fixed 3375353 - keyboard event.target not updated when blurring from form items
• fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.

2:06 PM Changeset in webkit [5089] by rjw

• 4 edits in trunk/WebKit

Fixed 3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.

Reviewed by Chris.

• WebView.subproj/WebView.m: (-[WebView isLoading]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):

12:53 PM Changeset in webkit [5088] by hyatt

• 21 edits in trunk/LayoutTests

Update layout tests.

11:47 AM Changeset in webkit [5087] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_list.cpp

Backing out an accidental commit.

11:46 AM Changeset in webkit [5086] by hyatt

• 3 edits in trunk/WebKit

Improvements to scrolling and layout. Also fixing 3264346, body overflow should
apply to document's scrollbars.

Reviewed by darin

• WebView.subproj/WebDynamicScrollBarsView.h:
• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView initWithFrame:]): (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):

11:45 AM Changeset in webkit [5085] by hyatt

• 19 edits in trunk/WebCore

Improvements to layout transitions and scrollbar appearance/disappearance.
Also implementing a fix for 3264346, overflow applied to body should apply to
the document's scrollers.

Reviewed by darin

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute):
• khtml/khtmlview.cpp: (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::resetScrollBars): (KHTMLView::clear): (KHTMLView::initScrollBars): (KHTMLView::applyBodyScrollQuirk): (KHTMLView::inLayout):
• khtml/khtmlview.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
• khtml/rendering/render_form.cpp: (TextAreaWidget::TextAreaWidget):
• khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): (RenderPartObject::slotViewCleared):
• khtml/rendering/render_list.cpp: (RenderListMarker::calcMinMaxWidth):
• khtml/rendering/render_object.cpp: (RenderObject::repaint): (RenderObject::repaintRectangle):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setInPageCache):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
• kwq/KWQRenderTreeDebug.cpp: (write): (externalRepresentation):
• kwq/KWQScrollView.h:
• kwq/KWQScrollView.mm: (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]):
• kwq/WebCoreFrameView.h:

11:39 AM Changeset in webkit [5084] by hyatt

• 3 edits in trunk/WebCore

Fix for 3437260, nil deref of the render style because it hasn't been set yet.
Fallout from my incremental repainting landing.

Reviewed by darin

• khtml/rendering/render_replaced.cpp: (RenderWidget::setQWidget):

11:35 AM Changeset in webkit [5083] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

Rolled in Harri Porten's change to accept non-breaking space in JavaScript.

• kjs/lexer.cpp: (Lexer::isWhiteSpace): Accept 00A0 as "whitespace".

11:30 AM Changeset in webkit [5082] by hyatt

• 3 edits in trunk/WebCore

Fix for 3438479, tables expand on every layout when a cell has percentage height
children.

Reviewed by darin

• khtml/rendering/render_table.cpp: (RenderTableSection::calcRowHeight): (RenderTableRow::layout):

Sep 29, 2003:

4:04 PM Changeset in webkit [5081] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3332460>: nil-deref in khtml::RenderWidget::eventFilter with onchange handler

Reviewed by darin.

• kwq/KWQTextField.mm: (-[KWQTextField controlTextDidEndEditing:]): call setHasFocus:NO last so we have the widget that lets us get to the bridge and lets us call controlTextDidEndEditing

3:33 PM Changeset in webkit [5080] by hyatt

• 3 edits in trunk/WebCore

Fix for 3425053, text past the bottom of a positioned table doesn't repaint.
3426847 is the same bug. Both are fixed by ensuring that calcHeight doesn't actually
do anything other than margin computation and position determination for positioned
elements. In reality, for weird edge cases like implying the height via explicit top and
bottom properties, we'll still be wrong.

Reviewed by darin

• ChangeLog:
• khtml/rendering/render_table.cpp: (RenderTable::layout):

3:05 PM Changeset in webkit [5079] by cblu

• 5 edits in trunk/WebKit

Fixed: <rdar://problem/3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream

Reviewed by mjs.

• Plugins.subproj/WebBaseNetscapePluginStream.h: renamed receivedError to cancelWithReason
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): call cancelWithReason if NPP_NewStream returns an error (-[WebBaseNetscapePluginStream cancelWithReason:]): renamed (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call renamed cancelWithReason (-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): new override, stop load then call super (-[WebNetscapePluginStream stop]): call cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): call renamed cancelWithReason

2:10 PM Changeset in webkit [5078] by hyatt

• 1 add in trunk/LayoutTests/fast/text/whitespace/024-expected.txt

Forgot to commit expected.txt for new whitespace test.

2:10 PM Changeset in webkit [5077] by hyatt

• 2 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for abs positioned object inside relpositioned inline containing block

1:29 PM Changeset in webkit [5076] by hyatt

• 1 add in trunk/LayoutTests/fast/text/whitespace/024.html

Adding layout test for <pre> maxwidth bug.

1:27 PM Changeset in webkit [5075] by hyatt

• 4 edits in trunk/WebCore

Make sure that timeouts updateRendering after they execute the scheduled timer
action.

Also fixing 3429455, maxwidth of pres miscomputed when two blank lines occur at
the end of a pre text run.

Reviewed by darin, mjs (setTimeout fix), darin (pre fix)

• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
• khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth):

9:49 AM Changeset in webkit [5074] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed 3437292 -- Safari uses wrong characters for &and; and &or; entities

• khtml/html/kentities.gperf: Corrected values for &and; and &or; entities. Checked all the rest against a list on the W3C site, and those are the only two that were wrong.
• khtml/html/kentities.c: Regnenerated.

Sep 26, 2003:

9:44 AM Changeset in webkit [5073] by kocienda

• 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3435532>: REGRESSION: tabbing to textareas causes infinite recursion

Add recursion guards to the becomeFirstResponder method, otherwise calling
eventFilter with a FocusIn event will cause the infinite recursion
described in the bug.

• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]):

Sep 25, 2003:

9:12 PM Changeset in webkit [5072] by mjs

• 4 edits in trunk/WebCore

Reviewed by John.

• khtml/ecma/kjs_window.cpp: (Window::installTimeout): Variant that takes a function and args. (WindowFunc::tryCall): If the argument is a function, call the function variant of installTimeout instead of pointlessly passing the string. Also, correctly implement the code to pass extra args along.
• khtml/ecma/kjs_window.h:

9:08 PM Changeset in webkit [5071] by mjs

• 9 edits in trunk

Tools:

Roll out build system change since it did not actually work. :-(

• Scripts/SourceTools.pm:
• Scripts/embed-into-alex: Added.
• Scripts/embed-into-webkit: Removed.

JavaScriptCore:

Roll out build system change since it did not actually work. :-(

• JavaScriptCore.pbproj/project.pbxproj:
• Makefile.am:

WebCore:

Roll out build system change since it did not actually work. :-(

• WebCore.pbproj/project.pbxproj:

WebKit:

Roll out build system change since it did not actually work. :-(

• WebKit.pbproj/project.pbxproj:

WebBrowser:

Roll out build system change since it did not actually work. :-(

• WebBrowser.pbproj/project.pbxproj:
• add-environment.sh: Removed.
• embed-frameworks.sh: Added.

6:04 PM Changeset in webkit [5070] by hyatt

• 3 edits in trunk/LayoutTests/fast

Updating the layout tests.

5:58 PM Changeset in webkit [5069] by hyatt

• 3 edits in trunk/WebKit

Change layout so that it is called from the private _recursive functions instead of
inside drawRect.

Reviewed by kocienda

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:adjustingViewSize:]): (-[WebHTMLView drawRect:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:testDirtyRect:]): (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSView _web_setPrintingModeRecursive]): (-[NSView _web_clearPrintingModeRecursive]): (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]):

5:57 PM Changeset in webkit [5068] by hyatt

• 28 edits in trunk/WebCore

Landing the new repainting code. This code eliminates many redundant layouts, makes
layout scheduling work properly when called from WebKit, cleans up relpositioned inlines
that act as containing blocks for absolute positioned children, and eliminates the
repaint timer.

Reviewed by kocienda

• ChangeLog:
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
• khtml/khtmlview.cpp: (KHTMLView::KHTMLView):
• khtml/khtmlview.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::setPixmap): (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintIfMoved): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical):
• khtml/rendering/render_box.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::layout): (RenderCanvas::repaintViewRectangle): (RenderCanvas::getAbsoluteRepaintRect): (RenderCanvas::computeAbsoluteRepaintRect):
• khtml/rendering/render_canvas.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_flexbox.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
• khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow):
• khtml/rendering/render_layer.cpp: (RenderLayer::convertToLayerCoords):
• khtml/rendering/render_list.cpp: (RenderListMarker::setPixmap):
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout): (RenderObject::markContainingBlocksForLayout): (RenderObject::containingBlock): (RenderObject::repaint): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintIfMoved): (RenderObject::repaintPositionedAndFloatingDescendants): (RenderObject::getAbsoluteRepaintRect): (RenderObject::getAbsoluteRepaintRectIncludingDescendants): (RenderObject::computeAbsoluteRepaintRect): (RenderObject::setStyle): (RenderObject::container): (RenderObject::detach): (RenderObject::scheduleRelayout):
• khtml/rendering/render_object.h:
• khtml/rendering/render_style.cpp: (RenderStyle::diff):
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableRow::getAbsoluteRepaintRect): (RenderTableCell::computeAbsoluteRepaintRect):
• khtml/rendering/render_table.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):
• kwq/KWQRenderTreeDebug.cpp: (write): (externalRepresentation):
• kwq/KWQRenderTreeDebug.h:

3:42 PM Changeset in webkit [5067] by hyatt

• 1 edit in trunk/LayoutTests/css1/box_properties/float_elements_in_series-expected.txt

Fix the css1 failure, since we now pass the test.

3:31 PM Changeset in webkit [5066] by rjw

• 2 edits in trunk/WebKit

Fixed 3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.

Reviewed by Richard.

• Carbon.subproj/HIWebView.m: (OwningWindowChanged):

3:26 PM Changeset in webkit [5065] by rjw

• 2 edits in trunk/WebKit

Fixed 3433488. Written by Ed. WebKit doesn't sync window visibility when new webview added to visible window.

Reviewed by Richard.

• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

3:15 PM Changeset in webkit [5064] by rjw

• 2 edits in trunk/WebKit

Fixed 3434854. Written by Ed. Correctly handle window modality in carbon.

Reviewed by Richard.

• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

2003-09-25 Maciej Stachowiak <​mjs@apple.com>

2:09 PM Changeset in webkit [5063] by mjs

• 9 edits
  1 add in trunk

Tools:

Reviewed by Darin.

• Scripts/SourceTools.pm: Don't try to install Foundation on the system any more. The new build setup takes care of it.
• Scripts/embed-into-alex: Removed.
• Scripts/embed-into-webkit: Added.

JavaScriptCore:

Reviewed by Darin.

• JavaScriptCore.pbproj/project.pbxproj: Don't hack install name. Instead of embedding into Safari, embed into WebKit as sub-umbrella.
• Makefile.am: Don't forget to rebuild if the user removes JavaScript.framework from symroots manually.

WebCore:

Reviewed by Darin.

• WebCore.pbproj/project.pbxproj: Don't hack install name. Instead of embedding into Safari, embed into WebKit as sub-umbrella.

WebKit:

Reviewed by Darin.

Updated setup for engineering builds. Don't embed the framework
into Safari or hack the install name. However, do copy WebCore and
JavaScriptCore into the proper sub-umbrella locations.

• WebKit.pbproj/project.pbxproj:
• embed-frameworks.sh: Added.

WebBrowser:

Reviewed by Darin.

Changed things around for the engineering Safari build. Instead of
building frameworks embedded, set DYLD_FRAMEWORK_PATH via the
Info.plist (for engineering builds only). This also removes the
need to install engineering builds of Foundation on the system.

• WebBrowser.pbproj/project.pbxproj:
• add-environment.sh: Added.
• embed-frameworks.sh: Removed.

1:43 PM Changeset in webkit [5062] by vicki

• 3 edits in trunk

The tree is open for Safari-108!

1:40 PM Changeset in webkit [5061]

• 3 copies in tags/Safari-107

This commit was manufactured by cvs2svn to create tag 'Safari-107'.

1:40 PM Changeset in webkit [5060] by vicki

• 8 edits in trunk

Safari-107 stamp.

12:59 PM Changeset in webkit [5059] by darin

• 3 edits in trunk/WebCore

• rolled out change to fix 3390850 because it caused a performance regression

• khtml/misc/decoder.cpp: (Decoder::decode): Rolled out change.

10:06 AM Changeset in webkit [5058] by kocienda

• 4 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3341222>: WebView doesn't follow AppKit default nextKeyView pattern

• WebCoreSupport.subproj/WebBridge.h: Added a variable to guard against recursion in -[WebBridge inNextKeyViewOutsideWebFrameViews].
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge inNextKeyViewOutsideWebFrameViews]): Accessor for recursion guard. (-[WebBridge nextKeyViewOutsideWebFrameViews]): Do not ask webView for its next key view, but rather, ask it for the next key view of the last view in its key view loop. This is what will get us to the next view outside of the webView.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView nextKeyView]): Ask AppKit, rather than khtml, for the next key key view if -[WebBridge inNextKeyViewOutsideWebFrameViews] returns YES. Doing so gives us the correct answer as calculated by AppKit, and makes HTML views behave like other views. This check also heads off an infinite recursion through -[WebBridge nextKeyViewOutsideWebFrameViews].

Also did some cleanup of some code that was marked for removal "some day".
That "some day" is today.

10:00 AM Changeset in webkit [5057] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3176853 -- can't attach files that have no extensions with Yahoo mail (bad Content-Type headers)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]): Return @"application/octet-stream" rather than nil or empty string when the type is not known.

9:51 AM Changeset in webkit [5056] by kocienda

• 11 edits in trunk/WebCore

Reviewed by Dave

Name change: TextRun is now InlineTextBox. Some related names
have been changed as well. There should be no change in
behavior as a result of this patch.

• khtml/khtml_part.cpp: (KHTMLPart::selectedText): (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
• khtml/rendering/bidi.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxDecorations):
• khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::placeBoxesVertically):
• khtml/rendering/render_line.h:
• khtml/rendering/render_text.cpp: (InlineTextBox::detach): (throw): (InlineTextBox::operator delete): (InlineTextBox::paintSelection): (InlineTextBox::paintDecoration): (InlineTextBox::checkSelectionPoint): (InlineTextBoxArray::InlineTextBoxArray): (InlineTextBoxArray::compareItems): (InlineTextBoxArray::findFirstMatching): (RenderText::deleteRuns): (RenderText::findNextInlineTextBox): (RenderText::nodeAtPoint): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::cursorPos): (RenderText::posOfChar): (RenderText::paintObject): (RenderText::createInlineBox): (RenderText::position): (RenderText::width):
• khtml/rendering/render_text.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
• kwq/KWQRenderTreeDebug.cpp: (writeTextRun): (write):

7:50 AM Changeset in webkit [5055] by darin

• 2 edits
  2 adds in trunk

Added a new layout test.

• layout-tests/fast/forms/form-element-geometry-expected.txt: Added.
• layout-tests/fast/forms/form-element-geometry.html: Added.

Sep 24, 2003:

11:36 PM Changeset in webkit [5054] by darin

• 3 edits in trunk

• layout-tests/fast/table/003-expected.txt: Updated for textarea width change.

9:34 PM Changeset in webkit [5053] by darin

• 1 edit in trunk/WebKit/ChangeLog

Added marker now that the change was reviewed by Maciej.

9:28 PM Changeset in webkit [5052] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Added one more call to _stopAutoscrollTimer for when drags begin.

5:47 PM Changeset in webkit [5051] by hyatt

• 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

5:44 PM Changeset in webkit [5050] by hyatt

• 31 adds in trunk/LayoutTests/fast/clip

Adding clipping tests.

5:37 PM Changeset in webkit [5049] by hyatt

• 4 edits in trunk/WebCore

Fix for 3429646, <img src="blah"<img src="foo"> should show up as two images.

Reviewed by darin

• khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

5:09 PM Changeset in webkit [5048] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed a recent regression, and ...
• fixed 3386544 -- ARCH: <object>s don't support transclusion like <iframe>s do

• khtml/khtml_part.cpp: (KHTMLPart::childFrame): Added back a cast I should not have removed to fix the function.

5:00 PM Changeset in webkit [5047] by hyatt

• 3 edits in trunk/WebCore

Fix for 3430612, crash on about:blank in updateHoverActiveState. Just missing
a null-check. Also remove a hover optimization that was bogus.

Reviewed by darin

• khtml/rendering/render_layer.cpp: (RenderLayer::updateHoverActiveState):

4:05 PM Changeset in webkit [5046] by rjw

• 12 edits in trunk

WebKit:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906. Also 3428451 needs to should be resolved.

Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.

Reviewed by John.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
• Plugins.subproj/npapi.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (FillStyleWithAttributes):
• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): (fontsChanged): (+[WebTextRendererFactory createSharedFactory]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

WebCore:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (+[WebCoreBridge updateAllViews]):

9:37 AM Changeset in webkit [5045] by darin

• 2 edits
  2 adds in trunk

• a new test for JavaScript date parsing

• layout-tests/fast/js/date-parse-test-expected.txt: Added.
• layout-tests/fast/js/date-parse-test.html: Added.

9:37 AM Changeset in webkit [5044] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed 3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names, to allow a time zone after date even if the date omits the time, and to understand AM and PM.

8:55 AM Changeset in webkit [5043] by darin

• 7 edits in trunk/WebCore

Reviewed by Ken.

• fixed ownerElement for documents in HTML objects (helpful for some work Dave is doing)

• khtml/khtml_part.h: Change name of frame function to childFrame for clarity.
• khtml/khtml_part.cpp: (KHTMLPart::slotChildStarted): Call the frame function by its new name, childFrame. (KHTMLPart::slotChildCompleted): Ditto. (KHTMLPart::slotChildURLRequest): Ditto. (KHTMLPart::childFrame): Change name from frame to childFrame for clarity, and make it work for parts inside HTML objects, not just normal frames and iframes. The change in behavior is the actual fix. Note that for the three callers above, it's an error to call this when the result would be 0, so there's no harm in doing the extra search of HTML objects in those cases.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Call the frame function by its new name, childFrame. This is the caller that will benefit most from the change in behavior.

• kwq/KWQKHTMLPart.h: Remove childFrameForPart function, which is superseded by the childFrame function now.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrame instead of childFrameForPart.

Sep 23, 2003:

9:52 PM Changeset in webkit [5042] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3390850 -- Shift_JIS in meta tag ignored because <img> tag in JavaScript comes first (vintagecomp.com)

• khtml/misc/decoder.cpp: (Decoder::decode): Don't let tags inside a script make us think we're in the body. Later we can enhance this even more.

4:45 PM Changeset in webkit [5041] by darin

• 1 edit in trunk/WebKit/ChangeLog

Update bug number to 3127833 -- autoscroll only works when mouse is moving.

4:19 PM Changeset in webkit [5040] by darin

• 4 edits in trunk/WebKit

Reviewed by John and Richard.

• fixed 3367377 -- autoscroll only works when mouse is moving

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewDidMoveToWindow]): Stop the auto-scroll timer. This covers the case where a view is removed from the view hierarchy while the mouse is down. (-[WebHTMLView mouseDown:]): Start the auto-scroll timer. (-[WebHTMLView mouseUp:]): Stop the auto-scroll timer.
• WebView.subproj/WebHTMLViewPrivate.h: Add an auto-scroll timer, and methods to start and stop it.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _startAutoscrollTimer]): Create and schedule a timer. It uses the same 1/10 second interval that NSTextView uses for its scrolling timer. (-[WebHTMLView _stopAutoscrollTimer]): Invalidate and release the timer. (-[WebHTMLView _autoscroll]): Check for a mouse up event in the queue; if one is there, then no autoscrlling. But if not, then create a fake mouse dragged event and dispatch it; that will lead to autoscrolling.

7:47 AM Changeset in webkit [5039] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3292723 -- onBlur() getting called twice on <input type=text>

• khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter): Call setFocusNode(0) instead of explicitly sending a blur event, otherwise setFocusNode will send a second blur event later.

Sep 22, 2003:

11:34 PM Changeset in webkit [5038] by darin

• 1 edit in trunk/LayoutTests/fast/js/global/encode-URI-test.html

Fix minor coding style issue in this test; something was being
computed twice.

11:28 PM Changeset in webkit [5037] by darin

• 1 edit in trunk/WebKit/WebView.subproj/WebHTMLViewPrivate.m

Fix check-in snafu.

11:11 PM Changeset in webkit [5036] by darin

• 2 edits in trunk/WebKit

Reviewed by Dave.

• worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

• WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

11:09 PM Changeset in webkit [5035] by darin

• 2 edits in trunk/WebKit

Reviewed by Dave.

• worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

• WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

9:03 PM Changeset in webkit [5034] by darin

• 4 edits in trunk/WebCore

• fixed 3391837 -- we list ISO-8859-8-E as visual ordering for Hebrew; it's "explicit ordering", not supported

• kwq/mac-encodings.txt: Removed ISO-8859-8-E.
• kwq/KWQCharsetData.c: Regenerated.

4:29 PM Changeset in webkit [5033] by darin

• 3 edits in trunk/WebCore

• kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Made it compile.

3:09 PM Changeset in webkit [5032] by darin

• 7 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3306041 -- Airborne tracking number field too narrow, tracking doesn't work (textare col property)

• khtml/rendering/render_form.cpp: (RenderTextArea::calcMinMaxWidth): Call the QTextEdit to ask it what size, rather than trying to compute it. This is the same thing we do with other widgets, I just hadn't done textarea yet.

• kwq/KWQTextEdit.h: Added sizeWithColumnsAndRows function.
• kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Added. Calls through to the KWQTextArea object.

• kwq/KWQTextArea.h: Added sizeWithColumns:rows: method.
• kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Make consistent with other callers of the size mapping methods by using [self class] instead of NSScrollView, and getting hasHorizontalScroller and hasVerticalScroller from the view. (-[KWQTextArea setFrame:]): Make consistent with other callers of the size mapping methods by using [self class] instead of NSScrollView. (-[KWQTextArea sizeWithColumns:rows:]): Added. Starts by computing the width and height of the columns specified, using a canonical width of a "0" character. Then converts that to a container size by adding line fragment padding. Then converts that into the text view size by adding the text container inset. Then converts that into the scroll view size by calling frameSizeForContentSize:.

11:16 AM Changeset in webkit [5031] by darin

• 8 edits in trunk

top level:

• configure.in: Add "OptimizedWithSymbols" build style.

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebCore:

• WebCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebKit:

• WebKit.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

8:22 AM Changeset in webkit [5030] by darin

• 1 edit in trunk/WebKit/ChangeLog

Tweaked some old ChangeLog entries to get rid of "Reviewed by NOBODY".

8:21 AM Changeset in webkit [5029] by darin

• 6 edits
  1 delete in trunk/WebCore

Reviewed by Ken.

• research determined we were using nothing defined in config.h, so I got rid of it

• Makefile.am: Removed rules to generate config.h.
• config.h: Removed.

• WebCore.pbproj/project.pbxproj: Removed define of HAVE_CONFIG_H.

• WebCorePrefix.h: Removed include of <config.h>.

• ForwardingHeaders/config.h: Emptied this file out. Can't remove this because there are some includes of <config.h> without HAVE_CONFIG_H wrappers.

8:21 AM Changeset in webkit [5028] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• kjs/config.h: Added HAVE_SYS_PARAM_H, since KJS does look for this header, and we do indeed have it. Just something I noticed in passing while cleaning up configure.in.

Sep 21, 2003:

7:27 PM Changeset in webkit [5027] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

5:33 PM Changeset in webkit [5026] by darin

• 12 edits in trunk

WebCore:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary to find it. It's used for tool tips at the WebKit level.
• kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.

• WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
• WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the tool tip string. (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView tracking rectangle implementation so we can trick the tool tip manager into trusting us about when you leave and enter the rectangle for each element. (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff. (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip manager, and send it on. (-[WebHTMLView _sendToolTipMouseEntered]): Ditto. (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool tip manager into working even though we don't know the rectangles of the tool tips beforehand. The advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping to a nice rectangular shape and fading out when you move away. (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual tool tip text. (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the WebCoreElementTitleKey in the dictionary.

• unrelated code cleanup

• WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use a definition exported from WebCore.
• WebView.subproj/WebFramePrivate.m: Ditto.
• English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

Sep 20, 2003:

9:00 PM Changeset in webkit [5025] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)

• kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction in here was incorrect. Perhaps I should have corrected it for the non-BSD case too, but I'm not sure the issue is the same.

8:59 PM Changeset in webkit [5024] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3328481 -- selection in select element list box does not scroll into view when set programatically

• kwq/KWQListBox.mm: (QListBox::setSelected): Scroll newly-selected item into view.

8:55 PM Changeset in webkit [5023] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3429384 -- REGRESSION (89-90): nil-deref in KHTMLPart::write() (cheshiremotorcyclesalvage.com)

• khtml/khtml_part.cpp: (KHTMLPart::write): Add a nil check.

8:53 PM Changeset in webkit [5022] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• more fixes for the W3C DOM tests

• khtml/dom/dom_doc.cpp: (Document::createAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not.

• khtml/dom/dom_element.cpp: (Element::removeAttributeNode): Get the attribute name properly. The old code would always get a 0, so this function would always fail. (Element::setAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (Element::setAttributeNodeNS): Remove redundant exception checks that are also done by setNamedItem in the implementation. I had to change the implementation of one, so I decided it was better not to have any duplication.

• khtml/xml/dom_docimpl.h: Added isValidName function.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (DocumentImpl::isValidName): Added. Used to check for valid names.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem): Don't do the document check until after checking for the "replace self" case. Otherwise we raise a spurious "in use" exception. (NamedAttrMapImpl::addAttribute): Point the new attribute at the element.

Sep 19, 2003:

6:41 PM Changeset in webkit [5021]

• 6 copies
  2 deletes in branches/WebCore-106-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-106-tarball-branch'.

6:41 PM Changeset in webkit [5020]

• 6 copies
  2 deletes in tags/WebCore-106

This commit was manufactured by cvs2svn to create tag 'WebCore-106'.

6:41 PM Changeset in webkit [5019]

• 7 copies in branches/Safari-1-1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-branch'.

6:41 PM Changeset in webkit [5018]

• 7 copies in tags/Safari-1-1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-1-anchor'.

6:41 PM Changeset in webkit [5017]

• 6 copies
  1 delete in branches/SUPanBisque-branch

This commit was manufactured by cvs2svn to create branch
'SUPanBisque-branch'.

6:41 PM Changeset in webkit [5016]

• 6 copies
  1 delete in tags/SUPanBisque-anchor

This commit was manufactured by cvs2svn to create tag
'SUPanBisque-anchor'.

6:41 PM Changeset in webkit [5015]

• 7 copies in tags/MacOSX_10_3

This commit was manufactured by cvs2svn to create tag 'MacOSX_10_3'.

6:41 PM Changeset in webkit [5014] by vicki

• 2 edits in branches/WebCore-105-branch/WebCore

release markers for WebCore-106

6:30 PM Changeset in webkit [5013] by mjs

• 3 edits in branches/WebCore-105-branch/WebCore

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Don't do paint suppression for history redirects.

6:22 PM Changeset in webkit [5012] by mjs

• 8 edits in trunk

WebCore:

Reviewed by Darin.

Roll out old fix for 3410980 and do a new better fix.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.mm:
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

Roll out old fix for 3410980.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]):

4:55 PM Changeset in webkit [5011] by darin

• 10 edits in trunk

Reviewed by Dave.

• update layout tests for Dave's change

• layout-tests/apple-only/base/www.excite.com/index-expected.txt:
• layout-tests/fast/block/positioning/051-expected.txt:
• layout-tests/fast/overflow/003-expected.txt:

• fixed 3426272 -- sites that use text-shadow cause leaks (QPainter::setShadow)

• kwq/KWQPainter.mm: (QPainter::setShadow): Release the color space and color.

• fixed some errors that caused failures in the W3C DOM suite

• khtml/ecma/kjs_binding.cpp: (DOMObject::get): Put "code" in the error object. (DOMObject::put): Put "code" in the error object. (DOMFunction::get): Put "code" in the error object.

• khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall): Add checks for negative count values. Not clear whether this change is really great, but it helps us pass W3C DOM tests and clearly won't affect normal pages in any bad way.

• khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): Set m_specified to true. Since we never set up the attributes from the DTD anyway, this is fine for now. If we ever go crazy and implement that, then the bit field is sitting here waiting for us. (NamedAttrMapImpl::removeNamedItem): The comment from KHTML says they don't raise the not found exception because "the DOM 2 spec doesn't say you should". But the DOM Level 1 specification clearly does, and the W3C DOM Level 1 Core test requires it, so I'm putting it in.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Typo; this was returning the wrong error code in the "wrong document" case.

• khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::remove): Fix overflow case. (DOMStringImpl::substring): Fix overflow case.

4:28 PM Changeset in webkit [5010] by hyatt

• 1 edit in trunk/WebCore/kwq/KWQRenderTreeDebug.cpp

Fix build error.

3:54 PM Changeset in webkit [5009] by hyatt

• 24 edits in trunk/WebCore

Fix for 3401409, fix negative z-index. This code actually substantially
reworks layers to be more efficient in both painting and event handling.
It also fixes bugs with clipping as well as with negative z-indices.

Reviewed by kocienda

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::repaintRectangle):
• khtml/rendering/render_box.h:
• khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
• khtml/rendering/render_frames.h:
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::stackingContext): (RenderLayer::enclosingPositionedAncestor): (RenderLayer::transparentAncestor): (RenderLayer::addChild): (RenderLayer::removeChild): (RenderLayer::convertToLayerCoords): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintScrollbars): (RenderLayer::paint): (setClip): (restoreClip): (RenderLayer::paintLayer): (RenderLayer::nodeAtPoint): (RenderLayer::nodeAtPointForLayer): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint): (hoverAncestor): (commonAncestor): (RenderLayer::updateHoverActiveState): (sortByZOrder): (RenderLayer::dirtyZOrderLists): (RenderLayer::updateZOrderLists): (RenderLayer::collectLayers):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::document): (RenderObject::renderArena): (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h:
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::recalcStyleSelector): (DocumentImpl::setHoverNode):
• khtml/xml/dom_docimpl.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::paintSelectionOnly): (KWQKHTMLPart::adjustPageHeight):
• kwq/KWQRect.h:
• kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers): (externalRepresentation):

3:16 PM Changeset in webkit [5008] by darin

• 6 edits in trunk

Reviewed by Dave.

• layout-tests: Updated for my mini-controls change.

2:46 PM Changeset in webkit [5007] by darin

• 16 edits in trunk

WebCore:

Reviewed by Dave.

• do the prep work for the mini controls feature; Dave will finish this

• khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Tell the widget about the font size. Our widgets use the font size to decide whether to use Aqua normal, small, or mini.

• kwq/KWQButton.h: Add setFont.
• kwq/KWQButton.mm: (QButton::setFont): Set control size based on font. (KWQNSControlSizeForFont): Determine control size given a font. Dave is going to tweak this later.

• kwq/KWQCheckBox.h: Add dimensions function for metrics for each control size.
• kwq/KWQCheckBox.mm: (QCheckBox::sizeHint): Use dimensions. (QCheckBox::frameGeometry): Use dimensions. (QCheckBox::setFrameGeometry): Use dimensions. (QCheckBox::baselinePosition): Use dimensions. (QCheckBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQComboBox.h: Add setFont and dimensions.
• kwq/KWQComboBox.mm: (QComboBox::sizeHint): Use dimensions. (QComboBox::frameGeometry): Use dimensions. (QComboBox::setFrameGeometry): Use dimensions. (QComboBox::baselinePosition): Use dimensions. (QComboBox::setFont): Use dimensions. (QComboBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQFileButton.mm: (KWQFileButton::baselinePosition): Change to adapt to flipped version of file button NSControl.

• kwq/KWQPushButton.h: Add dimensions function for metrics for each control size.
• kwq/KWQPushButton.mm: (QPushButton::sizeHint): Use dimensions. (QPushButton::frameGeometry): Use dimensions. (QPushButton::setFrameGeometry): Use dimensions. (QPushButton::baselinePosition): Use dimensions. (QPushButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQRadioButton.h: Add dimensions function for metrics for each control size.
• kwq/KWQRadioButton.mm: (QRadioButton::sizeHint): Use dimensions. (QRadioButton::frameGeometry): Use dimensions. (QRadioButton::setFrameGeometry): Use dimensions. (QRadioButton::baselinePosition): Use dimensions. (QRadioButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

WebKit:

Reviewed by Dave.

• do the prep work for the mini controls feature; Dave will finish this

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton isFlipped]): Make this flipped, easier to understand coordinates that way. (-[WebFileButton drawRect:]): Update for flipped-ness. (-[WebFileButton visualFrame]): Update for flipped-ness. (-[WebFileButton setVisualFrame:]): Update for flipped-ness. (-[WebFileButton baseline]): Update for flipped-ness.

1:46 PM Changeset in webkit [5006] by mjs

• 9 edits in trunk

WebCore:

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Remove redundant check removed.
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleHistoryNavigation): Only call the base class method to actually schedule when it's possible to go back or forward that number of steps.
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward. (-[WebBridge canGoBackOrForward:]): Use the new method. (-[WebBridge goBackOrForward:]): Likewise.

Sep 18, 2003:

2:56 PM Changeset in webkit [5005] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime, mktime, timegm, and time, since they no longer have the slow "hit the filesystem every time" behavior.

8:26 AM Changeset in webkit [5004] by sullivan

• 14 edits in trunk

WebCore:

• WebCore part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• kwq/KWQKHTMLSettings.h: add _shouldPrintBackgrounds field and accessors

• kwq/WebCoreSettings.h: add shouldPrintBackgrounds field and accessors
• kwq/WebCoreSettings.mm: (-[WebCoreSettings setShouldPrintBackgrounds:]): new method, passes value to KHTMLSettings (-[WebCoreSettings shouldPrintBackgrounds]): new method

• kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): new method, returns a style sheet that has backgrounds turned off if preference is set that way. (-[WebCoreBridge reapplyStylesForDeviceType:]): if printing, set the printStyleSheet to the one we created based on the preferences. (KHTML has always had support for a special printStyleSheet, but it was only being used in !APPLE_CHANGES code.)

• khtml/rendering/render_style.h: add shouldCorrectTextColor boolean field and accessors

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): tell style to correct text colors if backgrounds aren't being printed

• khtml/rendering/render_text.cpp: (TextRun::paintSelection): added comment (simpleDifferenceBetweenColors): new function, computes a quick measure of difference between colors (correctedTextColor): if text and background colors are too similar, returns lightened or darkened text color (RenderText::paintObject): if style says to correct text colors, call correctedTextColor

WebKit:

• WebKit part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• WebView.subproj/WebPreferences.h: new accessor methods for new shouldPrintBackgrounds preference
• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): set initial value for WebKitShouldPrintBackgroundsPreferenceKey to NO (-[WebPreferences shouldPrintBackgrounds]): new method, read NSUserDefaults value (-[WebPreferences setShouldPrintBackgrounds:]): new method, write NSUserDefault value

• WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): tell WebCore about value of shouldPrintBackgrounds

• English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes

WebBrowser:

• WebBrowser part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• English.lproj/PrintingAccessoryView.nib: new nib file, contains view holding single "Print Backgrounds" checkbox

• PrintingAccessoryViewController.h: Added.
• PrintingAccessoryViewController.m: Added. (-[PrintingAccessoryViewController init]): load the nib file with self as owner (+[PrintingAccessoryViewController sharedController]): returns shared instance used by BrowserDocument (-[PrintingAccessoryViewController togglePrintBackgrounds:]): toggle the WebKit preference (which in turn updates the WebCore setting) (-[PrintingAccessoryViewController accessoryView]): returns the view from the nib that will be displayed in the print panel, after updating the checkbox state

• BrowserDocument.m: (-[BrowserDocument printWebFrameView:showingPrintPanel:]): Set up print panel's accessory view

• Preferences.subproj/AppearancePreferences.m: removed unused method I stumbled across

• WebBrowser.pbproj/project.pbxproj: updated for new files

• English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Sep 17, 2003:

5:08 PM Changeset in webkit [5003] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the "no UI" flag, so we don't prompt the user when we're trying to load plug-ins. Also use OSStatus rather than OSErr so we don't miss error codes that just happen to have zeroes in the low 16 bits.

5:05 PM Changeset in webkit [5002] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]): Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'. This can happen if JavaScript or the web page sets the path explicitly, and adding this check avoids an unpleasant warning on the console.

2:51 PM Changeset in webkit [5001] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr. Otherwise we'll get confused and drop the contents of the big buffer. (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).

Sep 16, 2003:

5:25 PM Changeset in webkit [5000]

• 1 copy
  3 deletes in tags/WebKit-106

This commit was manufactured by cvs2svn to create tag 'WebKit-106'.

5:25 PM Changeset in webkit [4999] by vicki

• 1 edit in trunk/WebKit/ChangeLog

markers for WebKit-106, and updated release notes for Safari-100

3:59 PM Changeset in webkit [4998] by rjw

• 2 edits in trunk/WebKit

Backed out fix to 3412062 to resolve 3424197.

Many sites use a technique of posting forms the same URL to generate content server side. The fix to 3412062 broke those sites.

Reviewed by Darin.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):

Sep 15, 2003:

5:20 PM Changeset in webkit [4997]

• 1 copy
  3 deletes in tags/WebKit-105

This commit was manufactured by cvs2svn to create tag 'WebKit-105'.

5:20 PM Changeset in webkit [4996]

• 3 copies
  2 deletes in branches/WebCore-105-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-105-branch'.

5:20 PM Changeset in webkit [4995]

• 3 copies
  2 deletes in tags/WebCore-105-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-105-anchor'.

5:20 PM Changeset in webkit [4994]

• 3 copies
  2 deletes in tags/WebCore-105

This commit was manufactured by cvs2svn to create tag 'WebCore-105'.

5:20 PM Changeset in webkit [4993] by vicki

• 3 edits in trunk

updated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105

3:32 PM Changeset in webkit [4992] by darin

• 3 edits in trunk/WebCore

Reviewed by Darin and Don.

• fixed 3419957 -- REGRESSION: lines drawn across multiple columns at washingtonpost.com

• khtml/rendering/render_box.cpp: (RenderBox::calcWidth): Always use the width of the line rather than the width of the containing block for "flow around floats" blocks (<hr>). This undoes half of the change made to fix bug 3384609.

10:23 AM Changeset in webkit [4991] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken and Don.

• fixed 3417604 -- REGRESSION: dragging scroll thumb causes textarea contents to vanish

• kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Deallocated cached graphics state for the text view as well as for the clip view.

8:44 AM Changeset in webkit [4990]

• 5 copies
  2 deletes in tags/WebCore-104

This commit was manufactured by cvs2svn to create tag 'WebCore-104'.

8:44 AM Changeset in webkit [4989] by vicki

• 2 edits in trunk/WebCore

marker for WebCore-104