Context Navigation

← Previous Period
Next Period →

Timeline

Nov 15, 2003:

10:22 PM Changeset in webkit [5507] by hyatt

4 edits in trunk/WebCore

Fix for 3485260, regression on Uniview site from incremental repainting. When appending/inserting child
nodes into the render tree, we need to always mark them as needing layout themselves (and not just as
having children needing layout). This ensures that the incremental repainting code will know to repaint the
enclosing container (even though that container's size may not change).

Fix for 3411960, block-level replaced elements should avoid floats.

Fix for 3463234, floats should not intrude into overflow blocks (even when siblings happen to get in
between the float and the overflow block).

Fix for 3485576, the containing block for text runs is incorrect.

Fix for 3485577, text runs should not trigger layout when style is re-resolved.

Reviewed by darin

khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
khtml/rendering/render_box.cpp
khtml/rendering/render_object.cpp

9:53 PM Changeset in webkit [5506] by mjs

2 edits in branches/SUPanBisque-branch/WebCore

Reviewed by Darin.

initialize modifier key fields, needed to make the recent merged fixes work well

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): Always initialize, don't only set to true.

9:42 PM Changeset in webkit [5505] by mjs

18 edits in branches/SUPanBisque-branch/WebCore

merged the following fixes from HEAD

2003-11-13 Darin Adler <Darin Adler>

Reviewed by Ken.

fixed 3452554 -- keyCode attribute for DOM events reports incorrect value

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Return the Windows key code for keydown and keyup events. But for other events, return the character code. This matches IE. (UIEvent::which): Same behavior for now; may need further refinement.

kwq/KWQEvent.h: Change QEvent to allow copying. The Qt version probably doesn't allow it, but for us it's no big deal. Our event objects are just data holders. (QKeyEvent::QKeyEvent): Change parameters; take an NSEvent and figure the rest out here. Except for now get the type, button state, and auto repeat flag from the caller because that's a smaller change from how things are done now. I'll take this the next step later.
kwq/KWQEvent.mm: (characterCode): Added. Extracts the character code from the string if it's exactly 1 character long. (WindowsKeyCode): Added. Given an event, figures out the Windows key code. (QKeyEvent::QKeyEvent): Changed to get things from the NSEvent rather than having them passed individually. One change is that _ascii is now the Unicode value of the first character in the string. This causes us to return the Unicode value from keyCode for keypress events. Another change is that we now compute the Windows key code.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Change to use the new QKeyEvent constructor, passing in the NSEvent.

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): In APPLE_CHANGES, copy the QKeyEvent using the copy constructor rather than listing the fields. This is easier to maintain when the list of fields changes.

khtml/rendering/render_form.cpp: (ComboBoxWidget::eventFilter): Put #if !APPLE_CHANGES around code that constructs a QKeyEvent. We don't ever run this code, but now we can't compile it either so we need the #if.

2003-11-12 Ken Kocienda <kocienda@apple.com>

Reviewed by Richard

Fix for this bug:

<rdar://problem/3481600>: key event objects do not preserve unmodified keys

khtml/xml/dom2_eventsimpl.cpp: Modified constructor call to include unmodifiedText. (KeyboardEventImpl::KeyboardEventImpl):
kwq/KWQEvent.h: Added unmodifiedText accessor and variable to QKeyEvent.
kwq/KWQEvent.mm: (QKeyEvent::QKeyEvent): Modified constructor to include unmodifiedText. (QKeyEvent::unmodifiedText): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Modified constructor call to include unmodifiedText.

2003-11-05 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed 3475109 -- support keyboard event object properties of altkey, ctrlKey, shiftKey

We had the DOM Level 3 KeyboardEvent class already; I just had to add JavaScript bindings.

khtml/ecma/kjs_events.h: Added DOMKeyboardEvent class.
khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added code to make a DOMKeyboardEvent if the event is a DOM::KeyboardEvent. (DOMKeyboardEvent::~DOMKeyboardEvent): Added. (DOMKeyboardEvent::classInfo): Added. (DOMKeyboardEvent::tryGet): Added. (DOMKeyboardEvent::getValueProperty): Added. (DOMKeyboardEventProtoFunc::tryCall): Added.

khtml/dom/dom2_events.cpp: (KeyboardEvent::keyIdentifier): Added. (KeyboardEvent::keyLocation): Added.

khtml/ecma/kjs_events.lut.h: Regenerated.

2003-10-20 Ken Kocienda <kocienda@apple.com>

Reviewed by David

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Change over to use ascii value for key code. (UIEvent::which): Ditto. (KeyboardEvent::KeyboardEvent): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEvent::operator = ): New function. (KeyboardEvent::~KeyboardEvent): New function. (KeyboardEvent::ctrlKey): New function. (KeyboardEvent::shiftKey): New function. (KeyboardEvent::altKey): New function. (KeyboardEvent::metaKey): New function. (KeyboardEvent::altGraphKey): New function. (KeyboardEvent::initKeyboardEvent): New function.
khtml/dom/dom2_events.h: Ditto.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Use key identifiers to test which key was pressed, instead of removed keyVal(). (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new class name. Use key identifiers to test which key was pressed, instead of removed keyVal(). Use new modifier accessors.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (EventImpl::idToType): Ditto. (KeyboardEventImpl::KeyboardEventImpl): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEventImpl::~KeyboardEventImpl): Ditto. (KeyboardEventImpl::initKeyboardEvent): Ditto.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (DOM::KeyboardEventImpl::keyIdentifier): New function. (DOM::KeyboardEventImpl::keyLocation): New function. (DOM::KeyboardEventImpl::ctrlKey): New function. (DOM::KeyboardEventImpl::shiftKey): New function. (DOM::KeyboardEventImpl::altKey): New function. (DOM::KeyboardEventImpl::metaKey): New function. (DOM::KeyboardEventImpl::altGraphKey): New function. (DOM::KeyboardEventImpl::qKeyEvent): New function.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Now can create keyboard events.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Class name changes.
kwq/KWQEvent.h: Added QString identifier member.
kwq/KWQEvent.mm: (hexDigit): Added helper. (identifierForKeyText): Added new function to map keys to DOM key identifiers as listed in the DOM spec. (QKeyEvent::identifier): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::stateForCurrentEvent): Added check to see if a key press is on one of the numeric keypad keys.
kwq/KWQLogging.h: Added log constant for DOM events.
kwq/KWQLogging.m: Ditto

Nov 14, 2003:

8:53 PM Changeset in webkit [5504] by hyatt

2 edits in trunk/WebCore

Fix for 3473707, 100% height positioned divs are too tall. The padding box wasn't being used like it was
supposed to be when calcing percentage heights.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):

4:46 PM Changeset in webkit [5503] by sullivan

3 edits in trunk/WebKit

WebKit:

WebKit part of fix for <rdar://problem/3474757>: Safari on-screen text needs review

Reviewed by Ken.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): change "Download Link to Disk" to "Download Linked File to Disk"

English.lproj/Localizable.strings: updated for these changes

WebBrowser:

WebBrowser part of fix for <rdar://problem/3474757>: Safari on-screen text needs review

Reviewed by Ken.

Many text changes. In a small number of places I got to delete stuff, but
mostly I just changed the words to match Ron's edit (after much discussion).

ABHomePagesController.m: (-[ABHomePagesController openAddressBook:]):
AppController.m: (-[AppController confirmSwitchDefaultBrowser]): (-[AppController _showResourceFileWithName:extension:]):
BookmarksController.m: (-[BookmarksController tellUserAboutExceptionInFileLockingCode]): (-[BookmarksController tellUserThatISyncWon]): (-[BookmarksController tellUserThatExternalChangePreemptedLocalChange]): (-[BookmarksController exportBookmarks:]):
BrowserDocument.m: (-[BrowserDocument panel:userEnteredFilename:confirmed:]):
BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
BrowserWebController.m: (-[BrowserWebView mouseoverTextForElement:modifierFlags:]): (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebView openFileExternallyWithRequest:inFrame:]): (-[BrowserWebView revealInFinderWithRequest:inFrame:]): (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): (-[BrowserWebView displayName]):
BrowserWindowController.m: (-[BrowserWindowController setUpSearchField]): (-[BrowserWindowController goToToolbarLocationWithWindowPolicy:]):
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]):
DownloadRow.m: (-[DownloadRow _statusText]): (-[DownloadRow open:]):
DownloadViewController.m: (-[DownloadViewController _openEntries:]): (-[DownloadViewController _revealEntries:]):
DownloadWindowController.m: (-[DownloadWindowController windowDidLoad]): (-[DownloadWindowController askToTerminateWhileDownloading]): (-[DownloadWindowController reportInvalidDownloadFileErrorForPath:]):
FavoriteButton.m: (-[FavoriteButton setBookmark:]): (-[FavoriteButton confirmDeletingFolder]):
FavoritesBar.m: (-[FavoritesBar initWithView:]):
FormCompletionController.m: (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController autoFillInWebView:]):
LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): (-[LoadProgressMonitor _statusSummary]): (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler genericTitleForError:]): (-[LocationChangeHandler genericMessageForError:]):
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
Preferences.subproj/AutoFillPreferences.m: (-[AutoFillPreferences editMyCard:]):
Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences configureSynchronizing:]):
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaScriptCanOpenWindows:]):
RendezvousController.m: (-[RendezvousController reportErrorForServiceName:]):
TabBarView.m: (-[TabBarView initWithFrame:]):
main.m: (storeVersionInPreferences): Changed or removed words.

English.lproj/Localizable.strings: updated for these changes

3:29 PM Changeset in webkit [5502] by kocienda

5 edits
2 adds in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3481701>: Crashes before loading page/no error msg
(forums.pelicanparts.com) Works in IE and Netscape

This fix is really a workaround for this bug:

<rdar://problem/3484937>: Horribly malformed URL crashes when call
is made to CFURLCopyHostName

The fix is to avoid all usages of [NSURL host] by replacing all
such calls with a private URL method added to WebNSURLExtras.

I copied a number of URL methods from the private NSURL
extras file in Foundation to the WebKit URL extras file.

Misc.subproj/WebNSDataExtras.h: Added. Helper for new URL extras.
Misc.subproj/WebNSDataExtras.m: Ditto. (-[NSData _web_isCaseInsensitiveEqualToCString:]): New helper.
Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_hasQuestionMarkOnlyQueryString]): Added. (-[NSURL _web_schemeSeparatorWithoutColon]): Added. (-[NSURL _web_dataForURLComponentType:]): Added. (-[NSURL _web_schemeData]): Added. (-[NSURL _web_hostData]): Added. (-[NSURL _web_hostString]): Added.
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebView.m: (-[WebView userAgentForURL:]): Replace call to [NSURL host] with new extras _web_hostString method.

12:21 PM Changeset in webkit [5501] by vicki

3 edits in trunk

tree is open for Safari-115

12:13 PM Changeset in webkit [5500]

3 copies in tags/Safari-114

This commit was manufactured by cvs2svn to create tag 'Safari-114'.

12:13 PM Changeset in webkit [5499] by vicki

6 edits in trunk

Safari-114 stamp

12:05 PM Changeset in webkit [5498] by vicki

8 edits in trunk/WebKit

rolled out Darin's fixes for 3457162 and 3160035, since these changes broke plugins on macromedia.com and disney.go.com

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]):
WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]):
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient loadWithRequest:]): (-[WebMainResourceClient setDefersCallbacks:]):

11:38 AM Changeset in webkit [5497] by mjs

4 edits in trunk/WebCore

backed out changes unintentionally commited while the tree was closed

khtml/css/css_valueimpl.cpp:
khtml/css/css_valueimpl.h:
kwq/KWQKPartsBrowserInterface.mm:

11:29 AM Changeset in webkit [5496] by mjs

4 edits in trunk/WebCore

Reviewed by Ken.

fixed 3471925 - getting and setting cssText not implemented

khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::cssText): Implemented by gathering text of all properties, separated with semicolons. (CSSStyleDeclarationImpl::setCssText): Implemented by clearing all existing properties and invoking css parser. (CSSValueListImpl::cssText): Implemented. (FontValueImpl::cssText): Implemented. (ShadowValueImpl::cssText): Implemented. (CSSProperty::cssText): Implemented.
khtml/css/css_valueimpl.h: Declared new methods; made CSSValueImpl::cssText() pure virtual; removed CSSValueImpl::setCssText().

9:47 AM Changeset in webkit [5495] by darin

8 edits in trunk/WebKit

Reviewed by John.

fixes 3457162 -- selecting text during a page load that blows the text field away causes a crash
fixes 3160035 -- crash or hang if you hold down a button while "go to about:blank soon" test runs

The WebKit part of this fix is making setDefersCallbacks: work. It had succumbed to bit rot.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]): Set the defersCallbacks state from the WebView here so that clients don't have to do it.
WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]): Remove call to set the defersCallbacks state on the subresource client, because the above change obviates it. (the client/delegate terminology makes it confusing, but it's a subclass).

WebView.subproj/WebMainResourceClient.h: Added an _initialRequest field so we can defer the very first callback, which does not rely on NSURLConnection.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): Release the initial request. (-[WebMainResourceClient loadWithRequestNow:]): Moved the guts of loadWithRequest in here; to be used when the request is no longer deferred. Also removed the code to call setDefersCallbacks: on the connection, and assert that we are only called when callbacks are not deferred. Because the very first callback was not deferred, we would end up calling setDefersCallbacks:NO on the WebView, so nothing would be deferred. (-[WebMainResourceClient loadWithRequest:]): If callbacks are not deferred, then call the loadWithRequestNow: method, otherwise simply store the request in _initialRequest. (-[WebMainResourceClient setDefersCallbacks:]): If there is an _initialRequest and we are ceasing deferral of callbacks, then call the loadWithRequestNow: method.

9:30 AM Changeset in webkit [5494] by darin

3 edits in trunk/WebCore

Reviewed by John.

first half of fix for 3457162 -- selecting text during a page load that blows the text field away causes a crash

The WebCore part of this fix is to generalize the "defers loading" feature to all mouse clicks,
rather than just doing it for mouse clicks on the combo box.

kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Remove code to defer loading.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Put the code here instead.

9:12 AM Changeset in webkit [5493]

1 copy
327 deletes in branches/unlabeled-1.55.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.55.4'.

9:12 AM Changeset in webkit [5492] by sullivan

5 edits in trunk/WebCore

fixed <rdar://problem/3483585>: Option-tab in a text field inputs a character rather than tabbing to the next widget

Reviewed by Ken.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::handleKeyboardOptionTabInView): New method. If current event is option-tab or option-shift-tab, do keyboard navigation and return YES.

kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): Bail out if KWQKHTMLPart::handleKeyboardOptionTabInView returns YES.

kwq/KWQTextField.mm: (-[KWQTextField controlTextDidChange:]): Bail out if KWQKHTMLPart::handleKeyboardOptionTabInView returns YES.

12:09 AM Changeset in webkit [5491] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3472875 -- REGRESSION (109-110): insertion point does not blink in a nonempty textarea
fixed 3484002 -- disabling, then enabling a read-only <textarea> will make it editable

kwq/KWQTextArea.mm: (-[KWQTextArea setText:]): Call updateTextColor after setting the text. (-[KWQTextArea setEditable:]): Don't set the NSTextView editable property directly, because we don't want to make a disabled text view editable right away, but we need to later if it's enabled. (-[KWQTextArea isEditable]): Don't get the NSTextView editable property directly, because it can be appropriate to return YES even if the text view happens to be disabled. (-[KWQTextAreaTextView initWithFrame:textContainer:]): Initialize editableIfEnabled to YES. (-[KWQTextAreaTextView setEnabled:]): Don't set the editable state to true if editableIfEnabled is NO. The old code would make a read-only field editable if you changed it to be enabled. Also update the color of the text here. (-[KWQTextAreaTextView setEditableIfEnabled:]): Store the editableIfEnabled state in a field, and then alter the state of the editable flag to match if we're currently enabled. (-[KWQTextAreaTextView isEditableIfEnabled]): Return the editableIfEnabled state. (-[KWQTextAreaTextView updateTextColor]): Update the color of the text. This was done in drawRect: before, which was the cause of the lack of insertion point.

Nov 13, 2003:

10:15 PM Changeset in webkit [5490] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3474330 -- tooltips do not work for <area> elements

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): When looking for a title, start with innerNode (which can be an <area> inside a <map>). This matches what Mozilla does.

9:05 PM Changeset in webkit [5489] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed - 3479285 - hang at www.saccourt.com
fixed - 3477088 - (85-112) Safari frozen loading a page at Postal Service site of Taiwan

khtml/ecma/kjs_html.cpp: (KJS::HTMLSelectCollection::tryPut): Use the range-checking version of the number-conversion function to avoid negative numbers and NaN.

6:29 PM Changeset in webkit [5488]

1 copy in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore/bindings

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-Merlot-BuildFixes-branch'.

6:29 PM Changeset in webkit [5487]

15 copies in tags/Safari-1-1-Merlot-BuildFixes-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-1-Merlot-BuildFixes-anchor'.

6:29 PM Changeset in webkit [5486] by rjw

3 edits in trunk/JavaScriptCore

Factored common code between copy constructor and assignment operator.

Reviewed by Chris.

ChangeLog:
bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::_commonCopy): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaField::type):
bindings/runtime.h:

6:17 PM Changeset in webkit [5485] by rjw

5 edits
3 adds
3 deletes in trunk/JavaScriptCore

JavaScriptCore:

More LiveConnect stuff. This checkin adds abstract classes to model
language runtimes and a JNI based set of concrete implementations for
Java.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/Makefile.am: Removed.
bindings/jni/Makefile.am: Removed.
bindings/jni/jni_runtime.cpp: Added. (JavaField::JavaField): (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod): (JavaClass::JavaClass):
bindings/jni/jni_runtime.h: Added. (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::~JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaConstructor::parameterAt): (Bindings::JavaConstructor::numParameters): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::~JavaMethod): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::operator=): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType): (Bindings::JavaMethod::parameterAt): (Bindings::JavaMethod::numParameters): (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::~JavaClass): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::JavaClass): (Bindings::JavaClass::operator=): (Bindings::JavaClass::name): (Bindings::JavaClass::methodAt): (Bindings::JavaClass::numMethods): (Bindings::JavaClass::constructorAt): (Bindings::JavaClass::numConstructors): (Bindings::JavaClass::fieldAt): (Bindings::JavaClass::numFields):
bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodA): (callJNIObjectMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod): (callJNIVoidMethodA): (callJNIObjectMethodA): (callJNIByteMethodA): (callJNICharMethodA): (callJNIShortMethodA): (callJNIIntMethodA): (callJNILongMethodA): (callJNIFloatMethodA): (callJNIDoubleMethodA): (getCharactersFromJString): (releaseCharactersForJString):
bindings/jni/jni_utility.h:
bindings/objc/Makefile.am: Removed.
bindings/runtime.h: Added. (Bindings::Parameter::~Parameter): (Bindings::Constructor::~Constructor): (Bindings::Field::~Field): (Bindings::Method::~Method): (Bindings::Class::~Class):

Tests:

More tweaks to test new LiveConnect stuff.

DumpJava/main.cpp: (dumpClass):

4:34 PM Changeset in webkit [5484]

1 copy
327 deletes in branches/unlabeled-1.21.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.21.4'.

4:34 PM Changeset in webkit [5483] by kocienda

10 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

In addition to fixing the bug, I also did a bit of cleanup
in the code which helps to determine tab order.

Biggest change is to modify the keyboard UI mode function so
that it is a set of flags, rather than a straight-up value.

I also tweaked the names on the keyboard UI mode constants
to make them read better.

kwq/KWQButton.mm: (QButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Ditto. Plus, this function was not blocking exceptions.
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now checks new tabsToLinks function to determine if links can be tabbed to. (KWQKHTMLPart::currentEventIsKeyboardOptionTab): New function checks for option-tab keyboard event. (KWQKHTMLPart::tabsToLinks): New helper to take keyboard UI mode and option-tab into account. (KWQKHTMLPart::keyboardUIMode): Name tweak.
kwq/KWQListBox.mm: Tweaks to make more readable and use new model for keyboard UI mode. (QListBox::focusPolicy):
kwq/WebCoreKeyboardAccess.h: Tweaked names. Added WebCoreKeyboardAccessTabsToLinks.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove self from notification center. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Now checks for WebCoreKeyboardAccessTabsToLinks preference. (-[WebBridge keyboardUIMode]): Adds self to notification center to pick up changes to WebPreferences.

4:15 PM Changeset in webkit [5482] by vicki

2 edits in branches/SUPanBisque-branch/WebCore

roll the KWQKHTMLPart.mm change from this fix onto the branch; this is the WebCore part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto

4:06 PM Changeset in webkit [5481] by vicki

2 edits in branches/SUPanBisque-branch/WebKit

roll the WebHTMLView.m change from this fix onto the branch; this is the WebKit part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.

2:53 PM Changeset in webkit [5480] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3472562 - Null or Undefined variables passed to IN operator cause javascript exceptions

kjs/nodes.cpp: (ForInNode::execute): If the in value is null or undefined, bail out early, since attempting to iterate its properties will throw an exception.

1:37 PM Changeset in webkit [5479] by kocienda

3 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3481719>: WebKit needs preference for tabbing to links

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Add initialization of new WebKitTabToLinksPreferenceKey. (-[WebPreferences setTabsToLinks:]): Added preference setter. (-[WebPreferences tabsToLinks]): Added preference getter.
WebView.subproj/WebPreferencesPrivate.h: Declared new methods as SPI on WebPreferences.

12:13 PM Changeset in webkit [5478] by hyatt

10 edits in trunk/WebCore

Implement a custom unfurl marquee style.

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_box.cpp: (RenderBox::calcHeight):
khtml/rendering/render_layer.cpp: (m_direction): (Marquee::isUnfurlMarquee): (Marquee::start): (Marquee::updateMarqueePosition): (Marquee::updateMarqueeStyle): (Marquee::timerEvent):
khtml/rendering/render_layer.h: (khtml::):
khtml/rendering/render_style.h: (khtml::):

11:42 AM Changeset in webkit [5477] by kocienda

8 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3480761>: event object type attribute returns
khtml_keypress instead of keypress

Fixed string so that it returns keypress instead of khtml_keypress.
While I was at it, I changed the constant used for this event from
KHTML_KEYPRESS_EVENT to KEYPRESS_EVENT.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Constant name fixup.
khtml/ecma/kjs_dom.cpp: Ditto. (DOMNode::getValueProperty): Ditto. (DOMNode::putValue): Ditto.
khtml/ecma/kjs_window.cpp: (Window::get): Ditto. (Window::put): Ditto.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Ditto.
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::idToType): This is the change that fixes the bug. (KeyboardEventImpl::KeyboardEventImpl): Constant name fixup.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Ditto.

9:39 AM Changeset in webkit [5476] by darin

7 edits in trunk/WebCore

Reviewed by Ken.

fixed 3452554 -- keyCode attribute for DOM events reports incorrect value

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Return the Windows key code for keydown and keyup events. But for other events, return the character code. This matches IE. (UIEvent::which): Same behavior for now; may need further refinement.

kwq/KWQEvent.h: Change QEvent to allow copying. The Qt version probably doesn't allow it, but for us it's no big deal. Our event objects are just data holders. (QKeyEvent::QKeyEvent): Change parameters; take an NSEvent and figure the rest out here. Except for now get the type, button state, and auto repeat flag from the caller because that's a smaller change from how things are done now. I'll take this the next step later.
kwq/KWQEvent.mm: (characterCode): Added. Extracts the character code from the string if it's exactly 1 character long. (WindowsKeyCode): Added. Given an event, figures out the Windows key code. (QKeyEvent::QKeyEvent): Changed to get things from the NSEvent rather than having them passed individually. One change is that _ascii is now the Unicode value of the first character in the string. This causes us to return the Unicode value from keyCode for keypress events. Another change is that we now compute the Windows key code.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Change to use the new QKeyEvent constructor, passing in the NSEvent.

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): In APPLE_CHANGES, copy the QKeyEvent using the copy constructor rather than listing the fields. This is easier to maintain when the list of fields changes.

khtml/rendering/render_form.cpp: (ComboBoxWidget::eventFilter): Put #if !APPLE_CHANGES around code that constructs a QKeyEvent. We don't ever run this code, but now we can't compile it either so we need the #if.

Nov 12, 2003:

8:33 PM Changeset in webkit [5475] by darin

2 edits in trunk/JavaScriptCore

fixed the build

Makefile.am: Fix the build by removing the bindings directory from SUBDIRS. Later, we can either add this back and add the Makefile.am files to the top level configure.in or leave it out and remove the Makefile.am files.

6:04 PM Changeset in webkit [5474] by rjw

2 edits in trunk/WebKit

Fixed 3475082. Remove unnecessary orderKey before showKey.

Written by Ed Voas.

Reviewed by Richard.

Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter makeKeyWindow]):

5:56 PM Changeset in webkit [5473] by rjw

3 edits
8 adds in trunk/JavaScriptCore

Added utility functions for calling JNI methods.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/Makefile.am: Added.
bindings/jni/Makefile.am: Added.
bindings/jni/jni_utility.cpp: Added. (attachToJavaVM): (callJNIMethod): (callJNIVoidMethod): (callJNIObjectMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod):
bindings/jni/jni_utility.h: Added.
bindings/objc/Makefile.am: Added.

4:19 PM Changeset in webkit [5472] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3482147>: replace _releaseFutureIconForURL assertion with a log statement

Reviewed by rjw.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _releaseFutureIconForURL:]):

3:37 PM Changeset in webkit [5471]

1 copy
41 deletes in branches/unlabeled-1.30.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.30.4'.

3:37 PM Changeset in webkit [5470] by hyatt

7 edits in trunk/WebCore

Fix for 3482132, incremental repainting for layout, i.e., only repaint areas that change when
doing a layout.

Reviewed by kocienda

khtml/khtmlview.h:
khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout):
khtml/rendering/render_object.h:
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

12:08 PM Changeset in webkit [5469] by kocienda

3 edits in trunk/WebCore

Reviewed by me

I am an idiot for just assuming that these elements implement a focus()
function, without actually compiling and testing. I will have to add
this function to these elements so I can make this work.

khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::accessKeyAction): These elements do not implement focus().
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::accessKeyAction): Ditto.

12:05 PM Changeset in webkit [5468] by kocienda

8 edits in trunk/WebCore

Reviewed by Richard

khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::click): Implemented. Missed this in my earlier patch. (HTMLButtonElementImpl::accessKeyAction): Added. Focus and click. (HTMLInputElementImpl::accessKeyAction): Added. Focus the element. (HTMLSelectElementImpl::accessKeyAction): Added. Focus the element. (HTMLTextAreaElementImpl::accessKeyAction): Added. Focus the element.
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::accessKeyAction): Added. Focus and click.
khtml/html/html_inlineimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::addElementById): Dirty the accesskey dictionary. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Function to look up an element based on the key provided. (DocumentImpl::setDocumentChanged): Dirty the accesskey dictionary. (DocumentImpl::defaultEventHandler): Check the accesskey dictionary to see if some element wants to handle a key event.
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::accessKeyAction): Added. Send a click to the element.

10:04 AM Changeset in webkit [5467] by vicki

2 edits in branches/SUPanBisque-branch/WebCore

apply the WebCore part of the fix for 3478904 to the SUPanBisque branch

2003-11-06 Richard Williamson <rjw@apple.com>

Fixed 3476563. Remove unnecessary call to set view position after load

completes.

Reviewed by Gramps.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):

10:04 AM Changeset in webkit [5466] by vicki

4 edits in branches/SUPanBisque-branch/WebKit

apply this fix to the SUPanBisque branch

2003-11-06 Richard Williamson <rjw@apple.com>

Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.

Reviewed by Ken.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_scrollPointToVisible:fromView:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]):

9:32 AM Changeset in webkit [5465] by kocienda

5 edits in trunk/WebCore

Reviewed by Richard

Fix for this bug:

<rdar://problem/3481600>: key event objects do not preserve unmodified keys

khtml/xml/dom2_eventsimpl.cpp: Modified constructor call to include unmodifiedText. (KeyboardEventImpl::KeyboardEventImpl):
kwq/KWQEvent.h: Added unmodifiedText accessor and variable to QKeyEvent.
kwq/KWQEvent.mm: (QKeyEvent::QKeyEvent): Modified constructor to include unmodifiedText. (QKeyEvent::unmodifiedText): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Modified constructor call to include unmodifiedText.

8:49 AM Changeset in webkit [5464] by kocienda

7 edits in trunk/WebCore

Reviewed by Maciej

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): Implemented a programmatic click function for elements.
khtml/html/html_elementimpl.h:
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submitClick): Implemented a programmatic click function for elements. (HTMLInputElementImpl::click): This implementation calls through to Cocoa button programmatic click function to get user interface feedback for button elements, and calls through to the superclass for other elements.
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: Removed click() function for anchors. No longer needed.
khtml/html/html_inlineimpl.h: Ditto.

1:20 AM Changeset in webkit [5463] by hyatt

2 edits in trunk/WebCore

Fix build bustage in deployment builds.

12:48 AM Changeset in webkit [5462]

1 copy
93 deletes in branches/unlabeled-1.37.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.37.4'.

12:48 AM Changeset in webkit [5461] by hyatt

20 edits in trunk

Fix for 3481134, shorthand parsing in CSS does not fill in omitted values. The fix is to implement
the CSS3 'initial' value for all properties (covered by 3481323), and then to fill in the omitted
values with the 'initial' value.

This patch also fixes two bugs in the style system: 3481324, collapsed borders with border-style: none
should always return a width of 0, and 3481322, 'clip' not inheriting properly in CSS when explicit
inheritance is used.

Reviewed by mjs

khtml/css/css_valueimpl.cpp: (CSSInitialValueImpl::cssText):
khtml/css/css_valueimpl.h: (DOM::CSSInitialValueImpl::cssValueType):
khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseShortHand):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/dom/css_value.h: (DOM::CSSValue::):
khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleMarqueeData::StyleMarqueeData): (StyleFlexibleBoxData::StyleFlexibleBoxData): (opacity): (StyleInheritedData::StyleInheritedData): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::CollapsedBorderValue::width): (khtml::RenderStyle::InheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::resetBorderTop): (khtml::RenderStyle::resetBorderRight): (khtml::RenderStyle::resetBorderBottom): (khtml::RenderStyle::resetBorderLeft): (khtml::RenderStyle::resetOutline): (khtml::RenderStyle::setHasClip): (khtml::RenderStyle::resetMargin): (khtml::RenderStyle::resetPadding): (khtml::RenderStyle::setCursor):

Nov 11, 2003:

8:15 PM Changeset in webkit [5460] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebKit

rolled this fix onto the branch

2003-10-16 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content

Reviewed by rjw.

Misc.subproj/WebDownload.m: fixed build failure when using new Foundation. We are overriding and calling a renamed method. Continue to override the old method, override the new method and declare their interfaces to avoid build failures.

5:30 PM Changeset in webkit [5459] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3479537 - reproducible crash in KJS::WindowFunc::tryCall

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check part and doc impl for null.

3:16 PM Changeset in webkit [5458] by mjs

2 edits in trunk/WebCore

Reviewed by Ken.

fixed 3472330 - REGRESSION: onKeyPress handler not called when hitting keys in <input type=password> field

kwq/KWQTextField.mm: (-[KWQSecureTextField initWithQLineEdit:]): New initializer, so the secure text field knows about the widget. (-[KWQTextField setPasswordMode:]): Use new initializer for KWQSecureTextField. (-[KWQSecureTextField textView:shouldHandleEvent:]): New method, do the same thing as the non-secure text field to pass the event on. (-[KWQSecureTextField textView:didHandleEvent:]): Ditto.

1:58 PM Changeset in webkit [5457] by kocienda

8 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3480173>: Too many names for programmatic click functions

Changed all instances of performClick() and simulateClick() to click().
Changed all instances of performSubmitClick() to submitClick().

Additionally, KWQButton had a simulateClick method, which was redundant
given that its superclass has a performClick: method.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submitClick): (HTMLInputElementImpl::defaultEventHandler): (HTMLSelectElementImpl::defaultEventHandler):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): (HTMLAnchorElementImpl::click):
khtml/html/html_inlineimpl.h:
khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed):
kwq/KWQButton.h:
kwq/KWQButton.mm: (QButton::click):

1:51 PM Changeset in webkit [5456] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3475272 - custom property on CSSStyleObject won't hold a value

khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::tryPut): If the property is not a css property, save it as a custom object property in the normal way.

1:06 PM Changeset in webkit [5455] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3480421>: Focus rings around links are too thick, should use 3 px instead of 5 px

Reviewed by Don and Ken.

khtml/css/html4.css: use 3px instead of 5 px for :active, :focus

12:59 PM Changeset in webkit [5454] by kocienda

9 edits in trunk/WebCore

Reviewed by John

In the DOM Level 3 Events specification, keydown and keyup are
standard events. We can remove the KHTML component in the names
of these constants. Note that the keypress event is still
nonstandard and will retain the KHTML name component.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture)
khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty) (DOMNode::putValue)
khtml/ecma/kjs_window.cpp: (Window::get) (Window::put)
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute)
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler)
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler)
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId) (EventImpl::idToType) (KeyboardEventImpl::KeyboardEventImpl)
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::)

11:30 AM Changeset in webkit [5453] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3480281>: drag image of selected text and images include broken images

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::paintObject): when drawing the drag image, don't draw the broken image

10:34 AM Changeset in webkit [5452] by vicki

2 edits in trunk/WebCore

Reviewed by sullivan.

rolled Merlot build fix onto the trunk

WebCorePrefix.h: added #include <sys/types.h>

Nov 10, 2003:

5:12 PM Changeset in webkit [5451] by hyatt

2 edits in trunk/WebCore

Fix for 3473531, text nested in hr inside h3 did not get the h3's style.

Reviewed by darin

khtml/html/dtd.cpp: (DOM::checkChild):

5:03 PM Changeset in webkit [5450] by hyatt

110 edits in trunk

Fix for 3478435, <hr> tags should be centered by default. Ditched the 1px margin as well.

Fix for 3479441, <h1>-<h6> tags should *not* be centered by default. They should also use bold instead of
bolder.

Reviewed by darin

khtml/css/html4.css:
khtml/html/html_blockimpl.cpp: (HTMLHRElementImpl::parseAttribute):
layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
layout-tests/apple-only/base/www.excite.com/index-expected.txt:
layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
layout-tests/css1/basic/class_as_selector-expected.txt:
layout-tests/css1/basic/comments-expected.txt:
layout-tests/css1/basic/containment-expected.txt:
layout-tests/css1/basic/contextual_selectors-expected.txt:
layout-tests/css1/basic/grouping-expected.txt:
layout-tests/css1/basic/id_as_selector-expected.txt:
layout-tests/css1/basic/inheritance-expected.txt:
layout-tests/css1/box_properties/border-expected.txt:
layout-tests/css1/box_properties/border_bottom-expected.txt:
layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
layout-tests/css1/box_properties/border_bottom_width-expected.txt:
layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
layout-tests/css1/box_properties/border_color-expected.txt:
layout-tests/css1/box_properties/border_color_inline-expected.txt:
layout-tests/css1/box_properties/border_inline-expected.txt:
layout-tests/css1/box_properties/border_left-expected.txt:
layout-tests/css1/box_properties/border_left_inline-expected.txt:
layout-tests/css1/box_properties/border_left_width-expected.txt:
layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
layout-tests/css1/box_properties/border_right-expected.txt:
layout-tests/css1/box_properties/border_right_inline-expected.txt:
layout-tests/css1/box_properties/border_right_width-expected.txt:
layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
layout-tests/css1/box_properties/border_style-expected.txt:
layout-tests/css1/box_properties/border_style_inline-expected.txt:
layout-tests/css1/box_properties/border_top-expected.txt:
layout-tests/css1/box_properties/border_top_inline-expected.txt:
layout-tests/css1/box_properties/border_top_width-expected.txt:
layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
layout-tests/css1/box_properties/border_width-expected.txt:
layout-tests/css1/box_properties/border_width_inline-expected.txt:
layout-tests/css1/box_properties/clear-expected.txt:
layout-tests/css1/box_properties/clear_float-expected.txt:
layout-tests/css1/box_properties/float-expected.txt:
layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
layout-tests/css1/box_properties/float_margin-expected.txt:
layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
layout-tests/css1/box_properties/height-expected.txt:
layout-tests/css1/box_properties/margin-expected.txt:
layout-tests/css1/box_properties/margin_bottom-expected.txt:
layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
layout-tests/css1/box_properties/margin_inline-expected.txt:
layout-tests/css1/box_properties/margin_left-expected.txt:
layout-tests/css1/box_properties/margin_left_inline-expected.txt:
layout-tests/css1/box_properties/margin_right-expected.txt:
layout-tests/css1/box_properties/margin_right_inline-expected.txt:
layout-tests/css1/box_properties/margin_top-expected.txt:
layout-tests/css1/box_properties/margin_top_inline-expected.txt:
layout-tests/css1/box_properties/padding-expected.txt:
layout-tests/css1/box_properties/padding_bottom-expected.txt:
layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
layout-tests/css1/box_properties/padding_inline-expected.txt:
layout-tests/css1/box_properties/padding_left-expected.txt:
layout-tests/css1/box_properties/padding_left_inline-expected.txt:
layout-tests/css1/box_properties/padding_right-expected.txt:
layout-tests/css1/box_properties/padding_right_inline-expected.txt:
layout-tests/css1/box_properties/padding_top-expected.txt:
layout-tests/css1/box_properties/padding_top_inline-expected.txt:
layout-tests/css1/box_properties/width-expected.txt:
layout-tests/css1/cascade/cascade_order-expected.txt:
layout-tests/css1/cascade/important-expected.txt:
layout-tests/css1/classification/display-expected.txt:
layout-tests/css1/classification/list_style-expected.txt:
layout-tests/css1/classification/list_style_image-expected.txt:
layout-tests/css1/classification/list_style_position-expected.txt:
layout-tests/css1/classification/list_style_type-expected.txt:
layout-tests/css1/classification/white_space-expected.txt:
layout-tests/css1/color_and_background/background-expected.txt:
layout-tests/css1/color_and_background/background_attachment-expected.txt:
layout-tests/css1/color_and_background/background_color-expected.txt:
layout-tests/css1/color_and_background/background_image-expected.txt:
layout-tests/css1/color_and_background/background_position-expected.txt:
layout-tests/css1/color_and_background/background_repeat-expected.txt:
layout-tests/css1/color_and_background/color-expected.txt:
layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
layout-tests/css1/font_properties/font-expected.txt:
layout-tests/css1/font_properties/font_family-expected.txt:
layout-tests/css1/font_properties/font_size-expected.txt:
layout-tests/css1/font_properties/font_style-expected.txt:
layout-tests/css1/font_properties/font_variant-expected.txt:
layout-tests/css1/font_properties/font_weight-expected.txt:
layout-tests/css1/formatting_model/canvas-expected.txt:
layout-tests/css1/formatting_model/floating_elements-expected.txt:
layout-tests/css1/formatting_model/height_of_lines-expected.txt:
layout-tests/css1/formatting_model/inline_elements-expected.txt:
layout-tests/css1/formatting_model/replaced_elements-expected.txt:
layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
layout-tests/css1/pseudo/anchor-expected.txt:
layout-tests/css1/pseudo/firstletter-expected.txt:
layout-tests/css1/pseudo/firstline-expected.txt:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
layout-tests/css1/text_properties/letter_spacing-expected.txt:
layout-tests/css1/text_properties/line_height-expected.txt:
layout-tests/css1/text_properties/text-transform-expected.txt:
layout-tests/css1/text_properties/text_align-expected.txt:
layout-tests/css1/text_properties/text_decoration-expected.txt:
layout-tests/css1/text_properties/text_indent-expected.txt:
layout-tests/css1/text_properties/text_transform-expected.txt:
layout-tests/css1/text_properties/vertical_align-expected.txt:
layout-tests/css1/text_properties/word_spacing-expected.txt:
layout-tests/css1/units/color_units-expected.txt:
layout-tests/css1/units/length_units-expected.txt:
layout-tests/css1/units/percentage_units-expected.txt:
layout-tests/css1/units/urls-expected.txt:
layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
layout-tests/fast/encoding/utf-16-little-endian-expected.txt:

4:00 PM Changeset in webkit [5449]

1 copy
326 deletes in branches/unlabeled-1.56.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.56.4'.

4:00 PM Changeset in webkit [5448] by cblu

5 edits in trunk/WebCore

Fixed: <rdar://problem/3479266>: selected images don't obey CSS3 selection background-color attribute

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::selectionTintColor): new, takes style into account (RenderImage::paintObject): use selectionTintColor
khtml/rendering/render_image.h:
kwq/KWQPainter.h: removed selectedImageTintColor
kwq/KWQPainter.mm:

3:52 PM Changeset in webkit [5447] by hyatt

9 edits in trunk/WebCore

Fix for 3479287, macro-ize the handling of the CSS 'inherit' value. This patch is preparation for
adding support for the 'initial' value, which will be used to fix the CSS parser's shorthand parsing
bugs.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/khtmlview.cpp: (KHTMLView::layout):

3:21 PM Changeset in webkit [5446] by cblu

5 edits in trunk/WebCore

Fixed:
<rdar://problem/3478883>: REGRESSION (113-114u): drag image for selected text includes unselected images
<rdar://problem/3479204>: selected images don't look selected

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::RenderImage): init m_selectionState (RenderImage::paintObject): draw a tint over the image if selected, don't draw anything if not selected and the action is PaintActionSelection
khtml/rendering/render_image.h: (khtml::RenderImage::selectionState): new (khtml::RenderImage::setSelectionState): new
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::selectedImageTintColor): new

2:41 PM Changeset in webkit [5445] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3477795>: REGRESSION: can't submit form without
submit button by hitting return (cocoadev.com)

When I changed submitting forms using the return key in a text field
to go through a search for the correct submit or image input
element to use when submitting, I neglected to cover the case of
forms which have neither a submit or image input element. When
I encounter a form such as this now, I submit it anyway after
performing the submit or image input element and failing to find one.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::performSubmitClick)

1:54 PM Changeset in webkit [5444] by rjw

2 edits in trunk

Forget to change NOBODY to Darin.

1:51 PM Changeset in webkit [5443] by rjw

12 edits in trunk

WebKit:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.
Fixed 3478885. Remove dead arabic shaping code

Reviewed by NOBODY (OOPS!).

Misc.subproj/WebUnicode.h:
Misc.subproj/WebUnicode.m: (_unicodeDigitValue): (_unicodeDirection): (_unicodeMirrored): (_unicodeMirroredChar): (_unicodeLower): (_unicodeUpper): (WebKitInitializeUnicode): (shapeForNextCharacter): (initializeCharacterShapeIterator):
Misc.subproj/WebUnicodeTables.m:
WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter): (fontContainsString):

WebCore:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.

Reviewed by NOBODY (OOPS!).

WebCore-combined.exp:
WebCore.exp:
kwq/KWQChar.mm: (QChar::lower): (QChar::upper): (QChar::mirroredChar):
kwq/KWQString.h: (QChar::direction):
kwq/WebCoreUnicode.cpp:
kwq/WebCoreUnicode.h:

12:45 PM Changeset in webkit [5442] by rjw

1 add in trunk/LayoutTests/css1/text_properties/text-transform-expected.txt

Added expected results for text-transform test.

12:42 PM Changeset in webkit [5441] by rjw

1 edit in trunk/LayoutTests/css1/text_properties/text-transform.html

Removed Turkish and Deseret from the test case. These don't work yet.

11:58 AM Changeset in webkit [5440] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3478351>: Safari: URL Alias on Dock failed to open the 2byte URL

Reviewed by dave.

Misc.subproj/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): if the host name is percent-escaped, use CFURLCreateStringByReplacingPercentEscapes

10:49 AM Changeset in webkit [5439] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3478781>: drag image of selected text and images doesn't include images

Reviewed by rjw.

khtml/rendering/render_image.cpp: (RenderImage::paintObject): paint when the paint action is PaintActionSelection
khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): ditto

10:46 AM Changeset in webkit [5438] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3477624>: REGRESSION (113): Using input method to
enter non-ascii text submits the form

This regression has been in the tree for a couple of versions now,
since we improved the way key events are processed. The solution
is to ask the text input manager if it has any marked text when
the return key (or enter key) is pressed, because if it does, the key
needs to work in the "accept" role for the input manager. Fixing
in this way has the pleasant effect of making return/enter key
behavior "do the right thing" based on context.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Add check to see if text input manager has marked text before submitting text and password fields. Broke out key handling for checkboxes and radios, since the old code for these widgets worked fine.
kwq/KWQLineEdit.h: Added hasMarkedText function.
kwq/KWQLineEdit.mm: (QLineEdit::hasMarkedText): Returns whether the current input manager has marked text or not.

10:00 AM Changeset in webkit [5437] by rjw

2 edits in trunk/WebKit

Use ICU for upper/lower conversion. Fixed 3477157, 3478455, 3478456, 3478457, 3478486.
Remaining issues with surrogates (3477159) and Turkish I (3478482).

Reviewed by Ken.

Misc.subproj/WebUnicode.m: (_unicodeLower): (_unicodeUpper):

8:31 AM Changeset in webkit [5436] by darin

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3477528 -- array.sort(function) fails if the function returns a non-zero value that rounds to zero

kjs/array_object.cpp: (compareByStringForQSort): Added checks for undefined values to match what the specification calls for. (compareWithCompareFunctionForQSort): Added checks for undefined values as above, and also changed the code that looks at the compare function result to look at the number returned without rounding to an integer. (ArrayProtoFuncImp::call): Changed the code that looks at the compare function result to look at the number returned without rounding to an integer.

12:26 AM Changeset in webkit [5435] by darin

9 edits in trunk/WebCore

Reviewed by Dave.

fixed 3478173 -- REGRESSION (112-113): getElementById is failing for many types of elements

The problem was that ElementImpl::attach was being skipped for many objects with classes
derived from ElementImpl. By changing them all to call up to their base classes instead of
skipping levels, the bug went away. This was possible (and easy to do) because of the
rendererIsNeeded() change I made a while back.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). This was a remnant of the old way of changing the logic about when to create the renderer, not needed now that we have rendererIsNeeded(). (HTMLFrameSetElementImpl::attach): Ditto. (HTMLIFrameElementImpl::attach): Ditto.

khtml/html/html_formimpl.h: Removed many unused attach() overrides.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Ditto. (HTMLButtonElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLFieldSetElementImpl::attach): Ditto. (HTMLInputElementImpl::attach): Removed explicit createRendererIfNeeded call, not needed now that HTMLGenericFormElementImpl calls through to its base class. (HTMLLegendElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLSelectElementImpl::attach): Ditto. (HTMLTextAreaElementImpl::attach): Ditto.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLImageElementImpl::detach): Call base class's detach() instead of NodeBaseImpl::detach(). No need to skip the ElementImpl::detach() function, and important not to for the new "id" optimization.

khtml/html/html_inlineimpl.h: Removed HTMLBRElementImpl::attach override.
khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach().

khtml/html/html_objectimpl.h: Removed HTMLAppletElementImpl::attach override.
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::attach): Removed, because the base class's attach does the right thing. (HTMLEmbedElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLObjectElementImpl::attach): Ditto.

Nov 9, 2003:

3:43 PM Changeset in webkit [5434] by hyatt

2 adds in trunk/LayoutTests/fast/text/basic

Add layout test for letter/word spacing bug.

3:41 PM Changeset in webkit [5433] by hyatt

3 edits in trunk/WebCore

Fix for 3478317, letter/word-spacing don't inherit properly through italic/bold elements.

Reviewed by darin

khtml/rendering/font.h: (khtml::Font::Font):
khtml/rendering/render_style.h: (khtml::RenderStyle::setFontDef):

2:30 PM Changeset in webkit [5432] by hyatt

2 edits in trunk/WebCore

Fix for 3478309, make sure backgrounds paint in the border box and not just in the padding box.

Reviewed by darin

Also making sure that <frame>s aren't transparent, since other browsers seem to only make <iframe>s/<object>s
be transparent.

khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):

Nov 8, 2003:

9:10 PM Changeset in webkit [5431] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3478025 -- links with non-Latin-1 characters in the hostname are not getting IDN-encoded

kwq/KWQKURL.mm: (KURL::parse): Changed existing code to take advantage of the fact that a NUL character is classified as a path segment end character. (KURL::findHostnameInHierarchicalURL): Don't treat NUL characters as terminating characters for hostnames, because QChar::latin1() turns all non-Latin-1 characters into NUL characters.

3:24 PM Changeset in webkit [5430] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3477509 -- REGRESSION (112-113): crash in KHTMLPart::processObjectRequest at espn.com, chosun.com

khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Use a dynamic_cast to check the type of the part rather than assuming it's always a KHTMLPart. The crash was caused by casting a KWQPluginPart to KHTMLPart.

9:40 AM Changeset in webkit [5429] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3240778>: add "save" menu item to contextual menu for text pages

Reviewed by darin.

WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): Made WebTextView's context menu behavior like WebHTMLView's context menu behavior with regards to selection. If the control-click was on a selection, show menu options for the selection like copy. If it was not on a selection, show menu options such as save and print. Don't select anything when control-clicking.

9:40 AM Changeset in webkit [5428] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3478022>: assertion failure while loading WMP content

Reviewed by darin.

ChangeLog:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Don't continue if the stream is cancelled in startStreamWithResponse.

9:39 AM Changeset in webkit [5427] by darin

6 edits in trunk/WebCore

Reviewed by Richard.

event cleanup motivated by questions on khtml-devel

khtml/dom/dom2_events.h: Removed eventModuleName.
khtml/dom/dom2_events.cpp: Removed eventModuleName.

khtml/xml/dom2_eventsimpl.h: Removed eventModuleName, made many trivially simple functions inline, made virtual functions no longer inline. Also made some functions const. (DOM::EventImpl::propagationStopped): Made this non-virtual; there was no reason for it to be virtual I could see. (DOM::EventImpl::defaultPrevented): Ditto. (DOM::EventImpl::setDefaultHandled): Ditto. (DOM::UIEventImpl::view): Made this inline. (DOM::UIEventImpl::detail): Ditto. (DOM::MouseEventImpl::screenX): Ditto. (DOM::MouseEventImpl::screenY): Ditto. (DOM::MouseEventImpl::clientX): Ditto. (DOM::MouseEventImpl::clientY): Ditto. (DOM::MouseEventImpl::layerX): Ditto. (DOM::MouseEventImpl::layerY): Ditto. (DOM::MouseEventImpl::ctrlKey): Ditto. (DOM::MouseEventImpl::shiftKey): Ditto. (DOM::MouseEventImpl::altKey): Ditto. (DOM::MouseEventImpl::metaKey): Ditto. (DOM::MouseEventImpl::button): Ditto. (DOM::MouseEventImpl::relatedTarget): Ditto. (DOM::MutationEventImpl::relatedNode): Ditto. (DOM::MutationEventImpl::prevValue): Ditto. (DOM::MutationEventImpl::newValue): Ditto. (DOM::MutationEventImpl::attrName): Ditto. (DOM::MutationEventImpl::attrChange): Ditto.

khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Changed implementation to no longer require eventModuleName(), and removed some unneeded casts.

khtml/xml/dom2_eventsimpl.cpp: Made lots of functions inline. (EventImpl::isUIEvent): Since this is virtual, make it no longer inline. (EventImpl::isMouseEvent): Ditto. (EventImpl::isMutationEvent): Ditto. (EventImpl::isKeyboardEvent): Ditto. (UIEventImpl::isUIEvent): Ditto. (MouseEventImpl::isMouseEvent): Ditto. (KeyboardEventImpl::isKeyboardEvent): Ditto. (MutationEventImpl::isMutationEvent): Ditto.

Nov 7, 2003:

5:08 PM Changeset in webkit [5426] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3020196>: links with href="" don't show hand cursor when you mouse over them

Reviewed by darin.

khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): check if the URL on the event is non-NULL, not if it is non-empty

4:48 PM Changeset in webkit [5425]

9 copies
2 deletes in tags/Safari-100~0~1

This commit was manufactured by cvs2svn to create tag
'Safari-100~0~1'.

4:48 PM Changeset in webkit [5424] by vicki

1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore/ChangeLog-2005-08-23

moved the release marker in the ChangeLog

4:40 PM Changeset in webkit [5423] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore

Reviewed by kocienda.

WebCorePrefix.h: fix Merlot build breakage

3:36 PM Changeset in webkit [5422] by vicki

1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore/ChangeLog-2005-08-23

Safari v100.0.1 stamp

3:24 PM Changeset in webkit [5421] by vicki

4 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore

rolled this fix onto the Safari-1-1-Merlot-BuildFixes-branch

2003-10-26 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed 3463586 -- WebCore does not compile with new definition of NULL

khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.

WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.

3:24 PM Changeset in webkit [5420]

14 copies in branches/Safari-1-1-Merlot-BuildFixes-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-Merlot-BuildFixes-branch'.

10:57 AM Changeset in webkit [5419] by rjw

4 edits in trunk

WebKit:

Fixed 3477067. Use our case unicode conversion routines.

Reviewed by Ken.

WebCoreSupport.subproj/WebTextRenderer.m: (toUpper):

WebCore:

Fixed 3477067. Use our case unicode conversion routines.

Reviewed by Ken.

kwq/KWQChar.mm: (QChar::lower): (QChar::upper):

9:51 AM Changeset in webkit [5418] by rjw

1 add in trunk/LayoutTests/css1/text_properties/text-transform.html

New text-transform test case from Dave at CSS WG.

Nov 6, 2003:

11:59 PM Changeset in webkit [5417] by hyatt

3 adds in trunk/LayoutTests/fast/runin

Adding runin tests finally.

11:58 PM Changeset in webkit [5416] by hyatt

2 edits in trunk/WebCore

Fixes for 3476717, inline blocks should expand to encompass floats; 3476718, inline blocks should not
collapse margins with children; and 3476721, run-ins and compacts can flow into anonymous blocks, even
ones that they caused to be created by failing to run in/compact in the first place.

Reviewed by darin (inline block fixes only).

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren):

11:41 PM Changeset in webkit [5415] by hyatt

4 adds in trunk/LayoutTests/fast/inline-block

Adding inline-block growth/collapsing layout tests.

7:37 PM Changeset in webkit [5414] by rjw

2 edits in trunk/WebCore

Fixed 3476563. Remove unnecessary call to set view position after load completes.

Reviewed by Gramps.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):

4:40 PM Changeset in webkit [5413] by rjw

4 edits in trunk/WebKit

Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.

Reviewed by Ken.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_scrollPointToVisible:fromView:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]):

3:42 PM Changeset in webkit [5412] by cblu

2 edits in trunk/WebCore

khtml/rendering/render_image.h: (khtml::RenderImage::isDisplayingError): forgot to remove the "virtual" part of the declaration

3:37 PM Changeset in webkit [5411] by cblu

3 edits in trunk/WebCore

Fixed:
<rdar://problem/3275118>: Dragging from missing-image link stretches missing-image icon to size of missing image
<rdar://problem/3476225>: assert dragging non-existant images

Reviewed by rjw.

khtml/rendering/render_image.h: (khtml::RenderImage::isDisplayingError): new method, returns true for the broken image
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): only provide info if there is an image and the image is not broken

1:29 PM Changeset in webkit [5410] by kocienda

3 edits in trunk/WebCore

Reviewed by Richard

Fixes for these bugs:

<rdar://problem/3476006>: Form file input widgets do not scroll
to view when focused

<rdar://problem/3476007>: Form file input widgets should only
focus when full keyboard access is on

kwq/KWQFileButton.h: Added focusPolicy declaration.
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy): Added. Now works like other buttons. Fixes 3476007. (KWQFileButton::focusChanged): Added. Code similar to text area widgets. Fixes 3476006.

1:03 PM Changeset in webkit [5409] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3308609>: 6L60 Safari URL links with line-endings converted to hex by contextual menu

Reviewed by rjw.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): use parseURL to go from an attribute string to a URL string

12:11 PM Changeset in webkit [5408] by vicki

3 edits in trunk

the tree is open for Safari-114!

12:05 PM Changeset in webkit [5407]

3 copies in tags/Safari-113

This commit was manufactured by cvs2svn to create tag 'Safari-113'.

12:05 PM Changeset in webkit [5406] by vicki

6 edits in trunk

Safari-113 stamp

9:33 AM Changeset in webkit [5405] by sullivan

2 edits in trunk/WebCore

fixed broken build

khtml/xml/dom_docimpl.cpp: (DocumentImpl::completeURL): removed stray character

9:12 AM Changeset in webkit [5404] by mjs

9 edits in trunk/WebCore

Reviewed by Darin.

fixed 3475366 - 4.5% of time spent making html event listeners on slow intel page.

6% speedup on intel page, 1% speedup on cvs-base PLT.

khtml/ecma/kjs_events.cpp: (JSEventListener::JSEventListener): Don't add self to hashtable if imp is null (which can now happen in the lazy listener case). (JSEventListener::~JSEventListener): Ditto on removing. (JSEventListener::listenerObj): Made this virtual. (JSLazyEventListener::JSLazyEventListener): New constructor. (JSLazyEventListener::handleEvent): call parseCode, then superclass if it appeared to succeed. (JSLazyEventListener::listenerObj): call parseCode, then superclass. (JSLazyEventListener::parseCode): (KJS::getNodeEventListener): Check for null listenerObjImp in case of lazy listener that failed to parse.
khtml/ecma/kjs_dom.cpp: (DOMNode::getListener): Ditto.
khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Ditto.
khtml/ecma/kjs_events.h: (KJS::JSEventListener::listenerObjImp): call listenerObj() virtual method and get imp from the result.
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::createHTMLEventHandler): Don't parse the code here, make a lazy listener.
khtml/ecma/kjs_window.cpp: (Window::getJSLazyEventListener): make a new JSLazyEventListener - no need to check the listeners hashtable cause a brand new lazy listener won't have a function anyway.
khtml/ecma/kjs_window.h: Prototype new method.

9:06 AM Changeset in webkit [5403] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3475397 - REGRESSION: relative URLs on page load test sometimes contain garbage, leading to missing images

kwq/KWQKURL.mm: (KURL::KURL): When constructing from NSURL, null-terminate the raw bytes since KURL::parse expects a null-terminated C string. It might be even better to pass a length to parse, but this fix is simple and does the job.

Nov 5, 2003:

10:26 PM Changeset in webkit [5402] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3475109 -- support keyboard event object properties of altkey, ctrlKey, shiftKey

We had the DOM Level 3 KeyboardEvent class already; I just had to add JavaScript bindings.

khtml/ecma/kjs_events.h: Added DOMKeyboardEvent class.
khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added code to make a DOMKeyboardEvent if the event is a DOM::KeyboardEvent. (DOMKeyboardEvent::~DOMKeyboardEvent): Added. (DOMKeyboardEvent::classInfo): Added. (DOMKeyboardEvent::tryGet): Added. (DOMKeyboardEvent::getValueProperty): Added. (DOMKeyboardEventProtoFunc::tryCall): Added.

khtml/dom/dom2_events.cpp: (KeyboardEvent::keyIdentifier): Added. (KeyboardEvent::keyLocation): Added.

khtml/ecma/kjs_events.lut.h: Regenerated.

9:27 PM Changeset in webkit [5401] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3473913 -- host names in simple mailto URLs are not getting encoded/decoded correctly yet

Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Handle case where host name is at the end of the string. (applyHostNameFunctionToURLString): Add the # character to the set of characters that can end a domain name.

6:14 PM Changeset in webkit [5400] by rjw

2 edits in trunk/WebKit

Fixed 3413067, 3405797, 3456877
Use ATSUI to render Arabic and Hebrew.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU):

5:48 PM Changeset in webkit [5399] by mjs

5 edits in trunk/WebCore

Reviewed by John.

fixed 3475092 - Notifying the bridge about duplicate images takes 13% of time on intel page

Another 15% speedup on the intel page.

This also results in a 3% speedup on cvs-base PLT! (or maybe that was my last change)

kwq/KWQLoader.mm: (KWQServeRequest): Note that we told the bridge about the load. (KWQCheckCacheObjectStatus): Don't tell the bridge about the load if we have alrady; if we do tell it, then note it down.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::didTellBridgeAboutLoad): Helper method for the above. (KWQKHTMLPart::haveToldBridgeAboutLoad): Ditto. (KWQKHTMLPart::clear): Clear our idea of what URLs we told the bridge about.
khtml/khtml_part.h: make clear() virtual.

5:47 PM Changeset in webkit [5398] by sullivan

4 edits in trunk/WebKit

fixed <rdar://problem/3469791>: Bigger/Smaller commands are disabled for HTML Mail in separate window (w/WebKit-111)

Reviewed by Darin.

WebView.subproj/WebFrameView.m: (-[WebFrameView acceptsFirstResponder]): always be willing to become first responder, even if no page has yet been loaded. (-[WebFrameView becomeFirstResponder]): if no page has yet been loaded (so our scrollview refuses first responder-ness), don't do any special becoming-first- responder shenanigans.

Also removed obsolete overrides for nextKeyView, nextValidKeyView,
previousKeyView, and previousValidKeyView that are no longer
required now that we handle the key loop more like NSScrollView.

WebView.subproj/WebFrameViewPrivate.h: removed now-unused ivar inNextValidKeyView

5:43 PM Changeset in webkit [5397] by darin

2 edits in trunk/WebCore

WebCore-combined.exp: Checked in generated file.

4:17 PM Changeset in webkit [5396] by rjw

7 edits in trunk

WebKit:

Fixed 3029966. Animated backgrounds specified in <BODY> don't animate
Fixed 3474824. Tiled animated GIFs don't animate.
Fixed 3029966. Animated backgrounds specified with CSS don't animate.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]): (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer startAnimationIfNecessary]): (-[WebImageRenderer tileInRect:fromPoint:]):
WebView.subproj/WebImageView.m: (-[WebImageView drawRect:]):

WebCore:

Fixed 3474957. Changed name of image rendering method to better reflect it's actual function.

(void)beginAnimationInRect:(NSRect)ir fromRect:(NSRect)fr;

renamed to

(void)drawImageInRect:(NSRect)ir fromRect:(NSRect)fr;

Reviewed by Chris.

kwq/KWQPainter.mm: (QPainter::drawPixmap):
kwq/WebCoreImageRenderer.h:

2:59 PM Changeset in webkit [5395] by darin

2 edits in trunk/WebCore

WebCore-tests.exp: Added missing symbol so tests will link.

2:24 PM Changeset in webkit [5394] by mjs

4 edits in trunk/WebCore

Reviewed by Ken.

fixed 3474756 - Creating HTML event listeners takes 5% of time on particular slow intel page

khtml/ecma/kjs_window.h: Make jsEventListeners a hashtable keyed by listener object, not a list.
khtml/ecma/kjs_window.cpp: (Window::getJSEventListener): Do hashtable lookup for existing listener instead of walking list.
khtml/ecma/kjs_events.cpp: (JSEventListener::JSEventListener): Use hashtable insert instead of list append. (JSEventListener::~JSEventListener): Use hashtable remove instead of list removeRef.

1:59 PM Changeset in webkit [5393] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3201364>: Safari crashes when hosting carbon plug-in using drag and drop

Reviewed by rjw.

WebView.subproj/WebView.m: (-[WebView draggingUpdated:]): return NSDragOperationNone if we're over a plug-in view so the plug-in can handle the drag

12:57 PM Changeset in webkit [5392] by darin

6 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3473872 -- encode domain names for IDN when creating URLs inside WebCore

kwq/KWQKURL.h: Added KWQIntegerPair type, a number of private functions.
kwq/KWQKURL.mm: (isSchemeFirstChar): Make inline function from macro. (isSchemeChar): Make inline function from macro. (isUserInfoChar): Make inline function from macro. (isHostnameChar): Make inline function from macro. (isIPv6Char): Make inline function from macro. (isPathSegmentEndChar): Make inline function from macro. (isBadChar): Make inline function from macro. (isHexDigit): Make inline function from macro. (KURL::KURL): Remove unneeded initializations of m_isValid, since parse sets it. Use CFURLGetBytes in one place a FIXME asked for it. Changed non-ASCII case to use a separate function instead of code in line. (KURL::encodeHostnames): Added. Finds host names and encodes them. (KURL::findHostnameInHierarchicalURL): Added. Finds host name in a hierarchical URL. (KURL::encodeHostname): Added. Encodes one host name. (KURL::findHostnamesInMailToURL): Added. Finds host names in a mailto URL.

kwq/KWQString.h: Added new overloads for startsWith.
kwq/KWQString.mm: (compareIgnoringCaseForASCIIOnly): Moved these functions up in the file so they can be used by more methods of QString. (QString::startsWith): Added new overloads.

WebCore.pbproj/project.pbxproj: Add libicucore.A.dylib library.

12:00 PM Changeset in webkit [5391] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3473906 - getElementById takes about 44% of time on particular slow intel page

I fixed this by adding a per-document id --> element hash
table. This speeds up my local copy of the intel page by 60% (50
sec to 20 sec!) and does not cause any PLT slowdown.

khtml/xml/dom_docimpl.h: New QDict field for id to element hash table.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): Just look it up in the newly added hash table. (DocumentImpl::addElementById): New method. Add to hash table if no other element is set for that key (this lets the first element of several with matching ids win). (DocumentImpl::removeElementById): New method. Remove from hash table only if the key and value both match.

These Element changes to keep the id --> element hashtable working
seem needlessly tricky, due to lack of bottlenecks in attribute
changing.

khtml/xml/dom_elementimpl.cpp: (ElementImpl::updateId): New method that removes element from hash table for old it (ElementImpl::setAttribute): If setting id, call updateId. (ElementImpl::setAttributeMap): If either the old or the new map includes id, call updateId. (ElementImpl::attach): If we have an id, call updateId to set it after attaching. (ElementImpl::detach): Newly added. If we have an id, call updateId to clear it before detaching. (NamedAttrMapImpl::setNamedItem): If the name is id, call updateId on our element. (NamedAttrMapImpl::removeNamedItem): If the name is id, call updateId on our element. (NamedAttrMapImpl::operator=): If old or new contents include id attribute, call updateId on our element.
khtml/xml/dom_elementimpl.h: Prototype new methods.

11:06 AM Changeset in webkit [5390] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3474360>: should attempt to resolve symbolic links when choosing "Save Link As..."

Reviewed by kocienda.

WebView.subproj/WebView.m: (-[WebView _fileWrapperForURL:]): follow sym links

10:10 AM Changeset in webkit [5389] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3455910>: hitting up or down arrows when focus
is on a pop-up menu should pop the menu

WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): Call super with the event if focus is on a pop up button.

8:49 AM Changeset in webkit [5388] by kocienda

11 edits in trunk

WebCore:

Reviewed by Maciej

Fix for these bugs:

<rdar://problem/3467558>: Cannot tab to form file input widgets
<rdar://problem/3473631>: WebFileButton sends notifications to communicate with WebCore

Tabbing now works for these widgets. While I was in the neighborhood,
I improved the communication mechanism between the WebKit and WebCore
sides of the file button implementation, replacing notifications
with a callback object.

WebCore-combined.exp: Remove no-longer used WebCoreFileButtonClicked

and WebCoreFileButtonFilenameChanged notofication strings.

WebCore.exp: Ditto.
kwq/KWQFileButton.h: Changed declarations to match changes in callback functions.
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Now sets the view after creating the delegate object. (KWQFileButton::filenameChanged): Now takes a QString argument which indicates the filename. (KWQFileButton::focusChanged): New function. Sends DOM focus and blur events. (-[KWQFileButtonAdapter initWithKWQFileButton:]): No longer needs to register for notifications. (-[KWQFileButtonAdapter dealloc]): No longer needs to remove itself from the notification center. (-[KWQFileButtonAdapter filenameChanged:]): No longer a notification callback. Now a WebCoreFileButtonCallback callback. (-[KWQFileButtonAdapter focusChanged:]): New WebCoreFileButtonCallback callback. (-[KWQFileButtonAdapter clicked]): No longer a notification callback. Now a WebCoreFileButtonCallback callback.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Unrelated cleanup.
kwq/WebCoreBridge.h: Declared new WebCoreFileButtonDelegate protocol.

WebKit:

Reviewed by Maciej

Fix for these bugs:

<rdar://problem/3467558>: Cannot tab to form file input widgets
<rdar://problem/3473631>: WebFileButton sends notifications to communicate with WebCore

Tabbing now works for these widgets. While I was in the neighborhood,
I improved the communication mechanism between the WebKit and WebCore
sides of the file button implementation, replacing notifications
with a callback object.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileButtonWithDelegate:]): Method now takes a delegate object.
WebCoreSupport.subproj/WebFileButton.h:
WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithBridge:delegate:]): (-[WebFileButton initWithFrame:]): (-[WebFileButton dealloc]): (-[WebFileButton chooseFilename:]): Sends callback rather than posting a notification. (-[WebFileButton chooseButtonPressed:]): Ditto. (-[WebFileButton mouseDown:]): (-[WebFileButton acceptsFirstResponder]): (-[WebFileButton becomeFirstResponder]): Make the button subview first responder. (-[WebFileButton nextKeyView]): Hook up to WebBridge key view machinery. (-[WebFileButton previousKeyView]): Ditto. (-[WebFileButton nextValidKeyView]): Ditto. (-[WebFileButton previousValidKeyView]): Ditto. (-[WebFileChooserButton initWithDelegate:]): (-[WebFileChooserButton nextValidKeyView]): Ditto. (-[WebFileChooserButton previousValidKeyView]): Ditto. (-[WebFileChooserButton resignFirstResponder]): Sends a focus change callback.

12:58 AM Changeset in webkit [5387] by mjs

2 edits in trunk/WebCore

fixed deployment build

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fileWrapperForElement):

Nov 4, 2003:

5:39 PM Changeset in webkit [5386] by darin

5 edits in trunk/WebKit

Reviewed by John, except for one bit reviewed by Maciej.

first step for IDNA support; helper functions for Safari

Misc.subproj/WebNSURLExtras.h: Add six new methods to manipulate host names directly.
Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Added. Finds host names within a mailto URL. (applyHostNameFunctionToURLString): Added. Finds host names within a URL. (collectRangesThatNeedMapping): Added. Builds a list of host name ranges that need mapping. (collectRangesThatNeedEncoding): Added. Calls the above for encoding. (collectRangesThatNeedDecoding): Added. Calls the above for decoding. (mapHostNames): Added. Helper function that does the entire mapping process for a URL. (+[NSURL _web_URLWithUserTypedString:]): Call mapHostNames to encode after trimming whitespace. (-[NSURL _web_userVisibleString]): Call mapHostNames to decode after decoding escape sequences. (-[NSURL _webkit_URLByRemovingFragment]): Removed unneeded redundant NULL check. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Added. Workhorse function to call the IDN functions in the Unicode library. (-[NSString _web_hostNameNeedsDecodingWithRange:]): Added. (-[NSString _web_hostNameNeedsEncodingWithRange:]): Added. (-[NSString _web_decodeHostNameWithRange:]): Added. (-[NSString _web_encodeHostNameWithRange:]): Added. (-[NSString _web_decodeHostName]): Added. (-[NSString _web_encodeHostName]): Added.

WebKit.pbproj/project.pbxproj: Added libicucore.dylib.
English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.

4:31 PM Changeset in webkit [5385] by sullivan

2 edits in trunk/WebKit

WebKit:

a little optimization I noticed when looking at 3125137

Reviewed by Chris.

Misc.subproj/WebStringTruncator.m: (truncateString): if incoming string has length 0, bail out right away

WebBrowser:

fixed <rdar://problem/3125137>: long URL in bookmark bar toolbar popup takes over whole screen

Reviewed by Chris.

BookmarksController.m: (-[BookmarksController addMenuItemForBookmark:toMenu:]): truncate the titles of menu items created for bookmarks

2:50 PM Changeset in webkit [5384] by mjs

3 edits in trunk/WebCore

Reviewed by Ken.

khtml/ecma/kjs_window.cpp: Don't make event read-only, some sites want to set their own top-level function named "event" and will hang if they can't.
khtml/ecma/kjs_window.lut.h: Regenerated.

1:52 PM Changeset in webkit [5383] by hyatt

2 edits in trunk/WebCore

Fix for 3472167, for shrink-to-fit style printing, grow the width of the initial containing block
to be as large as the rightmost position after doing a layout to the page width.

Reviewed by john

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth):

12:06 PM Changeset in webkit [5382] by hyatt

3 edits
2 adds in trunk/LayoutTests

Update the layout tests.

11:15 AM Changeset in webkit [5381] by cblu

19 edits in trunk

WebCore:

Fixed:
<rdar://problem/3472403>: RTFD of copied text and images should use original image data not tiffs

Reviewed by john.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fileWrapperForElement): call [_bridge _fileWrapperForURL:] to get cached data
kwq/WebCoreBridge.h: added _fileWrapperForURL: to the bridge protocol
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedAttributedString]): call the instance method attributedString (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): call the instance method attributedString

WebKit:

Fixed:
<rdar://problem/3472403>: RTFD of copied text and images should use original image data not tiffs
<rdar://problem/3472435>: dragging local image file downloads it instead of copies it
<rdar://problem/3472450>: copied and dragged local image files are TIFF, not original image data

Reviewed by john.

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]): new
Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:fileWrapper:rect:URL:title:event:]): take a file wrapper instead of data so [NSPasteboard _web_writeFileWrapperAsRTFDAttachment:] can be called
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileWrapperForURL:]): call fileWrapperForURL on the WebView
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call [NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): when calling _web_dragImage, pass a file wrapper from fileWrapperForURL (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call fileWrapperForURL
WebView.subproj/WebImageRepresentation.h:
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation fileWrapper]): new
WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call [NSPasteboard _web_writeFileWrapperAsRTFDAttachment:] (-[WebImageView mouseDragged:]): pass the file wrapper to _web_dragImage
WebView.subproj/WebView.m: (-[WebView _fileWrapperForURL:]): new, returns a file wrapper from a local file or from the cache
WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed:
<rdar://problem/3472437>: "Download Link to Disk..." should be "Save Link As..." if the link is local
<rdar://problem/3472439>: "Download Image to Disk..." should be "Save Image As..." if the image is local

Reviewed by john.

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument setFileWrapperToSave:MIMEType:]): new, when saving data, use a file wrapper so that we can save things other than data sources. (-[BrowserDocument setDataSourceToSave:]): now calls setFileWrapperToSave:MIMEType: (-[BrowserDocument isSavingPlainText]): checks the _savingMIMEType (-[BrowserDocument saveDocumentTo:]): calls setDataSourceToSave if there is no fileWrapperToSave (-[BrowserDocument document:didSave:contextInfo:]): calls setFileWrapperToSave:MIMEType: (-[BrowserDocument dataRepresentationOfType:]): returns the data of the wrapper (-[BrowserDocument displayName]): if saving, return the filename of the wrapper (-[BrowserDocument fileType]): use _savingMIMEType
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): provide "Save Image As..." and "Save Link As..." for local files (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]): new (-[BrowserWebView saveImageAs:]): new (-[BrowserWebView saveLinkAs:]): new
English.lproj/Localizable.strings:

10:57 AM Changeset in webkit [5380] by sullivan

2 edits in trunk/WebKit

fixed <rdar://problem/3472813>: REGRESSION (100-111): Some tabs start out scrolled down to focused text field

Reviewed by Ken.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView acceptsFirstResponder]): The logic to avoid accepting first responder on clicks was too broad; it was rejecting first-responder-ness even for clicks outside of this view. Clicking a tab item was going through some logic in NSTabView looking for the first valid key view starting with the web view, but the web view was returning NO due to this faulty click logic. Thus the first subview text field was becoming first responder, and causing scroll.

10:18 AM Changeset in webkit [5379] by mjs

4 edits in trunk/WebCore

Reviewed by Chris.

fixed 3472893 - Slow intel page takes 20% of its time in CachedObject::ref

Speeds up loading of
http://www.intel.com/cd/ids/developer/asmo-na/eng/index.htm by
19%, no slowdown on PLT.

khtml/misc/loader.h: Use QPtrDict for m_clients instead of QPtrList.
khtml/misc/loader.cpp: (CachedObjectClientWalker::CachedObjectClientWalker): Ditto. (CachedObject::ref): Ditto.
kwq/KWQPtrDict.h: (QPtrDict::isEmpty): Implemented.

Nov 3, 2003:

5:48 PM Changeset in webkit [5378] by cblu

6 edits in trunk/WebKit

Fixed:
<rdar://problem/3472377>: Provide NSRTFDPboardType on pasteboard when copying or dragging images
<rdar://problem/3470809>: REGRESSION (111-112): Can't copy & paste image into Photoshop 7

Reviewed by hyatt.

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeFileDataAsRTFDAttachment:withFilename:]): renamed, now writes file data as an RTF attachment
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:originalData:rect:URL:title:event:]): call renamed _web_writeFileDataAsRTFDAttachment
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call renamed _web_writeFileDataAsRTFDAttachment
WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call renamed _web_writeFileDataAsRTFDAttachment

4:50 PM Changeset in webkit [5377] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3370085 - new frames with javascript: URLs should be populated with the result of the JavaScript code

ChangeLog:
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Skip special filtering of javascript:. (HTMLFrameElementImpl::attach): Ditto.
khtml/khtml_part.cpp: (KHTMLPart::replaceContentsWithScriptResult): New method to execute script and if the result is a string, set it as the new document contents. (KHTMLPart::requestFrame): Removed APPLE_CHANGES around javascript: handling. Use new replaceContentsWithScriptResult method. This executes the JS in the new child frame, not the parent frame, as in other browsers.
khtml/khtml_part.h: Prototype new method.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Use new part method.

4:49 PM Changeset in webkit [5376] by vicki

5 edits in trunk

JavaScriptCore:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

JavaScriptCore.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebCore:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebCore.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebKit:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebKit.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebBrowser:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebBrowser.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

4:42 PM Changeset in webkit [5375] by kocienda

3 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3470338>: onclick is not executing when you hit enter on focused links

Now when we trap return or enter when a link is focused, we send
a click event to the node.

khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Swallow key event when return or enter and send a mouse event. (HTMLAnchorElementImpl::performClick): New function to send simulated click.
khtml/html/html_inlineimpl.h: Declare performClick function.

4:40 PM Changeset in webkit [5374] by vicki

2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

JavaScriptCore.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebCore:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebCore.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebKit:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebKit.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

WebBrowser:

Reviewed by kocienda.

fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.

WebBrowser.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles

3:44 PM Changeset in webkit [5373] by darin

16 edits in trunk/WebCore

Reviewed by John.

fixed 3392543 -- incorrect base writing direction in RTL form controls
fixed baseline for list box <select> elements
moved style code from updateFromElement to setStyle

khtml/rendering/render_form.h: Added setStyle function to RenderFormElement, RenderLineEdit, RenderSelect, and RenderTextArea. Removed some unused stuff.
khtml/rendering/render_form.cpp: (RenderFormElement::setStyle): Set the font based on the style. (RenderFormElement::updateFromElement): Remove font setting code; moved to setStyle. Also ifdef'd out the color-setting code, which belongs in setStyle and is irrelevant for KWQ anyway. (RenderSubmitButton::setStyle): Set the writing direction based on the style. (RenderSubmitButton::updateFromElement): Tiny code cleanup, using a local variable. (RenderLineEdit::setStyle): Set the alignment and writing direction based on the style. (RenderLineEdit::updateFromElement): Remove alignment setting code; moved to setStyle. (RenderFileButton::RenderFileButton): Remove code to set m_focus, a data member that was never used. (RenderSelect::setWidgetWritingDirection): Added. Helper function. (RenderSelect::setStyle): Call setWidgetWritingDirection. (RenderSelect::updateFromElement): Call setWidgetWritingDirection if a new widget is created. (RenderSelect::baselinePosition): Added a FIXME comment. (RenderTextArea::setStyle): Set the alignment and writing direction based on the style. (RenderTextArea::updateFromElement): Remove alignment setting code; moved to setStyle.

kwq/KWQButton.h: Added setWritingDirection function.
kwq/KWQButton.mm: (+[KWQButton cellClass]): Use KWQButtonCell. (-[KWQButtonCell baseWritingDirection:]): Return base writing direction. (-[KWQButtonCell setBaseWritingDirection:]): Store base writing direction. (-[KWQButtonCell _textAttributes]): Set the base writing direction in the paragraph style if it's not already right. (QButton::setWritingDirection): Call setBaseWritingDirection: on the cell and do setNeedsDisplay: as needed.

kwq/KWQComboBox.h: Added setWritingDirection function.
kwq/KWQComboBox.mm: (QComboBox::setWritingDirection): Call setBaseWritingDirection: on the cell and do setNeedsDisplay: as needed. (-[KWQPopUpButtonCell setBaseWritingDirection:]): Store base writing direction. (-[KWQPopUpButtonCell baseWritingDirection:]): Return base writing direction. (-[KWQPopUpButtonCell _textAttributes]): Set the base writing direction in the paragraph style if it's not already right.

kwq/KWQLineEdit.h: Added setWritingDirection function.
kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Tweaked to match new setWritingDirection in style. (QLineEdit::setWritingDirection): Call setBaseWritingDirection: on the KWQTextField.

kwq/KWQTextField.h: Added setBaseWritingDirection method.
kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): Set the base writing direction of the secure field's cell based on the base writing direction of the parent field's cell, when creating the secure field. (-[KWQTextField setBaseWritingDirection:]): Added. Sets the base writing direction of the field's cell and the secure field's cell, if it exists, and does setNeedsDisplay as needed. (-[KWQTextFieldCell setBaseWritingDirection:]): Added. Stores the base writing direction. (-[KWQTextFieldCell baseWritingDirection]): Added. Returns the base writing direction. (-[KWQTextFieldCell _textAttributes]): Set the base writing direction in the paragraph style if it's not already right. (-[KWQSecureTextFieldCell setBaseWritingDirection:]): Added. Stores the base writing direction. (-[KWQSecureTextFieldCell _textAttributes]): Set the base writing direction in the paragraph style if it's not already right.

kwq/KWQListBox.h: Added itemIsGroupLabel and setWritingDirection functions, and made the private insertItem function take a QString instead of an NSObject. (QListBox::insertItem): Changed parameter from unsigned to int to match Qt, and made it use an inlne to call the private insertItem function shared with insertGroupLabel. (QListBox::insertGroupLabel): Changed parameter from unsigned to int and made it use an inline to call the private insertItem function.
kwq/KWQListBox.mm: (itemFont): Added. Returns a suitable font for individual items. (groupLabelFont): Added. Returns a suitable font for group labels. (paragraphStyle): Added. Returns a suitable paragraph style for a given writing direction. (stringAttributes): Added. Returns a string attributes dictionary for a given writing direction for either individual items or group labels. (QListBox::insertItem): Use an attributed string to give the item the appropriate font and writing direction, calling stringAttributes to get the attributes dictionary, and getting the writing direction from the table view. (QListBox::endBatchInsert): Tweak for consistency with other nearby methods. (QListBox::setSelected): Add an assertion and tweak a bit. (QListBox::isSelected): Add an assertion and tweak a bit. (QListBox::setWritingDirection): Update the styles for all the attributed strings and call reloadData if the writing direction changes. Also store the direction in the table view. (QListBox::itemIsGroupLabel): Added. Returns true if a given item is a group label; works by checking the font in the attributed string. (-[KWQTableView initWithListBox:items:]): Use itemFont() instead of computing the font. (-[KWQTableView tableView:shouldSelectRow:]): Use itemIsGroupLabel function instead of checking for NSString vs. NSttributedString in the items array; we now use attributed strings for all the items. (-[KWQTableView setBaseWritingDirection:]): Added. Stores a base writing direction. (-[KWQTableView baseWritingDirection]): Added. Returns the stored base writing direction.

kwq/KWQTextEdit.h: Added setWritingDirection function.
kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Removed code to set base writing direction. (QTextEdit::setWritingDirection): Added. Sets base writing direction.

kwq/KWQTextArea.mm: (-[KWQTextArea setBaseWritingDirection:]): Call setNeedsDisplay:YES.

3:37 PM Changeset in webkit [5372] by hyatt

3 edits in trunk/WebCore

Fix 3472200, media tests fail to parse correctly. Merging a patch to handle exotic media types
from the KHTML trunk.

khtml/css/parser.cpp:
khtml/css/parser.y:

3:18 PM Changeset in webkit [5371] by hyatt

2 edits in trunk/WebCore

Fix for 3471314, make sure to check the outline phase before painting backgrounds of iframes.

Reviewed by mjs

khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):

3:04 PM Changeset in webkit [5370] by hyatt

3 edits in trunk/WebCore

Fix for 3470855, links with script action stay focused when clicking.

Fix for 3470858, clicking and dragging a link and then releasing doesn't clear the glow ring.

Fix for 3472090, link should not be mouse focusable.

Reviewed by mjs

khtml/css/html4.css:
khtml/html/html_inlineimpl.h: (DOM::HTMLAnchorElementImpl::isMouseFocusable):

2:43 PM Changeset in webkit [5369] by hyatt

2 edits in trunk/WebCore

Fix for 3472030, line-height not properly reset in all cases when the font shorthand is used.

Reviewed by mjs

khtml/css/cssparser.cpp: (CSSParser::parseFont):

2:12 PM Changeset in webkit [5368] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3472023 - REGRESSION: assertion on layout tests

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Remove assert that length is not 0, since we can get zero length now when flushing.

2:01 PM Changeset in webkit [5367] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3260780>: hitting return in a text field submits
form without running onclick handler for submit button

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::performSubmitClick): Refactored this function to be more generic, so that text fields can use it, too. (HTMLInputElementImpl::defaultEventHandler): Removed code to check for a submit button, and merged this code into new performSubmitClick. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_formimpl.h: Removed declaration for simulateButtonClickForEvent. Added declaration for performSubmitClick.
khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed): Now calls performSubmitClick rather than prepareSubmit on the form. This is the key piece for the bug fix.

11:45 AM Changeset in webkit [5366] by kocienda

9 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3470342>: focus rings are shown for links in
web pages even in non-frontmost windows

kwq/KWQKHTMLPart.h: Add setShowsFirstResponder, showsFirstResponder functions and _showsFirstResponder member variable. (KWQKHTMLPart::showsFirstResponder): Added.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Initialize _showsFirstResponder to true (KWQKHTMLPart::setShowsFirstResponder): Sets whether the painter draws focus rings.
kwq/KWQPainter.h: Add _drawsFocusRing member variable. (QPainter::setDrawsFocusRing): Sets whether the painter draws focus rings.
kwq/KWQPainter.mm: (QPainter::QPainter): Initialize _drawsFocusRing to true. (QPainter::initFocusRing): Check _drawsFocusRing flag. Return if set to false. (QPainter::addFocusRingRect): Ditto. (QPainter::drawFocusRing): Ditto.
kwq/WebCoreBridge.h: Add setShowsFirstResponder method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Sets the value for _drawsFocusRing on the painter using _showsFirstResponder value from the part. (-[WebCoreBridge setShowsFirstResponder:]): Set passed in value on the part. Redraw the focus ring if flag has changed.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3470342>: focus rings are shown for links in
web pages even in non-frontmost windows

WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusRing]): New method. Uses the "keyness" of the view's window to toggle focus ring drawing. (-[WebHTMLView windowDidBecomeKey:]): Calls updateFocusRing. (-[WebHTMLView windowDidResignKey:]): Ditto.

10:46 AM Changeset in webkit [5365] by hyatt

2 edits in trunk/WebCore

Remove unneeded style property additions for form controls. In the KHTML trunk these moved into the UA
sheet, but we don't even need them there, since we don't honor any of them.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::attach): (HTMLSelectElementImpl::attach): (HTMLTextAreaElementImpl::attach):

10:35 AM Changeset in webkit [5364] by hyatt

3 edits in trunk/WebCore

Patch from KHTML trunk. Move frameset positioning reset into adjustRenderStyle so as not to
pollute the render tree.

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/rendering/render_box.cpp: (RenderBox::setStyle):

10:22 AM Changeset in webkit [5363] by hyatt

9 edits in trunk/WebCore

Fix for 3471609, 'transparent' should be an acceptable named color value instead of a special
keyword used only by background/border.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::): (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c:
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
khtml/rendering/render_object.cpp: (RenderObject::setStyle):
khtml/rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderValue::isTransparent): (khtml::BorderValue::operator==): (khtml::CollapsedBorderValue::isTransparent): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomColor):

12:20 AM Changeset in webkit [5362] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3471226 - HTML document that's less than 16 bytes comes out blank

kwq/KWQTextCodec.mm: (KWQTextDecoder::toUnicode): When flushing, don't bail out early if there are no new characters!

Nov 2, 2003:

10:34 PM Changeset in webkit [5361] by mjs

1 edit in trunk/WebCore/kwq/KWQTextCodec.mm

Revert change I didn't mean to commit.

10:32 PM Changeset in webkit [5360] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

don't resolve Null href or src attributes, since the distinction between empty and absent attribute is important.

khtml/dom/html_base.cpp: (HTMLIFrameElement::src):
khtml/dom/html_form.cpp: (HTMLInputElement::src):
khtml/dom/html_head.cpp: (HTMLBaseElement::href): (HTMLLinkElement::href): (HTMLScriptElement::src):
khtml/dom/html_image.cpp: (HTMLAreaElement::href): (HTMLImageElement::src):
khtml/dom/html_inline.cpp: (HTMLAnchorElement::href):

9:53 PM Changeset in webkit [5359]

1 copy
93 deletes in branches/unlabeled-1.95.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.95.4'.

9:53 PM Changeset in webkit [5358] by hyatt

15 edits in trunk/WebCore

Fix for 3468924, an implementation of outline-offset. We also give :focus links a built-in offset of
outline-width/2 by default for the Apple Aqua style.

Fix for 3470660, input type=image excluded from tab order.

Reviewed by darin

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/html4.css:
khtml/rendering/render_box.cpp: (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect):
khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
khtml/rendering/render_inline.cpp: (RenderInline::paintFocusRing): (RenderInline::paintOutlines): (RenderInline::paintOutline):
khtml/rendering/render_object.cpp: (RenderObject::paintOutline):
khtml/rendering/render_style.h: (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineSize): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineOffset):
khtml/rendering/render_text.cpp: (RenderText::paintObject):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): (QPainter::initFocusRing): (QPainter::addFocusRingRect):

6:03 PM Changeset in webkit [5357] by mjs

6 edits in trunk/WebKit

Reviewed by Darin.

remove use of obsolete HTTLCookiePolicyBaseURL SPI

WebCoreSupport.subproj/WebSubresourceClient.m: startLoadingResource:withURL:referrer:forDataSource:]): Use setMainDocumentURL, not setHTTPCookiePolicyBaseURL.
WebView.subproj/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): Likewise.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Likewise.

2:51 PM Changeset in webkit [5356] by darin

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

changed list manipulation to use Harri Porten's idea of a circular linked list that is built from head to tail rather than building the list backwards and reversing the list when done

kjs/grammar.y: Handle CatchNode and FinallyNode in a type-safe way. Change many places that passed 0L to pass nothing at all, or to pass 0.

kjs/nodes.h: (KJS::ElementNode::ElementNode): Build a circular list instead of a 0-terminated backwards list. (KJS::ArrayNode::ArrayNode): Break the circular list instead of reversing the list. (KJS::PropertyValueNode::PropertyValueNode): Moved before ObjectLiteralNode so the inline code in ObjectLiteralNode works. Build a circular list instead of a 0-terminated backwards list. Made the case for the first node separate so we don't need a nil check. (KJS::ObjectLiteralNode::ObjectLiteralNode): Break the circular list instead of reversing the list. (KJS::ArgumentListNode::ArgumentListNode): Build a circular list instead of a 0-terminated backwards list. Also, made the constructors inline (moved here from .cpp file). (KJS::ArgumentsNode::ArgumentsNode): Break the circular list instead of reversing the list. (KJS::NewExprNode::NewExprNode): Changed a 0L to 0. (KJS::StatListNode::StatListNode): Make this constructor no longer inline (moved into .cpp file). The one in the .cpp file builds a circular list instead of a 0-terminated backwards list. (KJS::VarDeclListNode::VarDeclListNode): Build a circular list instead of a 0-terminated backwards list. (KJS::VarStatementNode::VarStatementNode): Break the circular list instead of reversing the list. (KJS::BlockNode::BlockNode): Make this constructor no longer inline (moved into .cpp file). The one in the .cpp file breaks the list instead of reversing it. (KJS::ForNode::ForNode): Break the circular list instead of reversing the list. (KJS::CaseClauseNode::CaseClauseNode): Break the circular list instead of reversing the list. (KJS::ClauseListNode::ClauseListNode): Build a circular list instead of a 0-terminated backwards list. (KJS::CaseBlockNode::CaseBlockNode): Make this constructor no longer inline (moved into .cpp file). The one in the .cpp file breaks the list instead of reversing it. (KJS::TryNode::TryNode): Changed constructor to take typed parameters for the catch and finally nodes rather than just Node. (KJS::ParameterNode::ParameterNode): Build a circular list instead of a 0-terminated backwards list. (KJS::FuncDeclNode::FuncDeclNode): Break the circular list instead of reversing the list. (KJS::FuncExprNode::FuncExprNode): Break the circular list instead of reversing the list.

kjs/nodes.cpp: (StatListNode::StatListNode): Moved this constructor here, no longer inline. Did the "break circular list" thing instead of the "reverse list" thing. Added setLoc calls to match KJS in the KDE tree; since we don't currently use the JavaScript debugging support, it's unclear whether there's any benefit, but later we might be using it and it's good to be as close as possible. (BlockNode::BlockNode): Moved this constructor here, no longer inline. Did the "break circular list" thing instead of the "reverse list" thing. Added setLoc calls. (CaseBlockNode::CaseBlockNode): Moved this constructor here, no longer inline. Did the "break circular list" thing instead of the "reverse list" thing. (SourceElementsNode::SourceElementsNode): Moved this constructor here, no longer inline. Did the "break circular list" thing instead of the "reverse list" thing. Added setLoc calls.

kjs/grammar.cpp: Regenerated.
kjs/grammar.cpp.h: Regenerated.
kjs/grammar.h: Regenerated.

Nov 1, 2003:

9:37 PM Changeset in webkit [5355] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3470882 -- storage leaks in WebDownload code
fixed 3470884 -- download is always nil in downloadWindowForAuthenticationSheet: call from WebDownload

Misc.subproj/WebDownload.m: (-[WebDownloadInternal initWithDownload:]): Removed this method, which was never called. (-[WebDownloadInternal dealloc]): Added missing call to [super dealloc] to fix one cause of a leak of the WebDownloadInternal object itself. Removed the release of webDownload, which was always nil, and if it wasn't would end up causing a leak due to a reference cycle. (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Remove the use of webDownload, which was always nil, and instead use the download parameter passed to us, casting it to WebDownload, since it's guaranteed to be one. (-[WebDownload _setRealDelegate:]): Added. Shared by the methods below to set up the real delegate before calling init. The old code called init twice, causing an second call to the superclass's init method, which caused it to create an extra copy of its internal structure, as well as causing us to create two WebDownloadInternal objects. (-[WebDownload init]): Don't allocate a second WebDownloadInternal if _setRealDelegate already allocated it for us. Before we would allocate and leak an extra one each time. (-[WebDownload dealloc]): Added. Releases the WebDownloadInternal. This is the second cause of the leak of the WebDownloadInternal object. (-[WebDownload initWithRequest:delegate:]): Call [self _setRealDelegate:] instead of calling [self init] and then [_webInternal setRealDelegate:], avoiding the leaks caused by doing it the other way. (-[WebDownload _initWithLoadingConnection:request:response:delegate:proxy:]): Ditto. (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): Ditto. (-[WebDownload _initWithRequest:delegate:directory:]): Ditto.

7:53 PM Changeset in webkit [5354] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3469262 - REGRESSION (110-112): logitech page is very slow to load (due to style sheet updates?)

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Don't do default handling for events that don't bubble. Not 100% sure why this caused the big slowdown but it was a somewhat arbitrary change in my earlier patch.

6:01 PM Changeset in webkit [5353] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3468870 -- REGRESSION (108-109): cannot upload files (<input type=file> is broken)

kwq/KWQFileButton.mm: (KWQFileButton::filenameChanged): Pass the filename to the textChanged signal. The one without a parameter is a different signal.

3:46 PM Changeset in webkit [5352] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3466714 -- page with <object> tag with text subtype and no URL causes hang

khtml/khtml_part.cpp: (KHTMLPart::requestObject): Added a check so that an empty URL string doesn't get completed, and results in an empty KURL object. Also made the change to allow empty URLs unconditional, because I don't think it's a WebCore-specific thing on further reflection.

10:49 AM Changeset in webkit [5351] by darin

1 edit in trunk/WebCore/ChangeLog-2003-10-25

Fixed typo-type problems in some old log entries.

Oct 31, 2003:

6:23 PM Changeset in webkit [5350] by hyatt

2 edits in trunk/WebCore

Fix for 3470489, I just forgot to commit a piece of my patch. This has actually even
been reviewed by ken already.

Reviewed by kocienda

khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter):

5:26 PM Changeset in webkit [5349] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3457875 -- text disappears from fields in forms upon certain types of scrolling

kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]): Call releaseGState on the field editor and its clip view to prevent undesirable caching.

5:01 PM Changeset in webkit [5348] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3440719>: Read-only text field form controls
do not keyboard focus and do not take part in tabbing

kwq/KWQTextField.mm: (-[KWQTextField acceptsFirstResponder]): We want our text fields to accept first responder even if not editable.

Once this is fixed, this one comes along for free:

<rdar://problem/3440710>: Read-only textarea form controls should select all text when focused

4:31 PM Changeset in webkit [5347] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed 3469383 -- REGRESSION (100-111): if one line is selected on this page, too much gets copied (plain text)

khtml/khtml_part.cpp: (KHTMLPart::text): Range check the child node indices before using them to get at a child node. We don't want to set startNode or endNode to nil in any case. If the end node is set to nil, we end up copying the entire remainder of the page.

3:40 PM Changeset in webkit [5346]

1 copy
110 deletes in branches/unlabeled-1.16.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.16.4'.

3:40 PM Changeset in webkit [5345] by hyatt

13 edits in trunk/WebCore

Fix for 3470007, links don't get focus on mouse down. Fix the focus check on mouse down to actually
crawl up the content tree in order to find the nearest enclosing focusable node. Also clean up and
fix checks that improperly blurred the link after it got focused.

Fix for 3450335, AppKit widgets not obeying their desired focus policies. I renamed isSelectable to
isFocusable and then also added isMouseFocusable and isKeyboardFocusable methods.

Reviewed by kocienda

khtml/css/html4.css:
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::isFocusable):
khtml/html/html_baseimpl.h:
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isFocusable): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::isMouseFocusable):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable):
khtml/html/html_inlineimpl.h:
khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::nextFocusNode): (DocumentImpl::previousFocusNode):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isFocusable): (NodeImpl::isKeyboardFocusable): (NodeImpl::isMouseFocusable):
khtml/xml/dom_nodeimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent):

3:05 PM Changeset in webkit [5344] by kocienda

2 edits in trunk/WebCore

Reviewed by David

Fix for this bug:

<rdar://problem/3470233>: solid outlines drawing incorrectly

The problem was that when I collected the array of line boxes for
render inlines, I put a QRect() at the start and the end of the list.
However, the border calculation code expected "invalid" rectangles
(rects with 0 for all four dimentions) in the first and last
positions, and the default constructor for QRect makes rects with 1,1
for width/height.

khtml/rendering/render_inline.cpp: (RenderInline::paintOutlines)

12:14 PM Changeset in webkit [5343] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3464759 -- REGRESSION (100-107): Pressing on link loses mouse-down feedback almost instantly

khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Pass true for the "read-only" flag in prepareMoveEvent to prevent us from updating :hover and :active while the mouse is down.

11:54 AM Changeset in webkit [5342] by hyatt

4 edits in trunk/WebKit

Fix for 3466542, add a real minimum font size setting.

Reviewed by john

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences setMinimumFontSize:]): (-[WebPreferences minimumLogicalFontSize]): (-[WebPreferences setMinimumLogicalFontSize:]):
WebView.subproj/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

11:46 AM Changeset in webkit [5341] by kocienda

3 edits in trunk/WebCore

Reviewed by David

<rdar://problem/3468910>: REGRESSION: other than focus rings, outlines styles are broken

Outlines now draw like they used to.

khtml/rendering/render_inline.cpp: (RenderInline::paintObject): Now branches to call focus ring or "regular" outlines. (RenderInline::paintFocusRing): Broke out drawing aqua focus rings into its own function. (RenderInline::paintOutlines): New function to draw "regular outlines. (RenderInline::paintOutline): Removed code which special-cased aqua outlines.
khtml/rendering/render_inline.h: Added paintOutlines declaration.

11:29 AM Changeset in webkit [5340] by hyatt

9 edits in trunk/WebCore

Fix for 3467419, highlighted text in "search in books" Amazon feature is obscured. The
site is using the CSS3 opacity property. The CSS3 Color module is far enough along now
that opacity can safely be used without the "-khtml-" in front of it.

Fix for 3466542, the minimum font size bug. I am introducing a new minimum font size pref that
really is a hard override.

Reviewed by gramps (opacity) and john (min font size)

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):

8:46 AM Changeset in webkit [5339] by kocienda

5 edits in trunk

WebCore:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3469088>: focus not removed from text link
when user hits cmd-L or clicks in window chrome

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge deselectAll]): Now clears the focus ring as well. (-[WebCoreBridge deselectText]): Just clears text selection.

WebKit:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3469088>: focus not removed from text link
when user hits cmd-L or clicks in window chrome

WebView.subproj/WebHTMLView.m: (-[WebHTMLView deselectText]): Added new method just to deselect text. (-[WebHTMLView resignFirstResponder]): Just deseclect text if we are doing a programmatic setting of focus. Deselect all otherwise.

1:29 AM Changeset in webkit [5338] by hyatt

5 edits in trunk/WebCore

Three simple fixes:

(1) Fix for 3463777, crash on CSS3 box model draft. This was just a situation where a simple null-check
was needed for generated content.

(2) Added a != check when the old and new hover obj are the same to avoid a little bit of extra work.

(3) Removed the m_pressed member from DOM nodes and removed the calls to setPressed, since this code
is dead and not used by anyone.

khtml/khtmlview.cpp:
khtml/rendering/render_layer.cpp: (RenderLayer::addChild): (RenderLayer::updateHoverActiveState):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::hasStyle): (DOM::NodeImpl::setHasStyle):

Oct 30, 2003:

5:51 PM Changeset in webkit [5337] by hyatt

3 edits in trunk/WebCore

Fix for 3469330, the Marquee data in RenderStyle needs a copy constructor hack like all the other
objects do.

khtml/rendering/render_style.cpp: (direction):
khtml/rendering/render_style.h:

5:41 PM Changeset in webkit [5336] by hyatt

2 edits in trunk/WebCore

Fix for 3469206, images didn't paint outlines any more. They were bailing early because I forgot to
add a check for my new PaintAction.

Reviewed by darin

khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):

5:27 PM Changeset in webkit [5335] by hyatt

6 edits in trunk/WebCore

Fixes for 3469057, outlines not drawn on aintitcool.com and also for 3469178, objects with width/height of 0
incorrectly excluded from tabbing.

Reviewed by darin

khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isSelectable):
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isSelectable):
khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
khtml/rendering/render_inline.cpp: (RenderInline::addFocusRingRects): (RenderInline::paintOutline):
khtml/rendering/render_object.cpp: (RenderObject::addFocusRingRects): (RenderObject::getAbsoluteRepaintRectWithOutline):

4:47 PM Changeset in webkit [5334] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3426081 - empty cells HTMLCollection for <tr>
fixed 3367598 - "length" attribute for table row "cells" always returns 0

khtml/dom/html_table.cpp: (HTMLTableRowElement::cells): TR_CELLS, not TABLE_ROWS.

4:11 PM Changeset in webkit [5333] by hyatt

6 edits in trunk/WebCore

Fix for 3468916, outline needs its own paint action so that focus rings don't draw under other content.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats):
khtml/rendering/render_image.cpp: (RenderImage::paintObject):
khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer):
khtml/rendering/render_object.h:

4:09 PM Changeset in webkit [5332] by mjs

2 edits in branches/Safari-1-1-branch

Correct bug number in ChangeLogs.

3:35 PM Changeset in webkit [5331] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3458368>: drawing to the screen while window hidden: http://www.bhphotovideo.com/

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in when the window is miniaturized or hidden (-[WebBaseNetscapePluginView restartNullEvents]): don't restart null events if the window is miniaturized, this allows restartNullEvents to be called in start and viewDidMoveToWindow without needing to make the check (-[WebBaseNetscapePluginView start]): just call restartNullEvents instead of checking if the window is miniaturized

3:31 PM Changeset in webkit [5330] by mjs

2 edits in trunk/WebCore

Fixed Dave's fix to my fix to my fix:

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Put back m_render check, consider the case of image with no width/height attributes and display:none set. We don't want to crash on that. (HTMLImageElementImpl::height): Ditto.

3:28 PM Changeset in webkit [5329] by hyatt

1 edit in trunk/WebCore/khtml/html/html_imageimpl.cpp

Fix build bustage.

3:13 PM Changeset in webkit [5328]

1 copy
93 deletes in branches/unlabeled-1.41.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.41.4'.

3:13 PM Changeset in webkit [5327] by kocienda

38 edits
4 adds in trunk

WebCore:

Reviewed by Hyatt

Support for tabbing to links.

Fixes these bugs

<rdar://problem/3468395>: fix full keyboard access loop for buttons
<rdar://problem/3468397>: paint aqua focus rings around text links
<rdar://problem/3468406>: focused links do not activate by hitting

return key

<rdar://problem/3468410>: paintTextOutline in RenderText objects

should be done at a higher level

<rdar://problem/3468424>: improve function to determine if a node is

tab selectable

<rdar://problem/3468427>: add bridge function to access active

document view for a node

<rdar://problem/3468429>: links do not scroll into view when focusing
<rdar://problem/3468435>: when tabbing out of a frame, last focused

node is not cleared if it is a text link

<rdar://problem/3468436>: focus on text link does not clear when

clicking mouse in document body

<rdar://problem/3468440>: add setRect convenience to QRect
<rdar://problem/3468444>: elements paint their outlines even if they

are not visible

<rdar://problem/3468448>: setting focus on a node sets focus on all

its siblings

<rdar://problem/3468456>: cannot tab to form image input elements
<rdar://problem/3468461>: tab focus can seem to disappear from view on

pages with dhtml menus

<rdar://problem/3469021>: webcore bridge nextKeyView always starts
from the beginning of the document

WebCore-combined.exp: Export WebCoreGraphicsBridge class
WebCore.exp: Ditto
WebCore.pbproj/project.pbxproj: Add WebCoreGraphicsBridge class
khtml/css/cssparser.cpp: (CSSParser::parseValue): border style check now take apple aqua style into account
khtml/css/cssvalues.in: Add -apple-aqua border value
khtml/css/html4.css: Change focus, a:link:active, and a:visited:active to use new -apple-aqua focus rings.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isSelectable): Improve function so that invisible elements are no longer considered selectable
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isSelectable): Ditto. (HTMLAnchorElementImpl::defaultEventHandler): Make return key activate links as well as Enter.
khtml/html/html_inlineimpl.h: Move isSelectable function into implementation file.
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Do not paint outlines if content is invisible.
khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect): Improve function to correctly calculate repaint rects including outlines.
khtml/rendering/render_image.cpp: (RenderImage::paintObject): Do not paint outlines if content is invisible.
khtml/rendering/render_inline.cpp: (RenderInline::paintObject): Ditto. (RenderInline::addFocusRingRects): New function to gather up rects to use for painting outlines. (RenderInline::paintOutline): Added code to paint aqua focus rings.
khtml/rendering/render_inline.h:
khtml/rendering/render_object.cpp: (RenderObject::drawBorder): Add case for apple aqua border style. (RenderObject::addFocusRingRects): New function to gather up rects to use for painting outlines. (RenderObject::paintOutline): Added code to paint aqua focus rings. (RenderObject::getAbsoluteRepaintRectWithOutline): Helper function to calculate rectangle to use for repainting when an object has an outline.
khtml/rendering/render_object.h: Add addFocusRingRects declaration.
khtml/rendering/render_style.h: Add APPLEAQUA to border enum
khtml/rendering/render_text.cpp: (RenderText::paintObject): Removed code to draw outlines.
khtml/rendering/render_text.h: Ditto.
khtml/xml/dom_elementimpl.cpp: Removed redundant isSelectable check.
khtml/xml/dom_elementimpl.h: Ditto.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isSelectable): Added. (NodeBaseImpl::setFocus): Do not set focus on siblings.
khtml/xml/dom_nodeimpl.h: Moved implementation to .cpp file.
kwq/KWQButton.mm: (-[KWQButton nextKeyView]): Send a blur before going to next key view. This prevents focus from being lost altogether. (-[KWQButton previousKeyView]): Ditto.
kwq/KWQKHTMLPart.h: Added documentViewForNode function.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Add check for other focusables, like text links. (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Remove focus when leaving a view. (KWQKHTMLPart::documentViewForNode): Added. (KWQKHTMLPart::khtmlMousePressEvent): Remove focus when you click in a non-focusable area, like the document body.
kwq/KWQPainter.h: Added declarations.
kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): Modified constructor for new fields. (QPainter::initFocusRing): Added. (QPainter::addFocusRingRect): Added. (QPainter::drawFocusRing): Added. (QPainter::clearFocusRing): Added.
kwq/KWQRect.h: (QRect::setRect): Added.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyView]): Start from the currently-focused node, if there is one, not unconditionally from the start of the document. (-[WebCoreBridge previousKeyView]): Ditto
kwq/WebCoreGraphicsBridge.h: Added.
kwq/WebCoreGraphicsBridge.m: Added. (+[WebCoreGraphicsBridge sharedBridge]): Added. (-[WebCoreGraphicsBridge init]): Added. (-[WebCoreGraphicsBridge setFocusRingStyle:radius:color:]): Added.

WebKit:

Reviewed by Hyatt

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge documentView]): Added.
WebCoreSupport.subproj/WebGraphicsBridge.h: Added.
WebCoreSupport.subproj/WebGraphicsBridge.m: Added. (+[WebGraphicsBridge createSharedBridge]): Added. (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): Added.
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebFrameView.m: Create a WebGraphicsBridge when creating a WebFrameView.

2:51 PM Changeset in webkit [5326] by mjs

2 edits in trunk/WebCore

Fix mistake in my last change that I did not mean to commit.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Remove extraneous second attempt to lay out.

2:50 PM Changeset in webkit [5325] by hyatt

4 edits in trunk/WebCore

Put paged-media changes back without the wrongful removal of the style data copy constructors (which
were necessary after all).

ChangeLog:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/rendering/render_style.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::widows): (khtml::RenderStyle::orphans): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::setWidows): (khtml::RenderStyle::setOrphans): (khtml::RenderStyle::setPageBreakInside): (khtml::RenderStyle::setPageBreakBefore): (khtml::RenderStyle::setPageBreakAfter):

2:42 PM Changeset in webkit [5324] by mjs

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3468129 - REGRESSION: FOUC occurs on Surfin' Safari

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Don't force layout for image width/height if you can determine it statically from the attribute.

2:40 PM Changeset in webkit [5323] by mjs

5 edits in branches/Safari-1-1-branch

WebCore:

Merged fix for the following bug from HEAD:

fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent):

WebKit:

Merged fix for the following bug from HEAD:

fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]):

2:26 PM Changeset in webkit [5322] by vicki

3 edits in trunk

fixed version number. tree is open.

2:23 PM Changeset in webkit [5321]

3 copies in tags/Safari-112

This commit was manufactured by cvs2svn to create tag 'Safari-112'.

2:23 PM Changeset in webkit [5320] by vicki

3 edits in trunk

forgot to tag before setting the version number back (doh!)

2:22 PM Changeset in webkit [5319] by vicki

3 edits in trunk

tree is open for Safari-113

2:20 PM Changeset in webkit [5318] by vicki

6 edits in trunk

Safari-112 stamp

2:00 PM Changeset in webkit [5317] by kocienda

4 edits in trunk/WebCore

Reviewed by me

Rolling out this code since it caused a big performance
regression.

2003-10-29 David Hyatt <hyatt@apple.com>

Add the paged media properties to RenderStyle.
They aren't used yet, but they should now be
parsed and interpreted correctly.

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData): (StyleBoxData::StyleBoxData): (StyleBoxData::operator==): (StyleVisualData::~StyleVisualData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleFlexibleBoxData::StyleFlexibleBoxData): (opacity): (textShadow): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::~StyleInheritedData): (StyleInheritedData::operator==):
khtml/rendering/render_style.h: (khtml::StyleBackgroundData::~StyleBackgroundData): (khtml::StyleFlexibleBoxData::~StyleFlexibleBoxData): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults):

12:59 PM Changeset in webkit [5316] by mjs

1 edit in trunk/JavaScriptCore/ChangeLog

Corrected ChangeLog.

12:59 PM Changeset in webkit [5315] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

fixed 3427069 - browsing mp3.com causes leaks (KJS)

kjs/string_object.cpp: (StringProtoFuncImp::call): Don't do an early return, since that could leak a temporary regexp.

10:42 AM Changeset in webkit [5314] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by Darin.

fixed 3426076 - Leak of JS lexer data visiting http://www.ebay.com

kjs/grammar.cpp: (yyerror): Updated the commented code.
kjs/grammar.y: Don't delete string and identifier tokens when done with them any more, they'll get cleaned up by the lexer now.
kjs/internal.cpp: (Parser::parse): Tell lexer when done parsing.
kjs/lexer.cpp: (Lexer::Lexer): Initialize new data members. (Lexer::lex): Use new methods to make strings and identifiers, and save them. (Lexer::makeIdentifier): Make a new Identifier and save it in an auto-growing array. (Lexer::makeUString): Likewise for UStrings. (Lexer::doneParsing): Clean up arrays of Ifentifiers and UStrings.
kjs/lexer.h:

12:26 AM Changeset in webkit [5313] by hyatt

6 edits in trunk/WebCore

Fix for 3466628, widgets in overflow blocks don't move when the overflow block is scrolled. This
was a regression caused by my change to move widgets only during layout and not at paint time. The
problem with this is that scrolling an overflow block doesn't do a layout, just a repaint. I patched
the layer code to update widget positions on an overflow block scroll.

This then exposed a bug in absolutePosition, namely that the scroll offset was never factored in when
computing absolutePosition. This bug also explains why text selection and cursor display were wrong
inside scrolled overflow blocks.

Reviewed by mjs

khtml/rendering/render_box.cpp: (RenderBox::absolutePosition):
khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):
khtml/rendering/render_object.cpp: (RenderObject::absolutePosition):
khtml/rendering/render_text.cpp: (RenderText::cursorPos): (RenderText::posOfChar):
khtml/rendering/render_text.h:

Oct 29, 2003:

11:31 PM Changeset in webkit [5312] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed 3467632 - Leak of plugin info visiting http://www.ebay.com

Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Release lastModifiedDate.

10:55 PM Changeset in webkit [5311] by mjs

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3467499 - REGRESSION: onClick handlers on links don't work (bubbling broken)

khtml/xml/dom2_eventsimpl.cpp: (EventImpl::EventImpl): Initialize m_cancelBubble (duh).

9:45 PM Changeset in webkit [5310] by hyatt

2 edits in trunk/WebCore

Fix for 3466802. When breaking on a newline, "pre" is determined by checking the actual object that
the line broke on, and not by simply checking the "pre" status of the containing block.

Reviewed by mjs

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):

9:12 PM Changeset in webkit [5309] by hyatt

4 edits in trunk/WebCore

Add the paged media properties to RenderStyle. They aren't used yet, but they should now be
parsed and interpreted correctly.

Reviewed by kocienda

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/rendering/render_style.cpp: (StyleBoxData::operator==): (StyleFlexibleBoxData::StyleFlexibleBoxData): (:opacity): (:textShadow): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::widows): (khtml::RenderStyle::orphans): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::setWidows): (khtml::RenderStyle::setOrphans): (khtml::RenderStyle::setPageBreakInside): (khtml::RenderStyle::setPageBreakBefore): (khtml::RenderStyle::setPageBreakAfter):

5:30 PM Changeset in webkit [5308] by cblu

3 edits in trunk/WebKit

WebKit:

WebKit part of fix for:
<rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
<rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window

Reviewed by john.

WebView.subproj/WebView.m: (+[WebView _supportedMIMETypes]): new (+[WebView _supportedFileExtensions]): new
WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed:
<rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
<rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window

Reviewed by john.

BrowserDocumentController.m: (-[BrowserDocumentController _openableFileExtensions]): override, returns list of types that Safari and WebKit can handle so the NSOpenPanel properly enables files

2:36 PM Changeset in webkit [5307] by cblu

10 edits in trunk/WebKit

Fixed: <rdar://problem/3438716>: jpg and gif images copied from Safari and placed in mail are sent as tiff

Reviewed by john.

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeFileContents:withFilename:]): new
Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:originalData:rect:URL:title:event:]): now takes originalData and calls _web_fileContents:withFilename:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call _web_writeFileContents:withFilename:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): call renamed _web_dragImage and [WebView _cachedResponseForURL:] (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebView _cachedResponseForURL:]
WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call _web_writeFileContents:withFilename: (-[WebImageView mouseDragged:]): call renamed _web_dragImage
WebView.subproj/WebView.m: (-[WebView _cachedResponseForURL:]): new
WebView.subproj/WebViewPrivate.h:

1:47 PM Changeset in webkit [5306] by hyatt

2 edits in trunk/WebCore

Refine the fix to updateLayout.
updateStyleSelector would get called over and over again when you queried for layout properties from
JS. If no stylesheets are pending, this isn't necessary (and is quite expensive, since updateStyleSelector
is a slow function).

Reviewed by darin

khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateLayout):

1:15 PM Changeset in webkit [5305] by hyatt

2 edits in trunk/WebCore

Fix crasher in border collapsing code.

Reviewed by kocienda

khtml/rendering/render_table.cpp: (RenderTable::cellRight):

12:08 PM Changeset in webkit [5304] by mjs

4 edits in trunk/WebCore

Reviewed by Darin.

fixed 3163842 - Citibank cardmember central DHTML menus not working right in Safari

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): update layout before fetching image properties that need it.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_ignorePendingStylesheets to false. (DocumentImpl::updateLayout): Ignore pending stylesheets - when JS demands a layout, it wants a real one now. (DocumentImpl::updateStyleSelector): Go ahead with the update if we're ignoring pending stylesheets.
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::haveStylesheetsLoaded): Pretend stylesheets have loaded if we're temporarily ignoring pending stylesheets.

1:18 AM Changeset in webkit [5303] by hyatt

2 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for pre minwidth bugs.

1:02 AM Changeset in webkit [5302] by hyatt

2 adds in trunk/LayoutTests/fast/inline-block

Add inline block test inside a center tag.

12:57 AM Changeset in webkit [5301] by hyatt

31 edits in trunk/WebCore

Implement support for <marquee>. This includes support for the CSS3 specification (although modified a fair
bit to actually be compatible with WinIE's version and to correct obvious errors in the draft). All of the
marquee behaviors (slide, scroll, and alternate) are supported.

This patch also fixes the following bugs that were discovered while testing marquee:
(1) An error in the computation of scrollWidth and scrollHeight.
(2) The ability to ask for the leftmostPosition as well as the rightmostPosition of content and to
be able to ask for the positions of children (via left/right/lowest) without including the parent in the
computation.
(3) An optimization to RenderFlow's rightmost/lowestPosition functions to avoid examining text elements since
they are always fully accounted for by either overflow or by inline flow boxes.
(4) A fix for RTL rendering. A block with direction:RTL was being placed on the right, when in reality only
its children should be placed on the right.
(5) A fix to prevent inline blocks and tables from computing auto margins (making them just like floats in this
regard).

Reviewed by darin

khtml/css/cssparser.cpp: (validUnit): (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::convertToLength): (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/css/html4.css:
khtml/html/html_blockimpl.cpp: (HTMLMarqueeElementImpl::HTMLMarqueeElementImpl): (HTMLMarqueeElementImpl::id): (HTMLMarqueeElementImpl::parseAttribute):
khtml/html/html_blockimpl.h: (DOM::HTMLMarqueeElementImpl::minimumDelay):
khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
khtml/misc/htmlattrs.h:
khtml/misc/htmlattrs.in:
khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcWidth): (RenderBox::calcHorizontalMargins): (RenderBox::lowestPosition): (RenderBox::rightmostPosition): (RenderBox::leftmostPosition):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition): (RenderFlow::leftmostPosition):
khtml/rendering/render_flow.h:
khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPositions): (RenderLayer::scrollToOffset): (RenderLayer::computeScrollDimensions): (RenderLayer::styleChanged): (RenderLayer::stopMarquees): (m_whiteSpace): (Marquee::marqueeSpeed): (Marquee::direction): (Marquee::isHorizontal): (Marquee::computePosition): (Marquee::start): (Marquee::stop): (Marquee::updateMarqueePosition): (Marquee::updateMarqueeStyle): (Marquee::timerEvent):
khtml/rendering/render_layer.h: (khtml::): (khtml::RenderLayer::marquee):
khtml/rendering/render_object.cpp: (RenderObject::isHTMLMarquee): (RenderObject::sizesToMaxWidth):
khtml/rendering/render_object.h: (khtml::RenderObject::lowestPosition): (khtml::RenderObject::rightmostPosition): (khtml::RenderObject::leftmostPosition):
khtml/rendering/render_style.cpp: (StyleMarqueeData::StyleMarqueeData): (StyleMarqueeData::operator==): (opacity): (marquee): (StyleCSS3NonInheritedData::operator==): (RenderStyle::RenderStyle):
khtml/rendering/render_style.h: (khtml::): (khtml::StyleMarqueeData::operator!=): (khtml::RenderStyle::marqueeIncrement): (khtml::RenderStyle::marqueeSpeed): (khtml::RenderStyle::marqueeLoopCount): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::setMarqueeIncrement): (khtml::RenderStyle::setMarqueeSpeed): (khtml::RenderStyle::setMarqueeDirection): (khtml::RenderStyle::setMarqueeBehavior): (khtml::RenderStyle::setMarqueeLoopCount):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):

12:29 AM Changeset in webkit [5300] by hyatt

1 edit in trunk/LayoutTests/fast/selectors/064-expected.txt

Fixing the layout test that has a <button>

12:16 AM Changeset in webkit [5299] by hyatt

2 edits in trunk/WebCore

Make <button> be an inline-block.

khtml/css/html4.css:

Oct 28, 2003:

11:22 PM Changeset in webkit [5298] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3465547 - REGRESSION (100-111)?: window.prompt does not work

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::runJavaScriptPrompt): Return the result properly instead of always returning false.

10:31 PM Changeset in webkit [5297] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3465504 -- REGRESSION (100-111): text areas with Chinese text in them are wider than ones without

kwq/KWQTextArea.h: Add _font field.
kwq/KWQTextArea.mm: (-[KWQTextArea dealloc]): Release _font. (-[KWQTextArea setFont:]): Store font in _font as well as setting it in the text view. (-[KWQTextArea sizeWithColumns:rows:]): Use _font rather than asking the text view for the font.

9:42 PM Changeset in webkit [5296] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3464702 -- node.item(x) is not implemented (dynamic menus not filled out at techcu.com)

khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Add implementation of item function.
khtml/ecma/kjs_dom.h: Added Item to the enum.
khtml/ecma/kjs_dom.lut.h: Regenerated.

5:23 PM Changeset in webkit [5295] by mjs

6 edits in trunk/WebCore

Reviewed by Dave,

fixed 3379725 - for <a> elements with both onclick and href, Web Kit's behavior does not match other browsers

The fix for this was to make cancelBubble only prevent bubbling,
but not stop propagation or prevent default. While I was at it, I
made returnValue work right too.

khtml/ecma/kjs_events.cpp: (DOMEvent::getValueProperty): Implement cancelBubble and returnValue properties properly. (DOMEvent::putValue): Ditto.
khtml/dom/dom2_events.cpp: (Event::setCancelBubble): Call impl. (Event::setDefaultPrevented): Ditto. (Event::getCancelBubble): Ditto. (Event::defaultPrevented): Ditto.
khtml/dom/dom2_events.h:
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::propagationStopped): Made this a const method. (DOM::EventImpl::defaultPrevented): Ditto. (DOM::EventImpl::setCancelBubble): Implemented by setting a new field. (DOM::EventImpl::getCancelBubble): Corresponding getter. (DOM::EventImpl::setDefaultPrevented): Set the already existing field for this.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Check getCancelBubble() when bubbling. Do not check bubbles() before default handling.

4:39 PM Changeset in webkit [5294] by sullivan

2 edits in trunk/WebKit

fixed <rdar://problem/3466082>: 7B85/111: Crash viewing web page ([WebView setNextKeyView:])

Reviewed by Chris.

WebView.subproj/WebView.m: (-[WebView dealloc]): set _private to nil after releasing, because [super dealloc] can dispatch to it (-[WebView mainFrame]): fixed spelling error in comment

4:00 PM Changeset in webkit [5293] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3464472>: REGRESSION: New CSS cursor support breaks style="cursor:default

Reviewed by dave.

kwq/KWQWidget.mm: (QWidget::cursor): break after we hit a view that responds to documentCursor as we do in setCursor. Without breaking we were returning the cursor of the most super HTML view which is not what we want.

3:06 PM Changeset in webkit [5292] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3421393 - window.open does not handle non-integral height/width (small window at saabusa.com)

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Parse width, height, top and left as floating point and then cast to int instead of parsing as int to match other browsers and avoid rejecting floating point numbers.

2:52 PM Changeset in webkit [5291] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Ken.

fixed 3413962 - malicious web pages can kill all future JavaScript execution by breaking recursion limit check

kjs/nodes.cpp: (FunctionCallNode::evaluate): If we're going to return early due to breaking the recursion limit, make sure to lower it again, or it will creep up by one each time it's exceeded.

2:21 PM Changeset in webkit [5290] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3464528 - addEventListener does not work for buttons, text areas, or inputs

khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked): Send CLICK_EVENT as well as one of KHTML_CLICK_EVENT or KHTML_DOUBLE_CLICK_EVENT.

2:21 PM Changeset in webkit [5289] by cblu

2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop

Reviewed by john.

WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]): call _progressCompleted after we deliver the didFailLoadWithError or didFinishLoadForFrame message as we do in other places. This allows to be aware of the error (if there is one), when they get the WebViewProgressFinishedNotification notification.

WebBrowser:

Fixed:
<rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
<rdar://problem/3465910>: REGRESSION (100-110): Switching to bookmarks view shows progress bar but shouldn't

Reviewed by john.

BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebView setMainFrameLoadEndedInError:]): new (-[BrowserWebView progressFinished:]): if we have a main frame error, set the progress bar to 0
LocationChangeHandler.m: (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): call setMainFrameLoadEndedInError:NO for the main frame (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call setMainFrameLoadEndedInError:YES for the main frame

1:27 PM Changeset in webkit [5288] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didSetName:]): Tell the WebFrame about its new name.

11:52 AM Changeset in webkit [5287] by sullivan

2 edits in trunk/WebKit

fixed 3465613 -- REGRESSION (111): Crash creating nib that contains WebView

Reviewed by Chris.

WebView.subproj/WebView.m: (-[WebView mainFrame]): check for nil _private before dereferencing.

11:45 AM Changeset in webkit [5286] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3465591>: Security: Netscape plug-ins can execute JavaScript in other frames

Reviewed by mjs.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): renamed, no need to pass the target frame since the target is either the plug-in itself or the frame that contains the plug-in (-[WebBaseNetscapePluginView loadPluginRequest:]): call renamed evaluateJavaScriptPluginRequest (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): if this is a JS request that is targeted at a frame, return NPERR_INVALID_PARAM if the frame is not the frame that contains the plugin

11:40 AM Changeset in webkit [5285] by mjs

2 edits in trunk/WebCore

Fixed broken build.

kwq/KWQKPartsPart.mm: (KParts::ReadOnlyPart::setName): It's a ReadOnlyPart method, not a Part method.

11:15 AM Changeset in webkit [5284] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3437959>: javascript: URLs don't work from Java (and other Cocoa plugins, if any)

Reviewed by mjs.

Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): support JS requests targeted only to the plug-in's frame.

11:13 AM Changeset in webkit [5283] by mjs

6 edits in trunk/WebCore

Reviewed by John.

fixed 3427046 - href and src attributes don't always give resolved URL

It turns out that all href and src attributes should be resolved
against the base, except for frame elements.

khtml/dom/html_base.cpp: (HTMLIFrameElement::src): Resolve against base URL.
khtml/dom/html_form.cpp: (HTMLInputElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
khtml/dom/html_head.cpp: (HTMLBaseElement::href): Resolve against base URL. (HTMLLinkElement::href): Ditto. (HTMLScriptElement::src): Ditto.
khtml/dom/html_image.cpp: (HTMLAreaElement::href): Ditto. (HTMLImageElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
khtml/dom/html_inline.cpp: (HTMLAnchorElement::href): Resolve against base URL.

11:12 AM Changeset in webkit [5282] by mjs

7 edits
1 add in trunk/WebCore

Reviewed by Darin.

fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setName): Make sure the name is unique. Then tell the bridge and the superclass about it.
kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::setName): Made this method virtual.
kwq/KWQKPartsPart.m: Added. Moved implementations of virtual methods here.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Call the superclass method to avid sending the name pointlessly back across the bridge.

8:46 AM Changeset in webkit [5281] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3465063 -- REGRESSION (107-108): hang when fetching a page with an ad in a subframe (theage.com.au)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Follow the parent chain properly rather than repeatedly getting the part's own parent!

Oct 27, 2003:

4:51 PM Changeset in webkit [5280] by sullivan

2 edits in trunk/WebKit

fixed 3441258 -- hysteresis to start dragging a link is too small; too easy to start drag

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): Split DragHysteresis into two values, one for links and one for images. Make the link one much larger than the image one (since dragging an image doesn't occur accidentally in the ways that dragging a link does).

12:51 PM Changeset in webkit [5279]

1 copy
324 deletes in branches/unlabeled-1.70.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.70.4'.

12:51 PM Changeset in webkit [5278] by mjs

29 edits
1 add in trunk/WebCore

Reviewed by Darin.

Improved exception blocking in the following ways:

use C++ constructors and destructors so returning or breaking out of an exception block works
Remove use of volatile
Collapse the caught exception case into a single function call to reduce code size.

WebCore.pbproj/project.pbxproj:
kwq/KWQButton.mm:
kwq/KWQCheckBox.mm:
kwq/KWQComboBox.mm:
kwq/KWQExceptions.h:
kwq/KWQExceptions.mm: Added.
kwq/KWQFileButton.mm:
kwq/KWQFont.mm:
kwq/KWQFrame.mm:
kwq/KWQKConfigBase.mm:
kwq/KWQKCookieJar.mm:
kwq/KWQKCursor.mm:
kwq/KWQKHTMLPart.mm:
kwq/KWQKHTMLPartBrowserExtension.mm:
kwq/KWQKHistoryProvider.mm:
kwq/KWQKJavaAppletWidget.mm:
kwq/KWQKJobClasses.mm:
kwq/KWQKLocale.mm:
kwq/KWQKPartsBrowserInterface.mm:
kwq/KWQLineEdit.mm:
kwq/KWQListBox.mm:
kwq/KWQLoader.mm:
kwq/KWQPainter.mm:
kwq/KWQPushButton.mm:
kwq/KWQRadioButton.mm:
kwq/KWQScrollBar.mm:
kwq/KWQScrollView.mm:
kwq/KWQTextEdit.mm:
kwq/KWQWidget.mm:

12:48 PM Changeset in webkit [5277] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"

Reviewed by darin.

History.subproj/WebHistoryItem.m: (+[WebHistoryItem _destroyAllPluginsInPendingPageCaches]): Don't destroy plug-ins that are currently being viewed.

8:41 AM Changeset in webkit [5276] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed

Reviewed by john.

WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): don't allow image types to override types that are already registered as we do in [WebFrameView _viewTypesAllowImageTypeOmission:]

8:28 AM Changeset in webkit [5275] by cblu

2 edits in trunk/WebKit

Fixed:
<rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
<rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
<rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): attempt to fetch the image data from the cache, if that works, write out the file

Oct 26, 2003:

10:54 PM Changeset in webkit [5274] by darin

2 edits in trunk/WebCore

khtml/khtml_part.cpp: (findWordBoundary): Fix small mistake from NULL check-in earlier.

10:38 PM Changeset in webkit [5273] by darin

2 edits in trunk/WebCore

kwq/KWQLoader.mm: (KWQResponseMIMEType): Removed an excess volatile.

10:32 PM Changeset in webkit [5272] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Remove the word "Merlot".

10:32 PM Changeset in webkit [5271] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Updated change log to mention bug number for Merlot build fix.

10:31 PM Changeset in webkit [5270] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3463624 -- page at cinemakorea.com shows up blank due to kTECBufferBelowMinimumSizeErr from TEC

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): To work around the bug I found in the decoder (Radar 3351093), change kTECBufferBelowMinimumSizeErr to kTECOutputBufferFullStatus in cases where bytes were actually converted.

10:31 PM Changeset in webkit [5269] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed uses of NULL in non-pointer contexts

khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.

WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.

10:26 PM Changeset in webkit [5268] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3457831 -- REGRESSION: copying particular text and pasting (plain) produces lots of extra text

khtml/khtml_part.cpp: (KHTMLPart::text): Check for the end node when following a link to the parent node, not just when following a link to the next child node.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Ditto.

8:53 PM Changeset in webkit [5267] by darin

2 edits in trunk/WebKit

WebKitPrefix.h: Add a definition of NULL here so we get the stricter type checking even on pre-Merlot systems.

8:29 PM Changeset in webkit [5266] by darin

2 edits in trunk/JavaScriptCore

JavaScriptCorePrefix.h: Added a C case to the NULL definition since we use C as well as C++ in this project.

8:24 PM Changeset in webkit [5265] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Revised ChangeLog to strike a reference to Merlot.

8:21 PM Changeset in webkit [5264] by darin

3 edits in trunk/JavaScriptCore

rolled in some CString changes Harri Porten did on the KDE side

kjs/ustring.cpp: (KJS::CString::CString): Use memcpy instead of strcpy for speed. Fix an off by one error in the copy constructor. (KJS::CString::operator=): Use memcpy instead of strcpy for speed.

JavaScriptCorePrefix.h: Add a definition of NULL here that matches the one in Merlot. This makes us see warnings that otherwise would be Merlot-only warnings.

Oct 25, 2003:

4:53 PM Changeset in webkit [5263] by mjs

2 edits in trunk

JavaScriptCore:

Rolled over ChangeLog, since checkouts were getting slow again.

WebCore:

Ditto.

Oct 24, 2003:

6:02 PM Changeset in webkit [5262] by cblu

1 edit in trunk/WebKit/English.lproj/StringsNotToBeLocalized.txt

Fixed: <rdar://problem/3308160>: Safari goes bonkers on ftp:// URLs

Reviewed by hyatt.

BrowserWebController.m: (-[BrowserWebView openURLExternallyWithRequest:inFrame:]): if Safari is the handler for a URL that we are attempting to launch, unset that preference. If the URL is FTP, set the finder as the handler.

5:21 PM Changeset in webkit [5261] by vicki

3 edits in trunk

tree is open for Safari-112

5:18 PM Changeset in webkit [5260]

3 copies in tags/Safari-111

This commit was manufactured by cvs2svn to create tag 'Safari-111'.

5:18 PM Changeset in webkit [5259] by vicki

8 edits in trunk

Safari-111 stamp.

77 bugs fixed since Safari-110!

4:10 PM Changeset in webkit [5258] by rjw

5 edits in trunk

WebKit:

Fixed 3425358. Don't try to create page cache for pages that
have a nil view().

Reviewed by Hyatt.

WebView.subproj/WebFrame.m: (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]):

WebCore:

Fixed 3425358. Don't try to create page cache for pages that
have a nil view().

Reviewed by Hyatt.

kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):

3:32 PM Changeset in webkit [5257] by hyatt

3 edits in trunk/WebCore

Fix for 3133375, the minwidth computation for pres is wrong. There were a couple of bugs here.
One is that pres only should have a breakable character if they contain a newline. Otherwise they're
treated essentially like nowrap. The other was that m_beginMinWidth and m_endMinWidth needed to be
set to the maxwidth of the first line and the maxwidth of the last line respectively for pres instead of
being only the first and last words.

Reviewed by mjs

khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):

2:44 PM Changeset in webkit [5256] by hyatt

2 adds in trunk/LayoutTests/fast/text/whitespace

Adding test of unicode breakability and whitespace.

2:20 PM Changeset in webkit [5255] by hyatt

476 edits in trunk/LayoutTests

Checking in the layout test results using our current defaults and not ancient crufty defaults.

2:07 PM Changeset in webkit [5254] by hyatt

3 edits in trunk/WebCore

Two fixes to the computation of min/max width for text runs.
(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly
breaks a pre).
(2) Fix a bug where breakable characters weren't getting factored into minwidth properly. When a word got broken
because of a breakable character, we were treating the breakable character like a space, and not including its
width as part of the minimum width of the text run.

Reviewed by john

khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):

2:05 PM Changeset in webkit [5253] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): don't honor JS requests from standalone plug-ins to workaround 3462628 which is a deeper issue.

9:06 AM Changeset in webkit [5252] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded

Reviewed by john.

WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because the plug-in DB calls _viewTypesAllowImageTypeOmission:NO.

Oct 23, 2003:

4:47 PM Changeset in webkit [5251] by cblu

8 edits in trunk/WebKit

Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg

Reviewed by john.

Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Allow plug-ins to override built-in types except for our core HTML types and don't allow the QT plug-in to override any types because it handles many types that we already handle
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:): instead of asserting, handle the case where we ask a plug-in to map from an extension to a MIME type, but nil is returned (-[WebBridge frameRequiredForMIMEType:URL:]): no need to start up the plug-in DB because this is now handled by [WebView _viewClass:andRepresentationClass:forMIMEType:]
WebView.subproj/WebDataSource.m: (+[WebDataSource _representationClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (-[WebDataSource _makeRepresentation]): call _representationClassForMIMEType
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): tweak (+[WebFrameView _viewClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the MIME type is not found. This is required to fully fix 3364036. (+[WebView canShowMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (+[WebView registerViewClass:representationClass:forMIMEType:]): tweak
WebView.subproj/WebViewPrivate.h:

3:24 PM Changeset in webkit [5250] by hyatt

2 adds in trunk/LayoutTests/fast/css-generated-content

Adding generated content tests for fancy first-letter/line combos.

3:23 PM Changeset in webkit [5249] by hyatt

16 edits in trunk/WebCore

This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly. More
specifically it does the following:

(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.
The old code did this, and this was a regression from my previous patch.

(2) Fixes first-letter checking so that it happens at layout time rather than during render object
construction time, since that makes first-letter more dynamic and causes it to be discovered in cases
where it was being missed before. This fixes the front page of meyerweb.com.

(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles
cross blocks and inherit properly from enclosing containers.

(4) Make first-letter changes cause a detach/attach to fire just as when the display changes. I generalized
the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style
diff function.

(5) Fixed isBlockFlow to return true for inline-blocks.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getFirstLineBox): (khtml::RenderBlock::firstLineBlock): (khtml::RenderBlock::updateFirstLetter):
khtml/rendering/render_block.h: (khtml::RenderBlock::isBlockFlow):
khtml/rendering/render_line.cpp: (InlineFlowBox::paintBackgroundAndBorder):
khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::firstLineBlock): (RenderObject::updateFirstLetter): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::recalcMinMaxWidths): (RenderObject::style): (RenderObject::getPseudoStyle):
khtml/rendering/render_object.h: (khtml::RenderObject::overhangingContents):
khtml/rendering/render_style.cpp: (pseudoBit):
khtml/rendering/render_style.h: (khtml::RenderStyle::):
khtml/rendering/render_table.cpp: (RenderTable::firstLineBlock): (RenderTable::updateFirstLetter):
khtml/rendering/render_table.h:
khtml/rendering/render_text.cpp: (RenderText::paintObject): (RenderText::htmlFont):
khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::diff):
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::):

12:25 PM Changeset in webkit [5248] by sullivan

4 edits in trunk/WebKit

fixed 3459272 -- Can't set up keyboard loop inside a WebDocumentView without subclassing views
fixed 3179062 -- can't tab back to address bar from image-only page
fixed 3252009 -- tabbing from address bar to content area does not work with WebTextView
fixed 3461398 -- Can't click on a standalone image to focus it (for later keyboard scrolling)

I redid the way WebView and WebFrameView splice themselves into
the keyview loop in a way very similar to what NSScrollView and
NSClipView do. This means that contained and sibling views won't
need to do anything special to put themselves into the key loop.

Reviewed by Chris.

WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollView]): check for nil pointer before dereferencing; this can happen during [super dealloc]'s keyview-loop-fixup code (-[WebFrameView initWithFrame:]): wire our nextKeyView link to the contained scrollview (so previousKeyView will work correctly from scrollview) (-[WebFrameView acceptsFirstResponder]): return what the contained scrollview says (-[WebFrameView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained scrollview (which will in turn hand it down to clipview, which will in turn hand it down to document) (-[WebFrameView setNextKeyView:]): wire up scrollview instead of self, if it exists

WebView.subproj/WebImageView.m: (-[WebImageView acceptsFirstResponder]): overridden to return YES; this fixes 3461398 and puts the finishing touches on 3179062

WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]): wire our nextKeyView link to the contained webframeview (so previousKeyView will work correctly from webframeview). Also, if there's a nextKeyView already set (in a nib, e.g.), wire it to our contained webframeview. (-[WebView acceptsFirstResponder]): return what the contained webframeview says (-[WebView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained webframeview (which will in turn hand it down to scrollview, etc.) (-[WebView setNextKeyView:]): wire up webframeview instead of self, if it exists

8:41 AM Changeset in webkit [5247] by kocienda

3 edits in trunk/WebCore

Reviewed by David

Fix for these bugs:

<rdar://problem/3171929>: Safari picks a different button in a
form when you hit return if the first button has no name
<rdar://problem/3200386>: investigate which button is activated
when hitting return in form text input fields

HTML spec says that buttons must have names to be considered
successful. However, other browsers do not impose this constraint.
Therefore, we behave differently, and can use different buttons than
the author intended.

khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::isSuccessfulSubmitButton) (HTMLInputElementImpl::isSuccessfulSubmitButton)

Oct 22, 2003:

7:03 PM Changeset in webkit [5246] by hyatt

6 edits in trunk/WebCore

Fix for 3460726, the user agent string was returning nil.

Fix for 3386544, empty documents did not get a layout, and so they looked white. Also fixed the positioning
of widgets to account for border/padding in updateWidgetPositions.

Fix for espn.com crasher, 3458143, caused by layout object not being properly cleared when layouts were
unscheduled.

Reviewed by darin

khtml/khtmlview.cpp:
khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::userAgent):

6:01 PM Changeset in webkit [5245] by mjs

3 edits in trunk/WebCore

Reviewed by

fixed 3460664 - Exception handlers not properly removed

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mouseMoved): Don't return from exception block (KWQKHTMLPart::khtmlMouseReleaseEvent): Add exception blocking (whoops)

5:43 PM Changeset in webkit [5244] by sullivan

3 edits in trunk/WebCore

fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a frameset page

Reviewed by Darin (actually he made the change on my machine)

khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::defaultEventHandler): only set defaultHandled for the one event that we actually handle (mouse event to resize frame borders); this was always being set, hence preventing key events from being used elsewhere.

5:27 PM Changeset in webkit [5243] by rjw

10 edits in trunk/LayoutTests

Updated to account for change in metrics

5:10 PM Changeset in webkit [5242] by rjw

8 edits in trunk

WebKit:

Match WebCore's notion of distributing linegap between top and bottom of
line. WebKit used to put it all at the bottom of the line.

Reviewed by Hyatt.

WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

WebCore:

Fixed 3454067. RenderText's repaint wasn't called because of recent changes to de-virtualize repaint. Modified getAbsoluteRepaintRect() to return containing block's getAbsoluteRepaintRect().

Also removed the long standing +1 from QFontMetrics::height().

Reviewed by Hyatt.

khtml/rendering/render_text.cpp: (RenderText::getAbsoluteRepaintRect):
khtml/rendering/render_text.h:
kwq/KWQFontMetrics.mm: (QFontMetrics::height):

4:18 PM Changeset in webkit [5241] by mjs

3 edits in trunk/JavaScriptCore

Fix broken build.

kjs/simple_number.h:

3:36 PM Changeset in webkit [5240] by hyatt

5 edits in trunk/WebCore

Fix visibility to be done when widgets are added or when styles are set rather than at paint time. Fixes
the ads painting on top of content at tvguide.com.

Reviewed by cblu

khtml/rendering/render_replaced.cpp: (RenderWidget::setQWidget): (RenderWidget::setStyle): (RenderWidget::paintObject):
kwq/KWQWidget.h:
kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::show): (QWidget::hide):

2:31 PM Changeset in webkit [5239] by mjs

4 edits in trunk/JavaScriptCore

Merged 64-bit compilation fixes, and fixes for handling negative 0
from upstream kjs.

kjs/internal.cpp:
kjs/simple_number.h: (KJS::SimpleNumber): fixed constants; added negZero constant. (KJS::SimpleNumber::is): adjusted to use long and not int. (KJS::SimpleNumber::value): ditto. (KJS::SimpleNumber::fits): ditto; also don't allow -0 to fit, so we don't lose the distinction between -0 and +0. (KJS::SimpleNumber::make): adjusted to use long.

1:33 PM Changeset in webkit [5238] by mjs

8 edits in trunk

WebCore:

Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
fixed 3311511 - nil deref inside KJS::Screen
fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
fixed 3413224 - unrepro crash in KJS::Window::mark
fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()

WebCore.pbproj/project.pbxproj:
kwq/KWQFontMetrics.mm:
kwq/KWQPainter.mm: (QPainter::drawPixmap): (QPainter::drawTiledPixmap): (QPainter::_updateRenderer):
kwq/WebCoreTextRenderer.h:

WebKit:

Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
fixed 3311511 - nil deref inside KJS::Screen
fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
fixed 3413224 - unrepro crash in KJS::Window::mark
fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer ascent]): (-[WebTextRenderer descent]): (-[WebTextRenderer lineSpacing]): (-[WebTextRenderer xHeight]): (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): (-[WebTextRenderer _smallCapsRenderer]): (-[WebTextRenderer _initializeATSUStyle]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

1:25 PM Changeset in webkit [5237] by rjw

2 edits in trunk/WebKit

WebBrowser:

Fixed 3458715. Only update progress for current tab, and
update progress when tab is switched.

Reviewed by Chris.

BrowserWebController.m: (-[BrowserWebView _updateProgressBar]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
BrowserWindowController.m: (-[BrowserWindowController didSelectTabViewItem]):

WebKit:

Fixed 3458715. Reset to 0, not .1 when done.

Reviewed by Chris.

WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]):

Oct 21, 2003:

7:22 PM Changeset in webkit [5236] by hyatt

3 edits in trunk/WebCore

http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk.
Fixed backgrounds repeated when they weren't supposed to.

khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):

5:10 PM Changeset in webkit [5235] by rjw

2 edits in trunk/WebKit

Don't use small caps font for characters that don't have an
uppercase counterpart (i.e. punctuation marks).

Reviewed by Hyatt.

WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):

3:14 PM Changeset in webkit [5234] by hyatt

11 edits in trunk/WebCore

Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked
for by the front end render objects. Also fix first-letter to inherit properly from first-line styles.

Reviewed by mjs

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
khtml/css/cssstyleselector.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::createInlineBox): (RenderObject::style): (RenderObject::getPseudoStyle):
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (pseudoBit): (RenderStyle::hasPseudoStyle): (RenderStyle::setHasPseudoStyle): (RenderStyle::getPseudoStyle): (RenderStyle::addPseudoStyle):
khtml/rendering/render_style.h: (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults):
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject): (RenderText::htmlFont):

2:17 PM Changeset in webkit [5233] by mjs

3 edits in trunk/WebCore

Reviewed by Dave.

More exception blocking.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::generateFrameName): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (regExpForLabels): (KWQKHTMLPart::clearRecordedFormValues): (KWQKHTMLPart::recordFormValue): (KWQKHTMLPart::submitForm): (KHTMLPart::frameDetached): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::createPart): (KWQKHTMLPart::setTitle): (KWQKHTMLPart::setStatusBarText): (KWQKHTMLPart::scheduleClose): (KWQKHTMLPart::unfocusWindow): (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::redirectionTimerStartedOrStopped): (KWQKHTMLPart::userAgent): (KWQKHTMLPart::mimeTypeForFileName): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::currentEventIsMouseDownInWidget): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::saveDocumentState): (KWQKHTMLPart::restoreDocumentState): (KWQKHTMLPart::requestedURLString): (KWQKHTMLPart::incomingReferrer): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::createEmptyDocument): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::lastEventIsMouseUp): (findViewInSubviews): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::passSubframeEventToSubframe): (KWQKHTMLPart::buttonForCurrentEvent): (KWQKHTMLPart::stateForCurrentEvent): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::mouseDragged): (KWQKHTMLPart::mouseUp): (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): (KWQKHTMLPart::mouseMoved): (KWQKHTMLPart::sendContextMenuEvent): (fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::keyboardUIMode):

11:47 AM Changeset in webkit [5232] by cblu

7 edits in trunk

WebCore:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:
kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:

WebKit:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]): If no plug-in is found from the extension, attempt to map from the extension to a MIME type using our mappings and find a plug-in from the MIME type. This improves our chances of finding a plug-in when no MIME type is specified.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types. (-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.

Oct 20, 2003:

1:35 PM Changeset in webkit [5231] by cblu

9 edits in trunk/WebKit

Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
Fixed issues with plug-in stream error handling.
Improved plug-in logging.

Reviewed by kocienda.

Misc.subproj/WebKitLogging.h: added WebKitLogPluginEvents
Misc.subproj/WebKitLogging.m:
Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): improved logging (-[WebBaseNetscapePluginStream destroyStream]): improved logging (-[WebBaseNetscapePluginStream destroyStreamWithFailingReason:]): renamed from cancelWithReason to avoid confusion (-[WebBaseNetscapePluginStream receivedError:]): calls destroyStreamWithFailingReason after determining a reason from the NSError (-[WebBaseNetscapePluginStream cancelWithReason:]): calls destroyStreamWithFailingReason, this method is overriden by subclasses to cancel the actual load (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call destroyStreamWithFailingReason, not cancelWithReason because the loaded has already ended here (-[WebBaseNetscapePluginStream deliverData]): improved logging
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): use even logging (-[WebBaseNetscapePluginView sendUpdateEvent]): ditto (-[WebBaseNetscapePluginView becomeFirstResponder]): ditto (-[WebBaseNetscapePluginView resignFirstResponder]): ditto (-[WebBaseNetscapePluginView mouseDown:]): ditto (-[WebBaseNetscapePluginView mouseUp:]): ditto (-[WebBaseNetscapePluginView mouseEntered:]): ditto (-[WebBaseNetscapePluginView mouseExited:]): ditto (TSMEventHandler): ditto (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelWithReason so the reason is passed back to the plug-in
Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): tweak
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call receivedError (-[WebNetscapePluginRepresentation cancelWithReason:]): override, cancel the load, call super
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): override, cancel the load, call super (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): be sure to call the stream before calling super because the stream can be cleared out when calling super (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

11:49 AM Changeset in webkit [5230] by rjw

2 edits in trunk/WebKit

Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
has been fixed. This patch switches to the new UTI typing API for pasteboard types.

Reviewed by Ken.

Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):

11:22 AM Changeset in webkit [5229] by hyatt

2 adds in trunk/LayoutTests/fast/css-generated-content

Add test for floating/positioning generated content.

11:18 AM Changeset in webkit [5228] by hyatt

4 edits in trunk/WebCore

Fix generated content (before/after) so that it no longer has any restrictions on it. CSS2.1 lifted
restrictions preventing the floating/positioning of generated content.

Reviewed by rjw

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):

11:09 AM Changeset in webkit [5227] by rjw

5 edits in trunk/WebKit

WebBrowser

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.
Reviewed by Chris.

Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleAlternateProgress:]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]):

WebKit

Fixed 3456103. Don't assert, just check for inappropriate state.
Reviewed by Hyatt

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.

Also did some shuffling around of inline related stuff.

Reviewed by Chris.

WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (isControlCharacter): (isAlternateSpace): (isSpace): (getUncachedWidth): (widthFromMap): (widthForGlyph): (+[WebTextRenderer _setAlwaysUseATSU:]): (glyphForCharacter): (glyphForUnicodeCharacter): (shouldUseATSU):
WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): (-[WebView _progressCompleted:]):
WebView.subproj/WebViewPrivate.h:

10:28 AM Changeset in webkit [5226] by kocienda

15 edits in trunk/WebCore

Reviewed by David

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Change over to use ascii value for key code. (UIEvent::which): Ditto. (KeyboardEvent::KeyboardEvent): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEvent::operator = ): New function. (KeyboardEvent::~KeyboardEvent): New function. (KeyboardEvent::ctrlKey): New function. (KeyboardEvent::shiftKey): New function. (KeyboardEvent::altKey): New function. (KeyboardEvent::metaKey): New function. (KeyboardEvent::altGraphKey): New function. (KeyboardEvent::initKeyboardEvent): New function.
khtml/dom/dom2_events.h: Ditto.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Use key identifiers to test which key was pressed, instead of removed keyVal(). (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new class name. Use key identifiers to test which key was pressed, instead of removed keyVal(). Use new modifier accessors.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (EventImpl::idToType): Ditto. (KeyboardEventImpl::KeyboardEventImpl): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEventImpl::~KeyboardEventImpl): Ditto. (KeyboardEventImpl::initKeyboardEvent): Ditto.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (DOM::KeyboardEventImpl::keyIdentifier): New function. (DOM::KeyboardEventImpl::keyLocation): New function. (DOM::KeyboardEventImpl::ctrlKey): New function. (DOM::KeyboardEventImpl::shiftKey): New function. (DOM::KeyboardEventImpl::altKey): New function. (DOM::KeyboardEventImpl::metaKey): New function. (DOM::KeyboardEventImpl::altGraphKey): New function. (DOM::KeyboardEventImpl::qKeyEvent): New function.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Now can create keyboard events.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Class name changes.
kwq/KWQEvent.h: Added QString identifier member.
kwq/KWQEvent.mm: (hexDigit): Added helper. (identifierForKeyText): Added new function to map keys to DOM key identifiers as listed in the DOM spec. (QKeyEvent::identifier): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::stateForCurrentEvent): Added check to see if a key press is on one of the numeric keypad keys.
kwq/KWQLogging.h: Added log constant for DOM events.
kwq/KWQLogging.m: Ditto

8:42 AM Changeset in webkit [5225] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content

Reviewed by darin.

WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): manage the isStoppingLoad ivar, return if isStoppingLoad is YES
WebView.subproj/WebFramePrivate.h: added the isStoppingLoad ivar

7:59 AM Changeset in webkit [5224] by darin

2 edits in trunk/WebKit

Reviewed by Dave and Ken.

fixed 3457066 -- REGRESSION (91-92): command-left-arrow causes a scroll to the left before going back

WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): Add an else so that we don't fall into the scrolling code when the command key is down for right and left arrow.

12:09 AM Changeset in webkit [5223] by hyatt

2 adds in trunk/LayoutTests/fast/css-generated-content

Adding first-letter/before text-transform tests.

12:07 AM Changeset in webkit [5222] by hyatt

7 edits in trunk/WebCore

Make first-letter and before/after work with text transforms.

Reviewed by mjs

khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::isTextFragment): (RenderText::originalString): (RenderText::setText): (m_generatedContentStr): (m_start): (RenderTextFragment::~RenderTextFragment): (RenderTextFragment::isTextFragment): (RenderTextFragment::originalString):
khtml/rendering/render_text.h: (khtml::RenderTextFragment::start): (khtml::RenderTextFragment::end): (khtml::RenderTextFragment::contentString):
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::setRenderer):

12:05 AM Changeset in webkit [5221] by hyatt

2 edits in trunk/LayoutTests/fast

Layout tests affected by the removal of the list float quirk.

12:02 AM Changeset in webkit [5220] by hyatt

3 edits in trunk/WebCore

Remove the "flow-around-floats" hack for lists. Other browsers don't do this.

Reviewed by darin

khtml/css/quirks.css:

Oct 19, 2003:

11:57 PM Changeset in webkit [5219] by hyatt

3 edits in trunk/WebCore

Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
case. I forgot to deal with colspans.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTable::cellRight): (RenderTableCell::collapsedRightBorder):

9:16 PM Changeset in webkit [5218] by hyatt

3 edits in trunk/WebCore

Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::encoding): (HTMLTextAreaElementImpl::value):

5:45 PM Changeset in webkit [5217] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)

kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything after a question mark as a query, just the way the hierarchical code does. This makes the code that constructs the mailto URL work properly.

11:08 AM Changeset in webkit [5216] by cblu

7 edits
1 add in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it

Reviewed by darin.

English.lproj/Localizable.strings:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDocumentPrivate.h: Added.
WebView.subproj/WebImageRepresentation.h:
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release new filename and data ivars (-[WebImageRepresentation doneLoading]): return YES if data is non-nil (-[WebImageRepresentation setDataSource:]): store the filename (-[WebImageRepresentation receivedError:withDataSource:]): store the data (-[WebImageRepresentation finishedLoadingWithDataSource:]): store the data (-[WebImageRepresentation data]): new (-[WebImageRepresentation filename]): new
WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it (-[WebImageView image]): new

WebBrowser:

Fixed:
<rdar://problem/3456752>: Filename when saving a standalone image includes "nxn pixels"
<rdar://problem/3177870>: Context menu for standalone images should be "Save Image As..." not "Download Image to Disk"

Reviewed by darin.

BrowserDocument.m: (-[BrowserDocument displayName]): If we are saving a standalone image, use the responses suggestedFilename
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): If this is a context menu for a standalone image, provide "Save Image As..." and "Copy Image to Clipboard" (-[BrowserWebView saveDocumentAs:]): renamed from savePageAs to be more generic
English.lproj/StringsNotToBeLocalized.txt:

Oct 18, 2003:

8:09 PM Changeset in webkit [5215] by darin

2 edits in trunk/WebCore

Tweak some old log entries.

4:25 PM Changeset in webkit [5214] by hyatt

2 adds in trunk/LayoutTests/fast/block/positioning

Add minmax test for positioned elements.

4:23 PM Changeset in webkit [5213] by hyatt

4 edits in trunk/WebCore

Fix the intrinsic minmax width computation for blocks and XUL boxes to actually check fixed min/max CSS widths.

Reviewed by darin

khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):

2:30 PM Changeset in webkit [5212] by hyatt

7 edits in trunk/WebCore

Change the names of the border-spacing properties to border-horizontal-spacing and border-vertical-spacing.

Reviewed by NOBODY (Straightforward).

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):

2:27 PM Changeset in webkit [5211] by hyatt

1 delete in trunk/LayoutTests/fast/table/border-collapsing/004.html~

Remove accidental commit of a ~ file.

2:27 PM Changeset in webkit [5210] by hyatt

3 adds in trunk/LayoutTests/fast/table/border-collapsing

Adding another border-collapsing test.

2:13 PM Changeset in webkit [5209] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Dave.

fixed 3367015 -- interdependent variable declarations in for loop don't work (they go backwards)

kjs/nodes.h: (KJS::ForNode::ForNode): Add a new overload of the constructor for when the first parameter is a variable declaration list. Call reverseList as we do in other constructors that take lists that are built backwards.
kjs/nodes.cpp: (ForNode::reverseList): Added. New helper function.

1:54 PM Changeset in webkit [5208] by hyatt

2 edits in trunk/WebCore/khtml/rendering

Accidentally removed a FIXME comment. Putting it back.

1:50 PM Changeset in webkit [5207] by hyatt

2 adds in trunk/LayoutTests/fast/text/whitespace

Adding minmax width test for the mozilla web site beta bug.

1:49 PM Changeset in webkit [5206] by hyatt

2 adds in trunk/LayoutTests/fast/selectors

Adding test for classname parsing bug.

1:48 PM Changeset in webkit [5205] by hyatt

5 edits in trunk/WebCore

Fix for diveintomark className parsing bug. class="bigblue blue" would fail to match a rule with .blue.
The bug was in the selector matching code for class attributes.

Also fixing a minmax width bug for blocks on the mozilla.org Web site. XUL boxes had the same bug as
well.

Reviewed by darin

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):

2:28 AM Changeset in webkit [5204] by hyatt

3 edits in trunk/WebCore

Fix for 3443502, generated content sometimes doesn't generate. The bug is caused by an
uninitialized variable. m_isContinuation needed to be set to false in the RenderInline
constructor.

Reviewed by NOBODY (it's a simple obvious fix)

khtml/rendering/render_inline.cpp: (m_isContinuation):

Oct 17, 2003:

4:57 PM Changeset in webkit [5203] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

make text areas set the base writing direction based on the direction in the CSS style

kwq/KWQTextArea.h: Added setBaseWritingDirection method.
kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setWordWrap:]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setBaseWritingDirection:]): Added. New method that sets the base writing direction in both the style of the text and the typing attributes. (-[NSTextView _KWQ_typingParagraphStyle]): Added. Helper method to make setBaseWritingDirection: a little less gigantic. (-[NSTextView _KWQ_setTypingParagraphStyle:]): Ditto. (-[NSTextStorage _KWQ_setBaseWritingDirection:]): Ditto.

kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Set both alignment and base writing direction.

4:35 PM Changeset in webkit [5202] by cblu

2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com

Reviewed by kocienda.

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): call super before calling plug-in code as we do in other callbacks (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

WebBrowser:

Fixed: <rdar://problem/3456246>: repro assertion failure in DowloadViewController pressing cmd-. when active download is not selected

Reviewed by kocienda.

DownloadViewController.m: (-[DownloadViewController _stopSelection]): Removed the assertion because it is OK to call this method when there are no downloads to stop

4:06 PM Changeset in webkit [5201] by hyatt

7 adds in trunk/LayoutTests/fast/table/border-collapsing

Add border-collapsing tests.

3:32 PM Changeset in webkit [5200] by hyatt

20 edits in trunk/WebCore

Implement horizontal and vertical border-spacing. Allow them to be specified individually.

Reviewed by mjs

------

Fix the calcWidth method of tables to account for horizontal margins properly.

Reviewed by john

------

Implement border collapsing in tables.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c:
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
khtml/rendering/render_form.cpp: (RenderFieldset::paintBorderMinusLegend):
khtml/rendering/render_object.cpp: (RenderObject::paintBorder): (RenderObject::collectBorders):
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::): (khtml::CollapsedBorderValue::precedence): (khtml::CollapsedBorderValue::width): (khtml::CollapsedBorderValue::style): (khtml::CollapsedBorderValue::exists): (khtml::CollapsedBorderValue::color): (khtml::CollapsedBorderValue::isTransparent): (khtml::CollapsedBorderValue::operator==): (khtml::RenderStyle::borderLeft): (khtml::RenderStyle::borderRight): (khtml::RenderStyle::borderTop): (khtml::RenderStyle::borderBottom): (khtml::RenderStyle::horizontalBorderSpacing): (khtml::RenderStyle::verticalBorderSpacing): (khtml::RenderStyle::setHorizontalBorderSpacing): (khtml::RenderStyle::setVerticalBorderSpacing):
khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTable::paint): (RenderTable::borderLeft): (RenderTable::borderRight): (RenderTable::borderTop): (RenderTable::borderBottom): (RenderTable::cellAbove): (RenderTable::cellBelow): (RenderTable::cellLeft): (RenderTable::cellRight): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (compareBorders): (RenderTableCell::collapsedLeftBorder): (RenderTableCell::collapsedRightBorder): (RenderTableCell::collapsedTopBorder): (RenderTableCell::collapsedBottomBorder): (RenderTableCell::borderLeft): (RenderTableCell::borderRight): (RenderTableCell::borderTop): (RenderTableCell::borderBottom): (collapsedBorderStyle): (CollapsedBorder::CollapsedBorder): (CollapsedBorders:::count): (CollapsedBorders::addBorder): (CollapsedBorders::nextBorder): (addBorderStyle): (RenderTableCell::collectBorders): (RenderTableCell::paintCollapsedBorder): (RenderTableCell::paintObject): (RenderTableCell::paintBoxDecorations):
khtml/rendering/render_table.h: (khtml::RenderTable::hBorderSpacing): (khtml::RenderTable::vBorderSpacing): (khtml::RenderTable::bordersPaddingAndSpacing): (khtml::RenderTable::currentBorderStyle):
khtml/rendering/table_layout.cpp: (FixedTableLayout::layout): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):

Oct 16, 2003:

5:36 PM Changeset in webkit [5199] by mjs

5 edits in trunk/WebCore

Reviewed by John.

More exception blocking.

kwq/KWQFont.mm: (QFont::isFixedPitch): (QFont::getNSFont):
kwq/KWQKJobClasses.mm: (KIO::TransferJob::~TransferJob):
kwq/KWQLoader.mm: (KWQServeRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQResponseMIMEType):

5:17 PM Changeset in webkit [5198] by rjw

2 edits in trunk/WebKit

Fixed 3455306. Ensure that progress is correctly ended when a load is interupted (i.e. becomes a download).

Reviewed by mjs.

WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):

4:40 PM Changeset in webkit [5197] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content

Reviewed by rjw.

Misc.subproj/WebDownload.m: fixed build failure when using new Foundation. We are overriding and calling a renamed method. Continue to override the old method, override the new method and declare their interfaces to avoid build failures.
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): cancel the load before telling the plug-in about the error so plug-in code doesn't attempt to cancel the load twice

3:37 PM Changeset in webkit [5196]

5 copies in tags/Safari-110

This commit was manufactured by cvs2svn to create tag 'Safari-110'.

3:37 PM Changeset in webkit [5195] by vicki

2 edits in trunk/WebCore

move the Safari-110 marker in the ChangeLog

3:27 PM Changeset in webkit [5194] by vicki

3 edits in trunk/WebCore

Reviewed by vicki.

fix buildit build failure

kwq/KWQScrollView.mm: (QScrollView::resizeContents):

2:59 PM Changeset in webkit [5193] by rjw

2 edits in trunk/WebKit

Fixed 3453991. We weren't setting the array cursor correctly after changing
capacity.

Reviewed by John.

ChangeLog:
History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):

2:50 PM Changeset in webkit [5192] by vicki

3 edits in trunk

tree is open for Safari-111

2:44 PM Changeset in webkit [5191] by vicki

5 edits in trunk

The rest of the Safari-110 stamp

2:42 PM Changeset in webkit [5190] by vicki

3 edits in trunk/JavaScriptCore

top level:

configure.in: Add "OptimizedWithSymbols" build style.

Tools:

Scripts/autovicki: Renamed from run-tests.
Scripts/run-tests: Run autovicki passing all arguments (for compatibility with the humor-impaired).

JavaScriptCore:

kjs/create_hash_table: Remove stray semicolon.

kjs/array_object.lut.h:
kjs/date_object.lut.h:
kjs/lexer.lut.h:
kjs/math_object.lut.h:
kjs/number_object.lut.h:
kjs/string_object.lut.h: Regenerated.

Tests:

JSUnit/jsunit/app/jsUnitTestManager.js: Commented the lines I changed to work around bug 3269212 in WebCore.

WebCore:

Reviewed by Ken.

change "volatile X * volatile" to "X * volatile" in cases where the pointer needs to be volatile but the object pointed to do does not

kwq/KWQKConfigBase.mm: (KConfig::readEntry):
kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
kwq/KWQLineEdit.mm: (QLineEdit::text):
kwq/KWQScrollView.mm: (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::getDocumentView):
kwq/KWQTextEdit.mm: (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
kwq/KWQWidget.mm: (QWidget::getOuterView): Removed the excess volatiles and excess casts that go with them.

kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also remove an unnecessary nil check that is the same as QString::fromNSString's default behavior.

WebKit:

Tweaked the progress behavior and factored cleanup of progress
related ivars.

Reviewed by Hyatt.

WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]):
WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _progressCompleted:]): (-[WebView _incrementProgressForConnection:data:]):
WebView.subproj/WebViewPrivate.h:

WebBrowser:

Coalesce drawing of progress bar (like old behavior). This fixes a performance regression.
Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

Reviewed by Hyatt.

BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController _newUpdateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController showCompleteProgressBar]): (-[BrowserWindowController clearProgressBar]):
TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKitExamples:

CarbonDownloader/English.lproj/main.nib: Changed command key equivalent for Close to Cmd-W. Since this is example code and not localized, the localization freeze should not be an issue.
CarbonDownloader/English.lproj/main~.nib: Removed.

2:11 PM Changeset in webkit [5189] by mjs

5 edits in trunk/WebCore

Roll out earlier change, since the tree was closed.

1:55 PM Changeset in webkit [5188] by mjs

5 edits in trunk/WebCore

Reviewed by John.

More exception blocking.

kwq/KWQFont.mm: (QFont::isFixedPitch): (QFont::getNSFont):
kwq/KWQKJobClasses.mm: (KIO::TransferJob::~TransferJob):
kwq/KWQLoader.mm: (KWQServeRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQResponseMIMEType):

12:56 PM Changeset in webkit [5187] by rjw

5 edits in trunk/WebKit

WebBrowser:

Coalesce drawing of progress bar (like old behavior). This fixes a performance regression.
Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

Reviewed by Hyatt.

BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController _newUpdateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController showCompleteProgressBar]): (-[BrowserWindowController clearProgressBar]):
TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKit:

Tweaked the progress behavior and factored cleanup of progress
related ivars.

Reviewed by Hyatt.

WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]):
WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _progressCompleted:]): (-[WebView _incrementProgressForConnection:data:]):
WebView.subproj/WebViewPrivate.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed