⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 16, 2003:

8:03 PM Changeset in webkit [5812] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • WebCoreSupport.subproj/WebBridge.m: ObjC runtime needs a declaration for new _calculatedExpiration SPI in NSURLResponse in Foundation
7:21 PM Changeset in webkit [5811] by rjw
  • 2 edits in trunk/WebKit

Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
iterators. Much faster, better cheaper, etc.

Reviewed by Dave.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):
5:46 PM Changeset in webkit [5810] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3510956, crash on mezzoblue.com. Relax the float-list searching code that runs when
a float is removed.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (checkFloats): (RenderObject::removeFromObjectLists):
5:33 PM Changeset in webkit [5809] by rjw
  • 2 edits in trunk/WebKit

Fixed 3503011. Added '-' and '?' to rounding hack.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (isRoundingHackCharacter): (widthForNextCharacter):
5:30 PM Changeset in webkit [5808] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • finished fix to 3109132: can't open movie file via open panel
  • WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]): Include all the extensions for each MIME type, not jus the preferred one.
4:53 PM Changeset in webkit [5807] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3512199>: WebBridge expiresTimeForResponse can be
improved to use better expiration calculations

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): Switch to use new _calculatedExpiration SPI method on NSURLResponse.
1:19 PM Changeset in webkit [5806] by rjw
  • 2 edits in trunk/JavaScriptCore

Ack! More assertions. Lock ALL entry points into the interpreter!
(3511733).

Reviewed by Ken.

  • bindings/jni_jsobject.cpp: (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::removeMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::convertJObjectToValue):
11:33 AM Changeset in webkit [5805] by sullivan
  • 2 edits in trunk/WebCore

fixed <rdar://problem/3482852>: oft-seen, non-repro, nil-deref in
HTMLTokenizer::notifyFinished (snapfish.com, etc.)

At least one of the dupes of this bug is a separate (still reproducible) issue;
I'll clone it back to life and test the others.

Reviewed by Darin.

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::notifyFinished): Move check of cachedScript.isEmpty() until after scriptExecution() call, because cachedScript.isEmpty() value can be changed by that call.

Dec 15, 2003:

10:24 PM Changeset in webkit [5804] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed a couple of snafus and removed some logging.

Reviewed by Maciej.

  • bindings/jni_jsobject.cpp: (Bindings::performJavaScriptAccess): (Bindings::completedJavaScriptAccess): (Bindings::dispatchToJavaScriptThread): Removed some annoying JS_LOG clutter.

(Bindings::RootObject::removeAllJavaReferencesForRoot):
Fixed allocation of key buffer that was called after it was needed.

(Bindings::JSObject::invoke):
(Bindings::JSObject::JSObject):
(Bindings::JSObject::getMember):
(Bindings::JSObject::getSlot):
Added additional interpreter locks around getMember and getSlot.
These functions may cause allocation of JS impls.

5:27 PM Changeset in webkit [5803] by rjw
  • 3 edits in trunk/JavaScriptCore

args weren't passed to 'call' invocation. d'oh.
lock interpreter when we create instances of JS impls.

Reviewed by Maciej.

  • bindings/jni_jsobject.cpp: (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::convertValueToJObject): (Bindings::JSObject::convertJObjectToValue): (Bindings::JSObject::listFromJArray):
  • bindings/jni_jsobject.h:
4:45 PM Changeset in webkit [5802] by hyatt
  • 8 edits in trunk/WebCore

Fix for 3508807, positions/sizes wrong for text elts and multi-line elts for accessibility.

Reviewed by john

  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
  • khtml/rendering/render_text.h:
  • kwq/KWQAccObject.mm: (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]):
3:14 PM Changeset in webkit [5801] by rjw
  • 9 edits in trunk

JavaScriptCore:

Last piece of LiveConnect! This checkin adds implementation
of the Java to JavaScript object conversion functions.

Reviewed by John.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_utility.cpp:
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (Bindings::JSObject::invoke): (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::createNative): (Bindings::JSObject::convertValueToJObject): (Bindings::JSObject::convertJObjectToValue): (Bindings::JSObject::listFromJArray):
  • bindings/jni_jsobject.h: (Bindings::):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::get): (RuntimeMethodImp::codeType): (RuntimeMethodImp::execute):

WebCore:

Return 0 if the view doesn't have a bridge.

Reviewed by John.

  • kwq/WebCoreBridge.mm: (rootForView):
1:44 PM Changeset in webkit [5800] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using cert downloaded with Safari

Reviewed by john.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): set up the SecAccessRef with "everything goes" restrictions
1:38 PM Changeset in webkit [5799] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3508792. Remove tables and cells as AxObjects.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):
1:28 PM Changeset in webkit [5798] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3510459>: REGRESSION (100-113): Pressing button at google.com removes focus from text field

Reviewed by Dave.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't clear the focused widget when a mousedown occurs on a widget that is focusable in the abstract sense but is not mouse focusable or currently keyboard focusable. This matches the behavior of older Safaris (clicking in background or page text will make the webview itself be first responder, but clicking on a button won't).

Dec 14, 2003:

8:58 PM Changeset in webkit [5797] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3458937: nil-deref in timed layout
  • khtml/khtmlview.cpp: (KHTMLView::layout): Add a nil check for m_part.
4:46 PM Changeset in webkit [5796] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Maciej.

  • fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::click): Add a case for FILE that calls RenderFileButton's click() function. Get rid of the default case and list more cases explicitly. (HTMLInputElementImpl::accessKeyAction): Change FILE from just focus to focus/click.
  • khtml/rendering/render_form.h: Added a click() function to RenderFileButton.
  • khtml/rendering/render_form.cpp: (RenderFileButton::slotTextChanged): Added call to onChange on the element to match text input fields; helpful for the test case Adobe supplied. (RenderFileButton::click): Added. Calls click() on KWQFileButton.
  • kwq/KWQFileButton.h: Added a click function.
  • kwq/KWQFileButton.mm: (KWQFileButton::click): Added. Calls performClick on the file button.
  • kwq/WebCoreBridge.h: Add a performClick method to WebCoreFileButton.

WebKit:

Reviewed by Maciej.

  • fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton performClick]): Add method for clicking, now part of the WebCoreFileButton protocol. The rest of the fix is in WebCore.
3:50 PM Changeset in webkit [5795] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3269212>: FILEMAKER: can't use Option objects created in a different window

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::updateDOMObjectDocument): Update per-document caching for the DOM object - let it be protected by both the old and the new document.
  • khtml/ecma/kjs_binding.h: Prototype new method.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::setDocument): New method to change a node's document pointer. (NodeImpl::checkAddChild): If the new child node is owned by the wrong document but not actually in it, change its document (using the two aforementioned methods) instead of throwing an exception.
  • khtml/xml/dom_nodeimpl.h: Prototype new method.
9:10 AM Changeset in webkit [5794] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3332280: REGRESSION (74-85): setting src of iframe results in two GETs
  • khtml/html/html_baseimpl.h: Added openURL virtual function.
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Call openURL to do the meat of the work, since it's different for frames and iframes. (HTMLFrameElementImpl::openURL): Move the part that's different for frames in here. (HTMLFrameElementImpl::parseAttribute): Call setLocation to share code. (HTMLFrameElementImpl::setLocation): Do nothing if the location is not changing. Not needed to fix this bug, but could eliminate other cases of extra GETs. (HTMLIFrameElementImpl::parseAttribute): Remove special handling of SRC, because now we will end up calling openURL, which will do the right thing for iframes. (HTMLIFrameElementImpl::openURL): Instead of doing the change to the frame directly, use updateWidget, since that's what we do for other changes to iframes. To trigger a call to updateWidget(), set needWidgetUpdate and mark the node changed.

Dec 13, 2003:

10:43 PM Changeset in webkit [5793] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507885>: REGRESSION (100-116): frames missing due to cross-domain check (derstandard.at)

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen the frame access rules a bit. We already allowed access to a document loaded as empty from the parent or opener. Now also allow access from any document in the same domain as the parent or opener, so that, for instance, a sibling frame can access it so long as it is in the same domain as the parent.
4:43 PM Changeset in webkit [5792] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506204: homepage.mac slide show window is wrong size on 2nd monitor
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add code to flip the Y coordinate. This has no effect on the main screen, but a big effect on others. I used the same code to flip Y screen coordinates that is used KWQWindowWidget.mm and KWQKHTMLPartBrowserExtension.mm.
  • kwq/KWQKWinModule.mm: (KWinModule::workArea): Replaced the incorrect code to flip the Y coordinate here with correct code. The code flipped based on the frame of the main screen, but it needs to flip based on the frame of screen 0.
10:06 AM Changeset in webkit [5791] by darin
  • 2 edits in trunk/WebKit

Fixed by Ed Voas, reviewed by me.

  • fixed 3278443: CARBON: grow box obscures scroll bar knob
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _growBoxRect]): Return the grow box so AppKit's scroll bar code will know where it is.

Dec 12, 2003:

10:08 PM Changeset in webkit [5790] by kocienda
  • 305 edits
    2 deletes in branches

Reviewed by me

Merged HEAD to tip of branch

  • ChangeLog:
  • English.lproj/InfoPlist.strings:
  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): (DOM::Document::createElementNS): (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity): (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::classInfo): (KJS::HTMLElement::tryGet): (KJS::HTMLElementFunction::tryCall): (KJS::HTMLCollection::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/kjs_window.cpp: (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/ecma/xmlhttprequest.h: (KJS::XMLHttpRequest::):
  • khtml/ecma/xmlhttprequest.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/html/dtd.cpp:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified): (HTMLDocumentImpl::createElement):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::attach): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler): (HTMLKeygenElementImpl::parseAttribute): (HTMLKeygenElementImpl::encoding):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmlediting.cpp: (InputTextCommand::applyToDocument):
  • khtml/html/htmlediting.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/misc/loader.cpp: (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paint):
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::setMaximalOutlineSize): (khtml::RenderCanvas::maximalOutlineSize):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::updateLayerPositions): (RenderLayer::beginTransparencyLayers): (RenderLayer::scrollToOffset): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline): (RenderObject::isEditable): (RenderObject::setPixmap): (RenderObject::maximalOutlineSize):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DocumentImpl::createElement): (DocumentImpl::importNode): (DocumentImpl::createElementNS): (DocumentImpl::setTitle): (DocumentImpl::createHTMLElement): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv): (DocumentImpl::isValidName): (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::cloneNode): (ElementImpl::toString):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent): (NodeImpl::dispatchWindowEvent):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::processingInstruction): (XMLTokenizer::finish): (XMLTokenizer::executeScripts):
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::nextKeyViewInFrame): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): (KSSLKeyGen::signedPublicKeyAndChallengeString):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime):
  • kwq/KWQNSViewExtras.h:
  • kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle): (operator<<):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): (QScrollView::ensureVisible): (QScrollView::ensureRectVisibleCentered):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:
  • layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/lxr.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/my.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/news.cnet.com/index-expected.txt:
  • layout-tests/apple-only/base/slashdot.org/index-expected.txt:
  • layout-tests/apple-only/base/web.icq.com/index-expected.txt:
  • layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
  • layout-tests/apple-only/base/www.amazon.com/index-expected.txt:
  • layout-tests/apple-only/base/www.apple.com/index-expected.txt:
  • layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
  • layout-tests/apple-only/base/www.excite.com/index-expected.txt:
  • layout-tests/apple-only/base/www.expedia.com/index-expected.txt:
  • layout-tests/apple-only/base/www.google.com/index-expected.txt:
  • layout-tests/apple-only/base/www.iplanet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
  • layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
  • layout-tests/apple-only/base/www.moviefone.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
  • layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
  • layout-tests/apple-only/base/www.sun.com/index-expected.txt:
  • layout-tests/apple-only/base/www.time.com/index-expected.txt:
  • layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
  • layout-tests/apple-only/base/www.yahoo.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com_Gamespot.com/index-expected.txt:
  • layout-tests/css1/basic/class_as_selector-expected.txt:
  • layout-tests/css1/basic/comments-expected.txt:
  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/basic/contextual_selectors-expected.txt:
  • layout-tests/css1/basic/grouping-expected.txt:
  • layout-tests/css1/basic/id_as_selector-expected.txt:
  • layout-tests/css1/basic/inheritance-expected.txt:
  • layout-tests/css1/box_properties/acid_test-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_color-expected.txt:
  • layout-tests/css1/box_properties/border_color_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_style-expected.txt:
  • layout-tests/css1/box_properties/border_style_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/cascade/cascade_order-expected.txt:
  • layout-tests/css1/cascade/important-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/classification/list_style-expected.txt:
  • layout-tests/css1/classification/list_style_image-expected.txt:
  • layout-tests/css1/classification/list_style_position-expected.txt:
  • layout-tests/css1/classification/list_style_type-expected.txt:
  • layout-tests/css1/classification/white_space-expected.txt:
  • layout-tests/css1/color_and_background/background-expected.txt:
  • layout-tests/css1/color_and_background/background_attachment-expected.txt:
  • layout-tests/css1/color_and_background/background_color-expected.txt:
  • layout-tests/css1/color_and_background/background_image-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/color_and_background/background_repeat-expected.txt:
  • layout-tests/css1/color_and_background/color-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_family-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/font_properties/font_style-expected.txt:
  • layout-tests/css1/font_properties/font_variant-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/horizontal_formatting-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text-transform-expected.txt:
  • layout-tests/css1/text_properties/text_align-expected.txt:
  • layout-tests/css1/text_properties/text_decoration-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/text_transform-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/color_units-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/css1/units/percentage_units-expected.txt:
  • layout-tests/css1/units/urls-expected.txt:
  • layout-tests/fast/block/basic/010-expected.txt:
  • layout-tests/fast/block/basic/011-expected.txt:
  • layout-tests/fast/block/float/001-expected.txt:
  • layout-tests/fast/block/float/004-expected.txt:
  • layout-tests/fast/block/float/005-expected.txt:
  • layout-tests/fast/block/float/006-expected.txt:
  • layout-tests/fast/block/float/013-expected.txt:
  • layout-tests/fast/block/float/014-expected.txt:
  • layout-tests/fast/block/float/016-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/001-expected.txt:
  • layout-tests/fast/block/margin-collapse/005-expected.txt:
  • layout-tests/fast/block/margin-collapse/006-expected.txt:
  • layout-tests/fast/block/margin-collapse/010-expected.txt:
  • layout-tests/fast/block/margin-collapse/011-expected.txt:
  • layout-tests/fast/block/margin-collapse/012-expected.txt:
  • layout-tests/fast/block/margin-collapse/015-expected.txt:
  • layout-tests/fast/block/margin-collapse/016-expected.txt:
  • layout-tests/fast/block/margin-collapse/017-expected.txt:
  • layout-tests/fast/block/margin-collapse/018-expected.txt:
  • layout-tests/fast/block/margin-collapse/019-expected.txt:
  • layout-tests/fast/block/margin-collapse/020-expected.txt:
  • layout-tests/fast/block/margin-collapse/021-expected.txt:
  • layout-tests/fast/block/margin-collapse/022-expected.txt:
  • layout-tests/fast/block/margin-collapse/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/025-expected.txt:
  • layout-tests/fast/block/margin-collapse/026-expected.txt:
  • layout-tests/fast/block/margin-collapse/027-expected.txt:
  • layout-tests/fast/block/margin-collapse/028-expected.txt:
  • layout-tests/fast/block/margin-collapse/029-expected.txt:
  • layout-tests/fast/block/margin-collapse/031-expected.txt:
  • layout-tests/fast/block/margin-collapse/032-expected.txt:
  • layout-tests/fast/block/margin-collapse/033-expected.txt:
  • layout-tests/fast/block/margin-collapse/034-expected.txt:
  • layout-tests/fast/block/margin-collapse/035-expected.txt:
  • layout-tests/fast/block/margin-collapse/041-expected.txt:
  • layout-tests/fast/block/margin-collapse/042-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/positioning/001-expected.txt:
  • layout-tests/fast/block/positioning/002-expected.txt:
  • layout-tests/fast/block/positioning/053-expected.txt:
  • layout-tests/fast/block/positioning/056-expected.txt:
  • layout-tests/fast/block/positioning/058-expected.txt:
  • layout-tests/fast/block/positioning/060-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/compact/001-expected.txt:
  • layout-tests/fast/compact/002-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/css/005-expected.txt:
  • layout-tests/fast/dynamic/001-expected.txt:
  • layout-tests/fast/dynamic/007-expected.txt: Added.
  • layout-tests/fast/dynamic/007.html: Added.
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/025-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/lists/007-expected.txt:
  • layout-tests/fast/overflow/005.html: Added.
  • layout-tests/fast/replaced/001-expected.txt:
  • layout-tests/fast/replaced/002-expected.txt:
  • layout-tests/fast/replaced/003-expected.txt:
  • layout-tests/fast/replaced/004-expected.txt:
  • layout-tests/fast/selectors/001-expected.txt:
  • layout-tests/fast/selectors/006-expected.txt:
  • layout-tests/fast/selectors/007a-expected.txt:
  • layout-tests/fast/selectors/008-expected.txt:
  • layout-tests/fast/selectors/012-expected.txt:
  • layout-tests/fast/selectors/013-expected.txt:
  • layout-tests/fast/selectors/015-expected.txt:
  • layout-tests/fast/selectors/027-expected.txt:
  • layout-tests/fast/selectors/058-expected.txt:
  • layout-tests/fast/table/001-expected.txt:
  • layout-tests/fast/table/003-expected.txt:
  • layout-tests/fast/table/005-expected.txt:
  • layout-tests/fast/table/009-expected.txt:
  • layout-tests/fast/table/016-expected.txt:
  • layout-tests/fast/table/024-expected.txt:
  • layout-tests/fast/table/025-expected.txt:
  • layout-tests/fast/table/031-expected.txt:
  • layout-tests/fast/table/032-expected.txt:
  • layout-tests/fast/table/033-expected.txt:
  • layout-tests/fast/text/basic/012-expected.txt:
  • layout-tests/fast/text/international/003-expected.txt: Added.
  • layout-tests/fast/text/international/003.html: Added.
  • layout-tests/fast/text/whitespace/002-expected.txt:
  • layout-tests/fast/text/whitespace/003-expected.txt:
  • layout-tests/fast/text/whitespace/004-expected.txt:
  • layout-tests/fast/text/whitespace/005-expected.txt:
  • layout-tests/fast/text/whitespace/010-expected.txt:
  • layout-tests/fast/text/whitespace/011-expected.txt:
  • layout-tests/fast/text/whitespace/012-expected.txt:
  • layout-tests/fast/text/whitespace/015-expected.txt:
  • layout-tests/fast/text/whitespace/016-expected.txt:
  • layout-tests/fast/text/whitespace/017-expected.txt:
  • layout-tests/fast/text/whitespace/018-expected.txt:
  • layout-tests/fast/text/whitespace/021-expected.txt:
  • layout-tests/fast/text/whitespace/024-expected.txt:
10:08 PM Changeset in webkit [5789]
  • 1 copy
    117 deletes in branches/unlabeled-1.48.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.

7:23 PM Changeset in webkit [5788] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Fix build-bustin' typo.
5:37 PM Changeset in webkit [5787] by rjw
  • 6 edits in trunk/JavaScriptCore

Added implementation of stubs in JSObject. All that
remains is a couple of simple conversion functions stubs and
we're done with LiveConnect. Also, changed string passing to
JS to use uchars instead of chars.

Reviewed by Maciej.

4:57 PM Changeset in webkit [5786] by cblu
  • 13 edits in trunk

WebCore:

Fixed: <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::encoding): pass the page URL to signedPublicKeyAndChallengeString
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): take a URL
  • kwq/WebCoreKeyGenerator.h:
  • kwq/WebCoreKeyGenerator.m: (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a URL

WebKit:

Fixed:
<rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
<rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • English.lproj/Localizable.strings:
  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): take a key description arg and use it, take and return CFStrings, handle the empty string case (addCertificatesToKeychainFromData): return a WebCertificateParseResult so WB knows how to handle the cert
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a page URL so we can use its host name in the key description
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: <rdar://problem/3506645>: open PKCS7 encoded certificates downloaded from Verisign in Keychain Access

Reviewed by rjw.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): open PKCS7 files in Keychain Access
  • English.lproj/StringsNotToBeLocalized.txt:
4:23 PM Changeset in webkit [5785] by hyatt
  • 11 edits in trunk/WebCore

Fix for 3254534, CSS background-image style should be loaded lazily only when used.

Reviewed by rjw

  • ChangeLog:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
3:25 PM Changeset in webkit [5784] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3508825>: REGRESSION (100-116): crash in HTMLGenericFormElementImpl::attach at sonyericsson.com

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Move a few lines inside an existing nil check to prevent nil dereference.
2:01 PM Changeset in webkit [5783] by sullivan
  • 4 edits in trunk/WebCore
  • fixed <rdar://problem/3508760>: tabbing to out-of-sight link behaves differently than tabbing to out-of-sight form control

Reviewed by Dave.

  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): added comments and changed parameter names to reveal differences between what we've implemented and what QScrollView was intended to do. (QScrollView::ensureRectVisibleCentered): New method that calls _KWQ_scrollRectToVisible, which is the method we use when scrolling to reveal form controls.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): call ensureRectVisibleCentered so tabbing to a link will use the same scroll-to-reveal code as tabbing to a form control
12:18 PM Changeset in webkit [5782] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507856>: XMLHttpRequest xhtml test displays but doesn't load

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): complete the URL using the document, not the htmlDocument.
12:01 PM Changeset in webkit [5781] by vicki
  • 2 edits in trunk/WebKit

Reviewed by me.

  • change the WebKit version number back to 118u for tip of tree builds
  • WebKit.pbproj/project.pbxproj:
11:14 AM Changeset in webkit [5780]
  • 4 copies in tags/Safari-117

This commit was manufactured by cvs2svn to create tag 'Safari-117'.

11:14 AM Changeset in webkit [5779] by vicki
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (OOPS!).

  • fix version number for submission (117)
  • WebKit.pbproj/project.pbxproj:
10:14 AM Changeset in webkit [5778] by vicki
  • 2 edits in trunk/WebKit

Reviewed by kocienda.

  • fix buildit build bustage. INSTALL_PATH should be '=', not '+=' (probably changed unintentionally)
  • WebKit.pbproj/project.pbxproj:
9:32 AM Changeset in webkit [5777] by rjw
  • 6 edits in trunk

JavaScriptCore:

Ensure that all calls from Java into JavaScript are
performed on a designated thread (the main thread).

Reviewed by Ken.

  • bindings/jni_jsobject.cpp: (isJavaScriptThread): (rootForImp): (Bindings::performJavaScriptAccess): (Bindings::completedJavaScriptAccess): (Bindings::initializeJavaScriptAccessLock): (Bindings::lockJavaScriptAccess): (Bindings::unlockJavaScriptAccess): (Bindings::dispatchToJavaScriptThread): (Bindings::RootObject::setFindRootObjectForNativeHandleFunction): (Bindings::RootObject::removeAllJavaReferencesForRoot): (Bindings::JSObject::invoke): (Bindings::JSObject::JSObject): (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::removeMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::toString): (Bindings::JSObject::finalize): (Bindings::JSObject::getWindow):
  • bindings/jni_jsobject.h: (Bindings::RootObject::~RootObject): (Bindings::RootObject::findRootObjectForNativeHandleFunction): (Bindings::RootObject::runLoop): (Bindings::RootObject::performJavaScriptSource): (Bindings::):

WebCore:

Replace calls to global functions with static member functions.

Reviewed by Ken.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):

Dec 11, 2003:

5:54 PM Changeset in webkit [5776] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3464315>: createDocument creates document with initial child element, unlike other browsers

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Don;t add initial element.
5:32 PM Changeset in webkit [5775] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507863>: XMLHttpRequest should not parse response if HTML

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
4:48 PM Changeset in webkit [5774] by rjw
  • 12 edits in trunk

JavaScriptCore:

Added support for calling a JavaScript function from
Java. Right now this only works for void func(void)
functions, but the conversion of args and return values
will come shortly.

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Removed link hack for testkjs now that the Java folks think
they have a solution for the 1.4.2 JavaVM link problem. Although
Greg B. thinks his solution may cause problems for the 1.3.1
version of the VM!?!

Reviewed by Ken.

  • Makefile.am:
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue): (convertValueToJObject): (listFromJArray):
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (KJS_setFindRootObjectForNativeHandleFunction): (KJS_findRootObjectForNativeHandleFunction): (getReferencesByRootDictionary): (getReferencesDictionary): (findReferenceDictionary): (rootForImp): (addJavaReference): (removeJavaReference):
  • bindings/jni_jsobject.h: (Bindings::RootObject::RootObject): (Bindings::RootObject::~RootObject): (Bindings::RootObject::setRootObjectImp): (Bindings::RootObject::rootObjectImp): (Bindings::RootObject::setInterpreter): (Bindings::RootObject::interpreter):

WebCore:

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
3:56 PM Changeset in webkit [5773] by kocienda
  • 6 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded

Now POST requests reload the main document by default, but will not reload
all subresources.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Take the cache policy for subresources from the original request, rather than the data source's current request.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient _isPostOrRedirectAfterPost:redirectResponse:]): New helper. (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Call new helper to set the cache policy on the main resource load.
3:50 PM Changeset in webkit [5772] by mjs
  • 5 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507862>: XMLHttpRequest documents that reference external resources (e.g. stylesheets) cause crash

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::processingInstruction): (XMLTokenizer::executeScripts):
3:30 PM Changeset in webkit [5771] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3507859>: Status text should only include "OK", not full "HTTP/1.0 200 OK" status line

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getStatusText): Include only the status text, not the full status line.
2:59 PM Changeset in webkit [5770]
  • 1 copy
    25 deletes in branches/unlabeled-1.275.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.275.2'.

2:59 PM Changeset in webkit [5769] by vicki
  • 3 edits in trunk

the tree is open for Safari-118

2:55 PM Changeset in webkit [5768] by vicki
  • 6 edits in trunk

Safari-117 stamp, plus a few site changes

1:43 PM Changeset in webkit [5767] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: time_t is a signed type, so casting -1 to a time_t does not work to make a max value. We'll go with INT_MAX.
11:48 AM Changeset in webkit [5766] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix duplicate changelog entry

11:46 AM Changeset in webkit [5765] by hyatt
  • 203 edits in trunk/LayoutTests

Landing changed layout tests that don't dump incorrect backgrounds.

11:39 AM Changeset in webkit [5764] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3507164, scrolling really slow on hixie's web forms spec page. Hixie has 12 little transparent layers
at various points on this page, and beginning/ending transparency on only those 12 layers as you scroll
is enough to kill scrolling performance.

This patch works around the issue by lazily beginning transparency layers only when we determine that
we're actually painting a descendant layer of a transparent ancestor or a transparent layer.

Also fixing QColor's comparison operator. It was broken and not comparing the "valid" bit, so invalid and
valid colors were being assumed to be the same.

Also fixed the render dumper to not dump transparent and invalid background colors and fixed it do dump the
alpha for colors with an alpha < 0xFF.

Reviewed by mjs (opacity changes), darin (color changes) and john (render tree dumper changes)

  • ChangeLog:
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::beginTransparencyLayers): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
11:12 AM Changeset in webkit [5763] by kocienda
  • 4 edits in trunk/WebKit

Reviewed and C++ heavy-lifting by Darin

Fix warnings in C++ files.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Add cast to remove warning. (addCertificatesToKeychainFromData): Add cast to remove warning.
  • WebKit.pbproj/project.pbxproj: Add back warnings to C++ files.
  • WebKitPrefix.h: Add define for NULL that works for C++.
11:00 AM Changeset in webkit [5762] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): Fixed deployment build bustage.
8:11 AM Changeset in webkit [5761] by kocienda
  • 7 edits in trunk

WebCore:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • khtml/misc/loader.cpp: (Loader::slotFinished): Don't reset expiration date. We set this once in slotReceivedResponse. (Loader::slotReceivedResponse): Call new KWQ function to get a cache object's expiration date using its NSURLResponse data. (Cache::requestImage): Don't reset expiration date. We set this once in slotReceivedResponse, and we do not want the value from the DocLoader anyway. (Cache::requestStyleSheet): Ditto. (Cache::requestScript): Ditto.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): New function. Call over bridge to get access to SPI in NSURLResponse to calculate expiration time.
  • kwq/WebCoreBridge.h: Declare bridge method.

WebKit:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): New method. Call response freshness lifetime method and add it to the current time to yield an expiration time.

Dec 10, 2003:

10:56 PM Changeset in webkit [5760] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3504156>: XMLHttpRequest reuse test fails
<rdar://problem/3505158>: XMLHttpRequest "abort with open" test fails

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequestProtoFunc::tryCall):
10:50 PM Changeset in webkit [5759] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507175>: Setting timeout function can allocate JS objects without lock

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Lock interpreter around code that might allocate JS objects.
10:26 PM Changeset in webkit [5758]
  • 1 copy
    126 deletes in branches/unlabeled-1.1.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.2'.

10:26 PM Changeset in webkit [5757] by hyatt
  • 1 add in trunk/LayoutTests/fast/overflow/005.html

Adding overflow test with auto height.

10:25 PM Changeset in webkit [5756] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3507097, overflow:auto should include the height of the horizontal scrollbar when the height
of the block is auto.

Reviewed by darin

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren):
9:15 PM Changeset in webkit [5755] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506739: nil-deref in DocumentImpl::setSelection triple clicking (generated content)
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): Check for the case where m_selectionEnd is 0. This doesn't fix the behavior completely, but it does prevent a crash.
8:55 PM Changeset in webkit [5754] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Richard.

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData):
  • khtml/ecma/xmlhttprequest.h:
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString):
  • kwq/WebCoreBridge.h:

WebKit:

Reviewed by Richard.

WebKit part of fix for:

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
8:55 PM Changeset in webkit [5753] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed regression in JavaScript tests reported by the KDE guys
  • fixed 3506345: REGRESSION (115-116): VIP: chordfind.com no longer displays chords
  • kjs/ustring.h: Add tolerateEmptyString parameter to toDouble and toULong.
  • kjs/ustring.cpp: (KJS::UString::toDouble): Separate the "tolerant" parameter into two separate ones: tolerateTrailingJunk and tolerateEmptyString. Add new overloads; better for code size and binary compatibility than default parameter values. (KJS::UString::toULong): Pass tolerateEmptyString down to toDouble. Add new overload.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Pass false for the new "tolerate empty string" parameter.
8:49 PM Changeset in webkit [5752] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506706: REGRESSION (100-115): onkeyup handlers called twice for active input fields
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]): Don't call super because we don't want to pass the event down the responder chain.
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Return NO for key up events because we don't want to pass the event down the responder chain.
8:47 PM Changeset in webkit [5751] by hyatt
  • 1 edit in trunk/JavaScriptCore/bindings/jni_jsobject.cpp

Fix optimized build bustage.

6:20 PM Changeset in webkit [5750] by rjw
  • 11 edits in trunk

WebKit:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): (-[WebViewFactory bridgeForView:]):

WebCore:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:

JavaScriptCore:

Added code to manage reference counting of JavaScript
objects passed to Java. Also added implementation of
KJS_JSCreateNativeJSObject. This is the function that
provides the root object to Java (KJS::Window).

Reviewed by Hyatt.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni_jsobject.cpp: (KJS_setFindObjectForNativeHandleFunction): (KJS_findObjectForNativeHandleFunction): (getReferencesByOwnerDictionary): (getReferencesDictionary): (findReferenceDictionary): (addJavaReference): (removeJavaReference): (removeAllJavaReferencesForOwner):
  • bindings/jni_jsobject.h:
5:47 PM Changeset in webkit [5749] by sullivan
  • 10 edits in trunk

WebCore:

  • WebCore part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin.

  • kwq/KWQNSViewExtras.h:
  • kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]): new methods, similar to existing scrollRect methods except that the preferred position for the point is the top-left corner rather than centered in the visible area
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): new method, calls _KWQ_scrollPointRecursive:
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): call setContentsPosRecursive instead of setContentsPos; also remove the 50 pixel offset that upset Hyatt so.

WebKit:

  • WebKit part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: removed _web_scrollPointToVisible:fromView:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]): removed call to _web_scrollPointToVisible:fromView:
4:34 PM Changeset in webkit [5748] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): tweak (addCertificateToKeychainFromData): renamed to use lowercase "c" in "keychain" (addCertificatesToKeychainFromData): take data instead of a path to a file
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): added temporary workaround for 3396936

WebBrowser:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by me, kocienda.

  • BrowserNSDataExtras.h:
  • BrowserNSDataExtras.m: new categories implemented by kocienda. (-[NSData indexOfCharacterInCString:]): (-[NSData indexOfCString:]): (-[NSData indexOfCString:startOffset:]): (-[NSData indexOfByteString:length:]): (-[NSData indexOfByteString:length:startOffset:]): (-[NSData certificateFromMultipartData]): extracts the cert
  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): if the file is multipart/mixed, attempt to extract the cert using certificateFromMultipartData
2:39 PM Changeset in webkit [5747] by cblu
  • 2 edits in trunk/WebCore
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): removed unnecessary includes
2:34 PM Changeset in webkit [5746] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3505846, overflow:auto region doesn't update when scrolled. The child layers inside an overflow:auto
block were not updating their positions.

Reviewed by john

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPositions): (RenderLayer::scrollToOffset):
  • khtml/rendering/render_layer.h:
1:47 PM Changeset in webkit [5745] by mjs
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Corrected ChangeLog entry.

1:46 PM Changeset in webkit [5744] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3505795>: loading invalid XML document crashes trying to create h1 element

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::isValidName): include "0123456789" instead of "0-9", it's not a regexp it's just a list of characters.
1:42 PM Changeset in webkit [5743] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3504155>: Safari fails XMLHttpRequest abort test

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): Avoid throwing an exception after send().
1:14 PM Changeset in webkit [5742] by hyatt
  • 11 edits in trunk/WebCore

Rename -apple-aqua to auto for outline styles.

Reviewed by darin

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline):
  • khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle):

Dec 9, 2003:

8:09 PM Changeset in webkit [5741] by mjs
  • 7 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487195>: Implement responseXML property for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented responseXML by parsing the document and returning it. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new field
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/kjs_window.cpp: (Windw::get): Forgot this in last commit; add XMLSerializer constructor.
  • khtml/ecma/kjs_window.lut.h:
  • khtml/ecma/Makefile.am: Forgot to include this in the last commit.
8:05 PM Changeset in webkit [5740] by mjs
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3504049>: XMLSerializer object and serializeToString method needed for XMLHttpRequest testing

Also fixed some lasst-minute mistakes in the DOM serialization
code that was already there.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::toString):
5:23 PM Changeset in webkit [5739] by hyatt
  • 4 edits in trunk/WebCore

Implement start() and stop() for marquees.

Reviewed by darin

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::classInfo): (KJS::HTMLElementFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
5:05 PM Changeset in webkit [5738] by rjw
  • 3 edits
    2 adds in trunk/JavaScriptCore

LiveConnect stubs that correspond to the native methods
on JSObject. These will be called from the new Java plugin
when an instance of JSObject is instantiated and messaged.
When these are implemented the Java will be able to originate
calls into JavaScript.

Also a temporary work-around added to Makefile.am to solve
a link problem. The 1.4.2 JavaVM accidentally links against
libobjc. This call a failure linking testkjs. Mike Hay is
working with someone to fix the problem (3505587).

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni_jsobject.cpp: Added. (KJS_JSCreateNativeJSObject): (KJS_JSObject_JSFinalize): (KJS_JSObject_JSObjectCall): (KJS_JSObject_JSObjectEval): (KJS_JSObject_JSObjectGetMember): (KJS_JSObject_JSObjectSetMember): (KJS_JSObject_JSObjectRemoveMember): (KJS_JSObject_JSObjectGetSlot): (KJS_JSObject_JSObjectSetSlot): (KJS_JSObject_JSObjectToString):
  • bindings/jni_jsobject.h: Added.
4:53 PM Changeset in webkit [5737] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3505277: nil-deref in ownerElement after choosing item from menu at projectnissan.com
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Add check for nil.
4:46 PM Changeset in webkit [5736] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveLocationProperties): Add locking around the call to get the location since it can allocate. (KWQKHTMLPart::restoreLocationProperties): Ditto.
4:29 PM Changeset in webkit [5735] by hyatt
  • 2 edits in trunk/WebCore

Fix for mojibake bg painting problem on bofa.com. The bug # is 3487144. Transparent colors were not
being handled properly when specified on the body.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
3:39 PM Changeset in webkit [5734] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3505391: REGRESSION (100-116): pages that move cells around don't repaint correctly
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added code similar to the code in RenderBlock::layoutBlock, but for table cells.
3:38 PM Changeset in webkit [5733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add locking around the call to push event handler scope. Without this, we hit the "allocated without locking" assertion.
3:15 PM Changeset in webkit [5732] by hyatt
  • 5 edits in trunk/WebCore

Fix the dirty rect checks on various render_objects to be more accurate so that page-break properties don't
have mojibake when printing.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_table.cpp: (RenderTable::paint):
3:01 PM Changeset in webkit [5731] by darin
  • 5 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3500408: Web Kit should pass the MAYSCRIPT attribute from the APPLET tag to the Java plug-in
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): Allow the "mayscript" attribute. (HTMLAppletElementImpl::createRenderer): Pass the value of the "mayscript" attribute as an argument named "mayScript".
  • khtml/misc/htmlattrs.in: Added "mayscript".
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.
2:26 PM Changeset in webkit [5730] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/3505183>: JavaScriptCore should assert that interpreter is locked in collector

  • kjs/collector.cpp: (KJS::Collector::allocate): Assert that interpreter lock count is not 0. (KJS::Collector::collect): likewise
2:26 PM Changeset in webkit [5729] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3501030>: JavaScript sites crash when a PAC file is in place (WebCore,Safari 1.2)

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Lock interpreter when needed. (JSLazyEventListener::parseCode): Likewise. (KJS::getDOMEvent): Likewise.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Likewise. (KJSProxyImpl::initScript): Likewise.
2:11 PM Changeset in webkit [5728] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3491235, really make <script src="..."/> work in HTML. My original attempt to fix this only made
the tag flat, but did not ensure that the script got processed.

Reviewed by john

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
1:52 PM Changeset in webkit [5727] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): (addCertificateToKeyChainFromData): new (addCertificateToKeyChainFromFile): new
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]): new
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj: made WebKeyGenerator.h private

WebBrowser:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): new, calls [WebKeyGenerator addCertificateToKeyChainFromFileAtPath:] (-[DownloadProgressEntry autoOpen]): call _addCertificateToKeyChain
1:23 PM Changeset in webkit [5726] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3504907>: REGRESSION (100-116): Clicking QuickTime-requiring link twice crashes (wholenote.com)

I found the bug; Darin wrote the fix; I reviewed and tested.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Rewrote this method to not use GetIndString, because GetIndString looks at all open resource files and in this case was reading information from the wrong plugin file.
11:56 AM Changeset in webkit [5725] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Adding a dynamic cell array test.

Dec 8, 2003:

10:58 PM Changeset in webkit [5724] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3503652, news.com misrenders badly (footer is out of position). My fix to 3495748 caused this
regression. I made the tag priority of <nobr> too high. It needed to be the same as <div>, and I
accidentally made it higher. I intended for it to be the same as <div>.

I also had to make a fix (now that <nobr> has a higher priority) to ensure <nobr> can't be nested inside
other <nobr>.

Both fixes were required to make news.com render correctly again.

Reviewed by darin

  • khtml/html/dtd.cpp:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
6:12 PM Changeset in webkit [5723] by cblu
  • 15 edits
    6 adds
    4 deletes in trunk

WebCore:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::parseAttribute): store the KEYTYPE attribute (HTMLKeygenElementImpl::encoding): call KSSLKeyGen::signedPublicKeyAndChallengeString
  • khtml/html/html_formimpl.h: remove 2 declared but unimplemented methods
  • khtml/misc/htmlattrs.c: generated changes (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h: generated change
  • khtml/misc/htmlattrs.in: added KEYTYPE
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): call renamed strengthMenuItemTitles (KSSLKeyGen::signedPublicKeyAndChallengeString): new, calls [WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]
  • kwq/WebCoreKeyGenerationFactory.h: Added.
  • kwq/WebCoreKeyGenerationFactory.m: Added. (+[WebCoreKeyGenerationFactory sharedFactory]): (-[WebCoreKeyGenerationFactory init]): (-[WebCoreKeyGenerationFactory strengthMenuItemTitles]): (-[WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.

WebKit:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: Added. (gnrAddContextAttribute): new (gnrGetSubjPubKey): new (gnrNullAlgParams): new (gnrSign): new (gnrFreeCssmData): new (signedPublicKeyAndChallengeString): new
  • WebCoreSupport.subproj/WebKeyGeneration.h: Added.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.h: Added. Renamed from WebLocalizedStringFactory.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.m: Added. (+[WebKeyGenerationFactory createSharedFactory]): no change (-[WebKeyGenerationFactory dealloc]): no change (-[WebKeyGenerationFactory strengthMenuItemTitles]): new (-[WebKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): new
  • WebCoreSupport.subproj/WebLocalizedStringFactory.h: Removed.
  • WebCoreSupport.subproj/WebLocalizedStringFactory.m: Removed.
  • WebCoreSupport.subproj/WebNetscapeTemplates.cpp: Added.
  • WebCoreSupport.subproj/WebNetscapeTemplates.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView.subproj/WebFrameView.m:
5:03 PM Changeset in webkit [5722] by kocienda
  • 9 edits in branches

Reviewed by me.

Some more work on getting the delete key to work.
Some work to make relayout happen correctly.
Moved edit evenit handler to HTMLElementImpl.

  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler): (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_inlineimpl.h: (DOM::HTMLBRElementImpl::isHTMLBRElement):
  • khtml/html/htmlediting.cpp: (EditCommand::notifyChanged): (InputTextCommand::applyToDocument): (DeleteTextCommand::applyToDocument):
  • khtml/html/htmlediting.h: (khtml::EditCommand::selection): (khtml::InputTextCommand::text):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLBRElement):
5:02 PM Changeset in webkit [5721] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3504047>: XMLHttpRequest object needs onload event

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented onload property. (KJS::XMLHttpRequest::putValue): Ditto. (KJS::XMLHttpRequest::XMLHttpRequest): Ditto. (KJS::XMLHttpRequest::changeState): Ditto.
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/xmlhttprequest.lut.h: Regenerated.
4:53 PM Changeset in webkit [5720] by rjw
  • 10 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: The last piece of the JavaScript side of the
LiveConnect implementation. This change adds support for
setting/getting values from Java arrays in JavaScript.

Reviewed by John.

  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaArray::JavaArray): (JavaArray::~JavaArray): (JavaArray::setValueAt): (JavaArray::valueAt): (JavaArray::getLength):
  • bindings/jni/jni_runtime.h: (Bindings::JavaArray::operator=): (Bindings::JavaArray::javaArray):
  • bindings/jni/jni_utility.cpp: (JNITypeFromPrimitiveType): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::~RuntimeArrayImp): (RuntimeArrayImp::get): (RuntimeArrayImp::put): (RuntimeArrayImp::hasProperty):
  • bindings/runtime_array.h: (KJS::RuntimeArrayImp::getLength): (KJS::RuntimeArrayImp::getConcreteArray):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty):

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
3:51 PM Changeset in webkit [5719] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/international

Add asahi.com layout test.

3:50 PM Changeset in webkit [5718] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3503022, asahi.com is too wide. Bugs in line breaking of breakable Japanese characters caused
the breaks to be ignored.

Reviewed by john

  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
2:35 PM Changeset in webkit [5717] by kocienda
  • 7 edits in branches

Reviewed by me

Got some more basic text editing working, including:
Deleting selection when you start typing, and making
the delete key work to remove text.

I did some refactoring as well, moving the guts of
the application of editing commands into the command
implementation file.

  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/htmlediting.cpp: (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
  • khtml/html/htmlediting.h: (khtml::): (khtml::InputTextCommand::~InputTextCommand): (khtml::DeleteTextCommand::~DeleteTextCommand):
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtmlview.cpp: (KHTMLView::caretOverrides):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyEditing):
11:44 AM Changeset in webkit [5716] by hyatt
  • 3 edits in trunk/WebCore

Fix the position method to return screen coords like it should and to use the lower left corner instead of
the upper left.

Reviewed by john

  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject position]): (-[KWQAccObject size]):
9:43 AM Changeset in webkit [5715] by kocienda
  • 3 edits in branches

Reviewed by me

A couple of tweaks to make caret drawing work a little
better. Now the caret does not paint when you click on
a link, and the "leftover" pixel is gone from the
caret blink.

  • khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::placeCaret):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
8:45 AM Changeset in webkit [5714] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3502347: REGRESSION (100-116): bottom of login window sometimes missing (TR background image)
  • khtml/rendering/render_object.h: Added setPixmap.
  • khtml/rendering/render_object.cpp: (RenderObject::setPixmap): Moved this function here from RenderBox. This code is needed for the table row class and similar classes that supply a background image that is drawn by the table cell, and those are not RenderBox subclasses.
  • khtml/rendering/render_box.cpp: Removed setPixmap.
  • khtml/rendering/render_box.h: Removed setPixmap.

Dec 7, 2003:

10:04 PM Changeset in webkit [5713] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com

Reviewed by Darin.

  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Check for nil RenderApplet before dereferencing rather than after.

Dec 6, 2003:

9:27 AM Changeset in webkit [5712] by kocienda
  • 2 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed a dumb crasher in a debug printf.

Dec 5, 2003:

3:22 PM Changeset in webkit [5711] by hyatt
  • 2 edits in trunk/WebCore

Add support for link clicking as an accessibility action.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
3:05 PM Changeset in webkit [5710] by rjw
  • 6 edits
    2 adds in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Part 1 of supporting JS bindings to
native language arrays.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_runtime.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h: (Bindings::Array::~Array):

Tests:

Added tests to access Java arrays.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
2:03 PM Changeset in webkit [5709] by mjs
  • 21 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487222>: Add ability to create working fully standalone document object

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/dom/dom_doc.cpp: (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified):
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString):
2:00 PM Changeset in webkit [5708] by rjw
  • 2 edits in trunk/WebCore

Fixed 3501885. Added null test to returned node from collection.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):
10:06 AM Changeset in webkit [5707] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML content in Mail is blank when printed

Darin and I figured this one out.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't call setNeedsDisplay:NO when we're turning printing on, as doing so prevents anything from drawing in the case where this is called from adjustPageHeightsNew:top:bottom:limit
8:52 AM Changeset in webkit [5706] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed regression in small caps with substituted fonts my patch from yesterday caused
  • fixed 3463599: if Lucida font is installed, you see bad glyphs on pages that use it (advogato.org)
  • fixed storage leak if a renderer is ever deallocated (I don't think we ever do that)
  • fixed some small leaks in various error cases by adding appropriate free and dispose calls
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer dealloc]): Free the Unicode glyph map too. (fontContainsString): Moved inline function up here so it will be inlined. (-[WebTextRenderer _setupFont]): Free the glyph map and set it back to zero if we fail after extending the glyph map to include space. This fixes the "wrong glyph codes" bug with Lucida above. (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): Add free calls needed to avoid storage leaks in failure cases. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Ditto. (-[WebTextRenderer _initializeATSUStyle]): Add ATSUDisposeStyle to fix storage leak. (freeWidthMap): Use a loop instead of recursion. (freeGlyphMap): Use a loop instead of recursion. (freeUnicodeGlyphMap): Added. (widthForNextCharacter): Don't use the original characters or cluster length, because the character may have been capitalized for use in small caps rendering. So check the character for <= 0xFFFF instead of looking at clusterLength, and break the character into a local array instead of using the original character pointer.

Dec 4, 2003:

9:09 PM Changeset in webkit [5705] by kocienda
  • 4 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed some formatting. By calling new isEditingAtSelection() helper, fixed crasher caused by checking if we're editing and the selection has been cleared. (KHTMLPart::isEditingAtSelection): New helper.
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::placeCaret): Don't focus if not editing.
5:53 PM Changeset in webkit [5704] by kocienda
  • 1 edit
    2 adds in branches

2003-12-04 Ken Kocienda <​kocienda@apple.com>

Reviewed by me

  • khtml/html/htmlediting.cpp: Added.
  • khtml/html/htmlediting.h: Added.
5:53 PM Changeset in webkit [5703]
  • 16 copies
    341 deletes in branches/HTML-editing-hacks-branch

This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.

5:27 PM Changeset in webkit [5702] by darin
  • 4 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3497879: REGRESSION (100-115): all non-BMP characters (including Deseret) are broken
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): Bump offset by getting it from the iterator; don't assume we can just bump it by one each time. It would be even nicer to have a bit more abstraction. (initializeCharacterWidthIterator): Remove call to initializeCharacterShapeIterator. (widthForNextCharacter): Move handling of surrogate pairs (non-BMP) in here and unify it with the handling of BMP characters; this removes the broken code that was returning the wrong font, and changes us to use the code that was already doing the right thing for the surrogate pair case. Also get rid of the use of 0 width to mean "no glyph", which fixes the doubled glyph problem. Also got rid of remnants of use of the shape iterator.
  • Misc.subproj/WebUnicode.h: Remove obsolete shape iterator.
  • Misc.subproj/WebUnicode.m: Ditto.
5:05 PM Changeset in webkit [5701] by rjw
  • 7 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Moved defaultValue into concrete implementation because
more intelligent conversion can be perform with knowledge
of the class of the original instance.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::isNumberClass): (JavaClass::isBooleanClass): (JavaClass::isStringClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue): (JavaInstance::valueOf):
  • bindings/jni/jni_instance.h: (Bindings::JavaInstance::javaInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):

Tests:

Fixed incorrect log of boolean type.

Reviewed by Chris.

  • LiveConnect/Blink/test.html:
4:55 PM Changeset in webkit [5700]
  • 30 copies
    2 deletes in tags/WebCore-106~3

This commit was manufactured by cvs2svn to create tag
'WebCore-106~3'.

4:55 PM Changeset in webkit [5699] by mjs
  • 2 edits in branches/SUPanBisque-branch/WebCore

WebCore 106.3

4:30 PM Changeset in webkit [5698] by kocienda
  • 34 edits in branches

Reviewed by me

A large set of change to get a blinking caret
and a little bit of text input limping along.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_node.cpp: (Node::getCursor):
  • khtml/dom/dom_node.h:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/html_blockimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::hasSelection): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::caretNode): (KHTMLPart::caretOffset): (KHTMLPart::isPointInsideSelection): (KHTMLPart::khtmlMousePressEvent): (isBeforeNode): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::topLevelFrameCount): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (CaretViewContext::CaretViewContext): (EditorContext::EditorContext): (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLViewPrivate::editorContext): (khtml::ensureLeafNode): (khtml::findRenderer): (khtml::sanitizeCaretState): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::keyPressEvent): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::ensureNodeHasFocus): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret): (KHTMLView::foldSelectionToCaret): (KHTMLView::hideCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
  • khtml/khtmlview.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretPos):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_br.h: (khtml::RenderBR::isBR): (khtml::RenderBR::caretMinOffset): (khtml::RenderBR::caretMaxOffset):
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.h: (khtml::InlineBox::caretMinOffset): (khtml::InlineBox::caretMaxOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::caretPos): (RenderObject::isEditable):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFlow): (khtml::RenderObject::caretMinOffset): (khtml::RenderObject::caretMaxOffset):
  • khtml/rendering/render_replaced.h: (khtml::RenderReplaced::caretMinOffset): (khtml::RenderReplaced::caretMaxOffset):
  • khtml/rendering/render_text.cpp: (InlineTextBox::caretMinOffset): (InlineTextBox::caretMaxOffset): (RenderText::caretPos): (RenderText::htmlFont): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::hasWindowEventListener): (DocumentImpl::applyEditing):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isContentEditable): (NodeImpl::getCaret): (NodeImpl::prevLeafNode): (NodeImpl::nextLeafNode): (NodeImpl::createRenderer): (NodeImpl::caretMinOffset): (NodeImpl::caretMaxOffset):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::caretMinOffset): (CharacterDataImpl::caretMaxOffset):
  • khtml/xml/dom_textimpl.h:
  • kwq/KWQKDebug.h: (kdbgstream::operator<<):
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):
  • kwq/KWQLogging.h:
  • kwq/KWQLogging.m:
  • kwq/KWQWidget.h: (QWidget::focusInEvent):
4:28 PM Changeset in webkit [5697] by rjw
  • 9 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Added support for setting the value of Java
fields.

Reviewed by Chris.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod):
  • bindings/jni/jni_runtime.h: (Bindings::JavaField::getJNIType):
  • bindings/jni/jni_utility.cpp: (JNITypeFromClassName): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue):

Tests:

Added test of setting Java fields from JavaScript.

Reviewed by Chris.

  • LiveConnect/Blink/Holder.java: (Holder):
  • LiveConnect/Blink/test.html:
2:33 PM Changeset in webkit [5696] by rjw
  • 16 edits in trunk

WebCore:

Added support for named applet access from document node.
Factored creation of KJS::Values from RuntimeObjectImps.

Reviewed by Chris.

  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for string conversions.
Changed various JavaString member variables to be inline.
Implemented defaultValue for context relevant type coercion.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::setClassName): (JavaClass::classForInstance):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (appendClassName): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue):
  • bindings/runtime.h: (Bindings::Instance::valueOf):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::classInfo):

Tests:

Added tests passing various parameters type to Java methods.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.setTextWithString): (Blink.setTextWithNumberValueUsingByte): (Blink.setTextWithNumberValueUsingShort): (Blink.setTextWithNumberValueUsingInt): (Blink.setTextWithNumberValueUsingLong): (Blink.setTextWithNumberValueUsingFloat): (Blink.setTextWithNumberValueUsingDouble): (Blink.setTextWithNumberValueUsingChar): (Blink.setTextWithNumberValueUsingBoolean):
  • LiveConnect/Blink/Blink.pbproj/project.pbxproj:
  • LiveConnect/Blink/test.html:
  • PDFBundle/PDFBundle.pbproj/project.pbxproj:
2:28 PM Changeset in webkit [5695] by mjs
  • 3 edits in branches/SUPanBisque-branch/WebCore

Reviewed by Ken.

<rdar://problem/3500456>: JavaScript sites crash when a PAC file is in place

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add required locking. (KJS::getDOMEvent): Ditto.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Ditto. (KJSProxyImpl::createHTMLEventHandler): Ditto. (KJSProxyImpl::initScript): Ditto.
11:45 AM Changeset in webkit [5694] by darin
  • 9 edits in trunk/WebCore

Reviewed by John.

This was an uncaught exception thrown by DocumentImpl. But the design of KHTML DOM is that
"impl" classes return exception codes; they don't throw exceptions.

  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): Throw exception if necessary. The impl function now returns an exception code. (DOM::Document::createElementNS): Ditto.
  • khtml/html/html_documentimpl.h: Add exception code parameter to createElement.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createElement): Pass along the exception code from the lower level.
  • khtml/xml/dom_docimpl.h: Add exception code parameters to createElement, createElementNS, and createHTMLElement.
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Handle exception code from createElementNS. (DocumentImpl::createElement): Add exception code parameter, not set since there is no exception. (DocumentImpl::importNode): Handle exception code from createElementNS. (DocumentImpl::createElementNS): Add exception code parameter. Propagate the exception codes that we get from createHTMLElement and setPrefix. (DocumentImpl::createHTMLElement): Add exception code parameter. Use an exception code rather than a C++ exception for INVALID_CHARACTER_ERR.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Pass exception code parameter to createElement.
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): Pass exception code parameter to createElementNS, and return false if it is not zero. This is where the bug happened. Before we would get an exception from createElementNS, but "impl" functions are not supposed to throw in KHTML's DOM. (XMLTokenizer::finish): Add various exception code parameters to compile, but we know we won't get any exceptions.
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): Pass an (ignored) exception code parameter. (-[WebCoreDOMDocument createElementNS::]): Pass an (ignored) exception code parameter.
11:01 AM Changeset in webkit [5693] by vicki
  • 3 edits in trunk

the tree is open for Safari-117

10:57 AM Changeset in webkit [5692]
  • 3 copies in tags/Safari-116

This commit was manufactured by cvs2svn to create tag 'Safari-116'.

10:57 AM Changeset in webkit [5691] by vicki
  • 9 edits in trunk

Safari-116, Safari 1.2 stamp

8:28 AM Changeset in webkit [5690] by darin
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3498426: assertion failure in tooltip code at macosx.apple.com
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setToolTip:]): Work around the apparent bug in AppKit (3500217) that causes it to return 0 for the tool tip tag by using removeAllToolTips and not storing the tag at all. Besides the assertion failure there may also be a symptom of a "stuck" tool tip and a small memory leak until the window is closed.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove unused toolTipTag.

Dec 3, 2003:

5:41 PM Changeset in webkit [5689]
  • 1 copy
    77 deletes in branches/unlabeled-1.50.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.50.4'.

5:41 PM Changeset in webkit [5688]
  • 1 copy
    24 deletes in branches/unlabeled-1.2336.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2336.4'.

5:41 PM Changeset in webkit [5687] by rjw
  • 12 edits in trunk

WebCore:

LiveConnect: Removed some debugging.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

LiveConnect: Added support for parameter passing to Java and conversion
of return values.

Reviewed by Chris.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::getJNIType):
  • bindings/jni/jni_utility.cpp: (callJNIBooleanMethodA): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):
4:17 PM Changeset in webkit [5686]
  • 1 copy
    93 deletes in branches/unlabeled-1.79.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.79.4'.

4:17 PM Changeset in webkit [5685] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3475761, list bullets mislayout after text zooming.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
2:46 PM Changeset in webkit [5684]
  • 1 copy
    93 deletes in branches/unlabeled-1.86.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.86.4'.

2:46 PM Changeset in webkit [5683]
  • 1 copy
    92 deletes in branches/unlabeled-1.32.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.32.4'.

2:46 PM Changeset in webkit [5682]
  • 1 copy
    93 deletes in branches/unlabeled-1.118.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.118.4'.

2:46 PM Changeset in webkit [5681] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3493356, table cells didn't repaint properly.

Reviewed by kocienda

  • khtml/rendering/render_object.cpp: (RenderObject::repaintObjectsBeforeLayout):
  • khtml/rendering/render_table.cpp: (RenderTableCell::getAbsoluteRepaintRect):
  • khtml/rendering/render_table.h:
2:07 PM Changeset in webkit [5680] by hyatt
  • 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

2:04 PM Changeset in webkit [5679]
  • 1 copy
    129 deletes in branches/unlabeled-1.25.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.25.4'.

2:04 PM Changeset in webkit [5678] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3495748, hang in parser at ocelot.ca. <nobr> needs to have very high priority (equal to the
priority of blocks like h1-6, p, and div), so that unclosed <nobr>s will close divs and ps.

Reviewed by gramps

  • khtml/html/dtd.cpp:
12:58 PM Changeset in webkit [5677] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3475767, hang at saabnet.com. Fix h1-h6 to be more tolerant regarding allowed child elements, to avoid
deeply nested pages.

Reviewed by darin

  • khtml/html/dtd.cpp: (DOM::checkChild):
12:50 PM Changeset in webkit [5676]
  • 1 copy
    377 deletes in branches/unlabeled-1.58.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.58.4'.

12:50 PM Changeset in webkit [5675] by sullivan
  • 2 edits in trunk/WebCore
  • fixed these two design issues after Dave and I talked to HI: <rdar://problem/3497072>: There shouldn't be a focus ring around clicked regions <rdar://problem/3499315>: Focus ring should use aqua color always

Reviewed by Dave.

  • khtml/css/html4.css:
11:46 AM Changeset in webkit [5674]
  • 1 copy
    77 deletes in branches/unlabeled-1.40.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.40.4'.

11:46 AM Changeset in webkit [5673]
  • 1 copy
    107 deletes in branches/unlabeled-1.20.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.20.4'.

11:46 AM Changeset in webkit [5672] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3395759>: results of parent.document.getElementsByTagName can't be added to string

  • khtml/ecma/kjs_dom.cpp: (DOMNodeList::toPrimitive): Always convert to string instead of trying to convert to number and failing, as is done for DOMNode.
  • khtml/ecma/kjs_dom.h: Prototype new method.

Dec 2, 2003:

5:21 PM Changeset in webkit [5671] by rjw
  • 15 edits
    2 adds in trunk

WebCore:

Return a value that is backed by RuntimeObjectImpl, instead
of a DOM object for applet[0]. This is better than having
the DOM object redirect to the RuntimeObjectImpl.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for calling simple methods in Java from JavaScript.
(void return and no parameters). Yay, LiveConnect lives.

Still need write argument and return value conversion code.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_instance.cpp: (JavaInstance::getClass): (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::JNIReturnType):
  • bindings/jni/jni_runtime.h: (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::name):
  • bindings/jni/jni_utility.cpp: (signatureFromPrimitiveType):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: Added. (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::~RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::implementsCall): (RuntimeMethodImp::call): (RuntimeMethodImp::codeType): (RuntimeMethodImp::execute):
  • bindings/runtime_method.h: Added.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get):
  • bindings/runtime_object.h:
  • kjs/function.cpp: (FunctionImp::FunctionImp):
  • kjs/interpreter.h:
5:09 PM Changeset in webkit [5670]
  • 1 copy
    64 deletes in branches/unlabeled-1.97.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.97.4'.

5:09 PM Changeset in webkit [5669] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3488220>: namespaces test from David Faure causes Safari to crash in DOM::DocumentImpl::createElementNS

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): Check if new element is NULL before messing with it, to avoid a crash.
3:19 PM Changeset in webkit [5668]
  • 1 copy
    93 deletes in branches/unlabeled-1.83.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.83.4'.

3:19 PM Changeset in webkit [5667] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3497999, null check the text() of RenderTexts to avoid a crash in current().

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::current):
3:13 PM Changeset in webkit [5666]
  • 1 copy
    126 deletes in branches/unlabeled-1.9.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.9.4'.

3:13 PM Changeset in webkit [5665]
  • 1 copy
    556 deletes in branches/unlabeled-1.7.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.7.4'.

3:13 PM Changeset in webkit [5664]
  • 1 copy
    151 deletes in branches/unlabeled-1.46.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.46.4'.

3:13 PM Changeset in webkit [5663]
  • 1 copy
    629 deletes in branches/unlabeled-1.4.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.4'.

3:13 PM Changeset in webkit [5662]
  • 1 copy
    94 deletes in branches/unlabeled-1.28.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.28.4'.

3:13 PM Changeset in webkit [5661]
  • 1 copy
    115 deletes in branches/unlabeled-1.26.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.26.4'.

3:13 PM Changeset in webkit [5660]
  • 1 copy
    129 deletes in branches/unlabeled-1.24.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.24.4'.

3:13 PM Changeset in webkit [5659]
  • 1 copy
    498 deletes in branches/unlabeled-1.12.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.12.4'.

3:13 PM Changeset in webkit [5658]
  • 1 copy
    64 deletes in branches/unlabeled-1.11.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.11.4'.

3:13 PM Changeset in webkit [5657]
  • 1 copy
    115 deletes in branches/unlabeled-1.10.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.10.4'.

3:13 PM Changeset in webkit [5656] by mjs
  • 15 edits in trunk/WebCore

Reviewed by Darin.

Implemented a simple form of document serialization, enough to take care of:

<rdar://problem/3487190>: implement send of DOMDocument for XMLHttpRequest

  • khtml/dom/dom_doc.cpp: (DOM::Document::toString):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::urlMatchesDocumentDomain): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString): (DocumentTypeImpl::copyFrom): (DocumentTypeImpl::toString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::openTagStartToString): (ElementImpl::toString):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CommentImpl::toString): (TextImpl::toString): (CDATASectionImpl::toString):
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (EntityImpl::toString): (EntityReferenceImpl::toString): (ProcessingInstructionImpl::setStyleSheet): (ProcessingInstructionImpl::toString):
  • khtml/xml/dom_xmlimpl.h:
2:54 PM Changeset in webkit [5655]
  • 1 copy
    123 deletes in branches/unlabeled-1.116.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.116.4'.

2:54 PM Changeset in webkit [5654] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3493677, containingBlock() null because we tried to support position:relative on table rows. Fix
is to disallow this.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
2:25 PM Changeset in webkit [5653] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3493697, nil-deref in bidi code. Need to null-check strings with no length.

Reviewed by john

  • khtml/rendering/bidi.cpp: (khtml::addRun):
2:06 PM Changeset in webkit [5652]
  • 1 copy
    93 deletes in branches/unlabeled-1.101.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.101.4'.

2:06 PM Changeset in webkit [5651] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3495746, nil deref of containing block (frame inside frameset).

Reviewed by kocienda

  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):
11:58 AM Changeset in webkit [5650] by cblu
  • 2 edits in trunk/WebKit

Fixed:
<rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
<rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages

Reviewed by rjw.

  • WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use [[WebTextRendererFactory sharedFactory] fontWithFamilies:traits:size:] to get the font since it takes the font family which is what we store in WebPreferences and it does fallback work. Only set the font if non-nil is returned.
11:48 AM Changeset in webkit [5649] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

  • kwq/KWQRect.h:
  • kwq/KWQRect.mm: (QRect::bottomRight): Added helper.
8:04 AM Changeset in webkit [5648] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed 3493799: JavaScript string.replace expands $ if it's the last character in replacement string
  • kjs/ustring.cpp: (KJS::UString::toDouble): Fix backwards handling of the "tolerant" boolean. This indirectly caused the string.replace bug.
3:00 AM Changeset in webkit [5647]
  • 1 copy
    113 deletes in branches/unlabeled-1.96.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.96.4'.

3:00 AM Changeset in webkit [5646] by mjs
  • 2 edits in trunk/WebCore

Merged the following patch from David Faure to fix:

<rdar://problem/3497663>: Can't look up frames by number using windw[i] notation

2003-11-25 David Faure <​faure@kde.org>

  • ecma/kjs_window.cpp: Implement hasProperty and get for frames by number in Window, to fix window[0] and parent[1] etc. (#56983)
2:11 AM Changeset in webkit [5645] by mjs
  • 5 edits in trunk/JavaScriptCore

Merged patches from Harri Porten and David Faure to fix:

<rdar://problem/3497643>: reproducible crash printing self-referential array

  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): Break out of the loop if an exception was thrown.
  • kjs/nodes.cpp: (FunctionCallNode::evaluate): Move function call depth check from here...
  • kjs/object.cpp: (KJS::Object::call): ...to here.
  • kjs/object.h: Un-inline Object::call now that it does more.

Dec 1, 2003:

3:11 PM Changeset in webkit [5644] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed mistake in method signatures used to get boolean and integer fields.

Reviewed by Chris.

  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):
2:53 PM Changeset in webkit [5643] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): Let WebCore know about redirects.
2:52 PM Changeset in webkit [5642]
  • 1 copy
    529 deletes in branches/unlabeled-1.5.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.5.4'.

2:52 PM Changeset in webkit [5641] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): Refuse to start if the URL is not one this document is allowed to access. (KJS::XMLHttpRequest::slotRedirection): Stop the job if we redirect to a URL the home document is not allowed to access.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader redirectedToURL:]): emit the right signal
  • kwq/WebCoreResourceLoader.h: Prototype new method
2:44 PM Changeset in webkit [5640]
  • 1 copy
    76 deletes in branches/unlabeled-1.31.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.31.4'.

2:44 PM Changeset in webkit [5639]
  • 1 copy
    411 deletes in branches/unlabeled-1.13.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.13.4'.

2:44 PM Changeset in webkit [5638] by rjw
  • 16 edits in trunk

WebKit:

Moved grungy polling code from WebKit to the JavaPlugin.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now either create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance. When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance. This caused the applet instance cached on the applet element to be invalid. The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout):
  • khtml/rendering/render_applet.h: (khtml::RenderApplet::renderName):

JavaScriptCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance. When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance. This caused the applet instance cached on the applet element to be invalid. The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (Bindings::JObjectWrapper::~JObjectWrapper):
  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::deleteProperty):
  • bindings/runtime_object.h:
1:33 PM Changeset in webkit [5637]
  • 1 copy
    330 deletes in branches/unlabeled-1.197.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.197.4'.

1:33 PM Changeset in webkit [5636] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3496960: nil-deref in idFromNode inside elementDoesAutoComplete:
  • kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Added nil check. (formElementFromDOMElement): Added nil check.
11:22 AM Changeset in webkit [5635] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3490959, collapsed border tables don't paint backgrounds.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::paint): (RenderTable::paintBoxDecorations):
  • khtml/rendering/render_table.h:
11:18 AM Changeset in webkit [5634] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3493939: ordered lists with type="A" roll over to A' after X rather than after Z
  • khtml/rendering/render_list.cpp: (toLetter): Change 24 to 26.
11:05 AM Changeset in webkit [5633] by kocienda
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

  • Misc.subproj/WebNSEventExtras.h: Add declarations for new key event helpers.
  • Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isKeyEvent:]): Added. (-[NSEvent _web_isDeleteKeyEvent]): Added. (-[NSEvent _web_isEscapeKeyEvent]): Added. (-[NSEvent _web_isOptionTabKeyEvent]): Added. (-[NSEvent _web_isReturnOrEnterKeyEvent]): Added. (-[NSEvent _web_isTabKeyEvent]): Added.
  • WebKit.pbproj/project.pbxproj: Made WebNSEventExtras.h a private header so WebBrowser can use the new helpers.

WebBrowser:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

  • BookmarksViewController.m: (-[BookmarksViewController handleKeyDown:inSourceColumn:]): Move to new key event helper.
  • BrowserNSEventExtras.h: Remove key event helpers from here. WebBrowser will now pick these up from WebKit.
  • BrowserNSEventExtras.m: Ditto.
  • BrowserWindowController.m: Move to new key event helpers. (-[BrowserWindowController cancel:]): Ditto. (-[BrowserWindowController windowWillHandleKeyEvent:]): Ditto. (-[BrowserWindowController performQuickSearch:]): Ditto.
  • DownloadViewController.m: (-[DownloadViewController keyDown:]): Ditto.
  • Preferences.subproj/SheetWithTableController.m: (-[SheetWithTableController tableView:keyDown:]): Ditto.
  • TitleBarButton.m: Ditto.

Nov 21, 2003:

4:38 PM Changeset in webkit [5632]
  • 1 copy
    25 deletes in branches/unlabeled-1.269.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.269.4'.

4:38 PM Changeset in webkit [5631] by vicki
  • 3 edits in trunk

tree is open for Safari-116

4:27 PM Changeset in webkit [5630]
  • 3 copies in tags/Safari-115

This commit was manufactured by cvs2svn to create tag 'Safari-115'.

4:27 PM Changeset in webkit [5629] by vicki
  • 6 edits in trunk

Safari-115 stamp

3:27 PM Changeset in webkit [5628]
  • 1 copy
    330 deletes in branches/unlabeled-1.183.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.183.4'.

3:27 PM Changeset in webkit [5627]
  • 1 copy
    398 deletes in branches/unlabeled-1.14.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.14.4'.

3:27 PM Changeset in webkit [5626]
  • 1 copy
    330 deletes in branches/unlabeled-1.107.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.107.4'.

3:27 PM Changeset in webkit [5625] by mjs
  • 16 edits in trunk

WebCore:

Reviewed by Ken.

WebCore part of fix for:

<rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Call appropriate methods for status and statusText. (KJS::XMLHttpRequest::send): Set request headers as "customHeaders" metadata property. (KJS::XMLHttpRequest::setRequestHeader): Simply append to header string. (KJS::XMLHttpRequest::getAllResponseHeaders): Return the header string except for the first line. (KJS::XMLHttpRequest::getResponseHeader): Scan the response header string for the header field. Not sure if it's worth being more efficient. (KJS::XMLHttpRequest::getStatus): Try to pull a code out of the status line. (KJS::XMLHttpRequest::getStatusText): Pull the first line off the headers (if any), otherwise return undefined. (KJS::XMLHttpRequest::slotData): The first time through, save the response headers, retrieved from "HTTP-Headers" metadata property. (KJS::XMLHttpRequestProtoFunc::tryCall): Make setRequestHeader, getResponseHeader, getAllResponseHeaders call the right thing.
  • khtml/ecma/xmlhttprequest.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added header support. (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::assembleResponseHeaders): Get a header string out of the response if needed. (KIO::TransferJob::queryMetaData): Special-case "HTTP-Headers". (KIO::TransferJob::emitReceivedResponse): Save response.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (-[NSDictionary _webcore_initWithHeaderString:]): Helper method to turn a string of header fields into a dictionary. (KWQServeRequest): Pass custom headers through. (KWQResponseMIMEType): Admit it's an NSURLResponse *. (KWQResponseHeaderString): Assembled status code and response header fields into response header. Cheat a little on the status line.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Admit it's an NSURLResponse *.
  • kwq/WebCoreResourceLoader.h: Ditto.
  • kwq/WebCoreBridge.h: Add customHeader: arguments.

WebKit:

Reviewed by Ken.

WebKit part of fix for:

<rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:]): Added customHeaders parameter. (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Add the custom headers. (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:referrer:forDataSource:]): Pass along the custom headers. (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Pass along the custom headers.
11:14 AM Changeset in webkit [5624] by cblu
  • 7 edits in trunk/WebCore

Fixed: <rdar://problem/3491907>: When viewing applet, view hierarchy was an empty KWQView

Reviewed by rjw.

  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_objectimpl.cpp: removed setupApplet because that work is done when the applet widget is created (HTMLAppletElementImpl::createRenderer): pass the PARAM args to the render object (HTMLAppletElementImpl::getAppletInstance): don't call setupApplet
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): store args and context, don't call setQWidget here (RenderApplet::setStyle): call setQWidget here (RenderApplet::layout): don't parse args here, that is done in HTMLAppletElementImpl::createRenderer
  • khtml/rendering/render_applet.h:
  • kwq/KWQKJavaAppletWidget.h: (KJavaApplet::KJavaApplet): turned into a stub, this work is no longer needed (KJavaApplet::setAppletClass): ditto (KJavaApplet::setAppletName): ditto (KJavaApplet::setArchives): ditto (KJavaApplet::setBaseURL): ditto (KJavaApplet::setCodeBase): ditto (KJavaApplet::setParameter): ditto (KJavaAppletWidget::~KJavaAppletWidget): ditto (KJavaAppletWidget::applet): ditto (KJavaAppletWidget::setBaseURL): ditto (KJavaAppletWidget::setParameter): ditto (KJavaAppletWidget::showApplet): ditto
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): create the java here instead of doing it later
10:16 AM Changeset in webkit [5623]
  • 1 copy
    330 deletes in branches/unlabeled-1.440.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.440.4'.

10:16 AM Changeset in webkit [5622]
  • 1 copy
    330 deletes in branches/unlabeled-1.137.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.137.4'.

10:16 AM Changeset in webkit [5621] by sullivan
  • 7 edits in trunk

WebCore:

  • WebCore part of fix for <rdar://problem/3333744>: Safari prints page with very, very long line very, very small

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutWithPageWidthRange): Changed method name from forceLayoutForPageWidth; now takes min and max page width values. Use max page width value to limit how wide page will get when there's a very long line.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): changed pageWidth parameter into min and max parameters; pass them along to KWQKHTMLPart.

WebKit:

  • WebKit part of fix for <rdar://problem/3333744>: Safari prints page with very, very long line very, very small

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: renamed PrintingExtraWidthFactor to PrintingMinimumShrinkFactor, added PrintingMaximumShrinkFactor of 2.0, which matches IE (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): now takes a min and max page width; passes them along to bridge (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): now takes a min and max page width; passes them along to layoutTo... (-[WebHTMLView _scaleFactorForPrintOperation:]): now takes PrintingMaximumScaleFactor into account (-[WebHTMLView knowsPageRange:]): now takes PrintingMaximumScaleFactor into account

(-[WebHTMLView layout]):
pass 0 for maximumPageWidth when passing 0 for minimumPageWidth
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
ditto
(-[WebHTMLView _web_setPrintingModeRecursive]):
ditto
(-[WebHTMLView _web_clearPrintingModeRecursive]):
ditto
(-[WebHTMLView endDocument]):
ditto

9:29 AM Changeset in webkit [5620] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3490260: allow &sup1 to be misspelled &supl (lowercase l instead of numeral 1) because WinIE does
  • khtml/html/kentities.gperf: Added supl to the list. Maps to U+00B9, just as sup1 does.
  • khtml/html/kentities.c: Regenerated.
12:54 AM Changeset in webkit [5619] by mjs
  • 2 edits in trunk/JavaScriptCore

Patch from Harri Porten, reviewed by me.

  • fixed 3491712 - String slice with negative arguments does not offset from end of string
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Handle negative arguments as offsets from end by adding length and clamping to [0,length-1].
12:49 AM Changeset in webkit [5618] by mjs
  • 2 edits in trunk/JavaScriptCore

Patch from Harri Porten, reviewed by me.

  • fixed 3491709 - using Function.apply with a primitive type as the arg list causes crash
  • kjs/function_object.cpp: (FunctionProtoFuncImp::call): Nest parentheses properly.

Nov 20, 2003:

10:53 PM Changeset in webkit [5617] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3487201 - Implement abort for XMLHttpRequest async loads
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::abort): Kill and clear job. (KJS::XMLHttpRequest::slotData): Avoid moving to state 3 on early abort. (KJS::XMLHttpRequestProtoFunc::tryCall): Call abort when appropriate.
  • khtml/ecma/xmlhttprequest.h:
7:13 PM Changeset in webkit [5616] by rjw
  • 12 edits in trunk/JavaScriptCore

JavaScriptCore:

More LiveConnect stuff. Primitive Java fields are now
accessible from JavaScript! Yay!

Reviewed by Maciej.

  • bindings/jni/jni_class.cpp: (JavaClass::methodNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h: (Bindings::JavaClass::_commonDelete):
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance): (JavaInstance::getClass):
  • bindings/jni/jni_instance.h: (Bindings::JavaInstance::javaInstance):
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaField::valueFromInstance):
  • bindings/jni/jni_runtime.h: (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=):
  • bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodA): (callJNIVoidMethod): (callJNIObjectMethod): (callJNIBooleanMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod): (callJNIVoidMethodA): (callJNIObjectMethodA): (callJNIByteMethodA): (callJNICharMethodA): (callJNIShortMethodA): (callJNIIntMethodA): (callJNILongMethodA): (callJNIFloatMethodA): (callJNIDoubleMethodA): (releaseCharactersForJStringInEnv): (primitiveTypeFromClassName): (getJNIField):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance): (Instance::getValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):
6:02 PM Changeset in webkit [5615]
  • 10 copies
    3 deletes in tags/WebKit-106~2

This commit was manufactured by cvs2svn to create tag 'WebKit-106~2'.

6:02 PM Changeset in webkit [5614]
  • 29 copies
    2 deletes in tags/WebCore-106~2

This commit was manufactured by cvs2svn to create tag
'WebCore-106~2'.

6:02 PM Changeset in webkit [5613] by vicki
  • 4 edits in branches/SUPanBisque-branch
  • 106.2 stamp in WebCore and WebKit for SUPanBisque
6:01 PM Changeset in webkit [5612]
  • 1 copy
    115 deletes in branches/unlabeled-1.15.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.15.4'.

6:01 PM Changeset in webkit [5611] by sullivan
  • 10 edits in trunk

WebCore:

  • WebCore part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

Dave wrote this part and we reviewed it together.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): if printing, check for CSS page break locations (khtml::RenderBlock::inRootBlockContext): new method, used to check whether we're in a context for which CSS page breaks are legal.
  • khtml/rendering/render_block.h: prototype for inRootBlockContext; this might be useful for other code later.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::setBestTruncatedAt): now takes a forcedBreak parameter which overrides others.
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::setTruncatedAt): set default value for m_forcedPageBreak
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRects:withPageHeight:]): do the real work of pagination here

WebKit:

  • WebKit part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

Dave and I wrote and reviewed this.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): reset page rects when printing status changes (-[WebHTMLView _availablePaperWidthForPrintOperation:]): new helper method to compute paper width taking margins into account (-[WebHTMLView _scaleFactorForPrintOperation:]): new helper method to compute how much we need to shrink to fit one page across (-[WebHTMLView _provideTotalScaleFactorForPrintOperation:]): we overrode this secret internal AppKit method to make shrink-to-fit work; we wrote bug 3491344 about the need for this to be public. (-[WebHTMLView knowsPageRange:]): new method, computes rects and returns YES (-[WebHTMLView rectForPage:]): new method, returns rect computed above (-[WebHTMLView _calculatePrintHeight]): new method, used by knowsPageRange
  • WebView.subproj/WebHTMLViewPrivate.h: new pageRects ivar
4:54 PM Changeset in webkit [5610] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Corrected ChangeLog comment.

4:53 PM Changeset in webkit [5609] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Darin.

  • fixed 3487201 - Implement abort for XMLHttpRequest async loads
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:postData:]):
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:referrer:forDataSource:]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (+[WebSubresourceClient startLoadingResource:withURL:postData:referrer:forDataSource:]):
4:41 PM Changeset in webkit [5608] by vicki
  • 5 edits in branches/SUPanBisque-branch/WebKit
  • roll these fixes onto the branch to add tooltip support in SUPanBisque (rdar://problem/3490331)

2003-09-22 Darin Adler <Darin Adler>

Reviewed by Dave.

  • worked around 3429631 -- window stops getting mouse moved events after first tooltip appears
  • WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

2003-09-22 Darin Adler <Darin Adler>

Reviewed by Dave.

  • fixed 3431033 -- crash in -[NSToolTipManager _shouldInstallToolTip:]
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Override this alternate version of addTrackingRect. If I don't do this, we might create a real tracking rect, which we would then never remove. (-[WebHTMLView removeTrackingRect:]): Added assertions.

2003-09-21 Darin Adler <Darin Adler>

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

2003-09-21 Darin Adler <Darin Adler>

Reviewed by Dave.

  • fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)
  • WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the tool tip string. (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView tracking rectangle implementation so we can trick the tool tip manager into trusting us about when you leave and enter the rectangle for each element. (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff. (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip manager, and send it on. (-[WebHTMLView _sendToolTipMouseEntered]): Ditto. (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool tip manager into working even though we don't know the rectangles of the tool tips beforehand. The advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping to a nice rectangular shape and fading out when you move away. (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual tool tip text. (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the WebCoreElementTitleKey in the dictionary.
  • unrelated code cleanup
  • WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use a definition exported from WebCore.
  • WebView.subproj/WebFramePrivate.m: Ditto.
  • English.lproj/StringsNotToBeLocalized.txt: Update for above changes.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): (-[WebHTMLView removeTrackingRect:]): (-[WebHTMLView _sendToolTipMouseExited]): (-[WebHTMLView _sendToolTipMouseEntered]): (-[WebHTMLView _setToolTip:]): (-[WebHTMLView view:stringForToolTip:point:userData:]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):
4:36 PM Changeset in webkit [5607] by vicki
  • 5 edits in branches/SUPanBisque-branch/WebCore
  • roll these fixes onto the branch to add tooltip support in SUPanBisque (rdar://problem/3490331)

2003-11-13 Darin Adler <Darin Adler>

Reviewed by Dave.

  • fixed 3474330 -- tooltips do not work for <area> elements
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): When looking for a title, start with innerNode (which can be an <area> inside a <map>). This matches what Mozilla does.

2003-09-21 Darin Adler <Darin Adler>

Reviewed by Dave.

  • fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary to find it. It's used for tool tips at the WebKit level.
  • kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.
  • WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
  • WebCore-combined.exp: Regenerated.
  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
3:05 PM Changeset in webkit [5606]
  • 1 copy
    561 deletes in branches/unlabeled-1.6.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.4'.

3:05 PM Changeset in webkit [5605]
  • 1 copy
    76 deletes in branches/unlabeled-1.19.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.19.4'.

3:05 PM Changeset in webkit [5604]
  • 1 copy
    382 deletes in branches/unlabeled-1.1.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.4'.

3:05 PM Changeset in webkit [5603] by cblu
  • 9 edits
    5 adds in trunk

WebCore:

Fixed: <rdar://problem/3491225>: Need UI and localized strings for <KEYGEN> support

Reviewed by john.

  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: Added. (KSSLKeyGen::supportedKeySizes): implemented, calls [WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]
  • kwq/WebCoreLocalizedStringFactory.h: Added.
  • kwq/WebCoreLocalizedStringFactory.m: Added. (+[WebCoreLocalizedStringFactory sharedFactory]): new (-[WebCoreLocalizedStringFactory init]): new (-[WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]): new

WebKit:

Fixed: <rdar://problem/3491229>: Need UI and localized strings for <KEYGEN> support

Reviewed by john.

  • ChangeLog:
  • English.lproj/Localizable.strings:
  • WebCoreSupport.subproj/WebLocalizedStringFactory.h: Added.
  • WebCoreSupport.subproj/WebLocalizedStringFactory.m: Added. (+[WebLocalizedStringFactory createSharedFactory]): new (-[WebLocalizedStringFactory dealloc]): new (-[WebLocalizedStringFactory keyGenerationMenuItemTitles]): new
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebFrameView.m: call [WebLocalizedStringFactory createSharedFactory]
2:45 PM Changeset in webkit [5602] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3490086 - support http post for XMLHttpRequest
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJob::TransferJob):
2:00 PM Changeset in webkit [5601] by rjw
  • 19 edits in trunk

WebKit:

Added spin of event loop during applet lookup poll. This
is necessary to allow timers and performOnMainThread: methods
a chance to fire. The plugin depends on these mechanisms during
initialization.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:

Cleaned up synchronous applet lookup and initialization.
We need to further cleanup applet instantiation. It doesn't
need to be lazy with my modified Java Plugin.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::setupApplet): (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):

JavaScriptCore:

More LiveConnect stuff.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::classForName): (JavaClass::classForInstance):
  • bindings/jni/jni_instance.cpp: (JavaInstance::getValueOfField):
  • bindings/jni/jni_instance.h: (Bindings::JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::~JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::signature):
  • bindings/jni/jni_utility.cpp: (getJNIEnv): (attachToJavaVM):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::get):
  • bindings/runtime_object.h:
1:56 PM Changeset in webkit [5600] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by me

John and I decided to apply the _web_ prefix to the tab key
event method in the extras file, but I neglected to do this
before checking in. Fixed now.

  • Misc.subproj/WebNSEventExtras.h:
  • Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isTabKeyEvent])
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:])
1:01 PM Changeset in webkit [5599]
  • 1 copy
    327 deletes in branches/unlabeled-1.102.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.102.4'.

1:01 PM Changeset in webkit [5598] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by David

Fix for this bug:

<rdar://problem/3487421>: crash/exception when tabbing to a link without text

  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): A link is also not focusable if it has zero width or height, if it has no children, or if it is is not a continuation.
  • kwq/KWQPainter.mm: (QPainter::drawFocusRing): Put in a guard against trying to draw a focus ring with no control points. Log this as an error.
12:59 PM Changeset in webkit [5597] by kocienda
  • 3 edits
    2 adds in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3482159>: Tabbing to links gets "stuck" in "style switcher" on zeldman.com

  • Misc.subproj/WebNSEventExtras.h: Added.
  • Misc.subproj/WebNSEventExtras.m: Added. (-[NSEvent _isTabKeyEvent]): New helper.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Pass the key event to super unconditionally if it is a tab key. This fixes the bug.

Nov 19, 2003:

8:28 PM Changeset in webkit [5596] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3486963, crash because generated content was referencing a deleted object. Fix is to update the
variable to a sane value after deleting old generated content.

Reviewed by darin

  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
7:57 PM Changeset in webkit [5595] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for: <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page Setup margin settings

Reviewed by Dave.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Lay out the page into a width 25% wider than there's room for on the printed page. This will make pages that can fit into a thin area be scaled down a little when printed, which lets them fit on fewer pages. This closely matches what IE and Camino (at least) do; I used Google as my test page, and the Google logo is now precisely the same size when printed from Safari as when printed from IE. Pages that don't fit into a thin area are already causing the printed page to be scaled horizontally to fit, and this won't affect them.

WebBrowser:

  • WebBrowser part of fix for: <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page Setup margin settings

Reviewed by Dave.

  • BrowserDocument.m: (-[BrowserDocument printInfo]): Use the entire imageable area of the page (except max out at the paper size). This matches what IE does; you can tell by formatting for different printers in Page Setup and checking the printed margins against the margins reported in the Settings:Summary part of Page Setup.

With this change and the accompanying WebKit change to initially lay out into
an area 25% wider than fits on the page, and Hyatt's earlier change to re-layout
to the width of the widest element on the page, our printed pages are much, much
closer to how other browsers print. We are now no more different from other
browsers than they are from each other, at least for non-edge case pages.

4:46 PM Changeset in webkit [5594] by mjs
  • 8 edits in trunk/WebCore

Reviewed by John.

  • fixed 3486998 - Implement asynchronous http loading for XMLHttpRequest
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestQObject::XMLHttpRequestQObject): New QObject to use to connect to signals. (KJS::XMLHttpRequestQObject::slotData): Call XMLHttpRequest. (KJS::XMLHttpRequestQObject::slotFinished): Ditto. (KJS::XMLHttpRequestQObject::slotRedirection): Ditto. (KJS::XMLHttpRequest::getValueProperty): Implemented, onrequeststatechange, readyState and responseText. (KJS::XMLHttpRequest::putValue): Implemented onrequeststatechange. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new fields. (KJS::XMLHttpRequest::~XMLHttpRequest): Delete decoder. (KJS::XMLHttpRequest::changeState): Update state, and send event if needed. (KJS::XMLHttpRequest::open): Save the parameters. (KJS::XMLHttpRequest::send): Fire up a post or get job. (KJS::XMLHttpRequest::slotFinished): go to final state. (KJS::XMLHttpRequest::slotRedirection): Just stub for now. (KJS::XMLHttpRequest::slotData): Update state; decode & save data. (KJS::XMLHttpRequestProtoFunc::tryCall): Implemented open and send.
  • khtml/ecma/xmlhttprequest.h: Prototyped new stuff.
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added "readystatechange" event. (EventImpl::idToType): Ditto.
  • khtml/xml/dom2_eventsimpl.h: Ditto.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeRequest): New variant that doesn't need a Request.
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Handle XMLHttpRequestQObject's slots. (KWQSlot::call): Ditto.
3:45 PM Changeset in webkit [5593] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as "Download Linked File To Disk..." is redundant

Reviewed by john.

  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): use "Download Linked File" and "Download Image"
2:41 PM Changeset in webkit [5592] by rjw
  • 14 edits
    4 adds in trunk

Forget to check these in earlier.

2:25 PM Changeset in webkit [5591] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3488783>: Flash at ​http://www.sjwilson.net/reef/ does not load photos

Reviewed by rjw.

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_stringByStrippingReturnCharacters]): new
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): call _web_stringByStrippingReturnCharacters on the relative string
2:21 PM Changeset in webkit [5590] by rjw
  • 3 edits in trunk/WebKit

WebKit:

More LiveConnect stuff. Horrible polling hack that
blocks main thread waiting for applet to fully initialize.

Reviewed by Ken.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController addPlugin:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:

More LiveConnect stuff. With that patch we make the applet
visible to JavaScript in an Bindings::Instance. Next step
it to flush out implementation of RuntimeObjectImp and
RuntimeFunctionImp.

Reviewed by Ken.

  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::HTMLAppletElementImpl): (HTMLAppletElementImpl::~HTMLAppletElementImpl): (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
  • kwq/WebCoreBridge.h:

JavaScript:

More LiveConnect stuff.

Reviewed by Ken.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_class.cpp: Added. (JavaClass::_commonInit): (JavaClass::JavaClass): (_createClassesByNameIfNecessary): (JavaClass::classForName): (JavaClass::classForInstance): (JavaClass::methodNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h: Added. (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::~JavaClass): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::JavaClass): (Bindings::JavaClass::operator=): (Bindings::JavaClass::name): (Bindings::JavaClass::constructorAt): (Bindings::JavaClass::numConstructors):
  • bindings/jni/jni_instance.cpp: Added. (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance):
  • bindings/jni/jni_instance.h: Added. (Bindings::JObjectWrapper::JObjectWrapper): (Bindings::JObjectWrapper::~JObjectWrapper): (Bindings::JObjectWrapper::ref): (Bindings::JObjectWrapper::deref): (Bindings::JavaInstance::getClass): (Bindings::JavaInstance::operator=):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod):
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=):
  • bindings/jni/jni_utility.cpp: (getJavaVM): (getJNIEnv): (getCharactersFromJString): (releaseCharactersForJString): (getCharactersFromJStringInEnv): (releaseCharactersForJStringInEnv):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
  • bindings/runtime.h: (Bindings::Instance::):
12:36 PM Changeset in webkit [5589]
  • 1 copy
    129 deletes in branches/unlabeled-1.49.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.49.4'.

12:36 PM Changeset in webkit [5588]
  • 1 copy
    430 deletes in branches/unlabeled-1.18.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.18.4'.

12:36 PM Changeset in webkit [5587] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3488888, about:blank in iframes doesn't repaint properly. Fix for 3485478, refreshing a remote
page often causes a white flash. Fix for 3488827, XML/XHTML documents don't fire load events on bodies/framesets.

Reviewed by darin

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl):
  • khtml/html/html_documentimpl.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas): (RenderCanvas::layout):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::body): (DocumentImpl::close):
  • khtml/xml/dom_docimpl.h:
12:30 PM Changeset in webkit [5586] by hyatt
  • 3 edits in trunk/WebKit

Make updateScrollers guard non-static, so that it applies only to the view whose scrollers are being
updated.

Reviewed by darin

  • WebView.subproj/WebDynamicScrollBarsView.h:
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
10:55 AM Changeset in webkit [5585]
  • 1 copy
    41 deletes in branches/unlabeled-1.168.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.168.4'.

10:55 AM Changeset in webkit [5584] by mjs
  • 14 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3488883 - KIO::TransferJob needs to really use signals instead of calling loader directly
  • khtml/khtml_part.cpp: (KHTMLPart::openURL):
  • khtml/misc/loader.cpp: (Loader::servePendingRequests): (Loader::slotReceivedResponse):
  • khtml/misc/loader.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): (KIO::TransferJob::url): (KIO::TransferJob::emitData): (KIO::TransferJob::emitRedirection): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • kwq/KWQObject.mm: (QObject::connect):
  • kwq/KWQResourceLoader.h:
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): (-[KWQResourceLoader addData:]): (-[KWQResourceLoader finishJobAndHandle]):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):

Nov 18, 2003:

2:12 PM Changeset in webkit [5583]
  • 1 copy
    93 deletes in branches/unlabeled-1.61.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.61.4'.

2:12 PM Changeset in webkit [5582] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3488244, marquee-increments with percentage values not handled correctly. Also added a tweak to ensure
that 1% of a small value ends up being at least an increment of 1. Also added an optimization to not even
bother kicking off the marquee timer if the increment's initial value is 0 (matches WinIE).

  • khtml/rendering/render_layer.cpp: (Marquee::start): (Marquee::timerEvent):
1:23 PM Changeset in webkit [5581] by rjw
  • 15 edits
    3 adds in trunk

WebKit:

More live connect stubs. We're getting close.

Reviewed by Chris.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController addPlugin:]): (-[WebPluginController _delayedGetApplet:]):
  • WebView.subproj/WebView.m: (-[WebView _goToItem:withLoadType:]):

WebCore:

More live connect stubs. We're getting close.

Reviewed by Chris.

  • WebCore.pbproj/project.pbxproj:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:

JavaScriptCore:

More live connect stubs. We're getting close.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_runtime.cpp: (JavaClass::JavaClass): (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance):
  • bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::value): (Bindings::JavaField::value): (Bindings::JavaMethod::value): (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::methodNamed): (Bindings::JavaClass::fieldNamed): (Bindings::JavaInstance::getClass):
  • bindings/runtime.cpp: Added.
  • bindings/runtime.h: (Bindings::Instance::~Instance):
  • bindings/runtime_object.cpp: Added. (RuntimeObjectImp::classInfo): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::_initializeClassInfoFromInstance):
  • bindings/runtime_object.h: Added. (KJS::RuntimeObjectImp::setInternalInstance): (KJS::RuntimeObjectImp::getInternalInstance):
  • kjs/object.cpp: (KJS::ObjectImp::get): (KJS::ObjectImp::hasProperty):
  • kjs/value.h: (KJS::):
10:19 AM Changeset in webkit [5580]
  • 7 copies
    3 deletes in tags/JavaScriptCore-96~0~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-96~0~1'.

10:19 AM Changeset in webkit [5579] by vicki
  • 2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore
  • added a release marker for the latest Merlot build fix, JavaScriptCore-96~0~1
10:16 AM Changeset in webkit [5578]
  • 4 copies
    3 deletes in tags/WebKit-106~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-106~0~1'.

10:16 AM Changeset in webkit [5577] by vicki
  • 2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebKit
  • added a release marker for the latest Merlot build fix, WebKit-106~0~1
10:04 AM Changeset in webkit [5576] by vicki
  • 2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore
  • Merged this fix from HEAD. We thought this was already merged to the branch, but its not.

2003-11-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.
7:57 AM Changeset in webkit [5575] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed 3487335: REGRESSION (112-113): "a:b" error message does not cite the URL properly
  • Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): Call _webKitErrorWithDomain:code:URL:. (+[NSError _webKitErrorWithDomain:code:URL:]): Call _web_errorWithDomain:code:URL:, instead of using the deprecated failingURL: flavor. (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]): Change this method to call the other one. (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Implement this one, and put in the NSErrorFailingURLKey, as well as the NSErrorFailingURLStringKey, to match what Foundation now does for other errors.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Change to use the non-deprecated flavor of the NSError call above.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for above changes and other recent changes.
2:05 AM Changeset in webkit [5574] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css-generated-content/004-expected.txt

Fix for generated content problems fixes test 4.

2:04 AM Changeset in webkit [5573] by hyatt
  • 1 edit in trunk/LayoutTests/fast/parser/document-write-option-expected.txt

Update option document.write layout test. Somebody fixed a bug and didn't run the layout tests to see that they'd fixed a layout test. ;)

1:55 AM Changeset in webkit [5572] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3478122, crash using first-letter and zooming, and also the fix for 3478078, generated content
does not get removed properly on w3c site. The root cause of these two bugs was the same, namely my
change to meld the concept of generated anonymous content and anonymous blocks created by the layout
engine together. RenderBlock's setStyle method was incorrectly updating before/after/first-letter content
and wiping out its style in random (and bad) ways.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
1:28 AM Changeset in webkit [5571] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Adding layout test to cover image generated content.

1:21 AM Changeset in webkit [5570] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3487424, images not painting because of dropped layouts. When replaced elements dirtied
themselves during line layout, they only needed to do a local dirty and not walk up the parent chain.

Reviewed by mjs

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
12:52 AM Changeset in webkit [5569]
  • 1 copy
    379 deletes in branches/unlabeled-1.22.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.22.4'.

12:52 AM Changeset in webkit [5568] by mjs
  • 6 edits
    3 adds in trunk/WebCore

Reviewed by Dave.

  • fixed 3486991 - Add XMLHttpRequest object and stub methods
  • khtml/ecma/kjs_window.cpp: (Window::get): Handle XMLHttpRequest constructor like Option and Image.
  • khtml/ecma/kjs_window.h: Ditto.
  • khtml/ecma/kjs_window.lut.h: Regenerated.
  • khtml/ecma/xmlhttprequest.cpp: Added. Stub implementations of everything. (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp): (KJS::XMLHttpRequestConstructorImp::implementsConstruct): (KJS::XMLHttpRequestConstructorImp::construct): (KJS::XMLHttpRequest::tryGet): (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::tryPut): (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::notifyFinished): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/ecma/xmlhttprequest.h: Added. Stub implementations of everything. (KJS::XMLHttpRequest::toBoolean): (KJS::XMLHttpRequest::classInfo):
  • khtml/ecma/xmlhttprequest.lut.h: Added.
  • khtml/ecma/Makefile.am: Add new .lut.h file.
  • WebCore.pbproj/project.pbxproj: Add new files.
12:41 AM Changeset in webkit [5567]
  • 1 copy
    92 deletes in branches/unlabeled-1.34.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.34.4'.

12:41 AM Changeset in webkit [5566] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3487136, marquees reset when you return to a page in the b/f cache. This patch makes
marquees suspend and resume properly, so they pick up animating where they left off.

Reviewed by mjs

  • khtml/rendering/render_layer.cpp: (RenderLayer::suspendMarquees): (m_direction): (Marquee::start): (Marquee::suspend):
  • khtml/rendering/render_layer.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):

Nov 17, 2003:

9:40 PM Changeset in webkit [5565] by mjs
  • 3 edits in trunk/JavaScriptCore

Patch from Harri, reviewed by me.

  • fixed 3487375 - backwards array slice causes infinite loop
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call):
9:30 PM Changeset in webkit [5564] by mjs
  • 2 edits in trunk/JavaScriptCore

Patch from Harri Porten reviewed by me.

  • fixed 3487371 - operator precedence for bitwise or, xor and and is wrong
  • kjs/grammar.y: Correct the precedence.
8:15 PM Changeset in webkit [5563] by mjs
  • 2 edits in trunk/WebCore

Merged from khtml:

-fixed 3487324 - CSS url values should be wrapped in "url()" for cssText purposes

2003-11-07 Dirk Mueller <​mueller@kde.org>

  • css/css_valueimpl.cpp (cssText): wrap uri's into url(). Stephan Kulow noted that other browsers do that.
6:39 PM Changeset in webkit [5562] by hyatt
  • 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

6:38 PM Changeset in webkit [5561]
  • 1 copy
    78 deletes in branches/unlabeled-1.62.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.62.4'.

6:38 PM Changeset in webkit [5560] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3472998, stop a crash on an insanely malformed page. I had to change the concept of
"inStrayTableContent" to be a counter, since you could be nested and need to push/pop, and
then I also had to stop from mistakenly popping when I didn't need to.

Reviewed by rjw

  • khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::insertNode): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
  • khtml/html/htmlparser.h:
5:52 PM Changeset in webkit [5559]
  • 1 copy
    41 deletes in branches/unlabeled-1.80.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.80.4'.

5:52 PM Changeset in webkit [5558]
  • 1 copy
    93 deletes in branches/unlabeled-1.73.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.73.4'.

5:52 PM Changeset in webkit [5557]
  • 1 copy
    376 deletes in branches/unlabeled-1.23.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.23.4'.

5:52 PM Changeset in webkit [5556] by darin
  • 20 edits in trunk/WebCore

Reviewed by Ken.

  • did keyboard event cleanup to follow up on the keyCode work I did before
  • fixed 3485558: key identifers use lowercase hex, but the W3C document shows uppercase
  • fixed 3485564: key identifier for the Return key should be "Enter"
  • fixed 3485579: letter keys generate different key identifiers depending on whether the shift key is down
  • fixed 3485568: keyboard event modifier key bits are uninitialized; may have incorrect values
  • fixed 3481514: which attribute for DOM events reports incorrect value
  • fixed 3452569: charCode attribute for DOM events not supported
  • khtml/dom/dom2_events.h: Added charCode.
  • khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Call through to KeyboardEventImpl instead of doing the work here; better factoring. (UIEvent::charCode): Added. Calls through to KeyboardEventImpl. (UIEvent::which): Call keyCode in KeyboardEventImpl to share code.
  • khtml/ecma/kjs_events.h: Added charCode property for DOMUIEvent.
  • khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Added charCode.
  • khtml/ecma/kjs_events.lut.h: Regenerated.
  • khtml/html/html_formimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Remove checks for "U+00000d" since we now use "Enter" for that key; also, we use capitalized hex, so it would have to change to "U+00000D" anyway. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Ditto.
  • khtml/khtmlview.cpp: (KHTMLView::keyPressEvent): Put !APPLE_CHANGES around code we are not using. It was doing a switch based on Qt key codes, but the key value it was using to check was a Macintosh virtual key code, which could yield strange results when the codes happen to match. Safer and smaller code size not to do any of it at all.
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): Use a KLineEdit instead of LineEditWidget for APPLE_CHANGES. Allows us to put !APPLE_CHANGES around more Qt key code stuff. (RenderLineEdit::select): Cast to KLineEdit instead of LineEditWidget. (ComboBoxWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff. (TextAreaWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff.
  • khtml/xml/dom2_eventsimpl.h: Made id() const and added keyCode() and charCode().
  • khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): Initialize all fields in the empty constructor. Initialize all the modifier bits in the main constructor; the old code assumed they started off false, which is not a safe assumption. Also set m_altGraphKey false. Eliminated the unneeded check of text() before calling identifier(). Also adapted for the name change from identifier() to keyIdentifier(). (KeyboardEventImpl::keyCode): Added. Returns the Windows virtual key code for keydown and keyup events, and the Unicode character for all other events. (KeyboardEventImpl::charCode): Added. Returns the Unicode character.
  • kwq/KWQEvent.h: Changed QCustomEvent to be a typedef for QEvent. (QEvent::QEvent): Removed AccelAvailable, and added KParts, so I could remove some ugly constants from the KParts code. (QMouseEvent::button): Use a cast here since the field is now int. (QMouseEvent::state): Use a cast here since the field is now int. (QMouseEvent::stateAfter): Use a cast here since the field is now int, and use the new _stateAfter field. (QTimerEvent::QTimerEvent): Moved the constructor to be inline since it's so simple. (QKeyEvent::QKeyEvent): Removed type and button state parameters, now unneeded. Also removed now-unused _key, _ascii, and _count fields, and key(), ascii(), and count() functions. (QKeyEvent::state): Made inline. (QKeyEvent::isAccepted): Made inline. (QKeyEvent::text): Made inline. (QKeyEvent::isAutoRepeat): Made inline. (QKeyEvent::accept): Made inline. (QKeyEvent::ignore): Made inline. (QKeyEvent::unmodifiedText): Made inline. (QKeyEvent::keyIdentifier): Made inline and chnaged name from identifier().
  • kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Renamed from identifierForKeyText and changed parameter to be the event. Cleaned up the code a little bit, and wrote a comment or two. Changed from lowercase hex to uppercase, and called toupper on the key so that letter a-z would work properly. (A non-Unicode toupper is just the ticket here, because I am only sure we want to do this for a-z, not other lowercase characters.) (isKeypadEvent): Added. Uses virtual key codes to decide if a key event is a keypad event, so we can set the state flag correctly. (WindowsKeyCodeForKeyEvent): Added Clear key to the switch statement; it was missing. Changed to no longe use the characterCode helper function since this was the only place it was needed. (mouseButtonForEvent): Added. Similar logic to what was in KWQKHTMLPart before; better factoring to have it in here. (nonMouseButtonsForEvent): Ditto. (QMouseEvent::QMouseEvent): Rewrote constructors. One matches the one from Qt that's used in some places in KHTML code. The other takes an NSEvent and uses the new functions above to compute the button and state. (QKeyEvent::QKeyEvent): Computer type based on the passed-in NSEvent. Compute the auto-repeat flag based on the event and also the "forceAutoRepeat" parameter. Compute the button state based on the event too.
  • kwq/KWQKHTMLPart.h: Remove buttonForCurrentEvent and stateForCurrentEvent. Both are now in KWQEvent.mm.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Remove extra parameters in code that creates QKeyEvent, now that QKeyEvent can handle everything itself. (KWQKHTMLPart::mouseDown): Same thing as above, only for QMouseEvent. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto. (KWQKHTMLPart::sendContextMenuEvent): Ditto.
  • kwq/KWQKPartsEvent.h: Tweaked the class around a little so it can work without taking advantage of QCustomEvent's data pointer.
  • kwq/KWQKPartsEvent.mm: (KParts::Event::Event): Changed so it does a strdup on the event name and uses the new event type pre-allocated in KWQEvent.h for us. (KParts::Event::~Event): Free the event name. (KParts::Event::test): Reimplemented this.
  • kwq/KWQKPartsPart.h: (KParts::Part::event): Removed now-unnecessary cast to change a QCustomEvent into a QEvent.
  • kwq/KWQNamespace.h: Removed the Qt::Key enum. All the code that used it was already broken because of the mixup between Qt and Macintosh key codes.
4:59 PM Changeset in webkit [5555] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/3487079>: Some scheme checks in KURL do not verify
first char is a legal first char for a scheme

  • kwq/KWQKURL.mm: (KURL::KURL): Added some additional checks when looking through strings looking for schemes. Now the first character is checked for validity as a first character in a scheme.
4:54 PM Changeset in webkit [5554] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3486441, don't use the visibleWidth when computing the containingBlockWidth(). No need to
query the view, since the canvas's width has been set to the proper size (when printing).

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):
3:44 PM Changeset in webkit [5553]
  • 1 copy
    93 deletes in branches/unlabeled-1.45.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.45.4'.

3:44 PM Changeset in webkit [5552] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3413713 - iframe forms posting fails without initial src attribute value
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): If the new part is for "about:blank", set the document base URL to parent's base URL.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): If this part is an iframe, set the document base URL to the parent's base URL.
3:40 PM Changeset in webkit [5551]
  • 1 copy
    78 deletes in branches/unlabeled-1.44.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.44.4'.

3:40 PM Changeset in webkit [5550] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3485925: Safari does not correctly parse eight-digit hex character entities
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseEntity): Replaced puzzling variable limit on number of hexadecimal characters to parse with an 8-character limit.
3:35 PM Changeset in webkit [5549]
  • 1 copy
    78 deletes in branches/unlabeled-1.36.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.36.4'.

3:35 PM Changeset in webkit [5548] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3485572 -- secure form check in KHTML uses case-sensitive comparison with "https"
  • khtml/html/html_formimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formWouldHaveSecureSubmission): Changed to take a DOMString reference for slightly better efficiency, and to use startsWith so the prefix check is not case sensitive and for slightly better efficiency and clarity than calling latin1() and using strncmp.
3:29 PM Changeset in webkit [5547] by mjs
  • 2 edits in trunk/WebCore
  • commit updated .lut.h file that I forgot to commit before
  • khtml/ecma/kjs_window.lut.h:
3:27 PM Changeset in webkit [5546] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3382829 - Safari won't load script src javascript if done by a document.write followed by document.close
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::closeInternal): Don't delete the tokenizer if it's waiting for scripts. It will get destroyed later when the part gets all subresources and closes the document.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::isWaitingForScripts): Added.
  • khtml/html/htmltokenizer.h: Prototyped.
  • khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::isWaitingForScripts): Added.
  • khtml/xml/xml_tokenizer.h: Prototyped.
3:24 PM Changeset in webkit [5545] by hyatt
  • 2 adds in trunk/LayoutTests/fast/invalid

Add malformed table content test.

3:23 PM Changeset in webkit [5544] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3480108, crash because of the wrong malformedTableParent when stray content is placed inside
a <tr>.

Reviewed by john

  • khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):
3:21 PM Changeset in webkit [5543] by mjs
  • 2 edits in trunk/WebCore

Add file I forgot in the last commit.

3:17 PM Changeset in webkit [5542] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3397494 - FileMaker: Setting option object text fails if created without text
  • khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::childrenChanged): Update the select element. This ends up getting called when you add a text node to an option that didn't used to have one.
3:12 PM Changeset in webkit [5541] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3480023>: Links don't work if there's a colon in the URL

The colon in the URL was confusing KURL. I modified some checks in
KURL so that its search for schemes stops when a non-scheme
character is found rather than when a path end segment character
is found.

  • kwq/KWQKURL.mm: Added a new Colon class to the table of characters. (isSchemeCharOrColon): New helper. (KURL::KURL): Call on new helper when looking for a scheme. (KURL::findHostnameInHierarchicalURL): Ditto.
2:20 PM Changeset in webkit [5540] by hyatt
  • 16 edits in trunk/LayoutTests

Revise layout tests now that we break on hyphens and question marks.

2:08 PM Changeset in webkit [5539] by hyatt
  • 2 edits in trunk/WebCore

Fix for 2931829, lines with hyphens should break on the hyphens. Match WinIE's behavior of
breaking on - and ?.

Reviewed by john

  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
1:15 PM Changeset in webkit [5538] by hyatt
  • 12 edits in trunk/LayoutTests

Check in revised layout tests after changing all the logical font size definitions.

12:38 PM Changeset in webkit [5537] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3415771, Safari should use mini form controls when necessary. This patch adds heuristics for
swapping in mini form controls and also drops intrinsic margins when mini form controls are used.

Fix for 3486454, options/optgroups should strip leading/trailing space.

Together these two fixes solve 3486581, travelocity misrenders because form controls are too large.

Reviewed by Darin

Also fixing 3474994, alink needs to be restricted to actual links and not all <a> tags.

Reviewed by John

Finally, adding :active outlines around <input type=image> (covered by the old bug 3141767).

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::applyRule): (khtml::CSSStyleSelector::checkForGenericFamilyChange): (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (khtml::): (khtml::CSSStyleSelector::fontSizeForKeyword): (khtml::CSSStyleSelector::largerFontSize): (khtml::CSSStyleSelector::smallerFontSize):
  • khtml/css/cssstyleselector.h:
  • khtml/css/html4.css:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
  • khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSelect::updateFromElement):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::attach):
  • kwq/KWQButton.mm: (KWQNSControlSizeForFont):
3:45 AM Changeset in webkit [5536] by hyatt
  • 2 edits in trunk/WebCore

Back out my change to exclude text runs from getting a relayout on a style change. I totally forgot about
text zooming.

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
1:29 AM Changeset in webkit [5535] by mjs
  • 11 edits
    1 add in trunk

WebCore:

Reviewed by Dave.

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

  • khtml/ecma/kjs_window.cpp: (Window::get): add support for window.print (Apple-only) (WindowFunc::tryCall): ditto
  • khtml/ecma/kjs_window.h: Add Print to enum
  • khtml/ecma/kjs_window.lut.h: Regenerated
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::print): Call bridge.
  • kwq/KWQKHTMLPart.h: Declare above.
  • kwq/WebCoreBridge.h: prototype print method for other side of bridge.

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): Call delegate.
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewPrint:]): Implemented (do nothing).
  • WebView.subproj/WebUIDelegatePrivate.h: Added. Add extra SPI method webViewPrint: for UI delegate.
  • WebKit.pbproj/project.pbxproj: Install WebUIDelegatePrivate.h as private header

WebBrowser:

Reviewed by Dave.

WebBrowser part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

  • BrowserWebController.m: (-[BrowserWebView webViewPrint:]): Call printDocument: on the document.

Nov 16, 2003:

9:34 PM Changeset in webkit [5534] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Check for the returned part being NULL, not the out value pointer.
6:31 PM Changeset in webkit [5533]
  • 1 copy
    71 deletes in branches/unlabeled-1.54.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.54.4'.

6:31 PM Changeset in webkit [5532] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3485779, <input type=image> and <button> should not be mouse focusable.

Fix for 3485795, <input type=image> and <button> are being treated like links when they should not be.

Fix for 3485817, <input type=image> and <button> should obey full keyboard access mode.

Fix for 3485802, fieldset/legend/option/optgroup/label should not be focusable at all.

Reviewed by kocienda

  • ChangeLog:
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::isMouseFocusable): (HTMLFieldSetElementImpl::isFocusable): (HTMLLabelElementImpl::isFocusable): (HTMLLegendElementImpl::isFocusable): (HTMLOptGroupElementImpl::isFocusable): (HTMLOptionElementImpl::HTMLOptionElementImpl): (HTMLOptionElementImpl::isFocusable):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isMouseFocusable): (HTMLAnchorElementImpl::isKeyboardFocusable):
  • khtml/html/html_inlineimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::tabsToLinks): (KHTMLPart::tabsToAllControls):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): (KWQKHTMLPart::tabsToLinks): (KWQKHTMLPart::tabsToAllControls):
5:36 PM Changeset in webkit [5531] by darin
  • 12 edits in trunk/WebKit

Reviewed by John.

  • fixes 3457162 -- selecting text during a page load that blows the text field away causes a crash
  • fixes 3160035 -- crash or hang if you hold down a button while "go to about:blank soon" test runs
  • without causing 3484608 -- REGRESSION: Flash broken at ​http://www.macromedia.com/

The WebKit part of this fix is making setDefersCallbacks: work. It had succumbed to bit rot.
This has a side effect of not considering a page load done until all the plug-in streams are loaded.
If that's not a good idea, we'll have to keep two separate lists in WebDataSource.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]): Set the defersCallbacks state from the WebView here so that clients don't have to do it.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]): Remove call to set the defersCallbacks state on the subresource client, because the above change obviates it. (the client/delegate terminology makes it confusing, but it's a subclass). Also loosen the type so we can call this on clients for plug-in streams too. (-[WebDataSource _removeSubresourceClient:]): Loosen type here too. (-[WebDataSource _defersCallbacksChanged]): And here.
  • WebView.subproj/WebDataSourcePrivate.h: Loosen type of subresource client so we can pass in the delegates for plug-in streams too.
  • WebView.subproj/WebMainResourceClient.h: Added an _initialRequest field so we can defer the very first callback, which does not rely on NSURLConnection.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): Release the initial request. (-[WebMainResourceClient loadWithRequestNow:]): Moved the guts of loadWithRequest in here; to be used when the request is no longer deferred. Also removed the code to call setDefersCallbacks: on the connection, and assert that we are only called when callbacks are not deferred. Because the very first callback was not deferred, we would end up calling setDefersCallbacks:NO on the WebView, so nothing would be deferred. (-[WebMainResourceClient loadWithRequest:]): If callbacks are not deferred, then call the loadWithRequestNow: method, otherwise simply store the request in _initialRequest. (-[WebMainResourceClient setDefersCallbacks:]): If there is an _initialRequest and we are ceasing deferral of callbacks, then call the loadWithRequestNow: method.
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Call _addSubresourceClient, and then _removeSubresourceClient if the load fails to even start. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Call _removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Call _removeSubresourceClient.
  • Plugins.subproj/WebBaseNetscapePluginStream.h: Removed unneeded import.
  • Plugins.subproj/WebPluginDatabase.m: Add import needed now that WebBaseNetscapePluginStream.h imports less than before.
5:13 PM Changeset in webkit [5530] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3484723 - name property of window reference from window.open call is always empty
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set the part name on the khtml side when making a new window.
4:02 PM Changeset in webkit [5529] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3485766.

Make sure DOM elements that are programmatically focused at a time when they have no render objects restore the
focus to their widgets when render objects get built.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach):
3:23 PM Changeset in webkit [5528] by mjs
  • 1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore/ChangeLog
  • merged the following fix from HEAD

2003-11-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.
3:03 PM Changeset in webkit [5527] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

  • JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.
3:02 PM Changeset in webkit [5526]
  • 1 copy
    115 deletes in branches/unlabeled-1.47.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.47.4'.

3:02 PM Changeset in webkit [5525]
  • 1 copy
    584 deletes in branches/unlabeled-1.3.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.4'.

3:02 PM Changeset in webkit [5524]
  • 1 copy
    986 deletes in branches/unlabeled-1.2.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2.4'.

3:02 PM Changeset in webkit [5523] by hyatt
  • 272 edits in trunk

Add border info to the render tree dumper.

  • khtml/rendering/render_style.h: (khtml::BorderValue::operator!=):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle): (operator<<):
  • layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/lxr.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/my.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/news.cnet.com/index-expected.txt:
  • layout-tests/apple-only/base/web.icq.com/index-expected.txt:
  • layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
  • layout-tests/apple-only/base/www.amazon.com/index-expected.txt:
  • layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
  • layout-tests/apple-only/base/www.excite.com/index-expected.txt:
  • layout-tests/apple-only/base/www.expedia.com/index-expected.txt:
  • layout-tests/apple-only/base/www.iplanet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
  • layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
  • layout-tests/apple-only/base/www.moviefone.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
  • layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
  • layout-tests/apple-only/base/www.sun.com/index-expected.txt:
  • layout-tests/apple-only/base/www.time.com/index-expected.txt:
  • layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
  • layout-tests/apple-only/base/www.yahoo.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com_Gamespot.com/index-expected.txt:
  • layout-tests/css1/basic/class_as_selector-expected.txt:
  • layout-tests/css1/basic/comments-expected.txt:
  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/basic/contextual_selectors-expected.txt:
  • layout-tests/css1/basic/grouping-expected.txt:
  • layout-tests/css1/basic/id_as_selector-expected.txt:
  • layout-tests/css1/basic/inheritance-expected.txt:
  • layout-tests/css1/box_properties/acid_test-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_color-expected.txt:
  • layout-tests/css1/box_properties/border_color_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_style-expected.txt:
  • layout-tests/css1/box_properties/border_style_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/cascade/cascade_order-expected.txt:
  • layout-tests/css1/cascade/important-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/classification/list_style-expected.txt:
  • layout-tests/css1/classification/list_style_image-expected.txt:
  • layout-tests/css1/classification/list_style_position-expected.txt:
  • layout-tests/css1/classification/list_style_type-expected.txt:
  • layout-tests/css1/classification/white_space-expected.txt:
  • layout-tests/css1/color_and_background/background-expected.txt:
  • layout-tests/css1/color_and_background/background_attachment-expected.txt:
  • layout-tests/css1/color_and_background/background_color-expected.txt:
  • layout-tests/css1/color_and_background/background_image-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/color_and_background/background_repeat-expected.txt:
  • layout-tests/css1/color_and_background/color-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_family-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/font_properties/font_style-expected.txt:
  • layout-tests/css1/font_properties/font_variant-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text-transform-expected.txt:
  • layout-tests/css1/text_properties/text_align-expected.txt:
  • layout-tests/css1/text_properties/text_decoration-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/text_transform-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/color_units-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/css1/units/percentage_units-expected.txt:
  • layout-tests/css1/units/urls-expected.txt:
  • layout-tests/fast/block/basic/001-expected.txt:
  • layout-tests/fast/block/basic/002-expected.txt:
  • layout-tests/fast/block/basic/003-expected.txt:
  • layout-tests/fast/block/basic/004-expected.txt:
  • layout-tests/fast/block/basic/007-expected.txt:
  • layout-tests/fast/block/basic/011-expected.txt:
  • layout-tests/fast/block/basic/015-expected.txt:
  • layout-tests/fast/block/basic/016-expected.txt:
  • layout-tests/fast/block/basic/017-expected.txt:
  • layout-tests/fast/block/basic/018-expected.txt:
  • layout-tests/fast/block/basic/019-expected.txt:
  • layout-tests/fast/block/float/004-expected.txt:
  • layout-tests/fast/block/float/005-expected.txt:
  • layout-tests/fast/block/float/006-expected.txt:
  • layout-tests/fast/block/float/007-expected.txt:
  • layout-tests/fast/block/float/012-expected.txt:
  • layout-tests/fast/block/float/013-expected.txt:
  • layout-tests/fast/block/float/015-expected.txt:
  • layout-tests/fast/block/float/016-expected.txt:
  • layout-tests/fast/block/float/017-expected.txt:
  • layout-tests/fast/block/float/019-expected.txt:
  • layout-tests/fast/block/float/021-expected.txt:
  • layout-tests/fast/block/float/022-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/float/025-expected.txt:
  • layout-tests/fast/block/float/026-expected.txt:
  • layout-tests/fast/block/float/027-expected.txt:
  • layout-tests/fast/block/float/028-expected.txt:
  • layout-tests/fast/block/margin-collapse/001-expected.txt:
  • layout-tests/fast/block/margin-collapse/005-expected.txt:
  • layout-tests/fast/block/margin-collapse/006-expected.txt:
  • layout-tests/fast/block/margin-collapse/010-expected.txt:
  • layout-tests/fast/block/margin-collapse/011-expected.txt:
  • layout-tests/fast/block/margin-collapse/012-expected.txt:
  • layout-tests/fast/block/margin-collapse/015-expected.txt:
  • layout-tests/fast/block/margin-collapse/016-expected.txt:
  • layout-tests/fast/block/margin-collapse/017-expected.txt:
  • layout-tests/fast/block/margin-collapse/018-expected.txt:
  • layout-tests/fast/block/margin-collapse/019-expected.txt:
  • layout-tests/fast/block/margin-collapse/020-expected.txt:
  • layout-tests/fast/block/margin-collapse/021-expected.txt:
  • layout-tests/fast/block/margin-collapse/022-expected.txt:
  • layout-tests/fast/block/margin-collapse/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/025-expected.txt:
  • layout-tests/fast/block/margin-collapse/026-expected.txt:
  • layout-tests/fast/block/margin-collapse/027-expected.txt:
  • layout-tests/fast/block/margin-collapse/028-expected.txt:
  • layout-tests/fast/block/margin-collapse/029-expected.txt:
  • layout-tests/fast/block/margin-collapse/030-expected.txt:
  • layout-tests/fast/block/margin-collapse/032-expected.txt:
  • layout-tests/fast/block/margin-collapse/033-expected.txt:
  • layout-tests/fast/block/margin-collapse/034-expected.txt:
  • layout-tests/fast/block/margin-collapse/035-expected.txt:
  • layout-tests/fast/block/margin-collapse/041-expected.txt:
  • layout-tests/fast/block/margin-collapse/042-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/positioning/048-expected.txt:
  • layout-tests/fast/block/positioning/049-expected.txt:
  • layout-tests/fast/block/positioning/050-expected.txt:
  • layout-tests/fast/block/positioning/051-expected.txt:
  • layout-tests/fast/block/positioning/056-expected.txt:
  • layout-tests/fast/block/positioning/057-expected.txt:
  • layout-tests/fast/block/positioning/058-expected.txt:
  • layout-tests/fast/block/positioning/auto/001-expected.txt:
  • layout-tests/fast/block/positioning/auto/002-expected.txt:
  • layout-tests/fast/block/positioning/auto/003-expected.txt:
  • layout-tests/fast/block/positioning/auto/004-expected.txt:
  • layout-tests/fast/block/positioning/auto/005-expected.txt:
  • layout-tests/fast/block/positioning/auto/006-expected.txt:
  • layout-tests/fast/clip/013-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/css/003-expected.txt:
  • layout-tests/fast/css/004-expected.txt:
  • layout-tests/fast/css/005-expected.txt:
  • layout-tests/fast/dynamic/002-expected.txt:
  • layout-tests/fast/dynamic/004-expected.txt:
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/011-expected.txt:
  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/flexbox/017-expected.txt:
  • layout-tests/fast/flexbox/018-expected.txt:
  • layout-tests/fast/flexbox/019-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/025-expected.txt:
  • layout-tests/fast/forms/001-expected.txt:
  • layout-tests/fast/forms/002-expected.txt:
  • layout-tests/fast/forms/006-expected.txt:
  • layout-tests/fast/forms/007-expected.txt:
  • layout-tests/fast/forms/form-element-geometry-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/inline-block/001-expected.txt:
  • layout-tests/fast/inline-block/002-expected.txt:
  • layout-tests/fast/inline-block/003-expected.txt:
  • layout-tests/fast/inline/001-expected.txt:
  • layout-tests/fast/invalid/008-expected.txt:
  • layout-tests/fast/invalid/014-expected.txt:
  • layout-tests/fast/invalid/016-expected.txt:
  • layout-tests/fast/lists/001-expected.txt:
  • layout-tests/fast/lists/004-expected.txt:
  • layout-tests/fast/lists/007-expected.txt:
  • layout-tests/fast/overflow/001-expected.txt:
  • layout-tests/fast/overflow/002-expected.txt:
  • layout-tests/fast/overflow/004-expected.txt:
  • layout-tests/fast/replaced/005-expected.txt:
  • layout-tests/fast/replaced/006-expected.txt:
  • layout-tests/fast/replaced/008-expected.txt:
  • layout-tests/fast/selectors/009-expected.txt:
  • layout-tests/fast/selectors/014-expected.txt:
  • layout-tests/fast/selectors/032-expected.txt:
  • layout-tests/fast/selectors/033-expected.txt:
  • layout-tests/fast/selectors/039-expected.txt:
  • layout-tests/fast/selectors/039b-expected.txt:
  • layout-tests/fast/selectors/064-expected.txt:
  • layout-tests/fast/selectors/077-expected.txt:
  • layout-tests/fast/selectors/077b-expected.txt:
  • layout-tests/fast/selectors/078-expected.txt:
  • layout-tests/fast/selectors/078b-expected.txt:
  • layout-tests/fast/selectors/166a-expected.txt:
  • layout-tests/fast/table/003-expected.txt:
  • layout-tests/fast/table/004-expected.txt:
  • layout-tests/fast/table/005-expected.txt:
  • layout-tests/fast/table/006-expected.txt:
  • layout-tests/fast/table/007-expected.txt:
  • layout-tests/fast/table/008-expected.txt:
  • layout-tests/fast/table/009-expected.txt:
  • layout-tests/fast/table/015-expected.txt:
  • layout-tests/fast/table/017-expected.txt:
  • layout-tests/fast/table/018-expected.txt:
  • layout-tests/fast/table/020-expected.txt:
  • layout-tests/fast/table/023-expected.txt:
  • layout-tests/fast/table/025-expected.txt:
  • layout-tests/fast/table/027-expected.txt:
  • layout-tests/fast/table/028-expected.txt:
  • layout-tests/fast/table/029-expected.txt:
  • layout-tests/fast/table/030-expected.txt:
  • layout-tests/fast/table/035-expected.txt:
  • layout-tests/fast/table/036-expected.txt:
  • layout-tests/fast/table/038-expected.txt:
  • layout-tests/fast/table/border-collapsing/001-expected.txt:
  • layout-tests/fast/table/border-collapsing/002-expected.txt:
  • layout-tests/fast/table/border-collapsing/003-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/table/large-width-expected.txt:
  • layout-tests/fast/table/nobr-expected.txt:
  • layout-tests/fast/text/basic/001-expected.txt:
  • layout-tests/fast/text/basic/003-expected.txt:
  • layout-tests/fast/text/basic/004-expected.txt:
  • layout-tests/fast/text/basic/005-expected.txt:
  • layout-tests/fast/text/basic/006-expected.txt:
  • layout-tests/fast/text/basic/007-expected.txt:
  • layout-tests/fast/text/basic/012-expected.txt:
  • layout-tests/fast/text/firstline/002-expected.txt:
  • layout-tests/fast/text/whitespace/002-expected.txt:
  • layout-tests/fast/text/whitespace/003-expected.txt:
  • layout-tests/fast/text/whitespace/020-expected.txt:
  • layout-tests/fast/text/whitespace/023-expected.txt:
  • layout-tests/fast/text/whitespace/024-expected.txt:
  • layout-tests/fast/text/whitespace/025-expected.txt:
  • layout-tests/fast/text/whitespace/027-expected.txt:
1:25 PM Changeset in webkit [5522] by mjs
  • 4 edits in trunk

WebCore:

Reviewed by John.

  • fixed 3362841 - javascript History Object length property is always 0
  • kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::property): For the historyLength property, retturn a UInt variant, not Int, because that's what the kjs_window code expects.

WebKit:

Reviewed by John.

  • fixed 3362841 - javascript History Object length property is always 0
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge historyLength]): Add one to the length to match other browsers.
1:20 PM Changeset in webkit [5521] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken and Dave.

  • fixed 3471925 - getting and setting cssText not implemented
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::cssText): Implemented by gathering text of all properties (that are not non-CSS hints), separated with semicolons. (CSSStyleDeclarationImpl::setCssText): Implemented by clearing all existing properties (that are not non-CSS hints) and invoking css parser. (CSSValueListImpl::cssText): Implemented. (FontValueImpl::cssText): Implemented. (ShadowValueImpl::cssText): Implemented. (CSSProperty::cssText): Implemented.
  • khtml/css/css_valueimpl.h: Declared new methods; made CSSValueImpl::cssText() pure virtual; removed CSSValueImpl::setCssText().
1:02 PM Changeset in webkit [5520] by hyatt
  • 1 edit in trunk/LayoutTests/fast/overflow/004.html

Fix overflow test to be in strict mode.

1:01 PM Changeset in webkit [5519] by hyatt
  • 11 adds in trunk/LayoutTests/fast/css

Adding css tests.

1:00 PM Changeset in webkit [5518] by hyatt
  • 2 deletes in trunk/LayoutTests/fast/selectors

Moving this test.

12:57 PM Changeset in webkit [5517] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Add a dynamic id manipulation test.

12:53 PM Changeset in webkit [5516] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/basic

Adding basic block tests for hr and h1

12:51 PM Changeset in webkit [5515] by hyatt
  • 8 adds in trunk/LayoutTests/fast/block/float

Add new tests for float displacement.

12:50 PM Changeset in webkit [5514] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/basic/016-expected.txt

Fix the alignment test.

12:48 PM Changeset in webkit [5513]
  • 1 copy
    93 deletes in branches/unlabeled-1.93.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.93.4'.

12:48 PM Changeset in webkit [5512]
  • 1 copy
    102 deletes in branches/unlabeled-1.17.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.17.4'.

12:48 PM Changeset in webkit [5511] by hyatt
  • 14 edits in trunk/WebCore

3485717, Cleanup of the float code. Eliminated the -khtml-flow-mode style property in favor of two simple methods,
avoidsFloats() and usesLineWidth(). avoidsFloats can be called to tell whether an object does not want
floats to intrude into its space (and that it should also move to avoid floats). usesLineWidth is called
to find out if an object's containing block width is the line width or the content width, and has all the
right smarts to emulate WinIE's behaviors in both quirks and strict mode.

Also fixed a bug (3485718) where overflow:scroll blocks with auto height did not factor in the horizontal scrollbar's
height (thus causing it to paint on top of content).

Reviewed by darin

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::clearFloats):
  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth):
  • khtml/rendering/render_object.cpp: (RenderObject::isHR):
  • khtml/rendering/render_object.h: (khtml::RenderObject::avoidsFloats): (khtml::RenderObject::usesLineWidth):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::initialTextDecoration):
  • khtml/rendering/render_table.cpp: (RenderTable::calcWidth):
12:33 PM Changeset in webkit [5510]
  • 7 copies
    3 deletes in tags/WebKit-106~1

This commit was manufactured by cvs2svn to create tag 'WebKit-106~1'.

12:33 PM Changeset in webkit [5509]
  • 25 copies
    2 deletes in tags/WebCore-106~1

This commit was manufactured by cvs2svn to create tag
'WebCore-106~1'.

12:33 PM Changeset in webkit [5508] by vicki
  • 2 edits in branches/SUPanBisque-branch
  • bump WebKit and WebCore versions to 106.1, for SUPanBisque
Note: See TracTimeline for information about the timeline view.