Context Navigation

Fixed 3525853. We weren't handling mapping to overloaded Java
methods very well. Even though this is undefined the other
browsers support it. Also fixed a bug with returning arrays
from Java functions.

Reviewed by John.

bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::methodsNamed):
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaMethod::signature): (JavaArray::valueAt):
bindings/jni/jni_runtime.h:
bindings/jni_jsobject.cpp: (JSObject::call): (JSObject::convertJObjectToValue):
bindings/runtime.cpp: (MethodList::addMethod): (MethodList::length): (MethodList::methodAt): (MethodList::~MethodList):
bindings/runtime.h: (KJS::Bindings::MethodList::MethodList):
bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):

Tests:

Extending test to cover issues in 3525853.

Reviewed by John.

ChangeLog:
LiveConnect/Blink/Blink.java: (Blink.init): (Blink.getStrings): (Blink): (Blink.getManyNumbers): (Blink.overloadedFunction):
LiveConnect/Blink/Blink.pbproj/project.pbxproj:
LiveConnect/Blink/test.html:

10:59 AM Changeset in webkit [5918] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3531229. Another place that needs the Push/PopLocalFrame
protection implemented for 3530401.

Reviewed by John.

bindings/runtime_method.cpp: (RuntimeMethodImp::call):

Jan 15, 2004:

5:58 PM Changeset in webkit [5917] by rjw

8 edits in trunk/JavaScriptCore

Fixed 3530401. JNI doesn't cleanup local refs created on the
main thread. IMO this is a bad bug in our JMI implementation.

To work-around the problem I explicitly delete all local refs.
Further, I've added Push/PopLocalFrame calls to catch any refs
that I may have missed. This will guarantee that we don't leak
any Java references.

Reviewed by John.

bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::JavaClass):
bindings/jni/jni_instance.cpp: (JavaInstance::begin): (JavaInstance::end):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod):
bindings/jni_jsobject.cpp: (JSObject::listFromJArray):
bindings/runtime.h: (KJS::Bindings::Instance::begin): (KJS::Bindings::Instance::end):
bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):

4:53 PM Changeset in webkit [5916] by hyatt

2 edits in trunk/WebCore

Fix for 3530734, many java applets don't show up. Go ahead and just use the width/height from the style
system as the initial size when the width/height are fixed.

Reviewed by rjw

khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):

4:14 PM Changeset in webkit [5915] by kocienda

7 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

A lot of clean up in the caret class now that the
old khtmlview functions have been moved in. Many
functions have been factored together and the
API now makes a lot more sense.

khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::invalidate): (Caret::setVisible): (Caret::repaint): (Caret::paint): (Caret::timerEvent):
khtml/editing/edit_caret.h: (khtml::Caret::visible):
khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

3:44 PM Changeset in webkit [5914] by rjw

1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

I previously checked the fix for 3529426, but the fix was commented out. Oops.

1:36 PM Changeset in webkit [5913] by kocienda

15 edits
2 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Purged all caret member functions from KHTMLView,
rolling them all into the Caret class.

khtml/dom/dom_node.cpp:
khtml/dom/dom_node.h:
khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::part): (Caret::view): (Caret::initCaret): (Caret::invalidate): (Caret::recalcAndStoreCaretPos): (Caret::caretOn): (Caret::caretOff): (Caret::showCaret): (Caret::hideCaret): (Caret::updateView): (Caret::placeCaret): (Caret::paintCaret): (Caret::timerEvent): (Caret::ensureNodeHasFocus):
khtml/editing/edit_caret.h: (khtml::Caret::node): (khtml::Caret::offset): (khtml::Caret::xPos): (khtml::Caret::yPos): (khtml::Caret::height): (khtml::Caret::visible): (khtml::Caret::displayed):
khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
khtml/html/html_elementimpl.cpp:
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::complete):
khtml/khtmlview.h:
khtml/rendering/render_object.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_nodeimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

1:18 PM Changeset in webkit [5912] by rjw

2 edits in trunk/WebCore

Fixed 3529426. Exclude pages that contain Java applets from
the page cache. The means applets get the normal stop/destroy
messages that they expect when a user leaves a page.

Reviewed by John.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):

11:06 AM Changeset in webkit [5911] by vicki

7 edits in trunk

JavaScriptCore:

Reviewed by Darin.

JavaScriptCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebCore:

Reviewed by Darin.

WebCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebKit:

Reviewed by Darin.

WebKit.pbproj/project.pbxproj: Update copyright date to 2004.
English.lproj/InfoPlist.strings: Update copyright date to 2004.

WebBrowser:

Reviewed by Darin.

WebBrowser.pbproj/project.pbxproj: Update copyright date to 2004.

8:29 AM Changeset in webkit [5910] by kocienda

1 edit
2 deletes in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Files now obsolete.

khtml/editing/edit_caretimpl.cpp: Removed.
khtml/editing/edit_caretimpl.h: Removed.

8:28 AM Changeset in webkit [5909] by kocienda

27 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

First batch of changes from my notes I wrote while chatting
with Dave. Many small improvements.

WebCore.pbproj/project.pbxproj:
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::~Caret): (Caret::node): (Caret::offset): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::notifyChanged):
khtml/editing/edit_caret.h: (khtml::Caret::Caret):
khtml/editing/edit_caretimpl.h:
khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::isEditingAtCaret): (KHTMLPart::caret): (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret):
khtml/khtml_part.h:
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::placeCaret):
khtml/rendering/render_br.cpp: (RenderBR::caretMinOffset): (RenderBR::caretMaxOffset):
khtml/rendering/render_br.h:
khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
khtml/rendering/render_line.cpp: (InlineBox::caretMinOffset): (InlineBox::caretMaxOffset):
khtml/rendering/render_line.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::caretMinOffset): (RenderReplaced::caretMaxOffset):
khtml/rendering/render_replaced.h:
khtml/rendering/render_style.cpp: (userModify): (StyleCSS3InheritedData): (StyleCSS3InheritedData::shadowDataEquivalent):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
khtml/rendering/render_text.h:
kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):

8:26 AM Changeset in webkit [5908] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button

khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Add missing nil check that the other call to javaEnabled has.

Jan 14, 2004:

5:41 PM Changeset in webkit [5907] by vicki

3 edits in trunk

change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist change in rdar://problem/3529511

5:10 PM Changeset in webkit [5906] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3529466. With recent changes to Java plugin we must no
longer call DeleteLocalRef(). Not a problem, it was an optimization anyway.

Reviewed by John.

bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):

5:04 PM Changeset in webkit [5905] by vicki

3 edits in trunk

change version number to "123u". The tree is open for Safari-123

4:47 PM Changeset in webkit [5904]

3 copies in tags/Safari-122

This commit was manufactured by cvs2svn to create tag 'Safari-122'.

4:47 PM Changeset in webkit [5903] by vicki

6 edits in trunk

Safari-122 stamp (we'll have to change the release marker in WebBrowser after john's check in)

4:16 PM Changeset in webkit [5902] by hyatt

2 edits in trunk/WebCore

Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a minimum width of 0.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth):

1:00 PM Changeset in webkit [5901] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3529010.

Finalize may be called on an JSObject after we've already remove all our references. The assert in this case is firing because we've received a finalize call from Java for an instance that we no longer know about. The fix is to check in finalize that we're getting a call on an instance that we still care about.

Reviewed by John.

bindings/jni_jsobject.cpp: (addJavaReference): (removeJavaReference): (RootObject::removeAllJavaReferencesForRoot): (JSObject::invoke):

10:41 AM Changeset in webkit [5900] by kocienda

12 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Did quite a lot of cleanup in the way that
the caret position is set programmatically.
The attempt was to funnel more code through
KHTMLPart::moveCaretTo.

khtml/editing/edit_caret.cpp:
khtml/editing/edit_caret.h:
khtml/editing/edit_caretimpl.cpp: (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::adjustPosition):
khtml/editing/edit_caretimpl.h:
khtml/editing/htmlediting.cpp: (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): (HTMLElementImpl::defaultEventHandler):
khtml/html/html_elementimpl.h:
khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret): (KHTMLPart::nextNodeWithRenderer):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret):
khtml/khtmlview.h:

Jan 13, 2004:

8:57 PM Changeset in webkit [5899] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3528324.

The run loop that is used to execute JavaScript (in practice, always the main run loop) is held in a class variable. It is set and retained once and should not be released. Unfortunately is it being released when the 'root' object on a LiveConnect applet is released. This has the symptom of eventually causing an deallocation of the main run loop! Usually after about 5 instantiations/destructions of a LiveConnect applet. The CFRelease of the run loop was removed.

Reviewed by Hyatt.

bindings/jni_jsobject.h: (KJS::Bindings::RootObject::~RootObject):

6:32 PM Changeset in webkit [5898]

5 copies
2 deletes in tags/HTML-editing-hacks-anchor

This commit was manufactured by cvs2svn to create tag
'HTML-editing-hacks-anchor'.

6:32 PM Changeset in webkit [5897] by hyatt

3 edits in trunk/WebCore

Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negative when computing
positioned elements' heights. Also bulletproof the crash in case there are other negative height code
paths.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats):
khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):

5:12 PM Changeset in webkit [5896] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3527853>: REGRESSION (119-120): Peoplesoft menus do not work

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set m_bComplete to false, so it can get set right back to true if we're actually done loading and fire all the right signals.

11:36 AM Changeset in webkit [5895] by hyatt

2 edits in trunk/WebCore

Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our
Java applets can't yet resize.

Reviewed by john

khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout): (RenderEmptyApplet::layout):

10:04 AM Changeset in webkit [5894]

350 copies in branches/HTML-editing-hacks-branch

This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.

10:04 AM Changeset in webkit [5893] by kocienda

31 edits in branches

Reviewed by me

Merged TOT onto the branch

ChangeLog:
WebCore.pbproj/project.pbxproj:
khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp:
khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
khtml/ecma/kjs_html.lut.h: (KJS::):
khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::setZoomFactor): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::editorContext): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::dispatchMouseEvent): (KHTMLView::moveCaretTo):
khtml/khtmlview.h:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionNewFloats):
khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
khtml/rendering/render_frames.h:
khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData):
khtml/rendering/render_style.h:
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setStyle):
khtml/rendering/render_table.h: (khtml::RenderTableCol::lineHeight):
khtml/rendering/render_text.cpp: (RenderText::paintObject):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attach): (DocumentImpl::setInPageCache):
khtml/xml/dom_docimpl.h:
kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityActionDescription:]):
kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): (QKeyEvent::QKeyEvent):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::scrollToAnchor): (KWQKHTMLPart::attributedString):
kwq/KWQPageState.h:
kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): (-[KWQPageState clear]): (-[KWQPageState invalidate]): (-[KWQPageState dealloc]): (-[KWQPageState interpreterBuiltins]):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]): (-[WebCoreBridge setTextSizeMultiplier:]): (-[WebCoreBridge needsLayout]): (-[WebCoreBridge setNeedsLayout]):
kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):

Jan 12, 2004:

9:04 AM Changeset in webkit [5892] by kocienda

4 edits in branches

Reviewed by me

Some more clean up to basic caret movement and basic editing.
Fixed deleting BR's, which I broke late last week.

khtml/editing/htmlediting.cpp: (EditCommand::notifyChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/editing/htmlediting.h:
khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo):

Jan 11, 2004:

4:42 PM Changeset in webkit [5891] by vicki

3 edits in trunk

changed version number from '121' to '122u'

4:27 PM Changeset in webkit [5890]

3 copies in tags/Safari-121

This commit was manufactured by cvs2svn to create tag 'Safari-121'.

4:27 PM Changeset in webkit [5889] by vicki

3 edits in trunk

Safari-121 stamp

(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)

12:09 PM Changeset in webkit [5888] by darin

2 edits in trunk/WebCore

fixed Dave's check-in so it compiles; I assume he forgot to land one source file

khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.

11:06 AM Changeset in webkit [5887] by hyatt

3 edits in trunk/WebCore

Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the previous attempt.

Reviewed by darin

khtml/rendering/render_frames.cpp: (RenderPart::updateWidgetPositions):
khtml/rendering/render_frames.h:
khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):

Jan 10, 2004:

4:08 PM Changeset in webkit [5886] by darin

4 edits in trunk/WebKit

Reviewed by John.

fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)

Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
change I made that introduced this regression. Also remove the plug-in client in one case I had missed
before (cancel).

WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Release the set. (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set. (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set. (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto. (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and then call super.

12:10 PM Changeset in webkit [5885] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored

kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers. (QKeyEvent::QKeyEvent): Ditto.

Jan 9, 2004:

5:07 PM Changeset in webkit [5884] by kocienda

3 edits in branches

Reviewed by me

Did some caret adjustments to make the caret position
itself into the correct position when between text nodes.

khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (CaretImpl::notifyChanged):
khtml/editing/edit_caretimpl.h:

4:44 PM Changeset in webkit [5883] by darin

3 edits in trunk/WebKit

rolled out most of Dave's change for 3510669 and 3515442; it is not working yet

WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLView.m:

3:31 PM Changeset in webkit [5882] by mjs

2 edits in trunk/WebKit

Reviewed by Chris.

<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)

WebCoreSupport.subproj/WebKeyGeneration.cpp: (createPair): Cut & paste hunk of code from Security framework. (Safari_SecKeyCreatePair): Ditto. (signedPublicKeyAndChallengeString): Instead of creating a normal ACL, use our hacked version of the SecKeyCreatePair call that doesn't put in any kind of ACL. This works around a SecureTransport bug.

2:47 PM Changeset in webkit [5881] by hyatt

3 edits in trunk/WebCore

Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.

Reviewed by darin

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setNeedsLayout]):

2:43 PM Changeset in webkit [5880] by hyatt

4 edits in trunk/WebKit

Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.

Reviewed by darin

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]):
WebView.subproj/WebHTMLViewPrivate.h:

1:42 PM Changeset in webkit [5879] by kocienda

4 edits in branches

Reviewed by me

Made it so the cursor does not blink while you are
navigating with the arrow keys.

khtml/editing/edit_caretimpl.cpp: (CaretImpl::setPosition):
khtml/editing/edit_caretimpl.h: (khtml::CaretImpl::setOffset):
khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret):

1:09 PM Changeset in webkit [5878] by kocienda

13 edits in branches

Reviewed by me

Moved contenteditable to use the style system.

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::isContentEditable): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
khtml/html/html_elementimpl.h:
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):

12:11 PM Changeset in webkit [5877] by darin

2 edits in trunk/WebKit

Reviewed by Chris.

fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit

Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease pool stuff in the default run loop mode. If we're in another run loop mode that means we are in some Cocoa code that sets up its own autorelease pool; it's important that we don't release ours in that case.

8:53 AM Changeset in webkit [5876] by kocienda

15 edits in branches

Reviewed by me

A whole host of editing improvements

khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::setStartOfLine): (Caret::adjustPosition): (Caret::adjustedForEditing):
khtml/editing/edit_caret.h:
khtml/editing/edit_caretimpl.cpp: (CaretImpl::CaretImpl): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::adjustPosition): (EditNodeFilter::acceptNode):
khtml/editing/edit_caretimpl.h:
khtml/editing/htmlediting.cpp: (EditCommand::EditCommand): (EditCommand::~EditCommand): (EditCommand::notifyChanged): (EditCommand::notifyNodesChanged): (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::apply): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::apply):
khtml/editing/htmlediting.h: (khtml::EditCommand::document):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler):
khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::caret): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::foldSelectionToCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
khtml/xml/dom_docimpl.cpp:
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::previousLeafNode):
khtml/xml/dom_nodeimpl.h:

Jan 8, 2004:

5:49 PM Changeset in webkit [5875] by hyatt

2 edits in trunk/WebCore

Fix for 3524118, floats don't repaint when moved.

Reviewed by darin

khtml/rendering/render_block.cpp:

(khtml::RenderBlock::positionNewFloats):

3:47 PM Changeset in webkit [5874] by mjs

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3522298>: Error on MIT's x509 certificate site

WebCoreSupport.subproj/WebKeyGeneration.cpp: (addCertificatesToKeychainFromData): Sign the freshly minted public key using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.

3:36 PM Changeset in webkit [5873] by rjw

2 edits in trunk/WebKit

Fixed 3524430. This was a regression introduced when we added '-' and '?' to the word boundary detection.

Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.

Reviewed by Hyatt.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (widthForNextCharacter):

3:35 PM Changeset in webkit [5872] by hyatt

2 edits in trunk/WebCore

Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same children as <ul> and <ol>.

Reviewed by darin

khtml/html/dtd.cpp: (DOM::checkChild):

3:07 PM Changeset in webkit [5871] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html

Reviewed by darin.

Misc.subproj/WebKitNSStringExtras.h:
Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): new method, returns the encoding for a resource handle given its file system path
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): call _web_encodingForResource when creating the NSString

2:23 PM Changeset in webkit [5870] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3524359>: REGRESSSION (119-120): Double click to select text in form broken

Reviewed by Dave and Darin.

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't blur the focused node if that's the one you clicked on.

Jan 7, 2004:

4:45 PM Changeset in webkit [5869] by rjw

2 edits in trunk/WebCore

WebCore:

Fixed 3517550. Named array lookup of applet failed, i.e.:
var appletobj = document.appletsmyapplet

Reviewed by Chris.

khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):

Tests:

Added lookup test for all three variants of applet access:
named, indexed array, and named array.

LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
LiveConnect/Blink/Blink.pbproj/project.pbxproj:
LiveConnect/Blink/test.html:

10:58 AM Changeset in webkit [5868] by vicki

3 edits in trunk

ok, back to 121u now. tree is still closed.

10:51 AM Changeset in webkit [5867]

3 copies in tags/Safari-120

This commit was manufactured by cvs2svn to create tag 'Safari-120'.

10:51 AM Changeset in webkit [5866] by vicki

3 edits in trunk

silly me. i forgot to actually tag before updating the version number to 121u.

10:35 AM Changeset in webkit [5865] by vicki

3 edits in trunk

set version number to 121u -- the tree is still closed

10:32 AM Changeset in webkit [5864] by vicki

6 edits in trunk

Safari-120 stamp

Jan 6, 2004:

5:15 PM Changeset in webkit [5863] by hyatt

4 edits in trunk/WebCore

Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved.

Fix for 33522497, empty AXElements appear in AXBrowser.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth):
khtml/rendering/render_table.h:

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):

3:39 PM Changeset in webkit [5862] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3484465>: REGRESSION (118): button click does not take focus away from <textarea>; breaks Outlook Web Access

Reviewed by Dave.

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Removed nodeimpl == nil test that was preventing button/link clicks from blurring previously-focused text field.

3:09 PM Changeset in webkit [5861] by rjw

2 edits in trunk/WebKit

Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _createATSUTextLayoutForRun:]):

1:59 PM Changeset in webkit [5860] by hyatt

1 edit in trunk/WebCore/kwq/WebCoreBridge.mm

I meant kMax not kMin here.

1:55 PM Changeset in webkit [5859] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3521814. Finalize messages weren't being dispatched!

Reviewed by John.

bindings/jni_jsobject.cpp: (JSObject::invoke):

12:52 PM Changeset in webkit [5858] by hyatt

3 edits in trunk/WebCore

Fix for 3520636, infinite loop in page breaking code when printing.

Reviewed by darin

khtml/rendering/render_text.cpp: (RenderText::paintObject):
kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):

Jan 5, 2004:

3:24 PM Changeset in webkit [5857] by hyatt

2 edits in trunk/WebCore

Fix for 3521466, generated image content should not try to calcWidth/height when it isn't yet rooted in
the rendering tree.

Reviewed by john

khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

2:52 PM Changeset in webkit [5856] by rjw

2 edits in trunk/WebKit

Fix for 3514454. Work-around added for 3521759.

Filed 3521781 to cover deeper problem.

Reviewed by Kocienda.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

9:44 AM Changeset in webkit [5855] by rjw

8 edits in trunk/JavaScriptCore

Added cache of JNI method IDs to minimize allocations. This mitigates the problem
described by 3515579.

Also cleanup up logging of Java exceptions.

Reviewed by John.

bindings/jni/jni_class.cpp: (JavaClass::classForInstance):
bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::getClass): (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
bindings/jni/jni_instance.h: (KJS::Bindings::JavaInstance::operator=):
bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): (JavaMethod::methodID):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::JavaMethod):
bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodIDA): (callJNIMethodA): (KJS::Bindings::getMethodID): (KJS::Bindings::callJNIVoidMethodIDA): (KJS::Bindings::callJNIObjectMethodIDA): (KJS::Bindings::callJNIByteMethodIDA): (KJS::Bindings::callJNICharMethodIDA): (KJS::Bindings::callJNIShortMethodIDA): (KJS::Bindings::callJNIIntMethodIDA): (KJS::Bindings::callJNILongMethodIDA): (KJS::Bindings::callJNIFloatMethodIDA): (KJS::Bindings::callJNIDoubleMethodIDA): (KJS::Bindings::callJNIBooleanMethodIDA): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::getJNIField):
bindings/jni/jni_utility.h:

Dec 26, 2003:

2:21 PM Changeset in webkit [5854] by darin

2 edits in trunk

Tweak some old ChangeLog entries (mostly removed "removed by me").

8:56 AM Changeset in webkit [5853] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix change log entry.

7:57 AM Changeset in webkit [5852] by darin

2 edits in trunk/WebCore

one more small step to make -[KWQPageState dealloc] safer

kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Only do the real detach() if the document is already in the detached state; we don't want to detach twice.

Dec 23, 2003:

5:50 PM Changeset in webkit [5851] by sullivan

5 edits in trunk

JavaScriptCore:

JavaScriptCore.pbproj/project.pbxproj: Xcode version wars, harmless

WebCore:

fixed <rdar://problem/3451306>: address book search fails at Airborne Express Corporate site (Apple Shipping wants to use it)

Reviewed by Darin.

khtml/ecma/kjs_html.cpp: commented out definition of document.all; now sites like this one that set document.all to a value will work.
khtml/ecma/kjs_html.lut.h: (KJS::): regenerated this file

4:37 PM Changeset in webkit [5850] by darin

2 edits in trunk/JavaScriptCore

Reviewed by John (concept, not code, which is just the old code coming back).

fixed 3518092: REGRESSION (100-119): getting NaN instead of HH:MM times

kjs/date_object.cpp: Added back our CF-based implementations of gmtime, localtime, mktime, timegm, and time, because mktime, at least, won't handle a year of 0.

3:52 PM Changeset in webkit [5849] by darin

1 edit in trunk/WebKit/ChangeLog

Fix some old malformed log entries.

3:52 PM Changeset in webkit [5848] by darin

6 edits in trunk/WebCore

Reviewed by John.

another try at fixing the -[KWQPageState dealloc] bug, even though we don't fully understand it

This change saves the renderer inside the document rather than in the KWQPageState to
try to eliminate the possibility that multiple KWQPageState objects could restore the
same renderer multiple times, resulting in multiple detaches of the same renderer.

khtml/xml/dom_docimpl.h: Add a m_savedRenderer field.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_savedRenderer to 0. (DocumentImpl::~DocumentImpl): Added some asserts to make sure we don't get destroyed while we are in the page cache. (DocumentImpl::attach): Added an assert. (DocumentImpl::setInPageCache): Save the renderer when setting the flag, and restore the renderer when clearing it.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Instead of doing a restoreRenderer call, just do setInPageCache(NO), which will restore the renderer as a side effect.

kwq/KWQPageState.h: Removed the renderer method and field.
kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): Don't store a pointer to the renderer. (-[KWQPageState clear]): New method, shared by invalidate and dealloc. (-[KWQPageState invalidate]): Removed code relating to "relinquishing object ownership"; just deallocate everything here without doing a detach(). (-[KWQPageState dealloc]): Removed restoreRenderer now that setInPageCache(NO) handles that. Added some assertions. Share code with invalidate by calling clear.

Dec 22, 2003:

2:30 PM Changeset in webkit [5847] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3508798>: ACCESSIBILITY: role/description/value strings not defined

Reviewed by Darin.

kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): provide not-yet-localized strings for all the role descriptions that this class uses. (-[KWQAccObject value]): return nil string rather than dummy string for the cases where we don't have a value attribute. (-[KWQAccObject accessibilityActionDescription:]): changed comment passed to UI_STRING bogus macro so it won't have to change if/when macro loses its bogosity

11:32 AM Changeset in webkit [5846] by sullivan

6 edits in trunk

WebCore:

WebCore part of fix for <rdar://problem/3515706>: REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

Reviewed by Darin.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]): renamed method for clarity; now iterates over pages horizontally as well as vertically; assume x starts at 0 as we were already assuming that y starts at 0; now returns autoreleased result

WebKit:

WebKit part of fix for <rdar://problem/3515706>: REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _userScaleFactorForPrintOperation:]): new method, extracts the scale factor provided by the user in the Page Setup dialog (-[WebHTMLView _scaleFactorForPrintOperation:]): take user scale factor into account (-[WebHTMLView knowsPageRange:]): renamed local var scaleFactor -> totalScaleFactor for clarity; take user scale factor into account for print width; now assumes computePageRects returns autoreleased result.

WebKit.pbproj/project.pbxproj: Xcode version wars; Darin says these don't affect the build.

WebBrowser:

Reviewed by Darin.

WebBrowser.pbproj/project.pbxproj: Xcode version wars; Darin says these don't affect the build.

11:26 AM Changeset in webkit [5845] by darin

3 edits in trunk/WebCore

Reviewed by John.

follow-on to my fix for 3467919: handle collapsed spaces at the starts of runs too, not just at the end, and make sure that a space inherits style from the run it was collapsed from rather than always from the run it precedes

khtml/khtml_part.cpp: (KHTMLPart::text): Add code to deal with collapsed spaces at the start of runs.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Change code to keep the style of a space that was collapsed at the end of the run, and use that styled space if necessary. Also add the code to deal with collapsed spaces at the start of runs. Also remove comment that refers to long-since-deleted code.

9:42 AM Changeset in webkit [5844] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3467919: REGRESSION (91-92): space missing when copying text with link at start or end of line

khtml/khtml_part.cpp: (KHTMLPart::text):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Changed both "turn HTML into text" code paths to generate spaces in a different way. First, corrected the logic so it notices spaces left out at the end of a RenderText object. Second, don't emit the space until we are emitting more text, to prevent emitting trailing spaces. To get this completely right for the attributed string case, I had to add code to adjust the offset used to mark links.

9:40 AM Changeset in webkit [5843] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3477453: nowrap in a fixed-width TD is ignored on screen but not when printed (Williams-Sonoma)

khtml/rendering/render_table.cpp: (RenderTableCell::setStyle): Compute the proper whitespace mode before calling the base class setStyle, since the base class setStyle may create styles that inherit from our style, and we want them to inherit the computed whitespace mode.

WebCore.pbproj/project.pbxproj: Let Xcode be 1.1, as it was meant to be.

Dec 21, 2003:

12:42 PM Changeset in webkit [5842] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed a storage leak

WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Move the release of the request out of an if statement, since it's always needed.

12:40 PM Changeset in webkit [5841] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed a storage leak

khtml/rendering/render_style.h: Added a destructor and a private unimplemented assignment operator to StyleCSS3InheritedData, since the textShadow field that needs to be allocated and deallocated and the default destructor and assignment operator don't do that.
khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData): Added destructor that deletes the textShadow object.

fixed locking for JavaScript debugging tools in Caches window

kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): Lock and unlock around call to JavaScriptCore. (+[WebCoreJavaScript garbageCollect]): Ditto.

Dec 19, 2003:

9:16 PM Changeset in webkit [5840] by hyatt

3 edits in trunk/WebCore

Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at the bottom of
amazon.com.

Reviewed by john

khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]):

4:32 PM Changeset in webkit [5839] by kocienda

8 edits in branches

Reviewed by me

Made out TreeWalker implementation less lame. It's not
done yet, but it's a lot better.

khtml/dom/dom2_traversal.cpp: (TreeWalker::root): (TreeWalker::whatToShow): (TreeWalker::filter): (TreeWalker::expandEntityReferences): (TreeWalker::currentNode): (TreeWalker::setCurrentNode):
khtml/dom/dom2_traversal.h:
khtml/editing/edit_caretimpl.cpp: (CaretImpl::adjustForEditing):
khtml/xml/dom2_traversalimpl.cpp: (TreeWalkerImpl::TreeWalkerImpl): (TreeWalkerImpl::operator=): (TreeWalkerImpl::~TreeWalkerImpl): (TreeWalkerImpl::setRoot): (TreeWalkerImpl::setFilter): (TreeWalkerImpl::setCurrentNode): (TreeWalkerImpl::parentNode): (TreeWalkerImpl::firstChild): (TreeWalkerImpl::lastChild): (TreeWalkerImpl::previousSibling): (TreeWalkerImpl::nextSibling): (TreeWalkerImpl::previousNode): (TreeWalkerImpl::nextNode): (TreeWalkerImpl::isAccepted): (firstDescendent): (lastDescendent):
khtml/xml/dom2_traversalimpl.h: (DOM::TreeWalkerImpl::root): (DOM::TreeWalkerImpl::whatToShow): (DOM::TreeWalkerImpl::filter): (DOM::TreeWalkerImpl::expandEntityReferences): (DOM::TreeWalkerImpl::currentNode): (DOM::TreeWalkerImpl::setWhatToShow): (DOM::TreeWalkerImpl::setExpandEntityReferences): (DOM::TreeWalkerImpl::assertNodeValid):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createTreeWalker):
khtml/xml/dom_docimpl.h:

3:06 PM Changeset in webkit [5838] by rjw

2 edits in trunk/WebCore

Fixed 3515590. Return Undefined to JS for applet if
Java is disabled.

Reviewed by Chris.

khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):

1:55 PM Changeset in webkit [5837] by rjw

3 edits in trunk/JavaScriptCore

Fixed 3515597. When an error occurs we need
to make sure result values are zeroed.

Cleaned up logs by adding a newline.

Reviewed by John.

bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (callJNIMethod): (callJNIMethodA): (KJS::Bindings::getJNIField):
bindings/jni_jsobject.cpp: (JSObject::convertValueToJObject):

1:25 PM Changeset in webkit [5836] by mjs

2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3512545>: reproducible assertion failure in KWQKHTMLPart::addData scrolling to anchor while page loads

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Don't pretend we finished loading, because we don't actually make anchor scrolling stop the current page load.

11:54 AM Changeset in webkit [5835] by kocienda

41 edits in branches

Reviewed by me

Merged HEAD to branch

ChangeLog:
WebCore.pbproj/project.pbxproj:
khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp:
khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::updateDOMObjectDocument):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseAttribute): (HTMLFrameElementImpl::setLocation): (HTMLIFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::openURL):
khtml/html/html_baseimpl.h:
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::click): (HTMLInputElementImpl::accessKeyAction):
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): (HTMLAnchorElementImpl::isMouseFocusable):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::notifyFinished):
khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::dispatchMouseEvent):
khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_form.cpp: (RenderFileButton::slotTextChanged): (RenderFileButton::click):
khtml/rendering/render_form.h:
khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
khtml/rendering/render_inline.h:
khtml/rendering/render_object.cpp: (RenderObject::absoluteRects): (checkFloats): (RenderObject::removeFromObjectLists):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::absoluteRects): (RenderText::paintObject):
khtml/rendering/render_text.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::setDocument): (NodeImpl::checkAddChild):
khtml/xml/dom_nodeimpl.h:
kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]):
kwq/KWQApplication.mm: (QDesktopWidget::screenNumber): (QDesktopWidget::screenGeometry):
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::click):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
kwq/KWQKWinModule.mm: (KWinModule::workArea):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

9:59 AM Changeset in webkit [5834] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies

Reviewed by john.

WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
WebView.subproj/WebImageView.h:
WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebImageView mouseDragged:]): if ignoringMouseDraggedEvents, return (-[WebImageView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to YES

9:46 AM Changeset in webkit [5833] by vicki

3 edits in trunk

* empty log message *

9:37 AM Changeset in webkit [5832]

3 copies in tags/Safari-119

This commit was manufactured by cvs2svn to create tag 'Safari-119'.

9:37 AM Changeset in webkit [5831] by vicki

6 edits in trunk

top level:

Reviewed by me

Site/Internal/Design/html-editing-tasks.fp5: Added.

Tools:

disallow installation on 10.3.2 and later; update strings with better error messages

Install_resources/InstallationCheck:
Install_resources/InstallationCheck.strings:

JavaScriptCore:

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

Reviewed by Dave.

ChangeLog:
bindings/jni/jni_class.cpp:
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (JavaMethod::signature):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::ascii): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaField::name): (KJS::Bindings::JavaField::type): (KJS::Bindings::JavaMethod::name): (KJS::Bindings::JavaMethod::returnType):
bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (KJS::Bindings::callJNIVoidMethod): (KJS::Bindings::callJNIObjectMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIByteMethod): (KJS::Bindings::callJNICharMethod): (KJS::Bindings::callJNIShortMethod): (KJS::Bindings::callJNIIntMethod): (KJS::Bindings::callJNILongMethod): (KJS::Bindings::callJNIFloatMethod): (KJS::Bindings::callJNIDoubleMethod): (KJS::Bindings::callJNIVoidMethodA): (KJS::Bindings::callJNIObjectMethodA): (KJS::Bindings::callJNIByteMethodA): (KJS::Bindings::callJNICharMethodA): (KJS::Bindings::callJNIShortMethodA): (KJS::Bindings::callJNIIntMethodA): (KJS::Bindings::callJNILongMethodA): (KJS::Bindings::callJNIFloatMethodA): (KJS::Bindings::callJNIDoubleMethodA): (KJS::Bindings::callJNIBooleanMethodA): (KJS::Bindings::getCharactersFromJString): (KJS::Bindings::releaseCharactersForJString): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::releaseCharactersForJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::releaseUCharactersForJStringInEnv): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/jni_jsobject.cpp: (KJS::Bindings::JSObject::invoke): (KJS::Bindings::JSObject::JSObject): (KJS::Bindings::JSObject::call): (KJS::Bindings::JSObject::eval): (KJS::Bindings::JSObject::getMember): (KJS::Bindings::JSObject::setMember): (KJS::Bindings::JSObject::removeMember): (KJS::Bindings::JSObject::getSlot): (KJS::Bindings::JSObject::setSlot): (KJS::Bindings::JSObject::toString): (KJS::Bindings::JSObject::finalize): (KJS::Bindings::JSObject::createNative): (KJS::Bindings::JSObject::convertValueToJObject): (KJS::Bindings::JSObject::convertJObjectToValue): (KJS::Bindings::JSObject::listFromJArray):
bindings/jni_jsobject.h:
bindings/runtime.cpp:
bindings/runtime.h:
bindings/runtime_method.cpp:
bindings/runtime_method.h:

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
LiveConnect/Blink/test.html:

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebBrowser:

Reviewed by Chris

BrowserNSDataExtras.m: (-[NSData certificateFromMultipartData]): Fix off-by-one error in code to strip trailing CRLFs off certificate data.

WebKitExamples:

Fixed 3455347. WEBVIEW: Dragging links from a Carbon HIWebView crash with NSException raise
Written be Ed. This code is often copy/pasted by developers, so this problem propagates.

Reviewed by Richard.

CarbonWeb/CarbonWeb.pbproj/project.pbxproj:
CarbonWeb/TWebWindow.cp:

Dec 18, 2003:

3:14 PM Changeset in webkit [5830] by rjw

11 edits in trunk

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

Dec 17, 2003:

7:56 PM Changeset in webkit [5829] by rjw

6 edits in trunk/WebCore

Fixed build problem resulting from addition of KJS to Bindings namespace.

6:49 PM Changeset in webkit [5828] by rjw

15 edits in trunk/JavaScriptCore

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

Reviewed by Dave.

ChangeLog:
bindings/jni/jni_class.cpp:
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (JavaMethod::signature):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::ascii): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaField::name): (KJS::Bindings::JavaField::type): (KJS::Bindings::JavaMethod::name): (KJS::Bindings::JavaMethod::returnType):
bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (KJS::Bindings::callJNIVoidMethod): (KJS::Bindings::callJNIObjectMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIByteMethod): (KJS::Bindings::callJNICharMethod): (KJS::Bindings::callJNIShortMethod): (KJS::Bindings::callJNIIntMethod): (KJS::Bindings::callJNILongMethod): (KJS::Bindings::callJNIFloatMethod): (KJS::Bindings::callJNIDoubleMethod): (KJS::Bindings::callJNIVoidMethodA): (KJS::Bindings::callJNIObjectMethodA): (KJS::Bindings::callJNIByteMethodA): (KJS::Bindings::callJNICharMethodA): (KJS::Bindings::callJNIShortMethodA): (KJS::Bindings::callJNIIntMethodA): (KJS::Bindings::callJNILongMethodA): (KJS::Bindings::callJNIFloatMethodA): (KJS::Bindings::callJNIDoubleMethodA): (KJS::Bindings::callJNIBooleanMethodA): (KJS::Bindings::getCharactersFromJString): (KJS::Bindings::releaseCharactersForJString): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::releaseCharactersForJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::releaseUCharactersForJStringInEnv): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/jni_jsobject.cpp: (KJS::Bindings::JSObject::invoke): (KJS::Bindings::JSObject::JSObject): (KJS::Bindings::JSObject::call): (KJS::Bindings::JSObject::eval): (KJS::Bindings::JSObject::getMember): (KJS::Bindings::JSObject::setMember): (KJS::Bindings::JSObject::removeMember): (KJS::Bindings::JSObject::getSlot): (KJS::Bindings::JSObject::setSlot): (KJS::Bindings::JSObject::toString): (KJS::Bindings::JSObject::finalize): (KJS::Bindings::JSObject::createNative): (KJS::Bindings::JSObject::convertValueToJObject): (KJS::Bindings::JSObject::convertJObjectToValue): (KJS::Bindings::JSObject::listFromJArray):
bindings/jni_jsobject.h:
bindings/runtime.cpp:
bindings/runtime.h:
bindings/runtime_method.cpp:
bindings/runtime_method.h:

5:41 PM Changeset in webkit [5827] by rjw

2 edits in trunk/WebKit

Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as we do for spaces, to ensure that 'words' (as defined by out rounding hack) start on integer boundaries.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):

4:44 PM Changeset in webkit [5826] by cblu

3 edits in trunk/WebKit

Fixed:
<rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
<rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): set suspendKeyUpEvents to NO (-[WebBaseNetscapePluginView keyMessageForEvent:]): copied from CVS (-[WebBaseNetscapePluginView keyUp:]): if !suspendKeyUpEvents, send the keyUp event (-[WebBaseNetscapePluginView keyDown:]): set suspendKeyUpEvents to YES (-[WebBaseNetscapePluginView windowBecameKey:]): call SetUserFocusWindow

4:38 PM Changeset in webkit [5825] by darin

3 edits in trunk/WebKit

Reviewed by Richard.

fixed 3513274: REGRESSION: anchor navigation within frames with "Back" is broken at tivofaq.com

WebView.subproj/WebDataSource.m: (-[WebDataSource _setURL:]): Since this method is only used when you do a fragment scroll, we need to update the original request as well as the request. This ensure that the fragment gets recorded in the history item (which goes in the back/forward history).

4:21 PM Changeset in webkit [5824] by kocienda

7 edits
7 adds
2 deletes in branches

Reviewed by me.

Made editing subdirectory.
Moved htmlediting files into this new directory.
Added Caret and CaretImpl classes.

WebCore.pbproj/project.pbxproj:
khtml/editing/edit_caret.cpp: Added. (Caret::Caret): (Caret::~Caret): (Caret::node): (Caret::offset): (Caret::startOfLine): (Caret::setPosition): (Caret::setStartOfLine): (Caret::needsAdjustmentForEditing): (Caret::adjustForEditing): (Caret::adjustedForEditing): (Caret::handle): (operator==):
khtml/editing/edit_caret.h: Added.
khtml/editing/edit_caretimpl.cpp: Added. (CaretImpl::CaretImpl): (CaretImpl::~CaretImpl): (CaretImpl::setPosition): (CaretImpl::setStartOfLine): (CaretImpl::needsAdjustmentForEditing): (CaretImpl::adjustForEditing): (EditNodeFilter::acceptNode):
khtml/editing/edit_caretimpl.h: Added. (khtml::CaretImpl::node): (khtml::CaretImpl::offset): (khtml::CaretImpl::startOfLine): (khtml::CaretImpl::CaretImpl):
khtml/editing/htmlediting.cpp: Added. (EditCommand::notifyChanged): (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
khtml/editing/htmlediting.h: Added. (khtml::): (khtml::EditCommand::EditCommand): (khtml::EditCommand::~EditCommand): (khtml::EditCommand::selection): (khtml::InputTextCommand::~InputTextCommand): (khtml::InputTextCommand::text): (khtml::DeleteTextCommand::~DeleteTextCommand):
khtml/html/htmlediting.cpp: Removed.
khtml/html/htmlediting.h: Removed.
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::caret): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
khtml/khtmlview.cpp: (khtml::sanitizeCaretState): (KHTMLView::init): (KHTMLView::initCaret): (KHTMLView::moveCaretTo):
kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged):

4:21 PM Changeset in webkit [5823] by kocienda

in /

file edit_caret.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5822] by kocienda

in /

file htmlediting.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5821] by kocienda

in /

file edit_caretimpl.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5820] by kocienda

in /

file htmlediting.cpp was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5819] by kocienda

in /

file edit_caretimpl.cpp was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5818] by kocienda

in /

file edit_caret.cpp was initially added on branch HTML-editing-hacks-branch.

3:48 PM Changeset in webkit [5817] by darin

9 edits in trunk/WebCore

Reviewed by Dave.

fixed 3469085: can't tab to all links on aintitcool.com

khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): Re-implemented this to check width and height of all continuations, not just the main render object. Also, check the absoluteRects after checking all the render objects to catch things like floats. (HTMLAnchorElementImpl::isMouseFocusable): Clean up the code here a bit.

khtml/rendering/render_inline.h:
khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
khtml/rendering/render_object.h:
khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
khtml/rendering/render_text.h:
khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
kwq/KWQAccObject.mm: (boundingBoxRect): Use QValueList instead of QPtrList for clarity and to fix storage leaks.

10:45 AM Changeset in webkit [5816] by vicki

3 edits in trunk

The tree is open for Safari-119!

10:25 AM Changeset in webkit [5815]

3 copies in tags/Safari-118

This commit was manufactured by cvs2svn to create tag 'Safari-118'.

10:25 AM Changeset in webkit [5814] by vicki

6 edits in trunk

Safari-118 stamp

9:36 AM Changeset in webkit [5813] by sullivan

2 edits in trunk/WebKit

fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116): Mike Hay's Magic 8-ball game ignores slow clicks

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]): start the autoscroll timer here, so the timer only runs when KHTML is handling the event. (-[WebHTMLView mouseDown:]): don't start the autoscroll timer here.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed