⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 17, 2004:

2:19 PM Changeset in webkit [6237] by hyatt
  • 3 edits in trunk/WebKit

Expose ageLimitDate so that the autocomplete code can access it.

Reviewed by john

  • History.subproj/WebHistory.m: (-[WebHistory ageLimitDate]):
  • History.subproj/WebHistoryPrivate.h:
1:33 PM Changeset in webkit [6236] by rjw
  • 3 edits in trunk/JavaScriptCore

Added a context parameter (supplied by client) to result callbacks use by JavaScriptObject functions. This was a change requested by Eric Carlson on the QT plugin team.

Reviewed by Ken.

  • bindings/NP_jsobject.cpp: (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_ToString): (NP_GetPropertyAtIndex):
  • bindings/NP_runtime.h:
1:06 PM Changeset in webkit [6235] by rjw
  • 2 edits in trunk/WebKit

Fixed 3591667. Plugin view is added to view hierarchy before calling init.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]):
12:01 PM Changeset in webkit [6234] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by John.

  • fixed rdar://problem/3312803>: extra space in copied text (3g.co.uk)
  • khtml/khtml_part.cpp: (KHTMLPart::text): Explicitly set neededSpace to false after processing a line break. Doesn't really have an effect here, but matches the change to the styled text version.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Same change in the styled text version.
11:47 AM Changeset in webkit [6233] by darin
  • 3 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed rdar://problem/3312803>: extra space in copied text (3g.co.uk)
  • khtml/khtml_part.cpp: (KHTMLPart::text): Explicitly set neededSpace to false after processing a line break. Doesn't really have an effect here, but matches the change to the styled text version.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Same change in the styled text version.

Mar 16, 2004:

11:55 AM Changeset in webkit [6232] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Ken.

  • a little more DOM cleanup
  • kwq/DOM-CSS.mm: Added DOMCSSUnknownRule.
  • kwq/DOM.mm: Split category implementations out to match category interfaces.
  • kwq/DOMHTML.h: Removed lowSrc, not in DOM Level 2. Added a category for some extensions we'll want on DOMElement.
  • kwq/DOMInternal.h: Moved _documentImpl method here so it can be used from separate categories.
  • kwq/DOMRange.h: Changed DOMDocumentRange to a category from a protocol.
  • kwq/HTMLDOM.mm: Removed unneeded methods.
  • WebCore.pbproj/project.pbxproj: Sort DOM header files alphabetically.

WebKit:

  • DOM.subproj/DOMHTML.h: Updated from WebCore.
  • DOM.subproj/DOMRange.h: Ditto.
11:40 AM Changeset in webkit [6231] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3590169. Regression (crash) caused by the switch to MethodLists. Crash when attempting to invoke a method from JavaScript to Java that is not implemented.

Reviewed by John.

  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
10:35 AM Changeset in webkit [6230] by darin
  • 13 edits
    16 adds
    2 deletes in trunk

WebCore:

Reviewed by Ken.

  • update for new DOM namespacing and header organization
  • WebCore.pbproj/project.pbxproj:
  • kwq/DOM-CSS.h: Removed.
  • kwq/DOM-CSS.mm: Update for name changes.
  • kwq/DOM.h: Changed to include the other DOM headers.
  • kwq/DOM.mm: Update for name changes.
  • kwq/DOMCSS.h: Added.
  • kwq/DOMCore.h: Added.
  • kwq/DOMEvents.h: Added.
  • kwq/DOMHTML.h: Added.
  • kwq/DOMInternal.h: Update for name changes.
  • kwq/DOMRange.h: Added.
  • kwq/DOMStylesheets.h: Added.
  • kwq/DOMTraversal.h: Added.
  • kwq/DOMViews.h: Added.
  • kwq/HTMLDOM.h: Removed.
  • kwq/HTMLDOM.mm: Update for name changes; add some missing setters.

WebKit:

Reviewed by Ken.

  • update for new DOM namespacing and header organization
  • DOM.subproj/DOM.h: Changed to include the other DOM headers.
  • DOM.subproj/DOMCSS.h: Added.
  • DOM.subproj/DOMCore.h: Added.
  • DOM.subproj/DOMEvents.h: Added.
  • DOM.subproj/DOMHTML.h: Added.
  • DOM.subproj/DOMRange.h: Added.
  • DOM.subproj/DOMStylesheets.h: Added.
  • DOM.subproj/DOMTraversal.h: Added.
  • DOM.subproj/DOMViews.h: Added.
  • WebKit.pbproj/project.pbxproj: Added new files.
  • WebView.subproj/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[WebDefaultEditingDelegate webView:shouldChangeTypingStyle:toStyle:]): Change class names from CSS to DOMCSS.
  • WebView.subproj/WebViewPrivate.h: Ditto.
  • copy-webcore-files-to-webkit: Add new files.

Mar 15, 2004:

9:08 PM Changeset in webkit [6229] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • max out our iBench cheat. Don't even paint or lay out a quarter of the pages.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
2:10 PM Changeset in webkit [6228] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3570854. Don't attempt to convert Null to strings. We
were incorrectly converting to "Null".

Actually fixed by Scott Kovatch.

Reviewed by Richard.

  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
2:09 PM Changeset in webkit [6227] by kocienda
  • 7 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3588717>: REGRESSION (125-131u): Tabbing to links and tabbing in bookmarks view no longer works

Change some support methods which feed editing key events to
WebKit. The real fix is on the WebKit side.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::editingKeyEvent): Call new -editingKeyDown: on WebCoreBridge, as described below.
  • kwq/WebCoreBridge.h: Changed -keyDown: to -editingKeyDown: since we want to tell WebView about editing key events in a way that does not interfere with other key down events the WebView processes. This is not necessary in the strictest sense, but it seems reasonable to keep the terminology clear.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3588717>: REGRESSION (125-131u): Tabbing to links and tabbing in bookmarks view no longer works

WebView can't lay claim to -keyDown: just for editing events, as
this gets in the way of tab processing. The solution is to give
WebView a private method for processing editing key events fed to
it from over the bridge, and leave -keyDown: unimplemented.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge editingKeyDown:]): Changed from -keyDown: to keep terminology consistent with renamed WebView -editingKeyDown: method.
  • WebView.subproj/WebView.m: (-[WebView editingKeyDown:]): Give WebView a method to handle editing key events in a way that does not interfere with other key down events it processes.
  • WebView.subproj/WebViewPrivate.h: Declare -editingKeyDown: method.
2:04 PM Changeset in webkit [6226] by vicki
  • 3 edits in trunk

change version number from '132' to '133u'. the tree is open for business.

2:00 PM Changeset in webkit [6225]
  • 3 copies in tags/Safari-132

This commit was manufactured by cvs2svn to create tag 'Safari-132'.

2:00 PM Changeset in webkit [6224] by vicki
  • 6 edits in trunk

Safari-132 stamp

10:37 AM Changeset in webkit [6223] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

Mar 12, 2004:

5:04 PM Changeset in webkit [6222] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3433887>: copied &nbsp; characters remain non-breaking spaces; other browsers give normal spaces
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): Convert non-breaking spaces to the normal kind in the plain text part of the pasteboard.
1:59 PM Changeset in webkit [6221] by cblu
  • 5 edits in trunk/WebCore

Implemented ~25% of the HTML DOM API.

Reviewed by kocienda.

(DOM::HTMLElement::HTMLElement):

  • kwq/DOM.mm:
  • kwq/DOMInternal.h:
  • kwq/HTMLDOM.h:
  • kwq/HTMLDOM.mm: (-[HTMLCollection _initWithCollectionImpl:]): (+[HTMLCollection _collectionWithImpl:]): (-[HTMLCollection _collectionImpl]): (-[HTMLCollection length]): (-[HTMLCollection item:]): (-[HTMLCollection namedItem:]): (-[HTMLElement _initWithElementImpl:]): (+[HTMLElement _elementWithImpl:]): (-[HTMLElement _HTMLElementImpl]): (-[HTMLElement idName]): (-[HTMLElement setIdName:]): (-[HTMLElement title]): (-[HTMLElement setTitle:]): (-[HTMLElement lang]): (-[HTMLElement setLang:]): (-[HTMLElement dir]): (-[HTMLElement setDir:]): (-[HTMLElement className]): (-[HTMLElement setClassName:]): (-[HTMLDocument _HTMLDocumentImpl]): (-[HTMLDocument title]): (-[HTMLDocument setTitle:]): (-[HTMLDocument referrer]): (-[HTMLDocument domain]): (-[HTMLDocument URL]): (-[HTMLDocument body]): (-[HTMLDocument images]): (-[HTMLDocument applets]): (-[HTMLDocument links]): (-[HTMLDocument forms]): (-[HTMLDocument anchors]): (-[HTMLDocument setBody:]): (-[HTMLDocument cookie]): (-[HTMLDocument setCookie:]): (-[HTMLDocument open]): (-[HTMLDocument close]): (-[HTMLDocument write:]): (-[HTMLDocument writeln:]): (-[HTMLDocument getElementById:]): (-[HTMLDocument getElementsByName:]): (-[HTMLHtmlElement _HTMLHtmlElementImpl]): (-[HTMLHtmlElement version]): (-[HTMLHtmlElement setVersion:]): (-[HTMLHeadElement _headElementImpl]): (-[HTMLHeadElement profile]): (-[HTMLHeadElement setProfile:]): (-[HTMLLinkElement _linkElementImpl]): (-[HTMLLinkElement disabled]): (-[HTMLLinkElement setDisabled:]): (-[HTMLLinkElement charset]): (-[HTMLLinkElement setCharset:]): (-[HTMLLinkElement href]): (-[HTMLLinkElement setHref:]): (-[HTMLLinkElement hreflang]): (-[HTMLLinkElement setHreflang:]): (-[HTMLLinkElement media]): (-[HTMLLinkElement setMedia:]): (-[HTMLLinkElement rel]): (-[HTMLLinkElement setRel:]): (-[HTMLLinkElement rev]): (-[HTMLLinkElement setRev:]): (-[HTMLLinkElement target]): (-[HTMLLinkElement setTarget:]): (-[HTMLLinkElement type]): (-[HTMLLinkElement setType:]): (-[HTMLTitleElement _titleElementImpl]): (-[HTMLTitleElement text]): (-[HTMLTitleElement setText:]): (-[HTMLMetaElement _metaElementImpl]): (-[HTMLMetaElement content]): (-[HTMLMetaElement setContent:]): (-[HTMLMetaElement httpEquiv]): (-[HTMLMetaElement setHttpEquiv:]): (-[HTMLMetaElement name]): (-[HTMLMetaElement setName:]): (-[HTMLMetaElement scheme]): (-[HTMLMetaElement setScheme:]): (-[HTMLBaseElement _baseElementImpl]): (-[HTMLBaseElement href]): (-[HTMLBaseElement setHref:]): (-[HTMLBaseElement target]): (-[HTMLBaseElement setTarget:]): (-[HTMLStyleElement _styleElementImpl]): (-[HTMLStyleElement disabled]): (-[HTMLStyleElement setDisabled:]): (-[HTMLStyleElement media]): (-[HTMLStyleElement setMedia:]): (-[HTMLStyleElement type]): (-[HTMLStyleElement setType:]): (-[HTMLBodyElement _bodyElementImpl]): (-[HTMLBodyElement aLink]): (-[HTMLBodyElement setALink:]): (-[HTMLBodyElement background]): (-[HTMLBodyElement setBackground:]): (-[HTMLBodyElement bgColor]): (-[HTMLBodyElement setBgColor:]): (-[HTMLBodyElement link]): (-[HTMLBodyElement setLink:]): (-[HTMLBodyElement text]): (-[HTMLBodyElement setText:]): (-[HTMLBodyElement vLink]): (-[HTMLBodyElement setVLink:]):
1:21 PM Changeset in webkit [6220] by hyatt
  • 2 edits in trunk/WebCore

Fix for problem when undoing the deletion of a word in edit mode.

Reviewed by kocienda

  • khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
11:27 AM Changeset in webkit [6219] by kocienda
  • 14 edits in trunk

WebCore:

Reviewed by Chris

  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): Clear the selection's "modify bias" since the user clicked, and is therefore no longer extending the selection with arrow keys.
  • khtml/khtml_selection.cpp: (KHTMLSelection::KHTMLSelection): Add new m_modifyBiasSet flag. (KHTMLSelection::init): Set the flag to false by default. (KHTMLSelection::operator=): Copy over the value of the new m_modifyBiasSet flag. (KHTMLSelection::modify): Set the flag if extending the selection and set the base and extent nodes based on the movement direction requested.
  • khtml/khtml_selection.h:
  • kwq/WebCoreBridge.h: See below.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): This method is used by the WebKit side in response to requests to change the selection using the arrow keys. It used to be called rangeByModifyingRange:alteration:direction:granularity: but I changed it to this new format since I explicitly want to use the current selection, and not some arbitrarily passed in selection. This helps to maintain the "modify bias" correctly. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): New method. A command to alter the current selection as given. Again, applying the command to the current selection, rather than just setting the selection to a new one, helps to maintain the "modify bias" correctly.

WebKit:

Reviewed by Chris

  • WebView.subproj/WebView.m: (-[WebView _alterCurrentSelection:direction:granularity:]): Changed name from _alterSelection:direction:granularity: to give a little extra clarity. Also, the body calls through to renamed rangeByAlteringCurrentSelection:direction:granularity: in WebCore. (-[WebView moveRight:]): Now calls renamed _alterCurrentSelection:direction:granularity:. (-[WebView moveRightAndModifySelection:]): Ditto. (-[WebView moveLeft:]): Ditto. (-[WebView moveLeftAndModifySelection:]): Ditto.
11:20 AM Changeset in webkit [6218] by sullivan
  • 1 edit in trunk/WebKit/DOM.subproj/DOM.h
  • fixed the following bugs: <rdar://problem/3584028>: Consider disallowing "View Source" for inline error pages <rdar://problem/3584029>: "View Source" for inline error pages shows URL of "about:blank" <rdar://problem/3584272>: Location field should be focused after a page-load error page is displayed <rdar://problem/3586611>: REGRESSION (128): After option-pressing b/f button, selecting a menu item downloads it
  • simplified some code

Reviewed by Chris.

  • BrowserDocument.h:
  • BrowserDocument.m: removed goBack: and goForward:; all callers now use these methods on BrowserWindowController instead. (-[BrowserDocument goToItemInBackOrForwardMenu:]): renamed from goToItem: for clarity, now ignores the Option key to avoid downloading when the user pressed Option to see URLs in the menu (-[BrowserDocument _addItem:toMenu:]): updated for name change (-[BrowserDocument canViewSource]): new method, extracted from validateUserInterfaceItem. Now also returns NO if the current page is an error page. (-[BrowserDocument validateUserInterfaceItem:]): now calls extracted method (-[BrowserDocument viewSource:]): now bails out early if canViewSource returns NO
  • BrowserWindowController.m: (-[BrowserWindowController webFrameLoadCommitted:]): if we're showing an error page now, move focus to location field (rather than webview as in the normal case)
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goBack]): call through browserWindowController; this was the only remaining caller of -[BrowserDocument goBack:] or -[BrowserDocument goForward:]

Mar 11, 2004:

6:26 PM Changeset in webkit [6217]
  • 15 copies
    2 deletes in tags/WebCore-125~5

This commit was manufactured by cvs2svn to create tag
'WebCore-125~5'.

6:26 PM Changeset in webkit [6216] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.5

5:58 PM Changeset in webkit [6215] by rjw
  • 3 edits in trunk/WebKit

Workaround for 3585644. Force the window number of the
mouse moved event to be correct.

Reviewed by Chris.

  • Carbon.subproj/CarbonWindowFrame.m:
  • Carbon.subproj/HIWebView.m: (MouseMoved): (MouseDragged):
5:56 PM Changeset in webkit [6214] by cblu
  • 2 edits
    2 adds in trunk/WebCore

Added stubs for the HTML DOM API.

Reviewed by rjw.

  • WebCore.pbproj/project.pbxproj:
  • kwq/HTMLDOM.h: Added.
  • kwq/HTMLDOM.mm: Added. (-[HTMLCollection length]): (-[HTMLCollection item:]): (-[HTMLCollection namedItem:]): (-[HTMLElement idName]): (-[HTMLElement setIdName:]): (-[HTMLElement title]): (-[HTMLElement setTitle:]): (-[HTMLElement lang]): (-[HTMLElement setLang:]): (-[HTMLElement dir]): (-[HTMLElement setDir:]): (-[HTMLElement className]): (-[HTMLElement setClassName:]): (-[HTMLDocument title]): (-[HTMLDocument setTitle:]): (-[HTMLDocument referrer]): (-[HTMLDocument domain]): (-[HTMLDocument URL]): (-[HTMLDocument body]): (-[HTMLDocument images]): (-[HTMLDocument applets]): (-[HTMLDocument links]): (-[HTMLDocument forms]): (-[HTMLDocument anchors]): (-[HTMLDocument setBody:]): (-[HTMLDocument cookie]): (-[HTMLDocument setCookie:]): (-[HTMLDocument open]): (-[HTMLDocument close]): (-[HTMLDocument write:]): (-[HTMLDocument writeln:]): (-[HTMLDocument getElementById:]): (-[HTMLDocument getElementsByName:]): (-[HTMLHtmlElement version]): (-[HTMLHtmlElement setVersion:]): (-[HTMLHeadElement profile]): (-[HTMLHeadElement setProfile:]): (-[HTMLLinkElement disabled]): (-[HTMLLinkElement setDisabled:]): (-[HTMLLinkElement charset]): (-[HTMLLinkElement setCharset:]): (-[HTMLLinkElement href]): (-[HTMLLinkElement setHref:]): (-[HTMLLinkElement hreflang]): (-[HTMLLinkElement setHreflang:]): (-[HTMLLinkElement media]): (-[HTMLLinkElement setMedia:]): (-[HTMLLinkElement rel]): (-[HTMLLinkElement setRrevel:]): (-[HTMLLinkElement rev]): (-[HTMLLinkElement setRev:]): (-[HTMLLinkElement target]): (-[HTMLLinkElement setTarget:]): (-[HTMLLinkElement type]): (-[HTMLLinkElement setType:]): (-[HTMLTitleElement text]): (-[HTMLTitleElement setText:]): (-[HTMLMetaElement content]): (-[HTMLMetaElement setContent:]): (-[HTMLMetaElement httpEquiv]): (-[HTMLMetaElement setHttpEquiv:]): (-[HTMLMetaElement name]): (-[HTMLMetaElement setName:]): (-[HTMLMetaElement scheme]): (-[HTMLMetaElement setScheme:]): (-[HTMLBaseElement href]): (-[HTMLBaseElement setHref:]): (-[HTMLBaseElement target]): (-[HTMLBaseElement setTarget:]): (-[HTMLStyleElement disabled]): (-[HTMLStyleElement setDisabled:]): (-[HTMLStyleElement media]): (-[HTMLStyleElement setMedia:]): (-[HTMLStyleElement type]): (-[HTMLStyleElement setType:]): (-[HTMLBodyElement aLink]): (-[HTMLBodyElement setALink:]): (-[HTMLBodyElement background]): (-[HTMLBodyElement setBackground:]): (-[HTMLBodyElement bgColor]): (-[HTMLBodyElement setBgColor:]): (-[HTMLBodyElement link]): (-[HTMLBodyElement setLink:]): (-[HTMLBodyElement text]): (-[HTMLBodyElement setText:]): (-[HTMLBodyElement vLink]): (-[HTMLBodyElement setVLink:]): (-[HTMLFormElement elements]): (-[HTMLFormElement length]): (-[HTMLFormElement name]): (-[HTMLFormElement setName:]): (-[HTMLFormElement acceptCharset]): (-[HTMLFormElement setAcceptCharset:]): (-[HTMLFormElement action]): (-[HTMLFormElement setAction:]): (-[HTMLFormElement enctype]): (-[HTMLFormElement setEnctype:]): (-[HTMLFormElement method]): (-[HTMLFormElement setMethod:]): (-[HTMLFormElement target]): (-[HTMLFormElement setTarget:]): (-[HTMLFormElement submit]): (-[HTMLFormElement reset]): (-[HTMLIsIndexElement form]): (-[HTMLIsIndexElement prompt]): (-[HTMLIsIndexElement setPrompt:]): (-[HTMLSelectElement type]): (-[HTMLSelectElement selectedIndex]): (-[HTMLSelectElement setSelectedIndex:]): (-[HTMLSelectElement value]): (-[HTMLSelectElement setValue:]): (-[HTMLSelectElement length]): (-[HTMLSelectElement form]): (-[HTMLSelectElement options]): (-[HTMLSelectElement disabled]): (-[HTMLSelectElement multiple]): (-[HTMLSelectElement name]): (-[HTMLSelectElement setName:]): (-[HTMLSelectElement size]): (-[HTMLSelectElement tabIndex]): (-[HTMLSelectElement add::]): (-[HTMLSelectElement remove:]): (-[HTMLSelectElement blur]): (-[HTMLSelectElement focus]): (-[HTMLOptGroupElement disabled]): (-[HTMLOptGroupElement setDisabled:]): (-[HTMLOptGroupElement label]): (-[HTMLOptGroupElement setLabel:]): (-[HTMLOptionElement form]): (-[HTMLOptionElement defaultSelected]): (-[HTMLOptionElement setDefaultSelected:]): (-[HTMLOptionElement text]): (-[HTMLOptionElement index]): (-[HTMLOptionElement setIndex:]): (-[HTMLOptionElement disabled]): (-[HTMLOptionElement setDisabled:]): (-[HTMLOptionElement label]): (-[HTMLOptionElement setLabel:]): (-[HTMLOptionElement selected]): (-[HTMLOptionElement value]): (-[HTMLOptionElement setValue:]): (-[HTMLInputElement defaultValue]): (-[HTMLInputElement setDefaultValue:]): (-[HTMLInputElement defaultChecked]): (-[HTMLInputElement setDefaultChecked:]): (-[HTMLInputElement form]): (-[HTMLInputElement accept]): (-[HTMLInputElement setAccept:]): (-[HTMLInputElement accessKey]): (-[HTMLInputElement setAccessKey:]): (-[HTMLInputElement align]): (-[HTMLInputElement setAlign:]): (-[HTMLInputElement alt]): (-[HTMLInputElement setAlt:]): (-[HTMLInputElement checked]): (-[HTMLInputElement setChecked:]): (-[HTMLInputElement disabled]): (-[HTMLInputElement setDisabled:]): (-[HTMLInputElement maxLength]): (-[HTMLInputElement setMaxLength:]): (-[HTMLInputElement name]): (-[HTMLInputElement setName:]): (-[HTMLInputElement readOnly]): (-[HTMLInputElement setReadOnly:]): (-[HTMLInputElement size]): (-[HTMLInputElement setSize:]): (-[HTMLInputElement src]): (-[HTMLInputElement setSrc:]): (-[HTMLInputElement tabIndex]): (-[HTMLInputElement setTabIndex:]): (-[HTMLInputElement type]): (-[HTMLInputElement useMap]): (-[HTMLInputElement setUseMap:]): (-[HTMLInputElement value]): (-[HTMLInputElement setValue:]): (-[HTMLInputElement blur]): (-[HTMLInputElement focus]): (-[HTMLInputElement select]): (-[HTMLInputElement click]): (-[HTMLTextAreaElement defaultValue]): (-[HTMLTextAreaElement setDefaultValue:]): (-[HTMLTextAreaElement form]): (-[HTMLTextAreaElement accessKey]): (-[HTMLTextAreaElement setAccessKey:]): (-[HTMLTextAreaElement cols]): (-[HTMLTextAreaElement setCols:]): (-[HTMLTextAreaElement disabled]): (-[HTMLTextAreaElement setDisabled:]): (-[HTMLTextAreaElement name]): (-[HTMLTextAreaElement setName:]): (-[HTMLTextAreaElement readOnly]): (-[HTMLTextAreaElement setReadOnly:]): (-[HTMLTextAreaElement rows]): (-[HTMLTextAreaElement setRows:]): (-[HTMLTextAreaElement tabIndex]): (-[HTMLTextAreaElement setTabIndex:]): (-[HTMLTextAreaElement type]): (-[HTMLTextAreaElement value]): (-[HTMLTextAreaElement setValue:]): (-[HTMLTextAreaElement blur]): (-[HTMLTextAreaElement focus]): (-[HTMLTextAreaElement select]): (-[HTMLButtonElement form]): (-[HTMLButtonElement accessKey]): (-[HTMLButtonElement setAccessKey:]): (-[HTMLButtonElement disabled]): (-[HTMLButtonElement setDisabled:]): (-[HTMLButtonElement name]): (-[HTMLButtonElement setName:]): (-[HTMLButtonElement tabIndex]): (-[HTMLButtonElement setTabIndex:]): (-[HTMLButtonElement type]): (-[HTMLButtonElement value]): (-[HTMLButtonElement setValue:]): (-[HTMLLabelElement form]): (-[HTMLLabelElement accessKey]): (-[HTMLLabelElement setAccessKey:]): (-[HTMLLabelElement htmlFor]): (-[HTMLLabelElement setHtmlFor:]): (-[HTMLFieldSetElement form]): (-[HTMLLegendElement form]): (-[HTMLLegendElement accessKey]): (-[HTMLLegendElement setAccessKey:]): (-[HTMLLegendElement align]): (-[HTMLLegendElement setAlign:]): (-[HTMLUListElement compact]): (-[HTMLUListElement setCompact:]): (-[HTMLUListElement type]): (-[HTMLUListElement setType:]): (-[HTMLOListElement compact]): (-[HTMLOListElement setCompact:]): (-[HTMLOListElement start]): (-[HTMLOListElement setStart:]): (-[HTMLOListElement type]): (-[HTMLOListElement setType:]): (-[HTMLDListElement compact]): (-[HTMLDListElement setCompact:]): (-[HTMLDirectoryElement compact]): (-[HTMLDirectoryElement setCompact:]): (-[HTMLMenuElement compact]): (-[HTMLMenuElement setCompact:]): (-[HTMLLIElement type]): (-[HTMLLIElement setType:]): (-[HTMLLIElement value]): (-[HTMLLIElement setValue:]): (-[HTMLBlockquoteElement cite]): (-[HTMLBlockquoteElement setCite:]): (-[HTMLDivElement align]): (-[HTMLDivElement setAlign:]): (-[HTMLParagraphElement align]): (-[HTMLParagraphElement setAlign:]): (-[HTMLHeadingElement align]): (-[HTMLHeadingElement setAlign:]): (-[HTMLQuoteElement cite]): (-[HTMLQuoteElement setCite:]): (-[HTMLPreElement width]): (-[HTMLPreElement setWidth:]): (-[HTMLBRElement clear]): (-[HTMLBRElement setClear:]): (-[HTMLBaseFontElement color]): (-[HTMLBaseFontElement setColor:]): (-[HTMLBaseFontElement face]): (-[HTMLBaseFontElement setFace:]): (-[HTMLBaseFontElement size]): (-[HTMLBaseFontElement setSize:]): (-[HTMLFontElement color]): (-[HTMLFontElement setColor:]): (-[HTMLFontElement face]): (-[HTMLFontElement setFace:]): (-[HTMLFontElement size]): (-[HTMLFontElement setSize:]): (-[HTMLHRElement align]): (-[HTMLHRElement setAlign:]): (-[HTMLHRElement noShade]): (-[HTMLHRElement setNoShade:]): (-[HTMLHRElement size]): (-[HTMLHRElement setSize:]): (-[HTMLHRElement width]): (-[HTMLHRElement setWidth:]): (-[HTMLModElement cite]): (-[HTMLModElement setCite:]): (-[HTMLModElement dateTime]): (-[HTMLModElement setDateTime:]): (-[HTMLAnchorElement accessKey]): (-[HTMLAnchorElement setAccessKey:]): (-[HTMLAnchorElement charset]): (-[HTMLAnchorElement setCharset:]): (-[HTMLAnchorElement coords]): (-[HTMLAnchorElement setCoords:]): (-[HTMLAnchorElement href]): (-[HTMLAnchorElement setHref:]): (-[HTMLAnchorElement hreflang]): (-[HTMLAnchorElement setHreflang:]): (-[HTMLAnchorElement name]): (-[HTMLAnchorElement setName:]): (-[HTMLAnchorElement rel]): (-[HTMLAnchorElement setRel:]): (-[HTMLAnchorElement rev]): (-[HTMLAnchorElement setRev:]): (-[HTMLAnchorElement shape]): (-[HTMLAnchorElement setShape:]): (-[HTMLAnchorElement tabIndex]): (-[HTMLAnchorElement setTabIndex:]): (-[HTMLAnchorElement target]): (-[HTMLAnchorElement setTarget:]): (-[HTMLAnchorElement type]): (-[HTMLAnchorElement setType:]): (-[HTMLAnchorElement blur]): (-[HTMLAnchorElement focus]): (-[HTMLImageElement lowSrc]): (-[HTMLImageElement setLowSrc:]): (-[HTMLImageElement name]): (-[HTMLImageElement setName:]): (-[HTMLImageElement align]): (-[HTMLImageElement setAlign:]): (-[HTMLImageElement alt]): (-[HTMLImageElement setAlt:]): (-[HTMLImageElement border]): (-[HTMLImageElement setBorder:]): (-[HTMLImageElement height]): (-[HTMLImageElement setHeight:]): (-[HTMLImageElement hspace]): (-[HTMLImageElement setHspace:]): (-[HTMLImageElement isMap]): (-[HTMLImageElement setIsMap:]): (-[HTMLImageElement longDesc]): (-[HTMLImageElement setLongDesc:]): (-[HTMLImageElement src]): (-[HTMLImageElement setSrc:]): (-[HTMLImageElement useMap]): (-[HTMLImageElement setUseMap:]): (-[HTMLImageElement vspace]): (-[HTMLImageElement setVspace:]): (-[HTMLImageElement width]): (-[HTMLImageElement setWidth:]): (-[HTMLObjectElement form]): (-[HTMLObjectElement code]): (-[HTMLObjectElement setCode:]): (-[HTMLObjectElement align]): (-[HTMLObjectElement setAlign:]): (-[HTMLObjectElement archive]): (-[HTMLObjectElement setArchive:]): (-[HTMLObjectElement border]): (-[HTMLObjectElement setBorder:]): (-[HTMLObjectElement codeBase]): (-[HTMLObjectElement setCodeBase:]): (-[HTMLObjectElement codeType]): (-[HTMLObjectElement setCodeType:]): (-[HTMLObjectElement data]): (-[HTMLObjectElement setData:]): (-[HTMLObjectElement declare]): (-[HTMLObjectElement setDeclare:]): (-[HTMLObjectElement height]): (-[HTMLObjectElement setHeight:]): (-[HTMLObjectElement hspace]): (-[HTMLObjectElement setHspace:]): (-[HTMLObjectElement name]): (-[HTMLObjectElement setName:]): (-[HTMLObjectElement standby]): (-[HTMLObjectElement setStandby:]): (-[HTMLObjectElement tabIndex]): (-[HTMLObjectElement setTabIndex:]): (-[HTMLObjectElement type]): (-[HTMLObjectElement setType:]): (-[HTMLObjectElement useMap]): (-[HTMLObjectElement setUseMap:]): (-[HTMLObjectElement vspace]): (-[HTMLObjectElement setVspace:]): (-[HTMLObjectElement width]): (-[HTMLObjectElement setWidth:]): (-[HTMLParamElement name]): (-[HTMLParamElement setName:]): (-[HTMLParamElement type]): (-[HTMLParamElement setType:]): (-[HTMLParamElement value]): (-[HTMLParamElement setValue:]): (-[HTMLParamElement valueType]): (-[HTMLParamElement setValueType:]): (-[HTMLAppletElement align]): (-[HTMLAppletElement setAlign:]): (-[HTMLAppletElement alt]): (-[HTMLAppletElement setAlt:]): (-[HTMLAppletElement archive]): (-[HTMLAppletElement setArchive:]): (-[HTMLAppletElement code]): (-[HTMLAppletElement setCode:]): (-[HTMLAppletElement codeBase]): (-[HTMLAppletElement setCodeBase:]): (-[HTMLAppletElement codeType]): (-[HTMLAppletElement setCodeType:]): (-[HTMLAppletElement height]): (-[HTMLAppletElement setHeight:]): (-[HTMLAppletElement hspace]): (-[HTMLAppletElement setHspace:]): (-[HTMLAppletElement name]): (-[HTMLAppletElement setName:]): (-[HTMLAppletElement object]): (-[HTMLAppletElement setObject:]): (-[HTMLAppletElement vspace]): (-[HTMLAppletElement setVspace:]): (-[HTMLAppletElement width]): (-[HTMLAppletElement setWidth:]): (-[HTMLMapElement areas]): (-[HTMLMapElement name]): (-[HTMLMapElement setName:]): (-[HTMLAreaElement accessKey]): (-[HTMLAreaElement setAccessKey:]): (-[HTMLAreaElement alt]): (-[HTMLAreaElement setAlt:]): (-[HTMLAreaElement coords]): (-[HTMLAreaElement setCoords:]): (-[HTMLAreaElement href]): (-[HTMLAreaElement setHref:]): (-[HTMLAreaElement noHref]): (-[HTMLAreaElement setNoHref:]): (-[HTMLAreaElement shape]): (-[HTMLAreaElement setShape:]): (-[HTMLAreaElement tabIndex]): (-[HTMLAreaElement setTabIndex:]): (-[HTMLAreaElement target]): (-[HTMLAreaElement setTarget:]): (-[HTMLScriptElement text]): (-[HTMLScriptElement setText:]): (-[HTMLScriptElement htmlFor]): (-[HTMLScriptElement setHtmlFor:]): (-[HTMLScriptElement event]): (-[HTMLScriptElement setEvent:]): (-[HTMLScriptElement charset]): (-[HTMLScriptElement setCharset:]): (-[HTMLScriptElement defer]): (-[HTMLScriptElement setDefer:]): (-[HTMLScriptElement src]): (-[HTMLScriptElement setSrc:]): (-[HTMLScriptElement type]): (-[HTMLScriptElement setType:]): (-[HTMLTableCaptionElement align]): (-[HTMLTableCaptionElement setAlign:]): (-[HTMLTableSectionElement align]): (-[HTMLTableSectionElement setAlign:]): (-[HTMLTableSectionElement ch]): (-[HTMLTableSectionElement setCh:]): (-[HTMLTableSectionElement chOff]): (-[HTMLTableSectionElement setChOff:]): (-[HTMLTableSectionElement vAlign]): (-[HTMLTableSectionElement setVAlign:]): (-[HTMLTableSectionElement rows]): (-[HTMLTableSectionElement insertRow:]): (-[HTMLTableSectionElement deleteRow:]): (-[HTMLTableElement caption]): (-[HTMLTableElement tHead]): (-[HTMLTableElement tFoot]): (-[HTMLTableElement rows]): (-[HTMLTableElement tBodies]): (-[HTMLTableElement align]): (-[HTMLTableElement setAlign:]): (-[HTMLTableElement bgColor]): (-[HTMLTableElement setBgColor:]): (-[HTMLTableElement border]): (-[HTMLTableElement setBorder:]): (-[HTMLTableElement cellPadding]): (-[HTMLTableElement setCellPadding:]): (-[HTMLTableElement cellSpacing]): (-[HTMLTableElement setCellSpacing:]): (-[HTMLTableElement frame]): (-[HTMLTableElement setFrame:]): (-[HTMLTableElement rules]): (-[HTMLTableElement setRules:]): (-[HTMLTableElement summary]): (-[HTMLTableElement setSummary:]): (-[HTMLTableElement width]): (-[HTMLTableElement setWidth:]): (-[HTMLTableElement createTHead]): (-[HTMLTableElement deleteTHead]): (-[HTMLTableElement createTFoot]): (-[HTMLTableElement deleteTFoot]): (-[HTMLTableElement createCaption]): (-[HTMLTableElement deleteCaption]): (-[HTMLTableElement deleteRow:]): (-[HTMLTableColElement align]): (-[HTMLTableColElement setAlign:]): (-[HTMLTableColElement ch]): (-[HTMLTableColElement setCh:]): (-[HTMLTableColElement chOff]): (-[HTMLTableColElement setChOff:]): (-[HTMLTableColElement span]): (-[HTMLTableColElement setSpan:]): (-[HTMLTableColElement vAlign]): (-[HTMLTableColElement setVAlign:]): (-[HTMLTableColElement width]): (-[HTMLTableColElement setWidth:]): (-[HTMLTableRowElement rowIndex]): (-[HTMLTableRowElement setRowIndex:]): (-[HTMLTableRowElement sectionRowIndex]): (-[HTMLTableRowElement setSectionRowIndex:]): (-[HTMLTableRowElement cells]): (-[HTMLTableRowElement setCells:]): (-[HTMLTableRowElement align]): (-[HTMLTableRowElement setAlign:]): (-[HTMLTableRowElement bgColor]): (-[HTMLTableRowElement setBgColor:]): (-[HTMLTableRowElement ch]): (-[HTMLTableRowElement setCh:]): (-[HTMLTableRowElement chOff]): (-[HTMLTableRowElement setChOff:]): (-[HTMLTableRowElement vAlign]): (-[HTMLTableRowElement setVAlign:]): (-[HTMLTableRowElement insertCell:]): (-[HTMLTableRowElement deleteCell:]): (-[HTMLTableCellElement cellIndex]): (-[HTMLTableCellElement setCellIndex:]): (-[HTMLTableCellElement abbr]): (-[HTMLTableCellElement setAbbr:]): (-[HTMLTableCellElement align]): (-[HTMLTableCellElement setAlign:]): (-[HTMLTableCellElement axis]): (-[HTMLTableCellElement setAxis:]): (-[HTMLTableCellElement bgColor]): (-[HTMLTableCellElement setBgColor:]): (-[HTMLTableCellElement ch]): (-[HTMLTableCellElement setCh:]): (-[HTMLTableCellElement chOff]): (-[HTMLTableCellElement setChOff:]): (-[HTMLTableCellElement colSpan]): (-[HTMLTableCellElement setColSpan:]): (-[HTMLTableCellElement headers]): (-[HTMLTableCellElement setHeaders:]): (-[HTMLTableCellElement height]): (-[HTMLTableCellElement setHeight:]): (-[HTMLTableCellElement noWrap]): (-[HTMLTableCellElement setNoWrap:]): (-[HTMLTableCellElement rowSpan]): (-[HTMLTableCellElement setRowSpan:]): (-[HTMLTableCellElement scope]): (-[HTMLTableCellElement setScope:]): (-[HTMLTableCellElement vAlign]): (-[HTMLTableCellElement setVAlign:]): (-[HTMLTableCellElement width]): (-[HTMLTableCellElement setWidth:]): (-[HTMLFrameSetElement cols]): (-[HTMLFrameSetElement setCols:]): (-[HTMLFrameSetElement rows]): (-[HTMLFrameSetElement setRows:]): (-[HTMLFrameElement frameBorder]): (-[HTMLFrameElement setFrameBorder:]): (-[HTMLFrameElement longDesc]): (-[HTMLFrameElement setLongDesc:]): (-[HTMLFrameElement marginHeight]): (-[HTMLFrameElement setMarginHeight:]): (-[HTMLFrameElement marginWidth]): (-[HTMLFrameElement setMarginWidth:]): (-[HTMLFrameElement name]): (-[HTMLFrameElement setName:]): (-[HTMLFrameElement noResize]): (-[HTMLFrameElement setNoResize:]): (-[HTMLFrameElement scrolling]): (-[HTMLFrameElement setScrolling:]): (-[HTMLFrameElement src]): (-[HTMLFrameElement setSrc:]): (-[HTMLIFrameElement align]): (-[HTMLIFrameElement setAlign:]): (-[HTMLIFrameElement frameBorder]): (-[HTMLIFrameElement setFrameBorder:]): (-[HTMLIFrameElement height]): (-[HTMLIFrameElement setHeight:]): (-[HTMLIFrameElement longDesc]): (-[HTMLIFrameElement setLongDesc:]): (-[HTMLIFrameElement marginHeight]): (-[HTMLIFrameElement setMarginHeight:]): (-[HTMLIFrameElement marginWidth]): (-[HTMLIFrameElement setMarginWidth:]): (-[HTMLIFrameElement name]): (-[HTMLIFrameElement setName:]): (-[HTMLIFrameElement scrolling]): (-[HTMLIFrameElement setScrolling:]): (-[HTMLIFrameElement src]): (-[HTMLIFrameElement setSrc:]): (-[HTMLIFrameElement width]): (-[HTMLIFrameElement setWidth:]):
4:47 PM Changeset in webkit [6213] by darin
  • 2 edits in branches/Safari-1-2-branch/WebCore/khtml/rendering

Merge yet another fix for Epiphany.

2004-03-10 David Hyatt <​hyatt@apple.com>

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:
4:23 PM Changeset in webkit [6212] by rjw
  • 9 edits
    10 adds in trunk/JavaScriptCore

Stitched together the NP stuff to our language independent
JavaScript binding stuff. Very close to being done.

Added program to test C bindings (and NP stuff). Just tests
properties. Will add methods and JavaScript access, etc.

Updated Makefile.am to account for new bindings/c directory.

Change NP_UTF8 from "const char *" to "char" to allow for
declarations like "const NP_UTF8 *" and "NP_UTF8 *". Ditto
for NP_UTF16.

Added NP_IsValidIdentifier().

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/NP_jsobject.cpp: (identiferFromNPIdentifier): (NP_Evaluate):
  • bindings/NP_runtime.cpp: (NP_IdentifierFromUTF8): (NP_IsValidIdentifier): (NP_GetIdentifiers): (NP_UTF8FromIdentifier): (NP_SetExceptionWithUTF8): (NP_SetException): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString):
  • bindings/NP_runtime.h:
  • bindings/c/c_class.cpp: Added. (CClass::_commonDelete): (CClass::_commonCopy): (CClass::_commonInit): (_createClassesByIsAIfNecessary): (CClass::classForIsA): (CClass::CClass): (CClass::name): (CClass::methodsNamed): (CClass::fieldNamed):
  • bindings/c/c_class.h: Added. (KJS::Bindings::CClass::~CClass): (KJS::Bindings::CClass::CClass): (KJS::Bindings::CClass::operator=): (KJS::Bindings::CClass::constructorAt): (KJS::Bindings::CClass::numConstructors):
  • bindings/c/c_instance.cpp: Added. (CInstance::CInstance): (CInstance::~CInstance): (CInstance::operator=): (CInstance::getClass): (CInstance::begin): (CInstance::end): (CInstance::invokeMethod): (CInstance::defaultValue): (CInstance::stringValue): (CInstance::numberValue): (CInstance::booleanValue): (CInstance::valueOf):
  • bindings/c/c_instance.h: Added. (KJS::Bindings::CInstance::getObject):
  • bindings/c/c_runtime.cpp: Added. (CField::valueFromInstance): (CField::setValueToInstance):
  • bindings/c/c_runtime.h: Added. (KJS::Bindings::CField::CField): (KJS::Bindings::CField::name): (KJS::Bindings::CField::type): (KJS::Bindings::CMethod::CMethod): (KJS::Bindings::CMethod::name): (KJS::Bindings::CMethod::numParameters):
  • bindings/c/c_utility.cpp: Added. (coerceValueToNPValueType): (convertValueToNPValueType): (convertNPValueTypeToValue):
  • bindings/c/c_utility.h: Added.
  • bindings/make_testbindings:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
  • bindings/runtime.h: (KJS::Bindings::Instance::):
  • bindings/testbindings.cpp: Added. (initializeIdentifiers): (myInterfaceHasProperty): (myInterfaceHasMethod): (myInterfaceGetProperty): (myInterfaceSetProperty): (myInterfaceInvoke): (myInterfaceAllocate): (myInterfaceInvalidate): (myInterfaceDeallocate): (GlobalImp::className): (readJavaScriptFromFile): (main):
4:07 PM Changeset in webkit [6211] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Dave

I have clarified the concept (at least in my head)
that each edit command has an obligation to put the
selection in the right place after it is applied,
unapplied, or reapplied. Right now, each edit command
calls setStartingSelection and setEndingSelection to do
this, I made these function move the selection on
setting.

  • khtml/editing/htmlediting_impl.cpp: (EditCommandImpl::setStartingSelection) (EditCommandImpl::setEndingSelection) (InputTextCommandImpl::coalesce) (InputTextCommandImpl::deleteCharacter) (InputTextCommandImpl::execute)
  • khtml/editing/htmlediting_impl.h:
3:37 PM Changeset in webkit [6210] by kocienda
  • 34 edits
    7 adds in trunk

WebCore:

Reviewed by Dave

Various changes to move us forward on editing.

  1. I reorganized the concrete EditCommand interface and implementation classes alphabetically in their respective files, to make it easier to find things.
  1. I added a TypingCommand composite class to gang up all keystrokes and make it possible to pass a single command over to the Cocoa undo system in all cases.
  1. I now send all keystrokes back over to WebKit to be interpreted by the text input system. In concert with the many new NSResponder method implementations I added to WebView, we now respond to keystrokes in a much more Cocoa-like way that sets us down the path to integrating with the Cocoa text input system some day.
  1. I fixed up our integration with the Cocoa undo system. I also removed much of the undo support code from the KHTMPart class. As a replacement, I implemented reporting of undoable commands to KHTMLPart so that a KDE hookup is quite feasible. As a result, undo should "just work" in Blot (Chris has reported that it has been busted).
  1. I added the DOM CSS bindings for Objective-C. This required some rearranging of the existing DOM bindings code, and while I was there, I did various cleanups in the existing DOM bindings.
  • About 400 lines of changed files and functions elided.

WebKit:

Reviewed by Dave

Various changes to begin implementing the draft API proposal.

  • DOM.subproj/DOM.h: Checking in generated file.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge registerCommandForUndo:]): Now takes an id, a wrapped WebCore EditCommand implementation object. (-[WebBridge registerCommandForRedo:]): Ditto. (-[WebBridge clearUndoRedoOperations]): Use the web view's undo manager. (-[WebBridge keyDown:]): Pass keyDown events through to the web view.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultEditingDelegate.h: Added.
  • WebView.subproj/WebDefaultEditingDelegate.m: Added. Stubbed in default implementations declared in the draft editing API.
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): WebFrame no longer has an undo manager.
  • WebView.subproj/WebFramePrivate.h: Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedWebArchive:]): selectedRange method is now selectedDOMRange.
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Dealloc new editingDelegateForwarder. (-[WebView _editingDelegateForwarder]): Added. (-[WebView keyDown:]): Added. (-[WebView _bridgeForCurrentSelection]): Added. (-[WebView setSelectedDOMRange:]): Added. (-[WebView selectedDOMRange]): Added. (-[WebView insertText:]): Added. (-[WebView _alterSelection:direction:granularity:]): Added. (-[WebView selectWord:]): Added. (-[WebView moveRight:]): Added. (-[WebView moveRightAndModifySelection:]): Added. (-[WebView moveLeft:]): Added. (-[WebView moveLeftAndModifySelection:]): Added. (-[WebView deleteBackward:]): Added. (-[WebView insertNewline:]): Added. (-[WebView insertParagraphSeparator:]): Added. (-[WebView setEditingDelegate:]): Added. (-[WebView editingDelegate]): Added. (-[WebView undoManager]): Added. (-[WebView insertText:replacingDOMRange:]): Added.
  • WebView.subproj/WebViewPrivate.h: Added a collection of editing API declarations that will be public some day, but are still under review.

WebBrowser:

Reviewed by Dave

Browser document no longer creates its own undo manager.
Safari will use a different method to work with undo
managers once we settle on a WebKit API. For now, I am
just going to delete this early attempt.

  • BrowserDocument.h
  • BrowserDocument.m
2:15 PM Changeset in webkit [6209] by cblu
  • 4 edits in trunk/WebCore

Fixed some spacing issues in reconstructed source and web archives that were caused by a malformed doc type string that we were constructing.

Reviewed by darin.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode): set the public ID and system ID on the doc type
  • khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::toString): put a space between DOCTYPE and the name
  • khtml/xml/dom_docimpl.h: (DOM::DocumentTypeImpl::setPublicId): new (DOM::DocumentTypeImpl::setSystemId): new
2:08 PM Changeset in webkit [6208] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
  • bump the JavaScriptCore version number to 125.3 on the Safari-1-2-branch, to match the JSC version number that is in Feldspar
1:35 PM Changeset in webkit [6207] by vicki
  • 1 edit in branches/Safari-1-2-branch/JavaScriptCore/ChangeLog
  • fix my ChangeLog comment
1:26 PM Changeset in webkit [6206] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
  • roll this change from the SUPanFeldspar branch to the Safari-1-2-branch, so that all our Feldspar changes are also in Epiphany

2004-01-30 Richard Williamson <​rjw@apple.com>

Fixed 3542044. Create KJS::String using UString constructor instead
of passing UTF8 string to char* constructor.

Reviewed by Darin.

  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue):
12:12 PM Changeset in webkit [6205] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • fixed <rdar://problem/3585056>: Assertion failure if error page is loaded from webView:unableToImplementPolicyWithError:
  • also added HeaderDoc comments to could-be-API-soon methods and fixed a conceptual problem with said methods

Reviewed by Darin.

  • WebView.subproj/WebDataSourcePrivate.h: added HeaderDoc comment for -unreachableURL
  • WebView.subproj/WebFramePrivate.h: added HeaderDoc comment for -loadAlternateHTMLString:baseURL:forUnreachableURL:; also added boolean delegateIsHandlingUnimplementablePolicy ivar to WebFramePrivate
  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): treat delegateIsHandlingUnimplementablePolicy like delegateIsDecidingNavigationPolicy. Safari serves up error pages during the latter but clients are equally or more likely to do so during the former. (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): set delegateIsHandlingUnimplementablePolicy during delegate callback (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): tweaked assertion so it doesn't erroneously fire for clients that call loadAlternateHTML:baseURL:forUnreachableURL: while processing webView:unableToImplementPolicyWithError:

WebBrowser:

Removed obsolete comment I happened to notice.

Reviewed by Darin..

  • BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]):
11:32 AM Changeset in webkit [6204] by cblu
  • 11 edits in trunk/WebKit

Tests:

Now that WebArchive is a class, refer to it as such.

Reviewed by kocienda.

  • Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument loadWebArchive:]):

WebKit:

Made WebArchive a class instead of a data object. This allows clients to easily get the main resource and subresources from a WebArchive.

Reviewed by kocienda.

  • WebKit.exp:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadWebArchive]): (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): (-[WebHTMLRepresentation webArchiveFromNode:]): (-[WebHTMLRepresentation webArchiveFromRange:]):
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedWebArchive:]): (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView _pasteMarkupFromPasteboard:]):
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (-[WebArchivePrivate dealloc]): (-[WebResource _response]): (-[WebArchive init]): (-[WebArchive initWithMainResource:subresources:]): (-[WebArchive initWithData:]): (-[WebArchive dealloc]): (-[WebArchive mainResource]): (-[WebArchive subresources]): (-[WebArchive dataRepresentation]):
  • WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Now that WebArchive is a class, refer to it as such.

Reviewed by kocienda.

  • BrowserDocument.m: (-[BrowserDocument dataRepresentationOfType:]): (-[BrowserDocument _mailWebArchiveData:withApplicationAtPath:]): (-[BrowserDocument mailPage:]): (-[BrowserDocument mailPageAddress:]):
  • English.lproj/InfoPlist.strings:
2:25 AM Changeset in webkit [6203] by mjs
  • 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Merge yet another fix for Epiphany.

2004-03-10 David Hyatt <​hyatt@apple.com>

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:

Mar 10, 2004:

6:07 PM Changeset in webkit [6202] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3584646, AxWebArea should encompass all children (its AxSize should).

Reviewed by mjs

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::absoluteRects):
  • khtml/rendering/render_canvas.h:
2:58 PM Changeset in webkit [6201] by rjw
  • 1 edit in trunk/JavaScriptCore/bindings/runtime.cpp

Fixed broken build.

2:25 PM Changeset in webkit [6200] by rjw
  • 5 edits in trunk/JavaScriptCore

Made changes to support new asychronous approach to calls from
plugin to JavaScript

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_ToString): (NP_GetPropertyAtIndex):
  • bindings/NP_runtime.h:
  • bindings/make_testbindings:
  • bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
1:51 PM Changeset in webkit [6199] by cblu
  • 3 edits in trunk/WebCore

Fixed: INPUT images are not part of web archives.

Reviewed by rjw.

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_formimpl.h:
1:50 PM Changeset in webkit [6198] by cblu
  • 5 edits in trunk/WebKit

Made dragging of web archives work.

Reviewed by rjw.

  • English.lproj/StringsNotToBeLocalized.txt: updated
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): added a FIXME about working around old Foundations that don't know about web archive files
  • WebView.subproj/WebView.m: (+[WebView canShowFile:]): tweak (+[WebView suggestedFileExtensionForMIMEType:]): tweak (+[WebView _MIMETypeForFile:]): handle web archive files since Foundation may be too old to know about them
1:50 PM Changeset in webkit [6197] by rjw
  • 2 edits in trunk/JavaScriptCore

Updated header to include proposed changes from
plugin-futures list. Calls from plugin to JavaScript
are now asynchronous.

Reviewed by Chris.

  • bindings/NP_runtime.h:
4:08 AM Changeset in webkit [6196]
  • 13 copies
    2 deletes in tags/WebCore-125~4

This commit was manufactured by cvs2svn to create tag
'WebCore-125~4'.

4:08 AM Changeset in webkit [6195] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.4

3:55 AM Changeset in webkit [6194] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Fix branch so it builds.

  • khtml/ecma/kjs_html.h:

Mar 9, 2004:

5:33 PM Changeset in webkit [6193] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.

Reviewed by rjw.

  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): add timing code (+[WebResource _webArchiveWithMainResource:subresources:]): add timing code, use NSPropertyListBinaryFormat_v1_0

WebBrowser:

Reviewed by rjw.

  • BrowserDocument.m: (-[BrowserDocument mailPageAddress:]): call [WebResource _webArchiveWithMainResource:subresources:] and let it handle the property list serialization
5:26 PM Changeset in webkit [6192] by mjs
  • 3 edits in branches/Safari-1-2-branch/WebCore

Merged the following changes from HEAD for Epiphany:

2004-03-09 David Hyatt <​hyatt@apple.com>

Make the AXLinkUIElements attribute always return an array (never
return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):

2004-03-09 David Hyatt <​hyatt@apple.com>

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
3:46 PM Changeset in webkit [6191] by cblu
  • 31 edits in trunk

Tests:

Updated blot to use new SPI's.

  • Blot/BlotApp.m: (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): (-[BlotDocument loadWebArchive:]):
  • TestPlugin/TestPlugin.pbproj/project.pbxproj:

WebCore:

Implemented WebCore side of: <rdar://problem/3577508>: API: web archive related API's

Reviewed by rjw.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/DOM.mm: (+[DOMRange _rangeWithImpl:]): made internally accessible (-[DOMRange _rangeImpl]): ditto
  • kwq/DOMInternal.h:
  • kwq/KWQStringList.h:
  • kwq/KWQStringList.mm: (QStringList::getNSArray): new
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge pasteMarkupString:]): renamed from pasteHTMLString since XML pasting may be possible (-[WebCoreBridge selectedRange]): new (-[WebCoreBridge _documentTypeString]): new (-[WebCoreBridge _stringWithDocumentTypeStringAndMarkupString:]): new (-[WebCoreBridge markupStringFromNode:subresourceURLStrings:]): new, needed for WebKit API's (-[WebCoreBridge markupStringFromRange:subresourceURLStrings:]): new, needed for WebKit API's

WebKit:

Fixed: <rdar://problem/3577508>: API: web archive related API's
Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by rjw.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:textEncodingName:]): renamed to take a textEncodingName instead of data source. The data source argument is only needed for the textEncodingName.
  • WebKit.exp:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _subresourcesDictionary]): new (+[WebDataSource _repTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDocumentInternal.h:
  • WebView.subproj/WebDocumentPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadWebArchive:]): renamed, code factored out to [WebResource _parseWebArchive:mainResource:subresources:]
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): include "application/x-webarchive"
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentationPrivate dealloc]): (-[WebHTMLRepresentation _isDisplayingWebArchive]): new (-[WebHTMLRepresentation receivedData:withDataSource:]): don't feed data to WebCore if we're displaying a web archive since web archive can't be progressively loaded (-[WebHTMLRepresentation loadWebArchive]): new, feeds web archive data to WebCore (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): call loadWebArchive if necessary (-[WebHTMLRepresentation documentSource]): if displaying a web archive, return the HTML source from within the archive (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): new (-[WebHTMLRepresentation markupStringFromNode:]): implementation of new API (-[WebHTMLRepresentation markupStringFromRange:]): ditto (-[WebHTMLRepresentation webArchiveFromNode:]): ditto (-[WebHTMLRepresentation webArchiveFromRange:]): ditto
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): use renamed WebArchivePboardType (-[WebHTMLView _selectedWebArchive:]): renamed, call renamed methods (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed methods (-[WebHTMLView _haveSelection]): indentation tweak (-[WebHTMLView _canDelete]): ditto (-[WebHTMLView _canPaste]): ditto (-[WebHTMLView _pasteMarkupFromPasteboard:]): renamed, call [WebResource _webArchiveWithMainResource:subresources:] (-[WebHTMLView initWithFrame:]): use renamed WebArchivePboardType (-[WebHTMLView paste:]): call renamed _pasteMarkupFromPasteboard (-[WebHTMLView concludeDragOperation:]): call renamed _pasteMarkupFromPasteboard
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): modify the MIME type for web archives since Foundation is not yet web archive aware. This is ifdef'd pre-Tiger code.
  • WebView.subproj/WebResource.h:
  • WebView.subproj/WebResource.m: (+[WebResource _parseWebArchive:mainResource:subresources:]): new (+[WebResource _webArchiveWithMainResource:subresources:]): new
  • WebView.subproj/WebResourcePrivate.h:

WebBrowser:

Fixed: <rdar://problem/3144033>: ability to save web sites (images and all)

Reviewed by john.

  • BrowserDocument.h: added _dataSourceToSave, _fileFormatAccessoryView, _ fileFormatPopUpButton and _isSavingWithSavePanel ivars
  • BrowserDocument.m: (-[BrowserDocument dealloc]): added ASSERTs (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument canSaveAsWebArchive]): new (-[BrowserDocument isSavingWebArchive]): new (-[BrowserDocument MIMETypeForSaving]): take web archives into account (-[BrowserDocument filenameForSaving]): new (-[BrowserDocument isSavingPlainText]): moved (-[BrowserDocument setDataSourceToSave:]): instead of this being a wrapper method around setFileWrapperToSave:MIMEType:, have this set _dataSourceToSave since we need the data source for web archives to work (-[BrowserDocument saveDocumentTo:]): don't call setFileWrapperToSave:MIMEType: if there is no file wrapper since this case is handled in the above methods (-[BrowserDocument document:didSave:contextInfo:]): added more post-save clean-up (-[BrowserDocument allowedFileTypes]): new (-[BrowserDocument fileFormatPopUpButtonUpdated:]): new (-[BrowserDocument prepareSavePanel:]): attach an accessory view to the save panel if necessary (-[BrowserDocument dataRepresentationOfType:]): handle all cases of saving data (-[BrowserDocument displayName]): rely on the _isSavingWithSavePanel instead of _fileWrapperToSave for choosing a filename (-[BrowserDocument _isDisplayingCompletePage]): new, factored out from validateUserInterfaceItem: (-[BrowserDocument validateUserInterfaceItem:]): for mailPage:, makes sure the representation supports web archives (-[BrowserDocument _mailWebArchive:withApplicationAtPath:]): mail a web archive instead of a property list
(-[BrowserDocument mailPage:]): handle the case where the current page …
(-[BrowserDocument mailPageAddress:]): call renamed _mailWebArchive
  • PreferenceKeys.h: added keys for the pref of saving a web archive or raw source
  • WebBrowser.pbproj/project.pbxproj:
2:12 PM Changeset in webkit [6190] by hyatt
  • 2 edits in trunk/WebCore

Make the AXLinkUIElements attribute always return an array (never return nil).

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):
1:03 PM Changeset in webkit [6189] by sullivan
  • 6 edits in trunk/WebKit

WebKit:

  • fixed the following bugs: <rdar://problem/3579715>: Going to an error page in back/forward list doesn't work correctly in some cases <rdar://problem/3581031>: REGRESSION (130+): World Leak of WebFrame after trying to load page with unknown scheme

Reviewed by Darin.

  • WebView.subproj/WebDataSourcePrivate.h: renamed setRequest -> adoptRequest
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _URLForHistory]): updated comment (-[WebDataSource __adoptRequest:]): Renamed from setRequest; now takes an NSMutableURLRequest and uses it as-is. (-[WebDataSource _setRequest:]): now saves a mutable copy, instead of relying on the caller to do so. The (only) caller wasn't doing so in all cases, leading to trouble in River City. Also, special-case unreachable URL handling to allow alternate content to replace a URL in a redirect-like way without sending a redirect callback.
  • WebView.subproj/WebFrame.m: (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): renamed after discussion with Richard (was loadPlaceholderHTMLString:baseURL:unreachableURL:) (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): new helper method, returns YES only if we receive a load request for alternate content from a delegate for an unreachable URL while we are going back or forward. That's a lot of prepositions! (-[WebFrame _loadRequest:subresources:]): if _shouldReloadToHandleUnreachableURLFromRequest: returns YES, change load type to WebFrameLoadTypeReload so b/f list is preserved appropriately. (-[WebFrame _transitionToCommitted:]): Update currentItem in the unreachableURL case. (-[WebFrame _isLoadComplete]): Don't reset b/f list before calling provisionalLoadDidFail delegate; instead, determine where to reset b/f list beforehand, and then actually reset list afterwards only if we didn't start an alternate content load in the delegate. Also, set new boolean ivar so we know when we're processing a provisionalLoadDidFail delegate callback. (-[WebFrame _loadItem:withLoadType:]): don't make extra copy before calling adoptRequest; just pass it the one we made here. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): If we're loading alternate content for an unreachableURL, don't ask the decision listener, just do it. (This avoids problem with nested calls to checking the navigation policy that led to a WebFrame leak, and is conceptually the right thing to do also.) Also added some asserts that helped me track down the WebFrame leak. Set new boolean ivar so we know when we're processing a navigation policy delegate decision. (-[WebFrame _currentBackForwardListItemToResetTo]): new method, replaces _resetBackForwardListToCurrent. Does the same test as the latter but returns a boolean rather than actually resetting. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): save dataSource in a local var before calling stopLoading, and use it for _setProvisionalDataSource, because otherwise stopLoading was clobbering the dataSource for an unreachable URL handling case.
  • WebView.subproj/WebFramePrivate.h: two new boolean ivars
  • WebView.subproj/WebView.m: (+[WebView _canHandleRequest:]): return YES when we're loading alternate content for an unreachable URL

WebBrowser:

Reviewed by Darin.

  • BrowserWebController.m: (-[BrowserWebView showErrorPageForURL:withTitle:message:]): update call to renamed method
10:50 AM Changeset in webkit [6188] by hyatt
  • 3 edits in trunk/WebCore

(1) Change root element in a document to have a role of AXWebArea.
(2) Add support for AXURL to links and children of links.
(3) Add support for AXLinkUIElements to the AXWebArea

Reviewed by john

  • khtml/dom/html_misc.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
6:24 AM Changeset in webkit [6187] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by nobody.

  • kwq/KWQKURL.mm: (KURL::KURL): Fixed broken build by removing wayward "break" statement.

Mar 8, 2004:

4:14 PM Changeset in webkit [6186] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3554876>: REGRESSION (100-125): cannot upload file if path contains non-ASCII characters
  • kwq/KWQKURL.mm: Remove Colon constant so we can fit in 8 bits again. (KURL::KURL): Rewrite so we don't need isSchemeCharOrColon.
3:46 PM Changeset in webkit [6185]
  • 3 copies in tags/Safari-131

This commit was manufactured by cvs2svn to create tag 'Safari-131'.

3:46 PM Changeset in webkit [6184] by kocienda
  • 4 edits in trunk

Submitting Safari-131

3:46 PM Changeset in webkit [6183] by kocienda
  • 2 edits in trunk/WebKit

2004-03-08 Ken Kocienda <​kocienda@apple.com>

Reviewed by Darin

  • WebKit.pbproj/project.pbxproj: Added CFBundleName to Info.plist
3:45 PM Changeset in webkit [6182] by kocienda
  • 2 edits in trunk/WebCore

2004-03-08 Ken Kocienda <​kocienda@apple.com>

Reviewed by Darin

  • WebCore.pbproj/project.pbxproj: Added CFBundleName to Info.plist.

Mar 5, 2004:

5:21 PM Changeset in webkit [6181] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for first-letter bug.

5:19 PM Changeset in webkit [6180] by hyatt
  • 2 edits in trunk/WebCore

Fix for first-line inheritance problem caused by incorrectly inheriting first-line into floating
blocks.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::firstLineBlock):
3:34 PM Changeset in webkit [6179] by kocienda
  • 1 edit
    1 add in trunk/WebCore

Reviewed by me.

Forgot to add this when I checked in last time.

  • ForwardingHeaders/css/css_computedstyle.h: Added.
3:01 PM Changeset in webkit [6178] by kocienda
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Dave.

Added initial support for retrieving the computed
style of document elements.

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_computedstyle.cpp: Added. (DOM::valueForLength): Helper to turn a khtml::Length into a computed value string. (DOM::stringForBorderStyle): Helper to turn an EBorderStyle into a computed value string. (DOM::stringForTextAlign): Helper to turn an ETextAlign into a computed value string. (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): New function. (DOM::CSSComputedStyleDeclarationImpl::~CSSComputedStyleDeclarationImpl): Ditto. (DOM::CSSComputedStyleDeclarationImpl::cssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue): Ditto. (DOM::CSSComputedStyleDeclarationImpl::getPropertyPriority): Ditto. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::setLengthProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::item): Ditto. (DOM::CSSComputedStyleDeclarationImpl::property): Ditto.
  • khtml/css/css_computedstyle.h: Added.
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText): Fixed some formatting of Rect. Added suppoprt for rgba colors.
  • khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node):
  • khtml/ecma/kjs_css.cpp: (KJS::getDOMCSSStyleDeclaration):
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): defaultView is a property, used to be a function, which was wrong. Fixed. (DOMDocumentProtoFunc::tryCall): Ditto.
  • khtml/ecma/kjs_dom.lut.h: (KJS::): Regenerated file.
  • khtml/misc/khtmllayout.h: (khtml::Length::length): Added an accessor to the value, to promote better coding style, rather than peeking and poking the value directly.
  • khtml/rendering/render_style.h: (khtml::RenderStyle::borderLeftWidth): BHIDDEN also should be treated like BNONE when it comes to returning a zero value. Now it is. (khtml::RenderStyle::borderRightWidth): Ditto. (khtml::RenderStyle::borderTopWidth): Ditto. (khtml::RenderStyle::borderBottomWidth): Ditto. (khtml::RenderStyle::outlineWidth): Ditto. (khtml::RenderStyle::outlineOffset): Ditto.
  • khtml/xml/dom2_viewsimpl.cpp: (AbstractViewImpl::getComputedStyle): Added an implementation for this formerly stubbed out function.
1:27 PM Changeset in webkit [6177] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): declare the pboard types by calling _web_writeURL:::: before calling setData::
11:02 AM Changeset in webkit [6176] by sullivan
  • 9 edits in trunk/WebKit

WebKit:

First cut at WebKit support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos.

Reviewed by Darin.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate didReceiveResponse:]): use new _webDataRequextExternalURL to share code
  • WebView.subproj/WebDataProtocol.h: Three new methods (all internal to WebKit): -[NSURLRequest _webDataRequestUnreachableURL], -[NSURLRequest _webDataRequestExternalURL], -[NSURLRequest _webDataRequestSetUnreachableURL]
  • WebView.subproj/WebDataProtocol.m: new unreachableURL field of WebDataRequestParameters (-[WebDataRequestParameters copyWithZone:]): copy new field (-[WebDataRequestParameters dealloc]): release new field (-[NSURLRequest _webDataRequestUnreachableURL]): read new field (-[NSURLRequest _webDataRequestExternalURL]): new method, returns baseURL or "about:blank" for webdata protocol requests. This was done in multiple places previously. (-[NSURLRequest _webDataRequestExternalRequest]): now calls _webDataRequestExternalURL to share code (-[NSMutableURLRequest _webDataRequestSetUnreachableURL:]): write new field
  • WebView.subproj/WebDataSource.m: (-[WebDataSource unreachableURL]): new method, might become API; returns the unreachable URL, if any, for which this datasource holds placeholder content (-[WebDataSource _URLForHistory]): new method, returns the URL to be stored in History for this dataSource. This returns nil for run-of-the-mill WebDataProtocol URLs (replacing code elsewhere that checked for this case) but returns the unreachableURL for the case where this datasource holds placeholder content. (-[WebDataSource _setTitle:]): now calls _URLForHistory
  • WebView.subproj/WebDataSourcePrivate.h: added unreachableURL in the should-become-API section, and _URLForHistory elsewhere
  • WebView.subproj/WebFrame.m: (-[WebFrame loadPlaceholderHTMLString:baseURL:unreachableURL:]): new should-become-API method for displaying an error page for an unreachable URL (-[WebFrame loadPropertyList:]): updated to pass nil for unreachableURL (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets set on the data request (-[WebFrame _addBackForwardItemClippedAtTarget:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _createItem:]): use unreachableURL if there is one (-[WebFrame _transitionToCommitted:]): use _URLForHistory instead of just checking for WebDataProtocol (-[WebFrame _isLoadComplete]): check whether a new load has started in the delegate callback and if so, don't reset the loading state here (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): added unreachableURL parameter, which gets passed through (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): send nil unreachableURL parameter (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): new bottleneck method for loadHTMLString:baseURL: and loadPlaceholderHTMLString:baseURL:unreachableURL:; this is the guts of loadHTMLString:baseURL: with the new unreachableURL parameter passed through (-[WebFrame loadHTMLString:baseURL:]): now calls new bottleneck method
  • WebView.subproj/WebFramePrivate.h: added loadPlaceholderString:baseURL:unreachableURL: to should-be-API section; added unreachableURL parameter to _webDataRequestForData:MIMEType:textEncodingName:baseURL:

WebBrowser:

First cut at WebBrowser support for showing error pages for unreachable URLs.
This doesn't work quite right with the back/forward list yet, but is
good enough for demos. The old sheet-using code remains intact, and there's
a menu item in the Debug menu to try the new way (old way is still default
for now).

Reviewed by Darin.

  • PreferenceKeys.h: added DebugDisplayErrorsAsPagesPreferenceKey; also deleted a couple of unused old preference keys.
  • BrowserWebController.h: added showErrorPageForURL:withTitle:message:
  • BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): use showErrorPageForURL:... if the preference is set that way (-[BrowserWebView errorPageHTMLWithTitle:message:]): new method, returns an HTML string for the error page. This will eventually be done reading resources from disk no doubt, but for now we just display a simple page that has the same text as the sheet. (-[BrowserWebView showErrorPageForURL:withTitle:message:]): new method, uses new loadPlaceholderHTMLString:baseURL:unreachableURL: to put up an error page in the webview (-[BrowserWebView expectedOrCurrentURL]): use unreachableURL if there is one
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add menu item "Show Page Load Errors Inline" (-[NSApplication validate_toggleDisplayLoadErrorsAsPages:]): new method, sets the checkmark on the new menu item appropriately (-[NSApplication toggleDisplayLoadErrorsAsPages:]): new method, toggles the state of the preference
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): use unreachableURL if there is one (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): ditto
  • LocationChangeError.m: (-[LocationChangeHandler displayOrRememberLocationChangeError:forDataSource:]): use showErrorPage:... if the preference is set that way
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): use previously-fetched local variable "frame" rather than getting it from the dataSource again. This is not only trivially faster in the normal case, but also avoids a bug when the code earlier in this method triggers another page load (as in the showErrorPage:... case).
  • English.lproj/Localizable.strings: updated for these changes
10:20 AM Changeset in webkit [6175] by kocienda
  • 2 edits in trunk/WebCore

Change by Darin. Reviewed by me.

  • kwq/DOM.mm: Fixed the following functions to deal with casting objects derived from NodeImpl back and forth to NodeImpl given that the derived classes use multiple inheritance. (-[DOMDocument _documentImpl]): (-[DOMCharacterData _characterDataImpl]): (-[DOMAttr _attrImpl]): (-[DOMElement _elementImpl]): (-[DOMText _textImpl]): (-[DOMDocumentType _documentTypeImpl]): (-[DOMNotation _notationImpl]): (-[DOMEntity _entityImpl]): (-[DOMProcessingInstruction _processingInstructionImpl]):

Mar 4, 2004:

5:52 PM Changeset in webkit [6174]
  • 11 copies
    2 deletes in tags/WebCore-125~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~3'.

5:52 PM Changeset in webkit [6173] by mjs
  • 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

WebCore-125.3

5:48 PM Changeset in webkit [6172] by mjs
  • 8 edits in branches/Safari-1-2-branch/WebCore

Bump versions.

  • English.lproj/InfoPlist.strings:
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]): Fix to build on branch.

Merge the following fix for Epiphany:

2004-03-03 David Hyatt <​hyatt@apple.com>

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):
5:34 PM Changeset in webkit [6171] by rjw
  • 5 edits
    1 add in trunk/JavaScriptCore

Implementation of NP_JavaScriptObject. This is the 'C' class
that wraps a JavaScript object. Still have more stubs to
implement before this is complete.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: Added. (coerceValueToNPValueType): (convertValueToNPValueType): (convertNPValueTypeToValue): (listFromNPArray): (jsAllocate): (jsDeallocate): (identiferFromNPIdentifier): (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_SetProperty): (NP_RemoveProperty): (NP_ToString): (NP_GetPropertyAtIndex): (NP_SetPropertyAtIndex):
  • bindings/NP_runtime.cpp: (NP_ObjectAtIndex):
  • bindings/NP_runtime.h:
  • bindings/runtime_object.h:
3:34 PM Changeset in webkit [6170] by cblu
  • 10 edits in trunk/WebKit

WebKit:

  • Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
  • Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.

Reviewed by rjw.

  • ChangeLog:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileWrapperForURL:]): call _fileWrapperForURL on WebDataSource
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): moved from WebView, creates a wrapper from a WebResource
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call [WebDataSource _fileWrapperForURL:]
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebDataSource _fileWrapperForURL:] (-[WebHTMLView _dragOperationForDraggingInfo:]): new, factored out from draggingUpdated: (-[WebHTMLView draggingEntered:]): call _dragOperationForDraggingInfo:, if NSDragOperationNone, forward to WebView to it can handle the drag (-[WebHTMLView draggingUpdated:]): ditto (-[WebHTMLView concludeDragOperation:]): ditto
  • WebView.subproj/WebResource.m: (-[WebResource _fileWrapperRepresentation]): new
  • WebView.subproj/WebResourcePrivate.h:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): release draggedTypes, a new ivar that keeps track of drag types that we're currently registered for (-[WebView _setDraggedTypes:]): new (-[WebView unregisterDraggedTypes]): new, calls _setDraggedTypes then super (-[WebView registerForDraggedTypes:]): ditto (-[WebView _dragOperationForDraggingInfo:]): new, compares the types on the pasteboard against the types we are currently registered for. Normally the AppKit handles this for us, but since these messages can be forwarded from WebHTMLView, we need to do this comparison ourselves. (-[WebView draggingEntered:]): calls _dragOperationForDraggingInfo: (-[WebView draggingUpdated:]): ditto (-[WebView concludeDragOperation:]): ditto
  • WebView.subproj/WebViewPrivate.h: define new draggedTypes ivar

WebBrowser:

Removed "Download Image" context menus because images no longer need to be re-downloaded.

Reviewed by rjw.

  • ContextMenuHandler.m: (-[WebDataSource isDataLocalForURL:]): new category, moved from the WebView category (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): call isDataLocalForURL on WebDataSource (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource, use the resource to get the MIME type if possible (-[BrowserWebView saveFileWrapperToDownloadsFolderForURLKey:menuItem:]): call _fileWrapperForURL on WebDataSource
3:24 PM Changeset in webkit [6169] by rjw
  • 3 edits in trunk/JavaScriptCore

Added NP_Array implementation.

Changed NP_Boolean to just depend on two static instances, no
space is required for values.

Reviewed by Chris.

  • bindings/NP_runtime.cpp: (NP_CreateBoolean): (NP_BoolFromBoolean): (arrayAllocate): (arrayDeallocate): (NP_CreateArray): (NP_CreateArrayV): (NP_ObjectAtIndex):
  • bindings/NP_runtime.h:

Mar 3, 2004:

6:59 PM Changeset in webkit [6168] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Actually merge the two changes below, they didn't actually get in
last time.

  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):
4:39 PM Changeset in webkit [6167] by cblu
  • 2 edits in trunk/WebKit

Fixed a typo.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragOperation:]):
4:29 PM Changeset in webkit [6166] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file

Reviewed by rjw.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView draggingUpdated:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it (-[WebHTMLView concludeDragOperation:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it
2:56 PM Changeset in webkit [6165] by darin
  • 6 edits
    3 deletes in trunk

JavaScriptCore:

Reviewed by Vicki.

  • English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
  • JavaScriptCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebCore:

Reviewed by Vicki.

  • English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
  • WebCore.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebKit:

Reviewed by Vicki.

  • English.lproj/InfoPlist.strings: Removed. No need to localize the version and copyright string, and that's all that was in here.
  • WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.

WebBrowser:

Reviewed by Vicki.

  • English.lproj/InfoPlist.strings: Removed version, copyright message, and CFBundleName. We won't localize any of these (it's named "Safari" worldwide).
2:50 PM Changeset in webkit [6164] by rjw
  • 3 edits in trunk/JavaScriptCore

More 'C' binding implementation. Fleshed out all the
'primitive' data types.

Reviewed by Chris.

  • bindings/NP_runtime.cpp: (NP_ReleaseObject): (numberAllocate): (stringAllocate): (stringDeallocate): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString): (NP_StringLength): (booleanAllocate): (booleanDeallocate): (NP_CreateBoolean): (NP_BoolFromBoolean): (nullAllocate): (nullDeallocate): (NP_GetNull): (undefinedAllocate): (undefinedDeallocate): (NP_GetUndefined):
  • bindings/NP_runtime.h:
12:04 PM Changeset in webkit [6163] by rjw
  • 3 edits in trunk/JavaScriptCore

More 'C' binding implementation.

Reviewed by Chris.

  • bindings/NP_runtime.cpp: (identifierEqual): (identifierHash): (getIdentifierDictionary): (NP_IdentifierFromUTF8): (NP_UTF8FromIdentifier): (NP_CreateObject): (NP_ReleaseObject): (NP_IsKindOfClass): (numberCreate): (NP_CreateNumberWithInt): (NP_CreateNumberWithFloat): (NP_CreateNumberWithDouble): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber):
  • bindings/NP_runtime.h:
10:49 AM Changeset in webkit [6162]
  • 4 copies in tags/Safari-130

This commit was manufactured by cvs2svn to create tag 'Safari-130'.

10:49 AM Changeset in webkit [6161] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Chris

  • copy-webcore-files-to-webkit: Fixed up this script so that it does not fail if it is running "non-locally", like for B&I. The idiom is to check these files into WebKit after copying them from WebCore, hence this script is merely a convenience to keep the files in sync.
10:45 AM Changeset in webkit [6160] by hyatt
  • 6 edits in trunk/WebCore

Speed up access to the children arrays of accessibility objects by caching mutable arrays of children
and nulling them out only when the children change.

Reviewed by john

  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject childrenChanged]): (-[KWQAccObject clearChildren]):
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::childrenChanged):

Mar 2, 2004:

4:42 PM Changeset in webkit [6159] by kocienda
  • 10 edits in trunk

Tests:

Reviewed by me

  • Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]): Remove error out parameter from DOM call.

WebCore:

Reviewed by Darin and me. Coding by Darin and me.

1) Fix some places that were calling [self class], in at
least one case calling a method not defined on the class
(not gonna work).
2) Add underscore prefix for all non-API method names.
3) Make DOMObject refuse to init, which might prevent
problems where people get confused and think they can
subclass or instantiate it or its subclasses.
4) Use some C++ mojo to replace NSStringToDOMString and
DOMStringToNSString with type conversions built into the
DOMString class.
5) Removed NSError out parameters from the API. Methods
now throw NSExceptions.
6) Exception code local variables now initialized before
passing to khtml DOM impl calls.
7) Various other cleanups and tweaks.

  • khtml/dom/dom_string.h
  • khtml/xml/dom_atomicstring.h
  • kwq/DOM.h
  • kwq/DOM.mm
  • kwq/DOMInternal.h
  • kwq/KWQKHTMLPart.mm
  • kwq/WebCoreBridge.mm

WebKit:

Reviewed by NOBODY (OOPS!).

  • DOM.subproj/DOM.h: Checked in header copied over from WebCore.
4:20 PM Changeset in webkit [6158] by rjw
  • 3 edits in trunk/JavaScriptCore

Removed retain/release from NP_Class. Classes will not be allowed to implement their
own customer retain/release scheme.

Reviewed by Chris.

  • bindings/NP_runtime.cpp: (NP_RetainObject): (NP_ReleaseObject):
4:17 PM Changeset in webkit [6157] by rjw
  • 14 edits
    6 adds in trunk

WebKit:

Added WebJavaScriptObject API. The location of this file may
change.

Reviewed by Chris.

  • Plugins.subproj/NP_objc.h: Added.
  • WebKit.pbproj/project.pbxproj:

WebCore:

Added NP_SAP API. This API includes the new entry points
used to bind native interfaces to JavaScript. It's final location
may change.

Made changes to KWQKHTMLPart.mm to reflect changes in names
on RootObject.

Reviewed by Chris.

  • WebCore.pbproj/project.pbxproj:
  • khtml/ecma/NP_SAP.h: Added.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.mm:

JavaScriptCore:

C binding API. Partial implementation.

Completed ObjectiveC bindings (not based on the C API). These will re-implemented over the C binding API, but I wanted to get this code in the tree.

Factored root object reference counting scheme. It is now useful independent
of LiveConnect.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/NP_runtime.cpp: Added. (NP_IdentifierFromUTF8): (NP_GetIdentifiers): (NP_UTF8FromIdentifier): (NP_CreateObject): (NP_RetainObject): (NP_ReleaseObject): (NP_IsKindOfClass): (NP_SetException): (NP_Call): (NP_Evaluate): (NP_GetProperty): (NP_SetProperty): (NP_RemoveProperty): (NP_ToString): (NP_GetPropertyAtIndex): (NP_SetPropertyAtIndex): (NP_CreateNumberWithInt): (NP_CreateNumberWithFloat): (NP_CreateNumberWithDouble): (NP_IntFromNumber): (NP_FloatFromNumber): (NP_DoubleFromNumber): (NP_CreateStringWithUTF8): (NP_CreateStringWithUTF16): (NP_UTF8FromString): (NP_UTF16FromString): (NP_CreateBoolean): (NP_BoolFromBoolean): (NP_GetNull): (NP_GetUndefined): (NP_CreateArray): (NP_CreateArrayV): (NP_ObjectAtIndex):
  • bindings/NP_runtime.h: Added.
  • bindings/jni/jni_jsobject.cpp: (JSObject::invoke): (JSObject::finalize): (JSObject::createNative): (JSObject::convertValueToJObject):
  • bindings/jni/jni_jsobject.h:
  • bindings/objc/objc_jsobject.h:
  • bindings/objc/objc_jsobject.mm: (rootForView): (windowJavaScriptObject): (-[JavaScriptObject initWithObjectImp:KJS::root:Bindings::]): (-[JavaScriptObject dealloc]): (-[JavaScriptObject _convertValueToObjcValue:KJS::]): (-[JavaScriptObject call:arguments:]): (-[JavaScriptObject evaluate:]): (-[JavaScriptObject getMember:]): (-[JavaScriptObject setMember:value:]): (-[JavaScriptObject removeMember:]): (-[JavaScriptObject toString]): (-[JavaScriptObject getSlot:]): (-[JavaScriptObject setSlot:value:]):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • bindings/runtime_root.cpp: Added. (getReferencesByRootDictionary): (getReferencesDictionary): (KJS::Bindings::findReferenceDictionary): (KJS::Bindings::rootForImp): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (completedJavaScriptAccess): (initializeJavaScriptAccessLock): (lockJavaScriptAccess): (unlockJavaScriptAccess): (RootObject::dispatchToJavaScriptThread): (performJavaScriptAccess): (RootObject::setFindRootObjectForNativeHandleFunction): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: Added. (KJS::Bindings::RootObject::RootObject): (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp): (KJS::Bindings::RootObject::rootObjectImp): (KJS::Bindings::RootObject::setInterpreter): (KJS::Bindings::RootObject::interpreter): (KJS::Bindings::RootObject::findRootObjectForNativeHandleFunction): (KJS::Bindings::RootObject::runLoop): (KJS::Bindings::RootObject::performJavaScriptSource):
1:15 PM Changeset in webkit [6156] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3549201>: repro crash in KHTMLPart::begin inside JavaScript code (gmpartsdirect.com)

Added some null checks. I am not sure why this page attaches a
document that has no view, but these changes make it work
perfectly.

  • khtml/khtml_part.cpp: (KHTMLPart::begin): Add check for null view before use. * khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): ditto (DocumentImpl::recalcStyle): Add check for null paint device.
12:00 PM Changeset in webkit [6155] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3575598>: REGRESSION: Safari crashes at IS&T website

Reviewed by darin.

  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): don't stop the icon loader here because that can cause an infinite loop (-[WebDataSource _stopLoadingInternal]): always stop the icon loader here instead of just when the data source is loading as well.
10:07 AM Changeset in webkit [6154] by vicki
  • 3 edits in trunk

Change version number from '130' to '131u'. The tree is open.

9:27 AM Changeset in webkit [6153] by vicki
  • 6 edits in trunk

Safari-130 stamp

9:03 AM Changeset in webkit [6152] by kocienda
  • 8 edits in trunk

WebCore:

Reviewed by me

Rollout last night's checkin. The tree was closed.

  • kwq/DOM.h
  • kwq/DOM.mm
  • kwq/DOMInternal.h
  • kwq/KWQKHTMLPart.mm
  • kwq/WebCoreBridge.mm

WebKit:

Reviewed by me

  • DOM.subproj/DOM.h: Rollout last night's checkin. The tree was closed.

Mar 1, 2004:

6:59 PM Changeset in webkit [6151] by cblu
  • 5 edits in trunk/WebKit

Fixed: <rdar://problem/3574979>: REGRESSION (129-TOT): crash loading macromedia.com

deliverResource was being called after it had already been called in setDefersCallbacks:.

Reviewed by rjw.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate deliverResource]): set deliveredResource to YES (-[WebBaseResourceHandleDelegate deliverResourceAfterDelay]): new, calls deliverResource after a delay (-[WebBaseResourceHandleDelegate loadWithRequest:]): call deliverResourceAfterDelay (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResourceAfterDelay
6:52 PM Changeset in webkit [6150] by kocienda
  • 8 edits in trunk

WebCore:

Reviewed by me, changes by Darin.

Yet another pass at the DOM API, this one by
Darin to simplify the internal structure of the
implementation. Little has changed in the API;
much has changed in the implementation, particularly
with regard to object creation and data storage and
the class hierarchy.

  • kwq/DOM.h
  • kwq/DOM.mm
  • kwq/DOMInternal.h
  • kwq/KWQKHTMLPart.mm
  • kwq/WebCoreBridge.mm

WebKit:

Reviewed by me

  • DOM.subproj/DOM.h: Checked in header copied over from WebCore.
4:39 PM Changeset in webkit [6149] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • DOM.subproj/DOM.h: Oh, it's like the Keystone Cops this afternoon... Backed out an unintended change to thsi file.
4:37 PM Changeset in webkit [6148] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by me

  • copy-webcore-files-to-webkit: Dumb typing error on my part in making my previous quick fix. This quick fix works.
4:27 PM Changeset in webkit [6147] by cblu
  • 2 edits in trunk/WebKit

Updated the WebKit project file to 1.1 because a previous check-in reverted to 1.01.

  • WebKit.pbproj/project.pbxproj:
4:21 PM Changeset in webkit [6146] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • copy-webcore-files-to-webkit: Made this file buildit-compliant
4:04 PM Changeset in webkit [6145] by cblu
  • 3 edits in trunk/WebKit

Found a bug in my last check-in. If a load that originates from a WebResource is cancelled before the data from the WebResource is delivered, callbacks are sent anyway.

Reviewed by rjw.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelWithError:]): cancel the perform request for deliverResource
3:55 PM Changeset in webkit [6144] by vicki
  • 3 edits in trunk/WebKit

Reviewed by darin.

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): rejigger handle code to avoid Deployment failure
  • WebKit.pbproj/project.pbxproj:
2:39 PM Changeset in webkit [6143]
  • 5 copies
    3 deletes in tags/JavaScriptCore-125~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~3'.

2:39 PM Changeset in webkit [6142] by vicki
  • 2 edits in branches/SUPanFeldspar-branch/JavaScriptCore
2:37 PM Changeset in webkit [6141] by vicki
  • 2 edits in branches/SUPanFeldspar-branch/JavaScriptCore
  • roll this change onto the SUPanFeldspar branch

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.
2:23 PM Changeset in webkit [6140] by mjs
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed <rdar://problem/3567047>: REGRESSION: repro crash inside KJS (dispatchToBoolean) at www.thedonnas.com
  • fixed <rdar://problem/3550461>: REGRESSION: repro crash in JavaScript at www.alaska.com
  • khtml/ecma/kjs_window.cpp: (Window::getListener): Return Null() when the listener object is null, indicating the code failed to parse. Otherwise we return a bad value which can later crash the JS interpreter.
2:22 PM Changeset in webkit [6139] by cblu
  • 16 edits in trunk/WebKit
  • Made WebResource loading not use Foundation at all. This allows "Mail Page" and paste to more directly load subresources without any indirection involving NSURLConnection and the Foundation cache.
  • Made WebIconLoader a subclass of WebBaseResourceHandleDelegate. This makes favicons appear in the activity window among other things.

Reviewed by kocienda.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: removed connection and data ivars since WebBaseResourceHandleDelegate holds these (-[WebIconLoaderPrivate dealloc]): removed calls to deleted ivars (-[WebIconLoader URL]): call renamed request ivar (-[WebIconLoader startLoading]): call loadWithRequest (-[WebIconLoader stopLoading]): call cancel (-[WebIconLoader didFinishLoading]):
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection (-[WebNetscapePluginConnectionDelegate didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate didFinishLoading]): ditto (-[WebNetscapePluginConnectionDelegate didFailWithError:]): ditto
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): ditto (-[WebSubresourceClient didReceiveData:lengthReceived:]): ditto (-[WebSubresourceClient didFinishLoading]): ditto (-[WebSubresourceClient didFailWithError:]): ditto
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): instead of storing the resource in the Foundation cache in order to later load it from the cache, deliver the callbacks ourselves after a delay (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResource if callbacks are turned back on (-[WebBaseResourceHandleDelegate deliverResource]): new, calls didReceiveResponse:, didReceiveData:lengthReceived:, and didFinishLoading (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection (-[WebBaseResourceHandleDelegate didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate didReceiveData:lengthReceived:]): ditto (-[WebBaseResourceHandleDelegate didFinishLoading]): ditto (-[WebBaseResourceHandleDelegate didFailWithError:]): ditto (-[WebBaseResourceHandleDelegate willCacheResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): calls connection-less version of this method (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): ditto (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): ditto (-[WebBaseResourceHandleDelegate cancelWithError:]): call renamed _completeProgressForConnectionDelegate on WebView (-[WebBaseResourceHandleDelegate cancelledError]): tweak
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _loadIcon]): set the data source on the icon loader so it can callback
  • WebView.subproj/WebResource.m: (-[WebResource _response]): new, factored out from _cachedResponseRepresentation (-[WebResource _cachedResponseRepresentation]): call _response
  • WebView.subproj/WebResourcePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _incrementProgressForConnectionDelegate:response:]): renamed to be connection-less (-[WebView _incrementProgressForConnectionDelegate:data:]): ditto (-[WebView _completeProgressForConnectionDelegate:]): ditto
  • WebView.subproj/WebViewPrivate.h:
12:03 PM Changeset in webkit [6138] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed Tiger build
  • kwq/KWQXmlSimpleReader.mm: (QXmlSimpleReader::parse): Changed SAX structure initialization code so it compiles with both the newer and older libxml. Not sure this will work right with namespaces with the new libxml; we'll have to test.
9:30 AM Changeset in webkit [6137] by kocienda
  • 5 edits in trunk/WebCore

Reviewed by me, as suggested by Darin

  • khtml/misc/htmlattrs.c: (getAttrName): Generated code no longer has extraneous semicolon.
  • khtml/misc/htmltags.c: Generated code no longer has extraneous semicolon. (getTagName):
  • khtml/misc/makeattrs: Removed extraneous semicolon from end of file.
  • khtml/misc/maketags: Ditto.
9:24 AM Changeset in webkit [6136] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • kwq/DOMInternal.h: Replaced tabs with spaces.
9:04 AM Changeset in webkit [6135] by kocienda
  • 29 edits
    1 add
    2 deletes in trunk

Tests:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes

  • Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]):

WebCore:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes, using
a class cluster-like approach.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/html_object.cpp: Put code in DOM namespace.
  • khtml/html/html_headimpl.cpp: Pull in entire DOM namespace in using directive to make up for the removal of it from htmlattrs.
  • khtml/html/htmltokenizer.cpp: Add using directives for the DOM classes used.
  • khtml/misc/htmlattrs.c: (getAttrName):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmltags.c: (getTagName):
  • khtml/misc/makeattrs: Some changes here to avoid pulling in the entire DOM namespace. Explicitly use DOM namespace scoping for DOMString.
  • khtml/misc/maketags: Explicitly use DOM namespace scoping for DOMString.
  • khtml/rendering/render_form.cpp: Pull in entire DOM namespace in using directive to make up for the removal of it from htmlattrs.
  • kwq/DOM-compat.h:
  • kwq/DOM.h:
  • kwq/DOM.mm: Added.
  • kwq/WebCoreDOM.h: Removed.
  • kwq/WebCoreDOM.mm: Removed.

WebKit:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes.

  • DOM.subproj/DOM-compat.h:
  • DOM.subproj/DOM.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState form]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]): (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation elementForView:]): (-[WebHTMLRepresentation elementDoesAutoComplete:]): (-[WebHTMLRepresentation elementIsPassword:]): (-[WebHTMLRepresentation formForElement:]): (-[WebHTMLRepresentation controlsInForm:]): (-[WebHTMLRepresentation searchForLabels:beforeElement:]): (-[WebHTMLRepresentation matchLabels:againstElement:]):

WebBrowser:

Reviewed by Darin

Changed all Objective-C DOM classes from protocols to classes.

  • BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
  • Debug/SnippetController.m: (lastNode): (-[SnippetController loadComplete]):
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController loginInfoForForm:inFrame:]): (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): (+[FormCompletionController currentFormInFrame:]): (+[FormCompletionController currentFrameAndForm:inWebView:]): (+[FormCompletionController autoFillInWebView:]): (+[FormCompletionController autoFillPasswordInFrame:]): (-[FormCompletionController initWithSourceField:frame:]): (-[FormCompletionController maxStringLength]): (+[AutoFillController autoFillerForFrame:form:create:]): (+[AutoFillController abMatchInFrame:form:fieldName:]): (+[AutoFillController isContinuationField:inFrame:form:]): (+[AutoFillController recordABMatch:inFrame:form:fieldName:]): (+[AutoFillController clearAutoFilledView:inFrame:form:]): (-[AutoFillController _fieldNameForAutoFillOfView:rep:]): (fieldLooksLikeContinuation): (-[AutoFillController _reflectMultiFieldMatch:inViews:currIndex:fieldName:]): (-[FormToABBinder abPointerForView:rep:useFieldName:foundByPageScan:]):
  • Test/AutoFillTest.m: (+[AutoFillTest _dumpFormState:]):

Feb 27, 2004:

4:23 PM Changeset in webkit [6134]
  • 4 copies
    3 deletes in tags/JavaScriptCore-125~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~2'.

4:23 PM Changeset in webkit [6133] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
4:09 PM Changeset in webkit [6132] by vicki
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore
  • roll this change onto the Safari-1-2-branch, for SUPanFeldspar

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.
3:01 PM Changeset in webkit [6131]
  • 5 copies
    2 deletes in tags/JavaScriptCore-85~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-85~6'.

3:01 PM Changeset in webkit [6130] by vicki
  • 2 edits in branches/Safari-1-0-branch/JavaScriptCore
2:55 PM Changeset in webkit [6129] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3514733>: nil-deref in createHTMLEventListener at skiset.com
<rdar://problem/3510676>: nil-deref of view in DocumentImpl::createHTMLEventListener at kirotv.com

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Don't create the listener if there is no part. Also, get the part when going through the view. This prevents problems when handlers are set or removed from the onUnload handler.
2:50 PM Changeset in webkit [6128] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • WebKit changes to allow performance improvements to bookmarks

Reviewed by Darin.

  • History.subproj/WebHistoryItemPrivate.h: added notificationsSuppressed/setNotificationsSuppressed, and setURLString
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setNotificationsSuppressed:]): setter for new flag. When this flag is set, making changes to the WebHistoryItem will not cause WebHistoryChanged notifications to be sent. This is a big speedup for reading bookmarks from disk, since currently each WebBookmarkLeaf object keeps around a WebHistoryItem object that isn't really part of history and thus doesn't need to send notifications about history changing. (-[WebHistoryItem notificationsSuppressed]): getter for new flag (-[WebHistoryItem setURLString:]): new method, extracted from guts of setURL:; this allows callers (though currently only callers at Apple) that have a URL string in hand to set it directly on the WebHistoryItem rather than converting to a URL and back, both relatively slow operations. Also, doesn't sent a notification if notifications are suppressed. (-[WebHistoryItem setURL:]): now calls extracted method (-[WebHistoryItem setAlternateTitle:]): doesn't send notification if notifications are suppressed (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto

WebBrowser:

  • A number of performance improvements to importing bookmarks. Some but not all of them also apply to reading our native bookmarks from disk. When I started this, importing bookmarks from Netscape's HTML format was actually slower than importing bookmarks from our property list format, hard though that might be to imagine. Now importing the HTML format takes about half the time it used to, and now it's about 40% faster than importing the property list format, at least with my 33,000 bookmark sample file (and importing our property list format also sped up).

Reviewed by Darin.

  • BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): added count to timing log message (-[BookmarksController exportBookmarks:]): added timing log message (-[BookmarksController importFavoritesFrom:intoBookmarksFolder:settingPrefKey:]): added count to timing log message, and commented-out calls to start & stop sampling for the next time someone works on this. Also, in the case where we're importing from a user-chosen file instead of automatically, bypass the merging code because the merging code is unnecessarily complicated for the "just shlurp this pile o' bookmarks into a new folder" case.
  • BookmarksViewController.m: (-[BookmarksViewController changeAddressForBookmark:to:]): Use bestURLStringForUserTypedString here (when user manually edits a URL in the outline view) so that we don't have to use it in the general case of setting a bookmark's URL string, since it's slow. When programmatically setting a bookmark's URL string we can often just use an existing string as-is.
  • FormCompletionController.m: (+[FormCompletionController _saveCompletionDB:]): Fix the way an #ifdef was declared so it compiles in a deployment build that has LOG_DISABLED set to 0.
  • WebBookmarkGroupPrivate.h:
  • WebBookmarkGroup.m: (-[WebBookmarkGroup _bookmarkChild:wasAddedToParent:]): added this private-ish helper method to avoid creating an array in the case where we aren't even going to use it because notifications are suppressed (-[WebBookmarkGroup _bookmarkChild:wasRemovedFromParent:]): ditto
  • WebBookmarkImporter.m: (-[WebBookmarkImporter unescapeHTML:]): bail out early if there's no ampersand at all in the string (the normal case), to avoid creating a mutable string
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): suppress notifications on our private WebHistoryItem (-[WebBookmarkLeaf setURLString:]): call the new setURLString: method on our private WebHistoryItem instead of converting to a URL and then calling setURL: (which then converts back to a string)
  • WebBookmarkList.m: (-[WebBookmarkList removeChild:]): call new -[WebBookmarkGroup _bookmarkChild:wasRemovedFromParent:] so we don't have to create an NSArray here (-[WebBookmarkList insertChild:atIndex:]): call new -[WebBookmarkGroup _bookmarkChild:wasAddedToParent:] so we don't have to create an NSArray here
2:48 PM Changeset in webkit [6127] by vicki
  • 2 edits in branches/Safari-1-0-branch/JavaScriptCore
  • roll this change onto the Safari-1-0-branch, for Safari 1.0.3

2004-02-02 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fixed <rdar://problem/3546613>: array of negative size leads to crash (test page at oscar.the-rileys.net)
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): If the length is greater than 10,000, don't allocate an array until we start putting values in. This prevents new Array(2147483647) from causing trouble. (ArrayObjectImp::construct): Check number as described in specification, and raise a range error if the number is out of range. This prevents new Array(-1) from causing trouble.
1:25 AM Changeset in webkit [6126] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3571356>: REGRESSION: Crash in isPointInsideSelection clicking on link in Apple web directory frame
  • khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Don't crash if innerNode is NULL, as this can happen mousing over a frame that's in the process of loading and currently empty. Since such a frame obviously can't be inside the selection, this seems like a good enough fix.

Feb 26, 2004:

8:38 PM Changeset in webkit [6125] by cblu
  • 11 edits in trunk/WebKit

Tests:

Made Blot support the 'nmsg' event that Safari sends for the "Mail Page" and "Mail Page Address" feature.

Reviewed by NOBODY (OOPS!).

  • Blot/BlotApp.m: (-[BlotApp awakeFromNib]): (-[BlotApp handleURLEvent:withReplyEvent:]): (-[BlotApp handleNewMessageEvent:withReplyEvent:]):
  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m: (-[BlotDocument setSubject:]): (-[BlotDocument webView:didFinishLoadForFrame:]): (-[BlotDocument loadPropertyList:]):
  • Blot/English.lproj/BlotDocument.nib:
  • Blot/Info.plist:

WebKit:

WebKit side of:
<rdar://problem/3056566>: mail a link to this page
<rdar://problem/2961206>: implement ability to e-mail entire page

Reviewed by john.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): tweaks (-[WebIconDatabase _loadIconDictionaries]): fixed an assertion failure I found in Blot. Keep the original list of icon URLs as a separate list when doing the initial clean-up so we don't over release any icons. (-[WebIconDatabase _updateFileDatabase]): tweaks (-[WebIconDatabase _setIcon:forIconURL:]): tweaks (-[WebIconDatabase _releaseIconForIconURLString:]): tweaks (-[WebIconDatabase _retainOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list (-[WebIconDatabase _releaseOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list
  • Misc.subproj/WebIconDatabasePrivate.h:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _propertyListWithData:subresourceURLStrings:]): new, code moved from [WebHTMLView _selectedPropertyList:], creates property list rep of data and subresources (-[WebDataSource propertyList]): does the above with all the data source data, this is what "Mail Page" uses
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadPropertyList:]): renamed from loadHTMLPropertyList because the property list may contain non-HTML data
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedPropertyList:]): renamed, code moved to [WebDataSource _propertyListWithData:subresourceURLStrings:] (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed _selectedPropertyList

WebBrowser:

Fixed:
<rdar://problem/3056566>: mail a link to this page
<rdar://problem/2961206>: implement ability to e-mail entire page

The above work with Blot if you have that installed and will work with Mail once Mail supports it.

Reviewed by john.

  • BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]): handle mailPage and mailPageAddress (-[BrowserDocument _mailPropertyList:]): new, takes a WebKit property list and sends it to your Mail app if it supports it (-[BrowserDocument mailPage:]): calls _mailPropertyList with [WebDataSource propertyList] (-[BrowserDocument mailPageAddress:]): calls _mailPropertyList with boiler plate HTML
  • BrowserNSWorkspaceExtras.h:
  • BrowserNSWorkspaceExtras.m: (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:alreadyOpen:event:]): rearranged the arguments a little for aesthetic reasons
  • English.lproj/Localizable.strings:
  • English.lproj/MainMenu.nib: added "Mail Page" and "Mail Page Address" to the File menu
  • English.lproj/StringsNotToBeLocalized.txt:
  • Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences openProxyPreferences:]): call renamed launchApplicationAtPath:::::
  • WebBrowser.pbproj/project.pbxproj:
6:23 PM Changeset in webkit [6124]
  • 5 copies
    2 deletes in tags/WebCore-125~2

This commit was manufactured by cvs2svn to create tag
'WebCore-125~2'.

6:23 PM Changeset in webkit [6123]
  • 5 copies
    3 deletes in tags/WebCore-125~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~1'.

6:23 PM Changeset in webkit [6122] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore-125.1

5:37 PM Changeset in webkit [6121] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3528839, wide table cut off because of shorts being used instead of ints.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): (RenderTableCell::setWidth):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (FixedTableLayout::calcMinMaxWidth): (AutoTableLayout::calcMinMaxWidth):
4:44 PM Changeset in webkit [6120] by cblu
  • 8 edits in trunk/WebCore

Fixed a few problems I found with reconstructed source while on my way to implementing "Mail Page".

Reviewed by hyatt.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::isSubresourceURLAttribute): only true for stylesheet and icon
  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::isURLAttribute): implement isURLAttribute not isSubresourceURLAttribute
  • khtml/html/html_imageimpl.h:
  • khtml/rendering/render_box.cpp: (RenderBox::dirtyLineBoxes): crasher fix that I found using libgmalloc
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): don't escape SCRIPT and TEXTAREA text, write close tags for tags that need them instead of relying on the children check
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge HTMLString:]): call recursive_toHTMLWithOptions on the first child of the document so <#document /> isn't part of the source
3:10 PM Changeset in webkit [6119] by hyatt
  • 27 edits in trunk/WebCore

Convert render object widths from short to int. There was a bug on this, but I can't find it in Radar.

Reviewed by john

  • khtml/rendering/render_applet.cpp: (RenderApplet::intrinsicWidth): (RenderEmptyApplet::intrinsicWidth):
  • khtml/rendering/render_applet.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::width): (RenderBox::containingBlockWidth): (RenderBox::calcReplacedWidth): (RenderBox::setStaticX):
  • khtml/rendering/render_box.h: (khtml::RenderBox::minWidth): (khtml::RenderBox::maxWidth):
  • khtml/rendering/render_br.h: (khtml::RenderBR::minWidth): (khtml::RenderBR::maxWidth):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
  • khtml/rendering/render_frames.cpp: (RenderPart::intrinsicWidth): (RenderPartObject::layout):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_image.cpp: (RenderImage::layout): (RenderImage::calcReplacedWidth):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::width):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::scrollWidth):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::width): (khtml::RenderLayer::setWidth): (khtml::RenderLayer::scrollXOffset):
  • khtml/rendering/render_line.h: (khtml::InlineBox::setWidth): (khtml::InlineBox::width): (khtml::InlineBox::setXPos): (khtml::InlineBox::xPos):
  • khtml/rendering/render_object.cpp: (RenderObject::containingBlockWidth):
  • khtml/rendering/render_object.h: (khtml::RenderObject::setStaticX): (khtml::RenderObject::contentWidth): (khtml::RenderObject::intrinsicWidth): (khtml::RenderObject::width): (khtml::RenderObject::offsetWidth): (khtml::RenderObject::minWidth): (khtml::RenderObject::maxWidth):
  • khtml/rendering/render_replaced.h: (khtml::RenderReplaced::intrinsicWidth):
  • khtml/rendering/render_table.cpp: (RenderTable::calcWidth):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::width):
  • khtml/rendering/render_text.h: (khtml::RenderText::minWidth): (khtml::RenderText::maxWidth):
  • khtml/rendering/table_layout.cpp:
3:00 PM Changeset in webkit [6118] by trey
  • 6 edits in trunk/WebCore

3566668 - REGRESSION (125-128): autofill of popup lists is broken
3571271 - autofill parsing of field names should treat _ as a word separator

Reviewed by Chris, Darin

  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::populate): New virtual method to force any lazy field population to happen.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Change _ to ' ', to make it a word separator.
  • kwq/KWQWidget.h: (QWidget::populate): Implement populate to fill out the menu's data.
  • kwq/WebCoreBridge.mm: (viewForElement): Make sure widget is populated before handing it out.
11:16 AM Changeset in webkit [6117] by kocienda
  • 22 edits
    10 adds
    9 deletes in trunk

WebCore:

Reviewed by Chris

  • WebCore.pbproj/project.pbxproj:
  • khtml/xml/dom2_rangeimpl.h: Now includes createInstance glue function as do the other khtml DOM objects that we reflect into ObjC.
  • kwq/DOM-compat.h: Added. Compatibility declarations for DOM SPI. Note that this file is copied into WebKit by the build system as needed.
  • kwq/DOM.h: Added. New home for DOM SPI. Note that this file is copied into WebKit by the build system as needed.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::recordFormValue): Updated usage to new DOM SPI.
  • kwq/WebCoreBridge.h: Updated usage to new DOM SPI.
  • kwq/WebCoreBridge.mm: Updated usage to new DOM SPI. Needed to add DOM range impl include since includes jiggered around and this needed header was no longer included indirectly. (-[WebCoreBridge elementForView:]): Ditto. (inputElementFromDOMElement): Ditto. (formElementFromDOMElement): Ditto. (-[WebCoreBridge elementWithName:inForm:]): Ditto. (-[WebCoreBridge elementDoesAutoComplete:]): Ditto. (-[WebCoreBridge elementIsPassword:]): Ditto. (-[WebCoreBridge currentForm]): Ditto. (-[WebCoreBridge controlsInForm:]): Ditto. (-[WebCoreBridge searchForLabels:beforeElement:]): Ditto. (-[WebCoreBridge matchLabels:againstElement:]): Ditto. (-[WebCoreBridge elementAtPoint:]): Ditto. (-[WebCoreBridge DOMDocument]): Ditto. (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): Ditto. (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): Ditto. (-[WebCoreBridge selectionStart]): Ditto. (-[WebCoreBridge selectionEnd]): Ditto.
  • kwq/WebCoreDOM.h: New home for all private declarations needed for reflecting DOM into ObjC.
  • kwq/WebCoreDOM.mm: Added. New home for all implementations needed for reflecting DOM into ObjC.
  • kwq/WebCoreDOMDocument.mm: Removed. All ObjC DOM implementation now in WebCoreDOM.mm.
  • kwq/WebCoreDOMNode.mm: Removed. All ObjC DOM implementation now in WebCoreDOM.mm.
  • kwq/WebCoreDOMPrivate.h: Removed.
  • kwq/WebDOMDocument.h: Removed.
  • kwq/WebDOMElement.h: Removed.
  • kwq/WebDOMNode.h: Removed.

WebKit:

Reviewed by Chris

Updated usage of DOM SPI to use new names and conventions.

Unless indicated otherwise, the changes were to update protocol names for, which
changed from using a "WebDOM" prefix to a "DOM" prefix, and changing now need
only include the DOM.h header from WebKit to get everything.

  • DOM.subproj/DOM-compat.h: Added. This header contains some compatibility declarations to work with older clients of our DOM SPI. Though this file is checked into WebKit, it really lives and should be updated in WebCore. It is copied into WebKit by the build system as needed.
  • DOM.subproj/DOM.h: Added. This file includes the new "guts" of the DOM SPI. As above, this file is checked into WebKit, it really lives and should be updated in WebCore. It is copied into WebKit by the build system as needed.
  • DOM.subproj/WebDOMDocument.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
  • DOM.subproj/WebDOMDocument.m: Removed.
  • DOM.subproj/WebDOMElement.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
  • DOM.subproj/WebDOMElement.m: Removed.
  • DOM.subproj/WebDOMNode.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
  • DOM.subproj/WebDOMNode.m: Removed.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]) (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:])
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:])
  • WebView.subproj/WebFrame.h: Unrelated change. Removed -undoManager accessor from public header. Moved to private header.
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]) (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]) (-[WebFrame undoManager]): Moved -undoManager accessor to private category implementation. (-[WebFormState initWithForm:values:sourceFrame:]) (-[WebFormState form]) (-[WebFrame childFrames])
  • WebView.subproj/WebFramePrivate.h: Moved in -undoManager accessor.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]) (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]) (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]) (-[WebHTMLRepresentation elementWithName:inForm:]) (-[WebHTMLRepresentation elementForView:]) (-[WebHTMLRepresentation elementDoesAutoComplete:]) (-[WebHTMLRepresentation elementIsPassword:]) (-[WebHTMLRepresentation formForElement:]) (-[WebHTMLRepresentation controlsInForm:]) (-[WebHTMLRepresentation searchForLabels:beforeElement:]) (-[WebHTMLRepresentation matchLabels:againstElement:])
  • WebView.subproj/WebHTMLView.m:
  • copy-webcore-files-to-webkit: Added. Copies DOM.h and DOM-compat.h from WebCore when they have been updated there.

WebBrowser:

Reviewed by Chris

Updated usage of DOM SPI to use new names and conventions.

In each case, protocol names for DOM objects were changed from using a
"WebDOM" prefix to a "DOM" prefix, and clients now need only include the
DOM.h header from WebKit to get everything.

  • BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:])
  • Debug/SnippetController.m: (lastNode) (-[SnippetController loadComplete])
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController loginInfoForForm:inFrame:]) (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]) (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]) (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]) (+[FormCompletionController currentFormInFrame:]) (+[FormCompletionController currentFrameAndForm:inWebView:]) (+[FormCompletionController autoFillInWebView:]) (+[FormCompletionController autoFillPasswordInFrame:]) (-[FormCompletionController initWithSourceField:frame:]) (-[FormCompletionController maxStringLength]) (+[AutoFillController autoFillerForFrame:form:create:]) (+[AutoFillController abMatchInFrame:form:fieldName:]) (+[AutoFillController recordABMatch:inFrame:form:fieldName:]) (+[AutoFillController clearAutoFilledView:inFrame:form:]) (-[AutoFillController _fieldNameForAutoFillOfView:rep:]) (-[FormToABBinder abPointerForFieldName:view:rep:foundByPageScan:])

Feb 25, 2004:

8:51 AM Changeset in webkit [6116] by sullivan
  • 8 edits in trunk

WebCore:

WebCore part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tabsToAllControls): now checks for option-tab like tabsToLinks (KWQKHTMLPart::partForWidget): new method, extracted from bridgeForWidget (KWQKHTMLPart::bridgeForWidget): now calls extracted method
  • kwq/KWQButton.mm: (-[KWQButton canBecomeKeyView]): overridden to handle our rules about full keyboard access, different than NSView's rules
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): ditto
  • kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto

WebKit:

WebKit part of fix for <rdar://problem/3546370>: add a way to tab to menus,
checkmarks, and buttons without turning on Full Keyboard Acceess

Reviewed by Ken.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): turn on WebCoreKeyboardAccessFull bit whenever we turn on WebCoreKeyboardAccessTabsToLinks bit

WebBrowser:

  • WebBrowser part of fix for <rdar://problem/3546370>: add a way to tab to menus, checkmarks, and buttons without turning on Full Keyboard Acceess
  • fixed <rdar://problem/3566996>: "Highlight each item" choice in Preferences should use a checkbox and have different wording

Reviewed by Ken.

  • Preferences.subproj/AdvancedPreferences.h:
  • Preferences.subproj/AdvancedPreferences.m: (systemIsInFullKeyboardAccessMode): new function, reads the state of the Full Keyboard Access setting (-[AdvancedPreferences updateTabToAllViews]): set checkbox instead of matrix; new wording for fine print; renamed method (-[AdvancedPreferences keyboardUIModeDidChange:]): notification callback; call updateTabToAllViews (-[AdvancedPreferences toggleTabToAll:]): new method, replaces takeTabToLinksSettingFrom: (-[AdvancedPreferences initializeFromDefaults]): call renamed method (-[AdvancedPreferences moduleWillBeRemoved]): stop observing notification for Full Keyboard Access mode change (-[AdvancedPreferences moduleWasInstalled]): start observing notification for Full Keyboard Access mode change
  • Preferences.subproj/English.lproj/AdvancedPreferences.nib: replace radio buttons with checkbox; rejigger positions
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Feb 24, 2004:

7:21 PM Changeset in webkit [6115] by cblu
  • 1 edit
    3 adds in trunk/WebKit

I forgot to add these files in my last check-in.

  • WebView.subproj/WebResource.h: Added.
  • WebView.subproj/WebResource.m: Added. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _cachedResponseRepresentation]):
  • WebView.subproj/WebResourcePrivate.h: Added.
5:30 PM Changeset in webkit [6114] by cblu
  • 16 edits in trunk/WebKit

Tests:

Added support for WebHTMLPboardType.

Reviewed by rjw.

  • PasteboardViewer/PasteboardViewer.xcode/project.pbxproj:
  • PasteboardViewer/WindowController.m: (-[WindowController pasteboardTypes]): (-[WindowController reflectSelection]):

WebKit:

Fixed: <rdar://problem/3565476>: design/implement new pasteboard type for HTML that includes subresources

Reviewed by rjw.

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate initWithStream:view:]): don't manage buffer, WebBaseResourceHandleDelegate does this now (-[WebNetscapePluginConnectionDelegate releaseResources]): ditto (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate releaseResources]): release resourceData and resource (-[WebBaseResourceHandleDelegate loadWithRequest:]): check the dataSource for a resource, load that if we have one (-[WebBaseResourceHandleDelegate addData:]): new, adds data to resourceData (-[WebBaseResourceHandleDelegate saveResource]): new, saves data as a resource on the dataSource (-[WebBaseResourceHandleDelegate saveResourceWithCachedResponse:]): new, replaces the resource on the dataSource to save memory (-[WebBaseResourceHandleDelegate resourceData]): new (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): call addData: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): call saveResource (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): new, calls saveResourceWithCachedResponse:
  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): release subresources (-[WebDataSource subresources]): new, returns the subresources of the data source (-[WebDataSource subresourceForURL:]): new, returns a resource for a URL (-[WebDataSource addSubresource:]): new (-[WebDataSource addSubresources:]): new (-[WebDataSource _receivedData:]): added an assert (-[WebDataSource _setData:]): replaces the data of the data source (-[WebDataSource initWithRequest:]): create subresources
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadHTMLPropertyList:]): new, loads a frame from an HTML plist (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:]): new, factored out from loadData:MIMEType:textEncodingName:baseURL: (-[WebFrame _loadRequest:subresources:]): new, factored out from loadRequest:, handles subresources (-[WebFrame loadRequest:]): now just calls _loadRequest:subresources:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _dataSource]): new internal convenience (+[WebHTMLView _selectionPasteboardTypes]): renamed from _pasteboardTypes to be more precise (-[WebHTMLView _selectedHTMLPropertyList:]): new, constructs an HTML plist from the selection (-[WebHTMLView _writeSelectionToPasteboard:]): calls _selectedHTMLPropertyList to support WebHTMLPboardType (-[WebHTMLView _pasteHTMLFromPasteboard:]): added support for pasting WebHTMLPboardType (+[WebHTMLView initialize]): call renamed _selectionPasteboardTypes (-[WebHTMLView initWithFrame:]): allow WebHTMLPboardType to be dragged in (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _selectionPasteboardTypes
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): override since the main resource does it's own buffering (-[WebMainResourceClient saveResource]): override to do nothing since the main resource is not saved as a subresource (-[WebMainResourceClient saveResourceWithCachedResponse:]): override, calls _setData on the data source to (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
  • WebView.subproj/WebResource.h: Added.
  • WebView.subproj/WebResource.m: Added. New class the represents the data, URL, MIME type and textEncodingName of a resource. (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:]): (-[WebResource dealloc]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource description]): (+[WebResource _resourcesFromPropertyLists:]): (+[WebResource _propertyListsFromResources:]): (-[WebResource _initWithPropertyList:]): (-[WebResource _propertyListRepresentation]): (-[WebResource _initWithCachedResponse:originalURL:]): (-[WebResource _cachedResponseRepresentation]):
  • WebView.subproj/WebResourcePrivate.h: Added.
  • WebView.subproj/WebView.m:
2:53 PM Changeset in webkit [6113]
  • 9 copies
    2 deletes in tags/WebKit-85~8

This commit was manufactured by cvs2svn to create tag 'WebKit-85~8'.

2:53 PM Changeset in webkit [6112] by vicki
  • 4 edits in branches/Safari-1-0-branch/WebKit
  • roll this change onto the Safari-1-0-branch

2003-08-12 Ed Voas <​voas@apple.com>

Reviewed by Richard.

Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
11:36 AM Changeset in webkit [6111] by darin
  • 4 edits in trunk/WebCore

Tests:

Reviewed by Ken.

  • qt/qstring-test.cpp: (main): Added an endsWith test.
  • qt/qstring-test.chk: Added the expected result.

WebCore:

Reviewed by Ken.

  • kwq/KWQString.mm: (QString::endsWith): Fixed broken end of string test, to get rid of false positives.
  • WebCore-tests.exp: Added endsWith so it can be tested.
  • WebCore-combined.exp: Regenerated.

Feb 23, 2004:

3:33 PM Changeset in webkit [6110] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3549772, hangs on border collapsing.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (RenderObject::collectBorders):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (compareBorders): (RenderTableCell::paint): (addBorderStyle): (RenderTableCell::collectBorders):
  • khtml/rendering/render_table.h:
1:39 PM Changeset in webkit [6109] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/margin-collapse

Adding test for 3560033 fix.

1:31 PM Changeset in webkit [6108] by hyatt
  • 4 edits in trunk/LayoutTests/fast

Updating layout tests to reflect br fixes.

1:26 PM Changeset in webkit [6107] by hyatt
  • 27 edits in trunk/WebCore

Fix for 3558717, make sure that form elements that are removed from a document also remove themselves
from the form.

Reviewed by darin.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::removedFromDocument):
  • khtml/html/html_formimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:

Implement smarter line layout for faster typing and repainting when individual lines change.

Reviewed by kocienda.

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::addRepaintInfo): (KHTMLView::layout):
  • khtml/khtmlview.h:
  • khtml/rendering/bidi.cpp: (khtml::Bidinext): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::constructLine): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::computeVerticalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::determineEndPosition): (khtml::RenderBlock::matchedEndLine): (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::positionNewFloats): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox): (khtml::RenderBlock::setLinesAppended): (khtml::RenderBlock::linesAppended):
  • khtml/rendering/render_box.cpp: (RenderBox::dirtyLineBoxes): (RenderBox::deleteLineBoxWrapper): (RenderBox::setInlineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::createInlineBox): (RenderBR::position):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::placeChild):
  • khtml/rendering/render_flow.cpp: (RenderFlow::extractLineBox): (RenderFlow::attachLineBox): (RenderFlow::removeLineBox): (RenderFlow::dirtyLinesFromChangedChild): (RenderFlow::dirtyLineBoxes): (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.cpp: (InlineBox::dirtyLineBoxes): (InlineBox::deleteLine): (InlineBox::extractLine): (InlineBox::attachLine): (InlineBox::adjustVerticalPosition): (InlineBox::root): (InlineBox::nextOnLineExists): (InlineBox::prevOnLineExists): (InlineFlowBox::removeChild): (InlineFlowBox::deleteLine): (InlineFlowBox::extractLine): (InlineFlowBox::attachLine): (InlineFlowBox::adjustVerticalPosition): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (RootInlineBox::adjustVerticalPosition): (RootInlineBox::childRemoved):
  • khtml/rendering/render_line.h: (khtml::InlineBox::m_extracted): (khtml::InlineBox::setExtracted): (khtml::InlineBox::object): (khtml::InlineBox::parent): (khtml::InlineBox::isDirty): (khtml::InlineBox::markDirty): (khtml::InlineFlowBox::prevFlowBox): (khtml::InlineFlowBox::nextFlowBox): (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::nextRootBox): (khtml::RootInlineBox::prevRootBox): (khtml::RootInlineBox::setLineBreakInfo): (khtml::RootInlineBox::setLineBreakPos): (khtml::RootInlineBox::setBlockHeight): (khtml::RootInlineBox::setEndsWithBreak): (khtml::RootInlineBox::blockHeight): (khtml::RootInlineBox::endsWithBreak): (khtml::RootInlineBox::lineBreakObj): (khtml::RootInlineBox::lineBreakPos):
  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintObjectsBeforeLayout): (RenderObject::dirtyLinesFromChangedChild): (RenderObject::createInlineBox): (RenderObject::dirtyLineBoxes): (RenderObject::setInlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
  • khtml/rendering/render_object.h: (khtml::RenderObject::RepaintInfo::m_repaintRect):
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
  • khtml/rendering/render_text.cpp: (InlineTextBox::deleteLine): (InlineTextBox::extractLine): (InlineTextBox::attachLine): (RenderText::RenderText): (RenderText::detach): (RenderText::extractTextBox): (RenderText::attachTextBox): (RenderText::removeTextBox): (RenderText::setTextWithOffset): (RenderText::setText): (RenderText::dirtyLineBoxes): (RenderText::createInlineBox):
  • khtml/rendering/render_text.h: (khtml::InlineTextBox::start): (khtml::InlineTextBox::end): (khtml::InlineTextBox::offsetRun):
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): (CharacterDataImpl::appendData): (CharacterDataImpl::insertData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData): (TextImpl::splitText):
  • kwq/KWQRenderTreeDebug.cpp: (write):

RenderBlock contains two other fixes. The first is a fix to rightmost/lowestPosition to properly add in
margins to floats.

Reviewed by mjs

The second fix is to repair a bug in block-level replaced elements with margins. If the floats they moved to
dodge can fit in their margins, then they don't technically have to move at all.

Reviewed by john

Feb 20, 2004:

5:06 PM Changeset in webkit [6106] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3552346>: REGRESSION 100-125: nil-dereference in KHTMLPart::isPointInsideSelection (progz.ru, many other sites)

  • khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPointForLayer): To cover the case of positioned generated content, make sure to find an element if we don't have one yet when we get to the layer level.
4:51 PM Changeset in webkit [6105] by vicki
  • 3 edits in trunk

set version from '129' to '130u'. the tree is open!

4:46 PM Changeset in webkit [6104]
  • 3 copies in tags/Safari-129

This commit was manufactured by cvs2svn to create tag 'Safari-129'.

4:46 PM Changeset in webkit [6103] by vicki
  • 6 edits in trunk

Safari-129 stamp

3:53 PM Changeset in webkit [6102] by vicki
  • 2 edits in trunk/WebKit

Reviewed by mjs.

  • fix build breakage caused by removal of kWindowNoBufferingAttribute.
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): always used a retained backing store type
10:57 AM Changeset in webkit [6101] by cblu
  • 27 edits in trunk

Tests:

Reviewed by dave.

  • Blot/BlotDocument.m: (-[BlotDocument dataRepresentationOfType:]): call renamed HTMLString on WebHTMLRepresentation

WebCore:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

  • Added isSubresourceURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to a subresource.
  • Added isURLAttribute to ElementImpl which is overridden by subclasses determine if an attribute refers to any kind of URL.

Reviewed by Dave.

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::isSubresourceURLAttribute): (HTMLFrameElementImpl::isSubresourceURLAttribute): (HTMLIFrameElementImpl::openURL): (HTMLIFrameElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isURLAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::isSubresourceURLAttribute): (HTMLScriptElementImpl::id): (HTMLScriptElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::isSubresourceURLAttribute): (HTMLAreaElementImpl::getRegion): (HTMLAreaElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isURLAttribute):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isSubresourceURLAttribute): (HTMLObjectElementImpl::isSubresourceURLAttribute): (HTMLParamElementImpl::parseHTMLAttribute): (HTMLParamElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::isSubresourceURLAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableCellElementImpl::isSubresourceURLAttribute):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::toHTMLWithOptions): take completeURLs and subresourceURLs arguments (RangeImpl::toHTML): call toHTMLWithOptions with default options
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::isURLAttribute): (ElementImpl::isSubresourceURLAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): take completeURLs and subresourceURLs arguments (NodeImpl::recursive_toHTML): call recursive_toHTML with default options
  • khtml/xml/dom_nodeimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedHTML:]): renamed to return subresource URL strings

WebKit:

Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute

Reviewed by dave.

  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation HTMLString]): renamed from reconstructed source to be more analogous with other data get methods
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed selectedHTML on the bridge

Feb 19, 2004:

3:14 PM Changeset in webkit [6100] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): If shift key is down along with an arrow key, call super rather than eating event since we don't handle any shifted events here.

WebBrowser:

  • fixed <rdar://problem/3292380>: Cycle Tabs keyboard shortcut (cmd-shift-arrows) conflicts with text editing

Reviewed by Chris.

  • BrowserNSEventExtras.h:
  • BrowserNSEventExtras.m: (-[NSEvent isCommandLeftArrowKeyDown]): (-[NSEvent isCommandRightArrowKeyDown]): New methods
  • BrowserWindow.m: (-[BrowserWindow keyDown:]): Still honor old shortcuts of command-shift-arrows, but only if no other view has intercepted them already.
  • English.lproj/MainMenu.nib: Changed keyboard shortcuts for Select Next Tab and Select Previous Tab menu items to option-command-] and [
  • Debug/Shortcuts.html: Updated for these changes

Feb 18, 2004:

4:14 PM Changeset in webkit [6099] by rjw
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_runtime.mm

Fixed Deployment build problem (longjmp clobber warning)

2:30 PM Changeset in webkit [6098] by rjw
  • 3 edits in trunk/JavaScriptCore

Added NSNumber/Number conversion.

Removed some unnecessary KJS
namespace specifiers.

Reviewed by Ken.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime_array.h:
1:58 PM Changeset in webkit [6097] by rjw
  • 11 edits in trunk/JavaScriptCore

Added support for export NSArrays.

Updated valueAt() to take an ExecState so we can throw
JS exceptions.

Implemented excludeSelectorFromJavaScript: in ObjcClass. This allows
ObjectiveC classes to control the visibility of their methods in
JavaScript.

Reviewed by Ken.

  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::ObjcArray): (ObjcArray::~ObjcArray): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (Instance::getValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::get):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):

Feb 17, 2004:

5:56 PM Changeset in webkit [6096] by rjw
  • 4 edits in trunk/JavaScriptCore

Added String <-> NSString conversion.
Added tests of String <-> NSString conversion to test program.

Reviewed by Chris.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • bindings/test.js:
  • bindings/testbindings.mm: (-[MyFirstInterface getString]):
4:45 PM Changeset in webkit [6095] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3537397>: REGRESSION (100-114): Return doesn't work in Japanese input method for some HomePage fields

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Don't send events through DOM when there is marked text. (-[KWQTextAreaTextView keyUp:]): Ditto.
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Ditto. (-[KWQSecureTextField textView:shouldHandleEvent:]): Ditto.
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): No need to check for marked text on "return" any more, because we won't send key events through the DOM at all when there is marked text.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: Removed haveMarkedText method, no longer used by anything.
Note: See TracTimeline for information about the timeline view.