Context Navigation

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Reviewed by John.

Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):

4:32 PM Changeset in webkit [7077] by kocienda

6 edits in trunk

WebCore:

Reviewed by Richard

khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): No longer check whether the command key is modifying the key event. This check is now done elsewhere in the code. See the WebKit checkin that added the _web_keyBindingManagerHasBinding method to WebNSEventExtras.

WebKit:

Reviewed by Richard

Misc.subproj/WebNSEventExtras.h: Added helper that returns whether a key event has a binding in the key binding manager.
Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_keyBindingManagerHasBinding]): New helper mentioned above.
Plugins.subproj/npruntime.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Add a check of whether the key event has a binding in the key binding manager. This works around the fact that NSResponder's interpretKeyEvents does not return a value telling whether or not the key was handled. This now makes it possible for us to trap modified key events we know we can handle (like those command-key + arrow events used for text navigation), while letting all others pass.

4:17 PM Changeset in webkit [7076] by darin

2 edits in branches/Safari-1-2-branch/WebKit

merge this fix from HEAD for SUPanMoccasin and the July Security Update

2004-07-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Chris.

<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).

4:14 PM Changeset in webkit [7075]

20 copies
3 deletes in branches/WebKit-125~4-branch

This commit was manufactured by cvs2svn to create branch
'WebKit-125~4-branch'.

4:14 PM Changeset in webkit [7074]

20 copies
3 deletes in tags/WebKit-125~4-anchor

This commit was manufactured by cvs2svn to create tag
'WebKit-125~4-anchor'.

4:14 PM Changeset in webkit [7073] by darin

2 edits in branches/Safari-1-2-branch/WebKit

merge this fix from HEAD for SUPanMoccasin

2004-07-20 Richard Williamson <rjw@apple.com>

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Reviewed by John.

Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):

3:27 PM Changeset in webkit [7072] by cblu

5 edits in trunk

WebCore:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if there is no image, put the image URL on the element anyway

WebKit:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): if there is no image, but there is an image URL, provide image context menu items besides "Copy Image"
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): don't drag an image with an actual image (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto

WebBrowser:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): if there is no image, but there is an image URL, provide image context menu items besides copy and save menu items.
WebBrowser.pbproj/project.pbxproj:

3:11 PM Changeset in webkit [7071] by hyatt

6 edits in trunk/LayoutTests/fast

Reduced size of error images which affects test and fixed alt scaling bugs.

2:58 PM Changeset in webkit [7070] by mjs

2 edits in trunk/WebKit

Reviewed by Chris.

<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame

Plugins.subproj/npruntime.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).

2:54 PM Changeset in webkit [7069] by hyatt

2 edits in trunk/WebCore

Fix for alt text not working on images.

Reviewed by john

khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::setPixmap): (RenderImage::paint): (RenderImage::calcReplacedWidth): (RenderImage::calcReplacedHeight):

1:45 PM Changeset in webkit [7068] by mjs

3 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3720111> REGRESSION(125-152): map fails to load depending on banner ad; weather.com (works in IE and Firefox)

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): Initialize currentPrependingSrc. (khtml::HTMLTokenizer::scriptHandler): Store a pointer to the currently active prependingSrc variable on the stack, the better to handle weird cases of scripts writing out additional script tags and so forth. (khtml::HTMLTokenizer::write): Deal with the above.
khtml/html/htmltokenizer.h: Declare new member field.

1:41 PM Changeset in webkit [7067] by rjw

4 edits in trunk/WebKit

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Bumped the version of the NP function structures.

Reviewed by John.

Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):
Plugins.subproj/npapi.h:

1:39 PM Changeset in webkit [7066] by hyatt

2 edits
2 adds in trunk/LayoutTests/fast/overflow

Add overflow test and fix rss test to not be rss.

1:35 PM Changeset in webkit [7065] by hyatt

2 edits in trunk/WebCore

Fix for layer positioning error that occurs when absolute positioned blocks are inside static positioned overflow:auto
elements.

Reviewed by john

khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):

12:05 PM Changeset in webkit [7064] by trey

2 edits in trunk/WebKit

3733698 REGRESSION: sometimes dragging photos on homepage.mac.com leads to an assertion

Relax an assertion, as we ran into a valid case where it's not true.

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Removing this assert allows for the oddball case of a drag gesture that starts on one element, but then the element is no longer there when the drag is about to start.

11:56 AM Changeset in webkit [7063] by trey

2 edits in trunk/WebCore

3705624 REGRESSION: can't rearrange photos on homepage.mac.com album

A subtle problem stemming from some interaction between focus handing and
event propagation. We previously made it so when a focus shift fails we
don't propagate the event to KHTML. The fix is to get rid of the inverse
effect, so now even if a focus shift succeeds, we don't propagate to KHTML if
the page already canceled default behavior.

In this specific case, the page is cancelling default behavior since it
does its own dragging, and the bug was our new system dragging was
kicking in.

Reviewed by Ken.

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): What he said.

11:06 AM Changeset in webkit [7062] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3695240> pasting plain text with newlines in it turns them into spaces

kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Refine this function to be smart about converting line endings into BR elements.

8:38 AM Changeset in webkit [7061] by kocienda

9 edits in trunk

WebCore:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3707505> HTMLCompose: blinking cursor in both an address text field and the message body

khtml/khtml_part.cpp: (KHTMLPart::setCaretVisible): This method renamed from setSelectionVisible. Since it really only operates on the caret, this seems like a better name.
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::focusInEvent): Call setCaretVisible(true) (KHTMLView::focusOutEvent): Call setCaretVisible(false)
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setShowsFirstResponder): Name change: setSelectionVisible becomes setCaretVisible.
kwq/WebCoreBridge.h: Expose setCaretVisible as a bridge method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge setCaretVisible:]): Ditto.

WebKit:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3707505> HTMLCompose: blinking cursor in both an address text field and the message body

WebView.subproj/WebHTMLView.m: (-[WebHTMLView setCaretVisible:]): New helper. Calls over bridge to do the work. (-[WebHTMLView windowDidBecomeKey:]): This function cannot just assume that self is first responder (and do things like adjusting text background color and restoring focus rings). First-responder-ness needs to be checked first. Now it is. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView becomeFirstResponder]): Call new helper to make caret visible. (-[WebHTMLView resignFirstResponder]): Call new helper to make caret invisible.

1:12 AM Changeset in webkit [7060] by mjs

4 edits in trunk/WebCore

Reviewed by Trey.

<rdar://problem/3721428> REGRESSION (125.8-146): external javascript statements produce extra garbage character (sina.com)

khtml/misc/stringit.h: (khtml::TokenizerSubstring::TokenizerSubstring): For the apple branch, use the new stableUnicode() method to get the unicode pointer.
kwq/KWQString.h:
kwq/KWQString.mm: (QString::detachIfInternal): Reorganize this to be a bit less wacky about refcounts. It does not leave around a zombie internal data handle but rather destroys it right away, and leaves the object pointing to the new handle (which it can then deref). This makes the code more clear. (QString::~QString): Simplify. (QString::stableUnicode): New method that detaches a copy of the KWQStringData if it is internal to a string besides this one. This guarantees that if you get the unicode() pointer, it won't go bad so long as this string is still alive.

Jul 19, 2004:

4:43 PM Changeset in webkit [7059] by sullivan

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

bulletproofed array.slice() against NAN arguments. Harri noticed this vulnerability in my patch for 3714644

kjs/array_object.cpp: (ArrayProtoFuncImp::call): handle NAN parameters passed to slice() by clamping to 0 and length.

4:34 PM Changeset in webkit [7058] by hyatt

2 adds in trunk/LayoutTests/fast/dynamic

* empty log message *

4:33 PM Changeset in webkit [7057] by hyatt

2 edits in trunk/WebCore

Fix for 3715117, crash from a bug in removeChildren. Clean up node removal and fix an n-squared removal
bug. Also clean up checks in removeChild and in the dispatch of removedFromDocument mutation events to
make node removal more efficient.

Reviewed by kocienda

khtml/xml/dom_nodeimpl.cpp:

3:40 PM Changeset in webkit [7056] by sullivan

2 edits in trunk/WebCore

Reviewed by Trey.

fixed <rdar://problem/3141150> can't undo in form textarea fields

kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): call setAllowsUndo:YES. My, wasn't this easy?

3:32 PM Changeset in webkit [7055] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3733349. Prevent Java applet callbacks into JavaScript after applet
has been destroyed.

Reviewed by John.

bindings/jni/jni_jsobject.cpp: (JSObject::invoke): (JSObject::JSObject):

3:32 PM Changeset in webkit [7054] by rjw

3 edits in trunk/WebKit

Fixed 3721917. The RealPlayer plugin doesn't support the new
NPPVpluginScriptableNPObject variable passed to NPP_GetValue and
incorrectly returns NPERR_NO_ERROR. We interpret this to the
mean the variable has been set. The variable has not been set
and will consequently be uninitialized.

Reviewed by NOBODY (OOPS!).

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]):

2:50 PM Changeset in webkit [7053] by hyatt

4 edits in trunk

Merge @import fix for CSS1 test suite from Stephan Kulow.

Reviewed by hyatt

khtml/css/parser.cpp:
khtml/css/parser.y:
layout-tests/css1/basic/containment-expected.txt:

2:40 PM Changeset in webkit [7052] by hyatt

5 edits in trunk/WebCore

Fix for 3718697, crash clicking on JS tab at alaskaair.com.

Reviewed by kocienda

khtml/rendering/render_flow.cpp: (RenderFlow::detach): (RenderFlow::dirtyLinesFromChangedChild):
khtml/rendering/render_flow.h:
khtml/rendering/render_object.cpp: (RenderObject::dirtyLinesFromChangedChild):
khtml/rendering/render_object.h:

1:58 PM Changeset in webkit [7051] by kocienda

5 edits in trunk/WebKit

Reviewed by Richard

Fix for this bug:

<rdar://problem/3707504> HTMLCompose: key events are stolen by Web(HTML)View

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView firstResponderIsSelfOrDescendantView]): New helper to (-[WebHTMLView performKeyEquivalent:]): Do not pass key events through to the editing key handler unless the WebHTMLView is first responder or contains the first responder. This prevents the "stealing" of key events mentioned in the bug.
WebView.subproj/WebView.m: (-[WebView _performResponderOperation:with:]): Uses the new firstResponderIsSelfOrDescendantView helper. The code I replaced used the same logic as the new helper.

Jul 17, 2004:

9:59 PM Changeset in webkit [7050]

63 copies
2 deletes in tags/WebCore-125~8

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8'.

9:59 PM Changeset in webkit [7049] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

versioning for next SUPanMoccasin submission (SAP fixes), WebCore-125.8

9:57 PM Changeset in webkit [7048] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

Roll this Security Update change out for the next SUPanMoccasin
submission. Security Update changes can't be included in Software
Updates.

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

Jul 16, 2004:

3:56 PM Changeset in webkit [7047] by sullivan

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed <rdar://problem/3714644> REGRESSION (125.8-146): bugzilla submit link hangs browser with javascript

kjs/array_object.cpp: (ArrayProtoFuncImp::call): Check for undefined type for args[0] the same way we were already checking for args[1]. In this case, args was zero-length, but we were treating args[0] like an integer anyway. Resulted in some code looping from a NAN value to 4, taking approximately forever.

JavaScriptCore.pbproj/project.pbxproj: version wars

3:20 PM Changeset in webkit [7046] by hyatt

2 edits in trunk/WebCore

Fix for 3726471, need to ensure that it's safe to do updateRendering from within layout, since isContentEditable
relies on it. The fix is to just recalcStyle up front before beginning the layout, so that all of our renderobjects
will be up-to-date.

Reviewed by john

khtml/khtmlview.cpp: (KHTMLView::layout):

2:51 PM Changeset in webkit [7045] by adele

3 edits in branches/Safari-1-2-branch/WebCore

Reviewed by vicki.

merge these changes from HEAD for SUPanMoccasin, 3730021

2004-07-06 Ken Kocienda <kocienda@apple.com>

Reviewed by me

khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): Added a better comment in the code I just checked in a few minutes ago.

2004-07-06 Ken Kocienda <kocienda@apple.com>

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply
due to non-0 exception code trying to insert a DIV markup string

The solution was to revert to the code that was rolled out, and removing
the child checks from NodeImpl::checkAddChild. However, this time, I added
code very similar to this check into the code that runs while HTML is
being parsed to build up tables. This code relies on child-add failure
to ensure the proper construction of well-formed tables (as gross as that
sounds), so the check needs to be retained there. No other code seems to
be so affected. Layout tests are unchanged by this patch.

khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild):

2:29 PM Changeset in webkit [7044] by adele

2 edits in branches/Safari-1-2-branch/WebCore

Reviewed by vicki.

merge this change from HEAD for SUPanMoccasin, 3730017

2004-07-14 David Hyatt <hyatt@apple.com>

Fix for 3595073, setting innerHTML on a <table> should work.

Reviewed by rjw

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):

2:19 PM Changeset in webkit [7043] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3722153> Random crash while typing (DOM::NodeImpl::parentNode (this=0x0))

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): This check merely makes the code more robust. I do not understand how Grant ended up with null start or end blocks in the case of his bug report, but by adding two null checks, the code is now hardened a bit in case it happens again.

2:14 PM Changeset in webkit [7042] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for these bugs:

<rdar://problem/3730785> Crash when arrow navigation goes to empty table cell
<rdar://problem/3730790> Caret does not blink when placed in empty table cell

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Caret node's renderer might be this block, so don't block the painting of the caret in this case. This was the case in 3730790. We had the right geometry for the caret but blocked its painting.
khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): Rework the logic here. This function asserted that the new position we would navigate to had a line box, but empty table cells, for instance will not. So, deal with this situation as well. The end result is a function that worked like it did before in cases where the previous line position has a line box, but now also will allow navigation to work when it does not. (DOM::Position::nextLinePosition): Ditto.

1:37 PM Changeset in webkit [7041] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3687216> editable inline causes crash when focused

khtml/xml/dom_docimpl.cpp: (DocumentImpl::relinquishesEditingFocus): Add null check for rootEditableElement. (DocumentImpl::acceptsEditingFocus): Ditto.

1:25 PM Changeset in webkit [7040] by hyatt

2 edits in trunk/LayoutTests

Return Panther baseline to layout tests.

1:17 PM Changeset in webkit [7039] by hyatt

2 adds in trunk/LayoutTests/fast/compact

Add a layout test for the crashing compact case.

1:15 PM Changeset in webkit [7038] by hyatt

2 edits in trunk/WebCore

Fix for 3709337, crash when using display: compact. Need to make sure that the isCompact() check in bidi.cpp is
also checking for RenderBlocks, since otherwise you match text nodes (and that's just wrong).

Reviewed by kocienda

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):

11:00 AM Changeset in webkit [7037] by vicki

3 edits in trunk

change version number to '153u'. the tree is open!

10:55 AM Changeset in webkit [7036]

3 copies in tags/Safari-152

This commit was manufactured by cvs2svn to create tag 'Safari-152'.

10:55 AM Changeset in webkit [7035] by vicki

6 edits in trunk

Safari-152 stamp

Jul 15, 2004:

5:05 PM Changeset in webkit [7034] by hyatt

2 edits in trunk/WebCore

Fix for 3625611, images offset on first visit to page. The method for determining the last clean line was
flawed and would incorrectly miss dirty lines that occurred after the first clean line.

Reviewed by john

khtml/rendering/bidi.cpp: (khtml::RenderBlock::determineEndPosition):

10:20 AM Changeset in webkit [7033] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:
<rdar://problem/3587601> reproducible assertion failure in Blot deleting text, then image at Yahoo.com

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteCollapsibleWhitespaceCommandImpl::deleteWhitespace): Relax assertion that nodes are text nodes during the walk of eligible nodes that could possibly be deleted. Change the assertion to an conditional check for text nodes. We may have unrendered nodes in the mix here (as is the case in the bug where the assertion failed on an AREA element), and the conditional check is sufficient to skip them while leaving the delete logic we want unperturbed.

Jul 14, 2004:

5:14 PM Changeset in webkit [7032] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/3711474>: (REGRESSION (125-146): JavaScript 'toString(16)' is broken)
<rdar://problem/3644873>: (REGRESSION (125-140u): secondary list doesn't fill in at Southwest.com)

kjs/number_object.cpp: (NumberProtoFuncImp::call): Initialize radix from dradix, not from itself!

4:35 PM Changeset in webkit [7031] by kocienda

2 edits in trunk/WebCore

Reviewed by John

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Add null check on DOM node before asking if it is contentEditable.

4:03 PM Changeset in webkit [7030] by hyatt

2 edits in trunk/WebCore

Fix for 3595073, setting innerHTML on a <table> should work.

Reviewed by rjw

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):

2:45 PM Changeset in webkit [7029] by kocienda

5 edits in trunk

Reviewed by Hyatt

Updated these layout tests as a result of the last patch.
These results are better.

layout-tests/editing/execCommand/selectAll-expected.txt
layout-tests/editing/selection/extend-by-character-006-expected.txt
layout-tests/editing/selection/unrendered-001-expected.txt
layout-tests/editing/selection/unrendered-003-expected.txt

2:43 PM Changeset in webkit [7028] by kocienda

10 edits in trunk/WebCore

Reviewed by Hyatt

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Change back to start() from caretPosition(). Since the policy is now to move the selection to rendered content, if possible, when the selection is set, there is no longer any reason to have the additional caretPosition() function to store where the caret should be drawn.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): No longer any need to call closestRenderedPosition here. This is done in Selection::validate.
khtml/xml/dom_position.cpp: (DOM::Position::closestRenderedPosition): Improved algorithm. Now much simpler.
khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): caretPosition() and m_caretPosition now obsolete. (DOM::Selection::init): Ditto. (DOM::Selection::modifyExtendingRightForward): No longer any need to call closestRenderedPosition here. This is done in Selection::validate. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::layoutCaret): Ditto. (DOM::Selection::validate): Add code to move the selection to rendered content if possible.
khtml/xml/dom_selection.h: caretPosition() and m_caretPosition now obsolete.

2:01 PM Changeset in webkit [7027] by hyatt

2 adds in trunk/LayoutTests/fast/dynamic

Add layout test for dynamic float/position change.

1:13 PM Changeset in webkit [7026] by hyatt

2 edits in trunk/WebCore

Fix for 3716082, assert when you dynamically remove float or position styles.

Reviewed by kevin

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

12:56 PM Changeset in webkit [7025] by hyatt

2 adds in trunk/LayoutTests/fast/table

new layout test to cover percentage heights inside auto tables.

12:49 PM Changeset in webkit [7024] by hyatt

4 edits in trunk/WebCore

Fix for various table regressions (malumovies.com and cityofheroes.gameamp.com) involving bungling of
percentage heights.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing):
khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableCell::updateFromElement):
khtml/rendering/render_table.h:

12:48 PM Changeset in webkit [7023] by kocienda

3 edits in trunk/WebCore

Reviewed by John

khtml/xml/dom_position.cpp: (DOM::Position::equivalentDeepPosition): New helper function to improve selection handling. Soon, I plan to land some changes that use this new function.
khtml/xml/dom_position.h:

10:32 AM Changeset in webkit [7022] by kocienda

3 edits in trunk/WebCore

Reviewed by Vicki

WebCore-combined.exp: Added QString.at symbol to tests exports to facilitate debugging data formatting change that is to come.
WebCore-tests.exp:

Jul 13, 2004:

10:27 PM Changeset in webkit [7021] by kdecker

1 edit
2 adds in trunk/JavaScriptCore/tests/mozilla

Reviewed by mjs

Modified the test driver to spew out each test as it processes it. This is such a good thing to see from a performance perspective because it illustrates which tests JavaScriptCore chokes heavily.

5:57 PM Changeset in webkit [7020] by kdecker

2 adds in trunk/JavaScriptCore/tests/mozilla/Getopt

added a necessary support library for jsDriver.pl

5:38 PM Changeset in webkit [7019] by kdecker

1 edit
12 adds in trunk/LayoutTests/editing

* empty log message *

4:21 PM Changeset in webkit [7018] by kdecker

1 edit in trunk/JavaScriptCore/tests/mozilla/jsDriver.pl

Reviewed by mjs

added support for the kjs engine type

4:00 PM Changeset in webkit [7017] by kdecker

2 edits in trunk/JavaScriptCore

Reviewed by kocienda.

made testkjs and JavaScriptCore a subtarget of 'All'
testkjs now builds in $SYMROOTS

JavaScriptCore.pbproj/project.pbxproj:

2:50 PM Changeset in webkit [7016] by sullivan

3 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3705500> REGRESSION (125.8-146): Cmd-E on an HTML page puts a trailing space on Find pasteboard

khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::handleTextBox): In the case where a subrun doesn't extend to the end of the text box, the well-commented code was supposed to return from this routine, but the wrong variable was being compared. This would send us through another pass of the loop, which would end up worrying about collapsed space at the end of the current box, even though we only cared about the beginning of the current box.

Jul 12, 2004:

11:40 PM Changeset in webkit [7015] by mjs

3 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/3673988>: (REGRESSION(141-144): connection assertion failure at http://traffic.511.org/sfgate)

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Don't check connection consistency if this load got cancelled while finishing, because in this case we have cleared the connection field already. This can happen when a redirect fires from an onload handler.

5:26 PM Changeset in webkit [7014] by mjs

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)

Misc.subproj/WebIconLoader.m: (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't want an auth panel for favicons. (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring the challenge.

4:57 PM Changeset in webkit [7013]

12 copies
2 deletes in tags/WebCore-85~6~1

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~1'.

4:57 PM Changeset in webkit [7012] by vicki

2 edits in branches/Safari-1-0-branch/WebCore

fix CFBundleShortVersionString in WebCore. This should be 1.0.2, the Safari marketing version for the last update on Jaguar.

4:33 PM Changeset in webkit [7011] by rjw

2 edits in trunk/WebCore

Fixed 3717982. Implemented navigator.language!

Reviewed by John.

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):

4:01 PM Changeset in webkit [7010] by kdecker

2 adds in trunk/LayoutTests/fast/css

Reviewed by Dave

Added a layout test for css 'width:auto'

3:58 PM Changeset in webkit [7009] by hyatt

2 edits in trunk/WebCore/khtml/rendering

Back out my changes to the fix for my previous checkin, since it broke the inline-block layout test.

3:30 PM Changeset in webkit [7008] by kocienda

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by me

Remove cvs conflict indicators from ChangeLog

3:29 PM Changeset in webkit [7007] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent): I broke selection drawing with my last patch. This function is now used in selection drawing, and it was making an unneeded check to see that content was editable to answer whether or not is was rendered. Bad. Fixed.

3:26 PM Changeset in webkit [7006] by hyatt

3 edits in trunk/WebCore

Fix for 3621138, crash on hrweb.apple.com. Make sure that in the case where objects get pulled up from merging
blocks that we just delete all line boxes.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):

3:03 PM Changeset in webkit [7005] by mjs

3 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3706080>: (REGRESSION (125.8-147u): Nested <ul> do not display bullets)
<rdar://problem/3676376>: (Second level bullets not printed when printing Xcode release notes)

kwq/KWQPainter.h:
kwq/KWQPainter.mm: (CGColorFromNSColor): (QPainter::drawEllipse): (QPainter::setShadow):

2:57 PM Changeset in webkit [7004] by kocienda

1 edit
20 adds in trunk

Reviewed by me

Added new editing-related layout tests

layout-tests/editing/deleting/delete-after-span-ws-001-expected.txt: Added.
layout-tests/editing/deleting/delete-after-span-ws-001.html: Added.
layout-tests/editing/deleting/delete-after-span-ws-002-expected.txt: Added.
layout-tests/editing/deleting/delete-after-span-ws-002.html: Added.
layout-tests/editing/deleting/delete-after-span-ws-003-expected.txt: Added.
layout-tests/editing/deleting/delete-after-span-ws-003.html: Added.
layout-tests/editing/selection/unrendered-001-expected.txt: Added.
layout-tests/editing/selection/unrendered-001.html: Added.
layout-tests/editing/selection/unrendered-002-expected.txt: Added.
layout-tests/editing/selection/unrendered-002.html: Added.
layout-tests/editing/selection/unrendered-003-expected.txt: Added.
layout-tests/editing/selection/unrendered-003.html: Added.
layout-tests/editing/selection/unrendered-004-expected.txt: Added.
layout-tests/editing/selection/unrendered-004.html: Added.
layout-tests/editing/selection/unrendered-005-expected.txt: Added.
layout-tests/editing/selection/unrendered-005.html: Added.
layout-tests/traversal/node-iterator-008-expected.txt: Added.
layout-tests/traversal/node-iterator-008.html: Added.
layout-tests/traversal/tree-walker-005-expected.txt: Added.
layout-tests/traversal/tree-walker-005.html: Added.

2:51 PM Changeset in webkit [7003] by kocienda

7 edits in trunk/WebCore

Reviewed by Hyatt

Fixes for these bugs:

<rdar://problem/3723359> Extending then "unextending" selection with arrow keys should draw caret but doesn't
<rdar://problem/3724626> White-space deletion code deletes wrong character when space follows span

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): Modify special-case white-space deletion code so it runs only in the special case. It was throwing its net too widely, catching the case described in 3724626. By tightening up the special-case white-space deletion, and allowing the more general-purpose code to run, the bug is fixed.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Use recently-added closestRenderedPosition helper in Position class to figure out the start and end positions for selection drawing.
khtml/xml/dom_position.cpp: (DOM::Position::equivalentUpstreamPosition): Added code to handle white-space that causes line breaks. (DOM::Position::equivalentDownstreamPosition): Ditto. (DOM::Position::closestRenderedPosition): Trap empty selections at function entry, return *this. (DOM::Position::isFirstRenderedPositionOnLine): Can't be first rendered position on line if not rendered. Add check for this. (DOM::Position::isLastRenderedPositionOnLine): Ditto, but s/first/last/
khtml/xml/dom_selection.cpp: (DOM::Selection::validate): A selection is in caret state if the start and end are equal *or* equivalent. The equivalence case is new, and fixes 3723359.

1:13 PM Changeset in webkit [7002] by hyatt

4 edits in trunk/LayoutTests/fast

Fix the fast layout tests.

12:02 AM Changeset in webkit [7001]

9 copies
2 deletes in tags/WebKit-85~7~1

This commit was manufactured by cvs2svn to create tag
'WebKit-85~7~1'.

12:02 AM Changeset in webkit [7000]

9 copies
2 deletes in branches/WebKit-85~7-branch

This commit was manufactured by cvs2svn to create branch
'WebKit-85~7-branch'.

12:02 AM Changeset in webkit [6999]

9 copies
2 deletes in tags/WebKit-85~7-anchor

This commit was manufactured by cvs2svn to create tag
'WebKit-85~7-anchor'.

12:02 AM Changeset in webkit [6998] by vicki

2 edits in branches/Safari-1-0-branch/WebKit

fix CFBundleShortVersionString in WebKit. This should be 1.0.2, the Safari marketing version for the last update on Jaguar, not 1.0.3, which is the "Macromedia fixes" version that has not yet shipped

Jul 11, 2004:

11:49 PM Changeset in webkit [6997] by vicki

2 edits in branches/Safari-1-0-branch/WebKit

versioning for July Security Update (WebKit-85.7.1), and a bit of cleanup to the Changelog. We had already rolled a fix for Safari 1.0.3 to the branch, but do not want to include this in the Security Update.

Jul 9, 2004:

5:04 PM Changeset in webkit [6996] by vicki

2 edits in branches/Safari-1-0-branch/WebKit

merge these two fixes from HEAD for July 2004 Security Update

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge

2004-07-06 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto

4:50 PM Changeset in webkit [6995] by kdecker

4 edits in trunk

Reviewed by Hyatt.

fixes the width:auto problem in
<rdar://problem/3698344> REGRESSION (143?-144): macrumors.com tabs are compressed and illegible

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):

4:41 PM Changeset in webkit [6994] by vicki

2 edits in branches/Safari-1-0-branch/WebCore

WebCore versioning for July 2004 Security Update, WebCore-85.6.1

4:29 PM Changeset in webkit [6993] by vicki

3 edits in branches/Safari-1-0-branch/WebCore

merge this fix from HEAD, so that the July 2004 Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

4:23 PM Changeset in webkit [6992] by kocienda

3 edits in trunk

Reviewed by me

Updated some layout test results.

layout-tests/editing/deleting/delete-image-004-expected.txt:
layout-tests/editing/selection/extend-by-character-006-expected.txt:

3:10 PM Changeset in webkit [6991]

21 copies
3 deletes in tags/WebKit-125~3~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~3~1'.

3:10 PM Changeset in webkit [6990] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

WebKit versioning for July Security Update, WebKit-125.3.1

3:06 PM Changeset in webkit [6989]

61 copies
2 deletes in tags/WebCore-125~7~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~7~1'.

3:06 PM Changeset in webkit [6988] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

WebCore versioning for July Security Update, WebCore-125.7.1

2:56 PM Changeset in webkit [6987] by vicki

5 edits in branches/Safari-1-2-branch

WebCore:

merge this fix from HEAD so that July Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

WebKit:

merge this fix from HEAD so that the fix for the July Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge

2:46 PM Changeset in webkit [6986] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge this fix from HEAD for July Security Update, 3717262

2004-07-06 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto

2:24 PM Changeset in webkit [6985] by cblu

5 edits in trunk

WebCore:

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

WebKit:

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge

11:31 AM Changeset in webkit [6984] by kocienda

12 edits in trunk/WebCore

Reviewed by Hyatt

Some improvements to fix:

<rdar://problem/3723111> Caret not drawn when selection set to unrendered content

khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::issueCommandForDeleteKey): Adjust selection to delete if selected position is not rendered.
khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Use new caretPosition() function on Selection to figure out whether to paint.
khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): Now correctly deals with a start position that is not rendered. (DOM::Position::nextCharacterPosition): Ditto. (DOM::Position::closestRenderedPosition): New helper.
khtml/xml/dom_position.h: (DOM::): Moved in EAffinity from Selection header. Now used in closestRenderedPosition function.
khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Added new m_caretPosition member. This is the position of the caret after a caret layout. This may be different from start or end if start and end are not rendered. (DOM::Selection::init): (DOM::Selection::modifyExtendingRightForward): New helper to clean up modify() and make it more readble. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Use new helpers to make this more readble. (DOM::Selection::layoutCaret): Uses new closestRenderedPosition helper to place the caret if in unrendered content. (DOM::Selection::paintCaret): Remove moveToRenderedContent. obsolete.
khtml/xml/dom_selection.h: (DOM::Selection::caretPosition): New accessor.
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): EAffinity no longer a member enum of Selection class.

10:40 AM Changeset in webkit [6983] by kocienda

2 edits in trunk/WebKit

Reviewed by John

Plugins.subproj/npruntime.h: Updated license to lawyer-approved joint Apple-Mozilla BSD-style license.

Jul 8, 2004:

3:54 PM Changeset in webkit [6982] by hyatt

2 edits in trunk/WebCore

Fix for the table layout test that failed because of a change in how innerText worked. We need to do
updateLayout now when using innerText, since the method has been changed to use line boxes in the render tree
that might otherwise be out of date.

Reviewed by kocienda

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText):

2:31 PM Changeset in webkit [6981] by sullivan

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3691569> REGRESSION (142): cmd-shift-clicking on a link now also extends selection (even if there wasn't one before)

khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick): if there's a URL associated with the event, don't extend the selection

2:08 PM Changeset in webkit [6980] by kocienda

19 edits in trunk/WebCore

Reviewed by Vicki

Added some helper functions which provide strings to display in the
Xcode debugger's variable inspector window. These functions are called
from the LabyrinthDataFormatter debugger plugin I just checked in to
the Labyrinth/Tools directory.

Note that these functions are compiled in on Development builds only.

WebCore-combined.exp:
WebCore-tests.exp: Export all the formatForDebugger symbols so the debugger program can link with them.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::formatForDebugger):
khtml/xml/dom2_rangeimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::formatForDebugger):
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_position.cpp: (DOM::Position::formatForDebugger):
khtml/xml/dom_position.h:
khtml/xml/dom_selection.cpp: (DOM::Selection::formatForDebugger):
khtml/xml/dom_selection.h:
khtml/xml/dom_textimpl.cpp: (TextImpl::formatForDebugger):
khtml/xml/dom_textimpl.h:

2:01 PM Changeset in webkit [6979] by sullivan

2 edits in trunk/WebCore

Reviewed by Vicki.

fixed <rdar://problem/3721544> crash increasing font size; entrezeroetun.com (works in IE and Firefox)

khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter): Check for nil originalString() before dereffing

1:49 PM Changeset in webkit [6978] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3720728> REGRESSION (125.8-146): Crash moving mouse over plugin at manray-photo.com

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): don't call NPP_GetValue unless the plug-in implements it

1:28 PM Changeset in webkit [6977] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3706296> VIP: ifilm.com crashing reproducibly with Safari

Reviewed by kocienda.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): don't release a NULL appURL

1:22 PM Changeset in webkit [6976] by hyatt

2 edits in trunk/WebCore

Fix for 3721453, CSS3 initial property caused crashes because the macros were not written correctly.

Reviewed by john

khtml/css/cssstyleselector.cpp:

12:33 PM Changeset in webkit [6975] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3650140> reproducible assertion failure going to plugin page with JavaScript disabled

Reviewed by john.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): don't call NPP_NewStream and other stream methods if there is no JS result to deliver. This is what Mozilla does. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Return NPERR_GENERIC_ERROR if JS is disabled. This is what Mozilla does.

11:46 AM Changeset in webkit [6974] by vicki

3 edits in trunk

change the version number from '151' to '152u'

11:38 AM Changeset in webkit [6973]

3 copies in tags/Safari-151

This commit was manufactured by cvs2svn to create tag 'Safari-151'.

11:38 AM Changeset in webkit [6972] by vicki

6 edits in trunk

Safari-151 stamp!

Jul 7, 2004:

4:24 PM Changeset in webkit [6971] by hyatt

4 edits in trunk/WebCore

Fix for 3712133, crash from first-line pseudo-style use.

Reviewed by kocienda

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement):
khtml/css/cssstyleselector.h:
khtml/rendering/render_object.cpp: (RenderObject::getPseudoStyle):

2:36 PM Changeset in webkit [6970] by trey

2 edits in trunk/WebKit

3719051 - Safari doesn't update form inputs when a page was refreshed by javascript window.location
... and at least 5 other cases in Radar

Very similar problem to the Harvard PIN bug. We need to be sure
to not carry any state over when we are processing a client
redirect, which reuses the same WebHistoryItem.

Reviewed by John.

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Comment (-[WebFrame _opened]): Clear form and scroll state on client redirect.

1:13 PM Changeset in webkit [6969] by kocienda

5 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3716479> calling setInnerHTML during a webViewDidChange delegate call causes a crash

The fix involves some rearrangement of code in TypingCommand and TypingCommandImpl.
Formerly, new TypingCommands would apply themselves (which was a no-op) and then
do their action in some code a way different than other commands. This type of command
application is different than for all other commands since TypingCommands can be coalesced.
The crash occurred as a result of the "no-op" TypingCommand having the unconsidered
consequence of causing editing delegate notifications to be sent before the command
has actually run. This change takes a small step towards making TypingCommandImpl function like
other commands, where the command work is done in doApply. This makes the notification
happen in the right order.

khtml/editing/htmlediting.cpp: (khtml::TypingCommand::TypingCommand): (khtml::TypingCommand::insertText): (khtml::TypingCommand::insertNewline): (khtml::TypingCommand::deleteKeyPressed):
khtml/editing/htmlediting.h: (khtml::TypingCommand::):
khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::TypingCommandImpl): (khtml::TypingCommandImpl::doApply):
khtml/editing/htmlediting_impl.h:

Jul 6, 2004:

4:11 PM Changeset in webkit [6968] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto

3:18 PM Changeset in webkit [6967] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): Added a better comment in the code I just checked in a few minutes ago.

3:07 PM Changeset in webkit [6966] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply
due to non-0 exception code trying to insert a DIV markup string

The solution was to revert to the code that was rolled out, and removing
the child checks from NodeImpl::checkAddChild. However, this time, I added
code very similar to this check into the code that runs while HTML is
being parsed to build up tables. This code relies on child-add failure
to ensure the proper construction of well-formed tables (as gross as that
sounds), so the check needs to be retained there. No other code seems to
be so affected. Layout tests are unchanged by this patch.

khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild):

10:58 AM Changeset in webkit [6965] by kocienda

5 edits in trunk/WebCore

Reviewed by John

Simple change. I switched the arguments of the appendNode helper function
and the AppendNodeCommand and AppendNodeCommandImpl classes. The node to
insert now comes before the parent node in the argument list. I did this
to make this function match the convention of others in the HTML editing code.
This was the only one that was "different" in the way that it ordered arguments.
As a result, I was always looking to see that I was passing things in the right
order.

khtml/editing/htmlediting.cpp: (khtml::AppendNodeCommand::AppendNodeCommand): (khtml::AppendNodeCommand::appendChild): (khtml::AppendNodeCommand::parentNode):
khtml/editing/htmlediting.h:
khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::insertNodeAfter): (khtml::CompositeEditCommandImpl::insertNodeAt): (khtml::CompositeEditCommandImpl::appendNode): (khtml::AppendNodeCommandImpl::AppendNodeCommandImpl): (khtml::AppendNodeCommandImpl::~AppendNodeCommandImpl): (khtml::AppendNodeCommandImpl::doApply): (khtml::AppendNodeCommandImpl::doUnapply): (khtml::ApplyStyleCommandImpl::surroundNodeRangeWithElement): (khtml::DeleteSelectionCommandImpl::doApply): (khtml::InputNewlineCommandImpl::insertNodeAfterPosition): (khtml::InputNewlineCommandImpl::insertNodeBeforePosition): (khtml::InputTextCommandImpl::prepareForTextInsertion):
khtml/editing/htmlediting_impl.h: (khtml::AppendNodeCommandImpl::parentNode):

10:04 AM Changeset in webkit [6964] by kocienda

3 edits in trunk/WebCore

Reviewed by Trey

Fixed several problems with traversal classes. For one, NodeIterators treat
FILTER_REJECT and FILTER_SKIP the same, since it treats the DOM tree as a
flat collection of nodes free of hierarchy. The code before this change did
not do this correctly. It sure pays to go back and read the specs. :)

Also, the code to traverse from node to node when filters were applied was
not working correctly. My first attemmpt to implement this was just plain
buggy, as I discovered when I tried to write tests for my WWDC talk. I have
settled on an implementation which is much simpler and worked for all the
tests I threw at it.

khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::findNextNode): (DOM::NodeIteratorImpl::nextNode): (DOM::NodeIteratorImpl::findPreviousNode): (DOM::NodeIteratorImpl::previousNode): (DOM::TreeWalkerImpl::parentNode): (DOM::TreeWalkerImpl::firstChild): (DOM::TreeWalkerImpl::lastChild): (DOM::TreeWalkerImpl::previousSibling): (DOM::TreeWalkerImpl::nextSibling): (DOM::TreeWalkerImpl::previousNode): (DOM::TreeWalkerImpl::nextNode): (DOM::TreeWalkerImpl::ancestorRejected):
khtml/xml/dom2_traversalimpl.h:

9:45 AM Changeset in webkit [6963] by sullivan

2 edits in trunk/WebKit

Reviewed by Trey.

fixed <rdar://problem/3717147> folder icon used for error page in back/forward menu when iTunes is not installed

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): When displaying the error page for an unreachable URL, leave the requested URL in the WebHistoryItem; don't clobber it with a bogus one that represents the error page. This not only avoids the wrong-icon problem, but should also help in cases where an unreachable URL becomes reachable later on.

9:23 AM Changeset in webkit [6962] by vicki

2 edits in trunk

Reviewed by kocienda.

added backColorCommand, foreColorCommand, fontNameCommand, and fontSizeCommand

layout-tests/editing/editing.js:

9:13 AM Changeset in webkit [6961] by trey

8 edits in trunk

WebCore:

3716053 - www.theage.com.au has extra back/forward items due to ads

This turned out to be easily fixed by generalizing the fix to 3438441. We prevent
addition to the b/f list not just during an onload event, but during any non-user
gesture, which includes top level script executing.

Reviewed by Richard.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Only real change - prevent adding to b/f list if not a user gesture. (KWQKHTMLPart::openURLRequest): Rename "onLoadEvent" to "userGesture", swap sense (KWQKHTMLPart::submitForm): Ditto (KWQKHTMLPart::urlSelected): Ditto
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Ditto
kwq/WebCoreBridge.h:

WebKit:

3716053 - www.theage.com.au has extra back/forward items due to ads

The real change was in WebKit. Here was are just renaming a method and folding
all the WebFrameLoadTypeOnLoadEvent uses to be WebFrameLoadTypeInternal, since there
was never any difference anyway.

Reviewed by Richard

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): rename part of the method.
WebView.subproj/WebFrame.m: Nuke WebFrameLoadTypeOnLoadEvent. (-[WebFrame _transitionToCommitted:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _itemForRestoringDocState]):
WebView.subproj/WebFramePrivate.h:

8:46 AM Changeset in webkit [6960] by kocienda

2 edits in trunk/WebKit

Reviewed by Trey

Only register the editing delegate for those notifications for which it implements the callbacks.

WebView.subproj/WebView.m: (-[WebView registerForEditingDelegateNotification:selector:]): (-[WebView setEditingDelegate:]):

8:40 AM Changeset in webkit [6959] by trey

2 edits in trunk/WebKit

3294652 - Failed drag of links doesn't slide back

The only reason for this is that because of some hacks, we lie to
AK about the drag image offset, which means we slide back to
slightly the wrong place. But it's very minor, so we should
just fix it.

Reviewed by Ken.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Ask for slideback.

Jul 2, 2004:

10:27 AM Changeset in webkit [6958] by darin

3 edits in trunk/WebKit

Reviewed by Dave.

fixed problem where tabsToLinks and privateBrowsingEnabled did not work with non- standard WebPreferences objects

WebView.subproj/WebPreferences.m: (-[WebPreferences _valueForKey:]): New helper. (-[WebPreferences _stringValueForKey:]): Use _valueForKey. (-[WebPreferences _integerValueForKey:]): Use _valueForKey. (-[WebPreferences _boolValueForKey:]): Use _valueForKey. (-[WebPreferences tabsToLinks]): Use _boolValueForKey; this is the bug fix. (-[WebPreferences privateBrowsingEnabled]): Ditto. (+[WebPreferences _setIBCreatorID:]): Use copy instead of retain for keeping an NSString.

10:03 AM Changeset in webkit [6957] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed half of <rdar://problem/3709244> utf-8 meta tag not parsed when page title contains angle brackets or if </meta> tag used

khtml/misc/decoder.cpp: (Decoder::decode): Allow </meta> tags without deciding we are done with the header.

Jul 1, 2004:

1:41 PM Changeset in webkit [6956] by trey

2 edits in trunk/WebKit

3556159 - Crashes in -[WebFrame(WebPrivate) _transitionToCommitted:] at www.mastercardbusiness.com

We know from the line number of the crash that it is due to [self parentFrame]==nil.

Looking at the HTML and that of the related bugs, they do special stuff with onload
handlers. It is no longer repro, presumably because the includes JS files changed,
as the bugs only included the top level HTML. I suspect that the problem is that the
WebFrameLoadTypeOnLoadEvent case was added, and in some weird sequence specific to
MasterCard, they hit a case where we would be in WebFrameLoadTypeOnLoadEvent mode but
not have a parent frame.

So we guard in the code against hitting a nil parentFrame, and log an error just in
case this ever crops up again and we can learn more about it.

Reviewed by Richard.

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Guard against nil parentFrame.

10:41 AM Changeset in webkit [6955] by sullivan

3 edits in trunk/WebKit

Reviewed by Trey.

fixed these bugs: <rdar://problem/3709110> REGRESSION (Tiger): Pressing Tab key to move focus onto links skips every other link <rdar://problem/3692576> focus ring is in odd place after clicking RSS button with "Tab to links" enabled

WebHTMLView has some trickery by which we advance the focused link when nextKeyView
or previousKeyView is called within nextValidKeyView or previousValidKeyView. This
broke in Tiger because AppKit now (sometimes at least) calls nextKeyView more than
once within nextValidKeyView. Fixed 3709110 by making sure we only advance the focus
once within a call to nextValidKeyView or previousValidKeyView.

Also, this same trickery didn't work right with hidden views. Fixed 3692576 by checking
whether the view is hidden and bypassing the focus-moving trickery in that case.

WebView.subproj/WebHTMLViewInternal.h: renamed inNextValidKeyView -> nextKeyViewAccessShouldMoveFocus

WebView.subproj/WebHTMLView.m: (-[WebHTMLView nextKeyView]): now clears nextKeyViewAccessShouldMoveFocus (-[WebHTMLView previousKeyView]): ditto (-[WebHTMLView nextValidKeyView]): now doesn't set focus-moving trigger ivar if view is hidden or has hidden ancestor (-[WebHTMLView previousValidKeyView]): ditto

Jun 30, 2004:

7:07 PM Changeset in webkit [6954] by trey

14 edits in trunk

WebCore:

Dragging within a web view should be allowed to start when the window isn't key.

A few months ago, Chris made this work, but it relied on the fact that all dragging
was done in WebKit. When WebCore got involved in dragging, it was broken. Now we
have a new scheme that gets it working again that properly involves WebCore.

The general idea is that when AK asks us whether to accept the first mouse and do
"delayed window ordering", we must consult WC to see if we might start a drag. In
addition, instead of these drags in non-active windows being started as a special
case in WK, they go through the normal WK-WC drag machinery.

Reviewed by John.

khtml/khtml_part.cpp: (KHTMLPart::shouldDragAutoNode): New x,y args.
khtml/khtml_part.h:
khtml/rendering/render_object.cpp: (RenderObject::draggableNode): Pass through new x,y args.
khtml/rendering/render_object.h:
kwq/KWQKHTMLPart.h: (KWQKHTMLPart::setActivationEventNumber): New setter.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Init new ivar. (KWQKHTMLPart::eventMayStartDrag): New routine that checks if we might start a drag in response to a mouseDown. (KWQKHTMLPart::khtmlMouseMoveEvent): Pass x,y to the routine that finds a draggable node. This eventually gets back up to WK's _mayStartDragAtEventLocation:. Delay requirement when dragging the selection now implemented here. (KWQKHTMLPart::khtmlMouseReleaseEvent): Must avoid changing the selection if we wind up here as part of the first click in a window (because we started handling the click to possible start a drag, but that never came through). (KWQKHTMLPart::mouseDown): Save away event timestamp. (KWQKHTMLPart::shouldDragAutoNode): Pass location up to WK instead of the most recent event we stashed.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setActivationEventNumber:]): Trivial glue. (-[WebCoreBridge eventMayStartDrag:]): Ditto.

WebKit:

Dragging within a web view should be allowed to start when the window isn't key.

A few months ago, Chris made this work, but it relied on the fact that all dragging
was done in WebKit. When WebCore got involved in dragging, it was broken. Now we
have a new scheme that gets it working again that properly involves WebCore.

The general idea is that when AK asks us whether to accept the first mouse and do
"delayed window ordering", we must consult WC to see if we might start a drag. In
addition, instead of these drags in non-active windows being started as a special
case in WK, they go through the normal WK-WC drag machinery. Finally to work in
frames we have to drill to the deepest hit view in acceptsFirstMouse, because previous
hacks to hitTest make the top-most WebHTMLView field all events for its view tree
(which leads to it fielding all acceptFirstMouse messages too).

Reviewed by John.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge mayStartDragAtEventLocation:]): Glue change for new arg type.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): firstMouseDownEvent ivar is no longer needed. (-[WebHTMLView _mayStartDragAtEventLocation:]): Receives a location instead of a drag event, since we need to do this work when we have no drag event. This means the check of the delay for text dragging is moved down to WebCore. (-[WebHTMLView acceptsFirstMouse:]): Respond based on whether we might do a drag. This includes drilling to the deepest view the event hits, whereas we used to only respond considering the topmost WebHTMLView. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto. (-[WebHTMLView mouseDown:]): Get rid of special case where some activating mouseDown events weren't sent to WC. We need to go through the whole pipeline now to get a drag started properly. (-[WebHTMLView mouseDragged:]): Ditto, let WC start the drag. (-[WebHTMLView mouseUp:]): firstMouseDownEvent ivar is no longer needed.
WebView.subproj/WebHTMLViewInternal.h:
WebView.subproj/WebHTMLViewPrivate.h:

10:14 AM Changeset in webkit [6953] by trey

2 edits in trunk/WebCore

Need to tighten up JS error checking for requesting drag props
in the wrong cases.

Reviewed by John.

khtml/ecma/kjs_events.cpp: (Clipboard::getValueProperty): Assert if someone somehow set dropEffect or effectAllowed and it's a copy/paste clipboard instead of a dragging clipboard. (Clipboard::putValue): Don't let anyone set dropEffect or effectAllowed on a copy/paste clipboard. (ClipboardProtoFunc::tryCall): Disallow setting dragImage on a copy/paste clipboard.

Jun 29, 2004:

4:37 PM Changeset in webkit [6952] by trey

4 edits in trunk/WebCore

DHTML dragging - source should have access to the operation chosen
by the destination.

Reviewed by John

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dragSourceEndedAt): Set the destination's operation on the clipboard.
kwq/WebCoreBridge.mm: (-[WebCoreBridge dragExitedWithDraggingInfo:]): For completeness we set the source op for the ondragexit event. (-[WebCoreBridge concludeDragForDraggingInfo:]): Ditto for the drop event. (-[WebCoreBridge dragSourceEndedAt:operation:]): Pass through of operation.

Jun 25, 2004:

4:49 PM Changeset in webkit [6951] by trey

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix "reviewed by" line.

3:53 PM Changeset in webkit [6950] by trey

3 edits in trunk/WebKit

WebKit:

Added new utility method.

Reviewed by John.

WebView.subproj/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): New code.
WebView.subproj/WebFramePrivate.h:

WebBrowser:

3562182 - repro Safari crash when altering specific form field

The basic problem was that JS would disable the search field on submit, which prevents
AK from sending a proper endEditing notification, which left the FormCompletionControler
hung out to dry. We now watch for page transitions, and clear the FormCC then.

Reviewed by John

BrowserWebController.h:
BrowserWebController.m: (-[BrowserWebView dataSourceHasChanged:forFrame:]): New callback from LocationChangeHandler, just pass through to FormDelegate. (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Add ASSERT to catch similiar trouble in the figure. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Ditto. (-[FormDelegate controlTextDidChange:inFrame:]): Ditto (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Ditto. (-[FormDelegate frameHasChanged:]): Clear state when page transitions out from under us.
CompletionController.m: (+[CompletionController setCurrentCompletionController:]): Make the current comp controller a non-retained reference. Side pointers like this do not want to keep around objects with pointers into UI widgetry. (-[CompletionController dealloc]): Clear the current comp controller if we're going away.
FormCompletionController.h:
FormCompletionController.m: (-[FormCompletionController webFrame]): New getter.
LocationChangeHandler.m: Cleaned up a bunch of silly code due to old rote conversion. (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didCommitLoadForFrame:]): Let WebView know of commit. (-[LocationChangeHandler webView:didReceiveTitle:forFrame:]): (-[LocationChangeHandler webView:didReceiveIcon:forFrame:]): (-[LocationChangeHandler webView:didChangeLocationWithinPageForFrame:]): (-[LocationChangeHandler webView:willCloseFrame:]):

Jun 24, 2004:

10:20 PM Changeset in webkit [6949] by trey

2 edits in trunk/WebCore

3710422 - REGRESSION: Safari crashes trying to send onbeforecut event at about://blank

Simple fix - don't try to send the event to the body element if we have no body element.

Reviewed by NOBODY (OOPS!).

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dispatchCPPEvent):

7:16 PM Changeset in webkit [6948]

20 copies
3 deletes in tags/WebKit-125~3

This commit was manufactured by cvs2svn to create tag 'WebKit-125~3'.

7:16 PM Changeset in webkit [6947] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

versioning for SUPanMoccasin, WebKit-125.3

7:15 PM Changeset in webkit [6946]

61 copies
2 deletes in tags/WebCore-125~7

This commit was manufactured by cvs2svn to create tag
'WebCore-125~7'.

7:15 PM Changeset in webkit [6945] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

versioning for SUPanMoccasin, WebCore-125.7

7:14 PM Changeset in webkit [6944]

6 copies
4 deletes in tags/JavaScriptCore-125~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~5'.

7:14 PM Changeset in webkit [6943] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

versioning for SUPanMoccasin, JSC-125.5

6:54 PM Changeset in webkit [6942]

8 copies
2 deletes in tags/WebCore-146~1~1

This commit was manufactured by cvs2svn to create tag
'WebCore-146~1~1'.

6:54 PM Changeset in webkit [6941] by vicki

2 edits in branches/WWDC-demo-branch/WebCore

versioning for the demo

6:52 PM Changeset in webkit [6940] by vicki

2 edits in branches/WWDC-demo-branch/WebCore

roll this change to a branch, for the demo (one more try)

2004-06-22 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash

embedInstance was uninitialized.

Reviewed by Chris.

khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):

6:09 PM Changeset in webkit [6939] by vicki

2 edits in branches

versioning for the demo changes, WebCore-146.1.1

6:07 PM Changeset in webkit [6938] by vicki

3 edits in branches

merge this change for the WWDC demo

2004-06-22 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash

embedInstance was uninitialized.

Reviewed by Chris.

khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):

6:02 PM Changeset in webkit [6937]

4 copies
3 deletes in tags/WebKit-146~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-146~0~1'.

6:02 PM Changeset in webkit [6936] by vicki

2 edits in branches/WWDC-demo-branch/WebKit

versioning for demo changes, WebKit-146.0.1

5:58 PM Changeset in webkit [6935] by vicki

2 edits in branches/WWDC-demo-branch/WebKit

roll this change to a branch for the WWDC demo

2004-06-24 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/3710313>: CGContext not zeroed when WebImageRenderer is copied
The context ivar of WebImageRenderer wasn't being nil when the object was copied.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

5:28 PM Changeset in webkit [6934] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3710313>: CGContext not zeroed when WebImageRenderer is copied
The context ivar of WebImageRenderer wasn't being nil when the object was copied.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

5:06 PM Changeset in webkit [6933] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

fix a build error that cropped up from the merge for the radio button fix, 3673762

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::reset):

4:15 PM Changeset in webkit [6932] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge this change from HEAD for SUPanMoccasin, also for 3704961

2004-06-21 Chris Blumenberg <cblu@apple.com>

Made WebKitErrorDescriptionPlugInCancelledConnection properly reuse an already localized string to avoid loc changes.

Reviewed by john.

ChangeLog:
Misc.subproj/WebKitErrors.m:

4:10 PM Changeset in webkit [6931] by vicki

7 edits in branches/Safari-1-2-branch/WebKit

merge this change from HEAD for SUPanMoccasin, 3704961

2004-06-21 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

Misc.subproj/WebKitErrors.m: (registerErrors): register string for WebKitErrorPlugInCancelledConnection
Misc.subproj/WebKitErrorsPrivate.h:
Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant (-[WebBaseNetscapePluginStream destroyStream]): ditto
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): ditto

WebBrowser:

merge this change from HEAD for SUPanMoccasin, 3704961

2004-06-21 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

LoadProgressMonitor.m:
LocationChangeHandler.m: if the error is WebKitErrorPlugInCancelledConnection ignore it (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): ditto

3:51 PM Changeset in webkit [6930] by vicki

4 edits in branches/Safari-1-2-branch/WebKit

merge this change from HEAD for SUPanMoccasin, 3704493

2004-06-15 Trey Matteson <trey@apple.com>

3639321 - Harvard PIN authentication ends up sending PIN as clear text with POST action

When going back/forward to an item, if we went there originally via a POST,
we ask the user about rePOSTing, and if they say yes, we resend the POST.
This rePOST case is triggered by the form data that we saved on the b/f item.
In the case of this bug, the overall navigation was accomplished by a POST,
then a redirect, causing a GET. When a load of type redirect achieves the Committed
stage, we replace the current URL in the b/f item with the new URL (instead of
adding a new item to the b/f list).

The bug is that at the same time we should also update the form data in
the b/f item to match that of the new request. I think this will normally
mean nil'ing it out, unless there's some way for the result of the redirect
to be another POST.

The security leak occurred because we did not clear the form data on the item,
so when going back or forward to the page, we would go into the rePOSTing code,
even though we eventually reached that page via a GET (caused by the redirect).
So we would do a POST to the redirect URL containing the private data sent in
the original POST.

Reviewed by mjs and rjw.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): New method, just wraps 3 old set methods. (-[WebHistoryItem formData]): Diff being dumb, no change. (-[WebHistoryItem formContentType]): Ditto (-[WebHistoryItem formReferrer]): Ditto
History.subproj/WebHistoryItemPrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): Call new WebHistoryItem method - no change in real behavior (-[WebFrame _transitionToCommitted:]): Clear out the form data at the key time, to fix the bug.

3:46 PM Changeset in webkit [6929] by trey

2 edits in trunk/WebKit

WebKit:

3672725 - Assertion failure in URLCompletion code with particular set of bookmarks

Problem was caused by a URL with unescaped unicodes getting into
the Bookmarks file, presumably from import from IE. We now test
for this case and convert the data on the way in as if it were
user-entered.

Reviewed by John and Darin.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]):

WebBrowser:

A little extra timing logging added as part of fixing 3672725.

Reviewed by John.

URLCompletionController.m: (+[URLCompletionController _loadDB]):

3:23 PM Changeset in webkit [6928] by trey

6 edits in trunk

Hmm, I thought this was working when I checked it in, but now it's not.
So once more with feeling, eliminate the cvs warnings for all *mode*
files within XCode doc wrappers.

3:19 PM Changeset in webkit [6927] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge this change from HEAD for SUPanMoccasin, 3704509

2004-06-02 David Hyatt <hyatt@apple.com>

Fix for 3673931, negative margins on objects that dodge floats not handled correctly.

Reviewed by darin

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

3:16 PM Changeset in webkit [6926] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge this change from HEAD for SUPanMoccasin, 3703230

2004-06-18 John Sullivan <sullivan@apple.com>

Reviewed by Darin

fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

3:13 PM Changeset in webkit [6925] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

merge this change from HEAD for SUPanMoccasin, 3673762

2004-05-20 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3575385>: (multiple radio buttons checked when arriving at sites (poll at www.1170kfaq.com, many others))

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseHTMLAttribute): Use setChecked to set the default value if we are still in "use default checked" mode. That way, other radio buttons will be unchecked properly and the proper changed methods will be dispatched. (HTMLInputElementImpl::reset): Ditto.
khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::checked): Changed to just return m_checked. The m_useDefaultChecked flag is now only really looked at when you parse a checked attribute; that's because m_checked and m_defaultChecked are kept equal as long as m_useDefaultChecked is true.

1:53 PM Changeset in webkit [6924] by trey

6 edits in trunk

Added *.mode% to all .cvsignore files in XCode project doc wrappers.
Then copied the result to all the XCode wrappers that had none.

1:27 PM Changeset in webkit [6923] by trey

8 edits in trunk

WebCore:

3704950 drag image in DB ConfigBar has horizontal graphics turd WebCore JavaScript

When we generate a drag image (or a selection image too, for that matter) we
translate the CTM using a CG call. Later, WebImageRenderer adjusts the pattern
phase based on the CTM of the focused view, which doesn't include our translate.
So we must inform WebKit about the additional phase adjustment.

Reviewed by Richard

kwq/KWQKHTMLPart.mm: Tell WebKit about the phase adjustment. (KWQKHTMLPart::imageFromRect):
kwq/WebCoreGraphicsBridge.h:
kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge setAdditionalPatternPhase:]): New routine to receive the phase adjustment.

WebKit:

3704950 drag image in DB ConfigBar has horizontal graphics turd WebCore JavaScript

When we generate a drag image (or a selection image too, for that matter) we
translate the CTM using a CG call. Later, WebImageRenderer adjusts the pattern
phase based on the CTM of the focused view, which doesn't include our translate.
So we must inform WebKit about the additional phase adjustment.

Reviewed by Richard

WebCoreSupport.subproj/WebGraphicsBridge.h:
WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setAdditionalPatternPhase:]): New trivial setter. (-[WebGraphicsBridge additionalPatternPhase]): ...and getter.
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:context:]): Take any additional phase adjustment into account when setting phase.

1:20 PM Changeset in webkit [6922] by trey

8 edits in trunk/WebCore

3679986 - screenX and screenY are flipped and relative to the bottom left of the WebView, rather than the screen
3699510 - synthesized click events have bogus screen coords

Reviewed by Darin.

khtml/khtmlview.cpp: (KHTMLView::dispatchDragEvent): Generate screen coords for drag events using new func. (KHTMLView::dispatchMouseEvent): Ditto.
khtml/khtmlview.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchMouseEvent): Comment tricky semantics. Calc screen coords in apple-specific way.
kwq/KWQKHTMLView.mm: (KHTMLView::viewportToGlobal): Passthrough to window widget.
kwq/KWQScrollView.mm:
kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: (KWQWindowWidget::mapToGlobal): Call former code factored to new method below. (KWQWindowWidget::viewportToGlobal): New method to convert "viewport" (which for us really means NSWindow coords) to screen coords.

11:58 AM Changeset in webkit [6921] by trey

7 edits in trunk

WebCore:

3693420 - onbeforecut and onbeforepaste need real implementaion

Reviewed by Chris.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mayCut): Dispatch event to DHTML. (KWQKHTMLPart::mayCopy): Ditto (KWQKHTMLPart::mayPaste): Ditto (KWQKHTMLPart::tryCut): No more need to send fake onbefore event (KWQKHTMLPart::tryCopy): Ditto (KWQKHTMLPart::tryPaste): Ditto
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge mayDHTMLCut]): Standard glue (-[WebCoreBridge mayDHTMLCopy]): Ditto (-[WebCoreBridge mayDHTMLPaste]): Ditto

WebKit:

3693420 - onbeforecut and onbeforepaste need real implementaion

Reviewed by Chris.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView validateUserInterfaceItem:]): Check with WebCore to see if cut, copy, paste should be enabled.

11:43 AM Changeset in webkit [6920] by darin

4 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3709385> Find on page doesn't find a string at the very end of the file

khtml/misc/khtml_text_operations.cpp: (khtml::findPlainText): Rearrange loop to avoid an early exit once we have all the characters we need, but are at the end of the range we are searching.

fixed <rdar://problem/3102271>: (text areas have scroll bars even when they don't need them)
fixed <rdar://problem/3665430>: (horizontal scroll bar of text area does not show, even when text is wide in "no wrap" mode)

kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Added. Helper method that sets up the view for a new word wrap mode. (-[KWQTextArea _createTextView]): Moved much of the code inside _configureTextViewForWordWrapMode. (-[KWQTextArea _frameSizeChanged]): Added. Method shared by setFrame: and initWithFrame: to avoid duplicate code that was there before. The old code also had redundant code to update the text container size, but NSText handles that automatically. (-[KWQTextArea initWithFrame:]): Set wrap to YES by default, which is the key to fixing bug 3665430. Call setAutohidesScrollers:YES, which fixes bug 3102271. Also call the new _frameSizeChanged method. (-[KWQTextArea setWordWrap:]): Call _configureTextViewForWordWrapMode instead of trying to do the work here. The old version did both too little and too much. (-[KWQTextArea setFrame:]): Call _frameSizeChanged instead of trying to do the work here. The old version did both too little and too much.

11:42 AM Changeset in webkit [6919]

11 copies
3 deletes in tags/WebKit-146~1

This commit was manufactured by cvs2svn to create tag 'WebKit-146~1'.

11:42 AM Changeset in webkit [6918] by vicki

2 edits in branches/WWDC-2004-branch/WebKit

versioning for Safari 1.3 Developer Beta, WebKit 146.1

11:41 AM Changeset in webkit [6917] by cblu

3 edits in trunk/JavaScriptCore

JavaScriptCore:

Ignore .mode1 files in JavaScriptCore.pbproj

Reviewed by kocienda.

JavaScriptCore.pbproj/.cvsignore:

Tests:

Made TestBindingsPlugin compile again.
Removed TestPlugin from CVS since NetscapeMoviePlugin is a better Netscape plug-in example.

Reviewed by kocienda.

TestBindingsPlugin/TestBindingsPlugin.pbproj/.cvsignore: Added.
TestBindingsPlugin/TestBindingsPlugin.pbproj/project.pbxproj:
TestBindingsPlugin/main.c: (NPP_GetValue): (NPP_SetValue):
TestPlugin/English.lproj/InfoPlist.strings: Removed.
TestPlugin/TestPlugin.pbproj/project.pbxproj: Removed.
TestPlugin/main.c: Removed.
TestPlugin/npapi.h: Removed.
TestPlugin/test_plugin.html: Removed.

WebBrowser:

Ignore .mode1 files in WebBrowser.pbproj

Reviewed by kocienda.

WebBrowser.pbproj/.cvsignore:

WebKitExamples:

Ignore .mode1 and other files in WebKitMoviePlugIn.xcode and NetscapeMoviePlugIn.xcode.

Reviewed by kocienda.

NetscapeMoviePlugIn/NetscapeMoviePlugIn.xcode/.cvsignore: Added.
WebKitMoviePlugIn/WebKitMoviePlugIn.xcode/.cvsignore: Added.
WebKitMoviePlugIn/WebKitMoviePlugIn.xcode/project.pbxproj: Tiger updated the project

11:36 AM Changeset in webkit [6916]

11 copies
2 deletes in tags/WebCore-146~2

This commit was manufactured by cvs2svn to create tag
'WebCore-146~2'.

11:36 AM Changeset in webkit [6915] by vicki

2 edits in branches/WWDC-2004-branch/WebCore

versioning for Safari 1.3 Developer Beta, WebCore-146.2

11:34 AM Changeset in webkit [6914]

16 copies
3 deletes in tags/JavaScriptCore-146~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~2'.

11:34 AM Changeset in webkit [6913] by vicki

2 edits in branches/WWDC-2004-branch/JavaScriptCore

versioning for the 1.3 Developer Beta build, JavaScriptCore-146.2

11:22 AM Changeset in webkit [6912] by sullivan

3 edits in trunk/WebCore

Darin made this change on my machine; I reviewed it.

fixed <rdar://problem/3698333> Find on page doesn't find a particular string with a newline in the source

khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::handleTextBox): Clear m_lastTextNodeEndedWithCollapsedSpace after taking it into account.

11:22 AM Changeset in webkit [6911] by sullivan

2 edits in trunk/WebKit

Reviewed by Darin.

fixed <rdar://problem/3706792> 8A161: Choosing text encoding for error page opens finder window!?

WebView.subproj/WebFrame.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): take unreachableURL into account

11:19 AM Changeset in webkit [6910] by vicki

29 edits in branches/WWDC-2004-branch

JavaScriptCore:

merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <rjw@apple.com>

Implemented changes for latest npruntime.h.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_jsobject.cpp: (listFromVariantArgs): (identiferFromNPIdentifier): (_NPN_CreateScriptObject): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty):
bindings/NP_jsobject.h:
bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
bindings/c/c_instance.cpp: (CInstance::invokeMethod):
bindings/c/c_utility.cpp: (convertNPVariantToValue):
bindings/c/c_utility.h:
bindings/npruntime.cpp: (stringIdentifierEqual): (stringIdentifierHash): (getStringIdentifierDictionary): (intIdentifierEqual): (intIdentifierHash): (getIntIdentifierDictionary): (NPN_GetStringIdentifier): (NPN_GetStringIdentifiers): (NPN_GetIntIdentifier): (NPN_IdentifierIsString): (NPN_UTF8FromIdentifier): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_SetException):
bindings/npruntime.h:
bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]):
bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp):
bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter):
bindings/testbindings.cpp: (initializeIdentifiers): (logMessage): (setDoubleValue): (setIntValue): (setBooleanValue):

WebCore:

merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <rjw@apple.com>

Implemented changes for latest npruntime.h.

Reviewed by Chris.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::windowScriptNPObject): (KWQKHTMLPart::getEmbedInstanceForView):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]):

WebKit:

merge this change from HEAD, for Safari 1.3 Developer Beta

2004-06-23 Richard Williamson <rjw@apple.com>

Implemented changes for latest npruntime.h.
Made npruntime.h public.

Reviewed by Chris.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): (-[WebBaseNetscapePluginView forceRedraw]): (-[WebBaseNetscapePluginView getVariable:value:]):
Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
Plugins.subproj/npapi.h:
Plugins.subproj/npapi.m: (NPN_GetValue):
Plugins.subproj/npfunctions.h:
Plugins.subproj/npruntime.h:
WebKit.pbproj/project.pbxproj:

Jun 23, 2004:

5:36 PM Changeset in webkit [6909] by rjw

29 edits in trunk

WebKit:

Implemented changes for latest npruntime.h.
Made npruntime.h public.

Reviewed by Chris.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): (-[WebBaseNetscapePluginView forceRedraw]): (-[WebBaseNetscapePluginView getVariable:value:]):
Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
Plugins.subproj/npapi.h:
Plugins.subproj/npapi.m: (NPN_GetValue):
Plugins.subproj/npfunctions.h:
Plugins.subproj/npruntime.h:
WebKit.pbproj/project.pbxproj:

WebCore:

Implemented changes for latest npruntime.h.

Reviewed by Chris.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::windowScriptNPObject): (KWQKHTMLPart::getEmbedInstanceForView):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]):

JavaScriptCore:

Implemented changes for latest npruntime.h.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_jsobject.cpp: (listFromVariantArgs): (identiferFromNPIdentifier): (_NPN_CreateScriptObject): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty):
bindings/NP_jsobject.h:
bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
bindings/c/c_instance.cpp: (CInstance::invokeMethod):
bindings/c/c_utility.cpp: (convertNPVariantToValue):
bindings/c/c_utility.h:
bindings/npruntime.cpp: (stringIdentifierEqual): (stringIdentifierHash): (getStringIdentifierDictionary): (intIdentifierEqual): (intIdentifierHash): (getIntIdentifierDictionary): (NPN_GetStringIdentifier): (NPN_GetStringIdentifiers): (NPN_GetIntIdentifier): (NPN_IdentifierIsString): (NPN_UTF8FromIdentifier): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_SetException):
bindings/npruntime.h:
bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]):
bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp):
bindings/runtime_root.cpp: (KJS::Bindings::rootForInterpreter):
bindings/testbindings.cpp: (initializeIdentifiers): (logMessage): (setDoubleValue): (setIntValue): (setBooleanValue):

5:23 PM Changeset in webkit [6908] by vicki

3 edits in trunk

bump the version number in TOT to 148u, since I burned 147 for the WWDC demo build

Jun 22, 2004:

5:16 PM Changeset in webkit [6907] by rjw

2 edits in trunk/WebCore

Fixed <rdar://problem/3707162>: accessing embeds[] plug-in interface may crash

embedInstance was uninitialized.

Reviewed by Chris.

khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::HTMLEmbedElementImpl):

Jun 21, 2004:

4:50 PM Changeset in webkit [6906] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

3:13 PM Changeset in webkit [6905] by cblu

3 edits in trunk/WebKit

Made WebKitErrorDescriptionPlugInCancelledConnection have its own description string
(Not for software update branch)

Reviewed by john.

English.lproj/Localizable.strings:
Misc.subproj/WebKitErrors.m:

3:05 PM Changeset in webkit [6904] by cblu

2 edits in trunk/WebKit

Made WebKitErrorDescriptionPlugInCancelledConnection properly reuse an already localized string to avoid loc changes.

Reviewed by john.

ChangeLog:
Misc.subproj/WebKitErrors.m:

2:28 PM Changeset in webkit [6903] by cblu

7 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

Misc.subproj/WebKitErrors.m: (registerErrors): register string for WebKitErrorPlugInCancelledConnection
Misc.subproj/WebKitErrorsPrivate.h:
Plugins.subproj/WebBaseNetscapePluginStream.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant (-[WebBaseNetscapePluginStream destroyStream]): ditto
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): ditto

WebBrowser:

Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in

Reviewed by john.

LoadProgressMonitor.m:
LocationChangeHandler.m: if the error is WebKitErrorPlugInCancelledConnection ignore it (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): ditto

10:46 AM Changeset in webkit [6902] by vicki

1 edit in trunk/WebCore/ChangeLog-2005-08-23

add a release marker for WebCore-146.1

10:24 AM Changeset in webkit [6901] by vicki

1 edit in trunk/JavaScriptCore/ChangeLog

add release marker for JSC-146.1

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed