Context Navigation

← Previous Period
Next Period →

Timeline

Sep 20, 2004:

6:16 PM Changeset in webkit [7615] by darin

23 edits in trunk/WebCore

Reviewed by Maciej.

fixed regression from my recent check-in where misspelled words do not get unmarked when moving the caret
changed CaretPosition to hold a Position instead of a node and offset
renamed isEmpty to isNull, etc.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Updated for name changes. (KWQKHTMLPart::advanceToNextMisspelling): Ditto. (KWQKHTMLPart::fontForSelection): Ditto. (KWQKHTMLPart::setDisplaysWithFocusAttributes): Ditto. (KWQKHTMLPart::markMisspellingsInSelection): Ditto. (KWQKHTMLPart::updateSpellChecking): Fixed bug by using LeftWordIfOnBoundary.

khtml/xml/dom_position.h: Updated for name changes.
khtml/xml/dom_position.cpp: (DOM::Position::element): Change to not use a separate null check. (DOM::Position::computedStyle): Updated for name changes. (DOM::Position::previousCharacterPosition): Ditto. (DOM::Position::nextCharacterPosition): Ditto. (DOM::Position::equivalentRangeCompliantPosition): Ditto. (DOM::Position::equivalentShallowPosition): Ditto. (DOM::Position::equivalentDeepPosition): Ditto. (DOM::Position::closestRenderedPosition): Ditto. (DOM::Position::inRenderedContent): Ditto. (DOM::Position::inRenderedText): Ditto. (DOM::Position::isRenderedCharacter): Ditto. (DOM::Position::rendersInDifferentPosition): Ditto. (DOM::Position::isFirstRenderedPositionOnLine): Ditto. (DOM::Position::isLastRenderedPositionOnLine): Ditto. (DOM::Position::inFirstEditableInRootEditableElement): Ditto. (DOM::Position::leadingWhitespacePosition): Ditto. (DOM::Position::trailingWhitespacePosition): Ditto. (DOM::Position::debugPosition): Ditto. (DOM::Position::formatForDebugger): Ditto.

khtml/xml/dom_caretposition.h: Change to use m_position, and change names.
khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::CaretPosition): Remove code to set up m_node. (DOM::CaretPosition::init): Set m_position directly. (DOM::CaretPosition::isLastInBlock): Updated for name changes. (DOM::CaretPosition::next): Set m_position directly. (DOM::CaretPosition::previous): Set m_position directly. (DOM::CaretPosition::previousCaretPosition): Updated for name changes. (DOM::CaretPosition::nextCaretPosition): Ditto. (DOM::CaretPosition::previousPosition): Ditto. (DOM::CaretPosition::nextPosition): Ditto. (DOM::CaretPosition::atStart): Ditto. (DOM::CaretPosition::atEnd): Ditto. (DOM::CaretPosition::isCandidate): Ditto. (DOM::CaretPosition::debugPosition): Ditto. (DOM::CaretPosition::formatForDebugger): Ditto. (DOM::startOfWord): Ditto. (DOM::endOfWord): Ditto. (DOM::previousParagraphPosition): Ditto. (DOM::nextParagraphPosition): Ditto.

khtml/xml/dom_selection.h: Updated names. Added isCaret and isRange.
khtml/xml/dom_selection.cpp: (DOM::Selection::modifyMovingRightForward): Updated for name changes. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Ditto. (DOM::Selection::expandUsingGranularity): Ditto. (DOM::Selection::xPosForVerticalArrowNavigation): Ditto. (DOM::Selection::toRange): Ditto. (DOM::Selection::layoutCaret): Ditto. (DOM::Selection::needsCaretRepaint): Ditto. (DOM::Selection::validate): Ditto. (DOM::startOfFirstRunAt): Ditto. (DOM::endOfLastRunAt): Ditto. (DOM::selectionForLine): Ditto. (DOM::Selection::formatForDebugger): Ditto.

khtml/ecma/kjs_window.cpp: (Selection::get): Updated for name changes. (Selection::toString): Ditto.
khtml/editing/htmlediting_impl.cpp: (khtml::debugPosition): Ditto. (khtml::StyleChange::init): Ditto. (khtml::StyleChange::currentlyHasStyle): Ditto. (khtml::CompositeEditCommandImpl::deleteSelection): Ditto. (khtml::CompositeEditCommandImpl::deleteUnrenderedText): Ditto. (khtml::ApplyStyleCommandImpl::doApply): Ditto. (khtml::DeleteSelectionCommandImpl::doApply): Ditto. (khtml::InputNewlineCommandImpl::doApply): Ditto. (khtml::InputTextCommandImpl::prepareForTextInsertion): Ditto. (khtml::InputTextCommandImpl::input): Ditto. (khtml::ReplaceSelectionCommandImpl::doApply): Ditto. (khtml::MoveSelectionCommandImpl::doApply): Ditto. (khtml::TypingCommandImpl::doApply): Ditto. (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Ditto. (khtml::TypingCommandImpl::issueCommandForDeleteKey): Ditto.
khtml/editing/jsediting.cpp: (enabledAnySelection): Ditto. (enabledRangeSelection): Ditto.
khtml/khtml_part.cpp: (KHTMLPart::hasSelection): Ditto. (KHTMLPart::setFocusNodeIfNeeded): Ditto. (KHTMLPart::selectionLayoutChanged): Ditto. (KHTMLPart::timerEvent): Ditto. (KHTMLPart::isPointInsideSelection): Ditto. (KHTMLPart::selectClosestWordFromMouseEvent): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto. (KHTMLPart::selectionHasStyle): Ditto. (KHTMLPart::selectionComputedStyle): Ditto.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Ditto.
khtml/xml/dom_positioniterator.cpp: (DOM::PositionIterator::peekPrevious): Ditto. (DOM::PositionIterator::peekNext): Ditto. (DOM::PositionIterator::atStart): Ditto. (DOM::PositionIterator::atEnd): Ditto.
khtml/xml/dom_positioniterator.h: (DOM::PositionIterator::isEmpty): Ditto.
kwq/KWQRenderTreeDebug.cpp: (writeSelection): Ditto.
kwq/WebCoreBridge.mm: (-[WebCoreBridge editableDOMRangeForPoint:]): Ditto. (-[WebCoreBridge deleteSelection]): Ditto. (-[WebCoreBridge ensureCaretVisible]): Ditto. (-[WebCoreBridge rangeOfCharactersAroundCaret]): Ditto.

5:28 PM Changeset in webkit [7614] by darin

6 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3808073> find is broken

khtml/misc/khtml_text_operations.h: Add m_pastEndNode and change name of m_endNode to m_endContainer to more accurately reflect its purpose.
khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Use pastEnd() for end of iteration, and change to handle bad ranges better: just return an empty iterator instead of raising an exception. (khtml::TextIterator::advance): Change to use m_pastEndNode to detect the end of iteration. (khtml::TextIterator::handleTextNode): Update for name change. (khtml::TextIterator::handleTextBox): Ditto. (khtml::TextIterator::range): Handle case where m_endContainer is nil.

khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::surroundContents): Use offsetInCharacters. (DOM::RangeImpl::startNode): Added check for nil start container and use offsetInCharacters. (DOM::RangeImpl::pastEndNode): Ditto.

4:56 PM Changeset in webkit [7613] by cblu

10 edits in trunk

WebCore:

Fixed: <rdar://problem/3781290> REGRESSION (Mail): Crash in ReplaceSelectionCommandImpl attaching file to new message

Reviewed by kocienda.

khtml/khtml_part.cpp: (KHTMLPart::setSelection): setFocusNodeIfNeeded now works on the current selection so call setFocusNodeIfNeeded after setting the selection (KHTMLPart::clearSelection): don't call setFocusNodeIfNeeded with the current selection (KHTMLPart::setCaretVisible): ditto (KHTMLPart::setFocusNodeIfNeeded): do nothing if the part isn't focused, work with the current selection
khtml/khtml_part.h:
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): added m_isFocused
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): removed _displaysWithFocusAttributes this is replaced by m_isFocused (KWQKHTMLPart::setSelectionFromNone): new, code factored out from setDisplaysWithFocusAttributes (KWQKHTMLPart::setDisplaysWithFocusAttributes): call setSelectionFromNone (KWQKHTMLPart::displaysWithFocusAttributes): now returns m_isFocused
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFromNone]): new

WebKit:

Fixed: <rdar://problem/3781290> REGRESSION (Mail): Crash in ReplaceSelectionCommandImpl attaching file to new message

Reviewed by kocienda.

WebView.subproj/WebView.m: (-[WebView setEditable:]): call updateSelectionFromEmpty on the bridge if there is no selection

4:26 PM Changeset in webkit [7612] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed nil-deref happening often in Mail when I delete

khtml/rendering/render_br.cpp: (RenderBR::selectionRect): Check for nil lastLeafChild. Dave may want to figure out why it's nil and do a different fix later.

2:53 PM Changeset in webkit [7611] by mjs

2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3672101> HANG: typing into login field at dws-direkt.deutsche-bank.de (infinite recursion)

khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Copy the list of handlers before firing any of them, in case a handler affects the list of event handlers.

2:36 PM Changeset in webkit [7610] by cblu

15 edits in trunk

WebCore:

Fixed:
<rdar://problem/3429921> obey PARAM tags inside of OBJECT tags when necessary
<rdar://problem/3515685> Object tag in Java 1.4.1 / Safari doesn't recognize params

Reviewed by darin.

khtml/khtml_part.cpp: (KHTMLPart::requestFrame): take 2 parameter arrays rather than 1 which will have to be parsed (KHTMLPart::requestObject): ditto
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): use PARAM tags when there is no EMBED specified
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call renamed bridge method
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): ditto
kwq/KWQStringList.h:
kwq/KWQStringList.mm: (QStringList::getNSArray): return a const array
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge URLWithAttributeString:]): renamed to match API

WebKit:

Changes to implement renamed bridge methods.

Reviewed by darin.

ChangeLog:
DOM.subproj/WebDOMOperations.m: (-[DOMDocument URLWithAttributeString:]): call renamed bridge method
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): take 2 parameter arrays rather than 1 which will have to be parsed (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto

1:21 PM Changeset in webkit [7609] by darin

1 edit
1 add
1 delete in trunk/WebKit

Reviewed by Chris.

WebView.subproj/WebFramePrivate.h: Added back.
WebView.subproj/WebFrameViewPrivate.h: Removed.

11:54 AM Changeset in webkit [7608] by darin

39 edits
2 deletes in trunk

WebCore:

Reviewed by Ken.

fixed <rdar://problem/3655360> REGRESSION (Mail): Ctrl-V emacs key binding, -pageDown: method, unimplemented (and pageUp, and selection-modifying versions)
fixed <rdar://problem/3735055> REGRESSION (Mail): WebCore double click rules treat style change as a boundary
fixed <rdar://problem/3789939> REGRESSION (Mail): double-clicking on border whitespace selects space plus word before/after
fixed <rdar://problem/3792138> REGRESSION (Mail): Spell checker doesn't check current selected word
fixed <rdar://problem/3806604> REGRESSION (164): Triple-click sometimes selects extra characters
fixed <rdar://problem/3806996> REGRESSION (125-162): Triple-click in <pre> tagged text behaves oddly (leuf.net)

khtml/xml/dom_caretposition.h: Added a lot of new functions. Removed implicit conversion operator that converts from CaretPosition to Position.
khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::CaretPosition): Change to call deepEquivalent so it works without the implicit Position conversion operator. (DOM::CaretPosition::operator=): Ditto. (DOM::CaretPosition::next): Ditto. (DOM::CaretPosition::previous): Ditto. (DOM::CaretPosition::setPosition): Added an assertion. (DOM::start): Added. (DOM::end): Added. (DOM::setStart): Added. (DOM::setEnd): Added. (DOM::previousWordBoundary): Added. (DOM::nextWordBoundary): Added. (DOM::startWordBoundary): Added. (DOM::startOfWord): Added. (DOM::endWordBoundary): Added. (DOM::endOfWord): Added. (DOM::previousWordPositionBoundary): Added. (DOM::previousWordPosition): Added. (DOM::nextWordPositionBoundary): Added. (DOM::nextWordPosition): Added. (DOM::previousLinePosition): Added. (DOM::nextLinePosition): Added. (DOM::startOfParagraph): Changed function name. (DOM::endOfParagraph): Changed function name. Fixed code in includeLineBreak to work around the CaretPosition constructor issue for <br>, pass the right parameter for the block flow case, and handle <pre> properly. (DOM::inSameParagraph): Added. (DOM::previousParagraphPosition): Added. (DOM::nextParagraphPosition): Added.

khtml/xml/dom_position.h: Removed a number of functions no longer used; also made some private.
khtml/xml/dom_position.cpp: Removed a number of functions no longer used.

khtml/xml/dom_selection.h: Replaced DOCUMENT with DOCUMENT_BOUNDARY. Added overloads of lots of functions that take CaretPosition directly. Added overload of modify that takes a parameter for vertical distance to help implement pageDown: and friends. Replaced getRepaintRect with two new functions named caretRect and caretRepaintRect. Removed nodeIsBeforeNode.
khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Added constructor that takes two CaretPosition objects. (DOM::Selection::setModifyBias): Added. Helper function. (DOM::Selection::modifyExtendingRightForward): Don't set modify bias, since that's now the caller's responsibility. Reimplement WORD and LINE in terms of new CaretPosition functions. Implement PARAGRAPH and change PARAGRAPH_BOUNDARY to use CaretPosition function by its new name. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Call setModifyBias, and use a switch statement instead of if. (DOM::caretY): Added. Helper for the new modify function that implements moving a pixel distance, used by pageDown: and friends. (DOM::Selection::modify): Added. (DOM::Selection::toRange): Use RangeImpl::compareBoundaryPoints instead of nodeIsBeforeNode. (DOM::Selection::caretRect): Added. Replaces getRepaintRect, but does not add slop. (DOM::Selection::caretRepaintRect): Added. Replaces getRepaintRect; still adds slop. (DOM::Selection::needsCaretRepaint): Call caretRepaintRect. (DOM::Selection::validate): Use RangeImpl::compareBoundaryPoints instead of nodeIsBeforeNode. Reimplement WORD to use new CaretPosition functions; this fixes the double-clicking problems. Change paragraph calls to use new names.

ForwardingHeaders/dom/dom_position.h: Removed. This was in the wrong location.
khtml/editing/htmlediting.cpp: Fixed include that said "dom/dom_position.h".
khtml/editing/htmlediting_impl.cpp: Fixed include that said "dom/dom_position.h". (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Rewrote this to use the new CaretPosition functions instead of the old Position functions.

khtml/misc/helper.h: Added const to character pointer parameter. Also put invertedColor inside an !APPLE_CHANGES since it doesn't do us any good.
khtml/misc/helper.cpp: (khtml::findWordBoundary): Added const to character pointer parameter. (khtml::nextWordFromIndex): Ditto.

kwq/KWQTextUtilities.h: Change parameters to const.
kwq/KWQTextUtilities.cpp: (KWQFindWordBoundary): Change parameter to const.
kwq/KWQTextUtilities.mm: (KWQFindNextWordFromIndex): Change parameter to const.

khtml/css/cssstyleselector.cpp: Disable code that uses invertedColor when APPLE_CHANGES, since it won't work for us.

khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection): Added checks for selection end so we can set the selection end to nodes that are not leaf nodes and it will still work. Also took out bogus firstChild/lastChild loops for the same reason.

kwq/KWQKHTMLPart.h: Add "start before selection" flag to advanceToNextMisspelling. Needed to fix bug with spell checking.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): Changed to use CaretPosition. (KWQKHTMLPart::advanceToNextMisspelling): Added code to handle "start before selection" flag and changed to use CaretPosition and new helper functions. (KWQKHTMLPart::markMisspellingsInSelection): More changes to use CaretPosition. (KWQKHTMLPart::updateSpellChecking): Ditto.

kwq/WebCoreBridge.h: Replaced WebSelectByDocument with WebSelectToDocumentBoundary. Added advanceToNextMisspellingStartingJustBeforeSelection, rangeByAlteringCurrentSelection:verticalDistance:, and alterCurrentSelection:verticalDistance:.

kwq/WebCoreBridge.mm: (-[WebCoreBridge advanceToNextMisspellingStartingJustBeforeSelection]): Added. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Added case for selecting by paragraph to save X position. (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]): Added. (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): Added. (-[WebCoreBridge ensureCaretVisible]): Call caretRect instead of getRepaintRect.

WebKit:

Reviewed by Ken.

fixed <rdar://problem/3655360> REGRESSION (Mail): Ctrl-V emacs key binding, -pageDown: method, unimplemented (and pageUp, and selection-modifying versions)
fixed <rdar://problem/3792138> REGRESSION (Mail): Spell checker doesn't check current selected word

WebView.subproj/WebFrameViewInternal.h: Moved WebFrameViewPrivate inside the WebFrameView.m file. Removed a bunch of methods that don't need to be seen in other files, and added _verticalPageScrollDistance.
WebView.subproj/WebFrameViewPrivate.h: Removed. Renamed to WebFrameViewInternal.h.
WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): Move in the file because of internal vs. private. (-[WebFrameView _shouldDrawBorder]): Ditto. (-[WebFrameView _tile]): Ditto. (-[WebFrameView _verticalPageScrollDistance]): Added. Separate method so it can be called by the code to implement pageDown:. (-[WebFrameView _drawBorder]): Move in the file because of internal vs. private. (-[WebFrameView _goBack]): Ditto. (-[WebFrameView _goForward]): Ditto. (-[WebFrameView _scrollVerticallyBy:]): Ditto. (-[WebFrameView _scrollHorizontallyBy:]): Ditto. (-[WebFrameView _horizontalKeyboardScrollDistance]): Ditto. (-[WebFrameView _horizontalPageScrollDistance]): Added. Separate method for consistency with vertical method above. (-[WebFrameView _pageVertically:]): Moved and changed to use _verticalPageScrollDistance. (-[WebFrameView _pageHorizontally:]): Moved and changed to use _horizontalPageScrollDistance. (-[WebFrameView _scrollLineVertically:]): Move in the file because of internal vs. private. (-[WebFrameView _scrollLineHorizontally:]): Ditto. (-[WebFrameView scrollPageUp:]): Ditto. (-[WebFrameView scrollPageDown:]): Ditto. (-[WebFrameView scrollLineUp:]): Ditto. (-[WebFrameView scrollLineDown:]): Ditto. (-[WebFrameView _firstResponderIsControl]): Ditto. (-[WebFrameView keyDown:]): Changed to eliminate _pageLeft, _lineLeft, _pageRight, and _lineRight.

WebView.subproj/WebDataSource.m: Use WebFrameView.h instead of WebFrameViewPrivate.h.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): Added. (-[WebHTMLView moveToBeginningOfDocument:]): Use WebSelectToDocumentBoundary. (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): Ditto. (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): Added. (-[WebHTMLView moveParagraphForwardAndModifySelection:]): Added. (-[WebHTMLView pageUp:]): Added. (-[WebHTMLView pageDown:]): Added. (-[WebHTMLView pageUpAndModifySelection:]): Added. (-[WebHTMLView pageDownAndModifySelection:]): Added. (-[WebHTMLView showGuessPanel:]): Changed to call advanceToNextMisspellingStartingJustBeforeSelection. This fixes the problem with spell checking.

WebView.subproj/WebImageView.m: (-[WebImageView webView]): Changed to use _web_parentWebView. (-[WebImageView menuForEvent:]): Changed to use [self webView]. (-[WebImageView mouseDown:]): Ditto. (-[WebImageView mouseDragged:]): Ditto. (-[WebImageView draggedImage:endedAt:operation:]): Ditto.

WebView.subproj/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): Changed to use _web_parentWebView. (-[WebTextView menuForEvent:]): Ditto. (-[WebTextView drawPageBorderWithSize:]): Ditto. (-[WebTextView knowsPageRange:]): Ditto.

Plugins.subproj/WebPluginDatabase.m: Updated filename of WebFrameViewInternal.h.
WebCoreSupport.subproj/WebBridge.m: Ditto.
WebKit.pbproj/project.pbxproj: Ditto.
WebView.subproj/WebFrame.m: Ditto.
WebView.subproj/WebView.m: Ditto.
Misc.subproj/WebNSViewExtras.m: Ditto.

11:52 AM Changeset in webkit [7607] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

cleaned up DOM::RangeImpl a little so compareBoundaryPoints can be used outside the class

khtml/xml/dom2_rangeimpl.h: Added const to many of the member functions and made the compareBoundaryPoints that works on parameters be a const member function.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::commonAncestorContainer): Added const. (DOM::RangeImpl::compareBoundaryPoints): Added const. (DOM::RangeImpl::boundaryPointsValid): Added const, and wrote cleaner version. (DOM::RangeImpl::insertNode): Simplified by calling containedByReadOnly. (DOM::RangeImpl::toString): Added const. (DOM::RangeImpl::toHTML): Added const. (DOM::RangeImpl::createContextualFragment): Added const. (DOM::RangeImpl::cloneRange): Added const. (DOM::RangeImpl::surroundContents): Simplified by calling containedByReadOnly.

11:51 AM Changeset in webkit [7606] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3806990> REGRESSION (125-162): Crash on Select All at http://leuf.net/cgi/wikidn?PerlConvertEolScript

khtml/rendering/render_replaced.cpp: (RenderWidget::setSelectionState): Added nil check for the widget.

11:50 AM Changeset in webkit [7605] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3773740> calling addEventListener on a frame that hasn't loaded yet crashes

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Add nil checks for the document. The nil check prevents the crash but there's still a bug here; I filed 3807059 about that.

11:49 AM Changeset in webkit [7604] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed problem where up and down arrow keys are not preserving X position

khtml/khtml_part.cpp: (KHTMLPart::selectionLayoutChanged): Moved code to clear m_xPosForVerticalArrowNavigation out of here. (KHTMLPart::notifySelectionChanged): Moved it into here.

11:48 AM Changeset in webkit [7603] by darin

1 edit in trunk/WebKit/Misc.subproj/WebNSViewExtras.m

Fix filename.

11:47 AM Changeset in webkit [7602] by darin

3 edits in trunk/WebKit

Reviewed by Ken.

added helper method _web_parentWebView so fewer files need to get at WebFrame private methods

Misc.subproj/WebNSViewExtras.h: Added _web_parentWebView.
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): Added.

10:23 AM Changeset in webkit [7601]

24 copies
3 deletes in tags/WebKit-125~5~2

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~2'.

10:23 AM Changeset in webkit [7600] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

versioning for WebKit, WebKit-125.5.2

10:17 AM Changeset in webkit [7599]

71 copies
2 deletes in tags/WebCore-125~8~9

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~9'.

10:17 AM Changeset in webkit [7598] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

versioning for SUPanNavy, WebCore-125.8.9

10:12 AM Changeset in webkit [7597] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

rolled in the fix for 3801256

2004-09-03 Darin Adler <Darin Adler>

Reviewed by Chris.

fixed <rdar://problem/3410112> filename with non-ASCII name for <input type=file> should be sent in the page's encoding

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Encode filename using the codec rather than doing the &# dance. It turns out that Mozilla only does the &# thing under certain circumstances that are not important. Always encoding the filename is almost certainly better behavior, and will fix many serious problems for Japanese and Korean users and websites.

Sep 18, 2004:

6:12 PM Changeset in webkit [7596] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3805627> -[DOMRange _text] sometimes includes all text to the end of the document for certain ranges

khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::advance): Correctly handle the case when we are already on m_endNode. The concept here is that m_endNode is a node you must never "leave" when iterating.

Sep 17, 2004:

12:22 PM Changeset in webkit [7595] by vicki

3 edits in trunk

change version number to 2.0, 165u for TOT

12:06 PM Changeset in webkit [7594]

3 copies in tags/Safari-164

This commit was manufactured by cvs2svn to create tag 'Safari-164'.

12:06 PM Changeset in webkit [7593] by vicki

6 edits in trunk

Safari-164 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (164 for both).

11:10 AM Changeset in webkit [7592] by cblu

2 edits in trunk/WebKit

Fixed:

<rdar://problem/3805757> don't unnecessarily put RTFD on the pasteboard
<rdar://problem/3805756> strip attachments before generating RTF

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): only put RTFD on the pasteboard if it has attachments, strip attachments when writing RTF

9:49 AM Changeset in webkit [7591] by kocienda

2 edits in trunk

Reviewed by me

layout-tests/editing/selection/unrendered-004-expected.txt: Updated expected results.

9:44 AM Changeset in webkit [7590] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3780245> REGRESSION (Mail): some lines are skipped when doing arrow navigation

khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): One-line fix. Make sure that BRs at the end of blocks are not skipped.

9:42 AM Changeset in webkit [7589] by kocienda

4 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3805594> REGRESSION (Mail): Second return key stroke does not work when first was in blockquote

khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Code to convert caret positions moved the position upstream before making a range-compliant position, but erroneously would allow the position to cross blocks. Now it will no longer do so.

Sep 16, 2004:

5:58 PM Changeset in webkit [7588] by rjw

9 edits in trunk/WebCore

Part 1 of the feature requested in
<rdar://problem/3752791> Dashboard: Need a better solution for control regions

This patch implements the CSS parsing necessary for dashboard regions.
Here's an example of the syntax we support:

<style>
#aDiv {

-apple-dashboard-region:

dashboard-region-circle(control 0 0 80 0)
dashboard-region-rectangle(control,20,0,20,0)
dashboard-region-circle(control 80 0 0 0);

}
</style>

Part 2 will determine the appropriate regions.

Reviewed by Chris.

khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
khtml/css/css_valueimpl.h: (DOM::CSSPrimitiveValueImpl::): (DOM::DashboardRegionImpl::DashboardRegionImpl): (DOM::DashboardRegionImpl::~DashboardRegionImpl): (DOM::DashboardRegionImpl::setNext): (DOM::DashboardRegionImpl::setLabel):
khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseContent): (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
khtml/css/cssparser.h:
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/dom/css_value.h: (DOM::CSSPrimitiveValue::):

4:45 PM Changeset in webkit [7587] by darin

4 edits in trunk/WebCore

fixed caret-drawing regression from my last patch

khtml/xml/dom_selection.cpp: (DOM::Selection::xPosForVerticalArrowNavigation): Pass false, meaning "vertical line caret" rather than true meaning "big box for overtyping". (DOM::Selection::layoutCaret): Ditto.

4:09 PM Changeset in webkit [7586] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed <rdar://problem/3804648> 8A262: Safari crashed in -[WebView(WebPrivate) _editingDelegateForwarder] inside QuickTime Cocoa Plug-in during WebView deallocation

WebView.subproj/WebView.m: (-[WebView _editingDelegateForwarder]): Check _private for nil before dereferencing it.

3:24 PM Changeset in webkit [7585] by darin

18 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3803280> crash in selectAll on page with no contents

khtml/khtml_part.cpp: (KHTMLPart::selectAll): Handle case of 0 for documentElement().
khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Ditto. (DOM::Position::nextWordPosition): Ditto.

cleaned up caret code
changed DOM::Selection to use CaretPosition more

khtml/rendering/render_box.cpp: (RenderBox::caretRect): Change to use empty rectangles instead of an X value of -1 to mean no rectangle.
khtml/rendering/render_image.cpp: (RenderImage::selectionRect): Take advantage of the fixed QRect constructor.
khtml/rendering/render_object.cpp: (RenderObject::caretRect): Change to use empty rectangle instead of an X value of -1 to mean no rectangle.
khtml/rendering/render_text.cpp: (RenderText::caretRect): Cleaned up, and changed to use an empty rectangle instead of an X value of -1 to mean no rectangle.

khtml/xml/dom_caretposition.h: Made conversion from Position to CaretPosition something you can do implicitly, since it's an unambiguous conversion. Conversion in the other direction needs to be done explicitly. Moved EIncludeLineBreak here, and added startParagraphBoundary and endParagraphBoundary functions.
khtml/xml/dom_caretposition.cpp: (DOM::startParagraphBoundary): Added. Replaces, and made from, member function of DOM::Position. (DOM::endParagraphBoundary): Ditto.

khtml/xml/dom_position.h: Removed EIncludeLineBreak and startParagraphBoundary and endParagraphBoundary.
khtml/xml/dom_position.cpp: Removed startParagraphBoundary and endParagraphBoundary.

khtml/xml/dom_selection.h: Use CaretPosition instead of Position in a few places. Use a QRect for the caret rect. Change nodeIsBeforeNode to be a static member function.
khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Change caret to store QRect instead of 3 separate fields. (DOM::Selection::init): Ditto. (DOM::Selection::operator=): Ditto. (DOM::Selection::modifyExtendingRightForward): Change to use CaretPosition instead of Position. Check for 0. (DOM::Selection::modifyMovingRightForward): Ditto. Check for 0. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Ditto. (DOM::Selection::layoutCaret): Change to use a QRect for the caret rect, and use an empty one to mean no rectangle. (DOM::Selection::getRepaintRect): Ditto. (DOM::Selection::paintCaret): Ditto. (DOM::Selection::validate): Change to use CaretPosition instead of Position. Also fixed PARAGRAPH_BOUNDARY, which was broken and doing the same thing as PARAGRAPH before, but it's not really used so that didn't matter. Check for 0. (DOM::Selection::nodeIsBeforeNode): Tightened up a bit and added some FIXMEs. This function has a number of problems and should probably be discarded in favor of the DOMStringImpl method that does the same thing.

2:16 PM Changeset in webkit [7584] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3787168> REGRESSION (Mail): Deleting text from the beginning of a quoted range removes the quoting from the rest

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::moveNodesAfterNode): Only move the text nodes (and their siblings) when doing this move between blocks. This serves to mimic NSText behavior very well.

11:38 AM Changeset in webkit [7583] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3779150> REGRESSION: images not copied when copying HTML in Safari and pasting into TextEdit

Reviewed by john.

WebView.subproj/WebHTMLView.m:

(-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): use …

for RTFD

WebView.subproj/WebHTMLViewPrivate.h:

Sep 15, 2004:

9:57 PM Changeset in webkit [7582] by darin

2 edits in trunk/WebCore

fixed Panther build

kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityActionDescription:]): Fixed backwards check in #if that was compiling the code on Panther only rather than Tiger only.

5:57 PM Changeset in webkit [7581] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed lockFocus exception I observed; perhaps not a real issue in the field due to exception blocking

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::imageFromRect): Put most of the function inside a big if statement to avoid the exception we get from lockFocus otherwise.

5:57 PM Changeset in webkit [7580] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed <rdar://problem/3786467> REGRESSION (Mail): Reproducible crash replying to an HTML message when your preference is for plain text composing.

khtml/rendering/render_block.h: Remove removeChildrenFromLineBoxes.
khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): Remove calls to removeChildrenFromLineBoxes which was the old way of working around this.
khtml/rendering/render_flow.cpp: (RenderFlow::detach): Add comments and code to handle removing children from line boxes we are about to delete.

5:52 PM Changeset in webkit [7579] by rjw

2 edits in trunk/WebCore

Fixed <rdar://problem/3781561> REGRESSION (Mail): typing in Mail became suddenly really sluggish (substitute font code)

A DocumentMarker may begin before the InLineBox that includes
it. Ensure that we correctly handle that case. The paintMarker()
method and code that calls it could do with some cleanup to
make it clearer how all the cases are handled, i.e. marker
within box, or intersecting beginning or end of box.

Reviewed by Darin.

khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Minimal change to ensure that we handle the case of marker starting before box.

5:51 PM Changeset in webkit [7578] by darin

2 edits in trunk/WebCore

Reviewed by John.

get rid of some of the localizable strings in here; we still have to figure out how we're going to localize the last few role descriptions

kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): Use NSAccessibilityRoleDescription for most descriptions instead of a hard-coded string (inside the UI_STRING placeholder). (-[KWQAccObject accessibilityActionDescription:]): Same thing, with NSAccessibilityActionDescription.

5:46 PM Changeset in webkit [7577] by darin

4 edits in trunk/WebCore

Reviewed by John.

did some QRect-related changes to facilitate later bug fixing

kwq/KWQPainter.h: Added fillRect overload that takes QRect to match the real Qt one.
kwq/KWQPainter.mm: (QPainter::fillRect): Added overload that takes QRect.

kwq/KWQRect.mm: (QRect::QRect): Change default constructed QRect to have a width and height of 0 rather than 1. Contrary to what we believed earlier, this is what Qt does.

5:41 PM Changeset in webkit [7576] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3799512> REGRESSION (Mail): caret flashes 1 pixel too far to the left

khtml/rendering/render_text.cpp: (RenderText::caretRect): Added one to the horizontal position of the caret rect.

5:31 PM Changeset in webkit [7575] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed assertion I saw using the font panel

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _colorAsString:]): Convert color space before trying to get R, G, and B components.

4:55 PM Changeset in webkit [7574] by adele

2 edits in branches/Safari-1-2-branch/WebKit

Code change by Darin, reviewed by me.

further follow-up fix for for <rdar://problem/3791526>

WebView.subproj/WebFrame.m: (+[WebFrame _recursiveCheckCompleteFromFrame:]): Don't call _isLoadCompleted on the child frame again, once is enough. The second time hits an assertion failure. This is already fixed on Tiger.

1:58 PM Changeset in webkit [7573] by kocienda

2 edits
12 adds in trunk

Reviewed by Hyatt

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): The whitespace fixup code that makes sure proper whitespace renders after deletion was getting confused in cases where the deletion merged blocks. Basically, I needed to move some whitespace fixup code so it runs before deleting in the case where blocks need to be merged. It used to run after, and was getting confused by whitespace left over at the ends of the block after the deletion.
layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-012.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-013.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-014.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-015.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-016.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-017.html: Added.

11:26 AM Changeset in webkit [7572] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3802232> REGRESSION (Mail): WebCore Editing must do smart copy

Reviewed by kocienda.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call instance method not class method to get pasteboard types since the types depends on the current selection granularity (-[WebHTMLView pasteboardTypesForSelection]): if the selection granularity is "word" include the smart pasteboard type (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): put nil on the pasteboard for smart copy

11:02 AM Changeset in webkit [7571] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::moveNodesAfterNode): Renamed from moveNodesToBlock. Just some simplification and cleanup in this function. (khtml::DeleteSelectionCommandImpl::doApply): Remove a hunk of start-of-block code I thought I was going to get around to improving and refining. However, I no longer need this case.
khtml/editing/htmlediting_impl.h: Function name change.

10:36 AM Changeset in webkit [7570] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Remove stray change marker.

Sep 14, 2004:

10:57 PM Changeset in webkit [7569] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed <rdar://problem/3788894> REGRESSION (Mail): ctrl-t emacs key binding does not work (transpose)
fixed <rdar://problem/3798946> REGRESSION (Mail): Cursor does not disappear when typing

WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Hide cursor by calling setHiddenUntilMouseMoves:YES. (-[WebHTMLView transpose:]): Added.

10:55 PM Changeset in webkit [7568] by darin

8 edits in trunk/WebCore

Reviewed by Maciej.

added method for fix to <rdar://problem/3788894> REGRESSION (Mail): ctrl-t emacs key binding does not work (transpose)

kwq/WebCoreBridge.h: Added rangeOfCharactersAroundCaret.
kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeOfCharactersAroundCaret]): Added.

khtml/xml/dom_caretposition.h: Added range function to make a Range from two CaretPosition objects.
khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::rangeCompliantEquivalent): Fixed a bug in this that caused it to screw up ranges in text nodes. Also changed it to use offset 0 as Ken and I discussed. (DOM::range): Added.

kwq/DOM.mm: (-[DOMRange description]): Added.

8:05 PM Changeset in webkit [7567] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3786986> REGRESSION: TEXTAREAs have extra wide right margins where the scrollbars used to be

kwq/KWQTextArea.mm: (-[KWQTextArea _updateTextViewWidth]): Renamed from _frameSizeChanged. Now uses the width of the size from the contentSize method rather than trying to compute a size. (-[KWQTextArea initWithFrame:]): Call method by new name. (-[KWQTextArea tile]): Override this instead of setFrame: to adjust the size as the size of the text area changes.

7:59 PM Changeset in webkit [7566] by rjw

2 edits in trunk

Fixed typo in header comment.

7:48 PM Changeset in webkit [7565] by rjw

25 edits in trunk

WebKit:

Add class parameter to object allocation function. This is somewhat redundant, given that the allocation function is in the class function vector, but people wanted to use the same allocation function for different classes.

Renamed NPN_Class to NPN_Invoke to match the name in the function vector.

Add support for a default function on an object. This is a feature that ActiveX supports, and will allow JavaScript code to be written that will look exactly the same for both ActiveX plugins and Netscape or WebKit plugins. There are implementations included for the 'C' and 'Objective-C' bindings.

There bugs are covered by

<rdar://problem/3776343> Support for default functions in the JavaScript bindings
<rdar://problem/3779186> NPN_Call needs to be renamed to NPN_Invoke
<rdar://problem/3674754> Need to implement latest npruntime.h

Reviewed by John.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
Plugins.subproj/WebScriptObject.h:
Plugins.subproj/npfunctions.h:
Plugins.subproj/npruntime.h:

JavaScriptCore:

Add class parameter to object allocation function. This is somewhat redundant, given that the allocation function is in the class function vector, but people wanted to use the same allocation function for different classes.

Renamed NPN_Class to NPN_Invoke to match the name in the function vector.

Add support for a default function on an object. This is a feature that ActiveX supports, and will allow JavaScript code to be written that will look exactly the same for both ActiveX plugins and Netscape or WebKit plugins. There are implementations included for the 'C' and 'Objective-C' bindings.

There bugs are covered by

<rdar://problem/3776343> Support for default functions in the JavaScript bindings
<rdar://problem/3779186> NPN_Call needs to be renamed to NPN_Invoke
<rdar://problem/3674754> Need to implement latest npruntime.h

Reviewed by John.

bindings/NP_jsobject.cpp: (jsAllocate): (NPN_InvokeDefault): (NPN_Invoke):
bindings/c/c_class.cpp:
bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::operator=): (CInstance::invokeMethod): (CInstance::invokeDefaultMethod):
bindings/c/c_instance.h:
bindings/c/c_runtime.cpp:
bindings/c/c_runtime.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeDefaultMethod):
bindings/jni/jni_instance.h:
bindings/npruntime.cpp: (NPN_CreateObject):
bindings/npruntime.h:
bindings/objc/WebScriptObject.h:
bindings/objc/objc_class.mm: (ObjcClass::fallbackObject):
bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::invokeDefaultMethod):
bindings/objc/objc_runtime.h:
bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::get): (ObjcFallbackObjectImp::put): (ObjcFallbackObjectImp::canPut): (ObjcFallbackObjectImp::implementsCall): (ObjcFallbackObjectImp::call): (ObjcFallbackObjectImp::hasProperty): (ObjcFallbackObjectImp::deleteProperty): (ObjcFallbackObjectImp::defaultValue):
bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField): (KJS::Bindings::Instance::valueOf):
bindings/runtime_object.cpp: (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::call):
bindings/runtime_object.h:

WebKitExamples:

Reworked NetscapeMoviePlugIn to better test and illustrate
scripting APIs.

Reviewed by John.

CarbonWeb/MyWebUIAdapter.m: (-[MyWebUIAdapter webView:runJavaScriptAlertPanelWithMessage:]): (-[MyWebUIAdapter webView:runJavaScriptConfirmPanelWithMessage:]): (-[MyWebUIAdapter webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]):
CarbonWeb/TWebWindow.cp:
NetscapeMoviePlugIn/MovieObject.c: Added. (getMovieClass): (initializeIdentifiers): (movieHasProperty): (movieHasMethod): (movieGetProperty): (movieSetProperty): (movieInvoke): (movieInvokeDefault): (movieInvalidate): (movieAllocate): (movieDeallocate): (LoadMovieFromFile): (CreateMovieController): (UpdateMovieFrame): (PlayMovie): (PauseMovie): (IsMovieMuted): (SetMovieMuted): (DestroyMovie): (HandleMovieEvent):
NetscapeMoviePlugIn/MovieObject.h: Added.
NetscapeMoviePlugIn/NetscapeMoviePlugIn.xcode/project.pbxproj:
NetscapeMoviePlugIn/PluginObject.c: Added. (getPluginClass): (initializeIdentifiers): (pluginHasProperty): (pluginHasMethod): (pluginGetProperty): (pluginSetProperty): (pluginInvoke): (pluginInvokeDefault): (pluginInvalidate): (pluginAllocate): (pluginDeallocate):
NetscapeMoviePlugIn/PluginObject.h: Added.
NetscapeMoviePlugIn/main.c: (NP_Initialize): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_StreamAsFile): (NPP_HandleEvent): (NPP_GetValue): (NPP_SetValue):
NetscapeMoviePlugIn/movie.h: Added.
NetscapeMoviePlugIn/movie.html:
makefile:

5:16 PM Changeset in webkit [7564] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/3794735> Gmail- sending a very long message with Safari is so slow it seems like a hang

kjs/string_object.cpp: (StringProtoFuncImp::call): Replaced implementation of replace() method with function below... (replace): In order to avoid excessive allocation and copying, figure out the ranges of the original string and replacement strings to be assembled, instead of constantly creating new strings at each substitution. The old behavior is basically O(N^{2)
for a global replace on a pattern that matches many places in the
string.
(regExpIsGlobal): Helper function for the above.
(expandSourceRanges): ditto
(pushSourceRange): ditto
(expandReplacements): ditto
(pushReplacement): ditto}
kjs/ustring.cpp: (KJS::UString::spliceSubstringsWithSeparators): New method that pieces together substring ranges of this string together with specified separators, all at one go.
kjs/ustring.h: (KJS::UString::Range::Range): Added new helper class to represent substring choices.

4:59 PM Changeset in webkit [7563] by vicki

6 edits in branches/Safari-1-2-branch/WebCore

roll the fix for 3710123 in

2004-09-13 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari (Oracle Portal)

This is a more complete fix, but it requires the previous attempt at a fix for this same
bug below, because this is only the "don't destroy the KHTMLPart" portion; other fixes are
still needed to survive shutdown of the part.

khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::interpreter): Call the new keepAlive method. This is called whenever we're about to use an interpreter to run some JavaScript, and it's JavaScript that might destroy the part, hence the interpreter.

khtml/khtml_part.h: Added keepAlive() and slotEndLifeSupport() member functions.
khtml/khtmlpart_p.h: Added m_lifeSupportTimer.
khtml/khtml_part.cpp: (KHTMLPart::init): Connects m_lifeSupportTimer to slotEndLifeSupport. (KHTMLPart::write): Removed old attempt to work around this issue. (KHTMLPart::end): Ditto. (KHTMLPart::keepAlive): Added. References the part, then sets up a one-shot timer. (KHTMLPart::slotEndLifeSupport): Added. Stops the timer and then removes the reference from the part, possibly destroying it.

kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Added the new slot to the list of slots. (KWQSlot::call): Ditto.

4:41 PM Changeset in webkit [7562] by vicki

4 edits in branches/Safari-1-2-branch/WebCore

roll the fix for <rdar://problem/3791496> back in

4:41 PM Changeset in webkit [7561] by cblu

3 edits in trunk/WebCore

Backed out my changes to these files. They were not meant to be checked. (I'm having a bad CVS day)

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:]): (-[WebCoreBridge replaceSelectionWithNode:selectReplacement:]): (-[WebCoreBridge replaceSelectionWithMarkupString:baseURLString:selectReplacement:]): (-[WebCoreBridge replaceSelectionWithText:selectReplacement:]):

4:41 PM Changeset in webkit [7560] by hyatt

4 edits in trunk/WebCore

Fix the crash in the layout tests caused by my recent selection changes. Simply eliminate the buggy
selection border setting code and let isSelectionBorder be implemented in terms of the SelectionState.

Reviewed by kocienda

khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::container): (RenderObject::isSelectionBorder):
khtml/rendering/render_object.h: (khtml::RenderObject::minMaxKnown): (khtml::RenderObject::setReplaced):

4:35 PM Changeset in webkit [7559] by cblu

4 edits in trunk/WebCore

Fixed: <rdar://problem/3778680> REGRESSION: plug-in content sometimes doesn't show up

Reviewed by dave.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::parseHTMLAttribute): set needWidgetUpdate to true only if there is a renderer (HTMLObjectElementImpl::attach): if needWidgetUpdate is true, call updateWidget

3:14 PM Changeset in webkit [7558] by mjs

4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

fixed <rdar://problem/3800315> encode-URI-test layout test is failing

kjs/function.cpp: (KJS::GlobalFuncImp::call): Make sure to escape null characters. This is a bug in the new code that made part of the test fail.

WebCore:

Reviewed by Darin.

fixed <rdar://problem/3800315> encode-URI-test layout test is failing
updated escape/encodeURI layout test to match our new, more compatible behavior.

layout-tests/fast/js/global/encode-URI-test.html:

3:03 PM Changeset in webkit [7557] by kocienda

2 edits
2 adds in trunk

Reviewed by Richard

Fix for this bug:

<rdar://problem/3800834> REGRESSION (Mail): Can't delete backwards past quoted text using HTML editing

khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::issueCommandForDeleteKey): Use CaretPosition class to get superior smarts about the selection to delete in the "start of block" case. This fixes the bug. While I was in the neighborhood, I cleaned up this function a bit.
layout-tests/editing/deleting/delete-3800834-fix-expected.txt: Added.
layout-tests/editing/deleting/delete-3800834-fix.html: Added.

1:48 PM Changeset in webkit [7556] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/css/parser.cpp: Did not regenerate this file from parser.y before last checkin.

1:34 PM Changeset in webkit [7555] by cblu

4 edits in trunk/WebCore

Fixed typos in last check-in.

khtml/khtml_part.cpp: (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventDoubleClick):
khtml/khtml_part.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent):

1:16 PM Changeset in webkit [7554] by hyatt

13 edits in trunk/WebCore

Fix for 3667862, regression where dragging of selection became really slow. This patch completely rewrites
selection painting and drawing so that the enclosing rect is much more snug. The containing block rect is no
longer used at all.

Reviewed by NOBODY (OOPS!).

khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): (getSelectionInfo): (RenderCanvas::setSelection): (RenderCanvas::clearSelection):
khtml/rendering/render_canvas.h:
khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
khtml/rendering/render_image.cpp: (RenderImage::selectionRect): (RenderImage::selectionTintColor): (RenderImage::paint):
khtml/rendering/render_image.h:
khtml/rendering/render_object.cpp: (RenderObject::selectionStartEnd):
khtml/rendering/render_object.h: (khtml::RenderObject::selectionRect): (khtml::RenderObject::SelectionInfo::object): (khtml::RenderObject::SelectionInfo::rect): (khtml::RenderObject::SelectionInfo::state): (khtml::RenderObject::SelectionInfo::SelectionInfo): (khtml::RenderObject::SelectionInfo::m_state):
khtml/rendering/render_text.cpp: (InlineTextBox::textObject): (InlineTextBox::selectionRect): (InlineTextBox::paintSelection): (RenderText::getAbsoluteRepaintRect): (RenderText::selectionRect):
khtml/rendering/render_text.h:
kwq/KWQPainter.mm: (getBlendedColorComponent): (QPainter::selectedTextBackgroundColor):

1:16 PM Changeset in webkit [7553] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3794376> vertical formatting lines that show quote level are missing

Rolling out change Dave made to fix 3787686. It turns out that we do not want this
change, as it does not appear to have any effect on the bug. In addition, it caused
the regression in quote bar behavior.

khtml/css/parser.cp
khtml/css/parser.y

11:52 AM Changeset in webkit [7552] by cblu

2 edits in trunk/WebCore

Fixed: Control-click shouldn't cause deselect when clicking selection.

Reviewed by rjw.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): don't attempt to select the closest word when the selection is clicked

11:42 AM Changeset in webkit [7551] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge these changes for <rdar://problem/3800366>

2004-09-13 Richard Williamson <rjw@apple.com>

D'oh. How many times can I screw up a simple fix!

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

2004-09-13 Richard Williamson <rjw@apple.com>

Fixed snafu from 3782533 checkin.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

2004-09-10 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/3782533> CrashTracer: .1459 crashes at com.apple.WebKit: -[WebTextRenderer
initWithFont:usingPrinterFont:] + 0x138

We were explicitly failing when we encountered deprecated fonts.
(Those with unsupported glyph packings).
Deprecated fonts should only appear on a system that have
stuff migrated from OS 9. Ugh, thats probably why we've never seen
the problem here.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

11:29 AM Changeset in webkit [7550] by cblu

2 edits in trunk/WebCore

Fixed badness that my last patch caused. Because there was a conflict, my last patch added stuff that darin had just removed.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): don't call deref on the view

11:13 AM Changeset in webkit [7549] by cblu

4 edits in trunk/WebCore

Fixed: <rdar://problem/3783595> REGRESSION (Mail): control-click does not select closest word

Reviewed by kocienda.

khtml/khtml_part.cpp: (KHTMLPart::selectionGranularity): new getter, need this for an upcoming patch (KHTMLPart::selectClosetWordFromMouseEvent): new, factored from handleMousePressEventDoubleClick (KHTMLPart::handleMousePressEventDoubleClick): call selectClosetWordFromMouseEvent
khtml/khtml_part.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): call selectClosetWordFromMouseEvent if nothing swallows the event

9:54 AM Changeset in webkit [7548] by kocienda

2 edits
2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3800346> Inserting newline in BR after block not working

khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): The code to insert the "extra" BR at the end of blocks (hack done to make BRs show up when they appear at the ends of blocks) did not cover this one quirky case where the insertion point can be placed in a BR at the end of a block that does actually render. Now the input newline code can handle this addtional case.
layout-tests/editing/selection/insert-3800346-fix-expected.txt: Added.
layout-tests/editing/selection/insert-3800346-fix.html: Added.

9:22 AM Changeset in webkit [7547] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3479392> REGRESSION (Mail): select all does not select all at some pages

khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::deepEquivalent): Use caretMaxOffset instead of maxOffset when descending to the last node. Also change around the function a bit.

Sep 13, 2004:

11:03 PM Changeset in webkit [7546] by darin

7 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari (Oracle Portal)

This is a more complete fix, but it requires the previous attempt at a fix for this same
bug below, because this is only the "don't destroy the KHTMLPart" portion; other fixes are
still needed to survive shutdown of the part.

khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::interpreter): Call the new keepAlive method. This is called whenever we're about to use an interpreter to run some JavaScript, and it's JavaScript that might destroy the part, hence the interpreter.

khtml/khtml_part.h: Added keepAlive() and slotEndLifeSupport() member functions.
khtml/khtmlpart_p.h: Added m_lifeSupportTimer.
khtml/khtml_part.cpp: (KHTMLPart::init): Connects m_lifeSupportTimer to slotEndLifeSupport. (KHTMLPart::write): Removed old attempt to work around this issue. (KHTMLPart::end): Ditto. (KHTMLPart::keepAlive): Added. References the part, then sets up a one-shot timer. (KHTMLPart::slotEndLifeSupport): Added. Stops the timer and then removes the reference from the part, possibly destroying it.

kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Added the new slot to the list of slots. (KWQSlot::call): Ditto.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Removed an old attempt to work around this same issue. (KWQKHTMLPart::mouseDown): Ditto. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto. (KWQKHTMLPart::sendContextMenuEvent): Ditto.

9:48 PM Changeset in webkit [7545] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed regression caused by change earlier today

khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Use CaretPosition for CHARACTER, not WORD.

6:02 PM Changeset in webkit [7544]

9 copies
4 deletes in tags/JavaScriptCore-125~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~6'.

6:02 PM Changeset in webkit [7543] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

fix a typo in my last change, whoops!

kjs/property_map.cpp: (KJS::PropertyMap::put):

5:56 PM Changeset in webkit [7542] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

initialize deletedElementIndex to 0 to make the compiler happy

kjs/property_map.cpp: (KJS::PropertyMap::put):

5:37 PM Changeset in webkit [7541]

23 copies
3 deletes in tags/WebKit-125~5~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~1'.

5:37 PM Changeset in webkit [7540] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

versioning for SUPanNavy, WebKit-125.5.1

5:32 PM Changeset in webkit [7539]

68 copies
2 deletes in tags/WebCore-125~8~8

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~8'.

5:32 PM Changeset in webkit [7538] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

versioning for SUPanNavy, WebCore-125.8.8

5:27 PM Changeset in webkit [7537] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

versioning for SUPanNavy, JavaScriptCore-125.6

5:03 PM Changeset in webkit [7536] by vicki

4 edits in branches/Safari-1-2-branch/WebCore

roll the fix for <rdar://problem/3791496> off the branch, since we won't be including this in SUPanNavy

2004-08-10 Darin Adler <Darin Adler>

Reviewed by Trey.

fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari

I fixed three problems:

1) script interpreter destroyed while it was interpreting scripts, caused random havoc
2) code trying to get to view after view was detached from part, caused nil-deref
3) signals sent to parent after child was no longer in the parent's frames list, caused nil-deref

Now the test page works fine. Hope the real sites do too.

khtml/khtml_part.h: Add connectChild and disconnectChild helper functions (private).
khtml/khtml_part.cpp: (KHTMLPart::clear): Call disconnectChild on each frame as we detach it (see below). (KHTMLPart::end): Ref the part at the start, and deref the part at the end, of this function. Otherwise, we can end up destroying the part, and hence the interpreter, inside a script that the interpreter itself is running. (KHTMLPart::slotFinishedParsing): Add another check for a nil m_view, after the call to checkCompleted. (KHTMLPart::checkCompleted): Remove bogus if statement with empty body. (KHTMLPart::processObjectRequest): Call disconnectChild to disconnect the child <-> parent signals of the old child that the new one is replacing, and connectChild to connect the signals (nicer factoring). (KHTMLPart::slotChildCompleted): Fixed up a confusing boolean if/expression to be simpler. Not related to the bug fix, but an earlier version of the fix had changes in this function. (KHTMLPart::connectChild): Added. Connects the appropriate signals for a child frame. (KHTMLPart::disconnectChild): Added. Disconnects the same signals that connectChild connects.

kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Added a call to disconnectChild before removing the child from the frames list.

3:45 PM Changeset in webkit [7535] by darin

2 edits in trunk/WebCore

Reviewed by Kevin.

fixed <rdar://problem/3798453> DIG failure: getting variable with same name as DOM element attribute gets attribute value instead

khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): When adding current target and other event handler scope, put it below the existing scope chain. This ensures that things found in the function's scope will come before the event handler, as in other browsers.

3:44 PM Changeset in webkit [7534] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Kevin and Maciej.

new function to support fix for DIG bug in WebCore

kjs/scope_chain.h: Added new push function that pushes another entire scope chain.
kjs/scope_chain.cpp: (KJS::ScopeChain::push): Ditto.

2:36 PM Changeset in webkit [7533] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3798346> REGRESSION (125-162): crash pushing down arrow key on KLM.com site

khtml/xml/dom_position.cpp: (DOM::Position::nextLinePosition): This function was being called in a case where it was not expected until we traced the code. It has to do with some deeper issues associated with handling arrow keys, resulting in the editing arrow-down code running in a case where we are not editing. I discussed this with Darin, and we decided to handle the broader issues at a later date. The fix I am checking in here to fix the bug is merely avoiding a null-deref.

1:38 PM Changeset in webkit [7532] by rjw

2 edits in trunk/WebKit

D'oh. How many times can I screw up a simple fix!

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

1:17 PM Changeset in webkit [7531] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3784840> REGRESSION (Mail): Text is inserted in the wrong place after changing typing style

khtml/editing/htmlediting_impl.cpp: (khtml::InputTextCommandImpl::prepareForTextInsertion): Code to handle typing style did not check to see if the reference node used for the DOM node insertion operation was a block. If it is, then the new node containing the new editing style now is inserted at the start of the block, instead of after it.

12:32 PM Changeset in webkit [7530] by rjw

2 edits in trunk/WebKit

Fixed snafu from 3782533 checkin.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

11:39 AM Changeset in webkit [7529] by kocienda

2 edits
4 adds in trunk

Reviewed by me

Added a couple new layout tests to cover recent changes.

layout-tests/editing/editing.js: Added some new functions to do by-word selection movement.
layout-tests/editing/selection/move-backwords-by-word-001-expected.txt: Added.
layout-tests/editing/selection/move-backwords-by-word-001.html: Added.
layout-tests/editing/selection/selection-3748164-fix-expected.txt: Added.
layout-tests/editing/selection/selection-3748164-fix.html: Added.

11:25 AM Changeset in webkit [7528] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3765519> REGRESSION (Mail): word movement goes too far upstream at start of line

khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Use downstream position here when making final placement of caret.

11:09 AM Changeset in webkit [7527] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

fix merge errors from <rdar://problem/3773150>

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write):
khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending):

11:06 AM Changeset in webkit [7526] by kocienda

13 edits
5 adds in trunk/WebCore

Reviewed by Darin

Various editing improvements, many focused on the improvements made possible by the
new CaretPosition class.

Includes fixes for these bugs:

<rdar://problem/3748164> REGRESSION (Mail): Arrow navigation in typical mail message can result in stuck caret
<rdar://problem/3782062> REGRESSION (Mail): option-delete can delete almost all of a message when it has trouble finding a word
<rdar://problem/3790456> triple click does not select entire paragraph (folklore.org)

WebCore.pbproj/project.pbxproj: Added CaretPosition class files.
khtml/dom/dom2_range.h: (DOM::offsetInCharacters): Moved this helper here from khtml_text_operations.cpp. This function helps to determine how to interpret the offsets used in DOM Ranges.
khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Use CaretPosition class to make "end-of-block" determination. Also, fix a caret placement glitch in "case 1" in the code: Place the caret in the node after the inserted BR. This makes it show up in the right place.
khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): Don't limit double-click and triple-click handling only to text nodes. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::selectAll): Use CaretPosition class to implement improved selectAll.
khtml/misc/khtml_text_operations.cpp: (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Make a fix to the initial state setting of m_handledChildren. This is true if the offset into the end node is 0, meaning that we do not want to descend into its children at all.
khtml/xml/dom_caretposition.cpp: Added.
khtml/xml/dom_caretposition.h: Added.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): Fix bugs with the stayWithin implementation. We could miss nodes we want to test due to an erroneous check of stayWithin when no such check is needed. (NodeImpl::traverseNextSibling): Ditto. (NodeImpl::traversePreviousNodePostOrder): Ditto.
khtml/xml/dom_position.cpp: (DOM::Position::Position): Remove spurious semi-colon. (DOM::Position::upstream): Move incoming Position to its equivalentDeepPosition. This is part of the transition that will make this code work better with increased use of CaretPosition. (DOM::Position::downstream): Ditto. (DOM::Position::atStartOfContainingEditableBlock): Removed. Dead code; was not being called. (DOM::Position::atStartOfRootEditableElement): Removed. Dead code; was not being called. (DOM::Position::isLastRenderedPositionInEditableBlock): Removed. Replaced with calls to CaretPosition class. (DOM::Position::inLastEditableInRootEditableElement): Removed. Dead code; was not being called. (DOM::Position::inFirstEditableInRootEditableElement): Removed. Was only being called by other code that has been removed.
khtml/xml/dom_position.h:
khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Moved implementation of CHARACTER case to use CaretPosition class instead of Position class helpers. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::validate): Made simplifications in code that used to call a concoction of Position class helpers to do the right thing. Now calls CaretPosition equivalents.

10:56 AM Changeset in webkit [7525] by cblu

3 edits in trunk/WebKit

Support for: <rdar://problem/3794790> drop rate or time remaining from download status when window is too small to fit it

Reviewed by john.

Misc.subproj/WebStringTruncator.h:
Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator widthOfString:font:]): new

10:19 AM Changeset in webkit [7524] by kocienda

3 edits in trunk

Reviewed by me

This test was broken. The result is that it was not testing what it was supposed to
be testing. I fixed the test and updated the expected results.

layout-tests/editing/selection/move-between-blocks-no-001-expected.txt
layout-tests/editing/selection/move-between-blocks-no-001.html

9:43 AM Changeset in webkit [7523] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for these bugs:

<rdar://problem/3784835> REGRESSION (Mail): crash in DOM::ElementImpl::tagName inside delete text command code while editing a Mail message
<rdar://problem/3788015> REGRESSION (Mail): Crash deleting before a blockquote
<rdar://problem/3796366> REGRESSION (Mail): Crash Mail by deleting the right line from pasted HTML

khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): All of these bugs are due to the same problem. When I made the delete command run even when the text is a caret (to make block merges work right when the caret is at the start of a block), I failed to handle one case when there might be no text to delete. This resulted in a call to the DeleteTextCommand with a zero-length deletion request. This is not supported. Now, I have added an additional test in this one place in the code that was causing all these failures.

Sep 12, 2004:

11:23 PM Changeset in webkit [7522] by darin

2 edits in trunk/JavaScriptCore

tests/mozilla/expected.html: Updated test results for 3 more tests that pass with the new version of escape and unescape.

11:22 PM Changeset in webkit [7521] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed <rdar://problem/3798209> any non-ASCII characters are garbled in the result of toLocaleString

kjs/date_object.cpp: (formatLocaleDate): Replaced two old functions that used LongDateTime with this one new function that uses CFDateFormatter. (DateProtoFuncImp::call): Call the new formatLocaleDate instead of both formatLocaleDate and formatLocaleTime.

11:05 PM Changeset in webkit [7520] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3797758> REGRESSION (155-156): Cannot tab between input fields at switchboard.com

kwq/KWQLineEdit.mm: (QLineEdit::selectAll): Use setFocus() instead of calling makeFirstResponder directly since it handles the case where the field editor has focus.

11:05 PM Changeset in webkit [7519] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3792082> zero character codes in UTF-16 input cause crash

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Fixed code that was using the wrong variable to decrement the input length, causing buffer overrun.

11:04 PM Changeset in webkit [7518] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3798240> computed style error log messages seen with numbers in the range 74-77

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for CSS_PROPKHTML_MARQUEE_INCREMENT, CSS_PROP_MAX_HEIGHT, CSS_PROP_MAX_WIDTH, CSS_PROP_MIN_HEIGHT, CSS_PROP_MIN_WIDTH, and CSS_PROP_VISIBILITY.

11:03 PM Changeset in webkit [7517] by darin

1 edit
1 delete in trunk

layout-tests/css1/text_properties/text-transform-expected.txt: Removed unused test result.

Sep 11, 2004:

1:22 AM Changeset in webkit [7516] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3787208> can't log in to SAP SDN site (JS parse error)

kwq/KWQKURL.mm: (KURL::decode_string): Check for find result >= 0 instead of >0, to handle case of first character in a string being encoded.

Sep 10, 2004:

4:26 PM Changeset in webkit [7515] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3782533> CrashTracer: .1459 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 0x138

We were explicitly failing when we encountered deprecated fonts.
(Those with unsupported glyph packings).
Deprecated fonts should only appear on a system that have
stuff migrated from OS 9. Ugh, thats probably why we've never seen
the problem here.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

4:15 PM Changeset in webkit [7514] by vicki

4 edits in branches/Safari-1-2-branch/WebCore

merge these changes for SUPanNavy, <rdar://problem/3773150>

2004-08-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

fixed <rdar://problem/3752509> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

(actually the previous fix for this bug was mostly correct, but
this additional change is needed to avoid the regression in
<rdar://problem/3751025> REGRESSION: website rejects Safari 125.9
as "need to upgrade to IE 6", but didn't reject 125.8

So if merging for a software update, make sure to include both
this and the previous fix.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): When there is an immediate reidrect pending, make sure to stop tokenizing, because we need to make sure no further script tags are processed beyond the one that triggered the redirect.
khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): New method to allow checking if a redirect is pending.
khtml/khtml_part.h:

2004-06-18 John Sullivan <sullivan@apple.com>

Reviewed by Darin

fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

4:12 PM Changeset in webkit [7513] by vicki

3 edits in branches/Safari-1-2-branch/WebKit

WebKit:

merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <sullivan@apple.com>

Reviewed by Chris.

added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.

WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method

WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <sullivan@apple.com>

Reviewed by Chris.

changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.

BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.

3:21 PM Changeset in webkit [7512] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.

WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method

WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

Reviewed by Chris.

changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.

BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.

1:53 PM Changeset in webkit [7511] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

code changes by Darin, reviewed by Vicki

Fix build breakage on the branch caused by bad merging for <rdar://problem/3772916> controls
on page at http://help.sap.com don't work properly (clone for SUPanNavy)

khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/ecma/kjs_window.cpp: (Window::Window): (BarInfo::BarInfo):

9:18 AM Changeset in webkit [7510] by cblu

1 edit in trunk/WebKit/ChangeLog

Fixed previous "Reviewed by" line.

ChangeLog:

8:58 AM Changeset in webkit [7509] by cblu

10 edits in trunk

WebCore:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

khtml/khtml_part.h: (KHTMLPart::didFirstLayout): new
khtml/khtmlview.cpp: (KHTMLView::layout): call didFirstLayout
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::didFirstLayout): new
kwq/WebCoreBridge.h:

WebKit:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by NOBODY (OOPS!).

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didFirstLayout]): new
WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFirstLayoutInFrame:]): new
WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController startRSSAnimationForFrame:error:]): new (-[BrowserWindowController webFrameLoadDidFirstLayout:]): new (-[BrowserWindowController webFrameLoadFinished:withError:]): call startRSSAnimationForFrame:error:
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): added toggle for RSS animation (-[BrowserDocument toggleRSSAnimateAfterFirstLayout:]): new (-[BrowserDocument validate_toggleRSSAnimateAfterFirstLayout:]): new
LocationChangeHandler.m: (-[LocationChangeHandler webView:didFirstLayoutInFrame:]): new
PreferenceKeys.h:

Sep 9, 2004:

7:31 PM Changeset in webkit [7508] by rjw

7 edits
2 adds in trunk/WebKit

Alternate implementation of image rendering. Use CGImageRefs instead
of NSImages.

Mostly works, but currently disabled because of issues w/ CG.

Reviewed by Chris.

ChangeLog:
WebCoreSupport.subproj/WebImageData.h: Added.
WebCoreSupport.subproj/WebImageData.m: Added. (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData finalize]): (-[WebImageData copyWithZone:]): (-[WebImageData numberOfImages]): (-[WebImageData currentFrame]): (-[WebImageData _invalidateImages]): (-[WebImageData imageAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDuration]): (-[WebImageData _repetitionCount]): (-[WebImageData isAnimationFinished]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]): (-[WebImageData _stopAnimation]): (-[WebImageData _nextFrame:]): (-[WebImageData animate]):
WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer retainOrCopyIfNeeded]): (-[WebImageRenderer resize:]): (-[WebImageRenderer size]): (-[WebImageRenderer MIMEType]): (-[WebImageRenderer frameCount]): (-[WebImageRenderer isNull]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (-[WebImageRenderer tileInRect:fromPoint:context:]): (-[WebImageRenderer _startOrContinueAnimationIfNecessary]): (+[WebImageRenderer stopAnimationsInView:]): (-[WebImageRenderer stopAnimation]): (-[WebImageRenderer targetAnimationRect]): (-[WebImageRenderer increaseUseCount]): (-[WebImageRenderer decreaseUseCount]): (-[WebImageRenderer flushRasterCache]): (-[WebImageRenderer imageRef]): (-[WebImageRenderer TIFFRepresentation]): (-[WebImageRenderer image]):
WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): (-[WebImageRendererFactory imageRendererWithSize:]): (-[WebImageRendererFactory imageRendererWithName:]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebImageView.m: (-[WebImageView image]):

6:52 PM Changeset in webkit [7507] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by Richard.

<rdar://problem/3493140> REGRESSION (85-100): cedille displays %-escaped in JavaScript message at hotmail.com

kjs/function.cpp: (KJS::GlobalFuncImp::call): Replace our escape() and unescape() implementations with ones from KDE KJS, which have the proper latin-1 behavior to match Win IE.
kjs/lexer.cpp: (Lexer::isHexDigit): Made static and non-const.
kjs/lexer.h:

6:41 PM Changeset in webkit [7506] by vicki

3 edits in trunk

change version number to 2.0, 164u for TOT

6:29 PM Changeset in webkit [7505]

3 copies in tags/Safari-163

This commit was manufactured by cvs2svn to create tag 'Safari-163'.

6:29 PM Changeset in webkit [7504] by vicki

6 edits in trunk

Safari-163 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (163 in both cases).

6:02 PM Changeset in webkit [7503] by mjs

13 edits in trunk/WebCore

roll out the last change, it appears to cause a performance regression

khtml/rendering/render_box.cpp: (RenderBox::caretRect):
khtml/rendering/render_box.h:
khtml/rendering/render_br.cpp: (RenderBR::caretRect):
khtml/rendering/render_br.h:
khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
khtml/rendering/render_flow.h:
khtml/rendering/render_object.cpp: (RenderObject::caretRect):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (RenderText::caretRect):
khtml/rendering/render_text.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

6:01 PM Changeset in webkit [7502] by mjs

2 edits in trunk/WebKit

rolled out last two changes, they seem to cause a performance regression

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):

3:25 PM Changeset in webkit [7501] by mjs

2 edits in trunk/WebKit

fixed build

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):

2:02 PM Changeset in webkit [7500] by mjs

15 edits in trunk

WebCore:

Reviewed by Dave.

WebCore part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): New method to compute the rect for a DOMRange, or if the range is split into multiple lines, the rect for the part on the first line only.

khtml/rendering/render_object.cpp: (RenderObject::caretRect): Added extraWidthToEndOfLine parameter and ditto for the overrides below.
khtml/rendering/render_object.h:
khtml/rendering/render_box.cpp: (RenderBox::caretRect):
khtml/rendering/render_box.h:
khtml/rendering/render_br.cpp: (RenderBR::caretRect):
khtml/rendering/render_br.h:
khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
khtml/rendering/render_flow.h:
khtml/rendering/render_text.cpp: (RenderText::caretRect):

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method, and translate to screen coordinates.

10:56 AM Changeset in webkit [7499]

21 copies
3 deletes in tags/WebKit-125~5

This commit was manufactured by cvs2svn to create tag 'WebKit-125~5'.

10:56 AM Changeset in webkit [7498] by vicki

1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

add release marker and comment for WebKit-125.5

10:49 AM Changeset in webkit [7497] by vicki

1 edit in branches/Safari-1-2-branch/WebKit/WebKit.pbproj/project.pbxproj

change the WebKit version number from 125.4.2 to 125.5, for Security Update

8:00 AM Changeset in webkit [7496] by darin

20 edits in trunk

WebCore:

Reviewed by Ken.

fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)

khtml/khtml_part.h: Added mark and setMark.
khtml/khtmlpart_p.h: Added m_mark.
khtml/khtml_part.cpp: (KHTMLPart::mark): Added. (KHTMLPart::setMark): Added.

kwq/KWQKHTMLPart.h: Change name of markedRange to markedTextRange to decrease the change it will be confused with the mark.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Update for name change. (KWQKHTMLPart::markedTextRange): Ditto. (KWQKHTMLPart::setMarkedTextRange): Ditto.

khtml/rendering/render_text.cpp: (RenderText::paint): Update for name change.

kwq/WebCoreBridge.h: Remove setSelectionFrom, selectionStart, selectionStartOffset, selectionEnd, selectionEndOffset, and clearMarkedDOMRange. Renamed setMarkedDOMRange to setMarkedTextDOMRange and markedDOMRange to markedTextDOMRange. Added setMarkDOMRange and markDOMRange for the Emacs "mark".
kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkDOMRange:]): Added. (-[WebCoreBridge markDOMRange]): Added. (-[WebCoreBridge setMarkedTextDOMRange:]): Renamed. (-[WebCoreBridge markedTextDOMRange]): Renamed.

khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Make paragraph positions canonical by using deep rendered positions. Maybe someday this won't be an ad hoc decision any more.

khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::removeChildren): Use ref and deref rather than the unconventional check for 0 refCount. This makes us a bit more robust against a node going away partway through the removal process.

WebCore.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3.

WebKit:

Reviewed by Ken.

fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)

WebKit.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3 and add -fobjc-exceptions so we can use new exceptions.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView setMark:]): Added. (unionDOMRanges): Added. (-[WebHTMLView deleteToMark:]): Added. (-[WebHTMLView selectToMark:]): Added. (-[WebHTMLView swapWithMark:]): Added. (-[WebHTMLView markedRange]): Updated for change to bridge method names. (-[WebHTMLView hasMarkedText]): Ditto. (-[WebHTMLView unmarkText]): Ditto. (-[WebHTMLView _selectMarkedText]): Ditto. (-[WebHTMLView _selectRangeInMarkedText:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView _insertText:selectInsertedText:]): Removed check for empty string. An empty string should not be filtered out here. We need to allow inserting an empty string. (-[WebHTMLView _selectionIsInsideMarkedText]): Updated for change to bridge method names. (-[WebHTMLView _updateSelectionForInputManager]): Ditto.

WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Changed to use selectionDOMRange instead of selectionStart.

WebView.subproj/WebHTMLRepresentation.h: Removed unused setSelectionFrom method.
WebView.subproj/WebHTMLRepresentation.m: Ditto.

Sep 8, 2004:

4:56 PM Changeset in webkit [7495] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

check in regenerated file khtml/ecma/kjs_window.lut.h, for 3772916

khtml/ecma/kjs_window.lut.h: (KJS::):

4:53 PM Changeset in webkit [7494] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

fixed the localization aspect of: <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

We now have all the strings ready for localization; we just don't actually use them yet.

English.lproj/Localizable.strings: updated for this change

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setUndoActionNamePlaceholder]): added this placeholder method whose purpose is to hold localizable strings for all the Undo action names that NSTextView uses. Later we will use some or all of these, but we can do that part after the localization freeze.

WebBrowser:

Reviewed by Darin.

English.lproj/StringsNotToBeLocalized.txt: updated for my recent changes

4:43 PM Changeset in webkit [7493] by vicki

4 edits in branches/Safari-1-2-branch/WebCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3791496>

2004-08-10 Darin Adler <Darin Adler>

Reviewed by Trey.

fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari

I fixed three problems:

1) script interpreter destroyed while it was interpreting scripts, caused random havoc
2) code trying to get to view after view was detached from part, caused nil-deref
3) signals sent to parent after child was no longer in the parent's frames list, caused nil-deref

Now the test page works fine. Hope the real sites do too.

khtml/khtml_part.h: Add connectChild and disconnectChild helper functions (private).
khtml/khtml_part.cpp: (KHTMLPart::clear): Call disconnectChild on each frame as we detach it (see below). (KHTMLPart::end): Ref the part at the start, and deref the part at the end, of this function. Otherwise, we can end up destroying the part, and hence the interpreter, inside a script that the interpreter itself is running. (KHTMLPart::slotFinishedParsing): Add another check for a nil m_view, after the call to checkCompleted. (KHTMLPart::checkCompleted): Remove bogus if statement with empty body. (KHTMLPart::processObjectRequest): Call disconnectChild to disconnect the child <-> parent signals of the old child that the new one is replacing, and connectChild to connect the signals (nicer factoring). (KHTMLPart::slotChildCompleted): Fixed up a confusing boolean if/expression to be simpler. Not related to the bug fix, but an earlier version of the fix had changes in this function. (KHTMLPart::connectChild): Added. Connects the appropriate signals for a child frame. (KHTMLPart::disconnectChild): Added. Disconnects the same signals that connectChild connects.

kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Added a call to disconnectChild before removing the child from the frames list.

4:13 PM Changeset in webkit [7492] by cblu

1 edit in trunk/WebKit/ChangeLog

Fixed previous "Reviewed by" line.

ChangeLog:

4:12 PM Changeset in webkit [7491] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3778785> REGRESSION (Mail): copying from MS word and pasting into editable region leaves internal clipboard data

Reviewed by NOBODY (OOPS!).

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ignore Microsoft's header meta data

3:23 PM Changeset in webkit [7490] by vicki

3 edits in branches/Safari-1-2-branch/WebCore

A few follow up changes necessary to really fix the colgroup crash, <rdar://problem/3791559>. I've included the original ChangeLog comments below. I did not merge the changes in render_block.cpp to eliminate redundant setPos -500000 calls, since those weren't necessary for this fix.

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):

2004-09-01 David Hyatt <hyatt@apple.com>

Fix for 3769409, a regression from 10.3.4 to 10.3.5 involving <colgroup>s in malformed HTML.

Reviewed by mjs

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

2004-09-01 David Hyatt <hyatt@apple.com>

Fix for the <colgroup> crasher. Make sure adding to an anonymous box just returns immediately. Also eliminate
all the redundant setPos -500000 calls, since we don't need those at all.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):

3:07 PM Changeset in webkit [7489] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

follow-up fix for <rdar://problem/3791526>, for SUPanNavy

2004-08-13 Darin Adler <Darin Adler>

Reviewed by Chris.

fixed <rdar://problem/3760924> Carbon path passed in NPP_StreamAsFile must be in local character set, not UTF-8

Plugins.subproj/WebBaseNetscapePluginStream.m: (CarbonPathFromPOSIXPath): Added. New function that uses the path pieces from an FSSpec. This has many advantages; the big one that fixes the bug is that it gives the mangled names that work even for files that have names that can't otherwise be encoded in Carbon-style path names. I didn't write this from scratch: I started with the method in Foundation and just changed it to use FSSpec. (-[WebBaseNetscapePluginStream destroyStream]): Remove code that used NSString and just call CarbonPathFromPOSIXPath instead.

2:48 PM Changeset in webkit [7488] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3792893> WebBaseResourceHandleDelegate always returns cached data for subresource loads

Reviewed by rjw.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]): new (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceForRequest:

2:46 PM Changeset in webkit [7487] by mjs

3 edits in trunk/WebCore

fixed deployment build problems noticed by Grant

khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
khtml/rendering/render_text.cpp: (RenderText::caretRect):

1:26 PM Changeset in webkit [7486] by hyatt

2 edits in trunk/WebCore

Fix XML so that elements with no namespace never make HTML elements (when their names coincidentally match).

Reviewed by rjw

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS):

1:04 PM Changeset in webkit [7485] by cblu

1 edit
4 adds in trunk/WebKit

Forgot to add this in previous check-in.

English.lproj/WebViewEditingContextMenu.nib: Added.

12:26 PM Changeset in webkit [7484] by mjs

15 edits in trunk/WebCore

Reviewed by John.

renamed caretPos to caretRect and made it return a QRect instead of taking four out parameters by reference.

khtml/rendering/render_box.cpp: (RenderBox::caretRect):
khtml/rendering/render_box.h:
khtml/rendering/render_br.cpp: (RenderBR::caretRect):
khtml/rendering/render_br.h:
khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
khtml/rendering/render_flow.h:
khtml/rendering/render_object.cpp: (RenderObject::caretRect):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (RenderText::caretRect):
khtml/rendering/render_text.h:
khtml/xml/dom_selection.cpp: (DOM::Selection::xPosForVerticalArrowNavigation): (DOM::Selection::layoutCaret):
kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:]):

11:17 AM Changeset in webkit [7483] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3791240> WebKit uses the NSTextViewContextMenu nib from inside AppKit

Reviewed by john.

English.lproj/StringsNotToBeLocalized.txt:
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): use our copy of the nib

12:07 AM Changeset in webkit [7482] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3791559>

2004-08-26 David Hyatt <hyatt@apple.com>

Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups.

Reviewed by darin

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

Sep 7, 2004:

11:58 PM Changeset in webkit [7481] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3791536>

2004-08-25 Kevin Decker <kdecker@apple.com>

Reviewed by John and Maciej.

Fixes SAP bug <rdar://problem/3751295> Personalize link at the top gives an error in the pop-up window.

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Passes a referrer to KHTMLPart::begin()

11:54 PM Changeset in webkit [7480] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge this fix from HEAD for SUPanNavy, <rdar://problem/3791526>

2004-08-11 Adele Amchan <adele@apple.com>

Reviewed by me, bug fix by Darin.

fixed <rdar://problem/3736477> Pages don't load if hard drive is named with non-ASCII Symbol

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): Use UTF8String instead of cString to convert the MIME type to a C string. Safer, since it can't ever fail due to encoding problems even though this string should always be ASCII. (-[WebBaseNetscapePluginStream destroyStream]): Use stringWithUTF8String to convert the path name to an NSString, since stringWithCString is deprecated (doesn't really matter since the path is always all ASCII). Fix the bug by calling fileSystemRepresentation on the NSString to turn it into a C string form. Even though the POSIX path can't have any non-ASCII characters in it, the Carbon path can, so we need to use this instead of cString which can fail depending on characters and encoding.

11:36 PM Changeset in webkit [7479] by vicki

2 edits in branches/Safari-1-2-branch/WebKit

merge this fix from HEAD for SUPanNavy, <rdar://problem/3791327>

2004-07-08 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3706296> VIP: ifilm.com crashing reproducibly with Safari

Reviewed by kocienda.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): don't release a NULL appURL

6:27 PM Changeset in webkit [7478] by mjs

2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3759209> REGRESSION (Mail): assertion failure when all of marked text deleted at start of document

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setMarkedRange): Allow any empty range, even if it's not in a text node, since in this case it won't matter and weird things can happen when all marked text is removed, there might not be any text nodes.

6:08 PM Changeset in webkit [7477] by hyatt

10 edits in trunk/WebCore

Initial text-decoration CSS3 work for editing. Just gets the properties and values parsed.

Reviewed by darin

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:

4:01 PM Changeset in webkit [7476] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:33 PM Changeset in webkit [7475] by vicki

2 edits in branches/Safari-1-2-branch/WebCore

merge this change from HEAD for SUPanNavy, <rdar://problem/3772907>

2004-08-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Richard.

<rdar://problem/3245706> URLs with backslashes instead of slashes work on WinIE; should work on Safari (SAP)
<rdar://problem/3506429> <BASE> tag containing backslash is breaking images with absolute URLs

kwq/KWQKURL.mm: (substituteBackslashes): Helper method (KURL::KURL): If the URL contains any backslashes, substitute all that appear before the query or fragment.

3:00 PM Changeset in webkit [7474] by vicki

5 edits in branches/Safari-1-2-branch/WebCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3772916>

2004-07-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Trey.

<rdar://problem/3678534> controls on page at http://help.sap.com don't work properly

To fix this I implemented the various JavaScript BarInfo properties in JavaScript.

khtml/ecma/kjs_window.cpp: (Window::Window): (Window::locationbar): (Window::menubar): (Window::personalbar): (Window::statusbar): (Window::toolbar): (Window::scrollbars): (Window::mark): (Window::get): (SelectionFunc::tryCall): (BarInfo::BarInfo): (BarInfo::~BarInfo): (BarInfo::get): (BarInfo::put):
khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::BarInfo::): (KJS::BarInfo::part): (KJS::BarInfo::classInfo):
khtml/ecma/kjs_window.lut.h: (KJS::):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::locationbarVisible): (KWQKHTMLPart::menubarVisible): (KWQKHTMLPart::personalbarVisible): (KWQKHTMLPart::scrollbarsVisible): (KWQKHTMLPart::statusbarVisible): (KWQKHTMLPart::toolbarVisible):

2:34 PM Changeset in webkit [7473] by cblu

1 edit in trunk/WebKit/ChangeLog

Fixed previous "Reviewed by" line.

ChangeLog:

2:28 PM Changeset in webkit [7472] by cblu

1 edit in trunk/WebKit/ChangeLog

Fixed: <rdar://problem/3790143> exception raised when dragging a URL with 2-byte characters

(checked in with last check-in)

2:26 PM Changeset in webkit [7471] by cblu

3 edits in trunk/WebKit

Fixed:
<rdar://problem/3080103> Need to pass cmd-modified keys to plug-ins
<rdar://problem/3751509> can't use safari edit menu to copy and paste with Vantage Learning's My Access

Reviewed by NOBODY (OOPS!).

Plugins.subproj/WebBaseNetscapePluginView.m: fake up command-key events for cut, copy, paste and select all so these menu items work for plug-ins (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]):

2:19 PM Changeset in webkit [7470] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add layout test results.

1:51 PM Changeset in webkit [7469] by vicki

3 edits in branches/Safari-1-2-branch/JavaScriptCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3773145>

2004-08-17 Darin Adler <Darin Adler>

Reviewed by Adele.

fixed <rdar://problem/3746676> SAP WebDynpro app hangs inside JavaScript property map hash table code (deleted sentinel problem)

kjs/property_map.h: Added some private functions.
kjs/property_map.cpp: (KJS::PropertyMap::clear): Set sentinelCount to 0. (KJS::PropertyMap::put): Complete search for the element before choosing to use the deleted-element sentinel. Also keep sentinel count up to date when we destroy a sentinel by overwriting with a new added element. (KJS::PropertyMap::expand): Added. Calls rehash with a size 2x the old size, or 16. (KJS::PropertyMap::rehash): Added. Refactored the rehash code into a separate function. (KJS::PropertyMap::remove): Add one to sentinelCount, and rehash if 1/4 or more of the elements are deleted-element sentinels. (KJS::PropertyMap::checkConsistency): Check the sentinelCount.

1:40 PM Changeset in webkit [7468] by vicki

2 edits in branches/Safari-1-2-branch/JavaScriptCore

merge this fix from HEAD for SUPanNavy, <rdar://problem/3772913>

2004-08-04 Vicki Murley <vicki@apple.com>

Reviewed by mjs.

fix <rdar://problem/3649789> SAP WebGUI has problems loading first page because of parse error

kjs/lexer.cpp: (Lexer::lex): if the current character is a '\' and the next character is a line terminator, go to the next line and continue parsing the string (instead of failing). This matches behavior in Mac IE and Mozilla.

11:58 AM Changeset in webkit [7467] by darin

2 edits in trunk/WebKit

fixed deployment build

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Initialize prepend variable.

Sep 6, 2004:

11:37 PM Changeset in webkit [7466] by darin

2 edits in trunk/JavaScriptCore

JavaScriptCore.pbproj/project.pbxproj: Bump MACOSX_DEPLOYMENT_TARGET to 10.3.

10:38 PM Changeset in webkit [7465] by mjs

4 edits in trunk/WebCore

Reviewed by Darin and Ken.

<rdar://problem/3655568> window.open fails when URL contains trailing space

kwq/KWQKURL.mm: (KURL::KURL): Strip trailing and leading space when resolving relative URLs in all cases, instead of just leading in the non-absolute case as before.

refactored KURL constructor to put more work in separate functions and also to change static methods to static functions, to avoid having to change the header when only changing helper functions that do not affect the KURL API (since KURL.h is widely included).

kwq/KWQKURL.mm: (encodeHostname): (findHostnamesInMailToURL): (findHostnameInHierarchicalURL): (encodeHostnames): (encodeRelativeString): (substituteBackslashes):
kwq/KWQKURL.h:

add missing include of qvaluelist.h

khtml/ecma/kjs_dom.h:

5:25 PM Changeset in webkit [7464] by darin

34 edits in trunk

WebCore:

Reviewed by John.

fixed <rdar://problem/3512066> REGRESSION (Mail): Select All highlights only part of the content, though all is copied
fixed <rdar://problem/3157025> REGRESSION (Mail): Should select paragraph instead of line on triple-click
fixed <rdar://problem/3735048> REGRESSION (Mail): HTML editing must select newline on triple click
fixed <rdar://problem/3788872> REGRESSION (Mail): ctrl-a emacs key binding does not work (move to start of paragraph)
fixed <rdar://problem/3788881> REGRESSION (Mail): ctrl-e emacs key binding does not work (move to end of paragraph)
fixed <rdar://problem/3789931> REGRESSION (Mail): typing style lost when you backspace
added code to select inserted text to help WebKit implement yankAndSelect:
did some clean-up on editing commands code

khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventTripleClick): Expand to a paragraph, not a line. (KHTMLPart::selectAll): Remove a lot of unneeded code and just expand to document using Selection. (KHTMLPart::selectionHasStyle): Remove check that limited us to only HTML elements, and add a check for nil. Together, these two changes fix a few cases I ran into during testing.

khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection): Fix test that was checking if the old selection spanned multiple objects when it really should have checked whether the new new selection spans multiple objects. This caused the select all redraw bug.

khtml/editing/htmlediting.h: Fixed indenting. Remove command IDs, replacing them with a couple of specific type checking methods, and SharedCommandImpl, using EditCommandImpl directly instead. Got rid of virtual functions, since the command objects have no data members other than the ones inherited from SharedPtr. Removed explicit copy constructors and destructors. Removed unneeded empty constructors. Removed inline directives that were having no effect. Added some boolean selectInsertedText parameter to some commands. Made almost all member functions const, because the const here applies to the command object which is a smart pointer, not the pointed-to command implementation object.
khtml/editing/htmlediting.cpp: (khtml::EditCommand::EditCommand): Changed since SharedPtr is now a pointer to EditCommandImpl. (khtml::EditCommand::operator=): Added. By defining this explicitly, we don't need the class that we are pointing to defined in the header, which lets us get rid of SharedCommandImpl. (khtml::EditCommand::isInputTextCommand): Added. (khtml::EditCommand::isTypingCommand): Added. (khtml::EditCommand::setParent): Updated since EditCommandImpl.setParent takes an impl pointer now. (khtml::EditCommand::handle): Removed, since it's identical to get(). (khtml::InputTextCommand::input): Added selectInsertedText parameter. (khtml::TypingCommand::TypingCommand): Ditto. (khtml::TypingCommand::insertText): Ditto. (khtml::TypingCommand::isOpenForMoreTypingCommand): Use isTypingCommand instead of commandID. (khtml::TypingCommand::closeTyping): Change parameter type to const reference.

khtml/editing/htmlediting_impl.h: Made StyleChange functions be const member functions. Changed parent() and setParent() to take and return EditCommandImpl pointers and be inlined. Added virtual isInputTextCommand, isTypingCommand, and preservesTypingStyle functions. Removed commandID functions and unneeded explicit destructors. Removed unneeded doApply function declaration in CompositeEditCommandImpl. Changed type of applyTypingStyle to return a node, not necessarily an element. Removed private execute function from InputTextCommandImpl. Added selectInsertedText to InputTextCommandImpl's input function and TypingCommandImpl's constructor and insertText function.
khtml/editing/htmlediting_impl.cpp: (khtml::StyleChange::StyleChange): Don't bother initializing the booleans since init handles that. (khtml::StyleChange::init): Added code to strip whitespace, and tweaked how the function does its job. (khtml::StyleChange::currentlyHasStyle): Added a check for null value, which can happen for properties where we don't have computed style implemented yet. (khtml::EditCommandImpl::EditCommandImpl): Updated since there is no SharedCommandImpl any more. (khtml::EditCommandImpl::apply): Call new preservesTypingStyle function rather than checking the command ID. This preserves typing style when deleting with the keyboard. (khtml::EditCommandImpl::setStartingSelection): Changed since parent is now a EditCommandImpl. Also rewrote to use for loop so it's simpler-looking. (khtml::EditCommandImpl::setEndingSelection): Ditto. (khtml::EditCommandImpl::setTypingStyle): Ditto. (khtml::EditCommandImpl::preservesTypingStyle): Added. Returns false. (khtml::EditCommandImpl::isInputTextCommand): Added. Returns false. (khtml::EditCommandImpl::isTypingCommand): Added. Returns false. (khtml::CompositeEditCommandImpl::applyTypingStyle): Changed this function to return a node rather than an element. Also change it so it returns the child as-is if the style change has nothing in it. (khtml::AppendNodeCommandImpl::~AppendNodeCommandImpl): Removed unneeded null checks. (khtml::DeleteSelectionCommandImpl::preservesTypingStyle): Added. Returns true. (khtml::DeleteTextCommandImpl::~DeleteTextCommandImpl): Removed unneeded null checks. (khtml::InputTextCommandImpl::input): Renamed execute function to input and got rid of the additional level of indirection, since it was the only caller. Added selectInsertedText parameter and changed the code so it will respect it. (khtml::InputTextCommandImpl::isInputTextCommand): Added. Returns true. (khtml::InsertNodeBeforeCommandImpl::~InsertNodeBeforeCommandImpl): Removed unneeded null checks. (khtml::JoinTextNodesCommandImpl::~JoinTextNodesCommandImpl): Ditto. (khtml::MoveSelectionCommandImpl::MoveSelectionCommandImpl): Hold a reference to the fragment while the command exists. (khtml::MoveSelectionCommandImpl::~MoveSelectionCommandImpl): Release the fragment. (khtml::RemoveNodeCommandImpl::~RemoveNodeCommandImpl): Remove unneeded null checks. (khtml::RemoveNodeCommandImpl::doUnapply): Take advantage of defined behavior of insertBefore when the node to insert before is 0 (means the same thing as appendChild). (khtml::RemoveNodePreservingChildrenCommandImpl::~RemoveNodePreservingChildrenCommandImpl): Remove unneeded null check. (khtml::ReplaceSelectionCommandImpl::ReplaceSelectionCommandImpl): Hold a reference to the fragment while the command exists. (khtml::ReplaceSelectionCommandImpl::~ReplaceSelectionCommandImpl): Release the fragment. (khtml::SetNodeAttributeCommandImpl::~SetNodeAttributeCommandImpl): Remove unneeded null check. (khtml::SplitTextNodeCommandImpl::~SplitTextNodeCommandImpl): Remove unneeded null check. (khtml::TypingCommandImpl::TypingCommandImpl): Added selectInsertedText parameter. (khtml::TypingCommandImpl::doApply): Pass along selectInsertedText parameter. (khtml::TypingCommandImpl::insertText): Ditto. (khtml::TypingCommandImpl::preservesTypingStyle): Added. Returns true for DeleteKey. (khtml::TypingCommandImpl::isTypingCommand): Added. Returns true.

khtml/editing/jsediting.cpp: Add a cut at implementing the underline command. May not work perfectly yet because text-decoration is not inherited the way, say, font-weight is.

khtml/xml/dom_selection.h: Removed some unneeded friend declarations for comparison operators that use only public members. Added PARAGRAPH_BOUNDARY.
khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Implemented paragraph boundary case, simplified line boundary case (by changing parameter types and function names, not the algorithm), and made paragraph case fall into line case for now. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::validate): Implemented paragraph case and paragraph boundary case, simplified the line case as above and also fixed the document case. (DOM::startOfFirstRunAt): Changed to use DOM::Position instead of node offset pairs. Also renamed and got rid of separate bool to indicate "not found". (DOM::endOfLastRunAt): Ditto. (DOM::selectionForLine): Ditto.

khtml/xml/dom_position.h: Added startParagraphBoundary and endParagraphBoundary. Also used enums instead of bools in a couple of places. Removed some unneeded friend declarations for comparison operators that use only public members.
khtml/xml/dom_position.cpp: (DOM::Position::Position): Coding style tweak. (DOM::Position::startParagraphBoundary): Added. (DOM::Position::endParagraphBoundary): Added. (DOM::Position::upstream): Use enum parameter instead of bool. (DOM::Position::downstream): Ditto. (DOM::Position::rendersOnSameLine): Removed unused function. Noticed some backwards logic here, and removed it rather than fixing it.

khtml/xml/dom_nodeimpl.h: Added traversePreviousNodePostOrder.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traversePreviousNodePostOrder): Added. For some uses, this function is more analogous to traverseNextNode in reverse than traversePreviousNode, which does a backwards pre-order traversal.

kwq/WebCoreBridge.h: Replaced fontForCurrentPosition method with fontForSelection:, added selectInsertedText parameter to insertText method, and added selectionStartHasStyle: method. Add WebSelectToParagraphBoundary.
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Added workaround for bug where isRenderedContent returns false for <br> elements at the ends of lines. (-[WebCoreBridge insertText:selectInsertedText:]): Added selectInsertedText parameter, passing it along to TypingCommand::insertText. (-[WebCoreBridge selectionStartHasStyle:]): Added. Calls code in the part that does the real work. (-[WebCoreBridge fontForSelection:]): Ditto.

kwq/KWQKHTMLPart.h: Renamed fontForCurrentPosition to fontForSelection, and added a feature where it tells us whether there are multiple fonts in the selection or not.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Rewrote this to be a bit simpler, and added code to detect whether there are multiple fonts in the selection. (KWQKHTMLPart::didTellBridgeAboutLoad): Use a global character rather than a bad pointer here. Better not to rely on undefined behavior. (KWQKHTMLPart::documentFragmentWithText): Use lowercase HTML. I believe this works better when the document is XML, and we should probably visit all callers and change them. (KWQKHTMLPart::registerCommandForUndo): Call get() instead of handle(). (KWQKHTMLPart::registerCommandForRedo): Call get() instead of handle().

khtml/misc/shared.h: Added a private, non-implemented copy constructor and assignment operator to Shared<> and TreeShared<> to prevent copying reference counts by accident.
khtml/rendering/render_style.h: Get rid of Shared<BorderData>, since it's not used that way. This makes BorderData smaller, and allows it to compile with the change to Shared<>.
khtml/xml/dom_docimpl.h: Remove unneeded copy constructor on DocumentFragmentImpl, which ran afoul of the change to Shared<> and was unused.
khtml/xml/dom_docimpl.cpp: Ditto.
khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::empty): Changed code around so it doesn't run afoul of the change to Shared<>. The old code was copying a DOMStringImpl. (DOM::DOMStringImpl::ascii): Added code to null-terminate the string buffer.

WebKit:

Reviewed by John.

fixed <rdar://problem/3696542> REGRESSION (Mail): Editable WebKit doesn't support underline yet (in the iChat profile window, at least)
fixed <rdar://problem/3780249> REGRESSION (Mail): copy style/paste style doesn't work in HTML editing in Mail
fixed <rdar://problem/3788857> REGRESSION (Mail): Home and End keys don't work in message composer
fixed <rdar://problem/3788884> REGRESSION (Mail): ctrl-d emacs key binding does not work (delete forward)
fixed <rdar://problem/3788890> REGRESSION (Mail): ctrl-k emacs key binding does not work (delete to end of paragraph)
fixed <rdar://problem/3788899> REGRESSION (Mail): ctrl-y emacs key binding does not work (yank)
fixed <rdar://problem/3788901> REGRESSION (Mail): ctrl-o emacs key binding does not work (insert newline in front of insertion point)
fixed <rdar://problem/3788908> REGRESSION (Mail): ctrl-left-arrow emacs key binding does not work (move to beginning of line)
fixed <rdar://problem/3788913> REGRESSION (Mail): ctrl-right-arrow emacs key binding does not work (move to end of line)
implemented a first cut at other attribute changes from Text Panel besides underline (bugs?)
dealt with a couple of FIXMEs in WebHTMLView.m
updated list of not-yet-implemented methods in WebHTMLView.m
fixed many deletion operations to call the correct editing delegate methods

WebView.subproj/WebFrameViewPrivate.h: Remove _scrollToTopLeft and _scrollToBottomLeft. No one was calling them anyway, so they should really have been marked internal and not private.
WebView.subproj/WebFrameView.m: (-[WebFrameView scrollToBeginningOfDocument:]): Renamed _scrollToTopLeft to this, so the home key would start working with the key bindings machinery. (-[WebFrameView scrollToEndOfDocument:]): Same thing, for end key. (-[WebFrameView keyDown:]): Update for name changes, and also make sure we don't try to grab control-arrow keys here (probably not necessary, but good anyway).

WebView.subproj/WebHTMLViewInternal.h: Added keyDownEvent field, and startNewKillRingSequence and nextResponderDisabledOnce flags.
WebView.subproj/WebHTMLView.m: Rearrange declarations at the top of the file so that external things are up with the #import directives and things inside this file are declared below. (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]): Ditto. (-[WebHTMLView _calculatePrintHeight]): Moved up into the "internal to file" category. (-[WebHTMLView _updateTextSizeMultiplier]): Ditto. (-[WebHTMLView _selectedRange]): Added. (-[WebHTMLView _openLinkFromMenu:]): Left this method lying around even though I deleted the other APPKIT_CODE_FOR_REFERENCE in case this shows up in the context menu we are now sharing with the AppKit. Chris will look at this later, and he can delete it then. (+[WebHTMLView initialize]): Call _NSInitializeKillRing. (-[WebHTMLView _documentRange]): Added. (-[WebHTMLView string]): Call the bridge to get the plain text rather than making an attributed string and then getting the text from there. (-[WebHTMLView becomeFirstResponder]): Set startNewKillRingSequence flag, so that new deletions will create a new kill ring entry. (-[WebHTMLView moveToBeginningOfDocument:]): Use backward direction instead of left direction. (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToBeginningOfLine:]): Ditto. (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): Ditto. (-[WebHTMLView moveToBeginningOfParagraph:]): Ditto, also use WebSelectToParagraphBoundary. (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): Use forward direction instead of right direction. (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfLine:]): Ditto. (-[WebHTMLView moveToEndOfLineAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfParagraph:]): Ditto, also use WebSelectToParagraphBoundary. (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView _shouldDeleteRange:]): Added. (-[WebHTMLView _deleteRange:preflight:killRing:prepend:]): Added. (-[WebHTMLView delete:]): Changed to call new _deleteRange method. (-[WebHTMLView cut:]): Changed to preflight property and call new _deleteRange method. (-[WebHTMLView _selectionFontAttributes]): Added. (-[WebHTMLView _selectionFontAttributesAsRTF]): Added. (-[WebHTMLView _fontAttributesFromFontPasteboard]): Added. (-[WebHTMLView _emptyStyle]): Added. (-[WebHTMLView _styleFromFontAttributes:]): Added. (-[WebHTMLView _applyStyleToSelection:]): Added. (-[WebHTMLView copyFont:]): Implemented. (-[WebHTMLView pasteFont:]): Implemented. (-[WebHTMLView _originalFontA]): Added. (-[WebHTMLView _originalFontB]): Added. (-[WebHTMLView _addToStyle:fontA:fontB:]): Added. Has code from the method that figures out what the font manager is doing for changeFont:, now needed for changeAttribute: too. (-[WebHTMLView _styleFromFontManagerOperation]): Renamed and now calls shared methods. (-[WebHTMLView changeFont:]): Call shared method, still does the same thing. (-[WebHTMLView _colorAsString:]): Added. Has code from the method we were using with the color panel before. (-[WebHTMLView _shadowAsString:]): Added. (-[WebHTMLView _styleForAttributeChange:]): Added. (-[WebHTMLView changeAttributes:]): Implemented. (-[WebHTMLView _styleFromColorPanelWithSelector:]): Renamed and now calls shared methods. (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): Call method by new name. (-[WebHTMLView changeDocumentBackgroundColor:]): Call method by new name. (-[WebHTMLView changeColor:]): Changed around a bit; still doesn't work yet. (-[WebHTMLView _alignSelectionUsingCSSValue:]): Call shared methods. (-[WebHTMLView indent:]): Removed, since NSTextView doesn't implement this method. Added to list of methods to possibly implement later in the file. (-[WebHTMLView insertTab:]): Call insertText: to save code and so we get WebViewInsertActionTyped instead of WebViewInsertActionPasted. (-[WebHTMLView changeCaseOfLetter:]): Removed, since NSTextView doesn't implement this method. Added to list of methods to possibly implement later in the file. (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Added. (-[WebHTMLView deleteForward:]): Implemented. This makes Control-D work. (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Implemented by just calling deleteBackward for now; probably better than doing nothing. (-[WebHTMLView deleteWordForward:]): Changed to call new _delete method above. Fixes things so that we delete the selection if there is one, get the appropriate delegate calls, handle the kill ring properly, and don't do any selection if we can't delete. (-[WebHTMLView deleteWordBackward:]): Ditto. (-[WebHTMLView deleteToBeginningOfLine:]): Ditto. (-[WebHTMLView deleteToEndOfLine:]): Ditto. (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto. (-[WebHTMLView deleteToEndOfParagraph:]): Ditto. Added additional behavior needed since this is bound to Control-K, so it's not really just delete to end of paragraph. (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): Added. Calls insertNewline:. (-[WebHTMLView insertTabIgnoringFieldEditor:]): Added. Calls insertTab:. (-[WebHTMLView subscript:]): Added. (-[WebHTMLView superscript:]): Added. (-[WebHTMLView unscript:]): Added. (-[WebHTMLView underline:]): Added. (-[WebHTMLView yank:]): Added. (-[WebHTMLView yankAndSelect:]): Added. Calls _insertText. (-[WebHTMLView _arrowKeyDownEventSelectorIfPreprocessing:]): Added. Part of workaround for control-arrow key trouble. (-[WebHTMLView respondsToSelector:]): Added. More of workaround. (-[WebHTMLView nextResponder:]): Added. More of workaround. (-[WebHTMLView _selectionChanged]): Set startNewKillRingSequence flag, so that new deletions will create a new kill ring entry. (-[WebHTMLView _updateFontPanel]): Remove a bunch of code here that wasn't working very well because it walked a DOM range incorrectly, and instead use the new method that does all the right stuff on the other side of the bridge. (-[WebHTMLView _insertText:selectInsertedText:]): Added new helper method for use by both insertText and yankAndSelect, with most of the guts of insertText and one additional parameter. (-[WebHTMLView insertText:]): Call the new _insertText.

WebView.subproj/WebView.m: Use macros to make the forwarding from WebView more terse. Updated the list to include a few methods it didn't before.

4:30 PM Changeset in webkit [7463] by darin

3 edits in trunk/WebCore

Reviewed by John.

improved computed style code and implemented text-decoration and text-shadow (needed for, e.g., underline)

khtml/css/css_computedstyle.cpp: Added CSS_PROP_TEXT_DECORATION to the InheritableProperties array for now even though it's not inheritable. This makes underline work in some cases for typing style. We may decide to take it back out again after further consideration. (DOM::valueForLength): Use IDs in primitive values rather than strings. (DOM::valueForBorderStyle): Ditto, also renamed this. (DOM::valueForTextAlign): More of the same. (DOM::valueForShadow): Added this function. (DOM::CSSComputedStyleDeclarationImpl::getPositionOffsetValue): More IDs in primitive values. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Changed all the cases to use IDs instead of strings in primitive values. Also put the style in a local variable for better code size and smaller source code too. Added implementation for CSS_PROP_TEXT_DECORATION and CSS_PROP_TEXT_SHADOW.

khtml/css/css_valueimpl.cpp: (CSSValueListImpl::cssText): Put commas between list elements. (CSSPrimitiveValueImpl::cssText): Fixed some messed up indenting and removed an unneeded default case that would just prevent a warning if we ever have an unhandled enum value.

4:23 PM Changeset in webkit [7462] by darin

4 edits in trunk/WebCore

Reviewed by John.

did some clean-up on form data code

khtml/misc/formdata.h: Added more public functions as suggested by Chris when he reviewed this class.
khtml/misc/formdata.cpp: (khtml::FormData::appendFile): Added. Will be needed soon.
kwq/KWQFormData.mm: (arrayFromFormData): Use new cleaned-up FormData API.

4:22 PM Changeset in webkit [7461] by darin

2 edits in trunk/WebCore

Reviewed by John.

kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration description]): Use cssText in the description so it's easier to see in the debugger.

4:21 PM Changeset in webkit [7460] by darin

2 edits in trunk/WebCore

Reviewed by John.

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): Remove uneeded QCString copy.

2:13 PM Changeset in webkit [7459] by sullivan

3 edits
1 add in trunk/WebKit

WebKit:

Reviewed by Darin.

put preference keys in a private header file so Safari can use them for Managed Preferences

WebView.subproj/WebPreferenceKeysPrivate.h: new Private header file, includes the #defines for NSUserDefaults preference keys

WebView.subproj/WebPreferences.m: moved the preference key #defines out of here; now imports WebPreferenceKeysPrivate.h

WebKit.pbproj/project.pbxproj: updated for new file

WebBrowser:

Reviewed by Darin.

fixed these bugs: <rdar://problem/3786507> Safari's managed preferences manifest needs to be brought up to date and made localizable <rdar://problem/3550533> Would like Safari to make more preferences "managed" in the Managed Preferences sense

Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences updateStyleSheetMenu]): disable popup button if style sheet enabled-ness or location is forced (-[AdvancedPreferences updateMinFontSizeViews]): disable checkbox and combo box if min font size value is forced (-[AdvancedPreferences updateTabToAllViews]): disable checkbox if tab-to-links value is forced

Preferences.subproj/AppearancePreferences.h: new outlets for "Select" buttons
Preferences.subproj/English.lproj/AppearancePreferences.nib: wire up "Select" button outlets
Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences updateDefaultCharacterSetPopup]): disable popup if text encoding value is forced (-[AppearancePreferences initializeFromDefaults]): disable each "Select" button if the font or font size is forced

Preferences.subproj/AutoFillPreferences.m: (-[AutoFillPreferences updateViews]): disable each checkbox if its value is forced

Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences setUpCheckbox:fromPreferenceKey:]): renamed from "setStateOfCheckbox:..."; now disables checkbox if the preference key value is forced (-[BookmarkPreferences updateBookmarksViews]): updated for name change

Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences updateExternalLinkPolicyViews]): disable radio buttons if value is forced (-[GeneralPreferences initializeFromDefaults]): disable new window policy popup, downloads clearing policy popup, and/or auto-open downloads checkbox if its value is forced

Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences updateJavaScriptViews]): disable javascript and/or block popups checkbox if its value is forced (-[SecurityPreferences updateMiscellaneousSecurityViews]): disable insecure forms checkbox if its value is forced (-[SecurityPreferences initializeFromDefaults]): disable java checkbox and/or plugins checkbox if its value is forced

Preferences.subproj/TabsPreferences.m: (-[TabsPreferences updateViews]): disable each checkbox if its value is forced

PrintingAccessoryViewController.m: (-[PrintingAccessoryViewController accessoryView]): disable each checkbox if its value is forced

Resources/com.apple.Safari.manifest/Contents/Resources/com.apple.Safari.manifest: updated key names to match latest spec; removed keys that have been removed in latest spec (pfm_print_string and pfm_ui_category); added pfm_titles; removed periods from pfm_descriptions since they aren't sentences; made all keys user-managed

Resources/com.apple.Safari.manifest/Contents/Resources/English.lproj/Localizable.strings: created contents from com.apple.Safari.manifest. I did this by hand this time, but wrote bug 3789768 about automating it later.

10:15 AM Changeset in webkit [7458] by darin

1 delete in trunk/LayoutTests/css1/text_properties/text-transform.html

Removed this test, since it doesn't work reliably.
We can bring it back some day if we like.

Sep 4, 2004:

12:59 PM Changeset in webkit [7457] by rjw

3 edits in trunk/WebCore

Fix build problem on panther.

khtml/ecma/kjs_html.cpp:
khtml/rendering/render_canvasimage.h:

Sep 3, 2004:

8:58 PM Changeset in webkit [7456] by hyatt

2 edits in trunk/WebCore

Simple tweak to background-attachment. Don't apply the slow repaint flag until after the whole style has been
resolved, since while cascading someone may set the attachment to fixed but later override with scroll.

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty):

6:38 PM Changeset in webkit [7455] by rjw

5 edits in trunk/WebCore

Fixed <rdar://problem/3781001>: redirection of URL via resource load delegate does not correctly set base URL for subsequent loads

Ensure that stylesheets have the correct URL when request
is redirected.

Reviewed by Maciej.

khtml/misc/loader.cpp: (CachedCSSStyleSheet::checkNotify):
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQIsResponseURLEqualToURL): (KWQResponseURL):

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Compare parameter count with == instead of <=.

5:21 PM Changeset in webkit [7454] by hyatt

2 edits in trunk/WebCore

Fix for 3779083, deleting large amount of text is really slow. Don't use NodeLists in editing remove commands.

Reviewed by darin

khtml/editing/htmlediting_impl.cpp: (khtml::RemoveNodeCommandImpl::RemoveNodeCommandImpl): (khtml::RemoveNodePreservingChildrenCommandImpl::doApply):

5:04 PM Changeset in webkit [7453] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3782543> CrashTracer: ...87 crashes at com.apple.WebKit: -[WebNetscapePluginPackage initWithPath:] + 0x18c

Reviewed by john.

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): make sure the file is at least 8 bytes long before calling memcmp

4:02 PM Changeset in webkit [7452] by cblu

4 edits in trunk/WebKit

Fixed:
<rdar://problem/3788328> assertion failure when moving an image
<rdar://problem/3783628> REGRESSION (Mail): when I try to reorder an image, the image is duplicated

Reviewed by NOBODY (OOPS!).

DOM.subproj/WebDOMOperations.m: (-[DOMDocument _createRangeWithNode:]): new, convenience (-[DOMDocument _documentRange]): use _ createRangeWithNode:
DOM.subproj/WebDOMOperationsPrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): set the selection to the image when starting the drag. This allows "move selection" to work and this matches NSText's behavior

3:12 PM Changeset in webkit [7451] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3714501> REGRESSION (125.8-8A162): Chinese words display as garbage in search results (www.sz.net.cn)

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Resolve URL using the document method that passes the codec rather than calling the KURL constructor directly.

2:51 PM Changeset in webkit [7450] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3788409> can't create or clone an embed element

Reviewed by rjw.

khtml/html/htmlparser.cpp: added fixme about sharing code
khtml/xml/dom_docimpl.cpp: ditto (DocumentImpl::createHTMLElement): create and return a HTMLEmbedElementImpl

2:33 PM Changeset in webkit [7449] by vicki

1 edit in trunk/WebCore/ChangeLog-2005-08-23

re-jigger these ChangeLogs so that they actually reflect what went into Safari-162

2:25 PM Changeset in webkit [7448] by vicki

3 edits in trunk

change versions for TOT, Safari 2.0 (v163u)

1:41 PM Changeset in webkit [7447] by darin

2 edits in trunk/WebCore

Reviewed by Chris.

fixed <rdar://problem/3410112> filename with non-ASCII name for <input type=file> should be sent in the page's encoding

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Encode filename using the codec rather than doing the &# dance. It turns out that Mozilla only does the &# thing under certain circumstances that are not important. Always encoding the filename is almost certainly better behavior, and will fix many serious problems for Japanese and Korean users and websites.

12:23 PM Changeset in webkit [7446]

4 copies in tags/Safari-162

This commit was manufactured by cvs2svn to create tag 'Safari-162'.

12:23 PM Changeset in webkit [7445] by darin

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3788040> REGRESSION: text that i type into a textarea disappears when i tab out of the textarea

kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): Bring back an unconditional version of this method. Earlier, we deleted this method, but we should have instead removed the check.

10:35 AM Changeset in webkit [7444] by rjw

3 edits in trunk/WebCore

Made drawImage() in <canvas> compliant with whatwg spec.

Reviewed by John.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
khtml/html/html_imageimpl.h: (DOM::HTMLImageElementImpl::pixmap):

10:28 AM Changeset in webkit [7443] by hyatt

3 edits in trunk/WebCore

Fix for 3787686, CSS parser should do case-sensitive matching of ids and attributes only in strict mode
(and not whenever you have an HTML document).

Reviewed by john

khtml/css/parser.cpp:
khtml/css/parser.y:

10:14 AM Changeset in webkit [7442] by hyatt

2 edits in trunk/LayoutTests/fast

Land updated layout tests after box/container swap

Sep 2, 2004:

7:03 PM Changeset in webkit [7441] by vicki

6 edits in trunk

Safari-162 stamp for everything except WebBrowser. In these project, CFBundleShortVersionString matches CFBundleVersion (162 in both cases).

5:10 PM Changeset in webkit [7440] by hyatt

15 edits in trunk/WebCore

Swap RenderBox and RenderContainer. Make leaf RenderObjects actually derive off of RenderBox instead.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::detach):
khtml/rendering/render_box.h:
khtml/rendering/render_container.cpp: (RenderContainer::RenderContainer): (RenderContainer::detach):
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::detach): (RenderFlow::dirtyLineBoxes): (RenderFlow::createInlineBox): (RenderFlow::getAbsoluteRepaintRect): (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition): (RenderFlow::leftmostPosition): (RenderFlow::caretPos):
khtml/rendering/render_flow.h: (khtml::RenderFlow::RenderFlow):
khtml/rendering/render_frames.cpp: (RenderFrameSet::RenderFrameSet): (RenderFrameSet::nodeAtPoint): (RenderFrameSet::dump):
khtml/rendering/render_frames.h:
khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow):
khtml/rendering/render_replaced.cpp:
khtml/rendering/render_replaced.h: (khtml::RenderReplaced::setIntrinsicHeight):
khtml/rendering/render_table.cpp: (RenderTableSection::RenderTableSection): (RenderTableSection::detach): (RenderTableSection::setStyle):
khtml/rendering/render_table.h:

4:41 PM Changeset in webkit [7439] by kocienda

2 edits in trunk/WebCore

Reviewed by me

khtml/editing/htmlediting_impl.h: Fix some inconsistent use of whitespace. No code change.

4:25 PM Changeset in webkit [7438] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3786848> REGRESSION (Mail): Typing styles and font panel updates broken

khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent): Check for inlines that can have kids is wrong. I busted this the other day when making the PositionIterator class iterate over all nodes and not just leaves of the DOM tree.

Update all the following functions. These use the PositionIterator class, but still
only want to consider leaf nodes.

(DOM::Position::isFirstRenderedPositionOnLine)
(DOM::Position::isLastRenderedPositionOnLine)
(DOM::Position::isLastRenderedPositionInEditableBlock)
(DOM::Position::inFirstEditableInRootEditableElement)
(DOM::Position::inLastEditableInRootEditableElement)
(DOM::Position::inFirstEditableInContainingEditableBlock)
(DOM::Position::inLastEditableInContainingEditableBlock)

1:53 PM Changeset in webkit [7437] by rjw

11 edits in trunk

WebCore:

Support for patterns in <canvas>

Reviewed by Hyatt.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::putValue): (drawPattern): (ImagePattern::ImagePattern): (ImagePattern::~ImagePattern):
khtml/ecma/kjs_html.h: (KJS::ImagePattern::getPattern): (KJS::ImagePattern::pixmap):
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (QPixmap::imageRef):
kwq/WebCoreImageRenderer.h:

WebKit:

Support for patterns in <canvas>.
(These changes attempt to create a CGImageRef from a WebImageRenderer that
is used by the pattern drawing function.)

Reviewed by Hyatt.

WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): (-[WebImageRenderer finalize]): (-[WebImageRenderer imageRef]): (_createImageRef):
WebView.subproj/WebPDFView.h:
WebView.subproj/WebPDFView.m:

1:50 PM Changeset in webkit [7436] by hyatt

2 edits in trunk/WebCore

Fix for 3769409, a regression from 10.3.4 to 10.3.5 involving <colgroup>s in malformed HTML.

Reviewed by mjs

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

1:39 PM Changeset in webkit [7435] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

Add layout test for crashing colgroup

1:38 PM Changeset in webkit [7434] by hyatt

3 edits in trunk/WebCore

Fix for the <colgroup> crasher. Make sure adding to an anonymous box just returns immediately. Also eliminate
all the redundant setPos -500000 calls, since we don't need those at all.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::makeChildrenNonInline):
khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):

10:06 AM Changeset in webkit [7433] by kocienda

12 edits
20 adds in trunk

Reviewed by John

Fix for these bugs:

<rdar://problem/3729219> REGRESSION (Mail): Caret placement and navigation not working correctly at yahoo.com
<rdar://problem/3758606> REGRESSION (Mail): Deletions across DIV elements is broken
<rdar://problem/3784810> REGRESSION (Mail): delete at beginning of line instead deletes to the end of the document (simple reduced test)

I made some very big improvements to the code which handles deletions of selections
which span more than one block.

khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::deleteUnrenderedText): An new, overloaded version of this function which works on a NodeImpl. The code in this function fell out of some refactoring I did in the function with the same name which takes a Position as an argument. (khtml::DeleteSelectionCommandImpl::moveNodesToBlock): New function. This new logic provides the smarts to fix the bugs listed above and greatly improves the code to perform deleting selections which span more than one block. (khtml::DeleteSelectionCommandImpl::doApply): Several changes. Constrain downstream positions so that they stay in the current block. This was a mistake before I think. Add code to detect when the insertion point is a caret at the start of a block. This is a special-case of a cross-block selection. Change the end-of-deletion-fixup case to operate on the downstreamEnd position of the selection rather than the upstream. This is more logical. Refine the block merge logic to handle more cases, like dealing with whitespace.
khtml/editing/htmlediting_impl.h: Associated header file changes.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::rootEditableElement): Add code to clamp the return value to the body element.
khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Make selection canonicalizations stay in the current block.
layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-001.html:
layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-002.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-003-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-003.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-004-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-004.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-005-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-005.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-006-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-006.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-007-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-007.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-008-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-008.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-009-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-009.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-010.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-011-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-011.html: Added.
layout-tests/editing/inserting/insert-3654864-fix-expected.txt: Updated with new results.
layout-tests/editing/inserting/insert-3654864-fix.html: Updated test to deal better with improved select all behavior.
layout-tests/editing/selection/select-all-003-expected.txt: Updated with new results.

Sep 1, 2004:

5:58 PM Changeset in webkit [7432] by adele

3 adds in trunk/LayoutTests/fast/frames

Adding layout test for contentWindow for frames

4:49 PM Changeset in webkit [7431] by rjw

2 edits in trunk/JavaScriptCore

Add pid to exception messages (to help debug dashboard clients).

Reviewed by Chris.

kjs/interpreter.cpp: (Interpreter::evaluate):

3:53 PM Changeset in webkit [7430] by rjw

2 edits in trunk/WebCore

Fixed panther build glitch.

Reviewed by Ken.

khtml/ecma/kjs_html.cpp:

3:17 PM Changeset in webkit [7429] by cblu

2 edits in trunk/WebKit

Fixed deployment build failure.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]):

12:38 PM Changeset in webkit [7428] by rjw

4 edits in trunk/WebCore

WebCore:

Finished implementation of gradient support in <canvas>.

Reviewed by John.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): (isGradient): (isImagePattern): (KJS::Context2DFunction::tryCall): (Context2D::putValue): (Context2D::Context2D): (KJS::GradientFunction::tryCall): (gradientCallback): (Gradient::commonInit): (Gradient::Gradient): (Gradient::~Gradient): (Gradient::getShading): (Gradient::addColorStop): (sortStops): (Gradient::colorStops):
khtml/ecma/kjs_html.h: (KJS::ColorStop::ColorStop):
khtml/ecma/kjs_html.lut.h: (KJS::):

Tests:

Test page for gradients usage in the <canvas>.

Reviewed by John.

html/canvas_gradient.html: Added.
html/gibson.jpg: Added.

11:22 AM Changeset in webkit [7427] by hyatt

2 edits in trunk/WebCore

Fix for 3784686, hidden links still active. Make sure text nodes exclude themselves from nodeAtPoint checks
when hidden.

khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):

10:29 AM Changeset in webkit [7426] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add layout tests.

10:19 AM Changeset in webkit [7425] by hyatt

3 edits in trunk/WebCore

Fixes for 3761411 and 3782201. This patch makes two changes to percentage heights. First it makes sure that
replaced elements always flex inside a cell (unlike blocks and tables, which do so only sometimes under bizarre
conditions that are still being guessed at by me). The second fix is a recognition that empty tables do not
actually honor their heights, and so it is a mistake to try to flex them.

Reviewed by mjs

khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
khtml/rendering/render_table.h: (khtml::RenderTable::hasSections):

Aug 31, 2004:

3:12 PM Changeset in webkit [7424] by cblu

7 edits in trunk/WebKit

Fixed:
<rdar://problem/3699498> Context menu for editable WebViews should provide items like Cut and Paste
<rdar://problem/3781535> REGRESSION (Mail): no context menu after ctrl-clicking a misspelled word

Reviewed by kocienda.

English.lproj/Localizable.strings:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): updated to handle new menu items (-[WebDefaultUIDelegate contextMenuItemsForElement:]): renamed from webView:contextMenuItemsForElement:defaultMenuItems: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): new (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): moved, now call contextMenuItemsForElement: or editingContextMenuItemsForElement:
WebView.subproj/WebDefaultUIDelegate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): new (-[WebHTMLView _guessesForMisspelledSelection]): new (-[WebHTMLView _changeSpellingFromMenu:]): new (-[WebHTMLView _ignoreSpellingFromMenu:]): new (-[WebHTMLView _learnSpellingFromMenu:]): new
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebUIDelegate.h:

2:58 PM Changeset in webkit [7423] by darin

2 edits in trunk/WebKit

fixed B&I build failure

WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController _buildUI]): Work around unwanted warning by adding a cast.

2:31 PM Changeset in webkit [7422] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3781572> can't paste text in replied message view

khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Copying text placed in an anonymous block was failing since the code in here depending on the text node's containing block having an element, which it won't. In fact, using containing block is wrong anyway, since positioned elements can have containing blocks far from where they live in the tree. This "move up to block check" should use the more DOM-wise enclosingBlockFlowElement() in NodeImpl.

1:18 PM Changeset in webkit [7421] by mjs

1 edit in trunk/WebKit/ChangeLog

Reviewed by John.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]):

9:58 AM Changeset in webkit [7420] by hyatt

2 adds in trunk/LayoutTests/fast/table

* empty log message *

9:49 AM Changeset in webkit [7419] by hyatt

3 edits in trunk/WebCore

Fix for 3742585, sony dhtml menus wrong size. The percentage table height algorithm was wrong. This patch
unifies the table percentage height algorithm with the block percentage height algorithm and fixes bugs in
both.

Reviewed by john

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
khtml/rendering/render_table.cpp: (RenderTable::layout):

9:39 AM Changeset in webkit [7418] by kocienda

2 edits
16 adds in trunk

Reviewed by me

Added more editing layout tests.

layout-tests/editing/deleting/delete-tab-001-expected.txt: Added.
layout-tests/editing/deleting/delete-tab-001.html: Added.
layout-tests/editing/deleting/delete-tab-002-expected.txt: Added.
layout-tests/editing/deleting/delete-tab-002.html: Added.
layout-tests/editing/deleting/delete-tab-003-expected.txt: Added.
layout-tests/editing/deleting/delete-tab-003.html: Added.
layout-tests/editing/deleting/delete-tab-004-expected.txt: Added.
layout-tests/editing/deleting/delete-tab-004.html: Added.
layout-tests/editing/editing.js: Fixed a little bug in one of the "delayed" commands.
layout-tests/editing/inserting/insert-tab-001-expected.txt: Added.
layout-tests/editing/inserting/insert-tab-001.html: Added.
layout-tests/editing/inserting/insert-tab-002-expected.txt: Added.
layout-tests/editing/inserting/insert-tab-002.html: Added.
layout-tests/editing/inserting/insert-tab-003-expected.txt: Added.
layout-tests/editing/inserting/insert-tab-003.html: Added.
layout-tests/editing/inserting/insert-tab-004-expected.txt: Added.
layout-tests/editing/inserting/insert-tab-004.html: Added.

9:29 AM Changeset in webkit [7417] by kocienda

3 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3782521> Typing newline at start of block does not work

khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Change handling of case to insert newline at the start of a block.
layout-tests/editing/inserting/insert-br-006-expected.txt: Updated layout test with new results.

9:04 AM Changeset in webkit [7416] by kocienda

1 edit in trunk/WebCore/khtml/editing/htmlediting_impl.cpp

Checked this in by mistake, rolling back

8:57 AM Changeset in webkit [7415] by kocienda

2 edits in trunk/WebCore

ChangeLog

8:56 AM Changeset in webkit [7414] by kocienda

3 edits in trunk

Reviewed by NOBODY (OOPS!).

khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply):
layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
layout-tests/editing/selection/move-by-line-001-expected.txt:

8:41 AM Changeset in webkit [7413] by kocienda

2 edits
10 adds in trunk

Reviewed by me

Added more editing layout tests.

layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
layout-tests/editing/deleting/collapse-whitespace-3587601-fix.html: Added.
layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt: Added.
layout-tests/editing/deleting/delete-block-merge-contents-001.html: Added.
layout-tests/editing/editing.js: Added some more navigation commands.
layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3778059-fix.html: Added.
layout-tests/editing/selection/move-by-line-001-expected.txt: Added.
layout-tests/editing/selection/move-by-line-001.html: Added.
layout-tests/editing/style/typing-style-003-expected.txt: Added.
layout-tests/editing/style/typing-style-003.html: Added.

8:27 AM Changeset in webkit [7412] by kocienda

1 edit
14 adds
8 deletes in trunk

Reviewed by me

Added more editing layout tests. Renamed some others.

layout-tests/editing/inserting/insert-br-001-expected.txt: Added.
layout-tests/editing/inserting/insert-br-001.html: Added.
layout-tests/editing/inserting/insert-br-002-expected.txt: Added.
layout-tests/editing/inserting/insert-br-002.html: Added.
layout-tests/editing/inserting/insert-br-003-expected.txt: Added.
layout-tests/editing/inserting/insert-br-003.html: Added.
layout-tests/editing/inserting/insert-br-004-expected.txt: Added.
layout-tests/editing/inserting/insert-br-004.html: Added.
layout-tests/editing/inserting/insert-br-005-expected.txt: Added.
layout-tests/editing/inserting/insert-br-005.html: Added.
layout-tests/editing/inserting/insert-br-006-expected.txt: Added.
layout-tests/editing/inserting/insert-br-006.html: Added.
layout-tests/editing/inserting/insert-br-case1-expected.txt: Removed.
layout-tests/editing/inserting/insert-br-case1.html: Removed.
layout-tests/editing/inserting/insert-br-case2-expected.txt: Removed.
layout-tests/editing/inserting/insert-br-case2.html: Removed.
layout-tests/editing/inserting/insert-br-case3-expected.txt: Removed.
layout-tests/editing/inserting/insert-br-case3.html: Removed.
layout-tests/editing/inserting/insert-br-case6-expected.txt: Removed.
layout-tests/editing/inserting/insert-br-case6.html: Removed.
layout-tests/editing/inserting/insert-text-with-newlines-expected.txt: Added.
layout-tests/editing/inserting/insert-text-with-newlines.html: Added.

8:14 AM Changeset in webkit [7411] by kocienda

2 edits in trunk

Reviewed by me

layout-tests/editing/editing.js: Modified typeCharacterCommand so it can accept a character as an argument.

8:02 AM Changeset in webkit [7410] by kocienda

25 edits in trunk

Reviewed by Hyatt

Fix for these bugs:

<rdar://problem/3777629> REGRESSION (Mail): can't delete blank lines in quoted text in HTML mail replies
<rdar://problem/3780309> REGRESSION (Mail): can't delete past an empty span in a particular test case
<rdar://problem/3780315> REGRESSION (Mail): right arrow works incorrectly in a particular test case with an empty span
<rdar://problem/3780320> REGRESSION (Mail): left arrow works incorrectly in a particular test case with an empty span
<rdar://problem/3780336> REGRESSION (Mail): down arrow fails in a reduction of a Mail reply test case (seems to be inside a span)

khtml/xml/dom_position.cpp: (DOM::Position::upstream): If this position's node is a block, use it for the StayInBlock case, not the block's enclosing block. (DOM::Position::downstream): Ditto. (DOM::Position::inRenderedContent): Refine the case for non-text nodes. This was erroneously returning true for any empty element (like <span></span>).
khtml/xml/dom_positioniterator.cpp: Change the following four functions to consider all nodes, not just leaves of the DOM tree. This is a step towards making this iteration less cranky and unpredictable, and was necessary to do now to keep the inRenderedContent() change above from breaking editign layout tests. (DOM::PositionIterator::peekPrevious) (DOM::PositionIterator::peekNext) (DOM::PositionIterator::atStart) (DOM::PositionIterator::atEnd)
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForCurrentPosition): Check that the position being checked is an element and that the element is in rendered content. I ran across some null-check failures while I was coding this fix, and the additions seem prudent.

Updated these layout tests with new results.

layout-tests/editing/deleting/delete-3608430-fix-expected.txt:
layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
layout-tests/editing/deleting/delete-block-contents-001-expected.txt:
layout-tests/editing/deleting/delete-block-contents-002-expected.txt:
layout-tests/editing/deleting/delete-block-contents-003-expected.txt:
layout-tests/editing/deleting/delete-image-004-expected.txt:
layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
layout-tests/editing/editing.js:
layout-tests/editing/execCommand/boldSelection-expected.txt:
layout-tests/editing/execCommand/italicizeByCharacter-expected.txt:
layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt:
layout-tests/editing/execCommand/print-expected.txt:
layout-tests/editing/execCommand/selectAll-expected.txt:
layout-tests/editing/selection/extend-by-character-002-expected.txt:
layout-tests/editing/selection/extend-by-character-004-expected.txt:
layout-tests/editing/selection/extend-by-character-005-expected.txt:
layout-tests/editing/selection/extend-by-character-006-expected.txt:
layout-tests/editing/selection/select-all-001-expected.txt:
layout-tests/editing/selection/select-all-002-expected.txt:
layout-tests/editing/selection/select-all-003-expected.txt:

Aug 30, 2004:

5:49 PM Changeset in webkit [7409] by darin

10 edits
1 delete in trunk

WebCore:

Reviewed by John.

fixed <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com

kwq/KWQListBox.h: Added a clearCachedTextRenderers function.
kwq/KWQListBox.mm: (itemTextRenderer): Change to use globals that are outside the function, and added retain calls. (groupLabelTextRenderer): Ditto. (QListBox::clearCachedTextRenderers): Release global text renderers and nil out the globals.

kwq/WebCoreBridge.h: Removed updateAllViews; not needed any more.
kwq/WebCoreBridge.mm: Ditto.

kwq/WebCoreTextRendererFactory.h: Added a clearCaches method.
kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Added. Tells all the views to repaint after clearing the cached text renderers from KWQListBox. To be more elegant, we could generalize the KWQListBox trick, but for now why bother?

kwq/WebCoreTextRendererFactory.m: Removed. I needed to put some C++ code in here, so changed the extension to .mm.
WebCore.pbproj/project.pbxproj: Removed WebCoreTextRendererFactory.m, and added WebCoreTextRendererFactory.mm.

WebKit:

Reviewed by John.

part of fix for <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): Call [super clearCaches].

3:58 PM Changeset in webkit [7408] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/3528538> can paste a Return character into the Search field at amazon.com, other browsers won't

kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidChange:]): Truncate text before the first line break.

3:44 PM Changeset in webkit [7407] by darin

2 edits in trunk/WebCore

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): Added some more assertions I used to track down what looks like a TEC bug.

3:36 PM Changeset in webkit [7406] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3779122> No accesskey support on LABEL element

khtml/html/html_formimpl.h: Change type of m_currValue to DOMString. Should have been done as part of my form data check-in, but harmless to do now. Add accessKeyAction function for HTMLLabelElementImpl.
khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::parseHTMLAttribute): Remove conversion of DOMString to QString for m_currValue. (DOM::HTMLLabelElementImpl::formElement): If there's no "for" attribute, search children for the first control. (DOM::HTMLLabelElementImpl::accessKeyAction): Forward the accesskey action to the formElement.

2:50 PM Changeset in webkit [7405] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed <rdar://problem/3303968> final newline character omitted from <textarea> when parsing a new page

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): Handle newline pending cases as well as space and tab pending spaces at the end of this function. This seems right for both scripts and text areas; it's not clear why omittiing the LF is ever needed. Tested by running all the layout tests; no regressions.

fixed <rdar://problem/3552736> word wrapped text fields that blur/focus when you type move the insertion point strangely (vtext.com)

khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Call text() instead of calling widget->text() directly. This prevents this function from running in cases where the text didn't really change for text areas in wrap mode.

2:28 PM Changeset in webkit [7404] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

got rid of ERROR message when running layout tests by implementing text-transform in computed style

khtml/css/css_computedstyle.cpp: (DOM::numberAsString): Added. Helper that returns "1" rather then "1.0" for integer values. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Fixed use of tabs instead of spaces. Fixed switch statements so they don't use default so we get errors if we leave a case out. Changed callers to use numberAsString instead of QString::number. Added implementation of CSS_PROP_TEXT_TRANSFORM. Added code to prevent falling through to next property when no item in a switch statement matches.

1:35 PM Changeset in webkit [7403] by darin

31 edits
7 adds in trunk

WebCore:

Reviewed by Chris.

did work to prepare for uploading files incrementally when submitting forms

khtml/misc/formdata.h: Added. Class for holding form data inside WebCore.
khtml/misc/formdata.cpp: Added.

khtml/html/html_formimpl.h: Added the FormDataList type, changed the formData function parameters and made it private, renamed the encoding method to appendFormData and changed the parameters around.
khtml/html/html_formimpl.cpp: (DOM::FormDataList): Added. Class that replaces the old use of QValueList<QCString> for form data. Later we'll change it to accomodate filenames too. (DOM::HTMLFormElementImpl::formData): Changed code to use FormDataList intsead of the old encodingList. Also changed to return the "OK" result as the function result and put the form data into something passed as an "out" parameter; the old way was the other way around. (DOM::HTMLFormElementImpl::submit): Change to use FormData rather than a QByteArray when getting the form data to submit. (DOM::HTMLButtonElementImpl::appendFormData): Rename from encoding, and use the new appendData function instead of the old way of doing += to put data on the list. (DOM::HTMLInputElementImpl::appendFormData): Ditto. (DOM::HTMLSelectElementImpl::appendFormData): Ditto. (DOM::HTMLKeygenElementImpl::appendFormData): Ditto. (DOM::HTMLTextAreaElementImpl::appendFormData): Ditto. (DOM::FormDataList::FormDataList): Added. (DOM::FormDataList::appendString): Added. (DOM::FormDataList::begin): Added. (DOM::FormDataList::end): Added.

khtml/khtml_part.h: Changed the type of the submitForm parameter to FormData instead of QByteArray.
khtml/khtmlpart_p.h: Changed the type of the submitFormData data member to FormData instead of QByteArray.
khtml/khtml_part.cpp: (KHTMLPart::submitForm): Called the new flattenToString function in all the code that handles mailto forms. Called the new flatten function in the non-Apple code path.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Pass NSArray for form data instead of NSData.

kwq/KWQKJob.h: Use FormData instead of QByteArray. A couple other small cleanups.
kwq/KWQKJobClasses.h: Ditto.
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Ditto. (KIO::TransferJob::TransferJob): Ditto. (KIO::TransferJob::postData): Ditto.
kwq/KWQKPartsBrowserExtension.h: Ditto.
kwq/KWQLoader.mm: (KWQServeRequest): Ditto. (KWQServeSynchronousRequest): Ditto.

kwq/KWQFormData.h: Added. A function to convert KHTML form data into an NSArray for communication with the WebKit side.
kwq/KWQFormData.mm: Added.

kwq/WebCoreBridge.h: Pass NSArray instead of NSData for form data.

kwq/KWQArrayImpl.h: Added a detach member function. The old version would do unnecessary work when detach was called on an array that had exactly one reference.
kwq/KWQArrayImpl.mm: (KWQArrayImpl::detach): Added.
kwq/KWQMemArray.h: (QMemArray::detach): Call through to KWQArrayImpl.

kwq/KWQValueList.h: (QValueList::first): Added overload for non-const. (QValueList::last): Ditto.

ForwardingHeaders/misc/formdata.h: Added.
WebCore.pbproj/project.pbxproj: Added formdata.h, formdata.cpp, KWQFormData.h, and KWQFormData.cpp.

WebCore-tests.exp: Updated for changes to QValueList, and re-sorted.
WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Chris.

did work to prepare for uploading files incrementally when submitting forms

History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): Use NSArray instead of NSData for form data. (-[WebHistoryItem formData]): Ditto.
History.subproj/WebHistoryItemPrivate.h: Ditto.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto. (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
WebCoreSupport.subproj/WebSubresourceClient.h: Ditto.
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Ditto.
WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Ditto. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
WebView.subproj/WebFramePrivate.h: Ditto.

WebView.subproj/WebFormDataStream.h: Added.
WebView.subproj/WebFormDataStream.m: (-[WebFormDataStream initWithFormDataArray:]): Placeholder; not done yet. (-[WebFormDataStream formDataArray]): Ditto.
WebKit.pbproj/project.pbxproj: Added WebFormDataStream files.

11:00 AM Changeset in webkit [7402] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

improved multiple submit logic in preparation for making command-click on a form button load a form in another frame

kwq/KWQKHTMLPart.h: Added const to a bunch of member functions for cleanup. Added prepareForUserAction member function.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Simplified logic and removed special case for "http" and "https". (KWQKHTMLPart::renderer): Added const. (KWQKHTMLPart::keyEvent): Added call to prepareForUserAction. (KWQKHTMLPart::lastEventIsMouseUp): Added const. (KWQKHTMLPart::eventMayStartDrag): Added const. (KWQKHTMLPart::mouseDown): Added call to prepareForUserAction. (KWQKHTMLPart::overrideMediaType): Added const. (KWQKHTMLPart::canGoBackOrForward): Added const. (KWQKHTMLPart::prepareForUserAction): Added. Clears _submittedFormURL.
kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): Added call to prepareForUserAction.

10:43 AM Changeset in webkit [7401] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3762231> REGRESSION (Mail): tab key inserts a single space

khtml/editing/htmlediting_impl.cpp: (khtml::isTab): New helper. Checks a DOMString to see if it is one character and that character is a tab. (khtml::InputTextCommandImpl::execute): Trap tabs before handling insertion of other kinds of whitespace. Treat a tab like four spaces. Rearrange the code to update the ending position after the text insertion to cover the new tab case where the amount of advance is not the same as the number of character in the passed-in DOMString (i.e. tabs expand to four characters).

10:39 AM Changeset in webkit [7400] by sullivan

4 edits in trunk/WebKit

Reviewed by Ken.

WebKit part of fix for <rdar://problem/3607720> myFrame.print() prints the window but should only print the frame

WebView.subproj/WebUIDelegatePrivate.h: declare new delegate method that includes which frame to print

WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:printFrameView:]): implement default (no-op) version of new delegate method

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): call new delegate method if available, otherwise call old delegate method, for backward compatibility.

8:38 AM Changeset in webkit [7399] by kocienda

2 edits in trunk/WebKit

Reviewed by John.
Checked in by Ken

Ken comments: It looks like Maciej forgot to land this when he checked in the
WebCore portion of this change.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]):

8:13 AM Changeset in webkit [7398] by kocienda

4 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3779706> plain text on pasteboard loses indentation when pasted into Blot

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentFragmentWithText): New function that takes over the code from KWQKHTMLPart and improves it to handle converting tabs and spaces for suitable display in HTML.
kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Move smarts from here to KWQKHTMLPart.

Aug 29, 2004:

2:47 PM Changeset in webkit [7397] by mjs

6 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

khtml/khtml_part.cpp: (KHTMLPart::scheduleHistoryNavigation):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward):
kwq/KWQKPartsBrowserInterface.h:
kwq/WebCoreBridge.h:

Aug 27, 2004:

5:31 PM Changeset in webkit [7396] by mjs

6 edits
7 adds in trunk

Reviewed by Chris.

fixed <rdar://problem/3778043> REGRESSION: innerHTML is broken, breaks automated iBench testing
also fixed outerHTML, which would spill over past the node for whch it was supposed to get HTML

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::outerHTML):
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::toHTML): (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
khtml/xml/dom_nodeimpl.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):

added new layout tests to cover the problems I fixed

layout-tests/fast/innerHTML/001-expected.txt: Added.
layout-tests/fast/innerHTML/001.html: Added.
layout-tests/fast/innerHTML/002-expected.txt: Added.
layout-tests/fast/innerHTML/002.html: Added.
layout-tests/fast/innerHTML/003-expected.txt: Added.
layout-tests/fast/innerHTML/003.html: Added.

5:07 PM Changeset in webkit [7395] by hyatt

1 edit in trunk/WebCore/khtml/css/css_computedstyle.cpp

* empty log message *

5:06 PM Changeset in webkit [7394] by hyatt

3 edits in trunk/WebCore

Fix for 3739239, getComputedStyle of top not being implemented broke a site that checked for it.

Reviewed by kocienda

khtml/css/css_computedstyle.cpp: (DOM::valueForLength): (DOM::CSSComputedStyleDeclarationImpl::getPositionOffsetValue): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
khtml/css/css_computedstyle.h:

3:39 PM Changeset in webkit [7393] by sullivan

2 edits in trunk/WebCore

Reviewed by Ken.

Tweaked option-tab handling to match good suggestion from Tim Omernick of OmniWeb

kwq/KWQTextArea.mm: removed override of textDidChange: (-[KWQTextAreaTextView keyDown:]): moved option-tab handling that was in textDidChange to here. Rearranged existing code a little for clarity.

3:03 PM Changeset in webkit [7392] by adele

2 adds in trunk/LayoutTests/fast/frames

Adding layout test for contentWindow for iframe

2:52 PM Changeset in webkit [7391] by adele

6 edits in trunk/WebCore

Reviewed by Darin.

Fix for:
<rdar://problem/3689949> Provide contentWindow access on an iframe

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): added cases for contentWindow for frames and iframes
khtml/ecma/kjs_html.h: added contentWindow to the list of properties for frames and iframes
khtml/ecma/kjs_html.lut.h: regenerated file
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentPart): factored out old contentDocument code to return KHTMLPart for frame (HTMLFrameElementImpl::contentDocument): now just gets the contentDocument from contentPart
khtml/html/html_baseimpl.h: added declaration for contentPart

12:07 PM Changeset in webkit [7390] by kocienda

2 edits in trunk/WebKit

Reviewed by Chris

Fix for this bug:

<rdar://problem/3756997> WebKit aggressive in making pasted text into a URL, even when it's not much like a URL

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Don't try so hard to coerce data on the pasteboard into a URL, and do not make an anchor with an href for any URLs that are explicitly present on the pasteboard. Also, move URL pasteboard type check beneath the RTF checks.

11:59 AM Changeset in webkit [7389] by vicki

3 edits in trunk

back to 2.0, v162u for tip of tree

11:49 AM Changeset in webkit [7388]

3 copies in tags/Safari-161

This commit was manufactured by cvs2svn to create tag 'Safari-161'.

11:49 AM Changeset in webkit [7387] by vicki

6 edits in trunk

Safari-161 stamp

10:26 AM Changeset in webkit [7386] by kocienda

2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3778059> Odd behaviour when editing between blockquote elements

khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::deleteUnrenderedText): This function should not move the selection out of the current block, ever. This is exactly what the bug reported. What was I thinking? Now, the code looks at the passed-in position and then the equivalent upstream and downstream positions to see if the selection can be placed there after the delete, and settles on the block containing the passed-in position as a fallback.
layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
layout-tests/editing/inserting/insert-3778059-fix.html: Added.

Aug 26, 2004:

6:40 PM Changeset in webkit [7385] by rjw

4 edits in trunk/WebCore

Boiler plate for canvas gradients and patterns.

Reviewed by John.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::tryPut): (Context2D::~Context2D): (KJS::GradientFunction::tryCall): (Gradient::Gradient): (Gradient::tryGet): (Gradient::getValueProperty): (Gradient::tryPut): (Gradient::putValue): (Gradient::~Gradient): (ImagePattern::ImagePattern): (ImagePattern::tryGet): (ImagePattern::getValueProperty): (ImagePattern::tryPut): (ImagePattern::putValue): (ImagePattern::~ImagePattern):
khtml/ecma/kjs_html.h: (KJS::Gradient::toBoolean): (KJS::Gradient::classInfo): (KJS::Gradient::): (KJS::ImagePattern::toBoolean): (KJS::ImagePattern::classInfo): (KJS::ImagePattern::):
khtml/ecma/kjs_html.lut.h: (KJS::):

6:02 PM Changeset in webkit [7384] by cblu

2 edits in trunk/WebKit

Fixed build failure on Panther.

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ifdef'd out call to AppKit SPI (-[WebHTMLView _attributeStringFromDOMRange:]): ditto

5:38 PM Changeset in webkit [7383] by cblu

2 edits in trunk/WebKit

Tweak to last check-in.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):

5:10 PM Changeset in webkit [7382] by cblu

4 edits in trunk/WebKit

Fixed:
<rdar://problem/3546412> support for pasting and drag and dropping of RTF and RTFD to editable WebViews
<rdar://problem/3745345> use AppKit for converting from DOM to RTF

Reviewed by rjw.

DOM.subproj/WebDOMOperations.m: (-[DOMDocument _documentRange]): new
DOM.subproj/WebDOMOperationsPrivate.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call AppKit SPI to get a document fragment from an attributed string (-[WebHTMLView string]): added a FIXME (-[WebHTMLView _attributeStringFromDOMRange:]): new, calls AppKit SPI that creates an attributed string from a DOM Range (-[WebHTMLView attributedString]): call _attributeStringFromDOMRange:, fallback to old code if it returns nil (-[WebHTMLView selectedAttributedString]): ditto

4:54 PM Changeset in webkit [7381] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3777899> REGRESSION (Mail): only first of several misspelled words separated by
carriage returns is marked

khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Give the spellchecker a slightly larger selection to work with while typing. This should preclude bugs of this type.

3:43 PM Changeset in webkit [7380] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3777804> Deleting all content in a document can result in giant tall-as-window insertion point

khtml/rendering/render_box.cpp: (RenderBox::caretPos): Always use the font height for calculating the caret height in non-replaced elements (like blocks), rather than the height of the box.

3:20 PM Changeset in webkit [7379] by kocienda

1 edit
1 add in trunk

Reviewed by me

Silly me. Forgot to add this file before.

layout-tests/editing/inserting/insert-3775316-fix-expected.txt: Added.

3:19 PM Changeset in webkit [7378] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3774178> Plugin hooks for selected state aren't being called

Reviewed by darin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]): don't forget colons in method names

2:59 PM Changeset in webkit [7377] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3768439> can't click in WebView in Carbon WebKit apps (GetEventPlatformEventRecord returns false)

Reviewed by rjw.

Carbon.subproj/HIWebView.m: (Click): use WebGetEventPlatformEventRecord not GetEventPlatformEventRecord (MouseUp): ditto (MouseMoved): ditto (MouseDragged): ditto (MouseWheelMoved): ditto (WindowHandler): ditto (HIWebViewEventHandler): ditto (UpdateObserver): ditto (WebGetEventPlatformEventRecord): Call GetEventPlatformEventRecord, if that fails fallback to the current event. This is code Eric Schlegel to me to use.

2:36 PM Changeset in webkit [7376] by hyatt

2 edits in trunk/WebCore

Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups.

Reviewed by darin

khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

2:34 PM Changeset in webkit [7375] by kocienda

2 edits
1 add in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3775316> document sprouts an extra newline character at the end

khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): There was in insufficient check in the code which adds extra BR elements at the ends of blocks, which we do to work around the fact that BR elements, when they are the last element in a block, do not render. Now the code sees whether there already is one of these extra BR's in the document and won't add and "extra" extra.
layout-tests/editing/inserting/insert-3775316-fix.html: Added.

10:37 AM Changeset in webkit [7374] by hyatt

4 edits in trunk/WebCore

Fix for 3710721 and 3504114, crashes because of bad ownership model for list markers.

Reviewed by mjs

khtml/rendering/render_container.cpp: (RenderContainer::detach):
khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation):
khtml/rendering/render_list.h:

9:46 AM Changeset in webkit [7373] by kocienda

4 edits in trunk/WebCore

Reviewed by John

khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Remove the StayInBlock modifier from the call to upstream when passing the start position to removeStyle(). This makes the start position sufficiently upstream so that all relevant style tags are removed. (khtml::ApplyStyleCommandImpl::removeStyle): Pass the start position to nodeFullySelected. (khtml::ApplyStyleCommandImpl::nodeFullySelected): Change interface so start position for calculation is passed in, rather than recalculating it every time.
khtml/editing/htmlediting_impl.h: nodeFullySelected interface change.
khtml/xml/dom_position.h: Add a comment about the working of upstream() and downstream().

9:17 AM Changeset in webkit [7372] by kocienda

2 edits in trunk

Reviewed by me

Fix garbled contenteditable attribute. I must have checked
this in with a typo.

layout-tests/editing/deleting/delete-3775172-fix.html

Aug 25, 2004:

5:49 PM Changeset in webkit [7371] by kdecker

2 edits in trunk/WebCore

Reviewed by John and Maciej.

Fixes SAP bug <rdar://problem/3751295> Personalize link at the top gives an error in the pop-up window.

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Passes a referrer to KHTMLPart::begin()

4:40 PM Changeset in webkit [7370] by rjw

4 edits in trunk/WebCore

Updated to <canvas> API to match the spec. (Still need
to implement gradients and patterns.)

Reviewed by Ken.

khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::getValueProperty): (Context2D::drawingContext): (Context2D::colorRefFromValue): (Context2D::colorFromValue): (Context2D::setShadow): (Context2D::putValue): (Context2D::save): (Context2D::restore): (Context2D::Context2D):
khtml/ecma/kjs_html.h: (KJS::Context2D::):
khtml/ecma/kjs_html.lut.h: (KJS::):

2:54 PM Changeset in webkit [7369] by kocienda

2 edits in trunk

Reviewed by me

layout-tests/editing/deleting/delete-3775172-fix.html: Wrong version of test checked in a moment ago.

2:54 PM Changeset in webkit [7368] by kocienda

1 edit
2 adds in trunk

Reviewed by me

Added test case for <rdar://problem/3775172> Blot crashes after typing one character then deleting it

layout-tests/editing/deleting/delete-3775172-fix-expected.txt: Added.
layout-tests/editing/deleting/delete-3775172-fix.html: Added.

2:49 PM Changeset in webkit [7367] by kocienda

2 edits in trunk

Reviewed by me

layout-tests/editing/style/style-3690704-fix-expected.txt: Fewer styling spans added on this test as a result of the previously-checked-in fix.

2:34 PM Changeset in webkit [7366] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3775214> BR elements cause unnecessary spans to be added when applying style

khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): BR elements can be grouped more liberally with other nodes now in the iteration when attempting to find nodes that can be styled together with one span.
layout-tests/editing/style/style-3690704-fix-expected.txt: Updated with new results after bug fix.

2:33 PM Changeset in webkit [7365] by kocienda

3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3775172> Blot crashes after typing one character then deleting it

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Bail early if the element being queried does not have a renderer or that renderer does not have a style. Prevents a crash in the cases that it does not.
khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): Add one more case to deleting when the start and end nodes are different. If the downstream end node is the last node in the block, then it may need to be deleted completely. Before this patch, the code erroneously assumed that any deletion in this node had to be trimming of a text node. This was asserted, and the description in 3775172 shows a simple case where this assertion does not hold. The additional case and associated checks now make it all better.
layout-tests/editing/deleting/delete-3775172-fix.html: Added.

2:19 PM Changeset in webkit [7364] by hyatt

3 edits in trunk/WebCore

Fix for 3365086, large tables crash Safari. Make sure to use ints rather than shorts for row and column
counts. Also fix a pathological array resize scenario for tables as rows are added.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTableSection::RenderTableSection): (RenderTableSection::ensureRows): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableSection::recalcCells): (RenderTableSection::clearGrid):
khtml/rendering/render_table.h: (khtml::RenderTableSection::numRows):

1:01 PM Changeset in webkit [7363] by hyatt

3 edits in trunk/WebCore

To save memory in the common case, move the margin*Collapse variables into the CSS3 struct instead of
bloating the surround struct.

khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData): (StyleSurroundData::operator==): (marginBottomCollapse): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::setMarginTopCollapse): (khtml::RenderStyle::setMarginBottomCollapse):

12:04 PM Changeset in webkit [7362] by hyatt

12 edits in trunk/WebCore

Fix the "extra space in TypePad blogs" Emerson problem by adding the ability to collapse away margins.
Also added support for explicitly preventing margin collapsing.

Reviewed by mjs

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_block.cpp: (khtml::RenderBlock::isSelfCollapsingBlock): (khtml::RenderBlock::layoutBlockChildren):
khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData): (StyleSurroundData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::setMarginTopCollapse): (khtml::RenderStyle::setMarginBottomCollapse): (khtml::RenderStyle::initialMarginTopCollapse): (khtml::RenderStyle::initialMarginBottomCollapse):

10:52 AM Changeset in webkit [7361]

12 copies
3 deletes in tags/WebKit-125~2~2

This commit was manufactured by cvs2svn to create tag
'WebKit-125~2~2'.

10:52 AM Changeset in webkit [7360] by darin

1 edit in branches/SecurityUpdate-10~3~4-branch/WebKit/WebKit.pbproj/project.pbxproj

Bump version.

10:51 AM Changeset in webkit [7359] by darin

2 edits in branches/SecurityUpdate-10~3~4-branch/WebKit

fixed build, had merged wrong version of bug fix

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use _frame instead of webFrame method.

10:05 AM Changeset in webkit [7358]

9 copies
2 deletes in tags/WebKit-85~8~3

This commit was manufactured by cvs2svn to create tag
'WebKit-85~8~3'.

10:05 AM Changeset in webkit [7357] by vicki

1 edit in branches/WebKit-85~7-branch/WebKit/ChangeLog

More comments in the ChangeLog about this wacky versioning

9:53 AM Changeset in webkit [7356] by vicki

3 edits in branches/WebKit-85~7-branch/WebKit

Change the CFBV to 85.7 and the CFBSVS to 1.0.1 based on Tim Shaw's
recommendation. Even though this seems backwards, this is the only way
to ensure that the Security Update is properly installed. It should
install on 10.2.8 configs with all the latest Security Updates, but not
overwrite the copy of WebKit included with Safari 1.0.3 (CFBV 85.8.2, CFBSVS 1.0.2)

English.lproj/InfoPlist.strings:
WebKit.pbproj/project.pbxproj:

Aug 24, 2004:

5:57 PM Changeset in webkit [7355]

52 copies
2 deletes in tags/WebCore-125~6~9

This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~9'.

5:57 PM Changeset in webkit [7354] by darin

2 edits in branches/SecurityUpdate-10~3~4-branch/WebCore

Added release marker and bumped version.

5:56 PM Changeset in webkit [7353] by darin

3 edits in branches/SecurityUpdate-10~3~4-branch/WebCore

Rolled change in for 10.3.4 version of Security Update.

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

5:48 PM Changeset in webkit [7352]

12 copies
3 deletes in tags/WebKit-125~2~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~2~1'.

5:48 PM Changeset in webkit [7351] by darin

2 edits in branches/SecurityUpdate-10~3~4-branch/WebKit

Bump version number, add ChangeLog version marker.

5:45 PM Changeset in webkit [7350] by darin

2 edits in branches/SecurityUpdate-10~3~4-branch/WebKit

Rolled in security fix for 10.3.4 version of Security Update.

2004-07-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Chris.

<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame

Plugins.subproj/npruntime.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).

2004-07-09 Chris Blumenberg <cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge

2004-07-06 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto

5:33 PM Changeset in webkit [7349] by vicki

3 edits in trunk

set the TOT version number to '161u', since we burned 160 on ParisExpo-2004-branch

5:31 PM Changeset in webkit [7348]

15 copies in tags/Safari-160

This commit was manufactured by cvs2svn to create tag 'Safari-160'.

5:31 PM Changeset in webkit [7347] by vicki

6 edits in branches/ParisExpo-2004-branch

Safari-160 stamp (for the Expo build).

5:24 PM Changeset in webkit [7346] by vicki

2 edits in branches/ParisExpo-2004-branch/WebCore

merge this fix from HEAD for the Expo build

2004-08-20 Ken Kocienda <kocienda@apple.com>

Reviewed by Trey

Fix for this bug:

<rdar://problem/3768378> crash typing newline in Blot

khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Adding an assert in a recent change showed up that inserting newlines that was not being handled correctly for the case described in the bug. I added a new case to handle inserting BR's when at the caret max offset for a node, and this new code runs instead of the fall-through case that should not have been running and triggered the assert.

5:09 PM Changeset in webkit [7345] by vicki

6 edits in branches/ParisExpo-2004-branch/WebCore

merge this fix from HEAD for the Expo build

2004-08-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3770306> XMLHttpRequest does not honor character set encoding

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotData): Get encoding from the transfer job.
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added retrievedCharset flag. (KIO::TransferJob::retrieveCharset): New method, gets the charset from the response. (KIO::TransferJob::queryMetaData): Handle charset. (KIO::TransferJob::emitReceivedResponse): Clear retreivedCharset flag.
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQResponseTextEncodingName): New function, gets the encoding from the response.

4:37 PM Changeset in webkit [7344] by cblu

2 edits in trunk/WebKit

Fixed with help from Trey:
<rdar://problem/3764856> REGRESSION !25-154): Safari accepts mouse clicks (follows links) when not key

Reviewed by rjw.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionEvent:]): brought back from CVS (-[WebHTMLView acceptsFirstMouse:]): only call eventMayStartDrag if _isSelectionEvent returns YES since we only want to allow selection dragging on the first mouse down (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto

4:23 PM Changeset in webkit [7343] by kocienda

8 edits in trunk

WebCore:

Reviewed by Hyatt

Improved the ability of the bridge to report selection state.

khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::doApply): Bail when there is no selection.
kwq/WebCoreBridge.h: Added an enum to report selection state. These constants mirror those used in DOM::Selection.
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionState]): Replacement for haveSelection. Returns a value from an enum telling whether the selection is in the None, Caret, or Range state, rather than just true/false for the Range state as it did before.

WebKit:

Reviewed by Hyatt

Improved the checks used to see if certain operations can be done based
on the state of the selection and whether the selection is editable. I
added some helpers and improved some others to assist in making these
determinations.

This helps to fix this bug:
<rdar://problem/3764987> Crash after adding newline to quoted text

Since some editing methods expect the the selection to be in a certain state
in order to work, these checks help obviate crashes like 3764987.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): _haveSelection name changed to _hasSelection. (-[WebHTMLView _canCopy]): Checks to see if state is appropriate to perform this operation. (-[WebHTMLView _canCut]): Ditto. Function added. (-[WebHTMLView _canDelete]): Ditto. Function refined. (-[WebHTMLView _canPaste]): Ditto. Function refined. (-[WebHTMLView _canType]): Ditto. Function added. (-[WebHTMLView _hasSelection]): Name changed from _haveSelection. (-[WebHTMLView _hasSelectionOrInsertionPoint]): Added. (-[WebHTMLView _isEditable]): Added. (-[WebHTMLView takeFindStringFromSelection:]): _haveSelection name changed to _hasSelection. (-[WebHTMLView validateUserInterfaceItem:]): Ditto (-[WebHTMLView validRequestorForSendType:returnType:]): Ditto (-[WebHTMLView keyDown:]): (-[WebHTMLView copy:]): Uses new _canCopy check. (-[WebHTMLView cut:]): Uses new _canCut check. (-[WebHTMLView delete:]): Now uses _canDelete check. (-[WebHTMLView paste:]): Now uses _canPaste check. (-[WebHTMLView _updateFontPanel]): _haveSelection name changed to _hasSelection.
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebView.m: (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): Use selectionState check to determine whether or not operation can be done.

2:17 PM Changeset in webkit [7342] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3770469> Some PDFs open with line of previous page above PDF view

Set height resize flags on WebPDFView.

Reviewed by Chris.

WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]):

1:39 PM Changeset in webkit [7341] by hyatt

2 edits in trunk/WebCore

Make sure the ifdef XSLT is present for Panther.

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock):

1:38 PM Changeset in webkit [7340] by hyatt

4 edits in trunk/WebCore

Polish the XML error message so that it indicates when a document is the result of an XSL transformation
when reporting line/col #s.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform):
khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

1:23 PM Changeset in webkit [7339] by hyatt

5 edits in trunk/WebCore

Add support for Atom and RSS MIME types to the set of XML types.

Reviewed by rjw

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
khtml/khtml_part.cpp: (KHTMLPart::begin):
khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXBLDocument::CachedXBLDocument):
khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):

1:22 PM Changeset in webkit [7338] by hyatt

3 edits in trunk/WebKit

Add Atom and RSS MIME types to set of supported XML types.

Reviewed by rjw

WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):

11:37 AM Changeset in webkit [7337] by hyatt

2 edits in trunk/LayoutTests/fast/overflow

Change the file so that it isn't even close to RSS any more, since our sniffing code is broken.

11:02 AM Changeset in webkit [7336] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3746447> hang loading geocities.com/cinemaorchestra

Reviewed by john.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): do nothing if the src URL is the same as the part's URL

10:00 AM Changeset in webkit [7335] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3773564> REGRESSION (125-159): Code to remove HTML styles before applying new HTML styles is broken

khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Unrelated change to constrain downstream position of selection start to block boundaries. This is a new feature of the downstream function and I missed this usage when adding the feature. (khtml::ApplyStyleCommandImpl::removeCSSStyle): There once was code to remove style attributes from spans which became emptied as a result of removing CSS properties, but I do not see such code in the tree any more. A quick review of the ChangeLog did not reveal anything. I do not remember making such a change myself...

In any case, I have restored logic to prune out styling spans we insert if the process of
removing styles caused a span-plus-styles node to become emptied of markup which changes the style
of its contents. This fixes the bug.

8:23 AM Changeset in webkit [7334] by kocienda

5 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3765535> paste of text with newlines into text with newlines results in broken doc, crash

This is a "belt and suspenders" fix. The issue is with the paste code path which was creating
zero-length DOM text nodes when a selection being pasted ended with a newline. The normal
code path for parsing HTML does not allow this, but the code to convert newlines to BR's
during paste was creating such nodes. This will no longer happen.

In the case where someone inserts such zero-length nodes using the DOM API, the render tree
will no longer create render objects for these nodes, and it was these empty render text
nodes that was confusing the code doing editing navigation.

khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::rendererIsNeeded): Do not create renderers for zero-length DOM text nodes.
khtml/xml/dom_textimpl.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Do not insert zero-length DOM text nodes as part of converting line-end sequences to BR's.

Aug 23, 2004:

9:13 PM Changeset in webkit [7333] by mjs

3 edits in trunk/WebCore

Reviewed by Richard.

reduce cost of innerHTML from O(N^{2) to O(N*D) where N is the
number of nodes and D is the maximum DOM tree depth.}

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toString): New static helper method for recursive_toHTML - this is recursive for children but iterative for siblings. (NodeImpl::recursive_toHTML): Call the helper with this as the first argument.
khtml/xml/dom_nodeimpl.h:

8:22 PM Changeset in webkit [7332] by hyatt

7 edits in trunk/WebCore

Fix for 3558334.

Init the encodedURL explicitly for CSSStyleSelectors. Construction time was too early to be passing in the
document m_url, since it doesn't get set during construction.

Fix for 3769643, crash on vancouverblast.org.

Reviewed by darin

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::init): (khtml::CSSStyleSelector::setEncodedURL):
khtml/css/cssstyleselector.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setURL): (DocumentImpl::recalcStyleSelector):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::URL):

7:50 PM Changeset in webkit [7331] by mjs

2 edits in trunk/WebKit

Reviewed by Kevin.

remove annoying ERROR spew and replace with comment

WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]):

6:19 PM Changeset in webkit [7330] by mjs

2 edits in trunk/WebKit

Reviewed by Richard.

a bit of code cleanup

WebView.subproj/WebDataSource.m: (-[WebDataSource _stringWithData:]): Call textEncodingName instead of copying it's code. (-[WebDataSource textEncodingName]): Tweak formatting.

5:12 PM Changeset in webkit [7329] by cblu

2 edits in trunk/WebKit

Fixed build.

WebKit.pbproj/project.pbxproj: make sure we're doing -f on a file, not a directory

4:36 PM Changeset in webkit [7328] by cblu

6 edits
2 adds in trunk/WebKit

Fixed: <rdar://problem/3674867> use new Security framework SPI's to reenable cert acquisition

Reviewed by john.

WebCoreSupport.subproj/WebKeyGeneration.cpp:
WebCoreSupport.subproj/WebKeyGeneration.h:
WebCoreSupport.subproj/WebKeyGenerator.h:
WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): re-enabled cert code, call Panther version on Panther, Tiger version on Tiger (-[WebKeyGenerator addCertificatesToKeychainFromData:]): ditto
WebCoreSupport.subproj/WebNewKeyGeneration.c: Added. (gnrAddContextAttribute): (gnrGetSubjPubKey): (gnrNullAlgParams): (gnrSign): (gnrFreeCssmData): (nssArraySize): (signedPublicKeyAndChallengeString): (addCertificateToKeychainFromData): (addCertificatesToKeychainFromData):
WebCoreSupport.subproj/WebNewKeyGeneration.h: Added.
WebKit.pbproj/project.pbxproj:

4:02 PM Changeset in webkit [7327] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Get rid of stray conflict markers.

2:17 PM Changeset in webkit [7326] by kdecker

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed rdar://problem/3681094> Crash in KJS::WindowFunc::tryCall with application/xhtml+xml Content-Type
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): since this is an xml document, we get the domain from the xmlDocImpl(), not docImpl().

12:05 PM Changeset in webkit [7325] by vicki

3 edits in trunk

bump all version numbers to 160u, since I just submitted WebBrowser-159

11:06 AM Changeset in webkit [7324] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3771426> assertion failed due to reentering dispatchImageLoadEventsNow

khtml/xml/dom_docimpl.cpp: (DocumentImpl::dispatchImageLoadEventsNow): Avoid re-entering this function, since it uses a data member for the copy of the list of events to be dispatched.

10:52 AM Changeset in webkit [7323] by mjs

6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3770306> XMLHttpRequest does not honor character set encoding

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotData): Get encoding from the transfer job.
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added retrievedCharset flag. (KIO::TransferJob::retrieveCharset): New method, gets the charset from the response. (KIO::TransferJob::queryMetaData): Handle charset. (KIO::TransferJob::emitReceivedResponse): Clear retreivedCharset flag.
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQResponseTextEncodingName): New function, gets the encoding from the response.

10:44 AM Changeset in webkit [7322] by hyatt

2 edits in trunk/WebCore

Apply leo's fix to marquees.

Reviewed by hyatt

khtml/rendering/render_layer.cpp: (Marquee::start):

9:12 AM Changeset in webkit [7321] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

added an ascii() member function to DOMString and DOMStringImpl to help debugging

khtml/dom/dom_string.h: Add ascii member function for debugging.
khtml/dom/dom_string.cpp: (DOM::DOMString::ascii): Added. Calls through to DOMStringImpl::ascii.
khtml/xml/dom_stringimpl.h: Add ascii member function for debugging.
khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::ascii): Added. Makes a new buffer and puts a simple ASCII version in it. Maybe make it better about characters outside the 0x20-0x7E range some day, but for now this is way better than what we had before.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed